[GitHub] [maven-site-plugin] dependabot[bot] opened a new pull request, #116: Bump jettyVersion from 9.4.49.v20220914 to 10.0.13
dependabot[bot] opened a new pull request, #116: URL: https://github.com/apache/maven-site-plugin/pull/116 Bumps `jettyVersion` from 9.4.49.v20220914 to 10.0.13. Updates `jetty-server` from 9.4.49.v20220914 to 10.0.13 Release notes Sourced from https://github.com/eclipse/jetty.project/releases;>jetty-server's releases. 10.0.13 Special Thanks to the following Eclipse Jetty community members https://github.com/janvojt;>@janvojt (Jan Vojt) https://github.com/joschi;>@joschi (Jochen Schalanda) https://github.com/leonchen83;>@leonchen83 (Baoyi Chen) https://github.com/cowwoc;>@cowwoc (Gili Tzabari) https://github.com/Vlatombe;>@Vlatombe (Vincent Latombe) Changelog https://github-redirect.dependabot.com/eclipse/jetty.project/issues/9006;>#9006 - WebSocket Message InputStream read() returns signed byte https://github-redirect.dependabot.com/eclipse/jetty.project/issues/8913;>#8913 - Review Jetty XML syntax to allow calling JDK methods https://github-redirect.dependabot.com/eclipse/jetty.project/issues/8905;>#8905 - GzipHandler fails to set Vary header on 304 responses https://github-redirect.dependabot.com/eclipse/jetty.project/issues/8900;>#8900 - Improved documentation about virtual threads. https://github-redirect.dependabot.com/eclipse/jetty.project/issues/8897;>#8897 - Update Conditional request handling for RFC7232 https://github-redirect.dependabot.com/eclipse/jetty.project/issues/8895;>#8895 - Generate downloadable version of javadocs documentation in website deploy script https://github-redirect.dependabot.com/eclipse/jetty.project/issues/8863;>#8863 - Provide a possibility to name virtual threads https://github-redirect.dependabot.com/eclipse/jetty.project/issues/8810;>#8810 - ArrayRetainableByteBufferPool inefficiently calculates bucket indices https://github-redirect.dependabot.com/eclipse/jetty.project/issues/8786;>#8786 - KeyStoreScanner is not able to monitor a symlink file and always resolves to the target. https://github-redirect.dependabot.com/eclipse/jetty.project/issues/8779;>#8779 - CompactPathRule drops query section on use https://github-redirect.dependabot.com/eclipse/jetty.project/issues/8770;>#8770 - Review whether to send request body in redirects https://github-redirect.dependabot.com/eclipse/jetty.project/issues/8753;>#8753 - Starting HttpClient with destinationIdleTimeout set throws NPE. (https://github.com/janvojt;>@janvojt) https://github-redirect.dependabot.com/eclipse/jetty.project/issues/8750;>#8750 - AbstractProxyServlet.onServerResponseHeaders does not support headers with empty values https://github-redirect.dependabot.com/eclipse/jetty.project/issues/8743;>#8743 - Add log.isDebugEnabled() to reduce string allocation (https://github.com/leonchen83;>@leonchen83) https://github-redirect.dependabot.com/eclipse/jetty.project/issues/8721;>#8721 - jetty:effective-web-xml doesn't generate quickstart information for web fragment jars that contain META-INF/resources https://github-redirect.dependabot.com/eclipse/jetty.project/issues/8716;>#8716 - Multiple Host header values handled poorly https://github-redirect.dependabot.com/eclipse/jetty.project/issues/8712;>#8712 - ELContextCleaner no longer needed. https://github-redirect.dependabot.com/eclipse/jetty.project/issues/8688;>#8688 - Fix traversal bug on extraction of bad jar/zip files during jetty-start https://github-redirect.dependabot.com/eclipse/jetty.project/issues/8682;>#8682 - expand jetty properties when generating dry-run command line https://github-redirect.dependabot.com/eclipse/jetty.project/issues/8678;>#8678 - Jetty client is not responding to GO_AWAY packet received from (Jetty) Server and continue to send traffic on same connection https://github-redirect.dependabot.com/eclipse/jetty.project/issues/8628;>#8628 - Pseudo restore PathMappings.getMatch(String) for backwards compat reasons https://github-redirect.dependabot.com/eclipse/jetty.project/issues/8623;>#8623 - Use AutoLock in InputStreamResponseListener https://github-redirect.dependabot.com/eclipse/jetty.project/issues/8600;>#8600 - Allow to pass instances of ClientConfig and Config to Hazelcast data store factory (https://github.com/Vlatombe;>@Vlatombe) https://github-redirect.dependabot.com/eclipse/jetty.project/issues/8591;>#8591 - Indicate units of HttpClient properties (https://github.com/cowwoc;>@cowwoc) https://github-redirect.dependabot.com/eclipse/jetty.project/issues/8558;>#8558 - Idle timeout occured sometimes on HTTP/2 client with InputStreamResponseListener https://github-redirect.dependabot.com/eclipse/jetty.project/issues/8536;>#8536 - HotSwapHandler race condition https://github-redirect.dependabot.com/eclipse/jetty.project/issues/8473;>#8473 - add getter for the WebSocketUpgradeHandler configuration
[GitHub] [maven-mvnd] mxsm commented on issue #752: Build Rocketmq error
mxsm commented on issue #752: URL: https://github.com/apache/maven-mvnd/issues/752#issuecomment-1347601982 > * It looks like you are using Windows to compile. If you use Linux to compile, what will be the Log? I will try -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven] olamy merged pull request #908: simplify build and get rid of withMaven
olamy merged PR #908: URL: https://github.com/apache/maven/pull/908 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-compiler-plugin] slawekjaranowski commented on pull request #160: [MCOMPILER-515] This plugin is not "incremental"
slawekjaranowski commented on PR #160: URL: https://github.com/apache/maven-compiler-plugin/pull/160#issuecomment-1347454415 Also -1 from me. Maybe it is not incremental compile - but detecting if module should be recompiled. Detecting on change for project configuration should be fixed instead. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MNG-7624) Plugins without non-mandatory goalPrefix are now logging incomplete info
[
https://issues.apache.org/jira/browse/MNG-7624?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17646353#comment-17646353
]
Guillaume Nodet commented on MNG-7624:
--
In such cases, defaulting to {{groupId:artifactId:version:goal}} would be best
to keep the ability to copy/paste the failing goal to the command line.
> Plugins without non-mandatory goalPrefix are now logging incomplete info
>
>
> Key: MNG-7624
> URL: https://issues.apache.org/jira/browse/MNG-7624
> Project: Maven
> Issue Type: Bug
> Components: Logging
>Affects Versions: 4.0.0-alpha-3
>Reporter: Tamas Cservenak
>Priority: Major
>
> The introduction of MNG-7618 causes that plugins without goalPrefix (is not
> required) emit incomplete information on console, as nor artifactId nor
> goalPrefix is present on console. Goal prefix is not mandatory for plugins.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Updated] (MNG-7624) Plugins without non-mandatory goalPrefix are now logging incomplete info
[ https://issues.apache.org/jira/browse/MNG-7624?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guillaume Nodet updated MNG-7624: - Fix Version/s: 4.0.0-alpha-4 > Plugins without non-mandatory goalPrefix are now logging incomplete info > > > Key: MNG-7624 > URL: https://issues.apache.org/jira/browse/MNG-7624 > Project: Maven > Issue Type: Bug > Components: Logging >Affects Versions: 4.0.0-alpha-3 >Reporter: Tamas Cservenak >Assignee: Guillaume Nodet >Priority: Major > Fix For: 4.0.0-alpha-4 > > > The introduction of MNG-7618 causes that plugins without goalPrefix (is not > required) emit incomplete information on console, as nor artifactId nor > goalPrefix is present on console. Goal prefix is not mandatory for plugins. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Assigned] (MNG-7624) Plugins without non-mandatory goalPrefix are now logging incomplete info
[ https://issues.apache.org/jira/browse/MNG-7624?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guillaume Nodet reassigned MNG-7624: Assignee: Guillaume Nodet > Plugins without non-mandatory goalPrefix are now logging incomplete info > > > Key: MNG-7624 > URL: https://issues.apache.org/jira/browse/MNG-7624 > Project: Maven > Issue Type: Bug > Components: Logging >Affects Versions: 4.0.0-alpha-3 >Reporter: Tamas Cservenak >Assignee: Guillaume Nodet >Priority: Major > > The introduction of MNG-7618 causes that plugins without goalPrefix (is not > required) emit incomplete information on console, as nor artifactId nor > goalPrefix is present on console. Goal prefix is not mandatory for plugins. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MCOMPILER-515) Plugin is NOT incremental, so let it go
[ https://issues.apache.org/jira/browse/MCOMPILER-515?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17646352#comment-17646352 ] Olivier Lamy commented on MCOMPILER-515: -1 I'm happy to not have to recompile everything all the time. If you think there is a bug when changing the configuration it will be better to fix it correctly (e.g comparing inputs between 2 runs). Frankly the video is definitely not fair let’s be honest and pragmatic when you change such configuration (java 8 to java 17) value you are changing so many other things which worth at least one clean of your workspace… > Plugin is NOT incremental, so let it go > --- > > Key: MCOMPILER-515 > URL: https://issues.apache.org/jira/browse/MCOMPILER-515 > Project: Maven Compiler Plugin > Issue Type: Bug >Reporter: Tamas Cservenak >Priority: Major > > The maven-compiler-plugin is NOT incremental, so we should just let it go. > The shared incremental stuff is broken since it's last factual code change > (2012!). > Moreover, the broken incremental stuff just makes us look bad, see the "mvn > clean install" vs "mvn verify" issue: > [https://www.youtube.com/watch?v=XeQj-IbSxJI] > Accept it, that this plugins is not incremental, so it should not make users > believe it is. Moreover, the bugs in this feature exist for too long, that > just cause harm to users and to project as whole. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [maven-compiler-plugin] olamy commented on pull request #160: [MCOMPILER-515] This plugin is not "incremental"
olamy commented on PR #160: URL: https://github.com/apache/maven-compiler-plugin/pull/160#issuecomment-1347432650 -1 I'm happy to not have to recompile everything all the time. If you think there is a bug when changing the configuration it will be better to fix it correctly (e.g comparing inputs between 2 runs). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-dependency-tree] dependabot[bot] opened a new pull request, #33: Bump slf4j-api from 1.7.36 to 2.0.6
dependabot[bot] opened a new pull request, #33: URL: https://github.com/apache/maven-dependency-tree/pull/33 Bumps [slf4j-api](https://github.com/qos-ch/slf4j) from 1.7.36 to 2.0.6. Commits https://github.com/qos-ch/slf4j/commit/5ff6f2c385c36ea4f8b85cacd69f7ca891c37818;>5ff6f2c prepare for release 2.0.6 https://github.com/qos-ch/slf4j/commit/2f4aa754451167e2fef98a07f2e1260cdb08b332;>2f4aa75 fix SLF4J-575 https://github.com/qos-ch/slf4j/commit/363f0a534ea736bb02ced129f3ae27720f95c13f;>363f0a5 remove unused parts https://github.com/qos-ch/slf4j/commit/171679baa87e13cfb8ca471242da6fd0d3acbe53;>171679b SLF4J-574: Add full OSGi headers, especially uses clauses https://github.com/qos-ch/slf4j/commit/921b5b31e179d625d349debf15210ed067a5a153;>921b5b3 fix FUNDING file https://github.com/qos-ch/slf4j/commit/e02244c39f11cdcdb07d6b291f157e3687d5b920;>e02244c fix FUNDING file https://github.com/qos-ch/slf4j/commit/441d4584bed16ec8fe54a9c4acb8d289e51005b8;>441d458 fix FUNDING file https://github.com/qos-ch/slf4j/commit/f5e741ba1af6565269499d34c725c32ef8ca467f;>f5e741b add FUNDING file https://github.com/qos-ch/slf4j/commit/2e71327c8ee745927d731e8d9f4e51d331dad138;>2e71327 remove unused log4j dependency in the version definition section of pom.xml https://github.com/qos-ch/slf4j/commit/3ff2a30e05e5825d96ddb54da243df48f1a9d897;>3ff2a30 start work on 2.0.6-SNAPSHOT Additional commits viewable in https://github.com/qos-ch/slf4j/compare/v_1.7.36...v_2.0.6;>compare view [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-compiler-plugin] cstamas commented on pull request #160: [MCOMPILER-515] This plugin is not "incremental"
cstamas commented on PR #160: URL: https://github.com/apache/maven-compiler-plugin/pull/160#issuecomment-1347397562 As expected, without the two IT it all pass OK. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-compiler-plugin] cstamas commented on pull request #160: [MCOMPILER-515] This plugin is not "incremental"
cstamas commented on PR #160: URL: https://github.com/apache/maven-compiler-plugin/pull/160#issuecomment-1347354841 As expected, the two ITs did fail on GH CI. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (MNG-7625) Restore compatibility with maven 3 - SettingsUtils#merge
Slawomir Jaranowski created MNG-7625:
Summary: Restore compatibility with maven 3 - SettingsUtils#merge
Key: MNG-7625
URL: https://issues.apache.org/jira/browse/MNG-7625
Project: Maven
Issue Type: Task
Affects Versions: 4.0.0-alpha-3
Reporter: Slawomir Jaranowski
Assignee: Slawomir Jaranowski
Maven 3 has method:
{code:java}
void SettingsUtils#merge(org.apache.maven.settings.Settings,
org.apache.maven.settings.Settings, java.lang.String)
{code}
It is used by {{maven-invoker-plugin}}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[GitHub] [maven-compiler-plugin] cstamas opened a new pull request, #160: [MCOMPILER-515] This plugin is not "incremental"
cstamas opened a new pull request, #160: URL: https://github.com/apache/maven-compiler-plugin/pull/160 Drop the "incremental" bit of this plugin, make it just dumb always redo everything. The incremental bits just introduced bugs that exist for over 10 years, and just make us look bad. So just let "incremental" part go away. This change renders 2 ITs broken: ``` [ERROR] The following builds failed: [ERROR] * MCOMPILER-500-package-info-incr/pom.xml [ERROR] * default-incremental-disable/pom.xml ``` That IMHO should be dropped as well, if this PR goes in. --- https://issues.apache.org/jira/browse/MCOMPILER-515 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (MCOMPILER-515) Plugin is NOT incremental, so let it go
Tamas Cservenak created MCOMPILER-515: - Summary: Plugin is NOT incremental, so let it go Key: MCOMPILER-515 URL: https://issues.apache.org/jira/browse/MCOMPILER-515 Project: Maven Compiler Plugin Issue Type: Bug Reporter: Tamas Cservenak The maven-compiler-plugin is NOT incremental, so we should just let it go. The shared incremental stuff is broken since it's last factual code change (2012!). Moreover, the broken incremental stuff just makes us look bad, see the "mvn clean install" vs "mvn verify" issue: [https://www.youtube.com/watch?v=XeQj-IbSxJI] Accept it, that this plugins is not incremental, so it should not make users believe it is. Moreover, the bugs in this feature exist for too long, that just cause harm to users and to project as whole. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [maven-mvnd] linghengqian commented on issue #752: Build Rocketmq error
linghengqian commented on issue #752: URL: https://github.com/apache/maven-mvnd/issues/752#issuecomment-1347192193 - It looks like you are using Windows to compile. If you use Linux to compile, what will be the Log? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-javadoc-plugin] michael-o commented on a diff in pull request #176: Assorted minor updates
michael-o commented on code in PR #176: URL: https://github.com/apache/maven-javadoc-plugin/pull/176#discussion_r1046280113 ## src/site/fml/faq.fml: ## @@ -301,11 +301,11 @@ mvn deploy:deploy-file \ - - On Windows with Sun JDK, why javadoc:javadoc goal blows up due to an IllegalArgumentException in sun.net.www.ParseUtil.decode()? + + On Windows with Oracle JDK, why javadoc:javadoc goal blows up due to an IllegalArgumentException in sun.net.www.ParseUtil.decode()? - You are on Windows XP with Sun JDK 5 or JDK 6 freshly installed, and when you run mvn javadoc:javadoc, + You are on Windows XP with Oracle JDK 5 or JDK 6 freshly installed, and when you run mvn javadoc:javadoc, Review Comment: Delete it. Time to get over it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-javadoc-plugin] elharo commented on a diff in pull request #176: Assorted minor updates
elharo commented on code in PR #176: URL: https://github.com/apache/maven-javadoc-plugin/pull/176#discussion_r1046278939 ## src/site/fml/faq.fml: ## @@ -301,11 +301,11 @@ mvn deploy:deploy-file \ - - On Windows with Sun JDK, why javadoc:javadoc goal blows up due to an IllegalArgumentException in sun.net.www.ParseUtil.decode()? + + On Windows with Oracle JDK, why javadoc:javadoc goal blows up due to an IllegalArgumentException in sun.net.www.ParseUtil.decode()? - You are on Windows XP with Sun JDK 5 or JDK 6 freshly installed, and when you run mvn javadoc:javadoc, + You are on Windows XP with Oracle JDK 5 or JDK 6 freshly installed, and when you run mvn javadoc:javadoc, Review Comment: I'm tempted to delete this one entirely since both the Windows and JDK referenced are so old. However, I don't know if this might happen in a nee system or not. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-javadoc-plugin] michael-o commented on a diff in pull request #176: Assorted minor updates
michael-o commented on code in PR #176: URL: https://github.com/apache/maven-javadoc-plugin/pull/176#discussion_r1046264876 ## src/site/fml/faq.fml: ## @@ -301,11 +301,11 @@ mvn deploy:deploy-file \ - - On Windows with Sun JDK, why javadoc:javadoc goal blows up due to an IllegalArgumentException in sun.net.www.ParseUtil.decode()? + + On Windows with Oracle JDK, why javadoc:javadoc goal blows up due to an IllegalArgumentException in sun.net.www.ParseUtil.decode()? - You are on Windows XP with Sun JDK 5 or JDK 6 freshly installed, and when you run mvn javadoc:javadoc, + You are on Windows XP with Oracle JDK 5 or JDK 6 freshly installed, and when you run mvn javadoc:javadoc, Review Comment: I think you can totally reduce this sentence since there was not Oracle JDK at 5 times, no? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-javadoc-plugin] pzygielo commented on a diff in pull request #176: Assorted minor updates
pzygielo commented on code in PR #176: URL: https://github.com/apache/maven-javadoc-plugin/pull/176#discussion_r1046262061 ## src/site/fml/faq.fml: ## @@ -404,9 +404,9 @@ mvn deploy:deploy-file \ or fix the wrong environment variable. - Refer you to - http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=6219854;>http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=6219854 - from Sun for more details. + Refer to + https://bugs.java.com/bugdatabase/view_bug.do?bug_id=6219854;>Javs Bug 6219854 Review Comment: ```suggestion https://bugs.java.com/bugdatabase/view_bug.do?bug_id=6219854;>Java Bug 6219854 ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-javadoc-plugin] elharo opened a new pull request, #176: Assorted minor updates
elharo opened a new pull request, #176: URL: https://github.com/apache/maven-javadoc-plugin/pull/176 Sun --> Oracle Oxford comma update URLs @michael-o -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-scripting-plugin] bmarwell commented on pull request #5: [MSCRIPTING-9] - basic java scripting support
bmarwell commented on PR #5: URL: https://github.com/apache/maven-scripting-plugin/pull/5#issuecomment-1346793735 We should get rid of Travis-CI. In fact, we HAVE to. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-scripting-plugin] slachiewicz commented on pull request #5: [MSCRIPTING-9] - basic java scripting support
slachiewicz commented on PR #5: URL: https://github.com/apache/maven-scripting-plugin/pull/5#issuecomment-1346623345 would be good to add documentation to jsr223-script-engines.md.vm -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (MNG-7624) Plugins without non-mandatory goalPrefix are now logging incomplete info
[ https://issues.apache.org/jira/browse/MNG-7624?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tamas Cservenak updated MNG-7624: - Description: The introduction of MNG-7618 causes that plugins without goalPrefix (is not required) emit incomplete information on console, as nor artifactId nor goalPrefix is present on console. Goal prefix is not mandatory for plugins. (was: The introduction of MNG-7618 causes that plugins without goalPrefix (is not required) emit incomplete information on console, as nor artifactId nor goalPrefix is present on console.) > Plugins without non-mandatory goalPrefix are now logging incomplete info > > > Key: MNG-7624 > URL: https://issues.apache.org/jira/browse/MNG-7624 > Project: Maven > Issue Type: Bug > Components: Logging >Affects Versions: 4.0.0-alpha-3 >Reporter: Tamas Cservenak >Priority: Major > > The introduction of MNG-7618 causes that plugins without goalPrefix (is not > required) emit incomplete information on console, as nor artifactId nor > goalPrefix is present on console. Goal prefix is not mandatory for plugins. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (MNG-7624) Plugins without non-mandatory goalPrefix are now logging incomplete info
[ https://issues.apache.org/jira/browse/MNG-7624?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tamas Cservenak updated MNG-7624: - Description: The introduction of MNG-7618 causes that plugins without goalPrefix (is not required) emit incomplete information on console, as nor artifactId nor goalPrefix is present on console. (was: The introduction of MNG-7618 causes that plugins without goalPrefix (is not required) emit incomplete information on console, as nor artifactId nor goapPrefix is present on console.) > Plugins without non-mandatory goalPrefix are now logging incomplete info > > > Key: MNG-7624 > URL: https://issues.apache.org/jira/browse/MNG-7624 > Project: Maven > Issue Type: Bug > Components: Logging >Affects Versions: 4.0.0-alpha-3 >Reporter: Tamas Cservenak >Priority: Major > > The introduction of MNG-7618 causes that plugins without goalPrefix (is not > required) emit incomplete information on console, as nor artifactId nor > goalPrefix is present on console. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (MNG-7624) Plugins without non-mandatory goalPrefix are now logging incomplete info
Tamas Cservenak created MNG-7624: Summary: Plugins without non-mandatory goalPrefix are now logging incomplete info Key: MNG-7624 URL: https://issues.apache.org/jira/browse/MNG-7624 Project: Maven Issue Type: Bug Components: Logging Affects Versions: 4.0.0-alpha-3 Reporter: Tamas Cservenak The introduction of MNG-7618 causes that plugins without goalPrefix (is not required) emit incomplete information on console, as nor artifactId nor goapPrefix is present on console. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MWRAPPER-85) Docs do not mention distributionType for MavenWrapperDownloader.jar
[ https://issues.apache.org/jira/browse/MWRAPPER-85?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17646083#comment-17646083 ] ASF GitHub Bot commented on MWRAPPER-85: bmarwell opened a new pull request, #71: URL: https://github.com/apache/maven-wrapper/pull/71 Following this checklist to help us incorporate your contribution quickly and easily: - [X] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/MWRAPPER-85) filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes. - [X] Each commit in the pull request should have a meaningful subject line and body. - [X] Format the pull request title like `[MWRAPPER-85] - Fixes bug in ApproximateQuantiles`, where you replace `MWRAPPER-85` with the appropriate JIRA issue. Best practice is to use the JIRA issue title in the pull request title and in the first line of the commit message. - [X] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [X] Run `mvn clean verify` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically. - [X] You have run the integration tests successfully (`mvn -Prun-its clean verify`). If your pull request is about ~20 lines of code you don't need to sign an [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure please ask on the developers list. To make clear that you license your contribution under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) you have to acknowledge this by using the following check-box. - [X] I hereby declare this contribution to be licenced under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) - [X] In any other case, please file an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). > Docs do not mention distributionType for MavenWrapperDownloader.jar > --- > > Key: MWRAPPER-85 > URL: https://issues.apache.org/jira/browse/MWRAPPER-85 > Project: Maven Wrapper > Issue Type: Bug >Affects Versions: 3.1.1 >Reporter: Benjamin Marwell >Assignee: Benjamin Marwell >Priority: Major > Labels: Documentation > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [maven-wrapper] bmarwell opened a new pull request, #71: [MWRAPPER-85]_mention_distributionType
bmarwell opened a new pull request, #71: URL: https://github.com/apache/maven-wrapper/pull/71 Following this checklist to help us incorporate your contribution quickly and easily: - [X] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/MWRAPPER-85) filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes. - [X] Each commit in the pull request should have a meaningful subject line and body. - [X] Format the pull request title like `[MWRAPPER-85] - Fixes bug in ApproximateQuantiles`, where you replace `MWRAPPER-85` with the appropriate JIRA issue. Best practice is to use the JIRA issue title in the pull request title and in the first line of the commit message. - [X] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [X] Run `mvn clean verify` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically. - [X] You have run the integration tests successfully (`mvn -Prun-its clean verify`). If your pull request is about ~20 lines of code you don't need to sign an [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure please ask on the developers list. To make clear that you license your contribution under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) you have to acknowledge this by using the following check-box. - [X] I hereby declare this contribution to be licenced under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) - [X] In any other case, please file an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (MNG-7228) MavenProject.getOriginalSource returns interpolated parts
[
https://issues.apache.org/jira/browse/MNG-7228?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Guillaume Nodet updated MNG-7228:
-
Fix Version/s: 4.0.0-alpha-4
(was: 4.0.0-alpha-3)
> MavenProject.getOriginalSource returns interpolated parts
> -
>
> Key: MNG-7228
> URL: https://issues.apache.org/jira/browse/MNG-7228
> Project: Maven
> Issue Type: Bug
> Components: Core
>Affects Versions: 3.0-alpha-1
>Reporter: Karl Heinz Marbaise
>Priority: Minor
> Fix For: 4.0.0, 4.0.0-alpha-4
>
>
> I have tested the maven-enforcer-plugin 3.0.0 running in a project where I
> use the following configuration:
> {code:xml}
>
> The rules for repo1.maven.org are that pom.xml
> files should not include repository definitions. If
> repository definitions are included, they must be limited
> to SNAPSHOT only repositories.
> true
> true
> true
>
>
> {code}
> The project works correct with Maven 3.X but fails with Maven 4.X (current
> state of master 92d2c2e3b43ca214989f0f517aa90f1525f0ff2e).
> After some investigation it looks like that the
> {{mavenProject.getOriginalModel()}} returns already interpolated model and
> **NOT** the original model.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Updated] (MNG-7604) Removal of pom.* interpolation makes some older plugins defunct
[
https://issues.apache.org/jira/browse/MNG-7604?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Guillaume Nodet updated MNG-7604:
-
Fix Version/s: 4.0.0-alpha-4
(was: 4.0.0-alpha-3)
> Removal of pom.* interpolation makes some older plugins defunct
> ---
>
> Key: MNG-7604
> URL: https://issues.apache.org/jira/browse/MNG-7604
> Project: Maven
> Issue Type: Bug
> Components: Inheritance and Interpolation
>Affects Versions: 4.0.0-alpha-2
>Reporter: Tamas Cservenak
>Priority: Major
> Fix For: 4.0.0, 4.0.0-alpha-4
>
>
> The MNG-7244 removed completely the {{pom.*}} prefix interpolation, but IMHO
> intent was to do it for "currently built projects". The problem is that same
> interpolator is used in model builder to build transitive dependency models,
> and with the change Maven 4 lost it's ability to resolve artifacts like
> wagon-http 1.0-beta-6 (used by things like surefire 2.22.2 and so on).
> The implication is that Maven4 CANNOT resolve wagon-http 1.0-beta-6 (and
> implicitly surefire plugin 2.22.2 is defunct it seems as it uses it). Given
> we have NO 3.x release of surefire (just M releases), I bet many of users out
> there still use 2.22.2. Also, we have no idea how many other (used as
> transitive dependencies) artifact exists out there doing same/similar thing
> that wagon POM does.
> IMHO: rollback the change from master and we need alt fix for it, as making
> Maven 4 unable to resolve transitive deps using pom.* placeholder introduces
> a huge toll.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Updated] (MNG-7571) add new Maven immutable API to reference documentation
[ https://issues.apache.org/jira/browse/MNG-7571?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guillaume Nodet updated MNG-7571: - Fix Version/s: 4.0.0-alpha-4 (was: 4.0.0-alpha-3) > add new Maven immutable API to reference documentation > -- > > Key: MNG-7571 > URL: https://issues.apache.org/jira/browse/MNG-7571 > Project: Maven > Issue Type: Task >Affects Versions: 4.0.0-alpha-2 >Reporter: Herve Boutemy >Priority: Major > Fix For: 4.0.0-alpha-4 > > > immutable API added in MNG-7553 > api directory but maven-api documentation url > https://maven.apache.org/ref/4-LATEST/maven-api/index.html -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Closed] (MNG-7584) The properties-maven-plugin fails to load project properties
[
https://issues.apache.org/jira/browse/MNG-7584?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Guillaume Nodet closed MNG-7584.
Resolution: Fixed
> The properties-maven-plugin fails to load project properties
>
>
> Key: MNG-7584
> URL: https://issues.apache.org/jira/browse/MNG-7584
> Project: Maven
> Issue Type: Task
>Affects Versions: 4.0.0-alpha-2
>Reporter: Guillaume Nodet
>Assignee: Guillaume Nodet
>Priority: Major
> Fix For: 4.0.0-alpha-3
>
>
> The {{read-project-properties}} mojo fails with the following exception:
> {code:java}
> [ERROR] Failed to execute goal
> org.codehaus.mojo:properties-maven-plugin:1.0-alpha-2:read-project-properties
> (init-camel-schema-version-property-from-file) on project camel-spring-xml:
> Execution init-camel-schema-version-property-from-file of goal
> org.codehaus.mojo:properties-maven-plugin:1.0-alpha-2:read-project-properties
> failed.: UnsupportedOperationException -> [Help
> 1]org.apache.maven.lifecycle.LifecycleExecutionException: Failed to execute
> goal
> org.codehaus.mojo:properties-maven-plugin:1.0-alpha-2:read-project-properties
> (init-camel-schema-version-property-from-file) on project camel-spring-xml:
> Execution init-camel-schema-version-property-from-file of goal
> org.codehaus.mojo:properties-maven-plugin:1.0-alpha-2:read-project-properties
> failed. at
> org.apache.maven.lifecycle.internal.MojoExecutor.doExecute2(MojoExecutor.java:385)
>at
> org.apache.maven.lifecycle.internal.MojoExecutor.doExecute(MojoExecutor.java:361)
> at
> org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:232)
> at
> org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:188)
> at
> org.apache.maven.lifecycle.internal.MojoExecutor.access$000(MojoExecutor.java:78)
> at
> org.apache.maven.lifecycle.internal.MojoExecutor$1.run(MojoExecutor.java:179)
>at
> org.apache.maven.buildcache.BuildCacheMojosExecutionStrategy.execute(BuildCacheMojosExecutionStrategy.java:132)
> at
> org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:174)
> at
> org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:112)
> at
> org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:80)
> at
> org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.build(SingleThreadedBuilder.java:64)
> at
> org.apache.maven.lifecycle.internal.LifecycleStarter.execute(LifecycleStarter.java:141)
> at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:341)
> at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:248) at
> org.apache.maven.DefaultMaven.execute(DefaultMaven.java:158) at
> org.apache.maven.cli.DaemonMavenCli.execute(DaemonMavenCli.java:682) at
> org.apache.maven.cli.DaemonMavenCli.doMain(DaemonMavenCli.java:234) at
> org.apache.maven.cli.DaemonMavenCli.main(DaemonMavenCli.java:210)at
> org.mvndaemon.mvnd.daemon.Server.handle(Server.java:572) at
> org.mvndaemon.mvnd.daemon.Server.client(Server.java:256) at
> org.mvndaemon.mvnd.daemon.Server.accept(Server.java:224) at
> java.base/java.lang.Thread.run(Thread.java:833)Caused by:
> org.apache.maven.plugin.PluginExecutionException: Execution
> init-camel-schema-version-property-from-file of goal
> org.codehaus.mojo:properties-maven-plugin:1.0-alpha-2:read-project-properties
> failed. at
> org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo(DefaultBuildPluginManager.java:165)
> at
> org.apache.maven.lifecycle.internal.MojoExecutor.doExecute2(MojoExecutor.java:380)
>... 21 common frames omittedCaused by:
> java.lang.UnsupportedOperationException: nullat
> org.apache.maven.model.WrapperProperties.load(WrapperProperties.java:318)
> at
> org.codehaus.mojo.properties.ReadPropertiesMojo.execute(ReadPropertiesMojo.java:87)
> at
> org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo(DefaultBuildPluginManager.java:155)
> ... 22 common frames omitted
> {code}
>
> The {{WrapperProperties}} do not support the {{load}} operation.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Updated] (MWRAPPER-85) Docs do not mention distributionType for MavenWrapperDownloader.jar
[ https://issues.apache.org/jira/browse/MWRAPPER-85?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Benjamin Marwell updated MWRAPPER-85: - Summary: Docs do not mention distributionType for MavenWrapperDownloader.jar (was: wrapper:wrapper fails to install MavenWrapperDownloader.java) > Docs do not mention distributionType for MavenWrapperDownloader.jar > --- > > Key: MWRAPPER-85 > URL: https://issues.apache.org/jira/browse/MWRAPPER-85 > Project: Maven Wrapper > Issue Type: Bug >Affects Versions: 3.1.1 >Reporter: Benjamin Marwell >Assignee: Benjamin Marwell >Priority: Major > Labels: Documentation > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (MNG-6437) Generic .uri suffix to get the URI representation of any file property
[
https://issues.apache.org/jira/browse/MNG-6437?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Guillaume Nodet updated MNG-6437:
-
Fix Version/s: 4.0.0-alpha-4
(was: 4.0.0-alpha-3)
> Generic .uri suffix to get the URI representation of any file property
> --
>
> Key: MNG-6437
> URL: https://issues.apache.org/jira/browse/MNG-6437
> Project: Maven
> Issue Type: Improvement
> Components: Core
>Affects Versions: 3.5.4
>Reporter: Claude Brisson
>Assignee: Guillaume Nodet
>Priority: Major
> Fix For: 4.0.0, 4.0.0-alpha-4
>
>
> It's impossible to properly generate, for instance, a java policy file which
> needs files URIs, using either Cargo properties and filtered config files, or
> just filtered resources.
> In both cases, the problem is the impossibility to generate proper URIs when
> expanding Maven properties (see also MNG-3760).
> The candidate feature is to add a way to explicitly request the URI when
> expanding a property by means of a {{.uri}} suffix. The underlying
> {{getUri()}} method should rely on the correct {{Path#toUri()}} and neither
> {{File#toUri()}} nor {{File#toString()}}, see the SO reference in MNG-6386.
> For instance:
> * {{${project.basedir.uri}}} instead of the broken {{${project.baseUri}}}
> (and of course fix MNG-6436 otherwise it's useless)
> * {{${project.build.directory.uri}}}
> * {{${settings.localRepository.uri}}}
> * etc
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Closed] (MNG-7582) Reformat apiv4 javadoc according to usual rules
[ https://issues.apache.org/jira/browse/MNG-7582?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guillaume Nodet closed MNG-7582. Resolution: Fixed > Reformat apiv4 javadoc according to usual rules > --- > > Key: MNG-7582 > URL: https://issues.apache.org/jira/browse/MNG-7582 > Project: Maven > Issue Type: Task >Reporter: Guillaume Nodet >Assignee: Guillaume Nodet >Priority: Major > Fix For: 4.0.0-alpha-3 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (MNG-7456) Provide FileTransformer replacement within Maven
[ https://issues.apache.org/jira/browse/MNG-7456?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guillaume Nodet updated MNG-7456: - Fix Version/s: 4.0.0-alpha-4 (was: 4.0.0-alpha-3) > Provide FileTransformer replacement within Maven > > > Key: MNG-7456 > URL: https://issues.apache.org/jira/browse/MNG-7456 > Project: Maven > Issue Type: Task >Reporter: Tamas Cservenak >Priority: Major > Fix For: 4.0.0, 4.0.0-alpha-4 > > > As transforming "just in time" POM for consumer POM is not really Resolver > concern, that must get rid of current OOM-prone API. Maven should take care > of it by itself. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (MNG-7046) Revert MNG-5639 and make repo config static only (no ${param} interpolation)
[
https://issues.apache.org/jira/browse/MNG-7046?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Guillaume Nodet updated MNG-7046:
-
Fix Version/s: 4.0.0-alpha-4
(was: 4.0.0-alpha-3)
> Revert MNG-5639 and make repo config static only (no ${param} interpolation)
>
>
> Key: MNG-7046
> URL: https://issues.apache.org/jira/browse/MNG-7046
> Project: Maven
> Issue Type: Task
> Components: Artifacts and Repositories, Dependencies
>Affects Versions: 3.6.3
>Reporter: Michael Osipov
>Priority: Major
> Labels: must-be-in-4.0.0-alpha-2
> Fix For: 4.0.0, 4.0.0-alpha-4
>
>
> As discussed in MNG-5639 repositories should always be known upfront, they
> have to be static to avoid chicken and egg situations, a project should not
> influence settings. It should be the way around.
> In subsequent ticket it will be verified that repo configuration does not
> contain any expression:
> https://github.com/apache/maven/commit/d411c3fa98832e7d86d901fe86ff63ba907cf868#commitcomment-44782281.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Closed] (MNG-7596) Upgrade to plexus-utils 3.5.0
[ https://issues.apache.org/jira/browse/MNG-7596?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guillaume Nodet closed MNG-7596. Resolution: Fixed > Upgrade to plexus-utils 3.5.0 > - > > Key: MNG-7596 > URL: https://issues.apache.org/jira/browse/MNG-7596 > Project: Maven > Issue Type: Dependency upgrade >Reporter: Guillaume Nodet >Assignee: Guillaume Nodet >Priority: Major > Fix For: 4.0.0-alpha-3 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (MNG-7543) Upgrade JUnit Jupiter Version 5.9.1
[ https://issues.apache.org/jira/browse/MNG-7543?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guillaume Nodet updated MNG-7543: - Fix Version/s: 4.0.0-alpha-4 (was: 4.0.0-alpha-3) > Upgrade JUnit Jupiter Version 5.9.1 > --- > > Key: MNG-7543 > URL: https://issues.apache.org/jira/browse/MNG-7543 > Project: Maven > Issue Type: Dependency upgrade >Affects Versions: 4.0.0 >Reporter: Karl Heinz Marbaise >Assignee: Karl Heinz Marbaise >Priority: Minor > Fix For: 4.0.0-alpha-4 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Assigned] (MNG-7596) Upgrade to plexus-utils 3.5.0
[ https://issues.apache.org/jira/browse/MNG-7596?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guillaume Nodet reassigned MNG-7596: Assignee: Guillaume Nodet > Upgrade to plexus-utils 3.5.0 > - > > Key: MNG-7596 > URL: https://issues.apache.org/jira/browse/MNG-7596 > Project: Maven > Issue Type: Dependency upgrade >Reporter: Guillaume Nodet >Assignee: Guillaume Nodet >Priority: Major > Fix For: 4.0.0-alpha-3 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (MNG-7422) Remove dependency to guava
[ https://issues.apache.org/jira/browse/MNG-7422?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guillaume Nodet updated MNG-7422: - Fix Version/s: 4.0.0-alpha-4 (was: 4.0.0-alpha-3) > Remove dependency to guava > -- > > Key: MNG-7422 > URL: https://issues.apache.org/jira/browse/MNG-7422 > Project: Maven > Issue Type: Improvement >Affects Versions: 3.0-alpha-1 >Reporter: Karl Heinz Marbaise >Assignee: Karl Heinz Marbaise >Priority: Minor > Fix For: 4.0.0-alpha-4 > > > Currently we have dependency to google guava which is only needed for a > single test at the moment. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Closed] (MNG-7576) Restore compatibility with maven 3
[
https://issues.apache.org/jira/browse/MNG-7576?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Guillaume Nodet closed MNG-7576.
Resolution: Fixed
> Restore compatibility with maven 3
> --
>
> Key: MNG-7576
> URL: https://issues.apache.org/jira/browse/MNG-7576
> Project: Maven
> Issue Type: Task
>Affects Versions: 4.0.0-alpha-2
>Reporter: Guillaume Nodet
>Assignee: Guillaume Nodet
>Priority: Major
> Fix For: 4.0.0-alpha-3
>
>
> {{MavenBuildTimestamp}}
> https://github.com/apache/maven/commit/18eff3baeb899ddd27b34635c8f0d7e47f5c027b
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Updated] (MWRAPPER-85) wrapper:wrapper fails to install MavenWrapperDownloader.java
[ https://issues.apache.org/jira/browse/MWRAPPER-85?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Benjamin Marwell updated MWRAPPER-85: - Summary: wrapper:wrapper fails to install MavenWrapperDownloader.java (was: docs still mention MavenWrapperDownloader.java) > wrapper:wrapper fails to install MavenWrapperDownloader.java > > > Key: MWRAPPER-85 > URL: https://issues.apache.org/jira/browse/MWRAPPER-85 > Project: Maven Wrapper > Issue Type: Bug >Affects Versions: 3.1.1 >Reporter: Benjamin Marwell >Assignee: Benjamin Marwell >Priority: Major > Labels: Documentation > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Assigned] (MWRAPPER-75) Allow for sha256 checksum verification of downloaded artifacts.
[ https://issues.apache.org/jira/browse/MWRAPPER-75?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Slawomir Jaranowski reassigned MWRAPPER-75: --- Assignee: Slawomir Jaranowski > Allow for sha256 checksum verification of downloaded artifacts. > --- > > Key: MWRAPPER-75 > URL: https://issues.apache.org/jira/browse/MWRAPPER-75 > Project: Maven Wrapper > Issue Type: Improvement > Components: Maven Wrapper Jar, Maven Wrapper Plugin, Maven Wrapper > Scripts >Reporter: Rafael Winterhalter >Assignee: Slawomir Jaranowski >Priority: Normal > Fix For: 3.2.0 > > > Maven Wrapper is downloading binary artifacts that are later executed. To > prevent from an attack where a vulnerable repository could distribute > malicious Maven (wrapper) artifacts, the downloaded artifacts should be > verified against a secure checksum. If the expected checksum does not match, > execution could be aborted before the potentially compromised artifact is > executed. > In my PR, i chose SHA-256 as it is cheaper to compute than SHA-512 but still > impossible to replicate with a corrupted binary. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (MWRAPPER-85) docs still mention MavenWrapperDownloader.java
Benjamin Marwell created MWRAPPER-85: Summary: docs still mention MavenWrapperDownloader.java Key: MWRAPPER-85 URL: https://issues.apache.org/jira/browse/MWRAPPER-85 Project: Maven Wrapper Issue Type: Bug Affects Versions: 3.1.1 Reporter: Benjamin Marwell Assignee: Benjamin Marwell -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MNG-7623) Specify if a project can run in parallel
[ https://issues.apache.org/jira/browse/MNG-7623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17646062#comment-17646062 ] Christoph Läubrich commented on MNG-7623: - One example is I have two modules that both use a mojo and/or library that is not threadsafe or a resource that can not be shared. Currently maven warns if one mojo is not marked thread-safe, so maybe it would also be a valid solution to use that information to determine a project is "not parallel" > Specify if a project can run in parallel > > > Key: MNG-7623 > URL: https://issues.apache.org/jira/browse/MNG-7623 > Project: Maven > Issue Type: Improvement >Reporter: Christoph Läubrich >Priority: Major > > It would be great if one can specify in the pom if a project is safe to > execute in parallel. > I sometimes have a multi-module project where most of the module can run > easily in parallel but some needs serial execution, currently using some > "hacks" to enforce this. > This should work the following way: > # If all projects are marked as "parallel" all works like today (default) > # If a project is marked as not run in parallel, first execute all projects > in the build order until this project > # Then execute the serial one and proceed with the same (that is execute all > in parallel until the next serial project is found) > This could happen on different level, e.g. such a strategy might be delegated > to the builder, or the code that calling the builder can "slice" the projects > in the given way and call the builder multiple times. > Nerveless this will require some change to the project-model to mark a > project as parallel, or one might be able to use a project-session-property > or alike. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MNG-7623) Specify if a project can run in parallel
[ https://issues.apache.org/jira/browse/MNG-7623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17646061#comment-17646061 ] Slawomir Jaranowski commented on MNG-7623: -- Can you provide a live example for such feature? Parallel build graph is built according to dependencies between modules in your project. So correct dependencies should cover your requirements. > Specify if a project can run in parallel > > > Key: MNG-7623 > URL: https://issues.apache.org/jira/browse/MNG-7623 > Project: Maven > Issue Type: Improvement >Reporter: Christoph Läubrich >Priority: Major > > It would be great if one can specify in the pom if a project is safe to > execute in parallel. > I sometimes have a multi-module project where most of the module can run > easily in parallel but some needs serial execution, currently using some > "hacks" to enforce this. > This should work the following way: > # If all projects are marked as "parallel" all works like today (default) > # If a project is marked as not run in parallel, first execute all projects > in the build order until this project > # Then execute the serial one and proceed with the same (that is execute all > in parallel until the next serial project is found) > This could happen on different level, e.g. such a strategy might be delegated > to the builder, or the code that calling the builder can "slice" the projects > in the given way and call the builder multiple times. > Nerveless this will require some change to the project-model to mark a > project as parallel, or one might be able to use a project-session-property > or alike. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [maven] sultan closed pull request #901: fix version comparison
sultan closed pull request #901: fix version comparison URL: https://github.com/apache/maven/pull/901 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven] olamy opened a new pull request, #908: simplify build
olamy opened a new pull request, #908: URL: https://github.com/apache/maven/pull/908 Following this checklist to help us incorporate your contribution quickly and easily: - [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/MNG) filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes. - [ ] Each commit in the pull request should have a meaningful subject line and body. - [ ] Format the pull request title like `[MNG-XXX] SUMMARY`, where you replace `MNG-XXX` and `SUMMARY` with the appropriate JIRA issue. Best practice is to use the JIRA issue title in the pull request title and in the first line of the commit message. - [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [ ] Run `mvn clean verify` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically. - [ ] You have run the [Core IT][core-its] successfully. If your pull request is about ~20 lines of code you don't need to sign an [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure please ask on the developers list. To make clear that you license your contribution under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) you have to acknowledge this by using the following check-box. - [ ] I hereby declare this contribution to be licenced under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) - [ ] In any other case, please file an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). [core-its]: https://maven.apache.org/core-its/core-it-suite/ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MNG-7622) Reimplement Consumer POM feature
[ https://issues.apache.org/jira/browse/MNG-7622?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17646026#comment-17646026 ] ASF GitHub Bot commented on MNG-7622: - cstamas commented on PR #907: URL: https://github.com/apache/maven/pull/907#issuecomment-1346245435 Well, all I do is applying PR comments, no? > Reimplement Consumer POM feature > > > Key: MNG-7622 > URL: https://issues.apache.org/jira/browse/MNG-7622 > Project: Maven > Issue Type: Task > Components: build/consumer >Reporter: Tamas Cservenak >Priority: Major > Fix For: 4.0.x-candidate > > > Current implementation relies on deprecated resolver API (is deprecated as it > is OOM prone), and also renders use cases like m-gpg-p but also checksum-m-p > broken. > Reimplement consumer POM feature that: > * does not use FileTransformer API > * allows use cases like m-gpg-p -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [maven] cstamas commented on pull request #907: [MNG-7622] Maven Transformation and Consumer POM
cstamas commented on PR #907: URL: https://github.com/apache/maven/pull/907#issuecomment-1346245435 Well, all I do is applying PR comments, no? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MNG-7622) Reimplement Consumer POM feature
[ https://issues.apache.org/jira/browse/MNG-7622?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17646025#comment-17646025 ] ASF GitHub Bot commented on MNG-7622: - michael-o commented on PR #907: URL: https://github.com/apache/maven/pull/907#issuecomment-1346244136 > > I think this needs to be turned into a draft. > > Why? I don't get it what would make that different? Because it seems to me that you are still working on it, no? > Reimplement Consumer POM feature > > > Key: MNG-7622 > URL: https://issues.apache.org/jira/browse/MNG-7622 > Project: Maven > Issue Type: Task > Components: build/consumer >Reporter: Tamas Cservenak >Priority: Major > Fix For: 4.0.x-candidate > > > Current implementation relies on deprecated resolver API (is deprecated as it > is OOM prone), and also renders use cases like m-gpg-p but also checksum-m-p > broken. > Reimplement consumer POM feature that: > * does not use FileTransformer API > * allows use cases like m-gpg-p -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [maven] michael-o commented on pull request #907: [MNG-7622] Maven Transformation and Consumer POM
michael-o commented on PR #907: URL: https://github.com/apache/maven/pull/907#issuecomment-1346244136 > > I think this needs to be turned into a draft. > > Why? I don't get it what would make that different? Because it seems to me that you are still working on it, no? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MNG-7586) Update Maven Resolver to 1.9.2
[ https://issues.apache.org/jira/browse/MNG-7586?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17646021#comment-17646021 ] ASF GitHub Bot commented on MNG-7586: - cstamas commented on PR #742: URL: https://github.com/apache/maven-mvnd/pull/742#issuecomment-1346237745 Cool, thanks for picking up this :smile: > Update Maven Resolver to 1.9.2 > -- > > Key: MNG-7586 > URL: https://issues.apache.org/jira/browse/MNG-7586 > Project: Maven > Issue Type: Dependency upgrade > Components: Dependencies >Reporter: Tamas Cservenak >Assignee: Tamas Cservenak >Priority: Major > Fix For: 3.9.0, 4.0.0-alpha-3 > > > Update Maven Resolver to 1.9.2 (releases 1.9.0 and 1.9.1 are fluke due > different reasons). -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [maven-mvnd] cstamas commented on pull request #742: [MNG-7586] Update Maven Resolver to 1.9.2
cstamas commented on PR #742: URL: https://github.com/apache/maven-mvnd/pull/742#issuecomment-1346237745 Cool, thanks for picking up this :smile: -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (MRESOLVER-308) HTTP transport showdown
Tamas Cservenak created MRESOLVER-308: - Summary: HTTP transport showdown Key: MRESOLVER-308 URL: https://issues.apache.org/jira/browse/MRESOLVER-308 Project: Maven Resolver Issue Type: Task Components: Resolver Reporter: Tamas Cservenak For HTTP protocol resolver currently provides following transports: * transport-wagon that uses Maven 2.x Wagon, that among other protocols supports HTTP/1.1 as well * transport-http that uses directly Apache HttpClient 4.x supporting HTTP/1.1 but provides enhancements in form of "checksum strategy" (almost all of remote repositories emit those in headers, sparing one HTTP round-trip) As we saw, is very easy to outperform these as: * Maven Central supports HTTP/1.1 but also HTTP/2 * HTTP/3 is on the way as well An experiment involving Jetty Client far outperformed both of existing transports, most probably due HTTP/2 support. So, clients we should consider: * Jetty Client * OkHTTP * Java 11 HttpClient Point is, to invest into something that (ideally) transparently supports HTTP/1.1 and HTTP/2, and more ideal would be if even HTTP/3 would be transparently supported (Jetty 12 works on that). We could then simply compare these implementations, count in pros and cons, and decide where we want to go, -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MNG-7622) Reimplement Consumer POM feature
[ https://issues.apache.org/jira/browse/MNG-7622?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17646009#comment-17646009 ] ASF GitHub Bot commented on MNG-7622: - cstamas commented on PR #907: URL: https://github.com/apache/maven/pull/907#issuecomment-1346210555 > I think this needs to be turned into a draft. Why? I don't get it what would make that different? > Reimplement Consumer POM feature > > > Key: MNG-7622 > URL: https://issues.apache.org/jira/browse/MNG-7622 > Project: Maven > Issue Type: Task > Components: build/consumer >Reporter: Tamas Cservenak >Priority: Major > Fix For: 4.0.x-candidate > > > Current implementation relies on deprecated resolver API (is deprecated as it > is OOM prone), and also renders use cases like m-gpg-p but also checksum-m-p > broken. > Reimplement consumer POM feature that: > * does not use FileTransformer API > * allows use cases like m-gpg-p -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [maven] cstamas commented on pull request #907: [MNG-7622] Maven Transformation and Consumer POM
cstamas commented on PR #907: URL: https://github.com/apache/maven/pull/907#issuecomment-1346210555 > I think this needs to be turned into a draft. Why? I don't get it what would make that different? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MNG-7622) Reimplement Consumer POM feature
[
https://issues.apache.org/jira/browse/MNG-7622?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17646004#comment-17646004
]
ASF GitHub Bot commented on MNG-7622:
-
cstamas commented on code in PR #907:
URL: https://github.com/apache/maven/pull/907#discussion_r1045591133
##
maven-core/src/main/java/org/apache/maven/internal/transformation/TransformedArtifact.java:
##
@@ -0,0 +1,146 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.maven.internal.transformation;
+
+import static java.util.Objects.requireNonNull;
+
+import java.io.BufferedInputStream;
+import java.io.File;
+import java.io.InputStream;
+import java.nio.file.Files;
+import java.nio.file.Path;
+import java.security.MessageDigest;
+import java.util.function.BiConsumer;
+import java.util.function.Supplier;
+import org.apache.maven.artifact.Artifact;
+import org.apache.maven.artifact.DefaultArtifact;
+import org.apache.maven.artifact.handler.ArtifactHandler;
+
+/**
+ * Transformed artifact is derived with some transformation from source
artifact.
+ *
+ * @since TBD
+ */
+public abstract class TransformedArtifact extends DefaultArtifact {
+
+private final OnChangeTransformer onChangeTransformer;
+
+public TransformedArtifact(
+Artifact source,
+Supplier sourcePathProvider,
+String classifier,
+String extension,
+Path targetPath,
+BiConsumer transformerConsumer) {
+super(
+source.getGroupId(),
+source.getArtifactId(),
+source.getVersionRange(),
+source.getScope(),
+extension,
+classifier,
+new TransformedArtifactHandler(
+classifier, extension,
source.getArtifactHandler().getPackaging()));
+this.onChangeTransformer =
+new OnChangeTransformer(sourcePathProvider, targetPath,
TransformedArtifact::sha1, transformerConsumer);
+}
+
+@Override
+public boolean isResolved() {
+return getFile() != null;
+}
+
+@Override
+public void setFile(File file) {
+throw new IllegalStateException("transformed artifact file cannot be
set");
+}
+
+@Override
+public File getFile() {
+Path result = onChangeTransformer.get();
+if (result == null) {
+return null;
+}
+return result.toFile();
+}
+
+private static final int BUFFER_SIZE = 8192;
+
+private static String sha1(Path path) {
+try {
+MessageDigest md = MessageDigest.getInstance("SHA-1");
+try (InputStream fis = new
BufferedInputStream(Files.newInputStream(path), BUFFER_SIZE)) {
Review Comment:
Removed buffered input stream
> Reimplement Consumer POM feature
>
>
> Key: MNG-7622
> URL: https://issues.apache.org/jira/browse/MNG-7622
> Project: Maven
> Issue Type: Task
> Components: build/consumer
>Reporter: Tamas Cservenak
>Priority: Major
> Fix For: 4.0.x-candidate
>
>
> Current implementation relies on deprecated resolver API (is deprecated as it
> is OOM prone), and also renders use cases like m-gpg-p but also checksum-m-p
> broken.
> Reimplement consumer POM feature that:
> * does not use FileTransformer API
> * allows use cases like m-gpg-p
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[GitHub] [maven] cstamas commented on a diff in pull request #907: [MNG-7622] Maven Transformation and Consumer POM
cstamas commented on code in PR #907:
URL: https://github.com/apache/maven/pull/907#discussion_r1045591133
##
maven-core/src/main/java/org/apache/maven/internal/transformation/TransformedArtifact.java:
##
@@ -0,0 +1,146 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.maven.internal.transformation;
+
+import static java.util.Objects.requireNonNull;
+
+import java.io.BufferedInputStream;
+import java.io.File;
+import java.io.InputStream;
+import java.nio.file.Files;
+import java.nio.file.Path;
+import java.security.MessageDigest;
+import java.util.function.BiConsumer;
+import java.util.function.Supplier;
+import org.apache.maven.artifact.Artifact;
+import org.apache.maven.artifact.DefaultArtifact;
+import org.apache.maven.artifact.handler.ArtifactHandler;
+
+/**
+ * Transformed artifact is derived with some transformation from source
artifact.
+ *
+ * @since TBD
+ */
+public abstract class TransformedArtifact extends DefaultArtifact {
+
+private final OnChangeTransformer onChangeTransformer;
+
+public TransformedArtifact(
+Artifact source,
+Supplier sourcePathProvider,
+String classifier,
+String extension,
+Path targetPath,
+BiConsumer transformerConsumer) {
+super(
+source.getGroupId(),
+source.getArtifactId(),
+source.getVersionRange(),
+source.getScope(),
+extension,
+classifier,
+new TransformedArtifactHandler(
+classifier, extension,
source.getArtifactHandler().getPackaging()));
+this.onChangeTransformer =
+new OnChangeTransformer(sourcePathProvider, targetPath,
TransformedArtifact::sha1, transformerConsumer);
+}
+
+@Override
+public boolean isResolved() {
+return getFile() != null;
+}
+
+@Override
+public void setFile(File file) {
+throw new IllegalStateException("transformed artifact file cannot be
set");
+}
+
+@Override
+public File getFile() {
+Path result = onChangeTransformer.get();
+if (result == null) {
+return null;
+}
+return result.toFile();
+}
+
+private static final int BUFFER_SIZE = 8192;
+
+private static String sha1(Path path) {
+try {
+MessageDigest md = MessageDigest.getInstance("SHA-1");
+try (InputStream fis = new
BufferedInputStream(Files.newInputStream(path), BUFFER_SIZE)) {
Review Comment:
Removed buffered input stream
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Created] (MNG-7623) Specify if a project can run in parallel
Christoph Läubrich created MNG-7623: --- Summary: Specify if a project can run in parallel Key: MNG-7623 URL: https://issues.apache.org/jira/browse/MNG-7623 Project: Maven Issue Type: Improvement Reporter: Christoph Läubrich It would be great if one can specify in the pom if a project is safe to execute in parallel. I sometimes have a multi-module project where most of the module can run easily in parallel but some needs serial execution, currently using some "hacks" to enforce this. This should work the following way: # If all projects are marked as "parallel" all works like today (default) # If a project is marked as not run in parallel, first execute all projects in the build order until this project # Then execute the serial one and proceed with the same (that is execute all in parallel until the next serial project is found) This could happen on different level, e.g. such a strategy might be delegated to the builder, or the code that calling the builder can "slice" the projects in the given way and call the builder multiple times. Nerveless this will require some change to the project-model to mark a project as parallel, or one might be able to use a project-session-property or alike. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MNG-7622) Reimplement Consumer POM feature
[ https://issues.apache.org/jira/browse/MNG-7622?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17645991#comment-17645991 ] ASF GitHub Bot commented on MNG-7622: - michael-o commented on PR #907: URL: https://github.com/apache/maven/pull/907#issuecomment-1346145690 I think this needs to be turned into a draft. > Reimplement Consumer POM feature > > > Key: MNG-7622 > URL: https://issues.apache.org/jira/browse/MNG-7622 > Project: Maven > Issue Type: Task > Components: build/consumer >Reporter: Tamas Cservenak >Priority: Major > Fix For: 4.0.x-candidate > > > Current implementation relies on deprecated resolver API (is deprecated as it > is OOM prone), and also renders use cases like m-gpg-p but also checksum-m-p > broken. > Reimplement consumer POM feature that: > * does not use FileTransformer API > * allows use cases like m-gpg-p -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [maven] michael-o commented on pull request #907: [MNG-7622] Maven Transformation and Consumer POM
michael-o commented on PR #907: URL: https://github.com/apache/maven/pull/907#issuecomment-1346145690 I think this needs to be turned into a draft. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (MRESOLVER-304) DirectoryUtils should consider interpolation
[ https://issues.apache.org/jira/browse/MRESOLVER-304?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tamas Cservenak updated MRESOLVER-304: -- Description: As currently it cannot be interpolated, and it applies this logic: * if "relative path" it resolves against local repo * if "absolute path" it resolves against path what would be ideal to introduce somehow 3rd case: * resolve against local repo * resolve against maven.multiModuleProjectDirectory * resolver against absolute path As new 2nd option would allow to check in filter config along with sources. was:As currently it cannot be interpolated. > DirectoryUtils should consider interpolation > > > Key: MRESOLVER-304 > URL: https://issues.apache.org/jira/browse/MRESOLVER-304 > Project: Maven Resolver > Issue Type: Improvement > Components: Resolver >Reporter: Tamas Cservenak >Priority: Major > Fix For: 1.9.3 > > > As currently it cannot be interpolated, and it applies this logic: > * if "relative path" it resolves against local repo > * if "absolute path" it resolves against path > what would be ideal to introduce somehow 3rd case: > * resolve against local repo > * resolve against maven.multiModuleProjectDirectory > * resolver against absolute path > As new 2nd option would allow to check in filter config along with sources. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MNG-7622) Reimplement Consumer POM feature
[
https://issues.apache.org/jira/browse/MNG-7622?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17645988#comment-17645988
]
ASF GitHub Bot commented on MNG-7622:
-
cstamas commented on code in PR #907:
URL: https://github.com/apache/maven/pull/907#discussion_r1045564744
##
maven-core/src/main/java/org/apache/maven/internal/transformation/ArtifactTransformer.java:
##
@@ -0,0 +1,45 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.maven.internal.transformation;
+
+import java.io.IOException;
+import org.apache.maven.project.MavenProject;
+import org.eclipse.aether.RepositorySystemSession;
+import org.eclipse.aether.deployment.DeployRequest;
+import org.eclipse.aether.installation.InstallRequest;
+
+/**
+ * Artifact transformer component.
+ *
+ * Note: this interface is Maven internal component, subject to change or
removal without notice.
+ *
+ * @since TBD
+ */
+public interface ArtifactTransformer {
Review Comment:
Done
> Reimplement Consumer POM feature
>
>
> Key: MNG-7622
> URL: https://issues.apache.org/jira/browse/MNG-7622
> Project: Maven
> Issue Type: Task
> Components: build/consumer
>Reporter: Tamas Cservenak
>Priority: Major
> Fix For: 4.0.x-candidate
>
>
> Current implementation relies on deprecated resolver API (is deprecated as it
> is OOM prone), and also renders use cases like m-gpg-p but also checksum-m-p
> broken.
> Reimplement consumer POM feature that:
> * does not use FileTransformer API
> * allows use cases like m-gpg-p
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[GitHub] [maven] cstamas commented on a diff in pull request #907: [MNG-7622] Maven Transformation and Consumer POM
cstamas commented on code in PR #907:
URL: https://github.com/apache/maven/pull/907#discussion_r1045564744
##
maven-core/src/main/java/org/apache/maven/internal/transformation/ArtifactTransformer.java:
##
@@ -0,0 +1,45 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.maven.internal.transformation;
+
+import java.io.IOException;
+import org.apache.maven.project.MavenProject;
+import org.eclipse.aether.RepositorySystemSession;
+import org.eclipse.aether.deployment.DeployRequest;
+import org.eclipse.aether.installation.InstallRequest;
+
+/**
+ * Artifact transformer component.
+ *
+ * Note: this interface is Maven internal component, subject to change or
removal without notice.
+ *
+ * @since TBD
+ */
+public interface ArtifactTransformer {
Review Comment:
Done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [maven-resolver] cstamas commented on pull request #186: [WIP] move to org.apache.maven package
cstamas commented on PR #186: URL: https://github.com/apache/maven-resolver/pull/186#issuecomment-1346132728 It depends, we can do this only when resolver is completely sealed off from anything else than maven core (so when Maven 4 API is the only thing reachable for plugins). So, it may mean even 3.0... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-resolver] laeubi commented on pull request #186: [WIP] move to org.apache.maven package
laeubi commented on PR #186: URL: https://github.com/apache/maven-resolver/pull/186#issuecomment-1346124283 @cstamas this should be tagged 2.0 as well! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MRESOLVER-307) Support listing of workspace artifacts
[
https://issues.apache.org/jira/browse/MRESOLVER-307?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17645983#comment-17645983
]
ASF GitHub Bot commented on MRESOLVER-307:
--
laeubi commented on PR #230:
URL: https://github.com/apache/maven-resolver/pull/230#issuecomment-1346120213
@cstamas I now adjusted the code, the only think left is that one might want
to move the interface from `org.eclipse.aether.repository.WorkspaceReader` >
`org.eclipse.aether.spi.repository.WorkspaceReader` but I don't know if this is
sufficient.
> Support listing of workspace artifacts
> --
>
> Key: MRESOLVER-307
> URL: https://issues.apache.org/jira/browse/MRESOLVER-307
> Project: Maven Resolver
> Issue Type: Improvement
>Reporter: Christoph Läubrich
>Priority: Major
>
> Currently the WorkspaceReader has a way to list versions or resolve the file
> for an artifact, but there is no way of really get a list of workspace
> artifacts itself.
> The javadoc states:
> {quote}Manages a repository backed by the IDE workspace, a build session or a
> similar ad-hoc collection of artifacts.{quote}
> so the goal is to have a way getting hold of the "collection of artifacts"
> this Workspacereader manages.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[GitHub] [maven-resolver] laeubi commented on pull request #230: MRESOLVER-307 - Support listing of workspace artifacts
laeubi commented on PR #230: URL: https://github.com/apache/maven-resolver/pull/230#issuecomment-1346120213 @cstamas I now adjusted the code, the only think left is that one might want to move the interface from `org.eclipse.aether.repository.WorkspaceReader` > `org.eclipse.aether.spi.repository.WorkspaceReader` but I don't know if this is sufficient. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MNG-7622) Reimplement Consumer POM feature
[
https://issues.apache.org/jira/browse/MNG-7622?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17645972#comment-17645972
]
ASF GitHub Bot commented on MNG-7622:
-
gnodet commented on code in PR #907:
URL: https://github.com/apache/maven/pull/907#discussion_r1045541829
##
maven-core/src/main/java/org/apache/maven/internal/transformation/TransformedArtifact.java:
##
@@ -0,0 +1,146 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.maven.internal.transformation;
+
+import static java.util.Objects.requireNonNull;
+
+import java.io.BufferedInputStream;
+import java.io.File;
+import java.io.InputStream;
+import java.nio.file.Files;
+import java.nio.file.Path;
+import java.security.MessageDigest;
+import java.util.function.BiConsumer;
+import java.util.function.Supplier;
+import org.apache.maven.artifact.Artifact;
+import org.apache.maven.artifact.DefaultArtifact;
+import org.apache.maven.artifact.handler.ArtifactHandler;
+
+/**
+ * Transformed artifact is derived with some transformation from source
artifact.
+ *
+ * @since TBD
+ */
+public abstract class TransformedArtifact extends DefaultArtifact {
+
+private final OnChangeTransformer onChangeTransformer;
+
+public TransformedArtifact(
+Artifact source,
+Supplier sourcePathProvider,
+String classifier,
+String extension,
+Path targetPath,
+BiConsumer transformerConsumer) {
+super(
+source.getGroupId(),
+source.getArtifactId(),
+source.getVersionRange(),
+source.getScope(),
+extension,
+classifier,
+new TransformedArtifactHandler(
+classifier, extension,
source.getArtifactHandler().getPackaging()));
+this.onChangeTransformer =
+new OnChangeTransformer(sourcePathProvider, targetPath,
TransformedArtifact::sha1, transformerConsumer);
+}
+
+@Override
+public boolean isResolved() {
+return getFile() != null;
+}
+
+@Override
+public void setFile(File file) {
+throw new IllegalStateException("transformed artifact file cannot be
set");
+}
+
+@Override
+public File getFile() {
+Path result = onChangeTransformer.get();
+if (result == null) {
+return null;
+}
+return result.toFile();
+}
+
+private static final int BUFFER_SIZE = 8192;
+
+private static String sha1(Path path) {
+try {
+MessageDigest md = MessageDigest.getInstance("SHA-1");
+try (InputStream fis = new
BufferedInputStream(Files.newInputStream(path), BUFFER_SIZE)) {
Review Comment:
Yes, but the stream is read using a `read(buffer)` which achieves the same
effect than the `BufferedInputStream. So we end up reading into a buffer, then
transferring into another buffer.
> Reimplement Consumer POM feature
>
>
> Key: MNG-7622
> URL: https://issues.apache.org/jira/browse/MNG-7622
> Project: Maven
> Issue Type: Task
> Components: build/consumer
>Reporter: Tamas Cservenak
>Priority: Major
> Fix For: 4.0.x-candidate
>
>
> Current implementation relies on deprecated resolver API (is deprecated as it
> is OOM prone), and also renders use cases like m-gpg-p but also checksum-m-p
> broken.
> Reimplement consumer POM feature that:
> * does not use FileTransformer API
> * allows use cases like m-gpg-p
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[GitHub] [maven] gnodet commented on a diff in pull request #907: [MNG-7622] Maven Transformation and Consumer POM
gnodet commented on code in PR #907:
URL: https://github.com/apache/maven/pull/907#discussion_r1045541829
##
maven-core/src/main/java/org/apache/maven/internal/transformation/TransformedArtifact.java:
##
@@ -0,0 +1,146 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.maven.internal.transformation;
+
+import static java.util.Objects.requireNonNull;
+
+import java.io.BufferedInputStream;
+import java.io.File;
+import java.io.InputStream;
+import java.nio.file.Files;
+import java.nio.file.Path;
+import java.security.MessageDigest;
+import java.util.function.BiConsumer;
+import java.util.function.Supplier;
+import org.apache.maven.artifact.Artifact;
+import org.apache.maven.artifact.DefaultArtifact;
+import org.apache.maven.artifact.handler.ArtifactHandler;
+
+/**
+ * Transformed artifact is derived with some transformation from source
artifact.
+ *
+ * @since TBD
+ */
+public abstract class TransformedArtifact extends DefaultArtifact {
+
+private final OnChangeTransformer onChangeTransformer;
+
+public TransformedArtifact(
+Artifact source,
+Supplier sourcePathProvider,
+String classifier,
+String extension,
+Path targetPath,
+BiConsumer transformerConsumer) {
+super(
+source.getGroupId(),
+source.getArtifactId(),
+source.getVersionRange(),
+source.getScope(),
+extension,
+classifier,
+new TransformedArtifactHandler(
+classifier, extension,
source.getArtifactHandler().getPackaging()));
+this.onChangeTransformer =
+new OnChangeTransformer(sourcePathProvider, targetPath,
TransformedArtifact::sha1, transformerConsumer);
+}
+
+@Override
+public boolean isResolved() {
+return getFile() != null;
+}
+
+@Override
+public void setFile(File file) {
+throw new IllegalStateException("transformed artifact file cannot be
set");
+}
+
+@Override
+public File getFile() {
+Path result = onChangeTransformer.get();
+if (result == null) {
+return null;
+}
+return result.toFile();
+}
+
+private static final int BUFFER_SIZE = 8192;
+
+private static String sha1(Path path) {
+try {
+MessageDigest md = MessageDigest.getInstance("SHA-1");
+try (InputStream fis = new
BufferedInputStream(Files.newInputStream(path), BUFFER_SIZE)) {
Review Comment:
Yes, but the stream is read using a `read(buffer)` which achieves the same
effect than the `BufferedInputStream. So we end up reading into a buffer, then
transferring into another buffer.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Commented] (MNG-7622) Reimplement Consumer POM feature
[
https://issues.apache.org/jira/browse/MNG-7622?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17645971#comment-17645971
]
ASF GitHub Bot commented on MNG-7622:
-
gnodet commented on code in PR #907:
URL: https://github.com/apache/maven/pull/907#discussion_r1045534915
##
maven-core/src/main/java/org/apache/maven/internal/transformation/ArtifactTransformer.java:
##
@@ -0,0 +1,45 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.maven.internal.transformation;
+
+import java.io.IOException;
+import org.apache.maven.project.MavenProject;
+import org.eclipse.aether.RepositorySystemSession;
+import org.eclipse.aether.deployment.DeployRequest;
+import org.eclipse.aether.installation.InstallRequest;
+
+/**
+ * Artifact transformer component.
+ *
+ * Note: this interface is Maven internal component, subject to change or
removal without notice.
+ *
+ * @since TBD
+ */
+public interface ArtifactTransformer {
Review Comment:
If we don't foresee any additional usage of this interface, I'd rather
simply remove it and simply inject the `ConsumerPomArtifactTransformer`.
> Reimplement Consumer POM feature
>
>
> Key: MNG-7622
> URL: https://issues.apache.org/jira/browse/MNG-7622
> Project: Maven
> Issue Type: Task
> Components: build/consumer
>Reporter: Tamas Cservenak
>Priority: Major
> Fix For: 4.0.x-candidate
>
>
> Current implementation relies on deprecated resolver API (is deprecated as it
> is OOM prone), and also renders use cases like m-gpg-p but also checksum-m-p
> broken.
> Reimplement consumer POM feature that:
> * does not use FileTransformer API
> * allows use cases like m-gpg-p
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[GitHub] [maven] gnodet commented on a diff in pull request #907: [MNG-7622] Maven Transformation and Consumer POM
gnodet commented on code in PR #907:
URL: https://github.com/apache/maven/pull/907#discussion_r1045534915
##
maven-core/src/main/java/org/apache/maven/internal/transformation/ArtifactTransformer.java:
##
@@ -0,0 +1,45 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.maven.internal.transformation;
+
+import java.io.IOException;
+import org.apache.maven.project.MavenProject;
+import org.eclipse.aether.RepositorySystemSession;
+import org.eclipse.aether.deployment.DeployRequest;
+import org.eclipse.aether.installation.InstallRequest;
+
+/**
+ * Artifact transformer component.
+ *
+ * Note: this interface is Maven internal component, subject to change or
removal without notice.
+ *
+ * @since TBD
+ */
+public interface ArtifactTransformer {
Review Comment:
If we don't foresee any additional usage of this interface, I'd rather
simply remove it and simply inject the `ConsumerPomArtifactTransformer`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Commented] (MNG-7622) Reimplement Consumer POM feature
[
https://issues.apache.org/jira/browse/MNG-7622?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17645968#comment-17645968
]
ASF GitHub Bot commented on MNG-7622:
-
cstamas commented on code in PR #907:
URL: https://github.com/apache/maven/pull/907#discussion_r1045528456
##
maven-core/src/main/java/org/apache/maven/internal/transformation/TransformedArtifact.java:
##
@@ -0,0 +1,146 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.maven.internal.transformation;
+
+import static java.util.Objects.requireNonNull;
+
+import java.io.BufferedInputStream;
+import java.io.File;
+import java.io.InputStream;
+import java.nio.file.Files;
+import java.nio.file.Path;
+import java.security.MessageDigest;
+import java.util.function.BiConsumer;
+import java.util.function.Supplier;
+import org.apache.maven.artifact.Artifact;
+import org.apache.maven.artifact.DefaultArtifact;
+import org.apache.maven.artifact.handler.ArtifactHandler;
+
+/**
+ * Transformed artifact is derived with some transformation from source
artifact.
+ *
+ * @since TBD
+ */
+public abstract class TransformedArtifact extends DefaultArtifact {
+
+private final OnChangeTransformer onChangeTransformer;
+
+public TransformedArtifact(
+Artifact source,
+Supplier sourcePathProvider,
+String classifier,
+String extension,
+Path targetPath,
+BiConsumer transformerConsumer) {
+super(
+source.getGroupId(),
+source.getArtifactId(),
+source.getVersionRange(),
+source.getScope(),
+extension,
+classifier,
+new TransformedArtifactHandler(
+classifier, extension,
source.getArtifactHandler().getPackaging()));
+this.onChangeTransformer =
+new OnChangeTransformer(sourcePathProvider, targetPath,
TransformedArtifact::sha1, transformerConsumer);
+}
+
+@Override
+public boolean isResolved() {
+return getFile() != null;
+}
+
+@Override
+public void setFile(File file) {
+throw new IllegalStateException("transformed artifact file cannot be
set");
+}
+
+@Override
+public File getFile() {
+Path result = onChangeTransformer.get();
+if (result == null) {
+return null;
+}
+return result.toFile();
+}
+
+private static final int BUFFER_SIZE = 8192;
+
+private static String sha1(Path path) {
+try {
+MessageDigest md = MessageDigest.getInstance("SHA-1");
+try (InputStream fis = new
BufferedInputStream(Files.newInputStream(path), BUFFER_SIZE)) {
Review Comment:
Um, I don't think so Files.newInputStream returns _unbuffered_ stream,
unless am mistaken...
> Reimplement Consumer POM feature
>
>
> Key: MNG-7622
> URL: https://issues.apache.org/jira/browse/MNG-7622
> Project: Maven
> Issue Type: Task
> Components: build/consumer
>Reporter: Tamas Cservenak
>Priority: Major
> Fix For: 4.0.x-candidate
>
>
> Current implementation relies on deprecated resolver API (is deprecated as it
> is OOM prone), and also renders use cases like m-gpg-p but also checksum-m-p
> broken.
> Reimplement consumer POM feature that:
> * does not use FileTransformer API
> * allows use cases like m-gpg-p
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[GitHub] [maven] cstamas commented on a diff in pull request #907: [MNG-7622] Maven Transformation and Consumer POM
cstamas commented on code in PR #907:
URL: https://github.com/apache/maven/pull/907#discussion_r1045528456
##
maven-core/src/main/java/org/apache/maven/internal/transformation/TransformedArtifact.java:
##
@@ -0,0 +1,146 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.maven.internal.transformation;
+
+import static java.util.Objects.requireNonNull;
+
+import java.io.BufferedInputStream;
+import java.io.File;
+import java.io.InputStream;
+import java.nio.file.Files;
+import java.nio.file.Path;
+import java.security.MessageDigest;
+import java.util.function.BiConsumer;
+import java.util.function.Supplier;
+import org.apache.maven.artifact.Artifact;
+import org.apache.maven.artifact.DefaultArtifact;
+import org.apache.maven.artifact.handler.ArtifactHandler;
+
+/**
+ * Transformed artifact is derived with some transformation from source
artifact.
+ *
+ * @since TBD
+ */
+public abstract class TransformedArtifact extends DefaultArtifact {
+
+private final OnChangeTransformer onChangeTransformer;
+
+public TransformedArtifact(
+Artifact source,
+Supplier sourcePathProvider,
+String classifier,
+String extension,
+Path targetPath,
+BiConsumer transformerConsumer) {
+super(
+source.getGroupId(),
+source.getArtifactId(),
+source.getVersionRange(),
+source.getScope(),
+extension,
+classifier,
+new TransformedArtifactHandler(
+classifier, extension,
source.getArtifactHandler().getPackaging()));
+this.onChangeTransformer =
+new OnChangeTransformer(sourcePathProvider, targetPath,
TransformedArtifact::sha1, transformerConsumer);
+}
+
+@Override
+public boolean isResolved() {
+return getFile() != null;
+}
+
+@Override
+public void setFile(File file) {
+throw new IllegalStateException("transformed artifact file cannot be
set");
+}
+
+@Override
+public File getFile() {
+Path result = onChangeTransformer.get();
+if (result == null) {
+return null;
+}
+return result.toFile();
+}
+
+private static final int BUFFER_SIZE = 8192;
+
+private static String sha1(Path path) {
+try {
+MessageDigest md = MessageDigest.getInstance("SHA-1");
+try (InputStream fis = new
BufferedInputStream(Files.newInputStream(path), BUFFER_SIZE)) {
Review Comment:
Um, I don't think so Files.newInputStream returns _unbuffered_ stream,
unless am mistaken...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Commented] (MNG-7622) Reimplement Consumer POM feature
[
https://issues.apache.org/jira/browse/MNG-7622?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17645965#comment-17645965
]
ASF GitHub Bot commented on MNG-7622:
-
gnodet commented on code in PR #907:
URL: https://github.com/apache/maven/pull/907#discussion_r1045525901
##
maven-core/src/main/java/org/apache/maven/internal/transformation/TransformedArtifact.java:
##
@@ -0,0 +1,146 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.maven.internal.transformation;
+
+import static java.util.Objects.requireNonNull;
+
+import java.io.BufferedInputStream;
+import java.io.File;
+import java.io.InputStream;
+import java.nio.file.Files;
+import java.nio.file.Path;
+import java.security.MessageDigest;
+import java.util.function.BiConsumer;
+import java.util.function.Supplier;
+import org.apache.maven.artifact.Artifact;
+import org.apache.maven.artifact.DefaultArtifact;
+import org.apache.maven.artifact.handler.ArtifactHandler;
+
+/**
+ * Transformed artifact is derived with some transformation from source
artifact.
+ *
+ * @since TBD
+ */
+public abstract class TransformedArtifact extends DefaultArtifact {
+
+private final OnChangeTransformer onChangeTransformer;
+
+public TransformedArtifact(
+Artifact source,
+Supplier sourcePathProvider,
+String classifier,
+String extension,
+Path targetPath,
+BiConsumer transformerConsumer) {
+super(
+source.getGroupId(),
+source.getArtifactId(),
+source.getVersionRange(),
+source.getScope(),
+extension,
+classifier,
+new TransformedArtifactHandler(
+classifier, extension,
source.getArtifactHandler().getPackaging()));
+this.onChangeTransformer =
+new OnChangeTransformer(sourcePathProvider, targetPath,
TransformedArtifact::sha1, transformerConsumer);
+}
+
+@Override
+public boolean isResolved() {
+return getFile() != null;
+}
+
+@Override
+public void setFile(File file) {
+throw new IllegalStateException("transformed artifact file cannot be
set");
+}
+
+@Override
+public File getFile() {
+Path result = onChangeTransformer.get();
+if (result == null) {
+return null;
+}
+return result.toFile();
+}
+
+private static final int BUFFER_SIZE = 8192;
+
+private static String sha1(Path path) {
+try {
+MessageDigest md = MessageDigest.getInstance("SHA-1");
+try (InputStream fis = new
BufferedInputStream(Files.newInputStream(path), BUFFER_SIZE)) {
Review Comment:
No need for a `BufferedInputStream` as the stream is already read using a
buffer.
> Reimplement Consumer POM feature
>
>
> Key: MNG-7622
> URL: https://issues.apache.org/jira/browse/MNG-7622
> Project: Maven
> Issue Type: Task
> Components: build/consumer
>Reporter: Tamas Cservenak
>Priority: Major
> Fix For: 4.0.x-candidate
>
>
> Current implementation relies on deprecated resolver API (is deprecated as it
> is OOM prone), and also renders use cases like m-gpg-p but also checksum-m-p
> broken.
> Reimplement consumer POM feature that:
> * does not use FileTransformer API
> * allows use cases like m-gpg-p
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[GitHub] [maven] gnodet commented on a diff in pull request #907: [MNG-7622] Maven Transformation and Consumer POM
gnodet commented on code in PR #907:
URL: https://github.com/apache/maven/pull/907#discussion_r1045525901
##
maven-core/src/main/java/org/apache/maven/internal/transformation/TransformedArtifact.java:
##
@@ -0,0 +1,146 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.maven.internal.transformation;
+
+import static java.util.Objects.requireNonNull;
+
+import java.io.BufferedInputStream;
+import java.io.File;
+import java.io.InputStream;
+import java.nio.file.Files;
+import java.nio.file.Path;
+import java.security.MessageDigest;
+import java.util.function.BiConsumer;
+import java.util.function.Supplier;
+import org.apache.maven.artifact.Artifact;
+import org.apache.maven.artifact.DefaultArtifact;
+import org.apache.maven.artifact.handler.ArtifactHandler;
+
+/**
+ * Transformed artifact is derived with some transformation from source
artifact.
+ *
+ * @since TBD
+ */
+public abstract class TransformedArtifact extends DefaultArtifact {
+
+private final OnChangeTransformer onChangeTransformer;
+
+public TransformedArtifact(
+Artifact source,
+Supplier sourcePathProvider,
+String classifier,
+String extension,
+Path targetPath,
+BiConsumer transformerConsumer) {
+super(
+source.getGroupId(),
+source.getArtifactId(),
+source.getVersionRange(),
+source.getScope(),
+extension,
+classifier,
+new TransformedArtifactHandler(
+classifier, extension,
source.getArtifactHandler().getPackaging()));
+this.onChangeTransformer =
+new OnChangeTransformer(sourcePathProvider, targetPath,
TransformedArtifact::sha1, transformerConsumer);
+}
+
+@Override
+public boolean isResolved() {
+return getFile() != null;
+}
+
+@Override
+public void setFile(File file) {
+throw new IllegalStateException("transformed artifact file cannot be
set");
+}
+
+@Override
+public File getFile() {
+Path result = onChangeTransformer.get();
+if (result == null) {
+return null;
+}
+return result.toFile();
+}
+
+private static final int BUFFER_SIZE = 8192;
+
+private static String sha1(Path path) {
+try {
+MessageDigest md = MessageDigest.getInstance("SHA-1");
+try (InputStream fis = new
BufferedInputStream(Files.newInputStream(path), BUFFER_SIZE)) {
Review Comment:
No need for a `BufferedInputStream` as the stream is already read using a
buffer.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Commented] (MNG-7456) Provide FileTransformer replacement within Maven
[ https://issues.apache.org/jira/browse/MNG-7456?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17645959#comment-17645959 ] ASF GitHub Bot commented on MNG-7456: - cstamas commented on PR #712: URL: https://github.com/apache/maven/pull/712#issuecomment-1346067858 Superseded by https://github.com/apache/maven/pull/907 > Provide FileTransformer replacement within Maven > > > Key: MNG-7456 > URL: https://issues.apache.org/jira/browse/MNG-7456 > Project: Maven > Issue Type: Task >Reporter: Tamas Cservenak >Priority: Major > Fix For: 4.0.0, 4.0.0-alpha-3 > > > As transforming "just in time" POM for consumer POM is not really Resolver > concern, that must get rid of current OOM-prone API. Maven should take care > of it by itself. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MNG-7456) Provide FileTransformer replacement within Maven
[ https://issues.apache.org/jira/browse/MNG-7456?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17645960#comment-17645960 ] ASF GitHub Bot commented on MNG-7456: - cstamas closed pull request #712: [MNG-7456] Provide FileTransformer API replacement in Maven URL: https://github.com/apache/maven/pull/712 > Provide FileTransformer replacement within Maven > > > Key: MNG-7456 > URL: https://issues.apache.org/jira/browse/MNG-7456 > Project: Maven > Issue Type: Task >Reporter: Tamas Cservenak >Priority: Major > Fix For: 4.0.0, 4.0.0-alpha-3 > > > As transforming "just in time" POM for consumer POM is not really Resolver > concern, that must get rid of current OOM-prone API. Maven should take care > of it by itself. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [maven] cstamas closed pull request #712: [MNG-7456] Provide FileTransformer API replacement in Maven
cstamas closed pull request #712: [MNG-7456] Provide FileTransformer API replacement in Maven URL: https://github.com/apache/maven/pull/712 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven] cstamas commented on pull request #712: [MNG-7456] Provide FileTransformer API replacement in Maven
cstamas commented on PR #712: URL: https://github.com/apache/maven/pull/712#issuecomment-1346067858 Superseded by https://github.com/apache/maven/pull/907 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (ARCHETYPE-634) WARNING: An illegal reflective access operation has occurred
Christophe Marchand created ARCHETYPE-634:
-
Summary: WARNING: An illegal reflective access operation has
occurred
Key: ARCHETYPE-634
URL: https://issues.apache.org/jira/browse/ARCHETYPE-634
Project: Maven Archetype
Issue Type: Improvement
Components: Plugin
Affects Versions: 3.2.1
Environment: MacOS / JDK11
Reporter: Christophe Marchand
Having an archetype with a {{archetype-post-generate.groovy}} file inside, when
generating a new project with JDK11, I get a WARNING :
{{[*INFO*] Executing META-INF/archetype-post-generate.groovy post-generation
script}}
{{WARNING: An illegal reflective access operation has occurred}}
{{WARNING: Illegal reflective access by
org.codehaus.groovy.reflection.CachedClass
(file:.../.m2/repository/org/codehaus/groovy/groovy-all/2.4.16/groovy-all-2.4.16.jar)
to method java.lang.Object.finalize()}}
{{WARNING: Please consider reporting this to the maintainers of
org.codehaus.groovy.reflection.CachedClass}}
{{{}WARNING: Use --illegal-access=warn to enable warnings of further illegal
reflective access operations{}}}{{{}WARNING: All illegal access operations will
be denied in a future release{}}}
{{Components :}}
{{08:50 $ mvn -version}}
{{Apache Maven 3.8.4 (9b656c72d54e5bacbed989b64718c159fe39b537)}}
{{Maven home: /Users/cmarchand/applications/apache-maven-3.8.4}}
{{{}Java version: 11.0.4, vendor: AdoptOpenJDK,
runtime:{}}}{{{}/Library/Java/JavaVirtualMachines/adoptopenjdk-11.jdk/Contents/Home{}}}
{{Default locale: fr_FR, platform encoding: UTF-8}}
{{OS name: "mac os x", version: "10.16", arch: "x86_64", family: "mac"}}
{{08:51 $ java -version}}
{{openjdk version "11.0.4" 2019-07-16}}
{{OpenJDK Runtime Environment AdoptOpenJDK (build 11.0.4+11)}}
{{OpenJDK 64-Bit Server VM AdoptOpenJDK (build 11.0.4+11, mixed mode)}}
{{Problem comes probably from groovy-all dependency, which is quite old
(2.4.16), and should be upgraded to a more recent one (4.0.6 is available)}}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[GitHub] [maven-integration-testing] gnodet merged pull request #218: Disable tests on maven >= 4.0.0-alpha-3
gnodet merged PR #218: URL: https://github.com/apache/maven-integration-testing/pull/218 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
