[jira] [Closed] (SUREFIRE-2063) Adding argLine with tab characters fails
[
https://issues.apache.org/jira/browse/SUREFIRE-2063?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Osipov closed SUREFIRE-2063.
> Adding argLine with tab characters fails
>
>
> Key: SUREFIRE-2063
> URL: https://issues.apache.org/jira/browse/SUREFIRE-2063
> Project: Maven Surefire
> Issue Type: Bug
>Affects Versions: 3.0.0-M6
>Reporter: Daniel Subelman
>Assignee: Maarten Mulders
>Priority: Blocker
> Fix For: 3.0.0-M7
>
>
> Since v3.3.0-M6 fails when using to export or open a package. The
> failure is produced when using --add-opens or --add-exports in .
> The execution doesn't fail with v3.3.0-M5 or earlier.
> As an example, it fails when using the following :
> {code:java}
>
> --add-opens
> org.junit.platform.commons/org.junit.platform.commons.util=ALL-UNNAMED
> --add-opens
> org.junit.platform.commons/org.junit.platform.commons.logging=ALL-UNNAMED
>
> {code}
> The failure log:
> {code:java}
> [INFO] --- maven-surefire-plugin:3.0.0-M6:test (dev) @ testing ---
> [INFO] Using auto detected provider
> org.apache.maven.surefire.junitplatform.JUnitPlatformProvider
> [INFO]
> [INFO] ---
> [INFO] T E S T S
> [INFO] ---
> WARNING: Unknown module: org.junit.platform.commons specified to --add-opens
> Error: Could not find or load main class --add-opens
> Caused by: java.lang.ClassNotFoundException: --add-opens
> [INFO]
> [INFO] Results:
> [INFO]
> [INFO] Tests run: 0, Failures: 0, Errors: 0, Skipped: 0
> [INFO]
> [INFO]
>
> [INFO] BUILD FAILURE
> [INFO]
>
> [INFO] Total time: 9.157 s
> [INFO] Finished at: 2022-04-06T16:28:23-04:00
> [INFO]
>
> [ERROR] Failed to execute goal
> org.apache.maven.plugins:maven-surefire-plugin:3.0.0-M6:test (dev) on project
> testing:
> {code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Updated] (MDEP-832) Remove commons-collections-4
[
https://issues.apache.org/jira/browse/MDEP-832?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Osipov updated MDEP-832:
Fix Version/s: (was: version-next)
> Remove commons-collections-4
>
>
> Key: MDEP-832
> URL: https://issues.apache.org/jira/browse/MDEP-832
> Project: Maven Dependency Plugin
> Issue Type: Improvement
>Affects Versions: 3.3.0
>Reporter: Karl Heinz Marbaise
>Assignee: Karl Heinz Marbaise
>Priority: Minor
>
> Remove the dependency:
> {code:xml}
>
> org.apache.commons
> commons-collections4
> 4.2
>
> {code}
> which is used only for a single method.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Closed] (MDEP-841) Explicitly start and end tables with Doxia Sinks in report renderers
[ https://issues.apache.org/jira/browse/MDEP-841?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov closed MDEP-841. --- Resolution: Fixed Fixed with [4b478d61e1e78f5bddda6d1256f91c357c2561a4|https://gitbox.apache.org/repos/asf?p=maven-dependency-plugin.git;a=commit;h=4b478d61e1e78f5bddda6d1256f91c357c2561a4]. > Explicitly start and end tables with Doxia Sinks in report renderers > > > Key: MDEP-841 > URL: https://issues.apache.org/jira/browse/MDEP-841 > Project: Maven Dependency Plugin > Issue Type: Task >Affects Versions: 3.4.0 >Reporter: Michael Osipov >Assignee: Michael Osipov >Priority: Major > Fix For: version-next > > > In preperation for Doxia 2.0.0 we need to address this old style approach. > See > https://cwiki.apache.org/confluence/display/MAVEN/Towards+Doxia+2.0.0+Stack > for details. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Moved] (MDEP-841) Explicitly start and end tables with Doxia Sinks in report renderers
[ https://issues.apache.org/jira/browse/MDEP-841?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov moved MCHECKSTYLE-424 to MDEP-841: - Fix Version/s: version-next (was: 3.2.1) Key: MDEP-841 (was: MCHECKSTYLE-424) Affects Version/s: 3.4.0 (was: 3.2.0) Project: Maven Dependency Plugin (was: Maven Checkstyle Plugin) > Explicitly start and end tables with Doxia Sinks in report renderers > > > Key: MDEP-841 > URL: https://issues.apache.org/jira/browse/MDEP-841 > Project: Maven Dependency Plugin > Issue Type: Task >Affects Versions: 3.4.0 >Reporter: Michael Osipov >Assignee: Michael Osipov >Priority: Major > Fix For: version-next > > > In preperation for Doxia 2.0.0 we need to address this old style approach. > See > https://cwiki.apache.org/confluence/display/MAVEN/Towards+Doxia+2.0.0+Stack > for details. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (MCHECKSTYLE-424) Explicitly start and end tables with Doxia Sinks in report renderers
Michael Osipov created MCHECKSTYLE-424: -- Summary: Explicitly start and end tables with Doxia Sinks in report renderers Key: MCHECKSTYLE-424 URL: https://issues.apache.org/jira/browse/MCHECKSTYLE-424 Project: Maven Checkstyle Plugin Issue Type: Task Affects Versions: 3.2.0 Reporter: Michael Osipov Assignee: Michael Osipov Fix For: 3.2.1 In preperation for Doxia 2.0.0 we need to address this old style approach. See https://cwiki.apache.org/confluence/display/MAVEN/Towards+Doxia+2.0.0+Stack for details. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Closed] (MCHECKSTYLE-423) Explicitly start and end tables with Doxia Sinks in report renderers
[ https://issues.apache.org/jira/browse/MCHECKSTYLE-423?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov closed MCHECKSTYLE-423. -- Resolution: Fixed Fixed with [932c8bcd8953e3634cf8b409e276575c0ad60d3a|https://gitbox.apache.org/repos/asf?p=maven-checkstyle-plugin.git;a=commit;h=932c8bcd8953e3634cf8b409e276575c0ad60d3a]. > Explicitly start and end tables with Doxia Sinks in report renderers > > > Key: MCHECKSTYLE-423 > URL: https://issues.apache.org/jira/browse/MCHECKSTYLE-423 > Project: Maven Checkstyle Plugin > Issue Type: Task >Affects Versions: 3.2.0 >Reporter: Michael Osipov >Assignee: Michael Osipov >Priority: Major > Fix For: 3.2.1 > > > In preperation for Doxia 2.0.0 we need to address this old style approach. > See > https://cwiki.apache.org/confluence/display/MAVEN/Towards+Doxia+2.0.0+Stack > for details. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Moved] (MCHECKSTYLE-423) Explicitly start and end tables with Doxia Sinks in report renderers
[ https://issues.apache.org/jira/browse/MCHECKSTYLE-423?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov moved MPMD-362 to MCHECKSTYLE-423: - Fix Version/s: 3.2.1 (was: 3.20.0) Key: MCHECKSTYLE-423 (was: MPMD-362) Affects Version/s: 3.2.0 (was: 3.19.0) Project: Maven Checkstyle Plugin (was: Maven PMD Plugin) > Explicitly start and end tables with Doxia Sinks in report renderers > > > Key: MCHECKSTYLE-423 > URL: https://issues.apache.org/jira/browse/MCHECKSTYLE-423 > Project: Maven Checkstyle Plugin > Issue Type: Task >Affects Versions: 3.2.0 >Reporter: Michael Osipov >Assignee: Michael Osipov >Priority: Major > Fix For: 3.2.1 > > > In preperation for Doxia 2.0.0 we need to address this old style approach. > See > https://cwiki.apache.org/confluence/display/MAVEN/Towards+Doxia+2.0.0+Stack > for details. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (MPMD-362) Explicitly start and end tables with Doxia Sinks in report renderers
Michael Osipov created MPMD-362: --- Summary: Explicitly start and end tables with Doxia Sinks in report renderers Key: MPMD-362 URL: https://issues.apache.org/jira/browse/MPMD-362 Project: Maven PMD Plugin Issue Type: Task Affects Versions: 3.19.0 Reporter: Michael Osipov Assignee: Michael Osipov Fix For: 3.20.0 In preperation for Doxia 2.0.0 we need to address this old style approach. See https://cwiki.apache.org/confluence/display/MAVEN/Towards+Doxia+2.0.0+Stack for details. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Closed] (MCHECKSTYLE-398) suppressions inside JAR, non-absolute path, cannot be found
[
https://issues.apache.org/jira/browse/MCHECKSTYLE-398?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Osipov closed MCHECKSTYLE-398.
--
Fix Version/s: (was: waiting-for-feedback)
Resolution: Incomplete
No confirmation received.
> suppressions inside JAR, non-absolute path, cannot be found
> ---
>
> Key: MCHECKSTYLE-398
> URL: https://issues.apache.org/jira/browse/MCHECKSTYLE-398
> Project: Maven Checkstyle Plugin
> Issue Type: Bug
> Components: checkstyle:checkstyle
>Affects Versions: 3.1.1
>Reporter: CHAN Shih-Ping
>Priority: Major
>
> When the configuration file and suppressions XML file are inside a JAR, then
> if the configuration file references the suppressions file with a
> non-absolute path, the suppressions file cannot be located.
>
> wildfly-checkstyle-config:1.0.8.Final is a plugin dependency of
> maven-checkstyle-plugin:3.1.1, containing both
> {{wildfly-checkstyle/checkstyle.xml}} and
> {{wildfly-checkstyle/suppressions.xml
>
> {code:java}
> # inside checkstyle.xml we reference suppressions.xml with a absolute path
> # this doesn't work if the path is changed to non-absolute
> # wildfly-checkstyle/suppressions.xml, but both absolute/non-absolute
> reference
> # work in checkstyle-all.jar
>
>
> {code}
> The configuration file is {{wildfly-checkstyle/checkstyle.xml}} inside the
> JAR.
> Standard Maven project:
> {code:xml}
>
> org.apache.maven.plugins
> maven-checkstyle-plugin
> 3.1.1
>
> wildfly-checkstyle/checkstyle.xml
> true
>
> ${project.build.sourceDirectory}
>
> **/*.properties,**/*.xml
> true
> true
> true
> true
> true
> samedir=/wildfly-checkstyle/
>
>
>
> org.wildfly.checkstyle
> wildfly-checkstyle-config
> 1.0.8.Final
>
>
> com.puppycrawl.tools
> checkstyle
> 8.36.2
>
>
> {code}
> This configuraton works but if the reference to suppressions is non-absolute:
> {{wildfly-checkstyle/suppressions.xml}}, then
> {code:java}
> Caused by: com.puppycrawl.tools.checkstyle.api.CheckstyleException: cannot
> initialize module SuppressionFilter - Unable to find:
> wildfly-checkstyle/suppressions.xml
> at com.puppycrawl.tools.checkstyle.Checker.setupChild (Checker.java:482)
> at com.puppycrawl.tools.checkstyle.api.AutomaticBean.configure
> (AutomaticBean.java:201)
> at
> org.apache.maven.plugins.checkstyle.exec.DefaultCheckstyleExecutor.executeCheckstyle
> (DefaultCheckstyleExecutor.java:168)
> at
> org.apache.maven.plugins.checkstyle.AbstractCheckstyleReport.executeReport
> (AbstractCheckstyleReport.java:533)
> at org.apache.maven.plugins.checkstyle.CheckstyleReport.executeReport
> (CheckstyleReport.java:57)
> at org.apache.maven.reporting.AbstractMavenReport.generate
> (AbstractMavenReport.java:255)
> at org.apache.maven.reporting.AbstractMavenReport.execute
> (AbstractMavenReport.java:143)
> at org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo
> (DefaultBuildPluginManager.java:137)
> at org.apache.maven.lifecycle.internal.MojoExecutor.execute
> (MojoExecutor.java:210)
> {code}
> Using checkstyle-8.36.2-all.jar on the command line works whether the path
> reference has the leading {{'/'}} or not.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Closed] (MCHECKSTYLE-416) Release Version 3.2 on Master
[ https://issues.apache.org/jira/browse/MCHECKSTYLE-416?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov closed MCHECKSTYLE-416. -- Resolution: Done > Release Version 3.2 on Master > - > > Key: MCHECKSTYLE-416 > URL: https://issues.apache.org/jira/browse/MCHECKSTYLE-416 > Project: Maven Checkstyle Plugin > Issue Type: Wish >Reporter: James >Priority: Minor > > Hi! Sorry for the ticket, please do feel free to resolve this immediately if > it's not appropriate here (I couldn't work out another way to ask this > question other than via Jira). > We see that 3.2-SNAPSHOT is sat there on master. That uses version 9.3 of > the Checkstyle library which appears to contain Java 17 support. > We're wondering when 3.2 will be released (along with the Java 17 support > we're looking for)? Is there a rough estimate for that or it's impossible to > know at this point? > We can always work around it using > [https://maven.apache.org/plugins/maven-checkstyle-plugin/examples/upgrading-checkstyle.html] > but we'd like to stay on a default configuration if we can hence this > request/question. Getting a feeling for the release date allows us to plan > appropriately. > Really appreciate any guidance/information you have here and please do feel > free to resolve this ticket immediately if it's not appropriate. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Closed] (MPMD-361) Explicitly start and end tables with Doxia Sinks in report renderers
[ https://issues.apache.org/jira/browse/MPMD-361?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov closed MPMD-361. --- Resolution: Fixed Fixed with [f3e188aed9812c38655b7c42ae5620f1d18705ab|https://gitbox.apache.org/repos/asf?p=maven-pmd-plugin.git;a=commit;h=f3e188aed9812c38655b7c42ae5620f1d18705ab]. > Explicitly start and end tables with Doxia Sinks in report renderers > > > Key: MPMD-361 > URL: https://issues.apache.org/jira/browse/MPMD-361 > Project: Maven PMD Plugin > Issue Type: Task >Affects Versions: 3.19.0 >Reporter: Michael Osipov >Assignee: Michael Osipov >Priority: Major > Fix For: 3.20.0 > > > In preperation for Doxia 2.0.0 we need to address this old style approach. > See > https://cwiki.apache.org/confluence/display/MAVEN/Towards+Doxia+2.0.0+Stack > for details. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Closed] (MENFORCER-457) Bump assertj-core from 3.23.1 to 3.24.0
[ https://issues.apache.org/jira/browse/MENFORCER-457?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Slawomir Jaranowski closed MENFORCER-457. - Resolution: Fixed > Bump assertj-core from 3.23.1 to 3.24.0 > --- > > Key: MENFORCER-457 > URL: https://issues.apache.org/jira/browse/MENFORCER-457 > Project: Maven Enforcer Plugin > Issue Type: Dependency upgrade >Reporter: Slawomir Jaranowski >Assignee: Slawomir Jaranowski >Priority: Major > Fix For: 3.2.0 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (MPIR-428) Explicitly start and end tables with Doxia Sinks in report renderers
Michael Osipov created MPIR-428: --- Summary: Explicitly start and end tables with Doxia Sinks in report renderers Key: MPIR-428 URL: https://issues.apache.org/jira/browse/MPIR-428 Project: Maven Project Info Reports Plugin Issue Type: Task Affects Versions: 3.4.1 Reporter: Michael Osipov Assignee: Michael Osipov Fix For: 3.4.2 In preperation for Doxia 2.0.0 we need to address this old style approach. See https://cwiki.apache.org/confluence/display/MAVEN/Towards+Doxia+2.0.0+Stack for details. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Moved] (MPMD-361) Explicitly start and end tables with Doxia Sinks in report renderers
[ https://issues.apache.org/jira/browse/MPMD-361?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov moved MPIR-428 to MPMD-361: -- Fix Version/s: 3.20.0 (was: 3.4.2) Key: MPMD-361 (was: MPIR-428) Affects Version/s: 3.19.0 (was: 3.4.1) Project: Maven PMD Plugin (was: Maven Project Info Reports Plugin) > Explicitly start and end tables with Doxia Sinks in report renderers > > > Key: MPMD-361 > URL: https://issues.apache.org/jira/browse/MPMD-361 > Project: Maven PMD Plugin > Issue Type: Task >Affects Versions: 3.19.0 >Reporter: Michael Osipov >Assignee: Michael Osipov >Priority: Major > Fix For: 3.20.0 > > > In preperation for Doxia 2.0.0 we need to address this old style approach. > See > https://cwiki.apache.org/confluence/display/MAVEN/Towards+Doxia+2.0.0+Stack > for details. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MPLUGIN-446) ERROR during build of m-plugin-report-p and m-plugin-p: Dependencies in wrong scope
[
https://issues.apache.org/jira/browse/MPLUGIN-446?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17655585#comment-17655585
]
Michael Osipov commented on MPLUGIN-446:
PR merged, but issue still unassigned and open...
> ERROR during build of m-plugin-report-p and m-plugin-p: Dependencies in wrong
> scope
> ---
>
> Key: MPLUGIN-446
> URL: https://issues.apache.org/jira/browse/MPLUGIN-446
> Project: Maven Plugin Tools
> Issue Type: Bug
>Reporter: Konrad Windszus
>Priority: Major
> Fix For: 3.8.0
>
>
> The following errors can be observed during the build of the current master
> since MPLUGIN-441
> {code}
> [INFO] --- maven-plugin-plugin:3.6.4:descriptor (default-descriptor) @
> maven-plugin-plugin ---
> [ERROR]
> Some dependencies of Maven Plugins are expected to be in provided scope.
> Please make sure that dependencies listed below declared in POM
> have set 'provided' as well.
> The following dependencies are in wrong scope:
> * org.apache.maven:plexus-utils:jar:4.0.0-alpha-2:compile
> [INFO] Using 'UTF-8' encoding to read mojo source files.
> [INFO] java-annotations mojo extractor found 5 mojo descriptors.
> {code}
> This is emitted 4 times (for both goals descriptor and help-mojo in modules
> m-plugin-report-p and m-plugin-p).
> In addition {{plexus-utils}} is now twice in the dependency hierarchy:
> - Directly referenced with group id {{o.a.m}}
> - Transitively referenced with group id {{org.codehaus.plexus}}, e.g. from
> {{maven-core}}.
> As they cannot really coexist in the same classloader (as both export at
> least partially the same package names) only one version should ever be
> used
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[GitHub] [maven-enforcer] slawekjaranowski merged pull request #219: [MENFORCER-457] Bump assertj-core from 3.23.1 to 3.24.0
slawekjaranowski merged PR #219: URL: https://github.com/apache/maven-enforcer/pull/219 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (MENFORCER-457) Bump assertj-core from 3.23.1 to 3.24.0
Slawomir Jaranowski created MENFORCER-457: - Summary: Bump assertj-core from 3.23.1 to 3.24.0 Key: MENFORCER-457 URL: https://issues.apache.org/jira/browse/MENFORCER-457 Project: Maven Enforcer Plugin Issue Type: Dependency upgrade Reporter: Slawomir Jaranowski Assignee: Slawomir Jaranowski Fix For: 3.2.0 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [maven-enforcer] slawekjaranowski opened a new pull request, #220: [MENFORCER-456] New Enforcer API - RuleConfigProvider
slawekjaranowski opened a new pull request, #220: URL: https://github.com/apache/maven-enforcer/pull/220 Following this checklist to help us incorporate your contribution quickly and easily: - [x] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/MENFORCER) filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes. - [x] Each commit in the pull request should have a meaningful subject line and body. - [x] Format the pull request title like `[MENFORCER-XXX] - Fixes bug in ApproximateQuantiles`, where you replace `MENFORCER-XXX` with the appropriate JIRA issue. Best practice is to use the JIRA issue title in the pull request title and in the first line of the commit message. - [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [x] Run `mvn clean verify` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically. - [x] You have run the integration tests successfully (`mvn -Prun-its clean verify`). If your pull request is about ~20 lines of code you don't need to sign an [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure please ask on the developers list. To make clear that you license your contribution under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) you have to acknowledge this by using the following check-box. - [x] I hereby declare this contribution to be licenced under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) - [x] In any other case, please file an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-project-info-reports-plugin] dependabot[bot] opened a new pull request, #44: Bump bcel from 6.5.0 to 6.6.0
dependabot[bot] opened a new pull request, #44: URL: https://github.com/apache/maven-project-info-reports-plugin/pull/44 Bumps bcel from 6.5.0 to 6.6.0. [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) - `@dependabot use these labels` will set the current labels as the default for future PRs for this repo and language - `@dependabot use these reviewers` will set the current reviewers as the default for future PRs for this repo and language - `@dependabot use these assignees` will set the current assignees as the default for future PRs for this repo and language - `@dependabot use this milestone` will set the current milestone as the default for future PRs for this repo and language You can disable automated security fix PRs for this repo from the [Security Alerts page](https://github.com/apache/maven-project-info-reports-plugin/network/alerts). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Closed] (MPIR-425) Verbatim content should be rendered as plain text
[ https://issues.apache.org/jira/browse/MPIR-425?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov closed MPIR-425. --- Resolution: Fixed Fixed with [dee3a29c0248c497a9229043490b70cac17b8c12|https://gitbox.apache.org/repos/asf?p=maven-project-info-reports-plugin.git;a=commit;h=dee3a29c0248c497a9229043490b70cac17b8c12]. > Verbatim content should be rendered as plain text > - > > Key: MPIR-425 > URL: https://issues.apache.org/jira/browse/MPIR-425 > Project: Maven Project Info Reports Plugin > Issue Type: Bug > Components: ci-management, dependency-info, issue-management, > licenses, scm >Reporter: Slawomir Jaranowski >Assignee: Michael Osipov >Priority: Major > Fix For: 3.4.2 > > Attachments: Screenshot 2022-12-03 at 10.24.48.png, Screenshot > 2022-12-03 at 10.25.17.png > > > When license is imported from text files additional parsing is not needed. > Now we have a colorized some of items. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Comment Edited] (MJAVADOC-720) sourcepath does not work with aggregate goal
[
https://issues.apache.org/jira/browse/MJAVADOC-720?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17655575#comment-17655575
]
Oliver Drotbohm edited comment on MJAVADOC-720 at 1/6/23 8:55 PM:
--
I'm facing the same problem, as soon as you configure a {{sourcepath}} (e.g. as
described for delomboked sources), the root project does not aggregate the
Javadoc anymore but is apparently skipped as that source path does not exist
for the root POM. This completely breaks Javadoc aggregation for projects using
Lombok. I think the severity of this one should be raised.
To me, the decision table described
[here|https://github.com/apache/maven-javadoc-plugin/blob/fabff9c1ed15007f11d1644e445d766ea9e63c5d/src/main/java/org/apache/maven/plugins/javadoc/JavadocReport.java#L180-L238]
does not make sense for the multi-module case. In that, an aggregation
execution on a root project will – by definition – not find any source (as it's
a POM module) and thus, according to the table (row 3) will not get a report
generated. That looks obviously false to me, but I might be missing something
here.
[{{AbstractJavadocMojo.getSourcePaths()}}|https://github.com/apache/maven-javadoc-plugin/blob/fabff9c1ed15007f11d1644e445d766ea9e63c5d/src/main/java/org/apache/maven/plugins/javadoc/AbstractJavadocMojo.java#L2201]
at least seems to confirm my suspicion that the project's modules are only
inspected if no {{sourcepath}} is configured (first if-clause). The {{if
(isAggregator())}} clause then only uses the individual modules' source roots
not allowing any customizations.
This definitely seems to be a bug as it's at least inconsistent: I can either
tweak the sourcepath for all my modules (which I'd want) *or* can aggregate
Javadoc, but not both (which I'd want).
was (Author: oliver.gierke):
I'm facing the same problem, as soon as you configure a {{sourcepath}} (e.g. as
described for delomboked sources), the root project does not aggregate the
Javadoc anymore but is apparently skipped as that source path does not exist
for the root POM. This completely breaks Javadoc aggregation for projects using
Lombok. I think the severity of this one should be raised.
To me, the decision table described
[here|https://github.com/apache/maven-javadoc-plugin/blob/fabff9c1ed15007f11d1644e445d766ea9e63c5d/src/main/java/org/apache/maven/plugins/javadoc/JavadocReport.java#L180-L238]
does not make sense for the multi-module case. In that, an aggregation
execution on a root project will – by definition – not find any source (as it's
a POM module) and thus, according to the table (row 3) will not get a report
generated. That looks obviously false to me, but I might be missing something
here.
> sourcepath does not work with aggregate goal
>
>
> Key: MJAVADOC-720
> URL: https://issues.apache.org/jira/browse/MJAVADOC-720
> Project: Maven Javadoc Plugin
> Issue Type: Improvement
> Components: javadoc
>Affects Versions: 3.3.2
>Reporter: Christoph Schulz
>Priority: Minor
>
> In our project we use lombok.
> For the JavaDocs we delombok the sources using the Lombok plugin and add the
> output directory ({{${project.build.directory}/generated-source/delombok}})
> to the {{sourcepath}} option.
> This works fine for the non-aggregated reports, but it does not work for the
> aggregated report, with the sourcepath configured the report simply never
> executes (no {{Generating "Javadoc" report ---
> maven-javadoc-plugin:3.3.2:aggregate-no-fork}}).
> Is this a know issue? Otherwise I can provide a project to reproduce this.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Updated] (MPIR-425) Verbatim content should be rendered as plain text
[ https://issues.apache.org/jira/browse/MPIR-425?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov updated MPIR-425: Component/s: ci-management dependency-info issue-management scm > Verbatim content should be rendered as plain text > - > > Key: MPIR-425 > URL: https://issues.apache.org/jira/browse/MPIR-425 > Project: Maven Project Info Reports Plugin > Issue Type: Bug > Components: ci-management, dependency-info, issue-management, > licenses, scm >Reporter: Slawomir Jaranowski >Assignee: Michael Osipov >Priority: Major > Fix For: 3.4.2 > > Attachments: Screenshot 2022-12-03 at 10.24.48.png, Screenshot > 2022-12-03 at 10.25.17.png > > > When license is imported from text files additional parsing is not needed. > Now we have a colorized some of items. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (MPIR-425) Verbatim content should be rendered as plain text
[ https://issues.apache.org/jira/browse/MPIR-425?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov updated MPIR-425: Summary: Verbatim content should be rendered as plain text (was: License from text resource should be included as plain text) > Verbatim content should be rendered as plain text > - > > Key: MPIR-425 > URL: https://issues.apache.org/jira/browse/MPIR-425 > Project: Maven Project Info Reports Plugin > Issue Type: Improvement > Components: licenses >Reporter: Slawomir Jaranowski >Assignee: Michael Osipov >Priority: Major > Fix For: 3.4.2 > > Attachments: Screenshot 2022-12-03 at 10.24.48.png, Screenshot > 2022-12-03 at 10.25.17.png > > > When license is imported from text files additional parsing is not needed. > Now we have a colorized some of items. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (MPIR-425) License from text resource should be included as plain text
[ https://issues.apache.org/jira/browse/MPIR-425?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov updated MPIR-425: Fix Version/s: 3.4.2 > License from text resource should be included as plain text > --- > > Key: MPIR-425 > URL: https://issues.apache.org/jira/browse/MPIR-425 > Project: Maven Project Info Reports Plugin > Issue Type: Improvement > Components: licenses >Reporter: Slawomir Jaranowski >Assignee: Michael Osipov >Priority: Major > Fix For: 3.4.2 > > Attachments: Screenshot 2022-12-03 at 10.24.48.png, Screenshot > 2022-12-03 at 10.25.17.png > > > When license is imported from text files additional parsing is not needed. > Now we have a colorized some of items. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Comment Edited] (MJAVADOC-720) sourcepath does not work with aggregate goal
[
https://issues.apache.org/jira/browse/MJAVADOC-720?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17655575#comment-17655575
]
Oliver Drotbohm edited comment on MJAVADOC-720 at 1/6/23 8:48 PM:
--
I'm facing the same problem, as soon as you configure a {{sourcepath}} (e.g. as
described for delomboked sources), the root project does not aggregate the
Javadoc anymore but is apparently skipped as that source path does not exist
for the root POM. This completely breaks Javadoc aggregation for projects using
Lombok. I think the severity of this one should be raised.
To me, the decision table described
[here|https://github.com/apache/maven-javadoc-plugin/blob/fabff9c1ed15007f11d1644e445d766ea9e63c5d/src/main/java/org/apache/maven/plugins/javadoc/JavadocReport.java#L180-L238]
does not make sense for the multi-module case. In that, an aggregation
execution on a root project will – by definition – not find any source (as it's
a POM module) and thus, according to the table (row 3) will not get a report
generated. That looks obviously false to me, but I might be missing something
here.
was (Author: oliver.gierke):
I'm facing the same problem, as soon as you configure a {{sourcepath}} (e.g. as
described for delomboked sources), the root project does not aggregate the
Javadoc anymore but is apparently skipped as that source path does not exist
for the root POM. This completely breaks Javadoc aggregation for projects using
Lombok. I think the severity of this one should be raised.
> sourcepath does not work with aggregate goal
>
>
> Key: MJAVADOC-720
> URL: https://issues.apache.org/jira/browse/MJAVADOC-720
> Project: Maven Javadoc Plugin
> Issue Type: Improvement
> Components: javadoc
>Affects Versions: 3.3.2
>Reporter: Christoph Schulz
>Priority: Minor
>
> In our project we use lombok.
> For the JavaDocs we delombok the sources using the Lombok plugin and add the
> output directory ({{${project.build.directory}/generated-source/delombok}})
> to the {{sourcepath}} option.
> This works fine for the non-aggregated reports, but it does not work for the
> aggregated report, with the sourcepath configured the report simply never
> executes (no {{Generating "Javadoc" report ---
> maven-javadoc-plugin:3.3.2:aggregate-no-fork}}).
> Is this a know issue? Otherwise I can provide a project to reproduce this.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Updated] (MPIR-425) Verbatim content should be rendered as plain text
[ https://issues.apache.org/jira/browse/MPIR-425?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov updated MPIR-425: Issue Type: Bug (was: Improvement) > Verbatim content should be rendered as plain text > - > > Key: MPIR-425 > URL: https://issues.apache.org/jira/browse/MPIR-425 > Project: Maven Project Info Reports Plugin > Issue Type: Bug > Components: licenses >Reporter: Slawomir Jaranowski >Assignee: Michael Osipov >Priority: Major > Fix For: 3.4.2 > > Attachments: Screenshot 2022-12-03 at 10.24.48.png, Screenshot > 2022-12-03 at 10.25.17.png > > > When license is imported from text files additional parsing is not needed. > Now we have a colorized some of items. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MPIR-425) License from text resource should be included as plain text
[ https://issues.apache.org/jira/browse/MPIR-425?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17655579#comment-17655579 ] Michael Osipov commented on MPIR-425: - This is so fucked up in Doxia and Maven Reporting Impl that I need to implement a temporary workaround in this plugin until upsteam issues are resolved. > License from text resource should be included as plain text > --- > > Key: MPIR-425 > URL: https://issues.apache.org/jira/browse/MPIR-425 > Project: Maven Project Info Reports Plugin > Issue Type: Improvement > Components: licenses >Reporter: Slawomir Jaranowski >Assignee: Michael Osipov >Priority: Major > Attachments: Screenshot 2022-12-03 at 10.24.48.png, Screenshot > 2022-12-03 at 10.25.17.png > > > When license is imported from text files additional parsing is not needed. > Now we have a colorized some of items. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MJAVADOC-720) sourcepath does not work with aggregate goal
[
https://issues.apache.org/jira/browse/MJAVADOC-720?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17655575#comment-17655575
]
Oliver Drotbohm commented on MJAVADOC-720:
--
I'm facing the same problem, as soon as you configure a {{sourcepath}} (e.g. as
described for delomboked sources), the root project does not aggregate the
Javadoc anymore but is apparently skipped as that source path does not exist
for the root POM. This completely breaks Javadoc aggregation for projects using
Lombok. I think the severity of this one should be raised.
> sourcepath does not work with aggregate goal
>
>
> Key: MJAVADOC-720
> URL: https://issues.apache.org/jira/browse/MJAVADOC-720
> Project: Maven Javadoc Plugin
> Issue Type: Improvement
> Components: javadoc
>Affects Versions: 3.3.2
>Reporter: Christoph Schulz
>Priority: Minor
>
> In our project we use lombok.
> For the JavaDocs we delombok the sources using the Lombok plugin and add the
> output directory ({{${project.build.directory}/generated-source/delombok}})
> to the {{sourcepath}} option.
> This works fine for the non-aggregated reports, but it does not work for the
> aggregated report, with the sourcepath configured the report simply never
> executes (no {{Generating "Javadoc" report ---
> maven-javadoc-plugin:3.3.2:aggregate-no-fork}}).
> Is this a know issue? Otherwise I can provide a project to reproduce this.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Closed] (MPIR-427) Explicitly start and end tables with Doxia Sinks in report renderers
[ https://issues.apache.org/jira/browse/MPIR-427?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov closed MPIR-427. --- Resolution: Fixed Fixed with [88f2f7690059d71bc4def3a3e4db0bad0cae3e80|https://gitbox.apache.org/repos/asf?p=maven-project-info-reports-plugin.git;a=commit;h=88f2f7690059d71bc4def3a3e4db0bad0cae3e80]. > Explicitly start and end tables with Doxia Sinks in report renderers > > > Key: MPIR-427 > URL: https://issues.apache.org/jira/browse/MPIR-427 > Project: Maven Project Info Reports Plugin > Issue Type: Task >Affects Versions: 3.4.1 >Reporter: Michael Osipov >Assignee: Michael Osipov >Priority: Major > Fix For: 3.4.2 > > > In preperation for Doxia 2.0.0 we need to address this old style approach. > See > https://cwiki.apache.org/confluence/display/MAVEN/Towards+Doxia+2.0.0+Stack > for details. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (MPIR-427) Explicitly start and end tables with Doxia Sinks
[ https://issues.apache.org/jira/browse/MPIR-427?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov updated MPIR-427: Summary: Explicitly start and end tables with Doxia Sinks (was: Explicitly stand and end tables with Doxia Sinks) > Explicitly start and end tables with Doxia Sinks > > > Key: MPIR-427 > URL: https://issues.apache.org/jira/browse/MPIR-427 > Project: Maven Project Info Reports Plugin > Issue Type: Task >Affects Versions: 3.4.1 >Reporter: Michael Osipov >Assignee: Michael Osipov >Priority: Major > Fix For: 3.4.2 > > > In preperation for Doxia 2.0.0 we need to address this old style approach. > See > https://cwiki.apache.org/confluence/display/MAVEN/Towards+Doxia+2.0.0+Stack > for details. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (MPIR-427) Explicitly start and end tables with Doxia Sinks in report renderers
[ https://issues.apache.org/jira/browse/MPIR-427?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov updated MPIR-427: Summary: Explicitly start and end tables with Doxia Sinks in report renderers (was: Explicitly start and end tables with Doxia Sinks) > Explicitly start and end tables with Doxia Sinks in report renderers > > > Key: MPIR-427 > URL: https://issues.apache.org/jira/browse/MPIR-427 > Project: Maven Project Info Reports Plugin > Issue Type: Task >Affects Versions: 3.4.1 >Reporter: Michael Osipov >Assignee: Michael Osipov >Priority: Major > Fix For: 3.4.2 > > > In preperation for Doxia 2.0.0 we need to address this old style approach. > See > https://cwiki.apache.org/confluence/display/MAVEN/Towards+Doxia+2.0.0+Stack > for details. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MPIR-425) License from text resource should be included as plain text
[ https://issues.apache.org/jira/browse/MPIR-425?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17655564#comment-17655564 ] Michael Osipov commented on MPIR-425: - Here is an example: https://michael-o.github.io/tomcatspnegoad/licenses.html > License from text resource should be included as plain text > --- > > Key: MPIR-425 > URL: https://issues.apache.org/jira/browse/MPIR-425 > Project: Maven Project Info Reports Plugin > Issue Type: Improvement > Components: licenses >Reporter: Slawomir Jaranowski >Assignee: Michael Osipov >Priority: Major > Attachments: Screenshot 2022-12-03 at 10.24.48.png, Screenshot > 2022-12-03 at 10.25.17.png > > > When license is imported from text files additional parsing is not needed. > Now we have a colorized some of items. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] (MPIR-425) License from text resource should be included as plain text
[ https://issues.apache.org/jira/browse/MPIR-425 ] Michael Osipov deleted comment on MPIR-425: - was (Author: michael-o): [~sjaranowski], how can I reproduce this? > License from text resource should be included as plain text > --- > > Key: MPIR-425 > URL: https://issues.apache.org/jira/browse/MPIR-425 > Project: Maven Project Info Reports Plugin > Issue Type: Improvement > Components: licenses >Reporter: Slawomir Jaranowski >Assignee: Michael Osipov >Priority: Major > Attachments: Screenshot 2022-12-03 at 10.24.48.png, Screenshot > 2022-12-03 at 10.25.17.png > > > When license is imported from text files additional parsing is not needed. > Now we have a colorized some of items. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Closed] (MPIR-426) Remove Apache Buildr from Dependency Information Report
[ https://issues.apache.org/jira/browse/MPIR-426?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov closed MPIR-426. --- Resolution: Fixed Fixed with [7f80826d74ffbbc66bad4eaff85c0f4c236fd9d0|https://gitbox.apache.org/repos/asf?p=maven-project-info-reports-plugin.git;a=commit;h=7f80826d74ffbbc66bad4eaff85c0f4c236fd9d0]. > Remove Apache Buildr from Dependency Information Report > --- > > Key: MPIR-426 > URL: https://issues.apache.org/jira/browse/MPIR-426 > Project: Maven Project Info Reports Plugin > Issue Type: Task > Components: dependency-info >Reporter: Slawomir Jaranowski >Assignee: Michael Osipov >Priority: Major > Fix For: 3.4.2 > > > Apache Buildr is retired > https://attic.apache.org/projects/buildr.html -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (MPIR-427) Explicitly stand and end tables with Doxia Sinks
Michael Osipov created MPIR-427: --- Summary: Explicitly stand and end tables with Doxia Sinks Key: MPIR-427 URL: https://issues.apache.org/jira/browse/MPIR-427 Project: Maven Project Info Reports Plugin Issue Type: Task Affects Versions: 3.4.1 Reporter: Michael Osipov Assignee: Michael Osipov Fix For: 3.4.2 In preperation for Doxia 2.0.0 we need to address this old style approach. See https://cwiki.apache.org/confluence/display/MAVEN/Towards+Doxia+2.0.0+Stack for details. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (MPIR-426) Remove Apache Buildr from Dependency Information Report
[ https://issues.apache.org/jira/browse/MPIR-426?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov updated MPIR-426: Summary: Remove Apache Buildr from Dependency Information Report (was: Remove Apache Buildr from Dependency Information) > Remove Apache Buildr from Dependency Information Report > --- > > Key: MPIR-426 > URL: https://issues.apache.org/jira/browse/MPIR-426 > Project: Maven Project Info Reports Plugin > Issue Type: Task > Components: dependency-info >Reporter: Slawomir Jaranowski >Assignee: Michael Osipov >Priority: Major > Fix For: 3.4.2 > > > Apache Buildr is retired > https://attic.apache.org/projects/buildr.html -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (MPIR-426) Remove Apache Buildr from Dependency Information
[ https://issues.apache.org/jira/browse/MPIR-426?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov updated MPIR-426: Issue Type: Task (was: Improvement) > Remove Apache Buildr from Dependency Information > > > Key: MPIR-426 > URL: https://issues.apache.org/jira/browse/MPIR-426 > Project: Maven Project Info Reports Plugin > Issue Type: Task > Components: dependency-info >Reporter: Slawomir Jaranowski >Assignee: Michael Osipov >Priority: Major > Fix For: 3.4.2 > > > Apache Buildr is retired > https://attic.apache.org/projects/buildr.html -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (MPIR-426) Remove Apache Buildr from Dependency Information
[ https://issues.apache.org/jira/browse/MPIR-426?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov updated MPIR-426: Fix Version/s: 3.4.2 > Remove Apache Buildr from Dependency Information > > > Key: MPIR-426 > URL: https://issues.apache.org/jira/browse/MPIR-426 > Project: Maven Project Info Reports Plugin > Issue Type: Improvement > Components: dependency-info >Reporter: Slawomir Jaranowski >Assignee: Michael Osipov >Priority: Major > Fix For: 3.4.2 > > > Apache Buildr is retired > https://attic.apache.org/projects/buildr.html -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Assigned] (MPIR-426) Remove Apache Buildr from Dependency Information
[ https://issues.apache.org/jira/browse/MPIR-426?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov reassigned MPIR-426: --- Assignee: Michael Osipov > Remove Apache Buildr from Dependency Information > > > Key: MPIR-426 > URL: https://issues.apache.org/jira/browse/MPIR-426 > Project: Maven Project Info Reports Plugin > Issue Type: Improvement > Components: dependency-info >Reporter: Slawomir Jaranowski >Assignee: Michael Osipov >Priority: Major > > Apache Buildr is retired > https://attic.apache.org/projects/buildr.html -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MPIR-425) License from text resource should be included as plain text
[ https://issues.apache.org/jira/browse/MPIR-425?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=1769#comment-1769 ] Michael Osipov commented on MPIR-425: - [~sjaranowski], how can I reproduce this? > License from text resource should be included as plain text > --- > > Key: MPIR-425 > URL: https://issues.apache.org/jira/browse/MPIR-425 > Project: Maven Project Info Reports Plugin > Issue Type: Improvement > Components: licenses >Reporter: Slawomir Jaranowski >Priority: Major > Attachments: Screenshot 2022-12-03 at 10.24.48.png, Screenshot > 2022-12-03 at 10.25.17.png > > > When license is imported from text files additional parsing is not needed. > Now we have a colorized some of items. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Assigned] (MPIR-425) License from text resource should be included as plain text
[ https://issues.apache.org/jira/browse/MPIR-425?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov reassigned MPIR-425: --- Assignee: Michael Osipov > License from text resource should be included as plain text > --- > > Key: MPIR-425 > URL: https://issues.apache.org/jira/browse/MPIR-425 > Project: Maven Project Info Reports Plugin > Issue Type: Improvement > Components: licenses >Reporter: Slawomir Jaranowski >Assignee: Michael Osipov >Priority: Major > Attachments: Screenshot 2022-12-03 at 10.24.48.png, Screenshot > 2022-12-03 at 10.25.17.png > > > When license is imported from text files additional parsing is not needed. > Now we have a colorized some of items. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MWRAPPER-80) Support maven-mvnd as a maven distribution
[ https://issues.apache.org/jira/browse/MWRAPPER-80?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17655529#comment-17655529 ] ASF GitHub Bot commented on MWRAPPER-80: gzm55 commented on PR #65: URL: https://github.com/apache/maven-wrapper/pull/65#issuecomment-1373951163 > What with additional task per OS, like for macOs `xattr -r -d ...`? > > https://github.com/apache/maven-mvnd#install-manually The "com.apple.quarantine" extended attribute is set when the zip/tgz files are downloaded by the browsers, and not set when downloaded by curl/wget/java. This is tested on macos since 10.15. And the original maven distribution installed by wrapper also relies on this behavior. So the `xattr -r -d ...` step is not required by the wrapper for both original maven and mvnd. > Support maven-mvnd as a maven distribution > -- > > Key: MWRAPPER-80 > URL: https://issues.apache.org/jira/browse/MWRAPPER-80 > Project: Maven Wrapper > Issue Type: New Feature > Components: Maven Wrapper Scripts >Reporter: James Z.M. Gao >Priority: Major > > Here is a proposal method to integrate maven-mvnd. > When set distributionUrl to a maven-mvnd downloading url, the wrapper should > distinguish then download/install/run the maven-mvnd on the fly. The script > should take own the os/hardware detecting to select a proper native version. > For example: > * manual select platform: > distributionUrl=[https://downloads.apache.org/maven/mvnd/0.8.2/maven-mvnd-0.8.2-darwin-amd64.zip] > * auto select platform: > distributionUrl=[https://downloads.apache.org/maven/mvnd/0.8.2/maven-mvnd-0.8.2-bin.zip] > In the auto mode, the script can select the real platform via the result of > "uname -a", or fallback to the pure java version for unknown platform. For > `distributionSha256Sum`, we also need new pattern to support multiple > checksum, such as > > * distributionSha256Sum=darwin-aarch64:111;linux-amd64:222 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [maven-wrapper] gzm55 commented on pull request #65: [MWRAPPER-80] support maven-mvnd
gzm55 commented on PR #65: URL: https://github.com/apache/maven-wrapper/pull/65#issuecomment-1373951163 > What with additional task per OS, like for macOs `xattr -r -d ...`? > > https://github.com/apache/maven-mvnd#install-manually The "com.apple.quarantine" extended attribute is set when the zip/tgz files are downloaded by the browsers, and not set when downloaded by curl/wget/java. This is tested on macos since 10.15. And the original maven distribution installed by wrapper also relies on this behavior. So the `xattr -r -d ...` step is not required by the wrapper for both original maven and mvnd. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MWRAPPER-88) mvnw is not POSIX compatible
[ https://issues.apache.org/jira/browse/MWRAPPER-88?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17655507#comment-17655507 ] ASF GitHub Bot commented on MWRAPPER-88: gnodet commented on code in PR #79: URL: https://github.com/apache/maven-wrapper/pull/79#discussion_r1063591166 ## maven-wrapper-distribution/src/resources/mvnw: ## @@ -193,42 +193,48 @@ else else wrapperUrl="https://repo.maven.apache.org/maven2/org/apache/maven/wrapper/maven-wrapper/@@project.version@@/maven-wrapper-@@project.version@@.jar"; fi -while IFS="=" read key value; do +while IFS="=" read -r key value; do case "$key" in (wrapperUrl) wrapperUrl="$value"; break ;; esac done < "$MAVEN_PROJECTBASEDIR/.mvn/wrapper/maven-wrapper.properties" log "Downloading from: $wrapperUrl" if $cygwin; then - wrapperJarPath=`cygpath --path --windows "$wrapperJarPath"` + wrapperJarPath=$(cygpath --path --windows "$wrapperJarPath") fi if command -v wget > /dev/null; then log "Found wget ... using wget" +wgetrc=0 [ "$MVNW_VERBOSE" = true ] && QUIET="" || QUIET="--quiet" if [ -z "$MVNW_USERNAME" ] || [ -z "$MVNW_PASSWORD" ]; then wget $QUIET "$wrapperUrl" -O "$wrapperJarPath" +wgetrc=$? else wget $QUIET --http-user="$MVNW_USERNAME" --http-password="$MVNW_PASSWORD" "$wrapperUrl" -O "$wrapperJarPath" +wgetrc=$? fi -[ $? -eq 0 ] || rm -f "$wrapperJarPath" +[ $wgetrc -eq 0 ] || rm -f "$wrapperJarPath" elif command -v curl > /dev/null; then log "Found curl ... using curl" +curlrc=0 [ "$MVNW_VERBOSE" = true ] && QUIET="" || QUIET="--silent" if [ -z "$MVNW_USERNAME" ] || [ -z "$MVNW_PASSWORD" ]; then curl $QUIET -o "$wrapperJarPath" "$wrapperUrl" -f -L +curlrc=$? else curl $QUIET --user "$MVNW_USERNAME:$MVNW_PASSWORD" -o "$wrapperJarPath" "$wrapperUrl" -f -L +curlrc=$? fi -[ $? -eq 0 ] || rm -f "$wrapperJarPath" +[ $curlrc -eq 0 ] || rm -f "$wrapperJarPath" Review Comment: Ah, missed that. So my first proposal should work and keep the existing behaviour. > mvnw is not POSIX compatible > > > Key: MWRAPPER-88 > URL: https://issues.apache.org/jira/browse/MWRAPPER-88 > Project: Maven Wrapper > Issue Type: Bug > Components: Maven Wrapper Scripts >Affects Versions: 3.1.1 >Reporter: Benjamin Marwell >Assignee: Benjamin Marwell >Priority: Major > Labels: posix > > * POSIX scripts should not use bash-specific features > * Fix suggestions from shellcheck > ([https://github.com/apache/maven-wrapper/pull/74]) -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [maven-wrapper] gnodet commented on a diff in pull request #79: [MWRAPPER-88] fix shellcheck findings / POSIX compatiblity
gnodet commented on code in PR #79: URL: https://github.com/apache/maven-wrapper/pull/79#discussion_r1063591166 ## maven-wrapper-distribution/src/resources/mvnw: ## @@ -193,42 +193,48 @@ else else wrapperUrl="https://repo.maven.apache.org/maven2/org/apache/maven/wrapper/maven-wrapper/@@project.version@@/maven-wrapper-@@project.version@@.jar"; fi -while IFS="=" read key value; do +while IFS="=" read -r key value; do case "$key" in (wrapperUrl) wrapperUrl="$value"; break ;; esac done < "$MAVEN_PROJECTBASEDIR/.mvn/wrapper/maven-wrapper.properties" log "Downloading from: $wrapperUrl" if $cygwin; then - wrapperJarPath=`cygpath --path --windows "$wrapperJarPath"` + wrapperJarPath=$(cygpath --path --windows "$wrapperJarPath") fi if command -v wget > /dev/null; then log "Found wget ... using wget" +wgetrc=0 [ "$MVNW_VERBOSE" = true ] && QUIET="" || QUIET="--quiet" if [ -z "$MVNW_USERNAME" ] || [ -z "$MVNW_PASSWORD" ]; then wget $QUIET "$wrapperUrl" -O "$wrapperJarPath" +wgetrc=$? else wget $QUIET --http-user="$MVNW_USERNAME" --http-password="$MVNW_PASSWORD" "$wrapperUrl" -O "$wrapperJarPath" +wgetrc=$? fi -[ $? -eq 0 ] || rm -f "$wrapperJarPath" +[ $wgetrc -eq 0 ] || rm -f "$wrapperJarPath" elif command -v curl > /dev/null; then log "Found curl ... using curl" +curlrc=0 [ "$MVNW_VERBOSE" = true ] && QUIET="" || QUIET="--silent" if [ -z "$MVNW_USERNAME" ] || [ -z "$MVNW_PASSWORD" ]; then curl $QUIET -o "$wrapperJarPath" "$wrapperUrl" -f -L +curlrc=$? else curl $QUIET --user "$MVNW_USERNAME:$MVNW_PASSWORD" -o "$wrapperJarPath" "$wrapperUrl" -f -L +curlrc=$? fi -[ $? -eq 0 ] || rm -f "$wrapperJarPath" +[ $curlrc -eq 0 ] || rm -f "$wrapperJarPath" Review Comment: Ah, missed that. So my first proposal should work and keep the existing behaviour. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MWRAPPER-88) mvnw is not POSIX compatible
[ https://issues.apache.org/jira/browse/MWRAPPER-88?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17655505#comment-17655505 ] ASF GitHub Bot commented on MWRAPPER-88: bmarwell commented on code in PR #79: URL: https://github.com/apache/maven-wrapper/pull/79#discussion_r1063583507 ## maven-wrapper-distribution/src/resources/mvnw: ## @@ -281,20 +286,21 @@ MAVEN_OPTS="$(concat_lines "$MAVEN_PROJECTBASEDIR/.mvn/jvm.config") $MAVEN_OPTS" # For Cygwin, switch paths to Windows format before running java if $cygwin; then [ -n "$JAVA_HOME" ] && -JAVA_HOME=`cygpath --path --windows "$JAVA_HOME"` +JAVA_HOME=$(cygpath --path --windows "$JAVA_HOME") [ -n "$CLASSPATH" ] && -CLASSPATH=`cygpath --path --windows "$CLASSPATH"` +CLASSPATH=$(cygpath --path --windows "$CLASSPATH") [ -n "$MAVEN_PROJECTBASEDIR" ] && -MAVEN_PROJECTBASEDIR=`cygpath --path --windows "$MAVEN_PROJECTBASEDIR"` +MAVEN_PROJECTBASEDIR=$(cygpath --path --windows "$MAVEN_PROJECTBASEDIR") fi # Provide a "standardized" way to retrieve the CLI args that will # work with both Windows and non-Windows executions. -MAVEN_CMD_LINE_ARGS="$MAVEN_CONFIG $@" +MAVEN_CMD_LINE_ARGS="$MAVEN_CONFIG $*" export MAVEN_CMD_LINE_ARGS WRAPPER_LAUNCHER=org.apache.maven.wrapper.MavenWrapperMain +# shellcheck disable=SC2086 # safe args exec "$JAVACMD" \ $MAVEN_OPTS \ $MAVEN_DEBUG_OPTS \ Review Comment: We should open a Jira issue and investigate > mvnw is not POSIX compatible > > > Key: MWRAPPER-88 > URL: https://issues.apache.org/jira/browse/MWRAPPER-88 > Project: Maven Wrapper > Issue Type: Bug > Components: Maven Wrapper Scripts >Affects Versions: 3.1.1 >Reporter: Benjamin Marwell >Assignee: Benjamin Marwell >Priority: Major > Labels: posix > > * POSIX scripts should not use bash-specific features > * Fix suggestions from shellcheck > ([https://github.com/apache/maven-wrapper/pull/74]) -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [maven-wrapper] bmarwell commented on a diff in pull request #79: [MWRAPPER-88] fix shellcheck findings / POSIX compatiblity
bmarwell commented on code in PR #79: URL: https://github.com/apache/maven-wrapper/pull/79#discussion_r1063583507 ## maven-wrapper-distribution/src/resources/mvnw: ## @@ -281,20 +286,21 @@ MAVEN_OPTS="$(concat_lines "$MAVEN_PROJECTBASEDIR/.mvn/jvm.config") $MAVEN_OPTS" # For Cygwin, switch paths to Windows format before running java if $cygwin; then [ -n "$JAVA_HOME" ] && -JAVA_HOME=`cygpath --path --windows "$JAVA_HOME"` +JAVA_HOME=$(cygpath --path --windows "$JAVA_HOME") [ -n "$CLASSPATH" ] && -CLASSPATH=`cygpath --path --windows "$CLASSPATH"` +CLASSPATH=$(cygpath --path --windows "$CLASSPATH") [ -n "$MAVEN_PROJECTBASEDIR" ] && -MAVEN_PROJECTBASEDIR=`cygpath --path --windows "$MAVEN_PROJECTBASEDIR"` +MAVEN_PROJECTBASEDIR=$(cygpath --path --windows "$MAVEN_PROJECTBASEDIR") fi # Provide a "standardized" way to retrieve the CLI args that will # work with both Windows and non-Windows executions. -MAVEN_CMD_LINE_ARGS="$MAVEN_CONFIG $@" +MAVEN_CMD_LINE_ARGS="$MAVEN_CONFIG $*" export MAVEN_CMD_LINE_ARGS WRAPPER_LAUNCHER=org.apache.maven.wrapper.MavenWrapperMain +# shellcheck disable=SC2086 # safe args exec "$JAVACMD" \ $MAVEN_OPTS \ $MAVEN_DEBUG_OPTS \ Review Comment: We should open a Jira issue and investigate -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MWRAPPER-88) mvnw is not POSIX compatible
[
https://issues.apache.org/jira/browse/MWRAPPER-88?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17655504#comment-17655504
]
ASF GitHub Bot commented on MWRAPPER-88:
bmarwell commented on code in PR #79:
URL: https://github.com/apache/maven-wrapper/pull/79#discussion_r1063583039
##
maven-wrapper-distribution/src/resources/mvnw:
##
@@ -237,8 +243,7 @@ else
fi
if [ -e "$javaClass" ]; then
log " - Running MavenWrapperDownloader.java ..."
-("$JAVA_HOME/bin/java" -cp .mvn/wrapper MavenWrapperDownloader
"$wrapperUrl" "$wrapperJarPath")
-[ $? -eq 0 ] || rm -f "$wrapperJarPath"
+("$JAVA_HOME/bin/java" -cp .mvn/wrapper MavenWrapperDownloader
"$wrapperUrl" "$wrapperJarPath") || rm -f "$wrapperJarPath"
Review Comment:
The script won't exit anyway because neither `set -e` nor `set -o pipefail`
is set.
Rewriting is not part of this commit. Let's not fix things here which are
not broken. We can open an issue for this, though. I just want to make sure the
script behaves the same as before.
> mvnw is not POSIX compatible
>
>
> Key: MWRAPPER-88
> URL: https://issues.apache.org/jira/browse/MWRAPPER-88
> Project: Maven Wrapper
> Issue Type: Bug
> Components: Maven Wrapper Scripts
>Affects Versions: 3.1.1
>Reporter: Benjamin Marwell
>Assignee: Benjamin Marwell
>Priority: Major
> Labels: posix
>
> * POSIX scripts should not use bash-specific features
> * Fix suggestions from shellcheck
> ([https://github.com/apache/maven-wrapper/pull/74])
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[GitHub] [maven-wrapper] bmarwell commented on a diff in pull request #79: [MWRAPPER-88] fix shellcheck findings / POSIX compatiblity
bmarwell commented on code in PR #79:
URL: https://github.com/apache/maven-wrapper/pull/79#discussion_r1063583039
##
maven-wrapper-distribution/src/resources/mvnw:
##
@@ -237,8 +243,7 @@ else
fi
if [ -e "$javaClass" ]; then
log " - Running MavenWrapperDownloader.java ..."
-("$JAVA_HOME/bin/java" -cp .mvn/wrapper MavenWrapperDownloader
"$wrapperUrl" "$wrapperJarPath")
-[ $? -eq 0 ] || rm -f "$wrapperJarPath"
+("$JAVA_HOME/bin/java" -cp .mvn/wrapper MavenWrapperDownloader
"$wrapperUrl" "$wrapperJarPath") || rm -f "$wrapperJarPath"
Review Comment:
The script won't exit anyway because neither `set -e` nor `set -o pipefail`
is set.
Rewriting is not part of this commit. Let's not fix things here which are
not broken. We can open an issue for this, though. I just want to make sure the
script behaves the same as before.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Commented] (MWRAPPER-88) mvnw is not POSIX compatible
[ https://issues.apache.org/jira/browse/MWRAPPER-88?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17655502#comment-17655502 ] ASF GitHub Bot commented on MWRAPPER-88: bmarwell commented on code in PR #79: URL: https://github.com/apache/maven-wrapper/pull/79#discussion_r1063581666 ## maven-wrapper-distribution/src/resources/mvnw: ## @@ -193,42 +193,48 @@ else else wrapperUrl="https://repo.maven.apache.org/maven2/org/apache/maven/wrapper/maven-wrapper/@@project.version@@/maven-wrapper-@@project.version@@.jar"; fi -while IFS="=" read key value; do +while IFS="=" read -r key value; do case "$key" in (wrapperUrl) wrapperUrl="$value"; break ;; esac done < "$MAVEN_PROJECTBASEDIR/.mvn/wrapper/maven-wrapper.properties" log "Downloading from: $wrapperUrl" if $cygwin; then - wrapperJarPath=`cygpath --path --windows "$wrapperJarPath"` + wrapperJarPath=$(cygpath --path --windows "$wrapperJarPath") fi if command -v wget > /dev/null; then log "Found wget ... using wget" +wgetrc=0 [ "$MVNW_VERBOSE" = true ] && QUIET="" || QUIET="--quiet" if [ -z "$MVNW_USERNAME" ] || [ -z "$MVNW_PASSWORD" ]; then wget $QUIET "$wrapperUrl" -O "$wrapperJarPath" +wgetrc=$? else wget $QUIET --http-user="$MVNW_USERNAME" --http-password="$MVNW_PASSWORD" "$wrapperUrl" -O "$wrapperJarPath" +wgetrc=$? fi -[ $? -eq 0 ] || rm -f "$wrapperJarPath" +[ $wgetrc -eq 0 ] || rm -f "$wrapperJarPath" elif command -v curl > /dev/null; then log "Found curl ... using curl" +curlrc=0 [ "$MVNW_VERBOSE" = true ] && QUIET="" || QUIET="--silent" if [ -z "$MVNW_USERNAME" ] || [ -z "$MVNW_PASSWORD" ]; then curl $QUIET -o "$wrapperJarPath" "$wrapperUrl" -f -L +curlrc=$? else curl $QUIET --user "$MVNW_USERNAME:$MVNW_PASSWORD" -o "$wrapperJarPath" "$wrapperUrl" -f -L +curlrc=$? fi -[ $? -eq 0 ] || rm -f "$wrapperJarPath" +[ $curlrc -eq 0 ] || rm -f "$wrapperJarPath" Review Comment: Yes, we would need either an OR, or a trap function. But. The script won't exit anyway because neither `set -e` nor `set -o pipefail` is set. > mvnw is not POSIX compatible > > > Key: MWRAPPER-88 > URL: https://issues.apache.org/jira/browse/MWRAPPER-88 > Project: Maven Wrapper > Issue Type: Bug > Components: Maven Wrapper Scripts >Affects Versions: 3.1.1 >Reporter: Benjamin Marwell >Assignee: Benjamin Marwell >Priority: Major > Labels: posix > > * POSIX scripts should not use bash-specific features > * Fix suggestions from shellcheck > ([https://github.com/apache/maven-wrapper/pull/74]) -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [maven-wrapper] bmarwell commented on a diff in pull request #79: [MWRAPPER-88] fix shellcheck findings / POSIX compatiblity
bmarwell commented on code in PR #79: URL: https://github.com/apache/maven-wrapper/pull/79#discussion_r1063581666 ## maven-wrapper-distribution/src/resources/mvnw: ## @@ -193,42 +193,48 @@ else else wrapperUrl="https://repo.maven.apache.org/maven2/org/apache/maven/wrapper/maven-wrapper/@@project.version@@/maven-wrapper-@@project.version@@.jar"; fi -while IFS="=" read key value; do +while IFS="=" read -r key value; do case "$key" in (wrapperUrl) wrapperUrl="$value"; break ;; esac done < "$MAVEN_PROJECTBASEDIR/.mvn/wrapper/maven-wrapper.properties" log "Downloading from: $wrapperUrl" if $cygwin; then - wrapperJarPath=`cygpath --path --windows "$wrapperJarPath"` + wrapperJarPath=$(cygpath --path --windows "$wrapperJarPath") fi if command -v wget > /dev/null; then log "Found wget ... using wget" +wgetrc=0 [ "$MVNW_VERBOSE" = true ] && QUIET="" || QUIET="--quiet" if [ -z "$MVNW_USERNAME" ] || [ -z "$MVNW_PASSWORD" ]; then wget $QUIET "$wrapperUrl" -O "$wrapperJarPath" +wgetrc=$? else wget $QUIET --http-user="$MVNW_USERNAME" --http-password="$MVNW_PASSWORD" "$wrapperUrl" -O "$wrapperJarPath" +wgetrc=$? fi -[ $? -eq 0 ] || rm -f "$wrapperJarPath" +[ $wgetrc -eq 0 ] || rm -f "$wrapperJarPath" elif command -v curl > /dev/null; then log "Found curl ... using curl" +curlrc=0 [ "$MVNW_VERBOSE" = true ] && QUIET="" || QUIET="--silent" if [ -z "$MVNW_USERNAME" ] || [ -z "$MVNW_PASSWORD" ]; then curl $QUIET -o "$wrapperJarPath" "$wrapperUrl" -f -L +curlrc=$? else curl $QUIET --user "$MVNW_USERNAME:$MVNW_PASSWORD" -o "$wrapperJarPath" "$wrapperUrl" -f -L +curlrc=$? fi -[ $? -eq 0 ] || rm -f "$wrapperJarPath" +[ $curlrc -eq 0 ] || rm -f "$wrapperJarPath" Review Comment: Yes, we would need either an OR, or a trap function. But. The script won't exit anyway because neither `set -e` nor `set -o pipefail` is set. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-mvnd] gnodet commented on issue #728: Maven Project randomly fails with "Failed to open file channel '[..]\.m2\repository\.locks\[..].resolverlock"
gnodet commented on issue #728: URL: https://github.com/apache/maven-mvnd/issues/728#issuecomment-1373836302 Fixed in https://github.com/apache/maven-mvnd/milestone/31 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-mvnd] gnodet closed issue #728: Maven Project randomly fails with "Failed to open file channel '[..]\.m2\repository\.locks\[..].resolverlock"
gnodet closed issue #728: Maven Project randomly fails with "Failed to open file channel '[..]\.m2\repository\.locks\[..].resolverlock" URL: https://github.com/apache/maven-mvnd/issues/728 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-mvnd] gnodet commented on issue #762: Support for Maven 3.8.7?
gnodet commented on issue #762: URL: https://github.com/apache/maven-mvnd/issues/762#issuecomment-1373834394 See https://github.com/apache/maven-mvnd/commit/a31a080948790473d27dd41c36d653b8f89df61f -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MWRAPPER-88) mvnw is not POSIX compatible
[
https://issues.apache.org/jira/browse/MWRAPPER-88?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17655497#comment-17655497
]
ASF GitHub Bot commented on MWRAPPER-88:
gnodet commented on code in PR #79:
URL: https://github.com/apache/maven-wrapper/pull/79#discussion_r1063556378
##
maven-wrapper-distribution/src/resources/mvnw:
##
@@ -118,7 +118,7 @@ if [ -z "$JAVACMD" ] ; then
JAVACMD="$JAVA_HOME/bin/java"
fi
else
-JAVACMD="`\\unset -f command; \\command -v java`"
+JAVACMD="$(\\unset -f command; \\command -v java)"
Review Comment:
```
JAVACMD="$("unset" -f command 2>/dev/null; "command" -v java)"
```
This above seems to work on bash and zsh:
```
➜ ~ zsh -li
➜ ~ JAVACMD="$("unset" -f command 2>/dev/null; "command" -v java)" ; echo
$JAVACMD
/Users/gnodet/.jenv/shims/java
➜ ~ bash -li
gnodet-mac:~ gnodet$ JAVACMD="$("unset" -f command 2>/dev/null; "command" -v
java)" ; echo $JAVACMD
/usr/bin/java
gnodet-mac:~ gnodet$
```
> mvnw is not POSIX compatible
>
>
> Key: MWRAPPER-88
> URL: https://issues.apache.org/jira/browse/MWRAPPER-88
> Project: Maven Wrapper
> Issue Type: Bug
> Components: Maven Wrapper Scripts
>Affects Versions: 3.1.1
>Reporter: Benjamin Marwell
>Assignee: Benjamin Marwell
>Priority: Major
> Labels: posix
>
> * POSIX scripts should not use bash-specific features
> * Fix suggestions from shellcheck
> ([https://github.com/apache/maven-wrapper/pull/74])
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[GitHub] [maven-wrapper] gnodet commented on a diff in pull request #79: [MWRAPPER-88] fix shellcheck findings / POSIX compatiblity
gnodet commented on code in PR #79:
URL: https://github.com/apache/maven-wrapper/pull/79#discussion_r1063556378
##
maven-wrapper-distribution/src/resources/mvnw:
##
@@ -118,7 +118,7 @@ if [ -z "$JAVACMD" ] ; then
JAVACMD="$JAVA_HOME/bin/java"
fi
else
-JAVACMD="`\\unset -f command; \\command -v java`"
+JAVACMD="$(\\unset -f command; \\command -v java)"
Review Comment:
```
JAVACMD="$("unset" -f command 2>/dev/null; "command" -v java)"
```
This above seems to work on bash and zsh:
```
➜ ~ zsh -li
➜ ~ JAVACMD="$("unset" -f command 2>/dev/null; "command" -v java)" ; echo
$JAVACMD
/Users/gnodet/.jenv/shims/java
➜ ~ bash -li
gnodet-mac:~ gnodet$ JAVACMD="$("unset" -f command 2>/dev/null; "command" -v
java)" ; echo $JAVACMD
/usr/bin/java
gnodet-mac:~ gnodet$
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Commented] (MWRAPPER-88) mvnw is not POSIX compatible
[
https://issues.apache.org/jira/browse/MWRAPPER-88?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17655496#comment-17655496
]
ASF GitHub Bot commented on MWRAPPER-88:
gnodet commented on code in PR #79:
URL: https://github.com/apache/maven-wrapper/pull/79#discussion_r1063556378
##
maven-wrapper-distribution/src/resources/mvnw:
##
@@ -118,7 +118,7 @@ if [ -z "$JAVACMD" ] ; then
JAVACMD="$JAVA_HOME/bin/java"
fi
else
-JAVACMD="`\\unset -f command; \\command -v java`"
+JAVACMD="$(\\unset -f command; \\command -v java)"
Review Comment:
```
JAVACMD="$("unset" -f command 2>/dev/null; "command" -v java)"
```
This above seems to work on bash and zsh:
```
➜ ~ zsh -li
➜ ~ JAVACMD="$("unset" -f command 2>/dev/null; "command" -v java)" ; echo
$JAVACMD
/Users/gnodet/.jenv/shims/java
➜ ~ bash -li
Restored session: Fri Jan 6 16:55:48 CET 2023
gnodet-mac:~ gnodet$ JAVACMD="$("unset" -f command 2>/dev/null; "command" -v
java)" ; echo $JAVACMD
/usr/bin/java
gnodet-mac:~ gnodet$
```
> mvnw is not POSIX compatible
>
>
> Key: MWRAPPER-88
> URL: https://issues.apache.org/jira/browse/MWRAPPER-88
> Project: Maven Wrapper
> Issue Type: Bug
> Components: Maven Wrapper Scripts
>Affects Versions: 3.1.1
>Reporter: Benjamin Marwell
>Assignee: Benjamin Marwell
>Priority: Major
> Labels: posix
>
> * POSIX scripts should not use bash-specific features
> * Fix suggestions from shellcheck
> ([https://github.com/apache/maven-wrapper/pull/74])
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[GitHub] [maven-wrapper] gnodet commented on a diff in pull request #79: [MWRAPPER-88] fix shellcheck findings / POSIX compatiblity
gnodet commented on code in PR #79:
URL: https://github.com/apache/maven-wrapper/pull/79#discussion_r1063556378
##
maven-wrapper-distribution/src/resources/mvnw:
##
@@ -118,7 +118,7 @@ if [ -z "$JAVACMD" ] ; then
JAVACMD="$JAVA_HOME/bin/java"
fi
else
-JAVACMD="`\\unset -f command; \\command -v java`"
+JAVACMD="$(\\unset -f command; \\command -v java)"
Review Comment:
```
JAVACMD="$("unset" -f command 2>/dev/null; "command" -v java)"
```
This above seems to work on bash and zsh:
```
➜ ~ zsh -li
➜ ~ JAVACMD="$("unset" -f command 2>/dev/null; "command" -v java)" ; echo
$JAVACMD
/Users/gnodet/.jenv/shims/java
➜ ~ bash -li
Restored session: Fri Jan 6 16:55:48 CET 2023
gnodet-mac:~ gnodet$ JAVACMD="$("unset" -f command 2>/dev/null; "command" -v
java)" ; echo $JAVACMD
/usr/bin/java
gnodet-mac:~ gnodet$
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Commented] (MWRAPPER-88) mvnw is not POSIX compatible
[
https://issues.apache.org/jira/browse/MWRAPPER-88?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17655495#comment-17655495
]
ASF GitHub Bot commented on MWRAPPER-88:
gnodet commented on code in PR #79:
URL: https://github.com/apache/maven-wrapper/pull/79#discussion_r1063556378
##
maven-wrapper-distribution/src/resources/mvnw:
##
@@ -118,7 +118,7 @@ if [ -z "$JAVACMD" ] ; then
JAVACMD="$JAVA_HOME/bin/java"
fi
else
-JAVACMD="`\\unset -f command; \\command -v java`"
+JAVACMD="$(\\unset -f command; \\command -v java)"
Review Comment:
```
JAVACMD="$("unset" -f command 2>/dev/null; "command" -v java)"
```
This above seems to work on bash and zsh
> mvnw is not POSIX compatible
>
>
> Key: MWRAPPER-88
> URL: https://issues.apache.org/jira/browse/MWRAPPER-88
> Project: Maven Wrapper
> Issue Type: Bug
> Components: Maven Wrapper Scripts
>Affects Versions: 3.1.1
>Reporter: Benjamin Marwell
>Assignee: Benjamin Marwell
>Priority: Major
> Labels: posix
>
> * POSIX scripts should not use bash-specific features
> * Fix suggestions from shellcheck
> ([https://github.com/apache/maven-wrapper/pull/74])
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[GitHub] [maven-wrapper] gnodet commented on a diff in pull request #79: [MWRAPPER-88] fix shellcheck findings / POSIX compatiblity
gnodet commented on code in PR #79:
URL: https://github.com/apache/maven-wrapper/pull/79#discussion_r1063556378
##
maven-wrapper-distribution/src/resources/mvnw:
##
@@ -118,7 +118,7 @@ if [ -z "$JAVACMD" ] ; then
JAVACMD="$JAVA_HOME/bin/java"
fi
else
-JAVACMD="`\\unset -f command; \\command -v java`"
+JAVACMD="$(\\unset -f command; \\command -v java)"
Review Comment:
```
JAVACMD="$("unset" -f command 2>/dev/null; "command" -v java)"
```
This above seems to work on bash and zsh
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Commented] (MWRAPPER-88) mvnw is not POSIX compatible
[
https://issues.apache.org/jira/browse/MWRAPPER-88?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17655494#comment-17655494
]
ASF GitHub Bot commented on MWRAPPER-88:
gnodet commented on code in PR #79:
URL: https://github.com/apache/maven-wrapper/pull/79#discussion_r1063556378
##
maven-wrapper-distribution/src/resources/mvnw:
##
@@ -118,7 +118,7 @@ if [ -z "$JAVACMD" ] ; then
JAVACMD="$JAVA_HOME/bin/java"
fi
else
-JAVACMD="`\\unset -f command; \\command -v java`"
+JAVACMD="$(\\unset -f command; \\command -v java)"
Review Comment:
```
JAVACMD="$("unset" -f command; "command" -v java)"
```
This above seems to work on bash and zsh
> mvnw is not POSIX compatible
>
>
> Key: MWRAPPER-88
> URL: https://issues.apache.org/jira/browse/MWRAPPER-88
> Project: Maven Wrapper
> Issue Type: Bug
> Components: Maven Wrapper Scripts
>Affects Versions: 3.1.1
>Reporter: Benjamin Marwell
>Assignee: Benjamin Marwell
>Priority: Major
> Labels: posix
>
> * POSIX scripts should not use bash-specific features
> * Fix suggestions from shellcheck
> ([https://github.com/apache/maven-wrapper/pull/74])
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[GitHub] [maven-wrapper] gnodet commented on a diff in pull request #79: [MWRAPPER-88] fix shellcheck findings / POSIX compatiblity
gnodet commented on code in PR #79:
URL: https://github.com/apache/maven-wrapper/pull/79#discussion_r1063556378
##
maven-wrapper-distribution/src/resources/mvnw:
##
@@ -118,7 +118,7 @@ if [ -z "$JAVACMD" ] ; then
JAVACMD="$JAVA_HOME/bin/java"
fi
else
-JAVACMD="`\\unset -f command; \\command -v java`"
+JAVACMD="$(\\unset -f command; \\command -v java)"
Review Comment:
```
JAVACMD="$("unset" -f command; "command" -v java)"
```
This above seems to work on bash and zsh
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Commented] (MWRAPPER-88) mvnw is not POSIX compatible
[ https://issues.apache.org/jira/browse/MWRAPPER-88?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17655492#comment-17655492 ] ASF GitHub Bot commented on MWRAPPER-88: gnodet commented on code in PR #79: URL: https://github.com/apache/maven-wrapper/pull/79#discussion_r1063550049 ## maven-wrapper-distribution/src/resources/mvnw: ## @@ -281,20 +286,21 @@ MAVEN_OPTS="$(concat_lines "$MAVEN_PROJECTBASEDIR/.mvn/jvm.config") $MAVEN_OPTS" # For Cygwin, switch paths to Windows format before running java if $cygwin; then [ -n "$JAVA_HOME" ] && -JAVA_HOME=`cygpath --path --windows "$JAVA_HOME"` +JAVA_HOME=$(cygpath --path --windows "$JAVA_HOME") [ -n "$CLASSPATH" ] && -CLASSPATH=`cygpath --path --windows "$CLASSPATH"` +CLASSPATH=$(cygpath --path --windows "$CLASSPATH") [ -n "$MAVEN_PROJECTBASEDIR" ] && -MAVEN_PROJECTBASEDIR=`cygpath --path --windows "$MAVEN_PROJECTBASEDIR"` +MAVEN_PROJECTBASEDIR=$(cygpath --path --windows "$MAVEN_PROJECTBASEDIR") fi # Provide a "standardized" way to retrieve the CLI args that will # work with both Windows and non-Windows executions. -MAVEN_CMD_LINE_ARGS="$MAVEN_CONFIG $@" +MAVEN_CMD_LINE_ARGS="$MAVEN_CONFIG $*" export MAVEN_CMD_LINE_ARGS WRAPPER_LAUNCHER=org.apache.maven.wrapper.MavenWrapperMain +# shellcheck disable=SC2086 # safe args exec "$JAVACMD" \ $MAVEN_OPTS \ $MAVEN_DEBUG_OPTS \ Review Comment: Are there targets that could possibly not support arrays ? > mvnw is not POSIX compatible > > > Key: MWRAPPER-88 > URL: https://issues.apache.org/jira/browse/MWRAPPER-88 > Project: Maven Wrapper > Issue Type: Bug > Components: Maven Wrapper Scripts >Affects Versions: 3.1.1 >Reporter: Benjamin Marwell >Assignee: Benjamin Marwell >Priority: Major > Labels: posix > > * POSIX scripts should not use bash-specific features > * Fix suggestions from shellcheck > ([https://github.com/apache/maven-wrapper/pull/74]) -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [maven-wrapper] gnodet commented on a diff in pull request #79: [MWRAPPER-88] fix shellcheck findings / POSIX compatiblity
gnodet commented on code in PR #79: URL: https://github.com/apache/maven-wrapper/pull/79#discussion_r1063550049 ## maven-wrapper-distribution/src/resources/mvnw: ## @@ -281,20 +286,21 @@ MAVEN_OPTS="$(concat_lines "$MAVEN_PROJECTBASEDIR/.mvn/jvm.config") $MAVEN_OPTS" # For Cygwin, switch paths to Windows format before running java if $cygwin; then [ -n "$JAVA_HOME" ] && -JAVA_HOME=`cygpath --path --windows "$JAVA_HOME"` +JAVA_HOME=$(cygpath --path --windows "$JAVA_HOME") [ -n "$CLASSPATH" ] && -CLASSPATH=`cygpath --path --windows "$CLASSPATH"` +CLASSPATH=$(cygpath --path --windows "$CLASSPATH") [ -n "$MAVEN_PROJECTBASEDIR" ] && -MAVEN_PROJECTBASEDIR=`cygpath --path --windows "$MAVEN_PROJECTBASEDIR"` +MAVEN_PROJECTBASEDIR=$(cygpath --path --windows "$MAVEN_PROJECTBASEDIR") fi # Provide a "standardized" way to retrieve the CLI args that will # work with both Windows and non-Windows executions. -MAVEN_CMD_LINE_ARGS="$MAVEN_CONFIG $@" +MAVEN_CMD_LINE_ARGS="$MAVEN_CONFIG $*" export MAVEN_CMD_LINE_ARGS WRAPPER_LAUNCHER=org.apache.maven.wrapper.MavenWrapperMain +# shellcheck disable=SC2086 # safe args exec "$JAVACMD" \ $MAVEN_OPTS \ $MAVEN_DEBUG_OPTS \ Review Comment: Are there targets that could possibly not support arrays ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MWRAPPER-88) mvnw is not POSIX compatible
[
https://issues.apache.org/jira/browse/MWRAPPER-88?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17655490#comment-17655490
]
ASF GitHub Bot commented on MWRAPPER-88:
gnodet commented on code in PR #79:
URL: https://github.com/apache/maven-wrapper/pull/79#discussion_r1063547852
##
maven-wrapper-distribution/src/resources/mvnw:
##
@@ -237,8 +243,7 @@ else
fi
if [ -e "$javaClass" ]; then
log " - Running MavenWrapperDownloader.java ..."
-("$JAVA_HOME/bin/java" -cp .mvn/wrapper MavenWrapperDownloader
"$wrapperUrl" "$wrapperJarPath")
-[ $? -eq 0 ] || rm -f "$wrapperJarPath"
+("$JAVA_HOME/bin/java" -cp .mvn/wrapper MavenWrapperDownloader
"$wrapperUrl" "$wrapperJarPath") || rm -f "$wrapperJarPath"
Review Comment:
To be coherent, maybe we should rewrite it to the more simple:
```
"$JAVA_HOME/bin/java" -cp .mvn/wrapper MavenWrapperDownloader "$wrapperUrl"
"$wrapperJarPath"
```
> mvnw is not POSIX compatible
>
>
> Key: MWRAPPER-88
> URL: https://issues.apache.org/jira/browse/MWRAPPER-88
> Project: Maven Wrapper
> Issue Type: Bug
> Components: Maven Wrapper Scripts
>Affects Versions: 3.1.1
>Reporter: Benjamin Marwell
>Assignee: Benjamin Marwell
>Priority: Major
> Labels: posix
>
> * POSIX scripts should not use bash-specific features
> * Fix suggestions from shellcheck
> ([https://github.com/apache/maven-wrapper/pull/74])
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[GitHub] [maven-wrapper] gnodet commented on a diff in pull request #79: [MWRAPPER-88] fix shellcheck findings / POSIX compatiblity
gnodet commented on code in PR #79:
URL: https://github.com/apache/maven-wrapper/pull/79#discussion_r1063547852
##
maven-wrapper-distribution/src/resources/mvnw:
##
@@ -237,8 +243,7 @@ else
fi
if [ -e "$javaClass" ]; then
log " - Running MavenWrapperDownloader.java ..."
-("$JAVA_HOME/bin/java" -cp .mvn/wrapper MavenWrapperDownloader
"$wrapperUrl" "$wrapperJarPath")
-[ $? -eq 0 ] || rm -f "$wrapperJarPath"
+("$JAVA_HOME/bin/java" -cp .mvn/wrapper MavenWrapperDownloader
"$wrapperUrl" "$wrapperJarPath") || rm -f "$wrapperJarPath"
Review Comment:
To be coherent, maybe we should rewrite it to the more simple:
```
"$JAVA_HOME/bin/java" -cp .mvn/wrapper MavenWrapperDownloader "$wrapperUrl"
"$wrapperJarPath"
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Commented] (MWRAPPER-88) mvnw is not POSIX compatible
[
https://issues.apache.org/jira/browse/MWRAPPER-88?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17655489#comment-17655489
]
ASF GitHub Bot commented on MWRAPPER-88:
gnodet commented on code in PR #79:
URL: https://github.com/apache/maven-wrapper/pull/79#discussion_r1063545643
##
maven-wrapper-distribution/src/resources/mvnw:
##
@@ -237,8 +243,7 @@ else
fi
if [ -e "$javaClass" ]; then
log " - Running MavenWrapperDownloader.java ..."
-("$JAVA_HOME/bin/java" -cp .mvn/wrapper MavenWrapperDownloader
"$wrapperUrl" "$wrapperJarPath")
-[ $? -eq 0 ] || rm -f "$wrapperJarPath"
+("$JAVA_HOME/bin/java" -cp .mvn/wrapper MavenWrapperDownloader
"$wrapperUrl" "$wrapperJarPath") || rm -f "$wrapperJarPath"
Review Comment:
The parentheses will create a sub shell, so that if the java command fails,
the script won't end abruptly (unless the curl/wget above).
> mvnw is not POSIX compatible
>
>
> Key: MWRAPPER-88
> URL: https://issues.apache.org/jira/browse/MWRAPPER-88
> Project: Maven Wrapper
> Issue Type: Bug
> Components: Maven Wrapper Scripts
>Affects Versions: 3.1.1
>Reporter: Benjamin Marwell
>Assignee: Benjamin Marwell
>Priority: Major
> Labels: posix
>
> * POSIX scripts should not use bash-specific features
> * Fix suggestions from shellcheck
> ([https://github.com/apache/maven-wrapper/pull/74])
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[GitHub] [maven-wrapper] gnodet commented on a diff in pull request #79: [MWRAPPER-88] fix shellcheck findings / POSIX compatiblity
gnodet commented on code in PR #79:
URL: https://github.com/apache/maven-wrapper/pull/79#discussion_r1063545643
##
maven-wrapper-distribution/src/resources/mvnw:
##
@@ -237,8 +243,7 @@ else
fi
if [ -e "$javaClass" ]; then
log " - Running MavenWrapperDownloader.java ..."
-("$JAVA_HOME/bin/java" -cp .mvn/wrapper MavenWrapperDownloader
"$wrapperUrl" "$wrapperJarPath")
-[ $? -eq 0 ] || rm -f "$wrapperJarPath"
+("$JAVA_HOME/bin/java" -cp .mvn/wrapper MavenWrapperDownloader
"$wrapperUrl" "$wrapperJarPath") || rm -f "$wrapperJarPath"
Review Comment:
The parentheses will create a sub shell, so that if the java command fails,
the script won't end abruptly (unless the curl/wget above).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Commented] (MWRAPPER-88) mvnw is not POSIX compatible
[
https://issues.apache.org/jira/browse/MWRAPPER-88?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17655488#comment-17655488
]
ASF GitHub Bot commented on MWRAPPER-88:
gnodet commented on code in PR #79:
URL: https://github.com/apache/maven-wrapper/pull/79#discussion_r1063544854
##
maven-wrapper-distribution/src/resources/mvnw:
##
@@ -193,42 +193,48 @@ else
else
wrapperUrl="https://repo.maven.apache.org/maven2/org/apache/maven/wrapper/maven-wrapper/@@project.version@@/maven-wrapper-@@project.version@@.jar";
fi
-while IFS="=" read key value; do
+while IFS="=" read -r key value; do
case "$key" in (wrapperUrl) wrapperUrl="$value"; break ;;
esac
done < "$MAVEN_PROJECTBASEDIR/.mvn/wrapper/maven-wrapper.properties"
log "Downloading from: $wrapperUrl"
if $cygwin; then
- wrapperJarPath=`cygpath --path --windows "$wrapperJarPath"`
+ wrapperJarPath=$(cygpath --path --windows "$wrapperJarPath")
fi
if command -v wget > /dev/null; then
log "Found wget ... using wget"
+wgetrc=0
[ "$MVNW_VERBOSE" = true ] && QUIET="" || QUIET="--quiet"
if [ -z "$MVNW_USERNAME" ] || [ -z "$MVNW_PASSWORD" ]; then
wget $QUIET "$wrapperUrl" -O "$wrapperJarPath"
+wgetrc=$?
else
wget $QUIET --http-user="$MVNW_USERNAME"
--http-password="$MVNW_PASSWORD" "$wrapperUrl" -O "$wrapperJarPath"
+wgetrc=$?
fi
-[ $? -eq 0 ] || rm -f "$wrapperJarPath"
+[ $wgetrc -eq 0 ] || rm -f "$wrapperJarPath"
elif command -v curl > /dev/null; then
log "Found curl ... using curl"
+curlrc=0
[ "$MVNW_VERBOSE" = true ] && QUIET="" || QUIET="--silent"
if [ -z "$MVNW_USERNAME" ] || [ -z "$MVNW_PASSWORD" ]; then
curl $QUIET -o "$wrapperJarPath" "$wrapperUrl" -f -L
+curlrc=$?
else
curl $QUIET --user "$MVNW_USERNAME:$MVNW_PASSWORD" -o
"$wrapperJarPath" "$wrapperUrl" -f -L
+curlrc=$?
fi
-[ $? -eq 0 ] || rm -f "$wrapperJarPath"
+[ $curlrc -eq 0 ] || rm -f "$wrapperJarPath"
Review Comment:
```
if command -v wget > /dev/null; then
log "Found wget ... using wget"
[ "$MVNW_VERBOSE" = true ] && QUIET="" || QUIET="--quiet"
{ [ -z "$MVNW_USERNAME" ] || [ -z "$MVNW_PASSWORD" ] ;} \
&& USEROPT="" \
|| USEROPT="--http-user=\"$MVNW_USERNAME\"
--http-password=\"$MVNW_PASSWORD\""
wget $QUIET $USEROPT "$wrapperUrl" -O "$wrapperJarPath"
elif command -v curl > /dev/null; then
log "Found curl ... using curl"
[ "$MVNW_VERBOSE" = true ] && QUIET="" || QUIET="--silent"
{ [ -z "$MVNW_USERNAME" ] || [ -z "$MVNW_PASSWORD" ] ;} \
&& USEROPT="" \
|| USEROPT="--user \"$MVNW_USERNAME:$MVNW_PASSWORD\""
curl $QUIET $USEROPT -o "$wrapperJarPath" "$wrapperUrl" -f -L
else
```
> mvnw is not POSIX compatible
>
>
> Key: MWRAPPER-88
> URL: https://issues.apache.org/jira/browse/MWRAPPER-88
> Project: Maven Wrapper
> Issue Type: Bug
> Components: Maven Wrapper Scripts
>Affects Versions: 3.1.1
>Reporter: Benjamin Marwell
>Assignee: Benjamin Marwell
>Priority: Major
> Labels: posix
>
> * POSIX scripts should not use bash-specific features
> * Fix suggestions from shellcheck
> ([https://github.com/apache/maven-wrapper/pull/74])
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[GitHub] [maven-wrapper] gnodet commented on a diff in pull request #79: [MWRAPPER-88] fix shellcheck findings / POSIX compatiblity
gnodet commented on code in PR #79:
URL: https://github.com/apache/maven-wrapper/pull/79#discussion_r1063544854
##
maven-wrapper-distribution/src/resources/mvnw:
##
@@ -193,42 +193,48 @@ else
else
wrapperUrl="https://repo.maven.apache.org/maven2/org/apache/maven/wrapper/maven-wrapper/@@project.version@@/maven-wrapper-@@project.version@@.jar";
fi
-while IFS="=" read key value; do
+while IFS="=" read -r key value; do
case "$key" in (wrapperUrl) wrapperUrl="$value"; break ;;
esac
done < "$MAVEN_PROJECTBASEDIR/.mvn/wrapper/maven-wrapper.properties"
log "Downloading from: $wrapperUrl"
if $cygwin; then
- wrapperJarPath=`cygpath --path --windows "$wrapperJarPath"`
+ wrapperJarPath=$(cygpath --path --windows "$wrapperJarPath")
fi
if command -v wget > /dev/null; then
log "Found wget ... using wget"
+wgetrc=0
[ "$MVNW_VERBOSE" = true ] && QUIET="" || QUIET="--quiet"
if [ -z "$MVNW_USERNAME" ] || [ -z "$MVNW_PASSWORD" ]; then
wget $QUIET "$wrapperUrl" -O "$wrapperJarPath"
+wgetrc=$?
else
wget $QUIET --http-user="$MVNW_USERNAME"
--http-password="$MVNW_PASSWORD" "$wrapperUrl" -O "$wrapperJarPath"
+wgetrc=$?
fi
-[ $? -eq 0 ] || rm -f "$wrapperJarPath"
+[ $wgetrc -eq 0 ] || rm -f "$wrapperJarPath"
elif command -v curl > /dev/null; then
log "Found curl ... using curl"
+curlrc=0
[ "$MVNW_VERBOSE" = true ] && QUIET="" || QUIET="--silent"
if [ -z "$MVNW_USERNAME" ] || [ -z "$MVNW_PASSWORD" ]; then
curl $QUIET -o "$wrapperJarPath" "$wrapperUrl" -f -L
+curlrc=$?
else
curl $QUIET --user "$MVNW_USERNAME:$MVNW_PASSWORD" -o
"$wrapperJarPath" "$wrapperUrl" -f -L
+curlrc=$?
fi
-[ $? -eq 0 ] || rm -f "$wrapperJarPath"
+[ $curlrc -eq 0 ] || rm -f "$wrapperJarPath"
Review Comment:
```
if command -v wget > /dev/null; then
log "Found wget ... using wget"
[ "$MVNW_VERBOSE" = true ] && QUIET="" || QUIET="--quiet"
{ [ -z "$MVNW_USERNAME" ] || [ -z "$MVNW_PASSWORD" ] ;} \
&& USEROPT="" \
|| USEROPT="--http-user=\"$MVNW_USERNAME\"
--http-password=\"$MVNW_PASSWORD\""
wget $QUIET $USEROPT "$wrapperUrl" -O "$wrapperJarPath"
elif command -v curl > /dev/null; then
log "Found curl ... using curl"
[ "$MVNW_VERBOSE" = true ] && QUIET="" || QUIET="--silent"
{ [ -z "$MVNW_USERNAME" ] || [ -z "$MVNW_PASSWORD" ] ;} \
&& USEROPT="" \
|| USEROPT="--user \"$MVNW_USERNAME:$MVNW_PASSWORD\""
curl $QUIET $USEROPT -o "$wrapperJarPath" "$wrapperUrl" -f -L
else
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Commented] (MWRAPPER-88) mvnw is not POSIX compatible
[ https://issues.apache.org/jira/browse/MWRAPPER-88?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17655486#comment-17655486 ] ASF GitHub Bot commented on MWRAPPER-88: gnodet commented on code in PR #79: URL: https://github.com/apache/maven-wrapper/pull/79#discussion_r1063543811 ## maven-wrapper-distribution/src/resources/mvnw: ## @@ -193,42 +193,48 @@ else else wrapperUrl="https://repo.maven.apache.org/maven2/org/apache/maven/wrapper/maven-wrapper/@@project.version@@/maven-wrapper-@@project.version@@.jar"; fi -while IFS="=" read key value; do +while IFS="=" read -r key value; do case "$key" in (wrapperUrl) wrapperUrl="$value"; break ;; esac done < "$MAVEN_PROJECTBASEDIR/.mvn/wrapper/maven-wrapper.properties" log "Downloading from: $wrapperUrl" if $cygwin; then - wrapperJarPath=`cygpath --path --windows "$wrapperJarPath"` + wrapperJarPath=$(cygpath --path --windows "$wrapperJarPath") fi if command -v wget > /dev/null; then log "Found wget ... using wget" +wgetrc=0 [ "$MVNW_VERBOSE" = true ] && QUIET="" || QUIET="--quiet" if [ -z "$MVNW_USERNAME" ] || [ -z "$MVNW_PASSWORD" ]; then wget $QUIET "$wrapperUrl" -O "$wrapperJarPath" +wgetrc=$? else wget $QUIET --http-user="$MVNW_USERNAME" --http-password="$MVNW_PASSWORD" "$wrapperUrl" -O "$wrapperJarPath" +wgetrc=$? fi -[ $? -eq 0 ] || rm -f "$wrapperJarPath" +[ $wgetrc -eq 0 ] || rm -f "$wrapperJarPath" elif command -v curl > /dev/null; then log "Found curl ... using curl" +curlrc=0 [ "$MVNW_VERBOSE" = true ] && QUIET="" || QUIET="--silent" if [ -z "$MVNW_USERNAME" ] || [ -z "$MVNW_PASSWORD" ]; then curl $QUIET -o "$wrapperJarPath" "$wrapperUrl" -f -L +curlrc=$? else curl $QUIET --user "$MVNW_USERNAME:$MVNW_PASSWORD" -o "$wrapperJarPath" "$wrapperUrl" -f -L +curlrc=$? fi -[ $? -eq 0 ] || rm -f "$wrapperJarPath" +[ $curlrc -eq 0 ] || rm -f "$wrapperJarPath" Review Comment: Do I miss something or the shell will exit if curl/wget fail ? If so the `rm -f "$wrapperJarPath"` is useless anyway... > mvnw is not POSIX compatible > > > Key: MWRAPPER-88 > URL: https://issues.apache.org/jira/browse/MWRAPPER-88 > Project: Maven Wrapper > Issue Type: Bug > Components: Maven Wrapper Scripts >Affects Versions: 3.1.1 >Reporter: Benjamin Marwell >Assignee: Benjamin Marwell >Priority: Major > Labels: posix > > * POSIX scripts should not use bash-specific features > * Fix suggestions from shellcheck > ([https://github.com/apache/maven-wrapper/pull/74]) -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [maven-wrapper] gnodet commented on a diff in pull request #79: [MWRAPPER-88] fix shellcheck findings / POSIX compatiblity
gnodet commented on code in PR #79: URL: https://github.com/apache/maven-wrapper/pull/79#discussion_r1063543811 ## maven-wrapper-distribution/src/resources/mvnw: ## @@ -193,42 +193,48 @@ else else wrapperUrl="https://repo.maven.apache.org/maven2/org/apache/maven/wrapper/maven-wrapper/@@project.version@@/maven-wrapper-@@project.version@@.jar"; fi -while IFS="=" read key value; do +while IFS="=" read -r key value; do case "$key" in (wrapperUrl) wrapperUrl="$value"; break ;; esac done < "$MAVEN_PROJECTBASEDIR/.mvn/wrapper/maven-wrapper.properties" log "Downloading from: $wrapperUrl" if $cygwin; then - wrapperJarPath=`cygpath --path --windows "$wrapperJarPath"` + wrapperJarPath=$(cygpath --path --windows "$wrapperJarPath") fi if command -v wget > /dev/null; then log "Found wget ... using wget" +wgetrc=0 [ "$MVNW_VERBOSE" = true ] && QUIET="" || QUIET="--quiet" if [ -z "$MVNW_USERNAME" ] || [ -z "$MVNW_PASSWORD" ]; then wget $QUIET "$wrapperUrl" -O "$wrapperJarPath" +wgetrc=$? else wget $QUIET --http-user="$MVNW_USERNAME" --http-password="$MVNW_PASSWORD" "$wrapperUrl" -O "$wrapperJarPath" +wgetrc=$? fi -[ $? -eq 0 ] || rm -f "$wrapperJarPath" +[ $wgetrc -eq 0 ] || rm -f "$wrapperJarPath" elif command -v curl > /dev/null; then log "Found curl ... using curl" +curlrc=0 [ "$MVNW_VERBOSE" = true ] && QUIET="" || QUIET="--silent" if [ -z "$MVNW_USERNAME" ] || [ -z "$MVNW_PASSWORD" ]; then curl $QUIET -o "$wrapperJarPath" "$wrapperUrl" -f -L +curlrc=$? else curl $QUIET --user "$MVNW_USERNAME:$MVNW_PASSWORD" -o "$wrapperJarPath" "$wrapperUrl" -f -L +curlrc=$? fi -[ $? -eq 0 ] || rm -f "$wrapperJarPath" +[ $curlrc -eq 0 ] || rm -f "$wrapperJarPath" Review Comment: Do I miss something or the shell will exit if curl/wget fail ? If so the `rm -f "$wrapperJarPath"` is useless anyway... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MWRAPPER-33) Use java 8 in maven-wrapper
[
https://issues.apache.org/jira/browse/MWRAPPER-33?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17655485#comment-17655485
]
ASF GitHub Bot commented on MWRAPPER-33:
bmarwell merged PR #80:
URL: https://github.com/apache/maven-wrapper/pull/80
> Use java 8 in maven-wrapper
> ---
>
> Key: MWRAPPER-33
> URL: https://issues.apache.org/jira/browse/MWRAPPER-33
> Project: Maven Wrapper
> Issue Type: Improvement
> Components: Maven Wrapper Jar
>Affects Versions: 3.1.0
>Reporter: Slawomir Jaranowski
>Assignee: Benjamin Marwell
>Priority: Major
> Labels: up-for-grabs
> Fix For: 3.2.0
>
>
> Currently {{maven-wrapper}} use java {*}5{*}.
> It blocks build project on java > 8.
> {{maven-wrapper-plugin}} require java 8, so we can use {{maven-wrapper}} with
> java 5 but we can't install it.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[GitHub] [maven-wrapper] bmarwell merged pull request #80: [MWRAPPER-33] Adopt Java 8 constructs
bmarwell merged PR #80: URL: https://github.com/apache/maven-wrapper/pull/80 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MWRAPPER-88) mvnw is not POSIX compatible
[
https://issues.apache.org/jira/browse/MWRAPPER-88?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17655483#comment-17655483
]
ASF GitHub Bot commented on MWRAPPER-88:
gnodet commented on code in PR #79:
URL: https://github.com/apache/maven-wrapper/pull/79#discussion_r1063539117
##
maven-wrapper-distribution/src/resources/mvnw:
##
@@ -193,42 +193,48 @@ else
else
wrapperUrl="https://repo.maven.apache.org/maven2/org/apache/maven/wrapper/maven-wrapper/@@project.version@@/maven-wrapper-@@project.version@@.jar";
fi
-while IFS="=" read key value; do
+while IFS="=" read -r key value; do
case "$key" in (wrapperUrl) wrapperUrl="$value"; break ;;
esac
done < "$MAVEN_PROJECTBASEDIR/.mvn/wrapper/maven-wrapper.properties"
log "Downloading from: $wrapperUrl"
if $cygwin; then
- wrapperJarPath=`cygpath --path --windows "$wrapperJarPath"`
+ wrapperJarPath=$(cygpath --path --windows "$wrapperJarPath")
fi
if command -v wget > /dev/null; then
log "Found wget ... using wget"
+wgetrc=0
[ "$MVNW_VERBOSE" = true ] && QUIET="" || QUIET="--quiet"
if [ -z "$MVNW_USERNAME" ] || [ -z "$MVNW_PASSWORD" ]; then
wget $QUIET "$wrapperUrl" -O "$wrapperJarPath"
+wgetrc=$?
else
wget $QUIET --http-user="$MVNW_USERNAME"
--http-password="$MVNW_PASSWORD" "$wrapperUrl" -O "$wrapperJarPath"
+wgetrc=$?
fi
-[ $? -eq 0 ] || rm -f "$wrapperJarPath"
+[ $wgetrc -eq 0 ] || rm -f "$wrapperJarPath"
elif command -v curl > /dev/null; then
log "Found curl ... using curl"
+curlrc=0
[ "$MVNW_VERBOSE" = true ] && QUIET="" || QUIET="--silent"
if [ -z "$MVNW_USERNAME" ] || [ -z "$MVNW_PASSWORD" ]; then
curl $QUIET -o "$wrapperJarPath" "$wrapperUrl" -f -L
+curlrc=$?
else
curl $QUIET --user "$MVNW_USERNAME:$MVNW_PASSWORD" -o
"$wrapperJarPath" "$wrapperUrl" -f -L
+curlrc=$?
fi
-[ $? -eq 0 ] || rm -f "$wrapperJarPath"
+[ $curlrc -eq 0 ] || rm -f "$wrapperJarPath"
Review Comment:
What about:
```
if command -v wget > /dev/null; then
log "Found wget ... using wget"
[ "$MVNW_VERBOSE" = true ] && QUIET="" || QUIET="--quiet"
{ [ -z "$MVNW_USERNAME" ] || [ -z "$MVNW_PASSWORD" ] ;} \
&& USEROPT="" \
|| USEROPT="--http-user=\"$MVNW_USERNAME\"
--http-password=\"$MVNW_PASSWORD\""
wget $QUIET $USEROPT "$wrapperUrl" -O "$wrapperJarPath" \
|| rm -f "$wrapperJarPath"
elif command -v curl > /dev/null; then
log "Found curl ... using curl"
[ "$MVNW_VERBOSE" = true ] && QUIET="" || QUIET="--silent"
{ [ -z "$MVNW_USERNAME" ] || [ -z "$MVNW_PASSWORD" ] ;} \
&& USEROPT="" \
|| USEROPT="--user \"$MVNW_USERNAME:$MVNW_PASSWORD\""
curl $QUIET $USEROPT -o "$wrapperJarPath" "$wrapperUrl" -f -L \
|| rm -f "$wrapperJarPath"
else
```
> mvnw is not POSIX compatible
>
>
> Key: MWRAPPER-88
> URL: https://issues.apache.org/jira/browse/MWRAPPER-88
> Project: Maven Wrapper
> Issue Type: Bug
> Components: Maven Wrapper Scripts
>Affects Versions: 3.1.1
>Reporter: Benjamin Marwell
>Assignee: Benjamin Marwell
>Priority: Major
> Labels: posix
>
> * POSIX scripts should not use bash-specific features
> * Fix suggestions from shellcheck
> ([https://github.com/apache/maven-wrapper/pull/74])
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MWRAPPER-88) mvnw is not POSIX compatible
[
https://issues.apache.org/jira/browse/MWRAPPER-88?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17655482#comment-17655482
]
ASF GitHub Bot commented on MWRAPPER-88:
gnodet commented on code in PR #79:
URL: https://github.com/apache/maven-wrapper/pull/79#discussion_r1063539117
##
maven-wrapper-distribution/src/resources/mvnw:
##
@@ -193,42 +193,48 @@ else
else
wrapperUrl="https://repo.maven.apache.org/maven2/org/apache/maven/wrapper/maven-wrapper/@@project.version@@/maven-wrapper-@@project.version@@.jar";
fi
-while IFS="=" read key value; do
+while IFS="=" read -r key value; do
case "$key" in (wrapperUrl) wrapperUrl="$value"; break ;;
esac
done < "$MAVEN_PROJECTBASEDIR/.mvn/wrapper/maven-wrapper.properties"
log "Downloading from: $wrapperUrl"
if $cygwin; then
- wrapperJarPath=`cygpath --path --windows "$wrapperJarPath"`
+ wrapperJarPath=$(cygpath --path --windows "$wrapperJarPath")
fi
if command -v wget > /dev/null; then
log "Found wget ... using wget"
+wgetrc=0
[ "$MVNW_VERBOSE" = true ] && QUIET="" || QUIET="--quiet"
if [ -z "$MVNW_USERNAME" ] || [ -z "$MVNW_PASSWORD" ]; then
wget $QUIET "$wrapperUrl" -O "$wrapperJarPath"
+wgetrc=$?
else
wget $QUIET --http-user="$MVNW_USERNAME"
--http-password="$MVNW_PASSWORD" "$wrapperUrl" -O "$wrapperJarPath"
+wgetrc=$?
fi
-[ $? -eq 0 ] || rm -f "$wrapperJarPath"
+[ $wgetrc -eq 0 ] || rm -f "$wrapperJarPath"
elif command -v curl > /dev/null; then
log "Found curl ... using curl"
+curlrc=0
[ "$MVNW_VERBOSE" = true ] && QUIET="" || QUIET="--silent"
if [ -z "$MVNW_USERNAME" ] || [ -z "$MVNW_PASSWORD" ]; then
curl $QUIET -o "$wrapperJarPath" "$wrapperUrl" -f -L
+curlrc=$?
else
curl $QUIET --user "$MVNW_USERNAME:$MVNW_PASSWORD" -o
"$wrapperJarPath" "$wrapperUrl" -f -L
+curlrc=$?
fi
-[ $? -eq 0 ] || rm -f "$wrapperJarPath"
+[ $curlrc -eq 0 ] || rm -f "$wrapperJarPath"
Review Comment:
What about:
```
if command -v wget > /dev/null; then
log "Found wget ... using wget"
[ "$MVNW_VERBOSE" = true ] && QUIET="" || QUIET="--quiet"
{ [ -z "$MVNW_USERNAME" ] || [ -z "$MVNW_PASSWORD" ] ;} \
&& USEROPT="" \
|| USEROPT="--http-user=\"$MVNW_USERNAME\"
--http-password=\"$MVNW_PASSWORD\""
log wget $QUIET $USEROPT "$wrapperUrl" -O "$wrapperJarPath"
wget $QUIET $USEROPT "$wrapperUrl" -O "$wrapperJarPath" \
|| rm -f "$wrapperJarPath"
elif command -v curl > /dev/null; then
log "Found curl ... using curl"
[ "$MVNW_VERBOSE" = true ] && QUIET="" || QUIET="--silent"
{ [ -z "$MVNW_USERNAME" ] || [ -z "$MVNW_PASSWORD" ] ;} \
&& USEROPT="" \
|| USEROPT="--user \"$MVNW_USERNAME:$MVNW_PASSWORD\""
curl $QUIET $USEROPT -o "$wrapperJarPath" "$wrapperUrl" -f -L \
|| rm -f "$wrapperJarPath"
else
```
> mvnw is not POSIX compatible
>
>
> Key: MWRAPPER-88
> URL: https://issues.apache.org/jira/browse/MWRAPPER-88
> Project: Maven Wrapper
> Issue Type: Bug
> Components: Maven Wrapper Scripts
>Affects Versions: 3.1.1
>Reporter: Benjamin Marwell
>Assignee: Benjamin Marwell
>Priority: Major
> Labels: posix
>
> * POSIX scripts should not use bash-specific features
> * Fix suggestions from shellcheck
> ([https://github.com/apache/maven-wrapper/pull/74])
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[GitHub] [maven-wrapper] gnodet commented on a diff in pull request #79: [MWRAPPER-88] fix shellcheck findings / POSIX compatiblity
gnodet commented on code in PR #79:
URL: https://github.com/apache/maven-wrapper/pull/79#discussion_r1063539117
##
maven-wrapper-distribution/src/resources/mvnw:
##
@@ -193,42 +193,48 @@ else
else
wrapperUrl="https://repo.maven.apache.org/maven2/org/apache/maven/wrapper/maven-wrapper/@@project.version@@/maven-wrapper-@@project.version@@.jar";
fi
-while IFS="=" read key value; do
+while IFS="=" read -r key value; do
case "$key" in (wrapperUrl) wrapperUrl="$value"; break ;;
esac
done < "$MAVEN_PROJECTBASEDIR/.mvn/wrapper/maven-wrapper.properties"
log "Downloading from: $wrapperUrl"
if $cygwin; then
- wrapperJarPath=`cygpath --path --windows "$wrapperJarPath"`
+ wrapperJarPath=$(cygpath --path --windows "$wrapperJarPath")
fi
if command -v wget > /dev/null; then
log "Found wget ... using wget"
+wgetrc=0
[ "$MVNW_VERBOSE" = true ] && QUIET="" || QUIET="--quiet"
if [ -z "$MVNW_USERNAME" ] || [ -z "$MVNW_PASSWORD" ]; then
wget $QUIET "$wrapperUrl" -O "$wrapperJarPath"
+wgetrc=$?
else
wget $QUIET --http-user="$MVNW_USERNAME"
--http-password="$MVNW_PASSWORD" "$wrapperUrl" -O "$wrapperJarPath"
+wgetrc=$?
fi
-[ $? -eq 0 ] || rm -f "$wrapperJarPath"
+[ $wgetrc -eq 0 ] || rm -f "$wrapperJarPath"
elif command -v curl > /dev/null; then
log "Found curl ... using curl"
+curlrc=0
[ "$MVNW_VERBOSE" = true ] && QUIET="" || QUIET="--silent"
if [ -z "$MVNW_USERNAME" ] || [ -z "$MVNW_PASSWORD" ]; then
curl $QUIET -o "$wrapperJarPath" "$wrapperUrl" -f -L
+curlrc=$?
else
curl $QUIET --user "$MVNW_USERNAME:$MVNW_PASSWORD" -o
"$wrapperJarPath" "$wrapperUrl" -f -L
+curlrc=$?
fi
-[ $? -eq 0 ] || rm -f "$wrapperJarPath"
+[ $curlrc -eq 0 ] || rm -f "$wrapperJarPath"
Review Comment:
What about:
```
if command -v wget > /dev/null; then
log "Found wget ... using wget"
[ "$MVNW_VERBOSE" = true ] && QUIET="" || QUIET="--quiet"
{ [ -z "$MVNW_USERNAME" ] || [ -z "$MVNW_PASSWORD" ] ;} \
&& USEROPT="" \
|| USEROPT="--http-user=\"$MVNW_USERNAME\"
--http-password=\"$MVNW_PASSWORD\""
wget $QUIET $USEROPT "$wrapperUrl" -O "$wrapperJarPath" \
|| rm -f "$wrapperJarPath"
elif command -v curl > /dev/null; then
log "Found curl ... using curl"
[ "$MVNW_VERBOSE" = true ] && QUIET="" || QUIET="--silent"
{ [ -z "$MVNW_USERNAME" ] || [ -z "$MVNW_PASSWORD" ] ;} \
&& USEROPT="" \
|| USEROPT="--user \"$MVNW_USERNAME:$MVNW_PASSWORD\""
curl $QUIET $USEROPT -o "$wrapperJarPath" "$wrapperUrl" -f -L \
|| rm -f "$wrapperJarPath"
else
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [maven-wrapper] gnodet commented on a diff in pull request #79: [MWRAPPER-88] fix shellcheck findings / POSIX compatiblity
gnodet commented on code in PR #79:
URL: https://github.com/apache/maven-wrapper/pull/79#discussion_r1063539117
##
maven-wrapper-distribution/src/resources/mvnw:
##
@@ -193,42 +193,48 @@ else
else
wrapperUrl="https://repo.maven.apache.org/maven2/org/apache/maven/wrapper/maven-wrapper/@@project.version@@/maven-wrapper-@@project.version@@.jar";
fi
-while IFS="=" read key value; do
+while IFS="=" read -r key value; do
case "$key" in (wrapperUrl) wrapperUrl="$value"; break ;;
esac
done < "$MAVEN_PROJECTBASEDIR/.mvn/wrapper/maven-wrapper.properties"
log "Downloading from: $wrapperUrl"
if $cygwin; then
- wrapperJarPath=`cygpath --path --windows "$wrapperJarPath"`
+ wrapperJarPath=$(cygpath --path --windows "$wrapperJarPath")
fi
if command -v wget > /dev/null; then
log "Found wget ... using wget"
+wgetrc=0
[ "$MVNW_VERBOSE" = true ] && QUIET="" || QUIET="--quiet"
if [ -z "$MVNW_USERNAME" ] || [ -z "$MVNW_PASSWORD" ]; then
wget $QUIET "$wrapperUrl" -O "$wrapperJarPath"
+wgetrc=$?
else
wget $QUIET --http-user="$MVNW_USERNAME"
--http-password="$MVNW_PASSWORD" "$wrapperUrl" -O "$wrapperJarPath"
+wgetrc=$?
fi
-[ $? -eq 0 ] || rm -f "$wrapperJarPath"
+[ $wgetrc -eq 0 ] || rm -f "$wrapperJarPath"
elif command -v curl > /dev/null; then
log "Found curl ... using curl"
+curlrc=0
[ "$MVNW_VERBOSE" = true ] && QUIET="" || QUIET="--silent"
if [ -z "$MVNW_USERNAME" ] || [ -z "$MVNW_PASSWORD" ]; then
curl $QUIET -o "$wrapperJarPath" "$wrapperUrl" -f -L
+curlrc=$?
else
curl $QUIET --user "$MVNW_USERNAME:$MVNW_PASSWORD" -o
"$wrapperJarPath" "$wrapperUrl" -f -L
+curlrc=$?
fi
-[ $? -eq 0 ] || rm -f "$wrapperJarPath"
+[ $curlrc -eq 0 ] || rm -f "$wrapperJarPath"
Review Comment:
What about:
```
if command -v wget > /dev/null; then
log "Found wget ... using wget"
[ "$MVNW_VERBOSE" = true ] && QUIET="" || QUIET="--quiet"
{ [ -z "$MVNW_USERNAME" ] || [ -z "$MVNW_PASSWORD" ] ;} \
&& USEROPT="" \
|| USEROPT="--http-user=\"$MVNW_USERNAME\"
--http-password=\"$MVNW_PASSWORD\""
log wget $QUIET $USEROPT "$wrapperUrl" -O "$wrapperJarPath"
wget $QUIET $USEROPT "$wrapperUrl" -O "$wrapperJarPath" \
|| rm -f "$wrapperJarPath"
elif command -v curl > /dev/null; then
log "Found curl ... using curl"
[ "$MVNW_VERBOSE" = true ] && QUIET="" || QUIET="--silent"
{ [ -z "$MVNW_USERNAME" ] || [ -z "$MVNW_PASSWORD" ] ;} \
&& USEROPT="" \
|| USEROPT="--user \"$MVNW_USERNAME:$MVNW_PASSWORD\""
curl $QUIET $USEROPT -o "$wrapperJarPath" "$wrapperUrl" -f -L \
|| rm -f "$wrapperJarPath"
else
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Commented] (MWRAPPER-88) mvnw is not POSIX compatible
[
https://issues.apache.org/jira/browse/MWRAPPER-88?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17655481#comment-17655481
]
ASF GitHub Bot commented on MWRAPPER-88:
bmarwell commented on code in PR #79:
URL: https://github.com/apache/maven-wrapper/pull/79#discussion_r1063537820
##
.github/workflows/shellcheck-posix.yml:
##
@@ -39,7 +39,7 @@ jobs:
- name: check
run: |
echo "$GITHUB_WORKSPACE/shellcheck-v${SHELLCHECK_VERSION}" >>
$GITHUB_PATH
- readarray -t SCRIPT_FILES < <(grep -ErIl
'^#![[:blank:]]*/bin/(ba|da|c|k)?sh'
"$GITHUB_WORKSPACE/maven-wrapper-distribution/src/resources")
+ readarray -t SCRIPT_FILES < <(grep -ErIl -e
'^#![[:blank:]]*/bin/(ba|da|c|k)?sh' -e
'^#!/usr/bin/env[[:blank:]]+(ba|da|c|k)?sh'
"$GITHUB_WORKSPACE/maven-wrapper-distribution/src/resources")
Review Comment:
Can do. But then, we should only write POSIX scripts so it runs everywhere.
This would only be needed for shell specific scripts. I'd consider it optional,
but will add it later.
Thanks for the finding.
> mvnw is not POSIX compatible
>
>
> Key: MWRAPPER-88
> URL: https://issues.apache.org/jira/browse/MWRAPPER-88
> Project: Maven Wrapper
> Issue Type: Bug
> Components: Maven Wrapper Scripts
>Affects Versions: 3.1.1
>Reporter: Benjamin Marwell
>Assignee: Benjamin Marwell
>Priority: Major
> Labels: posix
>
> * POSIX scripts should not use bash-specific features
> * Fix suggestions from shellcheck
> ([https://github.com/apache/maven-wrapper/pull/74])
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[GitHub] [maven-wrapper] bmarwell commented on a diff in pull request #79: [MWRAPPER-88] fix shellcheck findings / POSIX compatiblity
bmarwell commented on code in PR #79:
URL: https://github.com/apache/maven-wrapper/pull/79#discussion_r1063537820
##
.github/workflows/shellcheck-posix.yml:
##
@@ -39,7 +39,7 @@ jobs:
- name: check
run: |
echo "$GITHUB_WORKSPACE/shellcheck-v${SHELLCHECK_VERSION}" >>
$GITHUB_PATH
- readarray -t SCRIPT_FILES < <(grep -ErIl
'^#![[:blank:]]*/bin/(ba|da|c|k)?sh'
"$GITHUB_WORKSPACE/maven-wrapper-distribution/src/resources")
+ readarray -t SCRIPT_FILES < <(grep -ErIl -e
'^#![[:blank:]]*/bin/(ba|da|c|k)?sh' -e
'^#!/usr/bin/env[[:blank:]]+(ba|da|c|k)?sh'
"$GITHUB_WORKSPACE/maven-wrapper-distribution/src/resources")
Review Comment:
Can do. But then, we should only write POSIX scripts so it runs everywhere.
This would only be needed for shell specific scripts. I'd consider it optional,
but will add it later.
Thanks for the finding.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Commented] (MWRAPPER-88) mvnw is not POSIX compatible
[ https://issues.apache.org/jira/browse/MWRAPPER-88?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17655480#comment-17655480 ] ASF GitHub Bot commented on MWRAPPER-88: bmarwell commented on code in PR #79: URL: https://github.com/apache/maven-wrapper/pull/79#discussion_r1063536293 ## maven-wrapper-distribution/src/resources/mvnw: ## @@ -118,7 +118,7 @@ if [ -z "$JAVACMD" ] ; then JAVACMD="$JAVA_HOME/bin/java" fi else -JAVACMD="`\\unset -f command; \\command -v java`" +JAVACMD="$(\\unset -f command; \\command -v java)" Review Comment: A backslash usually means "don't use the alias if it exists". The double backslash was probably used b/c of backticks which we got rid of. > mvnw is not POSIX compatible > > > Key: MWRAPPER-88 > URL: https://issues.apache.org/jira/browse/MWRAPPER-88 > Project: Maven Wrapper > Issue Type: Bug > Components: Maven Wrapper Scripts >Affects Versions: 3.1.1 >Reporter: Benjamin Marwell >Assignee: Benjamin Marwell >Priority: Major > Labels: posix > > * POSIX scripts should not use bash-specific features > * Fix suggestions from shellcheck > ([https://github.com/apache/maven-wrapper/pull/74]) -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [maven-wrapper] bmarwell commented on a diff in pull request #79: [MWRAPPER-88] fix shellcheck findings / POSIX compatiblity
bmarwell commented on code in PR #79: URL: https://github.com/apache/maven-wrapper/pull/79#discussion_r1063536293 ## maven-wrapper-distribution/src/resources/mvnw: ## @@ -118,7 +118,7 @@ if [ -z "$JAVACMD" ] ; then JAVACMD="$JAVA_HOME/bin/java" fi else -JAVACMD="`\\unset -f command; \\command -v java`" +JAVACMD="$(\\unset -f command; \\command -v java)" Review Comment: A backslash usually means "don't use the alias if it exists". The double backslash was probably used b/c of backticks which we got rid of. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (MENFORCER-456) New Enforcer API - RuleConfigProvider
Slawomir Jaranowski created MENFORCER-456:
-
Summary: New Enforcer API - RuleConfigProvider
Key: MENFORCER-456
URL: https://issues.apache.org/jira/browse/MENFORCER-456
Project: Maven Enforcer Plugin
Issue Type: New Feature
Reporter: Slawomir Jaranowski
Assignee: Slawomir Jaranowski
Fix For: 3.2.0
We have a case when one Rule, eg {{ExternalRules}} need to provide more rules
for executing.
Rule should not create next rules, it must be done by Mojo itself in order to
properly configure new Rule.
So we need special API for such case - Rule will can provide only configuration
for new Rules, and Rules will be crated by Mojo.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[GitHub] [maven-enforcer] dependabot[bot] opened a new pull request, #219: Bump assertj-core from 3.23.1 to 3.24.0
dependabot[bot] opened a new pull request, #219: URL: https://github.com/apache/maven-enforcer/pull/219 Bumps assertj-core from 3.23.1 to 3.24.0. [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Closed] (MENFORCER-455) New Enforcer API
[ https://issues.apache.org/jira/browse/MENFORCER-455?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Slawomir Jaranowski closed MENFORCER-455. - Resolution: Fixed > New Enforcer API > > > Key: MENFORCER-455 > URL: https://issues.apache.org/jira/browse/MENFORCER-455 > Project: Maven Enforcer Plugin > Issue Type: Improvement >Reporter: Slawomir Jaranowski >Assignee: Slawomir Jaranowski >Priority: Major > Fix For: 3.2.0 > > > Current Enforcer API was based on Maven/Plexus configuration, where each rule > must be in the same package as plugin implementation. > When rule is in another package user must provide implementation attribute on > rule tag with full class name of rule. > After MENFORCER-453 - we can implement rule as JSR 330 components. > So package of rule will be not important. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MNG-7662) Allow Graphbuilder to use session scoped components
[
https://issues.apache.org/jira/browse/MNG-7662?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17655464#comment-17655464
]
ASF GitHub Bot commented on MNG-7662:
-
gnodet commented on PR #948:
URL: https://github.com/apache/maven/pull/948#issuecomment-1373699754
> > Also, there is an existing workaround which I think I've used somewhere,
but I can't recall where exactly.
>
> This seems simlar to my aproach here, jsut that I more liek to fix it in
maven itself than in my beans :-)
>
> > I still think this should be done automatically, but not sure I'll have
the time to dig much into sisu/guice...
>
> maybe but I must confess that lazy lookup here seems easier ...
>
> > It may be preferable to use the workaround which will work on any maven
version imho.
>
> I already have some workarounds, bt my goal i to get it fixed instead of
running into the same issues again afterwards.
I think the
[`SessionScoped`](https://github.com/apache/maven/blob/master/maven-core/src/main/java/org/apache/maven/session/scope/internal/SessionScope.java)
class (and execution scope) could be a good candidate to implement transparent
proxying.
> Allow Graphbuilder to use session scoped components
> ---
>
> Key: MNG-7662
> URL: https://issues.apache.org/jira/browse/MNG-7662
> Project: Maven
> Issue Type: Bug
>Reporter: Christoph Läubrich
>Priority: Major
>
> Currently DefaultMaven gets the Graphbuilder injected as a strict requirement
> at a very early stage. This leads to the problem, that a GraphBuilder
> implementation can not use any SessionScoped Components (because the session
> scope is not setup yet).
> The error then is
> {code:java}
> 1) Error in custom provider, com.google.inject.OutOfScopeException: Cannot
> access Key[type=org.apache.maven.execution.MavenSession, annotation=[none]]
> outside of a scoping block
> at
> org.apache.maven.session.scope.internal.SessionScopeModule.configure(SessionScopeModule.java:64)
> (via modules: org.eclipse.sisu.wire.WireModule ->
> org.apache.maven.session.scope.internal.SessionScopeModule)
> while locating org.apache.maven.execution.MavenSession
> for the 1st parameter of
> org.eclipse.tycho.helper.PluginRealmHelper.(Unknown Source)
> at ClassRealm[coreExtension>org.eclipse.tycho:tycho-build:${tycho-version},
> parent: ClassRealm[plexus.core, parent: null]] (via modules:
> org.eclipse.sisu.wire.WireModule ->
> org.eclipse.sisu.plexus.PlexusBindingModule)
> while locating org.eclipse.tycho.helper.PluginRealmHelper
> at ClassRealm[coreExtension>org.eclipse.tycho:tycho-build:${tycho-version},
> parent: ClassRealm[plexus.core, parent: null]] (via modules:
> org.eclipse.sisu.wire.WireModule ->
> org.eclipse.sisu.plexus.PlexusBindingModule)
> while locating org.eclipse.tycho.p2maven.InstallableUnitGenerator
> at ClassRealm[coreExtension>org.eclipse.tycho:tycho-build:${tycho-version},
> parent: ClassRealm[plexus.core, parent: null]] (via modules:
> org.eclipse.sisu.wire.WireModule ->
> org.eclipse.sisu.plexus.PlexusBindingModule)
> while locating org.eclipse.tycho.p2maven.MavenProjectDependencyProcessor
> while locating org.eclipse.tycho.build.TychoGraphBuilder
> {code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[GitHub] [maven] gnodet commented on pull request #948: MNG-7662 - Allow Graphbuilder to use session scoped components
gnodet commented on PR #948: URL: https://github.com/apache/maven/pull/948#issuecomment-1373699754 > > Also, there is an existing workaround which I think I've used somewhere, but I can't recall where exactly. > > This seems simlar to my aproach here, jsut that I more liek to fix it in maven itself than in my beans :-) > > > I still think this should be done automatically, but not sure I'll have the time to dig much into sisu/guice... > > maybe but I must confess that lazy lookup here seems easier ... > > > It may be preferable to use the workaround which will work on any maven version imho. > > I already have some workarounds, bt my goal i to get it fixed instead of running into the same issues again afterwards. I think the [`SessionScoped`](https://github.com/apache/maven/blob/master/maven-core/src/main/java/org/apache/maven/session/scope/internal/SessionScope.java) class (and execution scope) could be a good candidate to implement transparent proxying. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-enforcer] kwin opened a new pull request, #218: [MENFORCER-444] Improve error message for failed version rules
kwin opened a new pull request, #218: URL: https://github.com/apache/maven-enforcer/pull/218 Convert lower bound only value to proper range string in message Following this checklist to help us incorporate your contribution quickly and easily: - [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/MENFORCER) filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes. - [ ] Each commit in the pull request should have a meaningful subject line and body. - [ ] Format the pull request title like `[MENFORCER-XXX] - Fixes bug in ApproximateQuantiles`, where you replace `MENFORCER-XXX` with the appropriate JIRA issue. Best practice is to use the JIRA issue title in the pull request title and in the first line of the commit message. - [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [ ] Run `mvn clean verify` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically. - [ ] You have run the integration tests successfully (`mvn -Prun-its clean verify`). If your pull request is about ~20 lines of code you don't need to sign an [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure please ask on the developers list. To make clear that you license your contribution under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) you have to acknowledge this by using the following check-box. - [ ] I hereby declare this contribution to be licenced under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) - [ ] In any other case, please file an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MWRAPPER-88) mvnw is not POSIX compatible
[ https://issues.apache.org/jira/browse/MWRAPPER-88?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17655461#comment-17655461 ] ASF GitHub Bot commented on MWRAPPER-88: slawekjaranowski commented on code in PR #79: URL: https://github.com/apache/maven-wrapper/pull/79#discussion_r1063457960 ## maven-wrapper-distribution/src/resources/mvnw: ## @@ -118,7 +118,7 @@ if [ -z "$JAVACMD" ] ; then JAVACMD="$JAVA_HOME/bin/java" fi else -JAVACMD="`\\unset -f command; \\command -v java`" +JAVACMD="$(\\unset -f command; \\command -v java)" Review Comment: confirm on `GNU bash, version 5.2.15(1)-release (x86_64-apple-darwin21.6.0)` this is ok: ```bash JAVACMD="$(unset -f command; command -v java)"; echo $JAVACMD ``` > mvnw is not POSIX compatible > > > Key: MWRAPPER-88 > URL: https://issues.apache.org/jira/browse/MWRAPPER-88 > Project: Maven Wrapper > Issue Type: Bug > Components: Maven Wrapper Scripts >Affects Versions: 3.1.1 >Reporter: Benjamin Marwell >Assignee: Benjamin Marwell >Priority: Major > Labels: posix > > * POSIX scripts should not use bash-specific features > * Fix suggestions from shellcheck > ([https://github.com/apache/maven-wrapper/pull/74]) -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [maven-wrapper] slawekjaranowski commented on a diff in pull request #79: [MWRAPPER-88] fix shellcheck findings / POSIX compatiblity
slawekjaranowski commented on code in PR #79: URL: https://github.com/apache/maven-wrapper/pull/79#discussion_r1063457960 ## maven-wrapper-distribution/src/resources/mvnw: ## @@ -118,7 +118,7 @@ if [ -z "$JAVACMD" ] ; then JAVACMD="$JAVA_HOME/bin/java" fi else -JAVACMD="`\\unset -f command; \\command -v java`" +JAVACMD="$(\\unset -f command; \\command -v java)" Review Comment: confirm on `GNU bash, version 5.2.15(1)-release (x86_64-apple-darwin21.6.0)` this is ok: ```bash JAVACMD="$(unset -f command; command -v java)"; echo $JAVACMD ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MWRAPPER-88) mvnw is not POSIX compatible
[
https://issues.apache.org/jira/browse/MWRAPPER-88?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17655456#comment-17655456
]
ASF GitHub Bot commented on MWRAPPER-88:
slawekjaranowski commented on code in PR #79:
URL: https://github.com/apache/maven-wrapper/pull/79#discussion_r1063447254
##
.github/workflows/shellcheck-posix.yml:
##
@@ -27,7 +27,7 @@ jobs:
runs-on: ubuntu-latest
env:
SHELLCHECK_VERSION: '0.9.0'
- SHELLCHECK_OPTS: '-e SC2009'
+ SHELLCHECK_OPTS: '-e SC1091 -e SC2009'
Review Comment:
I would like to add description what this numbers means - what rule is
exclude
##
.github/workflows/shellcheck-posix.yml:
##
@@ -39,7 +39,7 @@ jobs:
- name: check
run: |
echo "$GITHUB_WORKSPACE/shellcheck-v${SHELLCHECK_VERSION}" >>
$GITHUB_PATH
- readarray -t SCRIPT_FILES < <(grep -ErIl
'^#![[:blank:]]*/bin/(ba|da|c|k)?sh'
"$GITHUB_WORKSPACE/maven-wrapper-distribution/src/resources")
+ readarray -t SCRIPT_FILES < <(grep -ErIl -e
'^#![[:blank:]]*/bin/(ba|da|c|k)?sh' -e
'^#!/usr/bin/env[[:blank:]]+(ba|da|c|k)?sh'
"$GITHUB_WORKSPACE/maven-wrapper-distribution/src/resources")
Review Comment:
should it also match `zsh`?
> mvnw is not POSIX compatible
>
>
> Key: MWRAPPER-88
> URL: https://issues.apache.org/jira/browse/MWRAPPER-88
> Project: Maven Wrapper
> Issue Type: Bug
> Components: Maven Wrapper Scripts
>Affects Versions: 3.1.1
>Reporter: Benjamin Marwell
>Assignee: Benjamin Marwell
>Priority: Major
> Labels: posix
>
> * POSIX scripts should not use bash-specific features
> * Fix suggestions from shellcheck
> ([https://github.com/apache/maven-wrapper/pull/74])
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[GitHub] [maven-wrapper] slawekjaranowski commented on a diff in pull request #79: [MWRAPPER-88] fix shellcheck findings / POSIX compatiblity
slawekjaranowski commented on code in PR #79:
URL: https://github.com/apache/maven-wrapper/pull/79#discussion_r1063447254
##
.github/workflows/shellcheck-posix.yml:
##
@@ -27,7 +27,7 @@ jobs:
runs-on: ubuntu-latest
env:
SHELLCHECK_VERSION: '0.9.0'
- SHELLCHECK_OPTS: '-e SC2009'
+ SHELLCHECK_OPTS: '-e SC1091 -e SC2009'
Review Comment:
I would like to add description what this numbers means - what rule is
exclude
##
.github/workflows/shellcheck-posix.yml:
##
@@ -39,7 +39,7 @@ jobs:
- name: check
run: |
echo "$GITHUB_WORKSPACE/shellcheck-v${SHELLCHECK_VERSION}" >>
$GITHUB_PATH
- readarray -t SCRIPT_FILES < <(grep -ErIl
'^#![[:blank:]]*/bin/(ba|da|c|k)?sh'
"$GITHUB_WORKSPACE/maven-wrapper-distribution/src/resources")
+ readarray -t SCRIPT_FILES < <(grep -ErIl -e
'^#![[:blank:]]*/bin/(ba|da|c|k)?sh' -e
'^#!/usr/bin/env[[:blank:]]+(ba|da|c|k)?sh'
"$GITHUB_WORKSPACE/maven-wrapper-distribution/src/resources")
Review Comment:
should it also match `zsh`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Commented] (MRESOLVER-313) Artifact file permissions are 0600 and not implicitly set by umask
[
https://issues.apache.org/jira/browse/MRESOLVER-313?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17655455#comment-17655455
]
ASF GitHub Bot commented on MRESOLVER-313:
--
gnodet commented on code in PR #234:
URL: https://github.com/apache/maven-resolver/pull/234#discussion_r1063452977
##
maven-resolver-util/src/main/java/org/eclipse/aether/util/FileUtils.java:
##
@@ -85,17 +92,23 @@ public void close() throws IOException
}
/**
- * Creates a {@link TempFile} for given file. It will be in same directory
where given file is, and will reuse its
- * name for generated name. Returned instance should be handled in
try-with-resource construct and created temp
- * file once ready can be moved to passed in {@code file} parameter place.
+ * Creates a {@link CollocatedTempFile} instance for given file without
backing file. The path will be located in
+ * same directory where given file is, and will reuse its name for
generated (randomized) name. Returned instance
+ * should be handled in try-with-resource and created temp path is removed
(if exists) when returned instance is
+ * closed. The {@link CollocatedTempFile#move()} makes possible to
atomically replace passed in file with the
+ * processed content written into a file backing the {@link
CollocatedTempFile} instance.
*
* The {@code file} nor it's parent directories have to exist. The parent
directories are created if needed.
+ *
+ * This method uses {@link Path#resolve(String)} to create the temporary
file path in passed in file parent
+ * directory, but it does NOT create backing file on file system.
*/
public static CollocatedTempFile newTempFile( Path file ) throws
IOException
{
Path parent = requireNonNull( file.getParent(), "file must have
parent" );
Files.createDirectories( parent );
-Path tempFile = Files.createTempFile( parent,
file.getFileName().toString(), "tmp" );
+Path tempFile = parent.resolve(
+file.getFileName() + "." + Long.toUnsignedString(
RANDOM.nextLong() ) + ".tmp" );
Review Comment:
Same here.
> Artifact file permissions are 0600 and not implicitly set by umask
> --
>
> Key: MRESOLVER-313
> URL: https://issues.apache.org/jira/browse/MRESOLVER-313
> Project: Maven Resolver
> Issue Type: Bug
> Components: Resolver
>Reporter: Tamas Cservenak
>Assignee: Tamas Cservenak
>Priority: Major
> Fix For: 1.9.4
>
>
> With introduction of FileUtils, and widespread use of CollocatedTempFile, one
> problem occurs: in both "temp file" cases Files.createTempFile is being used,
> that uses 0600 permissions instead to rely on umask.
> In case of TempFile this is OK, but in case of CollocatedTempFile this is NOT
> OK, as these files are usually moved to their "final" place (like artifact in
> local repo once downloaded and verified).
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[GitHub] [maven-resolver] gnodet commented on a diff in pull request #234: [MRESOLVER-313] Wrong FS permissions on cached artifacts.
gnodet commented on code in PR #234:
URL: https://github.com/apache/maven-resolver/pull/234#discussion_r1063452977
##
maven-resolver-util/src/main/java/org/eclipse/aether/util/FileUtils.java:
##
@@ -85,17 +92,23 @@ public void close() throws IOException
}
/**
- * Creates a {@link TempFile} for given file. It will be in same directory
where given file is, and will reuse its
- * name for generated name. Returned instance should be handled in
try-with-resource construct and created temp
- * file once ready can be moved to passed in {@code file} parameter place.
+ * Creates a {@link CollocatedTempFile} instance for given file without
backing file. The path will be located in
+ * same directory where given file is, and will reuse its name for
generated (randomized) name. Returned instance
+ * should be handled in try-with-resource and created temp path is removed
(if exists) when returned instance is
+ * closed. The {@link CollocatedTempFile#move()} makes possible to
atomically replace passed in file with the
+ * processed content written into a file backing the {@link
CollocatedTempFile} instance.
*
* The {@code file} nor it's parent directories have to exist. The parent
directories are created if needed.
+ *
+ * This method uses {@link Path#resolve(String)} to create the temporary
file path in passed in file parent
+ * directory, but it does NOT create backing file on file system.
*/
public static CollocatedTempFile newTempFile( Path file ) throws
IOException
{
Path parent = requireNonNull( file.getParent(), "file must have
parent" );
Files.createDirectories( parent );
-Path tempFile = Files.createTempFile( parent,
file.getFileName().toString(), "tmp" );
+Path tempFile = parent.resolve(
+file.getFileName() + "." + Long.toUnsignedString(
RANDOM.nextLong() ) + ".tmp" );
Review Comment:
Same here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Commented] (MRESOLVER-313) Artifact file permissions are 0600 and not implicitly set by umask
[
https://issues.apache.org/jira/browse/MRESOLVER-313?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17655454#comment-17655454
]
ASF GitHub Bot commented on MRESOLVER-313:
--
gnodet commented on code in PR #234:
URL: https://github.com/apache/maven-resolver/pull/234#discussion_r1063451155
##
maven-resolver-util/src/main/java/org/eclipse/aether/util/FileUtils.java:
##
@@ -85,17 +92,23 @@ public void close() throws IOException
}
/**
- * Creates a {@link TempFile} for given file. It will be in same directory
where given file is, and will reuse its
- * name for generated name. Returned instance should be handled in
try-with-resource construct and created temp
- * file once ready can be moved to passed in {@code file} parameter place.
+ * Creates a {@link CollocatedTempFile} instance for given file without
backing file. The path will be located in
+ * same directory where given file is, and will reuse its name for
generated (randomized) name. Returned instance
+ * should be handled in try-with-resource and created temp path is removed
(if exists) when returned instance is
+ * closed. The {@link CollocatedTempFile#move()} makes possible to
atomically replace passed in file with the
+ * processed content written into a file backing the {@link
CollocatedTempFile} instance.
*
* The {@code file} nor it's parent directories have to exist. The parent
directories are created if needed.
+ *
+ * This method uses {@link Path#resolve(String)} to create the temporary
file path in passed in file parent
+ * directory, but it does NOT create backing file on file system.
*/
public static CollocatedTempFile newTempFile( Path file ) throws
IOException
{
Path parent = requireNonNull( file.getParent(), "file must have
parent" );
Files.createDirectories( parent );
-Path tempFile = Files.createTempFile( parent,
file.getFileName().toString(), "tmp" );
+Path tempFile = parent.resolve(
+file.getFileName().toString() + Long.toUnsignedString(
RANDOM.nextLong() ) + ".tmp" );
Review Comment:
Use `ThreadLocalRandom.current().nextLong()` instead
> Artifact file permissions are 0600 and not implicitly set by umask
> --
>
> Key: MRESOLVER-313
> URL: https://issues.apache.org/jira/browse/MRESOLVER-313
> Project: Maven Resolver
> Issue Type: Bug
> Components: Resolver
>Reporter: Tamas Cservenak
>Assignee: Tamas Cservenak
>Priority: Major
> Fix For: 1.9.4
>
>
> With introduction of FileUtils, and widespread use of CollocatedTempFile, one
> problem occurs: in both "temp file" cases Files.createTempFile is being used,
> that uses 0600 permissions instead to rely on umask.
> In case of TempFile this is OK, but in case of CollocatedTempFile this is NOT
> OK, as these files are usually moved to their "final" place (like artifact in
> local repo once downloaded and verified).
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[GitHub] [maven-resolver] gnodet commented on a diff in pull request #234: [MRESOLVER-313] Wrong FS permissions on cached artifacts.
gnodet commented on code in PR #234:
URL: https://github.com/apache/maven-resolver/pull/234#discussion_r1063451155
##
maven-resolver-util/src/main/java/org/eclipse/aether/util/FileUtils.java:
##
@@ -85,17 +92,23 @@ public void close() throws IOException
}
/**
- * Creates a {@link TempFile} for given file. It will be in same directory
where given file is, and will reuse its
- * name for generated name. Returned instance should be handled in
try-with-resource construct and created temp
- * file once ready can be moved to passed in {@code file} parameter place.
+ * Creates a {@link CollocatedTempFile} instance for given file without
backing file. The path will be located in
+ * same directory where given file is, and will reuse its name for
generated (randomized) name. Returned instance
+ * should be handled in try-with-resource and created temp path is removed
(if exists) when returned instance is
+ * closed. The {@link CollocatedTempFile#move()} makes possible to
atomically replace passed in file with the
+ * processed content written into a file backing the {@link
CollocatedTempFile} instance.
*
* The {@code file} nor it's parent directories have to exist. The parent
directories are created if needed.
+ *
+ * This method uses {@link Path#resolve(String)} to create the temporary
file path in passed in file parent
+ * directory, but it does NOT create backing file on file system.
*/
public static CollocatedTempFile newTempFile( Path file ) throws
IOException
{
Path parent = requireNonNull( file.getParent(), "file must have
parent" );
Files.createDirectories( parent );
-Path tempFile = Files.createTempFile( parent,
file.getFileName().toString(), "tmp" );
+Path tempFile = parent.resolve(
+file.getFileName().toString() + Long.toUnsignedString(
RANDOM.nextLong() ) + ".tmp" );
Review Comment:
Use `ThreadLocalRandom.current().nextLong()` instead
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Commented] (MRESOLVER-313) Artifact file permissions are 0600 and not implicitly set by umask
[ https://issues.apache.org/jira/browse/MRESOLVER-313?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17655447#comment-17655447 ] ASF GitHub Bot commented on MRESOLVER-313: -- michael-o commented on PR #234: URL: https://github.com/apache/maven-resolver/pull/234#issuecomment-1373621017 > @michael-o please look at last commit (and it's message) Makes sense, expect for the typo on the commit: its final place > Artifact file permissions are 0600 and not implicitly set by umask > -- > > Key: MRESOLVER-313 > URL: https://issues.apache.org/jira/browse/MRESOLVER-313 > Project: Maven Resolver > Issue Type: Bug > Components: Resolver >Reporter: Tamas Cservenak >Assignee: Tamas Cservenak >Priority: Major > Fix For: 1.9.4 > > > With introduction of FileUtils, and widespread use of CollocatedTempFile, one > problem occurs: in both "temp file" cases Files.createTempFile is being used, > that uses 0600 permissions instead to rely on umask. > In case of TempFile this is OK, but in case of CollocatedTempFile this is NOT > OK, as these files are usually moved to their "final" place (like artifact in > local repo once downloaded and verified). -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [maven-resolver] michael-o commented on pull request #234: [MRESOLVER-313] Wrong FS permissions on cached artifacts.
michael-o commented on PR #234: URL: https://github.com/apache/maven-resolver/pull/234#issuecomment-1373621017 > @michael-o please look at last commit (and it's message) Makes sense, expect for the typo on the commit: its final place -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MWRAPPER-88) mvnw is not POSIX compatible
[ https://issues.apache.org/jira/browse/MWRAPPER-88?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17655430#comment-17655430 ] ASF GitHub Bot commented on MWRAPPER-88: bmarwell commented on code in PR #79: URL: https://github.com/apache/maven-wrapper/pull/79#discussion_r1063402134 ## maven-wrapper-distribution/src/resources/mvnw: ## @@ -118,7 +118,7 @@ if [ -z "$JAVACMD" ] ; then JAVACMD="$JAVA_HOME/bin/java" fi else -JAVACMD="`\\unset -f command; \\command -v java`" +JAVACMD="$(\\unset -f command; \\command -v java)" Review Comment: This never worked in `zsh`. Probably a bashism. Can someone verify this? > mvnw is not POSIX compatible > > > Key: MWRAPPER-88 > URL: https://issues.apache.org/jira/browse/MWRAPPER-88 > Project: Maven Wrapper > Issue Type: Bug > Components: Maven Wrapper Scripts >Affects Versions: 3.1.1 >Reporter: Benjamin Marwell >Assignee: Benjamin Marwell >Priority: Major > Labels: posix > > * POSIX scripts should not use bash-specific features > * Fix suggestions from shellcheck > ([https://github.com/apache/maven-wrapper/pull/74]) -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [maven-wrapper] bmarwell commented on a diff in pull request #79: [MWRAPPER-88] fix shellcheck findings / POSIX compatiblity
bmarwell commented on code in PR #79: URL: https://github.com/apache/maven-wrapper/pull/79#discussion_r1063402134 ## maven-wrapper-distribution/src/resources/mvnw: ## @@ -118,7 +118,7 @@ if [ -z "$JAVACMD" ] ; then JAVACMD="$JAVA_HOME/bin/java" fi else -JAVACMD="`\\unset -f command; \\command -v java`" +JAVACMD="$(\\unset -f command; \\command -v java)" Review Comment: This never worked in `zsh`. Probably a bashism. Can someone verify this? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
