[jira] [Closed] (MGPG-94) Update parent pom to 39
[ https://issues.apache.org/jira/browse/MGPG-94?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sylwester Lachiewicz closed MGPG-94. Resolution: Fixed > Update parent pom to 39 > --- > > Key: MGPG-94 > URL: https://issues.apache.org/jira/browse/MGPG-94 > Project: Maven GPG Plugin > Issue Type: Dependency upgrade >Reporter: Elliotte Rusty Harold >Assignee: Sylwester Lachiewicz >Priority: Major > Fix For: 3.1.0 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (MGPG-94) Update parent pom to 39
[ https://issues.apache.org/jira/browse/MGPG-94?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sylwester Lachiewicz updated MGPG-94: - Fix Version/s: 3.1.0 > Update parent pom to 39 > --- > > Key: MGPG-94 > URL: https://issues.apache.org/jira/browse/MGPG-94 > Project: Maven GPG Plugin > Issue Type: Dependency upgrade >Reporter: Elliotte Rusty Harold >Assignee: Sylwester Lachiewicz >Priority: Major > Fix For: 3.1.0 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Assigned] (MGPG-94) Update parent pom to 39
[ https://issues.apache.org/jira/browse/MGPG-94?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sylwester Lachiewicz reassigned MGPG-94: Assignee: Sylwester Lachiewicz > Update parent pom to 39 > --- > > Key: MGPG-94 > URL: https://issues.apache.org/jira/browse/MGPG-94 > Project: Maven GPG Plugin > Issue Type: Dependency upgrade >Reporter: Elliotte Rusty Harold >Assignee: Sylwester Lachiewicz >Priority: Major > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [maven-gpg-plugin] slachiewicz merged pull request #44: [MGPG-94] Bump maven-plugins from 36 to 39
slachiewicz merged PR #44: URL: https://github.com/apache/maven-gpg-plugin/pull/44 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MRELEASE-1103) decryption of server password in settings.xml failed (works with 2.5.3)
[ https://issues.apache.org/jira/browse/MRELEASE-1103?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17712564#comment-17712564 ] Alan Czajkowski commented on MRELEASE-1103: --- [~michael-o] we are following this guide: https://maven.apache.org/guides/mini/guide-encryption.html and the Maven Release Plugin is not able to handle this all that I'm asking for is that the plugin work again, when this guide is followed > decryption of server password in settings.xml failed (works with 2.5.3) > --- > > Key: MRELEASE-1103 > URL: https://issues.apache.org/jira/browse/MRELEASE-1103 > Project: Maven Release Plugin > Issue Type: Bug >Affects Versions: 3.0.0-M6 >Reporter: Robert Seidel >Priority: Blocker > Fix For: 3.0.1 > > > A server section was defined in the settings.xml at > with id, username and password to connect to a > Bitbucket server. > In the pom.xml the id was referenced in the properties via project.scm.id. > With 2.5.3 the build is running fine, but with 3.0.06-M6 the following > happens: > *11:35:40* [INFO] [WARNING] The requested profile "distribute" could not be > activated because it does not exist. > *11:35:40* [INFO] 11/17 prepare:scm-commit-release > *11:35:40* [INFO] Checking in modified POMs... > *11:35:40* [WARNING] Failed to decrypt password/passphrase for server > bitbucket-prod, using auth token as is: decrypt failed > and in the aftermath: > *11:35:41* [ERROR] Failed to execute goal > org.apache.maven.plugins:maven-release-plugin:3.0.0-M6:prepare (default-cli) > on project ExamplePom: Unable to commit files > *11:35:41* [ERROR] Provider message: > *11:35:41* [ERROR] The git-push command failed. > *11:35:41* [ERROR] Command output: > *11:35:41* [ERROR] fatal: Authentication failed for > '[https://prod.bitbucket/scm/cp/examplepom.git/|https://git.aeb.com/bitbucket/scm/cp/aebparentpom.git/]' > > JDK used was Adoptium 17 (but with 11 the same problem occured). > Maven used was 3.8.6. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [maven-release] cstamas commented on pull request #181: [MRELEASE-1103] Wrong file path used for master pw file
cstamas commented on PR #181: URL: https://github.com/apache/maven-release/pull/181#issuecomment-1509265035 Interesting: branch has 4 commits, but this PR shows only 3 of them? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Comment Edited] (MRELEASE-1103) decryption of server password in settings.xml failed (works with 2.5.3)
[
https://issues.apache.org/jira/browse/MRELEASE-1103?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17712532#comment-17712532
]
Tamas Cservenak edited comment on MRELEASE-1103 at 4/14/23 8:40 PM:
Another workaround: create file {{~/.settings-security.xml}} (the one that code
looks due bug in your home directory) with content like this:
{noformat}
/abs/path/to/settings-security.xml
{noformat}
was (Author: cstamas):
Another workaround: create file {{~/settings-security.xml}} (the one that code
looks due bug in your home directory) with content like this:
{noformat}
/abs/path/to/settings-security.xml
{noformat}
> decryption of server password in settings.xml failed (works with 2.5.3)
> ---
>
> Key: MRELEASE-1103
> URL: https://issues.apache.org/jira/browse/MRELEASE-1103
> Project: Maven Release Plugin
> Issue Type: Bug
>Affects Versions: 3.0.0-M6
>Reporter: Robert Seidel
>Priority: Blocker
> Fix For: 3.0.1
>
>
> A server section was defined in the settings.xml at
> with id, username and password to connect to a
> Bitbucket server.
> In the pom.xml the id was referenced in the properties via project.scm.id.
> With 2.5.3 the build is running fine, but with 3.0.06-M6 the following
> happens:
> *11:35:40* [INFO] [WARNING] The requested profile "distribute" could not be
> activated because it does not exist.
> *11:35:40* [INFO] 11/17 prepare:scm-commit-release
> *11:35:40* [INFO] Checking in modified POMs...
> *11:35:40* [WARNING] Failed to decrypt password/passphrase for server
> bitbucket-prod, using auth token as is: decrypt failed
> and in the aftermath:
> *11:35:41* [ERROR] Failed to execute goal
> org.apache.maven.plugins:maven-release-plugin:3.0.0-M6:prepare (default-cli)
> on project ExamplePom: Unable to commit files
> *11:35:41* [ERROR] Provider message:
> *11:35:41* [ERROR] The git-push command failed.
> *11:35:41* [ERROR] Command output:
> *11:35:41* [ERROR] fatal: Authentication failed for
> '[https://prod.bitbucket/scm/cp/examplepom.git/|https://git.aeb.com/bitbucket/scm/cp/aebparentpom.git/]'
>
> JDK used was Adoptium 17 (but with 11 the same problem occured).
> Maven used was 3.8.6.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MRELEASE-1103) decryption of server password in settings.xml failed (works with 2.5.3)
[
https://issues.apache.org/jira/browse/MRELEASE-1103?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17712532#comment-17712532
]
Tamas Cservenak commented on MRELEASE-1103:
---
Another workaround: create file {{~/settings-security.xml}} (the one that code
looks due bug in your home directory) with content like this:
{noformat}
/abs/path/to/settings-security.xml
{noformat}
> decryption of server password in settings.xml failed (works with 2.5.3)
> ---
>
> Key: MRELEASE-1103
> URL: https://issues.apache.org/jira/browse/MRELEASE-1103
> Project: Maven Release Plugin
> Issue Type: Bug
>Affects Versions: 3.0.0-M6
>Reporter: Robert Seidel
>Priority: Blocker
> Fix For: 3.0.1
>
>
> A server section was defined in the settings.xml at
> with id, username and password to connect to a
> Bitbucket server.
> In the pom.xml the id was referenced in the properties via project.scm.id.
> With 2.5.3 the build is running fine, but with 3.0.06-M6 the following
> happens:
> *11:35:40* [INFO] [WARNING] The requested profile "distribute" could not be
> activated because it does not exist.
> *11:35:40* [INFO] 11/17 prepare:scm-commit-release
> *11:35:40* [INFO] Checking in modified POMs...
> *11:35:40* [WARNING] Failed to decrypt password/passphrase for server
> bitbucket-prod, using auth token as is: decrypt failed
> and in the aftermath:
> *11:35:41* [ERROR] Failed to execute goal
> org.apache.maven.plugins:maven-release-plugin:3.0.0-M6:prepare (default-cli)
> on project ExamplePom: Unable to commit files
> *11:35:41* [ERROR] Provider message:
> *11:35:41* [ERROR] The git-push command failed.
> *11:35:41* [ERROR] Command output:
> *11:35:41* [ERROR] fatal: Authentication failed for
> '[https://prod.bitbucket/scm/cp/examplepom.git/|https://git.aeb.com/bitbucket/scm/cp/aebparentpom.git/]'
>
> JDK used was Adoptium 17 (but with 11 the same problem occured).
> Maven used was 3.8.6.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Updated] (MRELEASE-1103) decryption of server password in settings.xml failed (works with 2.5.3)
[ https://issues.apache.org/jira/browse/MRELEASE-1103?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tamas Cservenak updated MRELEASE-1103: -- Fix Version/s: 3.0.1 > decryption of server password in settings.xml failed (works with 2.5.3) > --- > > Key: MRELEASE-1103 > URL: https://issues.apache.org/jira/browse/MRELEASE-1103 > Project: Maven Release Plugin > Issue Type: Bug >Affects Versions: 3.0.0-M6 >Reporter: Robert Seidel >Priority: Blocker > Fix For: 3.0.1 > > > A server section was defined in the settings.xml at > with id, username and password to connect to a > Bitbucket server. > In the pom.xml the id was referenced in the properties via project.scm.id. > With 2.5.3 the build is running fine, but with 3.0.06-M6 the following > happens: > *11:35:40* [INFO] [WARNING] The requested profile "distribute" could not be > activated because it does not exist. > *11:35:40* [INFO] 11/17 prepare:scm-commit-release > *11:35:40* [INFO] Checking in modified POMs... > *11:35:40* [WARNING] Failed to decrypt password/passphrase for server > bitbucket-prod, using auth token as is: decrypt failed > and in the aftermath: > *11:35:41* [ERROR] Failed to execute goal > org.apache.maven.plugins:maven-release-plugin:3.0.0-M6:prepare (default-cli) > on project ExamplePom: Unable to commit files > *11:35:41* [ERROR] Provider message: > *11:35:41* [ERROR] The git-push command failed. > *11:35:41* [ERROR] Command output: > *11:35:41* [ERROR] fatal: Authentication failed for > '[https://prod.bitbucket/scm/cp/examplepom.git/|https://git.aeb.com/bitbucket/scm/cp/aebparentpom.git/]' > > JDK used was Adoptium 17 (but with 11 the same problem occured). > Maven used was 3.8.6. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [maven-release] cstamas opened a new pull request, #181: [MRELEASE-1103] Wrong file path used for master pw file
cstamas opened a new pull request, #181: URL: https://github.com/apache/maven-release/pull/181 Using plexus default, that is NOT same as Maven default. --- https://issues.apache.org/jira/browse/MRELEASE-1103 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MRELEASE-1103) decryption of server password in settings.xml failed (works with 2.5.3)
[ https://issues.apache.org/jira/browse/MRELEASE-1103?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17712524#comment-17712524 ] Michael Osipov commented on MRELEASE-1103: -- [~alan-czajkowski], independent of the regressions which should be addressed, of course, I'd like to understand what security enhancement you see with the encryption. Basically, there is none. It just adds a level of indirection and the plaintext key is in Java source. > decryption of server password in settings.xml failed (works with 2.5.3) > --- > > Key: MRELEASE-1103 > URL: https://issues.apache.org/jira/browse/MRELEASE-1103 > Project: Maven Release Plugin > Issue Type: Bug >Affects Versions: 3.0.0-M6 >Reporter: Robert Seidel >Priority: Blocker > > A server section was defined in the settings.xml at > with id, username and password to connect to a > Bitbucket server. > In the pom.xml the id was referenced in the properties via project.scm.id. > With 2.5.3 the build is running fine, but with 3.0.06-M6 the following > happens: > *11:35:40* [INFO] [WARNING] The requested profile "distribute" could not be > activated because it does not exist. > *11:35:40* [INFO] 11/17 prepare:scm-commit-release > *11:35:40* [INFO] Checking in modified POMs... > *11:35:40* [WARNING] Failed to decrypt password/passphrase for server > bitbucket-prod, using auth token as is: decrypt failed > and in the aftermath: > *11:35:41* [ERROR] Failed to execute goal > org.apache.maven.plugins:maven-release-plugin:3.0.0-M6:prepare (default-cli) > on project ExamplePom: Unable to commit files > *11:35:41* [ERROR] Provider message: > *11:35:41* [ERROR] The git-push command failed. > *11:35:41* [ERROR] Command output: > *11:35:41* [ERROR] fatal: Authentication failed for > '[https://prod.bitbucket/scm/cp/examplepom.git/|https://git.aeb.com/bitbucket/scm/cp/aebparentpom.git/]' > > JDK used was Adoptium 17 (but with 11 the same problem occured). > Maven used was 3.8.6. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MRELEASE-1103) decryption of server password in settings.xml failed (works with 2.5.3)
[
https://issues.apache.org/jira/browse/MRELEASE-1103?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17712516#comment-17712516
]
Tamas Cservenak commented on MRELEASE-1103:
---
Actually, out of those two workarounds, I'd bet on this combo: add
{{-Dsettings.security=~/.m2/settings-security.xml}} to Maven, as Maven will
push those into system properties. Or naturally, use jvm.config or any other
means to "properly" set Java System properties, not abuse Maven user properties
(that ARE pushed to system properties currently).
> decryption of server password in settings.xml failed (works with 2.5.3)
> ---
>
> Key: MRELEASE-1103
> URL: https://issues.apache.org/jira/browse/MRELEASE-1103
> Project: Maven Release Plugin
> Issue Type: Bug
>Affects Versions: 3.0.0-M6
>Reporter: Robert Seidel
>Priority: Blocker
>
> A server section was defined in the settings.xml at
> with id, username and password to connect to a
> Bitbucket server.
> In the pom.xml the id was referenced in the properties via project.scm.id.
> With 2.5.3 the build is running fine, but with 3.0.06-M6 the following
> happens:
> *11:35:40* [INFO] [WARNING] The requested profile "distribute" could not be
> activated because it does not exist.
> *11:35:40* [INFO] 11/17 prepare:scm-commit-release
> *11:35:40* [INFO] Checking in modified POMs...
> *11:35:40* [WARNING] Failed to decrypt password/passphrase for server
> bitbucket-prod, using auth token as is: decrypt failed
> and in the aftermath:
> *11:35:41* [ERROR] Failed to execute goal
> org.apache.maven.plugins:maven-release-plugin:3.0.0-M6:prepare (default-cli)
> on project ExamplePom: Unable to commit files
> *11:35:41* [ERROR] Provider message:
> *11:35:41* [ERROR] The git-push command failed.
> *11:35:41* [ERROR] Command output:
> *11:35:41* [ERROR] fatal: Authentication failed for
> '[https://prod.bitbucket/scm/cp/examplepom.git/|https://git.aeb.com/bitbucket/scm/cp/aebparentpom.git/]'
>
> JDK used was Adoptium 17 (but with 11 the same problem occured).
> Maven used was 3.8.6.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MRELEASE-1103) decryption of server password in settings.xml failed (works with 2.5.3)
[
https://issues.apache.org/jira/browse/MRELEASE-1103?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17712514#comment-17712514
]
Tamas Cservenak commented on MRELEASE-1103:
---
Another tries would be to set {{settings.security=~/.m2/settings-security.xml}}
as {*}Java System Property{*}.
> decryption of server password in settings.xml failed (works with 2.5.3)
> ---
>
> Key: MRELEASE-1103
> URL: https://issues.apache.org/jira/browse/MRELEASE-1103
> Project: Maven Release Plugin
> Issue Type: Bug
>Affects Versions: 3.0.0-M6
>Reporter: Robert Seidel
>Priority: Blocker
>
> A server section was defined in the settings.xml at
> with id, username and password to connect to a
> Bitbucket server.
> In the pom.xml the id was referenced in the properties via project.scm.id.
> With 2.5.3 the build is running fine, but with 3.0.06-M6 the following
> happens:
> *11:35:40* [INFO] [WARNING] The requested profile "distribute" could not be
> activated because it does not exist.
> *11:35:40* [INFO] 11/17 prepare:scm-commit-release
> *11:35:40* [INFO] Checking in modified POMs...
> *11:35:40* [WARNING] Failed to decrypt password/passphrase for server
> bitbucket-prod, using auth token as is: decrypt failed
> and in the aftermath:
> *11:35:41* [ERROR] Failed to execute goal
> org.apache.maven.plugins:maven-release-plugin:3.0.0-M6:prepare (default-cli)
> on project ExamplePom: Unable to commit files
> *11:35:41* [ERROR] Provider message:
> *11:35:41* [ERROR] The git-push command failed.
> *11:35:41* [ERROR] Command output:
> *11:35:41* [ERROR] fatal: Authentication failed for
> '[https://prod.bitbucket/scm/cp/examplepom.git/|https://git.aeb.com/bitbucket/scm/cp/aebparentpom.git/]'
>
> JDK used was Adoptium 17 (but with 11 the same problem occured).
> Maven used was 3.8.6.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Comment Edited] (MRELEASE-1103) decryption of server password in settings.xml failed (works with 2.5.3)
[
https://issues.apache.org/jira/browse/MRELEASE-1103?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17712514#comment-17712514
]
Tamas Cservenak edited comment on MRELEASE-1103 at 4/14/23 7:55 PM:
Another attempt would be to set
{{settings.security=~/.m2/settings-security.xml}} as {*}Java System Property{*}.
was (Author: cstamas):
Another tries would be to set {{settings.security=~/.m2/settings-security.xml}}
as {*}Java System Property{*}.
> decryption of server password in settings.xml failed (works with 2.5.3)
> ---
>
> Key: MRELEASE-1103
> URL: https://issues.apache.org/jira/browse/MRELEASE-1103
> Project: Maven Release Plugin
> Issue Type: Bug
>Affects Versions: 3.0.0-M6
>Reporter: Robert Seidel
>Priority: Blocker
>
> A server section was defined in the settings.xml at
> with id, username and password to connect to a
> Bitbucket server.
> In the pom.xml the id was referenced in the properties via project.scm.id.
> With 2.5.3 the build is running fine, but with 3.0.06-M6 the following
> happens:
> *11:35:40* [INFO] [WARNING] The requested profile "distribute" could not be
> activated because it does not exist.
> *11:35:40* [INFO] 11/17 prepare:scm-commit-release
> *11:35:40* [INFO] Checking in modified POMs...
> *11:35:40* [WARNING] Failed to decrypt password/passphrase for server
> bitbucket-prod, using auth token as is: decrypt failed
> and in the aftermath:
> *11:35:41* [ERROR] Failed to execute goal
> org.apache.maven.plugins:maven-release-plugin:3.0.0-M6:prepare (default-cli)
> on project ExamplePom: Unable to commit files
> *11:35:41* [ERROR] Provider message:
> *11:35:41* [ERROR] The git-push command failed.
> *11:35:41* [ERROR] Command output:
> *11:35:41* [ERROR] fatal: Authentication failed for
> '[https://prod.bitbucket/scm/cp/examplepom.git/|https://git.aeb.com/bitbucket/scm/cp/aebparentpom.git/]'
>
> JDK used was Adoptium 17 (but with 11 the same problem occured).
> Maven used was 3.8.6.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MRELEASE-1103) decryption of server password in settings.xml failed (works with 2.5.3)
[
https://issues.apache.org/jira/browse/MRELEASE-1103?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17712513#comment-17712513
]
Tamas Cservenak commented on MRELEASE-1103:
---
[~alan-czajkowski] as a workaround attempt, can you try following: pass
{{-D_configurationFile=~/.m2/settings-security.xml}} to Maven.
> decryption of server password in settings.xml failed (works with 2.5.3)
> ---
>
> Key: MRELEASE-1103
> URL: https://issues.apache.org/jira/browse/MRELEASE-1103
> Project: Maven Release Plugin
> Issue Type: Bug
>Affects Versions: 3.0.0-M6
>Reporter: Robert Seidel
>Priority: Blocker
>
> A server section was defined in the settings.xml at
> with id, username and password to connect to a
> Bitbucket server.
> In the pom.xml the id was referenced in the properties via project.scm.id.
> With 2.5.3 the build is running fine, but with 3.0.06-M6 the following
> happens:
> *11:35:40* [INFO] [WARNING] The requested profile "distribute" could not be
> activated because it does not exist.
> *11:35:40* [INFO] 11/17 prepare:scm-commit-release
> *11:35:40* [INFO] Checking in modified POMs...
> *11:35:40* [WARNING] Failed to decrypt password/passphrase for server
> bitbucket-prod, using auth token as is: decrypt failed
> and in the aftermath:
> *11:35:41* [ERROR] Failed to execute goal
> org.apache.maven.plugins:maven-release-plugin:3.0.0-M6:prepare (default-cli)
> on project ExamplePom: Unable to commit files
> *11:35:41* [ERROR] Provider message:
> *11:35:41* [ERROR] The git-push command failed.
> *11:35:41* [ERROR] Command output:
> *11:35:41* [ERROR] fatal: Authentication failed for
> '[https://prod.bitbucket/scm/cp/examplepom.git/|https://git.aeb.com/bitbucket/scm/cp/aebparentpom.git/]'
>
> JDK used was Adoptium 17 (but with 11 the same problem occured).
> Maven used was 3.8.6.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Comment Edited] (MRELEASE-1103) decryption of server password in settings.xml failed (works with 2.5.3)
[ https://issues.apache.org/jira/browse/MRELEASE-1103?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17712511#comment-17712511 ] Alan Czajkowski edited comment on MRELEASE-1103 at 4/14/23 7:44 PM: [~michael-o] I do not understand what you mean by "fake security" ... the underlying problem here is, as identified by [~robert.sei...@aeb.com] above, that the Maven Release Plugin "has removed the calculation of the correct settings file" ... essentially the plugin is critically broken if you want it to reference the correct settings file we are not asking for the plugin to do anything more than what it already did in the past (version 3.0.0-M5 and every version before it): properly resolve the settings files this bug breaks releases, fake security or not was (Author: alan-czajkowski): [~michael-o] I do not understand what you mean by "fake security" ... the underlying problem here is, as identified by [~robert.sei...@aeb.com] above, that the Maven Release Plugin "has removed the calculation of the correct settings file" ... essentially the plugin is critically broken if you want it to reference the correct settings file we are not asking for the plugin to do anything more than what it already did in the past (version 3.0.0-M5 and every version before it): properly resolve the settings files > decryption of server password in settings.xml failed (works with 2.5.3) > --- > > Key: MRELEASE-1103 > URL: https://issues.apache.org/jira/browse/MRELEASE-1103 > Project: Maven Release Plugin > Issue Type: Bug >Affects Versions: 3.0.0-M6 >Reporter: Robert Seidel >Priority: Blocker > > A server section was defined in the settings.xml at > with id, username and password to connect to a > Bitbucket server. > In the pom.xml the id was referenced in the properties via project.scm.id. > With 2.5.3 the build is running fine, but with 3.0.06-M6 the following > happens: > *11:35:40* [INFO] [WARNING] The requested profile "distribute" could not be > activated because it does not exist. > *11:35:40* [INFO] 11/17 prepare:scm-commit-release > *11:35:40* [INFO] Checking in modified POMs... > *11:35:40* [WARNING] Failed to decrypt password/passphrase for server > bitbucket-prod, using auth token as is: decrypt failed > and in the aftermath: > *11:35:41* [ERROR] Failed to execute goal > org.apache.maven.plugins:maven-release-plugin:3.0.0-M6:prepare (default-cli) > on project ExamplePom: Unable to commit files > *11:35:41* [ERROR] Provider message: > *11:35:41* [ERROR] The git-push command failed. > *11:35:41* [ERROR] Command output: > *11:35:41* [ERROR] fatal: Authentication failed for > '[https://prod.bitbucket/scm/cp/examplepom.git/|https://git.aeb.com/bitbucket/scm/cp/aebparentpom.git/]' > > JDK used was Adoptium 17 (but with 11 the same problem occured). > Maven used was 3.8.6. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Comment Edited] (MRELEASE-1103) decryption of server password in settings.xml failed (works with 2.5.3)
[ https://issues.apache.org/jira/browse/MRELEASE-1103?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17712511#comment-17712511 ] Alan Czajkowski edited comment on MRELEASE-1103 at 4/14/23 7:43 PM: [~michael-o] I do not understand what you mean by "fake security" ... the underlying problem here is, as identified by [~robert.sei...@aeb.com] above, that the Maven Release Plugin "has removed the calculation of the correct settings file" ... essentially the plugin is critically broken if you want it to reference the correct settings file we are not asking for the plugin to do anything more than what it already did in the past (version 3.0.0-M5 and every version before it): properly resolve the settings files was (Author: alan-czajkowski): [~michael-o] I do not understand what you mean by "fake security" ... the underlying problem here is, as identified by [~robert.sei...@aeb.com] above, that the Maven Release Plugin "has removed the calculation of the correct settings file" ... essentially the plugin is critically broken if you want it to reference the correct settings file we are not asking for the plugin to do anything more than what it already did in the past: properly resolve the settings files > decryption of server password in settings.xml failed (works with 2.5.3) > --- > > Key: MRELEASE-1103 > URL: https://issues.apache.org/jira/browse/MRELEASE-1103 > Project: Maven Release Plugin > Issue Type: Bug >Affects Versions: 3.0.0-M6 >Reporter: Robert Seidel >Priority: Blocker > > A server section was defined in the settings.xml at > with id, username and password to connect to a > Bitbucket server. > In the pom.xml the id was referenced in the properties via project.scm.id. > With 2.5.3 the build is running fine, but with 3.0.06-M6 the following > happens: > *11:35:40* [INFO] [WARNING] The requested profile "distribute" could not be > activated because it does not exist. > *11:35:40* [INFO] 11/17 prepare:scm-commit-release > *11:35:40* [INFO] Checking in modified POMs... > *11:35:40* [WARNING] Failed to decrypt password/passphrase for server > bitbucket-prod, using auth token as is: decrypt failed > and in the aftermath: > *11:35:41* [ERROR] Failed to execute goal > org.apache.maven.plugins:maven-release-plugin:3.0.0-M6:prepare (default-cli) > on project ExamplePom: Unable to commit files > *11:35:41* [ERROR] Provider message: > *11:35:41* [ERROR] The git-push command failed. > *11:35:41* [ERROR] Command output: > *11:35:41* [ERROR] fatal: Authentication failed for > '[https://prod.bitbucket/scm/cp/examplepom.git/|https://git.aeb.com/bitbucket/scm/cp/aebparentpom.git/]' > > JDK used was Adoptium 17 (but with 11 the same problem occured). > Maven used was 3.8.6. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MRELEASE-1103) decryption of server password in settings.xml failed (works with 2.5.3)
[ https://issues.apache.org/jira/browse/MRELEASE-1103?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17712511#comment-17712511 ] Alan Czajkowski commented on MRELEASE-1103: --- [~michael-o] I do not understand what you mean by "fake security" ... the underlying problem here is, as identified by [~robert.sei...@aeb.com] above, that the Maven Release Plugin "has removed the calculation of the correct settings file" ... essentially the plugin is critically broken if you want it to reference the correct settings file we are not asking for the plugin to do anything more than what it already did in the past: properly resolve the settings files > decryption of server password in settings.xml failed (works with 2.5.3) > --- > > Key: MRELEASE-1103 > URL: https://issues.apache.org/jira/browse/MRELEASE-1103 > Project: Maven Release Plugin > Issue Type: Bug >Affects Versions: 3.0.0-M6 >Reporter: Robert Seidel >Priority: Blocker > > A server section was defined in the settings.xml at > with id, username and password to connect to a > Bitbucket server. > In the pom.xml the id was referenced in the properties via project.scm.id. > With 2.5.3 the build is running fine, but with 3.0.06-M6 the following > happens: > *11:35:40* [INFO] [WARNING] The requested profile "distribute" could not be > activated because it does not exist. > *11:35:40* [INFO] 11/17 prepare:scm-commit-release > *11:35:40* [INFO] Checking in modified POMs... > *11:35:40* [WARNING] Failed to decrypt password/passphrase for server > bitbucket-prod, using auth token as is: decrypt failed > and in the aftermath: > *11:35:41* [ERROR] Failed to execute goal > org.apache.maven.plugins:maven-release-plugin:3.0.0-M6:prepare (default-cli) > on project ExamplePom: Unable to commit files > *11:35:41* [ERROR] Provider message: > *11:35:41* [ERROR] The git-push command failed. > *11:35:41* [ERROR] Command output: > *11:35:41* [ERROR] fatal: Authentication failed for > '[https://prod.bitbucket/scm/cp/examplepom.git/|https://git.aeb.com/bitbucket/scm/cp/aebparentpom.git/]' > > JDK used was Adoptium 17 (but with 11 the same problem occured). > Maven used was 3.8.6. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MNG-7691) Provide a generic way to skip Maven Goals for a specified plugin
[ https://issues.apache.org/jira/browse/MNG-7691?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17712508#comment-17712508 ] ASF GitHub Bot commented on MNG-7691: - gnodet commented on PR #1086: URL: https://github.com/apache/maven/pull/1086#issuecomment-1509116733 > To demonstrate: https://github.com/cstamas/plugin-clash/blob/main/README.md (and project that creates two different GA plugins and use them in build). Hence, IMHO any coherence with console output would be misleading: prefix _cannot uniquely identify a plugin_ I'm not sure how that's relevant. Your syntax supports wildcards, which definitely cannot uniquely identify a plugin. My points is not to restrict the supported syntax to `pluginPrefix[:version]:goal` and `groupId:artifactId[:version]:goal`, but to support it. And I would also support the optional `e` after, i.e. `pluginPrefix[:version]:goal[:executionId]` and `groupId:artifactId[:version]:goal[:executionId]`, but more importantly, at least support `pluginPrefix:version:goal` so that people can simply copy/paste from the console to skip a given plugin goal, instead of having to find out the `groupId:artifactId`. For example, how can you simply relate `spotless:2.28.0:apply (default)` from the console output to `com.diffplug.spotless:spotless-maven-plugin:apply` when that plugin is defined in a parent outside of the project ? I'd like to find a syntax that would support just copy/pasting the output from the console, certainly not be limited to that. > Provide a generic way to skip Maven Goals for a specified plugin > > > Key: MNG-7691 > URL: https://issues.apache.org/jira/browse/MNG-7691 > Project: Maven > Issue Type: Improvement > Components: Plugins and Lifecycle >Reporter: Jimisola Laursen >Priority: Major > > From ([Baeldung|https://www.baeldung.com/maven-disable-parent-pom-plugin]: > "Many plugins feature a skip parameter. We can use the skip parameter to > disable the plugin. Support for the skip parameter should be the first thing > we check because it is the simplest solution and the most conventional.". > I was thinking that there should be a generic way to skip maven plugin goals > in the core of Maven, i.e. it should not have to be implemented in each > plugin. > Would something like this work? > -Dmaven.skip.goals=groupID:artifactId:goal (is there a need to specify > version?) > E.g. > -Dmaven.skip.goals=io.spring.javaformat:spring-javaformat-maven-plugin:apply > -Dmaven.skip.goals=io.spring.javaformat:spring-javaformat-maven-plugin:apply+validate > -Dmaven.skip.goals=io.spring.javaformat:spring-javaformat-maven-plugin:apply+validate,org.apache.maven.plugins:maven-enforcer-plugin:enforce -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [maven] gnodet commented on pull request #1086: [MNG-7691] Lifecycle filter
gnodet commented on PR #1086: URL: https://github.com/apache/maven/pull/1086#issuecomment-1509116733 > To demonstrate: https://github.com/cstamas/plugin-clash/blob/main/README.md (and project that creates two different GA plugins and use them in build). Hence, IMHO any coherence with console output would be misleading: prefix _cannot uniquely identify a plugin_ I'm not sure how that's relevant. Your syntax supports wildcards, which definitely cannot uniquely identify a plugin. My points is not to restrict the supported syntax to `pluginPrefix[:version]:goal` and `groupId:artifactId[:version]:goal`, but to support it. And I would also support the optional `e` after, i.e. `pluginPrefix[:version]:goal[:executionId]` and `groupId:artifactId[:version]:goal[:executionId]`, but more importantly, at least support `pluginPrefix:version:goal` so that people can simply copy/paste from the console to skip a given plugin goal, instead of having to find out the `groupId:artifactId`. For example, how can you simply relate `spotless:2.28.0:apply (default)` from the console output to `com.diffplug.spotless:spotless-maven-plugin:apply` when that plugin is defined in a parent outside of the project ? I'd like to find a syntax that would support just copy/pasting the output from the console, certainly not be limited to that. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MRELEASE-1103) decryption of server password in settings.xml failed (works with 2.5.3)
[ https://issues.apache.org/jira/browse/MRELEASE-1103?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17712505#comment-17712505 ] Michael Osipov commented on MRELEASE-1103: -- [~alan-czajkowski], can you explain what benefit you see from this fake security? > decryption of server password in settings.xml failed (works with 2.5.3) > --- > > Key: MRELEASE-1103 > URL: https://issues.apache.org/jira/browse/MRELEASE-1103 > Project: Maven Release Plugin > Issue Type: Bug >Affects Versions: 3.0.0-M6 >Reporter: Robert Seidel >Priority: Blocker > > A server section was defined in the settings.xml at > with id, username and password to connect to a > Bitbucket server. > In the pom.xml the id was referenced in the properties via project.scm.id. > With 2.5.3 the build is running fine, but with 3.0.06-M6 the following > happens: > *11:35:40* [INFO] [WARNING] The requested profile "distribute" could not be > activated because it does not exist. > *11:35:40* [INFO] 11/17 prepare:scm-commit-release > *11:35:40* [INFO] Checking in modified POMs... > *11:35:40* [WARNING] Failed to decrypt password/passphrase for server > bitbucket-prod, using auth token as is: decrypt failed > and in the aftermath: > *11:35:41* [ERROR] Failed to execute goal > org.apache.maven.plugins:maven-release-plugin:3.0.0-M6:prepare (default-cli) > on project ExamplePom: Unable to commit files > *11:35:41* [ERROR] Provider message: > *11:35:41* [ERROR] The git-push command failed. > *11:35:41* [ERROR] Command output: > *11:35:41* [ERROR] fatal: Authentication failed for > '[https://prod.bitbucket/scm/cp/examplepom.git/|https://git.aeb.com/bitbucket/scm/cp/aebparentpom.git/]' > > JDK used was Adoptium 17 (but with 11 the same problem occured). > Maven used was 3.8.6. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MNG-7706) Deprecate ${localRepository} mojo parameter expression
[
https://issues.apache.org/jira/browse/MNG-7706?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17712504#comment-17712504
]
ASF GitHub Bot commented on MNG-7706:
-
paulwwisl commented on PR #1012:
URL: https://github.com/apache/maven/pull/1012#issuecomment-1509091252
solved with latest 3.0.0
https://maven.apache.org/surefire/maven-surefire-plugin/
e.g. with Spring Boot
```xml
3.0.0
```
> Deprecate ${localRepository} mojo parameter expression
> --
>
> Key: MNG-7706
> URL: https://issues.apache.org/jira/browse/MNG-7706
> Project: Maven
> Issue Type: Improvement
> Components: Core
>Reporter: Tamas Cservenak
>Assignee: Tamas Cservenak
>Priority: Major
> Fix For: 3.9.1, 4.0.0-alpha-5, 4.0.0
>
>
> The mojo parameter expression 'localRepository' injects type
> {{ArtifactRepository}} that is part of the suite coming from Maven2 (predates
> Mercury, that was superseded by Aether, today Maven Resolver).
> The problem with this interface is that it is not compatible (nor is possible
> to adapt it) to Maven Resolver LocalRepositoryManager due lack of context.
> Also, the use of this interface in Mojos causes issues like MNG-7663, as they
> fully (and blindly) re-implement Maven local repository with *wired in*
> layout.
> Moreover, Mojos using this expression are usually dragging other (legacy)
> deprecated things as well, most typically maven-artifact-transfer, or
> maven-dependency-tree and so on, all things that predates Maven 3.1 (are done
> to "protect" from Aether package change happened between Maven 3.0 and Maven
> 3.1). Today baseline for plugins is 3.2.5, so none of these "indirection" are
> needed anymore. In fact, the use of this expression is very good sign of
> legacy and technical debt present in given plugin. And also, these plugins
> cripple Maven to adopt new features. This warning is a clear indicator for
> legacy or neglected plugins.
> The type {{ArtifactRepository}} is used in Maven internally (most in
> maven-compat, a bit less in maven-core), this is telling as well, but IMHO
> there is no need to deprecate this interface, as:
> * plugins who migrate from this ancient interface to Resolver will have much
> simpler job with maven 4 API (as it is much closer to Resolver than old Maven
> APIs)
> * this tackles only Plugins, while Maven itself is fine, as post Maven 4 the
> internals will be shut off, so warning Mojo authors is enough
> * still, we should look into core where and why is this type used for
> * deprecate localRepository used of {{ArtifactRepository}} type on
> following: {{{}MavenExecutionRequest{}}}, {{MavenSession}} and
> {{ProjectBuildingRequest}} as instance created for these are effectively not
> used (and are created "too early" and they carry repository system session
> anyway
> If a Mojo gets this WARNING, how should it be fixed?
> * presence of parameter {{{}$\{localRepository{ (with presence of type
> ArtifactReposiory) usually means following things: Mojo uses maven-compat
> Maven2 compatibility layer, OR uses some deprecated libraries (most prominent
> example is maven-artifact-transfer). Both are technical debts, and remedy is
> to switch code to use current APIs.
> * second most often reason for parameter is access to the base directory of
> local repository. In this case {{RepositorySystemSession}} should be injected
> instead, use expression {{{}$\{repositorySystemSession{ and get the
> LocalRepositoryManager (LRM) from it. Word of warning: in most cases you DO
> NOT want the base directory of local repository, as since Maven 3.9.0 the
> layout of it is not fixed. If you want to access contents of local
> repository, you *must use LRM APIs instead* (this is actually true since
> Maven 3.0.x)!
> If user is stuck with plugin that issues this warning, user still can use it,
> but should avoid use of any advanced (split, etc) local repository features,
> available since 3.9.0. Inevitably, the deprecated APIs (maven-compat, etc)
> will get removed in the future, so if no way to update the Mojo, user should
> plan to migrate to some alternative solution (to buy out the affected Mojo).
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[GitHub] [maven] paulwwisl commented on pull request #1012: [MNG-7706] Deprecate 'localRepository' parameter expression (#1009)
paulwwisl commented on PR #1012: URL: https://github.com/apache/maven/pull/1012#issuecomment-1509091252 solved with latest 3.0.0 https://maven.apache.org/surefire/maven-surefire-plugin/ e.g. with Spring Boot ```xml 3.0.0 ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MRELEASE-1103) decryption of server password in settings.xml failed (works with 2.5.3)
[ https://issues.apache.org/jira/browse/MRELEASE-1103?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17712500#comment-17712500 ] Alan Czajkowski commented on MRELEASE-1103: --- someone really needs to fix this, 3.0.0 was released without incorporating this fix, pretty scandalous if you ask me > decryption of server password in settings.xml failed (works with 2.5.3) > --- > > Key: MRELEASE-1103 > URL: https://issues.apache.org/jira/browse/MRELEASE-1103 > Project: Maven Release Plugin > Issue Type: Bug >Affects Versions: 3.0.0-M6 >Reporter: Robert Seidel >Priority: Blocker > > A server section was defined in the settings.xml at > with id, username and password to connect to a > Bitbucket server. > In the pom.xml the id was referenced in the properties via project.scm.id. > With 2.5.3 the build is running fine, but with 3.0.06-M6 the following > happens: > *11:35:40* [INFO] [WARNING] The requested profile "distribute" could not be > activated because it does not exist. > *11:35:40* [INFO] 11/17 prepare:scm-commit-release > *11:35:40* [INFO] Checking in modified POMs... > *11:35:40* [WARNING] Failed to decrypt password/passphrase for server > bitbucket-prod, using auth token as is: decrypt failed > and in the aftermath: > *11:35:41* [ERROR] Failed to execute goal > org.apache.maven.plugins:maven-release-plugin:3.0.0-M6:prepare (default-cli) > on project ExamplePom: Unable to commit files > *11:35:41* [ERROR] Provider message: > *11:35:41* [ERROR] The git-push command failed. > *11:35:41* [ERROR] Command output: > *11:35:41* [ERROR] fatal: Authentication failed for > '[https://prod.bitbucket/scm/cp/examplepom.git/|https://git.aeb.com/bitbucket/scm/cp/aebparentpom.git/]' > > JDK used was Adoptium 17 (but with 11 the same problem occured). > Maven used was 3.8.6. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MNG-7691) Provide a generic way to skip Maven Goals for a specified plugin
[ https://issues.apache.org/jira/browse/MNG-7691?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17712498#comment-17712498 ] ASF GitHub Bot commented on MNG-7691: - cstamas commented on PR #1086: URL: https://github.com/apache/maven/pull/1086#issuecomment-1509062861 To demonstrate: https://github.com/cstamas/plugin-clash/blob/main/README.md (and project that creates two different GA plugins and use them in build). Hence, IMHO "coherence" with console output would be misleading. > Provide a generic way to skip Maven Goals for a specified plugin > > > Key: MNG-7691 > URL: https://issues.apache.org/jira/browse/MNG-7691 > Project: Maven > Issue Type: Improvement > Components: Plugins and Lifecycle >Reporter: Jimisola Laursen >Priority: Major > > From ([Baeldung|https://www.baeldung.com/maven-disable-parent-pom-plugin]: > "Many plugins feature a skip parameter. We can use the skip parameter to > disable the plugin. Support for the skip parameter should be the first thing > we check because it is the simplest solution and the most conventional.". > I was thinking that there should be a generic way to skip maven plugin goals > in the core of Maven, i.e. it should not have to be implemented in each > plugin. > Would something like this work? > -Dmaven.skip.goals=groupID:artifactId:goal (is there a need to specify > version?) > E.g. > -Dmaven.skip.goals=io.spring.javaformat:spring-javaformat-maven-plugin:apply > -Dmaven.skip.goals=io.spring.javaformat:spring-javaformat-maven-plugin:apply+validate > -Dmaven.skip.goals=io.spring.javaformat:spring-javaformat-maven-plugin:apply+validate,org.apache.maven.plugins:maven-enforcer-plugin:enforce -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [maven] cstamas commented on pull request #1086: [MNG-7691] Lifecycle filter
cstamas commented on PR #1086: URL: https://github.com/apache/maven/pull/1086#issuecomment-1509062861 To demonstrate: https://github.com/cstamas/plugin-clash/blob/main/README.md (and project that creates two different GA plugins and use them in build). Hence, IMHO "coherence" with console output would be misleading. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MNG-7691) Provide a generic way to skip Maven Goals for a specified plugin
[ https://issues.apache.org/jira/browse/MNG-7691?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17712491#comment-17712491 ] ASF GitHub Bot commented on MNG-7691: - cstamas commented on PR #1086: URL: https://github.com/apache/maven/pull/1086#issuecomment-1509037734 I disagree here. Plugin prefix may be duplicated AFAIK, as it may be specified at plugin build time (not "derived" from artifact ID, like xxx-maven-plugin => xxx prefix). And nothing stops two plugins having G1:A1 and G2:A2 (where any combination of inequality may be, so basically we talk about two different artifacts)but still have same prefix. Prefix is used mostly for "manual" invocation of plugin, but to "address" the plugin, IMHO prefix is simply not precise. > Provide a generic way to skip Maven Goals for a specified plugin > > > Key: MNG-7691 > URL: https://issues.apache.org/jira/browse/MNG-7691 > Project: Maven > Issue Type: Improvement > Components: Plugins and Lifecycle >Reporter: Jimisola Laursen >Priority: Major > > From ([Baeldung|https://www.baeldung.com/maven-disable-parent-pom-plugin]: > "Many plugins feature a skip parameter. We can use the skip parameter to > disable the plugin. Support for the skip parameter should be the first thing > we check because it is the simplest solution and the most conventional.". > I was thinking that there should be a generic way to skip maven plugin goals > in the core of Maven, i.e. it should not have to be implemented in each > plugin. > Would something like this work? > -Dmaven.skip.goals=groupID:artifactId:goal (is there a need to specify > version?) > E.g. > -Dmaven.skip.goals=io.spring.javaformat:spring-javaformat-maven-plugin:apply > -Dmaven.skip.goals=io.spring.javaformat:spring-javaformat-maven-plugin:apply+validate > -Dmaven.skip.goals=io.spring.javaformat:spring-javaformat-maven-plugin:apply+validate,org.apache.maven.plugins:maven-enforcer-plugin:enforce -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [maven] cstamas commented on pull request #1086: [MNG-7691] Lifecycle filter
cstamas commented on PR #1086: URL: https://github.com/apache/maven/pull/1086#issuecomment-1509037734 I disagree here. Plugin prefix may be duplicated AFAIK, as it may be specified at plugin build time (not "derived" from artifact ID, like xxx-maven-plugin => xxx prefix). And nothing stops two plugins having G1:A1 and G2:A2 (where any combination of inequality may be, so basically we talk about two different artifacts)but still have same prefix. Prefix is used mostly for "manual" invocation of plugin, but to "address" the plugin, IMHO prefix is simply not precise. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-gpg-plugin] hboutemy commented on pull request #43: initial test at signing with sigstore
hboutemy commented on PR #43: URL: https://github.com/apache/maven-gpg-plugin/pull/43#issuecomment-1509026313 with the following commit, IT WORKS thanks to Vladimir Sitnikov for debugging the dependency list: > `com.google.protobuf:protobuf-java:jar:3.21.9` > and then > `com.google.protobuf:protobuf-java-util:jar:3.22.0` > That’s not gonna fly. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MNG-7706) Deprecate ${localRepository} mojo parameter expression
[
https://issues.apache.org/jira/browse/MNG-7706?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17712469#comment-17712469
]
ASF GitHub Bot commented on MNG-7706:
-
paulwwisl commented on PR #1012:
URL: https://github.com/apache/maven/pull/1012#issuecomment-1508963129
Does this has to do with warning for test phase, when actually there are no
tests at all?
mvn version 3.9.1
```
[INFO] -
> Deprecate ${localRepository} mojo parameter expression
> --
>
> Key: MNG-7706
> URL: https://issues.apache.org/jira/browse/MNG-7706
> Project: Maven
> Issue Type: Improvement
> Components: Core
>Reporter: Tamas Cservenak
>Assignee: Tamas Cservenak
>Priority: Major
> Fix For: 3.9.1, 4.0.0-alpha-5, 4.0.0
>
>
> The mojo parameter expression 'localRepository' injects type
> {{ArtifactRepository}} that is part of the suite coming from Maven2 (predates
> Mercury, that was superseded by Aether, today Maven Resolver).
> The problem with this interface is that it is not compatible (nor is possible
> to adapt it) to Maven Resolver LocalRepositoryManager due lack of context.
> Also, the use of this interface in Mojos causes issues like MNG-7663, as they
> fully (and blindly) re-implement Maven local repository with *wired in*
> layout.
> Moreover, Mojos using this expression are usually dragging other (legacy)
> deprecated things as well, most typically maven-artifact-transfer, or
> maven-dependency-tree and so on, all things that predates Maven 3.1 (are done
> to "protect" from Aether package change happened between Maven 3.0 and Maven
> 3.1). Today baseline for plugins is 3.2.5, so none of these "indirection" are
> needed anymore. In fact, the use of this expression is very good sign of
> legacy and technical debt present in given plugin. And also, these plugins
> cripple Maven to adopt new features. This warning is a clear indicator for
> legacy or neglected plugins.
> The type {{ArtifactRepository}} is used in Maven internally (most in
> maven-compat, a bit less in maven-core), this is telling as well, but IMHO
> there is no need to deprecate this interface, as:
> * plugins who migrate from this ancient interface to Resolver will have much
> simpler job with maven 4 API (as it is much closer to Resolver than old Maven
> APIs)
> * this tackles only Plugins, while Maven itself is fine, as post Maven 4 the
> internals will be shut off, so warning Mojo authors is enough
> * still, we should look into core where and why is this type used for
> * deprecate localRepository used of {{ArtifactRepository}} type on
> following: {{{}MavenExecutionRequest{}}}, {{MavenSession}} and
> {{ProjectBuildingRequest}} as instance created for these are effectively not
> used (and are created "too early" and they carry repository system session
> anyway
> If a Mojo gets this WARNING, how should it be fixed?
> * presence of parameter {{{}$\{localRepository{ (with presence of type
> ArtifactReposiory) usually means following things: Mojo uses maven-compat
> Maven2 compatibility layer, OR uses some deprecated libraries (most prominent
> example is maven-artifact-transfer). Both are technical debts, and remedy is
> to switch code to use current APIs.
> * second most often reason for parameter is access to the base directory of
> local repository. In this case {{RepositorySystemSession}} should be injected
> instead, use expression {{{}$\{repositorySystemSession{ and get the
> LocalRepositoryManager (LRM) from it. Word of warning: in most cases you DO
> NOT want the base directory of local repository, as since Maven 3.9.0 the
> layout of it is not fixed. If you want to access contents of local
> repository, you *must use LRM APIs instead* (this is actually true since
> Maven 3.0.x)!
> If user is stuck with plugin that issues this warning, user still can use it,
> but should avoid use of any advanced (split, etc) local repository features,
> available since 3.9.0. Inevitably, the deprecated APIs (maven-compat, etc)
> will get removed in the future, so if no way to update the Mojo, user should
> plan to migrate to some alternative solution (to buy out the affected Mojo).
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[GitHub] [maven] paulwwisl commented on pull request #1012: [MNG-7706] Deprecate 'localRepository' parameter expression (#1009)
paulwwisl commented on PR #1012:
URL: https://github.com/apache/maven/pull/1012#issuecomment-1508963129
Does this has to do with warning for test phase, when actually there are no
tests at all?
mvn version 3.9.1
```
[INFO] --- surefire:2.22.2:test (default-test) @ . ---
[WARNING] Parameter 'localRepository' is deprecated core expression; Avoid
use of ArtifactRepository type. If you need access to local repository, switch
to '${repositorySystemSession}' expression and get LRM from it instead.
[INFO] No tests to run.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Closed] (MPOM-415) Use surefire/failsafe version from ASF parent
[ https://issues.apache.org/jira/browse/MPOM-415?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Slawomir Jaranowski closed MPOM-415. Resolution: Fixed > Use surefire/failsafe version from ASF parent > - > > Key: MPOM-415 > URL: https://issues.apache.org/jira/browse/MPOM-415 > Project: Maven POMs > Issue Type: Task > Components: maven >Reporter: Slawomir Jaranowski >Assignee: Slawomir Jaranowski >Priority: Major > Fix For: MAVEN-40 > > > ASF parent will have the newest version of surefire, we need not to override > it. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [maven-parent] slawekjaranowski merged pull request #119: [MPOM-415] Use surefire/failsafe version from ASF parent
slawekjaranowski merged PR #119: URL: https://github.com/apache/maven-parent/pull/119 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-indexer] mbien commented on a diff in pull request #302: filter in index reader and use update request for configuration
mbien commented on code in PR #302: URL: https://github.com/apache/maven-indexer/pull/302#discussion_r1166968347 ## indexer-core/src/main/java/org/apache/maven/index/updater/DefaultIndexUpdater.java: ## @@ -233,7 +233,7 @@ private static void filterDirectory(final Directory directory, final DocumentFil continue; } -Document d = r.document(i); +Document d = r.storedFields().document(i); Review Comment: just in case someone is wondering what this does: it removes a deprecation warning -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Comment Edited] (MRELEASE-1119) release plugin ignores developmentVersion
[
https://issues.apache.org/jira/browse/MRELEASE-1119?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17712387#comment-17712387
]
Karl Heinz Marbaise edited comment on MRELEASE-1119 at 4/14/23 1:28 PM:
No. The property file contained the same versions as your pom file already
contained (next release versions implied by the existing SNAPSHOT versions)
which looks like it's working but it does not working that way. Just set your
version in your pom file to lets say {{3.2.0-SNAPSHOT}} commit that and then
define the content of your {{release.properties}} file with the following:
{code}
tag=release-3.3.0
releaseVersion=3.3.0
developmentVersion=3.4.0-SNAPSHOT
{code}
and just try to run: {{mvn -B release:prepare}} and look in the pom and the
created tag etc... it will tag: 3.2.0 and your pom (last commit will be 3.2.0)
etc. so not workgin at all...as documented...
If you in contradiction fill the {{release.properties}} file with correct
key/value pairs like this:
{code}
scm.tag=release-3.3.0
project.dev.io.rhpatrick.test\:mrp-test=3.4.0-SNAPSHOT
project.rel.io.rhpatrick.test\:mrp-test=3.3.0
{code}
and run {{mvn -B release:prepare}} you will see the difference...
was (Author: khmarbaise):
No. The property file contained the same versions as your pom file already
contained (next release versions implied by the existing SNAPSHOT versions)
which looks like it's working but it does not working that way. Just set your
version in your pom file to lets say {{3.2.0-SNAPSHOT}} commit that and then
define the content of your {{release.properties}} file with the following:
{code}
tag=release-3.3.0
releaseVersion=3.3.0
developmentVersion=3.4.0-SNAPSHOT {code}
{code}
and just try to run: {{mvn -B release:prepare}} and look in the pom and the
created tag etc... it will tag: 3.2.0 and your pom (last commit will be 3.2.0)
etc. so not workgin at all...as documented...
If you in contradiction fill the {{release.properties}} file with correct
key/value pairs like this:
{code}
scm.tag=release-3.3.0
project.dev.io.rhpatrick.test\:mrp-test=3.4.0-SNAPSHOT
project.rel.io.rhpatrick.test\:mrp-test=3.3.0
{code}
and run {{mvn -B release:prepare}} you will see the difference...
> release plugin ignores developmentVersion
> -
>
> Key: MRELEASE-1119
> URL: https://issues.apache.org/jira/browse/MRELEASE-1119
> Project: Maven Release Plugin
> Issue Type: Bug
>Affects Versions: 3.0.0
>Reporter: Robert Patrick
>Assignee: Karl Heinz Marbaise
>Priority: Major
>
> I just ran a release process using the 3.0.0 version of the
> maven-release-plugin with a release.properties file like this:
> {{tag=release-3.0.4}}
> {{releaseVersion=3.0.4}}
> {{developmentVersion=3.1.0-SNAPSHOT}}
> After running {{mvn -B release:prepare release:perform}}, the pom.xml version
> is 3.0.5-SNAPSHOT.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MRELEASE-1119) release plugin ignores developmentVersion
[
https://issues.apache.org/jira/browse/MRELEASE-1119?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17712387#comment-17712387
]
Karl Heinz Marbaise commented on MRELEASE-1119:
---
No. The property file contained the same versions as your pom file already
contained (next release versions implied by the existing SNAPSHOT versions)
which looks like it's working but it does not working that way. Just set your
version in your pom file to lets say {{3.2.0-SNAPSHOT}} commit that and then
define the content of your {{release.properties}} file with the following:
{code}
tag=release-3.3.0
releaseVersion=3.3.0
developmentVersion=3.4.0-SNAPSHOT {code}
{code}
and just try to run: {{mvn -B release:prepare}} and look in the pom and the
created tag etc... it will tag: 3.2.0 and your pom (last commit will be 3.2.0)
etc. so not workgin at all...as documented...
If you in contradiction fill the {{release.properties}} file with correct
key/value pairs like this:
{code}
scm.tag=release-3.3.0
project.dev.io.rhpatrick.test\:mrp-test=3.4.0-SNAPSHOT
project.rel.io.rhpatrick.test\:mrp-test=3.3.0
{code}
and run {{mvn -B release:prepare}} you will see the difference...
> release plugin ignores developmentVersion
> -
>
> Key: MRELEASE-1119
> URL: https://issues.apache.org/jira/browse/MRELEASE-1119
> Project: Maven Release Plugin
> Issue Type: Bug
>Affects Versions: 3.0.0
>Reporter: Robert Patrick
>Assignee: Karl Heinz Marbaise
>Priority: Major
>
> I just ran a release process using the 3.0.0 version of the
> maven-release-plugin with a release.properties file like this:
> {{tag=release-3.0.4}}
> {{releaseVersion=3.0.4}}
> {{developmentVersion=3.1.0-SNAPSHOT}}
> After running {{mvn -B release:prepare release:perform}}, the pom.xml version
> is 3.0.5-SNAPSHOT.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MRELEASE-1119) release plugin ignores developmentVersion
[
https://issues.apache.org/jira/browse/MRELEASE-1119?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17712367#comment-17712367
]
Robert Patrick commented on MRELEASE-1119:
--
That is really ugly. The property file I showed works perfectly fine except
when changing the development version. Not sure I understand why the same
system properties you use on the command-line cannot be used in the
release.properties file. Seems like everything expect the developmentVersion
is already working using the old approach I was using. If this were my
project, I would treat that as a bug...
> release plugin ignores developmentVersion
> -
>
> Key: MRELEASE-1119
> URL: https://issues.apache.org/jira/browse/MRELEASE-1119
> Project: Maven Release Plugin
> Issue Type: Bug
>Affects Versions: 3.0.0
>Reporter: Robert Patrick
>Assignee: Karl Heinz Marbaise
>Priority: Major
>
> I just ran a release process using the 3.0.0 version of the
> maven-release-plugin with a release.properties file like this:
> {{tag=release-3.0.4}}
> {{releaseVersion=3.0.4}}
> {{developmentVersion=3.1.0-SNAPSHOT}}
> After running {{mvn -B release:prepare release:perform}}, the pom.xml version
> is 3.0.5-SNAPSHOT.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MNG-6303) .mvn/jvm.config and .mvn/maven.config should allow to resolve environment variables
[
https://issues.apache.org/jira/browse/MNG-6303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17712345#comment-17712345
]
ASF GitHub Bot commented on MNG-6303:
-
gnodet commented on code in PR #1062:
URL: https://github.com/apache/maven/pull/1062#discussion_r1166721249
##
maven-embedder/src/test/java/org/apache/maven/cli/MavenCliTest.java:
##
@@ -544,6 +544,19 @@ public void populatePropertiesOverwrite() throws Exception
{
assertThat(request.getUserProperties().getProperty("x"), is("false"));
}
+@Test
+public void testPropertiesInterpolation() throws Exception {
Review Comment:
Added some tests.
> .mvn/jvm.config and .mvn/maven.config should allow to resolve environment
> variables
> ---
>
> Key: MNG-6303
> URL: https://issues.apache.org/jira/browse/MNG-6303
> Project: Maven
> Issue Type: New Feature
> Components: Bootstrap & Build
>Affects Versions: 3.5.0
>Reporter: Konrad Windszus
>Priority: Major
>
> With the mechanism of having project-specific maven options being specified
> in {{.mvn/maven.config}} and {{.mvn/jvm.config}} (MNG-6267) it is often handy
> to share those settings among multiple developers (i.e. via maintaining it
> via the SCM). Unfortunately the mechanism does not support resolving
> environment variables, which makes it hard to deal with user-specific
> directories or settings. Please support resolving environment variables
> through a special pattern like {{$ENV_NAME}}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[GitHub] [maven] gnodet commented on a diff in pull request #1062: [MNG-6303] Interpolate user supplied properties and command line arguments
gnodet commented on code in PR #1062:
URL: https://github.com/apache/maven/pull/1062#discussion_r1166721249
##
maven-embedder/src/test/java/org/apache/maven/cli/MavenCliTest.java:
##
@@ -544,6 +544,19 @@ public void populatePropertiesOverwrite() throws Exception
{
assertThat(request.getUserProperties().getProperty("x"), is("false"));
}
+@Test
+public void testPropertiesInterpolation() throws Exception {
Review Comment:
Added some tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Commented] (MNG-7038) Introduce public property to point to a root directory of (multi-module) project
[
https://issues.apache.org/jira/browse/MNG-7038?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17712298#comment-17712298
]
ASF GitHub Bot commented on MNG-7038:
-
michael-o commented on PR #1061:
URL: https://github.com/apache/maven/pull/1061#issuecomment-1508241579
I'll try to review this weekend.
> Introduce public property to point to a root directory of (multi-module)
> project
>
>
> Key: MNG-7038
> URL: https://issues.apache.org/jira/browse/MNG-7038
> Project: Maven
> Issue Type: Improvement
>Reporter: Envious Guest
>Assignee: Guillaume Nodet
>Priority: Major
> Fix For: 4.0.0-alpha-6
>
>
> This is a request to expose a property *maven.multiModuleProjectDirectory*
> which is currently internal (or introduce a brand new one with analogous
> functionality).
> * For a single-module project, its value should be same as *project.basedir*
> * For multi-module project, its value should point to a project.basedir of a
> root module
> Example:
> multi-module // located at /home/me/sources
> +- module-a
> +- module B
> Sample multi-module/pom.xml:
> {{}}
> {{ }}
> {{ com.acme}}
> {{ corp-parent}}
> {{ 1.0.0-RELEASE}}
> {{ }}
> {{ com.acme}}
> {{ multi-module}}
> {{ 0.5.2-SNAPSHOT}}
> {{ }}
> {{ module-a}}
> {{ module-b}}
> {{ }}
> {{}}
> The property requested should return /home/me/sources/multi-module,
> regardless of whether it's referenced in any of the child modules (module-a,
> module-b) or in multi-module.
> Note that multi-module itself has parent (e.g. installed in a local
> repository), so the new property should be smart enough to detect it and
> still point to /home/me/sources/multi-module instead of the local repository
> where the corp-parent is installed.
> The use-case for such a property could be to have a directory for combined
> report of static analysis tools. Typical example - jacoco combined coverage
> reports.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[GitHub] [maven] michael-o commented on pull request #1061: [MNG-7038] Introduce public property to point to a root directory of (multi-module) project
michael-o commented on PR #1061: URL: https://github.com/apache/maven/pull/1061#issuecomment-1508241579 I'll try to review this weekend. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MNG-7038) Introduce public property to point to a root directory of (multi-module) project
[
https://issues.apache.org/jira/browse/MNG-7038?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17712288#comment-17712288
]
ASF GitHub Bot commented on MNG-7038:
-
gnodet commented on PR #1061:
URL: https://github.com/apache/maven/pull/1061#issuecomment-1508214020
I'm done with the changes and added an IT.
> Introduce public property to point to a root directory of (multi-module)
> project
>
>
> Key: MNG-7038
> URL: https://issues.apache.org/jira/browse/MNG-7038
> Project: Maven
> Issue Type: Improvement
>Reporter: Envious Guest
>Assignee: Guillaume Nodet
>Priority: Major
> Fix For: 4.0.0-alpha-6
>
>
> This is a request to expose a property *maven.multiModuleProjectDirectory*
> which is currently internal (or introduce a brand new one with analogous
> functionality).
> * For a single-module project, its value should be same as *project.basedir*
> * For multi-module project, its value should point to a project.basedir of a
> root module
> Example:
> multi-module // located at /home/me/sources
> +- module-a
> +- module B
> Sample multi-module/pom.xml:
> {{}}
> {{ }}
> {{ com.acme}}
> {{ corp-parent}}
> {{ 1.0.0-RELEASE}}
> {{ }}
> {{ com.acme}}
> {{ multi-module}}
> {{ 0.5.2-SNAPSHOT}}
> {{ }}
> {{ module-a}}
> {{ module-b}}
> {{ }}
> {{}}
> The property requested should return /home/me/sources/multi-module,
> regardless of whether it's referenced in any of the child modules (module-a,
> module-b) or in multi-module.
> Note that multi-module itself has parent (e.g. installed in a local
> repository), so the new property should be smart enough to detect it and
> still point to /home/me/sources/multi-module instead of the local repository
> where the corp-parent is installed.
> The use-case for such a property could be to have a directory for combined
> report of static analysis tools. Typical example - jacoco combined coverage
> reports.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[GitHub] [maven] gnodet commented on pull request #1061: [MNG-7038] Introduce public property to point to a root directory of (multi-module) project
gnodet commented on PR #1061: URL: https://github.com/apache/maven/pull/1061#issuecomment-1508214020 I'm done with the changes and added an IT. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MNG-7038) Introduce public property to point to a root directory of (multi-module) project
[
https://issues.apache.org/jira/browse/MNG-7038?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17712285#comment-17712285
]
ASF GitHub Bot commented on MNG-7038:
-
gnodet commented on code in PR #1061:
URL: https://github.com/apache/maven/pull/1061#discussion_r1166567100
##
maven-core/src/main/java/org/apache/maven/execution/MavenExecutionRequest.java:
##
@@ -494,14 +504,49 @@ public interface MavenExecutionRequest {
/**
* @since 3.3.0
+ * @deprecated use {@link #setRootdir(Path)} instead
*/
+@Deprecated
void setMultiModuleProjectDirectory(File file);
/**
* @since 3.3.0
+ * @deprecated use {@link #getRootdir()} instead
*/
+@Deprecated
File getMultiModuleProjectDirectory();
+/**
+ * Sets the root dir of the project.
+ *
+ * @since 4.0.0
+ */
+MavenExecutionRequest setRootdir(Path rootdir);
+
+/**
+ * Gets the root dir of the project, which is the up-most directory of the
reactor, usually containing
+ * the {@code .mvn} directory.
+ *
+ * @since 4.0.0
+ */
+Path getRootdir();
+
+/**
+ * Sets the top dir of the project.
+ *
+ * @since 4.0.0
+ */
+MavenExecutionRequest setTopdir(Path topdir);
+
+/**
+ * Gets the top dir of the project, which is the up-most directory of the
reactor projects.
Review Comment:
I've removed the confusing part.
> Introduce public property to point to a root directory of (multi-module)
> project
>
>
> Key: MNG-7038
> URL: https://issues.apache.org/jira/browse/MNG-7038
> Project: Maven
> Issue Type: Improvement
>Reporter: Envious Guest
>Assignee: Guillaume Nodet
>Priority: Major
> Fix For: 4.0.0-alpha-6
>
>
> This is a request to expose a property *maven.multiModuleProjectDirectory*
> which is currently internal (or introduce a brand new one with analogous
> functionality).
> * For a single-module project, its value should be same as *project.basedir*
> * For multi-module project, its value should point to a project.basedir of a
> root module
> Example:
> multi-module // located at /home/me/sources
> +- module-a
> +- module B
> Sample multi-module/pom.xml:
> {{}}
> {{ }}
> {{ com.acme}}
> {{ corp-parent}}
> {{ 1.0.0-RELEASE}}
> {{ }}
> {{ com.acme}}
> {{ multi-module}}
> {{ 0.5.2-SNAPSHOT}}
> {{ }}
> {{ module-a}}
> {{ module-b}}
> {{ }}
> {{}}
> The property requested should return /home/me/sources/multi-module,
> regardless of whether it's referenced in any of the child modules (module-a,
> module-b) or in multi-module.
> Note that multi-module itself has parent (e.g. installed in a local
> repository), so the new property should be smart enough to detect it and
> still point to /home/me/sources/multi-module instead of the local repository
> where the corp-parent is installed.
> The use-case for such a property could be to have a directory for combined
> report of static analysis tools. Typical example - jacoco combined coverage
> reports.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[GitHub] [maven] gnodet commented on a diff in pull request #1061: [MNG-7038] Introduce public property to point to a root directory of (multi-module) project
gnodet commented on code in PR #1061:
URL: https://github.com/apache/maven/pull/1061#discussion_r1166567100
##
maven-core/src/main/java/org/apache/maven/execution/MavenExecutionRequest.java:
##
@@ -494,14 +504,49 @@ public interface MavenExecutionRequest {
/**
* @since 3.3.0
+ * @deprecated use {@link #setRootdir(Path)} instead
*/
+@Deprecated
void setMultiModuleProjectDirectory(File file);
/**
* @since 3.3.0
+ * @deprecated use {@link #getRootdir()} instead
*/
+@Deprecated
File getMultiModuleProjectDirectory();
+/**
+ * Sets the root dir of the project.
+ *
+ * @since 4.0.0
+ */
+MavenExecutionRequest setRootdir(Path rootdir);
+
+/**
+ * Gets the root dir of the project, which is the up-most directory of the
reactor, usually containing
+ * the {@code .mvn} directory.
+ *
+ * @since 4.0.0
+ */
+Path getRootdir();
+
+/**
+ * Sets the top dir of the project.
+ *
+ * @since 4.0.0
+ */
+MavenExecutionRequest setTopdir(Path topdir);
+
+/**
+ * Gets the top dir of the project, which is the up-most directory of the
reactor projects.
Review Comment:
I've removed the confusing part.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Commented] (MNG-7764) Small Code Improvments.
[
https://issues.apache.org/jira/browse/MNG-7764?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17712276#comment-17712276
]
ASF GitHub Bot commented on MNG-7764:
-
gnodet commented on code in PR #1088:
URL: https://github.com/apache/maven/pull/1088#discussion_r1166498043
##
maven-core/src/main/java/org/apache/maven/internal/impl/DefaultToolchainsBuilder.java:
##
@@ -55,23 +54,17 @@ public
DefaultToolchainsBuilder(org.apache.maven.toolchain.building.ToolchainsBu
@Override
public ToolchainsBuilderResult build(ToolchainsBuilderRequest request)
throws ToolchainsBuilderException, IllegalArgumentException {
-DefaultSession session = (DefaultSession) request.getSession();
try {
DefaultToolchainsBuildingRequest req = new
DefaultToolchainsBuildingRequest();
-if (request.getGlobalToolchainsSource().isPresent()) {
-req.setGlobalToolchainsSource(new MappedToolchainsSource(
-request.getGlobalToolchainsSource().get()));
-} else if (request.getGlobalToolchainsPath().isPresent()) {
-req.setGlobalToolchainsSource(new
org.apache.maven.building.FileSource(
-request.getGlobalToolchainsPath().get().toFile()));
-}
-if (request.getUserToolchainsSource().isPresent()) {
-req.setUserToolchainsSource(new MappedToolchainsSource(
-request.getUserToolchainsSource().get()));
-} else if (request.getUserToolchainsPath().isPresent()) {
-req.setUserToolchainsSource(new
org.apache.maven.building.FileSource(
-request.getUserToolchainsPath().get().toFile()));
-}
+
+request.getGlobalToolchainsSource()
+.ifPresent(s -> req.setGlobalToolchainsSource(new
MappedToolchainsSource(s)));
+request.getGlobalToolchainsPath().ifPresent(s ->
req.setGlobalToolchainsSource(new FileSource(s.toFile(;
Review Comment:
Not sure if this is problematic, but the before and after code are not
equivalent.
In the code before, the `setGlobalToolchainsSource` cannot be called twice
because of the `else if` statement. With the new proposed code, a second call
will override the first one...
##
maven-core/src/main/java/org/apache/maven/internal/impl/DefaultToolchainsBuilder.java:
##
@@ -55,23 +54,17 @@ public
DefaultToolchainsBuilder(org.apache.maven.toolchain.building.ToolchainsBu
@Override
public ToolchainsBuilderResult build(ToolchainsBuilderRequest request)
throws ToolchainsBuilderException, IllegalArgumentException {
-DefaultSession session = (DefaultSession) request.getSession();
try {
DefaultToolchainsBuildingRequest req = new
DefaultToolchainsBuildingRequest();
-if (request.getGlobalToolchainsSource().isPresent()) {
-req.setGlobalToolchainsSource(new MappedToolchainsSource(
-request.getGlobalToolchainsSource().get()));
-} else if (request.getGlobalToolchainsPath().isPresent()) {
-req.setGlobalToolchainsSource(new
org.apache.maven.building.FileSource(
-request.getGlobalToolchainsPath().get().toFile()));
-}
-if (request.getUserToolchainsSource().isPresent()) {
-req.setUserToolchainsSource(new MappedToolchainsSource(
-request.getUserToolchainsSource().get()));
-} else if (request.getUserToolchainsPath().isPresent()) {
-req.setUserToolchainsSource(new
org.apache.maven.building.FileSource(
-request.getUserToolchainsPath().get().toFile()));
-}
+
+request.getGlobalToolchainsSource()
+.ifPresent(s -> req.setGlobalToolchainsSource(new
MappedToolchainsSource(s)));
+request.getGlobalToolchainsPath().ifPresent(s ->
req.setGlobalToolchainsSource(new FileSource(s.toFile(;
+
+request.getUserToolchainsSource()
+.ifPresent(s -> req.setUserToolchainsSource(new
MappedToolchainsSource(s)));
+request.getUserToolchainsPath().ifPresent(s ->
req.setUserToolchainsSource(new FileSource(s.toFile(;
Review Comment:
Same here
> Small Code Improvments.
> ---
>
> Key: MNG-7764
> URL: https://issues.apache.org/jira/browse/MNG-7764
> Project: Maven
> Issue Type: Improvement
>Affects Versions: 4.0.0-alpha-5
>Reporter: Karl Heinz Marbaise
>Assignee: Karl Heinz Marbaise
>Priority: Minor
> Fix For: 4.0.0-alpha-6
>
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[GitHub] [maven] gnodet commented on a diff in pull request #1088: [MNG-7764] - Small Code Improvments.
gnodet commented on code in PR #1088:
URL: https://github.com/apache/maven/pull/1088#discussion_r1166498043
##
maven-core/src/main/java/org/apache/maven/internal/impl/DefaultToolchainsBuilder.java:
##
@@ -55,23 +54,17 @@ public
DefaultToolchainsBuilder(org.apache.maven.toolchain.building.ToolchainsBu
@Override
public ToolchainsBuilderResult build(ToolchainsBuilderRequest request)
throws ToolchainsBuilderException, IllegalArgumentException {
-DefaultSession session = (DefaultSession) request.getSession();
try {
DefaultToolchainsBuildingRequest req = new
DefaultToolchainsBuildingRequest();
-if (request.getGlobalToolchainsSource().isPresent()) {
-req.setGlobalToolchainsSource(new MappedToolchainsSource(
-request.getGlobalToolchainsSource().get()));
-} else if (request.getGlobalToolchainsPath().isPresent()) {
-req.setGlobalToolchainsSource(new
org.apache.maven.building.FileSource(
-request.getGlobalToolchainsPath().get().toFile()));
-}
-if (request.getUserToolchainsSource().isPresent()) {
-req.setUserToolchainsSource(new MappedToolchainsSource(
-request.getUserToolchainsSource().get()));
-} else if (request.getUserToolchainsPath().isPresent()) {
-req.setUserToolchainsSource(new
org.apache.maven.building.FileSource(
-request.getUserToolchainsPath().get().toFile()));
-}
+
+request.getGlobalToolchainsSource()
+.ifPresent(s -> req.setGlobalToolchainsSource(new
MappedToolchainsSource(s)));
+request.getGlobalToolchainsPath().ifPresent(s ->
req.setGlobalToolchainsSource(new FileSource(s.toFile(;
Review Comment:
Not sure if this is problematic, but the before and after code are not
equivalent.
In the code before, the `setGlobalToolchainsSource` cannot be called twice
because of the `else if` statement. With the new proposed code, a second call
will override the first one...
##
maven-core/src/main/java/org/apache/maven/internal/impl/DefaultToolchainsBuilder.java:
##
@@ -55,23 +54,17 @@ public
DefaultToolchainsBuilder(org.apache.maven.toolchain.building.ToolchainsBu
@Override
public ToolchainsBuilderResult build(ToolchainsBuilderRequest request)
throws ToolchainsBuilderException, IllegalArgumentException {
-DefaultSession session = (DefaultSession) request.getSession();
try {
DefaultToolchainsBuildingRequest req = new
DefaultToolchainsBuildingRequest();
-if (request.getGlobalToolchainsSource().isPresent()) {
-req.setGlobalToolchainsSource(new MappedToolchainsSource(
-request.getGlobalToolchainsSource().get()));
-} else if (request.getGlobalToolchainsPath().isPresent()) {
-req.setGlobalToolchainsSource(new
org.apache.maven.building.FileSource(
-request.getGlobalToolchainsPath().get().toFile()));
-}
-if (request.getUserToolchainsSource().isPresent()) {
-req.setUserToolchainsSource(new MappedToolchainsSource(
-request.getUserToolchainsSource().get()));
-} else if (request.getUserToolchainsPath().isPresent()) {
-req.setUserToolchainsSource(new
org.apache.maven.building.FileSource(
-request.getUserToolchainsPath().get().toFile()));
-}
+
+request.getGlobalToolchainsSource()
+.ifPresent(s -> req.setGlobalToolchainsSource(new
MappedToolchainsSource(s)));
+request.getGlobalToolchainsPath().ifPresent(s ->
req.setGlobalToolchainsSource(new FileSource(s.toFile(;
+
+request.getUserToolchainsSource()
+.ifPresent(s -> req.setUserToolchainsSource(new
MappedToolchainsSource(s)));
+request.getUserToolchainsPath().ifPresent(s ->
req.setUserToolchainsSource(new FileSource(s.toFile(;
Review Comment:
Same here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Created] (MNG-7765) Minimum Build Requirement is wrong
Karl Heinz Marbaise created MNG-7765: Summary: Minimum Build Requirement is wrong Key: MNG-7765 URL: https://issues.apache.org/jira/browse/MNG-7765 Project: Maven Issue Type: Improvement Affects Versions: 4.0.0-alpha-5 Reporter: Karl Heinz Marbaise Assignee: Karl Heinz Marbaise Fix For: 4.0.0-alpha-6 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MASFRES-30) Exclude all CI configuration files
[
https://issues.apache.org/jira/browse/MASFRES-30?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17712251#comment-17712251
]
Michael Osipov commented on MASFRES-30:
---
I disagree, there are plugins which read those files and continue processing,
.e.g, RAT plugin. Very much like {{.editorconfig}}.
> Exclude all CI configuration files
> --
>
> Key: MASFRES-30
> URL: https://issues.apache.org/jira/browse/MASFRES-30
> Project: Apache Maven Resource Bundles
> Issue Type: Improvement
> Components: apache-source-release-assembly-descriptor
>Affects Versions: apache-source-release-assembly-descriptor-1.0.6
>Reporter: Michael Osipov
>Assignee: Michael Osipov
>Priority: Major
> Fix For: apache-resources 1.5
>
>
> Exclude:
> * {{.github}}
> * {{Jenkinsfile}}
> * {{.asf.yaml}}
> * {{.travis.yml}}
> * {{deploySite.sh}}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MNG-7691) Provide a generic way to skip Maven Goals for a specified plugin
[ https://issues.apache.org/jira/browse/MNG-7691?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17712232#comment-17712232 ] ASF GitHub Bot commented on MNG-7691: - gnodet commented on PR #1086: URL: https://github.com/apache/maven/pull/1086#issuecomment-1508057578 The proposed syntax is problematic to me as it's not coherent with the one displayed to the user. Users now see: ``` [INFO] [INFO] - > Provide a generic way to skip Maven Goals for a specified plugin > > > Key: MNG-7691 > URL: https://issues.apache.org/jira/browse/MNG-7691 > Project: Maven > Issue Type: Improvement > Components: Plugins and Lifecycle >Reporter: Jimisola Laursen >Priority: Major > > From ([Baeldung|https://www.baeldung.com/maven-disable-parent-pom-plugin]: > "Many plugins feature a skip parameter. We can use the skip parameter to > disable the plugin. Support for the skip parameter should be the first thing > we check because it is the simplest solution and the most conventional.". > I was thinking that there should be a generic way to skip maven plugin goals > in the core of Maven, i.e. it should not have to be implemented in each > plugin. > Would something like this work? > -Dmaven.skip.goals=groupID:artifactId:goal (is there a need to specify > version?) > E.g. > -Dmaven.skip.goals=io.spring.javaformat:spring-javaformat-maven-plugin:apply > -Dmaven.skip.goals=io.spring.javaformat:spring-javaformat-maven-plugin:apply+validate > -Dmaven.skip.goals=io.spring.javaformat:spring-javaformat-maven-plugin:apply+validate,org.apache.maven.plugins:maven-enforcer-plugin:enforce -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [maven] gnodet commented on pull request #1086: [MNG-7691] Lifecycle filter
gnodet commented on PR #1086: URL: https://github.com/apache/maven/pull/1086#issuecomment-1508057578 The proposed syntax is problematic to me as it's not coherent with the one displayed to the user. Users now see: ``` [INFO] [INFO] --- checkstyle:3.0.0:check (checkstyle-check) @ core-it-suite --- [INFO] [INFO] --- enforcer:3.1.0:enforce (enforce-bytecode-version) @ core-it-suite --- [INFO] Adding ignore: module-info [INFO] [INFO] --- enforcer:3.1.0:enforce (enforce-maven-version) @ core-it-suite --- [INFO] [INFO] --- enforcer:3.1.0:enforce (enforce-java-version) @ core-it-suite --- [INFO] [INFO] --- remote-resources:1.7.0:process (process-resource-bundles) @ core-it-suite --- [WARN] The POM for org.apache.maven.wagon:wagon-http-lightweight:jar:1.0-beta-6 is invalid, transitive dependencies (if any) will not be available, enable verbose output (-X) for more details ``` so we need to use a syntax which actually supports what is displayed such as `enforcer:3.1.0:enforce`. So it should be coherent with: * https://github.com/apache/maven/blob/master/maven-core/src/main/java/org/apache/maven/lifecycle/internal/DefaultLifecycleTaskSegmentCalculator.java#L95 * https://github.com/apache/maven/blob/master/maven-embedder/src/main/java/org/apache/maven/cli/event/ExecutionEventLogger.java#L422-L431 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MASFRES-30) Exclude all CI configuration files
[
https://issues.apache.org/jira/browse/MASFRES-30?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17712224#comment-17712224
]
Christopher Tubbs commented on MASFRES-30:
--
[~michael-o] I think I would argue that the .gitignore and .gitattributes
files are also meta files for git, and also the .git file when in a git
worktree. All those only have meaning/utility inside a git repository. Inside a
source artifact with the .git directory removed and the git aspect removed,
they have no value, similar to the IDE files.
> Exclude all CI configuration files
> --
>
> Key: MASFRES-30
> URL: https://issues.apache.org/jira/browse/MASFRES-30
> Project: Apache Maven Resource Bundles
> Issue Type: Improvement
> Components: apache-source-release-assembly-descriptor
>Affects Versions: apache-source-release-assembly-descriptor-1.0.6
>Reporter: Michael Osipov
>Assignee: Michael Osipov
>Priority: Major
> Fix For: apache-resources 1.5
>
>
> Exclude:
> * {{.github}}
> * {{Jenkinsfile}}
> * {{.asf.yaml}}
> * {{.travis.yml}}
> * {{deploySite.sh}}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
