[jira] [Commented] (MNG-6401) Cannot interpolate property in proxy port of settings.xml
[ https://issues.apache.org/jira/browse/MNG-6401?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17726436#comment-17726436 ] ASF GitHub Bot commented on MNG-6401: - WilliamYuhangLee commented on PR #163: URL: https://github.com/apache/maven/pull/163#issuecomment-1563688366 Hi, can we please get some traction on this issue? It's now the middle of 2023 and yet Maven still has silly problems like this > Cannot interpolate property in proxy port of settings.xml > - > > Key: MNG-6401 > URL: https://issues.apache.org/jira/browse/MNG-6401 > Project: Maven > Issue Type: Bug > Components: Bootstrap Build, Settings >Affects Versions: 3.0, 3.5.3 >Reporter: KATADA Junya >Priority: Minor > Fix For: 4.0.x-candidate > > > If you use a property in proxy port of settings.xml, the property is not > replaced and the port number is "0" instead of property value. > My minimal demo about this problem is > [here|https://github.com/jkatada/maven-property-demo]. > In my demo, export two environment variables as follows. > {code} > export MAVEN_PROXY_HOST_STRING=proxy.foo.com > export MAVEN_PROXY_PORT_INT=18080 > {code} > These variables are used in settings.xml for proxy settings. > {code:xml} > > my_proxy > true > http > ${env.MAVEN_PROXY_HOST_STRING} > ${env.MAVEN_PROXY_PORT_INT} > local.net|some.host.com > > {code} > Execute maven-help-plugin to show effective settings.xml. > {code} > mvn help:effective-settings -X > {code} > The result is as follows. > {code:xml} > > 0 > proxy.foo.com > local.net|some.host.com > my_proxy > > {code} > `*${env.MAVEN_PROXY_HOST_STRING}*` is replaced with `*proxy.foo.com*`, > but `*${env.MAVEN_PROXY_PORT_INT}*` is not replaced with `*18080*`. > I found the following WARNING message in console. > {code:java} > [WARNING] Some problems were encountered while building the effective settings > [WARNING] Unable to parse element 'port', must be an integer (position: > END_TAG seen ...${env.MAVEN_PROXY_PORT_INT}... @12:47) caused > by: java.lang.NumberFormatException: For input string: > "${env.MAVEN_PROXY_PORT_INT}" @ /root/.m2/settings.xml, line 12, column 47 > {code} > I think that the cause of this problem is to parse settings.xml before > interpolation. > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [maven] WilliamYuhangLee commented on pull request #163: [MNG-6401] - Cannot interpolate property in proxy port of settings.xml
WilliamYuhangLee commented on PR #163: URL: https://github.com/apache/maven/pull/163#issuecomment-1563688366 Hi, can we please get some traction on this issue? It's now the middle of 2023 and yet Maven still has silly problems like this -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MNG-7796) Top directory cannot be computed
[ https://issues.apache.org/jira/browse/MNG-7796?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17726413#comment-17726413 ] Gregory Hart commented on MNG-7796: --- It seems related to [JDK-8172711|https://bugs.openjdk.org/browse/JDK-8172711] where Path.getRealPath() throws an exception when the path is on a docker volume inside a Windows guest. Maybe the call to Path.getRealPath() could be replaced with Path.normalize()? > Top directory cannot be computed > > > Key: MNG-7796 > URL: https://issues.apache.org/jira/browse/MNG-7796 > Project: Maven > Issue Type: Bug > Components: Command Line >Affects Versions: 3.9.2 > Environment: Windows Server Core 2016 guest running inside a docker > container on a Windows Server 2016 EC2 machine >Reporter: Gregory Hart >Priority: Major > > When running Maven it exits immediately with return code 1 after writing > "Error computing real path" to the console. > Here is the full console output: > {noformat} > Error computing real path from > C:\Users\Administrator\jenkins\workspace\myproject_release_1.0\src\myproject\src: > > C:\Users\Administrator\jenkins\workspace\myproject_release_1.0\src\myproject\src{noformat} -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [maven] gnodet commented on pull request #1129: Automatic discovery of JDK Toolchains
gnodet commented on PR #1129: URL: https://github.com/apache/maven/pull/1129#issuecomment-1563597871 > very interesting/nice feature! > sdkman can be used with osx as well. I haven’t reviewed the code enough but not sure if the current draft takes care of this? IntelliJ does ;) yes, that's taken care of ! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Comment Edited] (MRESOLVER-363) Maven metadata is not updated in some cases
[ https://issues.apache.org/jira/browse/MRESOLVER-363?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17726404#comment-17726404 ] Tamas Cservenak edited comment on MRESOLVER-363 at 5/25/23 9:56 PM: The file was present, but created with maven-compat, that uses different key for lastUpdated, so effectively, code behaved like not present, as key for lastUpdated was not found. was (Author: cstamas): It was present, but created with maven-compat, that uses different key for lastUpdated, so effectively, code behaved like not present, as key for lastUpdated nor value for it was not found. > Maven metadata is not updated in some cases > --- > > Key: MRESOLVER-363 > URL: https://issues.apache.org/jira/browse/MRESOLVER-363 > Project: Maven Resolver > Issue Type: Bug >Affects Versions: 1.9.10 >Reporter: Tamas Cservenak >Priority: Major > > Seems when update check for metadata happens, and: > * maven-metadata XML is present, but > * resolver-status.properties is not, OR was created by maven-compat, that > uses different key for lastUpdated. Effectively the value of lastUpdated is > not present. > The update check falsely DO NOT check for update, as it will end up with > update policy "never" in update policy analyzer. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (MRESOLVER-363) Maven metadata is not updated in some cases
[ https://issues.apache.org/jira/browse/MRESOLVER-363?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tamas Cservenak updated MRESOLVER-363: -- Description: Seems when update check for metadata happens, and: * maven-metadata XML is present, but * resolver-status.properties is not, OR was created by maven-compat, that uses different key for lastUpdated. Effectively the value of lastUpdated is not present. The update check falsely DO NOT check for update, as it will end up with update policy "never" in update policy analyzer. was: Seems when update check for metadata happens, and: * maven-metadata XML is present, but * resolver-status.properties is not The update check falsely DO NOT check for update, as it will end up with update policy "never" in update policy analyzer. > Maven metadata is not updated in some cases > --- > > Key: MRESOLVER-363 > URL: https://issues.apache.org/jira/browse/MRESOLVER-363 > Project: Maven Resolver > Issue Type: Bug >Affects Versions: 1.9.10 >Reporter: Tamas Cservenak >Priority: Major > > Seems when update check for metadata happens, and: > * maven-metadata XML is present, but > * resolver-status.properties is not, OR was created by maven-compat, that > uses different key for lastUpdated. Effectively the value of lastUpdated is > not present. > The update check falsely DO NOT check for update, as it will end up with > update policy "never" in update policy analyzer. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MRESOLVER-363) Maven metadata is not updated in some cases
[ https://issues.apache.org/jira/browse/MRESOLVER-363?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17726404#comment-17726404 ] Tamas Cservenak commented on MRESOLVER-363: --- It was present, but created with maven-compat, that uses different key for lastUpdated, so effectively, code behaved like not present, as key nor lastUpdated value was not found. > Maven metadata is not updated in some cases > --- > > Key: MRESOLVER-363 > URL: https://issues.apache.org/jira/browse/MRESOLVER-363 > Project: Maven Resolver > Issue Type: Bug >Affects Versions: 1.9.10 >Reporter: Tamas Cservenak >Priority: Major > > Seems when update check for metadata happens, and: > * maven-metadata XML is present, but > * resolver-status.properties is not > The update check falsely DO NOT check for update, as it will end up with > update policy "never" in update policy analyzer. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Comment Edited] (MRESOLVER-363) Maven metadata is not updated in some cases
[ https://issues.apache.org/jira/browse/MRESOLVER-363?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17726404#comment-17726404 ] Tamas Cservenak edited comment on MRESOLVER-363 at 5/25/23 9:50 PM: It was present, but created with maven-compat, that uses different key for lastUpdated, so effectively, code behaved like not present, as key for lastUpdated nor value for it was not found. was (Author: cstamas): It was present, but created with maven-compat, that uses different key for lastUpdated, so effectively, code behaved like not present, as key nor lastUpdated value was not found. > Maven metadata is not updated in some cases > --- > > Key: MRESOLVER-363 > URL: https://issues.apache.org/jira/browse/MRESOLVER-363 > Project: Maven Resolver > Issue Type: Bug >Affects Versions: 1.9.10 >Reporter: Tamas Cservenak >Priority: Major > > Seems when update check for metadata happens, and: > * maven-metadata XML is present, but > * resolver-status.properties is not > The update check falsely DO NOT check for update, as it will end up with > update policy "never" in update policy analyzer. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MRESOLVER-363) Maven metadata is not updated in some cases
[ https://issues.apache.org/jira/browse/MRESOLVER-363?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17726402#comment-17726402 ] Garret Wilson commented on MRESOLVER-363: - The description indicates that {{resolver-status.properties}} is not present. I understand that this is part of the scenario used initially to reproduce this problem in [Versions Maven Plugin Issue #959|https://github.com/mojohaus/versions/issues/959], but I just wanted to mention that for the original case {{resolver-status.properties}} was in fact present and this problem still presented itself. > Maven metadata is not updated in some cases > --- > > Key: MRESOLVER-363 > URL: https://issues.apache.org/jira/browse/MRESOLVER-363 > Project: Maven Resolver > Issue Type: Bug >Affects Versions: 1.9.10 >Reporter: Tamas Cservenak >Priority: Major > > Seems when update check for metadata happens, and: > * maven-metadata XML is present, but > * resolver-status.properties is not > The update check falsely DO NOT check for update, as it will end up with > update policy "never" in update policy analyzer. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (MRESOLVER-363) Maven metadata is not updated in some cases
Tamas Cservenak created MRESOLVER-363: - Summary: Maven metadata is not updated in some cases Key: MRESOLVER-363 URL: https://issues.apache.org/jira/browse/MRESOLVER-363 Project: Maven Resolver Issue Type: Bug Affects Versions: 1.9.10 Reporter: Tamas Cservenak Seems when update check for metadata happens, and: * maven-metadata XML is present, but * resolver-status.properties is not The update check falsely DO NOT check for update, as it will end up with update policy "never" in update policy analyzer. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (MANTRUN-239) Update parent pom to 39
[ https://issues.apache.org/jira/browse/MANTRUN-239?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sylwester Lachiewicz updated MANTRUN-239: - Fix Version/s: 3.2.0 > Update parent pom to 39 > --- > > Key: MANTRUN-239 > URL: https://issues.apache.org/jira/browse/MANTRUN-239 > Project: Maven Antrun Plugin > Issue Type: Dependency upgrade >Reporter: Elliotte Rusty Harold >Assignee: Sylwester Lachiewicz >Priority: Major > Fix For: 3.2.0 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Assigned] (MANTRUN-239) Update parent pom to 39
[ https://issues.apache.org/jira/browse/MANTRUN-239?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sylwester Lachiewicz reassigned MANTRUN-239: Assignee: Sylwester Lachiewicz > Update parent pom to 39 > --- > > Key: MANTRUN-239 > URL: https://issues.apache.org/jira/browse/MANTRUN-239 > Project: Maven Antrun Plugin > Issue Type: Dependency upgrade >Reporter: Elliotte Rusty Harold >Assignee: Sylwester Lachiewicz >Priority: Major > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MANTRUN-239) Update parent pom to 39
[ https://issues.apache.org/jira/browse/MANTRUN-239?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17726391#comment-17726391 ] ASF GitHub Bot commented on MANTRUN-239: slachiewicz opened a new pull request, #80: URL: https://github.com/apache/maven-antrun-plugin/pull/80 (no comment) > Update parent pom to 39 > --- > > Key: MANTRUN-239 > URL: https://issues.apache.org/jira/browse/MANTRUN-239 > Project: Maven Antrun Plugin > Issue Type: Dependency upgrade >Reporter: Elliotte Rusty Harold >Priority: Major > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [maven-antrun-plugin] dependabot[bot] commented on pull request #73: Bump maven-plugins from 34 to 39
dependabot[bot] commented on PR #73: URL: https://github.com/apache/maven-antrun-plugin/pull/73#issuecomment-1563503751 OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting `@dependabot ignore this major version` or `@dependabot ignore this minor version`. You can also ignore all major, minor, or patch releases for a dependency by adding an [`ignore` condition](https://docs.github.com/en/code-security/supply-chain-security/configuration-options-for-dependency-updates#ignore) with the desired `update_types` to your config file. If you change your mind, just re-open this PR and I'll resolve any conflicts on it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Closed] (MANTRUN-238) Upgrade parent POM to version 37
[ https://issues.apache.org/jira/browse/MANTRUN-238?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sylwester Lachiewicz closed MANTRUN-238. Resolution: Duplicate > Upgrade parent POM to version 37 > > > Key: MANTRUN-238 > URL: https://issues.apache.org/jira/browse/MANTRUN-238 > Project: Maven Antrun Plugin > Issue Type: Dependency upgrade >Reporter: Sylwester Lachiewicz >Assignee: Sylwester Lachiewicz >Priority: Minor > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MNG-7796) Top directory cannot be computed
[ https://issues.apache.org/jira/browse/MNG-7796?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17726384#comment-17726384 ] Gregory Hart commented on MNG-7796: --- No stack trace is displayed. I enabled debug logging with "mvn -X" and no additional output is displayed. Looking at the source code, I see that ExitException is thrown. I think that causes System.exit() to be called without printing a stack trace. https://github.com/apache/maven/blob/maven-3.9.2/maven-embedder/src/main/java/org/apache/maven/cli/MavenCli.java#L356 > Top directory cannot be computed > > > Key: MNG-7796 > URL: https://issues.apache.org/jira/browse/MNG-7796 > Project: Maven > Issue Type: Bug > Components: Command Line >Affects Versions: 3.9.2 > Environment: Windows Server Core 2016 guest running inside a docker > container on a Windows Server 2016 EC2 machine >Reporter: Gregory Hart >Priority: Major > > When running Maven it exits immediately with return code 1 after writing > "Error computing real path" to the console. > Here is the full console output: > {noformat} > Error computing real path from > C:\Users\Administrator\jenkins\workspace\myproject_release_1.0\src\myproject\src: > > C:\Users\Administrator\jenkins\workspace\myproject_release_1.0\src\myproject\src{noformat} -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (SUREFIRE-2164) Simplify serialization of elapsed time in StatelessXmlReporter
[ https://issues.apache.org/jira/browse/SUREFIRE-2164?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17726372#comment-17726372 ] ASF GitHub Bot commented on SUREFIRE-2164: -- michael-o commented on code in PR #645: URL: https://github.com/apache/maven-surefire/pull/645#discussion_r1205937494 ## maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/report/StatelessXmlReporter.java: ## @@ -387,7 +390,9 @@ private void startTestElement(XMLWriter ppw, WrappedReportEntry report) throws I ppw.addAttribute("classname", extraEscapeAttribute(className)); } -ppw.addAttribute("time", report.elapsedTimeAsString()); Review Comment: Yet another problem is that it was used only in one dir, not in both which is inconsistent and non-portable. I have basically applied what Ant does: https://github.com/apache/ant/blob/6f68fbdefad521741b37304cfdfc6d8646cf1839/src/main/org/apache/tools/ant/taskdefs/optional/junit/XMLJUnitResultFormatter.java#L189-L190 > Simplify serialization of elapsed time in StatelessXmlReporter > -- > > Key: SUREFIRE-2164 > URL: https://issues.apache.org/jira/browse/SUREFIRE-2164 > Project: Maven Surefire > Issue Type: Improvement > Components: xml generation >Affects Versions: 3.1.0 >Reporter: Michael Osipov >Assignee: Michael Osipov >Priority: Major > Fix For: 3.1.1 > > > The current code uses a convoluted solution based on {{NumberFormat}} which > refers to an outdated defintion on Ant's XML report file. These days, we can > use {{String#valueOf()}} to serialize the string representation of a float > value since: > * Easier to understand and this is not human output (separation of concerns) > * Ant's XMLJUnitResultFormatter does exactly the same with a double value. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [maven-surefire] michael-o commented on a diff in pull request #645: Simplify serialization/deserialization of elapsed time (SUREFIRE-2164 + SUREFIRE-2167)
michael-o commented on code in PR #645: URL: https://github.com/apache/maven-surefire/pull/645#discussion_r1205937494 ## maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/report/StatelessXmlReporter.java: ## @@ -387,7 +390,9 @@ private void startTestElement(XMLWriter ppw, WrappedReportEntry report) throws I ppw.addAttribute("classname", extraEscapeAttribute(className)); } -ppw.addAttribute("time", report.elapsedTimeAsString()); Review Comment: Yet another problem is that it was used only in one dir, not in both which is inconsistent and non-portable. I have basically applied what Ant does: https://github.com/apache/ant/blob/6f68fbdefad521741b37304cfdfc6d8646cf1839/src/main/org/apache/tools/ant/taskdefs/optional/junit/XMLJUnitResultFormatter.java#L189-L190 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (SUREFIRE-2164) Simplify serialization of elapsed time in StatelessXmlReporter
[ https://issues.apache.org/jira/browse/SUREFIRE-2164?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17726365#comment-17726365 ] ASF GitHub Bot commented on SUREFIRE-2164: -- michael-o commented on code in PR #645: URL: https://github.com/apache/maven-surefire/pull/645#discussion_r1205932070 ## maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/report/StatelessXmlReporter.java: ## @@ -387,7 +390,9 @@ private void startTestElement(XMLWriter ppw, WrappedReportEntry report) throws I ppw.addAttribute("classname", extraEscapeAttribute(className)); } -ppw.addAttribute("time", report.elapsedTimeAsString()); Review Comment: No, we can't. See here: https://github.com/apache/maven-surefire/pull/635/commits/9dab367d7e200022b4e88eb58cdfcf281824a124#diff-efbf1a613b0d3b854d7a732ab8f6221fa5ac34210449cdfb4eee6bb61a60c1ccR185 In fact, this subsequent commit makes `ReporterUtils` superfluous. My object was to clearly seperate serialization/deserialization of machine data (which are never locale-specific, but neutral), rendering happens in the view layer: https://github.com/apache/maven-surefire/pull/635/commits/9dab367d7e200022b4e88eb58cdfcf281824a124#diff-efbf1a613b0d3b854d7a732ab8f6221fa5ac34210449cdfb4eee6bb61a60c1ccR59-R61 > Simplify serialization of elapsed time in StatelessXmlReporter > -- > > Key: SUREFIRE-2164 > URL: https://issues.apache.org/jira/browse/SUREFIRE-2164 > Project: Maven Surefire > Issue Type: Improvement > Components: xml generation >Affects Versions: 3.1.0 >Reporter: Michael Osipov >Assignee: Michael Osipov >Priority: Major > Fix For: 3.1.1 > > > The current code uses a convoluted solution based on {{NumberFormat}} which > refers to an outdated defintion on Ant's XML report file. These days, we can > use {{String#valueOf()}} to serialize the string representation of a float > value since: > * Easier to understand and this is not human output (separation of concerns) > * Ant's XMLJUnitResultFormatter does exactly the same with a double value. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [maven-surefire] michael-o commented on a diff in pull request #645: Simplify serialization/deserialization of elapsed time (SUREFIRE-2164 + SUREFIRE-2167)
michael-o commented on code in PR #645: URL: https://github.com/apache/maven-surefire/pull/645#discussion_r1205932070 ## maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/report/StatelessXmlReporter.java: ## @@ -387,7 +390,9 @@ private void startTestElement(XMLWriter ppw, WrappedReportEntry report) throws I ppw.addAttribute("classname", extraEscapeAttribute(className)); } -ppw.addAttribute("time", report.elapsedTimeAsString()); Review Comment: No, we can't. See here: https://github.com/apache/maven-surefire/pull/635/commits/9dab367d7e200022b4e88eb58cdfcf281824a124#diff-efbf1a613b0d3b854d7a732ab8f6221fa5ac34210449cdfb4eee6bb61a60c1ccR185 In fact, this subsequent commit makes `ReporterUtils` superfluous. My object was to clearly seperate serialization/deserialization of machine data (which are never locale-specific, but neutral), rendering happens in the view layer: https://github.com/apache/maven-surefire/pull/635/commits/9dab367d7e200022b4e88eb58cdfcf281824a124#diff-efbf1a613b0d3b854d7a732ab8f6221fa5ac34210449cdfb4eee6bb61a60c1ccR59-R61 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-apache-parent] ctubbsii commented on a diff in pull request #155: [MPOM-289] Use properties to define the versions of plugins
ctubbsii commented on code in PR #155: URL: https://github.com/apache/maven-apache-parent/pull/155#discussion_r1205931901 ## pom.xml: ## @@ -96,6 +96,34 @@ under the License. 3.1.0 3.9.0 posix + + +0.15 +3.1.0 +3.6.0 +3.2.0 +3.11.0 +3.6.0 +3.1.1 +3.3.0 +3.3.0 +3.1.0 +3.4.0 +3.1.1 +3.5.1 +3.3.0 +3.5.0 + 3.4.3 +3.0.0 + 3.1.0 +3.3.1 +2.0.1 +3.2.1 +3.4.1 +3.12.1 +3.3.0 +3.3.2 Review Comment: @slawekjaranowski The [maven-site-plugin documentation](https://maven.apache.org/plugins/maven-site-plugin/examples/creating-content.html#Filtering) says you can use `$context.get("my.property")`, so that's not a problem. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (SUREFIRE-2164) Simplify serialization of elapsed time in StatelessXmlReporter
[ https://issues.apache.org/jira/browse/SUREFIRE-2164?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17726364#comment-17726364 ] ASF GitHub Bot commented on SUREFIRE-2164: -- michael-o commented on code in PR #645: URL: https://github.com/apache/maven-surefire/pull/645#discussion_r1205929141 ## maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/report/StatelessXmlReporter.java: ## @@ -387,7 +390,9 @@ private void startTestElement(XMLWriter ppw, WrappedReportEntry report) throws I ppw.addAttribute("classname", extraEscapeAttribute(className)); } -ppw.addAttribute("time", report.elapsedTimeAsString()); +if (report.getElapsed() != null) { +ppw.addAttribute("time", String.valueOf(report.getElapsed() / ONE_SECOND)); Review Comment: No, it won't. That's the good point about it. It is a straight locale-neutral serialization if a float. > Simplify serialization of elapsed time in StatelessXmlReporter > -- > > Key: SUREFIRE-2164 > URL: https://issues.apache.org/jira/browse/SUREFIRE-2164 > Project: Maven Surefire > Issue Type: Improvement > Components: xml generation >Affects Versions: 3.1.0 >Reporter: Michael Osipov >Assignee: Michael Osipov >Priority: Major > Fix For: 3.1.1 > > > The current code uses a convoluted solution based on {{NumberFormat}} which > refers to an outdated defintion on Ant's XML report file. These days, we can > use {{String#valueOf()}} to serialize the string representation of a float > value since: > * Easier to understand and this is not human output (separation of concerns) > * Ant's XMLJUnitResultFormatter does exactly the same with a double value. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [maven-surefire] michael-o commented on a diff in pull request #645: Simplify serialization/deserialization of elapsed time (SUREFIRE-2164 + SUREFIRE-2167)
michael-o commented on code in PR #645: URL: https://github.com/apache/maven-surefire/pull/645#discussion_r1205929141 ## maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/report/StatelessXmlReporter.java: ## @@ -387,7 +390,9 @@ private void startTestElement(XMLWriter ppw, WrappedReportEntry report) throws I ppw.addAttribute("classname", extraEscapeAttribute(className)); } -ppw.addAttribute("time", report.elapsedTimeAsString()); +if (report.getElapsed() != null) { +ppw.addAttribute("time", String.valueOf(report.getElapsed() / ONE_SECOND)); Review Comment: No, it won't. That's the good point about it. It is a straight locale-neutral serialization if a float. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-apache-parent] ctubbsii commented on a diff in pull request #155: [MPOM-289] Use properties to define the versions of plugins
ctubbsii commented on code in PR #155: URL: https://github.com/apache/maven-apache-parent/pull/155#discussion_r1205928192 ## pom.xml: ## @@ -96,6 +96,34 @@ under the License. 3.1.0 3.9.0 posix + + +0.15 +3.1.0 +3.6.0 +3.2.0 +3.11.0 +3.6.0 +3.1.1 +3.3.0 +3.3.0 +3.1.0 +3.4.0 +3.1.1 +3.5.1 +3.3.0 +3.5.0 + 3.4.3 +3.0.0 + 3.1.0 +3.3.1 +2.0.1 +3.2.1 +3.4.1 +3.12.1 +3.3.0 +3.3.2 Review Comment: I'm not sure I understand your use case, but couldn't you use the maven-resources-plugin to filter Maven variables into your velocity templates? Or use your own velocity-compatible variables? A slight variation that might accommodate that use case would be to use another dash, rather than a dot. The important principle is that "version" comes first, so when the properties are all sorted, the ones that specify versions are all grouped together, and that the part after "version" is the same as the artifact name, so it's easy to grep. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (SUREFIRE-2164) Simplify serialization of elapsed time in StatelessXmlReporter
[ https://issues.apache.org/jira/browse/SUREFIRE-2164?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17726362#comment-17726362 ] ASF GitHub Bot commented on SUREFIRE-2164: -- slawekjaranowski commented on code in PR #645: URL: https://github.com/apache/maven-surefire/pull/645#discussion_r1205911407 ## maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/report/StatelessXmlReporter.java: ## @@ -387,7 +390,9 @@ private void startTestElement(XMLWriter ppw, WrappedReportEntry report) throws I ppw.addAttribute("classname", extraEscapeAttribute(className)); } -ppw.addAttribute("time", report.elapsedTimeAsString()); +if (report.getElapsed() != null) { +ppw.addAttribute("time", String.valueOf(report.getElapsed() / ONE_SECOND)); Review Comment: This can depend on user locales like use dot or comma as separator - should we take care about it? ## maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/report/StatelessXmlReporter.java: ## @@ -387,7 +390,9 @@ private void startTestElement(XMLWriter ppw, WrappedReportEntry report) throws I ppw.addAttribute("classname", extraEscapeAttribute(className)); } -ppw.addAttribute("time", report.elapsedTimeAsString()); Review Comment: Can we remove method `elapsedTimeAsString` and used `org.apache.maven.plugin.surefire.report.ReporterUtils`? > Simplify serialization of elapsed time in StatelessXmlReporter > -- > > Key: SUREFIRE-2164 > URL: https://issues.apache.org/jira/browse/SUREFIRE-2164 > Project: Maven Surefire > Issue Type: Improvement > Components: xml generation >Affects Versions: 3.1.0 >Reporter: Michael Osipov >Assignee: Michael Osipov >Priority: Major > Fix For: 3.1.1 > > > The current code uses a convoluted solution based on {{NumberFormat}} which > refers to an outdated defintion on Ant's XML report file. These days, we can > use {{String#valueOf()}} to serialize the string representation of a float > value since: > * Easier to understand and this is not human output (separation of concerns) > * Ant's XMLJUnitResultFormatter does exactly the same with a double value. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MNG-7796) Top directory cannot be computed
[ https://issues.apache.org/jira/browse/MNG-7796?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17726357#comment-17726357 ] Tamas Cservenak commented on MNG-7796: -- Can you provide stack trace? > Top directory cannot be computed > > > Key: MNG-7796 > URL: https://issues.apache.org/jira/browse/MNG-7796 > Project: Maven > Issue Type: Bug > Components: Command Line >Affects Versions: 3.9.2 > Environment: Windows Server Core 2016 guest running inside a docker > container on a Windows Server 2016 EC2 machine >Reporter: Gregory Hart >Priority: Major > > When running Maven it exits immediately with return code 1 after writing > "Error computing real path" to the console. > Here is the full console output: > {noformat} > Error computing real path from > C:\Users\Administrator\jenkins\workspace\myproject_release_1.0\src\myproject\src: > > C:\Users\Administrator\jenkins\workspace\myproject_release_1.0\src\myproject\src{noformat} -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MNG-7796) Top directory cannot be computed
[ https://issues.apache.org/jira/browse/MNG-7796?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17726348#comment-17726348 ] Gregory Hart commented on MNG-7796: --- I suspect this is caused by MNG-7774 since that's the only place in the code with this error message. It was added in Maven 3.9.2 and I verified that Maven 3.9.1 does not have this issue. > Top directory cannot be computed > > > Key: MNG-7796 > URL: https://issues.apache.org/jira/browse/MNG-7796 > Project: Maven > Issue Type: Bug > Components: Command Line >Affects Versions: 3.9.2 > Environment: Windows Server Core 2016 guest running inside a docker > container on a Windows Server 2016 EC2 machine >Reporter: Gregory Hart >Priority: Major > > When running Maven it exits immediately with return code 1 after writing > "Error computing real path" to the console. > Here is the full console output: > {noformat} > Error computing real path from > C:\Users\Administrator\jenkins\workspace\myproject_release_1.0\src\myproject\src: > > C:\Users\Administrator\jenkins\workspace\myproject_release_1.0\src\myproject\src{noformat} -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (MNG-7796) Top directory cannot be computed
Gregory Hart created MNG-7796: - Summary: Top directory cannot be computed Key: MNG-7796 URL: https://issues.apache.org/jira/browse/MNG-7796 Project: Maven Issue Type: Bug Components: Command Line Affects Versions: 3.9.2 Environment: Windows Server Core 2016 guest running inside a docker container on a Windows Server 2016 EC2 machine Reporter: Gregory Hart When running Maven it exits immediately with return code 1 after writing "Error computing real path" to the console. Here is the full console output: {noformat} Error computing real path from C:\Users\Administrator\jenkins\workspace\myproject_release_1.0\src\myproject\src: C:\Users\Administrator\jenkins\workspace\myproject_release_1.0\src\myproject\src{noformat} -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [maven] gnodet opened a new pull request, #1129: Automatic discovery of JDK Toolchains
gnodet opened a new pull request, #1129: URL: https://github.com/apache/maven/pull/1129 Following this checklist to help us incorporate your contribution quickly and easily: - [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/MNG) filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes. - [ ] Each commit in the pull request should have a meaningful subject line and body. - [ ] Format the pull request title like `[MNG-XXX] SUMMARY`, where you replace `MNG-XXX` and `SUMMARY` with the appropriate JIRA issue. - [ ] Also format the first line of the commit message like `[MNG-XXX] SUMMARY`. Best practice is to use the JIRA issue title in both the pull request title and in the first line of the commit message. - [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [ ] Run `mvn clean verify` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically. - [ ] You have run the [Core IT][core-its] successfully. If your pull request is about ~20 lines of code you don't need to sign an [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure please ask on the developers list. To make clear that you license your contribution under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) you have to acknowledge this by using the following check-box. - [ ] I hereby declare this contribution to be licenced under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) - [ ] In any other case, please file an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). [core-its]: https://maven.apache.org/core-its/core-it-suite/ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MSHARED-1256) Add support for Multi-Release jars
[ https://issues.apache.org/jira/browse/MSHARED-1256?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17726323#comment-17726323 ] Gabriel Belingueres commented on MSHARED-1256: -- Provided a PR: https://github.com/apache/maven-shared-jar/pull/21 > Add support for Multi-Release jars > -- > > Key: MSHARED-1256 > URL: https://issues.apache.org/jira/browse/MSHARED-1256 > Project: Maven Shared Components > Issue Type: New Feature > Components: maven-shared-jar >Affects Versions: maven-shared-jar-3.0.0 >Reporter: Gabriel Belingueres >Priority: Major > > Add support for Multi-Release jars. > Currently the library is reporting wrong information. For example with > artifact org.codehause.plexus:{color:#00}plexus-utils:3.5.1, the > JarData.jdkRevision() method reports 11, but the library targets 8 (with some > classes targeting Java 9 and 11).{color} -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MRESOLVER-362) NoSuchFileException moving .tmp to .jar
[ https://issues.apache.org/jira/browse/MRESOLVER-362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17726239#comment-17726239 ] Michael Osipov commented on MRESOLVER-362: -- I would highly prefer a sample project with npm and and the rat load comes with it. Fails for me: {noformat} [INFO] warning " > react-markdown@8.0.7" has unmet peer dependency "@types/react@>=16". [INFO] error An unexpected error occurred: "ENOSYS: function not implemented, copyfile '/net/home/osipovmi/.cache/yarn/v6/npm-make-dir-2.1.0-5f0310e18b8be898cc07009295a30ae41e91e6f5-integrity/node_modules/make-dir/index.d.ts' -> '/var/osipovmi/Projekte/start.spring.io/start-client/node_modules/@babel/cli/node_modules/make-dir/index.d.ts'". [INFO] error An unexpected error occurred: "ENOSYS: function not implemented, copyfile '/net/home/osipovmi/.cache/yarn/v6/npm-make-dir-2.1.0-5f0310e18b8be898cc07009295a30ae41e91e6f5-integrity/node_modules/make-dir/index.d.ts' -> '/var/osipovmi/Projekte/start.spring.io/start-client/node_modules/@babel/cli/node_modules/make-dir/index.d.ts'".info If you think this is a bug, please open a bug report with the information provided in "/var/osipovmi/Projekte/start.spring.io/start-client/yarn-error.log". [INFO] info Visit https://yarnpkg.com/en/docs/cli/install for documentation about this command. [INFO] [INFO] Reactor Summary for start.spring.io 0.0.1-SNAPSHOT: [INFO] [INFO] start.spring.io SUCCESS [ 0.819 s] [INFO] start.spring.io client . FAILURE [ 9.644 s] [INFO] start.spring.io website SKIPPED [INFO] [INFO] BUILD FAILURE {noformat} > NoSuchFileException moving .tmp to .jar > --- > > Key: MRESOLVER-362 > URL: https://issues.apache.org/jira/browse/MRESOLVER-362 > Project: Maven Resolver > Issue Type: Bug >Affects Versions: 1.9.10 >Reporter: Stephane Nicoll >Priority: Major > > It looks like MRESOLVER-290 broke our metadata verification tests. We have a > test that uses the resolver API to collect a bunch of dependencies, and > checking the state is correct. Since the upgrade to 1.9 we get this > {noformat} > Caused by: org.eclipse.aether.transfer.ArtifactTransferException: Could not > transfer artifact > org.springframework.boot:spring-boot-starter:jar:3.0.8-20230525.115211-13 > from/to spring-snapshots (https://repo.spring.io/snapshot): > /var/folders/46/2wr2nf9x0nzd1220xfnp1nzrgn/T/metadata-validation-m28912614894186841938/org/springframework/boot/spring-boot-starter/3.0.8-SNAPSHOT/spring-boot-starter-3.0.8-20230525.115211-13.jar.4959477968260906889.tmp > -> > /var/folders/46/2wr2nf9x0nzd1220xfnp1nzrgn/T/metadata-validation-m28912614894186841938/org/springframework/boot/spring-boot-starter/3.0.8-SNAPSHOT/spring-boot-starter-3.0.8-20230525.115211-13.jar > at > org.eclipse.aether.connector.basic.ArtifactTransportListener.transferFailed(ArtifactTransportListener.java:44) > at > org.eclipse.aether.connector.basic.BasicRepositoryConnector$TaskRunner.run(BasicRepositoryConnector.java:417) > at > org.eclipse.aether.connector.basic.BasicRepositoryConnector.get(BasicRepositoryConnector.java:260) > at > org.eclipse.aether.internal.impl.DefaultArtifactResolver.performDownloads(DefaultArtifactResolver.java:536) > at > org.eclipse.aether.internal.impl.DefaultArtifactResolver.resolve(DefaultArtifactResolver.java:448) > ... 45 more > Caused by: java.nio.file.NoSuchFileException: > /var/folders/46/2wr2nf9x0nzd1220xfnp1nzrgn/T/metadata-validation-m28912614894186841938/org/springframework/boot/spring-boot-starter/3.0.8-SNAPSHOT/spring-boot-starter-3.0.8-20230525.115211-13.jar.4959477968260906889.tmp > -> > /var/folders/46/2wr2nf9x0nzd1220xfnp1nzrgn/T/metadata-validation-m28912614894186841938/org/springframework/boot/spring-boot-starter/3.0.8-SNAPSHOT/spring-boot-starter-3.0.8-20230525.115211-13.jar > at > java.base/sun.nio.fs.UnixException.translateToIOException(UnixException.java:92) > at > java.base/sun.nio.fs.UnixException.rethrowAsIOException(UnixException.java:106) > at java.base/sun.nio.fs.UnixCopyFile.move(UnixCopyFile.java:416) > at > java.base/sun.nio.fs.UnixFileSystemProvider.move(UnixFileSystemProvider.java:266) > at java.base/java.nio.file.Files.move(Files.java:1432) > at org.eclipse.aether.util.FileUtils$2.move(FileUtils.java:108) > at > org.eclipse.aether.connector.basic.BasicRepositoryConnector$GetTaskRunner.runTask(BasicRepositoryConnector.java:500) > at >
[GitHub] [maven-apache-parent] slawekjaranowski commented on a diff in pull request #155: [MPOM-289] Use properties to define the versions of plugins
slawekjaranowski commented on code in PR #155: URL: https://github.com/apache/maven-apache-parent/pull/155#discussion_r1205549486 ## pom.xml: ## @@ -96,6 +96,34 @@ under the License. 3.1.0 3.9.0 posix + + +0.15 +3.1.0 +3.6.0 +3.2.0 +3.11.0 +3.6.0 +3.1.1 +3.3.0 +3.3.0 +3.1.0 +3.4.0 +3.1.1 +3.5.1 +3.3.0 +3.5.0 + 3.4.3 +3.0.0 + 3.1.0 +3.3.1 +2.0.1 +3.2.1 +3.4.1 +3.12.1 +3.3.0 +3.3.2 Review Comment: I want to reuse those values in many place also in documentation in .vm files ... but we can not use 'dot' for velocity templates. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MRESOLVER-362) NoSuchFileException moving .tmp to .jar
[ https://issues.apache.org/jira/browse/MRESOLVER-362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17726201#comment-17726201 ] Stephane Nicoll commented on MRESOLVER-362: --- If you want to give it a try with the latest state, make sure to revert 1ed8af5 as I've downgraded to 1.8 in the meantime. > NoSuchFileException moving .tmp to .jar > --- > > Key: MRESOLVER-362 > URL: https://issues.apache.org/jira/browse/MRESOLVER-362 > Project: Maven Resolver > Issue Type: Bug >Affects Versions: 1.9.10 >Reporter: Stephane Nicoll >Priority: Major > > It looks like MRESOLVER-290 broke our metadata verification tests. We have a > test that uses the resolver API to collect a bunch of dependencies, and > checking the state is correct. Since the upgrade to 1.9 we get this > {noformat} > Caused by: org.eclipse.aether.transfer.ArtifactTransferException: Could not > transfer artifact > org.springframework.boot:spring-boot-starter:jar:3.0.8-20230525.115211-13 > from/to spring-snapshots (https://repo.spring.io/snapshot): > /var/folders/46/2wr2nf9x0nzd1220xfnp1nzrgn/T/metadata-validation-m28912614894186841938/org/springframework/boot/spring-boot-starter/3.0.8-SNAPSHOT/spring-boot-starter-3.0.8-20230525.115211-13.jar.4959477968260906889.tmp > -> > /var/folders/46/2wr2nf9x0nzd1220xfnp1nzrgn/T/metadata-validation-m28912614894186841938/org/springframework/boot/spring-boot-starter/3.0.8-SNAPSHOT/spring-boot-starter-3.0.8-20230525.115211-13.jar > at > org.eclipse.aether.connector.basic.ArtifactTransportListener.transferFailed(ArtifactTransportListener.java:44) > at > org.eclipse.aether.connector.basic.BasicRepositoryConnector$TaskRunner.run(BasicRepositoryConnector.java:417) > at > org.eclipse.aether.connector.basic.BasicRepositoryConnector.get(BasicRepositoryConnector.java:260) > at > org.eclipse.aether.internal.impl.DefaultArtifactResolver.performDownloads(DefaultArtifactResolver.java:536) > at > org.eclipse.aether.internal.impl.DefaultArtifactResolver.resolve(DefaultArtifactResolver.java:448) > ... 45 more > Caused by: java.nio.file.NoSuchFileException: > /var/folders/46/2wr2nf9x0nzd1220xfnp1nzrgn/T/metadata-validation-m28912614894186841938/org/springframework/boot/spring-boot-starter/3.0.8-SNAPSHOT/spring-boot-starter-3.0.8-20230525.115211-13.jar.4959477968260906889.tmp > -> > /var/folders/46/2wr2nf9x0nzd1220xfnp1nzrgn/T/metadata-validation-m28912614894186841938/org/springframework/boot/spring-boot-starter/3.0.8-SNAPSHOT/spring-boot-starter-3.0.8-20230525.115211-13.jar > at > java.base/sun.nio.fs.UnixException.translateToIOException(UnixException.java:92) > at > java.base/sun.nio.fs.UnixException.rethrowAsIOException(UnixException.java:106) > at java.base/sun.nio.fs.UnixCopyFile.move(UnixCopyFile.java:416) > at > java.base/sun.nio.fs.UnixFileSystemProvider.move(UnixFileSystemProvider.java:266) > at java.base/java.nio.file.Files.move(Files.java:1432) > at org.eclipse.aether.util.FileUtils$2.move(FileUtils.java:108) > at > org.eclipse.aether.connector.basic.BasicRepositoryConnector$GetTaskRunner.runTask(BasicRepositoryConnector.java:500) > at > org.eclipse.aether.connector.basic.BasicRepositoryConnector$TaskRunner.run(BasicRepositoryConnector.java:414) > {noformat} > The test is here > https://github.com/spring-io/start.spring.io/tree/main/start-site-verification/src/test/java/io/spring/start/site -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MRESOLVER-362) NoSuchFileException moving .tmp to .jar
[ https://issues.apache.org/jira/browse/MRESOLVER-362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17726200#comment-17726200 ] Stephane Nicoll commented on MRESOLVER-362: --- Yes. I have a particular occurrence that fails every time, and on that same artifact above. > NoSuchFileException moving .tmp to .jar > --- > > Key: MRESOLVER-362 > URL: https://issues.apache.org/jira/browse/MRESOLVER-362 > Project: Maven Resolver > Issue Type: Bug >Affects Versions: 1.9.10 >Reporter: Stephane Nicoll >Priority: Major > > It looks like MRESOLVER-290 broke our metadata verification tests. We have a > test that uses the resolver API to collect a bunch of dependencies, and > checking the state is correct. Since the upgrade to 1.9 we get this > {noformat} > Caused by: org.eclipse.aether.transfer.ArtifactTransferException: Could not > transfer artifact > org.springframework.boot:spring-boot-starter:jar:3.0.8-20230525.115211-13 > from/to spring-snapshots (https://repo.spring.io/snapshot): > /var/folders/46/2wr2nf9x0nzd1220xfnp1nzrgn/T/metadata-validation-m28912614894186841938/org/springframework/boot/spring-boot-starter/3.0.8-SNAPSHOT/spring-boot-starter-3.0.8-20230525.115211-13.jar.4959477968260906889.tmp > -> > /var/folders/46/2wr2nf9x0nzd1220xfnp1nzrgn/T/metadata-validation-m28912614894186841938/org/springframework/boot/spring-boot-starter/3.0.8-SNAPSHOT/spring-boot-starter-3.0.8-20230525.115211-13.jar > at > org.eclipse.aether.connector.basic.ArtifactTransportListener.transferFailed(ArtifactTransportListener.java:44) > at > org.eclipse.aether.connector.basic.BasicRepositoryConnector$TaskRunner.run(BasicRepositoryConnector.java:417) > at > org.eclipse.aether.connector.basic.BasicRepositoryConnector.get(BasicRepositoryConnector.java:260) > at > org.eclipse.aether.internal.impl.DefaultArtifactResolver.performDownloads(DefaultArtifactResolver.java:536) > at > org.eclipse.aether.internal.impl.DefaultArtifactResolver.resolve(DefaultArtifactResolver.java:448) > ... 45 more > Caused by: java.nio.file.NoSuchFileException: > /var/folders/46/2wr2nf9x0nzd1220xfnp1nzrgn/T/metadata-validation-m28912614894186841938/org/springframework/boot/spring-boot-starter/3.0.8-SNAPSHOT/spring-boot-starter-3.0.8-20230525.115211-13.jar.4959477968260906889.tmp > -> > /var/folders/46/2wr2nf9x0nzd1220xfnp1nzrgn/T/metadata-validation-m28912614894186841938/org/springframework/boot/spring-boot-starter/3.0.8-SNAPSHOT/spring-boot-starter-3.0.8-20230525.115211-13.jar > at > java.base/sun.nio.fs.UnixException.translateToIOException(UnixException.java:92) > at > java.base/sun.nio.fs.UnixException.rethrowAsIOException(UnixException.java:106) > at java.base/sun.nio.fs.UnixCopyFile.move(UnixCopyFile.java:416) > at > java.base/sun.nio.fs.UnixFileSystemProvider.move(UnixFileSystemProvider.java:266) > at java.base/java.nio.file.Files.move(Files.java:1432) > at org.eclipse.aether.util.FileUtils$2.move(FileUtils.java:108) > at > org.eclipse.aether.connector.basic.BasicRepositoryConnector$GetTaskRunner.runTask(BasicRepositoryConnector.java:500) > at > org.eclipse.aether.connector.basic.BasicRepositoryConnector$TaskRunner.run(BasicRepositoryConnector.java:414) > {noformat} > The test is here > https://github.com/spring-io/start.spring.io/tree/main/start-site-verification/src/test/java/io/spring/start/site -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MRESOLVER-362) NoSuchFileException moving .tmp to .jar
[ https://issues.apache.org/jira/browse/MRESOLVER-362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17726195#comment-17726195 ] Michael Osipov commented on MRESOLVER-362: -- [~snicoll], can this reliably re reproduced? > NoSuchFileException moving .tmp to .jar > --- > > Key: MRESOLVER-362 > URL: https://issues.apache.org/jira/browse/MRESOLVER-362 > Project: Maven Resolver > Issue Type: Bug >Affects Versions: 1.9.10 >Reporter: Stephane Nicoll >Priority: Major > > It looks like MRESOLVER-290 broke our metadata verification tests. We have a > test that uses the resolver API to collect a bunch of dependencies, and > checking the state is correct. Since the upgrade to 1.9 we get this > {noformat} > Caused by: org.eclipse.aether.transfer.ArtifactTransferException: Could not > transfer artifact > org.springframework.boot:spring-boot-starter:jar:3.0.8-20230525.115211-13 > from/to spring-snapshots (https://repo.spring.io/snapshot): > /var/folders/46/2wr2nf9x0nzd1220xfnp1nzrgn/T/metadata-validation-m28912614894186841938/org/springframework/boot/spring-boot-starter/3.0.8-SNAPSHOT/spring-boot-starter-3.0.8-20230525.115211-13.jar.4959477968260906889.tmp > -> > /var/folders/46/2wr2nf9x0nzd1220xfnp1nzrgn/T/metadata-validation-m28912614894186841938/org/springframework/boot/spring-boot-starter/3.0.8-SNAPSHOT/spring-boot-starter-3.0.8-20230525.115211-13.jar > at > org.eclipse.aether.connector.basic.ArtifactTransportListener.transferFailed(ArtifactTransportListener.java:44) > at > org.eclipse.aether.connector.basic.BasicRepositoryConnector$TaskRunner.run(BasicRepositoryConnector.java:417) > at > org.eclipse.aether.connector.basic.BasicRepositoryConnector.get(BasicRepositoryConnector.java:260) > at > org.eclipse.aether.internal.impl.DefaultArtifactResolver.performDownloads(DefaultArtifactResolver.java:536) > at > org.eclipse.aether.internal.impl.DefaultArtifactResolver.resolve(DefaultArtifactResolver.java:448) > ... 45 more > Caused by: java.nio.file.NoSuchFileException: > /var/folders/46/2wr2nf9x0nzd1220xfnp1nzrgn/T/metadata-validation-m28912614894186841938/org/springframework/boot/spring-boot-starter/3.0.8-SNAPSHOT/spring-boot-starter-3.0.8-20230525.115211-13.jar.4959477968260906889.tmp > -> > /var/folders/46/2wr2nf9x0nzd1220xfnp1nzrgn/T/metadata-validation-m28912614894186841938/org/springframework/boot/spring-boot-starter/3.0.8-SNAPSHOT/spring-boot-starter-3.0.8-20230525.115211-13.jar > at > java.base/sun.nio.fs.UnixException.translateToIOException(UnixException.java:92) > at > java.base/sun.nio.fs.UnixException.rethrowAsIOException(UnixException.java:106) > at java.base/sun.nio.fs.UnixCopyFile.move(UnixCopyFile.java:416) > at > java.base/sun.nio.fs.UnixFileSystemProvider.move(UnixFileSystemProvider.java:266) > at java.base/java.nio.file.Files.move(Files.java:1432) > at org.eclipse.aether.util.FileUtils$2.move(FileUtils.java:108) > at > org.eclipse.aether.connector.basic.BasicRepositoryConnector$GetTaskRunner.runTask(BasicRepositoryConnector.java:500) > at > org.eclipse.aether.connector.basic.BasicRepositoryConnector$TaskRunner.run(BasicRepositoryConnector.java:414) > {noformat} > The test is here > https://github.com/spring-io/start.spring.io/tree/main/start-site-verification/src/test/java/io/spring/start/site -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MRESOLVER-362) NoSuchFileException moving .tmp to .jar
[ https://issues.apache.org/jira/browse/MRESOLVER-362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17726194#comment-17726194 ] Michael Osipov commented on MRESOLVER-362: -- [~cstamas] > NoSuchFileException moving .tmp to .jar > --- > > Key: MRESOLVER-362 > URL: https://issues.apache.org/jira/browse/MRESOLVER-362 > Project: Maven Resolver > Issue Type: Bug >Affects Versions: 1.9.10 >Reporter: Stephane Nicoll >Priority: Major > > It looks like MRESOLVER-290 broke our metadata verification tests. We have a > test that uses the resolver API to collect a bunch of dependencies, and > checking the state is correct. Since the upgrade to 1.9 we get this > {noformat} > Caused by: org.eclipse.aether.transfer.ArtifactTransferException: Could not > transfer artifact > org.springframework.boot:spring-boot-starter:jar:3.0.8-20230525.115211-13 > from/to spring-snapshots (https://repo.spring.io/snapshot): > /var/folders/46/2wr2nf9x0nzd1220xfnp1nzrgn/T/metadata-validation-m28912614894186841938/org/springframework/boot/spring-boot-starter/3.0.8-SNAPSHOT/spring-boot-starter-3.0.8-20230525.115211-13.jar.4959477968260906889.tmp > -> > /var/folders/46/2wr2nf9x0nzd1220xfnp1nzrgn/T/metadata-validation-m28912614894186841938/org/springframework/boot/spring-boot-starter/3.0.8-SNAPSHOT/spring-boot-starter-3.0.8-20230525.115211-13.jar > at > org.eclipse.aether.connector.basic.ArtifactTransportListener.transferFailed(ArtifactTransportListener.java:44) > at > org.eclipse.aether.connector.basic.BasicRepositoryConnector$TaskRunner.run(BasicRepositoryConnector.java:417) > at > org.eclipse.aether.connector.basic.BasicRepositoryConnector.get(BasicRepositoryConnector.java:260) > at > org.eclipse.aether.internal.impl.DefaultArtifactResolver.performDownloads(DefaultArtifactResolver.java:536) > at > org.eclipse.aether.internal.impl.DefaultArtifactResolver.resolve(DefaultArtifactResolver.java:448) > ... 45 more > Caused by: java.nio.file.NoSuchFileException: > /var/folders/46/2wr2nf9x0nzd1220xfnp1nzrgn/T/metadata-validation-m28912614894186841938/org/springframework/boot/spring-boot-starter/3.0.8-SNAPSHOT/spring-boot-starter-3.0.8-20230525.115211-13.jar.4959477968260906889.tmp > -> > /var/folders/46/2wr2nf9x0nzd1220xfnp1nzrgn/T/metadata-validation-m28912614894186841938/org/springframework/boot/spring-boot-starter/3.0.8-SNAPSHOT/spring-boot-starter-3.0.8-20230525.115211-13.jar > at > java.base/sun.nio.fs.UnixException.translateToIOException(UnixException.java:92) > at > java.base/sun.nio.fs.UnixException.rethrowAsIOException(UnixException.java:106) > at java.base/sun.nio.fs.UnixCopyFile.move(UnixCopyFile.java:416) > at > java.base/sun.nio.fs.UnixFileSystemProvider.move(UnixFileSystemProvider.java:266) > at java.base/java.nio.file.Files.move(Files.java:1432) > at org.eclipse.aether.util.FileUtils$2.move(FileUtils.java:108) > at > org.eclipse.aether.connector.basic.BasicRepositoryConnector$GetTaskRunner.runTask(BasicRepositoryConnector.java:500) > at > org.eclipse.aether.connector.basic.BasicRepositoryConnector$TaskRunner.run(BasicRepositoryConnector.java:414) > {noformat} > The test is here > https://github.com/spring-io/start.spring.io/tree/main/start-site-verification/src/test/java/io/spring/start/site -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (MRESOLVER-362) NoSuchFileException moving .tmp to .jar
Stephane Nicoll created MRESOLVER-362: - Summary: NoSuchFileException moving .tmp to .jar Key: MRESOLVER-362 URL: https://issues.apache.org/jira/browse/MRESOLVER-362 Project: Maven Resolver Issue Type: Bug Affects Versions: 1.9.10 Reporter: Stephane Nicoll It looks like MRESOLVER-290 broke our metadata verification tests. We have a test that uses the resolver API to collect a bunch of dependencies, and checking the state is correct. Since the upgrade to 1.9 we get this {noformat} Caused by: org.eclipse.aether.transfer.ArtifactTransferException: Could not transfer artifact org.springframework.boot:spring-boot-starter:jar:3.0.8-20230525.115211-13 from/to spring-snapshots (https://repo.spring.io/snapshot): /var/folders/46/2wr2nf9x0nzd1220xfnp1nzrgn/T/metadata-validation-m28912614894186841938/org/springframework/boot/spring-boot-starter/3.0.8-SNAPSHOT/spring-boot-starter-3.0.8-20230525.115211-13.jar.4959477968260906889.tmp -> /var/folders/46/2wr2nf9x0nzd1220xfnp1nzrgn/T/metadata-validation-m28912614894186841938/org/springframework/boot/spring-boot-starter/3.0.8-SNAPSHOT/spring-boot-starter-3.0.8-20230525.115211-13.jar at org.eclipse.aether.connector.basic.ArtifactTransportListener.transferFailed(ArtifactTransportListener.java:44) at org.eclipse.aether.connector.basic.BasicRepositoryConnector$TaskRunner.run(BasicRepositoryConnector.java:417) at org.eclipse.aether.connector.basic.BasicRepositoryConnector.get(BasicRepositoryConnector.java:260) at org.eclipse.aether.internal.impl.DefaultArtifactResolver.performDownloads(DefaultArtifactResolver.java:536) at org.eclipse.aether.internal.impl.DefaultArtifactResolver.resolve(DefaultArtifactResolver.java:448) ... 45 more Caused by: java.nio.file.NoSuchFileException: /var/folders/46/2wr2nf9x0nzd1220xfnp1nzrgn/T/metadata-validation-m28912614894186841938/org/springframework/boot/spring-boot-starter/3.0.8-SNAPSHOT/spring-boot-starter-3.0.8-20230525.115211-13.jar.4959477968260906889.tmp -> /var/folders/46/2wr2nf9x0nzd1220xfnp1nzrgn/T/metadata-validation-m28912614894186841938/org/springframework/boot/spring-boot-starter/3.0.8-SNAPSHOT/spring-boot-starter-3.0.8-20230525.115211-13.jar at java.base/sun.nio.fs.UnixException.translateToIOException(UnixException.java:92) at java.base/sun.nio.fs.UnixException.rethrowAsIOException(UnixException.java:106) at java.base/sun.nio.fs.UnixCopyFile.move(UnixCopyFile.java:416) at java.base/sun.nio.fs.UnixFileSystemProvider.move(UnixFileSystemProvider.java:266) at java.base/java.nio.file.Files.move(Files.java:1432) at org.eclipse.aether.util.FileUtils$2.move(FileUtils.java:108) at org.eclipse.aether.connector.basic.BasicRepositoryConnector$GetTaskRunner.runTask(BasicRepositoryConnector.java:500) at org.eclipse.aether.connector.basic.BasicRepositoryConnector$TaskRunner.run(BasicRepositoryConnector.java:414) {noformat} The test is here https://github.com/spring-io/start.spring.io/tree/main/start-site-verification/src/test/java/io/spring/start/site -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Closed] (MCHECKSTYLE-438) Update and backfill release notes
[ https://issues.apache.org/jira/browse/MCHECKSTYLE-438?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov closed MCHECKSTYLE-438. -- Resolution: Fixed Fixed with [2b0fc93dce6da9685ab37a1b03b53409468075f3|https://gitbox.apache.org/repos/asf?p=maven-checkstyle-plugin.git=commit=2b0fc93dce6da9685ab37a1b03b53409468075f3]. > Update and backfill release notes > - > > Key: MCHECKSTYLE-438 > URL: https://issues.apache.org/jira/browse/MCHECKSTYLE-438 > Project: Maven Checkstyle Plugin > Issue Type: Task >Reporter: Zhenlei Huang >Assignee: Michael Osipov >Priority: Trivial > Fix For: 3.3.1 > > > http://maven.apache.org/plugins/maven-checkstyle-plugin/history.html is > missing some release history. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [maven-checkstyle-plugin] asfgit merged pull request #122: [MCHECKSTYLE-438] Update and backfill release notes
asfgit merged PR #122: URL: https://github.com/apache/maven-checkstyle-plugin/pull/122 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Assigned] (MCHECKSTYLE-438) Update and backfill release notes
[ https://issues.apache.org/jira/browse/MCHECKSTYLE-438?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov reassigned MCHECKSTYLE-438: -- Assignee: Michael Osipov > Update and backfill release notes > - > > Key: MCHECKSTYLE-438 > URL: https://issues.apache.org/jira/browse/MCHECKSTYLE-438 > Project: Maven Checkstyle Plugin > Issue Type: Task >Reporter: Zhenlei Huang >Assignee: Michael Osipov >Priority: Trivial > > http://maven.apache.org/plugins/maven-checkstyle-plugin/history.html is > missing some release history. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (MCHECKSTYLE-438) Update and backfill release notes
[ https://issues.apache.org/jira/browse/MCHECKSTYLE-438?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov updated MCHECKSTYLE-438: --- Fix Version/s: 3.3.1 > Update and backfill release notes > - > > Key: MCHECKSTYLE-438 > URL: https://issues.apache.org/jira/browse/MCHECKSTYLE-438 > Project: Maven Checkstyle Plugin > Issue Type: Task >Reporter: Zhenlei Huang >Assignee: Michael Osipov >Priority: Trivial > Fix For: 3.3.1 > > > http://maven.apache.org/plugins/maven-checkstyle-plugin/history.html is > missing some release history. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MCHECKSTYLE-438) Update and backfill release notes
[ https://issues.apache.org/jira/browse/MCHECKSTYLE-438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17726145#comment-17726145 ] Zhenlei Huang commented on MCHECKSTYLE-438: --- [~michael-o] See https://github.com/apache/maven-checkstyle-plugin/pull/122 > Update and backfill release notes > - > > Key: MCHECKSTYLE-438 > URL: https://issues.apache.org/jira/browse/MCHECKSTYLE-438 > Project: Maven Checkstyle Plugin > Issue Type: Task >Reporter: Zhenlei Huang >Priority: Trivial > > http://maven.apache.org/plugins/maven-checkstyle-plugin/history.html is > missing some release history. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [maven] adangel opened a new pull request, #1128: [MNG-7795] IllegalArgumentException: 'other' has different root durin…
adangel opened a new pull request, #1128: URL: https://github.com/apache/maven/pull/1128 …ing plugin validation Checks the paths before relativizing them. https://issues.apache.org/jira/browse/MNG-7795 Following this checklist to help us incorporate your contribution quickly and easily: - [x] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/MNG) filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes. - [x] Each commit in the pull request should have a meaningful subject line and body. - [x] Format the pull request title like `[MNG-XXX] SUMMARY`, where you replace `MNG-XXX` and `SUMMARY` with the appropriate JIRA issue. - [x] Also format the first line of the commit message like `[MNG-XXX] SUMMARY`. Best practice is to use the JIRA issue title in both the pull request title and in the first line of the commit message. - [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [ ] Run `mvn clean verify` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically. - [ ] You have run the [Core IT][core-its] successfully. If your pull request is about ~20 lines of code you don't need to sign an [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure please ask on the developers list. To make clear that you license your contribution under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) you have to acknowledge this by using the following check-box. - [ ] I hereby declare this contribution to be licenced under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) - [x] In any other case, please file an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). [core-its]: https://maven.apache.org/core-its/core-it-suite/ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (MNG-7795) IllegalArgumentException: 'other' has different root during plugin validation
Andreas Dangel created MNG-7795: --- Summary: IllegalArgumentException: 'other' has different root during plugin validation Key: MNG-7795 URL: https://issues.apache.org/jira/browse/MNG-7795 Project: Maven Issue Type: Bug Components: Core Affects Versions: 3.9.2 Reporter: Andreas Dangel Assignee: Andreas Dangel Fix For: 3.9.3 This bug happens under Windows only and is the reason, why one IT (MPMD-323-ruleset-basedir-jgitver) is failing for m-pmd-p with the following exception: {code:java} java.lang.IllegalArgumentException: 'other' has different root at sun.nio.fs.WindowsPath.relativize (WindowsPath.java:404) at sun.nio.fs.WindowsPath.relativize (WindowsPath.java:42) at org.apache.maven.plugin.internal.DefaultPluginValidationManager.pluginOccurrence (DefaultPluginValidationManager.java:224) at org.apache.maven.plugin.internal.DefaultPluginValidationManager.reportPluginValidationIssue (DefaultPluginValidationManager.java:111) at org.apache.maven.plugin.internal.PlexusContainerDefaultDependenciesValidator.doValidate (PlexusContainerDefaultDependenciesValidator.java:49) at org.apache.maven.plugin.internal.AbstractMavenPluginDependenciesValidator.validate (AbstractMavenPluginDependenciesValidator.java:50) at org.apache.maven.plugin.internal.DefaultMavenPluginManager.getConfiguredMojo (DefaultMavenPluginManager.java:560) at org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo (DefaultBuildPluginManager.java:114) at org.apache.maven.lifecycle.internal.MojoExecutor.doExecute2 (MojoExecutor.java:342) at org.apache.maven.lifecycle.internal.MojoExecutor.doExecute (MojoExecutor.java:330) at org.apache.maven.lifecycle.internal.MojoExecutor.execute (MojoExecutor.java:213) at org.apache.maven.lifecycle.internal.MojoExecutor.execute (MojoExecutor.java:175) at org.apache.maven.lifecycle.internal.MojoExecutor.access$000 (MojoExecutor.java:76) at org.apache.maven.lifecycle.internal.MojoExecutor$1.run (MojoExecutor.java:163) at org.apache.maven.plugin.DefaultMojosExecutionStrategy.execute (DefaultMojosExecutionStrategy.java:39) at org.apache.maven.lifecycle.internal.MojoExecutor.execute (MojoExecutor.java:160) at org.apache.maven.lifecycle.internal.MojoExecutor.executeForkedExecutions (MojoExecutor.java:462) at org.apache.maven.lifecycle.internal.MojoExecutor.doExecute (MojoExecutor.java:325) at org.apache.maven.lifecycle.internal.MojoExecutor.execute (MojoExecutor.java:213) at org.apache.maven.lifecycle.internal.MojoExecutor.execute (MojoExecutor.java:175) at org.apache.maven.lifecycle.internal.MojoExecutor.access$000 (MojoExecutor.java:76) at org.apache.maven.lifecycle.internal.MojoExecutor$1.run (MojoExecutor.java:163) at org.apache.maven.plugin.DefaultMojosExecutionStrategy.execute (DefaultMojosExecutionStrategy.java:39) at org.apache.maven.lifecycle.internal.MojoExecutor.execute (MojoExecutor.java:160) at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject (LifecycleModuleBuilder.java:105) at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject (LifecycleModuleBuilder.java:73) at org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.build (SingleThreadedBuilder.java:53) at org.apache.maven.lifecycle.internal.LifecycleStarter.execute (LifecycleStarter.java:118) at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:261) at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:173) at org.apache.maven.DefaultMaven.execute (DefaultMaven.java:101) at org.apache.maven.cli.MavenCli.execute (MavenCli.java:910) at org.apache.maven.cli.MavenCli.doMain (MavenCli.java:283) at org.apache.maven.cli.MavenCli.main (MavenCli.java:206) at jdk.internal.reflect.NativeMethodAccessorImpl.invoke0 (Native Method) at jdk.internal.reflect.NativeMethodAccessorImpl.invoke (NativeMethodAccessorImpl.java:62) at jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke (DelegatingMethodAccessorImpl.java:43) at java.lang.reflect.Method.invoke (Method.java:566) at org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced (Launcher.java:283) at org.codehaus.plexus.classworlds.launcher.Launcher.launch (Launcher.java:226) at org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode (Launcher.java:407) at org.codehaus.plexus.classworlds.launcher.Launcher.main (Launcher.java:348) {code} E.g. see GitHub Actions: [https://github.com/apache/maven-pmd-plugin/actions/runs/5024694265] (unfortunately without a stack trace) This IT uses the extension [jgitver-maven-plugin|https://github.com/jgitver/jgitver-maven-plugin], which creates a temporary pom file for the current project with the new
[jira] [Updated] (MNG-7794) Deprecate org.apache.maven.repository.RepositorySystem
[ https://issues.apache.org/jira/browse/MNG-7794?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tamas Cservenak updated MNG-7794: - Description: This component is implemented in maven-compat, uses own classes to access local repo and WagonManager for remote access, hence is Maven2 component. (was: This component is implemented in maven-compat, hence is Maven2 component.) > Deprecate org.apache.maven.repository.RepositorySystem > -- > > Key: MNG-7794 > URL: https://issues.apache.org/jira/browse/MNG-7794 > Project: Maven > Issue Type: Task >Reporter: Tamas Cservenak >Priority: Major > > This component is implemented in maven-compat, uses own classes to access > local repo and WagonManager for remote access, hence is Maven2 component. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (MNG-7794) Deprecate org.apache.maven.repository.RepositorySystem
Tamas Cservenak created MNG-7794: Summary: Deprecate org.apache.maven.repository.RepositorySystem Key: MNG-7794 URL: https://issues.apache.org/jira/browse/MNG-7794 Project: Maven Issue Type: Task Reporter: Tamas Cservenak This component is implemented in maven-compat, hence is Maven2 component. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [maven-surefire] michael-o opened a new pull request, #645: Simplify serialization/deserialization of elapsed time
michael-o opened a new pull request, #645: URL: https://github.com/apache/maven-surefire/pull/645 Following this checklist to help us incorporate your contribution quickly and easily: - [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/SUREFIRE) filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes. - [ ] Each commit in the pull request should have a meaningful subject line and body. - [ ] Format the pull request title like `[SUREFIRE-XXX] - Fixes bug in ApproximateQuantiles`, where you replace `SUREFIRE-XXX` with the appropriate JIRA issue. Best practice is to use the JIRA issue title in the pull request title and in the first line of the commit message. - [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [ ] Run `mvn clean install` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically. - [ ] You have run the integration tests successfully (`mvn -Prun-its clean install`). If your pull request is about ~20 lines of code you don't need to sign an [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure please ask on the developers list. To make clear that you license your contribution under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) you have to acknowledge this by using the following check-box. - [ ] I hereby declare this contribution to be licenced under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) - [ ] In any other case, please file an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-surefire] michael-o closed pull request #637: [SUREFIRE-2164] Simplify serialization of elapsed time in StatelessXmlReporter
michael-o closed pull request #637: [SUREFIRE-2164] Simplify serialization of elapsed time in StatelessXmlReporter URL: https://github.com/apache/maven-surefire/pull/637 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (SUREFIRE-2166) Use ChoiceFormat to selectively render percentage and elapsed time in SurefireReportRenderer
[ https://issues.apache.org/jira/browse/SUREFIRE-2166?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov updated SUREFIRE-2166: - Summary: Use ChoiceFormat to selectively render percentage and elapsed time in SurefireReportRenderer (was: Use ChoiceFormat to selective render percentage and elapsed time in SurefireReportRenderer) > Use ChoiceFormat to selectively render percentage and elapsed time in > SurefireReportRenderer > > > Key: SUREFIRE-2166 > URL: https://issues.apache.org/jira/browse/SUREFIRE-2166 > Project: Maven Surefire > Issue Type: Improvement > Components: Maven Surefire Report Plugin >Affects Versions: 3.1.0 >Reporter: Michael Osipov >Assignee: Michael Osipov >Priority: Major > Fix For: 3.1.1 > > Attachments: log-output.txt > > > The changes applied in SUREFIRE-2153 were in complete in terms of output > formatting. It was done halfheartedly. This ticket aims to improve this: > * Get rid of {{NumberFormat}} and use choice format with the resource bundles > where the former will do all necessary magic for us > * Selective scale the percentage to one decimal position if the value is > neither 0 nor 100, both will display as integer value only > * Scale the elapsed time of a test set to exactly four digits including > fractional values which improves the harmony of readability (see attachment) > and with a increasing decimal position (times 10) one decimal (fractional) > position is displayed less, e.g., no one cares about microseconds if your > test runs hundreds of seconds. > Note: Though the attached file refers to log output, the formatting is > consistent with the report and aims to unify both renderings. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (SUREFIRE-2170) Use ChoiceFormat to selectively render elapsed time in WrappedReportEntry
[ https://issues.apache.org/jira/browse/SUREFIRE-2170?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov updated SUREFIRE-2170: - Summary: Use ChoiceFormat to selectively render elapsed time in WrappedReportEntry (was: Use ChoiceFormat to selective render elapsed time in WrappedReportEntry) > Use ChoiceFormat to selectively render elapsed time in WrappedReportEntry > - > > Key: SUREFIRE-2170 > URL: https://issues.apache.org/jira/browse/SUREFIRE-2170 > Project: Maven Surefire > Issue Type: Improvement >Affects Versions: 3.1.0 >Reporter: Michael Osipov >Assignee: Michael Osipov >Priority: Major > Fix For: 3.1.1 > > > In consistence with SUREFIRE-2166 this issue shall apply the same rendering > to the console report output. For details see aforementioned ticket. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [maven-surefire] michael-o opened a new pull request, #644: update deps
michael-o opened a new pull request, #644: URL: https://github.com/apache/maven-surefire/pull/644 Following this checklist to help us incorporate your contribution quickly and easily: - [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/SUREFIRE) filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes. - [ ] Each commit in the pull request should have a meaningful subject line and body. - [ ] Format the pull request title like `[SUREFIRE-XXX] - Fixes bug in ApproximateQuantiles`, where you replace `SUREFIRE-XXX` with the appropriate JIRA issue. Best practice is to use the JIRA issue title in the pull request title and in the first line of the commit message. - [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [ ] Run `mvn clean install` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically. - [ ] You have run the integration tests successfully (`mvn -Prun-its clean install`). If your pull request is about ~20 lines of code you don't need to sign an [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure please ask on the developers list. To make clear that you license your contribution under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) you have to acknowledge this by using the following check-box. - [ ] I hereby declare this contribution to be licenced under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) - [ ] In any other case, please file an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MNG-7792) Use a single standalone version of asm
[ https://issues.apache.org/jira/browse/MNG-7792?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17726082#comment-17726082 ] Michael Osipov commented on MNG-7792: - Can we then make sure that it is still consistent? > Use a single standalone version of asm > -- > > Key: MNG-7792 > URL: https://issues.apache.org/jira/browse/MNG-7792 > Project: Maven > Issue Type: Improvement >Reporter: Guillaume Nodet >Priority: Major > Fix For: 4.0.x-candidate > > > Guice and sisu.inject both embeds asm. It would be better to use an external > version so that it can be update independently. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MNG-7793) Add APIs for generated sources
[ https://issues.apache.org/jira/browse/MNG-7793?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17726081#comment-17726081 ] Michael Osipov commented on MNG-7793: - [~gnodet] > Add APIs for generated sources > -- > > Key: MNG-7793 > URL: https://issues.apache.org/jira/browse/MNG-7793 > Project: Maven > Issue Type: New Feature > Components: Core >Reporter: Zhenlei Huang >Priority: Minor > > Some source code analysis plugins such as [Maven Checkstyle > Plugin|https://maven.apache.org/plugins/maven-checkstyle-plugin/] and [Apache > Maven PMD > Plugin|https://maven.apache.org/plugins/maven-pmd-plugin/index.html] might > want to exclude generated sources / test sources. Commonly the generators > have their own styles and make the generated sources as robust as possible so > users might not want to re-check them. > Typically the generated source directory is under > `${project.build.directory}/generated-sources` but it seems that is not > enforced. It can be valuable to have `generatedCompileSourceRoots` and > `generatedTestCompileSourceRoots` in maven-core and to be consumed by various > plugins. > [1] https://issues.apache.org/jira/browse/MCHECKSTYLE-412 > [2] https://maven.apache.org/plugins/maven-pmd-plugin/usage.html -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MCHECKSTYLE-438) Update and backfill release notes
[ https://issues.apache.org/jira/browse/MCHECKSTYLE-438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17726080#comment-17726080 ] Michael Osipov commented on MCHECKSTYLE-438: Feel free to raise a PR. > Update and backfill release notes > - > > Key: MCHECKSTYLE-438 > URL: https://issues.apache.org/jira/browse/MCHECKSTYLE-438 > Project: Maven Checkstyle Plugin > Issue Type: Task >Reporter: Zhenlei Huang >Priority: Trivial > > http://maven.apache.org/plugins/maven-checkstyle-plugin/history.html is > missing some release history. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (SUREFIRE-2170) Use ChoiceFormat to selective render elapsed time in WrappedReportEntry
Michael Osipov created SUREFIRE-2170: Summary: Use ChoiceFormat to selective render elapsed time in WrappedReportEntry Key: SUREFIRE-2170 URL: https://issues.apache.org/jira/browse/SUREFIRE-2170 Project: Maven Surefire Issue Type: Improvement Affects Versions: 3.1.0 Reporter: Michael Osipov Assignee: Michael Osipov Fix For: 3.1.1 In consistence with SUREFIRE-2166 this issue shall apply the same rendering to the console report output. For details see aforementioned ticket. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [maven-jarsigner] dependabot[bot] closed pull request #1: Bump maven-shared-utils from 3.2.1 to 3.3.3
dependabot[bot] closed pull request #1: Bump maven-shared-utils from 3.2.1 to 3.3.3 URL: https://github.com/apache/maven-jarsigner/pull/1 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-jarsigner] dependabot[bot] commented on pull request #1: Bump maven-shared-utils from 3.2.1 to 3.3.3
dependabot[bot] commented on PR #1: URL: https://github.com/apache/maven-jarsigner/pull/1#issuecomment-1562354963 Looks like org.apache.maven.shared:maven-shared-utils is no longer updatable, so this is no longer needed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-jarsigner] dependabot[bot] commented on pull request #1: Bump maven-shared-utils from 3.2.1 to 3.3.3
dependabot[bot] commented on PR #1: URL: https://github.com/apache/maven-jarsigner/pull/1#issuecomment-1562354412 Looks like this PR is closed. If you re-open it I'll rebase it as long as no-one else has edited it (you can use `@dependabot reopen` if the branch has been deleted). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-jarsigner] slachiewicz commented on pull request #2: [MJARSIGNER-65][MJARSIGNER-66][MJARSIGNER-67] Update parent POM to 39, Java minimum to 1.8, maven minimum to 3.2.5
slachiewicz commented on PR #2: URL: https://github.com/apache/maven-jarsigner/pull/2#issuecomment-1562353752 i'll leave this to @elharo maybe he wants to pickup something more from his branch -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org