[GitHub] [maven] talios commented on pull request #1190: PoC/experiment: new scope "import-plugins"
talios commented on PR #1190: URL: https://github.com/apache/maven/pull/1190#issuecomment-1612363169 > @talios @hboutemy also, what is the problem with adding new scope (that is special,in very same way as existing "import" scope is special)? No real problem - more questioning the naming (which may be too early in the change to quibble over naming), tho reading the reasoning of 'plugins don't have scope' that means this is possibly more a trade-off due to current limitations of the POM format. @rmannibucau's comment: > Think extensions are a nice way to configure plugins makes me think back to the current tiles implementation which operates as an extension, hooking into the model builder - but with the immutable model in M4 doesn't work - an new extension point for model manipulation would be nice. One nice thing with tiles, by pulling as parents - we also pull in any ` defined, which can also then be overridden/customised. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MNG-7820) Remove dependency on plexus-utils
[ https://issues.apache.org/jira/browse/MNG-7820?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17738346#comment-17738346 ] Zhongming Hua commented on MNG-7820: I will wait for this PR to be merged and then complete the issue based on it. > Remove dependency on plexus-utils > - > > Key: MNG-7820 > URL: https://issues.apache.org/jira/browse/MNG-7820 > Project: Maven > Issue Type: Task >Reporter: Guillaume Nodet >Priority: Major > Fix For: 4.0.0-alpha-8 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [maven] talios commented on pull request #1190: PoC/experiment: new scope "import-plugins"
talios commented on PR #1190: URL: https://github.com/apache/maven/pull/1190#issuecomment-1612359245 > And an idea from comment on [MNG-5588](https://issues.apache.org/jira/browse/MNG-5588): IF you are importing a POM, why not import everything? (And then need for new scope really goes away). Users can prepare POMs with parts they want (depMgt only, pluginMgt only, or both) and import. That's essentially what tiles-maven-plugin does - only it does it by synthetically injected the tile-pom as a parent (and has its own transitive tiles, which I don't like - but users do). Because it's pulling in everything - you get the plugin definition _and_ the executions, so you don't need to repeat all the plugins in the child pom (but that I could probably accept). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MNG-7829) CLI properties passed with -D are not accessible with session.getSystemProperties()
[
https://issues.apache.org/jira/browse/MNG-7829?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17738317#comment-17738317
]
Guillaume Nodet commented on MNG-7829:
--
Can the extension access user properties in another way ?
What about the {{SimpleLoggerConfiguration}} which retrieves all logger levels
from system properties ?
I'm not really sure not setting user properties as system properties is
correct, I suspect it may break a bunch of things.
> CLI properties passed with -D are not accessible with
> session.getSystemProperties()
> ---
>
> Key: MNG-7829
> URL: https://issues.apache.org/jira/browse/MNG-7829
> Project: Maven
> Issue Type: Bug
> Components: Command Line
>Affects Versions: 4.0.0-alpha-7
>Reporter: Jerome Prinet
>Priority: Minor
>
> h3. Context
> * Maven _4.0.0-alpha-6_ and above
> * A Maven extension collecting CLI arguments passed with _-D_
> h3. Issue
> In a Maven extension, I am collecting CLI arguments which allow to skip tests
> if present ({_}skipTests, skipITs, maven.test.skip{_}).
> The problem is that since Maven {_}4.0.0-alpha06{_}, these informations are
> not part of the
> [session.systemProperties|https://maven.apache.org/ref/3.9.3/maven-core/apidocs/org/apache/maven/execution/MavenSession.html#getSystemProperties()]
> anymore.
> This is working fine until [this
> commit|https://github.com/apache/maven/commit/a1fa3eb5346f562a745f054650eee1e84c44db30?diff=unified]
> if not mistaken.
> The missing instruction being [this
> one|https://github.com/apache/maven/commit/a1fa3eb5346f562a745f054650eee1e84c44db30?diff=unified#diff-b8b814f5b6b3855ae79dc45a0266b94871193dcef42803c316e07409e94af35cL1546].
> *If I add this back on the latest version of master, I am able to collect the
> information.*
> h3. Alternative
> Those properties can be accessed via the
> [session.getUserProperties()|https://maven.apache.org/ref/3.9.3/maven-core/apidocs/org/apache/maven/execution/MavenSession.html#getUserProperties()]
> Please confirm if this is the expected way to collect the data.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[GitHub] [maven-site] gnodet merged pull request #432: 4.0.0-alpha-7 release notes
gnodet merged PR #432: URL: https://github.com/apache/maven-site/pull/432 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MENFORCER-487) Bump commons-io from 2.11.0 to 2.13.0
[ https://issues.apache.org/jira/browse/MENFORCER-487?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17738292#comment-17738292 ] ASF GitHub Bot commented on MENFORCER-487: -- slawekjaranowski opened a new pull request, #277: URL: https://github.com/apache/maven-enforcer/pull/277 Following this checklist to help us incorporate your contribution quickly and easily: - [x] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/MENFORCER) filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes. - [x] Each commit in the pull request should have a meaningful subject line and body. - [x] Format the pull request title like `[MENFORCER-XXX] - Fixes bug in ApproximateQuantiles`, where you replace `MENFORCER-XXX` with the appropriate JIRA issue. Best practice is to use the JIRA issue title in the pull request title and in the first line of the commit message. - [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [x] Run `mvn clean verify` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically. - [x] You have run the integration tests successfully (`mvn -Prun-its clean verify`). If your pull request is about ~20 lines of code you don't need to sign an [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure please ask on the developers list. To make clear that you license your contribution under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) you have to acknowledge this by using the following check-box. - [x] I hereby declare this contribution to be licenced under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) - [x] In any other case, please file an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). > Bump commons-io from 2.11.0 to 2.13.0 > - > > Key: MENFORCER-487 > URL: https://issues.apache.org/jira/browse/MENFORCER-487 > Project: Maven Enforcer Plugin > Issue Type: Dependency upgrade >Reporter: Slawomir Jaranowski >Assignee: Slawomir Jaranowski >Priority: Major > Fix For: 3.3.1 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [maven-enforcer] slawekjaranowski opened a new pull request, #277: [MENFORCER-487] Bump commons-codec from 1.15 to 1.16.0
slawekjaranowski opened a new pull request, #277: URL: https://github.com/apache/maven-enforcer/pull/277 Following this checklist to help us incorporate your contribution quickly and easily: - [x] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/MENFORCER) filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes. - [x] Each commit in the pull request should have a meaningful subject line and body. - [x] Format the pull request title like `[MENFORCER-XXX] - Fixes bug in ApproximateQuantiles`, where you replace `MENFORCER-XXX` with the appropriate JIRA issue. Best practice is to use the JIRA issue title in the pull request title and in the first line of the commit message. - [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [x] Run `mvn clean verify` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically. - [x] You have run the integration tests successfully (`mvn -Prun-its clean verify`). If your pull request is about ~20 lines of code you don't need to sign an [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure please ask on the developers list. To make clear that you license your contribution under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) you have to acknowledge this by using the following check-box. - [x] I hereby declare this contribution to be licenced under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) - [x] In any other case, please file an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Comment Edited] (MASSEMBLY-992) Facility to define assembly descriptor in body of POM
[
https://issues.apache.org/jira/browse/MASSEMBLY-992?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17738286#comment-17738286
]
Garret Wilson edited comment on MASSEMBLY-992 at 6/28/23 8:21 PM:
--
That use of {{maven-dependency-plugin}} is interesting; I'll have to read more
about it. Thanks for the pointer. That technique may prove useful one day.
Nevertheless it means that in my child POM I have to declare some other plugin
with its own comprehensive configuration. I don't have to do that with the
Maven Shade Plugin. I don't have to do that with the Spring Maven Plugin. I
don't have to do that with the Versions Maven Plugin. I don't have to do that
with the Launch4J plugin. I don't have to do that with the (insert the name of
virtually any other Maven plugin).
I just want to inherit everything automatically from the POM without additional
plugins and artifacts. Thus I am filing a ticket for this improvement, so that
the Maven Plugin Assembly, like 99.9% of other Maven plugins can be 100%
configured within the POM without the need for additional artifacts or
additional plugin configurations just to get the additional artifacts included
in the project.
was (Author: garretwilson):
That use of {{maven-dependency-plugin}} is interesting; I'll have to read more
about it. Thanks for the pointer. That technique may prove useful one day.
Nevertheless it means that in my child POM I have to declare some other plugin
with its own comprehensive configuration. I don't have to do that with the
Maven Shade Plugin. I don't have to do that with the Spring Maven Plugin. I
don't have to do that with the Versions Maven Plugin. I don't have to do that
with the Launch4J plugin. I don't have to do that with the (insert the name of
virtually any other Maven plugin).
I just want to inherit everything automatically from the POM without additional
plugins and artifacts. Maybe you don't want that. But I want that. It's not
available now. So I am filing a ticket for this improvement, so that the Maven
Plugin Assembly, like 99.9% of other Maven plugins can be 100% configured
within the POM without the need for additional artifacts or additional plugin
configurations just to get the additional artifacts included in the project.
> Facility to define assembly descriptor in body of POM
> -
>
> Key: MASSEMBLY-992
> URL: https://issues.apache.org/jira/browse/MASSEMBLY-992
> Project: Maven Assembly Plugin
> Issue Type: New Feature
>Reporter: Garret Wilson
>Priority: Major
> Fix For: waiting-for-feedback
>
>
> The Maven Assembly Plugin allows custom descriptors to be defined, but only
> in an external file. Please add the capability to define the descriptor in
> the body of the POM itself.
> Requiring a separate descriptor file makes it almost impossible to declare an
> assembly in a parent POM so that it can be inherited by child POMs. The
> documentation describe a way to [share
> descriptors|https://maven.apache.org/plugins/maven-assembly-plugin/examples/sharing-descriptors.html],
> but it is complex and doesn't obviously support Maven property interpolation.
> Without this facility, in order to easily inherit an assembly from a parent
> POM, I'm currently resorting to workaround involving AntRun to generate an
> assembly descriptor on the fly. See [this
> {{pom.xml}}|https://github.com/globalmentor/globalmentor-root/blob/main/pom.xml].
> It's pretty convoluted and tedious to get right. In addition, it has to be
> placed in a phase that is guaranteed to run before the execution of the Maven
> Assembly Plugin itself.
> {code:xml}
>
> org.apache.maven.plugins
> maven-antrun-plugin
>
>
>
> generate-bin-assembly-descriptor
> prepare-package
>
> run
>
>
> ${_isSkipGenerateExe}
>
> encoding="UTF-8">
>
>
>
>
>
>
>
> {code}
> This was requested and finally implemented for Versions Maven Plugin; see
> [#258|https://github.com/mojohaus/versions/issues/258] and
> [#684|https://github.com/mojohaus/versions/issues/684], along with [_Versions
> Maven Plugin rules that are
> inheritable_|https://stackoverflow.com/q/72416739] on Stack Overflow.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Comment Edited] (MASSEMBLY-992) Facility to define assembly descriptor in body of POM
[
https://issues.apache.org/jira/browse/MASSEMBLY-992?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17738286#comment-17738286
]
Garret Wilson edited comment on MASSEMBLY-992 at 6/28/23 8:16 PM:
--
That use of {{maven-dependency-plugin}} is interesting; I'll have to read more
about it. Thanks for the pointer. That technique may prove useful one day.
Nevertheless it means that in my child POM I have to declare some other plugin
with its own comprehensive configuration. I don't have to do that with the
Maven Shade Plugin. I don't have to do that with the Spring Maven Plugin. I
don't have to do that with the Versions Maven Plugin. I don't have to do that
with the Launch4J plugin. I don't have to do that with the (insert the name of
virtually any other Maven plugin).
I just want to inherit everything automatically from the POM without additional
plugins and artifacts. Maybe you don't want that. But I want that. It's not
available now. So I am filing a ticket for this improvement, so that the Maven
Plugin Assembly, like 99.9% of other Maven plugins can be 100% configured
within the POM without the need for additional artifacts or additional plugin
configurations just to get the additional artifacts included in the project.
was (Author: garretwilson):
That use of {{maven-dependency-plugin}} is interesting; I'll have to read more
about it. Thanks for the pointer. That technique may prove useful one day.
Nevertheless it means that in my child POM I have to declare some other plugin
with its own comprehensive configuration. I don't have to do that with the
Maven Shade Plugin. I don't have to do that with the Spring Maven Plugin. I
don't have to do that withe Versions Maven Plugin. I don't have to do that with
the Launch4J plugin. I don't have to do that with the (insert the name of
virtually any other Maven plugin).
I just want to inherit everything automatically from the POM without additional
plugins and artifacts. Maybe you don't want that. But I want that. It's not
available now. So I am filing a ticket for this improvement, so that the Maven
Plugin Assembly, like 99.9% of other Maven plugins can be 100% configured
within the POM without the need for additional artifacts or additional plugin
configurations just to get the additional artifacts included in the project.
> Facility to define assembly descriptor in body of POM
> -
>
> Key: MASSEMBLY-992
> URL: https://issues.apache.org/jira/browse/MASSEMBLY-992
> Project: Maven Assembly Plugin
> Issue Type: New Feature
>Reporter: Garret Wilson
>Priority: Major
> Fix For: waiting-for-feedback
>
>
> The Maven Assembly Plugin allows custom descriptors to be defined, but only
> in an external file. Please add the capability to define the descriptor in
> the body of the POM itself.
> Requiring a separate descriptor file makes it almost impossible to declare an
> assembly in a parent POM so that it can be inherited by child POMs. The
> documentation describe a way to [share
> descriptors|https://maven.apache.org/plugins/maven-assembly-plugin/examples/sharing-descriptors.html],
> but it is complex and doesn't obviously support Maven property interpolation.
> Without this facility, in order to easily inherit an assembly from a parent
> POM, I'm currently resorting to workaround involving AntRun to generate an
> assembly descriptor on the fly. See [this
> {{pom.xml}}|https://github.com/globalmentor/globalmentor-root/blob/main/pom.xml].
> It's pretty convoluted and tedious to get right. In addition, it has to be
> placed in a phase that is guaranteed to run before the execution of the Maven
> Assembly Plugin itself.
> {code:xml}
>
> org.apache.maven.plugins
> maven-antrun-plugin
>
>
>
> generate-bin-assembly-descriptor
> prepare-package
>
> run
>
>
> ${_isSkipGenerateExe}
>
> encoding="UTF-8">
>
>
>
>
>
>
>
> {code}
> This was requested and finally implemented for Versions Maven Plugin; see
> [#258|https://github.com/mojohaus/versions/issues/258] and
> [#684|https://github.com/mojohaus/versions/issues/684], along with [_Versions
> Maven Plugin rules that are
> inheritable_|https://stackoverflow.com/q/72416739] on Stack Overflow.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MASSEMBLY-992) Facility to define assembly descriptor in body of POM
[
https://issues.apache.org/jira/browse/MASSEMBLY-992?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17738286#comment-17738286
]
Garret Wilson commented on MASSEMBLY-992:
-
That use of {{maven-dependency-plugin}} is interesting; I'll have to read more
about it. Thanks for the pointer. That technique may prove useful one day.
Nevertheless it means that in my child POM I have to declare some other plugin
with its own comprehensive configuration. I don't have to do that with the
Maven Shade Plugin. I don't have to do that with the Spring Maven Plugin. I
don't have to do that withe Versions Maven Plugin. I don't have to do that with
the Launch4J plugin. I don't have to do that with the (insert the name of
virtually any other Maven plugin).
I just want to inherit everything automatically from the POM without additional
plugins and artifacts. Maybe you don't want that. But I want that. It's not
available now. So I am filing a ticket for this improvement, so that the Maven
Plugin Assembly, like 99.9% of other Maven plugins can be 100% configured
within the POM without the need for additional artifacts or additional plugin
configurations just to get the additional artifacts included in the project.
> Facility to define assembly descriptor in body of POM
> -
>
> Key: MASSEMBLY-992
> URL: https://issues.apache.org/jira/browse/MASSEMBLY-992
> Project: Maven Assembly Plugin
> Issue Type: New Feature
>Reporter: Garret Wilson
>Priority: Major
> Fix For: waiting-for-feedback
>
>
> The Maven Assembly Plugin allows custom descriptors to be defined, but only
> in an external file. Please add the capability to define the descriptor in
> the body of the POM itself.
> Requiring a separate descriptor file makes it almost impossible to declare an
> assembly in a parent POM so that it can be inherited by child POMs. The
> documentation describe a way to [share
> descriptors|https://maven.apache.org/plugins/maven-assembly-plugin/examples/sharing-descriptors.html],
> but it is complex and doesn't obviously support Maven property interpolation.
> Without this facility, in order to easily inherit an assembly from a parent
> POM, I'm currently resorting to workaround involving AntRun to generate an
> assembly descriptor on the fly. See [this
> {{pom.xml}}|https://github.com/globalmentor/globalmentor-root/blob/main/pom.xml].
> It's pretty convoluted and tedious to get right. In addition, it has to be
> placed in a phase that is guaranteed to run before the execution of the Maven
> Assembly Plugin itself.
> {code:xml}
>
> org.apache.maven.plugins
> maven-antrun-plugin
>
>
>
> generate-bin-assembly-descriptor
> prepare-package
>
> run
>
>
> ${_isSkipGenerateExe}
>
> encoding="UTF-8">
>
>
>
>
>
>
>
> {code}
> This was requested and finally implemented for Versions Maven Plugin; see
> [#258|https://github.com/mojohaus/versions/issues/258] and
> [#684|https://github.com/mojohaus/versions/issues/684], along with [_Versions
> Maven Plugin rules that are
> inheritable_|https://stackoverflow.com/q/72416739] on Stack Overflow.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Created] (MENFORCER-487) Bump commons-io from 2.11.0 to 2.13.0
Slawomir Jaranowski created MENFORCER-487: - Summary: Bump commons-io from 2.11.0 to 2.13.0 Key: MENFORCER-487 URL: https://issues.apache.org/jira/browse/MENFORCER-487 Project: Maven Enforcer Plugin Issue Type: Dependency upgrade Reporter: Slawomir Jaranowski Assignee: Slawomir Jaranowski Fix For: 3.3.1 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [maven-integration-testing] gnodet opened a new pull request, #274: [MNG-7830] Switch from plexus-xml to stax / woodstox
gnodet opened a new pull request, #274: URL: https://github.com/apache/maven-integration-testing/pull/274 - Fix ITs - Add debug info - Ignore warnings at the beginning of the build caused by https://github.com/actions/setup-java/pull/503/ - Fix parser using beginning of tag to report errors - Fix spotless -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MNG-7827) Fix org.apache.maven.plugin.logging.Log deprecation message and AbstractMojo#getLog fallback
[ https://issues.apache.org/jira/browse/MNG-7827?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17738274#comment-17738274 ] ASF GitHub Bot commented on MNG-7827: - rmannibucau commented on PR #1187: URL: https://github.com/apache/maven/pull/1187#issuecomment-1612018723 @gnodet good for me too, I wondered about this point too and if true we should delete SystemStreamLog and just fail instead probably. If useful it means we must forward the fallback to the actual expected logging system behind `Log` and now it is v4 mecanism thanks new `Log` API, this was the intent behind this PR but happy to just drop it too cause I share your reasoning. > Fix org.apache.maven.plugin.logging.Log deprecation message and > AbstractMojo#getLog fallback > > > Key: MNG-7827 > URL: https://issues.apache.org/jira/browse/MNG-7827 > Project: Maven > Issue Type: Improvement > Components: Plugin API >Affects Versions: 4.0.0-alpha-7 >Reporter: Romain Manni-Bucau >Priority: Major > > In maven 4 an official Log API was created and using SLF4J as primary logging > solution is not recommended nor the official way so javadoc and impl should > be aligned to reflcet that. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MNG-7830) Switch from plexus-xml to stax / woodstox
[ https://issues.apache.org/jira/browse/MNG-7830?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17738259#comment-17738259 ] ASF GitHub Bot commented on MNG-7830: - gnodet commented on PR #1185: URL: https://github.com/apache/maven/pull/1185#issuecomment-1611971802 I plan to provide additional support for xml namespaces, but I think a follow-up PR may be better. I'll stop on that one. > Switch from plexus-xml to stax / woodstox > - > > Key: MNG-7830 > URL: https://issues.apache.org/jira/browse/MNG-7830 > Project: Maven > Issue Type: Dependency upgrade >Reporter: Guillaume Nodet >Assignee: Guillaume Nodet >Priority: Major > Fix For: 4.0.0-alpha-8 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MNG-7827) Fix org.apache.maven.plugin.logging.Log deprecation message and AbstractMojo#getLog fallback
[ https://issues.apache.org/jira/browse/MNG-7827?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17738240#comment-17738240 ] ASF GitHub Bot commented on MNG-7827: - gnodet commented on PR #1187: URL: https://github.com/apache/maven/pull/1187#issuecomment-1611893550 > 2. Ensure the default is the actual maven logging system and not stdout/stderr directly for other cases if it is present I don't understand the actual use case. All mojos called by maven are [injected with a proper log](https://github.com/apache/maven/blob/e08c95a6735a82c7abc25e2dc67ea4773ed9d05d/maven-core/src/main/java/org/apache/maven/plugin/internal/DefaultMavenPluginManager.java#L557-L560) already. The `SystemStreamLog` is really a fallback. In which case would this new code actually be used ? > Fix org.apache.maven.plugin.logging.Log deprecation message and > AbstractMojo#getLog fallback > > > Key: MNG-7827 > URL: https://issues.apache.org/jira/browse/MNG-7827 > Project: Maven > Issue Type: Improvement > Components: Plugin API >Affects Versions: 4.0.0-alpha-7 >Reporter: Romain Manni-Bucau >Priority: Major > > In maven 4 an official Log API was created and using SLF4J as primary logging > solution is not recommended nor the official way so javadoc and impl should > be aligned to reflcet that. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Closed] (MENFORCER-486) Bump commons-codec from 1.15 to 1.16.0
[ https://issues.apache.org/jira/browse/MENFORCER-486?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Slawomir Jaranowski closed MENFORCER-486. - Resolution: Fixed > Bump commons-codec from 1.15 to 1.16.0 > -- > > Key: MENFORCER-486 > URL: https://issues.apache.org/jira/browse/MENFORCER-486 > Project: Maven Enforcer Plugin > Issue Type: Dependency upgrade >Reporter: Slawomir Jaranowski >Assignee: Slawomir Jaranowski >Priority: Major > Fix For: 3.3.1 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MENFORCER-486) Bump commons-codec from 1.15 to 1.16.0
[ https://issues.apache.org/jira/browse/MENFORCER-486?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17738229#comment-17738229 ] ASF GitHub Bot commented on MENFORCER-486: -- slawekjaranowski merged PR #276: URL: https://github.com/apache/maven-enforcer/pull/276 > Bump commons-codec from 1.15 to 1.16.0 > -- > > Key: MENFORCER-486 > URL: https://issues.apache.org/jira/browse/MENFORCER-486 > Project: Maven Enforcer Plugin > Issue Type: Dependency upgrade >Reporter: Slawomir Jaranowski >Assignee: Slawomir Jaranowski >Priority: Major > Fix For: 3.3.1 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [maven-enforcer] slawekjaranowski merged pull request #276: [MENFORCER-486] Bump commons-codec from 1.15 to 1.16.0
slawekjaranowski merged PR #276: URL: https://github.com/apache/maven-enforcer/pull/276 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MENFORCER-485) Upgrade Parent to 40
[ https://issues.apache.org/jira/browse/MENFORCER-485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17738220#comment-17738220 ] ASF GitHub Bot commented on MENFORCER-485: -- slawekjaranowski merged PR #275: URL: https://github.com/apache/maven-enforcer/pull/275 > Upgrade Parent to 40 > > > Key: MENFORCER-485 > URL: https://issues.apache.org/jira/browse/MENFORCER-485 > Project: Maven Enforcer Plugin > Issue Type: Dependency upgrade >Reporter: Slawomir Jaranowski >Assignee: Slawomir Jaranowski >Priority: Major > Fix For: 3.3.1 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Closed] (MENFORCER-485) Upgrade Parent to 40
[ https://issues.apache.org/jira/browse/MENFORCER-485?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Slawomir Jaranowski closed MENFORCER-485. - Resolution: Fixed > Upgrade Parent to 40 > > > Key: MENFORCER-485 > URL: https://issues.apache.org/jira/browse/MENFORCER-485 > Project: Maven Enforcer Plugin > Issue Type: Dependency upgrade >Reporter: Slawomir Jaranowski >Assignee: Slawomir Jaranowski >Priority: Major > Fix For: 3.3.1 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MNG-7830) Switch from plexus-xml to stax / woodstox
[ https://issues.apache.org/jira/browse/MNG-7830?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17738219#comment-17738219 ] ASF GitHub Bot commented on MNG-7830: - elharo commented on PR #1185: URL: https://github.com/apache/maven/pull/1185#issuecomment-1611802061 Might or might not be related: [INFO] Error: Errors: Error:DefaultMavenProjectBuilderTest.rereadPom_mng7063:334 � FileSystem C:\Users\RUNNER~1\AppData\Local\Temp\junit5723635972946138167\pom.xml: The process cannot access the file because it is being used by another process. Error:ProjectBuilderTest.testReadModifiedPoms(Path) � IO Failed to delete temp directory C:\Users\RUNNER~1\AppData\Local\Temp\junit3720659451607426598. The following paths could not be deleted (see suppressed exceptions for details): , child [INFO] Error: Tests run: 428, Failures: 0, Errors: 2, Skipped: 1 [INFO] > Switch from plexus-xml to stax / woodstox > - > > Key: MNG-7830 > URL: https://issues.apache.org/jira/browse/MNG-7830 > Project: Maven > Issue Type: Dependency upgrade >Reporter: Guillaume Nodet >Assignee: Guillaume Nodet >Priority: Major > Fix For: 4.0.0-alpha-8 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [maven] elharo commented on pull request #1185: [MNG-7830] Switch from plexus-xml to stax / woodstox
elharo commented on PR #1185: URL: https://github.com/apache/maven/pull/1185#issuecomment-1611802061 Might or might not be related: [INFO] Error: Errors: Error:DefaultMavenProjectBuilderTest.rereadPom_mng7063:334 � FileSystem C:\Users\RUNNER~1\AppData\Local\Temp\junit5723635972946138167\pom.xml: The process cannot access the file because it is being used by another process. Error:ProjectBuilderTest.testReadModifiedPoms(Path) � IO Failed to delete temp directory C:\Users\RUNNER~1\AppData\Local\Temp\junit3720659451607426598. The following paths could not be deleted (see suppressed exceptions for details): , child [INFO] Error: Tests run: 428, Failures: 0, Errors: 2, Skipped: 1 [INFO] -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MNG-7830) Switch from plexus-xml to stax / woodstox
[ https://issues.apache.org/jira/browse/MNG-7830?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17738218#comment-17738218 ] ASF GitHub Bot commented on MNG-7830: - elharo commented on PR #1185: URL: https://github.com/apache/maven/pull/1185#issuecomment-1611800708 I am sure there are ways to fix that. > Switch from plexus-xml to stax / woodstox > - > > Key: MNG-7830 > URL: https://issues.apache.org/jira/browse/MNG-7830 > Project: Maven > Issue Type: Dependency upgrade >Reporter: Guillaume Nodet >Assignee: Guillaume Nodet >Priority: Major > Fix For: 4.0.0-alpha-8 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [maven] elharo commented on pull request #1185: [MNG-7830] Switch from plexus-xml to stax / woodstox
elharo commented on PR #1185: URL: https://github.com/apache/maven/pull/1185#issuecomment-1611800708 I am sure there are ways to fix that. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (SUREFIRE-2179) additionalClasspathElements should support Maven coordinates
[
https://issues.apache.org/jira/browse/SUREFIRE-2179?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17738188#comment-17738188
]
ASF GitHub Bot commented on SUREFIRE-2179:
--
kwin commented on code in PR #667:
URL: https://github.com/apache/maven-surefire/pull/667#discussion_r1243772435
##
maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/AbstractSurefireMojo.java:
##
@@ -281,6 +285,21 @@ public abstract class AbstractSurefireMojo extends
AbstractMojo implements Suref
@Parameter(property = "maven.test.additionalClasspath")
private String[] additionalClasspathElements;
+/**
+ * Additional Maven dependencies to be used in the test execution
classpath.
+ * Each element supports the parametrization like documented in https://maven.apache.org/pom.html#dependencies;>POM Reference:
Dependencies.
+ *
+ * Those dependencies are automatically collected (i.e. have their full
dependency tree calculated) and then all underlying artifacts are resolved from
the repository (including their transitive dependencies).
+ * Afterwards the resolved artifacts are filtered to only contain {@code
compile} and {@code runtime} scoped ones and appended to the test execution
classpath
+ * (after the ones from {@link #additionalClasspathElements}).
+ *
+ * The dependency management from the project is not taken into account.
+ *
+ * @since 3.2
+ */
+@Parameter(property = "maven.test.additionalClasspathDependencies")
+private Dependency[] additionalClasspathDependencies;
Review Comment:
This is just to be more in line with existing parameters. But I can switch
to `List`. The `null` check is not necessary for either array nor Collection,
as plexus.inject will inject an empty array.It is only necessary for unit tests.
> additionalClasspathElements should support Maven coordinates
>
>
> Key: SUREFIRE-2179
> URL: https://issues.apache.org/jira/browse/SUREFIRE-2179
> Project: Maven Surefire
> Issue Type: Improvement
> Components: classloading
>Affects Versions: 3.1.2
>Reporter: Konrad Windszus
>Assignee: Konrad Windszus
>Priority: Major
>
> Currently the parameter {{additionalClasspathElements}}
> (https://maven.apache.org/surefire/maven-surefire-plugin/test-mojo.html#additionalclasspathelements)
> only supports file paths. That usually requires to add an additional step to
> first download the necessary artifact to a temporary folder with another
> Mojo. In addition {{additionalClasspathElements}} only support full paths to
> JARs but no wildcards which makes configuration very verbose.
> For these reasons there should be an additional parameter supporting Maven
> coordinates which are then resolved automatically (even transitively) and
> added to the test execution classpath.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[GitHub] [maven-surefire] kwin commented on a diff in pull request #667: [SUREFIRE-2179] Support adding additional Maven dependencies to the test classpath
kwin commented on code in PR #667:
URL: https://github.com/apache/maven-surefire/pull/667#discussion_r1243772435
##
maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/AbstractSurefireMojo.java:
##
@@ -281,6 +285,21 @@ public abstract class AbstractSurefireMojo extends
AbstractMojo implements Suref
@Parameter(property = "maven.test.additionalClasspath")
private String[] additionalClasspathElements;
+/**
+ * Additional Maven dependencies to be used in the test execution
classpath.
+ * Each element supports the parametrization like documented in https://maven.apache.org/pom.html#dependencies;>POM Reference:
Dependencies.
+ *
+ * Those dependencies are automatically collected (i.e. have their full
dependency tree calculated) and then all underlying artifacts are resolved from
the repository (including their transitive dependencies).
+ * Afterwards the resolved artifacts are filtered to only contain {@code
compile} and {@code runtime} scoped ones and appended to the test execution
classpath
+ * (after the ones from {@link #additionalClasspathElements}).
+ *
+ * The dependency management from the project is not taken into account.
+ *
+ * @since 3.2
+ */
+@Parameter(property = "maven.test.additionalClasspathDependencies")
+private Dependency[] additionalClasspathDependencies;
Review Comment:
This is just to be more in line with existing parameters. But I can switch
to `List`. The `null` check is not necessary for either array nor Collection,
as plexus.inject will inject an empty array.It is only necessary for unit tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Commented] (MNG-7828) Bump guava from 31.1-jre to 32.0.1-jre
[ https://issues.apache.org/jira/browse/MNG-7828?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17738187#comment-17738187 ] ASF GitHub Bot commented on MNG-7828: - bvolpato commented on PR #1191: URL: https://github.com/apache/maven/pull/1191#issuecomment-1611690589 R: @cstamas > Bump guava from 31.1-jre to 32.0.1-jre > -- > > Key: MNG-7828 > URL: https://issues.apache.org/jira/browse/MNG-7828 > Project: Maven > Issue Type: Dependency upgrade >Affects Versions: 3.9.x-candidate, 4.0.x-candidate >Reporter: Bruno Candido Volpato da Cunha >Priority: Major > > Currently used version is in the range of CVE-2023-2976, which was fixed in > 32.0.0. > > Please check [https://osv.dev/vulnerability/GHSA-7g45-4rm6-3mm3] for more > information. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MNG-7830) Switch from plexus-xml to stax / woodstox
[
https://issues.apache.org/jira/browse/MNG-7830?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17738177#comment-17738177
]
ASF GitHub Bot commented on MNG-7830:
-
gnodet commented on code in PR #1185:
URL: https://github.com/apache/maven/pull/1185#discussion_r1245404521
##
maven-model-builder/src/main/java/org/apache/maven/model/io/DefaultModelReader.java:
##
@@ -120,23 +120,29 @@ private Model read(Reader reader, Path pomFile,
Map options) throws I
} else {
return readModel(transformingParser, strict);
}
-} catch (XmlPullParserException e) {
-throw new ModelParseException(e.getMessage(), e.getLineNumber(),
e.getColumnNumber(), e);
+} catch (XMLStreamException e) {
+Location location = e.getLocation();
+throw new ModelParseException(
+e.getMessage(),
+location != null ? location.getLineNumber() : -1,
+location != null ? location.getColumnNumber() : -1,
+e);
} catch (IOException e) {
throw e;
} catch (Exception e) {
Review Comment:
The `IOException` can still occur during the call to
`transformer.transform(...)` and we don't want to wrap it in another
`IOException`...
> Switch from plexus-xml to stax / woodstox
> -
>
> Key: MNG-7830
> URL: https://issues.apache.org/jira/browse/MNG-7830
> Project: Maven
> Issue Type: Dependency upgrade
>Reporter: Guillaume Nodet
>Assignee: Guillaume Nodet
>Priority: Major
> Fix For: 4.0.0-alpha-8
>
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[GitHub] [maven] gnodet commented on a diff in pull request #1185: [MNG-7830] Switch from plexus-xml to stax / woodstox
gnodet commented on code in PR #1185:
URL: https://github.com/apache/maven/pull/1185#discussion_r1245404521
##
maven-model-builder/src/main/java/org/apache/maven/model/io/DefaultModelReader.java:
##
@@ -120,23 +120,29 @@ private Model read(Reader reader, Path pomFile,
Map options) throws I
} else {
return readModel(transformingParser, strict);
}
-} catch (XmlPullParserException e) {
-throw new ModelParseException(e.getMessage(), e.getLineNumber(),
e.getColumnNumber(), e);
+} catch (XMLStreamException e) {
+Location location = e.getLocation();
+throw new ModelParseException(
+e.getMessage(),
+location != null ? location.getLineNumber() : -1,
+location != null ? location.getColumnNumber() : -1,
+e);
} catch (IOException e) {
throw e;
} catch (Exception e) {
Review Comment:
The `IOException` can still occur during the call to
`transformer.transform(...)` and we don't want to wrap it in another
`IOException`...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Commented] (MNG-7830) Switch from plexus-xml to stax / woodstox
[ https://issues.apache.org/jira/browse/MNG-7830?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17738167#comment-17738167 ] ASF GitHub Bot commented on MNG-7830: - gnodet commented on PR #1185: URL: https://github.com/apache/maven/pull/1185#issuecomment-1611612736 > Depending on spaces in the prolog is a bug. Tests should be comparing XML to XML, not XML to strings. The latter is extremely brittle and can cause tests to break even in minor upgrades of a library. Alternately, we can canonicalize documents before comparing them. If you file issues on specific tests that do that, I can take a look. That's not really the problem. I could hack the tests. However, the result xml is the one uploaded on central, and that one is ugly (because of the missing line breaks). So I think this is important to keep. > Switch from plexus-xml to stax / woodstox > - > > Key: MNG-7830 > URL: https://issues.apache.org/jira/browse/MNG-7830 > Project: Maven > Issue Type: Dependency upgrade >Reporter: Guillaume Nodet >Assignee: Guillaume Nodet >Priority: Major > Fix For: 4.0.0-alpha-8 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [maven] gnodet commented on pull request #1185: [MNG-7830] Switch from plexus-xml to stax / woodstox
gnodet commented on PR #1185: URL: https://github.com/apache/maven/pull/1185#issuecomment-1611612736 > Depending on spaces in the prolog is a bug. Tests should be comparing XML to XML, not XML to strings. The latter is extremely brittle and can cause tests to break even in minor upgrades of a library. Alternately, we can canonicalize documents before comparing them. If you file issues on specific tests that do that, I can take a look. That's not really the problem. I could hack the tests. However, the result xml is the one uploaded on central, and that one is ugly (because of the missing line breaks). So I think this is important to keep. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MNG-7830) Switch from plexus-xml to stax / woodstox
[ https://issues.apache.org/jira/browse/MNG-7830?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17738159#comment-17738159 ] ASF GitHub Bot commented on MNG-7830: - elharo commented on PR #1185: URL: https://github.com/apache/maven/pull/1185#issuecomment-1611590027 Depending on spaces in the prolog is a bug. Tests should be comparing XML to XML, not XML to strings. The latter is extremely brittle and can cause tests to break even in minor upgrades of a library. Alternately, we can canonicalize documents before comparing them. If you file issues on specific tests that do that, I can take a look. > Switch from plexus-xml to stax / woodstox > - > > Key: MNG-7830 > URL: https://issues.apache.org/jira/browse/MNG-7830 > Project: Maven > Issue Type: Dependency upgrade >Reporter: Guillaume Nodet >Assignee: Guillaume Nodet >Priority: Major > Fix For: 4.0.0-alpha-8 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [maven] elharo commented on pull request #1185: [MNG-7830] Switch from plexus-xml to stax / woodstox
elharo commented on PR #1185: URL: https://github.com/apache/maven/pull/1185#issuecomment-1611590027 Depending on spaces in the prolog is a bug. Tests should be comparing XML to XML, not XML to strings. The latter is extremely brittle and can cause tests to break even in minor upgrades of a library. Alternately, we can canonicalize documents before comparing them. If you file issues on specific tests that do that, I can take a look. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MNG-7830) Switch from plexus-xml to stax / woodstox
[ https://issues.apache.org/jira/browse/MNG-7830?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17738117#comment-17738117 ] ASF GitHub Bot commented on MNG-7830: - gnodet commented on code in PR #1185: URL: https://github.com/apache/maven/pull/1185#discussion_r1245206728 ## maven-model-transform/pom.xml: ## @@ -32,6 +32,14 @@ under the License. org.codehaus.plexus plexus-xml + + org.codehaus.woodstox + stax2-api Review Comment: Yes, the round tripping (i.e. read the xml using stax and write it back to a string without any difference) is only supported by woodstox (the `stax2-api` is a mandatory dependency of woodstox anyway). > Switch from plexus-xml to stax / woodstox > - > > Key: MNG-7830 > URL: https://issues.apache.org/jira/browse/MNG-7830 > Project: Maven > Issue Type: Dependency upgrade >Reporter: Guillaume Nodet >Assignee: Guillaume Nodet >Priority: Major > Fix For: 4.0.0-alpha-8 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MNG-7828) Bump guava from 31.1-jre to 32.0.1-jre
[ https://issues.apache.org/jira/browse/MNG-7828?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17738116#comment-17738116 ] ASF GitHub Bot commented on MNG-7828: - bvolpato commented on PR #1189: URL: https://github.com/apache/maven/pull/1189#issuecomment-1611407336 Thanks! https://github.com/apache/maven/pull/1191 for master > Bump guava from 31.1-jre to 32.0.1-jre > -- > > Key: MNG-7828 > URL: https://issues.apache.org/jira/browse/MNG-7828 > Project: Maven > Issue Type: Dependency upgrade >Affects Versions: 3.9.x-candidate, 4.0.x-candidate >Reporter: Bruno Candido Volpato da Cunha >Priority: Major > > Currently used version is in the range of CVE-2023-2976, which was fixed in > 32.0.0. > > Please check [https://osv.dev/vulnerability/GHSA-7g45-4rm6-3mm3] for more > information. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [maven] gnodet commented on a diff in pull request #1185: [MNG-7830] Switch from plexus-xml to stax / woodstox
gnodet commented on code in PR #1185: URL: https://github.com/apache/maven/pull/1185#discussion_r1245206728 ## maven-model-transform/pom.xml: ## @@ -32,6 +32,14 @@ under the License. org.codehaus.plexus plexus-xml + + org.codehaus.woodstox + stax2-api Review Comment: Yes, the round tripping (i.e. read the xml using stax and write it back to a string without any difference) is only supported by woodstox (the `stax2-api` is a mandatory dependency of woodstox anyway). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MNG-7830) Switch from plexus-xml to stax / woodstox
[
https://issues.apache.org/jira/browse/MNG-7830?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17738114#comment-17738114
]
ASF GitHub Bot commented on MNG-7830:
-
gnodet commented on code in PR #1185:
URL: https://github.com/apache/maven/pull/1185#discussion_r1245204583
##
maven-model/src/test/java/org/apache/maven/model/v4/StaxTest.java:
##
@@ -0,0 +1,104 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.maven.model.v4;
+
+import java.io.IOException;
+import java.io.InputStream;
+import java.io.StringWriter;
+import java.nio.charset.Charset;
+import java.nio.file.Files;
+import java.nio.file.Path;
+import java.nio.file.Paths;
+import java.util.Objects;
+import java.util.stream.Stream;
+
+import org.apache.maven.api.model.InputSource;
+import org.apache.maven.api.model.Model;
+import org.junit.jupiter.api.Disabled;
+import org.junit.jupiter.api.Test;
+
+class StaxTest {
+
+@Test
+@Disabled
Review Comment:
See below ...
> Switch from plexus-xml to stax / woodstox
> -
>
> Key: MNG-7830
> URL: https://issues.apache.org/jira/browse/MNG-7830
> Project: Maven
> Issue Type: Dependency upgrade
>Reporter: Guillaume Nodet
>Assignee: Guillaume Nodet
>Priority: Major
> Fix For: 4.0.0-alpha-8
>
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MNG-7830) Switch from plexus-xml to stax / woodstox
[
https://issues.apache.org/jira/browse/MNG-7830?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17738115#comment-17738115
]
ASF GitHub Bot commented on MNG-7830:
-
gnodet commented on code in PR #1185:
URL: https://github.com/apache/maven/pull/1185#discussion_r1245205028
##
maven-model/src/test/java/org/apache/maven/model/v4/StaxTest.java:
##
@@ -0,0 +1,104 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.maven.model.v4;
+
+import java.io.IOException;
+import java.io.InputStream;
+import java.io.StringWriter;
+import java.nio.charset.Charset;
+import java.nio.file.Files;
+import java.nio.file.Path;
+import java.nio.file.Paths;
+import java.util.Objects;
+import java.util.stream.Stream;
+
+import org.apache.maven.api.model.InputSource;
+import org.apache.maven.api.model.Model;
+import org.junit.jupiter.api.Disabled;
+import org.junit.jupiter.api.Test;
+
+class StaxTest {
Review Comment:
Not really, I'll remove it.
> Switch from plexus-xml to stax / woodstox
> -
>
> Key: MNG-7830
> URL: https://issues.apache.org/jira/browse/MNG-7830
> Project: Maven
> Issue Type: Dependency upgrade
>Reporter: Guillaume Nodet
>Assignee: Guillaume Nodet
>Priority: Major
> Fix For: 4.0.0-alpha-8
>
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[GitHub] [maven] gnodet commented on a diff in pull request #1185: [MNG-7830] Switch from plexus-xml to stax / woodstox
gnodet commented on code in PR #1185:
URL: https://github.com/apache/maven/pull/1185#discussion_r1245205028
##
maven-model/src/test/java/org/apache/maven/model/v4/StaxTest.java:
##
@@ -0,0 +1,104 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.maven.model.v4;
+
+import java.io.IOException;
+import java.io.InputStream;
+import java.io.StringWriter;
+import java.nio.charset.Charset;
+import java.nio.file.Files;
+import java.nio.file.Path;
+import java.nio.file.Paths;
+import java.util.Objects;
+import java.util.stream.Stream;
+
+import org.apache.maven.api.model.InputSource;
+import org.apache.maven.api.model.Model;
+import org.junit.jupiter.api.Disabled;
+import org.junit.jupiter.api.Test;
+
+class StaxTest {
Review Comment:
Not really, I'll remove it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [maven] gnodet commented on a diff in pull request #1185: [MNG-7830] Switch from plexus-xml to stax / woodstox
gnodet commented on code in PR #1185:
URL: https://github.com/apache/maven/pull/1185#discussion_r1245204583
##
maven-model/src/test/java/org/apache/maven/model/v4/StaxTest.java:
##
@@ -0,0 +1,104 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.maven.model.v4;
+
+import java.io.IOException;
+import java.io.InputStream;
+import java.io.StringWriter;
+import java.nio.charset.Charset;
+import java.nio.file.Files;
+import java.nio.file.Path;
+import java.nio.file.Paths;
+import java.util.Objects;
+import java.util.stream.Stream;
+
+import org.apache.maven.api.model.InputSource;
+import org.apache.maven.api.model.Model;
+import org.junit.jupiter.api.Disabled;
+import org.junit.jupiter.api.Test;
+
+class StaxTest {
+
+@Test
+@Disabled
Review Comment:
See below ...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Commented] (MNG-7830) Switch from plexus-xml to stax / woodstox
[ https://issues.apache.org/jira/browse/MNG-7830?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17738113#comment-17738113 ] ASF GitHub Bot commented on MNG-7830: - gnodet commented on PR #1185: URL: https://github.com/apache/maven/pull/1185#issuecomment-1611403721 > Wow. This looks great. definitely a big leap forward. > > I might have missed it, but I didn't find any explicit use of the Stax2 API or Woodstox classes. Could this be done with JDK classes only? classes? Stax2 / woodstox is actually needed for the consumer POM transformation: the stax api is not sufficient and does not allow full round tripping with xml as spaces in prolog are not reported. Even aalto-xml does not support it. The effect is that when using another implementation, the line breaks before the first element of the POM are removed, so the generated POM will usually contains the xml declaration, the license and the `` element on a single line. Most importantly, this breaks tests :-) Apart from this use case, changing the implementation leads to various small issues as they do sometimes slightly differ in the specific events they generate. Writing namespaces is particularly challenging, though there's certainly a way to solve those discrepancies, but again, it breaks a few ITs which are particularly sensitive to the exact XML generated. Also, woodstox is 50% faster than the JDK implementation, so I definitely think we should use it. > Switch from plexus-xml to stax / woodstox > - > > Key: MNG-7830 > URL: https://issues.apache.org/jira/browse/MNG-7830 > Project: Maven > Issue Type: Dependency upgrade >Reporter: Guillaume Nodet >Assignee: Guillaume Nodet >Priority: Major > Fix For: 4.0.0-alpha-8 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [maven] rmannibucau commented on pull request #1190: PoC/experiment: new scope "import-plugins"
rmannibucau commented on PR #1190: URL: https://github.com/apache/maven/pull/1190#issuecomment-1611402406 The issue with "import" magic is that very quickly you will also need the conflict resolution management until you import a single piece which is basically a parent. Think extensions are a nice way to configure plugins (bad for dependencies since this part must always load in an IDE without code execution but it is not the case for plugins) but for the case you want to inherit from something done outside we could just use xml references, which would enable to import a template and customize it inline instead of importing as such which often leads to issues. So from my window we shouldn't enable much on dependencies but we can go quite far now we have the consumer model transformation pipeline by enabling to reference a plugin from an imported resource (can need an import block but not a big deal) and customize it inline, even with required placeholders if needed. I'd really love to see it done within an extension and using the xml transformer feature and without hacking the core yet to validate the usage since this part is quite hard to design right upfront. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven] cstamas commented on pull request #1190: PoC/experiment: new scope "import-plugins"
cstamas commented on PR #1190: URL: https://github.com/apache/maven/pull/1190#issuecomment-161130 And an idea from comment on MNG-5588: IF you are importing a POM, why not import _everything_? (And then need for new scope really goes away). Users can prepare POMs with parts then want (depMgt only, pluginMgt only, or both) and import. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven] hboutemy commented on pull request #1190: PoC/experiment: new scope "import-plugins"
hboutemy commented on PR #1190: URL: https://github.com/apache/maven/pull/1190#issuecomment-1611310404 see https://issues.apache.org/jira/browse/MNG-5588 like @talios : why not simplly use `import` for `pluginManagement` like it is done for `dependencyManagement`? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MSHARED-1248) maven-dependency-analyzer should log instead of failing when analyzing a corrupted jar file
[
https://issues.apache.org/jira/browse/MSHARED-1248?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17738096#comment-17738096
]
Gary D. Gregory commented on MSHARED-1248:
--
Next up, expectation management: Would someone tag this ticket with an expected
version?
And, would someone start the ball rolling on a release or provide a guesstimate?
> maven-dependency-analyzer should log instead of failing when analyzing a
> corrupted jar file
> ---
>
> Key: MSHARED-1248
> URL: https://issues.apache.org/jira/browse/MSHARED-1248
> Project: Maven Shared Components
> Issue Type: Bug
> Components: maven-dependency-analyzer
>Affects Versions: maven-dependency-analyzer-1.13.1
> Environment: Apache Maven 3.9.1
> (2e178502fcdbffc201671fb2537d0cb4b4cc58f8)
> Maven home: C:\java\apache-maven-3.9.1
> Java version: 1.8.0_362, vendor: Temurin, runtime: C:\Program Files\Eclipse
> Adoptium\jdk-8.0.362.9-hotspot\jre
> Default locale: en_US, platform encoding: Cp1252
> OS name: "windows 10", version: "10.0", arch: "amd64", family: "windows"
> Microsoft Windows [Version 10.0.19044.2728]
>Reporter: Gary D. Gregory
>Priority: Major
>
> In Apache Commons BCEL, we include corrupted jar files created by the
> oss-fuzz project which causes the build to fail when the CycloneDX plugin
> runs to create an SBOM.
> This issue happens only after getting past the issue fixed by MSHARED-1247
> {noformat}
> [DEBUG] CycloneDX: Calculating Hashes
> [INFO]
>
> [INFO] BUILD FAILURE
> [INFO]
>
> [INFO] Total time: 3.594 s
> [INFO] Finished at: 2023-04-29T15:23:05-04:00
> [INFO]
>
> [ERROR] Failed to execute goal
> org.cyclonedx:cyclonedx-maven-plugin:2.7.7:makeAggregateBom (default-cli) on
> project bcel: Execution default-cli of goal
> org.cyclonedx:cyclonedx-maven-plugin:2.7.7:makeAggregateBom failed:
> Unsupported class file major version 1025 from directory =
> C:\Users\ggregory\git\a\commons-bcel\target\test-classes, path =
> C:\Users\ggregory\git\a\commons-bcel\target\test-classes\ossfuzz\issue51980\Test.class
> -> [Help 1]
> org.apache.maven.lifecycle.LifecycleExecutionException: Failed to execute
> goal org.cyclonedx:cyclonedx-maven-plugin:2.7.7:makeAggregateBom
> (default-cli) on project bcel: Execution default-cli of goal
> org.cyclonedx:cyclonedx-maven-plugin:2.7.7:makeAggregateBom failed:
> Unsupported class file major version 1025 from directory =
> C:\Users\ggregory\git\a\commons-bcel\target\test-classes, path =
> C:\Users\ggregory\git\a\commons-bcel\target\test-classes\ossfuzz\issue51980\Test.class
> at org.apache.maven.lifecycle.internal.MojoExecutor.doExecute2
> (MojoExecutor.java:347)
> at org.apache.maven.lifecycle.internal.MojoExecutor.doExecute
> (MojoExecutor.java:330)
> at org.apache.maven.lifecycle.internal.MojoExecutor.execute
> (MojoExecutor.java:213)
> at org.apache.maven.lifecycle.internal.MojoExecutor.execute
> (MojoExecutor.java:175)
> at org.apache.maven.lifecycle.internal.MojoExecutor.access$000
> (MojoExecutor.java:76)
> at org.apache.maven.lifecycle.internal.MojoExecutor$1.run
> (MojoExecutor.java:163)
> at org.apache.maven.plugin.DefaultMojosExecutionStrategy.execute
> (DefaultMojosExecutionStrategy.java:39)
> at org.apache.maven.lifecycle.internal.MojoExecutor.execute
> (MojoExecutor.java:160)
> at
> org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject
> (LifecycleModuleBuilder.java:105)
> at
> org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject
> (LifecycleModuleBuilder.java:73)
> at
> org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.build
> (SingleThreadedBuilder.java:53)
> at org.apache.maven.lifecycle.internal.LifecycleStarter.execute
> (LifecycleStarter.java:118)
> at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:261)
> at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:173)
> at org.apache.maven.DefaultMaven.execute (DefaultMaven.java:101)
> at org.apache.maven.cli.MavenCli.execute (MavenCli.java:827)
> at org.apache.maven.cli.MavenCli.doMain (MavenCli.java:272)
> at org.apache.maven.cli.MavenCli.main (MavenCli.java:195)
> at sun.reflect.NativeMethodAccessorImpl.invoke0 (Native Method)
> at sun.reflect.NativeMethodAccessorImpl.invoke
> (NativeMethodAccessorImpl.java:62)
> at sun.reflect.DelegatingMethodAccessorImpl.invoke
> (DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke (Method.java:498)
>
[jira] (MSHARED-1248) maven-dependency-analyzer should log instead of failing when analyzing a corrupted jar file
[ https://issues.apache.org/jira/browse/MSHARED-1248 ]
Gary D. Gregory deleted comment on MSHARED-1248:
--
was (Author: garydgregory):
_emphasized text_
> maven-dependency-analyzer should log instead of failing when analyzing a
> corrupted jar file
> ---
>
> Key: MSHARED-1248
> URL: https://issues.apache.org/jira/browse/MSHARED-1248
> Project: Maven Shared Components
> Issue Type: Bug
> Components: maven-dependency-analyzer
>Affects Versions: maven-dependency-analyzer-1.13.1
> Environment: Apache Maven 3.9.1
> (2e178502fcdbffc201671fb2537d0cb4b4cc58f8)
> Maven home: C:\java\apache-maven-3.9.1
> Java version: 1.8.0_362, vendor: Temurin, runtime: C:\Program Files\Eclipse
> Adoptium\jdk-8.0.362.9-hotspot\jre
> Default locale: en_US, platform encoding: Cp1252
> OS name: "windows 10", version: "10.0", arch: "amd64", family: "windows"
> Microsoft Windows [Version 10.0.19044.2728]
>Reporter: Gary D. Gregory
>Priority: Major
>
> In Apache Commons BCEL, we include corrupted jar files created by the
> oss-fuzz project which causes the build to fail when the CycloneDX plugin
> runs to create an SBOM.
> This issue happens only after getting past the issue fixed by MSHARED-1247
> {noformat}
> [DEBUG] CycloneDX: Calculating Hashes
> [INFO]
>
> [INFO] BUILD FAILURE
> [INFO]
>
> [INFO] Total time: 3.594 s
> [INFO] Finished at: 2023-04-29T15:23:05-04:00
> [INFO]
>
> [ERROR] Failed to execute goal
> org.cyclonedx:cyclonedx-maven-plugin:2.7.7:makeAggregateBom (default-cli) on
> project bcel: Execution default-cli of goal
> org.cyclonedx:cyclonedx-maven-plugin:2.7.7:makeAggregateBom failed:
> Unsupported class file major version 1025 from directory =
> C:\Users\ggregory\git\a\commons-bcel\target\test-classes, path =
> C:\Users\ggregory\git\a\commons-bcel\target\test-classes\ossfuzz\issue51980\Test.class
> -> [Help 1]
> org.apache.maven.lifecycle.LifecycleExecutionException: Failed to execute
> goal org.cyclonedx:cyclonedx-maven-plugin:2.7.7:makeAggregateBom
> (default-cli) on project bcel: Execution default-cli of goal
> org.cyclonedx:cyclonedx-maven-plugin:2.7.7:makeAggregateBom failed:
> Unsupported class file major version 1025 from directory =
> C:\Users\ggregory\git\a\commons-bcel\target\test-classes, path =
> C:\Users\ggregory\git\a\commons-bcel\target\test-classes\ossfuzz\issue51980\Test.class
> at org.apache.maven.lifecycle.internal.MojoExecutor.doExecute2
> (MojoExecutor.java:347)
> at org.apache.maven.lifecycle.internal.MojoExecutor.doExecute
> (MojoExecutor.java:330)
> at org.apache.maven.lifecycle.internal.MojoExecutor.execute
> (MojoExecutor.java:213)
> at org.apache.maven.lifecycle.internal.MojoExecutor.execute
> (MojoExecutor.java:175)
> at org.apache.maven.lifecycle.internal.MojoExecutor.access$000
> (MojoExecutor.java:76)
> at org.apache.maven.lifecycle.internal.MojoExecutor$1.run
> (MojoExecutor.java:163)
> at org.apache.maven.plugin.DefaultMojosExecutionStrategy.execute
> (DefaultMojosExecutionStrategy.java:39)
> at org.apache.maven.lifecycle.internal.MojoExecutor.execute
> (MojoExecutor.java:160)
> at
> org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject
> (LifecycleModuleBuilder.java:105)
> at
> org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject
> (LifecycleModuleBuilder.java:73)
> at
> org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.build
> (SingleThreadedBuilder.java:53)
> at org.apache.maven.lifecycle.internal.LifecycleStarter.execute
> (LifecycleStarter.java:118)
> at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:261)
> at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:173)
> at org.apache.maven.DefaultMaven.execute (DefaultMaven.java:101)
> at org.apache.maven.cli.MavenCli.execute (MavenCli.java:827)
> at org.apache.maven.cli.MavenCli.doMain (MavenCli.java:272)
> at org.apache.maven.cli.MavenCli.main (MavenCli.java:195)
> at sun.reflect.NativeMethodAccessorImpl.invoke0 (Native Method)
> at sun.reflect.NativeMethodAccessorImpl.invoke
> (NativeMethodAccessorImpl.java:62)
> at sun.reflect.DelegatingMethodAccessorImpl.invoke
> (DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke (Method.java:498)
> at org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced
> (Launcher.java:282)
> at org.codehaus.plexus.classworlds.launcher.Launcher.launch
> (Launcher.java:225)
> at
[jira] [Commented] (MNG-7830) Switch from plexus-xml to stax / woodstox
[
https://issues.apache.org/jira/browse/MNG-7830?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17738086#comment-17738086
]
ASF GitHub Bot commented on MNG-7830:
-
elharo commented on code in PR #1185:
URL: https://github.com/apache/maven/pull/1185#discussion_r1245091437
##
maven-model-builder/src/main/java/org/apache/maven/model/io/DefaultModelReader.java:
##
@@ -120,23 +120,29 @@ private Model read(Reader reader, Path pomFile,
Map options) throws I
} else {
return readModel(transformingParser, strict);
}
-} catch (XmlPullParserException e) {
-throw new ModelParseException(e.getMessage(), e.getLineNumber(),
e.getColumnNumber(), e);
+} catch (XMLStreamException e) {
+Location location = e.getLocation();
+throw new ModelParseException(
+e.getMessage(),
+location != null ? location.getLineNumber() : -1,
+location != null ? location.getColumnNumber() : -1,
+e);
} catch (IOException e) {
throw e;
} catch (Exception e) {
Review Comment:
This catch block might not be needed any more
##
maven-model/src/test/java/org/apache/maven/model/v4/StaxTest.java:
##
@@ -0,0 +1,104 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.maven.model.v4;
+
+import java.io.IOException;
+import java.io.InputStream;
+import java.io.StringWriter;
+import java.nio.charset.Charset;
+import java.nio.file.Files;
+import java.nio.file.Path;
+import java.nio.file.Paths;
+import java.util.Objects;
+import java.util.stream.Stream;
+
+import org.apache.maven.api.model.InputSource;
+import org.apache.maven.api.model.Model;
+import org.junit.jupiter.api.Disabled;
+import org.junit.jupiter.api.Test;
+
+class StaxTest {
+
+@Test
+@Disabled
+void readAll() throws IOException {
+Path userHome = Paths.get(System.getProperty("user.home"));
+Stream poms = Files.walk(userHome.resolve(".m2/repository/"))
+.filter(p -> p.getFileName().toString().endsWith(".pom") &&
Files.isRegularFile(p));
+poms.forEach(pom -> {
+Model stax = null, xpp3 = null;
+try (InputStream is = Files.newInputStream(pom)) {
+xpp3 = new MavenXpp3ReaderEx().read(is, false, new
InputSource("id", pom.toString()));
+} catch (Exception e) {
+System.err.println("Unable to parse using xpp3: " + pom + " ("
+ e.getMessage() + ")");
Review Comment:
The test should just fail here, or perhaps skip
##
maven-model/src/test/java/org/apache/maven/model/v4/StaxTest.java:
##
@@ -0,0 +1,104 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.maven.model.v4;
+
+import java.io.IOException;
+import java.io.InputStream;
+import java.io.StringWriter;
+import java.nio.charset.Charset;
+import java.nio.file.Files;
+import java.nio.file.Path;
+import java.nio.file.Paths;
+import java.util.Objects;
+import java.util.stream.Stream;
+
+import org.apache.maven.api.model.InputSource;
+import org.apache.maven.api.model.Model;
+import org.junit.jupiter.api.Disabled;
+import org.junit.jupiter.api.Test;
+
+class StaxTest {
+
+@Test
+@Disabled
+void readAll() throws IOException {
+
[GitHub] [maven] elharo commented on a diff in pull request #1185: [MNG-7830] Switch from plexus-xml to stax / woodstox
elharo commented on code in PR #1185:
URL: https://github.com/apache/maven/pull/1185#discussion_r1245091437
##
maven-model-builder/src/main/java/org/apache/maven/model/io/DefaultModelReader.java:
##
@@ -120,23 +120,29 @@ private Model read(Reader reader, Path pomFile,
Map options) throws I
} else {
return readModel(transformingParser, strict);
}
-} catch (XmlPullParserException e) {
-throw new ModelParseException(e.getMessage(), e.getLineNumber(),
e.getColumnNumber(), e);
+} catch (XMLStreamException e) {
+Location location = e.getLocation();
+throw new ModelParseException(
+e.getMessage(),
+location != null ? location.getLineNumber() : -1,
+location != null ? location.getColumnNumber() : -1,
+e);
} catch (IOException e) {
throw e;
} catch (Exception e) {
Review Comment:
This catch block might not be needed any more
##
maven-model/src/test/java/org/apache/maven/model/v4/StaxTest.java:
##
@@ -0,0 +1,104 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.maven.model.v4;
+
+import java.io.IOException;
+import java.io.InputStream;
+import java.io.StringWriter;
+import java.nio.charset.Charset;
+import java.nio.file.Files;
+import java.nio.file.Path;
+import java.nio.file.Paths;
+import java.util.Objects;
+import java.util.stream.Stream;
+
+import org.apache.maven.api.model.InputSource;
+import org.apache.maven.api.model.Model;
+import org.junit.jupiter.api.Disabled;
+import org.junit.jupiter.api.Test;
+
+class StaxTest {
+
+@Test
+@Disabled
+void readAll() throws IOException {
+Path userHome = Paths.get(System.getProperty("user.home"));
+Stream poms = Files.walk(userHome.resolve(".m2/repository/"))
+.filter(p -> p.getFileName().toString().endsWith(".pom") &&
Files.isRegularFile(p));
+poms.forEach(pom -> {
+Model stax = null, xpp3 = null;
+try (InputStream is = Files.newInputStream(pom)) {
+xpp3 = new MavenXpp3ReaderEx().read(is, false, new
InputSource("id", pom.toString()));
+} catch (Exception e) {
+System.err.println("Unable to parse using xpp3: " + pom + " ("
+ e.getMessage() + ")");
Review Comment:
The test should just fail here, or perhaps skip
##
maven-model/src/test/java/org/apache/maven/model/v4/StaxTest.java:
##
@@ -0,0 +1,104 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.maven.model.v4;
+
+import java.io.IOException;
+import java.io.InputStream;
+import java.io.StringWriter;
+import java.nio.charset.Charset;
+import java.nio.file.Files;
+import java.nio.file.Path;
+import java.nio.file.Paths;
+import java.util.Objects;
+import java.util.stream.Stream;
+
+import org.apache.maven.api.model.InputSource;
+import org.apache.maven.api.model.Model;
+import org.junit.jupiter.api.Disabled;
+import org.junit.jupiter.api.Test;
+
+class StaxTest {
+
+@Test
+@Disabled
+void readAll() throws IOException {
+Path userHome = Paths.get(System.getProperty("user.home"));
+Stream poms = Files.walk(userHome.resolve(".m2/repository/"))
+.filter(p -> p.getFileName().toString().endsWith(".pom") &&
[GitHub] [maven-pmd-plugin] dependabot[bot] opened a new pull request, #134: Bump release-drafter/release-drafter from 5.23.0 to 5.24.0
dependabot[bot] opened a new pull request, #134: URL: https://github.com/apache/maven-pmd-plugin/pull/134 Bumps [release-drafter/release-drafter](https://github.com/release-drafter/release-drafter) from 5.23.0 to 5.24.0. Release notes Sourced from https://github.com/release-drafter/release-drafter/releases;>release-drafter/release-drafter's releases. v5.24.0 What's Changed New Add release version to github action output (https://redirect.github.com/release-drafter/release-drafter/issues/1300;>#1300) https://github.com/mehdihadeli;>@mehdihadeli Bug Fixes fix(release): strip prefix before comparing version (https://redirect.github.com/release-drafter/release-drafter/issues/1255;>#1255) https://github.com/neilime;>@neilime Full Changelog: https://github.com/release-drafter/release-drafter/compare/v5.23.0...v5.24.0;>https://github.com/release-drafter/release-drafter/compare/v5.23.0...v5.24.0 Commits https://github.com/release-drafter/release-drafter/commit/65c5fb495d1e69aa8c08a3317bc44ff8aabe9772;>65c5fb4 v5.24.0 https://github.com/release-drafter/release-drafter/commit/918b32f6ce42491f4bb8da60f6d1db912028c800;>918b32f feat: add outputs descriptions to action.yaml file (https://redirect.github.com/release-drafter/release-drafter/issues/1347;>#1347) https://github.com/release-drafter/release-drafter/commit/a04b60931d2e3e5cfc7aa71e68334f2fdbe24b5f;>a04b609 Add release version to github action output (https://redirect.github.com/release-drafter/release-drafter/issues/1300;>#1300) https://github.com/release-drafter/release-drafter/commit/b853a4c92ff8c8de0356b86c020abb3c31cd0715;>b853a4c fix(release): strip prefix before comparing version (https://redirect.github.com/release-drafter/release-drafter/issues/1255;>#1255) See full diff in https://github.com/release-drafter/release-drafter/compare/v5.23.0...v5.24.0;>compare view [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MNG-7830) Switch from plexus-xml to stax / woodstox
[ https://issues.apache.org/jira/browse/MNG-7830?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17738074#comment-17738074 ] Michael Osipov commented on MNG-7830: - There are other issues in Jira which have the same topic, but for other modules. > Switch from plexus-xml to stax / woodstox > - > > Key: MNG-7830 > URL: https://issues.apache.org/jira/browse/MNG-7830 > Project: Maven > Issue Type: Dependency upgrade >Reporter: Guillaume Nodet >Assignee: Guillaume Nodet >Priority: Major > Fix For: 4.0.0-alpha-8 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MNG-7820) Remove dependency on plexus-utils
[ https://issues.apache.org/jira/browse/MNG-7820?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17738067#comment-17738067 ] Guillaume Nodet commented on MNG-7820: -- This will be taken care of by https://github.com/apache/maven/pull/1185 > Remove dependency on plexus-utils > - > > Key: MNG-7820 > URL: https://issues.apache.org/jira/browse/MNG-7820 > Project: Maven > Issue Type: Task >Reporter: Guillaume Nodet >Priority: Major > Fix For: 4.0.0-alpha-8 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [maven] talios commented on pull request #1190: PoC/experiment: new scope "import-plugins"
talios commented on PR #1190: URL: https://github.com/apache/maven/pull/1190#issuecomment-1611241970 @cstamas This is interesting and could almost be a migration path for tiles-maven-plugin - I wonder if having a new scope is good tho, rather than reusing the existing `import` scope, but included in the `` section itself. I'll pull the PR in the morning and play with it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Assigned] (MNG-7830) Switch from plexus-xml to stax / woodstox
[ https://issues.apache.org/jira/browse/MNG-7830?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guillaume Nodet reassigned MNG-7830: Assignee: Guillaume Nodet > Switch from plexus-xml to stax / woodstox > - > > Key: MNG-7830 > URL: https://issues.apache.org/jira/browse/MNG-7830 > Project: Maven > Issue Type: Dependency upgrade >Reporter: Guillaume Nodet >Assignee: Guillaume Nodet >Priority: Major > Fix For: 4.0.0-alpha-8 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (MNG-7830) Switch from plexus-xml to stax / woodstox
Guillaume Nodet created MNG-7830: Summary: Switch from plexus-xml to stax / woodstox Key: MNG-7830 URL: https://issues.apache.org/jira/browse/MNG-7830 Project: Maven Issue Type: Dependency upgrade Reporter: Guillaume Nodet Fix For: 4.0.0-alpha-8 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Closed] (MNG-7829) CLI properties passed with -D are not accessible with session.getSystemProperties()
[
https://issues.apache.org/jira/browse/MNG-7829?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Osipov closed MNG-7829.
---
Resolution: Information Provided
> CLI properties passed with -D are not accessible with
> session.getSystemProperties()
> ---
>
> Key: MNG-7829
> URL: https://issues.apache.org/jira/browse/MNG-7829
> Project: Maven
> Issue Type: Bug
> Components: Command Line
>Affects Versions: 4.0.0-alpha-7
>Reporter: Jerome Prinet
>Priority: Minor
>
> h3. Context
> * Maven _4.0.0-alpha-6_ and above
> * A Maven extension collecting CLI arguments passed with _-D_
> h3. Issue
> In a Maven extension, I am collecting CLI arguments which allow to skip tests
> if present ({_}skipTests, skipITs, maven.test.skip{_}).
> The problem is that since Maven {_}4.0.0-alpha06{_}, these informations are
> not part of the
> [session.systemProperties|https://maven.apache.org/ref/3.9.3/maven-core/apidocs/org/apache/maven/execution/MavenSession.html#getSystemProperties()]
> anymore.
> This is working fine until [this
> commit|https://github.com/apache/maven/commit/a1fa3eb5346f562a745f054650eee1e84c44db30?diff=unified]
> if not mistaken.
> The missing instruction being [this
> one|https://github.com/apache/maven/commit/a1fa3eb5346f562a745f054650eee1e84c44db30?diff=unified#diff-b8b814f5b6b3855ae79dc45a0266b94871193dcef42803c316e07409e94af35cL1546].
> *If I add this back on the latest version of master, I am able to collect the
> information.*
> h3. Alternative
> Those properties can be accessed via the
> [session.getUserProperties()|https://maven.apache.org/ref/3.9.3/maven-core/apidocs/org/apache/maven/execution/MavenSession.html#getUserProperties()]
> Please confirm if this is the expected way to collect the data.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MNG-7829) CLI properties passed with -D are not accessible with session.getSystemProperties()
[
https://issues.apache.org/jira/browse/MNG-7829?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17738049#comment-17738049
]
Jerome Prinet commented on MNG-7829:
Absolutely
> CLI properties passed with -D are not accessible with
> session.getSystemProperties()
> ---
>
> Key: MNG-7829
> URL: https://issues.apache.org/jira/browse/MNG-7829
> Project: Maven
> Issue Type: Bug
> Components: Command Line
>Affects Versions: 4.0.0-alpha-7
>Reporter: Jerome Prinet
>Priority: Minor
>
> h3. Context
> * Maven _4.0.0-alpha-6_ and above
> * A Maven extension collecting CLI arguments passed with _-D_
> h3. Issue
> In a Maven extension, I am collecting CLI arguments which allow to skip tests
> if present ({_}skipTests, skipITs, maven.test.skip{_}).
> The problem is that since Maven {_}4.0.0-alpha06{_}, these informations are
> not part of the
> [session.systemProperties|https://maven.apache.org/ref/3.9.3/maven-core/apidocs/org/apache/maven/execution/MavenSession.html#getSystemProperties()]
> anymore.
> This is working fine until [this
> commit|https://github.com/apache/maven/commit/a1fa3eb5346f562a745f054650eee1e84c44db30?diff=unified]
> if not mistaken.
> The missing instruction being [this
> one|https://github.com/apache/maven/commit/a1fa3eb5346f562a745f054650eee1e84c44db30?diff=unified#diff-b8b814f5b6b3855ae79dc45a0266b94871193dcef42803c316e07409e94af35cL1546].
> *If I add this back on the latest version of master, I am able to collect the
> information.*
> h3. Alternative
> Those properties can be accessed via the
> [session.getUserProperties()|https://maven.apache.org/ref/3.9.3/maven-core/apidocs/org/apache/maven/execution/MavenSession.html#getUserProperties()]
> Please confirm if this is the expected way to collect the data.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[GitHub] [maven] cstamas opened a new pull request, #1190: PoC/experiment: new scope "import-plugins"
cstamas opened a new pull request, #1190: URL: https://github.com/apache/maven/pull/1190 Introduces new scope very similar to "import" but this one is "import-plugins" and as it's name says, imports pluginManagement. To test it: * build this PR * use this POM https://gist.github.com/cstamas/8668205f68b0eaf42c8c34bba7d080a4 * invoke `mvn help:effective-pom` Enjoy! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (MDEP-878) Unexpected failure in mappers: no empty replacement or extension possible
Ernst Reissner created MDEP-878:
---
Summary: Unexpected failure in mappers: no empty replacement or
extension possible
Key: MDEP-878
URL: https://issues.apache.org/jira/browse/MDEP-878
Project: Maven Dependency Plugin
Issue Type: New Feature
Reporter: Ernst Reissner
I have the following configuration:
```
eu.simuline.m2latex
latex-maven-plugin
${versionLatexPlugin}
jar
true
src/main/resources
.latexmkrc.raw
c.raw$
c
```
As you can see, I tricked.
i wanted just to replace `.raw` by the empty string.
This was not possible and I think, an empty replacement is fully valid.
Also I would have used the `FileExtensionMapper`, but also this does not accept
an empty extension.
Analogously I think, this should be allowed.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Created] (MDEP-877) goal unpack: ignores path in includes/excludes
Ernst Reissner created MDEP-877:
---
Summary: goal unpack: ignores path in includes/excludes
Key: MDEP-877
URL: https://issues.apache.org/jira/browse/MDEP-877
Project: Maven Dependency Plugin
Issue Type: New Feature
Components: unpack
Affects Versions: 3.6.0
Reporter: Ernst Reissner
in my jar i have files
- .latexmkrc and
- raw/.latexmkrc
I want to extract only .latexmkrc
So I configure:
```
eu.simuline.m2latex
latex-maven-plugin
${versionLatexPlugin}
jar
true
${latexDir}
.latexmkrc,
.chktexrc
```
But what is extracted is still raw/.latexmkrc.
Even if i add `raw/.latexmkrc` this does not help.
I have the impression, the config just ignores all but the file name.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MNG-7829) CLI properties passed with -D are not accessible with session.getSystemProperties()
[
https://issues.apache.org/jira/browse/MNG-7829?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17738037#comment-17738037
]
Michael Osipov commented on MNG-7829:
-
Should we close this as information provided?
> CLI properties passed with -D are not accessible with
> session.getSystemProperties()
> ---
>
> Key: MNG-7829
> URL: https://issues.apache.org/jira/browse/MNG-7829
> Project: Maven
> Issue Type: Bug
> Components: Command Line
>Affects Versions: 4.0.0-alpha-7
>Reporter: Jerome Prinet
>Priority: Minor
>
> h3. Context
> * Maven _4.0.0-alpha-6_ and above
> * A Maven extension collecting CLI arguments passed with _-D_
> h3. Issue
> In a Maven extension, I am collecting CLI arguments which allow to skip tests
> if present ({_}skipTests, skipITs, maven.test.skip{_}).
> The problem is that since Maven {_}4.0.0-alpha06{_}, these informations are
> not part of the
> [session.systemProperties|https://maven.apache.org/ref/3.9.3/maven-core/apidocs/org/apache/maven/execution/MavenSession.html#getSystemProperties()]
> anymore.
> This is working fine until [this
> commit|https://github.com/apache/maven/commit/a1fa3eb5346f562a745f054650eee1e84c44db30?diff=unified]
> if not mistaken.
> The missing instruction being [this
> one|https://github.com/apache/maven/commit/a1fa3eb5346f562a745f054650eee1e84c44db30?diff=unified#diff-b8b814f5b6b3855ae79dc45a0266b94871193dcef42803c316e07409e94af35cL1546].
> *If I add this back on the latest version of master, I am able to collect the
> information.*
> h3. Alternative
> Those properties can be accessed via the
> [session.getUserProperties()|https://maven.apache.org/ref/3.9.3/maven-core/apidocs/org/apache/maven/execution/MavenSession.html#getUserProperties()]
> Please confirm if this is the expected way to collect the data.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MNG-7829) CLI properties passed with -D are not accessible with session.getSystemProperties()
[
https://issues.apache.org/jira/browse/MNG-7829?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17738029#comment-17738029
]
Jerome Prinet commented on MNG-7829:
Thanks for the swift confirmation
> CLI properties passed with -D are not accessible with
> session.getSystemProperties()
> ---
>
> Key: MNG-7829
> URL: https://issues.apache.org/jira/browse/MNG-7829
> Project: Maven
> Issue Type: Bug
> Components: Command Line
>Affects Versions: 4.0.0-alpha-7
>Reporter: Jerome Prinet
>Priority: Minor
>
> h3. Context
> * Maven _4.0.0-alpha-6_ and above
> * A Maven extension collecting CLI arguments passed with _-D_
> h3. Issue
> In a Maven extension, I am collecting CLI arguments which allow to skip tests
> if present ({_}skipTests, skipITs, maven.test.skip{_}).
> The problem is that since Maven {_}4.0.0-alpha06{_}, these informations are
> not part of the
> [session.systemProperties|https://maven.apache.org/ref/3.9.3/maven-core/apidocs/org/apache/maven/execution/MavenSession.html#getSystemProperties()]
> anymore.
> This is working fine until [this
> commit|https://github.com/apache/maven/commit/a1fa3eb5346f562a745f054650eee1e84c44db30?diff=unified]
> if not mistaken.
> The missing instruction being [this
> one|https://github.com/apache/maven/commit/a1fa3eb5346f562a745f054650eee1e84c44db30?diff=unified#diff-b8b814f5b6b3855ae79dc45a0266b94871193dcef42803c316e07409e94af35cL1546].
> *If I add this back on the latest version of master, I am able to collect the
> information.*
> h3. Alternative
> Those properties can be accessed via the
> [session.getUserProperties()|https://maven.apache.org/ref/3.9.3/maven-core/apidocs/org/apache/maven/execution/MavenSession.html#getUserProperties()]
> Please confirm if this is the expected way to collect the data.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Comment Edited] (MNG-7829) CLI properties passed with -D are not accessible with session.getSystemProperties()
[
https://issues.apache.org/jira/browse/MNG-7829?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17738020#comment-17738020
]
Tamas Cservenak edited comment on MNG-7829 at 6/28/23 9:10 AM:
---
The CLI -D properties are called "maven user properties". The "maven system
properties" are usually populated from Java System Properties (and more).
People usually mix up these above with Java System Properties (partially as
Maven3 did that: it pushed "maven user properties" into Java System Properties).
To get "effective" properties:
* create new map
* put all maven system properties
* put all maven user properties (as their precedence is higher, will replace
existing mapping if any)
* resulting map is "effective" properties
[~gnodet] please ping in here
was (Author: cstamas):
The CLI -D properties are called "maven user properties". The "maven system
properties" are usually populated from Java System Properties (and more).
People usually mix up these above with Java System Properties (partially as
Maven3 did that: it pushed "maven user properties" into Java System Properties).
To get "effective" properties:
create new map
put all system propertie
put all user properties (as their precedence is higher)
resulting map is "effective"
[~gnodet] please ping in here
> CLI properties passed with -D are not accessible with
> session.getSystemProperties()
> ---
>
> Key: MNG-7829
> URL: https://issues.apache.org/jira/browse/MNG-7829
> Project: Maven
> Issue Type: Bug
> Components: Command Line
>Affects Versions: 4.0.0-alpha-7
>Reporter: Jerome Prinet
>Priority: Minor
>
> h3. Context
> * Maven _4.0.0-alpha-6_ and above
> * A Maven extension collecting CLI arguments passed with _-D_
> h3. Issue
> In a Maven extension, I am collecting CLI arguments which allow to skip tests
> if present ({_}skipTests, skipITs, maven.test.skip{_}).
> The problem is that since Maven {_}4.0.0-alpha06{_}, these informations are
> not part of the
> [session.systemProperties|https://maven.apache.org/ref/3.9.3/maven-core/apidocs/org/apache/maven/execution/MavenSession.html#getSystemProperties()]
> anymore.
> This is working fine until [this
> commit|https://github.com/apache/maven/commit/a1fa3eb5346f562a745f054650eee1e84c44db30?diff=unified]
> if not mistaken.
> The missing instruction being [this
> one|https://github.com/apache/maven/commit/a1fa3eb5346f562a745f054650eee1e84c44db30?diff=unified#diff-b8b814f5b6b3855ae79dc45a0266b94871193dcef42803c316e07409e94af35cL1546].
> *If I add this back on the latest version of master, I am able to collect the
> information.*
> h3. Alternative
> Those properties can be accessed via the
> [session.getUserProperties()|https://maven.apache.org/ref/3.9.3/maven-core/apidocs/org/apache/maven/execution/MavenSession.html#getUserProperties()]
> Please confirm if this is the expected way to collect the data.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MNG-7828) Bump guava from 31.1-jre to 32.0.1-jre
[ https://issues.apache.org/jira/browse/MNG-7828?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17738024#comment-17738024 ] ASF GitHub Bot commented on MNG-7828: - cstamas commented on PR #1189: URL: https://github.com/apache/maven/pull/1189#issuecomment-1611048094 Similar change will be needed for master branch as well. > Bump guava from 31.1-jre to 32.0.1-jre > -- > > Key: MNG-7828 > URL: https://issues.apache.org/jira/browse/MNG-7828 > Project: Maven > Issue Type: Dependency upgrade >Affects Versions: 3.9.x-candidate, 4.0.x-candidate >Reporter: Bruno Candido Volpato da Cunha >Priority: Major > > Currently used version is in the range of CVE-2023-2976, which was fixed in > 32.0.0. > > Please check [https://osv.dev/vulnerability/GHSA-7g45-4rm6-3mm3] for more > information. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MNG-7829) CLI properties passed with -D are not accessible with session.getSystemProperties()
[
https://issues.apache.org/jira/browse/MNG-7829?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17738022#comment-17738022
]
Michael Osipov commented on MNG-7829:
-
Correct, misunderstanding from users. Look at {{{}mvn --help{}}}, it says user
properties. Although unexpected, I consider the behavior correct. System
properties need to be set by Java means, not Maven means.
> CLI properties passed with -D are not accessible with
> session.getSystemProperties()
> ---
>
> Key: MNG-7829
> URL: https://issues.apache.org/jira/browse/MNG-7829
> Project: Maven
> Issue Type: Bug
> Components: Command Line
>Affects Versions: 4.0.0-alpha-7
>Reporter: Jerome Prinet
>Priority: Minor
>
> h3. Context
> * Maven _4.0.0-alpha-6_ and above
> * A Maven extension collecting CLI arguments passed with _-D_
> h3. Issue
> In a Maven extension, I am collecting CLI arguments which allow to skip tests
> if present ({_}skipTests, skipITs, maven.test.skip{_}).
> The problem is that since Maven {_}4.0.0-alpha06{_}, these informations are
> not part of the
> [session.systemProperties|https://maven.apache.org/ref/3.9.3/maven-core/apidocs/org/apache/maven/execution/MavenSession.html#getSystemProperties()]
> anymore.
> This is working fine until [this
> commit|https://github.com/apache/maven/commit/a1fa3eb5346f562a745f054650eee1e84c44db30?diff=unified]
> if not mistaken.
> The missing instruction being [this
> one|https://github.com/apache/maven/commit/a1fa3eb5346f562a745f054650eee1e84c44db30?diff=unified#diff-b8b814f5b6b3855ae79dc45a0266b94871193dcef42803c316e07409e94af35cL1546].
> *If I add this back on the latest version of master, I am able to collect the
> information.*
> h3. Alternative
> Those properties can be accessed via the
> [session.getUserProperties()|https://maven.apache.org/ref/3.9.3/maven-core/apidocs/org/apache/maven/execution/MavenSession.html#getUserProperties()]
> Please confirm if this is the expected way to collect the data.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Updated] (MNG-7828) Bump guava from 31.1-jre to 32.0.1-jre
[ https://issues.apache.org/jira/browse/MNG-7828?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tamas Cservenak updated MNG-7828: - Summary: Bump guava from 31.1-jre to 32.0.1-jre (was: Bump guava from 31.1-android to 32.0.1-android) > Bump guava from 31.1-jre to 32.0.1-jre > -- > > Key: MNG-7828 > URL: https://issues.apache.org/jira/browse/MNG-7828 > Project: Maven > Issue Type: Dependency upgrade >Affects Versions: 3.9.x-candidate, 4.0.x-candidate >Reporter: Bruno Candido Volpato da Cunha >Priority: Major > > Currently used version is in the range of CVE-2023-2976, which was fixed in > 32.0.0. > > Please check [https://osv.dev/vulnerability/GHSA-7g45-4rm6-3mm3] for more > information. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MNG-7829) CLI properties passed with -D are not accessible with session.getSystemProperties()
[
https://issues.apache.org/jira/browse/MNG-7829?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17738020#comment-17738020
]
Tamas Cservenak commented on MNG-7829:
--
The CLI -D properties are called "maven user properties". The "maven system
properties" are usually populated from Java System Properties (and more).
People usually mix up these above with Java System Properties (partially as
Maven3 did that: it pushed "maven user properties" into Java System Properties).
To get "effective" properties:
create new map
put all system propertie
put all user properties (as their precedence is higher)
resulting map is "effective"
[~gnodet] please ping in here
> CLI properties passed with -D are not accessible with
> session.getSystemProperties()
> ---
>
> Key: MNG-7829
> URL: https://issues.apache.org/jira/browse/MNG-7829
> Project: Maven
> Issue Type: Bug
> Components: Command Line
>Affects Versions: 4.0.0-alpha-7
>Reporter: Jerome Prinet
>Priority: Minor
>
> h3. Context
> * Maven _4.0.0-alpha-6_ and above
> * A Maven extension collecting CLI arguments passed with _-D_
> h3. Issue
> In a Maven extension, I am collecting CLI arguments which allow to skip tests
> if present ({_}skipTests, skipITs, maven.test.skip{_}).
> The problem is that since Maven {_}4.0.0-alpha06{_}, these informations are
> not part of the
> [session.systemProperties|https://maven.apache.org/ref/3.9.3/maven-core/apidocs/org/apache/maven/execution/MavenSession.html#getSystemProperties()]
> anymore.
> This is working fine until [this
> commit|https://github.com/apache/maven/commit/a1fa3eb5346f562a745f054650eee1e84c44db30?diff=unified]
> if not mistaken.
> The missing instruction being [this
> one|https://github.com/apache/maven/commit/a1fa3eb5346f562a745f054650eee1e84c44db30?diff=unified#diff-b8b814f5b6b3855ae79dc45a0266b94871193dcef42803c316e07409e94af35cL1546].
> *If I add this back on the latest version of master, I am able to collect the
> information.*
> h3. Alternative
> Those properties can be accessed via the
> [session.getUserProperties()|https://maven.apache.org/ref/3.9.3/maven-core/apidocs/org/apache/maven/execution/MavenSession.html#getUserProperties()]
> Please confirm if this is the expected way to collect the data.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Updated] (MNG-7829) CLI properties passed with -D are not accessible with session.getSystemProperties()
[
https://issues.apache.org/jira/browse/MNG-7829?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jerome Prinet updated MNG-7829:
---
Description:
h3. Context
* Maven _4.0.0-alpha-6_ and above
* A Maven extension collecting CLI arguments passed with _-D_
h3. Issue
In a Maven extension, I am collecting CLI arguments which allow to skip tests
if present ({_}skipTests, skipITs, maven.test.skip{_}).
The problem is that since Maven {_}4.0.0-alpha06{_}, these informations are not
part of the
[session.systemProperties|https://maven.apache.org/ref/3.9.3/maven-core/apidocs/org/apache/maven/execution/MavenSession.html#getSystemProperties()]
anymore.
This is working fine until [this
commit|https://github.com/apache/maven/commit/a1fa3eb5346f562a745f054650eee1e84c44db30?diff=unified]
if not mistaken.
The missing instruction being [this
one|https://github.com/apache/maven/commit/a1fa3eb5346f562a745f054650eee1e84c44db30?diff=unified#diff-b8b814f5b6b3855ae79dc45a0266b94871193dcef42803c316e07409e94af35cL1546].
*If I add this back on the latest version of master, I am able to collect the
information.*
h3. Alternative
Those properties can be accessed via the
[session.getUserProperties()|https://maven.apache.org/ref/3.9.3/maven-core/apidocs/org/apache/maven/execution/MavenSession.html#getUserProperties()]
Please confirm if this is the expected way to collect the data.
was:
h3. Context
* Maven _4.0.0-alpha-6_ and above
* A Maven extension collecting CLI arguments passed with _-D_
h3. Issue
In a Maven extension, I am collecting CLI arguments which allow to skip tests
if present ({_}skipTests, skipITs, maven.test.skip{_}).
The problem is that since Maven {_}4.0.0-alpha06{_}, these informations are not
part of the
[session.systemProperties|https://maven.apache.org/ref/3.9.3/maven-core/apidocs/org/apache/maven/execution/MavenSession.html#getSystemProperties()]
anymore.
This is working fine until [this
commit|https://github.com/apache/maven/commit/a1fa3eb5346f562a745f054650eee1e84c44db30?diff=unified]
if not mistaken.
The missing instruction being [this
one|https://github.com/apache/maven/commit/a1fa3eb5346f562a745f054650eee1e84c44db30?diff=unified#diff-b8b814f5b6b3855ae79dc45a0266b94871193dcef42803c316e07409e94af35cL1546].
*If I add this back on the latest version of master, I am able to collect the
information.*
h3. Alternative
Those properties can be accessed via the
[session.getUserProperties()|https://maven.apache.org/ref/3.9.3/maven-core/apidocs/org/apache/maven/execution/MavenSession.html#getUserProperties()]
Please confirm if this is the expected way to collect the data.{{{}{}}}
> CLI properties passed with -D are not accessible with
> session.getSystemProperties()
> ---
>
> Key: MNG-7829
> URL: https://issues.apache.org/jira/browse/MNG-7829
> Project: Maven
> Issue Type: Bug
> Components: Command Line
>Affects Versions: 4.0.0-alpha-7
>Reporter: Jerome Prinet
>Priority: Minor
>
> h3. Context
> * Maven _4.0.0-alpha-6_ and above
> * A Maven extension collecting CLI arguments passed with _-D_
> h3. Issue
> In a Maven extension, I am collecting CLI arguments which allow to skip tests
> if present ({_}skipTests, skipITs, maven.test.skip{_}).
> The problem is that since Maven {_}4.0.0-alpha06{_}, these informations are
> not part of the
> [session.systemProperties|https://maven.apache.org/ref/3.9.3/maven-core/apidocs/org/apache/maven/execution/MavenSession.html#getSystemProperties()]
> anymore.
> This is working fine until [this
> commit|https://github.com/apache/maven/commit/a1fa3eb5346f562a745f054650eee1e84c44db30?diff=unified]
> if not mistaken.
> The missing instruction being [this
> one|https://github.com/apache/maven/commit/a1fa3eb5346f562a745f054650eee1e84c44db30?diff=unified#diff-b8b814f5b6b3855ae79dc45a0266b94871193dcef42803c316e07409e94af35cL1546].
> *If I add this back on the latest version of master, I am able to collect the
> information.*
> h3. Alternative
> Those properties can be accessed via the
> [session.getUserProperties()|https://maven.apache.org/ref/3.9.3/maven-core/apidocs/org/apache/maven/execution/MavenSession.html#getUserProperties()]
> Please confirm if this is the expected way to collect the data.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Created] (MNG-7829) CLI properties passed with -D are not accessible with session.getSystemProperties()
Jerome Prinet created MNG-7829:
--
Summary: CLI properties passed with -D are not accessible with
session.getSystemProperties()
Key: MNG-7829
URL: https://issues.apache.org/jira/browse/MNG-7829
Project: Maven
Issue Type: Bug
Components: Command Line
Affects Versions: 4.0.0-alpha-7
Reporter: Jerome Prinet
h3. Context
* Maven _4.0.0-alpha-6_ and above
* A Maven extension collecting CLI arguments passed with _-D_
h3. Issue
In a Maven extension, I am collecting CLI arguments which allow to skip tests
if present ({_}skipTests, skipITs, maven.test.skip{_}).
The problem is that since Maven {_}4.0.0-alpha06{_}, these informations are not
part of the
[session.systemProperties|https://maven.apache.org/ref/3.9.3/maven-core/apidocs/org/apache/maven/execution/MavenSession.html#getSystemProperties()]
anymore.
This is working fine until [this
commit|https://github.com/apache/maven/commit/a1fa3eb5346f562a745f054650eee1e84c44db30?diff=unified]
if not mistaken.
The missing instruction being [this
one|https://github.com/apache/maven/commit/a1fa3eb5346f562a745f054650eee1e84c44db30?diff=unified#diff-b8b814f5b6b3855ae79dc45a0266b94871193dcef42803c316e07409e94af35cL1546].
*If I add this back on the latest version of master, I am able to collect the
information.*
h3. Alternative
Those properties can be accessed via the
[session.getUserProperties()|https://maven.apache.org/ref/3.9.3/maven-core/apidocs/org/apache/maven/execution/MavenSession.html#getUserProperties()]
Please confirm if this is the expected way to collect the data.{{{}{}}}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MASSEMBLY-992) Facility to define assembly descriptor in body of POM
[
https://issues.apache.org/jira/browse/MASSEMBLY-992?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17737988#comment-17737988
]
Michael Osipov commented on MASSEMBLY-992:
--
This auto-attaches:
[https://github.com/michael-o/michael-o-parent/blob/7b828415464d4d7bc73ac88d9fba937540982457/pom.xml#L267-L284]
You can create a JAR with your assembly descriptor
This makes it available in the child:
[https://github.com/michael-o/tomcatspnegoad/blob/a22c3a4b0f7bc6592d4fd53268137599d84e6bf5/pom.xml#L101-L125]
Package your descriptor, reference it as a dependency for the plugin in your
child, it is available in you current reactor.
> Facility to define assembly descriptor in body of POM
> -
>
> Key: MASSEMBLY-992
> URL: https://issues.apache.org/jira/browse/MASSEMBLY-992
> Project: Maven Assembly Plugin
> Issue Type: New Feature
>Reporter: Garret Wilson
>Priority: Major
> Fix For: waiting-for-feedback
>
>
> The Maven Assembly Plugin allows custom descriptors to be defined, but only
> in an external file. Please add the capability to define the descriptor in
> the body of the POM itself.
> Requiring a separate descriptor file makes it almost impossible to declare an
> assembly in a parent POM so that it can be inherited by child POMs. The
> documentation describe a way to [share
> descriptors|https://maven.apache.org/plugins/maven-assembly-plugin/examples/sharing-descriptors.html],
> but it is complex and doesn't obviously support Maven property interpolation.
> Without this facility, in order to easily inherit an assembly from a parent
> POM, I'm currently resorting to workaround involving AntRun to generate an
> assembly descriptor on the fly. See [this
> {{pom.xml}}|https://github.com/globalmentor/globalmentor-root/blob/main/pom.xml].
> It's pretty convoluted and tedious to get right. In addition, it has to be
> placed in a phase that is guaranteed to run before the execution of the Maven
> Assembly Plugin itself.
> {code:xml}
>
> org.apache.maven.plugins
> maven-antrun-plugin
>
>
>
> generate-bin-assembly-descriptor
> prepare-package
>
> run
>
>
> ${_isSkipGenerateExe}
>
> encoding="UTF-8">
>
>
>
>
>
>
>
> {code}
> This was requested and finally implemented for Versions Maven Plugin; see
> [#258|https://github.com/mojohaus/versions/issues/258] and
> [#684|https://github.com/mojohaus/versions/issues/684], along with [_Versions
> Maven Plugin rules that are
> inheritable_|https://stackoverflow.com/q/72416739] on Stack Overflow.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Updated] (MPLUGIN-467) Remove reporting from maven-plugin-plugin: create maven-plugin-report-plugin
[
https://issues.apache.org/jira/browse/MPLUGIN-467?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Herve Boutemy updated MPLUGIN-467:
--
Summary: Remove reporting from maven-plugin-plugin: create
maven-plugin-report-plugin (was: Remove reporting from maven-plugin-plugin)
> Remove reporting from maven-plugin-plugin: create maven-plugin-report-plugin
>
>
> Key: MPLUGIN-467
> URL: https://issues.apache.org/jira/browse/MPLUGIN-467
> Project: Maven Plugin Tools
> Issue Type: Task
> Components: Plugin Plugin
>Affects Versions: 3.8.1
>Reporter: Michael Osipov
>Assignee: Michael Osipov
>Priority: Major
> Fix For: 3.9.0
>
>
> The reporting goal of the plugin is deprecated and has been moved to a
> separate plugin. It is supposed to be a drop-in replacement. Time to remove
> it favor of the new {{maven-plugin-report:plugin}}.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
