[jira] [Created] (MPMD-385) Support for --enable-preview
Gili created MPMD-385: - Summary: Support for --enable-preview Key: MPMD-385 URL: https://issues.apache.org/jira/browse/MPMD-385 Project: Maven PMD Plugin Issue Type: Improvement Components: PMD Affects Versions: 3.21.0 Reporter: Gili When running PMD against classes compiled using --enable-preview I get: [WARNING] Error during type resolution of field in class due to: java.lang.UnsupportedClassVersionError: Preview features are not enabled for gg/soulbound/optimus/server/Server (class file version 64.65535). Try running with '--enable-preview' It seems that PMD expects us to pass --enable-preview, but the Maven plugin does not provide a mechanism for doing so. I tried setting targetJdk to "20-preview" but that didn't help either. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [maven] kun-lu20 commented on a diff in pull request #1207: [MNG-7848] Add s390x pipeline to Jenkins CI
kun-lu20 commented on code in PR #1207:
URL: https://github.com/apache/maven/pull/1207#discussion_r1286254437
##
Jenkinsfile.s390x:
##
@@ -0,0 +1,173 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+properties([buildDiscarder(logRotator(artifactNumToKeepStr: '5', numToKeepStr:
env.BRANCH_NAME=='master'?'5':'1'))])
+
+def buildOs = 'linux'
+def buildJdk = '8'
+def buildMvn = '3.8.x'
+def runITsOses = ['linux']
+def runITsJdks = ['11', '17']
+def runITsMvn = '3.8.x'
+def runITscommand = "mvn clean install -Prun-its,embedded -B -U -V" //
-DmavenDistro=... -Dmaven.test.failure.ignore=true
+def tests
+
+try {
+
+def osNode = jenkinsEnv.labelForOS(buildOs)
+node('s390x') {
+dir('build') {
+stage('Checkout') {
+checkout scm
+}
+
+def WORK_DIR=pwd()
+def MAVEN_GOAL='verify'
+
+stage('Configure deploy') {
Review Comment:
Sure, thanks for pointing out! Will open a new PR to remove it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Commented] (MNG-7848) Add s390x pipeline to Jenkins CI
[
https://issues.apache.org/jira/browse/MNG-7848?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17751770#comment-17751770
]
ASF GitHub Bot commented on MNG-7848:
-
kun-lu20 commented on code in PR #1207:
URL: https://github.com/apache/maven/pull/1207#discussion_r1286254437
##
Jenkinsfile.s390x:
##
@@ -0,0 +1,173 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+properties([buildDiscarder(logRotator(artifactNumToKeepStr: '5', numToKeepStr:
env.BRANCH_NAME=='master'?'5':'1'))])
+
+def buildOs = 'linux'
+def buildJdk = '8'
+def buildMvn = '3.8.x'
+def runITsOses = ['linux']
+def runITsJdks = ['11', '17']
+def runITsMvn = '3.8.x'
+def runITscommand = "mvn clean install -Prun-its,embedded -B -U -V" //
-DmavenDistro=... -Dmaven.test.failure.ignore=true
+def tests
+
+try {
+
+def osNode = jenkinsEnv.labelForOS(buildOs)
+node('s390x') {
+dir('build') {
+stage('Checkout') {
+checkout scm
+}
+
+def WORK_DIR=pwd()
+def MAVEN_GOAL='verify'
+
+stage('Configure deploy') {
Review Comment:
Sure, thanks for pointing out! Will open a new PR to remove it.
> Add s390x pipeline to Jenkins CI
>
>
> Key: MNG-7848
> URL: https://issues.apache.org/jira/browse/MNG-7848
> Project: Maven
> Issue Type: New Feature
> Components: Bootstrap Build, Integration Tests
>Reporter: Kun Lu
>Priority: Major
> Labels: pull-request-available
>
> Apache INFRA team has installed necessary JDK flavours on all s390x nodes
> (Please check issue
> [https://issues.apache.org/jira/projects/INFRA/issues/INFRA-24781]). We’d
> like to add the s390x pipeline to Jenkins CI by raising a PR to add `
> Jenkinsfile.s390x` to the Maven code base.
> Can anyone from Maven team help us review the PR and create the s390x
> pipeline on Jenkins? Thanks!
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MNG-7848) Add s390x pipeline to Jenkins CI
[ https://issues.apache.org/jira/browse/MNG-7848?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17751765#comment-17751765 ] ASF GitHub Bot commented on MNG-7848: - kun-lu20 commented on PR #1213: URL: https://github.com/apache/maven/pull/1213#issuecomment-1668362161 Hi @olamy , Thanks for pointing out! I'll raise a new PR to address it. > Add s390x pipeline to Jenkins CI > > > Key: MNG-7848 > URL: https://issues.apache.org/jira/browse/MNG-7848 > Project: Maven > Issue Type: New Feature > Components: Bootstrap Build, Integration Tests >Reporter: Kun Lu >Priority: Major > Labels: pull-request-available > > Apache INFRA team has installed necessary JDK flavours on all s390x nodes > (Please check issue > [https://issues.apache.org/jira/projects/INFRA/issues/INFRA-24781]). We’d > like to add the s390x pipeline to Jenkins CI by raising a PR to add ` > Jenkinsfile.s390x` to the Maven code base. > Can anyone from Maven team help us review the PR and create the s390x > pipeline on Jenkins? Thanks! -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [maven] kun-lu20 commented on pull request #1213: [MNG-7848] Change the notification recipients in s390x pipeline
kun-lu20 commented on PR #1213: URL: https://github.com/apache/maven/pull/1213#issuecomment-1668362161 Hi @olamy , Thanks for pointing out! I'll raise a new PR to address it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MBUILDCACHE-64) Apply global exclusions to folder names
[
https://issues.apache.org/jira/browse/MBUILDCACHE-64?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17751751#comment-17751751
]
ASF GitHub Bot commented on MBUILDCACHE-64:
---
kbuntrock commented on PR #91:
URL:
https://github.com/apache/maven-build-cache-extension/pull/91#issuecomment-1668279033
Changed the exclude mechanism to use path matchers. A bit more than a bugfix
now, feedbacks appreciated if you see any lack, implementation detail you
disagree with or extra test case to add.
> Apply global exclusions to folder names
> ---
>
> Key: MBUILDCACHE-64
> URL: https://issues.apache.org/jira/browse/MBUILDCACHE-64
> Project: Maven Build Cache Extension
> Issue Type: Bug
>Affects Versions: 1.0.1
>Reporter: Frank Wagner
>Assignee: Olivier Lamy
>Priority: Major
> Labels: pull-request-available
> Fix For: 1.1.0
>
>
> It is currently not possible to exclude folders by their name, like
> {quote}
>
>
> node_modules
> dist
> build
>
>
> ...
> {quote}
> That's because isFilteredOutSubpath(),
> [https://github.com/apache/maven-build-cache-extension/blob/master/src/main/java/org/apache/maven/buildcache/checksum/MavenProjectInput.java#L638,]
> uses startWith on normalized absolute paths.
> That function could be enhanced with an additional criterion like in
> [https://github.com/apache/maven-build-cache-extension/blob/master/src/main/java/org/apache/maven/buildcache/checksum/MavenProjectInput.java#L510]
> {{filteredOutPaths.stream().anyMatch(it ->
> it.getFileName().equals(entry.getFileName()))}}
>
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[GitHub] [maven-build-cache-extension] kbuntrock commented on pull request #91: [MBUILDCACHE-64] Exclusion mechanism bugfix
kbuntrock commented on PR #91: URL: https://github.com/apache/maven-build-cache-extension/pull/91#issuecomment-1668279033 Changed the exclude mechanism to use path matchers. A bit more than a bugfix now, feedbacks appreciated if you see any lack, implementation detail you disagree with or extra test case to add. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MBUILDCACHE-64) Apply global exclusions to folder names
[
https://issues.apache.org/jira/browse/MBUILDCACHE-64?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17751749#comment-17751749
]
ASF GitHub Bot commented on MBUILDCACHE-64:
---
kbuntrock commented on code in PR #91:
URL:
https://github.com/apache/maven-build-cache-extension/pull/91#discussion_r1286165121
##
src/main/java/org/apache/maven/buildcache/checksum/MavenProjectInput.java:
##
@@ -108,11 +107,6 @@ public class MavenProjectInput {
* property name to pass glob value. The glob to be used to list directory
files in plugins scanning
*/
private static final String CACHE_INPUT_GLOB_NAME =
"maven.build.cache.input.glob";
-/**
- * default glob, bbsdk/abfx specific
- */
-public static final String DEFAULT_GLOB =
"{*.java,*.groovy,*.yaml,*.svcd,*.proto,*assembly.xml,assembly"
Review Comment:
Was not used except in a UT.
##
src/test/java/org/apache/maven/buildcache/checksum/MavenProjectInputTest.java:
##
@@ -47,52 +47,23 @@
public class MavenProjectInputTest {
-private static final String GLOB = "{*-pom.xml}";
+private static final String DEFAULT_GLOB = "*";
@Test
-public void testAddInputsRelativePath() {
-//MavenProjectInput inputs = new MavenProjectInput(config, new
ArrayList(),
-// Paths.get("src\\test\\resources\\org"), GLOB);
-//ArrayList files = new ArrayList<>();
-//inputs.listDirOrFile("../../resources", inputs.dirGlob,
files, new HashSet());
-//assertEquals(4, files.size());
-}
-
-@Test
-public void testAddInputsAbsolutePath() {
-//Path baseDirPath = Paths.get("src\\test\\resources\\org");
-//MavenProjectInput inputs = new MavenProjectInput(config, new
ArrayList(), baseDirPath, GLOB);
-//ArrayList files = new ArrayList<>();
-//Path candidatePath =
baseDirPath.resolve("../../resources").normalize().toAbsolutePath();
-//inputs.listDirOrFile(candidatePath.toString(),
inputs.dirGlob, files, new HashSet());
-//assertEquals(4, files.size()); // pom is filtered out by
hardcoded if
-}
-
-@Test
-public void testGlobInput() {
-//Path baseDirPath = Paths.get("src\\test\\resources");
-//MavenProjectInput inputs = new MavenProjectInput(config, new
ArrayList(), baseDirPath, GLOB);
-//ArrayList files = new ArrayList<>();
-//inputs.tryAddInputs("*.java", files, new HashSet());
-//assertEquals(0, files.size()); // pom is filtered out by
hardcoded if
-}
-
-@Test
-public void testGetDirectoryFiles() {
-List directoryFiles = new ArrayList<>();
+public void testCollectFilteredFiles() {
Review Comment:
Cleaned dead code and updated a test with a wrong assumption. Not the most
useful test but better than before.
##
src/main/java/org/apache/maven/buildcache/checksum/MavenProjectInput.java:
##
@@ -165,45 +184,94 @@ public MavenProjectInput(
this.repoSystem = repoSystem;
this.remoteCache = remoteCache;
Properties properties = project.getProperties();
-this.dirGlob = properties.getProperty(CACHE_INPUT_GLOB_NAME,
config.getDefaultGlob());
+this.defaultFilenameGlob =
properties.getProperty(CACHE_INPUT_GLOB_NAME, config.getDefaultGlob());
this.processPlugins =
Boolean.parseBoolean(properties.getProperty(CACHE_PROCESS_PLUGINS,
config.isProcessPlugins()));
this.tmpDir = System.getProperty("java.io.tmpdir");
+this.baseDirectoryGlob = baseDirPath.toString().replace("\\", "/") +
"/";
+
org.apache.maven.model.Build build = project.getBuild();
-filteredOutPaths = new ArrayList<>(Arrays.asList(
-normalizedPath(build.getDirectory()), // target by default
-normalizedPath(build.getOutputDirectory()),
-normalizedPath(build.getTestOutputDirectory(;
+addToExcludedSection(
+convertToPathMatcherFileSeperator(
+
normalizedPath(build.getDirectory()).toString())
++ GLOB_SX_ALL_SUB_FILES,
+false); // target by default
+addToExcludedSection(
+convertToPathMatcherFileSeperator(
+
normalizedPath(build.getOutputDirectory()).toString())
++ GLOB_SX_ALL_SUB_FILES,
+false); // target/classes by default
+addToExcludedSection(
+convertToPathMatcherFileSeperator(
+
normalizedPath(build.getTestOutputDirectory()).toString())
++ GLOB_SX_ALL_SUB_FILES,
+false); // target/test-classes by default
List excludes =
[GitHub] [maven-build-cache-extension] kbuntrock commented on a diff in pull request #91: [MBUILDCACHE-64] Exclusion mechanism bugfix
kbuntrock commented on code in PR #91:
URL:
https://github.com/apache/maven-build-cache-extension/pull/91#discussion_r1286165121
##
src/main/java/org/apache/maven/buildcache/checksum/MavenProjectInput.java:
##
@@ -108,11 +107,6 @@ public class MavenProjectInput {
* property name to pass glob value. The glob to be used to list directory
files in plugins scanning
*/
private static final String CACHE_INPUT_GLOB_NAME =
"maven.build.cache.input.glob";
-/**
- * default glob, bbsdk/abfx specific
- */
-public static final String DEFAULT_GLOB =
"{*.java,*.groovy,*.yaml,*.svcd,*.proto,*assembly.xml,assembly"
Review Comment:
Was not used except in a UT.
##
src/test/java/org/apache/maven/buildcache/checksum/MavenProjectInputTest.java:
##
@@ -47,52 +47,23 @@
public class MavenProjectInputTest {
-private static final String GLOB = "{*-pom.xml}";
+private static final String DEFAULT_GLOB = "*";
@Test
-public void testAddInputsRelativePath() {
-//MavenProjectInput inputs = new MavenProjectInput(config, new
ArrayList(),
-// Paths.get("src\\test\\resources\\org"), GLOB);
-//ArrayList files = new ArrayList<>();
-//inputs.listDirOrFile("../../resources", inputs.dirGlob,
files, new HashSet());
-//assertEquals(4, files.size());
-}
-
-@Test
-public void testAddInputsAbsolutePath() {
-//Path baseDirPath = Paths.get("src\\test\\resources\\org");
-//MavenProjectInput inputs = new MavenProjectInput(config, new
ArrayList(), baseDirPath, GLOB);
-//ArrayList files = new ArrayList<>();
-//Path candidatePath =
baseDirPath.resolve("../../resources").normalize().toAbsolutePath();
-//inputs.listDirOrFile(candidatePath.toString(),
inputs.dirGlob, files, new HashSet());
-//assertEquals(4, files.size()); // pom is filtered out by
hardcoded if
-}
-
-@Test
-public void testGlobInput() {
-//Path baseDirPath = Paths.get("src\\test\\resources");
-//MavenProjectInput inputs = new MavenProjectInput(config, new
ArrayList(), baseDirPath, GLOB);
-//ArrayList files = new ArrayList<>();
-//inputs.tryAddInputs("*.java", files, new HashSet());
-//assertEquals(0, files.size()); // pom is filtered out by
hardcoded if
-}
-
-@Test
-public void testGetDirectoryFiles() {
-List directoryFiles = new ArrayList<>();
+public void testCollectFilteredFiles() {
Review Comment:
Cleaned dead code and updated a test with a wrong assumption. Not the most
useful test but better than before.
##
src/main/java/org/apache/maven/buildcache/checksum/MavenProjectInput.java:
##
@@ -165,45 +184,94 @@ public MavenProjectInput(
this.repoSystem = repoSystem;
this.remoteCache = remoteCache;
Properties properties = project.getProperties();
-this.dirGlob = properties.getProperty(CACHE_INPUT_GLOB_NAME,
config.getDefaultGlob());
+this.defaultFilenameGlob =
properties.getProperty(CACHE_INPUT_GLOB_NAME, config.getDefaultGlob());
this.processPlugins =
Boolean.parseBoolean(properties.getProperty(CACHE_PROCESS_PLUGINS,
config.isProcessPlugins()));
this.tmpDir = System.getProperty("java.io.tmpdir");
+this.baseDirectoryGlob = baseDirPath.toString().replace("\\", "/") +
"/";
+
org.apache.maven.model.Build build = project.getBuild();
-filteredOutPaths = new ArrayList<>(Arrays.asList(
-normalizedPath(build.getDirectory()), // target by default
-normalizedPath(build.getOutputDirectory()),
-normalizedPath(build.getTestOutputDirectory(;
+addToExcludedSection(
+convertToPathMatcherFileSeperator(
+
normalizedPath(build.getDirectory()).toString())
++ GLOB_SX_ALL_SUB_FILES,
+false); // target by default
+addToExcludedSection(
+convertToPathMatcherFileSeperator(
+
normalizedPath(build.getOutputDirectory()).toString())
++ GLOB_SX_ALL_SUB_FILES,
+false); // target/classes by default
+addToExcludedSection(
+convertToPathMatcherFileSeperator(
+
normalizedPath(build.getTestOutputDirectory()).toString())
++ GLOB_SX_ALL_SUB_FILES,
+false); // target/test-classes by default
List excludes = config.getGlobalExcludePaths();
for (Exclude excludePath : excludes) {
-filteredOutPaths.add(Paths.get(excludePath.getValue()));
+addToExcludedSection(excludePath.getValue(), true);
}
for (String
[jira] [Commented] (MJAR-275) outputTimestamp not applied to module-info; breaks reproducible builds
[
https://issues.apache.org/jira/browse/MJAR-275?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17751541#comment-17751541
]
Herve Boutemy commented on MJAR-275:
MJAR-295 created to track this JDK patch version in module-info.class, even if
not sure that the. workaround is best done in m-jar-p. or m-compiler-p
> outputTimestamp not applied to module-info; breaks reproducible builds
> --
>
> Key: MJAR-275
> URL: https://issues.apache.org/jira/browse/MJAR-275
> Project: Maven JAR Plugin
> Issue Type: Bug
>Affects Versions: 3.2.0
> Environment: Mac OS X 10.14.6
> JDK 15 (build 15+36)
> JDK 11 (build 11.0.8+10)
>Reporter: Anand Beh
>Assignee: Slawomir Jaranowski
>Priority: Minor
> Fix For: 3.3.0
>
> Attachments: MCOMPILER-439.zip, Screenshot 2020-10-25 at 2.35.59
> PM.png
>
>
> Setting {{project.build.outputTimestamp}} to a fixed value allows creating
> reproducible builds per this guide:
> [https://maven.apache.org/guides/mini/guide-reproducible-builds.html
> |https://maven.apache.org/guides/mini/guide-reproducible-builds.html]However,
> if one adds a module-info file to the project, reproducible builds break.
> This is caused by module-info.class using the latest timestamp and not
> {{project.build.outputTimestamp}}. I was able to identify the problem using
> diffoscope: [https://diffoscope.org/.|https://diffoscope.org/] With it I
> determined the timestamp across 2 builds was constant for all but the
> module-info.class:
>
> {code:java}
> -rw 2.0 fat 862 bl defN 20-Oct-17 00:40
> space/arim/libertybans/api/select/SelectionOrder.class
> │ -rw 2.0 fat 1113 bl defN 20-Oct-17 00:40
> space/arim/libertybans/api/select/SelectionOrderBuilder.class
> │ -rw 2.0 fat 2285 bl defN 20-Oct-17 00:40
> META-INF/maven/space.arim.libertybans/bans-api/pom.xml
> │ -rw 2.0 fat 74 bl defN 20-Oct-17 00:40
> META-INF/maven/space.arim.libertybans/bans-api/pom.properties
> │ --rw 2.0 fat 557 bl defN 20-Oct-25 12:39 module-info.class
> │ +-rw 2.0 fat 557 bl defN 20-Oct-25 12:41 module-info.class
> {code}
>
> Note the + and - which are diffoscope's way of indicating the difference
> between the .jar files. Here the {{project.build.outputTimestamp}} is on 17
> October. As shown, module-info has a "rebellious" timestamp.
>
> *EDIT:*
> Example project to reproduce the bug:
> [https://github.com/A248/MJAR-275|https://github.com/A248/MCOMPILER-439]
> (Renamed from [https://github.com/A248/MCOMPILER-439])
> Source code is also provided as an attachment below
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Created] (MJAR-295) clean JDK patch version in module-info.class
Herve Boutemy created MJAR-295: -- Summary: clean JDK patch version in module-info.class Key: MJAR-295 URL: https://issues.apache.org/jira/browse/MJAR-295 Project: Maven JAR Plugin Issue Type: Improvement Affects Versions: 3.3.0 Reporter: Herve Boutemy as seen in MJAR-275, JDK patch version in module-info.class is not included only when building with a newer JDK release using "--release" flag, see https://github.com/jvm-repo-rebuild/module-info we need an issue in JDK to get a proper fix and waiting for. that, we need a workaround to drop the JDK patch version in other cases: we'll need to define were is the best place -- m-jar-p?m-compiler-p? other? -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [maven-build-cache-extension] dependabot[bot] opened a new pull request, #95: Bump ch.qos.logback:logback-classic from 1.3.7 to 1.3.9
dependabot[bot] opened a new pull request, #95: URL: https://github.com/apache/maven-build-cache-extension/pull/95 Bumps [ch.qos.logback:logback-classic](https://github.com/qos-ch/logback) from 1.3.7 to 1.3.9. Commits https://github.com/qos-ch/logback/commit/73f99846f27b4093bb285bedb1e578fd45771ff2;>73f9984 prepare release 1.3.9 https://github.com/qos-ch/logback/commit/9499401a0dfced4c9b70ce6af493173f00e1a66f;>9499401 fix TimeBasedRollingWithConfigFileTest.timeAndSize https://github.com/qos-ch/logback/commit/54c23fe2591bbb921bcafb736009984b4d4731ce;>54c23fe Merge branch 'branch_1.3.x' of github.com:qos-ch/logback into branch_1.3.x https://github.com/qos-ch/logback/commit/fbe45c6eb5d08d0bc662aee17bde0f1301a1bf12;>fbe45c6 LOGABCK-1717 configuirators shipping with logback-classic are instantiated vi... https://github.com/qos-ch/logback/commit/e69ed4da27f829e6cae07995196a0bd8a3d3e401;>e69ed4d fix typo in property name https://github.com/qos-ch/logback/commit/45c140d795f7a456b36771fd6c29d2466ccbf078;>45c140d enhance provides directive in module-info https://github.com/qos-ch/logback/commit/e2f6ef59e0ef0cbd17dd5b321401a9378df578d5;>e2f6ef5 ongoing work on GraalVM support https://github.com/qos-ch/logback/commit/0d16784f5f659f638cd9cea615dc2fe98f2733cb;>0d16784 Change LoggerContet to use MDCAdapter instead of LogbackMDCAdapter , partial ... https://github.com/qos-ch/logback/commit/950cbdfeaa37479891fe7fc24beb213faee8d061;>950cbdf [LOGBACK-1754] fixed use of CountDownLatch https://github.com/qos-ch/logback/commit/42e0355d1c2e95e3f03b98ed6ffe7594ccd8c74f;>42e0355 Change LoggerContet to use MDCAdapter instead of LogbackMDCAdapter , partial ... Additional commits viewable in https://github.com/qos-ch/logback/compare/v_1.3.7...v_1.3.9;>compare view [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MRESOLVER-324) Make the BF algorithm as the default option to speed up maven dependency resolution and downloading
[
https://issues.apache.org/jira/browse/MRESOLVER-324?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17751484#comment-17751484
]
ASF GitHub Bot commented on MRESOLVER-324:
--
cstamas commented on PR #325:
URL: https://github.com/apache/maven-resolver/pull/325#issuecomment-1667284980
We need to branch off 1.9.x first, then master made into 2.0.0...
> Make the BF algorithm as the default option to speed up maven dependency
> resolution and downloading
> ---
>
> Key: MRESOLVER-324
> URL: https://issues.apache.org/jira/browse/MRESOLVER-324
> Project: Maven Resolver
> Issue Type: Wish
> Components: Resolver
>Affects Versions: 2.0.0
>Reporter: wei cai
>Priority: Major
> Fix For: 2.0.0
>
>
> This is a WISH type Jira :D. So far, Maven 3.9.0 has released a BF algorithm
> which includes changes from below JIRAs along with the DF option (default).
> * MRESOLVER-228
> * MRESOLVER-247
> * MRESOLVER-7
> The BF algorithm solves:
> * Cache missing issue when comes to resolve heavy dependencies with
> different exclusions, it can help speed up dependency resolution especially
> for large scale enterprise level projects.
> * Improve download speed by:
> ** Skip downloading poms for conflict losers.
> ** Download poms in parallel.
> Below is the introduction in
> [https://maven.apache.org/docs/3.9.0/release-notes.html:]
> {noformat}
> Choice of resolver collectors: a new BF collector (with parallel POM
> downloads) has been added along the existing DF one.{noformat}
> The solution is already widely adopted at eBay. You can simply enable it by
> putting below config item into file: ${maven.projectBasedir}/.mvn/maven.config
> {code:java}
> aether.dependencyCollector.impl=bf {code}
> More introduction about this option:
> [https://maven.apache.org/resolver/configuration.html]
> Please try and tells us how much it helps by running:
> {code:java}
> 1. mvn clean install -DskipTests -Dmaven.repo.local=bf
> -Daether.dependencyCollector.impl=bf
> 2. mvn clean install -DskipTests -Dmaven.repo.local=df{code}
> With more feedback collected, we would be able to propose the changes to
> Maven team to make BF as the default.
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[GitHub] [maven-resolver] cstamas commented on pull request #325: [MRESOLVER-324] Make bf option as default
cstamas commented on PR #325: URL: https://github.com/apache/maven-resolver/pull/325#issuecomment-1667284980 We need to branch off 1.9.x first, then master made into 2.0.0... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MRESOLVER-324) Make the BF algorithm as the default option to speed up maven dependency resolution and downloading
[
https://issues.apache.org/jira/browse/MRESOLVER-324?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17751461#comment-17751461
]
ASF GitHub Bot commented on MRESOLVER-324:
--
caiwei-ebay opened a new pull request, #325:
URL: https://github.com/apache/maven-resolver/pull/325
(no comment)
> Make the BF algorithm as the default option to speed up maven dependency
> resolution and downloading
> ---
>
> Key: MRESOLVER-324
> URL: https://issues.apache.org/jira/browse/MRESOLVER-324
> Project: Maven Resolver
> Issue Type: Wish
> Components: Resolver
>Affects Versions: 2.0.0
>Reporter: wei cai
>Priority: Major
> Fix For: 2.0.0
>
>
> This is a WISH type Jira :D. So far, Maven 3.9.0 has released a BF algorithm
> which includes changes from below JIRAs along with the DF option (default).
> * MRESOLVER-228
> * MRESOLVER-247
> * MRESOLVER-7
> The BF algorithm solves:
> * Cache missing issue when comes to resolve heavy dependencies with
> different exclusions, it can help speed up dependency resolution especially
> for large scale enterprise level projects.
> * Improve download speed by:
> ** Skip downloading poms for conflict losers.
> ** Download poms in parallel.
> Below is the introduction in
> [https://maven.apache.org/docs/3.9.0/release-notes.html:]
> {noformat}
> Choice of resolver collectors: a new BF collector (with parallel POM
> downloads) has been added along the existing DF one.{noformat}
> The solution is already widely adopted at eBay. You can simply enable it by
> putting below config item into file: ${maven.projectBasedir}/.mvn/maven.config
> {code:java}
> aether.dependencyCollector.impl=bf {code}
> More introduction about this option:
> [https://maven.apache.org/resolver/configuration.html]
> Please try and tells us how much it helps by running:
> {code:java}
> 1. mvn clean install -DskipTests -Dmaven.repo.local=bf
> -Daether.dependencyCollector.impl=bf
> 2. mvn clean install -DskipTests -Dmaven.repo.local=df{code}
> With more feedback collected, we would be able to propose the changes to
> Maven team to make BF as the default.
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
