[jira] [Closed] (MNG-7908) Drop use of ServiceLocator
[ https://issues.apache.org/jira/browse/MNG-7908?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tamas Cservenak closed MNG-7908. Resolution: Fixed > Drop use of ServiceLocator > -- > > Key: MNG-7908 > URL: https://issues.apache.org/jira/browse/MNG-7908 > Project: Maven > Issue Type: Task > Components: Artifacts and Repositories >Reporter: Tamas Cservenak >Assignee: Tamas Cservenak >Priority: Major > > Drop use of SL in maven-resolver-provider -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Assigned] (MNG-7908) Drop use of ServiceLocator
[ https://issues.apache.org/jira/browse/MNG-7908?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tamas Cservenak reassigned MNG-7908: Assignee: Guillaume Nodet (was: Tamas Cservenak) > Drop use of ServiceLocator > -- > > Key: MNG-7908 > URL: https://issues.apache.org/jira/browse/MNG-7908 > Project: Maven > Issue Type: Task > Components: Artifacts and Repositories >Reporter: Tamas Cservenak >Assignee: Guillaume Nodet >Priority: Major > > Drop use of SL in maven-resolver-provider -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Comment Edited] (MNG-7908) Drop use of ServiceLocator
[ https://issues.apache.org/jira/browse/MNG-7908?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17775326#comment-17775326 ] Tamas Cservenak edited comment on MNG-7908 at 10/14/23 10:59 PM: - done as https://github.com/apache/maven/commit/1ab49b349f40867350e3e09f27074628d5b34af9 happened in 4.0.0-alpha-1 was (Author: cstamas): done as https://github.com/apache/maven/commit/1ab49b349f40867350e3e09f27074628d5b34af9 > Drop use of ServiceLocator > -- > > Key: MNG-7908 > URL: https://issues.apache.org/jira/browse/MNG-7908 > Project: Maven > Issue Type: Task > Components: Artifacts and Repositories >Reporter: Tamas Cservenak >Assignee: Tamas Cservenak >Priority: Major > > Drop use of SL in maven-resolver-provider -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (MNG-7908) Drop use of ServiceLocator
[ https://issues.apache.org/jira/browse/MNG-7908?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tamas Cservenak updated MNG-7908: - Fix Version/s: (was: 4.0.0-alpha-8) > Drop use of ServiceLocator > -- > > Key: MNG-7908 > URL: https://issues.apache.org/jira/browse/MNG-7908 > Project: Maven > Issue Type: Task > Components: Artifacts and Repositories >Reporter: Tamas Cservenak >Assignee: Tamas Cservenak >Priority: Major > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MNG-7908) Drop use of ServiceLocator
[ https://issues.apache.org/jira/browse/MNG-7908?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17775326#comment-17775326 ] Tamas Cservenak commented on MNG-7908: -- done as https://github.com/apache/maven/commit/1ab49b349f40867350e3e09f27074628d5b34af9 > Drop use of ServiceLocator > -- > > Key: MNG-7908 > URL: https://issues.apache.org/jira/browse/MNG-7908 > Project: Maven > Issue Type: Task > Components: Artifacts and Repositories >Reporter: Tamas Cservenak >Assignee: Tamas Cservenak >Priority: Major > Fix For: 4.0.0-alpha-8 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (MNG-7908) Drop use of ServiceLocator
[ https://issues.apache.org/jira/browse/MNG-7908?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tamas Cservenak updated MNG-7908: - Description: Drop use of SL in maven-resolver-provider > Drop use of ServiceLocator > -- > > Key: MNG-7908 > URL: https://issues.apache.org/jira/browse/MNG-7908 > Project: Maven > Issue Type: Task > Components: Artifacts and Repositories >Reporter: Tamas Cservenak >Assignee: Tamas Cservenak >Priority: Major > > Drop use of SL in maven-resolver-provider -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MNG-7909) Upgrade to Resolver 2.0.0
[ https://issues.apache.org/jira/browse/MNG-7909?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17775321#comment-17775321 ] ASF GitHub Bot commented on MNG-7909: - cstamas opened a new pull request, #1282: URL: https://github.com/apache/maven/pull/1282 This is WIP, but just to see does it work. UTs were using nasty "def ctor" that creates EMPTY/unusable system, and that ctor is gone (was there due SL). Replaced by mocks, as RepositorySystem is not really needed in these tests. --- https://issues.apache.org/jira/browse/MNG-7909 > Upgrade to Resolver 2.0.0 > - > > Key: MNG-7909 > URL: https://issues.apache.org/jira/browse/MNG-7909 > Project: Maven > Issue Type: Dependency upgrade > Components: Artifacts and Repositories >Reporter: Tamas Cservenak >Priority: Major > Fix For: 4.0.x-candidate > > > Post alpha-8 a release of Resolver 2.0.0 (depending on other work, like > transport) becomes possible, so upgrade as well. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[PR] [MNG-7909] Upgrade to Resolver 2.0.0 [maven]
cstamas opened a new pull request, #1282: URL: https://github.com/apache/maven/pull/1282 This is WIP, but just to see does it work. UTs were using nasty "def ctor" that creates EMPTY/unusable system, and that ctor is gone (was there due SL). Replaced by mocks, as RepositorySystem is not really needed in these tests. --- https://issues.apache.org/jira/browse/MNG-7909 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (MNG-7909) Upgrade to Resolver 2.0.0
[ https://issues.apache.org/jira/browse/MNG-7909?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tamas Cservenak updated MNG-7909: - Description: Post alpha-8 a release of Resolver 2.0.0 (depending on other work, like transport) becomes possible, so upgrade as well. (was: Post alpha-8 a release of Resolver 2.0.0 (depending on other work) becomes possible, so upgrade as well.) > Upgrade to Resolver 2.0.0 > - > > Key: MNG-7909 > URL: https://issues.apache.org/jira/browse/MNG-7909 > Project: Maven > Issue Type: Dependency upgrade > Components: Artifacts and Repositories >Reporter: Tamas Cservenak >Priority: Major > Fix For: 4.0.x-candidate > > > Post alpha-8 a release of Resolver 2.0.0 (depending on other work, like > transport) becomes possible, so upgrade as well. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (MNG-7909) Upgrade to Resolver 2.0.0
Tamas Cservenak created MNG-7909: Summary: Upgrade to Resolver 2.0.0 Key: MNG-7909 URL: https://issues.apache.org/jira/browse/MNG-7909 Project: Maven Issue Type: Dependency upgrade Components: Artifacts and Repositories Reporter: Tamas Cservenak Fix For: 4.0.x-candidate Post alpha-8 a release of Resolver 2.0.0 (depending on other work) becomes possible, so upgrade as well. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Assigned] (MRESOLVER-411) Update to Maven 4.0.0-alpha-7
[ https://issues.apache.org/jira/browse/MRESOLVER-411?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tamas Cservenak reassigned MRESOLVER-411: - Assignee: Tamas Cservenak > Update to Maven 4.0.0-alpha-7 > - > > Key: MRESOLVER-411 > URL: https://issues.apache.org/jira/browse/MRESOLVER-411 > Project: Maven Resolver > Issue Type: Task > Components: Resolver >Reporter: Tamas Cservenak >Assignee: Tamas Cservenak >Priority: Major > Fix For: 2.0.0 > > > And get rid of deprecations and TODOs in supplier (possible once alpha-8 is > out). -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (MRESOLVER-411) Update to Maven 4.0.0-alpha-7
Tamas Cservenak created MRESOLVER-411: - Summary: Update to Maven 4.0.0-alpha-7 Key: MRESOLVER-411 URL: https://issues.apache.org/jira/browse/MRESOLVER-411 Project: Maven Resolver Issue Type: Task Components: Resolver Reporter: Tamas Cservenak Fix For: 2.0.0 And get rid of deprecations and TODOs in supplier (possible once alpha-8 is out). -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (MRESOLVER-407) Upgrade to Maven 3.9.5
[ https://issues.apache.org/jira/browse/MRESOLVER-407?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tamas Cservenak updated MRESOLVER-407: -- Component/s: Resolver > Upgrade to Maven 3.9.5 > -- > > Key: MRESOLVER-407 > URL: https://issues.apache.org/jira/browse/MRESOLVER-407 > Project: Maven Resolver > Issue Type: Task > Components: Resolver >Reporter: Tamas Cservenak >Assignee: Tamas Cservenak >Priority: Major > Fix For: 2.0.0, 1.9.x > > > And get rid of deprecations and TODOs in supplier. > Note: this change may go into subsequent 1.x release as well, if happens. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (MRESOLVER-407) Upgrade to Maven 3.9.5
[ https://issues.apache.org/jira/browse/MRESOLVER-407?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tamas Cservenak updated MRESOLVER-407: -- Fix Version/s: (was: 2.0.0) > Upgrade to Maven 3.9.5 > -- > > Key: MRESOLVER-407 > URL: https://issues.apache.org/jira/browse/MRESOLVER-407 > Project: Maven Resolver > Issue Type: Task > Components: Resolver >Reporter: Tamas Cservenak >Assignee: Tamas Cservenak >Priority: Major > Fix For: 1.9.x > > > And get rid of deprecations and TODOs in supplier. > Note: this change may go into subsequent 1.x release as well, if happens. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (MRESOLVER-408) Prepare for 2.0.0 version
[ https://issues.apache.org/jira/browse/MRESOLVER-408?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tamas Cservenak updated MRESOLVER-408: -- Component/s: Resolver > Prepare for 2.0.0 version > - > > Key: MRESOLVER-408 > URL: https://issues.apache.org/jira/browse/MRESOLVER-408 > Project: Maven Resolver > Issue Type: Task > Components: Resolver >Reporter: Tamas Cservenak >Assignee: Tamas Cservenak >Priority: Major > Fix For: 2.0.0 > > > Preparations and version change for 2.x of resolver -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (MRESOLVER-409) Drop various deprecated methods and classes
[ https://issues.apache.org/jira/browse/MRESOLVER-409?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tamas Cservenak updated MRESOLVER-409: -- Component/s: Resolver > Drop various deprecated methods and classes > --- > > Key: MRESOLVER-409 > URL: https://issues.apache.org/jira/browse/MRESOLVER-409 > Project: Maven Resolver > Issue Type: Task > Components: Resolver >Reporter: Tamas Cservenak >Assignee: Tamas Cservenak >Priority: Major > Fix For: 2.0.0 > > > We have quite some sprinkled deprecations across codebase, drop them. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (MRESOLVER-392) Resolver installer should not be "smart" about installs
[ https://issues.apache.org/jira/browse/MRESOLVER-392?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tamas Cservenak updated MRESOLVER-392: -- Component/s: Resolver > Resolver installer should not be "smart" about installs > --- > > Key: MRESOLVER-392 > URL: https://issues.apache.org/jira/browse/MRESOLVER-392 > Project: Maven Resolver > Issue Type: Bug > Components: Resolver >Reporter: Tamas Cservenak >Priority: Major > Fix For: 2.0.0 > > > Seems in some cases (equality by timestamp and file size) DefaultInstaller > will NOT install the requested file, and log this fact on DEBUG level. > This is wrong: resolver should NOT be "smart" in this case. IMO, if "install > request" flies it, resolver should install unconditionally. > Or, maybe perform some more checks, and refuse install in case like: > * release artifact that is already present in local repository? -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (MRESOLVER-295) Split FileProcessor into ChecksumProcessor and PathProcessor
[ https://issues.apache.org/jira/browse/MRESOLVER-295?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tamas Cservenak updated MRESOLVER-295: -- Component/s: Resolver > Split FileProcessor into ChecksumProcessor and PathProcessor > > > Key: MRESOLVER-295 > URL: https://issues.apache.org/jira/browse/MRESOLVER-295 > Project: Maven Resolver > Issue Type: Task > Components: Resolver >Reporter: Tamas Cservenak >Priority: Major > Fix For: 2.0.0 > > > The FileProcessor should become obsolete. > Instead, split this component in two: ChecksumProcessor and PathProcessor. > PathProcessor should be doing what currently FileUtils are doing, but as a > component. Maybe extended with DirectoryUtils functionality? (so component > can be "enriched" by Maven for example). > ChecksumProcessor being dedicated component opens the gate to support several > formats of checksums (BSD, GNU and resolver-native are all able to read, but > we write only resolver-native format). -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Assigned] (MRESOLVER-410) Drop deprecated Guice modules
[ https://issues.apache.org/jira/browse/MRESOLVER-410?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tamas Cservenak reassigned MRESOLVER-410: - Assignee: Tamas Cservenak > Drop deprecated Guice modules > - > > Key: MRESOLVER-410 > URL: https://issues.apache.org/jira/browse/MRESOLVER-410 > Project: Maven Resolver > Issue Type: Task > Components: Resolver >Reporter: Tamas Cservenak >Assignee: Tamas Cservenak >Priority: Major > Fix For: 2.0.0 > > > Resolver is radically lowering the supported surfaces for bootstrapping it, > no resources to maintain those all. > Goal is: > - Sisu (as in Maven) > - Supplier (manual, supersedes ServiceLocator) > There are other options as well (positioned in the "middle ground"), the > Maveniverse MIMA as well. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (MRESOLVER-410) Drop deprecated Guice modules
Tamas Cservenak created MRESOLVER-410: - Summary: Drop deprecated Guice modules Key: MRESOLVER-410 URL: https://issues.apache.org/jira/browse/MRESOLVER-410 Project: Maven Resolver Issue Type: Task Components: Resolver Reporter: Tamas Cservenak Fix For: 2.0.0 Resolver is radically lowering the supported surfaces for bootstrapping it, no resources to maintain those all. Goal is: - Sisu (as in Maven) - Supplier (manual, supersedes ServiceLocator) There are other options as well (positioned in the "middle ground"), the Maveniverse MIMA as well. -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] [discuss] Enables to resolve direct pom dependencies (not transitive ones) location as project.dependencies. reference - eases javaagent usage for ex [maven]
bmarwell commented on PR #1281: URL: https://github.com/apache/maven/pull/1281#issuecomment-1763191586 I forgot this file doesn't exist anymore. https://github.com/apache/maven/blob/maven-3.3.8/maven-core/src/main/resources/META-INF/plexus/default-bindings.xml But I think you get what I'm referring to. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Assigned] (MRESOLVER-157) Get rid of ServiceLocator in Resolver
[ https://issues.apache.org/jira/browse/MRESOLVER-157?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tamas Cservenak reassigned MRESOLVER-157: - Assignee: Tamas Cservenak > Get rid of ServiceLocator in Resolver > - > > Key: MRESOLVER-157 > URL: https://issues.apache.org/jira/browse/MRESOLVER-157 > Project: Maven Resolver > Issue Type: Task > Components: Resolver >Reporter: Tamas Cservenak >Assignee: Tamas Cservenak >Priority: Major > Fix For: 2.0.0 > > > maven-resolver currently supports: > * ServiceLocator (deprecated as of 1.7.0 see MRESOLVER-160) > * "vanilla" Guice (provides a module) > * DI using Sisu, as used in Maven > IMO, it makes not much sense to support 3 vastly different "DI"s (in quotes > as ServiceLocator is really just a dumb factory pattern). > Not only just complicates the code base, makes changes error prone at least, > yields for "exceptions" (this or that will never work with it, as seen with > SyncContext), and, for me most importantly, prevents proper constructor > initialization and validation of components. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MRESOLVER-157) Get rid of ServiceLocator in Resolver
[ https://issues.apache.org/jira/browse/MRESOLVER-157?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17775315#comment-17775315 ] ASF GitHub Bot commented on MRESOLVER-157: -- cstamas opened a new pull request, #340: URL: https://github.com/apache/maven-resolver/pull/340 Drop deprecated ServiceLocator. At the same time switch to Maven4 required (using 4.0.0-alpha-7). --- https://issues.apache.org/jira/browse/MRESOLVER-157 > Get rid of ServiceLocator in Resolver > - > > Key: MRESOLVER-157 > URL: https://issues.apache.org/jira/browse/MRESOLVER-157 > Project: Maven Resolver > Issue Type: Task > Components: Resolver >Reporter: Tamas Cservenak >Priority: Major > Fix For: 2.0.0 > > > maven-resolver currently supports: > * ServiceLocator (deprecated as of 1.7.0 see MRESOLVER-160) > * "vanilla" Guice (provides a module) > * DI using Sisu, as used in Maven > IMO, it makes not much sense to support 3 vastly different "DI"s (in quotes > as ServiceLocator is really just a dumb factory pattern). > Not only just complicates the code base, makes changes error prone at least, > yields for "exceptions" (this or that will never work with it, as seen with > SyncContext), and, for me most importantly, prevents proper constructor > initialization and validation of components. -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] [discuss] Enables to resolve direct pom dependencies (not transitive ones) location as project.dependencies. reference - eases javaagent usage for ex [maven]
bmarwell commented on PR #1281:
URL: https://github.com/apache/maven/pull/1281#issuecomment-1763190531
So the idea is that a given group and artifact ID gets resolved to the
following property:
`${project.dependencies.com.bar.dummy-agent}`
Only disadvantage of your solution: I don't see where the groupId ends and
the artifact ID begins. But that's probably not going to clash.
This is very helpful for agents.
Other ideas:
Change the default lifecycle XML to include the property goal of the
dependency plugin. Way smaller change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[PR] [MRESOLVER-157] Drop Service Locator [maven-resolver]
cstamas opened a new pull request, #340: URL: https://github.com/apache/maven-resolver/pull/340 Drop deprecated ServiceLocator. At the same time switch to Maven4 required (using 4.0.0-alpha-7). --- https://issues.apache.org/jira/browse/MRESOLVER-157 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (MNG-7908) Drop use of ServiceLocator
Tamas Cservenak created MNG-7908: Summary: Drop use of ServiceLocator Key: MNG-7908 URL: https://issues.apache.org/jira/browse/MNG-7908 Project: Maven Issue Type: Task Components: Artifacts and Repositories Reporter: Tamas Cservenak Fix For: 4.0.0-alpha-8 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Assigned] (MNG-7908) Drop use of ServiceLocator
[ https://issues.apache.org/jira/browse/MNG-7908?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tamas Cservenak reassigned MNG-7908: Assignee: Tamas Cservenak > Drop use of ServiceLocator > -- > > Key: MNG-7908 > URL: https://issues.apache.org/jira/browse/MNG-7908 > Project: Maven > Issue Type: Task > Components: Artifacts and Repositories >Reporter: Tamas Cservenak >Assignee: Tamas Cservenak >Priority: Major > Fix For: 4.0.0-alpha-8 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] [MNG-7541] Implement powershell command [maven]
JurrianFahner commented on PR #878: URL: https://github.com/apache/maven/pull/878#issuecomment-1763182870 > It would be nice to fix the command terminal title, the rest LGTM I've created an issue to improve the command terminal title: https://issues.apache.org/jira/browse/MNG-7907 The description is a little bit rough right now and needs some extra refinement. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MNG-7541) Native support for PowerShell to start Maven
[ https://issues.apache.org/jira/browse/MNG-7541?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17775309#comment-17775309 ] ASF GitHub Bot commented on MNG-7541: - JurrianFahner commented on PR #878: URL: https://github.com/apache/maven/pull/878#issuecomment-1763182870 > It would be nice to fix the command terminal title, the rest LGTM I've created an issue to improve the command terminal title: https://issues.apache.org/jira/browse/MNG-7907 The description is a little bit rough right now and needs some extra refinement. > Native support for PowerShell to start Maven > > > Key: MNG-7541 > URL: https://issues.apache.org/jira/browse/MNG-7541 > Project: Maven > Issue Type: Improvement > Components: Command Line >Affects Versions: 3.8.3 > Environment: windows 10 / 11 >Reporter: Jurrian Fahner >Priority: Trivial > Labels: Script, Windows10, Windows11 > > Maven has two files in the bin dir: > ||command||its use|| > |mvn|POSIX shell| > |mvn.cmd|cmd.exe| > On windows there are two ways to write scripts, by using cmd.exe or using > powershell. > If you enter mvn in powershell it will look for `mvn.ps1` on the PATH first. > If it doesn't find anything it will execute `mvn.cmd` as fall-back. > When running maven for starting a server for development purposes and you do > ctrl-c to exit the server it will ask the question: Terminate batch job (Y/N)? > As far as I know it is default behaviour of cmd.exe. > Well if I don't want to terminate, I wouldn't press ctrl-c. ;) > It is not the case (as far as I know that Microsoft is going to deprecate > cmd.exe in favor of powershell: > [https://devblogs.microsoft.com/commandline/rumors-of-cmds-death-have-been-greatly-exaggerated/] > Allthough I think it would be a good move for maven to have also a powershell > script as well... It is possible to integrate elegant support for native help > in powershell, `get-help mvn`. > But it also increases the maintenance effort as well. I don't know whether > this cost outweigh the benefits, though... > By the way I would happy to contribute if it is appreciated. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (MNG-7907) Harmonize window title - windows
Jurrian Fahner created MNG-7907: --- Summary: Harmonize window title - windows Key: MNG-7907 URL: https://issues.apache.org/jira/browse/MNG-7907 Project: Maven Issue Type: New Feature Environment: windows Reporter: Jurrian Fahner In the mvnDebug script the window title is updated during the script. It doesn't set back the changed window title back to the original window title. But it is strange that only with the mvnDebug script the title is updated, it would be nice to have that also with other scripts as well. In this way we can monitor when the maven command is ended succesfully. This issue currently only focuses on windows, this means the following default terminals will be supported: * Windows Terminal * Windows Powershell * Command Prompt I have not yet formed an idea on what should be set to as an title, but that is open for brainstorm. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MPIR-451) Rename "Dependency Information" to "Maven Coordinates".
[ https://issues.apache.org/jira/browse/MPIR-451?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17775305#comment-17775305 ] Michael Osipov commented on MPIR-451: - We can do this in the next major version (4) easily. > Rename "Dependency Information" to "Maven Coordinates". > > > Key: MPIR-451 > URL: https://issues.apache.org/jira/browse/MPIR-451 > Project: Maven Project Info Reports Plugin > Issue Type: Improvement >Reporter: Elliotte Rusty Harold >Priority: Major > > From a thread on commons-math where I noticed I was unable to find the Maven > coordinates for the project on the project's website: > The only way to get to that page is scroll about two thirds of the way down a > sidebar and click one of the four links that mention "dependencies" that > seems as likely to bring you to a list of commons-math's own dependencies > rather than how to add this project as a dependency. I'm a Maven comitter > who's spent way more time in the depths of Maven Project website generation > than 99.9% of Java programmers and I still couldn't find this the first time > I looked for it. That's de facto evidence that this information is not easy > to find. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Comment Edited] (MPLUGIN-483) @Component in Mojo parent classes not detected/added to plugin.xml requirements
[
https://issues.apache.org/jira/browse/MPLUGIN-483?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17775256#comment-17775256
]
Alexander Kriegisch edited comment on MPLUGIN-483 at 10/14/23 3:38 PM:
---
[~cstamas], I find it very hard to believe that anyone would do something like
this on purpose, because it effectively means that developers have to redefine
protected fields with those annotations, which in turn would lead to only the
redefined ones being injected and the ones in the parent classes always null,
rendering them utterly useless. It would be such a huge design flaw, that I am
confident, nobody would do that on purpose. The whole concept of having a
parent class like {{AbstractMavenReport}} with common fields and behaviours
would fail.
BTW, of course annotations in the JVM cannot be inherited (except for ones on
class types with the meta annotation {{@Inherited}}). It is not about
inheriting them, rather about also scanning parent classes for their existence.
They do not need to be inherited, because protected fields belong to (i.e. are
visible and reachable via {{this}} from) subclasses.
was (Author: kriegaex):
[~cstamas], I find it very hard to believe that anyone would do something like
this on purpose, because it effectively means that developers have to redefine
protected fields with those annotations, which would effectively lead to only
the redefined ones being injected and the ones in the parent classes always
null, rendering them utterly useless. It would be such a huge design flaw, that
I am confident, nobody would do that on purpose. The whole concept of having a
parent class like {{AbstractMavenReport}} with common fields and behaviours
would fail.
BTW, of course annotations in the JVM cannot be inherited (except for ones on
class types with the meta annotation {{@Inherited}}). It is not about
inheriting them, rather about also scanning parent classes for their existence.
They do not need to be inherited, because protected fields belong to (i.e. are
visible and reachable via {{this}} from) subclasses.
> @Component in Mojo parent classes not detected/added to plugin.xml
> requirements
> ---
>
> Key: MPLUGIN-483
> URL: https://issues.apache.org/jira/browse/MPLUGIN-483
> Project: Maven Plugin Tools
> Issue Type: Bug
>Affects Versions: 3.9.0
>Reporter: Herve Boutemy
>Priority: Major
>
> see
> https://github.com/dev-aspectj/aspectj-maven-plugin/pull/137#issuecomment-1757713422
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Comment Edited] (MPLUGIN-483) @Component in Mojo parent classes not detected/added to plugin.xml requirements
[
https://issues.apache.org/jira/browse/MPLUGIN-483?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17775256#comment-17775256
]
Alexander Kriegisch edited comment on MPLUGIN-483 at 10/14/23 3:36 PM:
---
[~cstamas], I find it very hard to believe that anyone would do something like
this on purpose, because it effectively means that developers have to redefine
protected fields with those annotations, which would effectively lead to only
the redefined ones being injected and the ones in the parent classes always
null, rendering them utterly useless. It would be such a huge design flaw, that
I am confident, nobody would do that on purpose. The whole concept of having a
parent class like {{AbstractMavenReport}} with common fields and behaviours
would fail.
BTW, of course annotations in the JVM cannot be inherited (except for ones on
class types with the meta annotation {{@Inherited}}). It is not about
inheriting them, rather about also scanning parent classes for their existence.
They do not need to be inherited, because protected fields belong to (i.e. are
visible and reachable via {{this}} from) subclasses.
was (Author: kriegaex):
[~cstamas], I find it very hard to believe that anyone would do something like
this on purpose, because it effectively means that developers have to redefine
protected fields with those annotations, which would effectively lead to only
the redefined ones being injected and the ones in the parent classes always
null, rendering them utterly useless. It would be such a huge design flaw, that
I am confident, nobody would do that on purpose. The whole concept of having a
parent class like {{AbstractMavenReport}} with common fields and behaviours
would fail.
> @Component in Mojo parent classes not detected/added to plugin.xml
> requirements
> ---
>
> Key: MPLUGIN-483
> URL: https://issues.apache.org/jira/browse/MPLUGIN-483
> Project: Maven Plugin Tools
> Issue Type: Bug
>Affects Versions: 3.9.0
>Reporter: Herve Boutemy
>Priority: Major
>
> see
> https://github.com/dev-aspectj/aspectj-maven-plugin/pull/137#issuecomment-1757713422
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Comment Edited] (MPLUGIN-483) @Component in Mojo parent classes not detected/added to plugin.xml requirements
[
https://issues.apache.org/jira/browse/MPLUGIN-483?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17775256#comment-17775256
]
Alexander Kriegisch edited comment on MPLUGIN-483 at 10/14/23 3:32 PM:
---
[~cstamas], I find it very hard to believe that anyone would do something like
this on purpose, because it effectively means that developers have to redefine
protected fields with those annotations, which would effectively lead to only
the redefined ones being injected and the ones in the parent classes always
null, rendering them utterly useless. That would be such a huge design flaw
that I am confident, nobody would do that on purpose. The whole concept of
having a parent class like {{AbstractMavenReport}} with common fields and
behaviours would fail.
was (Author: kriegaex):
[~cstamas], I find it very hard to believe that anyone would do something like
this on purpose, because it effectively means that developers have to override
redefine protected fields with those annotations, which would effectively lead
to only the redefined ones being injected and the ones in the parent classes
always null, rendering them utterly useless. That would be such a huge design
flaw that I am confident, nobody would do that on purpose. The whole concept of
having a parent class like {{AbstractMavenReport}} with common fields and
behaviours would fail.
> @Component in Mojo parent classes not detected/added to plugin.xml
> requirements
> ---
>
> Key: MPLUGIN-483
> URL: https://issues.apache.org/jira/browse/MPLUGIN-483
> Project: Maven Plugin Tools
> Issue Type: Bug
>Affects Versions: 3.9.0
>Reporter: Herve Boutemy
>Priority: Major
>
> see
> https://github.com/dev-aspectj/aspectj-maven-plugin/pull/137#issuecomment-1757713422
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Comment Edited] (MPLUGIN-483) @Component in Mojo parent classes not detected/added to plugin.xml requirements
[
https://issues.apache.org/jira/browse/MPLUGIN-483?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17775256#comment-17775256
]
Alexander Kriegisch edited comment on MPLUGIN-483 at 10/14/23 3:32 PM:
---
[~cstamas], I find it very hard to believe that anyone would do something like
this on purpose, because it effectively means that developers have to redefine
protected fields with those annotations, which would effectively lead to only
the redefined ones being injected and the ones in the parent classes always
null, rendering them utterly useless. It would be such a huge design flaw, that
I am confident, nobody would do that on purpose. The whole concept of having a
parent class like {{AbstractMavenReport}} with common fields and behaviours
would fail.
was (Author: kriegaex):
[~cstamas], I find it very hard to believe that anyone would do something like
this on purpose, because it effectively means that developers have to redefine
protected fields with those annotations, which would effectively lead to only
the redefined ones being injected and the ones in the parent classes always
null, rendering them utterly useless. That would be such a huge design flaw
that I am confident, nobody would do that on purpose. The whole concept of
having a parent class like {{AbstractMavenReport}} with common fields and
behaviours would fail.
> @Component in Mojo parent classes not detected/added to plugin.xml
> requirements
> ---
>
> Key: MPLUGIN-483
> URL: https://issues.apache.org/jira/browse/MPLUGIN-483
> Project: Maven Plugin Tools
> Issue Type: Bug
>Affects Versions: 3.9.0
>Reporter: Herve Boutemy
>Priority: Major
>
> see
> https://github.com/dev-aspectj/aspectj-maven-plugin/pull/137#issuecomment-1757713422
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MPLUGIN-483) @Component in Mojo parent classes not detected/added to plugin.xml requirements
[
https://issues.apache.org/jira/browse/MPLUGIN-483?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17775256#comment-17775256
]
Alexander Kriegisch commented on MPLUGIN-483:
-
[~cstamas], I find it very hard to believe that anyone would do something like
this on purpose, because it effectively means that developers have to override
redefine protected fields with those annotations, which would effectively lead
to only the redefined ones being injected and the ones in the parent classes
always null, rendering them utterly useless. That would be such a huge design
flaw that I am confident, nobody would do that on purpose. The whole concept of
having a parent class like {{AbstractMavenReport}} with common fields and
behaviours would fail.
> @Component in Mojo parent classes not detected/added to plugin.xml
> requirements
> ---
>
> Key: MPLUGIN-483
> URL: https://issues.apache.org/jira/browse/MPLUGIN-483
> Project: Maven Plugin Tools
> Issue Type: Bug
>Affects Versions: 3.9.0
>Reporter: Herve Boutemy
>Priority: Major
>
> see
> https://github.com/dev-aspectj/aspectj-maven-plugin/pull/137#issuecomment-1757713422
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Closed] (MRESOLVER-409) Drop various deprecated methods and classes
[ https://issues.apache.org/jira/browse/MRESOLVER-409?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tamas Cservenak closed MRESOLVER-409. - Resolution: Fixed > Drop various deprecated methods and classes > --- > > Key: MRESOLVER-409 > URL: https://issues.apache.org/jira/browse/MRESOLVER-409 > Project: Maven Resolver > Issue Type: Task >Reporter: Tamas Cservenak >Assignee: Tamas Cservenak >Priority: Major > Fix For: 2.0.0 > > > We have quite some sprinkled deprecations across codebase, drop them. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MRESOLVER-409) Drop various deprecated methods and classes
[ https://issues.apache.org/jira/browse/MRESOLVER-409?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17775243#comment-17775243 ] ASF GitHub Bot commented on MRESOLVER-409: -- cstamas merged PR #339: URL: https://github.com/apache/maven-resolver/pull/339 > Drop various deprecated methods and classes > --- > > Key: MRESOLVER-409 > URL: https://issues.apache.org/jira/browse/MRESOLVER-409 > Project: Maven Resolver > Issue Type: Task >Reporter: Tamas Cservenak >Priority: Major > Fix For: 2.0.0 > > > We have quite some sprinkled deprecations across codebase, drop them. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Assigned] (MRESOLVER-409) Drop various deprecated methods and classes
[ https://issues.apache.org/jira/browse/MRESOLVER-409?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tamas Cservenak reassigned MRESOLVER-409: - Assignee: Tamas Cservenak > Drop various deprecated methods and classes > --- > > Key: MRESOLVER-409 > URL: https://issues.apache.org/jira/browse/MRESOLVER-409 > Project: Maven Resolver > Issue Type: Task >Reporter: Tamas Cservenak >Assignee: Tamas Cservenak >Priority: Major > Fix For: 2.0.0 > > > We have quite some sprinkled deprecations across codebase, drop them. -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] [MRESOLVER-409] Drop various deprecated methods and classes [maven-resolver]
cstamas merged PR #339: URL: https://github.com/apache/maven-resolver/pull/339 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MRESOLVER-409) Drop various deprecated methods and classes
[ https://issues.apache.org/jira/browse/MRESOLVER-409?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17775239#comment-17775239 ] ASF GitHub Bot commented on MRESOLVER-409: -- cstamas opened a new pull request, #339: URL: https://github.com/apache/maven-resolver/pull/339 We have quite some sprinkled deprecations across codebase, drop them. --- https://issues.apache.org/jira/browse/MRESOLVER-409 > Drop various deprecated methods and classes > --- > > Key: MRESOLVER-409 > URL: https://issues.apache.org/jira/browse/MRESOLVER-409 > Project: Maven Resolver > Issue Type: Task >Reporter: Tamas Cservenak >Priority: Major > Fix For: 2.0.0 > > > We have quite some sprinkled deprecations across codebase, drop them. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[PR] [MRESOLVER-409] Drop various deprecated methods and classes [maven-resolver]
cstamas opened a new pull request, #339: URL: https://github.com/apache/maven-resolver/pull/339 We have quite some sprinkled deprecations across codebase, drop them. --- https://issues.apache.org/jira/browse/MRESOLVER-409 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (MRESOLVER-409) Drop various deprecated methods and classes
Tamas Cservenak created MRESOLVER-409: - Summary: Drop various deprecated methods and classes Key: MRESOLVER-409 URL: https://issues.apache.org/jira/browse/MRESOLVER-409 Project: Maven Resolver Issue Type: Task Reporter: Tamas Cservenak Fix For: 2.0.0 We have quite some sprinkled deprecations across codebase, drop them. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MRESOLVER-389) Drop deprecated logging facade
[ https://issues.apache.org/jira/browse/MRESOLVER-389?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17775234#comment-17775234 ] ASF GitHub Bot commented on MRESOLVER-389: -- cstamas merged PR #338: URL: https://github.com/apache/maven-resolver/pull/338 > Drop deprecated logging facade > -- > > Key: MRESOLVER-389 > URL: https://issues.apache.org/jira/browse/MRESOLVER-389 > Project: Maven Resolver > Issue Type: Task > Components: Resolver >Reporter: Tamas Cservenak >Priority: Major > Fix For: 2.0.0 > > > There is some logging facade (unused) deprecated since long time. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Assigned] (MRESOLVER-377) Introduce metadata update policy
[ https://issues.apache.org/jira/browse/MRESOLVER-377?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tamas Cservenak reassigned MRESOLVER-377: - Assignee: Tamas Cservenak > Introduce metadata update policy > > > Key: MRESOLVER-377 > URL: https://issues.apache.org/jira/browse/MRESOLVER-377 > Project: Maven Resolver > Issue Type: Improvement > Components: Resolver >Reporter: Tamas Cservenak >Assignee: Tamas Cservenak >Priority: Major > Fix For: 2.0.0 > > > Split the policies applied in case of data and metadata, allowing greater > control of their updates. Still, work "as before" in case of applications > that migrate from 1.x resolver (they should receive no behavior change). > The crux of this change is really just to introduce two policies (to co-exist > in parallel), but if application using resolver decides to use same policy > for both, the original behavior of resolver returns and will seemingly behave > as before (ie. like 1.9.x does). > Maven relies on metadata in these cases ONLY: > * resolving maven plugin prefix to maven plugin groupId (G level md) > * resolving snapshot version to timestamped version (V level md) > Resolver OTOH provides one more use case: > * "discovery" of existing versions for given GA (this use case is NOT used in > Maven Core) (A level md) > Now, while Maven Core itself does NOT use 3rd use case, some plugins does, > most notably the versions-maven-plugin. Today, everyone on Earth use this > plugin along with `-U` Maven switch to pick up new stuff from remote > repository, but this is total overkill, as it refreshes _everything_ (yes, > even the immutable release artifacts!). The `-U` is simply a "must", to make > Maven "refresh metadata" (as well, along with all the Artifacts) to pick up > new versions on remote. Versions plugin did implement a ["hack" to overcome > this > limitation](https://github.com/mojohaus/versions/commit/82e2450d8bbd22c3f8cdc06d44c44d618c69e23e), > that is still a hack, as it still applies to everything. Proper solution is > to have means to express `-U but for metadata only`. This PR makes this > possible on resolver side. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Assigned] (MRESOLVER-389) Drop deprecated logging facade
[ https://issues.apache.org/jira/browse/MRESOLVER-389?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tamas Cservenak reassigned MRESOLVER-389: - Assignee: Tamas Cservenak > Drop deprecated logging facade > -- > > Key: MRESOLVER-389 > URL: https://issues.apache.org/jira/browse/MRESOLVER-389 > Project: Maven Resolver > Issue Type: Task > Components: Resolver >Reporter: Tamas Cservenak >Assignee: Tamas Cservenak >Priority: Major > Fix For: 2.0.0 > > > There is some logging facade (unused) deprecated since long time. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Closed] (MRESOLVER-389) Drop deprecated logging facade
[ https://issues.apache.org/jira/browse/MRESOLVER-389?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tamas Cservenak closed MRESOLVER-389. - Resolution: Fixed > Drop deprecated logging facade > -- > > Key: MRESOLVER-389 > URL: https://issues.apache.org/jira/browse/MRESOLVER-389 > Project: Maven Resolver > Issue Type: Task > Components: Resolver >Reporter: Tamas Cservenak >Assignee: Tamas Cservenak >Priority: Major > Fix For: 2.0.0 > > > There is some logging facade (unused) deprecated since long time. -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] [MRESOLVER-389] Drop logging facade [maven-resolver]
cstamas merged PR #338: URL: https://github.com/apache/maven-resolver/pull/338 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Assigned] (MRESOLVER-312) Raise build required Java to 11, target remains 8
[
https://issues.apache.org/jira/browse/MRESOLVER-312?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Tamas Cservenak reassigned MRESOLVER-312:
-
Assignee: Tamas Cservenak
> Raise build required Java to 11, target remains 8
> -
>
> Key: MRESOLVER-312
> URL: https://issues.apache.org/jira/browse/MRESOLVER-312
> Project: Maven Resolver
> Issue Type: Task
> Components: Resolver
>Reporter: Tamas Cservenak
>Assignee: Tamas Cservenak
>Priority: Major
> Fix For: 2.0.0
>
>
> As some newly introduced modules are Java11+, we need to raise the required
> build Java to 11+, while the output (of the existing) modules remains Java 8.
> This also means we can drop use of animal-sniffer, replace it with
> {{{}release=8{}}}.
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Updated] (MRESOLVER-302) Introduce onSession close
[ https://issues.apache.org/jira/browse/MRESOLVER-302?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tamas Cservenak updated MRESOLVER-302: -- Issue Type: Improvement (was: New Feature) > Introduce onSession close > - > > Key: MRESOLVER-302 > URL: https://issues.apache.org/jira/browse/MRESOLVER-302 > Project: Maven Resolver > Issue Type: Improvement > Components: Resolver >Reporter: Tamas Cservenak >Assignee: Tamas Cservenak >Priority: Major > Fix For: 2.0.0 > > > The on session close callback, revisited. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Closed] (MRESOLVER-312) Raise build required Java to 11, target remains 8
[
https://issues.apache.org/jira/browse/MRESOLVER-312?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Tamas Cservenak closed MRESOLVER-312.
-
Resolution: Fixed
Done as part of MRESOLVER-408
> Raise build required Java to 11, target remains 8
> -
>
> Key: MRESOLVER-312
> URL: https://issues.apache.org/jira/browse/MRESOLVER-312
> Project: Maven Resolver
> Issue Type: Task
> Components: Resolver
>Reporter: Tamas Cservenak
>Priority: Major
> Fix For: 2.0.0
>
>
> As some newly introduced modules are Java11+, we need to raise the required
> build Java to 11+, while the output (of the existing) modules remains Java 8.
> This also means we can drop use of animal-sniffer, replace it with
> {{{}release=8{}}}.
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Updated] (MRESOLVER-338) Drop FileTransform API
[ https://issues.apache.org/jira/browse/MRESOLVER-338?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tamas Cservenak updated MRESOLVER-338: -- Issue Type: Task (was: Dependency upgrade) > Drop FileTransform API > -- > > Key: MRESOLVER-338 > URL: https://issues.apache.org/jira/browse/MRESOLVER-338 > Project: Maven Resolver > Issue Type: Task > Components: Resolver >Reporter: Tamas Cservenak >Assignee: Tamas Cservenak >Priority: Major > Fix For: 2.0.0 > > > As this will streamline things from impl through connector and transport. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MNG-7899) Various memory usage improvements
[
https://issues.apache.org/jira/browse/MNG-7899?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17775230#comment-17775230
]
ASF GitHub Bot commented on MNG-7899:
-
gnodet commented on PR #1269:
URL: https://github.com/apache/maven/pull/1269#issuecomment-1762920120
> @sebastien-doyon unit tests seem broken. Also and fwiw, this looks like
all this work may be broken if we somehow integrate #1279... we may want to
investigate on that branch then...
Also, #1268, #1269 and #1270 really look related to the same goal, I.e.
optimize the logging, so I think they should be merged in order to have a
better understand of the benefits (even if they could be 3 different commits).
> Various memory usage improvements
> -
>
> Key: MNG-7899
> URL: https://issues.apache.org/jira/browse/MNG-7899
> Project: Maven
> Issue Type: Improvement
> Components: Design, Patterns Best Practices, Embedding,
> General, Logging
>Affects Versions: 4.0.0-alpha-2
>Reporter: sebastien
>Priority: Major
>
> Some optimisations can be applied to the code to reduce the use of temporary
> objects.
> Typical improvements identified are:
> * reduce scope of temporary objects creation to avoid creating when not
> needed. Example :
> {code:java}
> public String toString() {
> StringBuilder sb = new StringBuilder(512);
> if (isEmpty()) {
> return "empty";
> }
> for (MetadataGraphVertex v : vertices) {
> .{code}
> can be replaced by
> {code:java}
> public String toString() {
> if (isEmpty()) {
> return "empty";
> }
> StringBuilder sb = new StringBuilder(512);
> for (MetadataGraphVertex v : vertices) {
> .{code}
> * Reuse StringBuilder objects in loops by setting its length to zero
> * Use the StringBuilder.append() with index to avoid String.substring().
> Example:
>
> {code:java}
> int idx = resourceName.lastIndexOf('/');
> buffer.append(idx < 0 ? resourceName : resourceName.substring(idx + 1));
> {code}
> can be replaced by
>
> {code:java}
> int idx = resourceName.lastIndexOf('/');
> if (idx < 0) {
> buffer.append(resourceName);
> } else {
> buffer.append(resourceName, idx + 1, resourceName.length());
> } {code}
>
>
> * Replace dynamic string creation static constants when possible
> * Avoid creating temporary strings with + operator when the final
> destination can be used instead, like PrintStream.print() method
> * Avoir using StringBuilder.append() method and util method MessageUtils.a()
> when the final destination can be used instead, like PrintStream.print()
> method
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
Re: [PR] [MNG-7899] Various memory usage improvements 4 [maven]
gnodet commented on PR #1269: URL: https://github.com/apache/maven/pull/1269#issuecomment-1762920120 > @sebastien-doyon unit tests seem broken. Also and fwiw, this looks like all this work may be broken if we somehow integrate #1279... we may want to investigate on that branch then... Also, #1268, #1269 and #1270 really look related to the same goal, I.e. optimize the logging, so I think they should be merged in order to have a better understand of the benefits (even if they could be 3 different commits). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MRESOLVER-389) Drop deprecated logging facade
[ https://issues.apache.org/jira/browse/MRESOLVER-389?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17775229#comment-17775229 ] ASF GitHub Bot commented on MRESOLVER-389: -- cstamas opened a new pull request, #338: URL: https://github.com/apache/maven-resolver/pull/338 As Resolver has settled on slf4j since long time. --- https://issues.apache.org/jira/browse/MRESOLVER-389 > Drop deprecated logging facade > -- > > Key: MRESOLVER-389 > URL: https://issues.apache.org/jira/browse/MRESOLVER-389 > Project: Maven Resolver > Issue Type: Task > Components: Resolver >Reporter: Tamas Cservenak >Priority: Major > Fix For: 2.0.0 > > > There is some logging facade (unused) deprecated since long time. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MNG-7899) Various memory usage improvements
[
https://issues.apache.org/jira/browse/MNG-7899?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17775227#comment-17775227
]
ASF GitHub Bot commented on MNG-7899:
-
gnodet commented on PR #1269:
URL: https://github.com/apache/maven/pull/1269#issuecomment-1762918806
@sebastien-doyon unit tests seem broken.
Also and fwiw, this looks like all this work may be broken if we somehow
integrate https://github.com/apache/maven/pull/1279... we may want to
investigate on that branch then...
> Various memory usage improvements
> -
>
> Key: MNG-7899
> URL: https://issues.apache.org/jira/browse/MNG-7899
> Project: Maven
> Issue Type: Improvement
> Components: Design, Patterns Best Practices, Embedding,
> General, Logging
>Affects Versions: 4.0.0-alpha-2
>Reporter: sebastien
>Priority: Major
>
> Some optimisations can be applied to the code to reduce the use of temporary
> objects.
> Typical improvements identified are:
> * reduce scope of temporary objects creation to avoid creating when not
> needed. Example :
> {code:java}
> public String toString() {
> StringBuilder sb = new StringBuilder(512);
> if (isEmpty()) {
> return "empty";
> }
> for (MetadataGraphVertex v : vertices) {
> .{code}
> can be replaced by
> {code:java}
> public String toString() {
> if (isEmpty()) {
> return "empty";
> }
> StringBuilder sb = new StringBuilder(512);
> for (MetadataGraphVertex v : vertices) {
> .{code}
> * Reuse StringBuilder objects in loops by setting its length to zero
> * Use the StringBuilder.append() with index to avoid String.substring().
> Example:
>
> {code:java}
> int idx = resourceName.lastIndexOf('/');
> buffer.append(idx < 0 ? resourceName : resourceName.substring(idx + 1));
> {code}
> can be replaced by
>
> {code:java}
> int idx = resourceName.lastIndexOf('/');
> if (idx < 0) {
> buffer.append(resourceName);
> } else {
> buffer.append(resourceName, idx + 1, resourceName.length());
> } {code}
>
>
> * Replace dynamic string creation static constants when possible
> * Avoid creating temporary strings with + operator when the final
> destination can be used instead, like PrintStream.print() method
> * Avoir using StringBuilder.append() method and util method MessageUtils.a()
> when the final destination can be used instead, like PrintStream.print()
> method
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
Re: [PR] [MNG-7899] Various memory usage improvements 4 [maven]
gnodet commented on PR #1269: URL: https://github.com/apache/maven/pull/1269#issuecomment-1762918806 @sebastien-doyon unit tests seem broken. Also and fwiw, this looks like all this work may be broken if we somehow integrate https://github.com/apache/maven/pull/1279... we may want to investigate on that branch then... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MRESOLVER-338) Drop FileTransform API
[ https://issues.apache.org/jira/browse/MRESOLVER-338?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17775223#comment-17775223 ] ASF GitHub Bot commented on MRESOLVER-338: -- cstamas merged PR #337: URL: https://github.com/apache/maven-resolver/pull/337 > Drop FileTransform API > -- > > Key: MRESOLVER-338 > URL: https://issues.apache.org/jira/browse/MRESOLVER-338 > Project: Maven Resolver > Issue Type: Dependency upgrade > Components: Resolver >Reporter: Tamas Cservenak >Priority: Major > Fix For: 2.0.0 > > > As this will streamline things from impl through connector and transport. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Assigned] (MRESOLVER-338) Drop FileTransform API
[ https://issues.apache.org/jira/browse/MRESOLVER-338?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tamas Cservenak reassigned MRESOLVER-338: - Assignee: Tamas Cservenak > Drop FileTransform API > -- > > Key: MRESOLVER-338 > URL: https://issues.apache.org/jira/browse/MRESOLVER-338 > Project: Maven Resolver > Issue Type: Dependency upgrade > Components: Resolver >Reporter: Tamas Cservenak >Assignee: Tamas Cservenak >Priority: Major > Fix For: 2.0.0 > > > As this will streamline things from impl through connector and transport. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Closed] (MRESOLVER-338) Drop FileTransform API
[ https://issues.apache.org/jira/browse/MRESOLVER-338?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tamas Cservenak closed MRESOLVER-338. - Resolution: Fixed > Drop FileTransform API > -- > > Key: MRESOLVER-338 > URL: https://issues.apache.org/jira/browse/MRESOLVER-338 > Project: Maven Resolver > Issue Type: Dependency upgrade > Components: Resolver >Reporter: Tamas Cservenak >Assignee: Tamas Cservenak >Priority: Major > Fix For: 2.0.0 > > > As this will streamline things from impl through connector and transport. -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] [MRESOLVER-338] Drop FileTransform API [maven-resolver]
cstamas merged PR #337: URL: https://github.com/apache/maven-resolver/pull/337 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Drop FileTransformer API [maven-resolver]
cstamas closed pull request #229: Drop FileTransformer API URL: https://github.com/apache/maven-resolver/pull/229 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Drop FileTransformer API [maven-resolver]
cstamas commented on PR #229: URL: https://github.com/apache/maven-resolver/pull/229#issuecomment-1762892805 Superseded by https://github.com/apache/maven-resolver/pull/337 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MRESOLVER-338) Drop FileTransform API
[ https://issues.apache.org/jira/browse/MRESOLVER-338?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17775221#comment-17775221 ] ASF GitHub Bot commented on MRESOLVER-338: -- cstamas opened a new pull request, #337: URL: https://github.com/apache/maven-resolver/pull/337 To streamline all way down to transport and remove OOM prone code. Note: japicmp config was added, as we did a mistake, we deprecated types, but not related methods, so without these japicm would fail the build due breakages. --- https://issues.apache.org/jira/browse/MRESOLVER-338 > Drop FileTransform API > -- > > Key: MRESOLVER-338 > URL: https://issues.apache.org/jira/browse/MRESOLVER-338 > Project: Maven Resolver > Issue Type: Dependency upgrade > Components: Resolver >Reporter: Tamas Cservenak >Priority: Major > Fix For: 2.0.0 > > > As this will streamline things from impl through connector and transport. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[PR] [MRESOLVER-338] Drop FileTransform API [maven-resolver]
cstamas opened a new pull request, #337: URL: https://github.com/apache/maven-resolver/pull/337 To streamline all way down to transport and remove OOM prone code. Note: japicmp config was added, as we did a mistake, we deprecated types, but not related methods, so without these japicm would fail the build due breakages. --- https://issues.apache.org/jira/browse/MRESOLVER-338 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] Update build instructions for windows [maven-mvnd]
KasNotten opened a new pull request, #890: URL: https://github.com/apache/maven-mvnd/pull/890 I would like to propose adding the following details to the instructions for building `maven-mvnd` on Windows. I had to spend some time figuring out which tools I need and I figured I would save other future Windows contributors the trouble. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [MNG-7772] Test for extensions.xml defined in an ext directory in the… [maven-integration-testing]
juulhobert commented on code in PR #311:
URL:
https://github.com/apache/maven-integration-testing/pull/311#discussion_r1359376079
##
core-it-suite/src/test/java/org/apache/maven/it/ItUtils.java:
##
@@ -56,4 +63,24 @@ public static String calcHash(File file, String algo) throws
Exception {
return hash.toString();
}
+
+public static String getLogContent(Verifier verifier) throws IOException {
+ByteArrayOutputStream baos = new ByteArrayOutputStream();
+Files.copy(Paths.get(verifier.getBasedir(),
verifier.getLogFileName()), baos);
+return baos.toString();
+}
+
+public static void setUserHome(Verifier verifier, File file) {
+setUserHome(verifier, file.toPath());
+}
+
+public static void setUserHome(Verifier verifier, Path home) {
+// NOTE: We set the user.home directory instead of say
settings.security to reflect Maven's normal behavior
+String path = home.toAbsolutePath().toString();
+if (path.indexOf(' ') < 0) {
+verifier.setEnvironmentVariable("MAVEN_OPTS", "-Duser.home=" +
path);
+} else {
+verifier.setEnvironmentVariable("MAVEN_OPTS", "\"-Duser.home=" +
path + "\"");
Review Comment:
It's not trivial to get the forkJvm value, therefore i've only added a
comment to warn future developers about it. I hope you're ok with it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[PR] Use full terminal width in CLI with Maven 4 [maven-mvnd]
KasNotten opened a new pull request, #889: URL: https://github.com/apache/maven-mvnd/pull/889 I am trying to solve the following issue: #870 As far as I can determine this code (Also contains some test code which can be removed later) should work for using the full terminal width in maven-mvnd, comparing it with the code in the maven repository for using the full terminal width in maven 4. However, the terminal width is always -1. Can anyone shed some light on as to why this is happening? Maybe @ppalaga or @gnodet ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [MNG-7772] Test for extensions.xml defined in an ext directory in the… [maven-integration-testing]
slawekjaranowski commented on code in PR #311:
URL:
https://github.com/apache/maven-integration-testing/pull/311#discussion_r1359372962
##
core-it-suite/src/test/java/org/apache/maven/it/ItUtils.java:
##
@@ -56,4 +63,24 @@ public static String calcHash(File file, String algo) throws
Exception {
return hash.toString();
}
+
+public static String getLogContent(Verifier verifier) throws IOException {
+ByteArrayOutputStream baos = new ByteArrayOutputStream();
+Files.copy(Paths.get(verifier.getBasedir(),
verifier.getLogFileName()), baos);
+return baos.toString();
+}
+
+public static void setUserHome(Verifier verifier, File file) {
+setUserHome(verifier, file.toPath());
+}
+
+public static void setUserHome(Verifier verifier, Path home) {
+// NOTE: We set the user.home directory instead of say
settings.security to reflect Maven's normal behavior
+String path = home.toAbsolutePath().toString();
+if (path.indexOf(' ') < 0) {
+verifier.setEnvironmentVariable("MAVEN_OPTS", "-Duser.home=" +
path);
+} else {
+verifier.setEnvironmentVariable("MAVEN_OPTS", "\"-Duser.home=" +
path + "\"");
Review Comment:
We also need here
```
verifier.setForkJvm(true);
```
environment variable can be set only in fork mode of verifier
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] [MNG-7772] Test for extensions.xml defined in an ext directory in the… [maven-integration-testing]
juulhobert commented on code in PR #311:
URL:
https://github.com/apache/maven-integration-testing/pull/311#discussion_r1359360272
##
core-it-suite/src/test/java/org/apache/maven/it/MavenITmng7772CoreExtensionsNotFoundTest.java:
##
@@ -0,0 +1,81 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.maven.it;
+
+import java.io.ByteArrayOutputStream;
+import java.io.File;
+import java.io.IOException;
+import java.nio.file.Files;
+import java.nio.file.Path;
+import java.nio.file.Paths;
+
+import org.apache.maven.shared.verifier.VerificationException;
+import org.apache.maven.shared.verifier.Verifier;
+import org.apache.maven.shared.verifier.util.ResourceExtractor;
+import org.junit.jupiter.api.Test;
+
+/**
+ * This is a test set for https://issues.apache.org/jira/browse/MNG-7772;>MNG-7772:
+ * check that Maven fails if it cannot load core extensions contributed by
${user.home}/.m2/extensions.xml.
+ */
+public class MavenITmng7772CoreExtensionsNotFoundTest extends
AbstractMavenIntegrationTestCase {
+
+public MavenITmng7772CoreExtensionsNotFoundTest() {
+super("[3.9.0,)");
+}
+
+@Test
+public void testCoreExtensionsNotFound() throws Exception {
+File testDir = ResourceExtractor.simpleExtractResources(getClass(),
"/mng-7772-core-extensions-not-found");
+
+Path m2TestDirPath = Paths.get(testDir.toPath().toString(), ".m2");
+Files.createDirectories(Paths.get(System.getProperty("user.home"),
".m2"));
+Path to = Paths.get(System.getProperty("user.home"), ".m2",
"extensions.xml");
+
+// Test cannot run when there is already an extensions.xml file
present in the ${user.home}/.m2 folder
+assertFalse(Files.exists(to));
+
+try {
+Files.copy(m2TestDirPath.resolve("extensions.xml"), to);
+Verifier verifier = newVerifier(testDir.getAbsolutePath());
+
+try {
+verifier.addCliArgument("validate");
+verifier.execute();
Review Comment:
I see why it's not preferable to use the real user home. Somehow
`.setSystemProperty("user.home"` was not working but I found that test
MavenITmng0553SettingsAuthzEncryptionTest already had a method for setting the
user home. I've reused that code and that's working :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] [MNG-7772] Test for extensions.xml defined in an ext directory in the… [maven-integration-testing]
juulhobert commented on code in PR #311:
URL:
https://github.com/apache/maven-integration-testing/pull/311#discussion_r1359321315
##
core-it-suite/src/test/java/org/apache/maven/it/MavenITmng7772CoreExtensionsNotFoundTest.java:
##
@@ -0,0 +1,81 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.maven.it;
+
+import java.io.ByteArrayOutputStream;
+import java.io.File;
+import java.io.IOException;
+import java.nio.file.Files;
+import java.nio.file.Path;
+import java.nio.file.Paths;
+
+import org.apache.maven.shared.verifier.VerificationException;
+import org.apache.maven.shared.verifier.Verifier;
+import org.apache.maven.shared.verifier.util.ResourceExtractor;
+import org.junit.jupiter.api.Test;
+
+/**
+ * This is a test set for https://issues.apache.org/jira/browse/MNG-7772;>MNG-7772:
+ * check that Maven fails if it cannot load core extensions contributed by
${user.home}/.m2/extensions.xml.
+ */
+public class MavenITmng7772CoreExtensionsNotFoundTest extends
AbstractMavenIntegrationTestCase {
+
+public MavenITmng7772CoreExtensionsNotFoundTest() {
+super("[3.9.0,)");
Review Comment:
Changed it to `"(4.0.0-alpha-7,)"`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Closed] (MDEPLOY-312) [REGRESSION] deploy no longer updates project model
[ https://issues.apache.org/jira/browse/MDEPLOY-312?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tamas Cservenak closed MDEPLOY-312. --- Assignee: Tamas Cservenak Resolution: Not A Problem And use got relevant information how to do what they want to do. > [REGRESSION] deploy no longer updates project model > --- > > Key: MDEPLOY-312 > URL: https://issues.apache.org/jira/browse/MDEPLOY-312 > Project: Maven Deploy Plugin > Issue Type: Bug > Components: deploy:deploy, deploy:deploy-file >Affects Versions: 3.0.0 >Reporter: Jared Stehler >Assignee: Tamas Cservenak >Priority: Major > > Prior to 3.0.0, the maven-deploy-plugin would update artifacts on the Project > model: > * > [https://github.com/apache/maven/blob/master/maven-compat/src/main/java/org/apache/maven/artifact/deployer/DefaultArtifactDeployer.java#L147] > * > [https://github.com/apache/maven-deploy-plugin/blob/maven-deploy-plugin-2.8.2/src/main/java/org/apache/maven/plugin/deploy/DeployFileMojo.java#L276] > This is no longer occurring with the migration to maven-resolver, which is > breaking our downstream plugins relying on the resolved SNAPSHOT version. > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (MNG-7906) Dependency Management import does not work the "maven way"
[
https://issues.apache.org/jira/browse/MNG-7906?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Tamas Cservenak updated MNG-7906:
-
Fix Version/s: 4.0.x-candidate
> Dependency Management import does not work the "maven way"
> --
>
> Key: MNG-7906
> URL: https://issues.apache.org/jira/browse/MNG-7906
> Project: Maven
> Issue Type: Bug
> Components: Dependencies
>Reporter: Tamas Cservenak
>Priority: Blocker
> Fix For: 4.0.x-candidate
>
>
> This affects all released Maven versions so far.
> Problem reproducer: https://github.com/cstamas/MNG-7852 (repo name is wrong,
> obviously).
> In short: unlike with dependencies, where you CAN override some "deep
> transitive" dependency by re-declaring it directly as 1st level dependency in
> POM, for depMgt import this does not work, actually, it works quite the
> opposite ("first comes, wins"). Moreover, Maven remains silent about this, as
> reproducer shows, and all of this goes unnoticed.
> Solution: at least depMgt import should make "the maven way", maybe not by
> default (to not break existing builds) but configurable. Problem is solved if
> in reproducer:
> - with fix enabled, junit 5.9.3 is used, AND
> - with fix disabled, Maven yells about ignored depMgt import
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MPLUGIN-483) @Component in Mojo parent classes not detected/added to plugin.xml requirements
[ https://issues.apache.org/jira/browse/MPLUGIN-483?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17775181#comment-17775181 ] Tamas Cservenak commented on MPLUGIN-483: - Afaik Mojo annotations were never scanned in class hierarchy, and it was done on purpose. Unlike jsr330 annotations, that are "inherited", Mojo annotations were never inherited. > @Component in Mojo parent classes not detected/added to plugin.xml > requirements > --- > > Key: MPLUGIN-483 > URL: https://issues.apache.org/jira/browse/MPLUGIN-483 > Project: Maven Plugin Tools > Issue Type: Bug >Affects Versions: 3.9.0 >Reporter: Herve Boutemy >Priority: Major > > see > https://github.com/dev-aspectj/aspectj-maven-plugin/pull/137#issuecomment-1757713422 -- This message was sent by Atlassian Jira (v8.20.10#820010)
