Re: [PR] Support JDK 21 at build time [maven-mvnd]
gnodet merged PR #894: URL: https://github.com/apache/maven-mvnd/pull/894 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Closed] (MNG-7893) Allow versioning the superpom according to the model version
[ https://issues.apache.org/jira/browse/MNG-7893?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guillaume Nodet closed MNG-7893. > Allow versioning the superpom according to the model version > > > Key: MNG-7893 > URL: https://issues.apache.org/jira/browse/MNG-7893 > Project: Maven > Issue Type: New Feature >Reporter: Guillaume Nodet >Assignee: Guillaume Nodet >Priority: Major > Fix For: 4.0.0-alpha-8 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Closed] (MNG-7821) Require JDK 11 at build time and get rid of animal-sniffer
[ https://issues.apache.org/jira/browse/MNG-7821?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guillaume Nodet closed MNG-7821. Assignee: Guillaume Nodet Resolution: Fixed > Require JDK 11 at build time and get rid of animal-sniffer > -- > > Key: MNG-7821 > URL: https://issues.apache.org/jira/browse/MNG-7821 > Project: Maven > Issue Type: Task >Reporter: Guillaume Nodet >Assignee: Guillaume Nodet >Priority: Major > Fix For: 4.0.0-alpha-8 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MNG-7821) Require JDK 11 at build time and get rid of animal-sniffer
[ https://issues.apache.org/jira/browse/MNG-7821?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17776493#comment-17776493 ] ASF GitHub Bot commented on MNG-7821: - gnodet merged PR #1289: URL: https://github.com/apache/maven/pull/1289 > Require JDK 11 at build time and get rid of animal-sniffer > -- > > Key: MNG-7821 > URL: https://issues.apache.org/jira/browse/MNG-7821 > Project: Maven > Issue Type: Task >Reporter: Guillaume Nodet >Priority: Major > Fix For: 4.0.0-alpha-8 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] [MNG-7821] Remove useless animal-sniffer-plugin [maven]
gnodet merged PR #1289: URL: https://github.com/apache/maven/pull/1289 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Comment Edited] (MRESOLVER-384) Support HTTP/2 in maven-resolver-transport-http
[
https://issues.apache.org/jira/browse/MRESOLVER-384?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17776406#comment-17776406
]
Tamas Cservenak edited comment on MRESOLVER-384 at 10/17/23 9:50 PM:
-
To be solves as MRESOLVER-416 and MRESOLVER-415
was (Author: cstamas):
To be solves as MRESOLVER-414 and MRESOLVER-415
> Support HTTP/2 in maven-resolver-transport-http
> ---
>
> Key: MRESOLVER-384
> URL: https://issues.apache.org/jira/browse/MRESOLVER-384
> Project: Maven Resolver
> Issue Type: Improvement
> Components: Resolver
>Reporter: Konrad Windszus
>Priority: Major
> Fix For: 2.0.0
>
>
> Currently transport-http relies on the outdated Apache HttpClient 4.5.x which
> does not support HTTP/2
> (https://hc.apache.org/httpcomponents-client-4.5.x/index.html).
> {quote}
> Standards based, pure Java, implementation of HTTP versions 1.0 and 1.1
> {quote}.
> The recommendation in https://hc.apache.org/status.html is
> {quote}
> Users of HttpClient 4.x are strongly encouraged to migrate to HttpClient 5.x
> {quote}
> In order to benefit from HTTP/2 connections to Maven Central we should
> upgrade to Apache HttpClient 5.x or some other library capable of HTTP/2.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MRESOLVER-384) Support HTTP/2 in maven-resolver-transport-http
[
https://issues.apache.org/jira/browse/MRESOLVER-384?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17776406#comment-17776406
]
Tamas Cservenak commented on MRESOLVER-384:
---
To be solves as MRESOLVER-414 and MRESOLVER-415
> Support HTTP/2 in maven-resolver-transport-http
> ---
>
> Key: MRESOLVER-384
> URL: https://issues.apache.org/jira/browse/MRESOLVER-384
> Project: Maven Resolver
> Issue Type: Improvement
> Components: Resolver
>Reporter: Konrad Windszus
>Priority: Major
> Fix For: 2.0.0
>
>
> Currently transport-http relies on the outdated Apache HttpClient 4.5.x which
> does not support HTTP/2
> (https://hc.apache.org/httpcomponents-client-4.5.x/index.html).
> {quote}
> Standards based, pure Java, implementation of HTTP versions 1.0 and 1.1
> {quote}.
> The recommendation in https://hc.apache.org/status.html is
> {quote}
> Users of HttpClient 4.x are strongly encouraged to migrate to HttpClient 5.x
> {quote}
> In order to benefit from HTTP/2 connections to Maven Central we should
> upgrade to Apache HttpClient 5.x or some other library capable of HTTP/2.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Created] (MRESOLVER-416) New transport: Jetty, HTTP/2 capable
Tamas Cservenak created MRESOLVER-416: - Summary: New transport: Jetty, HTTP/2 capable Key: MRESOLVER-416 URL: https://issues.apache.org/jira/browse/MRESOLVER-416 Project: Maven Resolver Issue Type: New Feature Components: Resolver Reporter: Tamas Cservenak Fix For: 2.0.0 Create new transport "jetty" that uses Jetty 10.x (and is HTTP/2 capable). -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Closed] (MRESOLVER-412) BF collector causes same model to be loaded up multiple times
[ https://issues.apache.org/jira/browse/MRESOLVER-412?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tamas Cservenak closed MRESOLVER-412. - Resolution: Fixed This issue is not a resolver issue, but Maven Model Builder issue, handled in MNG-7615 > BF collector causes same model to be loaded up multiple times > - > > Key: MRESOLVER-412 > URL: https://issues.apache.org/jira/browse/MRESOLVER-412 > Project: Maven Resolver > Issue Type: Bug > Components: Resolver >Reporter: Tamas Cservenak >Priority: Major > > This bug probably affects all released versions of new BF collector. > Symptom is that Maven with BF collector fails MavenITmng5669ReadPomsOnce both > test methods. The IT verifies that POM XMLs are _read only once_ with and > without "consumer POM" feature enabled. Both IT methods fail (so failure is > irrelevant of consumer POM feature being enabled). Error consistently happens > on each subsequent IT invokcation, whether empty or prepopulated local repo. > Most probably cause: old DF was single threaded, while BF uses internally > thread pool, that seemingly causes that same POM XML is loaded up multiple > times as ModelBuilder is being asked multi threaded for different models by > BF collector. > Reproduce: either run MavenITmng5669ReadPomsOnce but modify the IT to enable > DF (if using Maven w/ resolver 1.x) or build Maven 4 w/ Resolver 2 (default > is BF). -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (MRESOLVER-412) BF collector causes same model to be loaded up multiple times
[ https://issues.apache.org/jira/browse/MRESOLVER-412?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tamas Cservenak updated MRESOLVER-412: -- Fix Version/s: (was: 2.0.0) > BF collector causes same model to be loaded up multiple times > - > > Key: MRESOLVER-412 > URL: https://issues.apache.org/jira/browse/MRESOLVER-412 > Project: Maven Resolver > Issue Type: Bug > Components: Resolver >Reporter: Tamas Cservenak >Priority: Major > > This bug probably affects all released versions of new BF collector. > Symptom is that Maven with BF collector fails MavenITmng5669ReadPomsOnce both > test methods. The IT verifies that POM XMLs are _read only once_ with and > without "consumer POM" feature enabled. Both IT methods fail (so failure is > irrelevant of consumer POM feature being enabled). Error consistently happens > on each subsequent IT invokcation, whether empty or prepopulated local repo. > Most probably cause: old DF was single threaded, while BF uses internally > thread pool, that seemingly causes that same POM XML is loaded up multiple > times as ModelBuilder is being asked multi threaded for different models by > BF collector. > Reproduce: either run MavenITmng5669ReadPomsOnce but modify the IT to enable > DF (if using Maven w/ resolver 1.x) or build Maven 4 w/ Resolver 2 (default > is BF). -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MRESOLVER-412) BF collector causes same model to be loaded up multiple times
[ https://issues.apache.org/jira/browse/MRESOLVER-412?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17776396#comment-17776396 ] Tamas Cservenak commented on MRESOLVER-412: --- Also, tested resolver + this PR https://github.com/apache/maven/pull/893 "Multi-threaded Model Builder" and all ITs pass OK, so I'd vote for this applied to maven core. This is not a resolver nor BF collector issue definitely. > BF collector causes same model to be loaded up multiple times > - > > Key: MRESOLVER-412 > URL: https://issues.apache.org/jira/browse/MRESOLVER-412 > Project: Maven Resolver > Issue Type: Bug > Components: Resolver >Reporter: Tamas Cservenak >Priority: Major > Fix For: 2.0.0 > > > This bug probably affects all released versions of new BF collector. > Symptom is that Maven with BF collector fails MavenITmng5669ReadPomsOnce both > test methods. The IT verifies that POM XMLs are _read only once_ with and > without "consumer POM" feature enabled. Both IT methods fail (so failure is > irrelevant of consumer POM feature being enabled). Error consistently happens > on each subsequent IT invokcation, whether empty or prepopulated local repo. > Most probably cause: old DF was single threaded, while BF uses internally > thread pool, that seemingly causes that same POM XML is loaded up multiple > times as ModelBuilder is being asked multi threaded for different models by > BF collector. > Reproduce: either run MavenITmng5669ReadPomsOnce but modify the IT to enable > DF (if using Maven w/ resolver 1.x) or build Maven 4 w/ Resolver 2 (default > is BF). -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] Use the same branch name for ITs on Jenkins - 3.9.x [maven]
slawekjaranowski merged PR #1288: URL: https://github.com/apache/maven/pull/1288 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MNG-7615) Multithreaded model builder
[ https://issues.apache.org/jira/browse/MNG-7615?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17776392#comment-17776392 ] ASF GitHub Bot commented on MNG-7615: - cstamas commented on PR #893: URL: https://github.com/apache/maven/pull/893#issuecomment-1767179898 Ran ITs of this PR + resolver 2.0.0 (both combined) and ITs are OK > Multithreaded model builder > --- > > Key: MNG-7615 > URL: https://issues.apache.org/jira/browse/MNG-7615 > Project: Maven > Issue Type: Task >Reporter: Guillaume Nodet >Assignee: Guillaume Nodet >Priority: Major > > Parsing all reactor models can be very lengthy, so use a map/reduce algorithm > to make the computation in parallel. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MNG-7821) Require JDK 11 at build time and get rid of animal-sniffer
[ https://issues.apache.org/jira/browse/MNG-7821?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17776391#comment-17776391 ] ASF GitHub Bot commented on MNG-7821: - gnodet opened a new pull request, #1289: URL: https://github.com/apache/maven/pull/1289 Following this checklist to help us incorporate your contribution quickly and easily: - [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/MNG) filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes. - [ ] Each commit in the pull request should have a meaningful subject line and body. - [ ] Format the pull request title like `[MNG-XXX] SUMMARY`, where you replace `MNG-XXX` and `SUMMARY` with the appropriate JIRA issue. - [ ] Also format the first line of the commit message like `[MNG-XXX] SUMMARY`. Best practice is to use the JIRA issue title in both the pull request title and in the first line of the commit message. - [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [ ] Run `mvn clean verify` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically. - [ ] You have run the [Core IT][core-its] successfully. If your pull request is about ~20 lines of code you don't need to sign an [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure please ask on the developers list. To make clear that you license your contribution under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) you have to acknowledge this by using the following check-box. - [ ] I hereby declare this contribution to be licenced under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) - [ ] In any other case, please file an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). [core-its]: https://maven.apache.org/core-its/core-it-suite/ > Require JDK 11 at build time and get rid of animal-sniffer > -- > > Key: MNG-7821 > URL: https://issues.apache.org/jira/browse/MNG-7821 > Project: Maven > Issue Type: Task >Reporter: Guillaume Nodet >Priority: Major > Fix For: 4.0.0-alpha-8 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] [MNG-7615] Multithreaded model builder [maven]
cstamas commented on PR #893: URL: https://github.com/apache/maven/pull/893#issuecomment-1767179898 Ran ITs of this PR + resolver 2.0.0 (both combined) and ITs are OK -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] [MNG-7821] Remove useless animal-sniffer-plugin [maven]
gnodet opened a new pull request, #1289: URL: https://github.com/apache/maven/pull/1289 Following this checklist to help us incorporate your contribution quickly and easily: - [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/MNG) filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes. - [ ] Each commit in the pull request should have a meaningful subject line and body. - [ ] Format the pull request title like `[MNG-XXX] SUMMARY`, where you replace `MNG-XXX` and `SUMMARY` with the appropriate JIRA issue. - [ ] Also format the first line of the commit message like `[MNG-XXX] SUMMARY`. Best practice is to use the JIRA issue title in both the pull request title and in the first line of the commit message. - [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [ ] Run `mvn clean verify` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically. - [ ] You have run the [Core IT][core-its] successfully. If your pull request is about ~20 lines of code you don't need to sign an [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure please ask on the developers list. To make clear that you license your contribution under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) you have to acknowledge this by using the following check-box. - [ ] I hereby declare this contribution to be licenced under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) - [ ] In any other case, please file an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). [core-its]: https://maven.apache.org/core-its/core-it-suite/ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] Switch to Maven 4.0.0-alpha-8 [maven-mvnd]
gnodet opened a new pull request, #895: URL: https://github.com/apache/maven-mvnd/pull/895 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] Support JDK 21 at build time [maven-mvnd]
gnodet opened a new pull request, #894: URL: https://github.com/apache/maven-mvnd/pull/894 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] Make sure the plugin works with maven 3 [maven-mvnd]
gnodet opened a new pull request, #893: URL: https://github.com/apache/maven-mvnd/pull/893 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MRESOLVER-415) New transport: JDK11 HTTP/2 capable
[ https://issues.apache.org/jira/browse/MRESOLVER-415?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17776382#comment-17776382 ] ASF GitHub Bot commented on MRESOLVER-415: -- cstamas opened a new pull request, #343: URL: https://github.com/apache/maven-resolver/pull/343 This is still WIP, but just wanted to showcase how I thought to implement this transport to give meaningful message on Java8, but also make it reusable (it produces 3 JARs). Naturally, in general case you'd depend on jdk.jar (multi-release), but still you can use jdk-11.jar if you want. Demo snippets modified just to use jdk transport. The PR is far from done, as no test exists yet, just the main code is copied from HTTP/2 transport showcase PR. --- https://issues.apache.org/jira/browse/MRESOLVER-415 > New transport: JDK11 HTTP/2 capable > --- > > Key: MRESOLVER-415 > URL: https://issues.apache.org/jira/browse/MRESOLVER-415 > Project: Maven Resolver > Issue Type: New Feature > Components: Resolver >Reporter: Tamas Cservenak >Priority: Major > Fix For: 2.0.0 > > > Create new transport "jdk" that uses Java11 java.net.http.HttpClient (and is > HTTP/2 capable). -- This message was sent by Atlassian Jira (v8.20.10#820010)
[PR] [MRESOLVER-415] The "jdk" transport [maven-resolver]
cstamas opened a new pull request, #343: URL: https://github.com/apache/maven-resolver/pull/343 This is still WIP, but just wanted to showcase how I thought to implement this transport to give meaningful message on Java8, but also make it reusable (it produces 3 JARs). Naturally, in general case you'd depend on jdk.jar (multi-release), but still you can use jdk-11.jar if you want. Demo snippets modified just to use jdk transport. The PR is far from done, as no test exists yet, just the main code is copied from HTTP/2 transport showcase PR. --- https://issues.apache.org/jira/browse/MRESOLVER-415 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (MRESOLVER-415) New transport: JDK11 HTTP/2 capable
Tamas Cservenak created MRESOLVER-415: - Summary: New transport: JDK11 HTTP/2 capable Key: MRESOLVER-415 URL: https://issues.apache.org/jira/browse/MRESOLVER-415 Project: Maven Resolver Issue Type: New Feature Components: Resolver Reporter: Tamas Cservenak Fix For: 2.0.0 Create new transport "jdk" that uses Java11 java.net.http.HttpClient (and is HTTP/2 capable). -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] [MNG-7772] Test for extensions.xml defined in an ext directory in the… [maven-integration-testing]
juulhobert commented on PR #311: URL: https://github.com/apache/maven-integration-testing/pull/311#issuecomment-1767064068 > Nice work, thanks for providing these extensive test cases! Thanks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] Use the same branch name for ITs on Jenkins - 3.9.x [maven]
slawekjaranowski opened a new pull request, #1288: URL: https://github.com/apache/maven/pull/1288 (cherry picked from commit 882c8dd9746f2fb7bec1c2b7b6ece4b85c75f701) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MNG-7913) Upgrade Sisu version
[ https://issues.apache.org/jira/browse/MNG-7913?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17776326#comment-17776326 ] ASF GitHub Bot commented on MNG-7913: - cstamas commented on PR #1286: URL: https://github.com/apache/maven/pull/1286#issuecomment-1766951141 I agree with @kwin: just keep it simple with Maven 3.9, let it go up to Java 21 but we don't want to "future proof" it, as there is maven4 > Upgrade Sisu version > > > Key: MNG-7913 > URL: https://issues.apache.org/jira/browse/MNG-7913 > Project: Maven > Issue Type: Improvement > Components: Core >Reporter: Tamas Cservenak >Priority: Major > Fix For: 3.9.6 > > > Recently, as new Java versions are pushed out more aggressively (with Java 21 > out this autumn), seemingly it became normal that users developing Maven > plugins (and components used by those plugins) using bytecode level that is > Java14+. > But alas, Maven 3.9.x line uses Sisu 0.3.5 that is capable to glean bytecode > only up to Java 14. Components having higher version bytecode are silently > skipped by Sisu (no output about this, only at Sisu DEBUG level not emitted > by default). > Hence, it would make sense to up Sisu version to at least 0.9.0.M2 in Maven > 3.9.x as well, that would allow use of JSR330 components using bytecode more > recent that Java 14 is. -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] [3.9.x] [MNG-7913] Upgrade Sisu version [maven]
cstamas commented on PR #1286: URL: https://github.com/apache/maven/pull/1286#issuecomment-1766951141 I agree with @kwin: just keep it simple with Maven 3.9, let it go up to Java 21 but we don't want to "future proof" it, as there is maven4 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MNG-7913) Upgrade Sisu version
[ https://issues.apache.org/jira/browse/MNG-7913?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17776314#comment-17776314 ] ASF GitHub Bot commented on MNG-7913: - kwin commented on PR #1286: URL: https://github.com/apache/maven/pull/1286#issuecomment-1766904173 I think supporting Java up to 19 is enough for Maven 3.9 > Upgrade Sisu version > > > Key: MNG-7913 > URL: https://issues.apache.org/jira/browse/MNG-7913 > Project: Maven > Issue Type: Improvement > Components: Core >Reporter: Tamas Cservenak >Priority: Major > Fix For: 3.9.6 > > > Recently, as new Java versions are pushed out more aggressively (with Java 21 > out this autumn), seemingly it became normal that users developing Maven > plugins (and components used by those plugins) using bytecode level that is > Java14+. > But alas, Maven 3.9.x line uses Sisu 0.3.5 that is capable to glean bytecode > only up to Java 14. Components having higher version bytecode are silently > skipped by Sisu (no output about this, only at Sisu DEBUG level not emitted > by default). > Hence, it would make sense to up Sisu version to at least 0.9.0.M2 in Maven > 3.9.x as well, that would allow use of JSR330 components using bytecode more > recent that Java 14 is. -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] [3.9.x] [MNG-7913] Upgrade Sisu version [maven]
kwin commented on PR #1286: URL: https://github.com/apache/maven/pull/1286#issuecomment-1766904173 I think supporting Java up to 19 is enough for Maven 3.9 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (MNG-6437) Generic .uri suffix to get the URI representation of any file property
[
https://issues.apache.org/jira/browse/MNG-6437?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Guillaume Nodet updated MNG-6437:
-
Fix Version/s: 4.0.0-alpha-8
(was: 4.0.x-candidate)
(was: 4.0.0)
> Generic .uri suffix to get the URI representation of any file property
> --
>
> Key: MNG-6437
> URL: https://issues.apache.org/jira/browse/MNG-6437
> Project: Maven
> Issue Type: Improvement
> Components: Core
>Affects Versions: 3.5.4
>Reporter: Claude Brisson
>Assignee: Guillaume Nodet
>Priority: Major
> Fix For: 4.0.0-alpha-8
>
>
> It's impossible to properly generate, for instance, a java policy file which
> needs files URIs, using either Cargo properties and filtered config files, or
> just filtered resources.
> In both cases, the problem is the impossibility to generate proper URIs when
> expanding Maven properties (see also MNG-3760).
> The candidate feature is to add a way to explicitly request the URI when
> expanding a property by means of a {{.uri}} suffix. The underlying
> {{getUri()}} method should rely on the correct {{Path#toUri()}} and neither
> {{File#toUri()}} nor {{File#toString()}}, see the SO reference in MNG-6386.
> For instance:
> * {{${project.basedir.uri}}} instead of the broken {{${project.baseUri}}}
> (and of course fix MNG-6436 otherwise it's useless)
> * {{${project.build.directory.uri}}}
> * {{${settings.localRepository.uri}}}
> * etc
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Closed] (MNG-6437) Generic .uri suffix to get the URI representation of any file property
[
https://issues.apache.org/jira/browse/MNG-6437?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Guillaume Nodet closed MNG-6437.
Resolution: Fixed
> Generic .uri suffix to get the URI representation of any file property
> --
>
> Key: MNG-6437
> URL: https://issues.apache.org/jira/browse/MNG-6437
> Project: Maven
> Issue Type: Improvement
> Components: Core
>Affects Versions: 3.5.4
>Reporter: Claude Brisson
>Assignee: Guillaume Nodet
>Priority: Major
> Fix For: 4.0.0-alpha-8
>
>
> It's impossible to properly generate, for instance, a java policy file which
> needs files URIs, using either Cargo properties and filtered config files, or
> just filtered resources.
> In both cases, the problem is the impossibility to generate proper URIs when
> expanding Maven properties (see also MNG-3760).
> The candidate feature is to add a way to explicitly request the URI when
> expanding a property by means of a {{.uri}} suffix. The underlying
> {{getUri()}} method should rely on the correct {{Path#toUri()}} and neither
> {{File#toUri()}} nor {{File#toString()}}, see the SO reference in MNG-6386.
> For instance:
> * {{${project.basedir.uri}}} instead of the broken {{${project.baseUri}}}
> (and of course fix MNG-6436 otherwise it's useless)
> * {{${project.build.directory.uri}}}
> * {{${settings.localRepository.uri}}}
> * etc
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MNG-6437) Generic .uri suffix to get the URI representation of any file property
[
https://issues.apache.org/jira/browse/MNG-6437?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17776313#comment-17776313
]
ASF GitHub Bot commented on MNG-6437:
-
gnodet merged PR #812:
URL: https://github.com/apache/maven/pull/812
> Generic .uri suffix to get the URI representation of any file property
> --
>
> Key: MNG-6437
> URL: https://issues.apache.org/jira/browse/MNG-6437
> Project: Maven
> Issue Type: Improvement
> Components: Core
>Affects Versions: 3.5.4
>Reporter: Claude Brisson
>Assignee: Guillaume Nodet
>Priority: Major
> Fix For: 4.0.x-candidate, 4.0.0
>
>
> It's impossible to properly generate, for instance, a java policy file which
> needs files URIs, using either Cargo properties and filtered config files, or
> just filtered resources.
> In both cases, the problem is the impossibility to generate proper URIs when
> expanding Maven properties (see also MNG-3760).
> The candidate feature is to add a way to explicitly request the URI when
> expanding a property by means of a {{.uri}} suffix. The underlying
> {{getUri()}} method should rely on the correct {{Path#toUri()}} and neither
> {{File#toUri()}} nor {{File#toString()}}, see the SO reference in MNG-6386.
> For instance:
> * {{${project.basedir.uri}}} instead of the broken {{${project.baseUri}}}
> (and of course fix MNG-6436 otherwise it's useless)
> * {{${project.build.directory.uri}}}
> * {{${settings.localRepository.uri}}}
> * etc
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
Re: [PR] [MNG-6437] Better support for path and uri in property interpolation [maven]
gnodet merged PR #812: URL: https://github.com/apache/maven/pull/812 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MNG-7891) Support configuration in extensions.xml / elements
[
https://issues.apache.org/jira/browse/MNG-7891?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17776312#comment-17776312
]
ASF GitHub Bot commented on MNG-7891:
-
gnodet merged PR #1272:
URL: https://github.com/apache/maven/pull/1272
> Support configuration in extensions.xml / elements
> --
>
> Key: MNG-7891
> URL: https://issues.apache.org/jira/browse/MNG-7891
> Project: Maven
> Issue Type: New Feature
>Reporter: Christoph Läubrich
>Assignee: Guillaume Nodet
>Priority: Major
> Fix For: 4.0.0-alpha-8
>
>
> Currently one can not configure extensions as only mojos are configurable.
> It would be great to have a basic configuration support for both in
> extension.xml as well as in pom>extension elements.
> The Idea would be for extensions.xml to only have very limited support:
> # Only the extension itself can be configured, no inheritance or similar
> complex stuff
> # Only basic interpolation: e.g. user-properties and env-variable
> for pom>extension elements one might want to allow everything that is allowed
> for build>plugins
> To aquire such configuration I would like it to be injectable into a
> component like this:
> {code:java}
> @Inject
> @Named("extension:my.group.id:my.extension.id")
> private PlexusConfiguration config;
> {code}
> for the second case this should be call-sensitive in respect to the current
> active session project.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
Re: [PR] [MNG-7891] Abstract ExtensionConfigurationModule from CliRequest [maven]
gnodet merged PR #1272: URL: https://github.com/apache/maven/pull/1272 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MNG-7913) Upgrade Sisu version
[ https://issues.apache.org/jira/browse/MNG-7913?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17776311#comment-17776311 ] ASF GitHub Bot commented on MNG-7913: - gnodet commented on PR #1286: URL: https://github.com/apache/maven/pull/1286#issuecomment-1766894060 > To version that supports gleaning JSR330 component classes up to Java 21. The reasoning of this change is only to allow 3rd party Maven plugins/Maven extensions/other JSR330 components (managed by Maven embedded Sisu) to use bytecode newer that Java 14 (Sisu 0.3.5). > > https://issues.apache.org/jira/browse/MNG-7913 Fwiw, I think you'll also need to back port https://github.com/apache/maven/pull/1126 in order to make sure the latest ASM supporting JDK 21 is used. > Upgrade Sisu version > > > Key: MNG-7913 > URL: https://issues.apache.org/jira/browse/MNG-7913 > Project: Maven > Issue Type: Improvement > Components: Core >Reporter: Tamas Cservenak >Priority: Major > Fix For: 3.9.6 > > > Recently, as new Java versions are pushed out more aggressively (with Java 21 > out this autumn), seemingly it became normal that users developing Maven > plugins (and components used by those plugins) using bytecode level that is > Java14+. > But alas, Maven 3.9.x line uses Sisu 0.3.5 that is capable to glean bytecode > only up to Java 14. Components having higher version bytecode are silently > skipped by Sisu (no output about this, only at Sisu DEBUG level not emitted > by default). > Hence, it would make sense to up Sisu version to at least 0.9.0.M2 in Maven > 3.9.x as well, that would allow use of JSR330 components using bytecode more > recent that Java 14 is. -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] [3.9.x] [MNG-7913] Upgrade Sisu version [maven]
gnodet commented on PR #1286: URL: https://github.com/apache/maven/pull/1286#issuecomment-1766894060 > To version that supports gleaning JSR330 component classes up to Java 21. The reasoning of this change is only to allow 3rd party Maven plugins/Maven extensions/other JSR330 components (managed by Maven embedded Sisu) to use bytecode newer that Java 14 (Sisu 0.3.5). > > https://issues.apache.org/jira/browse/MNG-7913 Fwiw, I think you'll also need to back port https://github.com/apache/maven/pull/1126 in order to make sure the latest ASM supporting JDK 21 is used. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MRESOLVER-412) BF collector causes same model to be loaded up multiple times
[
https://issues.apache.org/jira/browse/MRESOLVER-412?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17776304#comment-17776304
]
Tamas Cservenak commented on MRESOLVER-412:
---
It seems my suspicion was right: this is ModelBuilder issue, BF collector is to
"blame" only for invoking ModelBuilder on several threads :)
Locally was able to "fix" this issue by synchronizing the two method:
* org.apache.maven.model.building.DefaultModelBuilder#readRawModel
* org.apache.maven.model.building.DefaultModelBuilder#readFileModel
My guess is that what happens is that two competing threads both get {{null}}
from cache, then they both go to load/parse same (parent) POM, and finally both
put it into cache...
> BF collector causes same model to be loaded up multiple times
> -
>
> Key: MRESOLVER-412
> URL: https://issues.apache.org/jira/browse/MRESOLVER-412
> Project: Maven Resolver
> Issue Type: Bug
> Components: Resolver
>Reporter: Tamas Cservenak
>Priority: Major
> Fix For: 2.0.0
>
>
> This bug probably affects all released versions of new BF collector.
> Symptom is that Maven with BF collector fails MavenITmng5669ReadPomsOnce both
> test methods. The IT verifies that POM XMLs are _read only once_ with and
> without "consumer POM" feature enabled. Both IT methods fail (so failure is
> irrelevant of consumer POM feature being enabled). Error consistently happens
> on each subsequent IT invokcation, whether empty or prepopulated local repo.
> Most probably cause: old DF was single threaded, while BF uses internally
> thread pool, that seemingly causes that same POM XML is loaded up multiple
> times as ModelBuilder is being asked multi threaded for different models by
> BF collector.
> Reproduce: either run MavenITmng5669ReadPomsOnce but modify the IT to enable
> DF (if using Maven w/ resolver 1.x) or build Maven 4 w/ Resolver 2 (default
> is BF).
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MNG-7772) Allow to register maven core extension in .m2 directory instead of MAVEN_HOME
[
https://issues.apache.org/jira/browse/MNG-7772?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17776293#comment-17776293
]
ASF GitHub Bot commented on MNG-7772:
-
juulhobert closed pull request #1287: [MNG-7772] Allow to register maven core
extension in .m2 directory in…
URL: https://github.com/apache/maven/pull/1287
> Allow to register maven core extension in .m2 directory instead of MAVEN_HOME
> --
>
> Key: MNG-7772
> URL: https://issues.apache.org/jira/browse/MNG-7772
> Project: Maven
> Issue Type: Improvement
>Reporter: Roy Teeuwen
>Priority: Major
> Fix For: 4.0.x-candidate
>
>
> Currently the way to register a maven core extension is described here:
> [https://maven.apache.org/guides/mini/guide-using-extensions.html]
> Namely the following ways are supported:
> * Registered via extension jar in {{${maven.home}/lib/ext}}
> * Registered via CLI argument {{mvn -Dmaven.ext.class.path=extension.jar}}
> * Registered via [{{.mvn/extensions.xml}}
> file|https://maven.apache.org/configure.html#mvn-extensions-xml-file]
> The downside of this is that the ${maven.home} directory is not something
> that you should touch, seeing as with every update of maven (through for
> example homebrew), it will replace the directory with the new version, making
> it required to manually re-register the core extension by dragging the jar in
> /lib/ext.
> My proposal is to also make it possible to register the extension through the
> ${user.home}/.m2 directory. This could for example be by also allowing the
> extensions.xml in the .m2 directory or by creating an ext directory in the
> .m2 directory.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
Re: [PR] [MNG-7772] Allow to register maven core extension in .m2 directory in… [maven]
juulhobert closed pull request #1287: [MNG-7772] Allow to register maven core extension in .m2 directory in… URL: https://github.com/apache/maven/pull/1287 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MNG-7772) Allow to register maven core extension in .m2 directory instead of MAVEN_HOME
[
https://issues.apache.org/jira/browse/MNG-7772?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17776292#comment-17776292
]
ASF GitHub Bot commented on MNG-7772:
-
juulhobert opened a new pull request, #1287:
URL: https://github.com/apache/maven/pull/1287
…stead of MAVEN_HOME
Following this checklist to help us incorporate your
contribution quickly and easily:
- [ ] Make sure there is a [JIRA
issue](https://issues.apache.org/jira/browse/MNG) filed
for the change (usually before you start working on it). Trivial
changes like typos do not
require a JIRA issue. Your pull request should address just this
issue, without
pulling in other changes.
- [ ] Each commit in the pull request should have a meaningful subject line
and body.
- [ ] Format the pull request title like `[MNG-XXX] SUMMARY`,
where you replace `MNG-XXX` and `SUMMARY` with the appropriate JIRA
issue.
- [ ] Also format the first line of the commit message like `[MNG-XXX]
SUMMARY`.
Best practice is to use the JIRA issue title in both the pull request
title and in the first line of the commit message.
- [ ] Write a pull request description that is detailed enough to
understand what the pull request does, how, and why.
- [ ] Run `mvn clean verify` to make sure basic checks pass. A more
thorough check will
be performed on your pull request automatically.
- [ ] You have run the [Core IT][core-its] successfully.
If your pull request is about ~20 lines of code you don't need to sign an
[Individual Contributor License
Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure
please ask on the developers list.
To make clear that you license your contribution under
the [Apache License Version 2.0, January
2004](http://www.apache.org/licenses/LICENSE-2.0)
you have to acknowledge this by using the following check-box.
- [ ] I hereby declare this contribution to be licenced under the [Apache
License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
- [ ] In any other case, please file an [Apache Individual Contributor
License Agreement](https://www.apache.org/licenses/icla.pdf).
[core-its]: https://maven.apache.org/core-its/core-it-suite/
> Allow to register maven core extension in .m2 directory instead of MAVEN_HOME
> --
>
> Key: MNG-7772
> URL: https://issues.apache.org/jira/browse/MNG-7772
> Project: Maven
> Issue Type: Improvement
>Reporter: Roy Teeuwen
>Priority: Major
> Fix For: 4.0.x-candidate
>
>
> Currently the way to register a maven core extension is described here:
> [https://maven.apache.org/guides/mini/guide-using-extensions.html]
> Namely the following ways are supported:
> * Registered via extension jar in {{${maven.home}/lib/ext}}
> * Registered via CLI argument {{mvn -Dmaven.ext.class.path=extension.jar}}
> * Registered via [{{.mvn/extensions.xml}}
> file|https://maven.apache.org/configure.html#mvn-extensions-xml-file]
> The downside of this is that the ${maven.home} directory is not something
> that you should touch, seeing as with every update of maven (through for
> example homebrew), it will replace the directory with the new version, making
> it required to manually re-register the core extension by dragging the jar in
> /lib/ext.
> My proposal is to also make it possible to register the extension through the
> ${user.home}/.m2 directory. This could for example be by also allowing the
> extensions.xml in the .m2 directory or by creating an ext directory in the
> .m2 directory.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[PR] [MNG-7772] Allow to register maven core extension in .m2 directory in… [maven]
juulhobert opened a new pull request, #1287: URL: https://github.com/apache/maven/pull/1287 …stead of MAVEN_HOME Following this checklist to help us incorporate your contribution quickly and easily: - [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/MNG) filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes. - [ ] Each commit in the pull request should have a meaningful subject line and body. - [ ] Format the pull request title like `[MNG-XXX] SUMMARY`, where you replace `MNG-XXX` and `SUMMARY` with the appropriate JIRA issue. - [ ] Also format the first line of the commit message like `[MNG-XXX] SUMMARY`. Best practice is to use the JIRA issue title in both the pull request title and in the first line of the commit message. - [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [ ] Run `mvn clean verify` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically. - [ ] You have run the [Core IT][core-its] successfully. If your pull request is about ~20 lines of code you don't need to sign an [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure please ask on the developers list. To make clear that you license your contribution under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) you have to acknowledge this by using the following check-box. - [ ] I hereby declare this contribution to be licenced under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) - [ ] In any other case, please file an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). [core-its]: https://maven.apache.org/core-its/core-it-suite/ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MRESOLVER-412) BF collector causes same model to be loaded up multiple times
[ https://issues.apache.org/jira/browse/MRESOLVER-412?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17776276#comment-17776276 ] Tamas Cservenak commented on MRESOLVER-412: --- ModelBuilder is invoked implicitly, whenever this line is hit: https://github.com/apache/maven-resolver/blob/maven-resolver-1.9.16/maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/collect/bf/BfDependencyCollector.java#L464 And if you imagine POMs that share parents (like Maven project or apache commons project, etc), this causes that _same parent_ is parsed on different threads but again, this is just my guess currently, and I must miss something, as there should be model cache in play as well, but something seems off (in Maven or ModelBuilder maybe) > BF collector causes same model to be loaded up multiple times > - > > Key: MRESOLVER-412 > URL: https://issues.apache.org/jira/browse/MRESOLVER-412 > Project: Maven Resolver > Issue Type: Bug > Components: Resolver >Reporter: Tamas Cservenak >Priority: Major > Fix For: 2.0.0 > > > This bug probably affects all released versions of new BF collector. > Symptom is that Maven with BF collector fails MavenITmng5669ReadPomsOnce both > test methods. The IT verifies that POM XMLs are _read only once_ with and > without "consumer POM" feature enabled. Both IT methods fail (so failure is > irrelevant of consumer POM feature being enabled). Error consistently happens > on each subsequent IT invokcation, whether empty or prepopulated local repo. > Most probably cause: old DF was single threaded, while BF uses internally > thread pool, that seemingly causes that same POM XML is loaded up multiple > times as ModelBuilder is being asked multi threaded for different models by > BF collector. > Reproduce: either run MavenITmng5669ReadPomsOnce but modify the IT to enable > DF (if using Maven w/ resolver 1.x) or build Maven 4 w/ Resolver 2 (default > is BF). -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Comment Edited] (MRESOLVER-412) BF collector causes same model to be loaded up multiple times
[ https://issues.apache.org/jira/browse/MRESOLVER-412?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17776271#comment-17776271 ] Tamas Cservenak edited comment on MRESOLVER-412 at 10/17/23 4:37 PM: - [~wecai] the IT is introduced for maven4, yes. But the point is that this IT did never run with BF before (as the IT does not alter collector). Now that resolver 2.0.0 makes BF default collector (MRESOLVER-324), the IT runs with BF and fails. Also, my guess is that the IT would fail with all released versions of new BF collector. It MAY be that the IT is wrong, am still looking. RE ModelBuilder: the IT works in following way: it installs an agent, this one https://github.com/apache/maven-integration-testing/blob/master/core-it-support/core-it-javaagent/src/main/java/org/apache/maven/coreits/javaagent/mng5669/Premain.java#L49 that simply logs when DefaultModelReader#getSource is invoked and invocation params. Then the IT expects that the logged lines have no duplicates (file names), as that would mean that the POM XML was loaded up (parsed) two or more times. was (Author: cstamas): [~wecai] the IT is introduced for maven4, yes. But the point is that this IT never run with BF before (as it did not alter default collector). Now that resolver 2.0.0 makes BF default collector (MRESOLVER-324), the IT fails. Also, my guess is that the IT would fail with all released versions of new BF collector. It MAY be that the IT is wrong, am still looking. RE ModelBuilder: the IT works in following way: it installs an agent, this one https://github.com/apache/maven-integration-testing/blob/master/core-it-support/core-it-javaagent/src/main/java/org/apache/maven/coreits/javaagent/mng5669/Premain.java#L49 that simply logs out how is DefaultModelReader#getSource invoked and logs that out. Then the IT expects that the logged lines have no duplicates, as that would mean that the POM XML was loaded up (parsed) two or more times. > BF collector causes same model to be loaded up multiple times > - > > Key: MRESOLVER-412 > URL: https://issues.apache.org/jira/browse/MRESOLVER-412 > Project: Maven Resolver > Issue Type: Bug > Components: Resolver >Reporter: Tamas Cservenak >Priority: Major > Fix For: 2.0.0 > > > This bug probably affects all released versions of new BF collector. > Symptom is that Maven with BF collector fails MavenITmng5669ReadPomsOnce both > test methods. The IT verifies that POM XMLs are _read only once_ with and > without "consumer POM" feature enabled. Both IT methods fail (so failure is > irrelevant of consumer POM feature being enabled). Error consistently happens > on each subsequent IT invokcation, whether empty or prepopulated local repo. > Most probably cause: old DF was single threaded, while BF uses internally > thread pool, that seemingly causes that same POM XML is loaded up multiple > times as ModelBuilder is being asked multi threaded for different models by > BF collector. > Reproduce: either run MavenITmng5669ReadPomsOnce but modify the IT to enable > DF (if using Maven w/ resolver 1.x) or build Maven 4 w/ Resolver 2 (default > is BF). -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Comment Edited] (MRESOLVER-412) BF collector causes same model to be loaded up multiple times
[ https://issues.apache.org/jira/browse/MRESOLVER-412?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17776271#comment-17776271 ] Tamas Cservenak edited comment on MRESOLVER-412 at 10/17/23 4:34 PM: - [~wecai] the IT is introduced for maven4, yes. But the point is that this IT never run with BF before (as it did not alter default collector). Now that resolver 2.0.0 makes BF default collector (MRESOLVER-324), the IT fails. Also, my guess is that the IT would fail with all released versions of new BF collector. It MAY be that the IT is wrong, am still looking. RE ModelBuilder: the IT works in following way: it installs an agent, this one https://github.com/apache/maven-integration-testing/blob/master/core-it-support/core-it-javaagent/src/main/java/org/apache/maven/coreits/javaagent/mng5669/Premain.java#L49 that simply logs out how is DefaultModelReader#getSource invoked and logs that out. Then the IT expects that the logged lines have no duplicates, as that would mean that the POM XML was loaded up (parsed) two or more times. was (Author: cstamas): [~wecai] the IT is introduced for maven4, yes. But the point is that this IT never run with BF before (as it did not alter default collector). Now that resolver 2.0.0 makes BF default collector (MRESOLVER-324), the IT fails. Also, my guess is that the IT would fail with all released versions of new BF collector. It MAY be that the IT is wrong, am still looking. > BF collector causes same model to be loaded up multiple times > - > > Key: MRESOLVER-412 > URL: https://issues.apache.org/jira/browse/MRESOLVER-412 > Project: Maven Resolver > Issue Type: Bug > Components: Resolver >Reporter: Tamas Cservenak >Priority: Major > Fix For: 2.0.0 > > > This bug probably affects all released versions of new BF collector. > Symptom is that Maven with BF collector fails MavenITmng5669ReadPomsOnce both > test methods. The IT verifies that POM XMLs are _read only once_ with and > without "consumer POM" feature enabled. Both IT methods fail (so failure is > irrelevant of consumer POM feature being enabled). Error consistently happens > on each subsequent IT invokcation, whether empty or prepopulated local repo. > Most probably cause: old DF was single threaded, while BF uses internally > thread pool, that seemingly causes that same POM XML is loaded up multiple > times as ModelBuilder is being asked multi threaded for different models by > BF collector. > Reproduce: either run MavenITmng5669ReadPomsOnce but modify the IT to enable > DF (if using Maven w/ resolver 1.x) or build Maven 4 w/ Resolver 2 (default > is BF). -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MRESOLVER-412) BF collector causes same model to be loaded up multiple times
[ https://issues.apache.org/jira/browse/MRESOLVER-412?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17776271#comment-17776271 ] Tamas Cservenak commented on MRESOLVER-412: --- [~wecai] the IT is introduced for maven4, yes. But the point is that this IT never run with BF before (as it did not alter default collector). Now that resolver 2.0.0 makes BF default collector (MRESOLVER-324), the IT fails. Also, my guess is that the IT would fail with all released versions of new BF collector. It MAY be that the IT is wrong, am still looking. > BF collector causes same model to be loaded up multiple times > - > > Key: MRESOLVER-412 > URL: https://issues.apache.org/jira/browse/MRESOLVER-412 > Project: Maven Resolver > Issue Type: Bug > Components: Resolver >Reporter: Tamas Cservenak >Priority: Major > Fix For: 2.0.0 > > > This bug probably affects all released versions of new BF collector. > Symptom is that Maven with BF collector fails MavenITmng5669ReadPomsOnce both > test methods. The IT verifies that POM XMLs are _read only once_ with and > without "consumer POM" feature enabled. Both IT methods fail (so failure is > irrelevant of consumer POM feature being enabled). Error consistently happens > on each subsequent IT invokcation, whether empty or prepopulated local repo. > Most probably cause: old DF was single threaded, while BF uses internally > thread pool, that seemingly causes that same POM XML is loaded up multiple > times as ModelBuilder is being asked multi threaded for different models by > BF collector. > Reproduce: either run MavenITmng5669ReadPomsOnce but modify the IT to enable > DF (if using Maven w/ resolver 1.x) or build Maven 4 w/ Resolver 2 (default > is BF). -- This message was sent by Atlassian Jira (v8.20.10#820010)
[PR] [3.9.x] [MNG-7913] Upgrade Sisu version [maven]
cstamas opened a new pull request, #1286: URL: https://github.com/apache/maven/pull/1286 To version that supports gleaning JSR330 component classes up to Java 21. The reasoning of this change is only to allow 3rd party Maven plugins/Maven extensions/other JSR330 components (managed by Maven embedded Sisu) to use bytecode newer that Java 14 (Sisu 0.3.5). --- https://issues.apache.org/jira/browse/MNG-7913 Following this checklist to help us incorporate your contribution quickly and easily: - [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/MNG) filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes. - [ ] Each commit in the pull request should have a meaningful subject line and body. - [ ] Format the pull request title like `[MNG-XXX] SUMMARY`, where you replace `MNG-XXX` and `SUMMARY` with the appropriate JIRA issue. - [ ] Also format the first line of the commit message like `[MNG-XXX] SUMMARY`. Best practice is to use the JIRA issue title in both the pull request title and in the first line of the commit message. - [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [ ] Run `mvn clean verify` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically. - [ ] You have run the [Core IT][core-its] successfully. If your pull request is about ~20 lines of code you don't need to sign an [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure please ask on the developers list. To make clear that you license your contribution under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) you have to acknowledge this by using the following check-box. - [ ] I hereby declare this contribution to be licenced under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) - [ ] In any other case, please file an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). [core-its]: https://maven.apache.org/core-its/core-it-suite/ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MNG-7913) Upgrade Sisu version
[ https://issues.apache.org/jira/browse/MNG-7913?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17776242#comment-17776242 ] ASF GitHub Bot commented on MNG-7913: - cstamas opened a new pull request, #1286: URL: https://github.com/apache/maven/pull/1286 To version that supports gleaning JSR330 component classes up to Java 21. The reasoning of this change is only to allow 3rd party Maven plugins/Maven extensions/other JSR330 components (managed by Maven embedded Sisu) to use bytecode newer that Java 14 (Sisu 0.3.5). --- https://issues.apache.org/jira/browse/MNG-7913 Following this checklist to help us incorporate your contribution quickly and easily: - [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/MNG) filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes. - [ ] Each commit in the pull request should have a meaningful subject line and body. - [ ] Format the pull request title like `[MNG-XXX] SUMMARY`, where you replace `MNG-XXX` and `SUMMARY` with the appropriate JIRA issue. - [ ] Also format the first line of the commit message like `[MNG-XXX] SUMMARY`. Best practice is to use the JIRA issue title in both the pull request title and in the first line of the commit message. - [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [ ] Run `mvn clean verify` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically. - [ ] You have run the [Core IT][core-its] successfully. If your pull request is about ~20 lines of code you don't need to sign an [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure please ask on the developers list. To make clear that you license your contribution under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) you have to acknowledge this by using the following check-box. - [ ] I hereby declare this contribution to be licenced under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) - [ ] In any other case, please file an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). [core-its]: https://maven.apache.org/core-its/core-it-suite/ > Upgrade Sisu version > > > Key: MNG-7913 > URL: https://issues.apache.org/jira/browse/MNG-7913 > Project: Maven > Issue Type: Improvement > Components: Core >Reporter: Tamas Cservenak >Priority: Major > Fix For: 3.9.6 > > > Recently, as new Java versions are pushed out more aggressively (with Java 21 > out this autumn), seemingly it became normal that users developing Maven > plugins (and components used by those plugins) using bytecode level that is > Java14+. > But alas, Maven 3.9.x line uses Sisu 0.3.5 that is capable to glean bytecode > only up to Java 14. Components having higher version bytecode are silently > skipped by Sisu (no output about this, only at Sisu DEBUG level not emitted > by default). > Hence, it would make sense to up Sisu version to at least 0.9.0.M2 in Maven > 3.9.x as well, that would allow use of JSR330 components using bytecode more > recent that Java 14 is. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Comment Edited] (MNG-7587) Update Sisu to a version supporting at least Java 17
[
https://issues.apache.org/jira/browse/MNG-7587?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17776239#comment-17776239
]
Konrad Windszus edited comment on MNG-7587 at 10/17/23 2:37 PM:
[~cstamas] [~gnodet] I am still in favour of backporting this to Maven 3.9.x
given the discussion at
https://lists.apache.org/thread/6wxrhlkrqsl7wgr730xd50h55t7ff0vy. I am not sure
what are really the regressions faced here and whether there is an easy
workaround or fix we can just document.
was (Author: kwin):
[~cstamas] [~gnodet] I am still in favour of backporting this to Maven 3.9.x
given the discussion at
https://lists.apache.org/thread/6wxrhlkrqsl7wgr730xd50h55t7ff0vy. I am not sure
what are really the regressions faced here and whether there is an easy
workaround fix we can just document.
> Update Sisu to a version supporting at least Java 17
>
>
> Key: MNG-7587
> URL: https://issues.apache.org/jira/browse/MNG-7587
> Project: Maven
> Issue Type: Improvement
> Components: Core
>Reporter: Konrad Windszus
>Assignee: Guillaume Nodet
>Priority: Major
> Fix For: 4.0.0-alpha-7, 4.0.0
>
> Attachments: hello-maven-plugin.zip
>
>
> Version 0.3.5 (inherited from
> https://github.com/apache/maven-parent/blob/aff1eef5409009ca7f9d5f196233b2a575aba775/pom.xml#L934)
> in both Maven 4 and 3.9 of {{sisu.inject}} ships with ASM 5.0.2 (relaxed in
> https://github.com/eclipse/sisu.inject/commit/5e34add4790384dc764f77c9e31761cbc6e479aa
> to support up to Java 14).
> Given that Java 19 is the most recent one today Maven needs a newer version
> of {{sisu.inject}} to fully support newer Java bytecode than for Java 14.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MNG-7587) Update Sisu to a version supporting at least Java 17
[
https://issues.apache.org/jira/browse/MNG-7587?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17776239#comment-17776239
]
Konrad Windszus commented on MNG-7587:
--
[~cstamas] [~gnodet] I am still in favour of backporting this to Maven 3.9.x
given the discussion at
https://lists.apache.org/thread/6wxrhlkrqsl7wgr730xd50h55t7ff0vy. I am not sure
what are really the regressions faced here and whether there is an easy
workaround fix we can just document.
> Update Sisu to a version supporting at least Java 17
>
>
> Key: MNG-7587
> URL: https://issues.apache.org/jira/browse/MNG-7587
> Project: Maven
> Issue Type: Improvement
> Components: Core
>Reporter: Konrad Windszus
>Assignee: Guillaume Nodet
>Priority: Major
> Fix For: 4.0.0-alpha-7, 4.0.0
>
> Attachments: hello-maven-plugin.zip
>
>
> Version 0.3.5 (inherited from
> https://github.com/apache/maven-parent/blob/aff1eef5409009ca7f9d5f196233b2a575aba775/pom.xml#L934)
> in both Maven 4 and 3.9 of {{sisu.inject}} ships with ASM 5.0.2 (relaxed in
> https://github.com/eclipse/sisu.inject/commit/5e34add4790384dc764f77c9e31761cbc6e479aa
> to support up to Java 14).
> Given that Java 19 is the most recent one today Maven needs a newer version
> of {{sisu.inject}} to fully support newer Java bytecode than for Java 14.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Created] (MNG-7913) Upgrade Sisu version
Tamas Cservenak created MNG-7913: Summary: Upgrade Sisu version Key: MNG-7913 URL: https://issues.apache.org/jira/browse/MNG-7913 Project: Maven Issue Type: Improvement Components: Core Reporter: Tamas Cservenak Fix For: 3.9.6 Recently, as new Java versions are pushed out more aggressively (with Java 21 out this autumn), seemingly it became normal that users developing Maven plugins (and components used by those plugins) use bytecode that are Java14+. But alas, Maven 3.9.x line uses Sisu 0.3.5 that is capable to glean bytecode only up to Java 14. Components having higher version bytecode are silently skipped by Sisu (no output about this, only at Sisu DEBUG level not emitted by default). Hence, it would make sense to up Sisu version to at least 0.9.0.M2 in Maven 3.9.x as well, that would allow use of JSR330 components using bytecode more recent that Java 14 is. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (MNG-7913) Upgrade Sisu version
[ https://issues.apache.org/jira/browse/MNG-7913?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tamas Cservenak updated MNG-7913: - Description: Recently, as new Java versions are pushed out more aggressively (with Java 21 out this autumn), seemingly it became normal that users developing Maven plugins (and components used by those plugins) using bytecode level that is Java14+. But alas, Maven 3.9.x line uses Sisu 0.3.5 that is capable to glean bytecode only up to Java 14. Components having higher version bytecode are silently skipped by Sisu (no output about this, only at Sisu DEBUG level not emitted by default). Hence, it would make sense to up Sisu version to at least 0.9.0.M2 in Maven 3.9.x as well, that would allow use of JSR330 components using bytecode more recent that Java 14 is. was: Recently, as new Java versions are pushed out more aggressively (with Java 21 out this autumn), seemingly it became normal that users developing Maven plugins (and components used by those plugins) use bytecode that are Java14+. But alas, Maven 3.9.x line uses Sisu 0.3.5 that is capable to glean bytecode only up to Java 14. Components having higher version bytecode are silently skipped by Sisu (no output about this, only at Sisu DEBUG level not emitted by default). Hence, it would make sense to up Sisu version to at least 0.9.0.M2 in Maven 3.9.x as well, that would allow use of JSR330 components using bytecode more recent that Java 14 is. > Upgrade Sisu version > > > Key: MNG-7913 > URL: https://issues.apache.org/jira/browse/MNG-7913 > Project: Maven > Issue Type: Improvement > Components: Core >Reporter: Tamas Cservenak >Priority: Major > Fix For: 3.9.6 > > > Recently, as new Java versions are pushed out more aggressively (with Java 21 > out this autumn), seemingly it became normal that users developing Maven > plugins (and components used by those plugins) using bytecode level that is > Java14+. > But alas, Maven 3.9.x line uses Sisu 0.3.5 that is capable to glean bytecode > only up to Java 14. Components having higher version bytecode are silently > skipped by Sisu (no output about this, only at Sisu DEBUG level not emitted > by default). > Hence, it would make sense to up Sisu version to at least 0.9.0.M2 in Maven > 3.9.x as well, that would allow use of JSR330 components using bytecode more > recent that Java 14 is. -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] [MNG-7899] Various memory usage improvements 4 [maven]
sebastien-doyon commented on PR #1269: URL: https://github.com/apache/maven/pull/1269#issuecomment-1766473890 > @sebastien-doyon unit tests seem broken. @gnodet yes, I am trying to find the problem, but without access to the surefire report files, it is hard to find the problem. Do you have access or know how to get access to the target directory of a build in github? That would help debug. > Also and fwiw, this looks like all this work may be broken if we somehow integrate https://github.com/apache/maven/pull/1279... we may want to investigate on that branch then... I think the PR [1279](https://github.com/apache/maven/pull/1279) is complementary with this PR. The only change in the 1279 PR that would be needed is to add back the `MessageBuilder builder(StringBuilder stringBuilder)` method to `api/maven-api-core/src/main/java/org/apache/maven/api/services/MessageBuilderFactory.java` and `maven-core/src/main/java/org/apache/maven/internal/impl/DefaultMessageBuilderFactory.java` classes. > Also, https://github.com/apache/maven/pull/1268, https://github.com/apache/maven/pull/1269 and https://github.com/apache/maven/pull/1270 really look related to the same goal, I.e. optimize the logging, so I think they should be merged in order to have a better understand of the benefits (even if they could be 3 different commits). If you think, I was trying to separate unrelated changes so the obvious ones could be merged while those with problems or comments could be worked out separately, like this one. Tell me if you really prefer me to merge in on PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MNG-7899) Various memory usage improvements
[
https://issues.apache.org/jira/browse/MNG-7899?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17776228#comment-17776228
]
ASF GitHub Bot commented on MNG-7899:
-
sebastien-doyon commented on PR #1269:
URL: https://github.com/apache/maven/pull/1269#issuecomment-1766473890
> @sebastien-doyon unit tests seem broken.
@gnodet yes, I am trying to find the problem, but without access to the
surefire report files, it is hard to find the problem. Do you have access or
know how to get access to the target directory of a build in github? That would
help debug.
> Also and fwiw, this looks like all this work may be broken if we somehow
integrate https://github.com/apache/maven/pull/1279... we may want to
investigate on that branch then...
I think the PR [1279](https://github.com/apache/maven/pull/1279) is
complementary with this PR. The only change in the 1279 PR that would be needed
is to add back the `MessageBuilder builder(StringBuilder stringBuilder)` method
to
`api/maven-api-core/src/main/java/org/apache/maven/api/services/MessageBuilderFactory.java`
and
`maven-core/src/main/java/org/apache/maven/internal/impl/DefaultMessageBuilderFactory.java`
classes.
> Also, https://github.com/apache/maven/pull/1268,
https://github.com/apache/maven/pull/1269 and
https://github.com/apache/maven/pull/1270 really look related to the same goal,
I.e. optimize the logging, so I think they should be merged in order to have a
better understand of the benefits (even if they could be 3 different commits).
If you think, I was trying to separate unrelated changes so the obvious ones
could be merged while those with problems or comments could be worked out
separately, like this one. Tell me if you really prefer me to merge in on PR.
> Various memory usage improvements
> -
>
> Key: MNG-7899
> URL: https://issues.apache.org/jira/browse/MNG-7899
> Project: Maven
> Issue Type: Improvement
> Components: Design, Patterns Best Practices, Embedding,
> General, Logging
>Affects Versions: 4.0.0-alpha-2
>Reporter: sebastien
>Priority: Major
>
> Some optimisations can be applied to the code to reduce the use of temporary
> objects.
> Typical improvements identified are:
> * reduce scope of temporary objects creation to avoid creating when not
> needed. Example :
> {code:java}
> public String toString() {
> StringBuilder sb = new StringBuilder(512);
> if (isEmpty()) {
> return "empty";
> }
> for (MetadataGraphVertex v : vertices) {
> .{code}
> can be replaced by
> {code:java}
> public String toString() {
> if (isEmpty()) {
> return "empty";
> }
> StringBuilder sb = new StringBuilder(512);
> for (MetadataGraphVertex v : vertices) {
> .{code}
> * Reuse StringBuilder objects in loops by setting its length to zero
> * Use the StringBuilder.append() with index to avoid String.substring().
> Example:
>
> {code:java}
> int idx = resourceName.lastIndexOf('/');
> buffer.append(idx < 0 ? resourceName : resourceName.substring(idx + 1));
> {code}
> can be replaced by
>
> {code:java}
> int idx = resourceName.lastIndexOf('/');
> if (idx < 0) {
> buffer.append(resourceName);
> } else {
> buffer.append(resourceName, idx + 1, resourceName.length());
> } {code}
>
>
> * Replace dynamic string creation static constants when possible
> * Avoid creating temporary strings with + operator when the final
> destination can be used instead, like PrintStream.print() method
> * Avoir using StringBuilder.append() method and util method MessageUtils.a()
> when the final destination can be used instead, like PrintStream.print()
> method
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[PR] Bump org.codehaus.plexus:plexus-java from 1.1.2 to 1.2.0 [maven-plugin-tools]
dependabot[bot] opened a new pull request, #231: URL: https://github.com/apache/maven-plugin-tools/pull/231 Bumps [org.codehaus.plexus:plexus-java](https://github.com/codehaus-plexus/plexus-languages) from 1.1.2 to 1.2.0. Release notes Sourced from https://github.com/codehaus-plexus/plexus-languages/releases;>org.codehaus.plexus:plexus-java's releases. 1.2.0 Fail on duplicate modules on the module path (https://redirect.github.com/codehaus-plexus/plexus-languages/pull/172;>#172) https://github.com/hgschmie;>@hgschmie Add java bytecode class file version detection (https://redirect.github.com/codehaus-plexus/plexus-languages/pull/170;>#170) https://github.com/jorsol;>@jorsol Fix badge in README (https://redirect.github.com/codehaus-plexus/plexus-languages/pull/167;>#167) https://github.com/jorsol;>@jorsol (doc) Fix scm protocol (https://redirect.github.com/codehaus-plexus/plexus-languages/pull/144;>#144) https://github.com/pzygielo;>@pzygielo Dependency updates Bump org.ow2.asm:asm from 9.5 to 9.6 (https://redirect.github.com/codehaus-plexus/plexus-languages/pull/173;>#173) https://github.com/dependabot;>@dependabot Bump org.ow2.asm:asm from 9.4 to 9.5 (https://redirect.github.com/codehaus-plexus/plexus-languages/pull/153;>#153) https://github.com/dependabot;>@dependabot Bump guice from 5.1.0 to 6.0.0 (test scope)(https://redirect.github.com/codehaus-plexus/plexus-languages/pull/160;>#160) https://github.com/dependabot;>@dependabot Maintenance Run CI with Java 21 (https://redirect.github.com/codehaus-plexus/plexus-languages/pull/168;>#168) https://github.com/slachiewicz;>@slachiewicz Convert tests to JUnit 5 (https://redirect.github.com/codehaus-plexus/plexus-languages/pull/166;>#166) https://github.com/slachiewicz;>@slachiewicz Bump org.codehaus.plexus:plexus from 14 to 15 (https://redirect.github.com/codehaus-plexus/plexus-languages/pull/174;>#174) https://github.com/dependabot;>@dependabot Bump org.codehaus.plexus:plexus from 13 to 14 (https://redirect.github.com/codehaus-plexus/plexus-languages/pull/163;>#163) https://github.com/dependabot;>@dependabot Bump plexus from 10 to 13 (https://redirect.github.com/codehaus-plexus/plexus-languages/pull/161;>#161) https://github.com/dependabot;>@dependabot Bump actions/checkout from 3 to 4 (https://redirect.github.com/codehaus-plexus/plexus-languages/pull/171;>#171) https://github.com/dependabot;>@dependabot Bump maven-checkstyle-plugin from 3.2.1 to 3.2.2 (https://redirect.github.com/codehaus-plexus/plexus-languages/pull/155;>#155) https://github.com/dependabot;>@dependabot Bump maven-checkstyle-plugin from 3.2.0 to 3.2.1 (https://redirect.github.com/codehaus-plexus/plexus-languages/pull/145;>#145) https://github.com/dependabot;>@dependabot Bump maven-enforcer-plugin from 3.2.1 to 3.3.0 (https://redirect.github.com/codehaus-plexus/plexus-languages/pull/154;>#154) https://github.com/dependabot;>@dependabot Bump maven-enforcer-plugin from 3.1.0 to 3.2.1 (https://redirect.github.com/codehaus-plexus/plexus-languages/pull/149;>#149) https://github.com/dependabot;>@dependabot Bump maven-failsafe-plugin from 2.22.2 to 3.0.0 (https://redirect.github.com/codehaus-plexus/plexus-languages/pull/152;>#152) https://github.com/dependabot;>@dependabot Bump maven-surefire-plugin from 2.22.2 to 3.0.0 (https://redirect.github.com/codehaus-plexus/plexus-languages/pull/151;>#151) https://github.com/dependabot;>@dependabot Bump maven-javadoc-plugin from 3.4.1 to 3.5.0 (https://redirect.github.com/codehaus-plexus/plexus-languages/pull/150;>#150) https://github.com/dependabot;>@dependabot Commits https://github.com/codehaus-plexus/plexus-languages/commit/9036768c40d36dc26ccbc96a5c4693b4981e9fea;>9036768 [maven-release-plugin] prepare release plexus-languages-1.2.0 https://github.com/codehaus-plexus/plexus-languages/commit/e7df12c15f310b20f8d7aeb21262bbb6cfe4bce5;>e7df12c Bump Site Fluido Skin to 1.12.0 https://github.com/codehaus-plexus/plexus-languages/commit/4dfc56b885ac2b724b8ff0b3f84fe471b4366cb6;>4dfc56b Remove redundant overwrite for junit5Version https://github.com/codehaus-plexus/plexus-languages/commit/dacf8b232db395e07249f11adadd3e3b1b86a984;>dacf8b2 Remove redundant profile after parent pom update https://github.com/codehaus-plexus/plexus-languages/commit/477fb79bd95a69a4d607dbcd10d8e407fc636ec4;>477fb79 Cleanup after parent pom update https://github.com/codehaus-plexus/plexus-languages/commit/9cc4a3f6e4a4c9b079861594c76c8e4fe713843c;>9cc4a3f Bump org.codehaus.plexus:plexus from 14 to 15 https://github.com/codehaus-plexus/plexus-languages/commit/76d72d36f1f5e3389d134a3f997a6de10da0b23c;>76d72d3 Bump org.ow2.asm:asm from 9.5 to 9.6 https://github.com/codehaus-plexus/plexus-languages/commit/3a1f22b6022bab708d720f5f9ac91ecc03949eb3;>3a1f22b Fail on duplicate modules
[I] Feature request: install with winget and just a zip file [maven-mvnd]
nicenemo opened a new issue, #892: URL: https://github.com/apache/maven-mvnd/issues/892 As a Java developer on windows I would like to be able to install maven_mvnd using winget. Alternatively I want to be able to just download a zip file and have instructions on what to configure, just in case IT blocks winget or other install methods. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] Bump org.codehaus.plexus:plexus-java from 1.1.2 to 1.2.0 [maven-jxr]
dependabot[bot] opened a new pull request, #102: URL: https://github.com/apache/maven-jxr/pull/102 Bumps [org.codehaus.plexus:plexus-java](https://github.com/codehaus-plexus/plexus-languages) from 1.1.2 to 1.2.0. Release notes Sourced from https://github.com/codehaus-plexus/plexus-languages/releases;>org.codehaus.plexus:plexus-java's releases. 1.2.0 Fail on duplicate modules on the module path (https://redirect.github.com/codehaus-plexus/plexus-languages/pull/172;>#172) https://github.com/hgschmie;>@hgschmie Add java bytecode class file version detection (https://redirect.github.com/codehaus-plexus/plexus-languages/pull/170;>#170) https://github.com/jorsol;>@jorsol Fix badge in README (https://redirect.github.com/codehaus-plexus/plexus-languages/pull/167;>#167) https://github.com/jorsol;>@jorsol (doc) Fix scm protocol (https://redirect.github.com/codehaus-plexus/plexus-languages/pull/144;>#144) https://github.com/pzygielo;>@pzygielo Dependency updates Bump org.ow2.asm:asm from 9.5 to 9.6 (https://redirect.github.com/codehaus-plexus/plexus-languages/pull/173;>#173) https://github.com/dependabot;>@dependabot Bump org.ow2.asm:asm from 9.4 to 9.5 (https://redirect.github.com/codehaus-plexus/plexus-languages/pull/153;>#153) https://github.com/dependabot;>@dependabot Bump guice from 5.1.0 to 6.0.0 (test scope)(https://redirect.github.com/codehaus-plexus/plexus-languages/pull/160;>#160) https://github.com/dependabot;>@dependabot Maintenance Run CI with Java 21 (https://redirect.github.com/codehaus-plexus/plexus-languages/pull/168;>#168) https://github.com/slachiewicz;>@slachiewicz Convert tests to JUnit 5 (https://redirect.github.com/codehaus-plexus/plexus-languages/pull/166;>#166) https://github.com/slachiewicz;>@slachiewicz Bump org.codehaus.plexus:plexus from 14 to 15 (https://redirect.github.com/codehaus-plexus/plexus-languages/pull/174;>#174) https://github.com/dependabot;>@dependabot Bump org.codehaus.plexus:plexus from 13 to 14 (https://redirect.github.com/codehaus-plexus/plexus-languages/pull/163;>#163) https://github.com/dependabot;>@dependabot Bump plexus from 10 to 13 (https://redirect.github.com/codehaus-plexus/plexus-languages/pull/161;>#161) https://github.com/dependabot;>@dependabot Bump actions/checkout from 3 to 4 (https://redirect.github.com/codehaus-plexus/plexus-languages/pull/171;>#171) https://github.com/dependabot;>@dependabot Bump maven-checkstyle-plugin from 3.2.1 to 3.2.2 (https://redirect.github.com/codehaus-plexus/plexus-languages/pull/155;>#155) https://github.com/dependabot;>@dependabot Bump maven-checkstyle-plugin from 3.2.0 to 3.2.1 (https://redirect.github.com/codehaus-plexus/plexus-languages/pull/145;>#145) https://github.com/dependabot;>@dependabot Bump maven-enforcer-plugin from 3.2.1 to 3.3.0 (https://redirect.github.com/codehaus-plexus/plexus-languages/pull/154;>#154) https://github.com/dependabot;>@dependabot Bump maven-enforcer-plugin from 3.1.0 to 3.2.1 (https://redirect.github.com/codehaus-plexus/plexus-languages/pull/149;>#149) https://github.com/dependabot;>@dependabot Bump maven-failsafe-plugin from 2.22.2 to 3.0.0 (https://redirect.github.com/codehaus-plexus/plexus-languages/pull/152;>#152) https://github.com/dependabot;>@dependabot Bump maven-surefire-plugin from 2.22.2 to 3.0.0 (https://redirect.github.com/codehaus-plexus/plexus-languages/pull/151;>#151) https://github.com/dependabot;>@dependabot Bump maven-javadoc-plugin from 3.4.1 to 3.5.0 (https://redirect.github.com/codehaus-plexus/plexus-languages/pull/150;>#150) https://github.com/dependabot;>@dependabot Commits https://github.com/codehaus-plexus/plexus-languages/commit/9036768c40d36dc26ccbc96a5c4693b4981e9fea;>9036768 [maven-release-plugin] prepare release plexus-languages-1.2.0 https://github.com/codehaus-plexus/plexus-languages/commit/e7df12c15f310b20f8d7aeb21262bbb6cfe4bce5;>e7df12c Bump Site Fluido Skin to 1.12.0 https://github.com/codehaus-plexus/plexus-languages/commit/4dfc56b885ac2b724b8ff0b3f84fe471b4366cb6;>4dfc56b Remove redundant overwrite for junit5Version https://github.com/codehaus-plexus/plexus-languages/commit/dacf8b232db395e07249f11adadd3e3b1b86a984;>dacf8b2 Remove redundant profile after parent pom update https://github.com/codehaus-plexus/plexus-languages/commit/477fb79bd95a69a4d607dbcd10d8e407fc636ec4;>477fb79 Cleanup after parent pom update https://github.com/codehaus-plexus/plexus-languages/commit/9cc4a3f6e4a4c9b079861594c76c8e4fe713843c;>9cc4a3f Bump org.codehaus.plexus:plexus from 14 to 15 https://github.com/codehaus-plexus/plexus-languages/commit/76d72d36f1f5e3389d134a3f997a6de10da0b23c;>76d72d3 Bump org.ow2.asm:asm from 9.5 to 9.6 https://github.com/codehaus-plexus/plexus-languages/commit/3a1f22b6022bab708d720f5f9ac91ecc03949eb3;>3a1f22b Fail on duplicate modules on the
[jira] [Resolved] (MCOMPILER-549) improve recompilation cause display
[ https://issues.apache.org/jira/browse/MCOMPILER-549?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Maarten Mulders resolved MCOMPILER-549. --- Resolution: Fixed Fixed in [#628c3339|https://github.com/apache/maven-compiler-plugin/commit/628c33399cdfb4ea49dba580f98ddecdffdc3d20]. > improve recompilation cause display > --- > > Key: MCOMPILER-549 > URL: https://issues.apache.org/jira/browse/MCOMPILER-549 > Project: Maven Compiler Plugin > Issue Type: Improvement >Affects Versions: 3.11.0 >Reporter: Herve Boutemy >Assignee: Maarten Mulders >Priority: Major > Fix For: 3.11.1 > > > recompilation cause message has been implemented in MCOMPILER-499 > But message format is strange and some values are not clear: see last comment > in MCOMPILER-499 and users feedback > https://lists.apache.org/thread/on96m5fkngm43tppr67hxrjmk3wy2s79 > we need to improve the message a little bit -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] Reuse the same repository so that ITs can access maven snapshot jars from the repository [maven]
gnodet commented on PR #1277: URL: https://github.com/apache/maven/pull/1277#issuecomment-1765944922 @slawekjaranowski it seems to be working now :-) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (SUREFIRE-2203) In pom.xml, the configurationParameters configuration junit.platform.launcher.interceptors.enabled does not work
[
https://issues.apache.org/jira/browse/SUREFIRE-2203?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Hengyunabc Chen updated SUREFIRE-2203:
--
Description:
In pom.xml, the configuration {{junit.platform.launcher.interceptors.enabled}}
does not work.
The following configuration does not take effect:
{code:java}
maven-surefire-plugin
3.1.2
junit.platform.launcher.interceptors.enabled=true
{code}
The following configuration can work:
{code:java}
maven-surefire-plugin
3.1.2
true
{code}
Or configuring it in the {{junit-platform.properties}} file will also work.
Reference documentation:
*
[https://junit.org/junit5/docs/snapshot/user-guide/#launcher-api-launcher-interceptors-custom]
*
[https://junit.org/junit5/docs/snapshot/user-guide/#running-tests-build-maven-config-params]
*
[https://maven.apache.org/surefire/maven-surefire-plugin/examples/junit-platform.html#configuration-parameters]
was:
In pom.xml, the configuration {{junit.platform.launcher.interceptors.enabled}}
does not work.
The following configuration does not take effect:
maven-surefire-plugin
3.1.2
junit.platform.launcher.interceptors.enabled=true
The following configuration can work:
maven-surefire-plugin
3.1.2
true
Or configuring it in the {{junit-platform.properties}} file will also work.
Reference documentation:
*
[https://junit.org/junit5/docs/snapshot/user-guide/#launcher-api-launcher-interceptors-custom]
*
[https://junit.org/junit5/docs/snapshot/user-guide/#running-tests-build-maven-config-params]
*
[https://maven.apache.org/surefire/maven-surefire-plugin/examples/junit-platform.html#configuration-parameters]
> In pom.xml, the configurationParameters configuration
> junit.platform.launcher.interceptors.enabled does not work
>
>
> Key: SUREFIRE-2203
> URL: https://issues.apache.org/jira/browse/SUREFIRE-2203
> Project: Maven Surefire
> Issue Type: Bug
> Components: JUnit 5.x support
>Reporter: Hengyunabc Chen
>Priority: Trivial
>
> In pom.xml, the configuration
> {{junit.platform.launcher.interceptors.enabled}} does not work.
> The following configuration does not take effect:
> {code:java}
>
> maven-surefire-plugin
> 3.1.2
>
>
>
> junit.platform.launcher.interceptors.enabled=true
>
>
> {code}
>
> The following configuration can work:
> {code:java}
>
> maven-surefire-plugin
> 3.1.2
>
>
>
> true
>
> {code}
>
> Or configuring it in the {{junit-platform.properties}} file will also work.
> Reference documentation:
> *
> [https://junit.org/junit5/docs/snapshot/user-guide/#launcher-api-launcher-interceptors-custom]
> *
> [https://junit.org/junit5/docs/snapshot/user-guide/#running-tests-build-maven-config-params]
> *
> [https://maven.apache.org/surefire/maven-surefire-plugin/examples/junit-platform.html#configuration-parameters]
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Created] (SUREFIRE-2203) In pom.xml, the configurationParameters configuration junit.platform.launcher.interceptors.enabled does not work
Hengyunabc Chen created SUREFIRE-2203:
-
Summary: In pom.xml, the configurationParameters configuration
junit.platform.launcher.interceptors.enabled does not work
Key: SUREFIRE-2203
URL: https://issues.apache.org/jira/browse/SUREFIRE-2203
Project: Maven Surefire
Issue Type: Bug
Components: JUnit 5.x support
Reporter: Hengyunabc Chen
In pom.xml, the configuration {{junit.platform.launcher.interceptors.enabled}}
does not work.
The following configuration does not take effect:
maven-surefire-plugin
3.1.2
junit.platform.launcher.interceptors.enabled=true
The following configuration can work:
maven-surefire-plugin
3.1.2
true
Or configuring it in the {{junit-platform.properties}} file will also work.
Reference documentation:
*
[https://junit.org/junit5/docs/snapshot/user-guide/#launcher-api-launcher-interceptors-custom]
*
[https://junit.org/junit5/docs/snapshot/user-guide/#running-tests-build-maven-config-params]
*
[https://maven.apache.org/surefire/maven-surefire-plugin/examples/junit-platform.html#configuration-parameters]
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
Re: [PR] Add JDK 21 [maven-jenkins-env]
olamy merged PR #3: URL: https://github.com/apache/maven-jenkins-env/pull/3 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
