[jira] [Closed] (SUREFIRE-2207) Fails with modular project with Java 21

2023-11-02 Thread Slawomir Jaranowski (Jira)


 [ 
https://issues.apache.org/jira/browse/SUREFIRE-2207?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Slawomir Jaranowski closed SUREFIRE-2207.
-
Resolution: Fixed

> Fails with modular project with Java 21
> ---
>
> Key: SUREFIRE-2207
> URL: https://issues.apache.org/jira/browse/SUREFIRE-2207
> Project: Maven Surefire
>  Issue Type: Bug
>Reporter: Frank Ulbricht
>Assignee: Slawomir Jaranowski
>Priority: Major
> Fix For: version-next
>
> Attachments: example_java21.zip
>
>
> In a modular Java 21 project Surefire fails to execute tests that require 
> access to the module. It seems, Surefire tries to patch the module but 
> somehow the module is not known by Java.
> I added a minimal example to demonstrate the problem. Just run "mvnw test" to 
> reproduce.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[PR] Bump org.codehaus.mojo:mrm-maven-plugin from 1.5.0 to 1.6.0 [maven-site-plugin]

2023-11-02 Thread via GitHub


dependabot[bot] opened a new pull request, #163:
URL: https://github.com/apache/maven-site-plugin/pull/163

   Bumps [org.codehaus.mojo:mrm-maven-plugin](https://github.com/mojohaus/mrm) 
from 1.5.0 to 1.6.0.
   
   Release notes
   Sourced from https://github.com/mojohaus/mrm/releases";>org.codehaus.mojo:mrm-maven-plugin's
 releases.
   
   1.6.0
   
   :boom: Breaking changes
   
   Remove support for listing directory as html page and cleanups (https://redirect.github.com/mojohaus/mrm/pull/176";>#176) https://github.com/slawekjaranowski";>@鈥媠lawekjaranowski
   Remove of downloading predefined settings.xml by run mojo (https://redirect.github.com/mojohaus/mrm/pull/174";>#174) https://github.com/slawekjaranowski";>@鈥媠lawekjaranowski
   
   馃殌 New features and improvements
   
   Support SNAPSHOT versions by localRepo (https://redirect.github.com/mojohaus/mrm/pull/185";>#185) https://github.com/slawekjaranowski";>@鈥媠lawekjaranowski
   Require Maven 3.6.3+ (https://redirect.github.com/mojohaus/mrm/pull/184";>#184) https://github.com/slachiewicz";>@鈥媠lachiewicz
   Get rid of usage RepositoryMetadataManager (https://redirect.github.com/mojohaus/mrm/pull/182";>#182) https://github.com/slawekjaranowski";>@鈥媠lawekjaranowski
   Remove ${localRepository} and other from plugin parameters (https://redirect.github.com/mojohaus/mrm/pull/173";>#173) https://github.com/slawekjaranowski";>@鈥媠lawekjaranowski
   Get rid usage of deprecated ArtifactFactory (https://redirect.github.com/mojohaus/mrm/pull/171";>#171) https://github.com/slawekjaranowski";>@鈥媠lawekjaranowski
   Switch to JUnit 5 (https://redirect.github.com/mojohaus/mrm/pull/170";>#170) https://github.com/slawekjaranowski";>@鈥媠lawekjaranowski
   Resolves https://redirect.github.com/mojohaus/mrm/issues/99";>#99: Removing 
dependencies on maven-artifact-manager from Maven 2 (https://redirect.github.com/mojohaus/mrm/pull/157";>#157) https://github.com/ajarmoniuk";>@鈥媋jarmoniuk
   https://redirect.github.com/mojohaus/mrm/issues/99";>#99: 
First stage of maven 3 migration (https://redirect.github.com/mojohaus/mrm/pull/144";>#144) https://github.com/ajarmoniuk";>@鈥媋jarmoniuk
   
   馃悰 Bug Fixes
   
   Workaround for https://redirect.github.com/mojohaus/mrm/issues/179";>#179 - skip 
checksums for deployed metadata (https://redirect.github.com/mojohaus/mrm/pull/180";>#180) https://github.com/slawekjaranowski";>@鈥媠lawekjaranowski
   
   馃摝 Dependency updates
   
   Bump commons-io:commons-io from 2.14.0 to 2.15.0 (https://redirect.github.com/mojohaus/mrm/pull/186";>#186) https://github.com/dependabot";>@鈥媎ependabot
   Require Maven 3.6.3+ (https://redirect.github.com/mojohaus/mrm/pull/184";>#184) https://github.com/slachiewicz";>@鈥媠lachiewicz
   Bump jetty.version from 9.4.52.v20230823 to 9.4.53.v20231009 (https://redirect.github.com/mojohaus/mrm/pull/183";>#183) https://github.com/dependabot";>@鈥媎ependabot
   Bump plexus-utils from 3.5.1 to 4.0.0 and add plexus-xml 3.0.0 (https://redirect.github.com/mojohaus/mrm/pull/163";>#163) https://github.com/dependabot";>@鈥媎ependabot
   Bump org.codehaus.mojo:mojo-parent from 76 to 77 (https://redirect.github.com/mojohaus/mrm/pull/178";>#178) https://github.com/dependabot";>@鈥媎ependabot
   Bump commons-io:commons-io from 2.13.0 to 2.14.0 (https://redirect.github.com/mojohaus/mrm/pull/175";>#175) https://github.com/dependabot";>@鈥媎ependabot
   Bump jetty.version from 9.4.51.v20230217 to 9.4.52.v20230823 (https://redirect.github.com/mojohaus/mrm/pull/167";>#167) https://github.com/dependabot";>@鈥媎ependabot
   Bump parent from 72 to 76 (https://redirect.github.com/mojohaus/mrm/pull/168";>#168) https://github.com/slawekjaranowski";>@鈥媠lawekjaranowski
   Bump commons-io from 2.12.0 to 2.13.0 (https://redirect.github.com/mojohaus/mrm/pull/164";>#164) https://github.com/dependabot";>@鈥媎ependabot
   Bump org.codehaus.plexus:plexus-archiver from 4.7.1 to 4.8.0 (https://redirect.github.com/mojohaus/mrm/pull/166";>#166) https://github.com/dependabot";>@鈥媎ependabot
   Bump commons-io from 2.11.0 to 2.12.0 (https://redirect.github.com/mojohaus/mrm/pull/160";>#160) https://github.com/dependabot";>@鈥媎ependabot
   Bump plexus-archiver from 4.6.3 to 4.7.1 (https://redirect.github.com/mojohaus/mrm/pull/159";>#159) https://github.com/dependabot";>@鈥媎ependabot
   Bump plexus-archiver from 4.6.2 to 4.6.3 (https://redirect.github.com/mojohaus/mrm/pull/156";>#156) https://github.com/dependabot";>@鈥媎ependabot
   Bump jetty.version from 9.4.50.v20221201 to 9.4.51.v20230217 (https://redirect.github.com/mojohaus/mrm/pull/153";>#153) https://github.com/dependabot";>@鈥媎ependabot
   Bump plexus-archiver from 4.6.1 to 4.6.2 (https://redirect.github.com/mojohaus/mrm/pull/154";>#154) https://github.com/dependabot";>@鈥媎ependabot
   Bump plexus-utils from 3.5.0 to 3.5.1 (https://redirect.github.com/mojohaus/mrm/pull/155";>#155) https://github.com/dependabot";>@鈥媎ependabot
   Bump plexus-archiver from 4.6.0 to 4.6.1 (https://redirect.github.com/mojohaus/mrm/pull/142"

[PR] Bump org.codehaus.mojo:mrm-maven-plugin from 1.5.0 to 1.6.0 [maven-release]

2023-11-02 Thread via GitHub


dependabot[bot] opened a new pull request, #200:
URL: https://github.com/apache/maven-release/pull/200

   Bumps [org.codehaus.mojo:mrm-maven-plugin](https://github.com/mojohaus/mrm) 
from 1.5.0 to 1.6.0.
   
   Release notes
   Sourced from https://github.com/mojohaus/mrm/releases";>org.codehaus.mojo:mrm-maven-plugin's
 releases.
   
   1.6.0
   
   :boom: Breaking changes
   
   Remove support for listing directory as html page and cleanups (https://redirect.github.com/mojohaus/mrm/pull/176";>#176) https://github.com/slawekjaranowski";>@鈥媠lawekjaranowski
   Remove of downloading predefined settings.xml by run mojo (https://redirect.github.com/mojohaus/mrm/pull/174";>#174) https://github.com/slawekjaranowski";>@鈥媠lawekjaranowski
   
   馃殌 New features and improvements
   
   Support SNAPSHOT versions by localRepo (https://redirect.github.com/mojohaus/mrm/pull/185";>#185) https://github.com/slawekjaranowski";>@鈥媠lawekjaranowski
   Require Maven 3.6.3+ (https://redirect.github.com/mojohaus/mrm/pull/184";>#184) https://github.com/slachiewicz";>@鈥媠lachiewicz
   Get rid of usage RepositoryMetadataManager (https://redirect.github.com/mojohaus/mrm/pull/182";>#182) https://github.com/slawekjaranowski";>@鈥媠lawekjaranowski
   Remove ${localRepository} and other from plugin parameters (https://redirect.github.com/mojohaus/mrm/pull/173";>#173) https://github.com/slawekjaranowski";>@鈥媠lawekjaranowski
   Get rid usage of deprecated ArtifactFactory (https://redirect.github.com/mojohaus/mrm/pull/171";>#171) https://github.com/slawekjaranowski";>@鈥媠lawekjaranowski
   Switch to JUnit 5 (https://redirect.github.com/mojohaus/mrm/pull/170";>#170) https://github.com/slawekjaranowski";>@鈥媠lawekjaranowski
   Resolves https://redirect.github.com/mojohaus/mrm/issues/99";>#99: Removing 
dependencies on maven-artifact-manager from Maven 2 (https://redirect.github.com/mojohaus/mrm/pull/157";>#157) https://github.com/ajarmoniuk";>@鈥媋jarmoniuk
   https://redirect.github.com/mojohaus/mrm/issues/99";>#99: 
First stage of maven 3 migration (https://redirect.github.com/mojohaus/mrm/pull/144";>#144) https://github.com/ajarmoniuk";>@鈥媋jarmoniuk
   
   馃悰 Bug Fixes
   
   Workaround for https://redirect.github.com/mojohaus/mrm/issues/179";>#179 - skip 
checksums for deployed metadata (https://redirect.github.com/mojohaus/mrm/pull/180";>#180) https://github.com/slawekjaranowski";>@鈥媠lawekjaranowski
   
   馃摝 Dependency updates
   
   Bump commons-io:commons-io from 2.14.0 to 2.15.0 (https://redirect.github.com/mojohaus/mrm/pull/186";>#186) https://github.com/dependabot";>@鈥媎ependabot
   Require Maven 3.6.3+ (https://redirect.github.com/mojohaus/mrm/pull/184";>#184) https://github.com/slachiewicz";>@鈥媠lachiewicz
   Bump jetty.version from 9.4.52.v20230823 to 9.4.53.v20231009 (https://redirect.github.com/mojohaus/mrm/pull/183";>#183) https://github.com/dependabot";>@鈥媎ependabot
   Bump plexus-utils from 3.5.1 to 4.0.0 and add plexus-xml 3.0.0 (https://redirect.github.com/mojohaus/mrm/pull/163";>#163) https://github.com/dependabot";>@鈥媎ependabot
   Bump org.codehaus.mojo:mojo-parent from 76 to 77 (https://redirect.github.com/mojohaus/mrm/pull/178";>#178) https://github.com/dependabot";>@鈥媎ependabot
   Bump commons-io:commons-io from 2.13.0 to 2.14.0 (https://redirect.github.com/mojohaus/mrm/pull/175";>#175) https://github.com/dependabot";>@鈥媎ependabot
   Bump jetty.version from 9.4.51.v20230217 to 9.4.52.v20230823 (https://redirect.github.com/mojohaus/mrm/pull/167";>#167) https://github.com/dependabot";>@鈥媎ependabot
   Bump parent from 72 to 76 (https://redirect.github.com/mojohaus/mrm/pull/168";>#168) https://github.com/slawekjaranowski";>@鈥媠lawekjaranowski
   Bump commons-io from 2.12.0 to 2.13.0 (https://redirect.github.com/mojohaus/mrm/pull/164";>#164) https://github.com/dependabot";>@鈥媎ependabot
   Bump org.codehaus.plexus:plexus-archiver from 4.7.1 to 4.8.0 (https://redirect.github.com/mojohaus/mrm/pull/166";>#166) https://github.com/dependabot";>@鈥媎ependabot
   Bump commons-io from 2.11.0 to 2.12.0 (https://redirect.github.com/mojohaus/mrm/pull/160";>#160) https://github.com/dependabot";>@鈥媎ependabot
   Bump plexus-archiver from 4.6.3 to 4.7.1 (https://redirect.github.com/mojohaus/mrm/pull/159";>#159) https://github.com/dependabot";>@鈥媎ependabot
   Bump plexus-archiver from 4.6.2 to 4.6.3 (https://redirect.github.com/mojohaus/mrm/pull/156";>#156) https://github.com/dependabot";>@鈥媎ependabot
   Bump jetty.version from 9.4.50.v20221201 to 9.4.51.v20230217 (https://redirect.github.com/mojohaus/mrm/pull/153";>#153) https://github.com/dependabot";>@鈥媎ependabot
   Bump plexus-archiver from 4.6.1 to 4.6.2 (https://redirect.github.com/mojohaus/mrm/pull/154";>#154) https://github.com/dependabot";>@鈥媎ependabot
   Bump plexus-utils from 3.5.0 to 3.5.1 (https://redirect.github.com/mojohaus/mrm/pull/155";>#155) https://github.com/dependabot";>@鈥媎ependabot
   Bump plexus-archiver from 4.6.0 to 4.6.1 (https://redirect.github.com/mojohaus/mrm/pull/142";>#1

[PR] Bump org.codehaus.mojo:mrm-maven-plugin from 1.5.0 to 1.6.0 [maven-shade-plugin]

2023-11-02 Thread via GitHub


dependabot[bot] opened a new pull request, #201:
URL: https://github.com/apache/maven-shade-plugin/pull/201

   Bumps [org.codehaus.mojo:mrm-maven-plugin](https://github.com/mojohaus/mrm) 
from 1.5.0 to 1.6.0.
   
   Release notes
   Sourced from https://github.com/mojohaus/mrm/releases";>org.codehaus.mojo:mrm-maven-plugin's
 releases.
   
   1.6.0
   
   :boom: Breaking changes
   
   Remove support for listing directory as html page and cleanups (https://redirect.github.com/mojohaus/mrm/pull/176";>#176) https://github.com/slawekjaranowski";>@鈥媠lawekjaranowski
   Remove of downloading predefined settings.xml by run mojo (https://redirect.github.com/mojohaus/mrm/pull/174";>#174) https://github.com/slawekjaranowski";>@鈥媠lawekjaranowski
   
   馃殌 New features and improvements
   
   Support SNAPSHOT versions by localRepo (https://redirect.github.com/mojohaus/mrm/pull/185";>#185) https://github.com/slawekjaranowski";>@鈥媠lawekjaranowski
   Require Maven 3.6.3+ (https://redirect.github.com/mojohaus/mrm/pull/184";>#184) https://github.com/slachiewicz";>@鈥媠lachiewicz
   Get rid of usage RepositoryMetadataManager (https://redirect.github.com/mojohaus/mrm/pull/182";>#182) https://github.com/slawekjaranowski";>@鈥媠lawekjaranowski
   Remove ${localRepository} and other from plugin parameters (https://redirect.github.com/mojohaus/mrm/pull/173";>#173) https://github.com/slawekjaranowski";>@鈥媠lawekjaranowski
   Get rid usage of deprecated ArtifactFactory (https://redirect.github.com/mojohaus/mrm/pull/171";>#171) https://github.com/slawekjaranowski";>@鈥媠lawekjaranowski
   Switch to JUnit 5 (https://redirect.github.com/mojohaus/mrm/pull/170";>#170) https://github.com/slawekjaranowski";>@鈥媠lawekjaranowski
   Resolves https://redirect.github.com/mojohaus/mrm/issues/99";>#99: Removing 
dependencies on maven-artifact-manager from Maven 2 (https://redirect.github.com/mojohaus/mrm/pull/157";>#157) https://github.com/ajarmoniuk";>@鈥媋jarmoniuk
   https://redirect.github.com/mojohaus/mrm/issues/99";>#99: 
First stage of maven 3 migration (https://redirect.github.com/mojohaus/mrm/pull/144";>#144) https://github.com/ajarmoniuk";>@鈥媋jarmoniuk
   
   馃悰 Bug Fixes
   
   Workaround for https://redirect.github.com/mojohaus/mrm/issues/179";>#179 - skip 
checksums for deployed metadata (https://redirect.github.com/mojohaus/mrm/pull/180";>#180) https://github.com/slawekjaranowski";>@鈥媠lawekjaranowski
   
   馃摝 Dependency updates
   
   Bump commons-io:commons-io from 2.14.0 to 2.15.0 (https://redirect.github.com/mojohaus/mrm/pull/186";>#186) https://github.com/dependabot";>@鈥媎ependabot
   Require Maven 3.6.3+ (https://redirect.github.com/mojohaus/mrm/pull/184";>#184) https://github.com/slachiewicz";>@鈥媠lachiewicz
   Bump jetty.version from 9.4.52.v20230823 to 9.4.53.v20231009 (https://redirect.github.com/mojohaus/mrm/pull/183";>#183) https://github.com/dependabot";>@鈥媎ependabot
   Bump plexus-utils from 3.5.1 to 4.0.0 and add plexus-xml 3.0.0 (https://redirect.github.com/mojohaus/mrm/pull/163";>#163) https://github.com/dependabot";>@鈥媎ependabot
   Bump org.codehaus.mojo:mojo-parent from 76 to 77 (https://redirect.github.com/mojohaus/mrm/pull/178";>#178) https://github.com/dependabot";>@鈥媎ependabot
   Bump commons-io:commons-io from 2.13.0 to 2.14.0 (https://redirect.github.com/mojohaus/mrm/pull/175";>#175) https://github.com/dependabot";>@鈥媎ependabot
   Bump jetty.version from 9.4.51.v20230217 to 9.4.52.v20230823 (https://redirect.github.com/mojohaus/mrm/pull/167";>#167) https://github.com/dependabot";>@鈥媎ependabot
   Bump parent from 72 to 76 (https://redirect.github.com/mojohaus/mrm/pull/168";>#168) https://github.com/slawekjaranowski";>@鈥媠lawekjaranowski
   Bump commons-io from 2.12.0 to 2.13.0 (https://redirect.github.com/mojohaus/mrm/pull/164";>#164) https://github.com/dependabot";>@鈥媎ependabot
   Bump org.codehaus.plexus:plexus-archiver from 4.7.1 to 4.8.0 (https://redirect.github.com/mojohaus/mrm/pull/166";>#166) https://github.com/dependabot";>@鈥媎ependabot
   Bump commons-io from 2.11.0 to 2.12.0 (https://redirect.github.com/mojohaus/mrm/pull/160";>#160) https://github.com/dependabot";>@鈥媎ependabot
   Bump plexus-archiver from 4.6.3 to 4.7.1 (https://redirect.github.com/mojohaus/mrm/pull/159";>#159) https://github.com/dependabot";>@鈥媎ependabot
   Bump plexus-archiver from 4.6.2 to 4.6.3 (https://redirect.github.com/mojohaus/mrm/pull/156";>#156) https://github.com/dependabot";>@鈥媎ependabot
   Bump jetty.version from 9.4.50.v20221201 to 9.4.51.v20230217 (https://redirect.github.com/mojohaus/mrm/pull/153";>#153) https://github.com/dependabot";>@鈥媎ependabot
   Bump plexus-archiver from 4.6.1 to 4.6.2 (https://redirect.github.com/mojohaus/mrm/pull/154";>#154) https://github.com/dependabot";>@鈥媎ependabot
   Bump plexus-utils from 3.5.0 to 3.5.1 (https://redirect.github.com/mojohaus/mrm/pull/155";>#155) https://github.com/dependabot";>@鈥媎ependabot
   Bump plexus-archiver from 4.6.0 to 4.6.1 (https://redirect.github.com/mojohaus/mrm/pull/142

[PR] Bump org.codehaus.mojo:mrm-maven-plugin from 1.5.0 to 1.6.0 [maven-jlink-plugin]

2023-11-02 Thread via GitHub


dependabot[bot] opened a new pull request, #170:
URL: https://github.com/apache/maven-jlink-plugin/pull/170

   Bumps [org.codehaus.mojo:mrm-maven-plugin](https://github.com/mojohaus/mrm) 
from 1.5.0 to 1.6.0.
   
   Release notes
   Sourced from https://github.com/mojohaus/mrm/releases";>org.codehaus.mojo:mrm-maven-plugin's
 releases.
   
   1.6.0
   
   :boom: Breaking changes
   
   Remove support for listing directory as html page and cleanups (https://redirect.github.com/mojohaus/mrm/pull/176";>#176) https://github.com/slawekjaranowski";>@鈥媠lawekjaranowski
   Remove of downloading predefined settings.xml by run mojo (https://redirect.github.com/mojohaus/mrm/pull/174";>#174) https://github.com/slawekjaranowski";>@鈥媠lawekjaranowski
   
   馃殌 New features and improvements
   
   Support SNAPSHOT versions by localRepo (https://redirect.github.com/mojohaus/mrm/pull/185";>#185) https://github.com/slawekjaranowski";>@鈥媠lawekjaranowski
   Require Maven 3.6.3+ (https://redirect.github.com/mojohaus/mrm/pull/184";>#184) https://github.com/slachiewicz";>@鈥媠lachiewicz
   Get rid of usage RepositoryMetadataManager (https://redirect.github.com/mojohaus/mrm/pull/182";>#182) https://github.com/slawekjaranowski";>@鈥媠lawekjaranowski
   Remove ${localRepository} and other from plugin parameters (https://redirect.github.com/mojohaus/mrm/pull/173";>#173) https://github.com/slawekjaranowski";>@鈥媠lawekjaranowski
   Get rid usage of deprecated ArtifactFactory (https://redirect.github.com/mojohaus/mrm/pull/171";>#171) https://github.com/slawekjaranowski";>@鈥媠lawekjaranowski
   Switch to JUnit 5 (https://redirect.github.com/mojohaus/mrm/pull/170";>#170) https://github.com/slawekjaranowski";>@鈥媠lawekjaranowski
   Resolves https://redirect.github.com/mojohaus/mrm/issues/99";>#99: Removing 
dependencies on maven-artifact-manager from Maven 2 (https://redirect.github.com/mojohaus/mrm/pull/157";>#157) https://github.com/ajarmoniuk";>@鈥媋jarmoniuk
   https://redirect.github.com/mojohaus/mrm/issues/99";>#99: 
First stage of maven 3 migration (https://redirect.github.com/mojohaus/mrm/pull/144";>#144) https://github.com/ajarmoniuk";>@鈥媋jarmoniuk
   
   馃悰 Bug Fixes
   
   Workaround for https://redirect.github.com/mojohaus/mrm/issues/179";>#179 - skip 
checksums for deployed metadata (https://redirect.github.com/mojohaus/mrm/pull/180";>#180) https://github.com/slawekjaranowski";>@鈥媠lawekjaranowski
   
   馃摝 Dependency updates
   
   Bump commons-io:commons-io from 2.14.0 to 2.15.0 (https://redirect.github.com/mojohaus/mrm/pull/186";>#186) https://github.com/dependabot";>@鈥媎ependabot
   Require Maven 3.6.3+ (https://redirect.github.com/mojohaus/mrm/pull/184";>#184) https://github.com/slachiewicz";>@鈥媠lachiewicz
   Bump jetty.version from 9.4.52.v20230823 to 9.4.53.v20231009 (https://redirect.github.com/mojohaus/mrm/pull/183";>#183) https://github.com/dependabot";>@鈥媎ependabot
   Bump plexus-utils from 3.5.1 to 4.0.0 and add plexus-xml 3.0.0 (https://redirect.github.com/mojohaus/mrm/pull/163";>#163) https://github.com/dependabot";>@鈥媎ependabot
   Bump org.codehaus.mojo:mojo-parent from 76 to 77 (https://redirect.github.com/mojohaus/mrm/pull/178";>#178) https://github.com/dependabot";>@鈥媎ependabot
   Bump commons-io:commons-io from 2.13.0 to 2.14.0 (https://redirect.github.com/mojohaus/mrm/pull/175";>#175) https://github.com/dependabot";>@鈥媎ependabot
   Bump jetty.version from 9.4.51.v20230217 to 9.4.52.v20230823 (https://redirect.github.com/mojohaus/mrm/pull/167";>#167) https://github.com/dependabot";>@鈥媎ependabot
   Bump parent from 72 to 76 (https://redirect.github.com/mojohaus/mrm/pull/168";>#168) https://github.com/slawekjaranowski";>@鈥媠lawekjaranowski
   Bump commons-io from 2.12.0 to 2.13.0 (https://redirect.github.com/mojohaus/mrm/pull/164";>#164) https://github.com/dependabot";>@鈥媎ependabot
   Bump org.codehaus.plexus:plexus-archiver from 4.7.1 to 4.8.0 (https://redirect.github.com/mojohaus/mrm/pull/166";>#166) https://github.com/dependabot";>@鈥媎ependabot
   Bump commons-io from 2.11.0 to 2.12.0 (https://redirect.github.com/mojohaus/mrm/pull/160";>#160) https://github.com/dependabot";>@鈥媎ependabot
   Bump plexus-archiver from 4.6.3 to 4.7.1 (https://redirect.github.com/mojohaus/mrm/pull/159";>#159) https://github.com/dependabot";>@鈥媎ependabot
   Bump plexus-archiver from 4.6.2 to 4.6.3 (https://redirect.github.com/mojohaus/mrm/pull/156";>#156) https://github.com/dependabot";>@鈥媎ependabot
   Bump jetty.version from 9.4.50.v20221201 to 9.4.51.v20230217 (https://redirect.github.com/mojohaus/mrm/pull/153";>#153) https://github.com/dependabot";>@鈥媎ependabot
   Bump plexus-archiver from 4.6.1 to 4.6.2 (https://redirect.github.com/mojohaus/mrm/pull/154";>#154) https://github.com/dependabot";>@鈥媎ependabot
   Bump plexus-utils from 3.5.0 to 3.5.1 (https://redirect.github.com/mojohaus/mrm/pull/155";>#155) https://github.com/dependabot";>@鈥媎ependabot
   Bump plexus-archiver from 4.6.0 to 4.6.1 (https://redirect.github.com/mojohaus/mrm/pull/142

[PR] Bump org.codehaus.mojo:mrm-maven-plugin from 1.5.0 to 1.6.0 [maven-javadoc-plugin]

2023-11-02 Thread via GitHub


dependabot[bot] opened a new pull request, #247:
URL: https://github.com/apache/maven-javadoc-plugin/pull/247

   Bumps [org.codehaus.mojo:mrm-maven-plugin](https://github.com/mojohaus/mrm) 
from 1.5.0 to 1.6.0.
   
   Release notes
   Sourced from https://github.com/mojohaus/mrm/releases";>org.codehaus.mojo:mrm-maven-plugin's
 releases.
   
   1.6.0
   
   :boom: Breaking changes
   
   Remove support for listing directory as html page and cleanups (https://redirect.github.com/mojohaus/mrm/pull/176";>#176) https://github.com/slawekjaranowski";>@鈥媠lawekjaranowski
   Remove of downloading predefined settings.xml by run mojo (https://redirect.github.com/mojohaus/mrm/pull/174";>#174) https://github.com/slawekjaranowski";>@鈥媠lawekjaranowski
   
   馃殌 New features and improvements
   
   Support SNAPSHOT versions by localRepo (https://redirect.github.com/mojohaus/mrm/pull/185";>#185) https://github.com/slawekjaranowski";>@鈥媠lawekjaranowski
   Require Maven 3.6.3+ (https://redirect.github.com/mojohaus/mrm/pull/184";>#184) https://github.com/slachiewicz";>@鈥媠lachiewicz
   Get rid of usage RepositoryMetadataManager (https://redirect.github.com/mojohaus/mrm/pull/182";>#182) https://github.com/slawekjaranowski";>@鈥媠lawekjaranowski
   Remove ${localRepository} and other from plugin parameters (https://redirect.github.com/mojohaus/mrm/pull/173";>#173) https://github.com/slawekjaranowski";>@鈥媠lawekjaranowski
   Get rid usage of deprecated ArtifactFactory (https://redirect.github.com/mojohaus/mrm/pull/171";>#171) https://github.com/slawekjaranowski";>@鈥媠lawekjaranowski
   Switch to JUnit 5 (https://redirect.github.com/mojohaus/mrm/pull/170";>#170) https://github.com/slawekjaranowski";>@鈥媠lawekjaranowski
   Resolves https://redirect.github.com/mojohaus/mrm/issues/99";>#99: Removing 
dependencies on maven-artifact-manager from Maven 2 (https://redirect.github.com/mojohaus/mrm/pull/157";>#157) https://github.com/ajarmoniuk";>@鈥媋jarmoniuk
   https://redirect.github.com/mojohaus/mrm/issues/99";>#99: 
First stage of maven 3 migration (https://redirect.github.com/mojohaus/mrm/pull/144";>#144) https://github.com/ajarmoniuk";>@鈥媋jarmoniuk
   
   馃悰 Bug Fixes
   
   Workaround for https://redirect.github.com/mojohaus/mrm/issues/179";>#179 - skip 
checksums for deployed metadata (https://redirect.github.com/mojohaus/mrm/pull/180";>#180) https://github.com/slawekjaranowski";>@鈥媠lawekjaranowski
   
   馃摝 Dependency updates
   
   Bump commons-io:commons-io from 2.14.0 to 2.15.0 (https://redirect.github.com/mojohaus/mrm/pull/186";>#186) https://github.com/dependabot";>@鈥媎ependabot
   Require Maven 3.6.3+ (https://redirect.github.com/mojohaus/mrm/pull/184";>#184) https://github.com/slachiewicz";>@鈥媠lachiewicz
   Bump jetty.version from 9.4.52.v20230823 to 9.4.53.v20231009 (https://redirect.github.com/mojohaus/mrm/pull/183";>#183) https://github.com/dependabot";>@鈥媎ependabot
   Bump plexus-utils from 3.5.1 to 4.0.0 and add plexus-xml 3.0.0 (https://redirect.github.com/mojohaus/mrm/pull/163";>#163) https://github.com/dependabot";>@鈥媎ependabot
   Bump org.codehaus.mojo:mojo-parent from 76 to 77 (https://redirect.github.com/mojohaus/mrm/pull/178";>#178) https://github.com/dependabot";>@鈥媎ependabot
   Bump commons-io:commons-io from 2.13.0 to 2.14.0 (https://redirect.github.com/mojohaus/mrm/pull/175";>#175) https://github.com/dependabot";>@鈥媎ependabot
   Bump jetty.version from 9.4.51.v20230217 to 9.4.52.v20230823 (https://redirect.github.com/mojohaus/mrm/pull/167";>#167) https://github.com/dependabot";>@鈥媎ependabot
   Bump parent from 72 to 76 (https://redirect.github.com/mojohaus/mrm/pull/168";>#168) https://github.com/slawekjaranowski";>@鈥媠lawekjaranowski
   Bump commons-io from 2.12.0 to 2.13.0 (https://redirect.github.com/mojohaus/mrm/pull/164";>#164) https://github.com/dependabot";>@鈥媎ependabot
   Bump org.codehaus.plexus:plexus-archiver from 4.7.1 to 4.8.0 (https://redirect.github.com/mojohaus/mrm/pull/166";>#166) https://github.com/dependabot";>@鈥媎ependabot
   Bump commons-io from 2.11.0 to 2.12.0 (https://redirect.github.com/mojohaus/mrm/pull/160";>#160) https://github.com/dependabot";>@鈥媎ependabot
   Bump plexus-archiver from 4.6.3 to 4.7.1 (https://redirect.github.com/mojohaus/mrm/pull/159";>#159) https://github.com/dependabot";>@鈥媎ependabot
   Bump plexus-archiver from 4.6.2 to 4.6.3 (https://redirect.github.com/mojohaus/mrm/pull/156";>#156) https://github.com/dependabot";>@鈥媎ependabot
   Bump jetty.version from 9.4.50.v20221201 to 9.4.51.v20230217 (https://redirect.github.com/mojohaus/mrm/pull/153";>#153) https://github.com/dependabot";>@鈥媎ependabot
   Bump plexus-archiver from 4.6.1 to 4.6.2 (https://redirect.github.com/mojohaus/mrm/pull/154";>#154) https://github.com/dependabot";>@鈥媎ependabot
   Bump plexus-utils from 3.5.0 to 3.5.1 (https://redirect.github.com/mojohaus/mrm/pull/155";>#155) https://github.com/dependabot";>@鈥媎ependabot
   Bump plexus-archiver from 4.6.0 to 4.6.1 (https://redirect.github.com/mojohaus/mrm/pull/1

[PR] Bump org.codehaus.plexus:plexus-xml from 3.0.0 to 4.0.2 [maven-jar-plugin]

2023-11-02 Thread via GitHub


dependabot[bot] opened a new pull request, #66:
URL: https://github.com/apache/maven-jar-plugin/pull/66

   Bumps 
[org.codehaus.plexus:plexus-xml](https://github.com/codehaus-plexus/plexus-xml) 
from 3.0.0 to 4.0.2.
   
   Release notes
   Sourced from https://github.com/codehaus-plexus/plexus-xml/releases";>org.codehaus.plexus:plexus-xml's
 releases.
   
   Plexus XML 4.0.2
   What's Changed
   
   Cleanup after parent pom upgrade by https://github.com/slachiewicz";>@鈥媠lachiewicz in https://redirect.github.com/codehaus-plexus/plexus-xml/pull/22";>codehaus-plexus/plexus-xml#22
   Upgrade to 4.0.0-alpha-7 and exclude dependency to sisu (fixes https://redirect.github.com/codehaus-plexus/plexus-xml/issues/17";>#17)
 by https://github.com/gnodet";>@鈥媑nodet in https://redirect.github.com/codehaus-plexus/plexus-xml/pull/23";>codehaus-plexus/plexus-xml#23
   
   New Contributors
   
   https://github.com/slachiewicz";>@鈥媠lachiewicz 
made their first contribution in https://redirect.github.com/codehaus-plexus/plexus-xml/pull/22";>codehaus-plexus/plexus-xml#22
   
   Full Changelog: https://github.com/codehaus-plexus/plexus-xml/compare/plexus-xml-4.0.1...plexus-xml-4.0.2";>https://github.com/codehaus-plexus/plexus-xml/compare/plexus-xml-4.0.1...plexus-xml-4.0.2
   4.0.0
   
   
   Use spotless (https://redirect.github.com/codehaus-plexus/plexus-xml/pull/8";>#8) https://github.com/gnodet";>@鈥媑nodet
   Fix site generation (https://redirect.github.com/codehaus-plexus/plexus-xml/pull/15";>#15) 
https://github.com/gnodet";>@鈥媑nodet
   Switch build ci workflow to master branch (https://redirect.github.com/codehaus-plexus/plexus-xml/pull/14";>#14) 
https://github.com/gnodet";>@鈥媑nodet
   Fix SCM urls (https://redirect.github.com/codehaus-plexus/plexus-xml/pull/13";>#13) 
https://github.com/gnodet";>@鈥媑nodet
   MXParser tokenization fails when PI is before first tag (fixes https://redirect.github.com/codehaus-plexus/plexus-xml/issues/7";>#7) 
(https://redirect.github.com/codehaus-plexus/plexus-xml/pull/12";>#12) 
https://github.com/gnodet";>@鈥媑nodet
   Deprecate Xpp3DomUtils (fixes https://redirect.github.com/codehaus-plexus/plexus-xml/issues/6";>#6) 
(https://redirect.github.com/codehaus-plexus/plexus-xml/pull/9";>#9) https://github.com/gnodet";>@鈥媑nodet
   Use a ArrayDeque (https://redirect.github.com/codehaus-plexus/plexus-xml/pull/5";>#5) https://github.com/gnodet";>@鈥媑nodet
   Upgrade plugins and clean build warnings (https://redirect.github.com/codehaus-plexus/plexus-xml/pull/4";>#4) https://github.com/gnodet";>@鈥媑nodet
   Switch to junit 5 (https://redirect.github.com/codehaus-plexus/plexus-xml/pull/2";>#2) https://github.com/gnodet";>@鈥媑nodet
   Fix parsing an UTF-8 file without BOM and ISO-8859-1 encoding (https://redirect.github.com/codehaus-plexus/plexus-xml/pull/1";>#1) https://github.com/gnodet";>@鈥媑nodet
   
   
   
   
   Commits
   
   https://github.com/codehaus-plexus/plexus-xml/commit/944197c74386b199857a003160d840fb5593ac29";>944197c
 [maven-release-plugin] prepare release plexus-xml-4.0.2
   https://github.com/codehaus-plexus/plexus-xml/commit/c3d99b433a272d8eb1cc7c799410799e8c16ace3";>c3d99b4
 Upgrade to 4.0.0-alpha-7 and exclude dependency to sisu (fixes https://redirect.github.com/codehaus-plexus/plexus-xml/issues/17";>#17)
 (https://redirect.github.com/codehaus-plexus/plexus-xml/issues/23";>#23)
   https://github.com/codehaus-plexus/plexus-xml/commit/a83cefa086c9a5bb8b6674a409016f378b19891e";>a83cefa
 Cleanup after parent pom upgrade
   https://github.com/codehaus-plexus/plexus-xml/commit/25a00cd9d04ff3ab7acdcebdefdbb19ec5c4560d";>25a00cd
 [maven-release-plugin] prepare for next development iteration
   https://github.com/codehaus-plexus/plexus-xml/commit/bcb6981e2a9c635d024e0422de2a997a00ffdd8e";>bcb6981
 [maven-release-plugin] prepare release plexus-xml-4.0.1
   https://github.com/codehaus-plexus/plexus-xml/commit/d227a49f0f9b552a61b2aaac3bbe2c722ce06fea";>d227a49
 Fix detection of invalid spaces in prolog (https://redirect.github.com/codehaus-plexus/plexus-xml/issues/20";>#20)
   https://github.com/codehaus-plexus/plexus-xml/commit/27d6127d3196d09263d8fe0f445b9d83f6ccfb75";>27d6127
 pom.mxl and site.xml cleanup
   https://github.com/codehaus-plexus/plexus-xml/commit/62f50bc46c7b51d51a25541dfe0a502063dc1fc3";>62f50bc
 [maven-release-plugin] prepare for next development iteration
   https://github.com/codehaus-plexus/plexus-xml/commit/cac55e8c167b168c6c36dd4a057dedfadec03c0e";>cac55e8
 [maven-release-plugin] prepare release plexus-xml-4.0.0
   https://github.com/codehaus-plexus/plexus-xml/commit/17787e5ff7dea8acf347fd3f92bd855e110d6dfe";>17787e5
 Reformat using spotless
   Additional commits viewable in https://github.com/codehaus-plexus/plexus-xml/compare/plexus-xml-3.0.0...plexus-xml-4.0.2";>compare
 view
   
   
   
   
   
   [![Dependabot compatibility 
score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=org.codehaus.plexus:plexus-xml&package-manager=m

[PR] Bump org.codehaus.mojo:mrm-maven-plugin from 1.5.0 to 1.6.0 [maven-wrapper]

2023-11-02 Thread via GitHub


dependabot[bot] opened a new pull request, #109:
URL: https://github.com/apache/maven-wrapper/pull/109

   Bumps [org.codehaus.mojo:mrm-maven-plugin](https://github.com/mojohaus/mrm) 
from 1.5.0 to 1.6.0.
   
   Release notes
   Sourced from https://github.com/mojohaus/mrm/releases";>org.codehaus.mojo:mrm-maven-plugin's
 releases.
   
   1.6.0
   
   :boom: Breaking changes
   
   Remove support for listing directory as html page and cleanups (https://redirect.github.com/mojohaus/mrm/pull/176";>#176) https://github.com/slawekjaranowski";>@鈥媠lawekjaranowski
   Remove of downloading predefined settings.xml by run mojo (https://redirect.github.com/mojohaus/mrm/pull/174";>#174) https://github.com/slawekjaranowski";>@鈥媠lawekjaranowski
   
   馃殌 New features and improvements
   
   Support SNAPSHOT versions by localRepo (https://redirect.github.com/mojohaus/mrm/pull/185";>#185) https://github.com/slawekjaranowski";>@鈥媠lawekjaranowski
   Require Maven 3.6.3+ (https://redirect.github.com/mojohaus/mrm/pull/184";>#184) https://github.com/slachiewicz";>@鈥媠lachiewicz
   Get rid of usage RepositoryMetadataManager (https://redirect.github.com/mojohaus/mrm/pull/182";>#182) https://github.com/slawekjaranowski";>@鈥媠lawekjaranowski
   Remove ${localRepository} and other from plugin parameters (https://redirect.github.com/mojohaus/mrm/pull/173";>#173) https://github.com/slawekjaranowski";>@鈥媠lawekjaranowski
   Get rid usage of deprecated ArtifactFactory (https://redirect.github.com/mojohaus/mrm/pull/171";>#171) https://github.com/slawekjaranowski";>@鈥媠lawekjaranowski
   Switch to JUnit 5 (https://redirect.github.com/mojohaus/mrm/pull/170";>#170) https://github.com/slawekjaranowski";>@鈥媠lawekjaranowski
   Resolves https://redirect.github.com/mojohaus/mrm/issues/99";>#99: Removing 
dependencies on maven-artifact-manager from Maven 2 (https://redirect.github.com/mojohaus/mrm/pull/157";>#157) https://github.com/ajarmoniuk";>@鈥媋jarmoniuk
   https://redirect.github.com/mojohaus/mrm/issues/99";>#99: 
First stage of maven 3 migration (https://redirect.github.com/mojohaus/mrm/pull/144";>#144) https://github.com/ajarmoniuk";>@鈥媋jarmoniuk
   
   馃悰 Bug Fixes
   
   Workaround for https://redirect.github.com/mojohaus/mrm/issues/179";>#179 - skip 
checksums for deployed metadata (https://redirect.github.com/mojohaus/mrm/pull/180";>#180) https://github.com/slawekjaranowski";>@鈥媠lawekjaranowski
   
   馃摝 Dependency updates
   
   Bump commons-io:commons-io from 2.14.0 to 2.15.0 (https://redirect.github.com/mojohaus/mrm/pull/186";>#186) https://github.com/dependabot";>@鈥媎ependabot
   Require Maven 3.6.3+ (https://redirect.github.com/mojohaus/mrm/pull/184";>#184) https://github.com/slachiewicz";>@鈥媠lachiewicz
   Bump jetty.version from 9.4.52.v20230823 to 9.4.53.v20231009 (https://redirect.github.com/mojohaus/mrm/pull/183";>#183) https://github.com/dependabot";>@鈥媎ependabot
   Bump plexus-utils from 3.5.1 to 4.0.0 and add plexus-xml 3.0.0 (https://redirect.github.com/mojohaus/mrm/pull/163";>#163) https://github.com/dependabot";>@鈥媎ependabot
   Bump org.codehaus.mojo:mojo-parent from 76 to 77 (https://redirect.github.com/mojohaus/mrm/pull/178";>#178) https://github.com/dependabot";>@鈥媎ependabot
   Bump commons-io:commons-io from 2.13.0 to 2.14.0 (https://redirect.github.com/mojohaus/mrm/pull/175";>#175) https://github.com/dependabot";>@鈥媎ependabot
   Bump jetty.version from 9.4.51.v20230217 to 9.4.52.v20230823 (https://redirect.github.com/mojohaus/mrm/pull/167";>#167) https://github.com/dependabot";>@鈥媎ependabot
   Bump parent from 72 to 76 (https://redirect.github.com/mojohaus/mrm/pull/168";>#168) https://github.com/slawekjaranowski";>@鈥媠lawekjaranowski
   Bump commons-io from 2.12.0 to 2.13.0 (https://redirect.github.com/mojohaus/mrm/pull/164";>#164) https://github.com/dependabot";>@鈥媎ependabot
   Bump org.codehaus.plexus:plexus-archiver from 4.7.1 to 4.8.0 (https://redirect.github.com/mojohaus/mrm/pull/166";>#166) https://github.com/dependabot";>@鈥媎ependabot
   Bump commons-io from 2.11.0 to 2.12.0 (https://redirect.github.com/mojohaus/mrm/pull/160";>#160) https://github.com/dependabot";>@鈥媎ependabot
   Bump plexus-archiver from 4.6.3 to 4.7.1 (https://redirect.github.com/mojohaus/mrm/pull/159";>#159) https://github.com/dependabot";>@鈥媎ependabot
   Bump plexus-archiver from 4.6.2 to 4.6.3 (https://redirect.github.com/mojohaus/mrm/pull/156";>#156) https://github.com/dependabot";>@鈥媎ependabot
   Bump jetty.version from 9.4.50.v20221201 to 9.4.51.v20230217 (https://redirect.github.com/mojohaus/mrm/pull/153";>#153) https://github.com/dependabot";>@鈥媎ependabot
   Bump plexus-archiver from 4.6.1 to 4.6.2 (https://redirect.github.com/mojohaus/mrm/pull/154";>#154) https://github.com/dependabot";>@鈥媎ependabot
   Bump plexus-utils from 3.5.0 to 3.5.1 (https://redirect.github.com/mojohaus/mrm/pull/155";>#155) https://github.com/dependabot";>@鈥媎ependabot
   Bump plexus-archiver from 4.6.0 to 4.6.1 (https://redirect.github.com/mojohaus/mrm/pull/142";>#1

[jira] [Commented] (MSHARED-1326) Improve (documentation on) MavenReport interface/AbstractMavenReport class

2023-11-02 Thread ASF GitHub Bot (Jira)


[ 
https://issues.apache.org/jira/browse/MSHARED-1326?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17782370#comment-17782370
 ] 

ASF GitHub Bot commented on MSHARED-1326:
-

kriegaex commented on code in PR #19:
URL: 
https://github.com/apache/maven-reporting-api/pull/19#discussion_r1380963374


##
src/main/java/org/apache/maven/reporting/MavenReport.java:
##
@@ -53,7 +53,9 @@ public interface MavenReport {
 void generate(Sink sink, Locale locale) throws MavenReportException;
 
 /**
- * Get the base name used to create report's output file(s).
+ * Get the output name denoting a base location relative to the {@link 
#getReportOutputDirectory()}
+ * used to create the report's main output file. The base location may 
contain path components

Review Comment:
   @elharo, I agree with you in this case.





> Improve (documentation on) MavenReport interface/AbstractMavenReport class
> --
>
> Key: MSHARED-1326
> URL: https://issues.apache.org/jira/browse/MSHARED-1326
> Project: Maven Shared Components
>  Issue Type: Task
>  Components: maven-reporting-api
>Affects Versions: maven-reporting-impl-4.0.0-M11, 
> maven-reporting-api-4.0.0-M8
>Reporter: Michael Osipov
>Assignee: Michael Osipov
>Priority: Major
> Fix For: maven-reporting-api-4.0.0-M9, 
> maven-reporting-impl-4.0.0-M12
>
>
> Based on a 
> [discussion|https://lists.apache.org/thread/6yxlvbhb7odfylfgjgzbvmvxg0vry20b] 
> with [~kriegaex], there are few conceptional or documentational issues with 
> the {{MavenReport}} interface:
> * {{#getOutputName()}} does not clearly say that is actually an optional base 
> *path* and base name (base location) of the report item from a reporting 
> output directory. It needs at least a doc update and maybe even a rename to 
> {{#getOutputPath()}}/{{#getOutputPathLocation()}}?
> * Both {{#setReportOutputDirectory(File outputDirectory)}} and 
> {{#getReportOutputDirectory()}} documentation imply tha this directory solely 
> refers to this single report, but that is not correct. It refers to root 
> directory which contains all possibly generated reports. A shared directory, 
> not exclusive one. Consider your report generates in a subdir, then these do 
> *not* refer to it, but to its parent.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


Re: [PR] [MSHARED-1326] Improve (documentation on) MavenReport interface [maven-reporting-api]

2023-11-02 Thread via GitHub


kriegaex commented on code in PR #19:
URL: 
https://github.com/apache/maven-reporting-api/pull/19#discussion_r1380963374


##
src/main/java/org/apache/maven/reporting/MavenReport.java:
##
@@ -53,7 +53,9 @@ public interface MavenReport {
 void generate(Sink sink, Locale locale) throws MavenReportException;
 
 /**
- * Get the base name used to create report's output file(s).
+ * Get the output name denoting a base location relative to the {@link 
#getReportOutputDirectory()}
+ * used to create the report's main output file. The base location may 
contain path components

Review Comment:
   @elharo, I agree with you in this case.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[jira] [Commented] (MNGSITE-527) broken link to settings-1.3.0.xsd

2023-11-02 Thread ASF GitHub Bot (Jira)


[ 
https://issues.apache.org/jira/browse/MNGSITE-527?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17782354#comment-17782354
 ] 

ASF GitHub Bot commented on MNGSITE-527:


froque commented on PR #464:
URL: https://github.com/apache/maven-site/pull/464#issuecomment-1791714603

   Running `mvn verify` on latest maven master only creates a 
`settings-1.3.0.xsd`. How can I create those 3 files ?  




> broken link to settings-1.3.0.xsd
> -
>
> Key: MNGSITE-527
> URL: https://issues.apache.org/jira/browse/MNGSITE-527
> Project: Maven Project Web Site
>  Issue Type: Bug
>Reporter: Filipe Roque
>Priority: Major
>
> The url of the XSD mentioned in the settings.xml settings tag is broken in 
> Maven 4
> {code:java}
> http://maven.apache.org/SETTINGS/1.3.0";
>   xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance";
>   xsi:schemaLocation="http://maven.apache.org/SETTINGS/1.3.0 
> https://maven.apache.org/xsd/settings-1.3.0.xsd";> {code}
> Both the settings.xml found at apache-maven-4.0.0-alpha-8/conf/settings.xml 
> and at https://maven.apache.org/ref/4-LATEST/maven-settings/settings.html 
> reference a broken url.
> There are older Versions at [http://maven.apache.org/xsd/].



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


Re: [PR] MNGSITE-527 broken link to settings-1.3.0.xsd [maven-site]

2023-11-02 Thread via GitHub


froque commented on PR #464:
URL: https://github.com/apache/maven-site/pull/464#issuecomment-1791714603

   Running `mvn verify` on latest maven master only creates a 
`settings-1.3.0.xsd`. How can I create those 3 files ?  


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] [PR-104] bugfix / enhancements restoration of outputs on disk [maven-build-cache-extension]

2023-11-02 Thread via GitHub


kbuntrock commented on PR #104:
URL: 
https://github.com/apache/maven-build-cache-extension/pull/104#issuecomment-1791669225

   > @kbuntrock My company ran into the issue with clean deleting out the 
target directories but then not restoring the Jars when the build happens. I 
tested out your changes against our project and can confirm the jar restoration 
works as expected. Thank you for adding this! 馃帀
   
   Thank you. :) I guess it's more related to issue #92 
   
   Related to this one, since there is less discussion than expected, I will 
code some tests next weekend and then fully submit the PR. :)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[PR] Fix How To XSD links [maven-build-cache-extension]

2023-11-02 Thread via GitHub


froque opened a new pull request, #106:
URL: https://github.com/apache/maven-build-cache-extension/pull/106

   
   
   Following this checklist to help us incorporate your 
   contribution quickly and easily:
   
- [ ] ~~Make sure there is a [MBUILDCACHE JIRA 
issue](https://issues.apache.org/jira/browse/MBUILDCACHE) filed 
  for the change (usually before you start working on it).  Trivial 
changes like typos do not 
  require a JIRA issue.  Your pull request should address just this 
issue, without 
  pulling in other changes.~~
- [x] Each commit in the pull request should have a meaningful subject line 
and body.
- [ ] ~~Format the pull request title like `[MBUILDCACHE-XXX] - Fixes bug 
in ApproximateQuantiles`,
  where you replace `MBUILDCACHE-XXX` with the appropriate JIRA issue. 
Best practice
  is to use the JIRA issue title in the pull request title and in the 
first line of the 
  commit message.~~
- [x] Write a pull request description that is detailed enough to 
understand what the pull request does, how, and why.
- [x] Run `mvn clean verify` to make sure basic checks pass. A more 
thorough check will 
  be performed on your pull request automatically.
- [x] You have run the [Core IT][core-its] successfully.
   
   If your pull request is about ~20 lines of code you don't need to sign an
   [Individual Contributor License 
Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure
   please ask on the developers list.
   
   To make clear that you license your contribution under 
   the [Apache License Version 2.0, January 
2004](http://www.apache.org/licenses/LICENSE-2.0)
   you have to acknowledge this by using the following check-box.
   
- [x] I hereby declare this contribution to be licenced under the [Apache 
License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
   
- [ ] ~~In any other case, please file an [Apache Individual Contributor 
License Agreement](https://www.apache.org/licenses/icla.pdf).~~
   
   [core-its]: https://maven.apache.org/core-its/core-it-suite/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[jira] [Commented] (MNGSITE-527) broken link to settings-1.3.0.xsd

2023-11-02 Thread Guillaume Nodet (Jira)


[ 
https://issues.apache.org/jira/browse/MNGSITE-527?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17782322#comment-17782322
 ] 

Guillaume Nodet commented on MNGSITE-527:
-

Maven 4.0.0 is still in alpha, so those XSDs (this also includes 
maven-4.1.0.xsd, core-extensions-1.2.0.xsd, plugin-1.1.0.xsd) have not been 
published yet, because I assumed they could still change before 4.0.0 GA.
I'm fine with publishing those somehow, but not sure how to communicate to 
users that those can still change.

> broken link to settings-1.3.0.xsd
> -
>
> Key: MNGSITE-527
> URL: https://issues.apache.org/jira/browse/MNGSITE-527
> Project: Maven Project Web Site
>  Issue Type: Bug
>Reporter: Filipe Roque
>Priority: Major
>
> The url of the XSD mentioned in the settings.xml settings tag is broken in 
> Maven 4
> {code:java}
> http://maven.apache.org/SETTINGS/1.3.0";
>   xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance";
>   xsi:schemaLocation="http://maven.apache.org/SETTINGS/1.3.0 
> https://maven.apache.org/xsd/settings-1.3.0.xsd";> {code}
> Both the settings.xml found at apache-maven-4.0.0-alpha-8/conf/settings.xml 
> and at https://maven.apache.org/ref/4-LATEST/maven-settings/settings.html 
> reference a broken url.
> There are older Versions at [http://maven.apache.org/xsd/].



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[PR] Bump org.fusesource.jansi:jansi from 2.4.0 to 2.4.1 [maven-surefire]

2023-11-02 Thread via GitHub


dependabot[bot] opened a new pull request, #684:
URL: https://github.com/apache/maven-surefire/pull/684

   Bumps [org.fusesource.jansi:jansi](https://github.com/fusesource/jansi) from 
2.4.0 to 2.4.1.
   
   Release notes
   Sourced from https://github.com/fusesource/jansi/releases";>org.fusesource.jansi:jansi's
 releases.
   
   Jansi 2.4.1
   This long awaited bug fix release provides a bunch of fixes.  The upgrade 
should be just a matter of raising the version number, however JDK 7 support 
has been dropped at runtime.
   A merge of the JANSI library into https://github.com/jline/jline3";>JLine is being considered.  This 
would avoid duplication of somewhat similar code and ease the maintenance of 
both projects.  If your project is using the 
org.fusesource.jansi.io or 
org.fusesource.jansi.internal package, please drop us a note in https://redirect.github.com/fusesource/jansi/issues/277";>fusesource/jansi#277
 so that we can discuss things.
   What's Changed
   
   Fix missing synchronisation in AnsiConsole by https://github.com/gnodet";>@鈥媑nodet in https://github.com/fusesource/jansi/commit/dd7d5e2a63fbeb5e6f17d301b56c703f5ec80e72";>https://github.com/fusesource/jansi/commit/dd7d5e2a63fbeb5e6f17d301b56c703f5ec80e72
   Deprecate WindowsSupport by https://github.com/gnodet";>@鈥媑nodet in https://github.com/fusesource/jansi/commit/a9dc2a3e597a794eeb655d33968f30605a02cdf9";>https://github.com/fusesource/jansi/commit/a9dc2a3e597a794eeb655d33968f30605a02cdf9
   Modernize code by https://github.com/Glavo";>@鈥婫lavo in https://redirect.github.com/fusesource/jansi/pull/267";>fusesource/jansi#267
   Fix JVM crash when running java by https://github.com/gnodet";>@鈥媑nodet in https://redirect.github.com/fusesource/jansi/pull/265";>fusesource/jansi#265
   Fix terminal width support on MINGW by https://github.com/gnodet";>@鈥媑nodet in https://redirect.github.com/fusesource/jansi/pull/264";>fusesource/jansi#264
   Send both SCO and DEC command for save/restore cursor position by https://github.com/gnodet";>@鈥媑nodet in https://redirect.github.com/fusesource/jansi/pull/262";>fusesource/jansi#262
   Fix wrong output encoding on Windows with JDK >= 19 by https://github.com/gnodet";>@鈥媑nodet in https://redirect.github.com/fusesource/jansi/pull/258";>fusesource/jansi#258
   Improve robustness of initial cleanup by https://github.com/gnodet";>@鈥媑nodet in https://redirect.github.com/fusesource/jansi/issues/255";>fusesource/jansi#255
   Fix infinite loop bug by https://github.com/arthurscchan";>@鈥媋rthurscchan in https://redirect.github.com/fusesource/jansi/pull/252";>fusesource/jansi#252
   Fix invalid string input by https://github.com/arthurscchan";>@鈥媋rthurscchan in https://redirect.github.com/fusesource/jansi/pull/253";>fusesource/jansi#253
   Require JDK 8 at runtime and JDK 11 at build time by https://github.com/gnodet";>@鈥媑nodet in https://github.com/fusesource/jansi/commit/e29c505b9ea09753142c6c000e4849f2dc474ec4";>https://github.com/fusesource/jansi/commit/e29c505b9ea09753142c6c000e4849f2dc474ec4
 and https://github.com/fusesource/jansi/commit/7bc5862085f8626be485a1563e24d22130dd8ebc";>https://github.com/fusesource/jansi/commit/7bc5862085f8626be485a1563e24d22130dd8ebc
   Remove @author tags in code by https://github.com/gnodet";>@鈥媑nodet in https://github.com/fusesource/jansi/commit/c8172634bb5b39b62e515fd86d64b96a4f2bca3a";>https://github.com/fusesource/jansi/commit/c8172634bb5b39b62e515fd86d64b96a4f2bca3a
   Code formatting with spotless by https://github.com/gnodet";>@鈥媑nodet in https://redirect.github.com/fusesource/jansi/pull/256";>fusesource/jansi#256
   Add module-info through moditect by https://github.com/bowbahdoe";>@鈥媌owbahdoe in https://redirect.github.com/fusesource/jansi/pull/254";>fusesource/jansi#254
   Support windows on ARM, (fixes https://redirect.github.com/fusesource/jansi/issues/238";>#238) by https://github.com/gnodet";>@鈥媑nodet in https://redirect.github.com/fusesource/jansi/pull/240";>fusesource/jansi#240
   Only increment counter if install successful by https://github.com/kwin";>@鈥媖win in https://redirect.github.com/fusesource/jansi/pull/243";>fusesource/jansi#243
   Add missing space in SunOS-sparcv9_CCFLAGS by https://github.com/michael-o";>@鈥媘ichael-o in https://redirect.github.com/fusesource/jansi/pull/249";>fusesource/jansi#249
   Fix project's name by https://github.com/Nailik";>@鈥婲ailik in https://redirect.github.com/fusesource/jansi/pull/237";>fusesource/jansi#237
   
   New Contributors
   
   https://github.com/Nailik";>@鈥婲ailik made their 
first contribution in https://redirect.github.com/fusesource/jansi/pull/237";>fusesource/jansi#237
   https://github.com/michael-o";>@鈥媘ichael-o made 
their first contribution in https://redirect.github.com/fusesource/jansi/pull/249";>fusesource/jansi#249
   https://github.com/kwin";>@鈥媖win made their 
first contribution in https://redirect.github.com/fusesource/jansi/pull/243";>fusesource/jansi#243
   https://github.com/bowbahdoe";>@鈥媌owbahd

Re: [PR] [MSHARED-1326] Improve (documentation on) MavenReport interface [maven-reporting-api]

2023-11-02 Thread via GitHub


michael-o commented on code in PR #19:
URL: 
https://github.com/apache/maven-reporting-api/pull/19#discussion_r1380649425


##
src/main/java/org/apache/maven/reporting/MavenReport.java:
##
@@ -53,9 +53,10 @@ public interface MavenReport {
 void generate(Sink sink, Locale locale) throws MavenReportException;
 
 /**
- * Get the base name used to create report's output file(s).
+ * Get the path relative to {@link #getReportOutputDirectory()} where the 
report's main output
+ * file will be written. The last component is expected to be a basename 
only.

Review Comment:
   @elharo Done, please have another look.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[jira] [Commented] (MSHARED-1326) Improve (documentation on) MavenReport interface/AbstractMavenReport class

2023-11-02 Thread ASF GitHub Bot (Jira)


[ 
https://issues.apache.org/jira/browse/MSHARED-1326?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17782299#comment-17782299
 ] 

ASF GitHub Bot commented on MSHARED-1326:
-

michael-o commented on code in PR #19:
URL: 
https://github.com/apache/maven-reporting-api/pull/19#discussion_r1380649425


##
src/main/java/org/apache/maven/reporting/MavenReport.java:
##
@@ -53,9 +53,10 @@ public interface MavenReport {
 void generate(Sink sink, Locale locale) throws MavenReportException;
 
 /**
- * Get the base name used to create report's output file(s).
+ * Get the path relative to {@link #getReportOutputDirectory()} where the 
report's main output
+ * file will be written. The last component is expected to be a basename 
only.

Review Comment:
   @elharo Done, please have another look.





> Improve (documentation on) MavenReport interface/AbstractMavenReport class
> --
>
> Key: MSHARED-1326
> URL: https://issues.apache.org/jira/browse/MSHARED-1326
> Project: Maven Shared Components
>  Issue Type: Task
>  Components: maven-reporting-api
>Affects Versions: maven-reporting-impl-4.0.0-M11, 
> maven-reporting-api-4.0.0-M8
>Reporter: Michael Osipov
>Assignee: Michael Osipov
>Priority: Major
> Fix For: maven-reporting-api-4.0.0-M9, 
> maven-reporting-impl-4.0.0-M12
>
>
> Based on a 
> [discussion|https://lists.apache.org/thread/6yxlvbhb7odfylfgjgzbvmvxg0vry20b] 
> with [~kriegaex], there are few conceptional or documentational issues with 
> the {{MavenReport}} interface:
> * {{#getOutputName()}} does not clearly say that is actually an optional base 
> *path* and base name (base location) of the report item from a reporting 
> output directory. It needs at least a doc update and maybe even a rename to 
> {{#getOutputPath()}}/{{#getOutputPathLocation()}}?
> * Both {{#setReportOutputDirectory(File outputDirectory)}} and 
> {{#getReportOutputDirectory()}} documentation imply tha this directory solely 
> refers to this single report, but that is not correct. It refers to root 
> directory which contains all possibly generated reports. A shared directory, 
> not exclusive one. Consider your report generates in a subdir, then these do 
> *not* refer to it, but to its parent.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (MSHARED-1326) Improve (documentation on) MavenReport interface/AbstractMavenReport class

2023-11-02 Thread ASF GitHub Bot (Jira)


[ 
https://issues.apache.org/jira/browse/MSHARED-1326?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17782295#comment-17782295
 ] 

ASF GitHub Bot commented on MSHARED-1326:
-

michael-o commented on code in PR #19:
URL: 
https://github.com/apache/maven-reporting-api/pull/19#discussion_r1380636744


##
src/main/java/org/apache/maven/reporting/MavenReport.java:
##
@@ -53,9 +53,10 @@ public interface MavenReport {
 void generate(Sink sink, Locale locale) throws MavenReportException;
 
 /**
- * Get the base name used to create report's output file(s).
+ * Get the path relative to {@link #getReportOutputDirectory()} where the 
report's main output
+ * file will be written. The last component is expected to be a basename 
only.

Review Comment:
   > OK, so I indeed did not understand what "basename" meant in this context, 
which is de facto evidence that this isn't clear enough. Either define 
"basename" as the "filename without an extension or period" or perhaps write 
something like, "The last component is the name of the file without any 
extension. The extension (.pdf, .html, etc.) will be added by the sink. For 
example, repodocs/subtext/analysis_report"
   > 
   > though perhaps this is hard to explain because the API itself is weird. I 
rarely encounter a path to a file that includes directories and file anme but 
not file extension.
   
   That's exactly what I thought about. The issue is that the plugin does not 
know the sink impl therefore it shall not make any assumptions. It could also 
be a sink to an output stream of a servlet.





> Improve (documentation on) MavenReport interface/AbstractMavenReport class
> --
>
> Key: MSHARED-1326
> URL: https://issues.apache.org/jira/browse/MSHARED-1326
> Project: Maven Shared Components
>  Issue Type: Task
>  Components: maven-reporting-api
>Affects Versions: maven-reporting-impl-4.0.0-M11, 
> maven-reporting-api-4.0.0-M8
>Reporter: Michael Osipov
>Assignee: Michael Osipov
>Priority: Major
> Fix For: maven-reporting-api-4.0.0-M9, 
> maven-reporting-impl-4.0.0-M12
>
>
> Based on a 
> [discussion|https://lists.apache.org/thread/6yxlvbhb7odfylfgjgzbvmvxg0vry20b] 
> with [~kriegaex], there are few conceptional or documentational issues with 
> the {{MavenReport}} interface:
> * {{#getOutputName()}} does not clearly say that is actually an optional base 
> *path* and base name (base location) of the report item from a reporting 
> output directory. It needs at least a doc update and maybe even a rename to 
> {{#getOutputPath()}}/{{#getOutputPathLocation()}}?
> * Both {{#setReportOutputDirectory(File outputDirectory)}} and 
> {{#getReportOutputDirectory()}} documentation imply tha this directory solely 
> refers to this single report, but that is not correct. It refers to root 
> directory which contains all possibly generated reports. A shared directory, 
> not exclusive one. Consider your report generates in a subdir, then these do 
> *not* refer to it, but to its parent.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


Re: [PR] [MSHARED-1326] Improve (documentation on) MavenReport interface [maven-reporting-api]

2023-11-02 Thread via GitHub


michael-o commented on code in PR #19:
URL: 
https://github.com/apache/maven-reporting-api/pull/19#discussion_r1380636744


##
src/main/java/org/apache/maven/reporting/MavenReport.java:
##
@@ -53,9 +53,10 @@ public interface MavenReport {
 void generate(Sink sink, Locale locale) throws MavenReportException;
 
 /**
- * Get the base name used to create report's output file(s).
+ * Get the path relative to {@link #getReportOutputDirectory()} where the 
report's main output
+ * file will be written. The last component is expected to be a basename 
only.

Review Comment:
   > OK, so I indeed did not understand what "basename" meant in this context, 
which is de facto evidence that this isn't clear enough. Either define 
"basename" as the "filename without an extension or period" or perhaps write 
something like, "The last component is the name of the file without any 
extension. The extension (.pdf, .html, etc.) will be added by the sink. For 
example, repodocs/subtext/analysis_report"
   > 
   > though perhaps this is hard to explain because the API itself is weird. I 
rarely encounter a path to a file that includes directories and file anme but 
not file extension.
   
   That's exactly what I thought about. The issue is that the plugin does not 
know the sink impl therefore it shall not make any assumptions. It could also 
be a sink to an output stream of a servlet.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[jira] [Commented] (MSHARED-1326) Improve (documentation on) MavenReport interface/AbstractMavenReport class

2023-11-02 Thread ASF GitHub Bot (Jira)


[ 
https://issues.apache.org/jira/browse/MSHARED-1326?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17782293#comment-17782293
 ] 

ASF GitHub Bot commented on MSHARED-1326:
-

elharo commented on code in PR #19:
URL: 
https://github.com/apache/maven-reporting-api/pull/19#discussion_r1380634183


##
src/main/java/org/apache/maven/reporting/MavenReport.java:
##
@@ -53,9 +53,10 @@ public interface MavenReport {
 void generate(Sink sink, Locale locale) throws MavenReportException;
 
 /**
- * Get the base name used to create report's output file(s).
+ * Get the path relative to {@link #getReportOutputDirectory()} where the 
report's main output
+ * file will be written. The last component is expected to be a basename 
only.

Review Comment:
   OK, so I indeed did not understand what "basename" meant in this context, 
which is de facto evidence that this isn't clear enough. Either define 
"basename" as the "filename without an extension or period" or perhaps write 
something like, "The last component is the name of the file without any 
extension. The extension (.pdf, .html, etc.) will be added by the sink. For 
example, repodocs/subtext/analysis_report"
   
   though perhaps this is hard to explain because the API itself is weird. I 
rarely encounter a path to a file that includes directories and file anme but 
not file extension. 





> Improve (documentation on) MavenReport interface/AbstractMavenReport class
> --
>
> Key: MSHARED-1326
> URL: https://issues.apache.org/jira/browse/MSHARED-1326
> Project: Maven Shared Components
>  Issue Type: Task
>  Components: maven-reporting-api
>Affects Versions: maven-reporting-impl-4.0.0-M11, 
> maven-reporting-api-4.0.0-M8
>Reporter: Michael Osipov
>Assignee: Michael Osipov
>Priority: Major
> Fix For: maven-reporting-api-4.0.0-M9, 
> maven-reporting-impl-4.0.0-M12
>
>
> Based on a 
> [discussion|https://lists.apache.org/thread/6yxlvbhb7odfylfgjgzbvmvxg0vry20b] 
> with [~kriegaex], there are few conceptional or documentational issues with 
> the {{MavenReport}} interface:
> * {{#getOutputName()}} does not clearly say that is actually an optional base 
> *path* and base name (base location) of the report item from a reporting 
> output directory. It needs at least a doc update and maybe even a rename to 
> {{#getOutputPath()}}/{{#getOutputPathLocation()}}?
> * Both {{#setReportOutputDirectory(File outputDirectory)}} and 
> {{#getReportOutputDirectory()}} documentation imply tha this directory solely 
> refers to this single report, but that is not correct. It refers to root 
> directory which contains all possibly generated reports. A shared directory, 
> not exclusive one. Consider your report generates in a subdir, then these do 
> *not* refer to it, but to its parent.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


Re: [PR] [MSHARED-1326] Improve (documentation on) MavenReport interface [maven-reporting-api]

2023-11-02 Thread via GitHub


elharo commented on code in PR #19:
URL: 
https://github.com/apache/maven-reporting-api/pull/19#discussion_r1380634183


##
src/main/java/org/apache/maven/reporting/MavenReport.java:
##
@@ -53,9 +53,10 @@ public interface MavenReport {
 void generate(Sink sink, Locale locale) throws MavenReportException;
 
 /**
- * Get the base name used to create report's output file(s).
+ * Get the path relative to {@link #getReportOutputDirectory()} where the 
report's main output
+ * file will be written. The last component is expected to be a basename 
only.

Review Comment:
   OK, so I indeed did not understand what "basename" meant in this context, 
which is de facto evidence that this isn't clear enough. Either define 
"basename" as the "filename without an extension or period" or perhaps write 
something like, "The last component is the name of the file without any 
extension. The extension (.pdf, .html, etc.) will be added by the sink. For 
example, repodocs/subtext/analysis_report"
   
   though perhaps this is hard to explain because the API itself is weird. I 
rarely encounter a path to a file that includes directories and file anme but 
not file extension. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[jira] [Commented] (MSHARED-1326) Improve (documentation on) MavenReport interface/AbstractMavenReport class

2023-11-02 Thread ASF GitHub Bot (Jira)


[ 
https://issues.apache.org/jira/browse/MSHARED-1326?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17782289#comment-17782289
 ] 

ASF GitHub Bot commented on MSHARED-1326:
-

michael-o commented on code in PR #19:
URL: 
https://github.com/apache/maven-reporting-api/pull/19#discussion_r1380623760


##
src/main/java/org/apache/maven/reporting/MavenReport.java:
##
@@ -53,9 +53,10 @@ public interface MavenReport {
 void generate(Sink sink, Locale locale) throws MavenReportException;
 
 /**
- * Get the base name used to create report's output file(s).
+ * Get the path relative to {@link #getReportOutputDirectory()} where the 
report's main output
+ * file will be written. The last component is expected to be a basename 
only.

Review Comment:
   Since all reports are output format agnostic, the output path does not 
contain any extension, this is handled by a sink. Basename of the output file. 
E.g., index, foo, etc. How would you word it?





> Improve (documentation on) MavenReport interface/AbstractMavenReport class
> --
>
> Key: MSHARED-1326
> URL: https://issues.apache.org/jira/browse/MSHARED-1326
> Project: Maven Shared Components
>  Issue Type: Task
>  Components: maven-reporting-api
>Affects Versions: maven-reporting-impl-4.0.0-M11, 
> maven-reporting-api-4.0.0-M8
>Reporter: Michael Osipov
>Assignee: Michael Osipov
>Priority: Major
> Fix For: maven-reporting-api-4.0.0-M9, 
> maven-reporting-impl-4.0.0-M12
>
>
> Based on a 
> [discussion|https://lists.apache.org/thread/6yxlvbhb7odfylfgjgzbvmvxg0vry20b] 
> with [~kriegaex], there are few conceptional or documentational issues with 
> the {{MavenReport}} interface:
> * {{#getOutputName()}} does not clearly say that is actually an optional base 
> *path* and base name (base location) of the report item from a reporting 
> output directory. It needs at least a doc update and maybe even a rename to 
> {{#getOutputPath()}}/{{#getOutputPathLocation()}}?
> * Both {{#setReportOutputDirectory(File outputDirectory)}} and 
> {{#getReportOutputDirectory()}} documentation imply tha this directory solely 
> refers to this single report, but that is not correct. It refers to root 
> directory which contains all possibly generated reports. A shared directory, 
> not exclusive one. Consider your report generates in a subdir, then these do 
> *not* refer to it, but to its parent.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


Re: [PR] [MSHARED-1326] Improve (documentation on) MavenReport interface [maven-reporting-api]

2023-11-02 Thread via GitHub


michael-o commented on code in PR #19:
URL: 
https://github.com/apache/maven-reporting-api/pull/19#discussion_r1380623760


##
src/main/java/org/apache/maven/reporting/MavenReport.java:
##
@@ -53,9 +53,10 @@ public interface MavenReport {
 void generate(Sink sink, Locale locale) throws MavenReportException;
 
 /**
- * Get the base name used to create report's output file(s).
+ * Get the path relative to {@link #getReportOutputDirectory()} where the 
report's main output
+ * file will be written. The last component is expected to be a basename 
only.

Review Comment:
   Since all reports are output format agnostic, the output path does not 
contain any extension, this is handled by a sink. Basename of the output file. 
E.g., index, foo, etc. How would you word it?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] [MSHARED-1326] Improve (documentation on) MavenReport interface [maven-reporting-api]

2023-11-02 Thread via GitHub


michael-o commented on code in PR #19:
URL: 
https://github.com/apache/maven-reporting-api/pull/19#discussion_r1380623760


##
src/main/java/org/apache/maven/reporting/MavenReport.java:
##
@@ -53,9 +53,10 @@ public interface MavenReport {
 void generate(Sink sink, Locale locale) throws MavenReportException;
 
 /**
- * Get the base name used to create report's output file(s).
+ * Get the path relative to {@link #getReportOutputDirectory()} where the 
report's main output
+ * file will be written. The last component is expected to be a basename 
only.

Review Comment:
   Since all reports are output format agostic, the output path does not 
contain any extension, this is handled by a sink. Basename of the output file. 
E.g., index, foo, etc. How would you word it?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[jira] [Commented] (MSHARED-1326) Improve (documentation on) MavenReport interface/AbstractMavenReport class

2023-11-02 Thread ASF GitHub Bot (Jira)


[ 
https://issues.apache.org/jira/browse/MSHARED-1326?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17782288#comment-17782288
 ] 

ASF GitHub Bot commented on MSHARED-1326:
-

michael-o commented on code in PR #19:
URL: 
https://github.com/apache/maven-reporting-api/pull/19#discussion_r1380623760


##
src/main/java/org/apache/maven/reporting/MavenReport.java:
##
@@ -53,9 +53,10 @@ public interface MavenReport {
 void generate(Sink sink, Locale locale) throws MavenReportException;
 
 /**
- * Get the base name used to create report's output file(s).
+ * Get the path relative to {@link #getReportOutputDirectory()} where the 
report's main output
+ * file will be written. The last component is expected to be a basename 
only.

Review Comment:
   Since all reports are output format agostic, the output path does not 
contain any extension, this is handled by a sink. Basename of the output file. 
E.g., index, foo, etc. How would you word it?





> Improve (documentation on) MavenReport interface/AbstractMavenReport class
> --
>
> Key: MSHARED-1326
> URL: https://issues.apache.org/jira/browse/MSHARED-1326
> Project: Maven Shared Components
>  Issue Type: Task
>  Components: maven-reporting-api
>Affects Versions: maven-reporting-impl-4.0.0-M11, 
> maven-reporting-api-4.0.0-M8
>Reporter: Michael Osipov
>Assignee: Michael Osipov
>Priority: Major
> Fix For: maven-reporting-api-4.0.0-M9, 
> maven-reporting-impl-4.0.0-M12
>
>
> Based on a 
> [discussion|https://lists.apache.org/thread/6yxlvbhb7odfylfgjgzbvmvxg0vry20b] 
> with [~kriegaex], there are few conceptional or documentational issues with 
> the {{MavenReport}} interface:
> * {{#getOutputName()}} does not clearly say that is actually an optional base 
> *path* and base name (base location) of the report item from a reporting 
> output directory. It needs at least a doc update and maybe even a rename to 
> {{#getOutputPath()}}/{{#getOutputPathLocation()}}?
> * Both {{#setReportOutputDirectory(File outputDirectory)}} and 
> {{#getReportOutputDirectory()}} documentation imply tha this directory solely 
> refers to this single report, but that is not correct. It refers to root 
> directory which contains all possibly generated reports. A shared directory, 
> not exclusive one. Consider your report generates in a subdir, then these do 
> *not* refer to it, but to its parent.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (MSHARED-1326) Improve (documentation on) MavenReport interface/AbstractMavenReport class

2023-11-02 Thread ASF GitHub Bot (Jira)


[ 
https://issues.apache.org/jira/browse/MSHARED-1326?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17782286#comment-17782286
 ] 

ASF GitHub Bot commented on MSHARED-1326:
-

elharo commented on code in PR #19:
URL: 
https://github.com/apache/maven-reporting-api/pull/19#discussion_r1380616343


##
src/main/java/org/apache/maven/reporting/MavenReport.java:
##
@@ -53,9 +53,10 @@ public interface MavenReport {
 void generate(Sink sink, Locale locale) throws MavenReportException;
 
 /**
- * Get the base name used to create report's output file(s).
+ * Get the path relative to {@link #getReportOutputDirectory()} where the 
report's main output
+ * file will be written. The last component is expected to be a basename 
only.
  *
- * @return the output name of this report.
+ * @return the relative path of this report.

Review Comment:
   no period



##
src/main/java/org/apache/maven/reporting/MavenReport.java:
##
@@ -84,14 +85,17 @@ public interface MavenReport {
 String getDescription(Locale locale);
 
 /**
- * Set a new output directory. Useful for staging.
+ * Set a new shared report output directory. This directory may contain 
the output of other
+ * reports as well.
  *
- * @param outputDirectory the new output directory
+ * @param outputDirectory the new shared report output directory
  */
 void setReportOutputDirectory(File outputDirectory);
 
 /**
- * @return the current report output directory.
+ * Get the shared report output directory.
+ *
+ * @return the current shared report output directory.

Review Comment:
   no period



##
src/main/java/org/apache/maven/reporting/MavenReport.java:
##
@@ -53,9 +53,10 @@ public interface MavenReport {
 void generate(Sink sink, Locale locale) throws MavenReportException;
 
 /**
- * Get the base name used to create report's output file(s).
+ * Get the path relative to {@link #getReportOutputDirectory()} where the 
report's main output
+ * file will be written. The last component is expected to be a basename 
only.

Review Comment:
   still not sure what "basename" means. I guess the point is it's a directory, 
not a filename? 





> Improve (documentation on) MavenReport interface/AbstractMavenReport class
> --
>
> Key: MSHARED-1326
> URL: https://issues.apache.org/jira/browse/MSHARED-1326
> Project: Maven Shared Components
>  Issue Type: Task
>  Components: maven-reporting-api
>Affects Versions: maven-reporting-impl-4.0.0-M11, 
> maven-reporting-api-4.0.0-M8
>Reporter: Michael Osipov
>Assignee: Michael Osipov
>Priority: Major
> Fix For: maven-reporting-api-4.0.0-M9, 
> maven-reporting-impl-4.0.0-M12
>
>
> Based on a 
> [discussion|https://lists.apache.org/thread/6yxlvbhb7odfylfgjgzbvmvxg0vry20b] 
> with [~kriegaex], there are few conceptional or documentational issues with 
> the {{MavenReport}} interface:
> * {{#getOutputName()}} does not clearly say that is actually an optional base 
> *path* and base name (base location) of the report item from a reporting 
> output directory. It needs at least a doc update and maybe even a rename to 
> {{#getOutputPath()}}/{{#getOutputPathLocation()}}?
> * Both {{#setReportOutputDirectory(File outputDirectory)}} and 
> {{#getReportOutputDirectory()}} documentation imply tha this directory solely 
> refers to this single report, but that is not correct. It refers to root 
> directory which contains all possibly generated reports. A shared directory, 
> not exclusive one. Consider your report generates in a subdir, then these do 
> *not* refer to it, but to its parent.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


Re: [PR] [MSHARED-1326] Improve (documentation on) MavenReport interface [maven-reporting-api]

2023-11-02 Thread via GitHub


elharo commented on code in PR #19:
URL: 
https://github.com/apache/maven-reporting-api/pull/19#discussion_r1380616343


##
src/main/java/org/apache/maven/reporting/MavenReport.java:
##
@@ -53,9 +53,10 @@ public interface MavenReport {
 void generate(Sink sink, Locale locale) throws MavenReportException;
 
 /**
- * Get the base name used to create report's output file(s).
+ * Get the path relative to {@link #getReportOutputDirectory()} where the 
report's main output
+ * file will be written. The last component is expected to be a basename 
only.
  *
- * @return the output name of this report.
+ * @return the relative path of this report.

Review Comment:
   no period



##
src/main/java/org/apache/maven/reporting/MavenReport.java:
##
@@ -84,14 +85,17 @@ public interface MavenReport {
 String getDescription(Locale locale);
 
 /**
- * Set a new output directory. Useful for staging.
+ * Set a new shared report output directory. This directory may contain 
the output of other
+ * reports as well.
  *
- * @param outputDirectory the new output directory
+ * @param outputDirectory the new shared report output directory
  */
 void setReportOutputDirectory(File outputDirectory);
 
 /**
- * @return the current report output directory.
+ * Get the shared report output directory.
+ *
+ * @return the current shared report output directory.

Review Comment:
   no period



##
src/main/java/org/apache/maven/reporting/MavenReport.java:
##
@@ -53,9 +53,10 @@ public interface MavenReport {
 void generate(Sink sink, Locale locale) throws MavenReportException;
 
 /**
- * Get the base name used to create report's output file(s).
+ * Get the path relative to {@link #getReportOutputDirectory()} where the 
report's main output
+ * file will be written. The last component is expected to be a basename 
only.

Review Comment:
   still not sure what "basename" means. I guess the point is it's a directory, 
not a filename? 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[jira] [Commented] (MNGSITE-527) broken link to settings-1.3.0.xsd

2023-11-02 Thread ASF GitHub Bot (Jira)


[ 
https://issues.apache.org/jira/browse/MNGSITE-527?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17782226#comment-17782226
 ] 

ASF GitHub Bot commented on MNGSITE-527:


froque opened a new pull request, #464:
URL: https://github.com/apache/maven-site/pull/464

   (no comment)




> broken link to settings-1.3.0.xsd
> -
>
> Key: MNGSITE-527
> URL: https://issues.apache.org/jira/browse/MNGSITE-527
> Project: Maven Project Web Site
>  Issue Type: Bug
>Reporter: Filipe Roque
>Priority: Major
>
> The url of the XSD mentioned in the settings.xml settings tag is broken in 
> Maven 4
> {code:java}
> http://maven.apache.org/SETTINGS/1.3.0";
>   xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance";
>   xsi:schemaLocation="http://maven.apache.org/SETTINGS/1.3.0 
> https://maven.apache.org/xsd/settings-1.3.0.xsd";> {code}
> Both the settings.xml found at apache-maven-4.0.0-alpha-8/conf/settings.xml 
> and at https://maven.apache.org/ref/4-LATEST/maven-settings/settings.html 
> reference a broken url.
> There are older Versions at [http://maven.apache.org/xsd/].



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (MSHARED-1326) Improve (documentation on) MavenReport interface/AbstractMavenReport class

2023-11-02 Thread ASF GitHub Bot (Jira)


[ 
https://issues.apache.org/jira/browse/MSHARED-1326?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17782247#comment-17782247
 ] 

ASF GitHub Bot commented on MSHARED-1326:
-

michael-o commented on PR #19:
URL: 
https://github.com/apache/maven-reporting-api/pull/19#issuecomment-1791230206

   @elharo I tried to apply all of your comments. Maybe the method has to 
renamed to:
   ```java
   String getOutputPath()
   ```
   since `Name` is misleading...?




> Improve (documentation on) MavenReport interface/AbstractMavenReport class
> --
>
> Key: MSHARED-1326
> URL: https://issues.apache.org/jira/browse/MSHARED-1326
> Project: Maven Shared Components
>  Issue Type: Task
>  Components: maven-reporting-api
>Affects Versions: maven-reporting-impl-4.0.0-M11, 
> maven-reporting-api-4.0.0-M8
>Reporter: Michael Osipov
>Assignee: Michael Osipov
>Priority: Major
> Fix For: maven-reporting-api-4.0.0-M9, 
> maven-reporting-impl-4.0.0-M12
>
>
> Based on a 
> [discussion|https://lists.apache.org/thread/6yxlvbhb7odfylfgjgzbvmvxg0vry20b] 
> with [~kriegaex], there are few conceptional or documentational issues with 
> the {{MavenReport}} interface:
> * {{#getOutputName()}} does not clearly say that is actually an optional base 
> *path* and base name (base location) of the report item from a reporting 
> output directory. It needs at least a doc update and maybe even a rename to 
> {{#getOutputPath()}}/{{#getOutputPathLocation()}}?
> * Both {{#setReportOutputDirectory(File outputDirectory)}} and 
> {{#getReportOutputDirectory()}} documentation imply tha this directory solely 
> refers to this single report, but that is not correct. It refers to root 
> directory which contains all possibly generated reports. A shared directory, 
> not exclusive one. Consider your report generates in a subdir, then these do 
> *not* refer to it, but to its parent.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Updated] (MNGSITE-527) broken link to settings-1.3.0.xsd

2023-11-02 Thread Filipe Roque (Jira)


 [ 
https://issues.apache.org/jira/browse/MNGSITE-527?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Filipe Roque updated MNGSITE-527:
-
Description: 
The url of the XSD mentioned in the settings.xml settings tag is broken in 
Maven 4
{code:java}
http://maven.apache.org/SETTINGS/1.3.0";
  xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance";
  xsi:schemaLocation="http://maven.apache.org/SETTINGS/1.3.0 
https://maven.apache.org/xsd/settings-1.3.0.xsd";> {code}
Both the settings.xml found at apache-maven-4.0.0-alpha-8/conf/settings.xml and 
at 
[https://maven.apache.org/ref/4-LATEST/maven-settings/settings.html|[http://example.com|https://maven.apache.org/ref/4-LATEST/maven-settings/settings.html]]
 reference a broken url.

There are older Versions at [http://maven.apache.org/xsd/].

  was:
The url of the XSD mentioned in the settings.xml settings tag is broken in 
Maven 4
{code:java}
http://maven.apache.org/SETTINGS/1.3.0";
  xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance";
  xsi:schemaLocation="http://maven.apache.org/SETTINGS/1.3.0 
https://maven.apache.org/xsd/settings-1.3.0.xsd";> {code}
Both the settings.xml found at apache-maven-4.0.0-alpha-8/conf/settings.xml and 
at [http://maven.apache.org/ref/3.8.1/maven-settings/settings.html] reference a 
broken url.

There are older Versions at [http://maven.apache.org/xsd/].


> broken link to settings-1.3.0.xsd
> -
>
> Key: MNGSITE-527
> URL: https://issues.apache.org/jira/browse/MNGSITE-527
> Project: Maven Project Web Site
>  Issue Type: Bug
>Reporter: Filipe Roque
>Priority: Major
>
> The url of the XSD mentioned in the settings.xml settings tag is broken in 
> Maven 4
> {code:java}
> http://maven.apache.org/SETTINGS/1.3.0";
>   xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance";
>   xsi:schemaLocation="http://maven.apache.org/SETTINGS/1.3.0 
> https://maven.apache.org/xsd/settings-1.3.0.xsd";> {code}
> Both the settings.xml found at apache-maven-4.0.0-alpha-8/conf/settings.xml 
> and at 
> [https://maven.apache.org/ref/4-LATEST/maven-settings/settings.html|[http://example.com|https://maven.apache.org/ref/4-LATEST/maven-settings/settings.html]]
>  reference a broken url.
> There are older Versions at [http://maven.apache.org/xsd/].



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (MNGSITE-527) broken link to settings-1.3.0.xsd

2023-11-02 Thread Michael Osipov (Jira)


[ 
https://issues.apache.org/jira/browse/MNGSITE-527?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17782249#comment-17782249
 ] 

Michael Osipov commented on MNGSITE-527:


[~gnodet], please take.

> broken link to settings-1.3.0.xsd
> -
>
> Key: MNGSITE-527
> URL: https://issues.apache.org/jira/browse/MNGSITE-527
> Project: Maven Project Web Site
>  Issue Type: Bug
>Reporter: Filipe Roque
>Priority: Major
>
> The url of the XSD mentioned in the settings.xml settings tag is broken in 
> Maven 4
> {code:java}
> http://maven.apache.org/SETTINGS/1.3.0";
>   xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance";
>   xsi:schemaLocation="http://maven.apache.org/SETTINGS/1.3.0 
> https://maven.apache.org/xsd/settings-1.3.0.xsd";> {code}
> Both the settings.xml found at apache-maven-4.0.0-alpha-8/conf/settings.xml 
> and at https://maven.apache.org/ref/4-LATEST/maven-settings/settings.html 
> reference a broken url.
> There are older Versions at [http://maven.apache.org/xsd/].



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[PR] MNGSITE-527 broken link to settings-1.3.0.xsd [maven-site]

2023-11-02 Thread via GitHub


froque opened a new pull request, #464:
URL: https://github.com/apache/maven-site/pull/464

   (no comment)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] [MSHARED-1326] Improve (documentation on) MavenReport interface [maven-reporting-api]

2023-11-02 Thread via GitHub


michael-o commented on PR #19:
URL: 
https://github.com/apache/maven-reporting-api/pull/19#issuecomment-1791230206

   @elharo I tried to apply all of your comments. Maybe the method has to 
renamed to:
   ```java
   String getOutputPath()
   ```
   since `Name` is misleading...?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[I] "Unable to find the root directory" in multi-module build [maven-mvnd]

2023-11-02 Thread via GitHub


calle2010 opened a new issue, #901:
URL: https://github.com/apache/maven-mvnd/issues/901

   In different projects with multiple modules mvnd 1.0-m7 prints in the first 
line
   
   Unable to find the root directory. Create a .mvn directory in the root 
directory or add the root="true" attribute on the root project's model to 
identify it.
   
   But Maven 4.0.0-alpha-8 doesn't complain. In both cases Maven is started 
from the project root directory. Creating the ".mvn" directory doesn't mute the 
message printed by mvnd.
   
   ```
   $ mvnd -1 -DskipTests clean compile
   Unable to find the root directory. Create a .mvn directory in the root 
directory or add the root="true" attribute on the root project's model to 
identify it.
   [INFO] Processing build on daemon 85f9f7c1
   [INFO] Scanning for projects...
   [INFO] BuildTimeEventSpy is registered.
   [INFO] 

   [INFO] Reactor Build Order:
   ^C
   
   $ mvn -DskipTests clean compile
   [INFO] Scanning for projects...
   [INFO] 

   [INFO] Reactor Build Order:
   ^C
   
   $ mvnd -v
   Unable to find the root directory. Create a .mvn directory in the root 
directory or add the root="true" attribute on the root project's model to 
identify it.
   Apache Maven Daemon (mvnd) 1.0-m7 linux-amd64 native client 
(b2ef5d81997adbcdb72dc8c5603722538fa641fe)
   Terminal: org.jline.terminal.impl.PosixSysTerminal with pty 
org.jline.terminal.impl.jansi.linux.LinuxNativePty
   Apache Maven 4.0.0-alpha-7 (bf699a388cc04b8e4088226ba09a403b68de6b7b)
   Maven home: /home/wsl/bin/maven-mvnd-1.0-m7-m40-linux-amd64/mvn
   Java version: 21.0.1, vendor: Eclipse Adoptium, runtime: 
/usr/lib/jvm/temurin-21-jdk-amd64
   Default locale: en, platform encoding: UTF-8
   OS name: "linux", version: "5.15.90.1-microsoft-standard-wsl2", arch: 
"amd64", family: "unix"
   
   $ mvn -v
   Apache Maven 4.0.0-alpha-8 (a2cbf4873a99c1aca7e3908086fe53b17865f07a)
   Maven home: /home/wsl/bin/apache-maven-4.0.0-alpha-8
   Java version: 21.0.1, vendor: Eclipse Adoptium, runtime: 
/usr/lib/jvm/temurin-21-jdk-amd64
   Default locale: en, platform encoding: UTF-8
   OS name: "linux", version: "5.15.90.1-microsoft-standard-wsl2", arch: 
"amd64", family: "unix"
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[jira] [Updated] (MNGSITE-527) broken link to settings-1.3.0.xsd

2023-11-02 Thread Filipe Roque (Jira)


 [ 
https://issues.apache.org/jira/browse/MNGSITE-527?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Filipe Roque updated MNGSITE-527:
-
Description: 
The url of the XSD mentioned in the settings.xml settings tag is broken in 
Maven 4
{code:java}
http://maven.apache.org/SETTINGS/1.3.0";
  xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance";
  xsi:schemaLocation="http://maven.apache.org/SETTINGS/1.3.0 
https://maven.apache.org/xsd/settings-1.3.0.xsd";> {code}
Both the settings.xml found at apache-maven-4.0.0-alpha-8/conf/settings.xml and 
at https://maven.apache.org/ref/4-LATEST/maven-settings/settings.html reference 
a broken url.

There are older Versions at [http://maven.apache.org/xsd/].

  was:
The url of the XSD mentioned in the settings.xml settings tag is broken in 
Maven 4
{code:java}
http://maven.apache.org/SETTINGS/1.3.0";
  xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance";
  xsi:schemaLocation="http://maven.apache.org/SETTINGS/1.3.0 
https://maven.apache.org/xsd/settings-1.3.0.xsd";> {code}
Both the settings.xml found at apache-maven-4.0.0-alpha-8/conf/settings.xml and 
at 
[https://maven.apache.org/ref/4-LATEST/maven-settings/settings.html|[http://example.com|https://maven.apache.org/ref/4-LATEST/maven-settings/settings.html]]
 reference a broken url.

There are older Versions at [http://maven.apache.org/xsd/].


> broken link to settings-1.3.0.xsd
> -
>
> Key: MNGSITE-527
> URL: https://issues.apache.org/jira/browse/MNGSITE-527
> Project: Maven Project Web Site
>  Issue Type: Bug
>Reporter: Filipe Roque
>Priority: Major
>
> The url of the XSD mentioned in the settings.xml settings tag is broken in 
> Maven 4
> {code:java}
> http://maven.apache.org/SETTINGS/1.3.0";
>   xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance";
>   xsi:schemaLocation="http://maven.apache.org/SETTINGS/1.3.0 
> https://maven.apache.org/xsd/settings-1.3.0.xsd";> {code}
> Both the settings.xml found at apache-maven-4.0.0-alpha-8/conf/settings.xml 
> and at https://maven.apache.org/ref/4-LATEST/maven-settings/settings.html 
> reference a broken url.
> There are older Versions at [http://maven.apache.org/xsd/].



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Created] (MNGSITE-527) broken link to settings-1.3.0.xsd

2023-11-02 Thread Filipe Roque (Jira)
Filipe Roque created MNGSITE-527:


 Summary: broken link to settings-1.3.0.xsd
 Key: MNGSITE-527
 URL: https://issues.apache.org/jira/browse/MNGSITE-527
 Project: Maven Project Web Site
  Issue Type: Bug
Reporter: Filipe Roque


The url of the XSD mentioned in the settings.xml settings tag is broken in 
Maven 4
{code:java}
http://maven.apache.org/SETTINGS/1.3.0";
  xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance";
  xsi:schemaLocation="http://maven.apache.org/SETTINGS/1.3.0 
https://maven.apache.org/xsd/settings-1.3.0.xsd";> {code}
Both the settings.xml found at apache-maven-4.0.0-alpha-8/conf/settings.xml and 
at [http://maven.apache.org/ref/3.8.1/maven-settings/settings.html] reference a 
broken url.

There are older Versions at [http://maven.apache.org/xsd/].



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Updated] (MRESOLVER-423) Remove the 3.x banner from Resolver site

2023-11-02 Thread Tamas Cservenak (Jira)


 [ 
https://issues.apache.org/jira/browse/MRESOLVER-423?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Tamas Cservenak updated MRESOLVER-423:
--
Summary: Remove the 3.x banner from Resolver site  (was: Remove the 
nonsense banner from Resolver site)

> Remove the 3.x banner from Resolver site
> 
>
> Key: MRESOLVER-423
> URL: https://issues.apache.org/jira/browse/MRESOLVER-423
> Project: Maven Resolver
>  Issue Type: Task
>  Components: Resolver
>Reporter: Tamas Cservenak
>Assignee: Tamas Cservenak
>Priority: Major
> Fix For: 2.0.0
>
>
> The resolver index page starts with "Since version 1.7.0 Maven Resolver 
> requires Java 8 to run. For a Maven 3.8.x compatible version read here.". 
> Remove this, it really does not belong to Resolver 2.0.0.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (MRESOLVER-423) Remove the nonsense banner from Resolver site

2023-11-02 Thread ASF GitHub Bot (Jira)


[ 
https://issues.apache.org/jira/browse/MRESOLVER-423?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17782127#comment-17782127
 ] 

ASF GitHub Bot commented on MRESOLVER-423:
--

cstamas merged PR #354:
URL: https://github.com/apache/maven-resolver/pull/354




> Remove the nonsense banner from Resolver site
> -
>
> Key: MRESOLVER-423
> URL: https://issues.apache.org/jira/browse/MRESOLVER-423
> Project: Maven Resolver
>  Issue Type: Task
>  Components: Resolver
>Reporter: Tamas Cservenak
>Assignee: Tamas Cservenak
>Priority: Major
> Fix For: 2.0.0
>
>
> The resolver index page starts with "Since version 1.7.0 Maven Resolver 
> requires Java 8 to run. For a Maven 3.8.x compatible version read here.". 
> Remove this, it really does not belong to Resolver 2.0.0.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Closed] (MRESOLVER-423) Remove the nonsense banner from Resolver site

2023-11-02 Thread Tamas Cservenak (Jira)


 [ 
https://issues.apache.org/jira/browse/MRESOLVER-423?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Tamas Cservenak closed MRESOLVER-423.
-
Resolution: Fixed

> Remove the nonsense banner from Resolver site
> -
>
> Key: MRESOLVER-423
> URL: https://issues.apache.org/jira/browse/MRESOLVER-423
> Project: Maven Resolver
>  Issue Type: Task
>  Components: Resolver
>Reporter: Tamas Cservenak
>Assignee: Tamas Cservenak
>Priority: Major
> Fix For: 2.0.0
>
>
> The resolver index page starts with "Since version 1.7.0 Maven Resolver 
> requires Java 8 to run. For a Maven 3.8.x compatible version read here.". 
> Remove this, it really does not belong to Resolver 2.0.0.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


Re: [PR] [MRESOLVER-423] Legacy promotion is no stay here [maven-resolver]

2023-11-02 Thread via GitHub


cstamas merged PR #354:
URL: https://github.com/apache/maven-resolver/pull/354


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[jira] [Commented] (MSHARED-1326) Improve (documentation on) MavenReport interface/AbstractMavenReport class

2023-11-02 Thread ASF GitHub Bot (Jira)


[ 
https://issues.apache.org/jira/browse/MSHARED-1326?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17782126#comment-17782126
 ] 

ASF GitHub Bot commented on MSHARED-1326:
-

elharo commented on code in PR #19:
URL: 
https://github.com/apache/maven-reporting-api/pull/19#discussion_r1380023006


##
src/main/java/org/apache/maven/reporting/MavenReport.java:
##
@@ -53,7 +53,9 @@ public interface MavenReport {
 void generate(Sink sink, Locale locale) throws MavenReportException;
 
 /**
- * Get the base name used to create report's output file(s).
+ * Get the output name denoting a base location relative to the {@link 
#getReportOutputDirectory()}
+ * used to create the report's main output file. The base location may 
contain path components

Review Comment:
   Specific actionable context is useful, but too much "business need" is just 
wasted words. Common examples:
   
   * in order to improve performance
   * in order to improve customer service
   * in order to better serve you
   
   None of these actually explain anything. Here don't just say "to better 
structure the report output" but explain how the report output structure is 
changed, or say nothing at all. I don't know if this is accurate but something 
like "to divide the report documents into separate subdirectories" would be 
more concrete. "to better structure the report output" is not a user story and 
does not explain the business value. 
   





> Improve (documentation on) MavenReport interface/AbstractMavenReport class
> --
>
> Key: MSHARED-1326
> URL: https://issues.apache.org/jira/browse/MSHARED-1326
> Project: Maven Shared Components
>  Issue Type: Task
>  Components: maven-reporting-api
>Affects Versions: maven-reporting-impl-4.0.0-M11, 
> maven-reporting-api-4.0.0-M8
>Reporter: Michael Osipov
>Assignee: Michael Osipov
>Priority: Major
> Fix For: maven-reporting-api-4.0.0-M9, 
> maven-reporting-impl-4.0.0-M12
>
>
> Based on a 
> [discussion|https://lists.apache.org/thread/6yxlvbhb7odfylfgjgzbvmvxg0vry20b] 
> with [~kriegaex], there are few conceptional or documentational issues with 
> the {{MavenReport}} interface:
> * {{#getOutputName()}} does not clearly say that is actually an optional base 
> *path* and base name (base location) of the report item from a reporting 
> output directory. It needs at least a doc update and maybe even a rename to 
> {{#getOutputPath()}}/{{#getOutputPathLocation()}}?
> * Both {{#setReportOutputDirectory(File outputDirectory)}} and 
> {{#getReportOutputDirectory()}} documentation imply tha this directory solely 
> refers to this single report, but that is not correct. It refers to root 
> directory which contains all possibly generated reports. A shared directory, 
> not exclusive one. Consider your report generates in a subdir, then these do 
> *not* refer to it, but to its parent.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (MSHARED-1326) Improve (documentation on) MavenReport interface/AbstractMavenReport class

2023-11-02 Thread ASF GitHub Bot (Jira)


[ 
https://issues.apache.org/jira/browse/MSHARED-1326?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17782125#comment-17782125
 ] 

ASF GitHub Bot commented on MSHARED-1326:
-

elharo commented on code in PR #19:
URL: 
https://github.com/apache/maven-reporting-api/pull/19#discussion_r1380023006


##
src/main/java/org/apache/maven/reporting/MavenReport.java:
##
@@ -53,7 +53,9 @@ public interface MavenReport {
 void generate(Sink sink, Locale locale) throws MavenReportException;
 
 /**
- * Get the base name used to create report's output file(s).
+ * Get the output name denoting a base location relative to the {@link 
#getReportOutputDirectory()}
+ * used to create the report's main output file. The base location may 
contain path components

Review Comment:
   Specific actionable context is useful, but too much "business need" is just 
wasted words. Commons examples:
   
   * in order to improve performance
   * in order to improve customer service
   * in order to better serve you
   
   None of these actually explain anything. Here don't just say "to better 
structure the report output" but explain how the report output structure is 
changed, or say nothing at all. I don't know if this is accurate but something 
like "to divide the report documents into separate subdirectories" would be 
more concrete. "to better structure the report output" is not a user story and 
does not explain the business value. 
   





> Improve (documentation on) MavenReport interface/AbstractMavenReport class
> --
>
> Key: MSHARED-1326
> URL: https://issues.apache.org/jira/browse/MSHARED-1326
> Project: Maven Shared Components
>  Issue Type: Task
>  Components: maven-reporting-api
>Affects Versions: maven-reporting-impl-4.0.0-M11, 
> maven-reporting-api-4.0.0-M8
>Reporter: Michael Osipov
>Assignee: Michael Osipov
>Priority: Major
> Fix For: maven-reporting-api-4.0.0-M9, 
> maven-reporting-impl-4.0.0-M12
>
>
> Based on a 
> [discussion|https://lists.apache.org/thread/6yxlvbhb7odfylfgjgzbvmvxg0vry20b] 
> with [~kriegaex], there are few conceptional or documentational issues with 
> the {{MavenReport}} interface:
> * {{#getOutputName()}} does not clearly say that is actually an optional base 
> *path* and base name (base location) of the report item from a reporting 
> output directory. It needs at least a doc update and maybe even a rename to 
> {{#getOutputPath()}}/{{#getOutputPathLocation()}}?
> * Both {{#setReportOutputDirectory(File outputDirectory)}} and 
> {{#getReportOutputDirectory()}} documentation imply tha this directory solely 
> refers to this single report, but that is not correct. It refers to root 
> directory which contains all possibly generated reports. A shared directory, 
> not exclusive one. Consider your report generates in a subdir, then these do 
> *not* refer to it, but to its parent.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


Re: [PR] [MSHARED-1326] Improve (documentation on) MavenReport interface [maven-reporting-api]

2023-11-02 Thread via GitHub


elharo commented on code in PR #19:
URL: 
https://github.com/apache/maven-reporting-api/pull/19#discussion_r1380023006


##
src/main/java/org/apache/maven/reporting/MavenReport.java:
##
@@ -53,7 +53,9 @@ public interface MavenReport {
 void generate(Sink sink, Locale locale) throws MavenReportException;
 
 /**
- * Get the base name used to create report's output file(s).
+ * Get the output name denoting a base location relative to the {@link 
#getReportOutputDirectory()}
+ * used to create the report's main output file. The base location may 
contain path components

Review Comment:
   Specific actionable context is useful, but too much "business need" is just 
wasted words. Common examples:
   
   * in order to improve performance
   * in order to improve customer service
   * in order to better serve you
   
   None of these actually explain anything. Here don't just say "to better 
structure the report output" but explain how the report output structure is 
changed, or say nothing at all. I don't know if this is accurate but something 
like "to divide the report documents into separate subdirectories" would be 
more concrete. "to better structure the report output" is not a user story and 
does not explain the business value. 
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] [MSHARED-1326] Improve (documentation on) MavenReport interface [maven-reporting-api]

2023-11-02 Thread via GitHub


elharo commented on code in PR #19:
URL: 
https://github.com/apache/maven-reporting-api/pull/19#discussion_r1380023006


##
src/main/java/org/apache/maven/reporting/MavenReport.java:
##
@@ -53,7 +53,9 @@ public interface MavenReport {
 void generate(Sink sink, Locale locale) throws MavenReportException;
 
 /**
- * Get the base name used to create report's output file(s).
+ * Get the output name denoting a base location relative to the {@link 
#getReportOutputDirectory()}
+ * used to create the report's main output file. The base location may 
contain path components

Review Comment:
   Specific actionable context is useful, but too much "business need" is just 
wasted words. Commons examples:
   
   * in order to improve performance
   * in order to improve customer service
   * in order to better serve you
   
   None of these actually explain anything. Here don't just say "to better 
structure the report output" but explain how the report output structure is 
changed, or say nothing at all. I don't know if this is accurate but something 
like "to divide the report documents into separate subdirectories" would be 
more concrete. "to better structure the report output" is not a user story and 
does not explain the business value. 
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[jira] [Assigned] (MRESOLVER-423) Remove the nonsense banner from Resolver site

2023-11-02 Thread Tamas Cservenak (Jira)


 [ 
https://issues.apache.org/jira/browse/MRESOLVER-423?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Tamas Cservenak reassigned MRESOLVER-423:
-

Assignee: Tamas Cservenak

> Remove the nonsense banner from Resolver site
> -
>
> Key: MRESOLVER-423
> URL: https://issues.apache.org/jira/browse/MRESOLVER-423
> Project: Maven Resolver
>  Issue Type: Task
>  Components: Resolver
>Reporter: Tamas Cservenak
>Assignee: Tamas Cservenak
>Priority: Major
> Fix For: 2.0.0
>
>
> The resolver index page starts with "Since version 1.7.0 Maven Resolver 
> requires Java 8 to run. For a Maven 3.8.x compatible version read here.". 
> Remove this, it really does not belong to Resolver 2.0.0.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (MRESOLVER-423) Remove the nonsense banner from Resolver site

2023-11-02 Thread ASF GitHub Bot (Jira)


[ 
https://issues.apache.org/jira/browse/MRESOLVER-423?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17782113#comment-17782113
 ] 

ASF GitHub Bot commented on MRESOLVER-423:
--

cstamas opened a new pull request, #354:
URL: https://github.com/apache/maven-resolver/pull/354

   Maven 3.8.x is to be left for history.
   
   ---
   
   https://issues.apache.org/jira/browse/MRESOLVER-423




> Remove the nonsense banner from Resolver site
> -
>
> Key: MRESOLVER-423
> URL: https://issues.apache.org/jira/browse/MRESOLVER-423
> Project: Maven Resolver
>  Issue Type: Task
>  Components: Resolver
>Reporter: Tamas Cservenak
>Priority: Major
> Fix For: 2.0.0
>
>
> The resolver index page starts with "Since version 1.7.0 Maven Resolver 
> requires Java 8 to run. For a Maven 3.8.x compatible version read here.". 
> Remove this, it really does not belong to Resolver 2.0.0.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Created] (MRESOLVER-423) Remove the nonsense banner from Resolver site

2023-11-02 Thread Tamas Cservenak (Jira)
Tamas Cservenak created MRESOLVER-423:
-

 Summary: Remove the nonsense banner from Resolver site
 Key: MRESOLVER-423
 URL: https://issues.apache.org/jira/browse/MRESOLVER-423
 Project: Maven Resolver
  Issue Type: Task
  Components: Resolver
Reporter: Tamas Cservenak
 Fix For: 2.0.0


The resolver index page starts with "Since version 1.7.0 Maven Resolver 
requires Java 8 to run. For a Maven 3.8.x compatible version read here.". 
Remove this, it really does not belong to Resolver 2.0.0.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Updated] (MRESOLVER-422) Fix javadoc report

2023-11-02 Thread Tamas Cservenak (Jira)


 [ 
https://issues.apache.org/jira/browse/MRESOLVER-422?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Tamas Cservenak updated MRESOLVER-422:
--
Component/s: Resolver

> Fix javadoc report
> --
>
> Key: MRESOLVER-422
> URL: https://issues.apache.org/jira/browse/MRESOLVER-422
> Project: Maven Resolver
>  Issue Type: Task
>  Components: Resolver
>Reporter: Tamas Cservenak
>Priority: Major
> Fix For: 2.0.0
>
>
> Currently to overcome the m-javadoc-p report issue, the URL was fixed to 
> Java11, see
> https://github.com/apache/maven-resolver/commit/baac2975488adf630c02141b882d1459d8c66fae
> Simplest fix would be to introduce new property/variable, as javaVersion 
> _changes from module to module_, while a new _buildJavaVersion_ would be same 
> for whole reactor (and is Java11).



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Created] (MRESOLVER-422) Fix javadoc report

2023-11-02 Thread Tamas Cservenak (Jira)
Tamas Cservenak created MRESOLVER-422:
-

 Summary: Fix javadoc report
 Key: MRESOLVER-422
 URL: https://issues.apache.org/jira/browse/MRESOLVER-422
 Project: Maven Resolver
  Issue Type: Task
Reporter: Tamas Cservenak
 Fix For: 2.0.0


Currently to overcome the m-javadoc-p report issue, the URL was fixed to 
Java11, see
https://github.com/apache/maven-resolver/commit/baac2975488adf630c02141b882d1459d8c66fae

Simplest fix would be to introduce new property/variable, as javaVersion 
_changes from module to module_, while a new _buildJavaVersion_ would be same 
for whole reactor (and is Java11).



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Created] (MASSEMBLY-1001) Excluding pom packaging projects in moduleSet

2023-11-02 Thread Jira
N铆no Mart铆nez Wael created MASSEMBLY-1001:
-

 Summary: Excluding pom packaging projects in moduleSet
 Key: MASSEMBLY-1001
 URL: https://issues.apache.org/jira/browse/MASSEMBLY-1001
 Project: Maven Assembly Plugin
  Issue Type: Bug
  Components: moduleSet
Affects Versions: 3.6.0
Reporter: N铆no Mart铆nez Wael


h3. This is a revisit to:

_https://issues.apache.org/jira/browse/MASSEMBLY-676_

_If a project have pom packaging it will be excluded by module-assembly-plugin, 
while iterating over projects in moduleSet. So, there is no way to use 
artifacts, attached to this project._

And revolves around this line:

https://github.com/apache/maven-assembly-plugin/blob/maven-assembly-plugin-3.6.0/src/main/java/org/apache/maven/plugins/assembly/functions/MavenProjects.java#L81
h3. Workaround in old bug report:

_use the artifacts as dependencies._

However I could not use this workaround as it takes the dependency from outside 
the current project reactor set.聽
h3. Example

I have a multimodule project where one module builds the assembly and another 
builds the maven site. Maven site artifact are attached as jar with classifier 
site.

Layout simplified

Parent

|-module-application聽

|-module-site (pom)

|-module-assembly
h4. content of module-assembly pom
{code:java}
聽 聽 聽 聽 
聽 聽 聽 聽 聽 聽 ...
聽 聽 聽 聽 聽 聽 module-site
聽 聽 聽 聽 聽 聽 jar
聽 聽 聽 聽 聽 聽 site
聽 聽 聽 聽 {code}
h4. content of assembly descriptor

聽
{code:java}
 聽 聽 聽 聽 
聽 聽 聽 聽 聽 聽 true
聽 聽 聽 聽 聽 聽 
聽 聽 聽 聽 聽 聽 聽 聽 ...:module-site
聽 聽 聽 聽 聽 聽 
聽 聽 聽 聽 聽 聽 
聽 聽 聽 聽 聽 聽 聽 聽 
聽 聽 聽 聽 聽 聽 聽 聽 聽 聽 ...:module-site:jar:site
聽 聽 聽 聽 聽 聽 聽 聽 
聽 聽 聽 聽 聽 聽 聽 聽 site
聽 聽 聽 聽 聽 聽 聽 聽 documentation
聽 聽 聽 聽 聽 聽 聽 聽 false
聽 聽 聽 聽 聽 聽 聽 聽 true
聽 聽 聽 聽 聽 聽 
聽 聽 聽 聽 {code}
聽

聽
h3. The current workaround I use are to get the moduleset included:

By this workaround you will run into

change module-site to the following:

聽
{code:java}
  聽 jar
  聽 
聽 聽 聽 聽 
聽 聽 聽 聽 聽 聽 
聽 聽 聽 聽 聽 聽 聽 聽 maven-jar-plugin
聽 聽 聽 聽 聽 聽 聽 聽 3.3.0
聽 聽 聽 聽 聽 聽 聽 聽 
聽 聽 聽 聽 聽 聽 聽 聽 聽 聽 
related to site plugin when switching to jar package and 
https://issues.apache.org/jira/browse/MJAR-253 聽 聽 聽 聽 聽 聽 聽 聽 聽 聽 聽 聽 
default-jar
聽 聽 聽 聽 聽 聽 聽 聽 聽 聽 聽 聽 none
聽 聽 聽 聽 聽 聽 聽 聽 聽 聽 聽 聽 
聽 聽 聽 聽 聽 聽 聽 聽 聽 聽 聽 聽 聽 聽 jar
聽 聽 聽 聽 聽 聽 聽 聽 聽 聽 聽 聽 
聽 聽 聽 聽 聽 聽 聽 聽 聽 聽 
聽 聽 聽 聽 聽 聽 聽 聽 
聽 聽 聽 聽 聽 聽 
聽 聽 聽 聽 聽 聽 
聽 聽 聽 聽 聽 聽 聽 聽 maven-deploy-plugin
聽 聽 聽 聽 聽 聽 聽 聽 3.1.1
聽 聽 聽 聽 聽 聽 聽 聽 
related to site plugin when using jar packaging 聽 聽 聽 聽 聽 聽 聽 聽 聽 聽 
true
聽 聽 聽 聽 聽 聽 聽 聽 
聽 聽 聽 聽 聽 聽 
聽 聽 聽 聽 聽 聽 
聽 聽 聽 聽 聽 聽 聽 聽 maven-install-plugin
聽 聽 聽 聽 聽 聽 聽 聽 3.1.1
聽 聽 聽 聽 聽 聽 聽 聽 
related to site plugin when using jar packaging 聽 聽 聽 聽 聽 聽 聽 聽 聽
true
聽 聽 聽 聽 聽 聽 聽 聽 
聽 聽 聽 聽 聽 聽  {code}
聽

聽

聽

Possible changes that will make it work:
 * make it possible to allow pom modules by a flag on the moduleset
 * Inspect pom module for requested attached binary and allow if any attached

聽



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (MJAR-297) Update Parent to 40

2023-11-02 Thread ASF GitHub Bot (Jira)


[ 
https://issues.apache.org/jira/browse/MJAR-297?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17782047#comment-17782047
 ] 

ASF GitHub Bot commented on MJAR-297:
-

slawekjaranowski merged PR #64:
URL: https://github.com/apache/maven-jar-plugin/pull/64




> Update Parent to 40
> ---
>
> Key: MJAR-297
> URL: https://issues.apache.org/jira/browse/MJAR-297
> Project: Maven JAR Plugin
>  Issue Type: Dependency upgrade
>Affects Versions: 3.3.0
>Reporter: Jorge Sol贸rzano
>Priority: Minor
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Assigned] (MJAR-297) Update Parent to 40

2023-11-02 Thread Slawomir Jaranowski (Jira)


 [ 
https://issues.apache.org/jira/browse/MJAR-297?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Slawomir Jaranowski reassigned MJAR-297:


Assignee: Slawomir Jaranowski

> Update Parent to 40
> ---
>
> Key: MJAR-297
> URL: https://issues.apache.org/jira/browse/MJAR-297
> Project: Maven JAR Plugin
>  Issue Type: Dependency upgrade
>Affects Versions: 3.3.0
>Reporter: Jorge Sol贸rzano
>Assignee: Slawomir Jaranowski
>Priority: Minor
> Fix For: 3.4.0
>
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Closed] (MJAR-297) Update Parent to 40

2023-11-02 Thread Slawomir Jaranowski (Jira)


 [ 
https://issues.apache.org/jira/browse/MJAR-297?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Slawomir Jaranowski closed MJAR-297.

Fix Version/s: 3.4.0
   Resolution: Fixed

> Update Parent to 40
> ---
>
> Key: MJAR-297
> URL: https://issues.apache.org/jira/browse/MJAR-297
> Project: Maven JAR Plugin
>  Issue Type: Dependency upgrade
>Affects Versions: 3.3.0
>Reporter: Jorge Sol贸rzano
>Priority: Minor
> Fix For: 3.4.0
>
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)


Re: [PR] [MJAR-297] Update Parent to 40 [maven-jar-plugin]

2023-11-02 Thread via GitHub


slawekjaranowski merged PR #64:
URL: https://github.com/apache/maven-jar-plugin/pull/64


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[jira] [Closed] (MJAR-298) Update Maven-Archiver to 3.6.1

2023-11-02 Thread Slawomir Jaranowski (Jira)


 [ 
https://issues.apache.org/jira/browse/MJAR-298?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Slawomir Jaranowski closed MJAR-298.

Fix Version/s: 3.4.0
 Assignee: Slawomir Jaranowski
   Resolution: Fixed

> Update Maven-Archiver to 3.6.1
> --
>
> Key: MJAR-298
> URL: https://issues.apache.org/jira/browse/MJAR-298
> Project: Maven JAR Plugin
>  Issue Type: Dependency upgrade
>Affects Versions: 3.3.0
>Reporter: Jorge Sol贸rzano
>Assignee: Slawomir Jaranowski
>Priority: Major
> Fix For: 3.4.0
>
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (MJAR-298) Update Maven-Archiver to 3.6.1

2023-11-02 Thread ASF GitHub Bot (Jira)


[ 
https://issues.apache.org/jira/browse/MJAR-298?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17782043#comment-17782043
 ] 

ASF GitHub Bot commented on MJAR-298:
-

slawekjaranowski merged PR #65:
URL: https://github.com/apache/maven-jar-plugin/pull/65




> Update Maven-Archiver to 3.6.1
> --
>
> Key: MJAR-298
> URL: https://issues.apache.org/jira/browse/MJAR-298
> Project: Maven JAR Plugin
>  Issue Type: Dependency upgrade
>Affects Versions: 3.3.0
>Reporter: Jorge Sol贸rzano
>Priority: Major
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)


Re: [PR] [MJAR-298] Update Maven-Archiver to 3.6.1 [maven-jar-plugin]

2023-11-02 Thread via GitHub


slawekjaranowski merged PR #65:
URL: https://github.com/apache/maven-jar-plugin/pull/65


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[jira] [Closed] (SUREFIRE-2208) Bump org.codehaus.plexus:plexus-java from 1.1.2 to 1.2.0

2023-11-02 Thread Slawomir Jaranowski (Jira)


 [ 
https://issues.apache.org/jira/browse/SUREFIRE-2208?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Slawomir Jaranowski closed SUREFIRE-2208.
-
Resolution: Fixed

> Bump org.codehaus.plexus:plexus-java from 1.1.2 to 1.2.0
> 
>
> Key: SUREFIRE-2208
> URL: https://issues.apache.org/jira/browse/SUREFIRE-2208
> Project: Maven Surefire
>  Issue Type: Dependency upgrade
>Reporter: Slawomir Jaranowski
>Assignee: Slawomir Jaranowski
>Priority: Major
> Fix For: version-next
>
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (MSHARED-1326) Improve (documentation on) MavenReport interface/AbstractMavenReport class

2023-11-02 Thread ASF GitHub Bot (Jira)


[ 
https://issues.apache.org/jira/browse/MSHARED-1326?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17782028#comment-17782028
 ] 

ASF GitHub Bot commented on MSHARED-1326:
-

michael-o commented on code in PR #19:
URL: 
https://github.com/apache/maven-reporting-api/pull/19#discussion_r1379691836


##
src/main/java/org/apache/maven/reporting/MavenReport.java:
##
@@ -53,7 +53,9 @@ public interface MavenReport {
 void generate(Sink sink, Locale locale) throws MavenReportException;
 
 /**
- * Get the base name used to create report's output file(s).
+ * Get the output name denoting a base location relative to the {@link 
#getReportOutputDirectory()}

Review Comment:
   @elharo, it is both. A path to a file. I need to rename the API to satisfy 
this. I could do with a default interface method. The current name is just bad. 
I am happy to accept any reformulation of the docs which make it better. Should 
I raise a PR to rename the method and deprecate it? FWIW, it is not necessarily 
a file name because it is free of a format. The plugin impl does not decide 
about the format. It is a symbolic name in a virtual FS, so to speak.





> Improve (documentation on) MavenReport interface/AbstractMavenReport class
> --
>
> Key: MSHARED-1326
> URL: https://issues.apache.org/jira/browse/MSHARED-1326
> Project: Maven Shared Components
>  Issue Type: Task
>  Components: maven-reporting-api
>Affects Versions: maven-reporting-impl-4.0.0-M11, 
> maven-reporting-api-4.0.0-M8
>Reporter: Michael Osipov
>Assignee: Michael Osipov
>Priority: Major
> Fix For: maven-reporting-api-4.0.0-M9, 
> maven-reporting-impl-4.0.0-M12
>
>
> Based on a 
> [discussion|https://lists.apache.org/thread/6yxlvbhb7odfylfgjgzbvmvxg0vry20b] 
> with [~kriegaex], there are few conceptional or documentational issues with 
> the {{MavenReport}} interface:
> * {{#getOutputName()}} does not clearly say that is actually an optional base 
> *path* and base name (base location) of the report item from a reporting 
> output directory. It needs at least a doc update and maybe even a rename to 
> {{#getOutputPath()}}/{{#getOutputPathLocation()}}?
> * Both {{#setReportOutputDirectory(File outputDirectory)}} and 
> {{#getReportOutputDirectory()}} documentation imply tha this directory solely 
> refers to this single report, but that is not correct. It refers to root 
> directory which contains all possibly generated reports. A shared directory, 
> not exclusive one. Consider your report generates in a subdir, then these do 
> *not* refer to it, but to its parent.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


Re: [PR] [MSHARED-1326] Improve (documentation on) MavenReport interface [maven-reporting-api]

2023-11-02 Thread via GitHub


michael-o commented on code in PR #19:
URL: 
https://github.com/apache/maven-reporting-api/pull/19#discussion_r1379691836


##
src/main/java/org/apache/maven/reporting/MavenReport.java:
##
@@ -53,7 +53,9 @@ public interface MavenReport {
 void generate(Sink sink, Locale locale) throws MavenReportException;
 
 /**
- * Get the base name used to create report's output file(s).
+ * Get the output name denoting a base location relative to the {@link 
#getReportOutputDirectory()}

Review Comment:
   @elharo, it is both. A path to a file. I need to rename the API to satisfy 
this. I could do with a default interface method. The current name is just bad. 
I am happy to accept any reformulation of the docs which make it better. Should 
I raise a PR to rename the method and deprecate it?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] [MSHARED-1326] Improve (documentation on) MavenReport interface [maven-reporting-api]

2023-11-02 Thread via GitHub


michael-o commented on code in PR #19:
URL: 
https://github.com/apache/maven-reporting-api/pull/19#discussion_r1379691836


##
src/main/java/org/apache/maven/reporting/MavenReport.java:
##
@@ -53,7 +53,9 @@ public interface MavenReport {
 void generate(Sink sink, Locale locale) throws MavenReportException;
 
 /**
- * Get the base name used to create report's output file(s).
+ * Get the output name denoting a base location relative to the {@link 
#getReportOutputDirectory()}

Review Comment:
   @elharo, it is both. A path to a file. I need to rename the API to satisfy 
this. I could do with a default interface method. The current name is just bad. 
I am happy to accept any reformulation of the docs which make it better. Should 
I raise a PR to rename the method and deprecate it? FWIW, it is not necessarily 
a file name because it is free of a format. The plugin impl does not decide 
about the format. It is a symbolic name in a virtual FS, so to speak.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[jira] [Commented] (MSHARED-1326) Improve (documentation on) MavenReport interface/AbstractMavenReport class

2023-11-02 Thread ASF GitHub Bot (Jira)


[ 
https://issues.apache.org/jira/browse/MSHARED-1326?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17782026#comment-17782026
 ] 

ASF GitHub Bot commented on MSHARED-1326:
-

michael-o commented on code in PR #19:
URL: 
https://github.com/apache/maven-reporting-api/pull/19#discussion_r1379691836


##
src/main/java/org/apache/maven/reporting/MavenReport.java:
##
@@ -53,7 +53,9 @@ public interface MavenReport {
 void generate(Sink sink, Locale locale) throws MavenReportException;
 
 /**
- * Get the base name used to create report's output file(s).
+ * Get the output name denoting a base location relative to the {@link 
#getReportOutputDirectory()}

Review Comment:
   @elharo, it is both. A path to a file. I need to rename the API to satisfy 
this. I could do with a default interface method. The current name is just bad. 
I am happy to accept any reformulation of the docs which make it better. Should 
I raise a PR to rename the method and deprecate it?





> Improve (documentation on) MavenReport interface/AbstractMavenReport class
> --
>
> Key: MSHARED-1326
> URL: https://issues.apache.org/jira/browse/MSHARED-1326
> Project: Maven Shared Components
>  Issue Type: Task
>  Components: maven-reporting-api
>Affects Versions: maven-reporting-impl-4.0.0-M11, 
> maven-reporting-api-4.0.0-M8
>Reporter: Michael Osipov
>Assignee: Michael Osipov
>Priority: Major
> Fix For: maven-reporting-api-4.0.0-M9, 
> maven-reporting-impl-4.0.0-M12
>
>
> Based on a 
> [discussion|https://lists.apache.org/thread/6yxlvbhb7odfylfgjgzbvmvxg0vry20b] 
> with [~kriegaex], there are few conceptional or documentational issues with 
> the {{MavenReport}} interface:
> * {{#getOutputName()}} does not clearly say that is actually an optional base 
> *path* and base name (base location) of the report item from a reporting 
> output directory. It needs at least a doc update and maybe even a rename to 
> {{#getOutputPath()}}/{{#getOutputPathLocation()}}?
> * Both {{#setReportOutputDirectory(File outputDirectory)}} and 
> {{#getReportOutputDirectory()}} documentation imply tha this directory solely 
> refers to this single report, but that is not correct. It refers to root 
> directory which contains all possibly generated reports. A shared directory, 
> not exclusive one. Consider your report generates in a subdir, then these do 
> *not* refer to it, but to its parent.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Created] (MNG-7921) Allow plugins to control classpath extensions

2023-11-02 Thread Dave Syer (Jira)
Dave Syer created MNG-7921:
--

 Summary: Allow plugins to control classpath extensions
 Key: MNG-7921
 URL: https://issues.apache.org/jira/browse/MNG-7921
 Project: Maven
  Issue Type: Improvement
  Components: Class Loading, Core
Affects Versions: 3.9.5
Reporter: Dave Syer


It's great that a plugin (or extension jar) can have `` 
(specifically I want to use Google Guice in a plugin and this seems to be the 
only way), but it can only be applied globally AFAIK, so all plugins get the 
same exported packages and there might consequently be conflicts. It would be 
nice if a plugin that declared it was an extension could elect to specify 
exported packages independent of other plugins.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)