[PR] Bump org.testcontainers:testcontainers-bom from 1.19.1 to 1.19.2 [maven-build-cache-extension]

2023-11-14 Thread via GitHub


dependabot[bot] opened a new pull request, #108:
URL: https://github.com/apache/maven-build-cache-extension/pull/108

   Bumps 
[org.testcontainers:testcontainers-bom](https://github.com/testcontainers/testcontainers-java)
 from 1.19.1 to 1.19.2.
   
   Release notes
   Sourced from https://github.com/testcontainers/testcontainers-java/releases";>org.testcontainers:testcontainers-bom's
 releases.
   
   1.19.2
   Testcontainers for Java 1.19.2
   Core
   
   Add shutdownHook to send sigterm to ryuk (https://redirect.github.com/testcontainers/testcontainers-java/issues/7717";>#7717)
 https://github.com/eddumelendez";>@​eddumelendez
   Deprecate file/volume mapping APIs (https://redirect.github.com/testcontainers/testcontainers-java/issues/7652";>#7652)
 https://github.com/eddumelendez";>@​eddumelendez
   Container definition API (https://redirect.github.com/testcontainers/testcontainers-java/issues/7714";>#7714)
 https://github.com/eddumelendez";>@​eddumelendez
   Enable HTTP and HTTPS on native for HttpWaitStrategy (https://redirect.github.com/testcontainers/testcontainers-java/issues/7790";>#7790)
 https://github.com/eddumelendez";>@​eddumelendez
   Resolve strategy to detect the remote docker socket (https://redirect.github.com/testcontainers/testcontainers-java/issues/7727";>#7727)
 https://github.com/eddumelendez";>@​eddumelendez
   
   Modules
   
   New Oracle Free module (https://redirect.github.com/testcontainers/testcontainers-java/pull/7749";>testcontainers/testcontainers-java#7749)
 https://github.com/gvenzl";>@​gvenzl
   
   Elasticserach
   
   Support Elastisearch image from DockerHub (https://redirect.github.com/testcontainers/testcontainers-java/issues/";>#)
 https://github.com/eddumelendez";>@​eddumelendez
   
   JDBC
   
   Fix SQL parser (https://redirect.github.com/testcontainers/testcontainers-java/issues/7646";>#7646)
 https://github.com/inponomarev";>@​inponomarev
   
   K3S
   
   Fix K3S start command (https://redirect.github.com/testcontainers/testcontainers-java/issues/7677";>#7677)
 https://github.com/tgeens";>@​tgeens
   
   Kafka
   
   Create KafkaContainerDef (https://redirect.github.com/testcontainers/testcontainers-java/issues/7748";>#7748)
 https://github.com/eddumelendez";>@​eddumelendez
   Add examples enabling SASL with JAAS (https://redirect.github.com/testcontainers/testcontainers-java/issues/7763";>#7763)
 https://github.com/eddumelendez";>@​eddumelendez
   
   LocalStack
   
   Fix default credentials (https://redirect.github.com/testcontainers/testcontainers-java/issues/7718";>#7718)
 https://github.com/fokion";>@​fokion
   
   YugabyteDB
   
   Improve SQL wait strategy (https://redirect.github.com/testcontainers/testcontainers-java/issues/7784";>#7784)
 https://github.com/HarshDaryani896";>@​HarshDaryani896
   
   What's Changed
   📖 Documentation
   
   Introducing Oracle Free module (https://redirect.github.com/testcontainers/testcontainers-java/issues/7749";>#7749)
 https://github.com/gvenzl";>@​gvenzl
   Update PR template with more specific wording (https://redirect.github.com/testcontainers/testcontainers-java/issues/7751";>#7751)
 https://github.com/gvenzl";>@​gvenzl
   Fix small typo in new Podman docs (https://redirect.github.com/testcontainers/testcontainers-java/issues/7722";>#7722)
 https://github.com/TheHaf";>@​TheHaf
   Deprecate file/volume mapping APIs (https://redirect.github.com/testcontainers/testcontainers-java/issues/7652";>#7652)
 https://github.com/eddumelendez";>@​eddumelendez
   Fix link to Toxiproxy docs from Kafka docs (https://redirect.github.com/testcontainers/testcontainers-java/issues/7684";>#7684)
 https://github.com/alex-sherwin";>@​alex-sherwin
   Fix documentation for BigQuery in gcloud module (https://redirect.github.com/testcontainers/testcontainers-java/issues/7681";>#7681)
 https://github.com/zanmagerl";>@​zanmagerl
   Update Docker requirements page to be more container runtime agnostic 
(https://redirect.github.com/testcontainers/testcontainers-java/issues/7655";>#7655)
 https://github.com/kiview";>@​kiview
   
   📦 Dependency updates
   
   
   Combined dependencies PR (https://redirect.github.com/testcontainers/testcontainers-java/issues/7810";>#7810)
 https://github.com/eddumelendez";>@​eddumelendez
   Combined dependencies PR (https://redirect.github.com/testcontainers/testcontainers-java/issues/7809";>#7809)
 https://github.com/eddumelendez";>@​eddumelendez
   Combined dependencies PR (https://redirect.github.com/testcontainers/testcontainers-java/issues/7807";>#7807)
 https://github.com/eddumelendez";>@​eddumelendez
   Update docker-java version to 3.3.4 (https://redirect.github.com/testcontainers/testcontainers-java/issues/7730";>#7730)
 https://github.com/eddumelendez";>@​eddumelendez
   Update kubernetes client version to 19.0.0 (https://redirect.github.com/testcontainers/testcontainers-java/issues/7716";>#7716)
 https://github.com/eddumelendez";>@​eddumelendez
   Combined dependencies PR (https://redir

[jira] [Updated] (MSITE-990) org.eclipse.jetty.util.MultiException: Multiple exceptions

2023-11-14 Thread mikael petterson (Jira)


 [ 
https://issues.apache.org/jira/browse/MSITE-990?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

mikael petterson updated MSITE-990:
---
Attachment: multi_exceptions.log

> org.eclipse.jetty.util.MultiException: Multiple exceptions
> --
>
> Key: MSITE-990
> URL: https://issues.apache.org/jira/browse/MSITE-990
> Project: Maven Site Plugin
>  Issue Type: Bug
>  Components: site:run
>Affects Versions: 3.12.1
> Environment: Windows 10 and git bash
>Reporter: mikael petterson
>Priority: Major
> Fix For: waiting-for-feedback
>
> Attachments: multi_exceptions.log
>
>
>  mvn --version
> Apache Maven 3.8.5 (3599d3414f046de2324203b78ddcf9b5e4388aa0)
> Maven home: C:\apache-maven-3.8.5
> Java version: 17.0.6, vendor: Azul Systems, Inc., runtime: C:\Program 
> Files\Zulu\zulu-17
> Default locale: en_US, platform encoding: Cp1252
> OS name: "windows 10", version: "10.0", arch: "amd64", family: "windows"
>  
> When trying to run:
> mvn site:run
> {code:java}
> [INFO] jetty-9.4.46.v20220331; built: 2022-03-31T16:38:08.030Z; git: 
> bc17a0369a11ecf40bb92c839b9ef0a8ac50ea18; jvm 17.0.6+10-LTS
> [INFO] NO JSP Support for /, did not find 
> org.eclipse.jetty.jsp.JettyJspServlet
> [INFO] DefaultSessionIdManager workerName=node0
> [INFO] No SessionScavenger set, using defaults
> [INFO] node0 Scavenging every 66ms
> [WARNING] Failed startup of context 
> o.e.j.w.WebAppContext@64d42d3d{/,file:///C:/Users/userid/git/my-app/target/site-webapp/,UNAVAILABLE}
> org.eclipse.jetty.util.MultiException: Multiple exceptions
>     at org.eclipse.jetty.util.MultiException.ifExceptionThrow 
> (MultiException.java:122)
>     at org.eclipse.jetty.servlet.ServletHandler.initialize 
> (ServletHandler.java:757)
>     at org.eclipse.jetty.servlet.ServletContextHandler.startContext 
> (ServletContextHandler.java:379)
>     at org.eclipse.jetty.webapp.WebAppContext.startWebapp 
> (WebAppContext.java:1449)
>     at org.eclipse.jetty.webapp.WebAppContext.startContext 
> (WebAppContext.java:1414)
>     at org.eclipse.jetty.server.handler.ContextHandler.doStart 
> (ContextHandler.java:916)
>     at org.eclipse.jetty.servlet.ServletContextHandler.doStart 
> (ServletContextHandler.java:288)
>     at org.eclipse.jetty.webapp.WebAppContext.doStart (WebAppContext.java:524)
>     at org.eclipse.jetty.util.component.AbstractLifeCycle.start 
> (AbstractLifeCycle.java:73)
>     at org.eclipse.jetty.util.component.ContainerLifeCycle.start 
> (ContainerLifeCycle.java:169)
>     at org.eclipse.jetty.server.Server.start (Server.java:423)
>     at org.eclipse.jetty.util.component.ContainerLifeCycle.doStart 
> (ContainerLifeCycle.java:110)
>     at org.eclipse.jetty.server.handler.AbstractHandler.doStart 
> (AbstractHandler.java:97)
>     at org.eclipse.jetty.server.Server.doStart (Server.java:387)
>     at org.eclipse.jetty.util.component.AbstractLifeCycle.start 
> (AbstractLifeCycle.java:73)
>     at org.apache.maven.plugins.site.run.SiteRunMojo.execute 
> (SiteRunMojo.java:87)
>     at org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo 
> (DefaultBuildPluginManager.java:137)
>     at org.apache.maven.lifecycle.internal.MojoExecutor.doExecute 
> (MojoExecutor.java:301)
>     at org.apache.maven.lifecycle.internal.MojoExecutor.execute 
> (MojoExecutor.java:211)
>     at org.apache.maven.lifecycle.internal.MojoExecutor.execute 
> (MojoExecutor.java:165)
>     at org.apache.maven.lifecycle.internal.MojoExecutor.execute 
> (MojoExecutor.java:157)
>     at 
> org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject 
> (LifecycleModuleBuilder.java:121)
>     at 
> org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject 
> (LifecycleModuleBuilder.java:81)
>     at 
> org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.build
>  (SingleThreadedBuilder.java:56)
>     at org.apache.maven.lifecycle.internal.LifecycleStarter.execute 
> (LifecycleStarter.java:127)
>     at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:294)
>     at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:192)
>     at org.apache.maven.DefaultMaven.execute (DefaultMaven.java:105)
>     at org.apache.maven.cli.MavenCli.execute (MavenCli.java:960)
>     at org.apache.maven.cli.MavenCli.doMain (MavenCli.java:293)
>     at org.apache.maven.cli.MavenCli.main (MavenCli.java:196)
>     at jdk.internal.reflect.NativeMethodAccessorImpl.invoke0 (Native Method)
>     at jdk.internal.reflect.NativeMethodAccessorImpl.invoke 
> (NativeMethodAccessorImpl.java:77)
>     at jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke 
> (DelegatingMethodAccessorImpl.java:43)
>     at java.lang.reflect.Method.invoke (Method.java:568)
>     at org.codehaus.plexus.classworlds.launcher.Launcher.laun

[jira] [Commented] (MSITE-990) org.eclipse.jetty.util.MultiException: Multiple exceptions

2023-11-14 Thread mikael petterson (Jira)


[ 
https://issues.apache.org/jira/browse/MSITE-990?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17786188#comment-17786188
 ] 

mikael petterson commented on MSITE-990:


[~michael-o] uploaded log.

> org.eclipse.jetty.util.MultiException: Multiple exceptions
> --
>
> Key: MSITE-990
> URL: https://issues.apache.org/jira/browse/MSITE-990
> Project: Maven Site Plugin
>  Issue Type: Bug
>  Components: site:run
>Affects Versions: 3.12.1
> Environment: Windows 10 and git bash
>Reporter: mikael petterson
>Priority: Major
> Fix For: waiting-for-feedback
>
> Attachments: multi_exceptions.log
>
>
>  mvn --version
> Apache Maven 3.8.5 (3599d3414f046de2324203b78ddcf9b5e4388aa0)
> Maven home: C:\apache-maven-3.8.5
> Java version: 17.0.6, vendor: Azul Systems, Inc., runtime: C:\Program 
> Files\Zulu\zulu-17
> Default locale: en_US, platform encoding: Cp1252
> OS name: "windows 10", version: "10.0", arch: "amd64", family: "windows"
>  
> When trying to run:
> mvn site:run
> {code:java}
> [INFO] jetty-9.4.46.v20220331; built: 2022-03-31T16:38:08.030Z; git: 
> bc17a0369a11ecf40bb92c839b9ef0a8ac50ea18; jvm 17.0.6+10-LTS
> [INFO] NO JSP Support for /, did not find 
> org.eclipse.jetty.jsp.JettyJspServlet
> [INFO] DefaultSessionIdManager workerName=node0
> [INFO] No SessionScavenger set, using defaults
> [INFO] node0 Scavenging every 66ms
> [WARNING] Failed startup of context 
> o.e.j.w.WebAppContext@64d42d3d{/,file:///C:/Users/userid/git/my-app/target/site-webapp/,UNAVAILABLE}
> org.eclipse.jetty.util.MultiException: Multiple exceptions
>     at org.eclipse.jetty.util.MultiException.ifExceptionThrow 
> (MultiException.java:122)
>     at org.eclipse.jetty.servlet.ServletHandler.initialize 
> (ServletHandler.java:757)
>     at org.eclipse.jetty.servlet.ServletContextHandler.startContext 
> (ServletContextHandler.java:379)
>     at org.eclipse.jetty.webapp.WebAppContext.startWebapp 
> (WebAppContext.java:1449)
>     at org.eclipse.jetty.webapp.WebAppContext.startContext 
> (WebAppContext.java:1414)
>     at org.eclipse.jetty.server.handler.ContextHandler.doStart 
> (ContextHandler.java:916)
>     at org.eclipse.jetty.servlet.ServletContextHandler.doStart 
> (ServletContextHandler.java:288)
>     at org.eclipse.jetty.webapp.WebAppContext.doStart (WebAppContext.java:524)
>     at org.eclipse.jetty.util.component.AbstractLifeCycle.start 
> (AbstractLifeCycle.java:73)
>     at org.eclipse.jetty.util.component.ContainerLifeCycle.start 
> (ContainerLifeCycle.java:169)
>     at org.eclipse.jetty.server.Server.start (Server.java:423)
>     at org.eclipse.jetty.util.component.ContainerLifeCycle.doStart 
> (ContainerLifeCycle.java:110)
>     at org.eclipse.jetty.server.handler.AbstractHandler.doStart 
> (AbstractHandler.java:97)
>     at org.eclipse.jetty.server.Server.doStart (Server.java:387)
>     at org.eclipse.jetty.util.component.AbstractLifeCycle.start 
> (AbstractLifeCycle.java:73)
>     at org.apache.maven.plugins.site.run.SiteRunMojo.execute 
> (SiteRunMojo.java:87)
>     at org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo 
> (DefaultBuildPluginManager.java:137)
>     at org.apache.maven.lifecycle.internal.MojoExecutor.doExecute 
> (MojoExecutor.java:301)
>     at org.apache.maven.lifecycle.internal.MojoExecutor.execute 
> (MojoExecutor.java:211)
>     at org.apache.maven.lifecycle.internal.MojoExecutor.execute 
> (MojoExecutor.java:165)
>     at org.apache.maven.lifecycle.internal.MojoExecutor.execute 
> (MojoExecutor.java:157)
>     at 
> org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject 
> (LifecycleModuleBuilder.java:121)
>     at 
> org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject 
> (LifecycleModuleBuilder.java:81)
>     at 
> org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.build
>  (SingleThreadedBuilder.java:56)
>     at org.apache.maven.lifecycle.internal.LifecycleStarter.execute 
> (LifecycleStarter.java:127)
>     at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:294)
>     at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:192)
>     at org.apache.maven.DefaultMaven.execute (DefaultMaven.java:105)
>     at org.apache.maven.cli.MavenCli.execute (MavenCli.java:960)
>     at org.apache.maven.cli.MavenCli.doMain (MavenCli.java:293)
>     at org.apache.maven.cli.MavenCli.main (MavenCli.java:196)
>     at jdk.internal.reflect.NativeMethodAccessorImpl.invoke0 (Native Method)
>     at jdk.internal.reflect.NativeMethodAccessorImpl.invoke 
> (NativeMethodAccessorImpl.java:77)
>     at jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke 
> (DelegatingMethodAccessorImpl.java:43)
>     at java.lang.reflect.Method.invoke (Method.java:568)
>     at org.co

[jira] [Commented] (MNG-7920) Usage of packaging BOM fails in maven-install-plugin

2023-11-14 Thread ASF GitHub Bot (Jira)


[ 
https://issues.apache.org/jira/browse/MNG-7920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17786167#comment-17786167
 ] 

ASF GitHub Bot commented on MNG-7920:
-

CrazyHZM opened a new pull request, #1305:
URL: https://github.com/apache/maven/pull/1305

   Following this checklist to help us incorporate your
   contribution quickly and easily:
   
- [ ] Make sure there is a [JIRA 
issue](https://issues.apache.org/jira/browse/MNG) filed
  for the change (usually before you start working on it).  Trivial 
changes like typos do not
  require a JIRA issue. Your pull request should address just this 
issue, without
  pulling in other changes.
- [ ] Each commit in the pull request should have a meaningful subject line 
and body.
- [ ] Format the pull request title like `[MNG-XXX] SUMMARY`,
  where you replace `MNG-XXX` and `SUMMARY` with the appropriate JIRA 
issue.
- [ ] Also format the first line of the commit message like `[MNG-XXX] 
SUMMARY`.
  Best practice is to use the JIRA issue title in both the pull request 
title and in the first line of the commit message.
- [ ] Write a pull request description that is detailed enough to 
understand what the pull request does, how, and why.
- [ ] Run `mvn clean verify` to make sure basic checks pass. A more 
thorough check will
  be performed on your pull request automatically.
- [ ] You have run the [Core IT][core-its] successfully.
   
   If your pull request is about ~20 lines of code you don't need to sign an
   [Individual Contributor License 
Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure
   please ask on the developers list.
   
   To make clear that you license your contribution under
   the [Apache License Version 2.0, January 
2004](http://www.apache.org/licenses/LICENSE-2.0)
   you have to acknowledge this by using the following check-box.
   
- [ ] I hereby declare this contribution to be licenced under the [Apache 
License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
   
- [ ] In any other case, please file an [Apache Individual Contributor 
License Agreement](https://www.apache.org/licenses/icla.pdf).
   
   [core-its]: https://maven.apache.org/core-its/core-it-suite/
   




> Usage of packaging BOM fails in maven-install-plugin
> 
>
> Key: MNG-7920
> URL: https://issues.apache.org/jira/browse/MNG-7920
> Project: Maven
>  Issue Type: Bug
>  Components: Deployment
>Affects Versions: 4.0.0-alpha-8
>Reporter: Karl Heinz Marbaise
>Priority: Critical
> Fix For: 4.0.0, 4.0.0-alpha-9
>
>
> Using to use the `bom` packaging in a module it will fail with:
> {code}
> [INFO] 
> --
> [ERROR] Failed to execute goal 
> org.apache.maven.plugins:maven-install-plugin:3.1.1:install (default-install) 
> on project bom: The packaging plugin for this project did not assign a main 
> file to the project but it has attachments. Change packaging to 'pom'. -> 
> [Help 1]
> {code}
> The bom module looks like this:
> {code:xml}
>xmlns="http://maven.apache.org/POM/4.1.0";
>   xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance";
>   xsi:schemaLocation="http://maven.apache.org/POM/4.1.0 
> http://maven.apache.org/maven-v4_1_0.xsd";>
>   4.1.0
>   
> maven4
> bom-example
>   
>   bom
>   bom
>   
> 
>   
>   ...maven4
>   mod-1
>   
>   
>   maven4
>   mod-2
>   
> 
>   
> 
> {code}
> I would assume that I need to upgrade the maven-install-plugin which is 
> capable of handling that...but I assumed that this conversion is done by core?



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[PR] [MNG-7920]Fix usage of packaging BOM fails in maven-install-plugin [maven]

2023-11-14 Thread via GitHub


CrazyHZM opened a new pull request, #1305:
URL: https://github.com/apache/maven/pull/1305

   Following this checklist to help us incorporate your
   contribution quickly and easily:
   
- [ ] Make sure there is a [JIRA 
issue](https://issues.apache.org/jira/browse/MNG) filed
  for the change (usually before you start working on it).  Trivial 
changes like typos do not
  require a JIRA issue. Your pull request should address just this 
issue, without
  pulling in other changes.
- [ ] Each commit in the pull request should have a meaningful subject line 
and body.
- [ ] Format the pull request title like `[MNG-XXX] SUMMARY`,
  where you replace `MNG-XXX` and `SUMMARY` with the appropriate JIRA 
issue.
- [ ] Also format the first line of the commit message like `[MNG-XXX] 
SUMMARY`.
  Best practice is to use the JIRA issue title in both the pull request 
title and in the first line of the commit message.
- [ ] Write a pull request description that is detailed enough to 
understand what the pull request does, how, and why.
- [ ] Run `mvn clean verify` to make sure basic checks pass. A more 
thorough check will
  be performed on your pull request automatically.
- [ ] You have run the [Core IT][core-its] successfully.
   
   If your pull request is about ~20 lines of code you don't need to sign an
   [Individual Contributor License 
Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure
   please ask on the developers list.
   
   To make clear that you license your contribution under
   the [Apache License Version 2.0, January 
2004](http://www.apache.org/licenses/LICENSE-2.0)
   you have to acknowledge this by using the following check-box.
   
- [ ] I hereby declare this contribution to be licenced under the [Apache 
License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
   
- [ ] In any other case, please file an [Apache Individual Contributor 
License Agreement](https://www.apache.org/licenses/icla.pdf).
   
   [core-its]: https://maven.apache.org/core-its/core-it-suite/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[jira] [Closed] (MPOM-447) activate javac's release flag when building with JDK supporting that feature

2023-11-14 Thread Herve Boutemy (Jira)


 [ 
https://issues.apache.org/jira/browse/MPOM-447?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Herve Boutemy closed MPOM-447.
--
Resolution: Fixed

> activate javac's release flag when building with JDK supporting that feature
> 
>
> Key: MPOM-447
> URL: https://issues.apache.org/jira/browse/MPOM-447
> Project: Maven POMs
>  Issue Type: Improvement
>  Components: maven
>Affects Versions: MAVEN-41
>Reporter: Herve Boutemy
>Assignee: Herve Boutemy
>Priority: Major
> Fix For: MAVEN-42
>
>
> easy to do, prepares smooth transitioning
> and absolutely needeed when building with JDK 11+ as without this flag, it 
> may inject JDK APIs calls that are not supported by target platform



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


Re: [PR] [MPOM-447] activate javac's release flag [maven-parent]

2023-11-14 Thread via GitHub


hboutemy merged PR #150:
URL: https://github.com/apache/maven-parent/pull/150


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[jira] [Commented] (MJAVADOC-780) Unit tests create null-null.jar in build root directory

2023-11-14 Thread Herve Boutemy (Jira)


[ 
https://issues.apache.org/jira/browse/MJAVADOC-780?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17786105#comment-17786105
 ] 

Herve Boutemy commented on MJAVADOC-780:


thanks: PR provided

> Unit tests create null-null.jar in build root directory
> ---
>
> Key: MJAVADOC-780
> URL: https://issues.apache.org/jira/browse/MJAVADOC-780
> Project: Maven Javadoc Plugin
>  Issue Type: Bug
>Affects Versions: 3.6.2
>Reporter: Herve Boutemy
>Priority: Major
> Fix For: 3.6.3
>
>
> {noformat}[INFO] Running org.apache.maven.plugins.javadoc.JavadocJarTest
> [main] INFO org.codehaus.plexus.archiver.jar.JarArchiver - Building jar: 
> /tmp/sources/plugins/reporting/maven-javadoc-plugin/target/test/unit/javadocjar-default/target/javadocjar-default-javadoc.jar
> [main] INFO org.codehaus.plexus.archiver.jar.JarArchiver - Building jar: 
> /tmp/sources/plugins/reporting/maven-javadoc-plugin/null-null.jar
> [main] INFO org.codehaus.plexus.archiver.jar.JarArchiver - Building jar: 
> /tmp/sources/plugins/reporting/maven-javadoc-plugin/null-null.jar
> {noformat}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (MJAVADOC-780) Unit tests create null-null.jar in build root directory

2023-11-14 Thread ASF GitHub Bot (Jira)


[ 
https://issues.apache.org/jira/browse/MJAVADOC-780?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17786104#comment-17786104
 ] 

ASF GitHub Bot commented on MJAVADOC-780:
-

hboutemy opened a new pull request, #249:
URL: https://github.com/apache/maven-javadoc-plugin/pull/249

   https://issues.apache.org/jira/browse/MJAVADOC-780




> Unit tests create null-null.jar in build root directory
> ---
>
> Key: MJAVADOC-780
> URL: https://issues.apache.org/jira/browse/MJAVADOC-780
> Project: Maven Javadoc Plugin
>  Issue Type: Bug
>Affects Versions: 3.6.2
>Reporter: Herve Boutemy
>Priority: Major
> Fix For: 3.6.3
>
>
> {noformat}[INFO] Running org.apache.maven.plugins.javadoc.JavadocJarTest
> [main] INFO org.codehaus.plexus.archiver.jar.JarArchiver - Building jar: 
> /tmp/sources/plugins/reporting/maven-javadoc-plugin/target/test/unit/javadocjar-default/target/javadocjar-default-javadoc.jar
> [main] INFO org.codehaus.plexus.archiver.jar.JarArchiver - Building jar: 
> /tmp/sources/plugins/reporting/maven-javadoc-plugin/null-null.jar
> [main] INFO org.codehaus.plexus.archiver.jar.JarArchiver - Building jar: 
> /tmp/sources/plugins/reporting/maven-javadoc-plugin/null-null.jar
> {noformat}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (MRESOLVER-429) Enhance JDK transport error messaging

2023-11-14 Thread Tamas Cservenak (Jira)


[ 
https://issues.apache.org/jira/browse/MRESOLVER-429?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17786066#comment-17786066
 ] 

Tamas Cservenak commented on MRESOLVER-429:
---

These are the IT changes needed to have alpha-1 pass: 
https://github.com/apache/maven-integration-testing/commit/53d7ae5492ef58cf5a43c3cfa421e6457b5f6f9d

> Enhance JDK transport error messaging
> -
>
> Key: MRESOLVER-429
> URL: https://issues.apache.org/jira/browse/MRESOLVER-429
> Project: Maven Resolver
>  Issue Type: Task
>  Components: Resolver
>Reporter: Tamas Cservenak
>Priority: Major
> Fix For: 2.0.0
>
>
> Currently we rely fully on JDK HttpClient error message for example in case 
> of connection refused: message is "ConnectException", just that. We could 
> improve this, make it more humane.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (DOXIASITETOOLS-319) Improve (documentation on) DocumentRenderer interface/DocumentRenderingContext class

2023-11-14 Thread ASF GitHub Bot (Jira)


[ 
https://issues.apache.org/jira/browse/DOXIASITETOOLS-319?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17786063#comment-17786063
 ] 

ASF GitHub Bot commented on DOXIASITETOOLS-319:
---

michael-o commented on PR #118:
URL: 
https://github.com/apache/maven-doxia-sitetools/pull/118#issuecomment-1811182495

   @kriegaex, please have a look. This is the the logical continuation.




> Improve (documentation on) DocumentRenderer 
> interface/DocumentRenderingContext class
> 
>
> Key: DOXIASITETOOLS-319
> URL: https://issues.apache.org/jira/browse/DOXIASITETOOLS-319
> Project: Maven Doxia Sitetools
>  Issue Type: Task
>  Components: Site renderer
>Affects Versions: 2.0.0-M13
>Reporter: Michael Osipov
>Assignee: Michael Osipov
>Priority: Major
> Fix For: 2.0.0-M16
>
>
> This is a followup to MSHARED-1326.
> {{#getOutputName()}} does not clearly say that is actually an optional base 
> *path* and base name (base location) of the report item from a reporting 
> output directory. It needs at least a doc update and maybe even a rename to 
> {{#getOutputPath()}}/{{#getOutputPathLocation()}}?
> Same applies for {{#getInputName()}}.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


Re: [PR] [DOXIASITETOOLS-319] Improve (documentation on) DocumentRenderer inte… [maven-doxia-sitetools]

2023-11-14 Thread via GitHub


michael-o commented on PR #118:
URL: 
https://github.com/apache/maven-doxia-sitetools/pull/118#issuecomment-1811182495

   @kriegaex, please have a look. This is the the logical continuation.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[jira] [Commented] (DOXIASITETOOLS-319) Improve (documentation on) DocumentRenderer interface/DocumentRenderingContext class

2023-11-14 Thread ASF GitHub Bot (Jira)


[ 
https://issues.apache.org/jira/browse/DOXIASITETOOLS-319?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17786062#comment-17786062
 ] 

ASF GitHub Bot commented on DOXIASITETOOLS-319:
---

michael-o opened a new pull request, #118:
URL: https://github.com/apache/maven-doxia-sitetools/pull/118

   …rface/DocumentRenderingContext class
   
   This closes #118




> Improve (documentation on) DocumentRenderer 
> interface/DocumentRenderingContext class
> 
>
> Key: DOXIASITETOOLS-319
> URL: https://issues.apache.org/jira/browse/DOXIASITETOOLS-319
> Project: Maven Doxia Sitetools
>  Issue Type: Task
>  Components: Site renderer
>Affects Versions: 2.0.0-M13
>Reporter: Michael Osipov
>Assignee: Michael Osipov
>Priority: Major
> Fix For: 2.0.0-M16
>
>
> This is a followup to MSHARED-1326.
> {{#getOutputName()}} does not clearly say that is actually an optional base 
> *path* and base name (base location) of the report item from a reporting 
> output directory. It needs at least a doc update and maybe even a rename to 
> {{#getOutputPath()}}/{{#getOutputPathLocation()}}?
> Same applies for {{#getInputName()}}.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[PR] [DOXIASITETOOLS-319] Improve (documentation on) DocumentRenderer inte… [maven-doxia-sitetools]

2023-11-14 Thread via GitHub


michael-o opened a new pull request, #118:
URL: https://github.com/apache/maven-doxia-sitetools/pull/118

   …rface/DocumentRenderingContext class
   
   This closes #118


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[jira] [Commented] (MRESOLVER-433) Expose configuration for inhibiting Expect-Continue handshake in 1.x

2023-11-14 Thread Tamas Cservenak (Jira)


[ 
https://issues.apache.org/jira/browse/MRESOLVER-433?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17786053#comment-17786053
 ] 

Tamas Cservenak commented on MRESOLVER-433:
---

This issue is about backporting relevant part of 
https://github.com/apache/maven-resolver/commit/178cfba9f3889f7e942a6a0d74716355b01a78f5

> Expose configuration for inhibiting Expect-Continue handshake in 1.x
> 
>
> Key: MRESOLVER-433
> URL: https://issues.apache.org/jira/browse/MRESOLVER-433
> Project: Maven Resolver
>  Issue Type: Task
>  Components: Resolver
>Reporter: Tamas Cservenak
>Assignee: Tamas Cservenak
>Priority: Major
> Fix For: 1.9.17
>
>
> I consider servers claiming supporting HTTP/1.1 but "choking" on 
> Expect-Continue a broken server, but meh...



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Updated] (MRESOLVER-433) Expose configuration for inhibiting Expect-Continue handshake in 1.x

2023-11-14 Thread Tamas Cservenak (Jira)


 [ 
https://issues.apache.org/jira/browse/MRESOLVER-433?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Tamas Cservenak updated MRESOLVER-433:
--
Fix Version/s: (was: 2.0.0)

> Expose configuration for inhibiting Expect-Continue handshake in 1.x
> 
>
> Key: MRESOLVER-433
> URL: https://issues.apache.org/jira/browse/MRESOLVER-433
> Project: Maven Resolver
>  Issue Type: Task
>  Components: Resolver
>Reporter: Tamas Cservenak
>Assignee: Tamas Cservenak
>Priority: Major
> Fix For: 1.9.17
>
>
> I consider servers claiming supporting HTTP/1.1 but "choking" on 
> Expect-Continue a broken server, but meh...



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Created] (MRESOLVER-433) Expose configuration for inhibiting Expect-Continue handshake in 1.x

2023-11-14 Thread Tamas Cservenak (Jira)
Tamas Cservenak created MRESOLVER-433:
-

 Summary: Expose configuration for inhibiting Expect-Continue 
handshake in 1.x
 Key: MRESOLVER-433
 URL: https://issues.apache.org/jira/browse/MRESOLVER-433
 Project: Maven Resolver
  Issue Type: Task
  Components: Resolver
Reporter: Tamas Cservenak
Assignee: Tamas Cservenak
 Fix For: 2.0.0, 1.9.17


I consider servers claiming supporting HTTP/1.1 but "choking" on 
Expect-Continue a broken server, but meh...



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Updated] (MRESOLVER-427) Expose configuration for inhibiting Expect-Continue handshake

2023-11-14 Thread Tamas Cservenak (Jira)


 [ 
https://issues.apache.org/jira/browse/MRESOLVER-427?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Tamas Cservenak updated MRESOLVER-427:
--
Fix Version/s: (was: 1.9.17)

> Expose configuration for inhibiting Expect-Continue handshake
> -
>
> Key: MRESOLVER-427
> URL: https://issues.apache.org/jira/browse/MRESOLVER-427
> Project: Maven Resolver
>  Issue Type: Task
>  Components: Resolver
>Reporter: Tamas Cservenak
>Assignee: Tamas Cservenak
>Priority: Major
> Fix For: 2.0.0
>
>
> I consider servers claiming supporting HTTP/1.1 but "choking" on 
> Expect-Continue a broken server, but meh...



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (MRESOLVER-427) Expose configuration for inhibiting Expect-Continue handshake

2023-11-14 Thread ASF GitHub Bot (Jira)


[ 
https://issues.apache.org/jira/browse/MRESOLVER-427?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17786043#comment-17786043
 ] 

ASF GitHub Bot commented on MRESOLVER-427:
--

cstamas merged PR #363:
URL: https://github.com/apache/maven-resolver/pull/363




> Expose configuration for inhibiting Expect-Continue handshake
> -
>
> Key: MRESOLVER-427
> URL: https://issues.apache.org/jira/browse/MRESOLVER-427
> Project: Maven Resolver
>  Issue Type: Task
>  Components: Resolver
>Reporter: Tamas Cservenak
>Assignee: Tamas Cservenak
>Priority: Major
> Fix For: 2.0.0, 1.9.17
>
>
> I consider servers claiming supporting HTTP/1.1 but "choking" on 
> Expect-Continue a broken server, but meh...



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Closed] (MRESOLVER-427) Expose configuration for inhibiting Expect-Continue handshake

2023-11-14 Thread Tamas Cservenak (Jira)


 [ 
https://issues.apache.org/jira/browse/MRESOLVER-427?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Tamas Cservenak closed MRESOLVER-427.
-
Resolution: Fixed

> Expose configuration for inhibiting Expect-Continue handshake
> -
>
> Key: MRESOLVER-427
> URL: https://issues.apache.org/jira/browse/MRESOLVER-427
> Project: Maven Resolver
>  Issue Type: Task
>  Components: Resolver
>Reporter: Tamas Cservenak
>Assignee: Tamas Cservenak
>Priority: Major
> Fix For: 2.0.0, 1.9.17
>
>
> I consider servers claiming supporting HTTP/1.1 but "choking" on 
> Expect-Continue a broken server, but meh...



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


Re: [PR] [MRESOLVER-427] Config for expect/continue inhibition [maven-resolver]

2023-11-14 Thread via GitHub


cstamas merged PR #363:
URL: https://github.com/apache/maven-resolver/pull/363


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[jira] [Commented] (MRESOLVER-432) Introduce session provider as well

2023-11-14 Thread ASF GitHub Bot (Jira)


[ 
https://issues.apache.org/jira/browse/MRESOLVER-432?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17786042#comment-17786042
 ] 

ASF GitHub Bot commented on MRESOLVER-432:
--

cstamas merged PR #362:
URL: https://github.com/apache/maven-resolver/pull/362




> Introduce session provider as well
> --
>
> Key: MRESOLVER-432
> URL: https://issues.apache.org/jira/browse/MRESOLVER-432
> Project: Maven Resolver
>  Issue Type: Task
>  Components: Resolver
>Reporter: Tamas Cservenak
>Assignee: Tamas Cservenak
>Priority: Major
> Fix For: 2.0.0
>
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)


Re: [PR] [MRESOLVER-432] Introduce Session Supplier similar to System Supplier [maven-resolver]

2023-11-14 Thread via GitHub


cstamas merged PR #362:
URL: https://github.com/apache/maven-resolver/pull/362


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[jira] [Closed] (MRESOLVER-432) Introduce session provider as well

2023-11-14 Thread Tamas Cservenak (Jira)


 [ 
https://issues.apache.org/jira/browse/MRESOLVER-432?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Tamas Cservenak closed MRESOLVER-432.
-
Resolution: Fixed

> Introduce session provider as well
> --
>
> Key: MRESOLVER-432
> URL: https://issues.apache.org/jira/browse/MRESOLVER-432
> Project: Maven Resolver
>  Issue Type: Task
>  Components: Resolver
>Reporter: Tamas Cservenak
>Assignee: Tamas Cservenak
>Priority: Major
> Fix For: 2.0.0
>
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Created] (DOXIASITETOOLS-319) Improve (documentation on) DocumentRenderer interface/DocumentRenderingContext class

2023-11-14 Thread Michael Osipov (Jira)
Michael Osipov created DOXIASITETOOLS-319:
-

 Summary: Improve (documentation on) DocumentRenderer 
interface/DocumentRenderingContext class
 Key: DOXIASITETOOLS-319
 URL: https://issues.apache.org/jira/browse/DOXIASITETOOLS-319
 Project: Maven Doxia Sitetools
  Issue Type: Task
  Components: Site renderer
Affects Versions: 2.0.0-M13
Reporter: Michael Osipov
Assignee: Michael Osipov
 Fix For: 2.0.0-M16


This is a followup to MSHARED-1326.

{{#getOutputName()}} does not clearly say that is actually an optional base 
*path* and base name (base location) of the report item from a reporting output 
directory. It needs at least a doc update and maybe even a rename to 
{{#getOutputPath()}}/{{#getOutputPathLocation()}}?
Same applies for {{#getInputName()}}.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Updated] (DOXIASITETOOLS-318) Upgrade to Maven Reporting API 4.0.0-M9

2023-11-14 Thread Michael Osipov (Jira)


 [ 
https://issues.apache.org/jira/browse/DOXIASITETOOLS-318?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Michael Osipov updated DOXIASITETOOLS-318:
--
Fix Version/s: 2.0.0-M16

> Upgrade to Maven Reporting API 4.0.0-M9
> ---
>
> Key: DOXIASITETOOLS-318
> URL: https://issues.apache.org/jira/browse/DOXIASITETOOLS-318
> Project: Maven Doxia Sitetools
>  Issue Type: Dependency upgrade
>Reporter: Michael Osipov
>Assignee: Michael Osipov
>Priority: Major
> Fix For: 2.0.0-M14, 2.0.0-M15, 2.0.0-M16
>
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Updated] (DOXIASITETOOLS-317) Upgrade to Parent 41

2023-11-14 Thread Michael Osipov (Jira)


 [ 
https://issues.apache.org/jira/browse/DOXIASITETOOLS-317?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Michael Osipov updated DOXIASITETOOLS-317:
--
Fix Version/s: 2.0.0-M16

> Upgrade to Parent 41
> 
>
> Key: DOXIASITETOOLS-317
> URL: https://issues.apache.org/jira/browse/DOXIASITETOOLS-317
> Project: Maven Doxia Sitetools
>  Issue Type: Dependency upgrade
>Reporter: Michael Osipov
>Assignee: Michael Osipov
>Priority: Major
> Fix For: 2.0.0-M14, 2.0.0-M15, 2.0.0-M16
>
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (MPLUGIN-450) Make goal prefix mandatory by default

2023-11-14 Thread ASF GitHub Bot (Jira)


[ 
https://issues.apache.org/jira/browse/MPLUGIN-450?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17786035#comment-17786035
 ] 

ASF GitHub Bot commented on MPLUGIN-450:


michael-o commented on code in PR #240:
URL: 
https://github.com/apache/maven-plugin-tools/pull/240#discussion_r1393124464


##
maven-plugin-plugin/src/main/java/org/apache/maven/plugin/plugin/AbstractGeneratorMojo.java:
##
@@ -81,28 +80,24 @@ public void execute() throws MojoExecutionException {
 return;
 }
 
-String defaultGoalPrefix = getDefaultGoalPrefix(project);
-
-if (goalPrefix == null) {
-goalPrefix = defaultGoalPrefix;
-} else if (!goalPrefix.equals(defaultGoalPrefix)) {
-getLog().warn(LS + LS + "Goal prefix is specified as: '" + 
goalPrefix + "'. "
-+ "Maven currently expects it to be '" + defaultGoalPrefix 
+ "'." + LS);
+if (goalPrefix == null || goalPrefix.isEmpty()) {
+goalPrefix = getDefaultGoalPrefix(project);
+}
+if (goalPrefix == null || goalPrefix.isEmpty()) {
+throw new MojoExecutionException("You need to specify a goalPrefix 
as it can not be correctly computed");
 }
 
 generate();
 }
 
 static String getDefaultGoalPrefix(MavenProject project) {
-String defaultGoalPrefix;
-if 
("maven-plugin-report-plugin".equalsIgnoreCase(project.getArtifactId())) {
-defaultGoalPrefix = "plugin-report";
-} else if ("maven-plugin".equalsIgnoreCase(project.getArtifactId())) {
-defaultGoalPrefix =
-
project.getGroupId().substring(project.getGroupId().lastIndexOf('.') + 1);
+String artifactId = project.getArtifactId();
+if (artifactId.endsWith("-maven-plugin")) {
+return artifactId.substring(0, artifactId.length() - 
"-maven-plugin".length());
+} else if (artifactId.startsWith("maven-") && 
artifactId.endsWith("-plugin")) {
+return artifactId.substring("maven-".length(), artifactId.length() 
- "-plugin".length());
 } else {
-defaultGoalPrefix = 
PluginDescriptor.getGoalPrefixFromArtifactId(project.getArtifactId());

Review Comment:
   Alright, then not worth it.





> Make goal prefix mandatory by default
> -
>
> Key: MPLUGIN-450
> URL: https://issues.apache.org/jira/browse/MPLUGIN-450
> Project: Maven Plugin Tools
>  Issue Type: Improvement
>  Components: Plugin Plugin
>Reporter: Tamas Cservenak
>Priority: Major
>
> The goal prefix currently is not mandatory, and plugin uses heuristic to 
> figure it out, if possible (xxx-maven-plugin or maven-xxx-plugin, latter for 
> org.apache.maven plugins ONLY).
> In general, goal prefix is optional, but "good to have", and usually is 
> present.
> Cases when is not present, is when heuristics fails (so plugin module is not 
> named as "xxx-maven-plugin" or "maven-xxx-plugin") and user did not provide 
> one either. The cases when prefix is not present is mostly unintentional, but 
> maven-plugin-plugin leaves this without any remark or warning.
> IMHO, the maven-plugin-plugin should either warn, or even fail the build in 
> case when goal prefix is not present, but we may want to have some option to 
> turn off this feature (for me unknown reasons, where it would be expected to 
> NOT have goal prefix for a reason).
> TL;DR Am pretty much sure that in most of the cases when plugin developer 
> ends up with plugin without prefix, that it was unintentional (and causes 
> surprise later, not to mention refactoring the module name or POM change to 
> configure it), while there MAY be cases where goal prefix is not desired for 
> some reason (ie. plugin not mentioned for manual/CLI invocation). Simply put, 
> the out of the box defaults should enforce presence of it, while advanced 
> users still can produce prefix-less plugins with some extra configuration. 
> This would make things more explicit as well: even if plugin is named as 
> xxx-maven-plugin, configuration would be clear I do not want prefix for it.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


Re: [PR] [MPLUGIN-450] Require goalPrefix to be valid [maven-plugin-tools]

2023-11-14 Thread via GitHub


michael-o commented on code in PR #240:
URL: 
https://github.com/apache/maven-plugin-tools/pull/240#discussion_r1393124464


##
maven-plugin-plugin/src/main/java/org/apache/maven/plugin/plugin/AbstractGeneratorMojo.java:
##
@@ -81,28 +80,24 @@ public void execute() throws MojoExecutionException {
 return;
 }
 
-String defaultGoalPrefix = getDefaultGoalPrefix(project);
-
-if (goalPrefix == null) {
-goalPrefix = defaultGoalPrefix;
-} else if (!goalPrefix.equals(defaultGoalPrefix)) {
-getLog().warn(LS + LS + "Goal prefix is specified as: '" + 
goalPrefix + "'. "
-+ "Maven currently expects it to be '" + defaultGoalPrefix 
+ "'." + LS);
+if (goalPrefix == null || goalPrefix.isEmpty()) {
+goalPrefix = getDefaultGoalPrefix(project);
+}
+if (goalPrefix == null || goalPrefix.isEmpty()) {
+throw new MojoExecutionException("You need to specify a goalPrefix 
as it can not be correctly computed");
 }
 
 generate();
 }
 
 static String getDefaultGoalPrefix(MavenProject project) {
-String defaultGoalPrefix;
-if 
("maven-plugin-report-plugin".equalsIgnoreCase(project.getArtifactId())) {
-defaultGoalPrefix = "plugin-report";
-} else if ("maven-plugin".equalsIgnoreCase(project.getArtifactId())) {
-defaultGoalPrefix =
-
project.getGroupId().substring(project.getGroupId().lastIndexOf('.') + 1);
+String artifactId = project.getArtifactId();
+if (artifactId.endsWith("-maven-plugin")) {
+return artifactId.substring(0, artifactId.length() - 
"-maven-plugin".length());
+} else if (artifactId.startsWith("maven-") && 
artifactId.endsWith("-plugin")) {
+return artifactId.substring("maven-".length(), artifactId.length() 
- "-plugin".length());
 } else {
-defaultGoalPrefix = 
PluginDescriptor.getGoalPrefixFromArtifactId(project.getArtifactId());

Review Comment:
   Alright, then not worth it.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[jira] [Commented] (MPLUGIN-450) Make goal prefix mandatory by default

2023-11-14 Thread ASF GitHub Bot (Jira)


[ 
https://issues.apache.org/jira/browse/MPLUGIN-450?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17786033#comment-17786033
 ] 

ASF GitHub Bot commented on MPLUGIN-450:


gnodet commented on code in PR #240:
URL: 
https://github.com/apache/maven-plugin-tools/pull/240#discussion_r1393117919


##
maven-plugin-plugin/src/main/java/org/apache/maven/plugin/plugin/AbstractGeneratorMojo.java:
##
@@ -81,28 +80,24 @@ public void execute() throws MojoExecutionException {
 return;
 }
 
-String defaultGoalPrefix = getDefaultGoalPrefix(project);
-
-if (goalPrefix == null) {
-goalPrefix = defaultGoalPrefix;
-} else if (!goalPrefix.equals(defaultGoalPrefix)) {
-getLog().warn(LS + LS + "Goal prefix is specified as: '" + 
goalPrefix + "'. "
-+ "Maven currently expects it to be '" + defaultGoalPrefix 
+ "'." + LS);
+if (goalPrefix == null || goalPrefix.isEmpty()) {
+goalPrefix = getDefaultGoalPrefix(project);
+}
+if (goalPrefix == null || goalPrefix.isEmpty()) {
+throw new MojoExecutionException("You need to specify a goalPrefix 
as it can not be correctly computed");
 }
 
 generate();
 }
 
 static String getDefaultGoalPrefix(MavenProject project) {
-String defaultGoalPrefix;
-if 
("maven-plugin-report-plugin".equalsIgnoreCase(project.getArtifactId())) {
-defaultGoalPrefix = "plugin-report";
-} else if ("maven-plugin".equalsIgnoreCase(project.getArtifactId())) {
-defaultGoalPrefix =
-
project.getGroupId().substring(project.getGroupId().lastIndexOf('.') + 1);
+String artifactId = project.getArtifactId();
+if (artifactId.endsWith("-maven-plugin")) {
+return artifactId.substring(0, artifactId.length() - 
"-maven-plugin".length());
+} else if (artifactId.startsWith("maven-") && 
artifactId.endsWith("-plugin")) {
+return artifactId.substring("maven-".length(), artifactId.length() 
- "-plugin".length());
 } else {
-defaultGoalPrefix = 
PluginDescriptor.getGoalPrefixFromArtifactId(project.getArtifactId());

Review Comment:
   In 4.0 ? I'm currently working on cleaning the maven-plugin-api module, i.e. 
getting rid of plexus in the API and generating the model using the mdo file, 
etc... So the whole package will be somewhat deprecated at some point.  Not 
sure we should deprecate a single method...





> Make goal prefix mandatory by default
> -
>
> Key: MPLUGIN-450
> URL: https://issues.apache.org/jira/browse/MPLUGIN-450
> Project: Maven Plugin Tools
>  Issue Type: Improvement
>  Components: Plugin Plugin
>Reporter: Tamas Cservenak
>Priority: Major
>
> The goal prefix currently is not mandatory, and plugin uses heuristic to 
> figure it out, if possible (xxx-maven-plugin or maven-xxx-plugin, latter for 
> org.apache.maven plugins ONLY).
> In general, goal prefix is optional, but "good to have", and usually is 
> present.
> Cases when is not present, is when heuristics fails (so plugin module is not 
> named as "xxx-maven-plugin" or "maven-xxx-plugin") and user did not provide 
> one either. The cases when prefix is not present is mostly unintentional, but 
> maven-plugin-plugin leaves this without any remark or warning.
> IMHO, the maven-plugin-plugin should either warn, or even fail the build in 
> case when goal prefix is not present, but we may want to have some option to 
> turn off this feature (for me unknown reasons, where it would be expected to 
> NOT have goal prefix for a reason).
> TL;DR Am pretty much sure that in most of the cases when plugin developer 
> ends up with plugin without prefix, that it was unintentional (and causes 
> surprise later, not to mention refactoring the module name or POM change to 
> configure it), while there MAY be cases where goal prefix is not desired for 
> some reason (ie. plugin not mentioned for manual/CLI invocation). Simply put, 
> the out of the box defaults should enforce presence of it, while advanced 
> users still can produce prefix-less plugins with some extra configuration. 
> This would make things more explicit as well: even if plugin is named as 
> xxx-maven-plugin, configuration would be clear I do not want prefix for it.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


Re: [PR] [MPLUGIN-450] Require goalPrefix to be valid [maven-plugin-tools]

2023-11-14 Thread via GitHub


gnodet commented on code in PR #240:
URL: 
https://github.com/apache/maven-plugin-tools/pull/240#discussion_r1393117919


##
maven-plugin-plugin/src/main/java/org/apache/maven/plugin/plugin/AbstractGeneratorMojo.java:
##
@@ -81,28 +80,24 @@ public void execute() throws MojoExecutionException {
 return;
 }
 
-String defaultGoalPrefix = getDefaultGoalPrefix(project);
-
-if (goalPrefix == null) {
-goalPrefix = defaultGoalPrefix;
-} else if (!goalPrefix.equals(defaultGoalPrefix)) {
-getLog().warn(LS + LS + "Goal prefix is specified as: '" + 
goalPrefix + "'. "
-+ "Maven currently expects it to be '" + defaultGoalPrefix 
+ "'." + LS);
+if (goalPrefix == null || goalPrefix.isEmpty()) {
+goalPrefix = getDefaultGoalPrefix(project);
+}
+if (goalPrefix == null || goalPrefix.isEmpty()) {
+throw new MojoExecutionException("You need to specify a goalPrefix 
as it can not be correctly computed");
 }
 
 generate();
 }
 
 static String getDefaultGoalPrefix(MavenProject project) {
-String defaultGoalPrefix;
-if 
("maven-plugin-report-plugin".equalsIgnoreCase(project.getArtifactId())) {
-defaultGoalPrefix = "plugin-report";
-} else if ("maven-plugin".equalsIgnoreCase(project.getArtifactId())) {
-defaultGoalPrefix =
-
project.getGroupId().substring(project.getGroupId().lastIndexOf('.') + 1);
+String artifactId = project.getArtifactId();
+if (artifactId.endsWith("-maven-plugin")) {
+return artifactId.substring(0, artifactId.length() - 
"-maven-plugin".length());
+} else if (artifactId.startsWith("maven-") && 
artifactId.endsWith("-plugin")) {
+return artifactId.substring("maven-".length(), artifactId.length() 
- "-plugin".length());
 } else {
-defaultGoalPrefix = 
PluginDescriptor.getGoalPrefixFromArtifactId(project.getArtifactId());

Review Comment:
   In 4.0 ? I'm currently working on cleaning the maven-plugin-api module, i.e. 
getting rid of plexus in the API and generating the model using the mdo file, 
etc... So the whole package will be somewhat deprecated at some point.  Not 
sure we should deprecate a single method...



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[jira] [Commented] (MCHECKSTYLE-357) also allow inline configuration for reporting

2023-11-14 Thread ASF GitHub Bot (Jira)


[ 
https://issues.apache.org/jira/browse/MCHECKSTYLE-357?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17786031#comment-17786031
 ] 

ASF GitHub Bot commented on MCHECKSTYLE-357:


slachiewicz closed pull request #77: Bump checkstyle from 8.15 to 8.29 in 
/src/it/MCHECKSTYLE-357-with-header-override
URL: https://github.com/apache/maven-checkstyle-plugin/pull/77




> also allow inline configuration for reporting
> -
>
> Key: MCHECKSTYLE-357
> URL: https://issues.apache.org/jira/browse/MCHECKSTYLE-357
> Project: Maven Checkstyle Plugin
>  Issue Type: Improvement
>  Components: checkstyle:checkstyle, checkstyle:checkstyle-aggregate
>Affects Versions: 3.0.0
>Reporter: Peter Lamby
>Assignee: Enrico Olivelli
>Priority: Major
>  Time Spent: 0.5h
>  Remaining Estimate: 0h
>
> MCHECKSTYLE-211 allows the inline configuration of checkstyle rules. This is 
> extremly helpful when you want to inherit the checkstyle configuration from a 
> parent pom.
> Sadly it is not possible to configure the report targets this way. It would 
> be great if the same handling added in MCHECKSTYLE-211 would be added to the 
> reporting goals.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (MCHECKSTYLE-357) also allow inline configuration for reporting

2023-11-14 Thread ASF GitHub Bot (Jira)


[ 
https://issues.apache.org/jira/browse/MCHECKSTYLE-357?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17786032#comment-17786032
 ] 

ASF GitHub Bot commented on MCHECKSTYLE-357:


dependabot[bot] commented on PR #77:
URL: 
https://github.com/apache/maven-checkstyle-plugin/pull/77#issuecomment-1810976914

   OK, I won't notify you again about this release, but will get in touch when 
a new version is available. If you'd rather skip all updates until the next 
major or minor version, let me know by commenting `@dependabot ignore this 
major version` or `@dependabot ignore this minor version`. You can also ignore 
all major, minor, or patch releases for a dependency by adding an [`ignore` 
condition](https://docs.github.com/en/code-security/supply-chain-security/configuration-options-for-dependency-updates#ignore)
 with the desired `update_types` to your config file.
   
   If you change your mind, just re-open this PR and I'll resolve any conflicts 
on it.




> also allow inline configuration for reporting
> -
>
> Key: MCHECKSTYLE-357
> URL: https://issues.apache.org/jira/browse/MCHECKSTYLE-357
> Project: Maven Checkstyle Plugin
>  Issue Type: Improvement
>  Components: checkstyle:checkstyle, checkstyle:checkstyle-aggregate
>Affects Versions: 3.0.0
>Reporter: Peter Lamby
>Assignee: Enrico Olivelli
>Priority: Major
>  Time Spent: 0.5h
>  Remaining Estimate: 0h
>
> MCHECKSTYLE-211 allows the inline configuration of checkstyle rules. This is 
> extremly helpful when you want to inherit the checkstyle configuration from a 
> parent pom.
> Sadly it is not possible to configure the report targets this way. It would 
> be great if the same handling added in MCHECKSTYLE-211 would be added to the 
> reporting goals.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


Re: [PR] Bump checkstyle from 8.15 to 8.29 in /src/it/MCHECKSTYLE-357-with-header-override [maven-checkstyle-plugin]

2023-11-14 Thread via GitHub


dependabot[bot] commented on PR #77:
URL: 
https://github.com/apache/maven-checkstyle-plugin/pull/77#issuecomment-1810976914

   OK, I won't notify you again about this release, but will get in touch when 
a new version is available. If you'd rather skip all updates until the next 
major or minor version, let me know by commenting `@dependabot ignore this 
major version` or `@dependabot ignore this minor version`. You can also ignore 
all major, minor, or patch releases for a dependency by adding an [`ignore` 
condition](https://docs.github.com/en/code-security/supply-chain-security/configuration-options-for-dependency-updates#ignore)
 with the desired `update_types` to your config file.
   
   If you change your mind, just re-open this PR and I'll resolve any conflicts 
on it.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] Bump checkstyle from 8.15 to 8.29 in /src/it/MCHECKSTYLE-357-with-header-override [maven-checkstyle-plugin]

2023-11-14 Thread via GitHub


slachiewicz closed pull request #77: Bump checkstyle from 8.15 to 8.29 in 
/src/it/MCHECKSTYLE-357-with-header-override
URL: https://github.com/apache/maven-checkstyle-plugin/pull/77


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[jira] [Created] (MNG-7934) Upgrade Resolver version to 1.9.17

2023-11-14 Thread Tamas Cservenak (Jira)
Tamas Cservenak created MNG-7934:


 Summary: Upgrade Resolver version to 1.9.17
 Key: MNG-7934
 URL: https://issues.apache.org/jira/browse/MNG-7934
 Project: Maven
  Issue Type: Dependency upgrade
Reporter: Tamas Cservenak
 Fix For: 3.9.6






--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (MPLUGIN-450) Make goal prefix mandatory by default

2023-11-14 Thread ASF GitHub Bot (Jira)


[ 
https://issues.apache.org/jira/browse/MPLUGIN-450?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17786025#comment-17786025
 ] 

ASF GitHub Bot commented on MPLUGIN-450:


michael-o commented on code in PR #240:
URL: 
https://github.com/apache/maven-plugin-tools/pull/240#discussion_r1393074122


##
maven-plugin-plugin/src/main/java/org/apache/maven/plugin/plugin/AbstractGeneratorMojo.java:
##
@@ -81,28 +80,24 @@ public void execute() throws MojoExecutionException {
 return;
 }
 
-String defaultGoalPrefix = getDefaultGoalPrefix(project);
-
-if (goalPrefix == null) {
-goalPrefix = defaultGoalPrefix;
-} else if (!goalPrefix.equals(defaultGoalPrefix)) {
-getLog().warn(LS + LS + "Goal prefix is specified as: '" + 
goalPrefix + "'. "
-+ "Maven currently expects it to be '" + defaultGoalPrefix 
+ "'." + LS);
+if (goalPrefix == null || goalPrefix.isEmpty()) {
+goalPrefix = getDefaultGoalPrefix(project);
+}
+if (goalPrefix == null || goalPrefix.isEmpty()) {
+throw new MojoExecutionException("You need to specify a goalPrefix 
as it can not be correctly computed");
 }
 
 generate();
 }
 
 static String getDefaultGoalPrefix(MavenProject project) {
-String defaultGoalPrefix;
-if 
("maven-plugin-report-plugin".equalsIgnoreCase(project.getArtifactId())) {
-defaultGoalPrefix = "plugin-report";
-} else if ("maven-plugin".equalsIgnoreCase(project.getArtifactId())) {
-defaultGoalPrefix =
-
project.getGroupId().substring(project.getGroupId().lastIndexOf('.') + 1);
+String artifactId = project.getArtifactId();
+if (artifactId.endsWith("-maven-plugin")) {
+return artifactId.substring(0, artifactId.length() - 
"-maven-plugin".length());
+} else if (artifactId.startsWith("maven-") && 
artifactId.endsWith("-plugin")) {
+return artifactId.substring("maven-".length(), artifactId.length() 
- "-plugin".length());
 } else {
-defaultGoalPrefix = 
PluginDescriptor.getGoalPrefixFromArtifactId(project.getArtifactId());

Review Comment:
   Should this imply that this static method should be deprecated?





> Make goal prefix mandatory by default
> -
>
> Key: MPLUGIN-450
> URL: https://issues.apache.org/jira/browse/MPLUGIN-450
> Project: Maven Plugin Tools
>  Issue Type: Improvement
>  Components: Plugin Plugin
>Reporter: Tamas Cservenak
>Priority: Major
>
> The goal prefix currently is not mandatory, and plugin uses heuristic to 
> figure it out, if possible (xxx-maven-plugin or maven-xxx-plugin, latter for 
> org.apache.maven plugins ONLY).
> In general, goal prefix is optional, but "good to have", and usually is 
> present.
> Cases when is not present, is when heuristics fails (so plugin module is not 
> named as "xxx-maven-plugin" or "maven-xxx-plugin") and user did not provide 
> one either. The cases when prefix is not present is mostly unintentional, but 
> maven-plugin-plugin leaves this without any remark or warning.
> IMHO, the maven-plugin-plugin should either warn, or even fail the build in 
> case when goal prefix is not present, but we may want to have some option to 
> turn off this feature (for me unknown reasons, where it would be expected to 
> NOT have goal prefix for a reason).
> TL;DR Am pretty much sure that in most of the cases when plugin developer 
> ends up with plugin without prefix, that it was unintentional (and causes 
> surprise later, not to mention refactoring the module name or POM change to 
> configure it), while there MAY be cases where goal prefix is not desired for 
> some reason (ie. plugin not mentioned for manual/CLI invocation). Simply put, 
> the out of the box defaults should enforce presence of it, while advanced 
> users still can produce prefix-less plugins with some extra configuration. 
> This would make things more explicit as well: even if plugin is named as 
> xxx-maven-plugin, configuration would be clear I do not want prefix for it.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Updated] (MNG-7913) Upgrade Sisu version

2023-11-14 Thread Tamas Cservenak (Jira)


 [ 
https://issues.apache.org/jira/browse/MNG-7913?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Tamas Cservenak updated MNG-7913:
-
Issue Type: Dependency upgrade  (was: Improvement)

> Upgrade Sisu version
> 
>
> Key: MNG-7913
> URL: https://issues.apache.org/jira/browse/MNG-7913
> Project: Maven
>  Issue Type: Dependency upgrade
>  Components: Core
>Reporter: Tamas Cservenak
>Assignee: Tamas Cservenak
>Priority: Major
> Fix For: 3.9.6
>
>
> Recently, as new Java versions are pushed out more aggressively (with Java 21 
> out this autumn), seemingly it became normal that users developing Maven 
> plugins (and components used by those plugins) using bytecode level that is 
> Java14+.
> But alas, Maven 3.9.x line uses Sisu 0.3.5 that is capable to glean bytecode 
> only up to Java 14. Components having higher version bytecode are silently 
> skipped by Sisu (no output about this, only at Sisu DEBUG level not emitted 
> by default).
> Hence, it would make sense to up Sisu version to at least 0.9.0.M2 in Maven 
> 3.9.x as well, that would allow use of JSR330 components using bytecode more 
> recent that Java 14 is, up to 19.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


Re: [PR] [MPLUGIN-450] Require goalPrefix to be valid [maven-plugin-tools]

2023-11-14 Thread via GitHub


michael-o commented on code in PR #240:
URL: 
https://github.com/apache/maven-plugin-tools/pull/240#discussion_r1393074122


##
maven-plugin-plugin/src/main/java/org/apache/maven/plugin/plugin/AbstractGeneratorMojo.java:
##
@@ -81,28 +80,24 @@ public void execute() throws MojoExecutionException {
 return;
 }
 
-String defaultGoalPrefix = getDefaultGoalPrefix(project);
-
-if (goalPrefix == null) {
-goalPrefix = defaultGoalPrefix;
-} else if (!goalPrefix.equals(defaultGoalPrefix)) {
-getLog().warn(LS + LS + "Goal prefix is specified as: '" + 
goalPrefix + "'. "
-+ "Maven currently expects it to be '" + defaultGoalPrefix 
+ "'." + LS);
+if (goalPrefix == null || goalPrefix.isEmpty()) {
+goalPrefix = getDefaultGoalPrefix(project);
+}
+if (goalPrefix == null || goalPrefix.isEmpty()) {
+throw new MojoExecutionException("You need to specify a goalPrefix 
as it can not be correctly computed");
 }
 
 generate();
 }
 
 static String getDefaultGoalPrefix(MavenProject project) {
-String defaultGoalPrefix;
-if 
("maven-plugin-report-plugin".equalsIgnoreCase(project.getArtifactId())) {
-defaultGoalPrefix = "plugin-report";
-} else if ("maven-plugin".equalsIgnoreCase(project.getArtifactId())) {
-defaultGoalPrefix =
-
project.getGroupId().substring(project.getGroupId().lastIndexOf('.') + 1);
+String artifactId = project.getArtifactId();
+if (artifactId.endsWith("-maven-plugin")) {
+return artifactId.substring(0, artifactId.length() - 
"-maven-plugin".length());
+} else if (artifactId.startsWith("maven-") && 
artifactId.endsWith("-plugin")) {
+return artifactId.substring("maven-".length(), artifactId.length() 
- "-plugin".length());
 } else {
-defaultGoalPrefix = 
PluginDescriptor.getGoalPrefixFromArtifactId(project.getArtifactId());

Review Comment:
   Should this imply that this static method should be deprecated?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[jira] [Commented] (MNG-6026) Extend the Project Object Model (POM) with trust information (OpenPGP, hash values)

2023-11-14 Thread Tamas Cservenak (Jira)


[ 
https://issues.apache.org/jira/browse/MNG-6026?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17786001#comment-17786001
 ] 

Tamas Cservenak commented on MNG-6026:
--

Maven OOTB provides:
* trusted checksums 
https://maven.apache.org/resolver/expected-checksums.html#trusted-checksums
* SPI for resolver post processing

I hope you are aware of these,

> Extend the Project Object Model (POM) with trust information (OpenPGP, hash 
> values)
> ---
>
> Key: MNG-6026
> URL: https://issues.apache.org/jira/browse/MNG-6026
> Project: Maven
>  Issue Type: New Feature
>  Components: Core
>Reporter: Florian Schmaus
>Priority: Major
>  Labels: artifact-verification, security
>
> The origin of this feature request is the Stackoverflow question 
> ["Verification of dependency authenticity in Maven POM based automated build 
> systems"|http://stackoverflow.com/a/34795359/194894], and [especially a SO 
> user requesting me to put this 
> up|http://stackoverflow.com/questions/3307146/verification-of-dependency-authenticy-in-maven-pom-based-automated-build-systems/34795359?noredirect=1#comment62178671_34795359].
> h2. Extend the Project Object Model (POM) with trust information (OpenPGP - 
> RFC 4480 and hash values)
> What we need is the possibility to model a trust relation from your project 
> or artifact to the declared dependencies. So that, if all involved parties 
> declare such a relation, we are able to create a "chain of trust" from the 
> root (e.g. the project) over its dependencies down to the very last 
> transitive dependency. The Project Object Model (POM) needs to be extended by 
> a  element for dependencies.
> h3. Current Situation
> Right now we have something like
> {code:xml}
> 
>   junit
>   junit
>   4.0
> 
> {code}
> h3. Hard dependencies
> For hard dependencies,  could include the sha256sum of artifact 
> and its POM file:
> {code:xml}
> 
>   junit
>   junit
>   [4.0]
>   
> 
>   [sha256 of junit pom file]
>   [sha256sum of artifact (junit.jar)]
> 
>   
> 
> {code}
> h3. Soft dependencies
> If soft, which are also called "ranged" or "dynamic", dependencies are used, 
> then we could specify the public key (or multiple) of the keypair used to 
> sign the artifacts
> {code:xml}
> 
>   junit
>   junit
>   [4.0,4.5)
>   
> [secure fingerprint of OpenPGP key used to sign the junit 
> artifact(s)]
> 
>   
> 
> {code}
> I'm not sure if this is the right place to raise an feature request for the 
> POM format itself. I've already tried to get in touch with the right people 
> about this feature request, but failed. I'm willing to help designing and 
> implementing this, but need guidance.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (MNG-5814) Be able to verify the pgp signature of downloaded plugins against a trust configuration

2023-11-14 Thread Tamas Cservenak (Jira)


[ 
https://issues.apache.org/jira/browse/MNG-5814?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17785998#comment-17785998
 ] 

Tamas Cservenak commented on MNG-5814:
--

Using "trusted checksums" you can already ensure artifact integrity against any 
(for example SHA-512 or custom as checksums are extensible) checksum you want.

https://maven.apache.org/resolver/expected-checksums.html#trusted-checksums

> Be able to verify the pgp signature of downloaded plugins against a trust 
> configuration
> ---
>
> Key: MNG-5814
> URL: https://issues.apache.org/jira/browse/MNG-5814
> Project: Maven
>  Issue Type: Improvement
>  Components: Plugin Requests
>Reporter: Alexander Kjäll
>Priority: Major
>  Labels: security
>
> In order to protect ourself against an attacker that can do injection attacks 
> on our downloads we need to verify the pgp signatures of the downloaded 
> artifacts.
> For normal dependencies this can be done with a plugin, for example this one: 
> https://github.com/s4u/pgpverify-maven-plugin/
> But it's not possible for a plugin to verify it's own authenticity, as it was 
> downloaded over an possible insecure channel itself.
> Therefor we need something preinstalled that verifies that the plugin we 
> downloaded is the same one that was specified in our pom file.
> I propose that functionality is added to maven that verifies the jar and pom 
> files against it's pgp signature files for plugins. And some sort of notation 
> is added to the pom file so that it's possible to specify the signing key for 
> a plugin. 



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (MRESOLVER-427) Expose configuration for inhibiting Expect-Continue handshake

2023-11-14 Thread ASF GitHub Bot (Jira)


[ 
https://issues.apache.org/jira/browse/MRESOLVER-427?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17785995#comment-17785995
 ] 

ASF GitHub Bot commented on MRESOLVER-427:
--

cstamas opened a new pull request, #363:
URL: https://github.com/apache/maven-resolver/pull/363

   Add configuration to inhibit expect/continue handshake. Currently supported 
by "apache" and "jdk" HTTP transports.
   
   ---
   
   https://issues.apache.org/jira/browse/MRESOLVER-427




> Expose configuration for inhibiting Expect-Continue handshake
> -
>
> Key: MRESOLVER-427
> URL: https://issues.apache.org/jira/browse/MRESOLVER-427
> Project: Maven Resolver
>  Issue Type: Task
>  Components: Resolver
>Reporter: Tamas Cservenak
>Assignee: Tamas Cservenak
>Priority: Major
> Fix For: 2.0.0, 1.9.17
>
>
> I consider servers claiming supporting HTTP/1.1 but "choking" on 
> Expect-Continue a broken server, but meh...



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[PR] [MRESOLVER-427] Config for expect/continue inhibition [maven-resolver]

2023-11-14 Thread via GitHub


cstamas opened a new pull request, #363:
URL: https://github.com/apache/maven-resolver/pull/363

   Add configuration to inhibit expect/continue handshake. Currently supported 
by "apache" and "jdk" HTTP transports.
   
   ---
   
   https://issues.apache.org/jira/browse/MRESOLVER-427


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[jira] [Commented] (MJAVADOC-780) Unit tests create null-null.jar in build root directory

2023-11-14 Thread Michael Osipov (Jira)


[ 
https://issues.apache.org/jira/browse/MJAVADOC-780?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17785991#comment-17785991
 ] 

Michael Osipov commented on MJAVADOC-780:
-

Problematic test method: {{testStale()}}

> Unit tests create null-null.jar in build root directory
> ---
>
> Key: MJAVADOC-780
> URL: https://issues.apache.org/jira/browse/MJAVADOC-780
> Project: Maven Javadoc Plugin
>  Issue Type: Bug
>Affects Versions: 3.6.2
>Reporter: Herve Boutemy
>Priority: Major
> Fix For: 3.6.3
>
>
> {noformat}[INFO] Running org.apache.maven.plugins.javadoc.JavadocJarTest
> [main] INFO org.codehaus.plexus.archiver.jar.JarArchiver - Building jar: 
> /tmp/sources/plugins/reporting/maven-javadoc-plugin/target/test/unit/javadocjar-default/target/javadocjar-default-javadoc.jar
> [main] INFO org.codehaus.plexus.archiver.jar.JarArchiver - Building jar: 
> /tmp/sources/plugins/reporting/maven-javadoc-plugin/null-null.jar
> [main] INFO org.codehaus.plexus.archiver.jar.JarArchiver - Building jar: 
> /tmp/sources/plugins/reporting/maven-javadoc-plugin/null-null.jar
> {noformat}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Assigned] (MRESOLVER-427) Expose configuration for inhibiting Expect-Continue handshake

2023-11-14 Thread Tamas Cservenak (Jira)


 [ 
https://issues.apache.org/jira/browse/MRESOLVER-427?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Tamas Cservenak reassigned MRESOLVER-427:
-

Assignee: Tamas Cservenak

> Expose configuration for inhibiting Expect-Continue handshake
> -
>
> Key: MRESOLVER-427
> URL: https://issues.apache.org/jira/browse/MRESOLVER-427
> Project: Maven Resolver
>  Issue Type: Task
>  Components: Resolver
>Reporter: Tamas Cservenak
>Assignee: Tamas Cservenak
>Priority: Major
> Fix For: 2.0.0, 1.9.17
>
>
> I consider servers claiming supporting HTTP/1.1 but "choking" on 
> Expect-Continue a broken server, but meh...



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Assigned] (MRESOLVER-432) Introduce session provider as well

2023-11-14 Thread Tamas Cservenak (Jira)


 [ 
https://issues.apache.org/jira/browse/MRESOLVER-432?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Tamas Cservenak reassigned MRESOLVER-432:
-

Assignee: Tamas Cservenak

> Introduce session provider as well
> --
>
> Key: MRESOLVER-432
> URL: https://issues.apache.org/jira/browse/MRESOLVER-432
> Project: Maven Resolver
>  Issue Type: Task
>  Components: Resolver
>Reporter: Tamas Cservenak
>Assignee: Tamas Cservenak
>Priority: Major
> Fix For: 2.0.0
>
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (MNG-5378) Use maven-shared-utils in Maven core to replace plexus-utils

2023-11-14 Thread ASF GitHub Bot (Jira)


[ 
https://issues.apache.org/jira/browse/MNG-5378?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17785960#comment-17785960
 ] 

ASF GitHub Bot commented on MNG-5378:
-

jaredstehler opened a new pull request, #1304:
URL: https://github.com/apache/maven/pull/1304

   This adds a mechanism for setting a strict artifact descriptor policy, via a 
boolean config property: `aether.artifactDescriptorPolicy.strict`.
   
   
   Following this checklist to help us incorporate your
   contribution quickly and easily:
   
- [ ] Make sure there is a [JIRA 
issue](https://issues.apache.org/jira/browse/MNG) filed
  for the change (usually before you start working on it).  Trivial 
changes like typos do not
  require a JIRA issue. Your pull request should address just this 
issue, without
  pulling in other changes.
- [ ] Each commit in the pull request should have a meaningful subject line 
and body.
- [ ] Format the pull request title like `[MNG-XXX] SUMMARY`,
  where you replace `MNG-XXX` and `SUMMARY` with the appropriate JIRA 
issue.
- [ ] Also format the first line of the commit message like `[MNG-XXX] 
SUMMARY`.
  Best practice is to use the JIRA issue title in both the pull request 
title and in the first line of the commit message.
- [ ] Write a pull request description that is detailed enough to 
understand what the pull request does, how, and why.
- [ ] Run `mvn clean verify` to make sure basic checks pass. A more 
thorough check will
  be performed on your pull request automatically.
- [ ] You have run the [Core IT][core-its] successfully.
   
   If your pull request is about ~20 lines of code you don't need to sign an
   [Individual Contributor License 
Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure
   please ask on the developers list.
   
   To make clear that you license your contribution under
   the [Apache License Version 2.0, January 
2004](http://www.apache.org/licenses/LICENSE-2.0)
   you have to acknowledge this by using the following check-box.
   
- [ ] I hereby declare this contribution to be licenced under the [Apache 
License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
   
- [ ] In any other case, please file an [Apache Individual Contributor 
License Agreement](https://www.apache.org/licenses/icla.pdf).
   
   [core-its]: https://maven.apache.org/core-its/core-it-suite/
   




> Use maven-shared-utils in Maven core to replace plexus-utils
> 
>
> Key: MNG-5378
> URL: https://issues.apache.org/jira/browse/MNG-5378
> Project: Maven
>  Issue Type: Task
>Reporter: Jason van Zyl
>Priority: Major
>
> see http://maven.apache.org/shared/maven-shared-utils/ for the rationale



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[PR] [MNG-5378] configure strict artifact descriptor policy via property [maven]

2023-11-14 Thread via GitHub


jaredstehler opened a new pull request, #1304:
URL: https://github.com/apache/maven/pull/1304

   This adds a mechanism for setting a strict artifact descriptor policy, via a 
boolean config property: `aether.artifactDescriptorPolicy.strict`.
   
   
   Following this checklist to help us incorporate your
   contribution quickly and easily:
   
- [ ] Make sure there is a [JIRA 
issue](https://issues.apache.org/jira/browse/MNG) filed
  for the change (usually before you start working on it).  Trivial 
changes like typos do not
  require a JIRA issue. Your pull request should address just this 
issue, without
  pulling in other changes.
- [ ] Each commit in the pull request should have a meaningful subject line 
and body.
- [ ] Format the pull request title like `[MNG-XXX] SUMMARY`,
  where you replace `MNG-XXX` and `SUMMARY` with the appropriate JIRA 
issue.
- [ ] Also format the first line of the commit message like `[MNG-XXX] 
SUMMARY`.
  Best practice is to use the JIRA issue title in both the pull request 
title and in the first line of the commit message.
- [ ] Write a pull request description that is detailed enough to 
understand what the pull request does, how, and why.
- [ ] Run `mvn clean verify` to make sure basic checks pass. A more 
thorough check will
  be performed on your pull request automatically.
- [ ] You have run the [Core IT][core-its] successfully.
   
   If your pull request is about ~20 lines of code you don't need to sign an
   [Individual Contributor License 
Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure
   please ask on the developers list.
   
   To make clear that you license your contribution under
   the [Apache License Version 2.0, January 
2004](http://www.apache.org/licenses/LICENSE-2.0)
   you have to acknowledge this by using the following check-box.
   
- [ ] I hereby declare this contribution to be licenced under the [Apache 
License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
   
- [ ] In any other case, please file an [Apache Individual Contributor 
License Agreement](https://www.apache.org/licenses/icla.pdf).
   
   [core-its]: https://maven.apache.org/core-its/core-it-suite/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[jira] [Commented] (MNG-5378) Use maven-shared-utils in Maven core to replace plexus-utils

2023-11-14 Thread ASF GitHub Bot (Jira)


[ 
https://issues.apache.org/jira/browse/MNG-5378?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17785959#comment-17785959
 ] 

ASF GitHub Bot commented on MNG-5378:
-

jaredstehler closed pull request #1303: [MNG-5378] configure strict artifact 
descriptor policy with property
URL: https://github.com/apache/maven/pull/1303




> Use maven-shared-utils in Maven core to replace plexus-utils
> 
>
> Key: MNG-5378
> URL: https://issues.apache.org/jira/browse/MNG-5378
> Project: Maven
>  Issue Type: Task
>Reporter: Jason van Zyl
>Priority: Major
>
> see http://maven.apache.org/shared/maven-shared-utils/ for the rationale



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


Re: [PR] [MNG-5378] configure strict artifact descriptor policy with property [maven]

2023-11-14 Thread via GitHub


jaredstehler closed pull request #1303: [MNG-5378] configure strict artifact 
descriptor policy with property
URL: https://github.com/apache/maven/pull/1303


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[jira] [Updated] (MJAVADOC-780) Unit tests create null-null.jar in build root directory

2023-11-14 Thread Herve Boutemy (Jira)


 [ 
https://issues.apache.org/jira/browse/MJAVADOC-780?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Herve Boutemy updated MJAVADOC-780:
---
Description: 
{noformat}[INFO] Running org.apache.maven.plugins.javadoc.JavadocJarTest
[main] INFO org.codehaus.plexus.archiver.jar.JarArchiver - Building jar: 
/tmp/sources/plugins/reporting/maven-javadoc-plugin/target/test/unit/javadocjar-default/target/javadocjar-default-javadoc.jar
[main] INFO org.codehaus.plexus.archiver.jar.JarArchiver - Building jar: 
/tmp/sources/plugins/reporting/maven-javadoc-plugin/null-null.jar
[main] INFO org.codehaus.plexus.archiver.jar.JarArchiver - Building jar: 
/tmp/sources/plugins/reporting/maven-javadoc-plugin/null-null.jar
{noformat}


  was:
{noformat}
[main] INFO org.codehaus.plexus.archiver.jar.JarArchiver - Building jar: 
/tmp/maven-javadoc-plugin/null-null.jar
[main] INFO org.codehaus.plexus.archiver.jar.JarArchiver - Building jar: 
/tmp/maven-javadoc-plugin/null-null.jar
{noformat}
During JavadocJarTest


> Unit tests create null-null.jar in build root directory
> ---
>
> Key: MJAVADOC-780
> URL: https://issues.apache.org/jira/browse/MJAVADOC-780
> Project: Maven Javadoc Plugin
>  Issue Type: Bug
>Affects Versions: 3.6.2
>Reporter: Herve Boutemy
>Priority: Major
> Fix For: 3.6.3
>
>
> {noformat}[INFO] Running org.apache.maven.plugins.javadoc.JavadocJarTest
> [main] INFO org.codehaus.plexus.archiver.jar.JarArchiver - Building jar: 
> /tmp/sources/plugins/reporting/maven-javadoc-plugin/target/test/unit/javadocjar-default/target/javadocjar-default-javadoc.jar
> [main] INFO org.codehaus.plexus.archiver.jar.JarArchiver - Building jar: 
> /tmp/sources/plugins/reporting/maven-javadoc-plugin/null-null.jar
> [main] INFO org.codehaus.plexus.archiver.jar.JarArchiver - Building jar: 
> /tmp/sources/plugins/reporting/maven-javadoc-plugin/null-null.jar
> {noformat}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (MNG-5378) Use maven-shared-utils in Maven core to replace plexus-utils

2023-11-14 Thread ASF GitHub Bot (Jira)


[ 
https://issues.apache.org/jira/browse/MNG-5378?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17785953#comment-17785953
 ] 

ASF GitHub Bot commented on MNG-5378:
-

jaredstehler opened a new pull request, #1303:
URL: https://github.com/apache/maven/pull/1303

   This adds a mechanism for setting a strict artifact descriptor policy, via a 
config property.
   
   Following this checklist to help us incorporate your
   contribution quickly and easily:
   
- [ ] Make sure there is a [JIRA 
issue](https://issues.apache.org/jira/browse/MNG) filed
  for the change (usually before you start working on it).  Trivial 
changes like typos do not
  require a JIRA issue. Your pull request should address just this 
issue, without
  pulling in other changes.
- [ ] Each commit in the pull request should have a meaningful subject line 
and body.
- [ ] Format the pull request title like `[MNG-XXX] SUMMARY`,
  where you replace `MNG-XXX` and `SUMMARY` with the appropriate JIRA 
issue.
- [ ] Also format the first line of the commit message like `[MNG-XXX] 
SUMMARY`.
  Best practice is to use the JIRA issue title in both the pull request 
title and in the first line of the commit message.
- [ ] Write a pull request description that is detailed enough to 
understand what the pull request does, how, and why.
- [ ] Run `mvn clean verify` to make sure basic checks pass. A more 
thorough check will
  be performed on your pull request automatically.
- [ ] You have run the [Core IT][core-its] successfully.
   
   If your pull request is about ~20 lines of code you don't need to sign an
   [Individual Contributor License 
Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure
   please ask on the developers list.
   
   To make clear that you license your contribution under
   the [Apache License Version 2.0, January 
2004](http://www.apache.org/licenses/LICENSE-2.0)
   you have to acknowledge this by using the following check-box.
   
- [ ] I hereby declare this contribution to be licenced under the [Apache 
License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
   
- [ ] In any other case, please file an [Apache Individual Contributor 
License Agreement](https://www.apache.org/licenses/icla.pdf).
   
   [core-its]: https://maven.apache.org/core-its/core-it-suite/
   




> Use maven-shared-utils in Maven core to replace plexus-utils
> 
>
> Key: MNG-5378
> URL: https://issues.apache.org/jira/browse/MNG-5378
> Project: Maven
>  Issue Type: Task
>Reporter: Jason van Zyl
>Priority: Major
>
> see http://maven.apache.org/shared/maven-shared-utils/ for the rationale



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[PR] [MNG-5378] configure strict artifact descriptor policy with property [maven]

2023-11-14 Thread via GitHub


jaredstehler opened a new pull request, #1303:
URL: https://github.com/apache/maven/pull/1303

   This adds a mechanism for setting a strict artifact descriptor policy, via a 
config property.
   
   Following this checklist to help us incorporate your
   contribution quickly and easily:
   
- [ ] Make sure there is a [JIRA 
issue](https://issues.apache.org/jira/browse/MNG) filed
  for the change (usually before you start working on it).  Trivial 
changes like typos do not
  require a JIRA issue. Your pull request should address just this 
issue, without
  pulling in other changes.
- [ ] Each commit in the pull request should have a meaningful subject line 
and body.
- [ ] Format the pull request title like `[MNG-XXX] SUMMARY`,
  where you replace `MNG-XXX` and `SUMMARY` with the appropriate JIRA 
issue.
- [ ] Also format the first line of the commit message like `[MNG-XXX] 
SUMMARY`.
  Best practice is to use the JIRA issue title in both the pull request 
title and in the first line of the commit message.
- [ ] Write a pull request description that is detailed enough to 
understand what the pull request does, how, and why.
- [ ] Run `mvn clean verify` to make sure basic checks pass. A more 
thorough check will
  be performed on your pull request automatically.
- [ ] You have run the [Core IT][core-its] successfully.
   
   If your pull request is about ~20 lines of code you don't need to sign an
   [Individual Contributor License 
Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure
   please ask on the developers list.
   
   To make clear that you license your contribution under
   the [Apache License Version 2.0, January 
2004](http://www.apache.org/licenses/LICENSE-2.0)
   you have to acknowledge this by using the following check-box.
   
- [ ] I hereby declare this contribution to be licenced under the [Apache 
License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
   
- [ ] In any other case, please file an [Apache Individual Contributor 
License Agreement](https://www.apache.org/licenses/icla.pdf).
   
   [core-its]: https://maven.apache.org/core-its/core-it-suite/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[jira] [Created] (MNG-7933) Artifact descriptor policy should be configurable

2023-11-14 Thread Jared Stehler (Jira)
Jared Stehler created MNG-7933:
--

 Summary: Artifact descriptor policy should be configurable
 Key: MNG-7933
 URL: https://issues.apache.org/jira/browse/MNG-7933
 Project: Maven
  Issue Type: Improvement
  Components: Artifacts and Repositories, Core
Reporter: Jared Stehler


I wasn't able to find any way to configure a different artifact descriptor 
policy; ideally this would be doable via a config property.

[https://github.com/search?q=repo%3Aapache/maven%20setArtifactDescriptorPolicy&type=code]

 



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Updated] (MJAVADOC-780) Unit tests create null-null.jar in build root directory

2023-11-14 Thread Herve Boutemy (Jira)


 [ 
https://issues.apache.org/jira/browse/MJAVADOC-780?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Herve Boutemy updated MJAVADOC-780:
---
Description: 
{noformat}
[main] INFO org.codehaus.plexus.archiver.jar.JarArchiver - Building jar: 
/tmp/maven-javadoc-plugin/null-null.jar
[main] INFO org.codehaus.plexus.archiver.jar.JarArchiver - Building jar: 
/tmp/maven-javadoc-plugin/null-null.jar
{noformat}
During JavadocJarTest

  was:
{noformat}
[main] INFO org.codehaus.plexus.archiver.jar.JarArchiver - Building jar: 
/tmp/maven-javadoc-plugin/null-null.jar
[main] INFO org.codehaus.plexus.archiver.jar.JarArchiver - Building jar: 
/tmp/maven-javadoc-plugin/null-null.jar
10:17
{noformat}
During JavadocJarTest


> Unit tests create null-null.jar in build root directory
> ---
>
> Key: MJAVADOC-780
> URL: https://issues.apache.org/jira/browse/MJAVADOC-780
> Project: Maven Javadoc Plugin
>  Issue Type: Bug
>Affects Versions: 3.6.2
>Reporter: Herve Boutemy
>Priority: Major
> Fix For: 3.6.3
>
>
> {noformat}
> [main] INFO org.codehaus.plexus.archiver.jar.JarArchiver - Building jar: 
> /tmp/maven-javadoc-plugin/null-null.jar
> [main] INFO org.codehaus.plexus.archiver.jar.JarArchiver - Building jar: 
> /tmp/maven-javadoc-plugin/null-null.jar
> {noformat}
> During JavadocJarTest



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Created] (MJAVADOC-780) Unit tests create null-null.jar in build root directory

2023-11-14 Thread Herve Boutemy (Jira)
Herve Boutemy created MJAVADOC-780:
--

 Summary: Unit tests create null-null.jar in build root directory
 Key: MJAVADOC-780
 URL: https://issues.apache.org/jira/browse/MJAVADOC-780
 Project: Maven Javadoc Plugin
  Issue Type: Bug
Affects Versions: 3.6.2
Reporter: Herve Boutemy
 Fix For: 3.6.3


{noformat}
[main] INFO org.codehaus.plexus.archiver.jar.JarArchiver - Building jar: 
/tmp/maven-javadoc-plugin/null-null.jar
[main] INFO org.codehaus.plexus.archiver.jar.JarArchiver - Building jar: 
/tmp/maven-javadoc-plugin/null-null.jar
10:17
{noformat}
During JavadocJarTest



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Updated] (MNG-6026) Extend the Project Object Model (POM) with trust information (OpenPGP, hash values)

2023-11-14 Thread Florian Schmaus (Jira)


 [ 
https://issues.apache.org/jira/browse/MNG-6026?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Florian Schmaus updated MNG-6026:
-
Description: 
The origin of this feature request is the Stackoverflow question ["Verification 
of dependency authenticity in Maven POM based automated build 
systems"|http://stackoverflow.com/a/34795359/194894], and [especially a SO user 
requesting me to put this 
up|http://stackoverflow.com/questions/3307146/verification-of-dependency-authenticy-in-maven-pom-based-automated-build-systems/34795359?noredirect=1#comment62178671_34795359].
h2. Extend the Project Object Model (POM) with trust information (OpenPGP - RFC 
4480 and hash values)

What we need is the possibility to model a trust relation from your project or 
artifact to the declared dependencies. So that, if all involved parties declare 
such a relation, we are able to create a "chain of trust" from the root (e.g. 
the project) over its dependencies down to the very last transitive dependency. 
The Project Object Model (POM) needs to be extended by a  
element for dependencies.
h3. Current Situation

Right now we have something like
{code:xml}

  junit
  junit
  4.0

{code}
h3. Hard dependencies

For hard dependencies,  could include the sha256sum of artifact 
and its POM file:
{code:xml}

  junit
  junit
  [4.0]
  

  [sha256 of junit pom file]
  [sha256sum of artifact (junit.jar)]

  

{code}
h3. Soft dependencies

If soft, which are also called "ranged" or "dynamic", dependencies are used, 
then we could specify the public key (or multiple) of the keypair used to sign 
the artifacts
{code:xml}

  junit
  junit
  [4.0,4.5)
  
[secure fingerprint of OpenPGP key used to sign the junit 
artifact(s)]

  

{code}

I'm not sure if this is the right place to raise an feature request for the POM 
format itself. I've already tried to get in touch with the right people about 
this feature request, but failed. I'm willing to help designing and 
implementing this, but need guidance.

  was:
The origin of this feature request is the Stackoverflow question ["Verification 
of dependency authenticity in Maven POM based automated build 
systems"|http://stackoverflow.com/a/34795359/194894], and [especially a SO user 
requesting me to put this 
up|http://stackoverflow.com/questions/3307146/verification-of-dependency-authenticy-in-maven-pom-based-automated-build-systems/34795359?noredirect=1#comment62178671_34795359].
h2. Extend the Project Object Model (POM) with trust information (OpenPGP - RFC 
4480 and hash values)

What we need is the possibility to model a trust relation from your project or 
artifact to the declared dependencies. So that, if all involved parties declare 
such a relation, we are able to create a "chain of trust" from the root (e.g. 
the project) over its dependencies down to the very last transitive dependency. 
The Project Object Model (POM) needs to be extended by a  
element for dependencies.
h3. Current Situation

Right now we have something like
{code:xml}

  junit
  junit
  4.0

{code}
h3. Hard dependencies

For hard dependencies,  could include the sha256sum of artifact 
and its POM file:
{code:xml}

  junit
  junit
  [4.0]
  

  [sha256 of junit pom file]
  [sha256sum of artifact (junit.jar)]

  

{code}
h3. Soft dependencies

If soft. also called "ranged" or "dynamic", dependencies are used, then we 
could specify the public key (or multiple) of the keypair used to sign the 
artifacts
{code:xml}

  junit
  junit
  [4.0,4.5)
  
[secure fingerprint of OpenPGP key used to sign the junit 
artifact(s)]

  

{code}

I'm not sure if this is the right place to raise an feature request for the POM 
format itself. I've already tried to get in touch with the right people about 
this feature request, but failed. I'm willing to help designing and 
implementing this, but need guidance.


> Extend the Project Object Model (POM) with trust information (OpenPGP, hash 
> values)
> ---
>
> Key: MNG-6026
> URL: https://issues.apache.org/jira/browse/MNG-6026
> Project: Maven
>  Issue Type: New Feature
>  Components: Core
>Reporter: Florian Schmaus
>Priority: Major
>  Labels: artifact-verification, security
>
> The origin of this feature request is the Stackoverflow question 
> ["Verification of dependency authenticity in Maven POM based automated build 
> systems"|http://stackoverflow.com/a/34795359/194894], and [especially a SO 
> user requesting me to put this 
> up|http://stackoverflow.com/questions/3307146/verification-of-dependency-authenticy-in-maven-pom-based-automated-build-systems/34795359?noredirect=1#comment62178671_34795359].
> h2. Extend the Project Object Model (POM) with trust information (OpenPGP - 
> RFC 4480 and hash val

[jira] [Updated] (MSITE-990) org.eclipse.jetty.util.MultiException: Multiple exceptions

2023-11-14 Thread Michael Osipov (Jira)


 [ 
https://issues.apache.org/jira/browse/MSITE-990?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Michael Osipov updated MSITE-990:
-
Fix Version/s: waiting-for-feedback

> org.eclipse.jetty.util.MultiException: Multiple exceptions
> --
>
> Key: MSITE-990
> URL: https://issues.apache.org/jira/browse/MSITE-990
> Project: Maven Site Plugin
>  Issue Type: Bug
>  Components: site:run
>Affects Versions: 3.12.1
> Environment: Windows 10 and git bash
>Reporter: mikael petterson
>Priority: Major
> Fix For: waiting-for-feedback
>
>
>  mvn --version
> Apache Maven 3.8.5 (3599d3414f046de2324203b78ddcf9b5e4388aa0)
> Maven home: C:\apache-maven-3.8.5
> Java version: 17.0.6, vendor: Azul Systems, Inc., runtime: C:\Program 
> Files\Zulu\zulu-17
> Default locale: en_US, platform encoding: Cp1252
> OS name: "windows 10", version: "10.0", arch: "amd64", family: "windows"
>  
> When trying to run:
> mvn site:run
> {code:java}
> [INFO] jetty-9.4.46.v20220331; built: 2022-03-31T16:38:08.030Z; git: 
> bc17a0369a11ecf40bb92c839b9ef0a8ac50ea18; jvm 17.0.6+10-LTS
> [INFO] NO JSP Support for /, did not find 
> org.eclipse.jetty.jsp.JettyJspServlet
> [INFO] DefaultSessionIdManager workerName=node0
> [INFO] No SessionScavenger set, using defaults
> [INFO] node0 Scavenging every 66ms
> [WARNING] Failed startup of context 
> o.e.j.w.WebAppContext@64d42d3d{/,file:///C:/Users/userid/git/my-app/target/site-webapp/,UNAVAILABLE}
> org.eclipse.jetty.util.MultiException: Multiple exceptions
>     at org.eclipse.jetty.util.MultiException.ifExceptionThrow 
> (MultiException.java:122)
>     at org.eclipse.jetty.servlet.ServletHandler.initialize 
> (ServletHandler.java:757)
>     at org.eclipse.jetty.servlet.ServletContextHandler.startContext 
> (ServletContextHandler.java:379)
>     at org.eclipse.jetty.webapp.WebAppContext.startWebapp 
> (WebAppContext.java:1449)
>     at org.eclipse.jetty.webapp.WebAppContext.startContext 
> (WebAppContext.java:1414)
>     at org.eclipse.jetty.server.handler.ContextHandler.doStart 
> (ContextHandler.java:916)
>     at org.eclipse.jetty.servlet.ServletContextHandler.doStart 
> (ServletContextHandler.java:288)
>     at org.eclipse.jetty.webapp.WebAppContext.doStart (WebAppContext.java:524)
>     at org.eclipse.jetty.util.component.AbstractLifeCycle.start 
> (AbstractLifeCycle.java:73)
>     at org.eclipse.jetty.util.component.ContainerLifeCycle.start 
> (ContainerLifeCycle.java:169)
>     at org.eclipse.jetty.server.Server.start (Server.java:423)
>     at org.eclipse.jetty.util.component.ContainerLifeCycle.doStart 
> (ContainerLifeCycle.java:110)
>     at org.eclipse.jetty.server.handler.AbstractHandler.doStart 
> (AbstractHandler.java:97)
>     at org.eclipse.jetty.server.Server.doStart (Server.java:387)
>     at org.eclipse.jetty.util.component.AbstractLifeCycle.start 
> (AbstractLifeCycle.java:73)
>     at org.apache.maven.plugins.site.run.SiteRunMojo.execute 
> (SiteRunMojo.java:87)
>     at org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo 
> (DefaultBuildPluginManager.java:137)
>     at org.apache.maven.lifecycle.internal.MojoExecutor.doExecute 
> (MojoExecutor.java:301)
>     at org.apache.maven.lifecycle.internal.MojoExecutor.execute 
> (MojoExecutor.java:211)
>     at org.apache.maven.lifecycle.internal.MojoExecutor.execute 
> (MojoExecutor.java:165)
>     at org.apache.maven.lifecycle.internal.MojoExecutor.execute 
> (MojoExecutor.java:157)
>     at 
> org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject 
> (LifecycleModuleBuilder.java:121)
>     at 
> org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject 
> (LifecycleModuleBuilder.java:81)
>     at 
> org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.build
>  (SingleThreadedBuilder.java:56)
>     at org.apache.maven.lifecycle.internal.LifecycleStarter.execute 
> (LifecycleStarter.java:127)
>     at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:294)
>     at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:192)
>     at org.apache.maven.DefaultMaven.execute (DefaultMaven.java:105)
>     at org.apache.maven.cli.MavenCli.execute (MavenCli.java:960)
>     at org.apache.maven.cli.MavenCli.doMain (MavenCli.java:293)
>     at org.apache.maven.cli.MavenCli.main (MavenCli.java:196)
>     at jdk.internal.reflect.NativeMethodAccessorImpl.invoke0 (Native Method)
>     at jdk.internal.reflect.NativeMethodAccessorImpl.invoke 
> (NativeMethodAccessorImpl.java:77)
>     at jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke 
> (DelegatingMethodAccessorImpl.java:43)
>     at java.lang.reflect.Method.invoke (Method.java:568)
>     at org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced 
> (Launcher.java:282)
>     at org.

[jira] [Commented] (MSITE-990) org.eclipse.jetty.util.MultiException: Multiple exceptions

2023-11-14 Thread Michael Osipov (Jira)


[ 
https://issues.apache.org/jira/browse/MSITE-990?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17785942#comment-17785942
 ] 

Michael Osipov commented on MSITE-990:
--

Please provide {{mvn -X site:run}}...

> org.eclipse.jetty.util.MultiException: Multiple exceptions
> --
>
> Key: MSITE-990
> URL: https://issues.apache.org/jira/browse/MSITE-990
> Project: Maven Site Plugin
>  Issue Type: Bug
>  Components: site:run
>Affects Versions: 3.12.1
> Environment: Windows 10 and git bash
>Reporter: mikael petterson
>Priority: Major
>
>  mvn --version
> Apache Maven 3.8.5 (3599d3414f046de2324203b78ddcf9b5e4388aa0)
> Maven home: C:\apache-maven-3.8.5
> Java version: 17.0.6, vendor: Azul Systems, Inc., runtime: C:\Program 
> Files\Zulu\zulu-17
> Default locale: en_US, platform encoding: Cp1252
> OS name: "windows 10", version: "10.0", arch: "amd64", family: "windows"
>  
> When trying to run:
> mvn site:run
> {code:java}
> [INFO] jetty-9.4.46.v20220331; built: 2022-03-31T16:38:08.030Z; git: 
> bc17a0369a11ecf40bb92c839b9ef0a8ac50ea18; jvm 17.0.6+10-LTS
> [INFO] NO JSP Support for /, did not find 
> org.eclipse.jetty.jsp.JettyJspServlet
> [INFO] DefaultSessionIdManager workerName=node0
> [INFO] No SessionScavenger set, using defaults
> [INFO] node0 Scavenging every 66ms
> [WARNING] Failed startup of context 
> o.e.j.w.WebAppContext@64d42d3d{/,file:///C:/Users/userid/git/my-app/target/site-webapp/,UNAVAILABLE}
> org.eclipse.jetty.util.MultiException: Multiple exceptions
>     at org.eclipse.jetty.util.MultiException.ifExceptionThrow 
> (MultiException.java:122)
>     at org.eclipse.jetty.servlet.ServletHandler.initialize 
> (ServletHandler.java:757)
>     at org.eclipse.jetty.servlet.ServletContextHandler.startContext 
> (ServletContextHandler.java:379)
>     at org.eclipse.jetty.webapp.WebAppContext.startWebapp 
> (WebAppContext.java:1449)
>     at org.eclipse.jetty.webapp.WebAppContext.startContext 
> (WebAppContext.java:1414)
>     at org.eclipse.jetty.server.handler.ContextHandler.doStart 
> (ContextHandler.java:916)
>     at org.eclipse.jetty.servlet.ServletContextHandler.doStart 
> (ServletContextHandler.java:288)
>     at org.eclipse.jetty.webapp.WebAppContext.doStart (WebAppContext.java:524)
>     at org.eclipse.jetty.util.component.AbstractLifeCycle.start 
> (AbstractLifeCycle.java:73)
>     at org.eclipse.jetty.util.component.ContainerLifeCycle.start 
> (ContainerLifeCycle.java:169)
>     at org.eclipse.jetty.server.Server.start (Server.java:423)
>     at org.eclipse.jetty.util.component.ContainerLifeCycle.doStart 
> (ContainerLifeCycle.java:110)
>     at org.eclipse.jetty.server.handler.AbstractHandler.doStart 
> (AbstractHandler.java:97)
>     at org.eclipse.jetty.server.Server.doStart (Server.java:387)
>     at org.eclipse.jetty.util.component.AbstractLifeCycle.start 
> (AbstractLifeCycle.java:73)
>     at org.apache.maven.plugins.site.run.SiteRunMojo.execute 
> (SiteRunMojo.java:87)
>     at org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo 
> (DefaultBuildPluginManager.java:137)
>     at org.apache.maven.lifecycle.internal.MojoExecutor.doExecute 
> (MojoExecutor.java:301)
>     at org.apache.maven.lifecycle.internal.MojoExecutor.execute 
> (MojoExecutor.java:211)
>     at org.apache.maven.lifecycle.internal.MojoExecutor.execute 
> (MojoExecutor.java:165)
>     at org.apache.maven.lifecycle.internal.MojoExecutor.execute 
> (MojoExecutor.java:157)
>     at 
> org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject 
> (LifecycleModuleBuilder.java:121)
>     at 
> org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject 
> (LifecycleModuleBuilder.java:81)
>     at 
> org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.build
>  (SingleThreadedBuilder.java:56)
>     at org.apache.maven.lifecycle.internal.LifecycleStarter.execute 
> (LifecycleStarter.java:127)
>     at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:294)
>     at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:192)
>     at org.apache.maven.DefaultMaven.execute (DefaultMaven.java:105)
>     at org.apache.maven.cli.MavenCli.execute (MavenCli.java:960)
>     at org.apache.maven.cli.MavenCli.doMain (MavenCli.java:293)
>     at org.apache.maven.cli.MavenCli.main (MavenCli.java:196)
>     at jdk.internal.reflect.NativeMethodAccessorImpl.invoke0 (Native Method)
>     at jdk.internal.reflect.NativeMethodAccessorImpl.invoke 
> (NativeMethodAccessorImpl.java:77)
>     at jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke 
> (DelegatingMethodAccessorImpl.java:43)
>     at java.lang.reflect.Method.invoke (Method.java:568)
>     at org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced 
> (Launcher.java:282)
>  

[jira] [Updated] (MSITE-990) org.eclipse.jetty.util.MultiException: Multiple exceptions

2023-11-14 Thread mikael petterson (Jira)


 [ 
https://issues.apache.org/jira/browse/MSITE-990?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

mikael petterson updated MSITE-990:
---
Description: 
 mvn --version
Apache Maven 3.8.5 (3599d3414f046de2324203b78ddcf9b5e4388aa0)
Maven home: C:\apache-maven-3.8.5
Java version: 17.0.6, vendor: Azul Systems, Inc., runtime: C:\Program 
Files\Zulu\zulu-17
Default locale: en_US, platform encoding: Cp1252
OS name: "windows 10", version: "10.0", arch: "amd64", family: "windows"

 

When trying to run:

mvn site:run
{code:java}
[INFO] jetty-9.4.46.v20220331; built: 2022-03-31T16:38:08.030Z; git: 
bc17a0369a11ecf40bb92c839b9ef0a8ac50ea18; jvm 17.0.6+10-LTS
[INFO] NO JSP Support for /, did not find org.eclipse.jetty.jsp.JettyJspServlet
[INFO] DefaultSessionIdManager workerName=node0
[INFO] No SessionScavenger set, using defaults
[INFO] node0 Scavenging every 66ms
[WARNING] Failed startup of context 
o.e.j.w.WebAppContext@64d42d3d{/,file:///C:/Users/userid/git/my-app/target/site-webapp/,UNAVAILABLE}
org.eclipse.jetty.util.MultiException: Multiple exceptions
    at org.eclipse.jetty.util.MultiException.ifExceptionThrow 
(MultiException.java:122)
    at org.eclipse.jetty.servlet.ServletHandler.initialize 
(ServletHandler.java:757)
    at org.eclipse.jetty.servlet.ServletContextHandler.startContext 
(ServletContextHandler.java:379)
    at org.eclipse.jetty.webapp.WebAppContext.startWebapp 
(WebAppContext.java:1449)
    at org.eclipse.jetty.webapp.WebAppContext.startContext 
(WebAppContext.java:1414)
    at org.eclipse.jetty.server.handler.ContextHandler.doStart 
(ContextHandler.java:916)
    at org.eclipse.jetty.servlet.ServletContextHandler.doStart 
(ServletContextHandler.java:288)
    at org.eclipse.jetty.webapp.WebAppContext.doStart (WebAppContext.java:524)
    at org.eclipse.jetty.util.component.AbstractLifeCycle.start 
(AbstractLifeCycle.java:73)
    at org.eclipse.jetty.util.component.ContainerLifeCycle.start 
(ContainerLifeCycle.java:169)
    at org.eclipse.jetty.server.Server.start (Server.java:423)
    at org.eclipse.jetty.util.component.ContainerLifeCycle.doStart 
(ContainerLifeCycle.java:110)
    at org.eclipse.jetty.server.handler.AbstractHandler.doStart 
(AbstractHandler.java:97)
    at org.eclipse.jetty.server.Server.doStart (Server.java:387)
    at org.eclipse.jetty.util.component.AbstractLifeCycle.start 
(AbstractLifeCycle.java:73)
    at org.apache.maven.plugins.site.run.SiteRunMojo.execute 
(SiteRunMojo.java:87)
    at org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo 
(DefaultBuildPluginManager.java:137)
    at org.apache.maven.lifecycle.internal.MojoExecutor.doExecute 
(MojoExecutor.java:301)
    at org.apache.maven.lifecycle.internal.MojoExecutor.execute 
(MojoExecutor.java:211)
    at org.apache.maven.lifecycle.internal.MojoExecutor.execute 
(MojoExecutor.java:165)
    at org.apache.maven.lifecycle.internal.MojoExecutor.execute 
(MojoExecutor.java:157)
    at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject 
(LifecycleModuleBuilder.java:121)
    at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject 
(LifecycleModuleBuilder.java:81)
    at 
org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.build
 (SingleThreadedBuilder.java:56)
    at org.apache.maven.lifecycle.internal.LifecycleStarter.execute 
(LifecycleStarter.java:127)
    at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:294)
    at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:192)
    at org.apache.maven.DefaultMaven.execute (DefaultMaven.java:105)
    at org.apache.maven.cli.MavenCli.execute (MavenCli.java:960)
    at org.apache.maven.cli.MavenCli.doMain (MavenCli.java:293)
    at org.apache.maven.cli.MavenCli.main (MavenCli.java:196)
    at jdk.internal.reflect.NativeMethodAccessorImpl.invoke0 (Native Method)
    at jdk.internal.reflect.NativeMethodAccessorImpl.invoke 
(NativeMethodAccessorImpl.java:77)
    at jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke 
(DelegatingMethodAccessorImpl.java:43)
    at java.lang.reflect.Method.invoke (Method.java:568)
    at org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced 
(Launcher.java:282)
    at org.codehaus.plexus.classworlds.launcher.Launcher.launch 
(Launcher.java:225)
    at org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode 
(Launcher.java:406)
    at org.codehaus.plexus.classworlds.launcher.Launcher.main 
(Launcher.java:347)
Caused by: java.lang.NoSuchMethodError: 'javax.servlet.Filter 
javax.servlet.ServletContext.createFilter(java.lang.Class)'
    at org.eclipse.jetty.servlet.FilterHolder.initialize (FilterHolder.java:123)
    at org.eclipse.jetty.servlet.ServletHandler.lambda$initialize$0 
(ServletHandler.java:731)
    at java.util.Spliterators$ArraySpliterator.forEachRemaining 
(Spliterators.java:992)
    at java.util.stream.Streams$ConcatSpliterator.forEachRemaining 
(Stre

[jira] [Created] (MSITE-990) org.eclipse.jetty.util.MultiException: Multiple exceptions

2023-11-14 Thread mikael petterson (Jira)
mikael petterson created MSITE-990:
--

 Summary: org.eclipse.jetty.util.MultiException: Multiple exceptions
 Key: MSITE-990
 URL: https://issues.apache.org/jira/browse/MSITE-990
 Project: Maven Site Plugin
  Issue Type: Bug
  Components: site:run
Affects Versions: 3.12.1
 Environment: Windows 10 and git bash
Reporter: mikael petterson


When trying to run:

mvn site:site

INFO] Starting Jetty on http://localhost:8080/ [INFO] jetty-9.4.46.v20220331; 
built: 2022-03-31T16:38:08.030Z; git: bc17a0369a11ecf40bb92c839b9ef0a8ac50ea18; 
jvm 17.0.6+10-LTS [INFO] NO JSP Support for /, did not find 
org.eclipse.jetty.jsp.JettyJspServlet [INFO] DefaultSessionIdManager 
workerName=node0 [INFO] No SessionScavenger set, using defaults [INFO] node0 
Scavenging every 66ms [WARNING] Failed startup of context 
o.e.j.w.WebAppContext@64d42d3d\{/,file:///C:/Users/userid/git/my-app/target/site-webapp/,UNAVAILABLE}
 org.eclipse.jetty.util.MultiException: Multiple exceptions     at 
org.eclipse.jetty.util.MultiException.ifExceptionThrow 
(MultiException.java:122)     at 
org.eclipse.jetty.servlet.ServletHandler.initialize (ServletHandler.java:757)   
  at org.eclipse.jetty.servlet.ServletContextHandler.startContext 
(ServletContextHandler.java:379)     at 
org.eclipse.jetty.webapp.WebAppContext.startWebapp (WebAppContext.java:1449)    
 at org.eclipse.jetty.webapp.WebAppContext.startContext 
(WebAppContext.java:1414)     at 
org.eclipse.jetty.server.handler.ContextHandler.doStart 
(ContextHandler.java:916)     at 
org.eclipse.jetty.servlet.ServletContextHandler.doStart 
(ServletContextHandler.java:288)     at 
org.eclipse.jetty.webapp.WebAppContext.doStart (WebAppContext.java:524)     at 
org.eclipse.jetty.util.component.AbstractLifeCycle.start 
(AbstractLifeCycle.java:73)     at 
org.eclipse.jetty.util.component.ContainerLifeCycle.start 
(ContainerLifeCycle.java:169)     at org.eclipse.jetty.server.Server.start 
(Server.java:423)     at 
org.eclipse.jetty.util.component.ContainerLifeCycle.doStart 
(ContainerLifeCycle.java:110)     at 
org.eclipse.jetty.server.handler.AbstractHandler.doStart 
(AbstractHandler.java:97)     at org.eclipse.jetty.server.Server.doStart 
(Server.java:387)     at 
org.eclipse.jetty.util.component.AbstractLifeCycle.start 
(AbstractLifeCycle.java:73)     at 
org.apache.maven.plugins.site.run.SiteRunMojo.execute (SiteRunMojo.java:87)     
at org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo 
(DefaultBuildPluginManager.java:137)     at 
org.apache.maven.lifecycle.internal.MojoExecutor.doExecute 
(MojoExecutor.java:301)     at 
org.apache.maven.lifecycle.internal.MojoExecutor.execute 
(MojoExecutor.java:211)     at 
org.apache.maven.lifecycle.internal.MojoExecutor.execute 
(MojoExecutor.java:165)     at 
org.apache.maven.lifecycle.internal.MojoExecutor.execute 
(MojoExecutor.java:157)     at 
org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject 
(LifecycleModuleBuilder.java:121)     at 
org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject 
(LifecycleModuleBuilder.java:81)     at 
org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.build
 (SingleThreadedBuilder.java:56)     at 
org.apache.maven.lifecycle.internal.LifecycleStarter.execute 
(LifecycleStarter.java:127)     at org.apache.maven.DefaultMaven.doExecute 
(DefaultMaven.java:294)     at org.apache.maven.DefaultMaven.doExecute 
(DefaultMaven.java:192)     at org.apache.maven.DefaultMaven.execute 
(DefaultMaven.java:105)     at org.apache.maven.cli.MavenCli.execute 
(MavenCli.java:960)     at org.apache.maven.cli.MavenCli.doMain 
(MavenCli.java:293)     at org.apache.maven.cli.MavenCli.main 
(MavenCli.java:196)     at 
jdk.internal.reflect.NativeMethodAccessorImpl.invoke0 (Native Method)     at 
jdk.internal.reflect.NativeMethodAccessorImpl.invoke 
(NativeMethodAccessorImpl.java:77)     at 
jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke 
(DelegatingMethodAccessorImpl.java:43)     at java.lang.reflect.Method.invoke 
(Method.java:568)     at 
org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced 
(Launcher.java:282)     at 
org.codehaus.plexus.classworlds.launcher.Launcher.launch (Launcher.java:225)    
 at org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode 
(Launcher.java:406)     at 
org.codehaus.plexus.classworlds.launcher.Launcher.main (Launcher.java:347) 
Caused by: java.lang.NoSuchMethodError: 'javax.servlet.Filter 
javax.servlet.ServletContext.createFilter(java.lang.Class)'     at 
org.eclipse.jetty.servlet.FilterHolder.initialize (FilterHolder.java:123)     
at org.eclipse.jetty.servlet.ServletHandler.lambda$initialize$0 
(ServletHandler.java:731)     at 
java.util.Spliterators$ArraySpliterator.forEachRemaining 
(Spliterators.java:992)     at 
java.util.stream.Streams$ConcatSpliterator.forEachRemainin

[jira] [Created] (MJDEPRSCAN-10) Upgrade maven-plugin parent to 41

2023-11-14 Thread Karl Heinz Marbaise (Jira)
Karl Heinz Marbaise created MJDEPRSCAN-10:
-

 Summary: Upgrade maven-plugin parent to 41
 Key: MJDEPRSCAN-10
 URL: https://issues.apache.org/jira/browse/MJDEPRSCAN-10
 Project: Maven JDeprScan Plugin
  Issue Type: Improvement
Affects Versions: 3.0.0-alpha-1
Reporter: Karl Heinz Marbaise
Assignee: Karl Heinz Marbaise
 Fix For: 3.0.0






--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Closed] (MPH-211) Upgrade maven-plugin parent to 41

2023-11-14 Thread Karl Heinz Marbaise (Jira)


 [ 
https://issues.apache.org/jira/browse/MPH-211?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Karl Heinz Marbaise closed MPH-211.
---
Resolution: Done

> Upgrade maven-plugin parent to 41
> -
>
> Key: MPH-211
> URL: https://issues.apache.org/jira/browse/MPH-211
> Project: Maven Help Plugin
>  Issue Type: Improvement
>Affects Versions: 3.4.0
>Reporter: Karl Heinz Marbaise
>Assignee: Karl Heinz Marbaise
>Priority: Minor
> Fix For: next-release
>
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (MPH-211) Upgrade maven-plugin parent to 41

2023-11-14 Thread Karl Heinz Marbaise (Jira)


[ 
https://issues.apache.org/jira/browse/MPH-211?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17785935#comment-17785935
 ] 

Karl Heinz Marbaise commented on MPH-211:
-

Done in 
[8098d42b2f1582fcb2f5f1dcacc90e7da1997a18|https://gitbox.apache.org/repos/asf?p=maven-help-plugin.git;a=commitdiff;h=8098d42b2f1582fcb2f5f1dcacc90e7da1997a18]

> Upgrade maven-plugin parent to 41
> -
>
> Key: MPH-211
> URL: https://issues.apache.org/jira/browse/MPH-211
> Project: Maven Help Plugin
>  Issue Type: Improvement
>Affects Versions: 3.4.0
>Reporter: Karl Heinz Marbaise
>Assignee: Karl Heinz Marbaise
>Priority: Minor
> Fix For: next-release
>
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Updated] (MDEP-900) dependency:resolve fails for multi-module project

2023-11-14 Thread Gerd Aschemann (Jira)


 [ 
https://issues.apache.org/jira/browse/MDEP-900?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Gerd Aschemann updated MDEP-900:

Component/s: resolve
 (was: sources)

> dependency:resolve fails for multi-module project
> -
>
> Key: MDEP-900
> URL: https://issues.apache.org/jira/browse/MDEP-900
> Project: Maven Dependency Plugin
>  Issue Type: Bug
>  Components: resolve
>Affects Versions: 3.6.1
>Reporter: Gerd Aschemann
>Assignee: Slawomir Jaranowski
>Priority: Critical
> Fix For: 3.6.2
>
>
> When executing `mvn dependency:resolve` on a multi-module project it fails to 
> retrieve artifacts for the modules themselves (which is not necessary as 
> these can be installed by `mvn install` any time). 
> This can be seen on an [OSS multi-module 
> project|https://github.com/WASdev/sample.daytrader7]:
> {code:java}
> mvn dependency:resolve
> [INFO] Scanning for projects...
> [INFO] 
> 
> [INFO] Reactor Build Order:
> [INFO]
> [INFO] WAS Liberty Sample - Java EE7 Benchmark Sample - EJB Module        
> [jar]
> [INFO] WAS Liberty Sample - Java EE7 Benchmark Sample - Web Module        
> [war]
> [INFO] WAS Liberty Sample - Java EE7 Benchmark Sample                     
> [pom]
> [INFO] WAS Liberty Sample - Java EE7 Benchmark Sample - EAR               
> [ear]
> [INFO]
> [INFO] --< net.wasdev.wlp.sample:daytrader-ee7-ejb 
> >---
> [INFO] Building WAS Liberty Sample - Java EE7 Benchmark Sample - EJB Module 
> 1.0-SNAPSHOT [1/4]
> [INFO]   from daytrader-ee7-ejb/pom.xml
> [INFO] [ jar 
> ]-
> [INFO]
> [INFO] --- dependency:3.6.0:resolve (default-cli) @ daytrader-ee7-ejb ---
> [INFO]
> [INFO] The following files have been resolved:
> [INFO]    javax:javaee-api:jar:7.0:provided -- module javaee.api (auto)
> [INFO]    com.sun.mail:javax.mail:jar:1.5.0:provided -- module javax.mail 
> (auto)
> [INFO]    javax.activation:activation:jar:1.1:provided -- module activation 
> (auto)
> [INFO]    javax.annotation:javax.annotation-api:jar:1.3.2:provided -- module 
> java.annotation [auto]
> [INFO]
> [INFO]
> [INFO] --< net.wasdev.wlp.sample:daytrader-ee7-web 
> >---
> [INFO] Building WAS Liberty Sample - Java EE7 Benchmark Sample - Web Module 
> 1.0-SNAPSHOT [2/4]
> [INFO]   from daytrader-ee7-web/pom.xml
> [INFO] [ war 
> ]-
> [INFO] 
> 
> [INFO] Reactor Summary for WAS Liberty Sample - Java EE7 Benchmark Sample 
> 1.0-SNAPSHOT:
> [INFO]
> [INFO] WAS Liberty Sample - Java EE7 Benchmark Sample - EJB Module SUCCESS [  
> 0.402 s]
> [INFO] WAS Liberty Sample - Java EE7 Benchmark Sample - Web Module FAILURE [  
> 0.012 s]
> [INFO] WAS Liberty Sample - Java EE7 Benchmark Sample . SKIPPED
> [INFO] WAS Liberty Sample - Java EE7 Benchmark Sample - EAR SKIPPED
> [INFO] 
> 
> [INFO] BUILD FAILURE
> [INFO] 
> 
> [INFO] Total time:  0.552 s
> [INFO] Finished at: 2023-11-14T12:37:02+01:00
> [INFO] 
> 
> [ERROR] Failed to execute goal on project daytrader-ee7-web: Could not 
> resolve dependencies for project 
> net.wasdev.wlp.sample:daytrader-ee7-web:war:1.0-SNAPSHOT: The following 
> artifacts could not be resolved: 
> net.wasdev.wlp.sample:daytrader-ee7-ejb:jar:1.0-SNAPSHOT (absent): Could not 
> find artifact net.wasdev.wlp.sample:daytrader-ee7-ejb:jar:1.0-SNAPSHOT -> 
> [Help 1]{code}
> This is similar to the behaviour of MDEP-409, and MDEP-895



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Updated] (MDEP-900) dependency:resolve fails for multi-module project

2023-11-14 Thread Gerd Aschemann (Jira)


 [ 
https://issues.apache.org/jira/browse/MDEP-900?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Gerd Aschemann updated MDEP-900:

Description: 
When executing `mvn dependency:resolve` on a multi-module project it fails to 
retrieve artifacts for the modules themselves (which is not necessary as these 
can be installed by `mvn install` any time). 
This can be seen on an [OSS multi-module 
project|https://github.com/WASdev/sample.daytrader7]:
{code:java}
mvn dependency:resolve
[INFO] Scanning for projects...
[INFO] 
[INFO] Reactor Build Order:
[INFO]
[INFO] WAS Liberty Sample - Java EE7 Benchmark Sample - EJB Module        [jar]
[INFO] WAS Liberty Sample - Java EE7 Benchmark Sample - Web Module        [war]
[INFO] WAS Liberty Sample - Java EE7 Benchmark Sample                     [pom]
[INFO] WAS Liberty Sample - Java EE7 Benchmark Sample - EAR               [ear]
[INFO]
[INFO] --< net.wasdev.wlp.sample:daytrader-ee7-ejb >---
[INFO] Building WAS Liberty Sample - Java EE7 Benchmark Sample - EJB Module 
1.0-SNAPSHOT [1/4]
[INFO]   from daytrader-ee7-ejb/pom.xml
[INFO] [ jar ]-
[INFO]
[INFO] --- dependency:3.6.0:resolve (default-cli) @ daytrader-ee7-ejb ---
[INFO]
[INFO] The following files have been resolved:
[INFO]    javax:javaee-api:jar:7.0:provided -- module javaee.api (auto)
[INFO]    com.sun.mail:javax.mail:jar:1.5.0:provided -- module javax.mail (auto)
[INFO]    javax.activation:activation:jar:1.1:provided -- module activation 
(auto)
[INFO]    javax.annotation:javax.annotation-api:jar:1.3.2:provided -- module 
java.annotation [auto]
[INFO]
[INFO]
[INFO] --< net.wasdev.wlp.sample:daytrader-ee7-web >---
[INFO] Building WAS Liberty Sample - Java EE7 Benchmark Sample - Web Module 
1.0-SNAPSHOT [2/4]
[INFO]   from daytrader-ee7-web/pom.xml
[INFO] [ war ]-
[INFO] 
[INFO] Reactor Summary for WAS Liberty Sample - Java EE7 Benchmark Sample 
1.0-SNAPSHOT:
[INFO]
[INFO] WAS Liberty Sample - Java EE7 Benchmark Sample - EJB Module SUCCESS [  
0.402 s]
[INFO] WAS Liberty Sample - Java EE7 Benchmark Sample - Web Module FAILURE [  
0.012 s]
[INFO] WAS Liberty Sample - Java EE7 Benchmark Sample . SKIPPED
[INFO] WAS Liberty Sample - Java EE7 Benchmark Sample - EAR SKIPPED
[INFO] 
[INFO] BUILD FAILURE
[INFO] 
[INFO] Total time:  0.552 s
[INFO] Finished at: 2023-11-14T12:37:02+01:00
[INFO] 
[ERROR] Failed to execute goal on project daytrader-ee7-web: Could not resolve 
dependencies for project 
net.wasdev.wlp.sample:daytrader-ee7-web:war:1.0-SNAPSHOT: The following 
artifacts could not be resolved: 
net.wasdev.wlp.sample:daytrader-ee7-ejb:jar:1.0-SNAPSHOT (absent): Could not 
find artifact net.wasdev.wlp.sample:daytrader-ee7-ejb:jar:1.0-SNAPSHOT -> [Help 
1]{code}
This is similar to the behaviour of MDEP-409, and MDEP-895

  was:
When executing `mvn dependency:sources` on a multi-module project it fails to 
retrieve sources for the modules themselves (which is not necessary as the 
source code is provided locally already):


{code:java}
mvn dependency:sources
...
[INFO] -< org.apache.maven.its.dependency:tree-multimodule-module-b >--
[INFO] Building MultimoduleTest Module B 1.0-SNAPSHOT                     [3/3]
[INFO]   from module-b/pom.xml
[INFO] [ jar ]-
[INFO] 
[INFO] Reactor Summary for MultimoduleTest 1.0-SNAPSHOT:
[INFO]
[INFO] MultimoduleTest  SUCCESS [  0.390 s]
[INFO] MultimoduleTest Module A ... SUCCESS [  0.063 s]
[INFO] MultimoduleTest Module B ... FAILURE [  0.005 s]
[INFO] 
[INFO] BUILD FAILURE
[INFO] 
[INFO] Total time:  0.587 s
[INFO] Finished at: 2023-11-09T10:38:16+01:00
[INFO] 
[ERROR] Failed to execute goal on project tree-multimodule-module-b: Could not 
resolve dependencies for project 
org.apache.maven.its.dependency:tree-multimodule-module-b:jar:1.0-SNAPSHOT: The 
following artifacts could not be resolved: 
org.apache.maven.its.dependency:tree-multimodule-module-a:jar:1.0-SNAPSHOT 
(absent): Could not find artifact 
org.apache.maven.its.dependency:tree-multimodule-m

[jira] [Created] (MDEP-900) dependency:resolve fails for multi-module project

2023-11-14 Thread Gerd Aschemann (Jira)
Gerd Aschemann created MDEP-900:
---

 Summary: dependency:resolve fails for multi-module project
 Key: MDEP-900
 URL: https://issues.apache.org/jira/browse/MDEP-900
 Project: Maven Dependency Plugin
  Issue Type: Bug
  Components: sources
Affects Versions: 3.6.1
Reporter: Gerd Aschemann
Assignee: Slawomir Jaranowski
 Fix For: 3.6.2


When executing `mvn dependency:sources` on a multi-module project it fails to 
retrieve sources for the modules themselves (which is not necessary as the 
source code is provided locally already):


{code:java}
mvn dependency:sources
...
[INFO] -< org.apache.maven.its.dependency:tree-multimodule-module-b >--
[INFO] Building MultimoduleTest Module B 1.0-SNAPSHOT                     [3/3]
[INFO]   from module-b/pom.xml
[INFO] [ jar ]-
[INFO] 
[INFO] Reactor Summary for MultimoduleTest 1.0-SNAPSHOT:
[INFO]
[INFO] MultimoduleTest  SUCCESS [  0.390 s]
[INFO] MultimoduleTest Module A ... SUCCESS [  0.063 s]
[INFO] MultimoduleTest Module B ... FAILURE [  0.005 s]
[INFO] 
[INFO] BUILD FAILURE
[INFO] 
[INFO] Total time:  0.587 s
[INFO] Finished at: 2023-11-09T10:38:16+01:00
[INFO] 
[ERROR] Failed to execute goal on project tree-multimodule-module-b: Could not 
resolve dependencies for project 
org.apache.maven.its.dependency:tree-multimodule-module-b:jar:1.0-SNAPSHOT: The 
following artifacts could not be resolved: 
org.apache.maven.its.dependency:tree-multimodule-module-a:jar:1.0-SNAPSHOT 
(absent): Could not find artifact 
org.apache.maven.its.dependency:tree-multimodule-module-a:jar:1.0-SNAPSHOT -> 
[Help 1]{code}
This is similar to the behaviour of MDEP-409.

A test and PR is already prepared: 
https://github.com/jmle/maven-dependency-plugin/tree/fix-sources-multimodule



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (MPLUGIN-495) WARNINGs based on usage of @Component for session/MavenProject instead of @Parameter

2023-11-14 Thread Karl Heinz Marbaise (Jira)


[ 
https://issues.apache.org/jira/browse/MPLUGIN-495?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17785921#comment-17785921
 ] 

Karl Heinz Marbaise commented on MPLUGIN-495:
-

Thanks for reopening ... clicked on the wrong one. 

> WARNINGs based on usage of @Component for session/MavenProject instead of 
> @Parameter
> 
>
> Key: MPLUGIN-495
> URL: https://issues.apache.org/jira/browse/MPLUGIN-495
> Project: Maven Plugin Tools
>  Issue Type: Improvement
>Affects Versions: 3.10.2
>Reporter: Karl Heinz Marbaise
>Assignee: Guillaume Nodet
>Priority: Critical
>
> A change of parameters like this:
> {code:java}
> @Parameter(defaultValue = "${project}", readonly = true, required = true)
> {code}
> into:
> {code:java}
> @Component
> {code}
> This will result in WARNINGs like this:
> {code}
> Warning:  Deprecated @Component annotation for 'session' field in 
> org.apache.maven.plugins.dependency.GetMojo: replace with @Parameter( 
> defaultValue = "${session}", readonly = true )
> {code}
> The shown deprecation message is wrong. It is fine to use that for components 
> to be injected.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (MRESOLVER-432) Introduce session provider as well

2023-11-14 Thread ASF GitHub Bot (Jira)


[ 
https://issues.apache.org/jira/browse/MRESOLVER-432?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17785911#comment-17785911
 ] 

ASF GitHub Bot commented on MRESOLVER-432:
--

cstamas opened a new pull request, #362:
URL: https://github.com/apache/maven-resolver/pull/362

   ---
   
   https://issues.apache.org/jira/browse/MRESOLVER-432




> Introduce session provider as well
> --
>
> Key: MRESOLVER-432
> URL: https://issues.apache.org/jira/browse/MRESOLVER-432
> Project: Maven Resolver
>  Issue Type: Task
>  Components: Resolver
>Reporter: Tamas Cservenak
>Priority: Major
> Fix For: 2.0.0
>
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[PR] [MRESOLVER-432] Introduce Session Supplier similar to System Supplier [maven-resolver]

2023-11-14 Thread via GitHub


cstamas opened a new pull request, #362:
URL: https://github.com/apache/maven-resolver/pull/362

   ---
   
   https://issues.apache.org/jira/browse/MRESOLVER-432


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[jira] [Reopened] (MPLUGIN-495) WARNINGs based on usage of @Component for session/MavenProject instead of @Parameter

2023-11-14 Thread Guillaume Nodet (Jira)


 [ 
https://issues.apache.org/jira/browse/MPLUGIN-495?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Guillaume Nodet reopened MPLUGIN-495:
-
  Assignee: Guillaume Nodet

Wrongly closed

> WARNINGs based on usage of @Component for session/MavenProject instead of 
> @Parameter
> 
>
> Key: MPLUGIN-495
> URL: https://issues.apache.org/jira/browse/MPLUGIN-495
> Project: Maven Plugin Tools
>  Issue Type: Improvement
>Affects Versions: 3.10.2
>Reporter: Karl Heinz Marbaise
>Assignee: Guillaume Nodet
>Priority: Critical
>
> A change of parameters like this:
> {code:java}
> @Parameter(defaultValue = "${project}", readonly = true, required = true)
> {code}
> into:
> {code:java}
> @Component
> {code}
> This will result in WARNINGs like this:
> {code}
> Warning:  Deprecated @Component annotation for 'session' field in 
> org.apache.maven.plugins.dependency.GetMojo: replace with @Parameter( 
> defaultValue = "${session}", readonly = true )
> {code}
> The shown deprecation message is wrong. It is fine to use that for components 
> to be injected.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Closed] (MPLUGIN-495) WARNINGs based on usage of @Component for session/MavenProject instead of @Parameter

2023-11-14 Thread Guillaume Nodet (Jira)


 [ 
https://issues.apache.org/jira/browse/MPLUGIN-495?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Guillaume Nodet closed MPLUGIN-495.
---
Fix Version/s: (was: next-release)
   Resolution: Fixed

> WARNINGs based on usage of @Component for session/MavenProject instead of 
> @Parameter
> 
>
> Key: MPLUGIN-495
> URL: https://issues.apache.org/jira/browse/MPLUGIN-495
> Project: Maven Plugin Tools
>  Issue Type: Improvement
>Affects Versions: 3.10.2
>Reporter: Karl Heinz Marbaise
>Priority: Critical
>
> A change of parameters like this:
> {code:java}
> @Parameter(defaultValue = "${project}", readonly = true, required = true)
> {code}
> into:
> {code:java}
> @Component
> {code}
> This will result in WARNINGs like this:
> {code}
> Warning:  Deprecated @Component annotation for 'session' field in 
> org.apache.maven.plugins.dependency.GetMojo: replace with @Parameter( 
> defaultValue = "${session}", readonly = true )
> {code}
> The shown deprecation message is wrong. It is fine to use that for components 
> to be injected.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (MDEP-892) go-offline does not correctly resolve overridden properties

2023-11-14 Thread Arnout Engelen (Jira)


[ 
https://issues.apache.org/jira/browse/MDEP-892?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17785850#comment-17785850
 ] 

Arnout Engelen commented on MDEP-892:
-

Apologies for being unclear, I just updated the reproducer to pin the version 
to the latest release, 3.6.1, and it still shows the problem.

 

I tested with maven 3.9.5 and JDK 19.0.2

> go-offline does not correctly resolve overridden properties
> ---
>
> Key: MDEP-892
> URL: https://issues.apache.org/jira/browse/MDEP-892
> Project: Maven Dependency Plugin
>  Issue Type: Bug
>  Components: go-offline
>Affects Versions: 3.6.1
>Reporter: Arnout Engelen
>Priority: Minor
>
> When a project shares a parent pom with a dependency, and overrides a 
> property of that parent pom, this is not picked up by 
> {{{}dependency:go-offline{}}}.
> I have shared a reproducer at 
> [https://codeberg.org/raboof/maven-property-resolution] . The scenario is 
> `one` and `other-mod` both have parent pom `other-parent`. `other-parent` 
> specifies version 7.4 of a dependency, but `one` overrides this to 7.3. Other 
> plugins (including `mvn dependency:tree`) pick 7.3 in this scenario, but `mvn 
> dependency:go-offline` downloads version 7.4.
> It seems [https://github.com/apache/maven-dependency-plugin/pull/2] 
> (unmerged) fixed this, but its successor 
> [https://github.com/apache/maven-dependency-plugin/pull/135] (unmerged) does 
> not.
> An alternative is to use [https://github.com/qaware/go-offline-maven-plugin] 
> instead.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Updated] (MDEP-892) go-offline does not correctly resolve overridden properties

2023-11-14 Thread Arnout Engelen (Jira)


 [ 
https://issues.apache.org/jira/browse/MDEP-892?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Arnout Engelen updated MDEP-892:

Affects Version/s: 3.6.1

> go-offline does not correctly resolve overridden properties
> ---
>
> Key: MDEP-892
> URL: https://issues.apache.org/jira/browse/MDEP-892
> Project: Maven Dependency Plugin
>  Issue Type: Bug
>  Components: go-offline
>Affects Versions: 3.6.1
>Reporter: Arnout Engelen
>Priority: Minor
>
> When a project shares a parent pom with a dependency, and overrides a 
> property of that parent pom, this is not picked up by 
> {{{}dependency:go-offline{}}}.
> I have shared a reproducer at 
> [https://codeberg.org/raboof/maven-property-resolution] . The scenario is 
> `one` and `other-mod` both have parent pom `other-parent`. `other-parent` 
> specifies version 7.4 of a dependency, but `one` overrides this to 7.3. Other 
> plugins (including `mvn dependency:tree`) pick 7.3 in this scenario, but `mvn 
> dependency:go-offline` downloads version 7.4.
> It seems [https://github.com/apache/maven-dependency-plugin/pull/2] 
> (unmerged) fixed this, but its successor 
> [https://github.com/apache/maven-dependency-plugin/pull/135] (unmerged) does 
> not.
> An alternative is to use [https://github.com/qaware/go-offline-maven-plugin] 
> instead.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (MNG-7920) Usage of packaging BOM fails in maven-install-plugin

2023-11-14 Thread Zhongming Hua (Jira)


[ 
https://issues.apache.org/jira/browse/MNG-7920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17785829#comment-17785829
 ] 

Zhongming Hua commented on MNG-7920:


I will fix the problem.

[~sjaranowski] [~khmarbaise] 

> Usage of packaging BOM fails in maven-install-plugin
> 
>
> Key: MNG-7920
> URL: https://issues.apache.org/jira/browse/MNG-7920
> Project: Maven
>  Issue Type: Bug
>  Components: Deployment
>Affects Versions: 4.0.0-alpha-8
>Reporter: Karl Heinz Marbaise
>Priority: Critical
> Fix For: 4.0.0, 4.0.0-alpha-9
>
>
> Using to use the `bom` packaging in a module it will fail with:
> {code}
> [INFO] 
> --
> [ERROR] Failed to execute goal 
> org.apache.maven.plugins:maven-install-plugin:3.1.1:install (default-install) 
> on project bom: The packaging plugin for this project did not assign a main 
> file to the project but it has attachments. Change packaging to 'pom'. -> 
> [Help 1]
> {code}
> The bom module looks like this:
> {code:xml}
>xmlns="http://maven.apache.org/POM/4.1.0";
>   xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance";
>   xsi:schemaLocation="http://maven.apache.org/POM/4.1.0 
> http://maven.apache.org/maven-v4_1_0.xsd";>
>   4.1.0
>   
> maven4
> bom-example
>   
>   bom
>   bom
>   
> 
>   
>   ...maven4
>   mod-1
>   
>   
>   maven4
>   mod-2
>   
> 
>   
> 
> {code}
> I would assume that I need to upgrade the maven-install-plugin which is 
> capable of handling that...but I assumed that this conversion is done by core?



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (MNG-7920) Usage of packaging BOM fails in maven-install-plugin

2023-11-14 Thread Zhongming Hua (Jira)


[ 
https://issues.apache.org/jira/browse/MNG-7920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17785827#comment-17785827
 ] 

Zhongming Hua commented on MNG-7920:


[~khmarbaise] [~sjaranowski] 

> Usage of packaging BOM fails in maven-install-plugin
> 
>
> Key: MNG-7920
> URL: https://issues.apache.org/jira/browse/MNG-7920
> Project: Maven
>  Issue Type: Bug
>  Components: Deployment
>Affects Versions: 4.0.0-alpha-8
>Reporter: Karl Heinz Marbaise
>Priority: Critical
> Fix For: 4.0.0, 4.0.0-alpha-9
>
>
> Using to use the `bom` packaging in a module it will fail with:
> {code}
> [INFO] 
> --
> [ERROR] Failed to execute goal 
> org.apache.maven.plugins:maven-install-plugin:3.1.1:install (default-install) 
> on project bom: The packaging plugin for this project did not assign a main 
> file to the project but it has attachments. Change packaging to 'pom'. -> 
> [Help 1]
> {code}
> The bom module looks like this:
> {code:xml}
>xmlns="http://maven.apache.org/POM/4.1.0";
>   xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance";
>   xsi:schemaLocation="http://maven.apache.org/POM/4.1.0 
> http://maven.apache.org/maven-v4_1_0.xsd";>
>   4.1.0
>   
> maven4
> bom-example
>   
>   bom
>   bom
>   
> 
>   
>   ...maven4
>   mod-1
>   
>   
>   maven4
>   mod-2
>   
> 
>   
> 
> {code}
> I would assume that I need to upgrade the maven-install-plugin which is 
> capable of handling that...but I assumed that this conversion is done by core?



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] (MNG-7920) Usage of packaging BOM fails in maven-install-plugin

2023-11-14 Thread Zhongming Hua (Jira)


[ https://issues.apache.org/jira/browse/MNG-7920 ]


Zhongming Hua deleted comment on MNG-7920:


was (Author: crazyhzm):
[~khmarbaise] [~sjaranowski] 

> Usage of packaging BOM fails in maven-install-plugin
> 
>
> Key: MNG-7920
> URL: https://issues.apache.org/jira/browse/MNG-7920
> Project: Maven
>  Issue Type: Bug
>  Components: Deployment
>Affects Versions: 4.0.0-alpha-8
>Reporter: Karl Heinz Marbaise
>Priority: Critical
> Fix For: 4.0.0, 4.0.0-alpha-9
>
>
> Using to use the `bom` packaging in a module it will fail with:
> {code}
> [INFO] 
> --
> [ERROR] Failed to execute goal 
> org.apache.maven.plugins:maven-install-plugin:3.1.1:install (default-install) 
> on project bom: The packaging plugin for this project did not assign a main 
> file to the project but it has attachments. Change packaging to 'pom'. -> 
> [Help 1]
> {code}
> The bom module looks like this:
> {code:xml}
>xmlns="http://maven.apache.org/POM/4.1.0";
>   xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance";
>   xsi:schemaLocation="http://maven.apache.org/POM/4.1.0 
> http://maven.apache.org/maven-v4_1_0.xsd";>
>   4.1.0
>   
> maven4
> bom-example
>   
>   bom
>   bom
>   
> 
>   
>   ...maven4
>   mod-1
>   
>   
>   maven4
>   mod-2
>   
> 
>   
> 
> {code}
> I would assume that I need to upgrade the maven-install-plugin which is 
> capable of handling that...but I assumed that this conversion is done by core?



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Created] (MJLINK-76) Upgrade maven-plugin parent to 41

2023-11-14 Thread Karl Heinz Marbaise (Jira)
Karl Heinz Marbaise created MJLINK-76:
-

 Summary: Upgrade maven-plugin parent to 41
 Key: MJLINK-76
 URL: https://issues.apache.org/jira/browse/MJLINK-76
 Project: Maven JLink Plugin
  Issue Type: Improvement
Affects Versions: 3.1.0
Reporter: Karl Heinz Marbaise
Assignee: Karl Heinz Marbaise
 Fix For: 3.2.0






--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Assigned] (MJDEPS-31) Upgrade maven-plugin parent to 41

2023-11-14 Thread Karl Heinz Marbaise (Jira)


 [ 
https://issues.apache.org/jira/browse/MJDEPS-31?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Karl Heinz Marbaise reassigned MJDEPS-31:
-

Assignee: Karl Heinz Marbaise

> Upgrade maven-plugin parent to 41
> -
>
> Key: MJDEPS-31
> URL: https://issues.apache.org/jira/browse/MJDEPS-31
> Project: Maven JDeps Plugin
>  Issue Type: Improvement
>Affects Versions: 3.1.2
>Reporter: Karl Heinz Marbaise
>Assignee: Karl Heinz Marbaise
>Priority: Minor
> Fix For: 3.1.3
>
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Created] (MJDEPS-31) Upgrade maven-plugin parent to 41

2023-11-14 Thread Karl Heinz Marbaise (Jira)
Karl Heinz Marbaise created MJDEPS-31:
-

 Summary: Upgrade maven-plugin parent to 41
 Key: MJDEPS-31
 URL: https://issues.apache.org/jira/browse/MJDEPS-31
 Project: Maven JDeps Plugin
  Issue Type: Improvement
Affects Versions: 3.1.2
Reporter: Karl Heinz Marbaise
 Fix For: 3.1.3






--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Assigned] (MJAVADOC-779) Upgrade maven-plugin parent to 41

2023-11-14 Thread Karl Heinz Marbaise (Jira)


 [ 
https://issues.apache.org/jira/browse/MJAVADOC-779?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Karl Heinz Marbaise reassigned MJAVADOC-779:


Assignee: Karl Heinz Marbaise

> Upgrade maven-plugin parent to 41
> -
>
> Key: MJAVADOC-779
> URL: https://issues.apache.org/jira/browse/MJAVADOC-779
> Project: Maven Javadoc Plugin
>  Issue Type: Improvement
>Affects Versions: 3.6.2
>Reporter: Karl Heinz Marbaise
>Assignee: Karl Heinz Marbaise
>Priority: Minor
> Fix For: 3.6.3
>
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Updated] (MJAVADOC-779) Upgrade maven-plugin parent to 41

2023-11-14 Thread Karl Heinz Marbaise (Jira)


 [ 
https://issues.apache.org/jira/browse/MJAVADOC-779?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Karl Heinz Marbaise updated MJAVADOC-779:
-
Fix Version/s: 3.6.3
   (was: 4.0.0)

> Upgrade maven-plugin parent to 41
> -
>
> Key: MJAVADOC-779
> URL: https://issues.apache.org/jira/browse/MJAVADOC-779
> Project: Maven Javadoc Plugin
>  Issue Type: Improvement
>Affects Versions: 3.6.2
>Reporter: Karl Heinz Marbaise
>Priority: Minor
> Fix For: 3.6.3
>
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Created] (MJAVADOC-779) Upgrade maven-plugin parent to 41

2023-11-14 Thread Karl Heinz Marbaise (Jira)
Karl Heinz Marbaise created MJAVADOC-779:


 Summary: Upgrade maven-plugin parent to 41
 Key: MJAVADOC-779
 URL: https://issues.apache.org/jira/browse/MJAVADOC-779
 Project: Maven Javadoc Plugin
  Issue Type: Improvement
Affects Versions: 3.6.2
Reporter: Karl Heinz Marbaise
 Fix For: 4.0.0






--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Assigned] (MJAR-299) Upgrade maven-plugin parent to 41

2023-11-14 Thread Karl Heinz Marbaise (Jira)


 [ 
https://issues.apache.org/jira/browse/MJAR-299?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Karl Heinz Marbaise reassigned MJAR-299:


Assignee: Karl Heinz Marbaise

> Upgrade maven-plugin parent to 41
> -
>
> Key: MJAR-299
> URL: https://issues.apache.org/jira/browse/MJAR-299
> Project: Maven JAR Plugin
>  Issue Type: Improvement
>Affects Versions: 3.3.0
>Reporter: Karl Heinz Marbaise
>Assignee: Karl Heinz Marbaise
>Priority: Minor
> Fix For: 3.4.0
>
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Created] (MJAR-299) Upgrade maven-plugin parent to 41

2023-11-14 Thread Karl Heinz Marbaise (Jira)
Karl Heinz Marbaise created MJAR-299:


 Summary: Upgrade maven-plugin parent to 41
 Key: MJAR-299
 URL: https://issues.apache.org/jira/browse/MJAR-299
 Project: Maven JAR Plugin
  Issue Type: Improvement
Affects Versions: 3.3.0
Reporter: Karl Heinz Marbaise
 Fix For: 3.4.0






--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Created] (MINVOKER-350) Upgrade maven-plugin parent to 41

2023-11-14 Thread Karl Heinz Marbaise (Jira)
Karl Heinz Marbaise created MINVOKER-350:


 Summary: Upgrade maven-plugin parent to 41
 Key: MINVOKER-350
 URL: https://issues.apache.org/jira/browse/MINVOKER-350
 Project: Maven Invoker Plugin
  Issue Type: Improvement
Affects Versions: 3.6.0
Reporter: Karl Heinz Marbaise
Assignee: Karl Heinz Marbaise
 Fix For: 3.x






--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Assigned] (MPH-211) Upgrade maven-plugin parent to 41

2023-11-14 Thread Karl Heinz Marbaise (Jira)


 [ 
https://issues.apache.org/jira/browse/MPH-211?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Karl Heinz Marbaise reassigned MPH-211:
---

Assignee: Karl Heinz Marbaise

> Upgrade maven-plugin parent to 41
> -
>
> Key: MPH-211
> URL: https://issues.apache.org/jira/browse/MPH-211
> Project: Maven Help Plugin
>  Issue Type: Improvement
>Affects Versions: 3.4.0
>Reporter: Karl Heinz Marbaise
>Assignee: Karl Heinz Marbaise
>Priority: Minor
> Fix For: next-release
>
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Created] (MPH-211) Upgrade maven-plugin parent to 41

2023-11-14 Thread Karl Heinz Marbaise (Jira)
Karl Heinz Marbaise created MPH-211:
---

 Summary: Upgrade maven-plugin parent to 41
 Key: MPH-211
 URL: https://issues.apache.org/jira/browse/MPH-211
 Project: Maven Help Plugin
  Issue Type: Improvement
Affects Versions: 3.4.0
Reporter: Karl Heinz Marbaise
 Fix For: next-release






--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] (MPOM-447) activate javac's release flag when building with JDK supporting that feature

2023-11-14 Thread Herve Boutemy (Jira)


[ https://issues.apache.org/jira/browse/MPOM-447 ]


Herve Boutemy deleted comment on MPOM-447:


was (Author: hboutemy):
you're right, don't hesitate to improve issue title

> activate javac's release flag when building with JDK supporting that feature
> 
>
> Key: MPOM-447
> URL: https://issues.apache.org/jira/browse/MPOM-447
> Project: Maven POMs
>  Issue Type: Improvement
>  Components: maven
>Affects Versions: MAVEN-41
>Reporter: Herve Boutemy
>Assignee: Herve Boutemy
>Priority: Major
> Fix For: MAVEN-42
>
>
> easy to do, prepares smooth transitioning
> and absolutely needeed when building with JDK 11+ as without this flag, it 
> may inject JDK APIs calls that are not supported by target platform



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] (MPOM-447) activate javac's release flag when building with JDK supporting that feature

2023-11-14 Thread Herve Boutemy (Jira)


[ https://issues.apache.org/jira/browse/MPOM-447 ]


Herve Boutemy deleted comment on MPOM-447:


was (Author: michael-o):
I think this isn't necessarily about JPMS...

> activate javac's release flag when building with JDK supporting that feature
> 
>
> Key: MPOM-447
> URL: https://issues.apache.org/jira/browse/MPOM-447
> Project: Maven POMs
>  Issue Type: Improvement
>  Components: maven
>Affects Versions: MAVEN-41
>Reporter: Herve Boutemy
>Assignee: Herve Boutemy
>Priority: Major
> Fix For: MAVEN-42
>
>
> easy to do, prepares smooth transitioning
> and absolutely needeed when building with JDK 11+ as without this flag, it 
> may inject JDK APIs calls that are not supported by target platform



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Updated] (MPOM-447) activate javac's release flag when building with JDK supporting that feature

2023-11-14 Thread Herve Boutemy (Jira)


 [ 
https://issues.apache.org/jira/browse/MPOM-447?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Herve Boutemy updated MPOM-447:
---
Summary: activate javac's release flag when building with JDK supporting 
that feature  (was: Activate javac's release flag when Java 11 or newer is used)

> activate javac's release flag when building with JDK supporting that feature
> 
>
> Key: MPOM-447
> URL: https://issues.apache.org/jira/browse/MPOM-447
> Project: Maven POMs
>  Issue Type: Improvement
>  Components: maven
>Affects Versions: MAVEN-41
>Reporter: Herve Boutemy
>Assignee: Herve Boutemy
>Priority: Major
> Fix For: MAVEN-42
>
>
> easy to do, prepares smooth transitioning
> and absolutely needeed when building with JDK 11+ as without this flag, it 
> may inject JDK APIs calls that are not supported by target platform



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Created] (MEAR-328) Upgrade maven-plugin parent to 41

2023-11-14 Thread Karl Heinz Marbaise (Jira)
Karl Heinz Marbaise created MEAR-328:


 Summary: Upgrade maven-plugin parent to 41
 Key: MEAR-328
 URL: https://issues.apache.org/jira/browse/MEAR-328
 Project: Maven EAR Plugin
  Issue Type: Improvement
Affects Versions: 3.3.0
Reporter: Karl Heinz Marbaise
Assignee: Karl Heinz Marbaise
 Fix For: next-release






--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Updated] (MPOM-447) Activate javac's release flag when Java 11 or newer is used

2023-11-14 Thread Michael Osipov (Jira)


 [ 
https://issues.apache.org/jira/browse/MPOM-447?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Michael Osipov updated MPOM-447:

Summary: Activate javac's release flag when Java 11 or newer is used  (was: 
activate javac's release flag when Java 11 or newer is used)

> Activate javac's release flag when Java 11 or newer is used
> ---
>
> Key: MPOM-447
> URL: https://issues.apache.org/jira/browse/MPOM-447
> Project: Maven POMs
>  Issue Type: Improvement
>  Components: maven
>Affects Versions: MAVEN-41
>Reporter: Herve Boutemy
>Assignee: Herve Boutemy
>Priority: Major
> Fix For: MAVEN-42
>
>
> easy to do, prepares smooth transitioning
> and absolutely needeed when building with JDK 11+ as without this flag, it 
> may inject JDK APIs calls that are not supported by target platform



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Updated] (MPOM-447) activate javac's release flag when Java 11 or newer is used

2023-11-14 Thread Michael Osipov (Jira)


 [ 
https://issues.apache.org/jira/browse/MPOM-447?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Michael Osipov updated MPOM-447:

Summary: activate javac's release flag when Java 11 or newer is used  (was: 
activate javac's release flag when building with JPMS-enabled JDK)

> activate javac's release flag when Java 11 or newer is used
> ---
>
> Key: MPOM-447
> URL: https://issues.apache.org/jira/browse/MPOM-447
> Project: Maven POMs
>  Issue Type: Improvement
>  Components: maven
>Affects Versions: MAVEN-41
>Reporter: Herve Boutemy
>Assignee: Herve Boutemy
>Priority: Major
> Fix For: MAVEN-42
>
>
> easy to do, prepares smooth transitioning
> and absolutely needeed when building with JDK 11+ as without this flag, it 
> may inject JDK APIs calls that are not supported by target platform



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (MPOM-447) activate javac's release flag when building with JPMS-enabled JDK

2023-11-14 Thread Herve Boutemy (Jira)


[ 
https://issues.apache.org/jira/browse/MPOM-447?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17785798#comment-17785798
 ] 

Herve Boutemy commented on MPOM-447:


you're right, don't hesitate to improve issue title

> activate javac's release flag when building with JPMS-enabled JDK
> -
>
> Key: MPOM-447
> URL: https://issues.apache.org/jira/browse/MPOM-447
> Project: Maven POMs
>  Issue Type: Improvement
>  Components: maven
>Affects Versions: MAVEN-41
>Reporter: Herve Boutemy
>Assignee: Herve Boutemy
>Priority: Major
> Fix For: MAVEN-42
>
>
> easy to do, prepares smooth transitioning
> and absolutely needeed when building with JDK 11+ as without this flag, it 
> may inject JDK APIs calls that are not supported by target platform



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Resolved] (SUREFIRE-2210) Additional class path ordering broken since 3.2.0

2023-11-14 Thread Konrad Windszus (Jira)


 [ 
https://issues.apache.org/jira/browse/SUREFIRE-2210?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Konrad Windszus resolved SUREFIRE-2210.
---
Fix Version/s: next-release
   Resolution: Fixed

Fixed in 
https://github.com/apache/maven-surefire/commit/47c5816ae6d3e596d13a3253e214939f3a479b1f.
 
[~dmlloyd] Thanks a lot for the fix and test.

> Additional class path ordering broken since 3.2.0
> -
>
> Key: SUREFIRE-2210
> URL: https://issues.apache.org/jira/browse/SUREFIRE-2210
> Project: Maven Surefire
>  Issue Type: Bug
>Affects Versions: 3.2.1, 3.2.2
>Reporter: David M. Lloyd
>Priority: Critical
> Fix For: next-release
>
>
> Since commit 
> [47eb1974ef2fb77c621e5cb0c47ac10ab8f4753d|https://github.com/apache/maven-surefire/commit/47eb1974ef2fb77c621e5cb0c47ac10ab8f4753d]
>  ([#667|https://github.com/apache/maven-surefire/pull/667], SUREFIRE-2179), 
> the ordering of the {{additionalClasspathElements}} list configuration 
> property is no longer preserved. This breaks testing of multi-release JARs, 
> where the directories for newer JDKs *must* be strictly ordered *before* the 
> directories for older JDKs.
> The problem is likely due to changing the additional class paths collection 
> from a `List` to a `Set`, which does not preserve ordering.
> One simple fix could be to change the line {{Set 
> additionalClasspathElements = new HashSet<>();}} to construct a 
> {{LinkedHashSet}} instead.
> /cc [~kwin] who wrote the original patch back in June.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Assigned] (SUREFIRE-2210) Additional class path ordering broken since 3.2.0

2023-11-14 Thread Konrad Windszus (Jira)


 [ 
https://issues.apache.org/jira/browse/SUREFIRE-2210?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Konrad Windszus reassigned SUREFIRE-2210:
-

Assignee: Konrad Windszus

> Additional class path ordering broken since 3.2.0
> -
>
> Key: SUREFIRE-2210
> URL: https://issues.apache.org/jira/browse/SUREFIRE-2210
> Project: Maven Surefire
>  Issue Type: Bug
>Affects Versions: 3.2.1, 3.2.2
>Reporter: David M. Lloyd
>Assignee: Konrad Windszus
>Priority: Critical
> Fix For: next-release
>
>
> Since commit 
> [47eb1974ef2fb77c621e5cb0c47ac10ab8f4753d|https://github.com/apache/maven-surefire/commit/47eb1974ef2fb77c621e5cb0c47ac10ab8f4753d]
>  ([#667|https://github.com/apache/maven-surefire/pull/667], SUREFIRE-2179), 
> the ordering of the {{additionalClasspathElements}} list configuration 
> property is no longer preserved. This breaks testing of multi-release JARs, 
> where the directories for newer JDKs *must* be strictly ordered *before* the 
> directories for older JDKs.
> The problem is likely due to changing the additional class paths collection 
> from a `List` to a `Set`, which does not preserve ordering.
> One simple fix could be to change the line {{Set 
> additionalClasspathElements = new HashSet<>();}} to construct a 
> {{LinkedHashSet}} instead.
> /cc [~kwin] who wrote the original patch back in June.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


Re: [PR] [MPOM-447] activate javac's release flag [maven-parent]

2023-11-14 Thread via GitHub


slawekjaranowski commented on PR #150:
URL: https://github.com/apache/maven-parent/pull/150#issuecomment-1809752238

   > Should we also change property `minimalJavaBuildVersion` to `11`?
   
   ok it is in profile 😄 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] [SUREFIRE-2210] - Restore ordering of additional class path elements [maven-surefire]

2023-11-14 Thread via GitHub


kwin merged PR #686:
URL: https://github.com/apache/maven-surefire/pull/686


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] [MPOM-447] activate javac's release flag [maven-parent]

2023-11-14 Thread via GitHub


slawekjaranowski commented on PR #150:
URL: https://github.com/apache/maven-parent/pull/150#issuecomment-1809751347

   Should we also change property `minimalJavaBuildVersion` to `11`?
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



  1   2   >