Re: [PR] [MSHARED-1285] - incremental build does not honor `BuildContext#isUptodate()` [maven-filtering]

2023-12-05 Thread via GitHub


laeubi commented on PR #83:
URL: https://github.com/apache/maven-filtering/pull/83#issuecomment-1842270748

   I have now rebased my PR on top of your commit:
   - https://github.com/apache/maven-filtering/pull/77


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[jira] [Commented] (MSHARED-1285) DefaultMavenResourcesFiltering uses BuildContext in a way that fails sometimes

2023-12-05 Thread ASF GitHub Bot (Jira)


[ 
https://issues.apache.org/jira/browse/MSHARED-1285?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17793538#comment-17793538
 ] 

ASF GitHub Bot commented on MSHARED-1285:
-

laeubi commented on PR #83:
URL: https://github.com/apache/maven-filtering/pull/83#issuecomment-1842270748

   I have now rebased my PR on top of your commit:
   - https://github.com/apache/maven-filtering/pull/77




> DefaultMavenResourcesFiltering uses BuildContext in a way that fails sometimes
> --
>
> Key: MSHARED-1285
> URL: https://issues.apache.org/jira/browse/MSHARED-1285
> Project: Maven Shared Components
>  Issue Type: Bug
>Reporter: Christoph Läubrich
>Priority: Major
>
> The maven resources plugin uses 
> [https://github.com/apache/maven-filtering/blob/master/src/main/java/org/apache/maven/shared/filtering/DefaultMavenResourcesFiltering.java]
>  to copy resources, but that component has some subtile flaws reported here:
> [https://github.com/eclipse-m2e/m2e-core/discussions/1468]
> The problematic part is the usage of BuildContext#newScanner that already 
> mentions in the javadoc that passing ignoreDelta to neScanner might not 
> reveal all required items +*for copy-resources*+ form A -> B and instead 
> BuildContext#isUpTodate should be used.
> Just from a quick look I assume that part of code actually wants to use 
> something like this:
> {code:java}
> DirectoryScanner ds = new DirectoryScanner() {
>   @Override
>   protected boolean isSelected(String name, File file) {
> if (file.isFile() && buildContext.isUptodate(getTargetFile(file), file)) 
> { 
>  return false;
> }
> return true;
>   }
> };
> ds.setBasedir(basedir); {code}
> That way all the code that currently checks for if output directory existed 
> before can also be removed what is another issue because it leads to a full 
> resources copy even if source+target are already even if a single class file 
> is changed while the idea seems more that if the output was not there it 
> should not try to be incremental!



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (MNG-7532) Revert MNG-6931 deprecation since list shows no consensus on that

2023-12-05 Thread ASF GitHub Bot (Jira)


[ 
https://issues.apache.org/jira/browse/MNG-7532?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17793533#comment-17793533
 ] 

ASF GitHub Bot commented on MNG-7532:
-

rmannibucau commented on PR #793:
URL: https://github.com/apache/maven/pull/793#issuecomment-1842231553

   Up, seems we are still un a broken state where we say to use slf4j for 
plugins and I didn't find the mvn4 API (pretty sure you did something @gnodet 
but didnt see it in mvn4 branch).




> Revert MNG-6931 deprecation since list shows no consensus on that
> -
>
> Key: MNG-7532
> URL: https://issues.apache.org/jira/browse/MNG-7532
> Project: Maven
>  Issue Type: Task
>Reporter: Romain Manni-Bucau
>Priority: Major
>
> There are several threads on the dev list asking for the drop of slf4j and at 
> least keeping a logging abstraction for not internal dev (= core can use 
> slf4j but not mojo/extensions).
> Work is being done to abstract plugin api so let's keep the 
> deprecation/replacement of our Log API in this track and keep it the official 
> way for now.
> one of the multiple refs: 
> https://www.mail-archive.com/dev@maven.apache.org/msg123452.html



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


Re: [PR] [MNG-7532] Log shouldn't have been deprecated so ensure it is not [maven]

2023-12-05 Thread via GitHub


rmannibucau commented on PR #793:
URL: https://github.com/apache/maven/pull/793#issuecomment-1842231553

   Up, seems we are still un a broken state where we say to use slf4j for 
plugins and I didn't find the mvn4 API (pretty sure you did something @gnodet 
but didnt see it in mvn4 branch).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[jira] [Commented] (SUREFIRE-2219) Option to include stdOut/stdErr console logs into test report

2023-12-05 Thread ASF GitHub Bot (Jira)


[ 
https://issues.apache.org/jira/browse/SUREFIRE-2219?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17793528#comment-17793528
 ] 

ASF GitHub Bot commented on SUREFIRE-2219:
--

michael-o commented on PR #692:
URL: https://github.com/apache/maven-surefire/pull/692#issuecomment-1842184343

   @kriegaex thanks, will try to review asap. Corona has knocked me out.




> Option to include stdOut/stdErr console logs into test report
> -
>
> Key: SUREFIRE-2219
> URL: https://issues.apache.org/jira/browse/SUREFIRE-2219
> Project: Maven Surefire
>  Issue Type: New Feature
>  Components: Maven Surefire Report Plugin
>Affects Versions: 3.2.2
>Reporter: Alexander Kriegisch
>Priority: Major
> Attachments: image-2023-12-02-11-16-11-109.png
>
>
> Surefire report XML includes tags capturing console logs, e.g. 
> {{testsuite/testcase/system-err}}:
>  !image-2023-12-02-11-16-11-109.png! 
> As a report reader, I want to see the stdOut/stdErr console logs per test 
> case in the HTML report, ideally in a monotype font to easily be able to read 
> stack traces.
> This requirement has been discussed online a lot, e.g. on Stack Overflow or 
> Reddit. I wonder why such a feature is missing. The HTML report basically 
> being an XML transformation from the surefire report, it should not be super 
> complicated to implement.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


Re: [PR] [SUREFIRE-2219] Add test stdErr/stdOut output to ReportTestCase [maven-surefire]

2023-12-05 Thread via GitHub


michael-o commented on PR #692:
URL: https://github.com/apache/maven-surefire/pull/692#issuecomment-1842184343

   @kriegaex thanks, will try to review asap. Corona has knocked me out.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[jira] [Commented] (MBUILDCACHE-73) Add project version as additional property for reconcilation

2023-12-05 Thread Olivier Lamy (Jira)


[ 
https://issues.apache.org/jira/browse/MBUILDCACHE-73?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17793523#comment-17793523
 ] 

Olivier Lamy commented on MBUILDCACHE-73:
-

ideally we could simply add the project.version part of the checksum calculation

> Add project version as additional property for reconcilation
> 
>
> Key: MBUILDCACHE-73
> URL: https://issues.apache.org/jira/browse/MBUILDCACHE-73
> Project: Maven Build Cache Extension
>  Issue Type: New Feature
>Affects Versions: 1.0.1
>Reporter: Patrik Dudits
>Priority: Major
>
> Certain plugins or goals might require to run when project version changes 
> regardless of other inputs. A typical example would be {{deploy:deploy}} or 
> in my specific case {{docker:build}} - It is OK to reuse the build artifact, 
> but if version changed, I do want to upload it.
> Currently only way to achieve that is  to put the goal into {{runAlways}} 
> section. But that results in needles snapshots to be deployed or docker 
> images being built even if there's no relevant change.
> The reconcile section allows to specify properties for futher fine tuning the 
> input. These are limited to goal parameters, and neither of my examples 
> contain project version as a parameter, both use project model to fetch it.
> Proposal would be to extend tag {{reconcile}} either with:
>  * special magic name {{project.version}} to include version tracking, so 
> this could be achieved by {{}}
>  * attribute {{{}expression{}}}, to achieve the result with {{ propertyName="version" expression="${project.version}"/>}}
> * interpolating {{defaultValue}} attribute
> The second form would be preferrable as it has much larger scale of 
> application, I can imagine putting base docker image digests in environment 
> variable to invalidate builds when base tag gets updated. It is also more 
> discoverable than third option.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Created] (MNG-7952) Maven 3.9.x install:install-file doesn't recognize -Dpackaging

2023-12-05 Thread Wei-Chiu Chuang (Jira)
Wei-Chiu Chuang created MNG-7952:


 Summary: Maven 3.9.x install:install-file doesn't recognize 
-Dpackaging
 Key: MNG-7952
 URL: https://issues.apache.org/jira/browse/MNG-7952
 Project: Maven
  Issue Type: Bug
Affects Versions: 3.9.6
Reporter: Wei-Chiu Chuang


Hi there is a behavior change between Maven 3.8.8 and 3.9.6 where mvn 
install:install-file doesn't recognize -Dpackaging=exe

Reproducible on Apple Mac M3
{noformat}
PROTOBUF_VERSION="3.7.1"
curl -LO 
https://github.com/protocolbuffers/protobuf/releases/download/v${PROTOBUF_VERSION}/protobuf-all-${PROTOBUF_VERSION}.tar.gz
tar xzf protobuf-all-${PROTOBUF_VERSION}.tar.gz
cd protobuf-${PROTOBUF_VERSION}
./configure --disable-shared
make -j
mvn install:install-file -DgroupId=com.google.protobuf -DartifactId=protoc 
-Dversion=${PROTOBUF_VERSION} -Dclassifier=osx-aarch_64 -Dpackaging=exe 
-Dfile=src/protoc

{noformat}
Expected result (Maven 3.8 and below):
artifact installed at 
~/.m2/repository/com/google/protobuf/protoc/3.7.1/protoc-3.7.1-osx-aarch_64.exe

Incorrect result (Maven 3.9.x)
artifact installed at 
~/.m2/repository/com/google/protobuf/protoc/3.7.1/protoc-3.7.1-osx-aarch_64

 

Because of the missing suffix ".exe", Apache Ozone is not able to build on 
Apple Mac M3 using Maven 3.9.x. It works fine with Maven 3.8.x



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (SUREFIRE-2219) Option to include stdOut/stdErr console logs into test report

2023-12-05 Thread ASF GitHub Bot (Jira)


[ 
https://issues.apache.org/jira/browse/SUREFIRE-2219?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17793482#comment-17793482
 ] 

ASF GitHub Bot commented on SUREFIRE-2219:
--

kriegaex commented on PR #692:
URL: https://github.com/apache/maven-surefire/pull/692#issuecomment-1841974147

   @michael-o, FYI: I rebased on the latest changes, resolving a merge 
conflict, and also used `mvn spotless:apply` to satisfy the formatting build 
requirements.




> Option to include stdOut/stdErr console logs into test report
> -
>
> Key: SUREFIRE-2219
> URL: https://issues.apache.org/jira/browse/SUREFIRE-2219
> Project: Maven Surefire
>  Issue Type: New Feature
>  Components: Maven Surefire Report Plugin
>Affects Versions: 3.2.2
>Reporter: Alexander Kriegisch
>Priority: Major
> Attachments: image-2023-12-02-11-16-11-109.png
>
>
> Surefire report XML includes tags capturing console logs, e.g. 
> {{testsuite/testcase/system-err}}:
>  !image-2023-12-02-11-16-11-109.png! 
> As a report reader, I want to see the stdOut/stdErr console logs per test 
> case in the HTML report, ideally in a monotype font to easily be able to read 
> stack traces.
> This requirement has been discussed online a lot, e.g. on Stack Overflow or 
> Reddit. I wonder why such a feature is missing. The HTML report basically 
> being an XML transformation from the surefire report, it should not be super 
> complicated to implement.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


Re: [PR] [SUREFIRE-2219] Add test stdErr/stdOut output to ReportTestCase [maven-surefire]

2023-12-05 Thread via GitHub


kriegaex commented on PR #692:
URL: https://github.com/apache/maven-surefire/pull/692#issuecomment-1841974147

   @michael-o, FYI: I rebased on the latest changes, resolving a merge 
conflict, and also used `mvn spotless:apply` to satisfy the formatting build 
requirements.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[jira] [Commented] (SUREFIRE-2219) Option to include stdOut/stdErr console logs into test report

2023-12-05 Thread ASF GitHub Bot (Jira)


[ 
https://issues.apache.org/jira/browse/SUREFIRE-2219?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17793472#comment-17793472
 ] 

ASF GitHub Bot commented on SUREFIRE-2219:
--

kriegaex commented on PR #692:
URL: https://github.com/apache/maven-surefire/pull/692#issuecomment-1841925697

   > I also need to put other PRs into consider because of memory consumption, 
etc.
   
   Are we talking about memory consumption here or in the other PRs? What are 
you concerned about? The XML parser uses 
(SAX)[https://en.wikipedia.org/wiki/Simple_API_for_XML], not a DOM. Of course, 
the console log contents need to be stored in `ReportTestCase` properties 
subsequently, which necessarily uses more memory than the non-existence of such 
properties. If you are very concerned about this, you could make populating 
these fields optional. But then,
   
 * either users need to set two properties in two different plugins to 
activate console log reporting for tests,
 * or you need to always report console log entries, if they exist, 
assuming that if the user activated populating the fields she also wants to 
include them in the report, which is a reasonable assumption.




> Option to include stdOut/stdErr console logs into test report
> -
>
> Key: SUREFIRE-2219
> URL: https://issues.apache.org/jira/browse/SUREFIRE-2219
> Project: Maven Surefire
>  Issue Type: New Feature
>  Components: Maven Surefire Report Plugin
>Affects Versions: 3.2.2
>Reporter: Alexander Kriegisch
>Priority: Major
> Attachments: image-2023-12-02-11-16-11-109.png
>
>
> Surefire report XML includes tags capturing console logs, e.g. 
> {{testsuite/testcase/system-err}}:
>  !image-2023-12-02-11-16-11-109.png! 
> As a report reader, I want to see the stdOut/stdErr console logs per test 
> case in the HTML report, ideally in a monotype font to easily be able to read 
> stack traces.
> This requirement has been discussed online a lot, e.g. on Stack Overflow or 
> Reddit. I wonder why such a feature is missing. The HTML report basically 
> being an XML transformation from the surefire report, it should not be super 
> complicated to implement.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


Re: [PR] [SUREFIRE-2219] Add test stdErr/stdOut output to ReportTestCase [maven-surefire]

2023-12-05 Thread via GitHub


kriegaex commented on PR #692:
URL: https://github.com/apache/maven-surefire/pull/692#issuecomment-1841925697

   > I also need to put other PRs into consider because of memory consumption, 
etc.
   
   Are we talking about memory consumption here or in the other PRs? What are 
you concerned about? The XML parser uses 
(SAX)[https://en.wikipedia.org/wiki/Simple_API_for_XML], not a DOM. Of course, 
the console log contents need to be stored in `ReportTestCase` properties 
subsequently, which necessarily uses more memory than the non-existence of such 
properties. If you are very concerned about this, you could make populating 
these fields optional. But then,
   
 * either users need to set two properties in two different plugins to 
activate console log reporting for tests,
 * or you need to always report console log entries, if they exist, 
assuming that if the user activated populating the fields she also wants to 
include them in the report, which is a reasonable assumption.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] Bump ch.qos.logback:logback-classic from 1.2.3 to 1.3.12 in /surefire-its/src/test/resources/surefire-1659-stream-corruption [maven-surefire]

2023-12-05 Thread via GitHub


dependabot[bot] commented on PR #691:
URL: https://github.com/apache/maven-surefire/pull/691#issuecomment-1841731235

   Superseded by #696.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] Bump ch.qos.logback:logback-classic from 1.2.3 to 1.3.12 in /surefire-its/src/test/resources/surefire-1659-stream-corruption [maven-surefire]

2023-12-05 Thread via GitHub


dependabot[bot] closed pull request #691: Bump ch.qos.logback:logback-classic 
from 1.2.3 to 1.3.12 in 
/surefire-its/src/test/resources/surefire-1659-stream-corruption
URL: https://github.com/apache/maven-surefire/pull/691


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[PR] Bump ch.qos.logback:logback-classic from 1.2.3 to 1.2.13 in /surefire-its/src/test/resources/surefire-1659-stream-corruption [maven-surefire]

2023-12-05 Thread via GitHub


dependabot[bot] opened a new pull request, #696:
URL: https://github.com/apache/maven-surefire/pull/696

   Bumps [ch.qos.logback:logback-classic](https://github.com/qos-ch/logback) 
from 1.2.3 to 1.2.13.
   
   Commits
   
   https://github.com/qos-ch/logback/commit/2648b9e7fbb47426c89b9c93b411c07484e8f277";>2648b9e
 prepare release 1.2.13
   https://github.com/qos-ch/logback/commit/bb095154be011267b64e37a1d401546e7cc2b7c3";>bb09515
 fix CVE-2023-6378
   https://github.com/qos-ch/logback/commit/45732949bfb845df04cbe65292cf48aaa090cb1d";>4573294
 start work on 1.2.13-SNAPSHOT
   https://github.com/qos-ch/logback/commit/a388193052c298ca87cc64192319df723288c6ab";>a388193
 Merge branch 'branch_1.2.x' of github.com:qos-ch/logback into branch_1.2.x
   https://github.com/qos-ch/logback/commit/de44dc422bc3da1d7808283851324d960b492d4d";>de44dc4
 prepare release 1.2.12
   https://github.com/qos-ch/logback/commit/ca0cf172f680308938515b8a5d69348759ee947c";>ca0cf17
 Merge pull request https://redirect.github.com/qos-ch/logback/issues/532";>#532 from 
joakime/fix-jetty-requestlog
   https://github.com/qos-ch/logback/commit/e31609b1980b9ba986344aae3cab7275fa2b4935";>e31609b
 removed unused files
   https://github.com/qos-ch/logback/commit/21e29efb284766f386781175b2ba18585b690154";>21e29ef
 Merge pull request https://redirect.github.com/qos-ch/logback/issues/567";>#567 from 
spliffone/LOGBACK-1633
   https://github.com/qos-ch/logback/commit/e869000e1d5901e6aa6f46cc6575ee2137f15b69";>e869000
 fix: published POM file contain the wrong scm URL
   https://github.com/qos-ch/logback/commit/009ea46cb81a015f2ca312bde6e823581b93b37a";>009ea46
 version for next dev cycle
   Additional commits viewable in https://github.com/qos-ch/logback/compare/v_1.2.3...v_1.2.13";>compare 
view
   
   
   
   
   
   [![Dependabot compatibility 
score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=ch.qos.logback:logback-classic&package-manager=maven&previous-version=1.2.3&new-version=1.2.13)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)
   
   Dependabot will resolve any conflicts with this PR as long as you don't 
alter it yourself. You can also trigger a rebase manually by commenting 
`@dependabot rebase`.
   
   [//]: # (dependabot-automerge-start)
   [//]: # (dependabot-automerge-end)
   
   ---
   
   
   Dependabot commands and options
   
   
   You can trigger Dependabot actions by commenting on this PR:
   - `@dependabot rebase` will rebase this PR
   - `@dependabot recreate` will recreate this PR, overwriting any edits that 
have been made to it
   - `@dependabot merge` will merge this PR after your CI passes on it
   - `@dependabot squash and merge` will squash and merge this PR after your CI 
passes on it
   - `@dependabot cancel merge` will cancel a previously requested merge and 
block automerging
   - `@dependabot reopen` will reopen this PR if it is closed
   - `@dependabot close` will close this PR and stop Dependabot recreating it. 
You can achieve the same result by closing it manually
   - `@dependabot show  ignore conditions` will show all of 
the ignore conditions of the specified dependency
   - `@dependabot ignore this major version` will close this PR and stop 
Dependabot creating any more for this major version (unless you reopen the PR 
or upgrade to it yourself)
   - `@dependabot ignore this minor version` will close this PR and stop 
Dependabot creating any more for this minor version (unless you reopen the PR 
or upgrade to it yourself)
   - `@dependabot ignore this dependency` will close this PR and stop 
Dependabot creating any more for this dependency (unless you reopen the PR or 
upgrade to it yourself)
   You can disable automated security fix PRs for this repo from the [Security 
Alerts page](https://github.com/apache/maven-surefire/network/alerts).
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[PR] Add a flattenDependencyNodes method accepting a DependencyFilter [maven-resolver]

2023-12-05 Thread via GitHub


gnodet opened a new pull request, #388:
URL: https://github.com/apache/maven-resolver/pull/388

   (no comment)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] Bump ch.qos.logback:logback-classic from 1.2.11 to 1.3.12 [maven]

2023-12-05 Thread via GitHub


dependabot[bot] closed pull request #1329: Bump ch.qos.logback:logback-classic 
from 1.2.11 to 1.3.12
URL: https://github.com/apache/maven/pull/1329


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] Bump ch.qos.logback:logback-classic from 1.2.11 to 1.3.12 [maven]

2023-12-05 Thread via GitHub


dependabot[bot] commented on PR #1329:
URL: https://github.com/apache/maven/pull/1329#issuecomment-1841703027

   Superseded by #1331.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[PR] Bump ch.qos.logback:logback-classic from 1.2.11 to 1.2.13 [maven]

2023-12-05 Thread via GitHub


dependabot[bot] opened a new pull request, #1331:
URL: https://github.com/apache/maven/pull/1331

   Bumps [ch.qos.logback:logback-classic](https://github.com/qos-ch/logback) 
from 1.2.11 to 1.2.13.
   
   Commits
   
   https://github.com/qos-ch/logback/commit/2648b9e7fbb47426c89b9c93b411c07484e8f277";>2648b9e
 prepare release 1.2.13
   https://github.com/qos-ch/logback/commit/bb095154be011267b64e37a1d401546e7cc2b7c3";>bb09515
 fix CVE-2023-6378
   https://github.com/qos-ch/logback/commit/45732949bfb845df04cbe65292cf48aaa090cb1d";>4573294
 start work on 1.2.13-SNAPSHOT
   https://github.com/qos-ch/logback/commit/a388193052c298ca87cc64192319df723288c6ab";>a388193
 Merge branch 'branch_1.2.x' of github.com:qos-ch/logback into branch_1.2.x
   https://github.com/qos-ch/logback/commit/de44dc422bc3da1d7808283851324d960b492d4d";>de44dc4
 prepare release 1.2.12
   https://github.com/qos-ch/logback/commit/ca0cf172f680308938515b8a5d69348759ee947c";>ca0cf17
 Merge pull request https://redirect.github.com/qos-ch/logback/issues/532";>#532 from 
joakime/fix-jetty-requestlog
   https://github.com/qos-ch/logback/commit/e31609b1980b9ba986344aae3cab7275fa2b4935";>e31609b
 removed unused files
   https://github.com/qos-ch/logback/commit/21e29efb284766f386781175b2ba18585b690154";>21e29ef
 Merge pull request https://redirect.github.com/qos-ch/logback/issues/567";>#567 from 
spliffone/LOGBACK-1633
   https://github.com/qos-ch/logback/commit/e869000e1d5901e6aa6f46cc6575ee2137f15b69";>e869000
 fix: published POM file contain the wrong scm URL
   https://github.com/qos-ch/logback/commit/009ea46cb81a015f2ca312bde6e823581b93b37a";>009ea46
 version for next dev cycle
   Additional commits viewable in https://github.com/qos-ch/logback/compare/v_1.2.11...v_1.2.13";>compare 
view
   
   
   
   
   
   [![Dependabot compatibility 
score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=ch.qos.logback:logback-classic&package-manager=maven&previous-version=1.2.11&new-version=1.2.13)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)
   
   Dependabot will resolve any conflicts with this PR as long as you don't 
alter it yourself. You can also trigger a rebase manually by commenting 
`@dependabot rebase`.
   
   [//]: # (dependabot-automerge-start)
   [//]: # (dependabot-automerge-end)
   
   ---
   
   
   Dependabot commands and options
   
   
   You can trigger Dependabot actions by commenting on this PR:
   - `@dependabot rebase` will rebase this PR
   - `@dependabot recreate` will recreate this PR, overwriting any edits that 
have been made to it
   - `@dependabot merge` will merge this PR after your CI passes on it
   - `@dependabot squash and merge` will squash and merge this PR after your CI 
passes on it
   - `@dependabot cancel merge` will cancel a previously requested merge and 
block automerging
   - `@dependabot reopen` will reopen this PR if it is closed
   - `@dependabot close` will close this PR and stop Dependabot recreating it. 
You can achieve the same result by closing it manually
   - `@dependabot show  ignore conditions` will show all of 
the ignore conditions of the specified dependency
   - `@dependabot ignore this major version` will close this PR and stop 
Dependabot creating any more for this major version (unless you reopen the PR 
or upgrade to it yourself)
   - `@dependabot ignore this minor version` will close this PR and stop 
Dependabot creating any more for this minor version (unless you reopen the PR 
or upgrade to it yourself)
   - `@dependabot ignore this dependency` will close this PR and stop 
Dependabot creating any more for this dependency (unless you reopen the PR or 
upgrade to it yourself)
   You can disable automated security fix PRs for this repo from the [Security 
Alerts page](https://github.com/apache/maven/network/alerts).
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] Bump mavenVersion from 3.2.5 to 3.9.6 [maven-scm]

2023-12-05 Thread via GitHub


dependabot[bot] commented on PR #188:
URL: https://github.com/apache/maven-scm/pull/188#issuecomment-1841441212

   OK, I won't notify you about any of these dependencies again, unless you 
re-open this PR.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] Bump mavenVersion from 3.2.5 to 3.9.6 [maven-scm]

2023-12-05 Thread via GitHub


dependabot[bot] closed pull request #188: Bump mavenVersion from 3.2.5 to 3.9.6
URL: https://github.com/apache/maven-scm/pull/188


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] Bump mavenVersion from 3.2.5 to 3.9.6 [maven-scm]

2023-12-05 Thread via GitHub


slachiewicz commented on PR #188:
URL: https://github.com/apache/maven-scm/pull/188#issuecomment-1841441135

   @dependabot ignore this dependency


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] Update UTs regarding deprecations [maven-resolver]

2023-12-05 Thread via GitHub


cstamas merged PR #387:
URL: https://github.com/apache/maven-resolver/pull/387


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[PR] Just a general code health improvement [maven-resolver]

2023-12-05 Thread via GitHub


cstamas opened a new pull request, #387:
URL: https://github.com/apache/maven-resolver/pull/387

   With latest changes there were some deprecations,
   most notably the default ctor of DRSS. Due that
   the build started emitting quite some warning
   messages during build.
   
   This is not lowered to 2 warnings for whole build.
   There is no issue for this, as these changes are all happening in UTs.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[PR] Bump minaSshdVersion from 2.9.2 to 2.11.0 [maven-scm]

2023-12-05 Thread via GitHub


dependabot[bot] opened a new pull request, #190:
URL: https://github.com/apache/maven-scm/pull/190

   Bumps `minaSshdVersion` from 2.9.2 to 2.11.0.
   Updates `org.apache.sshd:sshd-git` from 2.9.2 to 2.11.0
   
   Release notes
   Sourced from https://github.com/apache/mina-sshd/releases";>org.apache.sshd:sshd-git's 
releases.
   
   SSHD 2.11.0
   Introduced in 2.11.0
   This new minor release provides a bunch of bug fixes and enhancements.
   This release is available for download from the https://mina.apache.org/sshd-project/download_2.11.0.html";>Apache MINA 
SSHD website.
   Bug Fixes
   
   https://redirect.github.com/apache/mina-sshd/issues/328";>GH-328 Added 
configurable timeout(s) to DefaultSftpClient
   https://redirect.github.com/apache/mina-sshd/issues/370";>GH-370 Also 
compare file keys in ModifiableFileWatcher.
   https://redirect.github.com/apache/mina-sshd/issues/371";>GH-371 Fix 
channel pool in SftpFileSystem.
   https://redirect.github.com/apache/mina-sshd/issues/383";>GH-383 Use 
correct default OpenOptions in 
SftpFileSystemProvider.newFileChannel().
   https://redirect.github.com/apache/mina-sshd/issues/384";>GH-384 Use 
correct lock modes for SFTP FileChannel.lock().
   https://redirect.github.com/apache/mina-sshd/issues/388";>GH-388 
ScpClient: support issuing commands to a server that uses a 
non-UTF-8 locale.
   https://redirect.github.com/apache/mina-sshd/issues/398";>GH-398 
SftpInputStreamAsync: fix reporting EOF on zero-length reads.
   https://redirect.github.com/apache/mina-sshd/issues/403";>GH-403 
Work-around a bug in WS_FTP <= 12.9 SFTP clients.
   https://redirect.github.com/apache/mina-sshd/issues/407";>GH-407 
(Regression in 2.10.0) SFTP performance fix: override 
FilterOutputStream.write(byte[], int, int).
   https://redirect.github.com/apache/mina-sshd/issues/410";>GH-410 Fix a 
race condition to ensure SSH_MSG_CHANNEL_EOF is always sent before 
SSH_MSG_CHANNEL_CLOSE.
   https://redirect.github.com/apache/mina-sshd/issues/414";>GH-414 Fix 
error handling while flushing queued packets at end of KEX.
   https://redirect.github.com/apache/mina-sshd/issues/420";>GH-420 Fix 
wrong log level on closing an Nio2Session.
   https://issues.apache.org/jira/browse/SSHD-789";>SSHD-789 
Fix detection of Android O/S from system properties.
   https://issues.apache.org/jira/browse/SSHD-1259";>SSHD-1259 
Consider all applicable host keys from the known_hosts files.
   https://issues.apache.org/jira/browse/SSHD-1310";>SSHD-1310 
SftpFileSystem: do not close user session.
   https://issues.apache.org/jira/browse/SSHD-1327";>SSHD-1327 
ChannelAsyncOutputStream: remove write future when done.
   https://issues.apache.org/jira/browse/SSHD-1332";>SSHD-1332 
(Regression in 2.10.0) Resolve ~ in IdentityFile file names in 
HostConfigEntry.
   
   New Features
   
   https://issues.apache.org/jira/browse/SSHD-1330";>SSHD-1330 
Use KeepAliveHandler global request instance in client as well
   https://redirect.github.com/apache/mina-sshd/issues/356";>GH-356 
Publish snapshot maven artifacts to the https://repository.apache.org/content/repositories/snapshots";>Apache 
Snapshots maven repository.
   Bundle sshd-contrib has support classes for the https://www.haproxy.org/download/2.7/doc/proxy-protocol.txt";>HAProxy 
protocol V2.
   
   Behavioral changes and enhancements
   SFTP file handle size
   Previous versions of Apache MINA sshd used SFTP file handles that were 
twice as large as configured via 
SftpModuleProperties.FILE_HANDLE_SIZE. The reason for this was 
that the file handle bytes were stringified, representing each byte as two hex 
characters. This stringified file handle was then send over the wire. If 
SftpModuleProperties.FILE_HANDLE_SIZE was configured as 16, the 
actual file handle size was thus 32 bytes.
   This has been fixed in this version.
   Additionally, the default setting for the size of file handles has been 
changed from 16 to 4 bytes. OpenSSH also uses 4-byte SFTP file handles. Using 
the same size not only means that there is a little more space left in SSH 
packets for actual data transfer, it also completely avoids the WS_FTP bug 
mentioned in https://redirect.github.com/apache/mina-sshd/issues/403";>GH-403.
   Potential compatibility issues
   KeepAliveHandler global request handler moved from server 
to common global requests package
   Was previously only on server-side - now also for client (see https://issues.apache.org/jira/browse/SSHD-1330";>SSHD-1330). This 
should be fully backward compatible since most servers do not send this 
request. However, if users have somehow added this handler to the client side 
independently, the code should be re-examined and the independent handler 
removed or make it replace the global one.
   Server-side SFTP file handle encoding
   
   
   ... (truncated)
   
   
   Changelog
   Sourced from https://github.com/apache/mina-sshd/blob/master/CHANGES.md";>org.apache.sshd:sshd-git's
 changelog.
   
   https://github.com/apa

[PR] Bump org.apache.commons:commons-text from 1.10.0 to 1.11.0 [maven-scm]

2023-12-05 Thread via GitHub


dependabot[bot] opened a new pull request, #189:
URL: https://github.com/apache/maven-scm/pull/189

   Bumps org.apache.commons:commons-text from 1.10.0 to 1.11.0.
   
   
   [![Dependabot compatibility 
score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=org.apache.commons:commons-text&package-manager=maven&previous-version=1.10.0&new-version=1.11.0)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)
   
   Dependabot will resolve any conflicts with this PR as long as you don't 
alter it yourself. You can also trigger a rebase manually by commenting 
`@dependabot rebase`.
   
   [//]: # (dependabot-automerge-start)
   [//]: # (dependabot-automerge-end)
   
   ---
   
   
   Dependabot commands and options
   
   
   You can trigger Dependabot actions by commenting on this PR:
   - `@dependabot rebase` will rebase this PR
   - `@dependabot recreate` will recreate this PR, overwriting any edits that 
have been made to it
   - `@dependabot merge` will merge this PR after your CI passes on it
   - `@dependabot squash and merge` will squash and merge this PR after your CI 
passes on it
   - `@dependabot cancel merge` will cancel a previously requested merge and 
block automerging
   - `@dependabot reopen` will reopen this PR if it is closed
   - `@dependabot close` will close this PR and stop Dependabot recreating it. 
You can achieve the same result by closing it manually
   - `@dependabot show  ignore conditions` will show all of 
the ignore conditions of the specified dependency
   - `@dependabot ignore this major version` will close this PR and stop 
Dependabot creating any more for this major version (unless you reopen the PR 
or upgrade to it yourself)
   - `@dependabot ignore this minor version` will close this PR and stop 
Dependabot creating any more for this minor version (unless you reopen the PR 
or upgrade to it yourself)
   - `@dependabot ignore this dependency` will close this PR and stop 
Dependabot creating any more for this dependency (unless you reopen the PR or 
upgrade to it yourself)
   
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[PR] Bump mavenVersion from 3.2.5 to 3.9.6 [maven-scm]

2023-12-05 Thread via GitHub


dependabot[bot] opened a new pull request, #188:
URL: https://github.com/apache/maven-scm/pull/188

   Bumps `mavenVersion` from 3.2.5 to 3.9.6.
   Updates `org.apache.maven:maven-plugin-api` from 3.2.5 to 3.9.6
   
   Release notes
   Sourced from https://github.com/apache/maven/releases";>org.apache.maven:maven-plugin-api's
 releases.
   
   3.9.6
   https://maven.apache.org/docs/3.9.6/release-notes.html";>Release 
Notes - Maven - Version 3.9.6
   Improvement
   
   [https://issues.apache.org/jira/browse/MNG-7939";>MNG-7939] 
- Allow to exclude plugins from validation
   
   Dependency upgrade
   
   [https://issues.apache.org/jira/browse/MNG-7913";>MNG-7913] 
- Upgrade Sisu version to 0.9.0.M2
   [https://issues.apache.org/jira/browse/MNG-7934";>MNG-7934] 
- Upgrade Resolver version to 1.9.18
   [https://issues.apache.org/jira/browse/MNG-7942";>MNG-7942] 
- Upgrade to parent POM 41
   [https://issues.apache.org/jira/browse/MNG-7943";>MNG-7943] 
- Upgrade default plugin bindings
   
   3.9.5
   https://maven.apache.org/docs/3.9.5/release-notes.html";>Release 
Notes - Maven - Version 3.9.5
   Bug
   
   [https://issues.apache.org/jira/browse/MNG-7851";>MNG-7851] 
- Error message when modelVersion is 4.0 is confusing
   
   Improvement
   
   [https://issues.apache.org/jira/browse/MNG-7875";>MNG-7875] 
- colorize transfer messages
   [https://issues.apache.org/jira/browse/MNG-7895";>MNG-7895] 
- Support ${project.basedir} in file profile activation
   
   Task
   
   [https://issues.apache.org/jira/browse/MNG-7856";>MNG-7856] 
- Maven Resolver Provider classes ctor change
   [https://issues.apache.org/jira/browse/MNG-7870";>MNG-7870] 
- Undeprecate wrongly deprecated repository metadata
   [https://issues.apache.org/jira/browse/MNG-7872";>MNG-7872] 
- Deprecate org.apache.maven.repository.internal.MavenResolverModule
   [https://issues.apache.org/jira/browse/MNG-7874";>MNG-7874] 
- maven-resolver-provider: introduce NAME constants.
   
   Dependency upgrade
   
   [https://issues.apache.org/jira/browse/MNG-7859";>MNG-7859] 
- Update to Resolver 1.9.16
   
   3.9.4
   https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12316922&version=12353369";>Release
 Notes - Maven - Version 3.9.4
   
   
   ... (truncated)
   
   
   Commits
   
   https://github.com/apache/maven/commit/bc0240f3c744dd6b6ec2920b3cd08dcc295161ae";>bc0240f
 [maven-release-plugin] prepare release maven-3.9.6
   https://github.com/apache/maven/commit/e6cc6c53cb979f46e7cf97fc9bab686343500a94";>e6cc6c5
 [MNG-7943] Upgrade default plugin bindings
   https://github.com/apache/maven/commit/48adee3711705c65918b2c736e88093a052f30f8";>48adee3
 [MNG-7934] Update to Resolver 1.9.18 (https://redirect.github.com/apache/maven/issues/1326";>#1326)
   https://github.com/apache/maven/commit/da6c7e4bcac34677ad9e7d93f345d9c896866e1b";>da6c7e4
 [MNG-7942] Upgrade maven-parent to 41
   https://github.com/apache/maven/commit/95fa548e1db672ac7b102ff27585c82ed5ae9ed2";>95fa548
 [MNG-7934] Update to Resolver 1.9.17 (https://redirect.github.com/apache/maven/issues/1321";>#1321)
   https://github.com/apache/maven/commit/c54baa64b38c09c440a11285d560e47d894b2414";>c54baa6
 [MNG-7939] Allow to exclude plugins from validation
   https://github.com/apache/maven/commit/ecd59b7158e048a6298b8b52d44fccaba26065ad";>ecd59b7
 [MNG-7913] Upgrade Sisu version (https://redirect.github.com/apache/maven/issues/1286";>#1286)
   https://github.com/apache/maven/commit/53edd71c989d8f2f2b92ee0b281976772c78b927";>53edd71
 Use the same branch name for ITs on Jenkins (https://redirect.github.com/apache/maven/issues/1263";>#1263)
   https://github.com/apache/maven/commit/2bc44491af62fef51e17d6ad0172baff82c8d022";>2bc4449
 The maven-3.9.x branch should fallback to maven-3.9.x branch of ITs
   https://github.com/apache/maven/commit/6e532cd249c0413fb6885ca6dfcc67dce25f703d";>6e532cd
 [maven-release-plugin] prepare for next development iteration
   Additional commits viewable in https://github.com/apache/maven/compare/maven-3.2.5...maven-3.9.6";>compare
 view
   
   
   
   
   Updates `org.apache.maven:maven-core` from 3.2.5 to 3.9.6
   
   Release notes
   Sourced from https://github.com/apache/maven/releases";>org.apache.maven:maven-core's 
releases.
   
   3.9.6
   https://maven.apache.org/docs/3.9.6/release-notes.html";>Release 
Notes - Maven - Version 3.9.6
   Improvement
   
   [https://issues.apache.org/jira/browse/MNG-7939";>MNG-7939] 
- Allow to exclude plugins from validation
   
   Dependency upgrade
   
   [https://issues.apache.org/jira/browse/MNG-7913";>MNG-7913] 
- Upgrade Sisu version to 0.9.0.M2
   [https://issues.apache.org/jira/browse/MNG-7934";>MNG-7934] 
- Upgrade Resolver version to 1.9.18
   [https://issues.apache.org/jira/browse/MNG-7942";>MNG-7942] 
- Upgrade to parent POM 41
   [https://issues.apache.org/jira/browse/MNG-7943";>MNG-7943] 
- Upgrade default plugin bindings
   
   3.9.5
   https://maven.apache.org/docs/3.9.5/release-notes.html";>Release 
No

[PR] Bump org.apache.commons:commons-lang3 from 3.11 to 3.14.0 [maven-scm]

2023-12-05 Thread via GitHub


dependabot[bot] opened a new pull request, #187:
URL: https://github.com/apache/maven-scm/pull/187

   Bumps org.apache.commons:commons-lang3 from 3.11 to 3.14.0.
   
   
   [![Dependabot compatibility 
score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=org.apache.commons:commons-lang3&package-manager=maven&previous-version=3.11&new-version=3.14.0)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)
   
   Dependabot will resolve any conflicts with this PR as long as you don't 
alter it yourself. You can also trigger a rebase manually by commenting 
`@dependabot rebase`.
   
   [//]: # (dependabot-automerge-start)
   [//]: # (dependabot-automerge-end)
   
   ---
   
   
   Dependabot commands and options
   
   
   You can trigger Dependabot actions by commenting on this PR:
   - `@dependabot rebase` will rebase this PR
   - `@dependabot recreate` will recreate this PR, overwriting any edits that 
have been made to it
   - `@dependabot merge` will merge this PR after your CI passes on it
   - `@dependabot squash and merge` will squash and merge this PR after your CI 
passes on it
   - `@dependabot cancel merge` will cancel a previously requested merge and 
block automerging
   - `@dependabot reopen` will reopen this PR if it is closed
   - `@dependabot close` will close this PR and stop Dependabot recreating it. 
You can achieve the same result by closing it manually
   - `@dependabot show  ignore conditions` will show all of 
the ignore conditions of the specified dependency
   - `@dependabot ignore this major version` will close this PR and stop 
Dependabot creating any more for this major version (unless you reopen the PR 
or upgrade to it yourself)
   - `@dependabot ignore this minor version` will close this PR and stop 
Dependabot creating any more for this minor version (unless you reopen the PR 
or upgrade to it yourself)
   - `@dependabot ignore this dependency` will close this PR and stop 
Dependabot creating any more for this dependency (unless you reopen the PR or 
upgrade to it yourself)
   
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[jira] [Commented] (MPMD-386) Resolution of suppression file failes using the "-f" parameter since 3.1.5.0

2023-12-05 Thread Jira


[ 
https://issues.apache.org/jira/browse/MPMD-386?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17793339#comment-17793339
 ] 

Matthias Bünger commented on MPMD-386:
--

After having a talk with [~khmarbaise] that a reproducer would be helpful, I've 
created one: Please see this github project: https://github.com/Bukama/mpmd386

> Resolution of suppression file failes using the "-f" parameter since 3.1.5.0
> 
>
> Key: MPMD-386
> URL: https://issues.apache.org/jira/browse/MPMD-386
> Project: Maven PMD Plugin
>  Issue Type: Bug
>  Components: PMD
>Affects Versions: 3.15.0, 3.16.0, 3.17.0, 3.18.0, 3.19.0, 3.20.0, 3.21.0
>Reporter: Matthias Bünger
>Priority: Major
> Attachments: meta-pom.xml
>
>
> I finally upgraded the maven-pmd-update of our meta POM, because I always 
> forgot to upgrade this particular one too. I tried to upgrade from 3.12.0 to 
> 3.21.0, but realized that our local and CI builds break after upgrading, 
> becuase our exclude files are not found anymore, when using the "{{{}-f{}}}" 
> parameter.
> I could nail it down that the break comes with 3.15.0, but I can not explain 
> why. The only ticket I could imagine to has something to do with it is 
> MPMD-323, but this is of 3.16.0, so I might be wrong at all.
> Background and setup:
> We have tons of Maven projects within own repositories, each with one of the 
> four structure:
> a) Single or multi-module project
> b) Root-pom in root directory or in a folder below
> The pmd-excludes file lies in same folder as the root-pom. So we have the 
> following setups
> Single-module
> {code}
> /
> ├─ src/
> │  ├─ ...
> ├─ pom.xml
> ├─ exclude-pmd.properties
>  
> /
> ├─ componentDir
>    ├─ src/
>    │  ├─ ...
>    ├─ pom.xml
>    ├─ exclude-pmd.properties
> {code}
> Same for multi module
> {code}
> /
> ├─ moduleA
> │  ├─src/
> │  │  ├─ ...
> ├─ moduleb
> │  ├─src/
> │  │  ├─ ...
> ├─ pom.xml
> ├─ exclude-pmd.properties
> /
> ├─ componentDir
>   ├─ moduleA
>   │  ├─src/
>   │  │  ├─ ...
>   ├─ moduleb
>   │  ├─src/
>   │  │  ├─ ...
>   ├─ pom.xml
>   ├─ exclude-pmd.properties
> {code}
> As we have so many Maven projects we don't create individual Jenkins 
> pipelines for each of them due the massive amount of work needed to maintain 
> them. The call this in one of the two ways, depending on the the pipeline 
> (verify or site), both using the "{{{}-f{}}}" parameter. On local developer 
> machines we just start the build in die root pom directory without the 
> "{{{}-f{}}}" parameter.
> While the resolution of the suppression file of the maven checkstyle plugin 
> works like a charm by only using this
> {code:xml}
>   
>     
>       
>         org.apache.maven.plugins
>         maven-checkstyle-plugin
>         
>           
> checkstyle-suppressions.xml
>         
>       
>     
>   
> {code}
> The resolution of the suppression file of the pmd plugin worked somehow 
> different, so we used the following universal approach to make it work for 
> all our projects
> {code:xml}
>   
>     
>       
>         org.apache.maven.plugins
>         maven-pmd-plugin
>         
>           
> ${path.to.suppressfile.wo.slash}/exclude-pmd.properties
>         
>       
>     
>   
> {code}
> where "path.to.suppressfile.wo.slash" is
> {code:xml}
> multi-module
> 
> ${project.basedir}/..
> single-module
> ${project.basedir}
> {code}
> This worked until 3.14.0, but failed after I upgraded to 3.15.0 in local and 
> Jenkins builds.
> I could make the local build work again by changing the configuration to the 
> same as the checkstyle plugin
> {code:xml}
> exclude-pmd.properties
> {code}
> When I looked at the changes made in MPMD-323, it seems to only affect the 
> ruleset file, but it seems to also affects the suppression file, as the maven 
> build fails when using the "{{{}-f{}}}" parameter.
> As this is my first time I get closer in contact with the PMD plugin sources 
> I can't provide any more information right but, except the fact that the 
> checkstyle plugin never had these kind of issues starting to use it in 2016 
> up to current version 3.3.0.
> Full example meta-pom attached.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Created] (MCOMPILER-561) Add new rebuild detection for bytecode changes

2023-12-05 Thread Jira
Jorge Solórzano created MCOMPILER-561:
-

 Summary: Add new rebuild detection for bytecode changes
 Key: MCOMPILER-561
 URL: https://issues.apache.org/jira/browse/MCOMPILER-561
 Project: Maven Compiler Plugin
  Issue Type: Improvement
Affects Versions: 3.11.0
Reporter: Jorge Solórzano


If the source code changes the bytecode version, it should trigger a rebuild.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


Re: [PR] Bump org.codehaus.plexus:plexus-xml from 3.0.0 to 4.0.2 [maven-compiler-plugin]

2023-12-05 Thread via GitHub


dependabot[bot] commented on PR #212:
URL: 
https://github.com/apache/maven-compiler-plugin/pull/212#issuecomment-1840940773

   OK, I won't notify you about version 4.x.x again, unless you re-open this PR.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] Bump org.codehaus.plexus:plexus-xml from 3.0.0 to 4.0.2 [maven-compiler-plugin]

2023-12-05 Thread via GitHub


dependabot[bot] closed pull request #212: Bump org.codehaus.plexus:plexus-xml 
from 3.0.0 to 4.0.2
URL: https://github.com/apache/maven-compiler-plugin/pull/212


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] Bump org.codehaus.plexus:plexus-xml from 3.0.0 to 4.0.2 [maven-compiler-plugin]

2023-12-05 Thread via GitHub


slawekjaranowski commented on PR #212:
URL: 
https://github.com/apache/maven-compiler-plugin/pull/212#issuecomment-1840940673

   @dependabot ignore this major version


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[PR] Bump org.codehaus.plexus:plexus-xml from 3.0.0 to 4.0.2 [maven-compiler-plugin]

2023-12-05 Thread via GitHub


dependabot[bot] opened a new pull request, #212:
URL: https://github.com/apache/maven-compiler-plugin/pull/212

   Bumps 
[org.codehaus.plexus:plexus-xml](https://github.com/codehaus-plexus/plexus-xml) 
from 3.0.0 to 4.0.2.
   
   Release notes
   Sourced from https://github.com/codehaus-plexus/plexus-xml/releases";>org.codehaus.plexus:plexus-xml's
 releases.
   
   Plexus XML 4.0.2
   What's Changed
   
   Cleanup after parent pom upgrade by https://github.com/slachiewicz";>@​slachiewicz in https://redirect.github.com/codehaus-plexus/plexus-xml/pull/22";>codehaus-plexus/plexus-xml#22
   Upgrade to 4.0.0-alpha-7 and exclude dependency to sisu (fixes https://redirect.github.com/codehaus-plexus/plexus-xml/issues/17";>#17)
 by https://github.com/gnodet";>@​gnodet in https://redirect.github.com/codehaus-plexus/plexus-xml/pull/23";>codehaus-plexus/plexus-xml#23
   
   New Contributors
   
   https://github.com/slachiewicz";>@​slachiewicz 
made their first contribution in https://redirect.github.com/codehaus-plexus/plexus-xml/pull/22";>codehaus-plexus/plexus-xml#22
   
   Full Changelog: https://github.com/codehaus-plexus/plexus-xml/compare/plexus-xml-4.0.1...plexus-xml-4.0.2";>https://github.com/codehaus-plexus/plexus-xml/compare/plexus-xml-4.0.1...plexus-xml-4.0.2
   4.0.0
   
   
   Use spotless (https://redirect.github.com/codehaus-plexus/plexus-xml/pull/8";>#8) https://github.com/gnodet";>@​gnodet
   Fix site generation (https://redirect.github.com/codehaus-plexus/plexus-xml/pull/15";>#15) 
https://github.com/gnodet";>@​gnodet
   Switch build ci workflow to master branch (https://redirect.github.com/codehaus-plexus/plexus-xml/pull/14";>#14) 
https://github.com/gnodet";>@​gnodet
   Fix SCM urls (https://redirect.github.com/codehaus-plexus/plexus-xml/pull/13";>#13) 
https://github.com/gnodet";>@​gnodet
   MXParser tokenization fails when PI is before first tag (fixes https://redirect.github.com/codehaus-plexus/plexus-xml/issues/7";>#7) 
(https://redirect.github.com/codehaus-plexus/plexus-xml/pull/12";>#12) 
https://github.com/gnodet";>@​gnodet
   Deprecate Xpp3DomUtils (fixes https://redirect.github.com/codehaus-plexus/plexus-xml/issues/6";>#6) 
(https://redirect.github.com/codehaus-plexus/plexus-xml/pull/9";>#9) https://github.com/gnodet";>@​gnodet
   Use a ArrayDeque (https://redirect.github.com/codehaus-plexus/plexus-xml/pull/5";>#5) https://github.com/gnodet";>@​gnodet
   Upgrade plugins and clean build warnings (https://redirect.github.com/codehaus-plexus/plexus-xml/pull/4";>#4) https://github.com/gnodet";>@​gnodet
   Switch to junit 5 (https://redirect.github.com/codehaus-plexus/plexus-xml/pull/2";>#2) https://github.com/gnodet";>@​gnodet
   Fix parsing an UTF-8 file without BOM and ISO-8859-1 encoding (https://redirect.github.com/codehaus-plexus/plexus-xml/pull/1";>#1) https://github.com/gnodet";>@​gnodet
   
   
   
   
   Commits
   
   https://github.com/codehaus-plexus/plexus-xml/commit/944197c74386b199857a003160d840fb5593ac29";>944197c
 [maven-release-plugin] prepare release plexus-xml-4.0.2
   https://github.com/codehaus-plexus/plexus-xml/commit/c3d99b433a272d8eb1cc7c799410799e8c16ace3";>c3d99b4
 Upgrade to 4.0.0-alpha-7 and exclude dependency to sisu (fixes https://redirect.github.com/codehaus-plexus/plexus-xml/issues/17";>#17)
 (https://redirect.github.com/codehaus-plexus/plexus-xml/issues/23";>#23)
   https://github.com/codehaus-plexus/plexus-xml/commit/a83cefa086c9a5bb8b6674a409016f378b19891e";>a83cefa
 Cleanup after parent pom upgrade
   https://github.com/codehaus-plexus/plexus-xml/commit/25a00cd9d04ff3ab7acdcebdefdbb19ec5c4560d";>25a00cd
 [maven-release-plugin] prepare for next development iteration
   https://github.com/codehaus-plexus/plexus-xml/commit/bcb6981e2a9c635d024e0422de2a997a00ffdd8e";>bcb6981
 [maven-release-plugin] prepare release plexus-xml-4.0.1
   https://github.com/codehaus-plexus/plexus-xml/commit/d227a49f0f9b552a61b2aaac3bbe2c722ce06fea";>d227a49
 Fix detection of invalid spaces in prolog (https://redirect.github.com/codehaus-plexus/plexus-xml/issues/20";>#20)
   https://github.com/codehaus-plexus/plexus-xml/commit/27d6127d3196d09263d8fe0f445b9d83f6ccfb75";>27d6127
 pom.mxl and site.xml cleanup
   https://github.com/codehaus-plexus/plexus-xml/commit/62f50bc46c7b51d51a25541dfe0a502063dc1fc3";>62f50bc
 [maven-release-plugin] prepare for next development iteration
   https://github.com/codehaus-plexus/plexus-xml/commit/cac55e8c167b168c6c36dd4a057dedfadec03c0e";>cac55e8
 [maven-release-plugin] prepare release plexus-xml-4.0.0
   https://github.com/codehaus-plexus/plexus-xml/commit/17787e5ff7dea8acf347fd3f92bd855e110d6dfe";>17787e5
 Reformat using spotless
   Additional commits viewable in https://github.com/codehaus-plexus/plexus-xml/compare/plexus-xml-3.0.0...plexus-xml-4.0.2";>compare
 view
   
   
   
   
   
   [![Dependabot compatibility 
score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=org.codehaus.plexus:plexus-xml&package-ma

[jira] [Commented] (MNG-7944) Execution default of goal org.apache.maven.plugins:maven-assembly-plugin:3.6.0:single failed: Index 2 out of bounds for length 2

2023-12-05 Thread Zhongming Hua (Jira)


[ 
https://issues.apache.org/jira/browse/MNG-7944?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17793236#comment-17793236
 ] 

Zhongming Hua commented on MNG-7944:


[~froque] 

I can't reproduce your question with your configuration. version 4.0.0-alpha-8 
is ok, you can try it again.

> Execution default of goal 
> org.apache.maven.plugins:maven-assembly-plugin:3.6.0:single failed: Index 2 
> out of bounds for length 2
> 
>
> Key: MNG-7944
> URL: https://issues.apache.org/jira/browse/MNG-7944
> Project: Maven
>  Issue Type: Bug
>Affects Versions: 4.0.0-alpha-8
>Reporter: Filipe Roque
>Priority: Major
>
> It only affects apache-maven-4.0.0-alpha-8
> pom.xml
> {code:java}
> 
> http://maven.apache.org/POM/4.0.0";
>  xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance";
>  xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 
> http://maven.apache.org/xsd/maven-4.0.0.xsd";>
> 4.0.0
> org.example
> mvn4-assembly-index
> 1.0-SNAPSHOT
> 
> 17
> 17
> UTF-8
> 
> 
> 
> org.ehcache
> ehcache
> 3.10.8
> 
> 
> 
> 
> 
> org.apache.maven.plugins
> maven-assembly-plugin
> 3.6.0
> 
> 
> 
> src/main/assembly/descriptor.xml
> 
> false
> 
> 
> 
> package
> 
> single
> 
> 
> 
> 
> 
> 
>  {code}
> descriptor.xml
> {code:java}
> http://maven.apache.org/ASSEMBLY/2.1.0"; 
> xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance";
>   xsi:schemaLocation="http://maven.apache.org/ASSEMBLY/2.1.0 
> http://maven.apache.org/xsd/assembly-2.1.0.xsd";>
> assembly
> 
> dir
> 
> false
> .
> 
> 
> /
> false
> runtime
> 
> 
> 
>  {code}
> {code:java}
> ❯ /opt/maven/apache-maven-4.0.0-alpha-8/bin/mvn -q package
> [ERROR] Failed to execute goal 
> org.apache.maven.plugins:maven-assembly-plugin:3.6.0:single (default) on 
> project mvn4-assembly-index: Execution default of goal 
> org.apache.maven.plugins:maven-assembly-plugin:3.6.0:single failed: Index 2 
> out of bounds for length 2 -> [Help 1]
> [ERROR] 
> [ERROR] To see the full stack trace of the errors, re-run Maven with the '-e' 
> switch
> [ERROR] Re-run Maven using the '-X' switch to enable verbose output
> [ERROR] 
> [ERROR] For more information about the errors and possible solutions, please 
> read the following articles:
> [ERROR] [Help 1] 
> http://cwiki.apache.org/confluence/display/MAVEN/PluginExecutionException
>  {code}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[PR] Fix reactor reader to not resolve any artifacts from projects being built outside the reactor [maven]

2023-12-05 Thread via GitHub


gnodet opened a new pull request, #1330:
URL: https://github.com/apache/maven/pull/1330

   (no comment)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[jira] [Closed] (MNG-7920) Usage of packaging BOM fails in maven-install-plugin

2023-12-05 Thread Guillaume Nodet (Jira)


 [ 
https://issues.apache.org/jira/browse/MNG-7920?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Guillaume Nodet closed MNG-7920.

Resolution: Fixed

> Usage of packaging BOM fails in maven-install-plugin
> 
>
> Key: MNG-7920
> URL: https://issues.apache.org/jira/browse/MNG-7920
> Project: Maven
>  Issue Type: Bug
>  Components: Deployment
>Affects Versions: 4.0.0-alpha-8
>Reporter: Karl Heinz Marbaise
>Priority: Critical
> Fix For: 4.0.0-alpha-9, 4.0.0
>
>
> Using to use the {{bom}} packaging in a module it will fail with:
> {code}
> [INFO] 
> --
> [ERROR] Failed to execute goal 
> org.apache.maven.plugins:maven-install-plugin:3.1.1:install (default-install) 
> on project bom: The packaging plugin for this project did not assign a main 
> file to the project but it has attachments. Change packaging to 'pom'. -> 
> [Help 1]
> {code}
> The bom module looks like this:
> {code:xml}
>xmlns="http://maven.apache.org/POM/4.1.0";
>   xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance";
>   xsi:schemaLocation="http://maven.apache.org/POM/4.1.0 
> http://maven.apache.org/maven-v4_1_0.xsd";>
>   4.1.0
>   
> maven4
> bom-example
>   
>   bom
>   bom
>   
> 
>   
>   ...maven4
>   mod-1
>   
>   
>   maven4
>   mod-2
>   
> 
>   
> 
> {code}
> I would assume that I need to upgrade the maven-install-plugin which is 
> capable of handling that...but I assumed that this conversion is done by core?



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (MNG-7920) Usage of packaging BOM fails in maven-install-plugin

2023-12-05 Thread ASF GitHub Bot (Jira)


[ 
https://issues.apache.org/jira/browse/MNG-7920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17793197#comment-17793197
 ] 

ASF GitHub Bot commented on MNG-7920:
-

gnodet merged PR #1305:
URL: https://github.com/apache/maven/pull/1305




> Usage of packaging BOM fails in maven-install-plugin
> 
>
> Key: MNG-7920
> URL: https://issues.apache.org/jira/browse/MNG-7920
> Project: Maven
>  Issue Type: Bug
>  Components: Deployment
>Affects Versions: 4.0.0-alpha-8
>Reporter: Karl Heinz Marbaise
>Priority: Critical
> Fix For: 4.0.0-alpha-9, 4.0.0
>
>
> Using to use the {{bom}} packaging in a module it will fail with:
> {code}
> [INFO] 
> --
> [ERROR] Failed to execute goal 
> org.apache.maven.plugins:maven-install-plugin:3.1.1:install (default-install) 
> on project bom: The packaging plugin for this project did not assign a main 
> file to the project but it has attachments. Change packaging to 'pom'. -> 
> [Help 1]
> {code}
> The bom module looks like this:
> {code:xml}
>xmlns="http://maven.apache.org/POM/4.1.0";
>   xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance";
>   xsi:schemaLocation="http://maven.apache.org/POM/4.1.0 
> http://maven.apache.org/maven-v4_1_0.xsd";>
>   4.1.0
>   
> maven4
> bom-example
>   
>   bom
>   bom
>   
> 
>   
>   ...maven4
>   mod-1
>   
>   
>   maven4
>   mod-2
>   
> 
>   
> 
> {code}
> I would assume that I need to upgrade the maven-install-plugin which is 
> capable of handling that...but I assumed that this conversion is done by core?



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


Re: [PR] [MNG-7920] Fix usage of packaging BOM fails in maven-install-plugin [maven]

2023-12-05 Thread via GitHub


gnodet merged PR #1305:
URL: https://github.com/apache/maven/pull/1305


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[jira] [Resolved] (MNG-7947) Plugin API

2023-12-05 Thread Guillaume Nodet (Jira)


 [ 
https://issues.apache.org/jira/browse/MNG-7947?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Guillaume Nodet resolved MNG-7947.
--
Resolution: Fixed

> Plugin API
> --
>
> Key: MNG-7947
> URL: https://issues.apache.org/jira/browse/MNG-7947
> Project: Maven
>  Issue Type: New Feature
>Reporter: Guillaume Nodet
>Assignee: Guillaume Nodet
>Priority: Major
> Fix For: 4.0.0-alpha-9
>
>
> h2. Switch to Guice 6.0, use guice to instantiate and inject mojos
> Context: the goal for the maven API is to be completely independent of any 
> third party library. I was working this week on migrating some parts of the 
> Plugin API for Maven 4. Unfortunately, the scopes ({{{}@SessionScoped{}}} and 
> {{{}@MojoExecutionScoped{}}}) need to be annotated by a scope annotation so 
> that they are recognised as such by Guice. So either the guice annotation or 
> the javax.inject one. Given javax.inject will slowly go away, I went straight 
> to jakarta.inject, thus upgrading to Guice 6.0 (which supports both 
> javax.inject and jakarta.inject, while Guice 7.0 only supports 
> jakarta.inject).
> h2. Maven 4 api for plugin execution
> This introduces an immutable plugin descriptor (and custom lifecycle for 
> plugins too). The Maven 3 PluginDescriptor contains runtime information such 
> as the class loader, dependencies, etc... Those are moved to the 
> o.a.m.api.Plugin class which can be accessed from the o.a.m.api.MojoExecution 
> along with the MojoDescriptor and PluginDescriptor.
> Leveraging guice, some fields inherited from the plexus land now disappear: 
> instantiationStrategy is replaced with scope annotations, @Component replaced 
> by @Inject.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Updated] (MNG-7947) Plugin API

2023-12-05 Thread Guillaume Nodet (Jira)


 [ 
https://issues.apache.org/jira/browse/MNG-7947?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Guillaume Nodet updated MNG-7947:
-
Description: 
h2. Switch to Guice 6.0, use guice to instantiate and inject mojos

Context: the goal for the maven API is to be completely independent of any 
third party library. I was working this week on migrating some parts of the 
Plugin API for Maven 4. Unfortunately, the scopes ({{{}@SessionScoped{}}} and 
{{{}@MojoExecutionScoped{}}}) need to be annotated by a scope annotation so 
that they are recognised as such by Guice. So either the guice annotation or 
the javax.inject one. Given javax.inject will slowly go away, I went straight 
to jakarta.inject, thus upgrading to Guice 6.0 (which supports both 
javax.inject and jakarta.inject, while Guice 7.0 only supports jakarta.inject).
h2. Maven 4 api for plugin execution

This introduces an immutable plugin descriptor (and custom lifecycle for 
plugins too). The Maven 3 PluginDescriptor contains runtime information such as 
the class loader, dependencies, etc... Those are moved to the o.a.m.api.Plugin 
class which can be accessed from the o.a.m.api.MojoExecution along with the 
MojoDescriptor and PluginDescriptor.

Leveraging guice, some fields inherited from the plexus land now disappear: 
instantiationStrategy is replaced with scope annotations, @Component replaced 
by @Inject.

> Plugin API
> --
>
> Key: MNG-7947
> URL: https://issues.apache.org/jira/browse/MNG-7947
> Project: Maven
>  Issue Type: New Feature
>Reporter: Guillaume Nodet
>Assignee: Guillaume Nodet
>Priority: Major
> Fix For: 4.0.0-alpha-9
>
>
> h2. Switch to Guice 6.0, use guice to instantiate and inject mojos
> Context: the goal for the maven API is to be completely independent of any 
> third party library. I was working this week on migrating some parts of the 
> Plugin API for Maven 4. Unfortunately, the scopes ({{{}@SessionScoped{}}} and 
> {{{}@MojoExecutionScoped{}}}) need to be annotated by a scope annotation so 
> that they are recognised as such by Guice. So either the guice annotation or 
> the javax.inject one. Given javax.inject will slowly go away, I went straight 
> to jakarta.inject, thus upgrading to Guice 6.0 (which supports both 
> javax.inject and jakarta.inject, while Guice 7.0 only supports 
> jakarta.inject).
> h2. Maven 4 api for plugin execution
> This introduces an immutable plugin descriptor (and custom lifecycle for 
> plugins too). The Maven 3 PluginDescriptor contains runtime information such 
> as the class loader, dependencies, etc... Those are moved to the 
> o.a.m.api.Plugin class which can be accessed from the o.a.m.api.MojoExecution 
> along with the MojoDescriptor and PluginDescriptor.
> Leveraging guice, some fields inherited from the plexus land now disappear: 
> instantiationStrategy is replaced with scope annotations, @Component replaced 
> by @Inject.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (MNG-7947) Plugin API

2023-12-05 Thread ASF GitHub Bot (Jira)


[ 
https://issues.apache.org/jira/browse/MNG-7947?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17793180#comment-17793180
 ] 

ASF GitHub Bot commented on MNG-7947:
-

gnodet merged PR #1309:
URL: https://github.com/apache/maven/pull/1309




> Plugin API
> --
>
> Key: MNG-7947
> URL: https://issues.apache.org/jira/browse/MNG-7947
> Project: Maven
>  Issue Type: New Feature
>Reporter: Guillaume Nodet
>Assignee: Guillaume Nodet
>Priority: Major
> Fix For: 4.0.0-alpha-9
>
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)


Re: [PR] [MNG-7947] Plugin API [maven]

2023-12-05 Thread via GitHub


gnodet merged PR #1309:
URL: https://github.com/apache/maven/pull/1309


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org