[jira] [Commented] (MNG-7972) Artifact creation from "standard string"

[ASF GitHub Bot (Jira)]

[ 
https://issues.apache.org/jira/browse/MNG-7972?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17798035#comment-17798035
 ] 

ASF GitHub Bot commented on MNG-7972:
-

gnodet commented on code in PR #1347:
URL: https://github.com/apache/maven/pull/1347#discussion_r1429589638


##
api/maven-api-core/src/main/java/org/apache/maven/api/services/ArtifactCoordinateFactory.java:
##
@@ -43,6 +43,18 @@ public interface ArtifactCoordinateFactory extends Service {
 @Nonnull
 ArtifactCoordinate create(@Nonnull ArtifactCoordinateFactoryRequest 
request);
 
+/**
+ * Creates a coordinate out of string that is formatted like:
+ * {@code :[:[:]]:}
+ *
+ * @param session the session.
+ * @param coordinateString the string having "standard" coordinate.
+ * @return an {@code Artifact}, never {@code null}
+ * @throws IllegalArgumentException if {@code request} is null or {@code 
request.session} is null or invalid
+ */
+@Nonnull
+ArtifactCoordinate create(@Nonnull Session session, @Nonnull String 
coordinateString);

Review Comment:
   In other services, when multiple "signatures" are involved, a single 
"request" object is used to store all those bits.  I'm not sure why we should 
not do the same here, i.e. add a `coordinateString` member to the 
`ArtifactCoordinateRequest`.





> Artifact creation from "standard string"
> 
>
> Key: MNG-7972
> URL: https://issues.apache.org/jira/browse/MNG-7972
> Project: Maven
>  Issue Type: Task
>  Components: Core
>Reporter: Tamas Cservenak
>Assignee: Tamas Cservenak
>Priority: Major
> Fix For: 4.0.0, 4.0.0-alpha-10
>
>
> Expose API to create artifact from "standard string":
> {noformat}
> :[:[:]]:{noformat}
> As currently there is none for this.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Re: [PR] [MNG-7972] Artifact coordinate out of "standard string" [maven]

[via GitHub]

gnodet commented on code in PR #1347:
URL: https://github.com/apache/maven/pull/1347#discussion_r1429589638


##
api/maven-api-core/src/main/java/org/apache/maven/api/services/ArtifactCoordinateFactory.java:
##
@@ -43,6 +43,18 @@ public interface ArtifactCoordinateFactory extends Service {
 @Nonnull
 ArtifactCoordinate create(@Nonnull ArtifactCoordinateFactoryRequest 
request);
 
+/**
+ * Creates a coordinate out of string that is formatted like:
+ * {@code :[:[:]]:}
+ *
+ * @param session the session.
+ * @param coordinateString the string having "standard" coordinate.
+ * @return an {@code Artifact}, never {@code null}
+ * @throws IllegalArgumentException if {@code request} is null or {@code 
request.session} is null or invalid
+ */
+@Nonnull
+ArtifactCoordinate create(@Nonnull Session session, @Nonnull String 
coordinateString);

Review Comment:
   In other services, when multiple "signatures" are involved, a single 
"request" object is used to store all those bits.  I'm not sure why we should 
not do the same here, i.e. add a `coordinateString` member to the 
`ArtifactCoordinateRequest`.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[jira] [Commented] (MNG-7968) Maven RT Service equivalent for RuntimeInformation

[ASF GitHub Bot (Jira)]

[ 
https://issues.apache.org/jira/browse/MNG-7968?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17798033#comment-17798033
 ] 

ASF GitHub Bot commented on MNG-7968:
-

gnodet commented on code in PR #1346:
URL: https://github.com/apache/maven/pull/1346#discussion_r1429587026


##
api/maven-api-core/src/main/java/org/apache/maven/api/services/RuntimeInformation.java:
##
@@ -0,0 +1,41 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.maven.api.services;
+
+import org.apache.maven.api.Service;
+import org.apache.maven.api.Version;
+import org.apache.maven.api.annotations.Experimental;
+import org.apache.maven.api.annotations.Nonnull;
+
+/**
+ * Service interface to provide runtime information.
+ *
+ * @since 4.0.0
+ */
+@Experimental
+public interface RuntimeInformation extends Service {
+
+/**
+ * Returns the "runtime version", Maven version caller runs in.
+ *
+ * @return the runtime version, never {@code null}
+ */
+@Nonnull
+Version runtimeVersion();

Review Comment:
   We already have `Session.getMavenVersion()`, I'm not sure we need a new 
service just for this bit.  However the session's method returns a `String`, 
maybe it needs to be changed to a `Version`.  If we keep this service, then the 
`Session.getMavenVersion` method should delegate to that Service.
   I think I did not used a service, I did not see the value for that single 
method... 





> Maven RT Service equivalent for RuntimeInformation
> --
>
> Key: MNG-7968
> URL: https://issues.apache.org/jira/browse/MNG-7968
> Project: Maven
>  Issue Type: Task
>  Components: Core
>Reporter: Tamas Cservenak
>Assignee: Tamas Cservenak
>Priority: Major
> Fix For: 4.0.0, 4.0.0-alpha-10
>
>
> Equivalent service for org.apache.maven.rtinfo.RuntimeInformation to reveal 
> "runtime Maven Version" for those who needs it.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Re: [PR] [MNG-7968] RT info service [maven]

[via GitHub]

gnodet commented on code in PR #1346:
URL: https://github.com/apache/maven/pull/1346#discussion_r1429587026


##
api/maven-api-core/src/main/java/org/apache/maven/api/services/RuntimeInformation.java:
##
@@ -0,0 +1,41 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.maven.api.services;
+
+import org.apache.maven.api.Service;
+import org.apache.maven.api.Version;
+import org.apache.maven.api.annotations.Experimental;
+import org.apache.maven.api.annotations.Nonnull;
+
+/**
+ * Service interface to provide runtime information.
+ *
+ * @since 4.0.0
+ */
+@Experimental
+public interface RuntimeInformation extends Service {
+
+/**
+ * Returns the "runtime version", Maven version caller runs in.
+ *
+ * @return the runtime version, never {@code null}
+ */
+@Nonnull
+Version runtimeVersion();

Review Comment:
   We already have `Session.getMavenVersion()`, I'm not sure we need a new 
service just for this bit.  However the session's method returns a `String`, 
maybe it needs to be changed to a `Version`.  If we keep this service, then the 
`Session.getMavenVersion` method should delegate to that Service.
   I think I did not used a service, I did not see the value for that single 
method... 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[jira] [Updated] (SUREFIRE-2222) Use JUnit 5 display name in test reports

[Alexander Kriegisch (Jira)]

 [ 
https://issues.apache.org/jira/browse/SUREFIRE-?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Alexander Kriegisch updated SUREFIRE-:
--
Description: 
When running a parametrised JUnit 5 Jupiter test, display names are not used 
for XML report files and consequently also not in HTML reports.

 
{code:java}
@ParameterizedTest(name = "{0}")
@MethodSource("testParseModernStream_withAnnotationProcessingErrors_args")
void testParseModernStream_withAnnotationProcessingErrors(String jdkAndLocale, 
String stackTraceHeader) {
  // ...
}
{code}
The method source provides a list of test diaplay names, which e.g. my IDE 
recognises and displays correctly:

!image-2023-12-18-13-27-51-220.png!

Surefire, however, does not:
{code:xml}

http://www.w3.org/2001/XMLSchema-instance"; 
xsi:noNamespaceSchemaLocation="https://maven.apache.org/surefire/maven-surefire-plugin/xsd/surefire-test-report-3.0.xsd";
 version="3.0" name="org.codehaus.plexus.compiler.javac.JavacCompilerTest" 
time="5.448" tests="21" errors="0" skipped="0" failures="0">
  
  
  
  
  
  
  
  

{code}
 
Please note, how the test case names are generic defaults with indices like 
{{testParseModernStream_withAnnotationProcessingErrors(String, String)[4]}}.

The same generic names are then reported in HTML reports for {{mvn 
surefire-report:report}} or {{mvn surefire-report:report-only}}.

  was:
When running a parametrised JUnit 5 Jupiter test, display names are not used 
for XML report files and consequently also not in HTML reports.

 
{code:java}
@ParameterizedTest(name = "{0}")
@MethodSource("testParseModernStream_withAnnotationProcessingErrors_args")
void testParseModernStream_withAnnotationProcessingErrors(String jdkAndLocale, 
String stackTraceHeader) {
  // ...
}
{code}
The method source provides a list of test diaplay names, which e.g. my IDE 
recognises and displays correctly:

!image-2023-12-18-13-27-51-220.png!

Surefire, however, does not:
{code:xml}

http://www.w3.org/2001/XMLSchema-instance"; 
xsi:noNamespaceSchemaLocation="https://maven.apache.org/surefire/maven-surefire-plugin/xsd/surefire-test-report-3.0.xsd";
 version="3.0" name="org.codehaus.plexus.compiler.javac.JavacCompilerTest" 
time="5.448" tests="21" errors="0" skipped="0" failures="0">
  
  
  
  
  
  
  
  

{code}
 
Please note, how the test case names are generic defaults with indices like 
{{testParseModernStream_withAnnotationProcessingErrors(String, String)[4]}}.


> Use JUnit 5 display name in test reports
> 
>
> Key: SUREFIRE-
> URL: https://issues.apache.org/jira/browse/SUREFIRE-
> Project: Maven Surefire
>  Issue Type: Improvement
>Affects Versions: 3.2.2
>Reporter: Alexander Kriegisch
>Priority: Major
> Attachments: image-2023-12-18-13-27-51-220.png
>
>
> When running a parametrised JUnit 5 Jupiter test, display names are not used 
> for XML report files and consequently also not in HTML reports.
>  
> {code:java}
> @ParameterizedTest(name = "{0}")
> @MethodSource("testParseModernStream_withAnnotationProcessingErrors_args")
> void testParseModernStream_withAnnotationProcessingErrors(String 
> jdkAndLocale, String stackTraceHeader) {
>   // ...
> }
> {code}
> The method source provides a list of test diaplay names, which e.g. my IDE 
> recognises and displays correctly:
> !image-2023-12-18-13-27-51-220.png!
> Surefire, however, does not:
> {code:xml}
> 
> http://www.w3.org/2001/XMLSchema-instance"; 
> xsi:noNamespaceSchemaLocation="https://maven.apache.org/surefire/maven-surefire-plugin/xsd/surefire-test-report-3.0.xsd";
>  version="3.0" name="org.codehaus.plexus.compiler.javac.JavacCompilerTest" 
> time="5.448" tests="21" errors="0" skipped="0" failures="0">
>   
>name="testParseModernStream_withAnnotationProcessingErrors(String, 
> String)[1]" classname="org.codehaus.plexus.compiler.javac.JavacCompilerTest" 
> time="0.12"/>
>name="testParseModernStream_withAnnotationProcessingErrors(String, 
> String)[2]" classname="org.codehaus.plexus.compiler.javac.JavacCompilerTest" 
> time="0.108"/>
>name="testParseModernStream_withAnnotationProcessingErrors(String, 
> String)[3]" classname="org.codehaus.plexus.compiler.javac.JavacCompilerTest" 
> time="0.113"/>
>name="testParseModernStream_withAnnotationProcessingErrors(String, 
> String)[4]" classname="org.codehaus.plexus.compiler.javac.JavacCompilerTest" 
> time="0.098"/>
>name="testParseModernStream_withAnnotationProcessingErrors(String, 
> String)[5]" classname="org.codehaus.plexus.compiler.javac.JavacCompilerTest" 
> time="0.088"/>
>name="testParseModernStream_withAnnotationProcessingErrors(String, 
> String)[6]" classname="org.codehaus.plexus.compiler.javac.JavacCompilerTest" 
> time="0.094"/>
>name="testParseModernStream_withAnnotationProcessingErrors(String, 
> String)[7]" classn

[jira] [Created] (SUREFIRE-2222) Use JUnit 5 display name in test reports

[Alexander Kriegisch (Jira)]

Alexander Kriegisch created SUREFIRE-:
-

 Summary: Use JUnit 5 display name in test reports
 Key: SUREFIRE-
 URL: https://issues.apache.org/jira/browse/SUREFIRE-
 Project: Maven Surefire
  Issue Type: Improvement
Affects Versions: 3.2.2
Reporter: Alexander Kriegisch
 Attachments: image-2023-12-18-13-27-51-220.png

When running a parametrised JUnit 5 Jupiter test, display names are not used 
for XML report files and consequently also not in HTML reports.

 
{code:java}
@ParameterizedTest(name = "{0}")
@MethodSource("testParseModernStream_withAnnotationProcessingErrors_args")
void testParseModernStream_withAnnotationProcessingErrors(String jdkAndLocale, 
String stackTraceHeader) {
  // ...
}
{code}
The method source provides a list of test diaplay names, which e.g. my IDE 
recognises and displays correctly:

!image-2023-12-18-13-27-51-220.png!

Surefire, however, does not:
{code:xml}

http://www.w3.org/2001/XMLSchema-instance"; 
xsi:noNamespaceSchemaLocation="https://maven.apache.org/surefire/maven-surefire-plugin/xsd/surefire-test-report-3.0.xsd";
 version="3.0" name="org.codehaus.plexus.compiler.javac.JavacCompilerTest" 
time="5.448" tests="21" errors="0" skipped="0" failures="0">
  
  
  
  
  
  
  
  

{code}
 
Please note, how the test case names are generic defaults with indices like 
{{testParseModernStream_withAnnotationProcessingErrors(String, String)[4]}}.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[PR] Bump lucene.version from 9.9.0 to 9.9.1 [maven-indexer]

[via GitHub]

dependabot[bot] opened a new pull request, #348:
URL: https://github.com/apache/maven-indexer/pull/348

   Bumps `lucene.version` from 9.9.0 to 9.9.1.
   Updates `org.apache.lucene:lucene-core` from 9.9.0 to 9.9.1
   
   Updates `org.apache.lucene:lucene-queryparser` from 9.9.0 to 9.9.1
   
   Updates `org.apache.lucene:lucene-analysis-common` from 9.9.0 to 9.9.1
   
   Updates `org.apache.lucene:lucene-highlighter` from 9.9.0 to 9.9.1
   
   Updates `org.apache.lucene:lucene-backward-codecs` from 9.9.0 to 9.9.1
   
   
   Dependabot will resolve any conflicts with this PR as long as you don't 
alter it yourself. You can also trigger a rebase manually by commenting 
`@dependabot rebase`.
   
   [//]: # (dependabot-automerge-start)
   [//]: # (dependabot-automerge-end)
   
   ---
   
   
   Dependabot commands and options
   
   
   You can trigger Dependabot actions by commenting on this PR:
   - `@dependabot rebase` will rebase this PR
   - `@dependabot recreate` will recreate this PR, overwriting any edits that 
have been made to it
   - `@dependabot merge` will merge this PR after your CI passes on it
   - `@dependabot squash and merge` will squash and merge this PR after your CI 
passes on it
   - `@dependabot cancel merge` will cancel a previously requested merge and 
block automerging
   - `@dependabot reopen` will reopen this PR if it is closed
   - `@dependabot close` will close this PR and stop Dependabot recreating it. 
You can achieve the same result by closing it manually
   - `@dependabot show  ignore conditions` will show all of 
the ignore conditions of the specified dependency
   - `@dependabot ignore this major version` will close this PR and stop 
Dependabot creating any more for this major version (unless you reopen the PR 
or upgrade to it yourself)
   - `@dependabot ignore this minor version` will close this PR and stop 
Dependabot creating any more for this minor version (unless you reopen the PR 
or upgrade to it yourself)
   - `@dependabot ignore this dependency` will close this PR and stop 
Dependabot creating any more for this dependency (unless you reopen the PR or 
upgrade to it yourself)
   
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[jira] [Commented] (SUREFIRE-1934) Ability to disable system-out/system-err for successfuly passed tests

[ASF GitHub Bot (Jira)]

[ 
https://issues.apache.org/jira/browse/SUREFIRE-1934?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17797986#comment-17797986
 ] 

ASF GitHub Bot commented on SUREFIRE-1934:
--

kriegaex commented on PR #670:
URL: https://github.com/apache/maven-surefire/pull/670#issuecomment-1859378299

   OK, I quickly looked at the code. This PR does nothing of the sort I was 
talking about above. It does not change stdOut/stdErr capturing in any way, 
just adds a switch adding the output to the XML report. I.e., which ever way 
Surefire handles those streams in a multi-threading situation, remains the 
same. Sorry for the misunderstanding and for the noise. I had hoped that 
someone came up with a magical solution for the root problem. But it is not 
being addressed here.




> Ability to disable system-out/system-err for successfuly passed tests
> -
>
> Key: SUREFIRE-1934
> URL: https://issues.apache.org/jira/browse/SUREFIRE-1934
> Project: Maven Surefire
>  Issue Type: Improvement
>  Components: Maven Surefire Plugin
>Affects Versions: 3.0.0-M5
>Reporter: Andrey Turbanov
>Priority: Major
>
> After SUREFIRE-1744 surefire-plugin always reports system-out/system-err even 
> for successfully passed test. A lot of old projects with big amount of tests 
> now have to deal with huge output.
> I think there should be option to disable new behavior.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Re: [PR] [SUREFIRE-1934] Ability to disable system-out/system-err for successfuly passed tests. [maven-surefire]

[via GitHub]

kriegaex commented on PR #670:
URL: https://github.com/apache/maven-surefire/pull/670#issuecomment-1859378299

   OK, I quickly looked at the code. This PR does nothing of the sort I was 
talking about above. It does not change stdOut/stdErr capturing in any way, 
just adds a switch adding the output to the XML report. I.e., which ever way 
Surefire handles those streams in a multi-threading situation, remains the 
same. Sorry for the misunderstanding and for the noise. I had hoped that 
someone came up with a magical solution for the root problem. But it is not 
being addressed here.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[jira] [Commented] (SUREFIRE-1934) Ability to disable system-out/system-err for successfuly passed tests

[ASF GitHub Bot (Jira)]

[ 
https://issues.apache.org/jira/browse/SUREFIRE-1934?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17797983#comment-17797983
 ] 

ASF GitHub Bot commented on SUREFIRE-1934:
--

kriegaex commented on PR #670:
URL: https://github.com/apache/maven-surefire/pull/670#issuecomment-1859364057

   > Also, were can I see that this applies to passed tests only?
   
   Yes, it seems that the `TestOutElements` classes need one negative test case 
each, too.
   
   @NissMoony, I guess all suggested changes are rather trivial to implement. 
If you give this PR some attention now, @michael-o, who is currently working on 
a bunch of at least two other output-stream-related PRs, could move forward 
more quickly and consider them all together as a whole.




> Ability to disable system-out/system-err for successfuly passed tests
> -
>
> Key: SUREFIRE-1934
> URL: https://issues.apache.org/jira/browse/SUREFIRE-1934
> Project: Maven Surefire
>  Issue Type: Improvement
>  Components: Maven Surefire Plugin
>Affects Versions: 3.0.0-M5
>Reporter: Andrey Turbanov
>Priority: Major
>
> After SUREFIRE-1744 surefire-plugin always reports system-out/system-err even 
> for successfully passed test. A lot of old projects with big amount of tests 
> now have to deal with huge output.
> I think there should be option to disable new behavior.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Re: [PR] [SUREFIRE-1934] Ability to disable system-out/system-err for successfuly passed tests. [maven-surefire]

[via GitHub]

kriegaex commented on PR #670:
URL: https://github.com/apache/maven-surefire/pull/670#issuecomment-1859364057

   > Also, were can I see that this applies to passed tests only?
   
   Yes, it seems that the `TestOutElements` classes need one negative test case 
each, too.
   
   @NissMoony, I guess all suggested changes are rather trivial to implement. 
If you give this PR some attention now, @michael-o, who is currently working on 
a bunch of at least two other output-stream-related PRs, could move forward 
more quickly and consider them all together as a whole.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[jira] [Commented] (SUREFIRE-1345) Report parser doesn't support flaky and retries

[ASF GitHub Bot (Jira)]

[ 
https://issues.apache.org/jira/browse/SUREFIRE-1345?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17797982#comment-17797982
 ] 

ASF GitHub Bot commented on SUREFIRE-1345:
--

kriegaex commented on PR #700:
URL: https://github.com/apache/maven-surefire/pull/700#issuecomment-1859355869

   @michael-o, thanks for considering that the original version of this PR 
collided with #692. But it is good to get confirmation from a third party that 
my idea of capturing _stdOut_ and _stdErr_ is useful to other users, too. No 
objections.




> Report parser doesn't support flaky and retries
> ---
>
> Key: SUREFIRE-1345
> URL: https://issues.apache.org/jira/browse/SUREFIRE-1345
> Project: Maven Surefire
>  Issue Type: Bug
>Reporter: Dmitry Baev
>Priority: Major
>
> TestSuiteXmlParser (from 
> `org.apache.maven.surefire:surefire-report-parser:2.19.1`)
> doesn't support changes described in 
> https://github.com/apache/maven-surefire/blob/master/maven-surefire-plugin/src/site/apt/examples/rerun-failing-tests.apt.vm



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Re: [PR] [SUREFIRE-1345] Support flakyFailure and flakyError in TestSuiteXmlParser [maven-surefire]

[via GitHub]

kriegaex commented on PR #700:
URL: https://github.com/apache/maven-surefire/pull/700#issuecomment-1859355869

   @michael-o, thanks for considering that the original version of this PR 
collided with #692. But it is good to get confirmation from a third party that 
my idea of capturing _stdOut_ and _stdErr_ is useful to other users, too. No 
objections.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[jira] [Commented] (MASSEMBLY-992) Facility to define assembly descriptor in body of POM

[ASF GitHub Bot (Jira)]

[ 
https://issues.apache.org/jira/browse/MASSEMBLY-992?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17797971#comment-17797971
 ] 

ASF GitHub Bot commented on MASSEMBLY-992:
--

slawekjaranowski merged PR #174:
URL: https://github.com/apache/maven-assembly-plugin/pull/174




> Facility to define assembly descriptor in body of POM
> -
>
> Key: MASSEMBLY-992
> URL: https://issues.apache.org/jira/browse/MASSEMBLY-992
> Project: Maven Assembly Plugin
>  Issue Type: New Feature
>Reporter: Garret Wilson
>Assignee: Slawomir Jaranowski
>Priority: Major
> Fix For: 3.7.0
>
>
> The Maven Assembly Plugin allows custom descriptors to be defined, but only 
> in an external file. Please add the capability to define the descriptor in 
> the body of the POM itself.
> Requiring a separate descriptor file makes it almost impossible to declare an 
> assembly in a parent POM so that it can be inherited by child POMs. The 
> documentation describe a way to [share 
> descriptors|https://maven.apache.org/plugins/maven-assembly-plugin/examples/sharing-descriptors.html],
>  but it is complex and doesn't obviously support Maven property interpolation.
> Without this facility, in order to easily inherit an assembly from a parent 
> POM, I'm currently resorting to workaround involving AntRun to generate an 
> assembly descriptor on the fly. See [this 
> {{pom.xml}}|https://github.com/globalmentor/globalmentor-root/blob/main/pom.xml].
>  It's pretty convoluted and tedious to get right. In addition, it has to be 
> placed in a phase that is guaranteed to run before the execution of the Maven 
> Assembly Plugin itself.
> {code:xml}
>   
> org.apache.maven.plugins
> maven-antrun-plugin
> 
>   
> 
> generate-bin-assembly-descriptor
> prepare-package
> 
>   run
> 
> 
>   ${_isSkipGenerateExe}
>   
>  encoding="UTF-8">
>   
> 
>   
> 
>   
> 
>   
> {code}
> This was requested and finally implemented for Versions Maven Plugin; see 
> [#258|https://github.com/mojohaus/versions/issues/258] and 
> [#684|https://github.com/mojohaus/versions/issues/684], along with [_Versions 
> Maven Plugin rules that are 
> inheritable_|https://stackoverflow.com/q/72416739] on Stack Overflow.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Re: [PR] [MASSEMBLY-992] Inline Assembly Descriptors [maven-assembly-plugin]

[via GitHub]

slawekjaranowski merged PR #174:
URL: https://github.com/apache/maven-assembly-plugin/pull/174


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] Bump camel-core from 2.24.1 to 3.2.0 in /src/it/projects/bugs/massembly-920 [maven-assembly-plugin]

[via GitHub]

slawekjaranowski merged PR #137:
URL: https://github.com/apache/maven-assembly-plugin/pull/137


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[jira] [Commented] (MNG-7969) Add missing information on Version and VersionRange

[Guillaume Nodet (Jira)]

[ 
https://issues.apache.org/jira/browse/MNG-7969?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17797962#comment-17797962
 ] 

Guillaume Nodet commented on MNG-7969:
--

See 
[https://github.com/apache/maven/blob/master/api/maven-api-core/src/main/java/org/apache/maven/api/Version.java]

and 
[https://github.com/apache/maven/blob/master/api/maven-api-core/src/main/java/org/apache/maven/api/VersionRange.java]

 

They contain no access to the version (major, minor, etc...) or range (lower / 
upper bounds)  information.

> Add missing information on Version and VersionRange
> ---
>
> Key: MNG-7969
> URL: https://issues.apache.org/jira/browse/MNG-7969
> Project: Maven
>  Issue Type: New Feature
>  Components: API
>Reporter: Guillaume Nodet
>Assignee: Guillaume Nodet
>Priority: Major
> Fix For: 4.0.0-alpha-10
>
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Assigned] (MNG-7975) Update to logback 1.2.13

[Tamas Cservenak (Jira)]

 [ 
https://issues.apache.org/jira/browse/MNG-7975?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Tamas Cservenak reassigned MNG-7975:


Assignee: Tamas Cservenak

> Update to logback 1.2.13
> 
>
> Key: MNG-7975
> URL: https://issues.apache.org/jira/browse/MNG-7975
> Project: Maven
>  Issue Type: Dependency upgrade
>  Components: Bootstrap & Build
>Reporter: Tamas Cservenak
>Assignee: Tamas Cservenak
>Priority: Major
> Fix For: 4.0.0, 4.0.0-alpha-10
>
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Closed] (MNG-7975) Update to logback 1.2.13

[Tamas Cservenak (Jira)]

 [ 
https://issues.apache.org/jira/browse/MNG-7975?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Tamas Cservenak closed MNG-7975.

Resolution: Fixed

> Update to logback 1.2.13
> 
>
> Key: MNG-7975
> URL: https://issues.apache.org/jira/browse/MNG-7975
> Project: Maven
>  Issue Type: Dependency upgrade
>  Components: Bootstrap & Build
>Reporter: Tamas Cservenak
>Assignee: Tamas Cservenak
>Priority: Major
> Fix For: 4.0.0, 4.0.0-alpha-10
>
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Re: [PR] Bump ch.qos.logback:logback-classic from 1.2.11 to 1.2.13 [maven]

[via GitHub]

cstamas merged PR #1331:
URL: https://github.com/apache/maven/pull/1331


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[jira] [Created] (MNG-7975) Update to logback 1.2.13

[Tamas Cservenak (Jira)]

Tamas Cservenak created MNG-7975:


 Summary: Update to logback 1.2.13
 Key: MNG-7975
 URL: https://issues.apache.org/jira/browse/MNG-7975
 Project: Maven
  Issue Type: Dependency upgrade
  Components: Bootstrap & Build
Reporter: Tamas Cservenak
 Fix For: 4.0.0, 4.0.0-alpha-10






--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Updated] (MNG-7933) Artifact descriptor policy should be configurable

[Tamas Cservenak (Jira)]

 [ 
https://issues.apache.org/jira/browse/MNG-7933?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Tamas Cservenak updated MNG-7933:
-
Fix Version/s: 4.0.0-alpha-9
   (was: 4.0.0-alpha-10)

> Artifact descriptor policy should be configurable
> -
>
> Key: MNG-7933
> URL: https://issues.apache.org/jira/browse/MNG-7933
> Project: Maven
>  Issue Type: Improvement
>  Components: Artifacts and Repositories
>Reporter: Jared Stehler
>Assignee: Tamas Cservenak
>Priority: Major
> Fix For: 4.0.0-alpha-9, 4.0.0
>
>
> I wasn't able to find any way to configure a different artifact descriptor 
> policy; ideally this would be doable via a config property.
> [https://github.com/search?q=repo%3Aapache/maven%20setArtifactDescriptorPolicy&type=code]
>  



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Commented] (MNG-7933) Artifact descriptor policy should be configurable

[Tamas Cservenak (Jira)]

[ 
https://issues.apache.org/jira/browse/MNG-7933?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17797950#comment-17797950
 ] 

Tamas Cservenak commented on MNG-7933:
--

Fixed by https://github.com/apache/maven/pull/1301 (same area had huge amount 
of changes, these among them). New CLI parameters (short) is {{sadp}} long is 
{{strict-artifact-descriptor-policy}}.

> Artifact descriptor policy should be configurable
> -
>
> Key: MNG-7933
> URL: https://issues.apache.org/jira/browse/MNG-7933
> Project: Maven
>  Issue Type: Improvement
>  Components: Artifacts and Repositories, Core
>Reporter: Jared Stehler
>Priority: Major
> Fix For: 4.0.0, 4.0.0-alpha-10
>
>
> I wasn't able to find any way to configure a different artifact descriptor 
> policy; ideally this would be doable via a config property.
> [https://github.com/search?q=repo%3Aapache/maven%20setArtifactDescriptorPolicy&type=code]
>  



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Updated] (MNG-7933) Artifact descriptor policy should be configurable

[Tamas Cservenak (Jira)]

 [ 
https://issues.apache.org/jira/browse/MNG-7933?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Tamas Cservenak updated MNG-7933:
-
Component/s: (was: Core)

> Artifact descriptor policy should be configurable
> -
>
> Key: MNG-7933
> URL: https://issues.apache.org/jira/browse/MNG-7933
> Project: Maven
>  Issue Type: Improvement
>  Components: Artifacts and Repositories
>Reporter: Jared Stehler
>Assignee: Tamas Cservenak
>Priority: Major
> Fix For: 4.0.0, 4.0.0-alpha-10
>
>
> I wasn't able to find any way to configure a different artifact descriptor 
> policy; ideally this would be doable via a config property.
> [https://github.com/search?q=repo%3Aapache/maven%20setArtifactDescriptorPolicy&type=code]
>  



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Assigned] (MNG-7933) Artifact descriptor policy should be configurable

[Tamas Cservenak (Jira)]

 [ 
https://issues.apache.org/jira/browse/MNG-7933?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Tamas Cservenak reassigned MNG-7933:


Assignee: Tamas Cservenak

> Artifact descriptor policy should be configurable
> -
>
> Key: MNG-7933
> URL: https://issues.apache.org/jira/browse/MNG-7933
> Project: Maven
>  Issue Type: Improvement
>  Components: Artifacts and Repositories, Core
>Reporter: Jared Stehler
>Assignee: Tamas Cservenak
>Priority: Major
> Fix For: 4.0.0, 4.0.0-alpha-10
>
>
> I wasn't able to find any way to configure a different artifact descriptor 
> policy; ideally this would be doable via a config property.
> [https://github.com/search?q=repo%3Aapache/maven%20setArtifactDescriptorPolicy&type=code]
>  



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Closed] (MNG-7933) Artifact descriptor policy should be configurable

[Tamas Cservenak (Jira)]

 [ 
https://issues.apache.org/jira/browse/MNG-7933?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Tamas Cservenak closed MNG-7933.

Resolution: Fixed

> Artifact descriptor policy should be configurable
> -
>
> Key: MNG-7933
> URL: https://issues.apache.org/jira/browse/MNG-7933
> Project: Maven
>  Issue Type: Improvement
>  Components: Artifacts and Repositories, Core
>Reporter: Jared Stehler
>Priority: Major
> Fix For: 4.0.0, 4.0.0-alpha-10
>
>
> I wasn't able to find any way to configure a different artifact descriptor 
> policy; ideally this would be doable via a config property.
> [https://github.com/search?q=repo%3Aapache/maven%20setArtifactDescriptorPolicy&type=code]
>  



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Updated] (MNG-7933) Artifact descriptor policy should be configurable

[Tamas Cservenak (Jira)]

 [ 
https://issues.apache.org/jira/browse/MNG-7933?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Tamas Cservenak updated MNG-7933:
-
Fix Version/s: 4.0.0
   4.0.0-alpha-10

> Artifact descriptor policy should be configurable
> -
>
> Key: MNG-7933
> URL: https://issues.apache.org/jira/browse/MNG-7933
> Project: Maven
>  Issue Type: Improvement
>  Components: Artifacts and Repositories, Core
>Reporter: Jared Stehler
>Priority: Major
> Fix For: 4.0.0, 4.0.0-alpha-10
>
>
> I wasn't able to find any way to configure a different artifact descriptor 
> policy; ideally this would be doable via a config property.
> [https://github.com/search?q=repo%3Aapache/maven%20setArtifactDescriptorPolicy&type=code]
>  



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Commented] (MNG-7933) Artifact descriptor policy should be configurable

[ASF GitHub Bot (Jira)]

[ 
https://issues.apache.org/jira/browse/MNG-7933?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17797949#comment-17797949
 ] 

ASF GitHub Bot commented on MNG-7933:
-

jaredstehler closed pull request #1304: [MNG-7933] configure strict artifact 
descriptor policy via property
URL: https://github.com/apache/maven/pull/1304




> Artifact descriptor policy should be configurable
> -
>
> Key: MNG-7933
> URL: https://issues.apache.org/jira/browse/MNG-7933
> Project: Maven
>  Issue Type: Improvement
>  Components: Artifacts and Repositories, Core
>Reporter: Jared Stehler
>Priority: Major
>
> I wasn't able to find any way to configure a different artifact descriptor 
> policy; ideally this would be doable via a config property.
> [https://github.com/search?q=repo%3Aapache/maven%20setArtifactDescriptorPolicy&type=code]
>  



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Re: [PR] [MNG-7933] configure strict artifact descriptor policy via property [maven]

[via GitHub]

jaredstehler closed pull request #1304: [MNG-7933] configure strict artifact 
descriptor policy via property
URL: https://github.com/apache/maven/pull/1304


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[jira] [Commented] (SUREFIRE-1345) Report parser doesn't support flaky and retries

[ASF GitHub Bot (Jira)]

[ 
https://issues.apache.org/jira/browse/SUREFIRE-1345?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17797948#comment-17797948
 ] 

ASF GitHub Bot commented on SUREFIRE-1345:
--

michael-o commented on PR #700:
URL: https://github.com/apache/maven-surefire/pull/700#issuecomment-1859226263

   @kriegaex Any objections before I go over to your PR?




> Report parser doesn't support flaky and retries
> ---
>
> Key: SUREFIRE-1345
> URL: https://issues.apache.org/jira/browse/SUREFIRE-1345
> Project: Maven Surefire
>  Issue Type: Bug
>Reporter: Dmitry Baev
>Priority: Major
>
> TestSuiteXmlParser (from 
> `org.apache.maven.surefire:surefire-report-parser:2.19.1`)
> doesn't support changes described in 
> https://github.com/apache/maven-surefire/blob/master/maven-surefire-plugin/src/site/apt/examples/rerun-failing-tests.apt.vm



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Re: [PR] [SUREFIRE-1345] Support flakyFailure and flakyError in TestSuiteXmlParser [maven-surefire]

[via GitHub]

michael-o commented on PR #700:
URL: https://github.com/apache/maven-surefire/pull/700#issuecomment-1859226263

   @kriegaex Any objections before I go over to your PR?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[jira] [Commented] (SUREFIRE-1345) Report parser doesn't support flaky and retries

[ASF GitHub Bot (Jira)]

[ 
https://issues.apache.org/jira/browse/SUREFIRE-1345?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17797946#comment-17797946
 ] 

ASF GitHub Bot commented on SUREFIRE-1345:
--

gsmet commented on code in PR #700:
URL: https://github.com/apache/maven-surefire/pull/700#discussion_r1429212809


##
surefire-report-parser/src/main/java/org/apache/maven/plugins/surefire/report/ReportTestCase.java:
##
@@ -161,6 +168,26 @@ public boolean hasSkipped() {
 return hasSkipped;
 }
 
+public boolean hasFlake() {
+return !flakyErrors.isEmpty() || !flakyFailures.isEmpty();
+}
+
+public void addFlakyError(FlakyError flakyError) {
+flakyErrors.add(flakyError);
+}
+
+public List getFlakyErrors() {
+return flakyErrors;
+}
+
+public void addFlakyFailure(FlakyFailure flakyFailure) {
+flakyFailures.add(flakyFailure);
+}
+
+public List getFlakyFailures() {
+return flakyFailures;
+}

Review Comment:
   Done.



##
surefire-report-parser/src/main/java/org/apache/maven/plugins/surefire/report/ReportTestCase.java:
##
@@ -161,6 +168,26 @@ public boolean hasSkipped() {
 return hasSkipped;
 }
 
+public boolean hasFlake() {

Review Comment:
   Done.





> Report parser doesn't support flaky and retries
> ---
>
> Key: SUREFIRE-1345
> URL: https://issues.apache.org/jira/browse/SUREFIRE-1345
> Project: Maven Surefire
>  Issue Type: Bug
>Reporter: Dmitry Baev
>Priority: Major
>
> TestSuiteXmlParser (from 
> `org.apache.maven.surefire:surefire-report-parser:2.19.1`)
> doesn't support changes described in 
> https://github.com/apache/maven-surefire/blob/master/maven-surefire-plugin/src/site/apt/examples/rerun-failing-tests.apt.vm



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Commented] (SUREFIRE-1345) Report parser doesn't support flaky and retries

[ASF GitHub Bot (Jira)]

[ 
https://issues.apache.org/jira/browse/SUREFIRE-1345?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17797947#comment-17797947
 ] 

ASF GitHub Bot commented on SUREFIRE-1345:
--

gsmet commented on code in PR #700:
URL: https://github.com/apache/maven-surefire/pull/700#discussion_r1429212930


##
surefire-report-parser/src/main/java/org/apache/maven/plugins/surefire/report/TestSuiteXmlParser.java:
##
@@ -177,9 +183,27 @@ public void startElement(String uri, String localName, 
String qName, Attributes
 currentSuite.incrementNumberOfSkipped();
 break;
 case "flakyFailure":
+testCaseFlakyFailure = new ReportTestCase.FlakyFailure(
+attributes.getValue("message"), 
attributes.getValue("type"));
+currentSuite.incrementNumberOfFlakes();
+break;
 case "flakyError":
+testCaseFlakyError = new ReportTestCase.FlakyError(
+attributes.getValue("message"), 
attributes.getValue("type"));
 currentSuite.incrementNumberOfFlakes();
 break;
+case "stackTrace":
+currentElement = new StringBuilder();
+parseContent = true;
+break;
+case "system-out":
+currentElement = new StringBuilder();
+parseContent = true;
+break;
+case "system-err":
+currentElement = new StringBuilder();
+parseContent = true;
+break;

Review Comment:
   Ah removed the other part but forgot about these ones. Fixed.





> Report parser doesn't support flaky and retries
> ---
>
> Key: SUREFIRE-1345
> URL: https://issues.apache.org/jira/browse/SUREFIRE-1345
> Project: Maven Surefire
>  Issue Type: Bug
>Reporter: Dmitry Baev
>Priority: Major
>
> TestSuiteXmlParser (from 
> `org.apache.maven.surefire:surefire-report-parser:2.19.1`)
> doesn't support changes described in 
> https://github.com/apache/maven-surefire/blob/master/maven-surefire-plugin/src/site/apt/examples/rerun-failing-tests.apt.vm



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Re: [PR] [SUREFIRE-1345] Support flakyFailure and flakyError in TestSuiteXmlParser [maven-surefire]

[via GitHub]

gsmet commented on code in PR #700:
URL: https://github.com/apache/maven-surefire/pull/700#discussion_r1429212930


##
surefire-report-parser/src/main/java/org/apache/maven/plugins/surefire/report/TestSuiteXmlParser.java:
##
@@ -177,9 +183,27 @@ public void startElement(String uri, String localName, 
String qName, Attributes
 currentSuite.incrementNumberOfSkipped();
 break;
 case "flakyFailure":
+testCaseFlakyFailure = new ReportTestCase.FlakyFailure(
+attributes.getValue("message"), 
attributes.getValue("type"));
+currentSuite.incrementNumberOfFlakes();
+break;
 case "flakyError":
+testCaseFlakyError = new ReportTestCase.FlakyError(
+attributes.getValue("message"), 
attributes.getValue("type"));
 currentSuite.incrementNumberOfFlakes();
 break;
+case "stackTrace":
+currentElement = new StringBuilder();
+parseContent = true;
+break;
+case "system-out":
+currentElement = new StringBuilder();
+parseContent = true;
+break;
+case "system-err":
+currentElement = new StringBuilder();
+parseContent = true;
+break;

Review Comment:
   Ah removed the other part but forgot about these ones. Fixed.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] [SUREFIRE-1345] Support flakyFailure and flakyError in TestSuiteXmlParser [maven-surefire]

[via GitHub]

gsmet commented on code in PR #700:
URL: https://github.com/apache/maven-surefire/pull/700#discussion_r1429212809


##
surefire-report-parser/src/main/java/org/apache/maven/plugins/surefire/report/ReportTestCase.java:
##
@@ -161,6 +168,26 @@ public boolean hasSkipped() {
 return hasSkipped;
 }
 
+public boolean hasFlake() {
+return !flakyErrors.isEmpty() || !flakyFailures.isEmpty();
+}
+
+public void addFlakyError(FlakyError flakyError) {
+flakyErrors.add(flakyError);
+}
+
+public List getFlakyErrors() {
+return flakyErrors;
+}
+
+public void addFlakyFailure(FlakyFailure flakyFailure) {
+flakyFailures.add(flakyFailure);
+}
+
+public List getFlakyFailures() {
+return flakyFailures;
+}

Review Comment:
   Done.



##
surefire-report-parser/src/main/java/org/apache/maven/plugins/surefire/report/ReportTestCase.java:
##
@@ -161,6 +168,26 @@ public boolean hasSkipped() {
 return hasSkipped;
 }
 
+public boolean hasFlake() {

Review Comment:
   Done.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] Bump camel-core from 2.24.1 to 3.2.0 in /src/it/projects/bugs/massembly-920 [maven-assembly-plugin]

[via GitHub]

slawekjaranowski commented on PR #137:
URL: 
https://github.com/apache/maven-assembly-plugin/pull/137#issuecomment-1859223830

   @dependabot rebase


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[jira] [Commented] (SUREFIRE-1345) Report parser doesn't support flaky and retries

[ASF GitHub Bot (Jira)]

[ 
https://issues.apache.org/jira/browse/SUREFIRE-1345?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17797944#comment-17797944
 ] 

ASF GitHub Bot commented on SUREFIRE-1345:
--

michael-o commented on code in PR #700:
URL: https://github.com/apache/maven-surefire/pull/700#discussion_r1429207237


##
surefire-report-parser/src/main/java/org/apache/maven/plugins/surefire/report/ReportTestCase.java:
##
@@ -161,6 +168,26 @@ public boolean hasSkipped() {
 return hasSkipped;
 }
 
+public boolean hasFlake() {

Review Comment:
   `hasFlakes()`



##
surefire-report-parser/src/main/java/org/apache/maven/plugins/surefire/report/ReportTestCase.java:
##
@@ -161,6 +168,26 @@ public boolean hasSkipped() {
 return hasSkipped;
 }
 
+public boolean hasFlake() {
+return !flakyErrors.isEmpty() || !flakyFailures.isEmpty();
+}
+
+public void addFlakyError(FlakyError flakyError) {
+flakyErrors.add(flakyError);
+}
+
+public List getFlakyErrors() {
+return flakyErrors;
+}
+
+public void addFlakyFailure(FlakyFailure flakyFailure) {
+flakyFailures.add(flakyFailure);
+}
+
+public List getFlakyFailures() {
+return flakyFailures;
+}

Review Comment:
   Should these be immutable?



##
surefire-report-parser/src/main/java/org/apache/maven/plugins/surefire/report/TestSuiteXmlParser.java:
##
@@ -177,9 +183,27 @@ public void startElement(String uri, String localName, 
String qName, Attributes
 currentSuite.incrementNumberOfSkipped();
 break;
 case "flakyFailure":
+testCaseFlakyFailure = new ReportTestCase.FlakyFailure(
+attributes.getValue("message"), 
attributes.getValue("type"));
+currentSuite.incrementNumberOfFlakes();
+break;
 case "flakyError":
+testCaseFlakyError = new ReportTestCase.FlakyError(
+attributes.getValue("message"), 
attributes.getValue("type"));
 currentSuite.incrementNumberOfFlakes();
 break;
+case "stackTrace":
+currentElement = new StringBuilder();
+parseContent = true;
+break;
+case "system-out":
+currentElement = new StringBuilder();
+parseContent = true;
+break;
+case "system-err":
+currentElement = new StringBuilder();
+parseContent = true;
+break;

Review Comment:
   Both are still there?





> Report parser doesn't support flaky and retries
> ---
>
> Key: SUREFIRE-1345
> URL: https://issues.apache.org/jira/browse/SUREFIRE-1345
> Project: Maven Surefire
>  Issue Type: Bug
>Reporter: Dmitry Baev
>Priority: Major
>
> TestSuiteXmlParser (from 
> `org.apache.maven.surefire:surefire-report-parser:2.19.1`)
> doesn't support changes described in 
> https://github.com/apache/maven-surefire/blob/master/maven-surefire-plugin/src/site/apt/examples/rerun-failing-tests.apt.vm



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Re: [PR] [SUREFIRE-1345] Support flakyFailure and flakyError in TestSuiteXmlParser [maven-surefire]

[via GitHub]

michael-o commented on code in PR #700:
URL: https://github.com/apache/maven-surefire/pull/700#discussion_r1429207237


##
surefire-report-parser/src/main/java/org/apache/maven/plugins/surefire/report/ReportTestCase.java:
##
@@ -161,6 +168,26 @@ public boolean hasSkipped() {
 return hasSkipped;
 }
 
+public boolean hasFlake() {

Review Comment:
   `hasFlakes()`



##
surefire-report-parser/src/main/java/org/apache/maven/plugins/surefire/report/ReportTestCase.java:
##
@@ -161,6 +168,26 @@ public boolean hasSkipped() {
 return hasSkipped;
 }
 
+public boolean hasFlake() {
+return !flakyErrors.isEmpty() || !flakyFailures.isEmpty();
+}
+
+public void addFlakyError(FlakyError flakyError) {
+flakyErrors.add(flakyError);
+}
+
+public List getFlakyErrors() {
+return flakyErrors;
+}
+
+public void addFlakyFailure(FlakyFailure flakyFailure) {
+flakyFailures.add(flakyFailure);
+}
+
+public List getFlakyFailures() {
+return flakyFailures;
+}

Review Comment:
   Should these be immutable?



##
surefire-report-parser/src/main/java/org/apache/maven/plugins/surefire/report/TestSuiteXmlParser.java:
##
@@ -177,9 +183,27 @@ public void startElement(String uri, String localName, 
String qName, Attributes
 currentSuite.incrementNumberOfSkipped();
 break;
 case "flakyFailure":
+testCaseFlakyFailure = new ReportTestCase.FlakyFailure(
+attributes.getValue("message"), 
attributes.getValue("type"));
+currentSuite.incrementNumberOfFlakes();
+break;
 case "flakyError":
+testCaseFlakyError = new ReportTestCase.FlakyError(
+attributes.getValue("message"), 
attributes.getValue("type"));
 currentSuite.incrementNumberOfFlakes();
 break;
+case "stackTrace":
+currentElement = new StringBuilder();
+parseContent = true;
+break;
+case "system-out":
+currentElement = new StringBuilder();
+parseContent = true;
+break;
+case "system-err":
+currentElement = new StringBuilder();
+parseContent = true;
+break;

Review Comment:
   Both are still there?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[jira] [Commented] (SUREFIRE-1345) Report parser doesn't support flaky and retries

[ASF GitHub Bot (Jira)]

[ 
https://issues.apache.org/jira/browse/SUREFIRE-1345?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17797943#comment-17797943
 ] 

ASF GitHub Bot commented on SUREFIRE-1345:
--

gsmet commented on code in PR #700:
URL: https://github.com/apache/maven-surefire/pull/700#discussion_r1429205246


##
surefire-report-parser/src/main/java/org/apache/maven/plugins/surefire/report/TestSuiteXmlParser.java:
##
@@ -217,6 +241,38 @@ public void endElement(String uri, String localName, 
String qName) throws SAXExc
 throw new SAXException("Failed to parse time value", e);
 }
 break;
+case "flakyFailure":
+testCase.addFlakyFailure(testCaseFlakyFailure);
+testCaseFlakyFailure = null;
+break;
+case "flakyError":
+testCase.addFlakyError(testCaseFlakyError);
+testCaseFlakyError = null;
+break;
+case "stackTrace":
+if (testCaseFlakyFailure != null) {
+
testCaseFlakyFailure.setStackTrace(currentElement.toString());
+}
+if (testCaseFlakyError != null) {
+
testCaseFlakyError.setStackTrace(currentElement.toString());
+}
+break;
+case "system-out":
+if (testCaseFlakyFailure != null) {
+
testCaseFlakyFailure.setSystemOut(currentElement.toString());
+}
+if (testCaseFlakyError != null) {
+testCaseFlakyError.setSystemOut(currentElement.toString());
+}
+break;
+case "system-err":
+if (testCaseFlakyFailure != null) {
+
testCaseFlakyFailure.setSystemErr(currentElement.toString());
+}
+if (testCaseFlakyError != null) {
+testCaseFlakyError.setSystemErr(currentElement.toString());
+}

Review Comment:
   I pushed an additional commit to drop the parsing of system out and system 
err.





> Report parser doesn't support flaky and retries
> ---
>
> Key: SUREFIRE-1345
> URL: https://issues.apache.org/jira/browse/SUREFIRE-1345
> Project: Maven Surefire
>  Issue Type: Bug
>Reporter: Dmitry Baev
>Priority: Major
>
> TestSuiteXmlParser (from 
> `org.apache.maven.surefire:surefire-report-parser:2.19.1`)
> doesn't support changes described in 
> https://github.com/apache/maven-surefire/blob/master/maven-surefire-plugin/src/site/apt/examples/rerun-failing-tests.apt.vm



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Re: [PR] [SUREFIRE-1345] Support flakyFailure and flakyError in TestSuiteXmlParser [maven-surefire]

[via GitHub]

gsmet commented on code in PR #700:
URL: https://github.com/apache/maven-surefire/pull/700#discussion_r1429205246


##
surefire-report-parser/src/main/java/org/apache/maven/plugins/surefire/report/TestSuiteXmlParser.java:
##
@@ -217,6 +241,38 @@ public void endElement(String uri, String localName, 
String qName) throws SAXExc
 throw new SAXException("Failed to parse time value", e);
 }
 break;
+case "flakyFailure":
+testCase.addFlakyFailure(testCaseFlakyFailure);
+testCaseFlakyFailure = null;
+break;
+case "flakyError":
+testCase.addFlakyError(testCaseFlakyError);
+testCaseFlakyError = null;
+break;
+case "stackTrace":
+if (testCaseFlakyFailure != null) {
+
testCaseFlakyFailure.setStackTrace(currentElement.toString());
+}
+if (testCaseFlakyError != null) {
+
testCaseFlakyError.setStackTrace(currentElement.toString());
+}
+break;
+case "system-out":
+if (testCaseFlakyFailure != null) {
+
testCaseFlakyFailure.setSystemOut(currentElement.toString());
+}
+if (testCaseFlakyError != null) {
+testCaseFlakyError.setSystemOut(currentElement.toString());
+}
+break;
+case "system-err":
+if (testCaseFlakyFailure != null) {
+
testCaseFlakyFailure.setSystemErr(currentElement.toString());
+}
+if (testCaseFlakyError != null) {
+testCaseFlakyError.setSystemErr(currentElement.toString());
+}

Review Comment:
   I pushed an additional commit to drop the parsing of system out and system 
err.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[jira] [Commented] (SUREFIRE-1345) Report parser doesn't support flaky and retries

[ASF GitHub Bot (Jira)]

[ 
https://issues.apache.org/jira/browse/SUREFIRE-1345?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17797941#comment-17797941
 ] 

ASF GitHub Bot commented on SUREFIRE-1345:
--

michael-o commented on PR #700:
URL: https://github.com/apache/maven-surefire/pull/700#issuecomment-1859211434

   > The plan is to consume them in the Quarkus GitHub Bot for this feature: 
https://github.com/quarkusio/quarkus-github-bot#workflow-run-report .
   > 
   > It analyses all the build reports from our CI workflow and post a comment 
in the pull request.
   > 
   > We wanted to try to rerun tests but we need the feedback to contain the 
flakiness information.
   
   I see, let's focus on the issue and handle std streams separately, if you 
don't mind.




> Report parser doesn't support flaky and retries
> ---
>
> Key: SUREFIRE-1345
> URL: https://issues.apache.org/jira/browse/SUREFIRE-1345
> Project: Maven Surefire
>  Issue Type: Bug
>Reporter: Dmitry Baev
>Priority: Major
>
> TestSuiteXmlParser (from 
> `org.apache.maven.surefire:surefire-report-parser:2.19.1`)
> doesn't support changes described in 
> https://github.com/apache/maven-surefire/blob/master/maven-surefire-plugin/src/site/apt/examples/rerun-failing-tests.apt.vm



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Re: [PR] [SUREFIRE-1345] Support flakyFailure and flakyError in TestSuiteXmlParser [maven-surefire]

[via GitHub]

michael-o commented on PR #700:
URL: https://github.com/apache/maven-surefire/pull/700#issuecomment-1859211434

   > The plan is to consume them in the Quarkus GitHub Bot for this feature: 
https://github.com/quarkusio/quarkus-github-bot#workflow-run-report .
   > 
   > It analyses all the build reports from our CI workflow and post a comment 
in the pull request.
   > 
   > We wanted to try to rerun tests but we need the feedback to contain the 
flakiness information.
   
   I see, let's focus on the issue and handle std streams separately, if you 
don't mind.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[jira] [Commented] (SUREFIRE-1345) Report parser doesn't support flaky and retries

[ASF GitHub Bot (Jira)]

[ 
https://issues.apache.org/jira/browse/SUREFIRE-1345?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17797939#comment-17797939
 ] 

ASF GitHub Bot commented on SUREFIRE-1345:
--

gsmet commented on PR #700:
URL: https://github.com/apache/maven-surefire/pull/700#issuecomment-1859208898

   The plan is to consume them in the Quarkus GitHub Bot for this feature: 
https://github.com/quarkusio/quarkus-github-bot#workflow-run-report .
   
   It analyses all the build reports from our CI workflow and post a comment in 
the pull request.
   
   We wanted to try to rerun tests but we need the feedback to contain the 
flakiness information.




> Report parser doesn't support flaky and retries
> ---
>
> Key: SUREFIRE-1345
> URL: https://issues.apache.org/jira/browse/SUREFIRE-1345
> Project: Maven Surefire
>  Issue Type: Bug
>Reporter: Dmitry Baev
>Priority: Major
>
> TestSuiteXmlParser (from 
> `org.apache.maven.surefire:surefire-report-parser:2.19.1`)
> doesn't support changes described in 
> https://github.com/apache/maven-surefire/blob/master/maven-surefire-plugin/src/site/apt/examples/rerun-failing-tests.apt.vm



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Re: [PR] [SUREFIRE-1345] Support flakyFailure and flakyError in TestSuiteXmlParser [maven-surefire]

[via GitHub]

gsmet commented on PR #700:
URL: https://github.com/apache/maven-surefire/pull/700#issuecomment-1859208898

   The plan is to consume them in the Quarkus GitHub Bot for this feature: 
https://github.com/quarkusio/quarkus-github-bot#workflow-run-report .
   
   It analyses all the build reports from our CI workflow and post a comment in 
the pull request.
   
   We wanted to try to rerun tests but we need the feedback to contain the 
flakiness information.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] Bump org.apache.commons:commons-text from 1.10.0 to 1.11.0 [maven-dependency-plugin]

[via GitHub]

elharo merged PR #357:
URL: https://github.com/apache/maven-dependency-plugin/pull/357


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] [MASSEMBLY-1013] Remove custom SAR UnArchiver [maven-assembly-plugin]

[via GitHub]

slawekjaranowski merged PR #175:
URL: https://github.com/apache/maven-assembly-plugin/pull/175


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[jira] [Commented] (SUREFIRE-1345) Report parser doesn't support flaky and retries

[ASF GitHub Bot (Jira)]

[ 
https://issues.apache.org/jira/browse/SUREFIRE-1345?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17797931#comment-17797931
 ] 

ASF GitHub Bot commented on SUREFIRE-1345:
--

michael-o commented on code in PR #700:
URL: https://github.com/apache/maven-surefire/pull/700#discussion_r1429177568


##
surefire-report-parser/src/main/java/org/apache/maven/plugins/surefire/report/TestSuiteXmlParser.java:
##
@@ -217,6 +241,38 @@ public void endElement(String uri, String localName, 
String qName) throws SAXExc
 throw new SAXException("Failed to parse time value", e);
 }
 break;
+case "flakyFailure":
+testCase.addFlakyFailure(testCaseFlakyFailure);
+testCaseFlakyFailure = null;
+break;
+case "flakyError":
+testCase.addFlakyError(testCaseFlakyError);
+testCaseFlakyError = null;
+break;
+case "stackTrace":
+if (testCaseFlakyFailure != null) {
+
testCaseFlakyFailure.setStackTrace(currentElement.toString());
+}
+if (testCaseFlakyError != null) {
+
testCaseFlakyError.setStackTrace(currentElement.toString());
+}
+break;
+case "system-out":
+if (testCaseFlakyFailure != null) {
+
testCaseFlakyFailure.setSystemOut(currentElement.toString());
+}
+if (testCaseFlakyError != null) {
+testCaseFlakyError.setSystemOut(currentElement.toString());
+}
+break;
+case "system-err":
+if (testCaseFlakyFailure != null) {
+
testCaseFlakyFailure.setSystemErr(currentElement.toString());
+}
+if (testCaseFlakyError != null) {
+testCaseFlakyError.setSystemErr(currentElement.toString());
+}

Review Comment:
   Yes, please do so. It should be handled separate will adequate testing.





> Report parser doesn't support flaky and retries
> ---
>
> Key: SUREFIRE-1345
> URL: https://issues.apache.org/jira/browse/SUREFIRE-1345
> Project: Maven Surefire
>  Issue Type: Bug
>Reporter: Dmitry Baev
>Priority: Major
>
> TestSuiteXmlParser (from 
> `org.apache.maven.surefire:surefire-report-parser:2.19.1`)
> doesn't support changes described in 
> https://github.com/apache/maven-surefire/blob/master/maven-surefire-plugin/src/site/apt/examples/rerun-failing-tests.apt.vm



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Commented] (SUREFIRE-1345) Report parser doesn't support flaky and retries

[ASF GitHub Bot (Jira)]

[ 
https://issues.apache.org/jira/browse/SUREFIRE-1345?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17797934#comment-17797934
 ] 

ASF GitHub Bot commented on SUREFIRE-1345:
--

michael-o commented on PR #700:
URL: https://github.com/apache/maven-surefire/pull/700#issuecomment-1859189876

   Yet another question: How do you want to utilize the data? In the Maven 
Surefire Report Plugin or somewhere else?




> Report parser doesn't support flaky and retries
> ---
>
> Key: SUREFIRE-1345
> URL: https://issues.apache.org/jira/browse/SUREFIRE-1345
> Project: Maven Surefire
>  Issue Type: Bug
>Reporter: Dmitry Baev
>Priority: Major
>
> TestSuiteXmlParser (from 
> `org.apache.maven.surefire:surefire-report-parser:2.19.1`)
> doesn't support changes described in 
> https://github.com/apache/maven-surefire/blob/master/maven-surefire-plugin/src/site/apt/examples/rerun-failing-tests.apt.vm



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Re: [PR] [SUREFIRE-1345] Support flakyFailure and flakyError in TestSuiteXmlParser [maven-surefire]

[via GitHub]

michael-o commented on PR #700:
URL: https://github.com/apache/maven-surefire/pull/700#issuecomment-1859189876

   Yet another question: How do you want to utilize the data? In the Maven 
Surefire Report Plugin or somewhere else?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] [SUREFIRE-1345] Support flakyFailure and flakyError in TestSuiteXmlParser [maven-surefire]

[via GitHub]

michael-o commented on code in PR #700:
URL: https://github.com/apache/maven-surefire/pull/700#discussion_r1429177568


##
surefire-report-parser/src/main/java/org/apache/maven/plugins/surefire/report/TestSuiteXmlParser.java:
##
@@ -217,6 +241,38 @@ public void endElement(String uri, String localName, 
String qName) throws SAXExc
 throw new SAXException("Failed to parse time value", e);
 }
 break;
+case "flakyFailure":
+testCase.addFlakyFailure(testCaseFlakyFailure);
+testCaseFlakyFailure = null;
+break;
+case "flakyError":
+testCase.addFlakyError(testCaseFlakyError);
+testCaseFlakyError = null;
+break;
+case "stackTrace":
+if (testCaseFlakyFailure != null) {
+
testCaseFlakyFailure.setStackTrace(currentElement.toString());
+}
+if (testCaseFlakyError != null) {
+
testCaseFlakyError.setStackTrace(currentElement.toString());
+}
+break;
+case "system-out":
+if (testCaseFlakyFailure != null) {
+
testCaseFlakyFailure.setSystemOut(currentElement.toString());
+}
+if (testCaseFlakyError != null) {
+testCaseFlakyError.setSystemOut(currentElement.toString());
+}
+break;
+case "system-err":
+if (testCaseFlakyFailure != null) {
+
testCaseFlakyFailure.setSystemErr(currentElement.toString());
+}
+if (testCaseFlakyError != null) {
+testCaseFlakyError.setSystemErr(currentElement.toString());
+}

Review Comment:
   Yes, please do so. It should be handled separate will adequate testing.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[jira] [Commented] (MNG-7972) Artifact creation from "standard string"

[ASF GitHub Bot (Jira)]

[ 
https://issues.apache.org/jira/browse/MNG-7972?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17797929#comment-17797929
 ] 

ASF GitHub Bot commented on MNG-7972:
-

cstamas opened a new pull request, #1347:
URL: https://github.com/apache/maven/pull/1347

   Expose ArtifactCoordinate creation out of standard string.
   
   ---
   
   https://issues.apache.org/jira/browse/MNG-7972




> Artifact creation from "standard string"
> 
>
> Key: MNG-7972
> URL: https://issues.apache.org/jira/browse/MNG-7972
> Project: Maven
>  Issue Type: Task
>  Components: Core
>Reporter: Tamas Cservenak
>Assignee: Tamas Cservenak
>Priority: Major
> Fix For: 4.0.0, 4.0.0-alpha-10
>
>
> Expose API to create artifact from "standard string":
> {noformat}
> :[:[:]]:{noformat}
> As currently there is none for this.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[PR] [MNG-7972] Artifact coordinate out of "standard string" [maven]

[via GitHub]

cstamas opened a new pull request, #1347:
URL: https://github.com/apache/maven/pull/1347

   Expose ArtifactCoordinate creation out of standard string.
   
   ---
   
   https://issues.apache.org/jira/browse/MNG-7972


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[jira] [Assigned] (MNG-7972) Artifact creation from "standard string"

[Tamas Cservenak (Jira)]

 [ 
https://issues.apache.org/jira/browse/MNG-7972?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Tamas Cservenak reassigned MNG-7972:


Assignee: Tamas Cservenak

> Artifact creation from "standard string"
> 
>
> Key: MNG-7972
> URL: https://issues.apache.org/jira/browse/MNG-7972
> Project: Maven
>  Issue Type: Task
>  Components: Core
>Reporter: Tamas Cservenak
>Assignee: Tamas Cservenak
>Priority: Major
> Fix For: 4.0.0, 4.0.0-alpha-10
>
>
> Expose API to create artifact from "standard string":
> {noformat}
> :[:[:]]:{noformat}
> As currently there is none for this.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Assigned] (MNG-7968) Maven RT Service equivalent for RuntimeInformation

[Tamas Cservenak (Jira)]

 [ 
https://issues.apache.org/jira/browse/MNG-7968?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Tamas Cservenak reassigned MNG-7968:


Assignee: Tamas Cservenak

> Maven RT Service equivalent for RuntimeInformation
> --
>
> Key: MNG-7968
> URL: https://issues.apache.org/jira/browse/MNG-7968
> Project: Maven
>  Issue Type: Task
>  Components: Core
>Reporter: Tamas Cservenak
>Assignee: Tamas Cservenak
>Priority: Major
> Fix For: 4.0.0, 4.0.0-alpha-10
>
>
> Equivalent service for org.apache.maven.rtinfo.RuntimeInformation to reveal 
> "runtime Maven Version" for those who needs it.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Commented] (MNG-7968) Maven RT Service equivalent for RuntimeInformation

[ASF GitHub Bot (Jira)]

[ 
https://issues.apache.org/jira/browse/MNG-7968?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17797927#comment-17797927
 ] 

ASF GitHub Bot commented on MNG-7968:
-

cstamas opened a new pull request, #1346:
URL: https://github.com/apache/maven/pull/1346

   New API for Runtime info
   
   ---
   
   https://issues.apache.org/jira/browse/MNG-7968




> Maven RT Service equivalent for RuntimeInformation
> --
>
> Key: MNG-7968
> URL: https://issues.apache.org/jira/browse/MNG-7968
> Project: Maven
>  Issue Type: Task
>  Components: Core
>Reporter: Tamas Cservenak
>Priority: Major
> Fix For: 4.0.0, 4.0.0-alpha-10
>
>
> Equivalent service for org.apache.maven.rtinfo.RuntimeInformation to reveal 
> "runtime Maven Version" for those who needs it.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[PR] [MNG-7968] RT info service [maven]

[via GitHub]

cstamas opened a new pull request, #1346:
URL: https://github.com/apache/maven/pull/1346

   New API for Runtime info
   
   ---
   
   https://issues.apache.org/jira/browse/MNG-7968


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[jira] [Commented] (MNG-7969) Add missing information on Version and VersionRange

[Tamas Cservenak (Jira)]

[ 
https://issues.apache.org/jira/browse/MNG-7969?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17797926#comment-17797926
 ] 

Tamas Cservenak commented on MNG-7969:
--

What is this about?

> Add missing information on Version and VersionRange
> ---
>
> Key: MNG-7969
> URL: https://issues.apache.org/jira/browse/MNG-7969
> Project: Maven
>  Issue Type: New Feature
>  Components: API
>Reporter: Guillaume Nodet
>Assignee: Guillaume Nodet
>Priority: Major
> Fix For: 4.0.0-alpha-10
>
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Commented] (MNG-7967) The javadoc:jar goal is broken due Maven Core

[Tamas Cservenak (Jira)]

[ 
https://issues.apache.org/jira/browse/MNG-7967?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17797924#comment-17797924
 ] 

Tamas Cservenak commented on MNG-7967:
--

IT merged as 
https://github.com/apache/maven-integration-testing/commit/b4e8fd52b99a058336f9c7c5ec44fdbc1427759c

> The javadoc:jar goal is broken due Maven Core
> -
>
> Key: MNG-7967
> URL: https://issues.apache.org/jira/browse/MNG-7967
> Project: Maven
>  Issue Type: Bug
>  Components: Core
>Affects Versions: 4.0.0-alpha-9
>Reporter: Tamas Cservenak
>Assignee: Tamas Cservenak
>Priority: Major
> Fix For: 4.0.0, 4.0.0-alpha-10
>
>
> The plugin contains a check for Artifact "language", but in MNG-7924 we did 
> not retain the "language" assuming is not used. It turned out it is used, as 
> javadoc:jar Mojo shows.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Closed] (MNG-7967) The javadoc:jar goal is broken due Maven Core

[Tamas Cservenak (Jira)]

 [ 
https://issues.apache.org/jira/browse/MNG-7967?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Tamas Cservenak closed MNG-7967.

Resolution: Fixed

> The javadoc:jar goal is broken due Maven Core
> -
>
> Key: MNG-7967
> URL: https://issues.apache.org/jira/browse/MNG-7967
> Project: Maven
>  Issue Type: Bug
>  Components: Core
>Affects Versions: 4.0.0-alpha-9
>Reporter: Tamas Cservenak
>Assignee: Tamas Cservenak
>Priority: Major
> Fix For: 4.0.0, 4.0.0-alpha-10
>
>
> The plugin contains a check for Artifact "language", but in MNG-7924 we did 
> not retain the "language" assuming is not used. It turned out it is used, as 
> javadoc:jar Mojo shows.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Commented] (MASSEMBLY-992) Facility to define assembly descriptor in body of POM

[ASF GitHub Bot (Jira)]

[ 
https://issues.apache.org/jira/browse/MASSEMBLY-992?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17797923#comment-17797923
 ] 

ASF GitHub Bot commented on MASSEMBLY-992:
--

elharo commented on code in PR #174:
URL: 
https://github.com/apache/maven-assembly-plugin/pull/174#discussion_r1429161427


##
src/site/apt/examples/using-inline-descriptors.apt.vm:
##
@@ -0,0 +1,86 @@
+ --
+  Using Inline Assembly Descriptors
+ --
+  Slawomir Jaranowski
+ --
+  2023-12-17
+ --
+
+~~ Licensed to the Apache Software Foundation (ASF) under one
+~~ or more contributor license agreements.  See the NOTICE file
+~~ distributed with this work for additional information
+~~ regarding copyright ownership.  The ASF licenses this file
+~~ to you under the Apache License, Version 2.0 (the
+~~ "License"); you may not use this file except in compliance
+~~ with the License.  You may obtain a copy of the License at
+~~
+~~   http://www.apache.org/licenses/LICENSE-2.0
+~~
+~~ Unless required by applicable law or agreed to in writing,
+~~ software distributed under the License is distributed on an
+~~ "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+~~ KIND, either express or implied.  See the License for the
+~~ specific language governing permissions and limitations
+~~ under the License.
+
+~~ NOTE: For help with the syntax of this file, see:
+~~ https://maven.apache.org/doxia/references/apt-format.html
+
+Using Inline Assembly Descriptors
+
+* Introduction
+
+  For simple usage we can inline Assembly descriptor into project 
configuration.

Review Comment:
   the project configuration



##
src/site/apt/examples/using-inline-descriptors.apt.vm:
##
@@ -0,0 +1,86 @@
+ --
+  Using Inline Assembly Descriptors
+ --
+  Slawomir Jaranowski
+ --
+  2023-12-17
+ --
+
+~~ Licensed to the Apache Software Foundation (ASF) under one
+~~ or more contributor license agreements.  See the NOTICE file
+~~ distributed with this work for additional information
+~~ regarding copyright ownership.  The ASF licenses this file
+~~ to you under the Apache License, Version 2.0 (the
+~~ "License"); you may not use this file except in compliance
+~~ with the License.  You may obtain a copy of the License at
+~~
+~~   http://www.apache.org/licenses/LICENSE-2.0
+~~
+~~ Unless required by applicable law or agreed to in writing,
+~~ software distributed under the License is distributed on an
+~~ "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+~~ KIND, either express or implied.  See the License for the
+~~ specific language governing permissions and limitations
+~~ under the License.
+
+~~ NOTE: For help with the syntax of this file, see:
+~~ https://maven.apache.org/doxia/references/apt-format.html
+
+Using Inline Assembly Descriptors
+
+* Introduction
+
+  For simple usage we can inline Assembly descriptor into project 
configuration.
+  We don't need to create additional file with Assembly descriptor.

Review Comment:
   an additional



##
src/site/apt/examples/using-inline-descriptors.apt.vm:
##
@@ -0,0 +1,86 @@
+ --
+  Using Inline Assembly Descriptors
+ --
+  Slawomir Jaranowski
+ --
+  2023-12-17
+ --
+
+~~ Licensed to the Apache Software Foundation (ASF) under one
+~~ or more contributor license agreements.  See the NOTICE file
+~~ distributed with this work for additional information
+~~ regarding copyright ownership.  The ASF licenses this file
+~~ to you under the Apache License, Version 2.0 (the
+~~ "License"); you may not use this file except in compliance
+~~ with the License.  You may obtain a copy of the License at
+~~
+~~   http://www.apache.org/licenses/LICENSE-2.0
+~~
+~~ Unless required by applicable law or agreed to in writing,
+~~ software distributed under the License is distributed on an
+~~ "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+~~ KIND, either express or implied.  See the License for the
+~~ specific language governing permissions and limitations
+~~ under the License.
+
+~~ NOTE: For help with the syntax of this file, see:
+~~ https://maven.apache.org/doxia/references/apt-format.html
+
+Using Inline Assembly Descriptors
+
+* Introduction
+
+  For simple usage we can inline Assembly descriptor into project 
configuration.
+  We don't need to create additional file with Assembly descriptor.
+
+  It can allow simplify configuration in case of inherited,

Review Comment:
   delete "allow"
   sounds like a sentence fragment? Is something missing? inherited what?





> Facility to define assembly descriptor in body of POM
> -
>
> Key: MASSEMBLY-992
> URL: https://issues.apache.org/jira/browse/MASSEMBLY-992
> Project: Maven Assembly Plugin
>  Issue Type: New Feature
>Reporter: Garret Wilson
>Assignee

Re: [PR] [MASSEMBLY-992] Inline Assembly Descriptors [maven-assembly-plugin]

[via GitHub]

elharo commented on code in PR #174:
URL: 
https://github.com/apache/maven-assembly-plugin/pull/174#discussion_r1429161427


##
src/site/apt/examples/using-inline-descriptors.apt.vm:
##
@@ -0,0 +1,86 @@
+ --
+  Using Inline Assembly Descriptors
+ --
+  Slawomir Jaranowski
+ --
+  2023-12-17
+ --
+
+~~ Licensed to the Apache Software Foundation (ASF) under one
+~~ or more contributor license agreements.  See the NOTICE file
+~~ distributed with this work for additional information
+~~ regarding copyright ownership.  The ASF licenses this file
+~~ to you under the Apache License, Version 2.0 (the
+~~ "License"); you may not use this file except in compliance
+~~ with the License.  You may obtain a copy of the License at
+~~
+~~   http://www.apache.org/licenses/LICENSE-2.0
+~~
+~~ Unless required by applicable law or agreed to in writing,
+~~ software distributed under the License is distributed on an
+~~ "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+~~ KIND, either express or implied.  See the License for the
+~~ specific language governing permissions and limitations
+~~ under the License.
+
+~~ NOTE: For help with the syntax of this file, see:
+~~ https://maven.apache.org/doxia/references/apt-format.html
+
+Using Inline Assembly Descriptors
+
+* Introduction
+
+  For simple usage we can inline Assembly descriptor into project 
configuration.

Review Comment:
   the project configuration



##
src/site/apt/examples/using-inline-descriptors.apt.vm:
##
@@ -0,0 +1,86 @@
+ --
+  Using Inline Assembly Descriptors
+ --
+  Slawomir Jaranowski
+ --
+  2023-12-17
+ --
+
+~~ Licensed to the Apache Software Foundation (ASF) under one
+~~ or more contributor license agreements.  See the NOTICE file
+~~ distributed with this work for additional information
+~~ regarding copyright ownership.  The ASF licenses this file
+~~ to you under the Apache License, Version 2.0 (the
+~~ "License"); you may not use this file except in compliance
+~~ with the License.  You may obtain a copy of the License at
+~~
+~~   http://www.apache.org/licenses/LICENSE-2.0
+~~
+~~ Unless required by applicable law or agreed to in writing,
+~~ software distributed under the License is distributed on an
+~~ "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+~~ KIND, either express or implied.  See the License for the
+~~ specific language governing permissions and limitations
+~~ under the License.
+
+~~ NOTE: For help with the syntax of this file, see:
+~~ https://maven.apache.org/doxia/references/apt-format.html
+
+Using Inline Assembly Descriptors
+
+* Introduction
+
+  For simple usage we can inline Assembly descriptor into project 
configuration.
+  We don't need to create additional file with Assembly descriptor.

Review Comment:
   an additional



##
src/site/apt/examples/using-inline-descriptors.apt.vm:
##
@@ -0,0 +1,86 @@
+ --
+  Using Inline Assembly Descriptors
+ --
+  Slawomir Jaranowski
+ --
+  2023-12-17
+ --
+
+~~ Licensed to the Apache Software Foundation (ASF) under one
+~~ or more contributor license agreements.  See the NOTICE file
+~~ distributed with this work for additional information
+~~ regarding copyright ownership.  The ASF licenses this file
+~~ to you under the Apache License, Version 2.0 (the
+~~ "License"); you may not use this file except in compliance
+~~ with the License.  You may obtain a copy of the License at
+~~
+~~   http://www.apache.org/licenses/LICENSE-2.0
+~~
+~~ Unless required by applicable law or agreed to in writing,
+~~ software distributed under the License is distributed on an
+~~ "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+~~ KIND, either express or implied.  See the License for the
+~~ specific language governing permissions and limitations
+~~ under the License.
+
+~~ NOTE: For help with the syntax of this file, see:
+~~ https://maven.apache.org/doxia/references/apt-format.html
+
+Using Inline Assembly Descriptors
+
+* Introduction
+
+  For simple usage we can inline Assembly descriptor into project 
configuration.
+  We don't need to create additional file with Assembly descriptor.
+
+  It can allow simplify configuration in case of inherited,

Review Comment:
   delete "allow"
   sounds like a sentence fragment? Is something missing? inherited what?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] [MNG-7967] Verify javadoc:jar is invoked [maven-integration-testing]

[via GitHub]

cstamas merged PR #324:
URL: https://github.com/apache/maven-integration-testing/pull/324


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[jira] [Commented] (SUREFIRE-1345) Report parser doesn't support flaky and retries

[ASF GitHub Bot (Jira)]

[ 
https://issues.apache.org/jira/browse/SUREFIRE-1345?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17797922#comment-17797922
 ] 

ASF GitHub Bot commented on SUREFIRE-1345:
--

gsmet commented on code in PR #700:
URL: https://github.com/apache/maven-surefire/pull/700#discussion_r1429156954


##
surefire-report-parser/src/main/java/org/apache/maven/plugins/surefire/report/TestSuiteXmlParser.java:
##
@@ -217,6 +241,38 @@ public void endElement(String uri, String localName, 
String qName) throws SAXExc
 throw new SAXException("Failed to parse time value", e);
 }
 break;
+case "flakyFailure":
+testCase.addFlakyFailure(testCaseFlakyFailure);
+testCaseFlakyFailure = null;
+break;
+case "flakyError":
+testCase.addFlakyError(testCaseFlakyError);
+testCaseFlakyError = null;
+break;
+case "stackTrace":
+if (testCaseFlakyFailure != null) {
+
testCaseFlakyFailure.setStackTrace(currentElement.toString());
+}
+if (testCaseFlakyError != null) {
+
testCaseFlakyError.setStackTrace(currentElement.toString());
+}
+break;
+case "system-out":
+if (testCaseFlakyFailure != null) {
+
testCaseFlakyFailure.setSystemOut(currentElement.toString());
+}
+if (testCaseFlakyError != null) {
+testCaseFlakyError.setSystemOut(currentElement.toString());
+}
+break;
+case "system-err":
+if (testCaseFlakyFailure != null) {
+
testCaseFlakyFailure.setSystemErr(currentElement.toString());
+}
+if (testCaseFlakyError != null) {
+testCaseFlakyError.setSystemErr(currentElement.toString());
+}

Review Comment:
   Given the parsing is sequential, I don't think it's going to be hard to 
affect things properly.
   
   But if we think parsing system out and system err is controversial and 
require more thinking, I can remove them from this patch. I added them to be 
comprehensive but atm I don't actually need them.





> Report parser doesn't support flaky and retries
> ---
>
> Key: SUREFIRE-1345
> URL: https://issues.apache.org/jira/browse/SUREFIRE-1345
> Project: Maven Surefire
>  Issue Type: Bug
>Reporter: Dmitry Baev
>Priority: Major
>
> TestSuiteXmlParser (from 
> `org.apache.maven.surefire:surefire-report-parser:2.19.1`)
> doesn't support changes described in 
> https://github.com/apache/maven-surefire/blob/master/maven-surefire-plugin/src/site/apt/examples/rerun-failing-tests.apt.vm



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Re: [PR] [SUREFIRE-1345] Support flakyFailure and flakyError in TestSuiteXmlParser [maven-surefire]

[via GitHub]

gsmet commented on code in PR #700:
URL: https://github.com/apache/maven-surefire/pull/700#discussion_r1429156954


##
surefire-report-parser/src/main/java/org/apache/maven/plugins/surefire/report/TestSuiteXmlParser.java:
##
@@ -217,6 +241,38 @@ public void endElement(String uri, String localName, 
String qName) throws SAXExc
 throw new SAXException("Failed to parse time value", e);
 }
 break;
+case "flakyFailure":
+testCase.addFlakyFailure(testCaseFlakyFailure);
+testCaseFlakyFailure = null;
+break;
+case "flakyError":
+testCase.addFlakyError(testCaseFlakyError);
+testCaseFlakyError = null;
+break;
+case "stackTrace":
+if (testCaseFlakyFailure != null) {
+
testCaseFlakyFailure.setStackTrace(currentElement.toString());
+}
+if (testCaseFlakyError != null) {
+
testCaseFlakyError.setStackTrace(currentElement.toString());
+}
+break;
+case "system-out":
+if (testCaseFlakyFailure != null) {
+
testCaseFlakyFailure.setSystemOut(currentElement.toString());
+}
+if (testCaseFlakyError != null) {
+testCaseFlakyError.setSystemOut(currentElement.toString());
+}
+break;
+case "system-err":
+if (testCaseFlakyFailure != null) {
+
testCaseFlakyFailure.setSystemErr(currentElement.toString());
+}
+if (testCaseFlakyError != null) {
+testCaseFlakyError.setSystemErr(currentElement.toString());
+}

Review Comment:
   Given the parsing is sequential, I don't think it's going to be hard to 
affect things properly.
   
   But if we think parsing system out and system err is controversial and 
require more thinking, I can remove them from this patch. I added them to be 
comprehensive but atm I don't actually need them.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] Use Maven 3.9.6 [maven-integration-testing]

[via GitHub]

cstamas merged PR #328:
URL: https://github.com/apache/maven-integration-testing/pull/328


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[PR] Use Maven 3.9.6 [maven-integration-testing]

[via GitHub]

cstamas opened a new pull request, #328:
URL: https://github.com/apache/maven-integration-testing/pull/328

   (no comment)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] Update Jetty to 9.4.53.v20231009 [maven-integration-testing]

[via GitHub]

cstamas merged PR #326:
URL: https://github.com/apache/maven-integration-testing/pull/326


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[jira] [Assigned] (MNG-7974) Update to Resolver 2.0.0-alpha-5

[Tamas Cservenak (Jira)]

 [ 
https://issues.apache.org/jira/browse/MNG-7974?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Tamas Cservenak reassigned MNG-7974:


Assignee: Tamas Cservenak

> Update to Resolver 2.0.0-alpha-5
> 
>
> Key: MNG-7974
> URL: https://issues.apache.org/jira/browse/MNG-7974
> Project: Maven
>  Issue Type: Dependency upgrade
>  Components: Artifacts and Repositories
>Reporter: Tamas Cservenak
>Assignee: Tamas Cservenak
>Priority: Major
> Fix For: 4.0.0, 4.0.0-alpha-10
>
>
> Update to Resolver 2.0.0-alpha-5



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Created] (MNG-7974) Update to Resolver 2.0.0-alpha-5

[Tamas Cservenak (Jira)]

Tamas Cservenak created MNG-7974:


 Summary: Update to Resolver 2.0.0-alpha-5
 Key: MNG-7974
 URL: https://issues.apache.org/jira/browse/MNG-7974
 Project: Maven
  Issue Type: Dependency upgrade
  Components: Artifacts and Repositories
Reporter: Tamas Cservenak
 Fix For: 4.0.0, 4.0.0-alpha-10


Update to Resolver 2.0.0-alpha-5



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[PR] [MASSEMBLY-1013] Remove custom SAR UnArchiver [maven-assembly-plugin]

[via GitHub]

slawekjaranowski opened a new pull request, #175:
URL: https://github.com/apache/maven-assembly-plugin/pull/175

   It is implemented by newer plexus-archiver
   
   ---
   
   Following this checklist to help us incorporate your 
   contribution quickly and easily:
   
- [x] Make sure there is a [JIRA 
issue](https://issues.apache.org/jira/browse/MASSEMBLY) filed 
  for the change (usually before you start working on it).  Trivial 
changes like typos do not 
  require a JIRA issue.  Your pull request should address just this 
issue, without 
  pulling in other changes.
- [x] Each commit in the pull request should have a meaningful subject line 
and body.
- [x] Format the pull request title like `[MASSEMBLY-XXX] - Fixes bug in 
ApproximateQuantiles`,
  where you replace `MASSEMBLY-XXX` with the appropriate JIRA issue. 
Best practice
  is to use the JIRA issue title in the pull request title and in the 
first line of the 
  commit message.
- [x] Write a pull request description that is detailed enough to 
understand what the pull request does, how, and why.
- [x] Run `mvn clean verify` to make sure basic checks pass. A more 
thorough check will 
  be performed on your pull request automatically.
- [x] You have run the integration tests successfully (`mvn -Prun-its clean 
verify`).
   
   If your pull request is about ~20 lines of code you don't need to sign an
   [Individual Contributor License 
Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure
   please ask on the developers list.
   
   To make clear that you license your contribution under 
   the [Apache License Version 2.0, January 
2004](http://www.apache.org/licenses/LICENSE-2.0)
   you have to acknowledge this by using the following check-box.
   
- [x] I hereby declare this contribution to be licenced under the [Apache 
License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
   
- [x] In any other case, please file an [Apache Individual Contributor 
License Agreement](https://www.apache.org/licenses/icla.pdf).
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[jira] [Commented] (MASSEMBLY-1013) Code cleanups

[ASF GitHub Bot (Jira)]

[ 
https://issues.apache.org/jira/browse/MASSEMBLY-1013?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17797914#comment-17797914
 ] 

ASF GitHub Bot commented on MASSEMBLY-1013:
---

slawekjaranowski opened a new pull request, #175:
URL: https://github.com/apache/maven-assembly-plugin/pull/175

   It is implemented by newer plexus-archiver
   
   ---
   
   Following this checklist to help us incorporate your 
   contribution quickly and easily:
   
- [x] Make sure there is a [JIRA 
issue](https://issues.apache.org/jira/browse/MASSEMBLY) filed 
  for the change (usually before you start working on it).  Trivial 
changes like typos do not 
  require a JIRA issue.  Your pull request should address just this 
issue, without 
  pulling in other changes.
- [x] Each commit in the pull request should have a meaningful subject line 
and body.
- [x] Format the pull request title like `[MASSEMBLY-XXX] - Fixes bug in 
ApproximateQuantiles`,
  where you replace `MASSEMBLY-XXX` with the appropriate JIRA issue. 
Best practice
  is to use the JIRA issue title in the pull request title and in the 
first line of the 
  commit message.
- [x] Write a pull request description that is detailed enough to 
understand what the pull request does, how, and why.
- [x] Run `mvn clean verify` to make sure basic checks pass. A more 
thorough check will 
  be performed on your pull request automatically.
- [x] You have run the integration tests successfully (`mvn -Prun-its clean 
verify`).
   
   If your pull request is about ~20 lines of code you don't need to sign an
   [Individual Contributor License 
Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure
   please ask on the developers list.
   
   To make clear that you license your contribution under 
   the [Apache License Version 2.0, January 
2004](http://www.apache.org/licenses/LICENSE-2.0)
   you have to acknowledge this by using the following check-box.
   
- [x] I hereby declare this contribution to be licenced under the [Apache 
License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
   
- [x] In any other case, please file an [Apache Individual Contributor 
License Agreement](https://www.apache.org/licenses/icla.pdf).
   
   




> Code cleanups
> -
>
> Key: MASSEMBLY-1013
> URL: https://issues.apache.org/jira/browse/MASSEMBLY-1013
> Project: Maven Assembly Plugin
>  Issue Type: Task
>Reporter: Slawomir Jaranowski
>Assignee: Slawomir Jaranowski
>Priority: Major
> Fix For: 3.7.0
>
>
> Like:
> - diamond operators
> - use NIO new(Input|Output)Stream
> - inline simple variables
> - simplify arguments of {{AssemblyArchiver#createArchive}}
> -  minimize usage of deprecated apis
> - remove unnecessary casting



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Commented] (MASSEMBLY-992) Facility to define assembly descriptor in body of POM

[ASF GitHub Bot (Jira)]

[ 
https://issues.apache.org/jira/browse/MASSEMBLY-992?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17797911#comment-17797911
 ] 

ASF GitHub Bot commented on MASSEMBLY-992:
--

slawekjaranowski opened a new pull request, #174:
URL: https://github.com/apache/maven-assembly-plugin/pull/174

   Following this checklist to help us incorporate your 
   contribution quickly and easily:
   
- [x] Make sure there is a [JIRA 
issue](https://issues.apache.org/jira/browse/MASSEMBLY) filed 
  for the change (usually before you start working on it).  Trivial 
changes like typos do not 
  require a JIRA issue.  Your pull request should address just this 
issue, without 
  pulling in other changes.
- [x] Each commit in the pull request should have a meaningful subject line 
and body.
- [x] Format the pull request title like `[MASSEMBLY-XXX] - Fixes bug in 
ApproximateQuantiles`,
  where you replace `MASSEMBLY-XXX` with the appropriate JIRA issue. 
Best practice
  is to use the JIRA issue title in the pull request title and in the 
first line of the 
  commit message.
- [ ] Write a pull request description that is detailed enough to 
understand what the pull request does, how, and why.
- [x] Run `mvn clean verify` to make sure basic checks pass. A more 
thorough check will 
  be performed on your pull request automatically.
- [x] You have run the integration tests successfully (`mvn -Prun-its clean 
verify`).
   
   If your pull request is about ~20 lines of code you don't need to sign an
   [Individual Contributor License 
Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure
   please ask on the developers list.
   
   To make clear that you license your contribution under 
   the [Apache License Version 2.0, January 
2004](http://www.apache.org/licenses/LICENSE-2.0)
   you have to acknowledge this by using the following check-box.
   
- [x] I hereby declare this contribution to be licenced under the [Apache 
License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
   
- [x] In any other case, please file an [Apache Individual Contributor 
License Agreement](https://www.apache.org/licenses/icla.pdf).
   
   




> Facility to define assembly descriptor in body of POM
> -
>
> Key: MASSEMBLY-992
> URL: https://issues.apache.org/jira/browse/MASSEMBLY-992
> Project: Maven Assembly Plugin
>  Issue Type: New Feature
>Reporter: Garret Wilson
>Assignee: Slawomir Jaranowski
>Priority: Major
> Fix For: next-release
>
>
> The Maven Assembly Plugin allows custom descriptors to be defined, but only 
> in an external file. Please add the capability to define the descriptor in 
> the body of the POM itself.
> Requiring a separate descriptor file makes it almost impossible to declare an 
> assembly in a parent POM so that it can be inherited by child POMs. The 
> documentation describe a way to [share 
> descriptors|https://maven.apache.org/plugins/maven-assembly-plugin/examples/sharing-descriptors.html],
>  but it is complex and doesn't obviously support Maven property interpolation.
> Without this facility, in order to easily inherit an assembly from a parent 
> POM, I'm currently resorting to workaround involving AntRun to generate an 
> assembly descriptor on the fly. See [this 
> {{pom.xml}}|https://github.com/globalmentor/globalmentor-root/blob/main/pom.xml].
>  It's pretty convoluted and tedious to get right. In addition, it has to be 
> placed in a phase that is guaranteed to run before the execution of the Maven 
> Assembly Plugin itself.
> {code:xml}
>   
> org.apache.maven.plugins
> maven-antrun-plugin
> 
>   
> 
> generate-bin-assembly-descriptor
> prepare-package
> 
>   run
> 
> 
>   ${_isSkipGenerateExe}
>   
>  encoding="UTF-8">
>   
> 
>   
> 
>   
> 
>   
> {code}
> This was requested and finally implemented for Versions Maven Plugin; see 
> [#258|https://github.com/mojohaus/versions/issues/258] and 
> [#684|https://github.com/mojohaus/versions/issues/684], along with [_Versions 
> Maven Plugin rules that are 
> inheritable_|https://stackoverflow.com/q/72416739] on Stack Overflow.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[PR] [MASSEMBLY-992] Inline Assembly Descriptors [maven-assembly-plugin]

[via GitHub]

slawekjaranowski opened a new pull request, #174:
URL: https://github.com/apache/maven-assembly-plugin/pull/174

   Following this checklist to help us incorporate your 
   contribution quickly and easily:
   
- [x] Make sure there is a [JIRA 
issue](https://issues.apache.org/jira/browse/MASSEMBLY) filed 
  for the change (usually before you start working on it).  Trivial 
changes like typos do not 
  require a JIRA issue.  Your pull request should address just this 
issue, without 
  pulling in other changes.
- [x] Each commit in the pull request should have a meaningful subject line 
and body.
- [x] Format the pull request title like `[MASSEMBLY-XXX] - Fixes bug in 
ApproximateQuantiles`,
  where you replace `MASSEMBLY-XXX` with the appropriate JIRA issue. 
Best practice
  is to use the JIRA issue title in the pull request title and in the 
first line of the 
  commit message.
- [ ] Write a pull request description that is detailed enough to 
understand what the pull request does, how, and why.
- [x] Run `mvn clean verify` to make sure basic checks pass. A more 
thorough check will 
  be performed on your pull request automatically.
- [x] You have run the integration tests successfully (`mvn -Prun-its clean 
verify`).
   
   If your pull request is about ~20 lines of code you don't need to sign an
   [Individual Contributor License 
Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure
   please ask on the developers list.
   
   To make clear that you license your contribution under 
   the [Apache License Version 2.0, January 
2004](http://www.apache.org/licenses/LICENSE-2.0)
   you have to acknowledge this by using the following check-box.
   
- [x] I hereby declare this contribution to be licenced under the [Apache 
License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
   
- [x] In any other case, please file an [Apache Individual Contributor 
License Agreement](https://www.apache.org/licenses/icla.pdf).
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[jira] [Commented] (SUREFIRE-1345) Report parser doesn't support flaky and retries

[ASF GitHub Bot (Jira)]

[ 
https://issues.apache.org/jira/browse/SUREFIRE-1345?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17797907#comment-17797907
 ] 

ASF GitHub Bot commented on SUREFIRE-1345:
--

michael-o commented on code in PR #700:
URL: https://github.com/apache/maven-surefire/pull/700#discussion_r1429119813


##
surefire-report-parser/src/main/java/org/apache/maven/plugins/surefire/report/TestSuiteXmlParser.java:
##
@@ -217,6 +241,38 @@ public void endElement(String uri, String localName, 
String qName) throws SAXExc
 throw new SAXException("Failed to parse time value", e);
 }
 break;
+case "flakyFailure":
+testCase.addFlakyFailure(testCaseFlakyFailure);
+testCaseFlakyFailure = null;
+break;
+case "flakyError":
+testCase.addFlakyError(testCaseFlakyError);
+testCaseFlakyError = null;
+break;
+case "stackTrace":
+if (testCaseFlakyFailure != null) {
+
testCaseFlakyFailure.setStackTrace(currentElement.toString());
+}
+if (testCaseFlakyError != null) {
+
testCaseFlakyError.setStackTrace(currentElement.toString());
+}
+break;
+case "system-out":
+if (testCaseFlakyFailure != null) {
+
testCaseFlakyFailure.setSystemOut(currentElement.toString());
+}
+if (testCaseFlakyError != null) {
+testCaseFlakyError.setSystemOut(currentElement.toString());
+}
+break;
+case "system-err":
+if (testCaseFlakyFailure != null) {
+
testCaseFlakyFailure.setSystemErr(currentElement.toString());
+}
+if (testCaseFlakyError != null) {
+testCaseFlakyError.setSystemErr(currentElement.toString());
+}

Review Comment:
   I cannot exactly tell, but I see in the schema:
   
https://maven.apache.org/surefire/maven-surefire-plugin/xsd/surefire-test-report.xsd
 multiple system out/err. We must make sure that the exact one is pulled in. 
Yet another issue is similar to 
https://issues.apache.org/jira/browse/SUREFIRE-2212. If those std streams are 
huge we should be able to disable this. See: 
https://github.com/apache/maven-surefire/pull/670. This should be opt-in. 
   
   WDYT? I am willing to merge when all questions and test cases have been 
clarified and verified.





> Report parser doesn't support flaky and retries
> ---
>
> Key: SUREFIRE-1345
> URL: https://issues.apache.org/jira/browse/SUREFIRE-1345
> Project: Maven Surefire
>  Issue Type: Bug
>Reporter: Dmitry Baev
>Priority: Major
>
> TestSuiteXmlParser (from 
> `org.apache.maven.surefire:surefire-report-parser:2.19.1`)
> doesn't support changes described in 
> https://github.com/apache/maven-surefire/blob/master/maven-surefire-plugin/src/site/apt/examples/rerun-failing-tests.apt.vm



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Re: [PR] [SUREFIRE-1345] Support flakyFailure and flakyError in TestSuiteXmlParser [maven-surefire]

[via GitHub]

michael-o commented on code in PR #700:
URL: https://github.com/apache/maven-surefire/pull/700#discussion_r1429119813


##
surefire-report-parser/src/main/java/org/apache/maven/plugins/surefire/report/TestSuiteXmlParser.java:
##
@@ -217,6 +241,38 @@ public void endElement(String uri, String localName, 
String qName) throws SAXExc
 throw new SAXException("Failed to parse time value", e);
 }
 break;
+case "flakyFailure":
+testCase.addFlakyFailure(testCaseFlakyFailure);
+testCaseFlakyFailure = null;
+break;
+case "flakyError":
+testCase.addFlakyError(testCaseFlakyError);
+testCaseFlakyError = null;
+break;
+case "stackTrace":
+if (testCaseFlakyFailure != null) {
+
testCaseFlakyFailure.setStackTrace(currentElement.toString());
+}
+if (testCaseFlakyError != null) {
+
testCaseFlakyError.setStackTrace(currentElement.toString());
+}
+break;
+case "system-out":
+if (testCaseFlakyFailure != null) {
+
testCaseFlakyFailure.setSystemOut(currentElement.toString());
+}
+if (testCaseFlakyError != null) {
+testCaseFlakyError.setSystemOut(currentElement.toString());
+}
+break;
+case "system-err":
+if (testCaseFlakyFailure != null) {
+
testCaseFlakyFailure.setSystemErr(currentElement.toString());
+}
+if (testCaseFlakyError != null) {
+testCaseFlakyError.setSystemErr(currentElement.toString());
+}

Review Comment:
   I cannot exactly tell, but I see in the schema:
   
https://maven.apache.org/surefire/maven-surefire-plugin/xsd/surefire-test-report.xsd
 multiple system out/err. We must make sure that the exact one is pulled in. 
Yet another issue is similar to 
https://issues.apache.org/jira/browse/SUREFIRE-2212. If those std streams are 
huge we should be able to disable this. See: 
https://github.com/apache/maven-surefire/pull/670. This should be opt-in. 
   
   WDYT? I am willing to merge when all questions and test cases have been 
clarified and verified.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[jira] [Commented] (SUREFIRE-1345) Report parser doesn't support flaky and retries

[ASF GitHub Bot (Jira)]

[ 
https://issues.apache.org/jira/browse/SUREFIRE-1345?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17797904#comment-17797904
 ] 

ASF GitHub Bot commented on SUREFIRE-1345:
--

gsmet commented on code in PR #700:
URL: https://github.com/apache/maven-surefire/pull/700#discussion_r1429103230


##
surefire-report-parser/src/main/java/org/apache/maven/plugins/surefire/report/TestSuiteXmlParser.java:
##
@@ -217,6 +241,38 @@ public void endElement(String uri, String localName, 
String qName) throws SAXExc
 throw new SAXException("Failed to parse time value", e);
 }
 break;
+case "flakyFailure":
+testCase.addFlakyFailure(testCaseFlakyFailure);
+testCaseFlakyFailure = null;
+break;
+case "flakyError":
+testCase.addFlakyError(testCaseFlakyError);
+testCaseFlakyError = null;
+break;
+case "stackTrace":
+if (testCaseFlakyFailure != null) {
+
testCaseFlakyFailure.setStackTrace(currentElement.toString());
+}
+if (testCaseFlakyError != null) {
+
testCaseFlakyError.setStackTrace(currentElement.toString());
+}
+break;
+case "system-out":
+if (testCaseFlakyFailure != null) {
+
testCaseFlakyFailure.setSystemOut(currentElement.toString());
+}
+if (testCaseFlakyError != null) {
+testCaseFlakyError.setSystemOut(currentElement.toString());
+}
+break;
+case "system-err":
+if (testCaseFlakyFailure != null) {
+
testCaseFlakyFailure.setSystemErr(currentElement.toString());
+}
+if (testCaseFlakyError != null) {
+testCaseFlakyError.setSystemErr(currentElement.toString());
+}

Review Comment:
   Will it? There will be a conflict but I think it's just a matter of adding 
it to test case if it can't be added to the two others.
   
   Does it make sense or do you foresee something more complex.
   
   In any case, no problem to rebase this one or help finishing the other one. 
I really need this in so I'll do my best to help.
   
   Thanks!
   





> Report parser doesn't support flaky and retries
> ---
>
> Key: SUREFIRE-1345
> URL: https://issues.apache.org/jira/browse/SUREFIRE-1345
> Project: Maven Surefire
>  Issue Type: Bug
>Reporter: Dmitry Baev
>Priority: Major
>
> TestSuiteXmlParser (from 
> `org.apache.maven.surefire:surefire-report-parser:2.19.1`)
> doesn't support changes described in 
> https://github.com/apache/maven-surefire/blob/master/maven-surefire-plugin/src/site/apt/examples/rerun-failing-tests.apt.vm



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Re: [PR] [SUREFIRE-1345] Support flakyFailure and flakyError in TestSuiteXmlParser [maven-surefire]

[via GitHub]

gsmet commented on code in PR #700:
URL: https://github.com/apache/maven-surefire/pull/700#discussion_r1429103230


##
surefire-report-parser/src/main/java/org/apache/maven/plugins/surefire/report/TestSuiteXmlParser.java:
##
@@ -217,6 +241,38 @@ public void endElement(String uri, String localName, 
String qName) throws SAXExc
 throw new SAXException("Failed to parse time value", e);
 }
 break;
+case "flakyFailure":
+testCase.addFlakyFailure(testCaseFlakyFailure);
+testCaseFlakyFailure = null;
+break;
+case "flakyError":
+testCase.addFlakyError(testCaseFlakyError);
+testCaseFlakyError = null;
+break;
+case "stackTrace":
+if (testCaseFlakyFailure != null) {
+
testCaseFlakyFailure.setStackTrace(currentElement.toString());
+}
+if (testCaseFlakyError != null) {
+
testCaseFlakyError.setStackTrace(currentElement.toString());
+}
+break;
+case "system-out":
+if (testCaseFlakyFailure != null) {
+
testCaseFlakyFailure.setSystemOut(currentElement.toString());
+}
+if (testCaseFlakyError != null) {
+testCaseFlakyError.setSystemOut(currentElement.toString());
+}
+break;
+case "system-err":
+if (testCaseFlakyFailure != null) {
+
testCaseFlakyFailure.setSystemErr(currentElement.toString());
+}
+if (testCaseFlakyError != null) {
+testCaseFlakyError.setSystemErr(currentElement.toString());
+}

Review Comment:
   Will it? There will be a conflict but I think it's just a matter of adding 
it to test case if it can't be added to the two others.
   
   Does it make sense or do you foresee something more complex.
   
   In any case, no problem to rebase this one or help finishing the other one. 
I really need this in so I'll do my best to help.
   
   Thanks!
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org