[jira] [Updated] (DOXIASITETOOLS-330) Option to ignore parent site.xml or override XML elements like breadcrumbs and links
[
https://issues.apache.org/jira/browse/DOXIASITETOOLS-330?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Alexander Kriegisch updated DOXIASITETOOLS-330:
---
Summary: Option to ignore parent site.xml or override XML elements like
breadcrumbs and links (was: Option to override parent breadcrumbs and links)
> Option to ignore parent site.xml or override XML elements like breadcrumbs
> and links
>
>
> Key: DOXIASITETOOLS-330
> URL: https://issues.apache.org/jira/browse/DOXIASITETOOLS-330
> Project: Maven Doxia Sitetools
> Issue Type: Improvement
> Components: Site model
>Affects Versions: 2.0.0-M16
>Reporter: Alexander Kriegisch
>Priority: Major
>
> I have a use case in which I want to use a parent POM, because its defined
> dependencies and plugins are exactly what I need. However, the parent POM has
> a {{site.xml}} attached which I would like to completely replace, not
> inherit. As that does not seem to be possible, at least I need to override
> some existing entries of the site structure. While some like {{bannerLeft}}
> can just be redefined, there is no way to remove them completely. Especially
> annoying in my use case is the fact that I cannot override parent breadcrumbs.
> As you can see
> [here|https://github.com/apache/maven-doxia-sitetools/blob/5fe4a4c5359e6a23b78f385e15f77767cadaee99/doxia-site-model/src/main/java/org/apache/maven/doxia/site/inheritance/DefaultSiteModelInheritanceAssembler.java#L163-L164]
> and
> [here|https://github.com/apache/maven-doxia-sitetools/blob/5fe4a4c5359e6a23b78f385e15f77767cadaee99/doxia-site-model/src/main/java/org/apache/maven/doxia/site/inheritance/DefaultSiteModelInheritanceAssembler.java#L239-L268],
> method {{DefaultSiteModelInheritanceAssembler::mergeLinkItemLists}} only
> permits limited interactions with parent breadcrumbs, i.e. I can copy the
> first one (which I want to get rid of, too) and cut off after that. But this
> is not what I need.
> What I need at least, is to be able to use something like {{ combine.self="override">}}, similar to Maven plugin configurations. Better
> still would be an option to use that in all tags on all levels or an option
> exposable to Maven Site to generally ignore a parent {{site.xml}}.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Created] (DOXIASITETOOLS-330) Option to override parent breadcrumbs and links
Alexander Kriegisch created DOXIASITETOOLS-330:
--
Summary: Option to override parent breadcrumbs and links
Key: DOXIASITETOOLS-330
URL: https://issues.apache.org/jira/browse/DOXIASITETOOLS-330
Project: Maven Doxia Sitetools
Issue Type: Improvement
Components: Site model
Affects Versions: 2.0.0-M16
Reporter: Alexander Kriegisch
I have a use case in which I want to use a parent POM, because its defined
dependencies and plugins are exactly what I need. However, the parent POM has a
{{site.xml}} attached which I would like to completely replace, not inherit. As
that does not seem to be possible, at least I need to override some existing
entries of the site structure. While some like {{bannerLeft}} can just be
redefined, there is no way to remove them completely. Especially annoying in my
use case is the fact that I cannot override parent breadcrumbs.
As you can see
[here|https://github.com/apache/maven-doxia-sitetools/blob/5fe4a4c5359e6a23b78f385e15f77767cadaee99/doxia-site-model/src/main/java/org/apache/maven/doxia/site/inheritance/DefaultSiteModelInheritanceAssembler.java#L163-L164]
and
[here|https://github.com/apache/maven-doxia-sitetools/blob/5fe4a4c5359e6a23b78f385e15f77767cadaee99/doxia-site-model/src/main/java/org/apache/maven/doxia/site/inheritance/DefaultSiteModelInheritanceAssembler.java#L239-L268],
method {{DefaultSiteModelInheritanceAssembler::mergeLinkItemLists}} only
permits limited interactions with parent breadcrumbs, i.e. I can copy the first
one (which I want to get rid of, too) and cut off after that. But this is not
what I need.
What I need at least, is to be able to use something like {{}}, similar to Maven plugin configurations. Better
still would be an option to use that in all tags on all levels or an option
exposable to Maven Site to generally ignore a parent {{site.xml}}.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Assigned] (MNG-8039) DefaultProjectBuilder should not change given artifact
[
https://issues.apache.org/jira/browse/MNG-8039?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Slawomir Jaranowski reassigned MNG-8039:
Assignee: Slawomir Jaranowski
> DefaultProjectBuilder should not change given artifact
> --
>
> Key: MNG-8039
> URL: https://issues.apache.org/jira/browse/MNG-8039
> Project: Maven
> Issue Type: Bug
>Affects Versions: 4.0.0-alpha-12
>Reporter: Slawomir Jaranowski
>Assignee: Slawomir Jaranowski
>Priority: Major
>
> In {{org.apache.maven.project.DefaultProjectBuilder}} we have a code:
> {code:java}
> File pomFile = pomArtifact.getFile();
> if ("pom".equals(artifact.getType())) {
> artifact.selectVersion(pomArtifact.getVersion());
> artifact.setFile(pomFile);
> artifact.setResolved(true);
> }
> {code}
> Which cause a error for immutable {{TransformedArtifact}}
> Error occurs when plugin try build project for current project attachments,
> like in assembly-m-p
> {noformat}
> Caused by: java.lang.UnsupportedOperationException: transformed artifact file
> cannot be set
> at
> org.apache.maven.internal.transformation.impl.TransformedArtifact.setFile(TransformedArtifact.java:88)
> at
> org.apache.maven.project.DefaultProjectBuilder$BuildSession.build(DefaultProjectBuilder.java:375)
> at
> org.apache.maven.project.DefaultProjectBuilder.build(DefaultProjectBuilder.java:155)
> at
> org.apache.maven.project.DefaultProjectBuilder.build(DefaultProjectBuilder.java:148)
> at
> org.apache.maven.plugins.assembly.archive.task.AddDependencySetsTask.addDependencySet(AddDependencySetsTask.java:150)
> {noformat}
> In assembly-m-p IT
> {{src/it/projects/dependency-sets/include-project-attachments}} fails.
>
> Introduced in MNG-4791
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MNG-8039) DefaultProjectBuilder should not change given artifact
[
https://issues.apache.org/jira/browse/MNG-8039?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17816243#comment-17816243
]
ASF GitHub Bot commented on MNG-8039:
-
slawekjaranowski opened a new pull request, #1408:
URL: https://github.com/apache/maven/pull/1408
https://issues.apache.org/jira/browse/MNG-8039
> DefaultProjectBuilder should not change given artifact
> --
>
> Key: MNG-8039
> URL: https://issues.apache.org/jira/browse/MNG-8039
> Project: Maven
> Issue Type: Bug
>Affects Versions: 4.0.0-alpha-12
>Reporter: Slawomir Jaranowski
>Priority: Major
>
> In {{org.apache.maven.project.DefaultProjectBuilder}} we have a code:
> {code:java}
> File pomFile = pomArtifact.getFile();
> if ("pom".equals(artifact.getType())) {
> artifact.selectVersion(pomArtifact.getVersion());
> artifact.setFile(pomFile);
> artifact.setResolved(true);
> }
> {code}
> Which cause a error for immutable {{TransformedArtifact}}
> Error occurs when plugin try build project for current project attachments,
> like in assembly-m-p
> {noformat}
> Caused by: java.lang.UnsupportedOperationException: transformed artifact file
> cannot be set
> at
> org.apache.maven.internal.transformation.impl.TransformedArtifact.setFile(TransformedArtifact.java:88)
> at
> org.apache.maven.project.DefaultProjectBuilder$BuildSession.build(DefaultProjectBuilder.java:375)
> at
> org.apache.maven.project.DefaultProjectBuilder.build(DefaultProjectBuilder.java:155)
> at
> org.apache.maven.project.DefaultProjectBuilder.build(DefaultProjectBuilder.java:148)
> at
> org.apache.maven.plugins.assembly.archive.task.AddDependencySetsTask.addDependencySet(AddDependencySetsTask.java:150)
> {noformat}
> In assembly-m-p IT
> {{src/it/projects/dependency-sets/include-project-attachments}} fails.
>
> Introduced in MNG-4791
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[PR] [MNG-8039] Don't change resolved artifact by DefaultProjectBuilder [maven]
slawekjaranowski opened a new pull request, #1408: URL: https://github.com/apache/maven/pull/1408 https://issues.apache.org/jira/browse/MNG-8039 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] DI and API fixes [maven]
gnodet merged PR #1407: URL: https://github.com/apache/maven/pull/1407 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MNG-7092) Core mechanism for skipping mojos
[
https://issues.apache.org/jira/browse/MNG-7092?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17816140#comment-17816140
]
Peter Palaga commented on MNG-7092:
---
bq. The "omit" is the one you want, if I understant correctly
Right.
bq. the "skip" would actually populate the local repository, think uses cases
like "go offline" (assuming plugin does not resolve anything dynamically).
Thanks for the explanation. It sounds like a useful scenario.
> Core mechanism for skipping mojos
> -
>
> Key: MNG-7092
> URL: https://issues.apache.org/jira/browse/MNG-7092
> Project: Maven
> Issue Type: New Feature
>Reporter: Peter Palaga
>Priority: Major
>
> The current practice is that mojo authors have to implement skipping on their
> side. It is easy to do, but it has a couple of disadvantages:
> * Not every mojo has a skip option
> * The naming conventions differ among mojos
> * Performance: the dependencies of the mojo need to be resolved, downloaded,
> classes loaded and initialized, config injected only to eval the skip option
> and do nothing. I have collected some numbers in
> https://peter.palaga.org/2020/10/29/skipping-maven-mojos-properly.html .
> I wonder if Maven core could provide a mechanism for skipping mojos without
> the above drawbacks?
> There could be some global naming convention, so that
> {{-Dorg.my-org.my-maven-plugin.my-mojo.skip}} or just `-Dmy.my-mojo.skip`
> would skip `my-mojo`.
> WDYT?
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Comment Edited] (MNG-7092) Core mechanism for skipping mojos
[
https://issues.apache.org/jira/browse/MNG-7092?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17816137#comment-17816137
]
Tamas Cservenak edited comment on MNG-7092 at 2/9/24 4:32 PM:
--
The "omit" is the one you want, if I understant correctly, the "skip" would
actually populate the local repository, think uses cases like "go offline"
(assuming plugin does not resolve anything dynamically).
was (Author: cstamas):
The "omit" is the one you want, if I understant correctly, the "skip" would
actually populate the local repository, this uses cases like "go offline"
(assuming plugin does not resolve anything dynamically).
> Core mechanism for skipping mojos
> -
>
> Key: MNG-7092
> URL: https://issues.apache.org/jira/browse/MNG-7092
> Project: Maven
> Issue Type: New Feature
>Reporter: Peter Palaga
>Priority: Major
>
> The current practice is that mojo authors have to implement skipping on their
> side. It is easy to do, but it has a couple of disadvantages:
> * Not every mojo has a skip option
> * The naming conventions differ among mojos
> * Performance: the dependencies of the mojo need to be resolved, downloaded,
> classes loaded and initialized, config injected only to eval the skip option
> and do nothing. I have collected some numbers in
> https://peter.palaga.org/2020/10/29/skipping-maven-mojos-properly.html .
> I wonder if Maven core could provide a mechanism for skipping mojos without
> the above drawbacks?
> There could be some global naming convention, so that
> {{-Dorg.my-org.my-maven-plugin.my-mojo.skip}} or just `-Dmy.my-mojo.skip`
> would skip `my-mojo`.
> WDYT?
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MNG-7092) Core mechanism for skipping mojos
[
https://issues.apache.org/jira/browse/MNG-7092?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17816137#comment-17816137
]
Tamas Cservenak commented on MNG-7092:
--
The "omit" is the one you want, if I understant correctly, the "skip" would
actually populate the local repository, this uses cases like "go offline"
(assuming plugin does not resolve anything dynamically).
> Core mechanism for skipping mojos
> -
>
> Key: MNG-7092
> URL: https://issues.apache.org/jira/browse/MNG-7092
> Project: Maven
> Issue Type: New Feature
>Reporter: Peter Palaga
>Priority: Major
>
> The current practice is that mojo authors have to implement skipping on their
> side. It is easy to do, but it has a couple of disadvantages:
> * Not every mojo has a skip option
> * The naming conventions differ among mojos
> * Performance: the dependencies of the mojo need to be resolved, downloaded,
> classes loaded and initialized, config injected only to eval the skip option
> and do nothing. I have collected some numbers in
> https://peter.palaga.org/2020/10/29/skipping-maven-mojos-properly.html .
> I wonder if Maven core could provide a mechanism for skipping mojos without
> the above drawbacks?
> There could be some global naming convention, so that
> {{-Dorg.my-org.my-maven-plugin.my-mojo.skip}} or just `-Dmy.my-mojo.skip`
> would skip `my-mojo`.
> WDYT?
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MNG-7092) Core mechanism for skipping mojos
[
https://issues.apache.org/jira/browse/MNG-7092?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17816136#comment-17816136
]
Peter Palaga commented on MNG-7092:
---
What would be the benefit of having both options (plus the third one equivalent
to the second for most mojos)?
> Core mechanism for skipping mojos
> -
>
> Key: MNG-7092
> URL: https://issues.apache.org/jira/browse/MNG-7092
> Project: Maven
> Issue Type: New Feature
>Reporter: Peter Palaga
>Priority: Major
>
> The current practice is that mojo authors have to implement skipping on their
> side. It is easy to do, but it has a couple of disadvantages:
> * Not every mojo has a skip option
> * The naming conventions differ among mojos
> * Performance: the dependencies of the mojo need to be resolved, downloaded,
> classes loaded and initialized, config injected only to eval the skip option
> and do nothing. I have collected some numbers in
> https://peter.palaga.org/2020/10/29/skipping-maven-mojos-properly.html .
> I wonder if Maven core could provide a mechanism for skipping mojos without
> the above drawbacks?
> There could be some global naming convention, so that
> {{-Dorg.my-org.my-maven-plugin.my-mojo.skip}} or just `-Dmy.my-mojo.skip`
> would skip `my-mojo`.
> WDYT?
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MNG-7092) Core mechanism for skipping mojos
[
https://issues.apache.org/jira/browse/MNG-7092?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17816134#comment-17816134
]
Tamas Cservenak commented on MNG-7092:
--
I would even go step further and differentiate two operations (if not 3):
* omit (like is not there, completely omit it from lifecycle)
* skip (do resolve and all, but do not invoke execute of Mojo) – this would be
"logical equivalent" of existing skip implementations
> Core mechanism for skipping mojos
> -
>
> Key: MNG-7092
> URL: https://issues.apache.org/jira/browse/MNG-7092
> Project: Maven
> Issue Type: New Feature
>Reporter: Peter Palaga
>Priority: Major
>
> The current practice is that mojo authors have to implement skipping on their
> side. It is easy to do, but it has a couple of disadvantages:
> * Not every mojo has a skip option
> * The naming conventions differ among mojos
> * Performance: the dependencies of the mojo need to be resolved, downloaded,
> classes loaded and initialized, config injected only to eval the skip option
> and do nothing. I have collected some numbers in
> https://peter.palaga.org/2020/10/29/skipping-maven-mojos-properly.html .
> I wonder if Maven core could provide a mechanism for skipping mojos without
> the above drawbacks?
> There could be some global naming convention, so that
> {{-Dorg.my-org.my-maven-plugin.my-mojo.skip}} or just `-Dmy.my-mojo.skip`
> would skip `my-mojo`.
> WDYT?
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Created] (MNG-8049) Provide a generic way to "target" some step in build
Tamas Cservenak created MNG-8049: Summary: Provide a generic way to "target" some step in build Key: MNG-8049 URL: https://issues.apache.org/jira/browse/MNG-8049 Project: Maven Issue Type: Improvement Components: Plugins and Lifecycle Reporter: Tamas Cservenak Would be nice if we could somehow "target" some bits of build, for example: * given plugin * given mojo of a plugin * given lifecycle maybe? As then MNG-7092, MNG-7691 and MNG-8048 could apply different modifications (i.e. debug log, skip etc) -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (MNG-8048) Provide a way for "targeted debug"
Tamas Cservenak created MNG-8048: Summary: Provide a way for "targeted debug" Key: MNG-8048 URL: https://issues.apache.org/jira/browse/MNG-8048 Project: Maven Issue Type: Improvement Components: Plugins and Lifecycle Reporter: Tamas Cservenak Current -X makes everything (core and plugins) emit DEBUG messages. Would be good if one could "target" which plugins should debug only... -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Assigned] (SCM-914) InfoItem.lastChangedDate is leaky abstraction
[ https://issues.apache.org/jira/browse/SCM-914?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Konrad Windszus reassigned SCM-914: --- Assignee: Konrad Windszus > InfoItem.lastChangedDate is leaky abstraction > - > > Key: SCM-914 > URL: https://issues.apache.org/jira/browse/SCM-914 > Project: Maven SCM > Issue Type: Bug > Components: maven-scm-api >Reporter: Tobias Gruetzmacher >Assignee: Konrad Windszus >Priority: Minor > > I was looking into implementing > [https://github.com/mojohaus/buildnumber-maven-plugin/pull/16] in a sane way, > but had to conclude that InfoItem.lastChangedDate is unfortunately just a > string and not a Data, so will leak the console output of different providers > to the user. > Does anybody see a sane way to fix this API and create a sane abstraction for > different SCMs? If yes, I would try to go ahead with the following tasks: > # Fix InfoItem, so that lastChangedDate is a Date > # Fix the current providers filling this field (svnexe and svnjava AFAICS - > aside: why is svnjava not part of the maven-scm repository?) > # Implement this feature for at least gitexe (and maybe jgit) so I can use > it for my usecase > Ideas, comments? -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (SCM-914) InfoItem.lastChangedDate is leaky abstraction
[ https://issues.apache.org/jira/browse/SCM-914?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17816130#comment-17816130 ] ASF GitHub Bot commented on SCM-914: kwin opened a new pull request, #193: URL: https://github.com/apache/maven-scm/pull/193 Populate it with SVN and JGit for now > InfoItem.lastChangedDate is leaky abstraction > - > > Key: SCM-914 > URL: https://issues.apache.org/jira/browse/SCM-914 > Project: Maven SCM > Issue Type: Bug > Components: maven-scm-api >Reporter: Tobias Gruetzmacher >Assignee: Konrad Windszus >Priority: Minor > > I was looking into implementing > [https://github.com/mojohaus/buildnumber-maven-plugin/pull/16] in a sane way, > but had to conclude that InfoItem.lastChangedDate is unfortunately just a > string and not a Data, so will leak the console output of different providers > to the user. > Does anybody see a sane way to fix this API and create a sane abstraction for > different SCMs? If yes, I would try to go ahead with the following tasks: > # Fix InfoItem, so that lastChangedDate is a Date > # Fix the current providers filling this field (svnexe and svnjava AFAICS - > aside: why is svnjava not part of the maven-scm repository?) > # Implement this feature for at least gitexe (and maybe jgit) so I can use > it for my usecase > Ideas, comments? -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MDEP-713) dependency:tree should not log info the user doesn't ask for
[ https://issues.apache.org/jira/browse/MDEP-713?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17816128#comment-17816128 ] Tamas Cservenak commented on MDEP-713: -- Well, I did, as a reaction of one of your earlier rants, create a PR that left unnoticed by anyone: [https://github.com/apache/maven/pull/1238] But I'd say this is a bit like "OS customization"... as you most probably are changing desktop wallpaper as well, or you insist on using the OS default one (and expect that wallpaper for your taste will be set by whoever produced OS you use) > dependency:tree should not log info the user doesn't ask for > > > Key: MDEP-713 > URL: https://issues.apache.org/jira/browse/MDEP-713 > Project: Maven Dependency Plugin > Issue Type: Improvement > Components: tree >Reporter: Elliotte Rusty Harold >Priority: Major > Fix For: waiting-for-feedback > > > I'm going to start this report here, though I kind of expect it slips into > core and a lot of other components. Suppose I run mvn dependency:tree on > Guava. As a user here's what I want to see (though probably minus the [INFO] > prefix): > [INFO] com.google.guava:guava-gwt:jar:HEAD-jre-SNAPSHOT > [INFO] +- com.google.guava:failureaccess:jar:1.0.1:compile > [INFO] +- com.google.guava:guava:jar:HEAD-jre-SNAPSHOT:compile > [INFO] | +- > com.google.guava:listenablefuture:jar:.0-empty-to-avoid-conflict-with-guava:compile > [INFO] | +- com.google.code.findbugs:jsr305:jar:3.0.2:compile > [INFO] | +- com.google.errorprone:error_prone_annotations:jar:2.3.4:compile > [INFO] | \- com.google.j2objc:j2objc-annotations:jar:1.3:compile > [INFO] +- com.google.elemental2:elemental2-promise:jar:1.0.0-RC1:compile > [INFO] | +- com.google.jsinterop:jsinterop-annotations:jar:1.0.2:compile > [INFO] | \- com.google.jsinterop:base:jar:1.0.0-RC1:compile > [INFO] +- com.google.guava:guava-testlib:jar:HEAD-jre-SNAPSHOT:test > [INFO] | \- junit:junit:jar:4.13:test > [INFO] | \- org.hamcrest:hamcrest-core:jar:1.3:test > [INFO] +- com.google.guava:guava-testlib:jar:tests:HEAD-jre-SNAPSHOT:test > [INFO] +- com.google.guava:guava-tests:jar:tests:HEAD-jre-SNAPSHOT:test > [INFO] +- com.google.gwt:gwt-dev:jar:2.8.2:provided > [INFO] | +- com.google.code.gson:gson:jar:2.6.2:provided > [INFO] | +- org.ow2.asm:asm:jar:5.0.3:provided > [INFO] | +- org.ow2.asm:asm-util:jar:5.0.3:provided > [INFO] | | \- org.ow2.asm:asm-tree:jar:5.0.3:provided > [INFO] | +- org.ow2.asm:asm-commons:jar:5.0.3:provided > [INFO] | +- colt:colt:jar:1.2.0:provided > [INFO] | +- ant:ant:jar:1.6.5:provided > [INFO] | +- commons-collections:commons-collections:jar:3.2.2:provided > [INFO] | +- commons-io:commons-io:jar:2.4:provided > [INFO] | +- com.ibm.icu:icu4j:jar:50.1.1:provided > [INFO] | +- tapestry:tapestry:jar:4.0.2:provided > [INFO] | +- net.sourceforge.htmlunit:htmlunit:jar:2.19:provided > [INFO] | | +- xalan:xalan:jar:2.7.2:provided > [INFO] | | | \- xalan:serializer:jar:2.7.2:provided > [INFO] | | +- org.apache.commons:commons-lang3:jar:3.4:provided > [INFO] | | +- org.apache.httpcomponents:httpclient:jar:4.5.1:provided > [INFO] | | | \- org.apache.httpcomponents:httpcore:jar:4.4.3:provided > [INFO] | | +- org.apache.httpcomponents:httpmime:jar:4.5.1:provided > [INFO] | | +- commons-codec:commons-codec:jar:1.10:provided > [INFO] | | +- net.sourceforge.htmlunit:htmlunit-core-js:jar:2.17:provided > [INFO] | | +- xerces:xercesImpl:jar:2.11.0:provided > [INFO] | | | \- xml-apis:xml-apis:jar:1.4.01:provided > [INFO] | | +- net.sourceforge.nekohtml:nekohtml:jar:1.9.22:provided > [INFO] | | +- net.sourceforge.cssparser:cssparser:jar:0.9.18:provided > [INFO] | | +- commons-logging:commons-logging:jar:1.2:provided > [INFO] | | \- > org.eclipse.jetty.websocket:websocket-client:jar:9.2.13.v20150730:provided > [INFO] | | \- > org.eclipse.jetty.websocket:websocket-common:jar:9.2.13.v20150730:provided > [INFO] | |\- > org.eclipse.jetty.websocket:websocket-api:jar:9.2.13.v20150730:provided > [INFO] | +- org.eclipse.jetty:jetty-webapp:jar:9.2.14.v20151106:provided > [INFO] | | +- org.eclipse.jetty:jetty-xml:jar:9.2.14.v20151106:provided > [INFO] | | \- org.eclipse.jetty:jetty-servlet:jar:9.2.14.v20151106:provided > [INFO] | | \- > org.eclipse.jetty:jetty-security:jar:9.2.14.v20151106:provided > [INFO] | +- org.eclipse.jetty:jetty-servlets:jar:9.2.14.v20151106:provided > [INFO] | | +- > org.eclipse.jetty:jetty-continuation:jar:9.2.14.v20151106:provided > [INFO] | | +- org.eclipse.jetty:jetty-http:jar:9.2.14.v20151106:provided > [INFO] | | +- org.eclipse.jetty:jetty-util:jar:9.2.14.v20151106:provided > [INFO] | | \- org.eclipse.jetty:jetty-io:jar:9.2.14.v20151106:provided > [INFO] | +-
[jira] [Commented] (MWRAPPER-91) Concurrent execution of mvnw to download wrapper fails
[
https://issues.apache.org/jira/browse/MWRAPPER-91?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17816123#comment-17816123
]
Benjamin Marwell commented on MWRAPPER-91:
--
[~ahus1] do you, by chance, know which scripts are affected? We have multiple
wrappers, the "most modern" option at the moment being only-mvnw,
See the "without binary" section here:
https://maven.apache.org/wrapper/index.html
> Concurrent execution of mvnw to download wrapper fails
> --
>
> Key: MWRAPPER-91
> URL: https://issues.apache.org/jira/browse/MWRAPPER-91
> Project: Maven Wrapper
> Issue Type: Bug
> Components: Maven Wrapper Scripts
>Affects Versions: 3.1.0
>Reporter: Alexander Schwartz
>Assignee: Benjamin Marwell
>Priority: Major
>
> The script will download the executable maven wrapper JAR file directly to
> the final file name.
> When multiple calls do this concurrently, it happens that the first call
> executes the JAR file that is currently overwritten by the second parallel
> call.
> This leads to error like:
> * {{NoClassDefFoundError: org/codehaus/plexus/PlexusContainer}}
> * {{ClassNotFoundException: org.apache.maven.wrapper.MavenWrapperMain}}
> A different solution might be to first download the JAR file to a temporary
> file, and then use an atomic file operator like a rename one the download is
> complete.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[PR] Bump commons-codec:commons-codec from 1.16.0 to 1.16.1 [maven-enforcer]
dependabot[bot] opened a new pull request, #305: URL: https://github.com/apache/maven-enforcer/pull/305 Bumps [commons-codec:commons-codec](https://github.com/apache/commons-codec) from 1.16.0 to 1.16.1. Changelog Sourced from https://github.com/apache/commons-codec/blob/master/RELEASE-NOTES.txt;>commons-codec:commons-codec's changelog. Apache Commons Codec 1.16.1 RELEASE NOTES The Apache Commons Codec component contains encoder and decoders for various formats such as Base16, Base32, Base64, digest, and Hexadecimal. In addition to these widely used encoders and decoders, the codec package also maintains a collection of phonetic encoding utilities. Feature and fix release. Requires a minimum of Java 8. Changes in this version include: New features: o Add Maven property project.build.outputTimestamp for build reproducibility. Thanks to Gary Gregory. Fixed Bugs: o CODEC-295: Test clean ups. Thanks to Gary Gregory. o [StepSecurity] ci: Harden GitHub Actions https://redirect.github.com/apache/commons-codec/issues/187;>#187. Thanks to step-security-bot, Gary Gregory. o CODEC-295: Correct error in Base64 Javadoc https://redirect.github.com/apache/commons-codec/issues/188;>#188. Thanks to Evan Saulpaugh. o CODEC-295: Add minimum Java version in changes.xml https://redirect.github.com/apache/commons-codec/issues/186;>#186. Thanks to Olivier Jaquemet, Gary Gregory. o CODEC-310: Documentation update for the org.apache.commons.codec.digest.* package https://redirect.github.com/apache/commons-codec/issues/208;>#208. Thanks to Yakov Shafranovich. o Precompile regular expression in UnixCrypt.crypt(byte[], String). Thanks to Gary Gregory. o CODEC-315: Fix possible IndexOutOfBoundException in PhoneticEngine.encode method https://redirect.github.com/apache/commons-codec/issues/223;>#223. Thanks to Arthur Chan, Gary Gregory. o CODEC-313: Fix possible ArrayIndexOutOfBoundsException in QuotedPrintableCodec.encodeQuotedPrintable() method https://redirect.github.com/apache/commons-codec/issues/221;>#221. Thanks to Arthur Chan, Gary Gregory. o CODEC-312: Fix possible StringIndexOutOfBoundException in MatchRatingApproachEncoder.encode() method https://redirect.github.com/apache/commons-codec/issues/220;>#220. Thanks to Arthur Chan, Gary Gregory. o CODEC-311: Fix possible ArrayIndexOutOfBoundException in RefinedSoundex.getMappingCode() https://redirect.github.com/apache/commons-codec/issues/219;>#219. Thanks to Arthur Chan, Gary Gregory. o CODEC-314: Fix possible IndexOutOfBoundsException in PercentCodec.insertAlwaysEncodeChars() method https://redirect.github.com/apache/commons-codec/issues/222;>#222. Thanks to Arthur Chan, Gary Gregory. o Deprecate UnixCrypt 0-argument constructor. Thanks to Gary Gregory. o Deprecate Md5Crypt 0-argument constructor. Thanks to Gary Gregory. o Deprecate Crypt 0-argument constructor. Thanks to Gary Gregory. o Deprecate StringUtils 0-argument constructor. Thanks to Gary Gregory. o Deprecate Resources 0-argument constructor. Thanks to Gary Gregory. o Deprecate Charsets 0-argument constructor. Thanks to Gary Gregory. o Deprecate CharEncoding 0-argument constructor. Thanks to Gary Gregory. o Add missing version for animal-sniffer-maven-plugin. Thanks to Gary Gregory. Changes: o Bump commons-parent from 58 to 66. Thanks to Dependabot, Gary Gregory. o Bump commons-lang3 from 3.12.0 to 3.14.0. Thanks to Gary Gregory. o Bump commons-io from 2.13.0 to 2.15.1. Thanks to Gary Gregory. For complete information on Apache Commons Codec, including instructions on how to submit bug reports, patches, or suggestions for improvement, see the Apache Commons Codec website: https://commons.apache.org/proper/commons-codec/;>https://commons.apache.org/proper/commons-codec/ Download page: https://commons.apache.org/proper/commons-codec/download_codec.cgi;>https://commons.apache.org/proper/commons-codec/download_codec.cgi ... (truncated) Commits https://github.com/apache/commons-codec/commit/e59fc76531141cb4a36f3031457b9d5f07e5e43f;>e59fc76 Prepare release candidate https://github.com/apache/commons-codec/commit/90c8023be911b42bab20b31b0e325174df0ee452;>90c8023 Prepare for the next release candidate https://github.com/apache/commons-codec/commit/05714adcf957e7a7644a71cd82de30145288ff38;>05714ad Prepare release candidate https://github.com/apache/commons-codec/commit/060be1a1ca4b229ab348618ecae506a65543356f;>060be1a Add missing version for animal-sniffer-maven-plugin https://github.com/apache/commons-codec/commit/0fd7b59fb1dbd67260429e1d75789fca92ab8a6f;>0fd7b59 Remove variable assignment just before returning it
[jira] [Commented] (MWRAPPER-86) Trim trailing slash in Repo URL
[
https://issues.apache.org/jira/browse/MWRAPPER-86?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17816119#comment-17816119
]
ASF GitHub Bot commented on MWRAPPER-86:
bmarwell opened a new pull request, #119:
URL: https://github.com/apache/maven-wrapper/pull/119
* first commit tries to fixes the problem, except I actually used `- 2`
instead of `- 1`
* Refactored the methods a bit to make them easier to test
* Added a few tests for the most common cases
* Opened a field and method for testing to `protected`
* Don't use too short repo URLs where not even the protocol could fit.
---
Following this checklist to help us incorporate your
contribution quickly and easily:
- [X] Make sure there is a [JIRA
issue](https://issues.apache.org/jira/browse/MWRAPPER) filed
for the change (usually before you start working on it). Trivial
changes like typos do not
require a JIRA issue. Your pull request should address just this
issue, without
pulling in other changes.
- [X] Each commit in the pull request should have a meaningful subject line
and body.
- [X] Format the pull request title like `[MWRAPPER-XXX] - Fixes bug in
ApproximateQuantiles`,
where you replace `MWRAPPER-XXX` with the appropriate JIRA issue.
Best practice
is to use the JIRA issue title in the pull request title and in the
first line of the
commit message.
- [X] Write a pull request description that is detailed enough to
understand what the pull request does, how, and why.
- [X] Run `mvn clean verify` to make sure basic checks pass. A more
thorough check will
be performed on your pull request automatically.
- [X] You have run the integration tests successfully (`mvn -Prun-its clean
verify`).
If your pull request is about ~20 lines of code you don't need to sign an
[Individual Contributor License
Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure
please ask on the developers list.
To make clear that you license your contribution under
the [Apache License Version 2.0, January
2004](http://www.apache.org/licenses/LICENSE-2.0)
you have to acknowledge this by using the following check-box.
- [X] I hereby declare this contribution to be licenced under the [Apache
License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
- [X] In any other case, please file an [Apache Individual Contributor
License Agreement](https://www.apache.org/licenses/icla.pdf).
> Trim trailing slash in Repo URL
> ---
>
> Key: MWRAPPER-86
> URL: https://issues.apache.org/jira/browse/MWRAPPER-86
> Project: Maven Wrapper
> Issue Type: Bug
> Components: Maven Wrapper Plugin
>Affects Versions: 3.1.1
>Reporter: Björn Michael
>Assignee: Benjamin Marwell
>Priority: Major
>
> If repository URL ends with a trailing slash then the URLs in
> {{maven-wrapper.properties}} contain double slashes.
> E.g. {{MVNW_REPOURL=[https://myrepo.local/]}} ends up with
> {code:java}
> distributionUrl=https://myrepo.local//org/apache/maven/apache-maven/3.8.7/apache-maven-3.8.7-bin.zip
> wrapperUrl=https://myrepo.local//org/apache/maven/wrapper/maven-wrapper/3.1.1/maven-wrapper-3.1.1.jar{code}
> This also occurs when mirror * URL ends with trailing slash.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[PR] [MWRAPPER-86] Trim repourl and other checks; tests [maven-wrapper]
bmarwell opened a new pull request, #119: URL: https://github.com/apache/maven-wrapper/pull/119 * first commit tries to fixes the problem, except I actually used `- 2` instead of `- 1` * Refactored the methods a bit to make them easier to test * Added a few tests for the most common cases * Opened a field and method for testing to `protected` * Don't use too short repo URLs where not even the protocol could fit. --- Following this checklist to help us incorporate your contribution quickly and easily: - [X] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/MWRAPPER) filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes. - [X] Each commit in the pull request should have a meaningful subject line and body. - [X] Format the pull request title like `[MWRAPPER-XXX] - Fixes bug in ApproximateQuantiles`, where you replace `MWRAPPER-XXX` with the appropriate JIRA issue. Best practice is to use the JIRA issue title in the pull request title and in the first line of the commit message. - [X] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [X] Run `mvn clean verify` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically. - [X] You have run the integration tests successfully (`mvn -Prun-its clean verify`). If your pull request is about ~20 lines of code you don't need to sign an [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure please ask on the developers list. To make clear that you license your contribution under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) you have to acknowledge this by using the following check-box. - [X] I hereby declare this contribution to be licenced under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) - [X] In any other case, please file an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Assigned] (MWRAPPER-108) mvnw script fails silently when download fails
[ https://issues.apache.org/jira/browse/MWRAPPER-108?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Benjamin Marwell reassigned MWRAPPER-108: - Assignee: Benjamin Marwell > mvnw script fails silently when download fails > -- > > Key: MWRAPPER-108 > URL: https://issues.apache.org/jira/browse/MWRAPPER-108 > Project: Maven Wrapper > Issue Type: Bug > Components: Maven Wrapper Scripts >Affects Versions: 3.2.0 >Reporter: selckin >Assignee: Benjamin Marwell >Priority: Major > > The wrapper only-mvnw script fail silently when the download fails, giving a > cryptic error when trying to run mvn > https://github.com/apache/maven-wrapper/pull/98 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Assigned] (MWRAPPER-86) Trim trailing slash in Repo URL
[
https://issues.apache.org/jira/browse/MWRAPPER-86?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Benjamin Marwell reassigned MWRAPPER-86:
Assignee: Benjamin Marwell
> Trim trailing slash in Repo URL
> ---
>
> Key: MWRAPPER-86
> URL: https://issues.apache.org/jira/browse/MWRAPPER-86
> Project: Maven Wrapper
> Issue Type: Bug
> Components: Maven Wrapper Plugin
>Affects Versions: 3.1.1
>Reporter: Björn Michael
>Assignee: Benjamin Marwell
>Priority: Major
>
> If repository URL ends with a trailing slash then the URLs in
> {{maven-wrapper.properties}} contain double slashes.
> E.g. {{MVNW_REPOURL=[https://myrepo.local/]}} ends up with
> {code:java}
> distributionUrl=https://myrepo.local//org/apache/maven/apache-maven/3.8.7/apache-maven-3.8.7-bin.zip
> wrapperUrl=https://myrepo.local//org/apache/maven/wrapper/maven-wrapper/3.1.1/maven-wrapper-3.1.1.jar{code}
> This also occurs when mirror * URL ends with trailing slash.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Assigned] (MWRAPPER-91) Concurrent execution of mvnw to download wrapper fails
[
https://issues.apache.org/jira/browse/MWRAPPER-91?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Benjamin Marwell reassigned MWRAPPER-91:
Assignee: Benjamin Marwell
> Concurrent execution of mvnw to download wrapper fails
> --
>
> Key: MWRAPPER-91
> URL: https://issues.apache.org/jira/browse/MWRAPPER-91
> Project: Maven Wrapper
> Issue Type: Bug
> Components: Maven Wrapper Scripts
>Affects Versions: 3.1.0
>Reporter: Alexander Schwartz
>Assignee: Benjamin Marwell
>Priority: Major
>
> The script will download the executable maven wrapper JAR file directly to
> the final file name.
> When multiple calls do this concurrently, it happens that the first call
> executes the JAR file that is currently overwritten by the second parallel
> call.
> This leads to error like:
> * {{NoClassDefFoundError: org/codehaus/plexus/PlexusContainer}}
> * {{ClassNotFoundException: org.apache.maven.wrapper.MavenWrapperMain}}
> A different solution might be to first download the JAR file to a temporary
> file, and then use an atomic file operator like a rename one the download is
> complete.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Resolved] (MWRAPPER-113) Error and warning output goes to standard output and intermingles with Maven output
[
https://issues.apache.org/jira/browse/MWRAPPER-113?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Benjamin Marwell resolved MWRAPPER-113.
---
Resolution: Fixed
> Error and warning output goes to standard output and intermingles with Maven
> output
> ---
>
> Key: MWRAPPER-113
> URL: https://issues.apache.org/jira/browse/MWRAPPER-113
> Project: Maven Wrapper
> Issue Type: Bug
> Components: Maven Wrapper Scripts
>Affects Versions: 3.2.0, 3.3.0
>Reporter: Ingo Karkat
>Assignee: Benjamin Marwell
>Priority: Trivial
> Labels: pull-request-available
> Fix For: 3.3.0
>
>
> Errors and warnings from the wrapper should go to standard error, so that
> those are also shown to the user when the regular Maven output is suppressed,
> redirected into a file, or captured by a script.
> For the latter use case, separation is especially critical because otherwise
> error output is mistakenly interpreted as desired Maven output (for example,
> when obtaining the list of Maven project names in the reactor with {{mvnw
> --quiet -Dexec.executable=echo
> '-Dexec.args=${project.groupId}:${project.artifactId}'
> org.codehaus.mojo:exec-maven-plugin:exec}}).
> The current wrapper scripts do this only inconsistently, and so warnings like
> {{Warning: JAVA_HOME environment variable is not set.}} are printed to stdout
> instead of stderr.
> Pull request: https://github.com/apache/maven-wrapper/pull/106
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MWRAPPER-113) Error and warning output goes to standard output and intermingles with Maven output
[
https://issues.apache.org/jira/browse/MWRAPPER-113?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17816104#comment-17816104
]
ASF GitHub Bot commented on MWRAPPER-113:
-
bmarwell merged PR #106:
URL: https://github.com/apache/maven-wrapper/pull/106
> Error and warning output goes to standard output and intermingles with Maven
> output
> ---
>
> Key: MWRAPPER-113
> URL: https://issues.apache.org/jira/browse/MWRAPPER-113
> Project: Maven Wrapper
> Issue Type: Bug
> Components: Maven Wrapper Scripts
>Affects Versions: 3.2.0, 3.3.0
>Reporter: Ingo Karkat
>Priority: Trivial
> Labels: pull-request-available
> Fix For: 3.3.0
>
>
> Errors and warnings from the wrapper should go to standard error, so that
> those are also shown to the user when the regular Maven output is suppressed,
> redirected into a file, or captured by a script.
> For the latter use case, separation is especially critical because otherwise
> error output is mistakenly interpreted as desired Maven output (for example,
> when obtaining the list of Maven project names in the reactor with {{mvnw
> --quiet -Dexec.executable=echo
> '-Dexec.args=${project.groupId}:${project.artifactId}'
> org.codehaus.mojo:exec-maven-plugin:exec}}).
> The current wrapper scripts do this only inconsistently, and so warnings like
> {{Warning: JAVA_HOME environment variable is not set.}} are printed to stdout
> instead of stderr.
> Pull request: https://github.com/apache/maven-wrapper/pull/106
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Assigned] (MWRAPPER-113) Error and warning output goes to standard output and intermingles with Maven output
[
https://issues.apache.org/jira/browse/MWRAPPER-113?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Benjamin Marwell reassigned MWRAPPER-113:
-
Assignee: Benjamin Marwell
> Error and warning output goes to standard output and intermingles with Maven
> output
> ---
>
> Key: MWRAPPER-113
> URL: https://issues.apache.org/jira/browse/MWRAPPER-113
> Project: Maven Wrapper
> Issue Type: Bug
> Components: Maven Wrapper Scripts
>Affects Versions: 3.2.0, 3.3.0
>Reporter: Ingo Karkat
>Assignee: Benjamin Marwell
>Priority: Trivial
> Labels: pull-request-available
> Fix For: 3.3.0
>
>
> Errors and warnings from the wrapper should go to standard error, so that
> those are also shown to the user when the regular Maven output is suppressed,
> redirected into a file, or captured by a script.
> For the latter use case, separation is especially critical because otherwise
> error output is mistakenly interpreted as desired Maven output (for example,
> when obtaining the list of Maven project names in the reactor with {{mvnw
> --quiet -Dexec.executable=echo
> '-Dexec.args=${project.groupId}:${project.artifactId}'
> org.codehaus.mojo:exec-maven-plugin:exec}}).
> The current wrapper scripts do this only inconsistently, and so warnings like
> {{Warning: JAVA_HOME environment variable is not set.}} are printed to stdout
> instead of stderr.
> Pull request: https://github.com/apache/maven-wrapper/pull/106
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Updated] (MWRAPPER-113) Error and warning output goes to standard output and intermingles with Maven output
[
https://issues.apache.org/jira/browse/MWRAPPER-113?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Benjamin Marwell updated MWRAPPER-113:
--
Fix Version/s: 3.3.0
> Error and warning output goes to standard output and intermingles with Maven
> output
> ---
>
> Key: MWRAPPER-113
> URL: https://issues.apache.org/jira/browse/MWRAPPER-113
> Project: Maven Wrapper
> Issue Type: Bug
> Components: Maven Wrapper Scripts
>Affects Versions: 3.2.0, 3.3.0
>Reporter: Ingo Karkat
>Priority: Trivial
> Labels: pull-request-available
> Fix For: 3.3.0
>
>
> Errors and warnings from the wrapper should go to standard error, so that
> those are also shown to the user when the regular Maven output is suppressed,
> redirected into a file, or captured by a script.
> For the latter use case, separation is especially critical because otherwise
> error output is mistakenly interpreted as desired Maven output (for example,
> when obtaining the list of Maven project names in the reactor with {{mvnw
> --quiet -Dexec.executable=echo
> '-Dexec.args=${project.groupId}:${project.artifactId}'
> org.codehaus.mojo:exec-maven-plugin:exec}}).
> The current wrapper scripts do this only inconsistently, and so warnings like
> {{Warning: JAVA_HOME environment variable is not set.}} are printed to stdout
> instead of stderr.
> Pull request: https://github.com/apache/maven-wrapper/pull/106
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
Re: [PR] [MWRAPPER-113] Some mvnw error and warning output goes to standard output [maven-wrapper]
bmarwell merged PR #106: URL: https://github.com/apache/maven-wrapper/pull/106 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MDEP-713) dependency:tree should not log info the user doesn't ask for
[ https://issues.apache.org/jira/browse/MDEP-713?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17816096#comment-17816096 ] Elliotte Rusty Harold commented on MDEP-713: Turn this around. Instead of thinking about what the code does, start from the user experience. Then design the code to produce that. This is hardly only a problem in this plugin with this goal. I see it all over the Maven ecosystem. More generically, perhaps what maven needs is a silent build option that is turned on by default. I run a compile and I see javac errors, and nothing else. I run mvn test and I see test failures, and nothing else. Genuinely blocking errors might be shown. I can't test if I can't compile the tests, for instance. But everything else should be invisible by default. Only the actual user supplied goal should be allowed to print anything to the console at a level below fatal error. > dependency:tree should not log info the user doesn't ask for > > > Key: MDEP-713 > URL: https://issues.apache.org/jira/browse/MDEP-713 > Project: Maven Dependency Plugin > Issue Type: Improvement > Components: tree >Reporter: Elliotte Rusty Harold >Priority: Major > Fix For: waiting-for-feedback > > > I'm going to start this report here, though I kind of expect it slips into > core and a lot of other components. Suppose I run mvn dependency:tree on > Guava. As a user here's what I want to see (though probably minus the [INFO] > prefix): > [INFO] com.google.guava:guava-gwt:jar:HEAD-jre-SNAPSHOT > [INFO] +- com.google.guava:failureaccess:jar:1.0.1:compile > [INFO] +- com.google.guava:guava:jar:HEAD-jre-SNAPSHOT:compile > [INFO] | +- > com.google.guava:listenablefuture:jar:.0-empty-to-avoid-conflict-with-guava:compile > [INFO] | +- com.google.code.findbugs:jsr305:jar:3.0.2:compile > [INFO] | +- com.google.errorprone:error_prone_annotations:jar:2.3.4:compile > [INFO] | \- com.google.j2objc:j2objc-annotations:jar:1.3:compile > [INFO] +- com.google.elemental2:elemental2-promise:jar:1.0.0-RC1:compile > [INFO] | +- com.google.jsinterop:jsinterop-annotations:jar:1.0.2:compile > [INFO] | \- com.google.jsinterop:base:jar:1.0.0-RC1:compile > [INFO] +- com.google.guava:guava-testlib:jar:HEAD-jre-SNAPSHOT:test > [INFO] | \- junit:junit:jar:4.13:test > [INFO] | \- org.hamcrest:hamcrest-core:jar:1.3:test > [INFO] +- com.google.guava:guava-testlib:jar:tests:HEAD-jre-SNAPSHOT:test > [INFO] +- com.google.guava:guava-tests:jar:tests:HEAD-jre-SNAPSHOT:test > [INFO] +- com.google.gwt:gwt-dev:jar:2.8.2:provided > [INFO] | +- com.google.code.gson:gson:jar:2.6.2:provided > [INFO] | +- org.ow2.asm:asm:jar:5.0.3:provided > [INFO] | +- org.ow2.asm:asm-util:jar:5.0.3:provided > [INFO] | | \- org.ow2.asm:asm-tree:jar:5.0.3:provided > [INFO] | +- org.ow2.asm:asm-commons:jar:5.0.3:provided > [INFO] | +- colt:colt:jar:1.2.0:provided > [INFO] | +- ant:ant:jar:1.6.5:provided > [INFO] | +- commons-collections:commons-collections:jar:3.2.2:provided > [INFO] | +- commons-io:commons-io:jar:2.4:provided > [INFO] | +- com.ibm.icu:icu4j:jar:50.1.1:provided > [INFO] | +- tapestry:tapestry:jar:4.0.2:provided > [INFO] | +- net.sourceforge.htmlunit:htmlunit:jar:2.19:provided > [INFO] | | +- xalan:xalan:jar:2.7.2:provided > [INFO] | | | \- xalan:serializer:jar:2.7.2:provided > [INFO] | | +- org.apache.commons:commons-lang3:jar:3.4:provided > [INFO] | | +- org.apache.httpcomponents:httpclient:jar:4.5.1:provided > [INFO] | | | \- org.apache.httpcomponents:httpcore:jar:4.4.3:provided > [INFO] | | +- org.apache.httpcomponents:httpmime:jar:4.5.1:provided > [INFO] | | +- commons-codec:commons-codec:jar:1.10:provided > [INFO] | | +- net.sourceforge.htmlunit:htmlunit-core-js:jar:2.17:provided > [INFO] | | +- xerces:xercesImpl:jar:2.11.0:provided > [INFO] | | | \- xml-apis:xml-apis:jar:1.4.01:provided > [INFO] | | +- net.sourceforge.nekohtml:nekohtml:jar:1.9.22:provided > [INFO] | | +- net.sourceforge.cssparser:cssparser:jar:0.9.18:provided > [INFO] | | +- commons-logging:commons-logging:jar:1.2:provided > [INFO] | | \- > org.eclipse.jetty.websocket:websocket-client:jar:9.2.13.v20150730:provided > [INFO] | | \- > org.eclipse.jetty.websocket:websocket-common:jar:9.2.13.v20150730:provided > [INFO] | |\- > org.eclipse.jetty.websocket:websocket-api:jar:9.2.13.v20150730:provided > [INFO] | +- org.eclipse.jetty:jetty-webapp:jar:9.2.14.v20151106:provided > [INFO] | | +- org.eclipse.jetty:jetty-xml:jar:9.2.14.v20151106:provided > [INFO] | | \- org.eclipse.jetty:jetty-servlet:jar:9.2.14.v20151106:provided > [INFO] | | \- > org.eclipse.jetty:jetty-security:jar:9.2.14.v20151106:provided > [INFO] | +- org.eclipse.jetty:jetty-servlets:jar:9.2.14.v20151106:provided >
[jira] [Comment Edited] (SCM-914) InfoItem.lastChangedDate is leaky abstraction
[
https://issues.apache.org/jira/browse/SCM-914?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17816073#comment-17816073
]
Konrad Windszus edited comment on SCM-914 at 2/9/24 2:43 PM:
-
This would be interesting in the context of DOXIASITETOOLS-329 as well. I think
we should change the API in this case in a backwards compatible way (i.e.
introduce a new getter method returning a {{java.time.OffsetDateTime}} and
deprecate the old method returning a String). For example JGit exposes the date
as int on
https://git.eclipse.org/c/jgit/jgit.git/tree/org.eclipse.jgit/src/org/eclipse/jgit/revwalk/RevCommit.java#n321
(not sure what it stands for).
[Git log|https://git-scm.com/docs/git-log] can be used like this {{git log -1
--format=%ct}} to retrieve the unix epoch. The timezone can be adjusted in
which to emit via
https://git-scm.com/docs/git-log#Documentation/git-log.txt---dateltformatgt.
was (Author: kwin):
This would be interesting in the context of DOXIASITETOOLS-329 as well. I think
we should change the API in this case in a backwards compatible way (i.e.
introduce a new getter method returning a {{java.time.LocalDateTime}} and
deprecate the old method returning a String). For example JGit exposes the date
as int on
https://git.eclipse.org/c/jgit/jgit.git/tree/org.eclipse.jgit/src/org/eclipse/jgit/revwalk/RevCommit.java#n321
(not sure what it stands for).
[Git log|https://git-scm.com/docs/git-log] can be used like this {{git log -1
--format=%ct}} to retrieve the unix epoch. The timezone can be adjusted in
which to emit via
https://git-scm.com/docs/git-log#Documentation/git-log.txt---dateltformatgt.
> InfoItem.lastChangedDate is leaky abstraction
> -
>
> Key: SCM-914
> URL: https://issues.apache.org/jira/browse/SCM-914
> Project: Maven SCM
> Issue Type: Bug
> Components: maven-scm-api
>Reporter: Tobias Gruetzmacher
>Priority: Minor
>
> I was looking into implementing
> [https://github.com/mojohaus/buildnumber-maven-plugin/pull/16] in a sane way,
> but had to conclude that InfoItem.lastChangedDate is unfortunately just a
> string and not a Data, so will leak the console output of different providers
> to the user.
> Does anybody see a sane way to fix this API and create a sane abstraction for
> different SCMs? If yes, I would try to go ahead with the following tasks:
> # Fix InfoItem, so that lastChangedDate is a Date
> # Fix the current providers filling this field (svnexe and svnjava AFAICS -
> aside: why is svnjava not part of the maven-scm repository?)
> # Implement this feature for at least gitexe (and maybe jgit) so I can use
> it for my usecase
> Ideas, comments?
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Comment Edited] (SCM-914) InfoItem.lastChangedDate is leaky abstraction
[
https://issues.apache.org/jira/browse/SCM-914?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17816073#comment-17816073
]
Konrad Windszus edited comment on SCM-914 at 2/9/24 2:10 PM:
-
This would be interesting in the context of DOXIASITETOOLS-329 as well. I think
we should change the API in this case in a backwards compatible way (i.e.
introduce a new getter method returning a {{java.time.LocalDateTime}} and
deprecate the old method returning a String). For example JGit exposes the date
as int on
https://git.eclipse.org/c/jgit/jgit.git/tree/org.eclipse.jgit/src/org/eclipse/jgit/revwalk/RevCommit.java#n321
(not sure what it stands for).
[Git log|https://git-scm.com/docs/git-log] can be used like this {{git log -1
--format=%ct}} to retrieve the unix epoch. The timezone can be adjusted in
which to emit via
https://git-scm.com/docs/git-log#Documentation/git-log.txt---dateltformatgt.
was (Author: kwin):
This would be interesting in the context of DOXIASITETOOLS-329 as well. I think
we should change the API in this case in a backwards compatible way (i.e.
introduce a new getter method returning a {{java.time.LocalDateTime}} and
deprecate the old method returning a String). For example JGit exposes the date
as int on
https://git.eclipse.org/c/jgit/jgit.git/tree/org.eclipse.jgit/src/org/eclipse/jgit/revwalk/RevCommit.java#n321
(not sure what it stands for).
> InfoItem.lastChangedDate is leaky abstraction
> -
>
> Key: SCM-914
> URL: https://issues.apache.org/jira/browse/SCM-914
> Project: Maven SCM
> Issue Type: Bug
> Components: maven-scm-api
>Reporter: Tobias Gruetzmacher
>Priority: Minor
>
> I was looking into implementing
> [https://github.com/mojohaus/buildnumber-maven-plugin/pull/16] in a sane way,
> but had to conclude that InfoItem.lastChangedDate is unfortunately just a
> string and not a Data, so will leak the console output of different providers
> to the user.
> Does anybody see a sane way to fix this API and create a sane abstraction for
> different SCMs? If yes, I would try to go ahead with the following tasks:
> # Fix InfoItem, so that lastChangedDate is a Date
> # Fix the current providers filling this field (svnexe and svnjava AFAICS -
> aside: why is svnjava not part of the maven-scm repository?)
> # Implement this feature for at least gitexe (and maybe jgit) so I can use
> it for my usecase
> Ideas, comments?
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (SCM-914) InfoItem.lastChangedDate is leaky abstraction
[
https://issues.apache.org/jira/browse/SCM-914?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17816073#comment-17816073
]
Konrad Windszus commented on SCM-914:
-
This would be interesting in the context of DOXIASITETOOLS-329 as well. I think
we should change the API in this case in a backwards compatible way (i.e.
introduce a new getter method returning a {{java.time.LocalDateTime}} and
deprecate the old method returning a String). For example JGit exposes the date
as int on
https://git.eclipse.org/c/jgit/jgit.git/tree/org.eclipse.jgit/src/org/eclipse/jgit/revwalk/RevCommit.java#n321
(not sure what it stands for).
> InfoItem.lastChangedDate is leaky abstraction
> -
>
> Key: SCM-914
> URL: https://issues.apache.org/jira/browse/SCM-914
> Project: Maven SCM
> Issue Type: Bug
> Components: maven-scm-api
>Reporter: Tobias Gruetzmacher
>Priority: Minor
>
> I was looking into implementing
> [https://github.com/mojohaus/buildnumber-maven-plugin/pull/16] in a sane way,
> but had to conclude that InfoItem.lastChangedDate is unfortunately just a
> string and not a Data, so will leak the console output of different providers
> to the user.
> Does anybody see a sane way to fix this API and create a sane abstraction for
> different SCMs? If yes, I would try to go ahead with the following tasks:
> # Fix InfoItem, so that lastChangedDate is a Date
> # Fix the current providers filling this field (svnexe and svnjava AFAICS -
> aside: why is svnjava not part of the maven-scm repository?)
> # Implement this feature for at least gitexe (and maybe jgit) so I can use
> it for my usecase
> Ideas, comments?
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Comment Edited] (DOXIASITETOOLS-329) Expose lastModification date in addition to publishDate in Velocity Context
[
https://issues.apache.org/jira/browse/DOXIASITETOOLS-329?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17814869#comment-17814869
]
Konrad Windszus edited comment on DOXIASITETOOLS-329 at 2/9/24 1:51 PM:
Maybe one needs a more sophisticated approach here, which relies on SCM
modification date. The filesystem one does not necessarily reflect a deliberate
content change either (compare with
https://softwareengineering.stackexchange.com/questions/350403/why-doesnt-git-set-the-file-time).
Update: Unfortunately the information is not exposed via via Maven SCM
providers (except for the SVN one). Although potentially this information is
exposed via {{ScmProvider.info(...)}}
(https://github.com/apache/maven-scm/blob/f5d8bb4fa69b0338377fd96a6cd3ec2499ad688c/maven-scm-api/src/main/java/org/apache/maven/scm/provider/ScmProvider.java#L943)
only the SVN provider ever calls the relevant
https://github.com/apache/maven-scm/blob/f5d8bb4fa69b0338377fd96a6cd3ec2499ad688c/maven-scm-api/src/main/java/org/apache/maven/scm/command/info/InfoItem.java#L124.
Compare with SCM-914.
was (Author: kwin):
Maybe one needs a more sophisticated approach here, which relies on SCM
modification date. The filesystem one does not necessarily reflect a deliberate
content change either (compare with
https://softwareengineering.stackexchange.com/questions/350403/why-doesnt-git-set-the-file-time).
Update: Unfortunately the information is not exposed via via Maven SCM
providers (except for the SVN one). Although potentially this information is
exposed via {{ScmProvider.info(...)}}
(https://github.com/apache/maven-scm/blob/f5d8bb4fa69b0338377fd96a6cd3ec2499ad688c/maven-scm-api/src/main/java/org/apache/maven/scm/provider/ScmProvider.java#L943)
only the SVN provider ever calls the relevant
https://github.com/apache/maven-scm/blob/f5d8bb4fa69b0338377fd96a6cd3ec2499ad688c/maven-scm-api/src/main/java/org/apache/maven/scm/command/info/InfoItem.java#L124.
> Expose lastModification date in addition to publishDate in Velocity Context
> ---
>
> Key: DOXIASITETOOLS-329
> URL: https://issues.apache.org/jira/browse/DOXIASITETOOLS-329
> Project: Maven Doxia Sitetools
> Issue Type: Improvement
> Components: Site renderer
>Reporter: Konrad Windszus
>Assignee: Konrad Windszus
>Priority: Major
>
> Currently only the published date (the same for the whole site) is available
> in the Velocity context
> (https://github.com/apache/maven-doxia-sitetools/blob/5fe4a4c5359e6a23b78f385e15f77767cadaee99/doxia-site-renderer/src/main/java/org/apache/maven/doxia/siterenderer/DefaultSiteRenderer.java#L495).
> It would be useful to also populate the lastModification date of the doxia
> source file (if available).
> That way one could expose a more useful date for end-users (as the publish
> date rarely is equal to the date when a page was last touched). Obviously for
> Sinks/Documents not based on Doxia source files this is not available.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Comment Edited] (DOXIASITETOOLS-329) Expose lastModification date in addition to publishDate in Velocity Context
[ https://issues.apache.org/jira/browse/DOXIASITETOOLS-329?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17814869#comment-17814869 ] Konrad Windszus edited comment on DOXIASITETOOLS-329 at 2/9/24 1:48 PM: Maybe one needs a more sophisticated approach here, which relies on SCM modification date. The filesystem one does not necessarily reflect a deliberate content change either (compare with https://softwareengineering.stackexchange.com/questions/350403/why-doesnt-git-set-the-file-time). Update: Unfortunately the information is not exposed via via Maven SCM providers (except for the SVN one). Although potentially this information is exposed via `ScmProvider.info(...)` (https://github.com/apache/maven-scm/blob/f5d8bb4fa69b0338377fd96a6cd3ec2499ad688c/maven-scm-api/src/main/java/org/apache/maven/scm/provider/ScmProvider.java#L943) only the SVN provider ever calls the relevant https://github.com/apache/maven-scm/blob/f5d8bb4fa69b0338377fd96a6cd3ec2499ad688c/maven-scm-api/src/main/java/org/apache/maven/scm/command/info/InfoItem.java#L124. was (Author: kwin): Maybe one needs a more sophisticated approach here, which relies on SCM modification date. The filesystem one does not necessarily reflect a deliberate content change either (compare with https://softwareengineering.stackexchange.com/questions/350403/why-doesnt-git-set-the-file-time). > Expose lastModification date in addition to publishDate in Velocity Context > --- > > Key: DOXIASITETOOLS-329 > URL: https://issues.apache.org/jira/browse/DOXIASITETOOLS-329 > Project: Maven Doxia Sitetools > Issue Type: Improvement > Components: Site renderer >Reporter: Konrad Windszus >Assignee: Konrad Windszus >Priority: Major > > Currently only the published date (the same for the whole site) is available > in the Velocity context > (https://github.com/apache/maven-doxia-sitetools/blob/5fe4a4c5359e6a23b78f385e15f77767cadaee99/doxia-site-renderer/src/main/java/org/apache/maven/doxia/siterenderer/DefaultSiteRenderer.java#L495). > It would be useful to also populate the lastModification date of the doxia > source file (if available). > That way one could expose a more useful date for end-users (as the publish > date rarely is equal to the date when a page was last touched). Obviously for > Sinks/Documents not based on Doxia source files this is not available. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Comment Edited] (DOXIASITETOOLS-329) Expose lastModification date in addition to publishDate in Velocity Context
[
https://issues.apache.org/jira/browse/DOXIASITETOOLS-329?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17814869#comment-17814869
]
Konrad Windszus edited comment on DOXIASITETOOLS-329 at 2/9/24 1:48 PM:
Maybe one needs a more sophisticated approach here, which relies on SCM
modification date. The filesystem one does not necessarily reflect a deliberate
content change either (compare with
https://softwareengineering.stackexchange.com/questions/350403/why-doesnt-git-set-the-file-time).
Update: Unfortunately the information is not exposed via via Maven SCM
providers (except for the SVN one). Although potentially this information is
exposed via {{ScmProvider.info(...)}}
(https://github.com/apache/maven-scm/blob/f5d8bb4fa69b0338377fd96a6cd3ec2499ad688c/maven-scm-api/src/main/java/org/apache/maven/scm/provider/ScmProvider.java#L943)
only the SVN provider ever calls the relevant
https://github.com/apache/maven-scm/blob/f5d8bb4fa69b0338377fd96a6cd3ec2499ad688c/maven-scm-api/src/main/java/org/apache/maven/scm/command/info/InfoItem.java#L124.
was (Author: kwin):
Maybe one needs a more sophisticated approach here, which relies on SCM
modification date. The filesystem one does not necessarily reflect a deliberate
content change either (compare with
https://softwareengineering.stackexchange.com/questions/350403/why-doesnt-git-set-the-file-time).
Update: Unfortunately the information is not exposed via via Maven SCM
providers (except for the SVN one). Although potentially this information is
exposed via `ScmProvider.info(...)`
(https://github.com/apache/maven-scm/blob/f5d8bb4fa69b0338377fd96a6cd3ec2499ad688c/maven-scm-api/src/main/java/org/apache/maven/scm/provider/ScmProvider.java#L943)
only the SVN provider ever calls the relevant
https://github.com/apache/maven-scm/blob/f5d8bb4fa69b0338377fd96a6cd3ec2499ad688c/maven-scm-api/src/main/java/org/apache/maven/scm/command/info/InfoItem.java#L124.
> Expose lastModification date in addition to publishDate in Velocity Context
> ---
>
> Key: DOXIASITETOOLS-329
> URL: https://issues.apache.org/jira/browse/DOXIASITETOOLS-329
> Project: Maven Doxia Sitetools
> Issue Type: Improvement
> Components: Site renderer
>Reporter: Konrad Windszus
>Assignee: Konrad Windszus
>Priority: Major
>
> Currently only the published date (the same for the whole site) is available
> in the Velocity context
> (https://github.com/apache/maven-doxia-sitetools/blob/5fe4a4c5359e6a23b78f385e15f77767cadaee99/doxia-site-renderer/src/main/java/org/apache/maven/doxia/siterenderer/DefaultSiteRenderer.java#L495).
> It would be useful to also populate the lastModification date of the doxia
> source file (if available).
> That way one could expose a more useful date for end-users (as the publish
> date rarely is equal to the date when a page was last touched). Obviously for
> Sinks/Documents not based on Doxia source files this is not available.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Resolved] (MSCMPUB-63) Rely on DefaultScmRepositoryConfigurator from maven-release for extracting credentials from settings.xml
[
https://issues.apache.org/jira/browse/MSCMPUB-63?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Konrad Windszus resolved MSCMPUB-63.
Fix Version/s: 3.2.2
Resolution: Fixed
Fixed in
https://github.com/apache/maven-scm-publish-plugin/commit/f431e9ea4bc2f2506690cc1f10fc51a59483.
> Rely on DefaultScmRepositoryConfigurator from maven-release for extracting
> credentials from settings.xml
>
>
> Key: MSCMPUB-63
> URL: https://issues.apache.org/jira/browse/MSCMPUB-63
> Project: Maven SCM Publish Plugin
> Issue Type: Improvement
>Reporter: Konrad Windszus
>Assignee: Konrad Windszus
>Priority: Major
> Fix For: 3.2.2
>
>
> Currently the logic to extract (encrypted) server credentials from Maven
> settings is duplicated in
> https://github.com/apache/maven-scm-publish-plugin/blob/823fdfba3f5034bca2f337b8754a1e923d16a8a9/src/main/java/org/apache/maven/plugins/scmpublish/AbstractScmPublishMojo.java#L331-L351
> (would happen in
> https://github.com/apache/maven-release/blob/0f5e7a14ac7df9861ee7fc08a6ed8ac9fb18321b/maven-release-manager/src/main/java/org/apache/maven/shared/release/scm/DefaultScmRepositoryConfigurator.java#L80
> implicitly). Therefore the according code should be removed from the
> {{maven-scm-publish-plugin}} and just the server id passed to the
> {{ScmRepositoryConfigurator}}. That would potentially also consider private
> keys.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MSCMPUB-63) Rely on DefaultScmRepositoryConfigurator from maven-release for extracting credentials from settings.xml
[
https://issues.apache.org/jira/browse/MSCMPUB-63?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17816069#comment-17816069
]
ASF GitHub Bot commented on MSCMPUB-63:
---
kwin merged PR #29:
URL: https://github.com/apache/maven-scm-publish-plugin/pull/29
> Rely on DefaultScmRepositoryConfigurator from maven-release for extracting
> credentials from settings.xml
>
>
> Key: MSCMPUB-63
> URL: https://issues.apache.org/jira/browse/MSCMPUB-63
> Project: Maven SCM Publish Plugin
> Issue Type: Improvement
>Reporter: Konrad Windszus
>Assignee: Konrad Windszus
>Priority: Major
>
> Currently the logic to extract (encrypted) server credentials from Maven
> settings is duplicated in
> https://github.com/apache/maven-scm-publish-plugin/blob/823fdfba3f5034bca2f337b8754a1e923d16a8a9/src/main/java/org/apache/maven/plugins/scmpublish/AbstractScmPublishMojo.java#L331-L351
> (would happen in
> https://github.com/apache/maven-release/blob/0f5e7a14ac7df9861ee7fc08a6ed8ac9fb18321b/maven-release-manager/src/main/java/org/apache/maven/shared/release/scm/DefaultScmRepositoryConfigurator.java#L80
> implicitly). Therefore the according code should be removed from the
> {{maven-scm-publish-plugin}} and just the server id passed to the
> {{ScmRepositoryConfigurator}}. That would potentially also consider private
> keys.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
Re: [PR] [MSCMPUB-63] Rely on DefaultScmRepositoryConfigurator for extracting credentials from [maven-scm-publish-plugin]
kwin merged PR #29: URL: https://github.com/apache/maven-scm-publish-plugin/pull/29 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] (doc) Fix examples for custom configuration [maven-dependency-plugin]
steffanschlein closed pull request #363: (doc) Fix examples for custom configuration URL: https://github.com/apache/maven-dependency-plugin/pull/363 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] (doc) Fix examples for custom configuration [maven-dependency-plugin]
elharo commented on PR #363: URL: https://github.com/apache/maven-dependency-plugin/pull/363#issuecomment-1935874917 And yet you clicked the checkbox for Jira issue. If there is no Jira issue, please uncheck it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MDEP-713) dependency:tree should not log info the user doesn't ask for
[ https://issues.apache.org/jira/browse/MDEP-713?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17816044#comment-17816044 ] Tamas Cservenak commented on MDEP-713: -- So you invoke dep tree on top of a reactor? And what you expect to see, one tree? Some hints: -ntp = no transport logs -N = do not recurse, or -f = run on given module etc. > dependency:tree should not log info the user doesn't ask for > > > Key: MDEP-713 > URL: https://issues.apache.org/jira/browse/MDEP-713 > Project: Maven Dependency Plugin > Issue Type: Improvement > Components: tree >Reporter: Elliotte Rusty Harold >Priority: Major > Fix For: waiting-for-feedback > > > I'm going to start this report here, though I kind of expect it slips into > core and a lot of other components. Suppose I run mvn dependency:tree on > Guava. As a user here's what I want to see (though probably minus the [INFO] > prefix): > [INFO] com.google.guava:guava-gwt:jar:HEAD-jre-SNAPSHOT > [INFO] +- com.google.guava:failureaccess:jar:1.0.1:compile > [INFO] +- com.google.guava:guava:jar:HEAD-jre-SNAPSHOT:compile > [INFO] | +- > com.google.guava:listenablefuture:jar:.0-empty-to-avoid-conflict-with-guava:compile > [INFO] | +- com.google.code.findbugs:jsr305:jar:3.0.2:compile > [INFO] | +- com.google.errorprone:error_prone_annotations:jar:2.3.4:compile > [INFO] | \- com.google.j2objc:j2objc-annotations:jar:1.3:compile > [INFO] +- com.google.elemental2:elemental2-promise:jar:1.0.0-RC1:compile > [INFO] | +- com.google.jsinterop:jsinterop-annotations:jar:1.0.2:compile > [INFO] | \- com.google.jsinterop:base:jar:1.0.0-RC1:compile > [INFO] +- com.google.guava:guava-testlib:jar:HEAD-jre-SNAPSHOT:test > [INFO] | \- junit:junit:jar:4.13:test > [INFO] | \- org.hamcrest:hamcrest-core:jar:1.3:test > [INFO] +- com.google.guava:guava-testlib:jar:tests:HEAD-jre-SNAPSHOT:test > [INFO] +- com.google.guava:guava-tests:jar:tests:HEAD-jre-SNAPSHOT:test > [INFO] +- com.google.gwt:gwt-dev:jar:2.8.2:provided > [INFO] | +- com.google.code.gson:gson:jar:2.6.2:provided > [INFO] | +- org.ow2.asm:asm:jar:5.0.3:provided > [INFO] | +- org.ow2.asm:asm-util:jar:5.0.3:provided > [INFO] | | \- org.ow2.asm:asm-tree:jar:5.0.3:provided > [INFO] | +- org.ow2.asm:asm-commons:jar:5.0.3:provided > [INFO] | +- colt:colt:jar:1.2.0:provided > [INFO] | +- ant:ant:jar:1.6.5:provided > [INFO] | +- commons-collections:commons-collections:jar:3.2.2:provided > [INFO] | +- commons-io:commons-io:jar:2.4:provided > [INFO] | +- com.ibm.icu:icu4j:jar:50.1.1:provided > [INFO] | +- tapestry:tapestry:jar:4.0.2:provided > [INFO] | +- net.sourceforge.htmlunit:htmlunit:jar:2.19:provided > [INFO] | | +- xalan:xalan:jar:2.7.2:provided > [INFO] | | | \- xalan:serializer:jar:2.7.2:provided > [INFO] | | +- org.apache.commons:commons-lang3:jar:3.4:provided > [INFO] | | +- org.apache.httpcomponents:httpclient:jar:4.5.1:provided > [INFO] | | | \- org.apache.httpcomponents:httpcore:jar:4.4.3:provided > [INFO] | | +- org.apache.httpcomponents:httpmime:jar:4.5.1:provided > [INFO] | | +- commons-codec:commons-codec:jar:1.10:provided > [INFO] | | +- net.sourceforge.htmlunit:htmlunit-core-js:jar:2.17:provided > [INFO] | | +- xerces:xercesImpl:jar:2.11.0:provided > [INFO] | | | \- xml-apis:xml-apis:jar:1.4.01:provided > [INFO] | | +- net.sourceforge.nekohtml:nekohtml:jar:1.9.22:provided > [INFO] | | +- net.sourceforge.cssparser:cssparser:jar:0.9.18:provided > [INFO] | | +- commons-logging:commons-logging:jar:1.2:provided > [INFO] | | \- > org.eclipse.jetty.websocket:websocket-client:jar:9.2.13.v20150730:provided > [INFO] | | \- > org.eclipse.jetty.websocket:websocket-common:jar:9.2.13.v20150730:provided > [INFO] | |\- > org.eclipse.jetty.websocket:websocket-api:jar:9.2.13.v20150730:provided > [INFO] | +- org.eclipse.jetty:jetty-webapp:jar:9.2.14.v20151106:provided > [INFO] | | +- org.eclipse.jetty:jetty-xml:jar:9.2.14.v20151106:provided > [INFO] | | \- org.eclipse.jetty:jetty-servlet:jar:9.2.14.v20151106:provided > [INFO] | | \- > org.eclipse.jetty:jetty-security:jar:9.2.14.v20151106:provided > [INFO] | +- org.eclipse.jetty:jetty-servlets:jar:9.2.14.v20151106:provided > [INFO] | | +- > org.eclipse.jetty:jetty-continuation:jar:9.2.14.v20151106:provided > [INFO] | | +- org.eclipse.jetty:jetty-http:jar:9.2.14.v20151106:provided > [INFO] | | +- org.eclipse.jetty:jetty-util:jar:9.2.14.v20151106:provided > [INFO] | | \- org.eclipse.jetty:jetty-io:jar:9.2.14.v20151106:provided > [INFO] | +- org.eclipse.jetty:jetty-annotations:jar:9.2.14.v20151106:provided > [INFO] | | +- org.eclipse.jetty:jetty-plus:jar:9.2.14.v20151106:provided > [INFO] | | | \- org.eclipse.jetty:jetty-jndi:jar:9.2.14.v20151106:provided >
[jira] [Created] (MDEP-906) AbstractSerializingVisitor should use a writer, not a printwriter
Elliotte Rusty Harold created MDEP-906: -- Summary: AbstractSerializingVisitor should use a writer, not a printwriter Key: MDEP-906 URL: https://issues.apache.org/jira/browse/MDEP-906 Project: Maven Dependency Plugin Issue Type: Bug Reporter: Elliotte Rusty Harold PrintWriter swallows exceptions. This is unfortunately an API breaking change, but it's an important one,. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Comment Edited] (MDEP-713) dependency:tree should not log info the user doesn't ask for
[ https://issues.apache.org/jira/browse/MDEP-713?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17816042#comment-17816042 ] Elliotte Rusty Harold edited comment on MDEP-713 at 2/9/24 12:42 PM: - No, outputFile is not what I'm asking for. I want to see what I asked for, on the console, and nothing else (unless the project can't be built at all). The single command mvn dependency:tree should not do anything but print the dependency tree. Everything else is an implementation detail. Some of this can be fixed by reducing excess logging in other components like the resolver. However, ultimately we need a way to redirect and suppress all those logs and only print output from this plugin. was (Author: elharo): No, outputFile is not what I'm asking for. I want to see what I asked for, on the console, and nothing else (unless the project can't be built at all). The single command mvn dependency:tree should not do anything but print the dependency tree. Everything else is an implementation detail. > dependency:tree should not log info the user doesn't ask for > > > Key: MDEP-713 > URL: https://issues.apache.org/jira/browse/MDEP-713 > Project: Maven Dependency Plugin > Issue Type: Improvement > Components: tree >Reporter: Elliotte Rusty Harold >Priority: Major > Fix For: waiting-for-feedback > > > I'm going to start this report here, though I kind of expect it slips into > core and a lot of other components. Suppose I run mvn dependency:tree on > Guava. As a user here's what I want to see (though probably minus the [INFO] > prefix): > [INFO] com.google.guava:guava-gwt:jar:HEAD-jre-SNAPSHOT > [INFO] +- com.google.guava:failureaccess:jar:1.0.1:compile > [INFO] +- com.google.guava:guava:jar:HEAD-jre-SNAPSHOT:compile > [INFO] | +- > com.google.guava:listenablefuture:jar:.0-empty-to-avoid-conflict-with-guava:compile > [INFO] | +- com.google.code.findbugs:jsr305:jar:3.0.2:compile > [INFO] | +- com.google.errorprone:error_prone_annotations:jar:2.3.4:compile > [INFO] | \- com.google.j2objc:j2objc-annotations:jar:1.3:compile > [INFO] +- com.google.elemental2:elemental2-promise:jar:1.0.0-RC1:compile > [INFO] | +- com.google.jsinterop:jsinterop-annotations:jar:1.0.2:compile > [INFO] | \- com.google.jsinterop:base:jar:1.0.0-RC1:compile > [INFO] +- com.google.guava:guava-testlib:jar:HEAD-jre-SNAPSHOT:test > [INFO] | \- junit:junit:jar:4.13:test > [INFO] | \- org.hamcrest:hamcrest-core:jar:1.3:test > [INFO] +- com.google.guava:guava-testlib:jar:tests:HEAD-jre-SNAPSHOT:test > [INFO] +- com.google.guava:guava-tests:jar:tests:HEAD-jre-SNAPSHOT:test > [INFO] +- com.google.gwt:gwt-dev:jar:2.8.2:provided > [INFO] | +- com.google.code.gson:gson:jar:2.6.2:provided > [INFO] | +- org.ow2.asm:asm:jar:5.0.3:provided > [INFO] | +- org.ow2.asm:asm-util:jar:5.0.3:provided > [INFO] | | \- org.ow2.asm:asm-tree:jar:5.0.3:provided > [INFO] | +- org.ow2.asm:asm-commons:jar:5.0.3:provided > [INFO] | +- colt:colt:jar:1.2.0:provided > [INFO] | +- ant:ant:jar:1.6.5:provided > [INFO] | +- commons-collections:commons-collections:jar:3.2.2:provided > [INFO] | +- commons-io:commons-io:jar:2.4:provided > [INFO] | +- com.ibm.icu:icu4j:jar:50.1.1:provided > [INFO] | +- tapestry:tapestry:jar:4.0.2:provided > [INFO] | +- net.sourceforge.htmlunit:htmlunit:jar:2.19:provided > [INFO] | | +- xalan:xalan:jar:2.7.2:provided > [INFO] | | | \- xalan:serializer:jar:2.7.2:provided > [INFO] | | +- org.apache.commons:commons-lang3:jar:3.4:provided > [INFO] | | +- org.apache.httpcomponents:httpclient:jar:4.5.1:provided > [INFO] | | | \- org.apache.httpcomponents:httpcore:jar:4.4.3:provided > [INFO] | | +- org.apache.httpcomponents:httpmime:jar:4.5.1:provided > [INFO] | | +- commons-codec:commons-codec:jar:1.10:provided > [INFO] | | +- net.sourceforge.htmlunit:htmlunit-core-js:jar:2.17:provided > [INFO] | | +- xerces:xercesImpl:jar:2.11.0:provided > [INFO] | | | \- xml-apis:xml-apis:jar:1.4.01:provided > [INFO] | | +- net.sourceforge.nekohtml:nekohtml:jar:1.9.22:provided > [INFO] | | +- net.sourceforge.cssparser:cssparser:jar:0.9.18:provided > [INFO] | | +- commons-logging:commons-logging:jar:1.2:provided > [INFO] | | \- > org.eclipse.jetty.websocket:websocket-client:jar:9.2.13.v20150730:provided > [INFO] | | \- > org.eclipse.jetty.websocket:websocket-common:jar:9.2.13.v20150730:provided > [INFO] | |\- > org.eclipse.jetty.websocket:websocket-api:jar:9.2.13.v20150730:provided > [INFO] | +- org.eclipse.jetty:jetty-webapp:jar:9.2.14.v20151106:provided > [INFO] | | +- org.eclipse.jetty:jetty-xml:jar:9.2.14.v20151106:provided > [INFO] | | \- org.eclipse.jetty:jetty-servlet:jar:9.2.14.v20151106:provided > [INFO] | | \- >
[jira] [Commented] (MDEP-713) dependency:tree should not log info the user doesn't ask for
[ https://issues.apache.org/jira/browse/MDEP-713?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17816042#comment-17816042 ] Elliotte Rusty Harold commented on MDEP-713: No, outputFile is not what I'm asking for. I want to see what I asked for, on the console, and nothing else (unless the project can't be built at all). The single command mvn dependency:tree should not do anything but print the dependency tree. Everything else is an implementation detail. > dependency:tree should not log info the user doesn't ask for > > > Key: MDEP-713 > URL: https://issues.apache.org/jira/browse/MDEP-713 > Project: Maven Dependency Plugin > Issue Type: Improvement > Components: tree >Reporter: Elliotte Rusty Harold >Priority: Major > Fix For: waiting-for-feedback > > > I'm going to start this report here, though I kind of expect it slips into > core and a lot of other components. Suppose I run mvn dependency:tree on > Guava. As a user here's what I want to see (though probably minus the [INFO] > prefix): > [INFO] com.google.guava:guava-gwt:jar:HEAD-jre-SNAPSHOT > [INFO] +- com.google.guava:failureaccess:jar:1.0.1:compile > [INFO] +- com.google.guava:guava:jar:HEAD-jre-SNAPSHOT:compile > [INFO] | +- > com.google.guava:listenablefuture:jar:.0-empty-to-avoid-conflict-with-guava:compile > [INFO] | +- com.google.code.findbugs:jsr305:jar:3.0.2:compile > [INFO] | +- com.google.errorprone:error_prone_annotations:jar:2.3.4:compile > [INFO] | \- com.google.j2objc:j2objc-annotations:jar:1.3:compile > [INFO] +- com.google.elemental2:elemental2-promise:jar:1.0.0-RC1:compile > [INFO] | +- com.google.jsinterop:jsinterop-annotations:jar:1.0.2:compile > [INFO] | \- com.google.jsinterop:base:jar:1.0.0-RC1:compile > [INFO] +- com.google.guava:guava-testlib:jar:HEAD-jre-SNAPSHOT:test > [INFO] | \- junit:junit:jar:4.13:test > [INFO] | \- org.hamcrest:hamcrest-core:jar:1.3:test > [INFO] +- com.google.guava:guava-testlib:jar:tests:HEAD-jre-SNAPSHOT:test > [INFO] +- com.google.guava:guava-tests:jar:tests:HEAD-jre-SNAPSHOT:test > [INFO] +- com.google.gwt:gwt-dev:jar:2.8.2:provided > [INFO] | +- com.google.code.gson:gson:jar:2.6.2:provided > [INFO] | +- org.ow2.asm:asm:jar:5.0.3:provided > [INFO] | +- org.ow2.asm:asm-util:jar:5.0.3:provided > [INFO] | | \- org.ow2.asm:asm-tree:jar:5.0.3:provided > [INFO] | +- org.ow2.asm:asm-commons:jar:5.0.3:provided > [INFO] | +- colt:colt:jar:1.2.0:provided > [INFO] | +- ant:ant:jar:1.6.5:provided > [INFO] | +- commons-collections:commons-collections:jar:3.2.2:provided > [INFO] | +- commons-io:commons-io:jar:2.4:provided > [INFO] | +- com.ibm.icu:icu4j:jar:50.1.1:provided > [INFO] | +- tapestry:tapestry:jar:4.0.2:provided > [INFO] | +- net.sourceforge.htmlunit:htmlunit:jar:2.19:provided > [INFO] | | +- xalan:xalan:jar:2.7.2:provided > [INFO] | | | \- xalan:serializer:jar:2.7.2:provided > [INFO] | | +- org.apache.commons:commons-lang3:jar:3.4:provided > [INFO] | | +- org.apache.httpcomponents:httpclient:jar:4.5.1:provided > [INFO] | | | \- org.apache.httpcomponents:httpcore:jar:4.4.3:provided > [INFO] | | +- org.apache.httpcomponents:httpmime:jar:4.5.1:provided > [INFO] | | +- commons-codec:commons-codec:jar:1.10:provided > [INFO] | | +- net.sourceforge.htmlunit:htmlunit-core-js:jar:2.17:provided > [INFO] | | +- xerces:xercesImpl:jar:2.11.0:provided > [INFO] | | | \- xml-apis:xml-apis:jar:1.4.01:provided > [INFO] | | +- net.sourceforge.nekohtml:nekohtml:jar:1.9.22:provided > [INFO] | | +- net.sourceforge.cssparser:cssparser:jar:0.9.18:provided > [INFO] | | +- commons-logging:commons-logging:jar:1.2:provided > [INFO] | | \- > org.eclipse.jetty.websocket:websocket-client:jar:9.2.13.v20150730:provided > [INFO] | | \- > org.eclipse.jetty.websocket:websocket-common:jar:9.2.13.v20150730:provided > [INFO] | |\- > org.eclipse.jetty.websocket:websocket-api:jar:9.2.13.v20150730:provided > [INFO] | +- org.eclipse.jetty:jetty-webapp:jar:9.2.14.v20151106:provided > [INFO] | | +- org.eclipse.jetty:jetty-xml:jar:9.2.14.v20151106:provided > [INFO] | | \- org.eclipse.jetty:jetty-servlet:jar:9.2.14.v20151106:provided > [INFO] | | \- > org.eclipse.jetty:jetty-security:jar:9.2.14.v20151106:provided > [INFO] | +- org.eclipse.jetty:jetty-servlets:jar:9.2.14.v20151106:provided > [INFO] | | +- > org.eclipse.jetty:jetty-continuation:jar:9.2.14.v20151106:provided > [INFO] | | +- org.eclipse.jetty:jetty-http:jar:9.2.14.v20151106:provided > [INFO] | | +- org.eclipse.jetty:jetty-util:jar:9.2.14.v20151106:provided > [INFO] | | \- org.eclipse.jetty:jetty-io:jar:9.2.14.v20151106:provided > [INFO] | +- org.eclipse.jetty:jetty-annotations:jar:9.2.14.v20151106:provided > [INFO] | | +-
[jira] [Commented] (MDEP-799) improve mvn dependency:tree - add optional JSON output of the results
[
https://issues.apache.org/jira/browse/MDEP-799?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17816039#comment-17816039
]
ASF GitHub Bot commented on MDEP-799:
-
elharo commented on code in PR #325:
URL:
https://github.com/apache/maven-dependency-plugin/pull/325#discussion_r1484260841
##
src/main/java/org/apache/maven/plugins/dependency/tree/JsonDependencyNodeVisitor.java:
##
@@ -0,0 +1,179 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.maven.plugins.dependency.tree;
+
+import java.io.IOException;
+import java.io.Writer;
+
+import org.apache.commons.lang3.StringUtils;
+import org.apache.maven.artifact.Artifact;
+import org.apache.maven.shared.dependency.graph.DependencyNode;
+import
org.apache.maven.shared.dependency.graph.traversal.DependencyNodeVisitor;
+
+/**
+ * A dependency node visitor that serializes visited nodes to a writer using
the JSON format.
+ */
+public class JsonDependencyNodeVisitor extends AbstractSerializingVisitor
implements DependencyNodeVisitor {
Review Comment:
Does this need to be public? It's easier to evolve and iterate on if it's
not.
##
src/main/java/org/apache/maven/plugins/dependency/tree/JsonDependencyNodeVisitor.java:
##
@@ -0,0 +1,179 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.maven.plugins.dependency.tree;
+
+import java.io.IOException;
+import java.io.Writer;
+
+import org.apache.commons.lang3.StringUtils;
+import org.apache.maven.artifact.Artifact;
+import org.apache.maven.shared.dependency.graph.DependencyNode;
+import
org.apache.maven.shared.dependency.graph.traversal.DependencyNodeVisitor;
+
+/**
+ * A dependency node visitor that serializes visited nodes to a writer using
the JSON format.
+ */
+public class JsonDependencyNodeVisitor extends AbstractSerializingVisitor
implements DependencyNodeVisitor {
+
+private String indentChar = " ";
+
+/**
+ * Creates a new instance of {@link JsonDependencyNodeVisitor}. The writer
will be used to write the output.
+ * @param writer the writer to write to
+ */
+public JsonDependencyNodeVisitor(Writer writer) {
+super(writer);
+}
+
+@Override
+public boolean visit(DependencyNode node) {
+if (node.getParent() == null || node.getParent() == node) {
+writeRootNode(node, writer);
+}
+return true;
+}
+
+/**
+ * Writes the node to the writer. This method is recursive and will write
all children nodes.
+ * @param node the node to write
+ * @param writer the writer to write to
+ */
+private void writeRootNode(DependencyNode node, Writer writer) {
+int indent = 2;
+StringBuilder sb = new StringBuilder();
+sb.append("{").append("\n");
+writeNode(indent, node, sb);
+sb.append("}").append("\n");
+try {
+writer.write(sb.toString());
+} catch (IOException e) {
+throw new RuntimeException("Error while writing json output", e);
Review Comment:
needs a more specific exception. Looking at this now I notice that the
superclass and interface are badly designed. They use a PrintWriter which
swallows exceptions. That might need to be fixed.
> improve mvn dependency:tree - add optional JSON output of the results
>
Re: [PR] [MDEP-799] tree: add optional output type json [maven-dependency-plugin]
elharo commented on code in PR #325:
URL:
https://github.com/apache/maven-dependency-plugin/pull/325#discussion_r1484260841
##
src/main/java/org/apache/maven/plugins/dependency/tree/JsonDependencyNodeVisitor.java:
##
@@ -0,0 +1,179 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.maven.plugins.dependency.tree;
+
+import java.io.IOException;
+import java.io.Writer;
+
+import org.apache.commons.lang3.StringUtils;
+import org.apache.maven.artifact.Artifact;
+import org.apache.maven.shared.dependency.graph.DependencyNode;
+import
org.apache.maven.shared.dependency.graph.traversal.DependencyNodeVisitor;
+
+/**
+ * A dependency node visitor that serializes visited nodes to a writer using
the JSON format.
+ */
+public class JsonDependencyNodeVisitor extends AbstractSerializingVisitor
implements DependencyNodeVisitor {
Review Comment:
Does this need to be public? It's easier to evolve and iterate on if it's
not.
##
src/main/java/org/apache/maven/plugins/dependency/tree/JsonDependencyNodeVisitor.java:
##
@@ -0,0 +1,179 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.maven.plugins.dependency.tree;
+
+import java.io.IOException;
+import java.io.Writer;
+
+import org.apache.commons.lang3.StringUtils;
+import org.apache.maven.artifact.Artifact;
+import org.apache.maven.shared.dependency.graph.DependencyNode;
+import
org.apache.maven.shared.dependency.graph.traversal.DependencyNodeVisitor;
+
+/**
+ * A dependency node visitor that serializes visited nodes to a writer using
the JSON format.
+ */
+public class JsonDependencyNodeVisitor extends AbstractSerializingVisitor
implements DependencyNodeVisitor {
+
+private String indentChar = " ";
+
+/**
+ * Creates a new instance of {@link JsonDependencyNodeVisitor}. The writer
will be used to write the output.
+ * @param writer the writer to write to
+ */
+public JsonDependencyNodeVisitor(Writer writer) {
+super(writer);
+}
+
+@Override
+public boolean visit(DependencyNode node) {
+if (node.getParent() == null || node.getParent() == node) {
+writeRootNode(node, writer);
+}
+return true;
+}
+
+/**
+ * Writes the node to the writer. This method is recursive and will write
all children nodes.
+ * @param node the node to write
+ * @param writer the writer to write to
+ */
+private void writeRootNode(DependencyNode node, Writer writer) {
+int indent = 2;
+StringBuilder sb = new StringBuilder();
+sb.append("{").append("\n");
+writeNode(indent, node, sb);
+sb.append("}").append("\n");
+try {
+writer.write(sb.toString());
+} catch (IOException e) {
+throw new RuntimeException("Error while writing json output", e);
Review Comment:
needs a more specific exception. Looking at this now I notice that the
superclass and interface are badly designed. They use a PrintWriter which
swallows exceptions. That might need to be fixed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Created] (MRESOLVER-494) LOCAL_PATH Artifact property really belongs to "system" scope (or is at least very related to it)
Tamas Cservenak created MRESOLVER-494: - Summary: LOCAL_PATH Artifact property really belongs to "system" scope (or is at least very related to it) Key: MRESOLVER-494 URL: https://issues.apache.org/jira/browse/MRESOLVER-494 Project: Maven Resolver Issue Type: Improvement Components: Resolver Reporter: Tamas Cservenak Fix For: 2.0.0-alpha-8, 2.0.0 LOCAL_PATH Artifact property really belongs to "system" scope (or is at least very related to it). It may need to be removed as well? -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MDEP-799) improve mvn dependency:tree - add optional JSON output of the results
[ https://issues.apache.org/jira/browse/MDEP-799?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17816017#comment-17816017 ] ASF GitHub Bot commented on MDEP-799: - pombredanne commented on PR #325: URL: https://github.com/apache/maven-dependency-plugin/pull/325#issuecomment-1935725046 @MartinWitt what's left to do to get this through? FWIW, there is a cottage industry of smalls tools and scripts that are parsing this plugin output it would be awesome to have a structure JSON output! Anything to help you need move this forward? > improve mvn dependency:tree - add optional JSON output of the results > - > > Key: MDEP-799 > URL: https://issues.apache.org/jira/browse/MDEP-799 > Project: Maven Dependency Plugin > Issue Type: New Feature > Components: tree >Reporter: Zhenxu Ke >Priority: Major > > I'd like to add an output type JSON, will open a pull request soon -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] [MDEP-799] tree: add optional output type json [maven-dependency-plugin]
pombredanne commented on PR #325: URL: https://github.com/apache/maven-dependency-plugin/pull/325#issuecomment-1935725046 @MartinWitt what's left to do to get this through? FWIW, there is a cottage industry of smalls tools and scripts that are parsing this plugin output it would be awesome to have a structure JSON output! Anything to help you need move this forward? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] Bump org.testcontainers:testcontainers-bom from 1.19.4 to 1.19.5 [maven-build-cache-extension]
dependabot[bot] opened a new pull request, #132: URL: https://github.com/apache/maven-build-cache-extension/pull/132 Bumps [org.testcontainers:testcontainers-bom](https://github.com/testcontainers/testcontainers-java) from 1.19.4 to 1.19.5. Release notes Sourced from https://github.com/testcontainers/testcontainers-java/releases;>org.testcontainers:testcontainers-bom's releases. 1.19.5 Testcontainers for Java 1.19.5 [!IMPORTANT] This version has downgraded the commons-compress version to 1.24.0 in order to avoid classpath conflicts due to a recent change in commons-compress 1.25.0. See https://redirect.github.com/testcontainers/testcontainers-java/issues/8169;>testcontainers/testcontainers-java#8169 for more details. Commits https://github.com/testcontainers/testcontainers-java/commit/c210afb0b0944d1a96b7a760f93d6601a9058173;>c210afb Downgrade commons-compress version to 1.24.0 (https://redirect.github.com/testcontainers/testcontainers-java/issues/8284;>#8284) https://github.com/testcontainers/testcontainers-java/commit/853f657be4c0b1b930b0c298cdc10288f0ac7521;>853f657 Increase maximum heap size (https://redirect.github.com/testcontainers/testcontainers-java/issues/8283;>#8283) https://github.com/testcontainers/testcontainers-java/commit/d3d10854a9b116f379dee63310d4dbaa9f36e0f2;>d3d1085 Fix HiveMQ logo (https://redirect.github.com/testcontainers/testcontainers-java/issues/8215;>#8215) https://github.com/testcontainers/testcontainers-java/commit/78d17685359de57dd770d3dbf5e24433d40698fb;>78d1768 [create-pull-request] automated change (https://redirect.github.com/testcontainers/testcontainers-java/issues/8165;>#8165) https://github.com/testcontainers/testcontainers-java/commit/62ca5a084109a8d4f6749b691168f3eb2420120c;>62ca5a0 [create-pull-request] automated change (https://redirect.github.com/testcontainers/testcontainers-java/issues/8166;>#8166) See full diff in https://github.com/testcontainers/testcontainers-java/compare/1.19.4...1.19.5;>compare view [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
