[jira] [Commented] (MJLINK-79) addOptions should not quote option strings

2024-03-08 Thread ASF GitHub Bot (Jira)


[ 
https://issues.apache.org/jira/browse/MJLINK-79?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17824901#comment-17824901
 ] 

ASF GitHub Bot commented on MJLINK-79:
--

YaSuenag commented on PR #196:
URL: 
https://github.com/apache/maven-jlink-plugin/pull/196#issuecomment-1986732996

   PING: could you review this PR?




> addOptions should not quote option strings
> --
>
> Key: MJLINK-79
> URL: https://issues.apache.org/jira/browse/MJLINK-79
> Project: Maven JLink Plugin
>  Issue Type: Bug
>Affects Versions: 3.2.0
>Reporter: Yasumasa Suenaga
>Priority: Major
>
> I configured maven-jlink-plugin as following:
> {code:java}
> 
> -XX:+HeapDumpOnOutOfMemoryError
>     -XX:+UseParallelOldGC
>  {code}
> I saw following error when I run jlink'ed binary:
> {code:java}
> $ ./target/maven-jlink/classifiers/linux-amd64/bin/test
> Unrecognized VM option 'HeapDumpOnOutOfMemoryError -XX:+UseParallelOldGC'
> Error: Could not create the Java Virtual Machine.
> Error: A fatal exception has occurred. Program will exit. {code}
> JLinkMojo.java would quote option string like 
> {noformat}
> String.format("\"%s\"", String.join(" ", addOptions)){noformat}
> However it should not do that because jlink would run jlink implementation 
> which comes from ToolProvider, not on the shell.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


Re: [PR] [MJLINK-79] addOptions should not quote option strings [maven-jlink-plugin]

2024-03-08 Thread via GitHub


YaSuenag commented on PR #196:
URL: 
https://github.com/apache/maven-jlink-plugin/pull/196#issuecomment-1986732996

   PING: could you review this PR?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[jira] [Commented] (SUREFIRE-2219) Option to include stdOut/stdErr console logs into test report

2024-03-08 Thread ASF GitHub Bot (Jira)


[ 
https://issues.apache.org/jira/browse/SUREFIRE-2219?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17824887#comment-17824887
 ] 

ASF GitHub Bot commented on SUREFIRE-2219:
--

acouvreur commented on PR #692:
URL: https://github.com/apache/maven-surefire/pull/692#issuecomment-1986579612

   Thanks for this feature @kriegaex !
   I would also need this feature, do you need any help on getting the work 
done ?
   I'm able to help




> Option to include stdOut/stdErr console logs into test report
> -
>
> Key: SUREFIRE-2219
> URL: https://issues.apache.org/jira/browse/SUREFIRE-2219
> Project: Maven Surefire
>  Issue Type: New Feature
>  Components: Maven Surefire Report Plugin
>Affects Versions: 3.2.2
>Reporter: Alexander Kriegisch
>Priority: Major
> Attachments: image-2023-12-02-11-16-11-109.png
>
>
> Surefire report XML includes tags capturing console logs, e.g. 
> {{testsuite/testcase/system-err}}:
>  !image-2023-12-02-11-16-11-109.png! 
> As a report reader, I want to see the stdOut/stdErr console logs per test 
> case in the HTML report, ideally in a monotype font to easily be able to read 
> stack traces.
> This requirement has been discussed online a lot, e.g. on Stack Overflow or 
> Reddit. I wonder why such a feature is missing. The HTML report basically 
> being an XML transformation from the surefire report, it should not be super 
> complicated to implement.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


Re: [PR] [SUREFIRE-2219] Add test stdErr/stdOut output to ReportTestCase [maven-surefire]

2024-03-08 Thread via GitHub


acouvreur commented on PR #692:
URL: https://github.com/apache/maven-surefire/pull/692#issuecomment-1986579612

   Thanks for this feature @kriegaex !
   I would also need this feature, do you need any help on getting the work 
done ?
   I'm able to help


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[PR] Bump org.apache.camel:camel-core from 3.2.0 to 3.21.4 in /src/it/projects/bugs/massembly-920 [maven-assembly-plugin]

2024-03-08 Thread via GitHub


dependabot[bot] opened a new pull request, #190:
URL: https://github.com/apache/maven-assembly-plugin/pull/190

   Bumps org.apache.camel:camel-core from 3.2.0 to 3.21.4.
   
   
   [![Dependabot compatibility 
score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=org.apache.camel:camel-core&package-manager=maven&previous-version=3.2.0&new-version=3.21.4)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)
   
   Dependabot will resolve any conflicts with this PR as long as you don't 
alter it yourself. You can also trigger a rebase manually by commenting 
`@dependabot rebase`.
   
   [//]: # (dependabot-automerge-start)
   [//]: # (dependabot-automerge-end)
   
   ---
   
   
   Dependabot commands and options
   
   
   You can trigger Dependabot actions by commenting on this PR:
   - `@dependabot rebase` will rebase this PR
   - `@dependabot recreate` will recreate this PR, overwriting any edits that 
have been made to it
   - `@dependabot merge` will merge this PR after your CI passes on it
   - `@dependabot squash and merge` will squash and merge this PR after your CI 
passes on it
   - `@dependabot cancel merge` will cancel a previously requested merge and 
block automerging
   - `@dependabot reopen` will reopen this PR if it is closed
   - `@dependabot close` will close this PR and stop Dependabot recreating it. 
You can achieve the same result by closing it manually
   - `@dependabot show  ignore conditions` will show all of 
the ignore conditions of the specified dependency
   - `@dependabot ignore this major version` will close this PR and stop 
Dependabot creating any more for this major version (unless you reopen the PR 
or upgrade to it yourself)
   - `@dependabot ignore this minor version` will close this PR and stop 
Dependabot creating any more for this minor version (unless you reopen the PR 
or upgrade to it yourself)
   - `@dependabot ignore this dependency` will close this PR and stop 
Dependabot creating any more for this dependency (unless you reopen the PR or 
upgrade to it yourself)
   You can disable automated security fix PRs for this repo from the [Security 
Alerts page](https://github.com/apache/maven-assembly-plugin/network/alerts).
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[jira] [Updated] (MCOMPILER-581) Create second default execution "default-generate-sources" for APT

2024-03-08 Thread Michael Osipov (Jira)


 [ 
https://issues.apache.org/jira/browse/MCOMPILER-581?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Michael Osipov updated MCOMPILER-581:
-
Summary: Create second default execution "default-generate-sources" for APT 
 (was: Create 2nd default execution "default-generate-sources" for APT)

> Create second default execution "default-generate-sources" for APT
> --
>
> Key: MCOMPILER-581
> URL: https://issues.apache.org/jira/browse/MCOMPILER-581
> Project: Maven Compiler Plugin
>  Issue Type: Task
>Reporter: Benjamin Marwell
>Priority: Major
> Fix For: 4.0.0
>
>
> Starting with version 4.0.0 of this plugin for use with Maven 4+, the 
> following changes should be incorporated to align the compilation process 
> with the process designed by the OpenJDK javac team:
> * Modify default-compile to use proc:none by default
> * Create a new goal default-generate-sources and use proc:only
> This will align the compilation process with the default javac use.
> h2. Rationale 
> Before JDK 21+, no "proc:full" was available and implicitly used when no 
> proc:* was set.
> However, starting with  JDK 21, proc:full was introduced and not specifying 
> proc:* will now trigger a warning.
> h2. Alternatives
> Keep one phase but specify proc:full whenever APTs are in the CP or used as a 
> compiler-plugin dependency/path or when APT classes are explicitly given.
> h2. Drawbacks of this approach
> TODO: document drawbacks of this approach and of the alternatives.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (DOXIASITETOOLS-332) Create anchors for indexable entries automatically

2024-03-08 Thread ASF GitHub Bot (Jira)


[ 
https://issues.apache.org/jira/browse/DOXIASITETOOLS-332?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17824852#comment-17824852
 ] 

ASF GitHub Bot commented on DOXIASITETOOLS-332:
---

michael-o opened a new pull request, #139:
URL: https://github.com/apache/maven-doxia-sitetools/pull/139

   This closes #139




> Create anchors for indexable entries automatically
> --
>
> Key: DOXIASITETOOLS-332
> URL: https://issues.apache.org/jira/browse/DOXIASITETOOLS-332
> Project: Maven Doxia Sitetools
>  Issue Type: Improvement
>  Components: Site renderer
>Affects Versions: 2.0.0-M16
>Reporter: Michael Osipov
>Assignee: Michael Osipov
>Priority: Major
> Fix For: 2.0.0, 2.0.0-M17
>
>
> At some point some wrapping code was dropped which created duplicate IDs in 
> the output. Doxia 2.0.0-M9 can now natively, without collisions, produce 
> those IDs. We should enable them by default for site rendering.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[PR] [DOXIASITETOOLS-332] Create anchors for indexable entries automatically [maven-doxia-sitetools]

2024-03-08 Thread via GitHub


michael-o opened a new pull request, #139:
URL: https://github.com/apache/maven-doxia-sitetools/pull/139

   This closes #139


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[jira] [Created] (MPMD-392) Allow skip maven toolchain configuration

2024-03-08 Thread Roberto Araujo (Jira)
Roberto Araujo created MPMD-392:
---

 Summary: Allow skip maven toolchain configuration
 Key: MPMD-392
 URL: https://issues.apache.org/jira/browse/MPMD-392
 Project: Maven PMD Plugin
  Issue Type: New Feature
Reporter: Roberto Araujo


I think it's a good idea allow skip the usage of maven toolchain, let me give 
my use case:

I'm working on a "legacy" java application. The application is compiled 
targeting Java 6. Our build requires Java 17, so we are using the JDK 6 
toolchain (via Maven Toolchain plugin) to compile the source code (Note that 
Java 17 compiler can't target Java 6 bytecode).

The problem is that PMD Plugin will use the configured toolchain. Obviously, 
the latest version is not compatible with Java 6 so the execution fails with  
the following exception:

```
Exception in thread "main" java.lang.UnsupportedClassVersionError: 
org/apache/maven/plugins/pmd/exec/PmdExecutor : Unsupported major.minor version 
52.0
```

One option is to configure a new toolchain just to  PMD plugin and use the 
``option 
(https://maven.apache.org/plugins/maven-pmd-plugin/pmd-mojo.html#jdkToolchain). 
A Much more portable solution is to skip the usage of configured toolchain, so 
we don't depend of the `settings.xml` file.


If this makes sense, I can try to work on it and fire a PR on the GitHub 
repository.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Created] (DOXIASITETOOLS-332) Create anchors for indexable entries automatically

2024-03-08 Thread Michael Osipov (Jira)
Michael Osipov created DOXIASITETOOLS-332:
-

 Summary: Create anchors for indexable entries automatically
 Key: DOXIASITETOOLS-332
 URL: https://issues.apache.org/jira/browse/DOXIASITETOOLS-332
 Project: Maven Doxia Sitetools
  Issue Type: Improvement
  Components: Site renderer
Affects Versions: 2.0.0-M16
Reporter: Michael Osipov
Assignee: Michael Osipov
 Fix For: 2.0.0, 2.0.0-M17


At some point some wrapping code was dropped which created duplicate IDs in the 
output. Doxia 2.0.0-M9 can now natively, without collisions, produce those IDs. 
We should enable them by default for site rendering.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Closed] (DOXIA-725) Latest Doxia Core is not compatible with doxia-sitetools

2024-03-08 Thread Michael Osipov (Jira)


 [ 
https://issues.apache.org/jira/browse/DOXIA-725?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Michael Osipov closed DOXIA-725.

Fix Version/s: (was: waiting-for-feedback)
   Resolution: Information Provided

> Latest Doxia Core is not compatible with doxia-sitetools
> 
>
> Key: DOXIA-725
> URL: https://issues.apache.org/jira/browse/DOXIA-725
> Project: Maven Doxia
>  Issue Type: Improvement
>Affects Versions: 2.0.0-M9
>Reporter: Abel Salgado Romero
>Priority: Major
>
> Testing Milestones I found `doxia-core` 4.0.0-M9 is not compatible with 
> `doxia-sitetools`.
> This commit 
> [https://github.com/apache/maven-doxia/commit/0dfe227b6603151b8b460d2b7cacc8953a512f4f]
>  final methods where added to `AbstractSink` class, those are still present 
> in sub-classes like `SiteRendererSink` which now fail instantiation with:
> ```
> java.lang.IncompatibleClassChangeError: class 
> org.apache.maven.doxia.siterenderer.sink.SiteRendererSink overrides final 
> method org.apache.maven.doxia.sink.impl.AbstractSink.head(
> ```



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Updated] (MNG-7906) Dependency Management import (BOM) does not work the "maven way"

2024-03-08 Thread Tamas Cservenak (Jira)


 [ 
https://issues.apache.org/jira/browse/MNG-7906?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Tamas Cservenak updated MNG-7906:
-
Summary: Dependency Management import (BOM) does not work the "maven way"  
(was: Dependency Management import does not work the "maven way")

> Dependency Management import (BOM) does not work the "maven way"
> 
>
> Key: MNG-7906
> URL: https://issues.apache.org/jira/browse/MNG-7906
> Project: Maven
>  Issue Type: Bug
>  Components: Dependencies, Documentation:  General
>Reporter: Tamas Cservenak
>Priority: Major
> Fix For: 4.0.x-candidate
>
>
> This affects all released Maven versions so far.
> Problem reproducer: https://github.com/cstamas/MNG-7852 (repo name is wrong, 
> obviously).
> In short: unlike with dependencies, where you CAN override some "deep 
> transitive" dependency by re-declaring it directly as 1st level dependency in 
> POM, for depMgt import this does not work, actually, it works quite the 
> opposite ("first comes, wins"). Moreover, Maven remains silent about this, as 
> reproducer shows, and all of this goes unnoticed.
> Solution: at least depMgt import should make "the maven way", maybe not by 
> default (to not break existing builds) but configurable. Problem is solved if 
> in reproducer:
> - with fix enabled, junit 5.9.3 is used, AND
> - with fix disabled, Maven yells about ignored depMgt import



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (MGPG-111) Clean upn dependency declarations

2024-03-08 Thread Tamas Cservenak (Jira)


[ 
https://issues.apache.org/jira/browse/MGPG-111?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17824801#comment-17824801
 ] 

Tamas Cservenak commented on MGPG-111:
--

Re junixsocket, in fact BOTH are used (but one goes undetected, as is native):

[https://repo.maven.apache.org/maven2/com/kohlschutter/junixsocket/junixsocket-core/2.9.0/junixsocket-core-2.9.0.pom]

This is how POM looks and even description tells "this is the one you want to 
add as dependency".

About "dependency grouping": 
[https://blog.sonatype.com/2009/10/maven-tips-and-tricks-grouping-dependencies/]

Note: this technique predates BOMs, but is IMHO maybe better than BOMs as they 
do work in "maven way", unlike BOMs. See MNG-8009, MNG-7906, MNG-5971 and many 
others.

> Clean upn dependency declarations
> -
>
> Key: MGPG-111
> URL: https://issues.apache.org/jira/browse/MGPG-111
> Project: Maven GPG Plugin
>  Issue Type: Dependency upgrade
>Reporter: Elliotte Rusty Harold
>Priority: Minor
>
> [WARNING] Used undeclared dependencies found:
> [WARNING]org.apache.maven:maven-artifact:jar:3.9.6:provided
> [WARNING]org.apache.maven:maven-settings:jar:3.9.6:provided
> [WARNING]com.kohlschutter.junixsocket:junixsocket-common:jar:2.9.0:compile
> [WARNING]org.apache.maven.resolver:maven-resolver-impl:jar:1.9.18:provided
> [WARNING] Unused declared dependencies found:
> [WARNING]com.kohlschutter.junixsocket:junixsocket-core:pom:2.9.0:compile
> [WARNING]org.codehaus.plexus:plexus-cipher:jar:2.0:compile



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (MNG-5726) Update OS Activation To Allow Wildcards In OS Version

2024-03-08 Thread ASF GitHub Bot (Jira)


[ 
https://issues.apache.org/jira/browse/MNG-5726?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17824794#comment-17824794
 ] 

ASF GitHub Bot commented on MNG-5726:
-

kwin opened a new pull request, #501:
URL: https://github.com/apache/maven-site/pull/501

   Extend description in POM reference.




> Update OS Activation To Allow Wildcards In OS Version
> -
>
> Key: MNG-5726
> URL: https://issues.apache.org/jira/browse/MNG-5726
> Project: Maven
>  Issue Type: New Feature
>  Components: Profiles
>Affects Versions: 3.1.1, 3.2.3
> Environment: RHEL/CentOs
>Reporter: Andy Lehane
>Assignee: Konrad Windszus
>Priority: Minor
> Fix For: 3.9.7, 4.0.0, 4.0.0-alpha-13
>
> Attachments: maven-os-version-patch-3.2.3.zip
>
>
> I'm attempting to use maven to build a legacy project that requires different 
> dependecies based on the operating system version, i.e:
>  - version 1.0 of "a platform specific library" for Red Hat Linux 5 
>  - version 1.1 of "a platform specific library" for Red Hat Linux 6
>  - version 1.4a of "a platform specific library" for Windows and
>  - version 1.3b of (a platform specific library" for Solaris.
> I can configure my pom file to get activate specific profiles for RHEL, Win 
> and Solaris but cannot distinguish between Red Hat 5 and 6 unless I use the 
> full version string, which is of the form "2.6.32-504.1.3.el6.x86_64".
> As this Linux version will change whenever patch updates are installed, this 
> will make maintaining the pom/project akward.
> To solve this, it would be good to be able to specify wildcard's in the os 
> version tag. I have taken a look at the range checking (for example, as 
> applied to the JdkVersion), but don't think this method would be sufficient, 
> as the specific part of the Red Hat version number we require is buried over 
> half way into the version string (i.e. "el6" of the version 
> "2.6.32-504.1.3.el6.x86_64").
> It would be nice to be able to have something like:
> {code}
> 
>   linux-rhel5
> 
>   false
>   
> unix
> Linux
> *el5*
>   
> 
> 
> .
> {code}
> I've taken a look at the OperatingSystemProfileActivator code and have 
> created a patch that will use ^ to signify that the text is a regular 
> expression, for example:
> {code}
> ^.*(el5).*
> {code}
> I've also kept the ! notation, so the following can also be used:
> {code}
> !^.*(el5).*
> {code}
> The patch added contains a unit test for the OperatingSystemProfileActivator 
> in the maven-model-builder project (warning: it's a nasty test but I couldn't 
> find a nicer way of being able to reliably manuplate the OS Version).
> I've also patch the OperatingSystemProfileActivator class in the maven-compat 
> project but have not been able to write a unit test for that class.
> Can this updated be considered for implementation/inclusion please?



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[PR] [MNG-5726] Describe regex matching for OS version profile activation [maven-site]

2024-03-08 Thread via GitHub


kwin opened a new pull request, #501:
URL: https://github.com/apache/maven-site/pull/501

   Extend description in POM reference.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[jira] [Commented] (MSHARED-1285) DefaultMavenResourcesFiltering uses BuildContext in a way that fails sometimes

2024-03-08 Thread ASF GitHub Bot (Jira)


[ 
https://issues.apache.org/jira/browse/MSHARED-1285?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17824793#comment-17824793
 ] 

ASF GitHub Bot commented on MSHARED-1285:
-

reckart commented on PR #77:
URL: https://github.com/apache/maven-filtering/pull/77#issuecomment-1985714575

   @OLibutzki the development process of Apache projects generally is public - 
you can help by testing and casting your vote as well - just reply to the 
voting mail. However, unless you are part of the project management committee, 
you vote will not count as binding. A release vote is successful with at least 
3 +1 votes after at least 72h and no -1 vote. See 
https://www.apache.org/foundation/voting.html




> DefaultMavenResourcesFiltering uses BuildContext in a way that fails sometimes
> --
>
> Key: MSHARED-1285
> URL: https://issues.apache.org/jira/browse/MSHARED-1285
> Project: Maven Shared Components
>  Issue Type: Bug
>  Components: maven-filtering
>Reporter: Christoph Läubrich
>Assignee: Elliotte Rusty Harold
>Priority: Major
> Fix For: maven-filtering-3.3.2
>
>
> The maven resources plugin uses 
> [https://github.com/apache/maven-filtering/blob/master/src/main/java/org/apache/maven/shared/filtering/DefaultMavenResourcesFiltering.java]
>  to copy resources, but that component has some subtile flaws reported here:
> [https://github.com/eclipse-m2e/m2e-core/discussions/1468]
> The problematic part is the usage of BuildContext#newScanner that already 
> mentions in the javadoc that passing ignoreDelta to neScanner might not 
> reveal all required items +*for copy-resources*+ form A -> B and instead 
> BuildContext#isUpTodate should be used.
> Just from a quick look I assume that part of code actually wants to use 
> something like this:
> {code:java}
> DirectoryScanner ds = new DirectoryScanner() {
>   @Override
>   protected boolean isSelected(String name, File file) {
> if (file.isFile() && buildContext.isUptodate(getTargetFile(file), file)) 
> { 
>  return false;
> }
> return true;
>   }
> };
> ds.setBasedir(basedir); {code}
> That way all the code that currently checks for if output directory existed 
> before can also be removed what is another issue because it leads to a full 
> resources copy even if source+target are already even if a single class file 
> is changed while the idea seems more that if the output was not there it 
> should not try to be incremental!



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


Re: [PR] [MSHARED-1285] use an up-to-date scanner instead the newscanner [maven-filtering]

2024-03-08 Thread via GitHub


reckart commented on PR #77:
URL: https://github.com/apache/maven-filtering/pull/77#issuecomment-1985714575

   @OLibutzki the development process of Apache projects generally is public - 
you can help by testing and casting your vote as well - just reply to the 
voting mail. However, unless you are part of the project management committee, 
you vote will not count as binding. A release vote is successful with at least 
3 +1 votes after at least 72h and no -1 vote. See 
https://www.apache.org/foundation/voting.html


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[jira] [Commented] (MSHARED-1285) DefaultMavenResourcesFiltering uses BuildContext in a way that fails sometimes

2024-03-08 Thread ASF GitHub Bot (Jira)


[ 
https://issues.apache.org/jira/browse/MSHARED-1285?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17824791#comment-17824791
 ] 

ASF GitHub Bot commented on MSHARED-1285:
-

reckart commented on PR #77:
URL: https://github.com/apache/maven-filtering/pull/77#issuecomment-1985709598

   https://lists.apache.org/list?d...@maven.apache.org:2024-3:vote




> DefaultMavenResourcesFiltering uses BuildContext in a way that fails sometimes
> --
>
> Key: MSHARED-1285
> URL: https://issues.apache.org/jira/browse/MSHARED-1285
> Project: Maven Shared Components
>  Issue Type: Bug
>  Components: maven-filtering
>Reporter: Christoph Läubrich
>Assignee: Elliotte Rusty Harold
>Priority: Major
> Fix For: maven-filtering-3.3.2
>
>
> The maven resources plugin uses 
> [https://github.com/apache/maven-filtering/blob/master/src/main/java/org/apache/maven/shared/filtering/DefaultMavenResourcesFiltering.java]
>  to copy resources, but that component has some subtile flaws reported here:
> [https://github.com/eclipse-m2e/m2e-core/discussions/1468]
> The problematic part is the usage of BuildContext#newScanner that already 
> mentions in the javadoc that passing ignoreDelta to neScanner might not 
> reveal all required items +*for copy-resources*+ form A -> B and instead 
> BuildContext#isUpTodate should be used.
> Just from a quick look I assume that part of code actually wants to use 
> something like this:
> {code:java}
> DirectoryScanner ds = new DirectoryScanner() {
>   @Override
>   protected boolean isSelected(String name, File file) {
> if (file.isFile() && buildContext.isUptodate(getTargetFile(file), file)) 
> { 
>  return false;
> }
> return true;
>   }
> };
> ds.setBasedir(basedir); {code}
> That way all the code that currently checks for if output directory existed 
> before can also be removed what is another issue because it leads to a full 
> resources copy even if source+target are already even if a single class file 
> is changed while the idea seems more that if the output was not there it 
> should not try to be incremental!



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


Re: [PR] [MSHARED-1285] use an up-to-date scanner instead the newscanner [maven-filtering]

2024-03-08 Thread via GitHub


reckart commented on PR #77:
URL: https://github.com/apache/maven-filtering/pull/77#issuecomment-1985709598

   https://lists.apache.org/list?d...@maven.apache.org:2024-3:vote


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[jira] [Commented] (MSHARED-1285) DefaultMavenResourcesFiltering uses BuildContext in a way that fails sometimes

2024-03-08 Thread ASF GitHub Bot (Jira)


[ 
https://issues.apache.org/jira/browse/MSHARED-1285?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17824790#comment-17824790
 ] 

ASF GitHub Bot commented on MSHARED-1285:
-

OLibutzki commented on PR #77:
URL: https://github.com/apache/maven-filtering/pull/77#issuecomment-1985701031

   > The release is still under vote.
   
   Thanks for the feedback... this is not a publicly visible process, right?




> DefaultMavenResourcesFiltering uses BuildContext in a way that fails sometimes
> --
>
> Key: MSHARED-1285
> URL: https://issues.apache.org/jira/browse/MSHARED-1285
> Project: Maven Shared Components
>  Issue Type: Bug
>  Components: maven-filtering
>Reporter: Christoph Läubrich
>Assignee: Elliotte Rusty Harold
>Priority: Major
> Fix For: maven-filtering-3.3.2
>
>
> The maven resources plugin uses 
> [https://github.com/apache/maven-filtering/blob/master/src/main/java/org/apache/maven/shared/filtering/DefaultMavenResourcesFiltering.java]
>  to copy resources, but that component has some subtile flaws reported here:
> [https://github.com/eclipse-m2e/m2e-core/discussions/1468]
> The problematic part is the usage of BuildContext#newScanner that already 
> mentions in the javadoc that passing ignoreDelta to neScanner might not 
> reveal all required items +*for copy-resources*+ form A -> B and instead 
> BuildContext#isUpTodate should be used.
> Just from a quick look I assume that part of code actually wants to use 
> something like this:
> {code:java}
> DirectoryScanner ds = new DirectoryScanner() {
>   @Override
>   protected boolean isSelected(String name, File file) {
> if (file.isFile() && buildContext.isUptodate(getTargetFile(file), file)) 
> { 
>  return false;
> }
> return true;
>   }
> };
> ds.setBasedir(basedir); {code}
> That way all the code that currently checks for if output directory existed 
> before can also be removed what is another issue because it leads to a full 
> resources copy even if source+target are already even if a single class file 
> is changed while the idea seems more that if the output was not there it 
> should not try to be incremental!



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


Re: [PR] [MSHARED-1285] use an up-to-date scanner instead the newscanner [maven-filtering]

2024-03-08 Thread via GitHub


OLibutzki commented on PR #77:
URL: https://github.com/apache/maven-filtering/pull/77#issuecomment-1985701031

   > The release is still under vote.
   
   Thanks for the feedback... this is not a publicly visible process, right?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[jira] [Commented] (MSHARED-1285) DefaultMavenResourcesFiltering uses BuildContext in a way that fails sometimes

2024-03-08 Thread ASF GitHub Bot (Jira)


[ 
https://issues.apache.org/jira/browse/MSHARED-1285?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17824787#comment-17824787
 ] 

ASF GitHub Bot commented on MSHARED-1285:
-

gnodet commented on PR #77:
URL: https://github.com/apache/maven-filtering/pull/77#issuecomment-1985677119

   > > I'm doing a review of maven shared projects now and will do a release 
for this project also.
   > 
   > Any progress, @slachiewicz?
   > 
   > There is a [3.3.2 
tag](https://github.com/apache/maven-filtering/releases/tag/maven-filtering-3.3.2),
 but the release did not find its way to Maven Central. Do you know why @gnodet?
   
   The release is still under vote.




> DefaultMavenResourcesFiltering uses BuildContext in a way that fails sometimes
> --
>
> Key: MSHARED-1285
> URL: https://issues.apache.org/jira/browse/MSHARED-1285
> Project: Maven Shared Components
>  Issue Type: Bug
>  Components: maven-filtering
>Reporter: Christoph Läubrich
>Assignee: Elliotte Rusty Harold
>Priority: Major
> Fix For: maven-filtering-3.3.2
>
>
> The maven resources plugin uses 
> [https://github.com/apache/maven-filtering/blob/master/src/main/java/org/apache/maven/shared/filtering/DefaultMavenResourcesFiltering.java]
>  to copy resources, but that component has some subtile flaws reported here:
> [https://github.com/eclipse-m2e/m2e-core/discussions/1468]
> The problematic part is the usage of BuildContext#newScanner that already 
> mentions in the javadoc that passing ignoreDelta to neScanner might not 
> reveal all required items +*for copy-resources*+ form A -> B and instead 
> BuildContext#isUpTodate should be used.
> Just from a quick look I assume that part of code actually wants to use 
> something like this:
> {code:java}
> DirectoryScanner ds = new DirectoryScanner() {
>   @Override
>   protected boolean isSelected(String name, File file) {
> if (file.isFile() && buildContext.isUptodate(getTargetFile(file), file)) 
> { 
>  return false;
> }
> return true;
>   }
> };
> ds.setBasedir(basedir); {code}
> That way all the code that currently checks for if output directory existed 
> before can also be removed what is another issue because it leads to a full 
> resources copy even if source+target are already even if a single class file 
> is changed while the idea seems more that if the output was not there it 
> should not try to be incremental!



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


Re: [PR] [MSHARED-1285] use an up-to-date scanner instead the newscanner [maven-filtering]

2024-03-08 Thread via GitHub


gnodet commented on PR #77:
URL: https://github.com/apache/maven-filtering/pull/77#issuecomment-1985677119

   > > I'm doing a review of maven shared projects now and will do a release 
for this project also.
   > 
   > Any progress, @slachiewicz?
   > 
   > There is a [3.3.2 
tag](https://github.com/apache/maven-filtering/releases/tag/maven-filtering-3.3.2),
 but the release did not find its way to Maven Central. Do you know why @gnodet?
   
   The release is still under vote.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[jira] [Commented] (MGPG-111) Clean upn dependency declarations

2024-03-08 Thread Elliotte Rusty Harold (Jira)


[ 
https://issues.apache.org/jira/browse/MGPG-111?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17824784#comment-17824784
 ] 

Elliotte Rusty Harold commented on MGPG-111:


I don't. These reports also help figure out where maven-dependency-analyzer has 
issues that need to be fixed. The "dependency grouping" pattern is interesting. 
I haven't encountered that before. I'll have to look into it. Do note that 
junix-socket common is reported as used but undeclared, so perhaps it does need 
to be declared.

plexus-sec-dispatcher and plexus-cipher I'm not sure about. It sounds like 
there might be a better way to handle this.

If maven-resolver-impl is used in test, then perhaps the scope is wrong or 
perhaps this is a bug in maven-dependency-analyzer. I know it's had problems 
with test dependencies before.



> Clean upn dependency declarations
> -
>
> Key: MGPG-111
> URL: https://issues.apache.org/jira/browse/MGPG-111
> Project: Maven GPG Plugin
>  Issue Type: Dependency upgrade
>Reporter: Elliotte Rusty Harold
>Priority: Minor
>
> [WARNING] Used undeclared dependencies found:
> [WARNING]org.apache.maven:maven-artifact:jar:3.9.6:provided
> [WARNING]org.apache.maven:maven-settings:jar:3.9.6:provided
> [WARNING]com.kohlschutter.junixsocket:junixsocket-common:jar:2.9.0:compile
> [WARNING]org.apache.maven.resolver:maven-resolver-impl:jar:1.9.18:provided
> [WARNING] Unused declared dependencies found:
> [WARNING]com.kohlschutter.junixsocket:junixsocket-core:pom:2.9.0:compile
> [WARNING]org.codehaus.plexus:plexus-cipher:jar:2.0:compile



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[PR] Clarify effect of depMgmt on plugin dependencies [maven-site]

2024-03-08 Thread via GitHub


kwin opened a new pull request, #500:
URL: https://github.com/apache/maven-site/pull/500

   Add section on depMgmt to POM reference


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[jira] [Commented] (MGPG-111) Clean upn dependency declarations

2024-03-08 Thread Tamas Cservenak (Jira)


[ 
https://issues.apache.org/jira/browse/MGPG-111?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17824770#comment-17824770
 ] 

Tamas Cservenak commented on MGPG-111:
--

Please, do not blindly follow these (broken anyway) reports.

Explanations:
 * junixsocket is clearly _used_ but analyzer is dumb enough to miss the thing: 
they release a POM that is "dependency grouping" pattern, so POM that is 
"unused" actually brings in common that IS used
 * plexus-sec-dispatcher and plexus-cipher (reported as "unused") MUST be 
declared in pair, once to align them, and secondly to EXCLUDE whatever they 
want to pull in (a LOT of cruft, even things like old guice)
 * maven-resolver-impl is used in test, so I kinda accept this

The only "real" issues (2 out of 6, not bad)
 * maven-artifact, used but undeclared (but only ArtifactHandler, while myself 
consider everything else in there as deprecated, which actually mostly is)
 * maven-settings, used but undeclared

> Clean upn dependency declarations
> -
>
> Key: MGPG-111
> URL: https://issues.apache.org/jira/browse/MGPG-111
> Project: Maven GPG Plugin
>  Issue Type: Dependency upgrade
>Reporter: Elliotte Rusty Harold
>Priority: Minor
>
> [WARNING] Used undeclared dependencies found:
> [WARNING]org.apache.maven:maven-artifact:jar:3.9.6:provided
> [WARNING]org.apache.maven:maven-settings:jar:3.9.6:provided
> [WARNING]com.kohlschutter.junixsocket:junixsocket-common:jar:2.9.0:compile
> [WARNING]org.apache.maven.resolver:maven-resolver-impl:jar:1.9.18:provided
> [WARNING] Unused declared dependencies found:
> [WARNING]com.kohlschutter.junixsocket:junixsocket-core:pom:2.9.0:compile
> [WARNING]org.codehaus.plexus:plexus-cipher:jar:2.0:compile



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Created] (MGPG-111) Clean upn dependency declarations

2024-03-08 Thread Elliotte Rusty Harold (Jira)
Elliotte Rusty Harold created MGPG-111:
--

 Summary: Clean upn dependency declarations
 Key: MGPG-111
 URL: https://issues.apache.org/jira/browse/MGPG-111
 Project: Maven GPG Plugin
  Issue Type: Dependency upgrade
Reporter: Elliotte Rusty Harold


[WARNING] Used undeclared dependencies found:
[WARNING]org.apache.maven:maven-artifact:jar:3.9.6:provided
[WARNING]org.apache.maven:maven-settings:jar:3.9.6:provided
[WARNING]com.kohlschutter.junixsocket:junixsocket-common:jar:2.9.0:compile
[WARNING]org.apache.maven.resolver:maven-resolver-impl:jar:1.9.18:provided
[WARNING] Unused declared dependencies found:
[WARNING]com.kohlschutter.junixsocket:junixsocket-core:pom:2.9.0:compile
[WARNING]org.codehaus.plexus:plexus-cipher:jar:2.0:compile



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Closed] (DOXIASITETOOLS-331) Upgrade to htmlunit 3.11.0

2024-03-08 Thread Michael Osipov (Jira)


 [ 
https://issues.apache.org/jira/browse/DOXIASITETOOLS-331?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Michael Osipov closed DOXIASITETOOLS-331.
-
Resolution: Fixed

Fixed with 
[897c947e765746a43952d5c09d3f7dcfcfed40f9|https://gitbox.apache.org/repos/asf?p=maven-doxia-sitetools.git;a=commit;h=897c947e765746a43952d5c09d3f7dcfcfed40f9].

> Upgrade to htmlunit 3.11.0
> --
>
> Key: DOXIASITETOOLS-331
> URL: https://issues.apache.org/jira/browse/DOXIASITETOOLS-331
> Project: Maven Doxia Sitetools
>  Issue Type: Dependency upgrade
>Reporter: Michael Osipov
>Assignee: Michael Osipov
>Priority: Major
> Fix For: 2.0.0, 2.0.0-M17
>
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)


Re: [PR] Bump org.htmlunit:htmlunit from 3.9.0 to 3.11.0 [maven-doxia-sitetools]

2024-03-08 Thread via GitHub


dependabot[bot] commented on PR #137:
URL: 
https://github.com/apache/maven-doxia-sitetools/pull/137#issuecomment-1985420719

   OK, I won't notify you again about this release, but will get in touch when 
a new version is available. If you'd rather skip all updates until the next 
major or minor version, let me know by commenting `@dependabot ignore this 
major version` or `@dependabot ignore this minor version`. You can also ignore 
all major, minor, or patch releases for a dependency by adding an [`ignore` 
condition](https://docs.github.com/en/code-security/supply-chain-security/configuration-options-for-dependency-updates#ignore)
 with the desired `update_types` to your config file.
   
   If you change your mind, just re-open this PR and I'll resolve any conflicts 
on it.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] Bump org.htmlunit:htmlunit from 3.9.0 to 3.11.0 [maven-doxia-sitetools]

2024-03-08 Thread via GitHub


asfgit closed pull request #137: Bump org.htmlunit:htmlunit from 3.9.0 to 3.11.0
URL: https://github.com/apache/maven-doxia-sitetools/pull/137


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[jira] [Created] (DOXIASITETOOLS-331) Upgrade to htmlunit 3.11.0

2024-03-08 Thread Michael Osipov (Jira)
Michael Osipov created DOXIASITETOOLS-331:
-

 Summary: Upgrade to htmlunit 3.11.0
 Key: DOXIASITETOOLS-331
 URL: https://issues.apache.org/jira/browse/DOXIASITETOOLS-331
 Project: Maven Doxia Sitetools
  Issue Type: Dependency upgrade
Reporter: Michael Osipov
Assignee: Michael Osipov
 Fix For: 2.0.0, 2.0.0-M17






--
This message was sent by Atlassian Jira
(v8.20.10#820010)


Re: [PR] Bump apache/maven-gh-actions-shared from 3 to 4 [maven-doxia-sitetools]

2024-03-08 Thread via GitHub


michael-o merged PR #138:
URL: https://github.com/apache/maven-doxia-sitetools/pull/138


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[jira] [Commented] (MNGSITE-533) Add Sentry Maven Skin to the list of available skins for Maven Site plugin

2024-03-08 Thread ASF GitHub Bot (Jira)


[ 
https://issues.apache.org/jira/browse/MNGSITE-533?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17824708#comment-17824708
 ] 

ASF GitHub Bot commented on MNGSITE-533:


michael-o closed pull request #498: [MNGSITE-533] Add Sentry Maven Skin
URL: https://github.com/apache/maven-site/pull/498




> Add Sentry Maven Skin to the list of available skins for Maven Site plugin
> --
>
> Key: MNGSITE-533
> URL: https://issues.apache.org/jira/browse/MNGSITE-533
> Project: Maven Project Web Site
>  Issue Type: Improvement
>Reporter: Bertrand Martin
>Assignee: Michael Osipov
>Priority: Major
>
> h1. Requested improvement
> Add [Sentry Maven Skin|https://sentrysoftware.org/sentry-maven-skin/] in the 
> list of available skins for the Maven Site plugin (outside the Maven world).
> h1. Specifications
> Update `content/apt/skins/index.apt` to list this new skin.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (MNGSITE-533) Add Sentry Maven Skin to the list of available skins for Maven Site plugin

2024-03-08 Thread ASF GitHub Bot (Jira)


[ 
https://issues.apache.org/jira/browse/MNGSITE-533?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17824709#comment-17824709
 ] 

ASF GitHub Bot commented on MNGSITE-533:


michael-o commented on PR #498:
URL: https://github.com/apache/maven-site/pull/498#issuecomment-1985412482

   Merged with 756a4592b44b232343d2cb1a4eebf37f46b220be




> Add Sentry Maven Skin to the list of available skins for Maven Site plugin
> --
>
> Key: MNGSITE-533
> URL: https://issues.apache.org/jira/browse/MNGSITE-533
> Project: Maven Project Web Site
>  Issue Type: Improvement
>Reporter: Bertrand Martin
>Assignee: Michael Osipov
>Priority: Major
>
> h1. Requested improvement
> Add [Sentry Maven Skin|https://sentrysoftware.org/sentry-maven-skin/] in the 
> list of available skins for the Maven Site plugin (outside the Maven world).
> h1. Specifications
> Update `content/apt/skins/index.apt` to list this new skin.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


Re: [PR] [MNGSITE-533] Add Sentry Maven Skin [maven-site]

2024-03-08 Thread via GitHub


michael-o commented on PR #498:
URL: https://github.com/apache/maven-site/pull/498#issuecomment-1985412482

   Merged with 756a4592b44b232343d2cb1a4eebf37f46b220be


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] [MNGSITE-533] Add Sentry Maven Skin [maven-site]

2024-03-08 Thread via GitHub


michael-o closed pull request #498: [MNGSITE-533] Add Sentry Maven Skin
URL: https://github.com/apache/maven-site/pull/498


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[jira] [Closed] (MNGSITE-533) Add Sentry Maven Skin to the list of available skins for Maven Site plugin

2024-03-08 Thread Michael Osipov (Jira)


 [ 
https://issues.apache.org/jira/browse/MNGSITE-533?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Michael Osipov closed MNGSITE-533.
--
  Assignee: Michael Osipov
Resolution: Fixed

Fixed with 
[756a4592b44b232343d2cb1a4eebf37f46b220be|https://gitbox.apache.org/repos/asf?p=maven-site.git;a=commit;h=756a4592b44b232343d2cb1a4eebf37f46b220be].

> Add Sentry Maven Skin to the list of available skins for Maven Site plugin
> --
>
> Key: MNGSITE-533
> URL: https://issues.apache.org/jira/browse/MNGSITE-533
> Project: Maven Project Web Site
>  Issue Type: Improvement
>Reporter: Bertrand Martin
>Assignee: Michael Osipov
>Priority: Major
>
> h1. Requested improvement
> Add [Sentry Maven Skin|https://sentrysoftware.org/sentry-maven-skin/] in the 
> list of available skins for the Maven Site plugin (outside the Maven world).
> h1. Specifications
> Update `content/apt/skins/index.apt` to list this new skin.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


Re: [PR] Maven 4.0.0-alpha-13 release notes [maven-site]

2024-03-08 Thread via GitHub


gnodet commented on PR #499:
URL: https://github.com/apache/maven-site/pull/499#issuecomment-1985393718

   > And now I don't get something: at least looks fishy to me: when I compare 
repository-metadata 1.1.0 (current metadata) and 1.2.0 (generated by Maven4) I 
see some changes. Most of them are "comment text changes", BUT there are some 
ordering changes as well (but no structural).
   > 
   > So Maven4 deploys repository-metadata 1.2.0? What will Maven3 do with it? 
But again, I see no structural changes between XSD 1.1.0 and 1.2.0... structure 
wise they look same to me, unless "version=1.2.0" does not makes Maven3 belly 
up. Should not this simply remain model version 1.1.0 w/ "updated 
comments/descriptions"?
   
   The 1.2.0 comes from the new immutable model afaik, there’s a need to switch 
to a different version so that we can have both v3 and v4 models. I don’t think 
there’s any real change to the schema though.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[jira] [Commented] (MSHARED-1285) DefaultMavenResourcesFiltering uses BuildContext in a way that fails sometimes

2024-03-08 Thread ASF GitHub Bot (Jira)


[ 
https://issues.apache.org/jira/browse/MSHARED-1285?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17824697#comment-17824697
 ] 

ASF GitHub Bot commented on MSHARED-1285:
-

OLibutzki commented on PR #77:
URL: https://github.com/apache/maven-filtering/pull/77#issuecomment-1985381882

   > I'm doing a review of maven shared projects now and will do a release for 
this project also.
   
   Any progress, @slachiewicz?




> DefaultMavenResourcesFiltering uses BuildContext in a way that fails sometimes
> --
>
> Key: MSHARED-1285
> URL: https://issues.apache.org/jira/browse/MSHARED-1285
> Project: Maven Shared Components
>  Issue Type: Bug
>  Components: maven-filtering
>Reporter: Christoph Läubrich
>Assignee: Elliotte Rusty Harold
>Priority: Major
> Fix For: maven-filtering-3.3.2
>
>
> The maven resources plugin uses 
> [https://github.com/apache/maven-filtering/blob/master/src/main/java/org/apache/maven/shared/filtering/DefaultMavenResourcesFiltering.java]
>  to copy resources, but that component has some subtile flaws reported here:
> [https://github.com/eclipse-m2e/m2e-core/discussions/1468]
> The problematic part is the usage of BuildContext#newScanner that already 
> mentions in the javadoc that passing ignoreDelta to neScanner might not 
> reveal all required items +*for copy-resources*+ form A -> B and instead 
> BuildContext#isUpTodate should be used.
> Just from a quick look I assume that part of code actually wants to use 
> something like this:
> {code:java}
> DirectoryScanner ds = new DirectoryScanner() {
>   @Override
>   protected boolean isSelected(String name, File file) {
> if (file.isFile() && buildContext.isUptodate(getTargetFile(file), file)) 
> { 
>  return false;
> }
> return true;
>   }
> };
> ds.setBasedir(basedir); {code}
> That way all the code that currently checks for if output directory existed 
> before can also be removed what is another issue because it leads to a full 
> resources copy even if source+target are already even if a single class file 
> is changed while the idea seems more that if the output was not there it 
> should not try to be incremental!



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


Re: [PR] [MSHARED-1285] use an up-to-date scanner instead the newscanner [maven-filtering]

2024-03-08 Thread via GitHub


OLibutzki commented on PR #77:
URL: https://github.com/apache/maven-filtering/pull/77#issuecomment-1985381882

   > I'm doing a review of maven shared projects now and will do a release for 
this project also.
   
   Any progress, @slachiewicz?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] Maven 4.0.0-alpha-13 release notes [maven-site]

2024-03-08 Thread via GitHub


gnodet commented on PR #499:
URL: https://github.com/apache/maven-site/pull/499#issuecomment-1985381167

   > IIUC, I should do this:
   > 
   > * copy all of these into site `content/resources/xsd`
   > * IF there is a change (git shows file as "edited"), restore original and 
make it alpha-13 suffixed?
   
   Apart from the metadata, the schema should be unchanged or with a new 
version + alpha flag.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] Maven 4.0.0-alpha-13 release notes [maven-site]

2024-03-08 Thread via GitHub


gnodet commented on PR #499:
URL: https://github.com/apache/maven-site/pull/499#issuecomment-1985378176

   > I have following:
   > 
   > ```
   > [cstamas@blondie checkout ((maven-4.0.0-alpha-13))]$ find . -type f | grep 
generated-site | grep .xsd
   > 
./api/maven-api-plugin/target/generated-site/resources/xsd/lifecycle-1.0.0.xsd
   > ./api/maven-api-plugin/target/generated-site/resources/xsd/plugin-2.0.0.xsd
   > 
./api/maven-api-settings/target/generated-site/resources/xsd/settings-1.3.0.xsd
   > ./maven-compat/target/generated-site/resources/xsd/profiles-1.0.0.xsd
   > ./maven-compat/target/generated-site/resources/xsd/paramdoc-1.0.0.xsd
   > 
./maven-embedder/target/generated-site/resources/xsd/core-extensions-1.2.0.xsd
   > ./maven-model/target/generated-site/resources/xsd/maven-4.1.0.xsd
   > 
./maven-repository-metadata/target/generated-site/resources/xsd/repository-metadata-1.2.0.xsd
   > ./maven-settings/target/generated-site/resources/xsd/settings-2.0.0.xsd
   > 
./maven-toolchain-model/target/generated-site/resources/xsd/toolchains-1.1.0.xsd
   > [cstamas@blondie checkout ((maven-4.0.0-alpha-13))]$ 
   > ```
   > 
   > Things like `maven-repository-metadata-1.2.0.xsd` is not even on site... 
do I need to move all these (and sufix alpha-13?)
   
   Is it a public resource ? I guess we don’t know for sure, so maybe publish 
it as alpha-13. AFAIK, old readers and writers don’t care about the namespace, 
but the new ones do (at least, it is reported in the root element).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[jira] [Closed] (MGPG-108) Update plugin site doco

2024-03-08 Thread Tamas Cservenak (Jira)


 [ 
https://issues.apache.org/jira/browse/MGPG-108?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Tamas Cservenak closed MGPG-108.

Resolution: Fixed

> Update plugin site doco
> ---
>
> Key: MGPG-108
> URL: https://issues.apache.org/jira/browse/MGPG-108
> Project: Maven GPG Plugin
>  Issue Type: Task
>Reporter: Tamas Cservenak
>Assignee: Tamas Cservenak
>Priority: Major
> Fix For: 3.2.0
>
>
> Document the latest changes, update examples.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


Re: [PR] [MGPG-105] [MGPG-108] Make plugin backward compat and update site and doco [maven-gpg-plugin]

2024-03-08 Thread via GitHub


cstamas merged PR #77:
URL: https://github.com/apache/maven-gpg-plugin/pull/77


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org