[jira] [Commented] (MSKINS-245) Maven Site 4 will break code highlight of site generated by Markdown
[ https://issues.apache.org/jira/browse/MSKINS-245?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17845647#comment-17845647 ] ASF GitHub Bot commented on MSKINS-245: --- michael-o commented on PR #58: URL: https://github.com/apache/maven-fluido-skin/pull/58#issuecomment-2106023820 This can now reduced to: ```patch diff --git a/src/main/resources/META-INF/maven/site.vm b/src/main/resources/META-INF/maven/site.vm index 5e0604f..26bb876 100644 - > Maven Site 4 will break code highlight of site generated by Markdown > > > Key: MSKINS-245 > URL: https://issues.apache.org/jira/browse/MSKINS-245 > Project: Maven Skins > Issue Type: Bug > Components: Fluido Skin >Reporter: Xavi Lee >Assignee: Konrad Windszus >Priority: Major > Fix For: fluido-2.0.0-M9, fluido-2.0.0 > > Attachments: maven-site-3.png, maven-site-4.png, test-v3.html, > test-v4.html > > > repro repo https://github.com/awxiaoxian2020/code-render-bug > master branch is Maven Site 3 with Fluido skin 1 > v4 branch is Maven Site 4 with Fluido skin 2. > Open their respective `target/site/test.html` files in local to see the > rendered result. -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] [MSKINS-245] Add code highlighting class to every combination [maven-fluido-skin]
michael-o commented on PR #58:
URL: https://github.com/apache/maven-fluido-skin/pull/58#issuecomment-2106023820
This can now reduced to:
```patch
diff --git a/src/main/resources/META-INF/maven/site.vm
b/src/main/resources/META-INF/maven/site.vm
index 5e0604f..26bb876 100644
--- a/src/main/resources/META-INF/maven/site.vm
+++ b/src/main/resources/META-INF/maven/site.vm
@@ -242 +242 @@
-#* *#$bodyContent.replaceAll( '(\r?\n)?', '' ).replaceAll( 'class="bodyTable"', 'class="table
table-striped"' ).replaceAll( 'class="bodyTable bodyTableBorder"',
'class="table table-bordered table-striped"' )
+#* *#$bodyContent.replace( '', '' ).replace( 'class="bodyTable"', 'class="table
table-striped"' ).replace( 'class="bodyTable bodyTableBorder"', 'class="table
table-bordered table-striped"' )
diff --git a/src/main/resources/css/maven-base.css
b/src/main/resources/css/maven-base.css
index 829ef71..5747cd6 100644
--- a/src/main/resources/css/maven-base.css
+++ b/src/main/resources/css/maven-base.css
@@ -33 +33 @@ section > table.table,
-section > div.verbatim {
+section > pre {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Closed] (MSKINS-246) Upgrade plugins and components (in ITs)
[ https://issues.apache.org/jira/browse/MSKINS-246?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov closed MSKINS-246. - Resolution: Fixed Fixed with [1f449b606ab455c61dc25f56e68d371e659bfe90|https://gitbox.apache.org/repos/asf?p=maven-fluido-skin.git;a=commit;h=1f449b606ab455c61dc25f56e68d371e659bfe90]. > Upgrade plugins and components (in ITs) > --- > > Key: MSKINS-246 > URL: https://issues.apache.org/jira/browse/MSKINS-246 > Project: Maven Skins > Issue Type: Dependency upgrade > Components: Fluido Skin >Reporter: Michael Osipov >Assignee: Michael Osipov >Priority: Major > Fix For: fluido-2.0.0-M9, fluido-2.0.0 > > > * Upgrade to Doxia Sitetools 2.0.0-M18 > * Upgrade to Maven Site Plugin 4.0.0-M14 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MSHARED-1392) Upgrade to Parent 42 and Maven 3.6.3
[ https://issues.apache.org/jira/browse/MSHARED-1392?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17845640#comment-17845640 ] ASF GitHub Bot commented on MSHARED-1392: - michael-o opened a new pull request, #22: URL: https://github.com/apache/maven-reporting-exec/pull/22 This closes #22 Approach copied from Maven Doxia Sitetools > Upgrade to Parent 42 and Maven 3.6.3 > > > Key: MSHARED-1392 > URL: https://issues.apache.org/jira/browse/MSHARED-1392 > Project: Maven Shared Components > Issue Type: Dependency upgrade > Components: maven-reporting-api, maven-reporting-exec, > maven-reporting-impl >Reporter: Michael Osipov >Assignee: Michael Osipov >Priority: Major > Fix For: maven-reporting-api-4.0.0, maven-reporting-impl-4.0.0, > maven-reporting-exec-2.0.0, maven-reporting-api-4.0.0-M12, > maven-reporting-impl-4.0.0-M15, maven-reporting-exec-2.0.0-M14 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[PR] [MSHARED-1392] Upgrade to Parent 42 and Maven 3.6.3 [maven-reporting-exec]
michael-o opened a new pull request, #22: URL: https://github.com/apache/maven-reporting-exec/pull/22 This closes #22 Approach copied from Maven Doxia Sitetools -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MSHARED-1392) Upgrade to Parent 42 and Maven 3.6.3
[ https://issues.apache.org/jira/browse/MSHARED-1392?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17845637#comment-17845637 ] ASF GitHub Bot commented on MSHARED-1392: - asfgit closed pull request #40: [MSHARED-1392] Upgrade to Parent 42 and Maven 3.6.3 URL: https://github.com/apache/maven-reporting-impl/pull/40 > Upgrade to Parent 42 and Maven 3.6.3 > > > Key: MSHARED-1392 > URL: https://issues.apache.org/jira/browse/MSHARED-1392 > Project: Maven Shared Components > Issue Type: Dependency upgrade > Components: maven-reporting-api, maven-reporting-exec, > maven-reporting-impl >Reporter: Michael Osipov >Assignee: Michael Osipov >Priority: Major > Fix For: maven-reporting-api-4.0.0, maven-reporting-impl-4.0.0, > maven-reporting-exec-2.0.0, maven-reporting-api-4.0.0-M12, > maven-reporting-impl-4.0.0-M15, maven-reporting-exec-2.0.0-M14 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] Bump org.apache.maven.shared:maven-shared-components from 41 to 42 [maven-reporting-impl]
dependabot[bot] closed pull request #38: Bump org.apache.maven.shared:maven-shared-components from 41 to 42 URL: https://github.com/apache/maven-reporting-impl/pull/38 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump org.apache.maven.shared:maven-shared-components from 41 to 42 [maven-reporting-impl]
dependabot[bot] commented on PR #38: URL: https://github.com/apache/maven-reporting-impl/pull/38#issuecomment-2105999733 Looks like org.apache.maven.shared:maven-shared-components is up-to-date now, so this is no longer needed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MSHARED-1392) Upgrade to Parent 42 and Maven 3.6.3
[ https://issues.apache.org/jira/browse/MSHARED-1392?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17845638#comment-17845638 ] Michael Osipov commented on MSHARED-1392: - Fixed with [7bff1c2ddbe6d196ab71ad196a0367235a694332|https://gitbox.apache.org/repos/asf?p=maven-reporting-impl.git;a=commit;h=7bff1c2ddbe6d196ab71ad196a0367235a694332] for maven-reporting-impl. > Upgrade to Parent 42 and Maven 3.6.3 > > > Key: MSHARED-1392 > URL: https://issues.apache.org/jira/browse/MSHARED-1392 > Project: Maven Shared Components > Issue Type: Dependency upgrade > Components: maven-reporting-api, maven-reporting-exec, > maven-reporting-impl >Reporter: Michael Osipov >Assignee: Michael Osipov >Priority: Major > Fix For: maven-reporting-api-4.0.0, maven-reporting-impl-4.0.0, > maven-reporting-exec-2.0.0, maven-reporting-api-4.0.0-M12, > maven-reporting-impl-4.0.0-M15, maven-reporting-exec-2.0.0-M14 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] Bump org.apache.maven.shared:maven-shared-components from 41 to 42 [maven-reporting-impl]
michael-o commented on PR #38: URL: https://github.com/apache/maven-reporting-impl/pull/38#issuecomment-2105999668 @dependabot rebase -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [MSHARED-1392] Upgrade to Parent 42 and Maven 3.6.3 [maven-reporting-impl]
asfgit closed pull request #40: [MSHARED-1392] Upgrade to Parent 42 and Maven 3.6.3 URL: https://github.com/apache/maven-reporting-impl/pull/40 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (ARCHETYPE-637) PomUtils.addNewModule Pretty-Printing has issue on java 9+
[ https://issues.apache.org/jira/browse/ARCHETYPE-637?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17845629#comment-17845629 ] ASF GitHub Bot commented on ARCHETYPE-637: -- oeiutomo commented on PR #128: URL: https://github.com/apache/maven-archetype/pull/128#issuecomment-2105954687 Hi all.. Thank you for sharing and explain the problem here Me too waiting for the next plugin release..is there any plan to release this changes? Thank you so much > PomUtils.addNewModule Pretty-Printing has issue on java 9+ > -- > > Key: ARCHETYPE-637 > URL: https://issues.apache.org/jira/browse/ARCHETYPE-637 > Project: Maven Archetype > Issue Type: Bug > Components: Generator >Reporter: qxo >Assignee: Tamas Cservenak >Priority: Minor > Fix For: 3.3.0 > > > > *As of Java 9, the _Transformer_ class's pretty-print feature doesn't define > the actual format. Therefore, whitespace-only nodes will be outputted as > well.* This has been discussed in this [JDK bug > ticket|https://bugs.openjdk.java.net/browse/JDK-8262285?attachmentViewMode=list]. > Also, [Java 9's release > note|https://www.oracle.com/java/technologies/javase/9-notes.html] has > explained this in the xml/jaxp section. > *If we want our pretty-print method to always generate the same format under > various Java versions, we need to provide a stylesheet file.* > ref： > [https://bugs.openjdk.java.net/browse/JDK-8262285?attachmentViewMode=list] > > [https://www.baeldung.com/java-pretty-print-xml#pretty-printing-xml-with-the-transformer-class] -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] [ARCHETYPE-637] fix PomUtils.addNewModule Pretty-Printing issue on java 9+ [maven-archetype]
oeiutomo commented on PR #128: URL: https://github.com/apache/maven-archetype/pull/128#issuecomment-2105954687 Hi all.. Thank you for sharing and explain the problem here Me too waiting for the next plugin release..is there any plan to release this changes? Thank you so much -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MASSEMBLY-1030) Manifest entries from archive configuration are not added in final MANIFEST
[
https://issues.apache.org/jira/browse/MASSEMBLY-1030?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17845626#comment-17845626
]
ASF GitHub Bot commented on MASSEMBLY-1030:
---
slawekjaranowski commented on code in PR #205:
URL:
https://github.com/apache/maven-assembly-plugin/pull/205#discussion_r1597465312
##
src/it/projects/mojo-configuration/manifest-with-customEntry-manifest-file/verify.bsh:
##
Review Comment:
I like more groovy for such scripts ... but it is a personal habit
> Manifest entries from archive configuration are not added in final MANIFEST
> ---
>
> Key: MASSEMBLY-1030
> URL: https://issues.apache.org/jira/browse/MASSEMBLY-1030
> Project: Maven Assembly Plugin
> Issue Type: Bug
> Components: manifest
>Affects Versions: 3.7.1
>Reporter: Olivier Lamy
>Assignee: Olivier Lamy
>Priority: Major
> Fix For: 3.7.2
>
>
> given the follow configuration
> {code:java}
>
>
> src/main/assembly/web-bundle.xml
>
>
>
> ${project.build.outputDirectory}/META-INF/MANIFEST.MF
>
> ee10
>
>
> merge
> {code}
> he entries from manifestEntries are not added to MANIFEST file
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
Re: [PR] [MASSEMBLY-1030] Manifest entries from archive configuration are not added in final MANIFEST [maven-assembly-plugin]
slawekjaranowski commented on code in PR #205: URL: https://github.com/apache/maven-assembly-plugin/pull/205#discussion_r1597465312 ## src/it/projects/mojo-configuration/manifest-with-customEntry-manifest-file/verify.bsh: ## Review Comment: I like more groovy for such scripts ... but it is a personal habit -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump m-wrapper-p from 3.2.0 to 3.3.1 [maven-gh-actions-shared]
slawekjaranowski merged PR #101: URL: https://github.com/apache/maven-gh-actions-shared/pull/101 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (MNGSITE-537) Set up CI for the Giothub repo
Elliotte Rusty Harold created MNGSITE-537: - Summary: Set up CI for the Giothub repo Key: MNGSITE-537 URL: https://issues.apache.org/jira/browse/MNGSITE-537 Project: Maven Project Web Site Issue Type: Task Reporter: Elliotte Rusty Harold https://github.com/apache/maven-site/ seems to have no Continuous integration checks. We should set some up. I'm pretty sure I've broken the site build in the past by merging bad code, and if I haven't yet, I will in the future without some guard rails. -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] Bump org.apache.maven.plugins:maven-site-plugin from 4.0.0-M8 to 4.0.0-M14 [maven-site]
elharo merged PR #523: URL: https://github.com/apache/maven-site/pull/523 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MDEP-919) Fix / investigate failed ITs with Maven4
[
https://issues.apache.org/jira/browse/MDEP-919?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17845594#comment-17845594
]
ASF GitHub Bot commented on MDEP-919:
-
slawekjaranowski opened a new pull request, #390:
URL: https://github.com/apache/maven-dependency-plugin/pull/390
(no comment)
> Fix / investigate failed ITs with Maven4
>
>
> Key: MDEP-919
> URL: https://issues.apache.org/jira/browse/MDEP-919
> Project: Maven Dependency Plugin
> Issue Type: Task
>Reporter: Slawomir Jaranowski
>Priority: Major
>
> We still have failed:
> {noformat}
> [ERROR] The following builds failed:
> [ERROR] * tree-multimodule/pom.xml
> [ERROR] * tree-verbose/pom.xml
> [ERROR] * list-repositories/pom.xml
> [ERROR] * tree-verbose-multimodule/pom.xml{noformat}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MINVOKER-307) invoker should also support the @{ } syntax like the surefire plugin
[
https://issues.apache.org/jira/browse/MINVOKER-307?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17845588#comment-17845588
]
ASF GitHub Bot commented on MINVOKER-307:
-
slawekjaranowski opened a new pull request, #241:
URL: https://github.com/apache/maven-invoker-plugin/pull/241
https://issues.apache.org/jira/browse/MINVOKER-307
> invoker should also support the @{ } syntax like the surefire plugin
>
>
> Key: MINVOKER-307
> URL: https://issues.apache.org/jira/browse/MINVOKER-307
> Project: Maven Invoker Plugin
> Issue Type: Improvement
>Affects Versions: 3.3.0
>Reporter: Henning Schmiedehausen
>Assignee: Slawomir Jaranowski
>Priority: Major
> Labels: up-for-grabs
> Fix For: 3.7.0
>
>
> The surefire plugin supports a special `@\{ ... }` syntax to do 'late'
> resolution of maven properties (not at POM evaluation time but at plugin
> execution time). See
> [https://maven.apache.org/surefire/maven-surefire-plugin/test-mojo.html#argLine]
> for details.
>
> It would be great if the invoker plugin would support the same syntax for the
> configuration setting.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Closed] (MINVOKER-367) Bump org.apache.maven.shared:maven-invoker from 3.2.0 to 3.3.0
[ https://issues.apache.org/jira/browse/MINVOKER-367?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Slawomir Jaranowski closed MINVOKER-367. Resolution: Fixed > Bump org.apache.maven.shared:maven-invoker from 3.2.0 to 3.3.0 > -- > > Key: MINVOKER-367 > URL: https://issues.apache.org/jira/browse/MINVOKER-367 > Project: Maven Invoker Plugin > Issue Type: Dependency upgrade >Reporter: Slawomir Jaranowski >Assignee: Slawomir Jaranowski >Priority: Major > Fix For: 3.7.0 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MINVOKER-367) Bump org.apache.maven.shared:maven-invoker from 3.2.0 to 3.3.0
[ https://issues.apache.org/jira/browse/MINVOKER-367?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17845585#comment-17845585 ] ASF GitHub Bot commented on MINVOKER-367: - slawekjaranowski merged PR #240: URL: https://github.com/apache/maven-invoker-plugin/pull/240 > Bump org.apache.maven.shared:maven-invoker from 3.2.0 to 3.3.0 > -- > > Key: MINVOKER-367 > URL: https://issues.apache.org/jira/browse/MINVOKER-367 > Project: Maven Invoker Plugin > Issue Type: Dependency upgrade >Reporter: Slawomir Jaranowski >Assignee: Slawomir Jaranowski >Priority: Major > Fix For: 3.7.0 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] [MINVOKER-367] Bump org.apache.maven.shared:maven-invoker from 3.2.0 to 3.3.0 [maven-invoker-plugin]
slawekjaranowski merged PR #240: URL: https://github.com/apache/maven-invoker-plugin/pull/240 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (MINVOKER-367) Bump org.apache.maven.shared:maven-invoker from 3.2.0 to 3.3.0
Slawomir Jaranowski created MINVOKER-367: Summary: Bump org.apache.maven.shared:maven-invoker from 3.2.0 to 3.3.0 Key: MINVOKER-367 URL: https://issues.apache.org/jira/browse/MINVOKER-367 Project: Maven Invoker Plugin Issue Type: Dependency upgrade Reporter: Slawomir Jaranowski Assignee: Slawomir Jaranowski Fix For: 3.7.0 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[PR] [MDEP-923] Extract copyFile method from AbstractDependencyMojo [maven-dependency-plugin]
slawekjaranowski opened a new pull request, #389: URL: https://github.com/apache/maven-dependency-plugin/pull/389 this method is only needed in CopyMojo and CopyDependenciesMojo so it is not needed in AbstractDependencyMojo -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MDEP-923) Code cleanups
[
https://issues.apache.org/jira/browse/MDEP-923?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17845584#comment-17845584
]
ASF GitHub Bot commented on MDEP-923:
-
slawekjaranowski opened a new pull request, #389:
URL: https://github.com/apache/maven-dependency-plugin/pull/389
this method is only needed in CopyMojo and CopyDependenciesMojo so it is not
needed in AbstractDependencyMojo
> Code cleanups
> -
>
> Key: MDEP-923
> URL: https://issues.apache.org/jira/browse/MDEP-923
> Project: Maven Dependency Plugin
> Issue Type: Task
>Reporter: Slawomir Jaranowski
>Assignee: Slawomir Jaranowski
>Priority: Major
> Fix For: 3.7.0
>
>
> * remove usage of deprecated API where possible
> * cleanup pom after update to 42
> * exclude transitive dependencies on org.apache.maven
> * add {{@project.version@}} in ITs
> * Remove plexus logger from DependencySilentLog
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MDEP-919) Fix / investigate failed ITs with Maven4
[
https://issues.apache.org/jira/browse/MDEP-919?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17845582#comment-17845582
]
ASF GitHub Bot commented on MDEP-919:
-
cstamas commented on PR #386:
URL:
https://github.com/apache/maven-dependency-plugin/pull/386#issuecomment-2105666204
Ok, but am on Fedora 40, not MacOS
> Fix / investigate failed ITs with Maven4
>
>
> Key: MDEP-919
> URL: https://issues.apache.org/jira/browse/MDEP-919
> Project: Maven Dependency Plugin
> Issue Type: Task
>Reporter: Slawomir Jaranowski
>Priority: Major
>
> We still have failed:
> {noformat}
> [ERROR] The following builds failed:
> [ERROR] * tree-multimodule/pom.xml
> [ERROR] * tree-verbose/pom.xml
> [ERROR] * list-repositories/pom.xml
> [ERROR] * tree-verbose-multimodule/pom.xml{noformat}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
Re: [PR] [MDEP-919] Try to fix a list-repositories for Maven 4 [maven-dependency-plugin]
cstamas commented on PR #386: URL: https://github.com/apache/maven-dependency-plugin/pull/386#issuecomment-2105666204 Ok, but am on Fedora 40, not MacOS -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [MDEP-919] Try to fix a list-repositories for Maven 4 [maven-dependency-plugin]
slawekjaranowski commented on PR #386: URL: https://github.com/apache/maven-dependency-plugin/pull/386#issuecomment-2105664165 > With current master (of both, m-dep-p and maven beta1) I have this UT failure: > > ``` > [ERROR] Tests run: 18, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 1.465 s <<< FAILURE! -- in org.apache.maven.plugins.dependency.fromConfiguration.TestUnpackMojo > [ERROR] org.apache.maven.plugins.dependency.fromConfiguration.TestUnpackMojo.testUnpackOverWriteIfNewer -- Time elapsed: 0.050 s <<< FAILURE! > ``` try to re-run, this test is flaky especially on MacOS -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MDEP-919) Fix / investigate failed ITs with Maven4
[
https://issues.apache.org/jira/browse/MDEP-919?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17845580#comment-17845580
]
ASF GitHub Bot commented on MDEP-919:
-
slawekjaranowski commented on PR #386:
URL:
https://github.com/apache/maven-dependency-plugin/pull/386#issuecomment-2105664165
> With current master (of both, m-dep-p and maven beta1) I have this UT
failure:
>
> ```
> [ERROR] Tests run: 18, Failures: 1, Errors: 0, Skipped: 0, Time elapsed:
1.465 s <<< FAILURE!
> Fix / investigate failed ITs with Maven4
>
>
> Key: MDEP-919
> URL: https://issues.apache.org/jira/browse/MDEP-919
> Project: Maven Dependency Plugin
> Issue Type: Task
>Reporter: Slawomir Jaranowski
>Priority: Major
>
> We still have failed:
> {noformat}
> [ERROR] The following builds failed:
> [ERROR] * tree-multimodule/pom.xml
> [ERROR] * tree-verbose/pom.xml
> [ERROR] * list-repositories/pom.xml
> [ERROR] * tree-verbose-multimodule/pom.xml{noformat}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MDEP-919) Fix / investigate failed ITs with Maven4
[
https://issues.apache.org/jira/browse/MDEP-919?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17845579#comment-17845579
]
ASF GitHub Bot commented on MDEP-919:
-
cstamas commented on PR #386:
URL:
https://github.com/apache/maven-dependency-plugin/pull/386#issuecomment-2105663494
With current master (of both, m-dep-p and maven beta1) I have this UT
failure:
```
[ERROR] Tests run: 18, Failures: 1, Errors: 0, Skipped: 0, Time elapsed:
1.465 s <<< FAILURE!
> Fix / investigate failed ITs with Maven4
>
>
> Key: MDEP-919
> URL: https://issues.apache.org/jira/browse/MDEP-919
> Project: Maven Dependency Plugin
> Issue Type: Task
>Reporter: Slawomir Jaranowski
>Priority: Major
>
> We still have failed:
> {noformat}
> [ERROR] The following builds failed:
> [ERROR] * tree-multimodule/pom.xml
> [ERROR] * tree-verbose/pom.xml
> [ERROR] * list-repositories/pom.xml
> [ERROR] * tree-verbose-multimodule/pom.xml{noformat}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
Re: [PR] [MDEP-919] Try to fix a list-repositories for Maven 4 [maven-dependency-plugin]
cstamas commented on PR #386: URL: https://github.com/apache/maven-dependency-plugin/pull/386#issuecomment-2105663494 With current master (of both, m-dep-p and maven beta1) I have this UT failure: ``` [ERROR] Tests run: 18, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 1.465 s <<< FAILURE! -- in org.apache.maven.plugins.dependency.fromConfiguration.TestUnpackMojo [ERROR] org.apache.maven.plugins.dependency.fromConfiguration.TestUnpackMojo.testUnpackOverWriteIfNewer -- Time elapsed: 0.050 s <<< FAILURE! ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MDEP-919) Fix / investigate failed ITs with Maven4
[
https://issues.apache.org/jira/browse/MDEP-919?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17845578#comment-17845578
]
ASF GitHub Bot commented on MDEP-919:
-
cstamas commented on PR #386:
URL:
https://github.com/apache/maven-dependency-plugin/pull/386#issuecomment-2105663152
It does, but it does via "middleman" the Context:
https://github.com/maveniverse/mima/blob/main/runtime/embedded-maven/src/main/java/eu/maveniverse/maven/mima/runtime/maven/MavenRuntime.java#L91
(which in case of Maven Runtime "runs embedded in maven" and project being
present)
> Fix / investigate failed ITs with Maven4
>
>
> Key: MDEP-919
> URL: https://issues.apache.org/jira/browse/MDEP-919
> Project: Maven Dependency Plugin
> Issue Type: Task
>Reporter: Slawomir Jaranowski
>Priority: Major
>
> We still have failed:
> {noformat}
> [ERROR] The following builds failed:
> [ERROR] * tree-multimodule/pom.xml
> [ERROR] * tree-verbose/pom.xml
> [ERROR] * list-repositories/pom.xml
> [ERROR] * tree-verbose-multimodule/pom.xml{noformat}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
Re: [PR] [MDEP-919] Try to fix a list-repositories for Maven 4 [maven-dependency-plugin]
cstamas commented on PR #386: URL: https://github.com/apache/maven-dependency-plugin/pull/386#issuecomment-2105663152 It does, but it does via "middleman" the Context: https://github.com/maveniverse/mima/blob/main/runtime/embedded-maven/src/main/java/eu/maveniverse/maven/mima/runtime/maven/MavenRuntime.java#L91 (which in case of Maven Runtime "runs embedded in maven" and project being present) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (MINVOKER-307) invoker should also support the @{ } syntax like the surefire plugin
[
https://issues.apache.org/jira/browse/MINVOKER-307?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Slawomir Jaranowski updated MINVOKER-307:
-
Fix Version/s: 3.7.0
> invoker should also support the @{ } syntax like the surefire plugin
>
>
> Key: MINVOKER-307
> URL: https://issues.apache.org/jira/browse/MINVOKER-307
> Project: Maven Invoker Plugin
> Issue Type: Improvement
>Affects Versions: 3.3.0
>Reporter: Henning Schmiedehausen
>Assignee: Slawomir Jaranowski
>Priority: Major
> Labels: up-for-grabs
> Fix For: 3.7.0
>
>
> The surefire plugin supports a special `@\{ ... }` syntax to do 'late'
> resolution of maven properties (not at POM evaluation time but at plugin
> execution time). See
> [https://maven.apache.org/surefire/maven-surefire-plugin/test-mojo.html#argLine]
> for details.
>
> It would be great if the invoker plugin would support the same syntax for the
> configuration setting.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Assigned] (MINVOKER-307) invoker should also support the @{ } syntax like the surefire plugin
[
https://issues.apache.org/jira/browse/MINVOKER-307?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Slawomir Jaranowski reassigned MINVOKER-307:
Assignee: Slawomir Jaranowski
> invoker should also support the @{ } syntax like the surefire plugin
>
>
> Key: MINVOKER-307
> URL: https://issues.apache.org/jira/browse/MINVOKER-307
> Project: Maven Invoker Plugin
> Issue Type: Improvement
>Affects Versions: 3.3.0
>Reporter: Henning Schmiedehausen
>Assignee: Slawomir Jaranowski
>Priority: Major
> Labels: up-for-grabs
>
> The surefire plugin supports a special `@\{ ... }` syntax to do 'late'
> resolution of maven properties (not at POM evaluation time but at plugin
> execution time). See
> [https://maven.apache.org/surefire/maven-surefire-plugin/test-mojo.html#argLine]
> for details.
>
> It would be great if the invoker plugin would support the same syntax for the
> configuration setting.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MDEP-919) Fix / investigate failed ITs with Maven4
[
https://issues.apache.org/jira/browse/MDEP-919?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17845577#comment-17845577
]
ASF GitHub Bot commented on MDEP-919:
-
slawekjaranowski commented on PR #386:
URL:
https://github.com/apache/maven-dependency-plugin/pull/386#issuecomment-2105660694
Toolbox propabbly doesn't use a `getProject().getRemoteProjectRepositories()`
https://github.com/maveniverse/mima/blob/main/context/src/main/java/eu/maveniverse/maven/mima/context/ContextOverrides.java#L36
> Fix / investigate failed ITs with Maven4
>
>
> Key: MDEP-919
> URL: https://issues.apache.org/jira/browse/MDEP-919
> Project: Maven Dependency Plugin
> Issue Type: Task
>Reporter: Slawomir Jaranowski
>Priority: Major
>
> We still have failed:
> {noformat}
> [ERROR] The following builds failed:
> [ERROR] * tree-multimodule/pom.xml
> [ERROR] * tree-verbose/pom.xml
> [ERROR] * list-repositories/pom.xml
> [ERROR] * tree-verbose-multimodule/pom.xml{noformat}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
Re: [PR] [MDEP-919] Try to fix a list-repositories for Maven 4 [maven-dependency-plugin]
slawekjaranowski commented on PR #386: URL: https://github.com/apache/maven-dependency-plugin/pull/386#issuecomment-2105660694 Toolbox propabbly doesn't use a `getProject().getRemoteProjectRepositories()` https://github.com/maveniverse/mima/blob/main/context/src/main/java/eu/maveniverse/maven/mima/context/ContextOverrides.java#L36 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MDEP-919) Fix / investigate failed ITs with Maven4
[
https://issues.apache.org/jira/browse/MDEP-919?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17845575#comment-17845575
]
ASF GitHub Bot commented on MDEP-919:
-
slawekjaranowski commented on PR #386:
URL:
https://github.com/apache/maven-dependency-plugin/pull/386#issuecomment-2105659462
> @slawekjaranowski how to reproduce? Is this m-dep-p IT?
Yes, there is `src/it/projects/list-repositories`
> Fix / investigate failed ITs with Maven4
>
>
> Key: MDEP-919
> URL: https://issues.apache.org/jira/browse/MDEP-919
> Project: Maven Dependency Plugin
> Issue Type: Task
>Reporter: Slawomir Jaranowski
>Priority: Major
>
> We still have failed:
> {noformat}
> [ERROR] The following builds failed:
> [ERROR] * tree-multimodule/pom.xml
> [ERROR] * tree-verbose/pom.xml
> [ERROR] * list-repositories/pom.xml
> [ERROR] * tree-verbose-multimodule/pom.xml{noformat}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
Re: [PR] [MDEP-919] Try to fix a list-repositories for Maven 4 [maven-dependency-plugin]
slawekjaranowski commented on PR #386: URL: https://github.com/apache/maven-dependency-plugin/pull/386#issuecomment-2105659462 > @slawekjaranowski how to reproduce? Is this m-dep-p IT? Yes, there is `src/it/projects/list-repositories` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MSHARED-1392) Upgrade to Parent 42 and Maven 3.6.3
[ https://issues.apache.org/jira/browse/MSHARED-1392?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17845574#comment-17845574 ] ASF GitHub Bot commented on MSHARED-1392: - cstamas commented on PR #40: URL: https://github.com/apache/maven-reporting-impl/pull/40#issuecomment-2105659226 If you check out this: https://github.com/apache/maven/blob/maven-3.9.x/maven-core/src/main/resources/META-INF/maven/extension.xml you will see that same stands for plexus... There is ONE tricky dep: resolver-util IF you don't use it, nothing. IF YOU DO use it, it has to be _compile_ to make compatible with Maven 3.8 and 3.9 (where change happened, as resolver-util became provided as well, it was not in previous versions). > Upgrade to Parent 42 and Maven 3.6.3 > > > Key: MSHARED-1392 > URL: https://issues.apache.org/jira/browse/MSHARED-1392 > Project: Maven Shared Components > Issue Type: Dependency upgrade > Components: maven-reporting-api, maven-reporting-exec, > maven-reporting-impl >Reporter: Michael Osipov >Assignee: Michael Osipov >Priority: Major > Fix For: maven-reporting-api-4.0.0, maven-reporting-impl-4.0.0, > maven-reporting-exec-2.0.0, maven-reporting-api-4.0.0-M12, > maven-reporting-impl-4.0.0-M15, maven-reporting-exec-2.0.0-M14 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] [MSHARED-1392] Upgrade to Parent 42 and Maven 3.6.3 [maven-reporting-impl]
cstamas commented on PR #40: URL: https://github.com/apache/maven-reporting-impl/pull/40#issuecomment-2105659226 If you check out this: https://github.com/apache/maven/blob/maven-3.9.x/maven-core/src/main/resources/META-INF/maven/extension.xml you will see that same stands for plexus... There is ONE tricky dep: resolver-util IF you don't use it, nothing. IF YOU DO use it, it has to be _compile_ to make compatible with Maven 3.8 and 3.9 (where change happened, as resolver-util became provided as well, it was not in previous versions). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MDEP-919) Fix / investigate failed ITs with Maven4
[
https://issues.apache.org/jira/browse/MDEP-919?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17845573#comment-17845573
]
ASF GitHub Bot commented on MDEP-919:
-
cstamas commented on PR #386:
URL:
https://github.com/apache/maven-dependency-plugin/pull/386#issuecomment-2105656773
@slawekjaranowski how to reproduce? Is this m-dep-p IT?
> Fix / investigate failed ITs with Maven4
>
>
> Key: MDEP-919
> URL: https://issues.apache.org/jira/browse/MDEP-919
> Project: Maven Dependency Plugin
> Issue Type: Task
>Reporter: Slawomir Jaranowski
>Priority: Major
>
> We still have failed:
> {noformat}
> [ERROR] The following builds failed:
> [ERROR] * tree-multimodule/pom.xml
> [ERROR] * tree-verbose/pom.xml
> [ERROR] * list-repositories/pom.xml
> [ERROR] * tree-verbose-multimodule/pom.xml{noformat}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
Re: [PR] [MDEP-919] Try to fix a list-repositories for Maven 4 [maven-dependency-plugin]
cstamas commented on PR #386: URL: https://github.com/apache/maven-dependency-plugin/pull/386#issuecomment-2105656773 @slawekjaranowski how to reproduce? Is this m-dep-p IT? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MSHARED-1392) Upgrade to Parent 42 and Maven 3.6.3
[ https://issues.apache.org/jira/browse/MSHARED-1392?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17845572#comment-17845572 ] ASF GitHub Bot commented on MSHARED-1392: - michael-o commented on PR #40: URL: https://github.com/apache/maven-reporting-impl/pull/40#issuecomment-2105655308 @cstamas Changed, please have a look. > Upgrade to Parent 42 and Maven 3.6.3 > > > Key: MSHARED-1392 > URL: https://issues.apache.org/jira/browse/MSHARED-1392 > Project: Maven Shared Components > Issue Type: Dependency upgrade > Components: maven-reporting-api, maven-reporting-exec, > maven-reporting-impl >Reporter: Michael Osipov >Assignee: Michael Osipov >Priority: Major > Fix For: maven-reporting-api-4.0.0, maven-reporting-impl-4.0.0, > maven-reporting-exec-2.0.0, maven-reporting-api-4.0.0-M12, > maven-reporting-impl-4.0.0-M15, maven-reporting-exec-2.0.0-M14 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] [MSHARED-1392] Upgrade to Parent 42 and Maven 3.6.3 [maven-reporting-impl]
michael-o commented on PR #40: URL: https://github.com/apache/maven-reporting-impl/pull/40#issuecomment-2105655308 @cstamas Changed, please have a look. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MSHARED-1392) Upgrade to Parent 42 and Maven 3.6.3
[ https://issues.apache.org/jira/browse/MSHARED-1392?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17845570#comment-17845570 ] ASF GitHub Bot commented on MSHARED-1392: - michael-o commented on PR #40: URL: https://github.com/apache/maven-reporting-impl/pull/40#issuecomment-2105654284 > Anything that executes "like a maven plugin" should have them provided. Now, in case of site/reports am aware you have some intermediate libs that are not plugins, but can execute only in context of plugin/report. > > It does not have to, as "root" dependency will be plugin (or report that is like a plugin) and it will force maven deps into provided anyway (as these intermediate stuff will always be deeper in dep tree). Yes, reporting impl always executes as a Maven Plugin from command line, so provided seems to be right here. > Upgrade to Parent 42 and Maven 3.6.3 > > > Key: MSHARED-1392 > URL: https://issues.apache.org/jira/browse/MSHARED-1392 > Project: Maven Shared Components > Issue Type: Dependency upgrade > Components: maven-reporting-api, maven-reporting-exec, > maven-reporting-impl >Reporter: Michael Osipov >Assignee: Michael Osipov >Priority: Major > Fix For: maven-reporting-api-4.0.0, maven-reporting-impl-4.0.0, > maven-reporting-exec-2.0.0, maven-reporting-api-4.0.0-M12, > maven-reporting-impl-4.0.0-M15, maven-reporting-exec-2.0.0-M14 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] [MSHARED-1392] Upgrade to Parent 42 and Maven 3.6.3 [maven-reporting-impl]
michael-o commented on PR #40: URL: https://github.com/apache/maven-reporting-impl/pull/40#issuecomment-2105654284 > Anything that executes "like a maven plugin" should have them provided. Now, in case of site/reports am aware you have some intermediate libs that are not plugins, but can execute only in context of plugin/report. > > It does not have to, as "root" dependency will be plugin (or report that is like a plugin) and it will force maven deps into provided anyway (as these intermediate stuff will always be deeper in dep tree). Yes, reporting impl always executes as a Maven Plugin from command line, so provided seems to be right here. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MSHARED-1392) Upgrade to Parent 42 and Maven 3.6.3
[ https://issues.apache.org/jira/browse/MSHARED-1392?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17845569#comment-17845569 ] ASF GitHub Bot commented on MSHARED-1392: - cstamas commented on PR #40: URL: https://github.com/apache/maven-reporting-impl/pull/40#issuecomment-2105653241 Anything that executes "like a maven plugin" should have them provided. Now, in case of site/reports am aware you have some intermediate libs that are not plugins, but can execute only in context of plugin/report. It does not have to, as "root" dependency will be plugin (or report that is like a plugin) and it will force maven deps into provided anyway (as these intermediate stuff will always be deeper in dep tree). > Upgrade to Parent 42 and Maven 3.6.3 > > > Key: MSHARED-1392 > URL: https://issues.apache.org/jira/browse/MSHARED-1392 > Project: Maven Shared Components > Issue Type: Dependency upgrade > Components: maven-reporting-api, maven-reporting-exec, > maven-reporting-impl >Reporter: Michael Osipov >Assignee: Michael Osipov >Priority: Major > Fix For: maven-reporting-api-4.0.0, maven-reporting-impl-4.0.0, > maven-reporting-exec-2.0.0, maven-reporting-api-4.0.0-M12, > maven-reporting-impl-4.0.0-M15, maven-reporting-exec-2.0.0-M14 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] [MSHARED-1392] Upgrade to Parent 42 and Maven 3.6.3 [maven-reporting-impl]
cstamas commented on PR #40: URL: https://github.com/apache/maven-reporting-impl/pull/40#issuecomment-2105653241 Anything that executes "like a maven plugin" should have them provided. Now, in case of site/reports am aware you have some intermediate libs that are not plugins, but can execute only in context of plugin/report. It does not have to, as "root" dependency will be plugin (or report that is like a plugin) and it will force maven deps into provided anyway (as these intermediate stuff will always be deeper in dep tree). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MSHARED-1392) Upgrade to Parent 42 and Maven 3.6.3
[ https://issues.apache.org/jira/browse/MSHARED-1392?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17845568#comment-17845568 ] ASF GitHub Bot commented on MSHARED-1392: - michael-o opened a new pull request, #40: URL: https://github.com/apache/maven-reporting-impl/pull/40 @cstamas Can you tell me whether the Maven dependencies should move to `provided` scope? > Upgrade to Parent 42 and Maven 3.6.3 > > > Key: MSHARED-1392 > URL: https://issues.apache.org/jira/browse/MSHARED-1392 > Project: Maven Shared Components > Issue Type: Dependency upgrade > Components: maven-reporting-api, maven-reporting-exec, > maven-reporting-impl >Reporter: Michael Osipov >Assignee: Michael Osipov >Priority: Major > Fix For: maven-reporting-api-4.0.0, maven-reporting-impl-4.0.0, > maven-reporting-exec-2.0.0, maven-reporting-api-4.0.0-M12, > maven-reporting-impl-4.0.0-M15, maven-reporting-exec-2.0.0-M14 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[PR] [MSHARED-1392] Upgrade to Parent 42 and Maven 3.6.3 [maven-reporting-impl]
michael-o opened a new pull request, #40: URL: https://github.com/apache/maven-reporting-impl/pull/40 @cstamas Can you tell me whether the Maven dependencies should move to `provided` scope? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump com.github.luben:zstd-jni from 1.5.6-1 to 1.5.6-3 [maven-assembly-plugin]
dependabot[bot] merged PR #203: URL: https://github.com/apache/maven-assembly-plugin/pull/203 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump org.apache.maven.plugins:maven-plugins from 41 to 42 [maven-assembly-plugin]
dependabot[bot] merged PR #202: URL: https://github.com/apache/maven-assembly-plugin/pull/202 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (MSHARED-1392) Upgrade to Parent 42 and Maven 3.6.3
[ https://issues.apache.org/jira/browse/MSHARED-1392?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov updated MSHARED-1392: Summary: Upgrade to Parent 42 and Maven 3.6.3 (was: Upgrade to Parent 42) > Upgrade to Parent 42 and Maven 3.6.3 > > > Key: MSHARED-1392 > URL: https://issues.apache.org/jira/browse/MSHARED-1392 > Project: Maven Shared Components > Issue Type: Dependency upgrade > Components: maven-reporting-api, maven-reporting-exec, > maven-reporting-impl >Reporter: Michael Osipov >Assignee: Michael Osipov >Priority: Major > Fix For: maven-reporting-api-4.0.0, maven-reporting-impl-4.0.0, > maven-reporting-exec-2.0.0, maven-reporting-api-4.0.0-M12, > maven-reporting-impl-4.0.0-M15, maven-reporting-exec-2.0.0-M14 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (MBUILDCACHE-96) Remove usage of maven-compat
[ https://issues.apache.org/jira/browse/MBUILDCACHE-96?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Olivier Lamy updated MBUILDCACHE-96: Fix Version/s: 1.3.0 > Remove usage of maven-compat > > > Key: MBUILDCACHE-96 > URL: https://issues.apache.org/jira/browse/MBUILDCACHE-96 > Project: Maven Build Cache Extension > Issue Type: Task >Affects Versions: 1.2.0 >Reporter: Olivier Lamy >Assignee: Olivier Lamy >Priority: Major > Fix For: 1.3.0 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (MBUILDCACHE-96) Remove usage of maven-compat
Olivier Lamy created MBUILDCACHE-96: --- Summary: Remove usage of maven-compat Key: MBUILDCACHE-96 URL: https://issues.apache.org/jira/browse/MBUILDCACHE-96 Project: Maven Build Cache Extension Issue Type: Task Affects Versions: 1.2.0 Reporter: Olivier Lamy Assignee: Olivier Lamy -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MDEP-919) Fix / investigate failed ITs with Maven4
[
https://issues.apache.org/jira/browse/MDEP-919?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17845564#comment-17845564
]
ASF GitHub Bot commented on MDEP-919:
-
cstamas commented on PR #386:
URL:
https://github.com/apache/maven-dependency-plugin/pull/386#issuecomment-2105645151
Will take a peek. In the meantime, what does toolbox list-repositories say?
> Fix / investigate failed ITs with Maven4
>
>
> Key: MDEP-919
> URL: https://issues.apache.org/jira/browse/MDEP-919
> Project: Maven Dependency Plugin
> Issue Type: Task
>Reporter: Slawomir Jaranowski
>Priority: Major
>
> We still have failed:
> {noformat}
> [ERROR] The following builds failed:
> [ERROR] * tree-multimodule/pom.xml
> [ERROR] * tree-verbose/pom.xml
> [ERROR] * list-repositories/pom.xml
> [ERROR] * tree-verbose-multimodule/pom.xml{noformat}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MASSEMBLY-1030) Manifest entries from archive configuration are not added in final MANIFEST
[
https://issues.apache.org/jira/browse/MASSEMBLY-1030?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17845563#comment-17845563
]
ASF GitHub Bot commented on MASSEMBLY-1030:
---
olamy opened a new pull request, #205:
URL: https://github.com/apache/maven-assembly-plugin/pull/205
Signed-off-by: Olivier Lamy
Following this checklist to help us incorporate your
contribution quickly and easily:
- [ ] Make sure there is a [JIRA
issue](https://issues.apache.org/jira/browse/MASSEMBLY) filed
for the change (usually before you start working on it). Trivial
changes like typos do not
require a JIRA issue. Your pull request should address just this
issue, without
pulling in other changes.
- [ ] Each commit in the pull request should have a meaningful subject line
and body.
- [ ] Format the pull request title like `[MASSEMBLY-XXX] - Fixes bug in
ApproximateQuantiles`,
where you replace `MASSEMBLY-XXX` with the appropriate JIRA issue.
Best practice
is to use the JIRA issue title in the pull request title and in the
first line of the
commit message.
- [ ] Write a pull request description that is detailed enough to
understand what the pull request does, how, and why.
- [ ] Run `mvn clean verify` to make sure basic checks pass. A more
thorough check will
be performed on your pull request automatically.
- [ ] You have run the integration tests successfully (`mvn -Prun-its clean
verify`).
If your pull request is about ~20 lines of code you don't need to sign an
[Individual Contributor License
Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure
please ask on the developers list.
To make clear that you license your contribution under
the [Apache License Version 2.0, January
2004](http://www.apache.org/licenses/LICENSE-2.0)
you have to acknowledge this by using the following check-box.
- [ ] I hereby declare this contribution to be licenced under the [Apache
License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
- [ ] In any other case, please file an [Apache Individual Contributor
License Agreement](https://www.apache.org/licenses/icla.pdf).
> Manifest entries from archive configuration are not added in final MANIFEST
> ---
>
> Key: MASSEMBLY-1030
> URL: https://issues.apache.org/jira/browse/MASSEMBLY-1030
> Project: Maven Assembly Plugin
> Issue Type: Bug
> Components: manifest
>Affects Versions: 3.7.1
>Reporter: Olivier Lamy
>Assignee: Olivier Lamy
>Priority: Major
> Fix For: 3.7.2
>
>
> given the follow configuration
> {code:java}
>
>
> src/main/assembly/web-bundle.xml
>
>
>
> ${project.build.outputDirectory}/META-INF/MANIFEST.MF
>
> ee10
>
>
> merge
> {code}
> he entries from manifestEntries are not added to MANIFEST file
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Updated] (MASSEMBLY-1030) Manifest entries from archive configuration are not added in final MANIFEST
[
https://issues.apache.org/jira/browse/MASSEMBLY-1030?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Olivier Lamy updated MASSEMBLY-1030:
Summary: Manifest entries from archive configuration are not added in final
MANIFEST (was: Manifest entries from archive configuration are not added )
> Manifest entries from archive configuration are not added in final MANIFEST
> ---
>
> Key: MASSEMBLY-1030
> URL: https://issues.apache.org/jira/browse/MASSEMBLY-1030
> Project: Maven Assembly Plugin
> Issue Type: Bug
> Components: manifest
>Affects Versions: 3.7.1
>Reporter: Olivier Lamy
>Assignee: Olivier Lamy
>Priority: Major
> Fix For: 3.7.2
>
>
> given the follow configuration
> {code:java}
>
>
> src/main/assembly/web-bundle.xml
>
>
>
> ${project.build.outputDirectory}/META-INF/MANIFEST.MF
>
> ee10
>
>
> merge
> {code}
> he entries from manifestEntries are not added to MANIFEST file
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
Re: [PR] [MDEP-919] Try to fix a list-repositories for Maven 4 [maven-dependency-plugin]
cstamas commented on PR #386: URL: https://github.com/apache/maven-dependency-plugin/pull/386#issuecomment-2105645151 Will take a peek. In the meantime, what does toolbox list-repositories say? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] [MASSEMBLY-1030] Manifest entries from archive configuration are not added in final MANIFEST [maven-assembly-plugin]
olamy opened a new pull request, #205: URL: https://github.com/apache/maven-assembly-plugin/pull/205 Signed-off-by: Olivier Lamy Following this checklist to help us incorporate your contribution quickly and easily: - [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/MASSEMBLY) filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes. - [ ] Each commit in the pull request should have a meaningful subject line and body. - [ ] Format the pull request title like `[MASSEMBLY-XXX] - Fixes bug in ApproximateQuantiles`, where you replace `MASSEMBLY-XXX` with the appropriate JIRA issue. Best practice is to use the JIRA issue title in the pull request title and in the first line of the commit message. - [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [ ] Run `mvn clean verify` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically. - [ ] You have run the integration tests successfully (`mvn -Prun-its clean verify`). If your pull request is about ~20 lines of code you don't need to sign an [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure please ask on the developers list. To make clear that you license your contribution under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) you have to acknowledge this by using the following check-box. - [ ] I hereby declare this contribution to be licenced under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) - [ ] In any other case, please file an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [MSHARED-1393] Allow to exclude classes from verification [maven-dependency-analyzer]
slawekjaranowski merged PR #118: URL: https://github.com/apache/maven-dependency-analyzer/pull/118 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Closed] (MSHARED-1393) Allow to exclude classes from verification - revert MSHARED-1248
[ https://issues.apache.org/jira/browse/MSHARED-1393?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Slawomir Jaranowski closed MSHARED-1393. Resolution: Fixed > Allow to exclude classes from verification - revert MSHARED-1248 > > > Key: MSHARED-1393 > URL: https://issues.apache.org/jira/browse/MSHARED-1393 > Project: Maven Shared Components > Issue Type: New Feature > Components: maven-dependency-analyzer >Reporter: Slawomir Jaranowski >Assignee: Slawomir Jaranowski >Priority: Major > Fix For: maven-dependency-analyzer-1.14.0 > > > In some situation project can contains corrupted classes. > Instead of skip it with only warning like in: MSHARED-1248 we should have > possibility to skip only known corrupted classes - not all. > When we skip all - we can stop analyzing anything when asm does not support > next byte code version. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MSHARED-1393) Allow to exclude classes from verification - revert MSHARED-1248
[ https://issues.apache.org/jira/browse/MSHARED-1393?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17845554#comment-17845554 ] ASF GitHub Bot commented on MSHARED-1393: - slawekjaranowski merged PR #118: URL: https://github.com/apache/maven-dependency-analyzer/pull/118 > Allow to exclude classes from verification - revert MSHARED-1248 > > > Key: MSHARED-1393 > URL: https://issues.apache.org/jira/browse/MSHARED-1393 > Project: Maven Shared Components > Issue Type: New Feature > Components: maven-dependency-analyzer >Reporter: Slawomir Jaranowski >Assignee: Slawomir Jaranowski >Priority: Major > Fix For: maven-dependency-analyzer-1.14.0 > > > In some situation project can contains corrupted classes. > Instead of skip it with only warning like in: MSHARED-1248 we should have > possibility to skip only known corrupted classes - not all. > When we skip all - we can stop analyzing anything when asm does not support > next byte code version. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MSOURCES-148) The plugin should respect the --update-dependencies for final versions
[
https://issues.apache.org/jira/browse/MSOURCES-148?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17845552#comment-17845552
]
Slawomir Jaranowski commented on MSOURCES-148:
--
[~bmuschko] Can you show an example project?
The Maven plugins does not support cli arguments ... it is recognized by Maven
executing
But I don't see an argument {{--update-dependencies}} for Maven ... where you
use such argument?
> The plugin should respect the --update-dependencies for final versions
> --
>
> Key: MSOURCES-148
> URL: https://issues.apache.org/jira/browse/MSOURCES-148
> Project: Maven Source Plugin
> Issue Type: New Feature
>Reporter: Benjamin Muschko
>Priority: Major
>
> Executing the build with the flag {{--update-dependencies}} should only
> update SNAPSHOT dependencies. The plugin doesn't seem to evaluate this flag.
> Running the build with the flag will update SNAPSHOT _and_ final dependencies
> leading to a much longer build time.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Updated] (MINVOKER-351) Prevent XML-prohibited characters from entering JUnit report
[
https://issues.apache.org/jira/browse/MINVOKER-351?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Slawomir Jaranowski updated MINVOKER-351:
-
Fix Version/s: waiting-for-feedback
> Prevent XML-prohibited characters from entering JUnit report
>
>
> Key: MINVOKER-351
> URL: https://issues.apache.org/jira/browse/MINVOKER-351
> Project: Maven Invoker Plugin
> Issue Type: Improvement
>Reporter: Mikkel Kjeldsen
>Priority: Major
> Fix For: waiting-for-feedback
>
>
> Neither the Maven Invoker plugin's implementation of {{}}
> nor the underlying XML infrastructure directly protect against the presence
> of character literals prohibited by the XML specification, meaning such
> literals can appear in the JUnit report and render it unreadable. *I would
> appreciate if the Maven Invoker plugin could learn to strip prohibited
> literals to protect its users from creative plugins.* I argue that this is a
> safe and expected transformation that is not materially lossy.
>
> h2. Background
> MINVOKER-196 added the {{}} option [back in
> maven-invoker-plugin-3.2.1|https://github.com/apache/maven-invoker-plugin/blob/maven-invoker-plugin-3.2.1/src/main/java/org/apache/maven/plugins/invoker/AbstractInvokerMojo.java#L1878-L1946].
> As of [maven-invoker-plugin-3.6.0 the effective implementation of the JUnit
> report remains effectively
> unchanged|https://github.com/apache/maven-invoker-plugin/blob/maven-invoker-plugin-3.6.0/src/main/java/org/apache/maven/plugins/invoker/AbstractInvokerMojo.java#L1695-L1754].
> The JUnit report includes a {{}} element ([example
> documentation|https://github.com/testmoapp/junitxml]) whose value Maven
> Invoker populates with the raw build log contents. I've observed that this
> value is XML-escaped, which I imagine is well understood in the
> implementation, although I can't immediately find documentation to support
> that.
> However, escaping notwithstanding, a number of character literals are
> outright prohibited by the XML specifications. These literals cannot be
> escaped, and their presence renders an XML document not well formed. The
> exact set of prohibited characters varies by XML version; the report produced
> by the Maven Invoker plugin is XML version 1.0. When the Maven Invoker plugin
> reads in the build log it does not strip these character literals and neither
> does the XML writer the Maven Invoker plugin relies on. Consequently, if a
> build log ends up including a prohibited character the resulting JUnit report
> will not be well formed.
> The set of prohibited characters is the complement of [the XML
> specification's definition of {{Char}}|https://www.w3.org/TR/xml/#NT-Char].
> h2. Example
> Among the literals prohibited by XML version 1.0 is {{^H}} (backspace). When
> [pitest runs via Maven|https://pitest.org/quickstart/maven/] it prints a
> spinner to standard out, and the implementation uses backspace to render the
> spinner in place. I have used the Maven Invoker plugin with
> {{}} to verify a pitest configuration, whereby I discovered
> this limitation.
> h2. Remediation
> h3. Blame plugins
> Perhaps pitest should not behave this way but we can't change pitest, and
> even if pitest could be changed that offers no protection against any other
> plugin, so blaming plugins is an ineffective course of action.
> h3. Work-arounds
> The user can manually clean the build log in-place via
> {{}}. This is technically fairly easy to do, and makes
> the transformation very explicit, but it requires considerable local work to
> address an issue many would find obscure and the transformation is
> permanently lossy unless the user also backs up the raw log to another file
> name.
> h3. Strip prohibited literals inside Maven Invoker plugin
> If the Maven Invoker plugin learns to strip offending character literals
> in-between reading the build log and writing to the {{}} value
> then {{}} will Just Work™, which I assert is what a user
> will typically expect. Although the {{}} value will no longer
> exactly match the build log contents, this lossy translation is acceptable:
> the prohibited characters are overwhelmingly unprintable to begin with and
> therefore cannot be meaningfully rendered in a static context, and the raw
> build log remains unchanged in the event that the user needs to investigate
> or assert against the raw output.
> This change would be backwards compatible, because any existing user that
> would be affected by it would already have unparseable JUnit reports.
> * I _believe_ that Java's {{j.u.r.Pattern}} can trivially express the
> complement of allowed characters but there may exist more efficient solutions.
> * Consider also applying this transformation to the 2 uses of
>
[jira] [Commented] (MINVOKER-351) Prevent XML-prohibited characters from entering JUnit report
[
https://issues.apache.org/jira/browse/MINVOKER-351?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17845549#comment-17845549
]
Slawomir Jaranowski commented on MINVOKER-351:
--
[~mkjeldsen] please provide a simple project which can reproduce it
> Prevent XML-prohibited characters from entering JUnit report
>
>
> Key: MINVOKER-351
> URL: https://issues.apache.org/jira/browse/MINVOKER-351
> Project: Maven Invoker Plugin
> Issue Type: Improvement
>Reporter: Mikkel Kjeldsen
>Priority: Major
>
> Neither the Maven Invoker plugin's implementation of {{}}
> nor the underlying XML infrastructure directly protect against the presence
> of character literals prohibited by the XML specification, meaning such
> literals can appear in the JUnit report and render it unreadable. *I would
> appreciate if the Maven Invoker plugin could learn to strip prohibited
> literals to protect its users from creative plugins.* I argue that this is a
> safe and expected transformation that is not materially lossy.
>
> h2. Background
> MINVOKER-196 added the {{}} option [back in
> maven-invoker-plugin-3.2.1|https://github.com/apache/maven-invoker-plugin/blob/maven-invoker-plugin-3.2.1/src/main/java/org/apache/maven/plugins/invoker/AbstractInvokerMojo.java#L1878-L1946].
> As of [maven-invoker-plugin-3.6.0 the effective implementation of the JUnit
> report remains effectively
> unchanged|https://github.com/apache/maven-invoker-plugin/blob/maven-invoker-plugin-3.6.0/src/main/java/org/apache/maven/plugins/invoker/AbstractInvokerMojo.java#L1695-L1754].
> The JUnit report includes a {{}} element ([example
> documentation|https://github.com/testmoapp/junitxml]) whose value Maven
> Invoker populates with the raw build log contents. I've observed that this
> value is XML-escaped, which I imagine is well understood in the
> implementation, although I can't immediately find documentation to support
> that.
> However, escaping notwithstanding, a number of character literals are
> outright prohibited by the XML specifications. These literals cannot be
> escaped, and their presence renders an XML document not well formed. The
> exact set of prohibited characters varies by XML version; the report produced
> by the Maven Invoker plugin is XML version 1.0. When the Maven Invoker plugin
> reads in the build log it does not strip these character literals and neither
> does the XML writer the Maven Invoker plugin relies on. Consequently, if a
> build log ends up including a prohibited character the resulting JUnit report
> will not be well formed.
> The set of prohibited characters is the complement of [the XML
> specification's definition of {{Char}}|https://www.w3.org/TR/xml/#NT-Char].
> h2. Example
> Among the literals prohibited by XML version 1.0 is {{^H}} (backspace). When
> [pitest runs via Maven|https://pitest.org/quickstart/maven/] it prints a
> spinner to standard out, and the implementation uses backspace to render the
> spinner in place. I have used the Maven Invoker plugin with
> {{}} to verify a pitest configuration, whereby I discovered
> this limitation.
> h2. Remediation
> h3. Blame plugins
> Perhaps pitest should not behave this way but we can't change pitest, and
> even if pitest could be changed that offers no protection against any other
> plugin, so blaming plugins is an ineffective course of action.
> h3. Work-arounds
> The user can manually clean the build log in-place via
> {{}}. This is technically fairly easy to do, and makes
> the transformation very explicit, but it requires considerable local work to
> address an issue many would find obscure and the transformation is
> permanently lossy unless the user also backs up the raw log to another file
> name.
> h3. Strip prohibited literals inside Maven Invoker plugin
> If the Maven Invoker plugin learns to strip offending character literals
> in-between reading the build log and writing to the {{}} value
> then {{}} will Just Work™, which I assert is what a user
> will typically expect. Although the {{}} value will no longer
> exactly match the build log contents, this lossy translation is acceptable:
> the prohibited characters are overwhelmingly unprintable to begin with and
> therefore cannot be meaningfully rendered in a static context, and the raw
> build log remains unchanged in the event that the user needs to investigate
> or assert against the raw output.
> This change would be backwards compatible, because any existing user that
> would be affected by it would already have unparseable JUnit reports.
> * I _believe_ that Java's {{j.u.r.Pattern}} can trivially express the
> complement of allowed characters but there may exist more efficient solutions.
> * Consider also applying this transformation to the 2
[jira] [Updated] (MINVOKER-348) Build job report is truncated
[
https://issues.apache.org/jira/browse/MINVOKER-348?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Slawomir Jaranowski updated MINVOKER-348:
-
Fix Version/s: waiting-for-feedback
> Build job report is truncated
> -
>
> Key: MINVOKER-348
> URL: https://issues.apache.org/jira/browse/MINVOKER-348
> Project: Maven Invoker Plugin
> Issue Type: Bug
>Affects Versions: 3.5.1
>Reporter: Alvaro Sanchez-Mariscal
>Priority: Major
> Fix For: waiting-for-feedback
>
> Attachments: BUILD-test-resources.xml, build.log
>
>
> The build-job.xml generated for a project is truncated:
> {code:xml}
>
> result="failure-post-hook" time="42.662"
> buildlog="/Users/alvaro/Dev/micronaut-projects/micronaut-maven-plugin/target/it/test-resources/build.log">
> Assertion failed:
> assert log.text.contains("BUILD SUCCESS")
>| ||
>| |false
>| '[INFO] Error stacktraces are turned on.\n[INFO] Scanning for
> projects...\n[WARNING] This build will only read from the build cache, since
> the clean lifecycle is not part of the build invocation.\n[INFO] \n[INFO]
> -
> {code}
> Examining the build output, it gets truncated after a {{<}} appears, which is
> replaced in the XML with {{}};, but then nothing else. Snippet following
> {noformat}
> [INFO] Error stacktraces are turned on.\n[INFO] Scanning for
> projects...\n[WARNING] This build will only read from the build cache, since
> the clean lifecycle is not part of the build invocation.\n[INFO] \n[INFO]
> -< io.micronaut.build.examples:test-resources
> >-\n[INFO]
> {noformat}
> Then, the verify mojo crashes when reading such file:
> {noformat}
> [ERROR] Failed to execute goal
> org.apache.maven.plugins:maven-invoker-plugin:3.5.1:verify (integration-test)
> on project micronaut-maven-integration-tests: Failed to read report file:
> /Users/alvaro/Dev/micronaut-projects/micronaut-maven-plugin/micronaut-maven-integration-tests/target/invoker-reports/BUILD-test-resources.xml:
> no more data available - expected end tags to
> close start tag from line 3 and start tag from
> line 2, parser stopped on START_TAG seen ...t part of the build
> invocation.\n[INFO] \n[INFO] -... @8:242 -> [Help 1]
> {noformat}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MINVOKER-348) Build job report is truncated
[
https://issues.apache.org/jira/browse/MINVOKER-348?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17845547#comment-17845547
]
Slawomir Jaranowski commented on MINVOKER-348:
--
[~alvaro.sanchez] can you provide a simple project which can reproduce it?
> Build job report is truncated
> -
>
> Key: MINVOKER-348
> URL: https://issues.apache.org/jira/browse/MINVOKER-348
> Project: Maven Invoker Plugin
> Issue Type: Bug
>Affects Versions: 3.5.1
>Reporter: Alvaro Sanchez-Mariscal
>Priority: Major
> Attachments: BUILD-test-resources.xml, build.log
>
>
> The build-job.xml generated for a project is truncated:
> {code:xml}
>
> result="failure-post-hook" time="42.662"
> buildlog="/Users/alvaro/Dev/micronaut-projects/micronaut-maven-plugin/target/it/test-resources/build.log">
> Assertion failed:
> assert log.text.contains("BUILD SUCCESS")
>| ||
>| |false
>| '[INFO] Error stacktraces are turned on.\n[INFO] Scanning for
> projects...\n[WARNING] This build will only read from the build cache, since
> the clean lifecycle is not part of the build invocation.\n[INFO] \n[INFO]
> -
> {code}
> Examining the build output, it gets truncated after a {{<}} appears, which is
> replaced in the XML with {{}};, but then nothing else. Snippet following
> {noformat}
> [INFO] Error stacktraces are turned on.\n[INFO] Scanning for
> projects...\n[WARNING] This build will only read from the build cache, since
> the clean lifecycle is not part of the build invocation.\n[INFO] \n[INFO]
> -< io.micronaut.build.examples:test-resources
> >-\n[INFO]
> {noformat}
> Then, the verify mojo crashes when reading such file:
> {noformat}
> [ERROR] Failed to execute goal
> org.apache.maven.plugins:maven-invoker-plugin:3.5.1:verify (integration-test)
> on project micronaut-maven-integration-tests: Failed to read report file:
> /Users/alvaro/Dev/micronaut-projects/micronaut-maven-plugin/micronaut-maven-integration-tests/target/invoker-reports/BUILD-test-resources.xml:
> no more data available - expected end tags to
> close start tag from line 3 and start tag from
> line 2, parser stopped on START_TAG seen ...t part of the build
> invocation.\n[INFO] \n[INFO] -... @8:242 -> [Help 1]
> {noformat}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[PR] Bump org.apache.maven.shared:maven-invoker from 3.2.0 to 3.3.0 [maven-invoker-plugin]
dependabot[bot] opened a new pull request, #240: URL: https://github.com/apache/maven-invoker-plugin/pull/240 Bumps [org.apache.maven.shared:maven-invoker](https://github.com/apache/maven-invoker) from 3.2.0 to 3.3.0. Release notes Sourced from https://github.com/apache/maven-invoker/releases;>org.apache.maven.shared:maven-invoker's releases. 3.3.0 New features and improvements https://issues.apache.org/jira/browse/MSHARED-1390;>[MSHARED-1390] - Deprecate InvocationRequest#setGoals (https://redirect.github.com/apache/maven-invoker/pull/76;>#76) https://github.com/slawekjaranowski;>@slawekjaranowski https://issues.apache.org/jira/browse/MSHARED-1382;>[MSHARED-1382] - support a possibility to disable snapshots update. (https://redirect.github.com/apache/maven-invoker/pull/74;>#74) https://github.com/lrozenblyum;>@lrozenblyum https://issues.apache.org/jira/browse/MSHARED-1150;>[MSHARED-1150] - Add ps1 as detectable file type for PowerShell (https://redirect.github.com/apache/maven-invoker/pull/55;>#55) https://github.com/iofit;>@iofit Bug Fixes https://issues.apache.org/jira/browse/MSHARED-971;>[MSHARED-971] - Add test for inherited environment (https://redirect.github.com/apache/maven-invoker/pull/79;>#79) https://github.com/slawekjaranowski;>@slawekjaranowski Dependency updates https://issues.apache.org/jira/browse/MSHARED-1388;>[MSHARED-1388] - Bump org.apache.maven.shared:maven-shared-components from 41 to 42 (https://redirect.github.com/apache/maven-invoker/pull/73;>#73) https://github.com/dependabot;>@dependabot Bump apache/maven-gh-actions-shared from 3 to 4 (https://redirect.github.com/apache/maven-invoker/pull/72;>#72) https://github.com/dependabot;>@dependabot Bump org.junit:junit-bom from 5.10.1 to 5.10.2 (https://redirect.github.com/apache/maven-invoker/pull/71;>#71) https://github.com/dependabot;>@dependabot Bump org.apache.maven.shared:maven-shared-components from 39 to 41 (https://redirect.github.com/apache/maven-invoker/pull/70;>#70) https://github.com/dependabot;>@dependabot Bump org.junit:junit-bom from 5.10.0 to 5.10.1 (https://redirect.github.com/apache/maven-invoker/pull/69;>#69) https://github.com/dependabot;>@dependabot https://issues.apache.org/jira/browse/MSHARED-1305;>[MSHARED-1305] - update maven-shared-utils to 3.4.2 (https://redirect.github.com/apache/maven-invoker/pull/65;>#65) https://github.com/elharo;>@elharo Bump org.junit:junit-bom from 5.9.2 to 5.10.0 (https://redirect.github.com/apache/maven-invoker/pull/64;>#64) https://github.com/dependabot;>@dependabot Bump junit-bom from 5.9.1 to 5.9.2 (https://redirect.github.com/apache/maven-invoker/pull/60;>#60) https://github.com/dependabot;>@dependabot https://issues.apache.org/jira/browse/MSHARED-1151;>[MSHARED-1151] - Upgrade parent to version 39 (https://redirect.github.com/apache/maven-invoker/pull/58;>#58) https://github.com/psiroky;>@psiroky Bump maven-pmd-plugin from 3.16.0 to 3.18.0 (https://redirect.github.com/apache/maven-invoker/pull/52;>#52) https://github.com/dependabot;>@dependabot Maintenance https://issues.apache.org/jira/browse/MSHARED-1152;>[MSHARED-1152] - Remove public modifier for JUnit5 tests (https://redirect.github.com/apache/maven-invoker/pull/77;>#77) https://github.com/slawekjaranowski;>@slawekjaranowski https://issues.apache.org/jira/browse/MSHARED-1391;>[MSHARED-1391] - Code cleanups (https://redirect.github.com/apache/maven-invoker/pull/78;>#78) https://github.com/slawekjaranowski;>@slawekjaranowski https://issues.apache.org/jira/browse/MSHARED-1389;>[MSHARED-1389] - Refresh download page (https://redirect.github.com/apache/maven-invoker/pull/75;>#75) https://github.com/slawekjaranowski;>@slawekjaranowski Bump org.junit:junit-bom from 5.10.1 to 5.10.2 (https://redirect.github.com/apache/maven-invoker/pull/71;>#71) https://github.com/dependabot;>@dependabot https://issues.apache.org/jira/browse/MSHARED-1307;>[MSHARED-1307] - systemProperties is deprecated: Use systemPropertyVari… (https://redirect.github.com/apache/maven-invoker/pull/68;>#68) https://github.com/elharo;>@elharo https://issues.apache.org/jira/browse/MSHARED-1306;>[MSHARED-1306] - Use fixtures to reduce duplicate code (https://redirect.github.com/apache/maven-invoker/pull/67;>#67) https://github.com/elharo;>@elharo https://issues.apache.org/jira/browse/MSHARED-1306;>[MSHARED-1306] - don't log from passing tests (https://redirect.github.com/apache/maven-invoker/pull/66;>#66) https://github.com/elharo;>@elharo https://issues.apache.org/jira/browse/MNG-6829;>[MNG-6829] - Replace any StringUtils#isEmpty(String) and #isNotEmpty(String) (https://redirect.github.com/apache/maven-invoker/pull/63;>#63) https://github.com/timtebeek;>@timtebeek https://issues.apache.org/jira/browse/MSHARED-1152;>[MSHARED-1152] - Migrate tests to JUnit5
[PR] feat: Specify wrapper version (or latest) [maven-wrapper]
reneleonhardt opened a new pull request, #138: URL: https://github.com/apache/maven-wrapper/pull/138 ### Feature In addition to the wrapped Maven distribution * `-Dmaven=3.9.6` or * `-Dmvnd=0.9.0` support specifying the wrapper version itself with * `-Dversion=3.3.1` This allows using/replacing the wrapper with a specific version, or updating it to * `-Dversion=latest` for example to retrieve (security) fixes or use new features. If a project doesn't want to commit the maven-wrapper.jar, but cache it in a GitHub Action after the automatic download: ``` mvn -N wrapper:wrapper -Dversion=latest -Dtype=script ``` ### Checklist Following this checklist to help us incorporate your contribution quickly and easily: - [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/MWRAPPER) filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes. - [x] Each commit in the pull request should have a meaningful subject line and body. - [ ] Format the pull request title like `[MWRAPPER-XXX] - Fixes bug in ApproximateQuantiles`, where you replace `MWRAPPER-XXX` with the appropriate JIRA issue. Best practice is to use the JIRA issue title in the pull request title and in the first line of the commit message. - [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [x] Run `mvn clean verify` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically. - [x] You have run the integration tests successfully (`mvn -Prun-its clean verify`). If your pull request is about ~20 lines of code you don't need to sign an [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure please ask on the developers list. To make clear that you license your contribution under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) you have to acknowledge this by using the following check-box. - [x] I hereby declare this contribution to be licenced under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) - [ ] In any other case, please file an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
