[PR] Bump org.codehaus.mojo:build-helper-maven-plugin from 3.5.0 to 3.6.0 [maven-checkstyle-plugin]
dependabot[bot] opened a new pull request, #135: URL: https://github.com/apache/maven-checkstyle-plugin/pull/135 Bumps [org.codehaus.mojo:build-helper-maven-plugin](https://github.com/mojohaus/build-helper-maven-plugin) from 3.5.0 to 3.6.0. Release notes Sourced from https://github.com/mojohaus/build-helper-maven-plugin/releases;>org.codehaus.mojo:build-helper-maven-plugin's releases. 3.6.0 Changes New features and improvements Deprecate remove-project-artifact goal (https://redirect.github.com/mojohaus/build-helper-maven-plugin/pull/205;>#205) https://github.com/slawekjaranowski;>@slawekjaranowski Parallel execution of uptodate-properties (https://redirect.github.com/mojohaus/build-helper-maven-plugin/pull/201;>#201) https://github.com/mkarg;>@mkarg Dependency updates Bump org.codehaus.mojo:mojo-parent from 81 to 82 (https://redirect.github.com/mojohaus/build-helper-maven-plugin/pull/206;>#206) https://github.com/dependabot;>@dependabot Bump org.codehaus.mojo:mojo-parent from 78 to 81 (https://redirect.github.com/mojohaus/build-helper-maven-plugin/pull/204;>#204) https://github.com/dependabot;>@dependabot Bump org.codehaus.plexus:plexus-utils from 4.0.0 to 4.0.1 (https://redirect.github.com/mojohaus/build-helper-maven-plugin/pull/202;>#202) https://github.com/dependabot;>@dependabot Bump apache/maven-gh-actions-shared from 3 to 4 (https://redirect.github.com/mojohaus/build-helper-maven-plugin/pull/200;>#200) https://github.com/dependabot;>@dependabot Bump release-drafter/release-drafter from 5 to 6 (https://redirect.github.com/mojohaus/build-helper-maven-plugin/pull/195;>#195) https://github.com/dependabot;>@dependabot Bump org.codehaus.mojo:mojo-parent from 77 to 78 (https://redirect.github.com/mojohaus/build-helper-maven-plugin/pull/193;>#193) https://github.com/dependabot;>@dependabot Maintenance Delete link to remove-project-artifact as is deprecated (https://redirect.github.com/mojohaus/build-helper-maven-plugin/pull/210;>#210) https://github.com/slawekjaranowski;>@slawekjaranowski Cleanups dependencies (https://redirect.github.com/mojohaus/build-helper-maven-plugin/pull/209;>#209) https://github.com/slawekjaranowski;>@slawekjaranowski Remove public modifiers from JUnit 5 tests (https://redirect.github.com/mojohaus/build-helper-maven-plugin/pull/208;>#208) https://github.com/slawekjaranowski;>@slawekjaranowski Delete example about remove-project-artifact as is deprecated (https://redirect.github.com/mojohaus/build-helper-maven-plugin/pull/207;>#207) https://github.com/slawekjaranowski;>@slawekjaranowski Fix goal in usage add-test-resource example (https://redirect.github.com/mojohaus/build-helper-maven-plugin/pull/199;>#199) https://github.com/mfussenegger;>@mfussenegger Build Use shared action for release drafter (https://redirect.github.com/mojohaus/build-helper-maven-plugin/pull/203;>#203) https://github.com/slawekjaranowski;>@slawekjaranowski Commits https://github.com/mojohaus/build-helper-maven-plugin/commit/45494bc6053095b7f42b1fccfb8f230f75d1;>454 [maven-release-plugin] prepare release 3.6.0 https://github.com/mojohaus/build-helper-maven-plugin/commit/05ee2cb17ff155862accaee1fc1b0ea1cae53911;>05ee2cb Delete link to remove-project-artifact as is deprecated https://github.com/mojohaus/build-helper-maven-plugin/commit/a4190d2f634210091031ad27a3a50d626ea37cfa;>a4190d2 Cleanups dependencies https://github.com/mojohaus/build-helper-maven-plugin/commit/b99f6be8c876c012c41d163c832c4b0adfb28356;>b99f6be Remove public modifiers from JUnit 5 tests https://github.com/mojohaus/build-helper-maven-plugin/commit/f21a0272a00f6bb4e6d404817a6c144ac65b2778;>f21a027 Add me as developer https://github.com/mojohaus/build-helper-maven-plugin/commit/211d4b9687c79085c3c036aefc14a8428195eb69;>211d4b9 Delete example about remove-project-artifact as is deprecated https://github.com/mojohaus/build-helper-maven-plugin/commit/27ab33494dffaa5d5f5e9cbbbac4f581e4ed9479;>27ab334 Deprecate remove-project-artifact goal https://github.com/mojohaus/build-helper-maven-plugin/commit/8a4c7c41842082f530775a933ab22088d673fd3c;>8a4c7c4 Bump org.codehaus.mojo:mojo-parent from 81 to 82 https://github.com/mojohaus/build-helper-maven-plugin/commit/57f54801686afb43b3540c597010f0c9857b5901;>57f5480 Bump org.codehaus.mojo:mojo-parent from 78 to 81 (https://redirect.github.com/mojohaus/build-helper-maven-plugin/issues/204;>#204) https://github.com/mojohaus/build-helper-maven-plugin/commit/c09d77946636cf605515c851cd6ede87b94eb81a;>c09d779 Use shared action for release drafter Additional commits viewable in https://github.com/mojohaus/build-helper-maven-plugin/compare/3.5.0...3.6.0;>compare view [![Dependabot compatibility
[PR] Bump org.graalvm.buildtools:native-maven-plugin from 0.10.1 to 0.10.2 [maven-mvnd]
dependabot[bot] opened a new pull request, #996: URL: https://github.com/apache/maven-mvnd/pull/996 Bumps [org.graalvm.buildtools:native-maven-plugin](https://github.com/graalvm/native-build-tools) from 0.10.1 to 0.10.2. Release notes Sourced from https://github.com/graalvm/native-build-tools/releases;>org.graalvm.buildtools:native-maven-plugin's releases. 0.10.2 What's Changed Bump repo version to 0.10.2-SNAPSHOT by https://github.com/dnestoro;>@dnestoro in https://redirect.github.com/graalvm/native-build-tools/pull/578;>graalvm/native-build-tools#578 Update Getting Started with Maven Plugin doc. by https://github.com/olyagpl;>@olyagpl in https://redirect.github.com/graalvm/native-build-tools/pull/577;>graalvm/native-build-tools#577 Update Default Target Directory for MetadataCopy Task by https://github.com/dnestoro;>@dnestoro in https://redirect.github.com/graalvm/native-build-tools/pull/580;>graalvm/native-build-tools#580 Delete old stale args file by https://github.com/n0tl3ss;>@n0tl3ss in https://redirect.github.com/graalvm/native-build-tools/pull/589;>graalvm/native-build-tools#589 fix class path directroy analyzer by https://github.com/n0tl3ss;>@n0tl3ss in https://redirect.github.com/graalvm/native-build-tools/pull/590;>graalvm/native-build-tools#590 Add a parameter to be able to skip build native for pom type modules, leave it as false per default for backward compat by https://github.com/olamy;>@olamy in https://redirect.github.com/graalvm/native-build-tools/pull/593;>graalvm/native-build-tools#593 Update Reachability Metadata repository version by https://github.com/dnestoro;>@dnestoro in https://redirect.github.com/graalvm/native-build-tools/pull/594;>graalvm/native-build-tools#594 New Contributors https://github.com/n0tl3ss;>@n0tl3ss made their first contribution in https://redirect.github.com/graalvm/native-build-tools/pull/589;>graalvm/native-build-tools#589 https://github.com/olamy;>@olamy made their first contribution in https://redirect.github.com/graalvm/native-build-tools/pull/593;>graalvm/native-build-tools#593 Full Changelog: https://github.com/graalvm/native-build-tools/compare/0.10.1...0.10.2;>https://github.com/graalvm/native-build-tools/compare/0.10.1...0.10.2 Commits https://github.com/graalvm/native-build-tools/commit/de7f1dffa4217d82eed4bb99a3099696a20312a3;>de7f1df Bump repo version to 0.10.2 https://github.com/graalvm/native-build-tools/commit/c47f2dc7f08bd2adc4c9e7468657eee753dfe1a2;>c47f2dc Merge pull request https://redirect.github.com/graalvm/native-build-tools/issues/594;>#594 from graalvm/dnestoro/UpdateMetadataVersion https://github.com/graalvm/native-build-tools/commit/892da4f7995be821e06a39d62533047fd145dfa6;>892da4f Update Reachability Metadata repository version https://github.com/graalvm/native-build-tools/commit/9f8dbd02c8d47b201afd67d5b15075d9b050d4c1;>9f8dbd0 Add a parameter to be able to skip build native for pom type modules, leave i... https://github.com/graalvm/native-build-tools/commit/d4b5ce3c4a9fbb27d9f48fcbdbc9bf0a2274e446;>d4b5ce3 fix class path directroy analyzer (https://redirect.github.com/graalvm/native-build-tools/issues/590;>#590) https://github.com/graalvm/native-build-tools/commit/08d4a02809a174c7ea752d1f6cba32b7ec0cf03e;>08d4a02 Merge pull request https://redirect.github.com/graalvm/native-build-tools/issues/589;>#589 from n0tl3ss/stale-files https://github.com/graalvm/native-build-tools/commit/ca05132021e8d2163965362dccdbbdbe4eae7606;>ca05132 code review fixes https://github.com/graalvm/native-build-tools/commit/ca35e20fe3b9e31d773398d2fadb310074053a2c;>ca35e20 trigger build https://github.com/graalvm/native-build-tools/commit/501cf2febc05cce564df99e25d57d4e7e22f;>501 write-args-file task should delete old stale args file before generating a ne... https://github.com/graalvm/native-build-tools/commit/6db59badd557f10d25f852d8f7eedaf30bf0496f;>6db59ba Merge pull request https://redirect.github.com/graalvm/native-build-tools/issues/580;>#580 from dnestoro/dnestoro/SetProperDefaultMetadataCopyDir Additional commits viewable in https://github.com/graalvm/native-build-tools/compare/0.10.1...0.10.2;>compare view [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot
[PR] Bump com.google.code.gson:gson from 2.10.1 to 2.11.0 [maven-indexer]
dependabot[bot] opened a new pull request, #366: URL: https://github.com/apache/maven-indexer/pull/366 Bumps [com.google.code.gson:gson](https://github.com/google/gson) from 2.10.1 to 2.11.0. Commits https://github.com/google/gson/commit/828a97be0f8d58108b140b77df8dc76b657f4a87;>828a97b [maven-release-plugin] prepare release gson-parent-2.11.0 https://github.com/google/gson/commit/93bc0f23a13f9e9df3bf71894d479dbd5d952ba6;>93bc0f2 Skip signing graal-native-test module. (https://redirect.github.com/google/gson/issues/2675;>#2675) https://github.com/google/gson/commit/b153ca18bfef611edff4dbea85de79e153ea4809;>b153ca1 [maven-release-plugin] rollback the release of gson-parent-2.11.0 https://github.com/google/gson/commit/0e3d2aab622fb50addb98b10b0a661cadda0f989;>0e3d2aa [maven-release-plugin] prepare for next development iteration https://github.com/google/gson/commit/545b802d639917c50928ec96bcab49b0c70dbb7a;>545b802 [maven-release-plugin] prepare release gson-parent-2.11.0 https://github.com/google/gson/commit/8bfdbb4e14172b013c3d1f56c3a36812075e2886;>8bfdbb4 Guarantee that JsonElement.toString() produces JSON (https://redirect.github.com/google/gson/issues/2659;>#2659) https://github.com/google/gson/commit/9008b093ac40f226643df17c767357aa1947984a;>9008b09 Extend Troubleshooting Guide with some ProGuard / R8 information (https://redirect.github.com/google/gson/issues/2656;>#2656) https://github.com/google/gson/commit/05652c3b7dea68a9ffc781b2cdf89076fce56b12;>05652c3 Document that other JVM languages are not fully supported (https://redirect.github.com/google/gson/issues/2666;>#2666) https://github.com/google/gson/commit/454a49127f9416f45221eecf311eefdca50e4cdc;>454a491 Improved Long-Double Number Policy (https://redirect.github.com/google/gson/issues/2674;>#2674) https://github.com/google/gson/commit/570d91194e223132982d56b6fa499af15fd7b1ea;>570d911 Bump the github-actions group with 4 updates (https://redirect.github.com/google/gson/issues/2671;>#2671) Additional commits viewable in https://github.com/google/gson/compare/gson-parent-2.10.1...gson-parent-2.11.0;>compare view [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] Bump mavenVersion from 3.6.3 to 3.9.6 [maven-site-plugin]
dependabot[bot] opened a new pull request, #188:
URL: https://github.com/apache/maven-site-plugin/pull/188
Bumps `mavenVersion` from 3.6.3 to 3.9.6.
Updates `org.apache.maven:maven-artifact` from 3.6.3 to 3.9.6
Release notes
Sourced from https://github.com/apache/maven/releases;>org.apache.maven:maven-artifact's
releases.
3.9.6
https://maven.apache.org/docs/3.9.6/release-notes.html;>Release
Notes - Maven - Version 3.9.6
Improvement
[https://issues.apache.org/jira/browse/MNG-7939;>MNG-7939]
- Allow to exclude plugins from validation
Dependency upgrade
[https://issues.apache.org/jira/browse/MNG-7913;>MNG-7913]
- Upgrade Sisu version to 0.9.0.M2
[https://issues.apache.org/jira/browse/MNG-7934;>MNG-7934]
- Upgrade Resolver version to 1.9.18
[https://issues.apache.org/jira/browse/MNG-7942;>MNG-7942]
- Upgrade to parent POM 41
[https://issues.apache.org/jira/browse/MNG-7943;>MNG-7943]
- Upgrade default plugin bindings
3.9.5
https://maven.apache.org/docs/3.9.5/release-notes.html;>Release
Notes - Maven - Version 3.9.5
Bug
[https://issues.apache.org/jira/browse/MNG-7851;>MNG-7851]
- Error message when modelVersion is 4.0 is confusing
Improvement
[https://issues.apache.org/jira/browse/MNG-7875;>MNG-7875]
- colorize transfer messages
[https://issues.apache.org/jira/browse/MNG-7895;>MNG-7895]
- Support ${project.basedir} in file profile activation
Task
[https://issues.apache.org/jira/browse/MNG-7856;>MNG-7856]
- Maven Resolver Provider classes ctor change
[https://issues.apache.org/jira/browse/MNG-7870;>MNG-7870]
- Undeprecate wrongly deprecated repository metadata
[https://issues.apache.org/jira/browse/MNG-7872;>MNG-7872]
- Deprecate org.apache.maven.repository.internal.MavenResolverModule
[https://issues.apache.org/jira/browse/MNG-7874;>MNG-7874]
- maven-resolver-provider: introduce NAME constants.
Dependency upgrade
[https://issues.apache.org/jira/browse/MNG-7859;>MNG-7859]
- Update to Resolver 1.9.16
3.9.4
https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12316922version=12353369;>Release
Notes - Maven - Version 3.9.4
... (truncated)
Commits
https://github.com/apache/maven/commit/bc0240f3c744dd6b6ec2920b3cd08dcc295161ae;>bc0240f
[maven-release-plugin] prepare release maven-3.9.6
https://github.com/apache/maven/commit/e6cc6c53cb979f46e7cf97fc9bab686343500a94;>e6cc6c5
[MNG-7943] Upgrade default plugin bindings
https://github.com/apache/maven/commit/48adee3711705c65918b2c736e88093a052f30f8;>48adee3
[MNG-7934] Update to Resolver 1.9.18 (https://redirect.github.com/apache/maven/issues/1326;>#1326)
https://github.com/apache/maven/commit/da6c7e4bcac34677ad9e7d93f345d9c896866e1b;>da6c7e4
[MNG-7942] Upgrade maven-parent to 41
https://github.com/apache/maven/commit/95fa548e1db672ac7b102ff27585c82ed5ae9ed2;>95fa548
[MNG-7934] Update to Resolver 1.9.17 (https://redirect.github.com/apache/maven/issues/1321;>#1321)
https://github.com/apache/maven/commit/c54baa64b38c09c440a11285d560e47d894b2414;>c54baa6
[MNG-7939] Allow to exclude plugins from validation
https://github.com/apache/maven/commit/ecd59b7158e048a6298b8b52d44fccaba26065ad;>ecd59b7
[MNG-7913] Upgrade Sisu version (https://redirect.github.com/apache/maven/issues/1286;>#1286)
https://github.com/apache/maven/commit/53edd71c989d8f2f2b92ee0b281976772c78b927;>53edd71
Use the same branch name for ITs on Jenkins (https://redirect.github.com/apache/maven/issues/1263;>#1263)
https://github.com/apache/maven/commit/2bc44491af62fef51e17d6ad0172baff82c8d022;>2bc4449
The maven-3.9.x branch should fallback to maven-3.9.x branch of ITs
https://github.com/apache/maven/commit/6e532cd249c0413fb6885ca6dfcc67dce25f703d;>6e532cd
[maven-release-plugin] prepare for next development iteration
Additional commits viewable in https://github.com/apache/maven/compare/maven-3.6.3...maven-3.9.6;>compare
view
Updates `org.apache.maven:maven-compat` from 3.6.3 to 3.9.6
Release notes
Sourced from https://github.com/apache/maven/releases;>org.apache.maven:maven-compat's
releases.
3.9.6
https://maven.apache.org/docs/3.9.6/release-notes.html;>Release
Notes - Maven - Version 3.9.6
Improvement
[https://issues.apache.org/jira/browse/MNG-7939;>MNG-7939]
- Allow to exclude plugins from validation
Dependency upgrade
[https://issues.apache.org/jira/browse/MNG-7913;>MNG-7913]
- Upgrade Sisu version to 0.9.0.M2
[https://issues.apache.org/jira/browse/MNG-7934;>MNG-7934]
- Upgrade Resolver version to 1.9.18
[https://issues.apache.org/jira/browse/MNG-7942;>MNG-7942]
- Upgrade to parent POM 41
[https://issues.apache.org/jira/browse/MNG-7943;>MNG-7943]
- Upgrade default plugin bindings
3.9.5
https://maven.apache.org/docs/3.9.5/release-notes.html;>Release
Notes - Maven - Version 3.9.5
Re: [PR] Bump org.codehaus.mojo:build-helper-maven-plugin from 3.4.0 to 3.5.0 [maven]
dependabot[bot] closed pull request #1516: Bump org.codehaus.mojo:build-helper-maven-plugin from 3.4.0 to 3.5.0 URL: https://github.com/apache/maven/pull/1516 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump org.codehaus.mojo:build-helper-maven-plugin from 3.4.0 to 3.5.0 [maven]
dependabot[bot] commented on PR #1516: URL: https://github.com/apache/maven/pull/1516#issuecomment-2119509137 Superseded by #1526. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] Bump org.codehaus.mojo:build-helper-maven-plugin from 3.4.0 to 3.6.0 [maven]
dependabot[bot] opened a new pull request, #1526: URL: https://github.com/apache/maven/pull/1526 Bumps [org.codehaus.mojo:build-helper-maven-plugin](https://github.com/mojohaus/build-helper-maven-plugin) from 3.4.0 to 3.6.0. Release notes Sourced from https://github.com/mojohaus/build-helper-maven-plugin/releases;>org.codehaus.mojo:build-helper-maven-plugin's releases. 3.6.0 Changes New features and improvements Deprecate remove-project-artifact goal (https://redirect.github.com/mojohaus/build-helper-maven-plugin/pull/205;>#205) https://github.com/slawekjaranowski;>@slawekjaranowski Parallel execution of uptodate-properties (https://redirect.github.com/mojohaus/build-helper-maven-plugin/pull/201;>#201) https://github.com/mkarg;>@mkarg Dependency updates Bump org.codehaus.mojo:mojo-parent from 81 to 82 (https://redirect.github.com/mojohaus/build-helper-maven-plugin/pull/206;>#206) https://github.com/dependabot;>@dependabot Bump org.codehaus.mojo:mojo-parent from 78 to 81 (https://redirect.github.com/mojohaus/build-helper-maven-plugin/pull/204;>#204) https://github.com/dependabot;>@dependabot Bump org.codehaus.plexus:plexus-utils from 4.0.0 to 4.0.1 (https://redirect.github.com/mojohaus/build-helper-maven-plugin/pull/202;>#202) https://github.com/dependabot;>@dependabot Bump apache/maven-gh-actions-shared from 3 to 4 (https://redirect.github.com/mojohaus/build-helper-maven-plugin/pull/200;>#200) https://github.com/dependabot;>@dependabot Bump release-drafter/release-drafter from 5 to 6 (https://redirect.github.com/mojohaus/build-helper-maven-plugin/pull/195;>#195) https://github.com/dependabot;>@dependabot Bump org.codehaus.mojo:mojo-parent from 77 to 78 (https://redirect.github.com/mojohaus/build-helper-maven-plugin/pull/193;>#193) https://github.com/dependabot;>@dependabot Maintenance Delete link to remove-project-artifact as is deprecated (https://redirect.github.com/mojohaus/build-helper-maven-plugin/pull/210;>#210) https://github.com/slawekjaranowski;>@slawekjaranowski Cleanups dependencies (https://redirect.github.com/mojohaus/build-helper-maven-plugin/pull/209;>#209) https://github.com/slawekjaranowski;>@slawekjaranowski Remove public modifiers from JUnit 5 tests (https://redirect.github.com/mojohaus/build-helper-maven-plugin/pull/208;>#208) https://github.com/slawekjaranowski;>@slawekjaranowski Delete example about remove-project-artifact as is deprecated (https://redirect.github.com/mojohaus/build-helper-maven-plugin/pull/207;>#207) https://github.com/slawekjaranowski;>@slawekjaranowski Fix goal in usage add-test-resource example (https://redirect.github.com/mojohaus/build-helper-maven-plugin/pull/199;>#199) https://github.com/mfussenegger;>@mfussenegger Build Use shared action for release drafter (https://redirect.github.com/mojohaus/build-helper-maven-plugin/pull/203;>#203) https://github.com/slawekjaranowski;>@slawekjaranowski 3.5.0 Changes New features and improvements Add skipIfMissing flag (https://redirect.github.com/mojohaus/build-helper-maven-plugin/pull/187;>#187) https://github.com/hgschmie;>@hgschmie Add skip flags (https://redirect.github.com/mojohaus/build-helper-maven-plugin/pull/186;>#186) https://github.com/hgschmie;>@hgschmie Deprecate maven-version goal (https://redirect.github.com/mojohaus/build-helper-maven-plugin/pull/191;>#191) https://github.com/slawekjaranowski;>@slawekjaranowski Dependency updates Bump org.codehaus.mojo:mojo-parent from 76 to 77 (https://redirect.github.com/mojohaus/build-helper-maven-plugin/pull/190;>#190) https://github.com/dependabot;>@dependabot Bump mojo-parent from 75 to 76 (https://redirect.github.com/mojohaus/build-helper-maven-plugin/pull/185;>#185) https://github.com/dependabot;>@dependabot Bump mojo-parent from 74 to 75 (https://redirect.github.com/mojohaus/build-helper-maven-plugin/pull/184;>#184) https://github.com/dependabot;>@dependabot Bump plexus-utils from 3.5.1 to 4.0.0 (https://redirect.github.com/mojohaus/build-helper-maven-plugin/pull/183;>#183) https://github.com/dependabot;>@dependabot Bump maven-plugin-annotations from 3.8.2 to 3.9.0 (https://redirect.github.com/mojohaus/build-helper-maven-plugin/pull/182;>#182) https://github.com/dependabot;>@dependabot Maintenance Use plugins versions from parent in ITs (https://redirect.github.com/mojohaus/build-helper-maven-plugin/pull/192;>#192) https://github.com/slawekjaranowski;>@slawekjaranowski Use Maven Apache shared GitHub action (https://redirect.github.com/mojohaus/build-helper-maven-plugin/pull/189;>#189) https://github.com/slawekjaranowski;>@slawekjaranowski ... (truncated) Commits https://github.com/mojohaus/build-helper-maven-plugin/commit/45494bc6053095b7f42b1fccfb8f230f75d1;>454
[jira] [Commented] (MSKINS-245) Maven Site 4 will break code highlight of site generated by Markdown
[ https://issues.apache.org/jira/browse/MSKINS-245?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17847738#comment-17847738 ] ASF GitHub Bot commented on MSKINS-245: --- kwin commented on PR #58: URL: https://github.com/apache/maven-fluido-skin/pull/58#issuecomment-2119370796 > Should I rebase and merge this? I'd like to start the release Yes, please. > Maven Site 4 will break code highlight of site generated by Markdown > > > Key: MSKINS-245 > URL: https://issues.apache.org/jira/browse/MSKINS-245 > Project: Maven Skins > Issue Type: Bug > Components: Fluido Skin >Reporter: Xavi Lee >Assignee: Konrad Windszus >Priority: Major > Fix For: fluido-2.0.0-M9, fluido-2.0.0 > > Attachments: maven-site-3.png, maven-site-4.png, test-v3.html, > test-v4.html > > > repro repo https://github.com/awxiaoxian2020/code-render-bug > master branch is Maven Site 3 with Fluido skin 1 > v4 branch is Maven Site 4 with Fluido skin 2. > Open their respective `target/site/test.html` files in local to see the > rendered result. -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] [MSKINS-245] Add code highlighting class to every combination [maven-fluido-skin]
kwin commented on PR #58: URL: https://github.com/apache/maven-fluido-skin/pull/58#issuecomment-2119370796 > Should I rebase and merge this? I'd like to start the release Yes, please. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MPMD-395) Build doesn't fail for invalid CPD format
[
https://issues.apache.org/jira/browse/MPMD-395?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17847723#comment-17847723
]
ASF GitHub Bot commented on MPMD-395:
-
michael-o commented on code in PR #150:
URL: https://github.com/apache/maven-pmd-plugin/pull/150#discussion_r1606095807
##
src/main/java/org/apache/maven/plugins/pmd/exec/CpdReportConsumer.java:
##
@@ -0,0 +1,133 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.maven.plugins.pmd.exec;
+
+import java.io.File;
+import java.io.FileOutputStream;
+import java.io.IOException;
+import java.io.OutputStreamWriter;
+import java.io.Writer;
+import java.util.function.Consumer;
+import java.util.function.Predicate;
+
+import net.sourceforge.pmd.cpd.CPDReport;
+import net.sourceforge.pmd.cpd.CPDReportRenderer;
+import net.sourceforge.pmd.cpd.Match;
+import net.sourceforge.pmd.cpd.XMLRenderer;
+import org.apache.maven.plugins.pmd.ExcludeDuplicationsFromFile;
+import org.apache.maven.reporting.MavenReportException;
+import org.codehaus.plexus.util.FileUtils;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+class CpdReportConsumer implements Consumer {
+private static final Logger LOG =
LoggerFactory.getLogger(CpdReportConsumer.class);
+
+private final CpdRequest request;
+private final ExcludeDuplicationsFromFile excludeDuplicationsFromFile;
+private MavenReportException reportException;
+
+CpdReportConsumer(CpdRequest request, ExcludeDuplicationsFromFile
excludeDuplicationsFromFile) {
+this.request = request;
+this.excludeDuplicationsFromFile = excludeDuplicationsFromFile;
+}
+
+@Override
+public void accept(CPDReport report) {
+try {
+// always create XML format. we need to output it even if the file
list is empty or we have no
+// duplications so that the "check" goals can check for violations
+writeXmlReport(report);
+
+// html format is handled by maven site report, xml format has
already been rendered
+// a renderer is only needed for other formats
+String format = request.getFormat();
+if (!"html".equals(format) && !"xml".equals(format)) {
+writeFormattedReport(report);
+}
+} catch (MavenReportException e) {
+// Exceptions happening during this consumer are only logged by
PMD.
+// Remembering the exception here, so that we can rethrow it later
to fail the build.
+reportException = e;
+throw new RuntimeException(e);
+}
+}
+
+private void writeXmlReport(CPDReport cpd) throws MavenReportException {
+File targetFile = writeReport(cpd, new
XMLRenderer(request.getOutputEncoding()), "xml");
+if (request.isIncludeXmlInSite()) {
+File siteDir = new File(request.getReportOutputDirectory());
+siteDir.mkdirs();
+try {
+FileUtils.copyFile(targetFile, new File(siteDir, "cpd.xml"));
+} catch (IOException e) {
+throw new MavenReportException("Error while copying cpd.xml
report to site dir", e);
+}
+}
+}
+
+private void writeFormattedReport(CPDReport cpd) throws
MavenReportException {
+CPDReportRenderer r = CpdExecutor.createRenderer(request.getFormat(),
request.getOutputEncoding());
+writeReport(cpd, r, request.getFormat());
+}
+
+private File writeReport(CPDReport cpd, CPDReportRenderer r, String
extension) throws MavenReportException {
+if (r == null) {
+return null;
+}
+
+File targetDir = new File(request.getTargetDirectory());
+targetDir.mkdirs();
+File targetFile = new File(targetDir, "cpd." + extension);
+try (Writer writer = new OutputStreamWriter(new
FileOutputStream(targetFile), request.getOutputEncoding())) {
+r.render(cpd.filterMatches(filterMatches()), writer);
+writer.flush();
+} catch (IOException ioe) {
+throw new MavenReportException(ioe.getMessage(), ioe);
Review Comment:
Re: [PR] [MPMD-395] Build doesn't fail for invalid CPD format [maven-pmd-plugin]
michael-o commented on code in PR #150:
URL: https://github.com/apache/maven-pmd-plugin/pull/150#discussion_r1606095807
##
src/main/java/org/apache/maven/plugins/pmd/exec/CpdReportConsumer.java:
##
@@ -0,0 +1,133 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.maven.plugins.pmd.exec;
+
+import java.io.File;
+import java.io.FileOutputStream;
+import java.io.IOException;
+import java.io.OutputStreamWriter;
+import java.io.Writer;
+import java.util.function.Consumer;
+import java.util.function.Predicate;
+
+import net.sourceforge.pmd.cpd.CPDReport;
+import net.sourceforge.pmd.cpd.CPDReportRenderer;
+import net.sourceforge.pmd.cpd.Match;
+import net.sourceforge.pmd.cpd.XMLRenderer;
+import org.apache.maven.plugins.pmd.ExcludeDuplicationsFromFile;
+import org.apache.maven.reporting.MavenReportException;
+import org.codehaus.plexus.util.FileUtils;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+class CpdReportConsumer implements Consumer {
+private static final Logger LOG =
LoggerFactory.getLogger(CpdReportConsumer.class);
+
+private final CpdRequest request;
+private final ExcludeDuplicationsFromFile excludeDuplicationsFromFile;
+private MavenReportException reportException;
+
+CpdReportConsumer(CpdRequest request, ExcludeDuplicationsFromFile
excludeDuplicationsFromFile) {
+this.request = request;
+this.excludeDuplicationsFromFile = excludeDuplicationsFromFile;
+}
+
+@Override
+public void accept(CPDReport report) {
+try {
+// always create XML format. we need to output it even if the file
list is empty or we have no
+// duplications so that the "check" goals can check for violations
+writeXmlReport(report);
+
+// html format is handled by maven site report, xml format has
already been rendered
+// a renderer is only needed for other formats
+String format = request.getFormat();
+if (!"html".equals(format) && !"xml".equals(format)) {
+writeFormattedReport(report);
+}
+} catch (MavenReportException e) {
+// Exceptions happening during this consumer are only logged by
PMD.
+// Remembering the exception here, so that we can rethrow it later
to fail the build.
+reportException = e;
+throw new RuntimeException(e);
+}
+}
+
+private void writeXmlReport(CPDReport cpd) throws MavenReportException {
+File targetFile = writeReport(cpd, new
XMLRenderer(request.getOutputEncoding()), "xml");
+if (request.isIncludeXmlInSite()) {
+File siteDir = new File(request.getReportOutputDirectory());
+siteDir.mkdirs();
+try {
+FileUtils.copyFile(targetFile, new File(siteDir, "cpd.xml"));
+} catch (IOException e) {
+throw new MavenReportException("Error while copying cpd.xml
report to site dir", e);
+}
+}
+}
+
+private void writeFormattedReport(CPDReport cpd) throws
MavenReportException {
+CPDReportRenderer r = CpdExecutor.createRenderer(request.getFormat(),
request.getOutputEncoding());
+writeReport(cpd, r, request.getFormat());
+}
+
+private File writeReport(CPDReport cpd, CPDReportRenderer r, String
extension) throws MavenReportException {
+if (r == null) {
+return null;
+}
+
+File targetDir = new File(request.getTargetDirectory());
+targetDir.mkdirs();
+File targetFile = new File(targetDir, "cpd." + extension);
+try (Writer writer = new OutputStreamWriter(new
FileOutputStream(targetFile), request.getOutputEncoding())) {
+r.render(cpd.filterMatches(filterMatches()), writer);
+writer.flush();
+} catch (IOException ioe) {
+throw new MavenReportException(ioe.getMessage(), ioe);
Review Comment:
This duplicates the message...not good
##
src/main/java/org/apache/maven/plugins/pmd/exec/CpdReportConsumer.java:
##
@@ -0,0 +1,133 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or
Re: [PR] Bump org.apache.maven.plugins:maven-plugins from 41 to 42 [maven-site-plugin]
dependabot[bot] closed pull request #181: Bump org.apache.maven.plugins:maven-plugins from 41 to 42 URL: https://github.com/apache/maven-site-plugin/pull/181 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump org.apache.maven.plugins:maven-plugins from 41 to 42 [maven-site-plugin]
dependabot[bot] commented on PR #181: URL: https://github.com/apache/maven-site-plugin/pull/181#issuecomment-2119344630 Looks like org.apache.maven.plugins:maven-plugins is up-to-date now, so this is no longer needed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump org.apache.maven.plugins:maven-plugins from 41 to 42 [maven-site-plugin]
michael-o commented on PR #181: URL: https://github.com/apache/maven-site-plugin/pull/181#issuecomment-2119344483 @dependabot rebase -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MSITE-1008) Upgrade to Parent 42 and Maven 3.6.3
[ https://issues.apache.org/jira/browse/MSITE-1008?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17847718#comment-17847718 ] ASF GitHub Bot commented on MSITE-1008: --- asfgit closed pull request #187: [MSITE-1008] Upgrade to Parent 42 and Maven 3.6.3 URL: https://github.com/apache/maven-site-plugin/pull/187 > Upgrade to Parent 42 and Maven 3.6.3 > > > Key: MSITE-1008 > URL: https://issues.apache.org/jira/browse/MSITE-1008 > Project: Maven Site Plugin > Issue Type: Dependency upgrade >Reporter: Michael Osipov >Assignee: Michael Osipov >Priority: Major > Fix For: 4.0.0, 4.0.0-M15 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Closed] (MSITE-1008) Upgrade to Parent 42 and Maven 3.6.3
[ https://issues.apache.org/jira/browse/MSITE-1008?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov closed MSITE-1008. - Resolution: Fixed Fixed with [deee90af4e539095cfc6f3208db3df1fa9395ed8|https://gitbox.apache.org/repos/asf?p=maven-site-plugin.git;a=commit;h=deee90af4e539095cfc6f3208db3df1fa9395ed8]. > Upgrade to Parent 42 and Maven 3.6.3 > > > Key: MSITE-1008 > URL: https://issues.apache.org/jira/browse/MSITE-1008 > Project: Maven Site Plugin > Issue Type: Dependency upgrade >Reporter: Michael Osipov >Assignee: Michael Osipov >Priority: Major > Fix For: 4.0.0, 4.0.0-M15 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MSITE-1008) Upgrade to Parent 42 and Maven 3.6.3
[ https://issues.apache.org/jira/browse/MSITE-1008?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17847719#comment-17847719 ] ASF GitHub Bot commented on MSITE-1008: --- asfgit merged PR #187: URL: https://github.com/apache/maven-site-plugin/pull/187 > Upgrade to Parent 42 and Maven 3.6.3 > > > Key: MSITE-1008 > URL: https://issues.apache.org/jira/browse/MSITE-1008 > Project: Maven Site Plugin > Issue Type: Dependency upgrade >Reporter: Michael Osipov >Assignee: Michael Osipov >Priority: Major > Fix For: 4.0.0, 4.0.0-M15 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] [MSITE-1008] Upgrade to Parent 42 and Maven 3.6.3 [maven-site-plugin]
asfgit merged PR #187: URL: https://github.com/apache/maven-site-plugin/pull/187 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [MSITE-1008] Upgrade to Parent 42 and Maven 3.6.3 [maven-site-plugin]
asfgit closed pull request #187: [MSITE-1008] Upgrade to Parent 42 and Maven 3.6.3 URL: https://github.com/apache/maven-site-plugin/pull/187 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MSITE-1008) Upgrade to Parent 42 and Maven 3.6.3
[ https://issues.apache.org/jira/browse/MSITE-1008?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17847717#comment-17847717 ] ASF GitHub Bot commented on MSITE-1008: --- michael-o commented on PR #187: URL: https://github.com/apache/maven-site-plugin/pull/187#issuecomment-2119337439 Will take care of the failure... > Upgrade to Parent 42 and Maven 3.6.3 > > > Key: MSITE-1008 > URL: https://issues.apache.org/jira/browse/MSITE-1008 > Project: Maven Site Plugin > Issue Type: Dependency upgrade >Reporter: Michael Osipov >Assignee: Michael Osipov >Priority: Major > Fix For: 4.0.0, 4.0.0-M15 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MSKINS-245) Maven Site 4 will break code highlight of site generated by Markdown
[ https://issues.apache.org/jira/browse/MSKINS-245?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17847716#comment-17847716 ] ASF GitHub Bot commented on MSKINS-245: --- michael-o commented on PR #58: URL: https://github.com/apache/maven-fluido-skin/pull/58#issuecomment-2119337386 @kwin Should I rebase and merge this? I'd like to start the release. > Maven Site 4 will break code highlight of site generated by Markdown > > > Key: MSKINS-245 > URL: https://issues.apache.org/jira/browse/MSKINS-245 > Project: Maven Skins > Issue Type: Bug > Components: Fluido Skin >Reporter: Xavi Lee >Assignee: Konrad Windszus >Priority: Major > Fix For: fluido-2.0.0-M9, fluido-2.0.0 > > Attachments: maven-site-3.png, maven-site-4.png, test-v3.html, > test-v4.html > > > repro repo https://github.com/awxiaoxian2020/code-render-bug > master branch is Maven Site 3 with Fluido skin 1 > v4 branch is Maven Site 4 with Fluido skin 2. > Open their respective `target/site/test.html` files in local to see the > rendered result. -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] [MSITE-1008] Upgrade to Parent 42 and Maven 3.6.3 [maven-site-plugin]
michael-o commented on PR #187: URL: https://github.com/apache/maven-site-plugin/pull/187#issuecomment-2119337439 Will take care of the failure... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [MSKINS-245] Add code highlighting class to every combination [maven-fluido-skin]
michael-o commented on PR #58: URL: https://github.com/apache/maven-fluido-skin/pull/58#issuecomment-2119337386 @kwin Should I rebase and merge this? I'd like to start the release. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MSITE-1008) Upgrade to Parent 42 and Maven 3.6.3
[ https://issues.apache.org/jira/browse/MSITE-1008?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17847714#comment-17847714 ] ASF GitHub Bot commented on MSITE-1008: --- michael-o commented on PR #187: URL: https://github.com/apache/maven-site-plugin/pull/187#issuecomment-211959 @slawekjaranowski Good catches! > Upgrade to Parent 42 and Maven 3.6.3 > > > Key: MSITE-1008 > URL: https://issues.apache.org/jira/browse/MSITE-1008 > Project: Maven Site Plugin > Issue Type: Dependency upgrade >Reporter: Michael Osipov >Assignee: Michael Osipov >Priority: Major > Fix For: 4.0.0, 4.0.0-M15 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] [MSITE-1008] Upgrade to Parent 42 and Maven 3.6.3 [maven-site-plugin]
michael-o commented on PR #187: URL: https://github.com/apache/maven-site-plugin/pull/187#issuecomment-211959 @slawekjaranowski Good catches! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MSITE-1008) Upgrade to Parent 42 and Maven 3.6.3
[ https://issues.apache.org/jira/browse/MSITE-1008?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17847713#comment-17847713 ] ASF GitHub Bot commented on MSITE-1008: --- slawekjaranowski commented on PR #187: URL: https://github.com/apache/maven-site-plugin/pull/187#issuecomment-2119329596 Please also fix in Jenkinsfile Maven versions > Upgrade to Parent 42 and Maven 3.6.3 > > > Key: MSITE-1008 > URL: https://issues.apache.org/jira/browse/MSITE-1008 > Project: Maven Site Plugin > Issue Type: Dependency upgrade >Reporter: Michael Osipov >Assignee: Michael Osipov >Priority: Major > Fix For: 4.0.0, 4.0.0-M15 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] [MSITE-1008] Upgrade to Parent 42 and Maven 3.6.3 [maven-site-plugin]
slawekjaranowski commented on PR #187: URL: https://github.com/apache/maven-site-plugin/pull/187#issuecomment-2119329596 Please also fix in Jenkinsfile Maven versions -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MSITE-1008) Upgrade to Parent 42 and Maven 3.6.3
[ https://issues.apache.org/jira/browse/MSITE-1008?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17847712#comment-17847712 ] ASF GitHub Bot commented on MSITE-1008: --- slawekjaranowski commented on PR #187: URL: https://github.com/apache/maven-site-plugin/pull/187#issuecomment-2119329149 There is: ```xml org.apache.maven maven-parent 39 ``` In: src/it/projects/full-reporting/pom.xml and test fails > Upgrade to Parent 42 and Maven 3.6.3 > > > Key: MSITE-1008 > URL: https://issues.apache.org/jira/browse/MSITE-1008 > Project: Maven Site Plugin > Issue Type: Dependency upgrade >Reporter: Michael Osipov >Assignee: Michael Osipov >Priority: Major > Fix For: 4.0.0, 4.0.0-M15 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] [MSITE-1008] Upgrade to Parent 42 and Maven 3.6.3 [maven-site-plugin]
slawekjaranowski commented on PR #187: URL: https://github.com/apache/maven-site-plugin/pull/187#issuecomment-2119329149 There is: ```xml org.apache.maven maven-parent 39 ``` In: src/it/projects/full-reporting/pom.xml and test fails -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MSITE-1008) Upgrade to Parent 42 and Maven 3.6.3
[ https://issues.apache.org/jira/browse/MSITE-1008?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17847708#comment-17847708 ] ASF GitHub Bot commented on MSITE-1008: --- michael-o opened a new pull request, #187: URL: https://github.com/apache/maven-site-plugin/pull/187 This closes #187 Following this checklist to help us incorporate your contribution quickly and easily: - [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/MSITE) filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes. - [ ] Each commit in the pull request should have a meaningful subject line and body. - [ ] Format the pull request title like `[MSITE-XXX] - Fixes bug in ApproximateQuantiles`, where you replace `MSITE-XXX` with the appropriate JIRA issue. Best practice is to use the JIRA issue title in the pull request title and in the first line of the commit message. - [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [ ] Run `mvn clean verify` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically. - [ ] You have run the integration tests successfully (`mvn -Prun-its clean verify`). If your pull request is about ~20 lines of code you don't need to sign an [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure please ask on the developers list. To make clear that you license your contribution under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) you have to acknowledge this by using the following check-box. - [ ] I hereby declare this contribution to be licenced under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) - [ ] In any other case, please file an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). > Upgrade to Parent 42 and Maven 3.6.3 > > > Key: MSITE-1008 > URL: https://issues.apache.org/jira/browse/MSITE-1008 > Project: Maven Site Plugin > Issue Type: Dependency upgrade >Reporter: Michael Osipov >Assignee: Michael Osipov >Priority: Major > Fix For: 4.0.0, 4.0.0-M15 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[PR] [MSITE-1008] Upgrade to Parent 42 and Maven 3.6.3 [maven-site-plugin]
michael-o opened a new pull request, #187: URL: https://github.com/apache/maven-site-plugin/pull/187 This closes #187 Following this checklist to help us incorporate your contribution quickly and easily: - [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/MSITE) filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes. - [ ] Each commit in the pull request should have a meaningful subject line and body. - [ ] Format the pull request title like `[MSITE-XXX] - Fixes bug in ApproximateQuantiles`, where you replace `MSITE-XXX` with the appropriate JIRA issue. Best practice is to use the JIRA issue title in the pull request title and in the first line of the commit message. - [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [ ] Run `mvn clean verify` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically. - [ ] You have run the integration tests successfully (`mvn -Prun-its clean verify`). If your pull request is about ~20 lines of code you don't need to sign an [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure please ask on the developers list. To make clear that you license your contribution under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) you have to acknowledge this by using the following check-box. - [ ] I hereby declare this contribution to be licenced under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) - [ ] In any other case, please file an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (MSITE-1008) Upgrade to Parent 42 and Maven 3.6.3
Michael Osipov created MSITE-1008: - Summary: Upgrade to Parent 42 and Maven 3.6.3 Key: MSITE-1008 URL: https://issues.apache.org/jira/browse/MSITE-1008 Project: Maven Site Plugin Issue Type: Dependency upgrade Reporter: Michael Osipov Assignee: Michael Osipov Fix For: 4.0.0-M15, 4.0.0 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Closed] (MSHARED-1398) StringIndexOutOfBoundsException processing record classes
[
https://issues.apache.org/jira/browse/MSHARED-1398?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Slawomir Jaranowski closed MSHARED-1398.
Resolution: Fixed
> StringIndexOutOfBoundsException processing record classes
> -
>
> Key: MSHARED-1398
> URL: https://issues.apache.org/jira/browse/MSHARED-1398
> Project: Maven Shared Components
> Issue Type: Bug
> Components: maven-dependency-analyzer
>Affects Versions: maven-dependency-analyzer-1.14.0
>Reporter: Jared Stehler
>Assignee: Slawomir Jaranowski
>Priority: Major
> Fix For: maven-dependency-analyzer-next-release
>
>
> Processing classes with records results in an index out of bounds exception:
> {code:java}
> Caused by: java.lang.StringIndexOutOfBoundsException: Index 41 out of bounds
> for length 41
> at
> java.base@21.0.3/jdk.internal.util.Preconditions$1.apply(Preconditions.java:55)
> at
> java.base@21.0.3/jdk.internal.util.Preconditions$1.apply(Preconditions.java:52)
> at
> java.base@21.0.3/jdk.internal.util.Preconditions$4.apply(Preconditions.java:213)
> at
> java.base@21.0.3/jdk.internal.util.Preconditions$4.apply(Preconditions.java:210)
> at
> java.base@21.0.3/jdk.internal.util.Preconditions.outOfBounds(Preconditions.java:98)
> at
> java.base@21.0.3/jdk.internal.util.Preconditions.outOfBoundsCheckIndex(Preconditions.java:106)
> at
> java.base@21.0.3/jdk.internal.util.Preconditions.checkIndex(Preconditions.java:302)
> at java.base@21.0.3/java.lang.String.checkIndex(String.java:4832)
> at java.base@21.0.3/java.lang.StringLatin1.charAt(StringLatin1.java:46)
> at java.base@21.0.3/java.lang.String.charAt(String.java:1555)
> at app//org.objectweb.asm.Type.getReturnTypeOffset(Type.java:378)
> at app//org.objectweb.asm.Type.getReturnType(Type.java:355)
> at
> app//org.apache.maven.shared.dependency.analyzer.asm.ResultCollector.addMethodDesc(ResultCollector.java:112)
> {code}
> I have a reproducible test case here:
> https://github.com/jaredstehler/maven-dependency-analyzer/tree/js-repro-record-error
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MSHARED-1398) StringIndexOutOfBoundsException processing record classes
[
https://issues.apache.org/jira/browse/MSHARED-1398?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17847705#comment-17847705
]
ASF GitHub Bot commented on MSHARED-1398:
-
slawekjaranowski merged PR #121:
URL: https://github.com/apache/maven-dependency-analyzer/pull/121
> StringIndexOutOfBoundsException processing record classes
> -
>
> Key: MSHARED-1398
> URL: https://issues.apache.org/jira/browse/MSHARED-1398
> Project: Maven Shared Components
> Issue Type: Bug
> Components: maven-dependency-analyzer
>Affects Versions: maven-dependency-analyzer-1.14.0
>Reporter: Jared Stehler
>Assignee: Slawomir Jaranowski
>Priority: Major
> Fix For: maven-dependency-analyzer-next-release
>
>
> Processing classes with records results in an index out of bounds exception:
> {code:java}
> Caused by: java.lang.StringIndexOutOfBoundsException: Index 41 out of bounds
> for length 41
> at
> java.base@21.0.3/jdk.internal.util.Preconditions$1.apply(Preconditions.java:55)
> at
> java.base@21.0.3/jdk.internal.util.Preconditions$1.apply(Preconditions.java:52)
> at
> java.base@21.0.3/jdk.internal.util.Preconditions$4.apply(Preconditions.java:213)
> at
> java.base@21.0.3/jdk.internal.util.Preconditions$4.apply(Preconditions.java:210)
> at
> java.base@21.0.3/jdk.internal.util.Preconditions.outOfBounds(Preconditions.java:98)
> at
> java.base@21.0.3/jdk.internal.util.Preconditions.outOfBoundsCheckIndex(Preconditions.java:106)
> at
> java.base@21.0.3/jdk.internal.util.Preconditions.checkIndex(Preconditions.java:302)
> at java.base@21.0.3/java.lang.String.checkIndex(String.java:4832)
> at java.base@21.0.3/java.lang.StringLatin1.charAt(StringLatin1.java:46)
> at java.base@21.0.3/java.lang.String.charAt(String.java:1555)
> at app//org.objectweb.asm.Type.getReturnTypeOffset(Type.java:378)
> at app//org.objectweb.asm.Type.getReturnType(Type.java:355)
> at
> app//org.apache.maven.shared.dependency.analyzer.asm.ResultCollector.addMethodDesc(ResultCollector.java:112)
> {code}
> I have a reproducible test case here:
> https://github.com/jaredstehler/maven-dependency-analyzer/tree/js-repro-record-error
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
Re: [PR] [MSHARED-1398] Fix StringIndexOutOfBoundsException in dynamic bootstrap types [maven-dependency-analyzer]
slawekjaranowski merged PR #121: URL: https://github.com/apache/maven-dependency-analyzer/pull/121 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MINVOKER-351) Prevent XML-prohibited characters from entering JUnit report
[
https://issues.apache.org/jira/browse/MINVOKER-351?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17847704#comment-17847704
]
ASF GitHub Bot commented on MINVOKER-351:
-
slawekjaranowski commented on PR #242:
URL:
https://github.com/apache/maven-invoker-plugin/pull/242#issuecomment-2119309540
@michael-o, @elharo I try to fix plexus-xml
Here only add an IT which generate special chars in outputs ...
> Prevent XML-prohibited characters from entering JUnit report
>
>
> Key: MINVOKER-351
> URL: https://issues.apache.org/jira/browse/MINVOKER-351
> Project: Maven Invoker Plugin
> Issue Type: Bug
>Reporter: Mikkel Kjeldsen
>Assignee: Slawomir Jaranowski
>Priority: Major
> Fix For: 3.7.0
>
> Attachments: minvoker-351.tar.gz
>
>
> Neither the Maven Invoker plugin's implementation of {{}}
> nor the underlying XML infrastructure directly protect against the presence
> of character literals prohibited by the XML specification, meaning such
> literals can appear in the JUnit report and render it unreadable. *I would
> appreciate if the Maven Invoker plugin could learn to strip prohibited
> literals to protect its users from creative plugins.* I argue that this is a
> safe and expected transformation that is not materially lossy.
>
> h2. Background
> MINVOKER-196 added the {{}} option [back in
> maven-invoker-plugin-3.2.1|https://github.com/apache/maven-invoker-plugin/blob/maven-invoker-plugin-3.2.1/src/main/java/org/apache/maven/plugins/invoker/AbstractInvokerMojo.java#L1878-L1946].
> As of [maven-invoker-plugin-3.6.0 the effective implementation of the JUnit
> report remains effectively
> unchanged|https://github.com/apache/maven-invoker-plugin/blob/maven-invoker-plugin-3.6.0/src/main/java/org/apache/maven/plugins/invoker/AbstractInvokerMojo.java#L1695-L1754].
> The JUnit report includes a {{}} element ([example
> documentation|https://github.com/testmoapp/junitxml]) whose value Maven
> Invoker populates with the raw build log contents. I've observed that this
> value is XML-escaped, which I imagine is well understood in the
> implementation, although I can't immediately find documentation to support
> that.
> However, escaping notwithstanding, a number of character literals are
> outright prohibited by the XML specifications. These literals cannot be
> escaped, and their presence renders an XML document not well formed. The
> exact set of prohibited characters varies by XML version; the report produced
> by the Maven Invoker plugin is XML version 1.0. When the Maven Invoker plugin
> reads in the build log it does not strip these character literals and neither
> does the XML writer the Maven Invoker plugin relies on. Consequently, if a
> build log ends up including a prohibited character the resulting JUnit report
> will not be well formed.
> The set of prohibited characters is the complement of [the XML
> specification's definition of {{Char}}|https://www.w3.org/TR/xml/#NT-Char].
> h2. Example
> Among the literals prohibited by XML version 1.0 is {{^H}} (backspace). When
> [pitest runs via Maven|https://pitest.org/quickstart/maven/] it prints a
> spinner to standard out, and the implementation uses backspace to render the
> spinner in place. I have used the Maven Invoker plugin with
> {{}} to verify a pitest configuration, whereby I discovered
> this limitation.
> h2. Remediation
> h3. Blame plugins
> Perhaps pitest should not behave this way but we can't change pitest, and
> even if pitest could be changed that offers no protection against any other
> plugin, so blaming plugins is an ineffective course of action.
> h3. Work-arounds
> The user can manually clean the build log in-place via
> {{}}. This is technically fairly easy to do, and makes
> the transformation very explicit, but it requires considerable local work to
> address an issue many would find obscure and the transformation is
> permanently lossy unless the user also backs up the raw log to another file
> name.
> h3. Strip prohibited literals inside Maven Invoker plugin
> If the Maven Invoker plugin learns to strip offending character literals
> in-between reading the build log and writing to the {{}} value
> then {{}} will Just Work™, which I assert is what a user
> will typically expect. Although the {{}} value will no longer
> exactly match the build log contents, this lossy translation is acceptable:
> the prohibited characters are overwhelmingly unprintable to begin with and
> therefore cannot be meaningfully rendered in a static context, and the raw
> build log remains unchanged in the event that the user needs to investigate
> or assert against the raw output.
> This change would be backwards compatible, because any existing user that
> would
Re: [PR] [MINVOKER-351] Escape special xml character in junit report [maven-invoker-plugin]
slawekjaranowski commented on PR #242: URL: https://github.com/apache/maven-invoker-plugin/pull/242#issuecomment-2119309540 @michael-o, @elharo I try to fix plexus-xml Here only add an IT which generate special chars in outputs ... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MBUILDCACHE-87) Checksum should consider plugin dependencies
[
https://issues.apache.org/jira/browse/MBUILDCACHE-87?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17847703#comment-17847703
]
ASF GitHub Bot commented on MBUILDCACHE-87:
---
reda-alaoui commented on PR #146:
URL:
https://github.com/apache/maven-build-cache-extension/pull/146#issuecomment-2119306161
Oups, I forgot to add logs.
> Checksum should consider plugin dependencies
>
>
> Key: MBUILDCACHE-87
> URL: https://issues.apache.org/jira/browse/MBUILDCACHE-87
> Project: Maven Build Cache Extension
> Issue Type: Improvement
>Reporter: Réda Housni Alaoui
>Priority: Major
> Labels: pull-request-available
>
> I have a multi module project where module A is used as a dependency of
> maven-dependency-plugin:unpack declared in module B.
> {{buildinfo.xml}} of module B does not consider module A as a dependency.
> Maybe something similar to
> https://github.com/apache/maven-build-cache-extension/blob/6eb05e61fdfa7be1ad44cf6afc13958b0c6ea4a6/src/main/java/org/apache/maven/buildcache/checksum/MavenProjectInput.java#L602
> should be added for plugin dependencies?
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
Re: [PR] [MBUILDCACHE-87] - Checksum should consider plugin dependencies [maven-build-cache-extension]
reda-alaoui commented on PR #146: URL: https://github.com/apache/maven-build-cache-extension/pull/146#issuecomment-2119306161 Oups, I forgot to add logs. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MBUILDCACHE-59) Accommodate Maven CI-friendly versions
[
https://issues.apache.org/jira/browse/MBUILDCACHE-59?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17847702#comment-17847702
]
Réda Housni Alaoui commented on MBUILDCACHE-59:
---
[~mwang5], yes I was also using the same workaround.
> Accommodate Maven CI-friendly versions
> --
>
> Key: MBUILDCACHE-59
> URL: https://issues.apache.org/jira/browse/MBUILDCACHE-59
> Project: Maven Build Cache Extension
> Issue Type: Improvement
>Affects Versions: 1.0.0
>Reporter: Bas van Erp
>Priority: Major
>
> I would argue that the Maven Build Cache Extension (MBCE) can provide the
> greatest value for users that utilize large multi-module (mono-)repositories,
> since those projects tend to have large amounts of "stable" code which isn't
> modified frequently.
> Speeding up the build of these multi-module projects using the MBCE would be
> totally awesome!
> But for my particular project (200K LOC, 400 modules, mono-repo) our initial
> trials with the MBCE have proven somewhat troublesome.
> It has to do with our use of [https://maven.apache.org/maven-ci-friendly.html]
> h2. Example setup
> {{repo/.mvn/maven.config}}
> {code:java}
> -Drevision=0.0.0-local-SNAPSHOT {code}
> {{repo/pom.xml}}
> {code:java}
> com.corp
> parent
> ${revision}
> pom {code}
> {{repo/moduleX/pom.xml}}
> {code:java}
>
> com.corp
> parent
> ${revision}
> ../pom.xml
>
> moduleX
> jar{code}
> {{repo/moduleY/pom.xml}}
> {code:java}
>
> com.corp
> parent
> ${revision}
> ../pom.xml
>
> moduleY
> jar
>
>
> com.corp
> moduleX
> ${revision}
>
> {code}
> {{repo/Jenkinsfile}}
> {code:java}
> mvn clean deploy -Drevision=$(git describe){code}
> h2. Effect
> This setup effectively means that while all our 150 developers might
> theoretically get decent cache hit % since they are all always using version
> {{0.0.0-local-SNAPSHOT}} for every single POM for every single build, our CI
> pipelines are out of luck.
> Since the effective-POMs will change radically with each new Git commit, the
> hashes will virtually never collide.
> h2. Solution?
> I'm very new to the MBCE so I might be way off the mark, but I think
> accommodating this setup will not be trivial to implement. It would probably
> require parsing the effective-POM for every module picked-up by the reactor
> and then removing all clauses of the module, the parent, and each
> dependency and plugin which are part of the reactor build.
> Doesn't sound easy to me. But perhaps I'm missing something.
>
> p.s. Congrats on the v1.0.0 release :). I'm enjoying experimenting with it.
> But the documentation could use some love. It's pretty hard to read. Some
> paragraphs are confusing, terse or lacking in detail, are clearly written by
> non-English-native writers (like myself), or even stop mid-sentence.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Updated] (MBUILDCACHE-92) Allow to define 'reconciles' at plugin execution level
[
https://issues.apache.org/jira/browse/MBUILDCACHE-92?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Réda Housni Alaoui updated MBUILDCACHE-92:
--
Description:
I have the following case:
{code:xml}
com.github.eirslett
frontend-maven-plugin
yarn-build-dev
yarn
prepare-package
${build-dev.skip}
build:dev
yarn-build-prod
yarn
prepare-package
${build-prod.skip}
build:prod
{code}
{{yarn-build-prod}} produces a more complete output than {{yarn-build-dev}} but
it also takes more time to execute:
- on a dev environment (build-prod.skip=true and build-dev.skip=false) using a
cache produced with build-prod.skip=false and build-dev.skip=true should lead
to a cache hit
- on a CI environment (build-prod.skip=false and build-dev.skip=true) using a
cache produced with build-prod.skip=true and build-dev.skip=false should lead
to a cache miss
The only way I can think of implementing this is to track property {{skip}}
only for execution id {{yarn-build-prod}}, but not for execution id
{{yarn-build-dev}}.
But I can't, because as of now, this extension allows to track plugin property
with reconcile at plugin goal level, not execution level.
was:
I have the following case:
{code:xml}
com.github.eirslett
frontend-maven-plugin
yarn-build-dev
yarn
prepare-package
${build-dev.skip}
build:dev
yarn-build-prod
yarn
prepare-package
${build-prod.skip}
build:prod
{code}
{{yarn-build-prod}} produces a more complete than {{yarn-build-dev}} but it
also takes more time to execute:
- on a dev environment (build-prod.skip=true and build-dev.skip=false) using a
cache produced with build-prod.skip=false and build-dev.skip=true should lead
to a cache hit
- on a CI environment (build-prod.skip=false and build-dev.skip=true) using a
cache produced with build-prod.skip=true and build-dev.skip=false should lead
to a cache miss
The only way I can think of implementing this is to track property {{skip}}
only for execution id {{yarn-build-prod}}, but not for execution id
{{yarn-build-dev}}.
But I can't, because as of now, this extension allows to track plugin property
with reconcile at plugin goal level, not execution level.
> Allow to define 'reconciles' at plugin execution level
> --
>
> Key: MBUILDCACHE-92
> URL: https://issues.apache.org/jira/browse/MBUILDCACHE-92
> Project: Maven Build Cache Extension
> Issue Type: Improvement
>Affects Versions: 1.1.0
>Reporter: Réda Housni Alaoui
>Priority: Major
>
> I have the following case:
> {code:xml}
>
> com.github.eirslett
> frontend-maven-plugin
>
>
> yarn-build-dev
>
> yarn
>
> prepare-package
>
> ${build-dev.skip}
> build:dev
>
>
>
> yarn-build-prod
>
> yarn
>
> prepare-package
>
> ${build-prod.skip}
> build:prod
>
>
>
>
> {code}
> {{yarn-build-prod}} produces a more complete output than {{yarn-build-dev}}
> but it also takes more time to execute:
> - on a dev environment (build-prod.skip=true and build-dev.skip=false) using
> a cache produced with build-prod.skip=false and build-dev.skip=true should
> lead to a cache hit
> - on a CI environment (build-prod.skip=false and build-dev.skip=true) using
> a cache produced with build-prod.skip=true and build-dev.skip=false should
> lead to a cache miss
> The only way I can think of implementing this is to track property {{skip}}
> only for execution id {{yarn-build-prod}}, but not for execution id
> {{yarn-build-dev}}.
> But I can't, because as of now, this extension allows to track plugin
> property with reconcile at plugin goal level, not execution level.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Updated] (MBUILDCACHE-92) Allow to define 'reconciles' at plugin execution level
[
https://issues.apache.org/jira/browse/MBUILDCACHE-92?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Réda Housni Alaoui updated MBUILDCACHE-92:
--
Description:
I have the following case:
{code:xml}
com.github.eirslett
frontend-maven-plugin
yarn-build-dev
yarn
prepare-package
${build-dev.skip}
build:dev
yarn-build-prod
yarn
prepare-package
${build-prod.skip}
build:prod
{code}
{{yarn-build-prod}} produces a more complete than {{yarn-build-dev}} but it
also takes more time to execute:
- on a dev environment (build-prod.skip=true and build-dev.skip=false) using a
cache produced with build-prod.skip=false and build-dev.skip=true should lead
to a cache hit
- on a CI environment (build-prod.skip=false and build-dev.skip=true) using a
cache produced with build-prod.skip=true and build-dev.skip=false should lead
to a cache miss
The only way I can think of implementing this is to track property {{skip}}
only for execution id {{yarn-build-prod}}, but not for execution id
{{yarn-build-dev}}.
But I can't, because as of now, this extension allows to track plugin property
with reconcile at plugin goal level, not execution level.
was:
I have the following case:
{code:xml}
com.github.eirslett
frontend-maven-plugin
yarn-build-dev
yarn
prepare-package
${build-dev.skip}
build:dev
yarn-build-prod
yarn
prepare-package
${build-prod.skip}
build:prod
{code}
{{yarn-build-prod}} produce a more complete than {{yarn-build-dev}} but it also
takes more time to execute:
- on a dev environment (build-prod.skip=true and build-dev.skip=false) using a
cache produced with build-prod.skip=false and build-dev.skip=true should lead
to a cache hit
- on a CI environment (build-prod.skip=false and build-dev.skip=true) using a
cache produced with build-prod.skip=true and build-dev.skip=false should lead
to a cache miss
The only way I can think of implementing this is to track property {{skip}}
only for execution id {{yarn-build-prod}}, but not for execution id
{{yarn-build-dev}}.
But I can't, because as of now, this extension allows to track plugin property
with reconcile at plugin goal level, not execution level.
> Allow to define 'reconciles' at plugin execution level
> --
>
> Key: MBUILDCACHE-92
> URL: https://issues.apache.org/jira/browse/MBUILDCACHE-92
> Project: Maven Build Cache Extension
> Issue Type: Improvement
>Affects Versions: 1.1.0
>Reporter: Réda Housni Alaoui
>Priority: Major
>
> I have the following case:
> {code:xml}
>
> com.github.eirslett
> frontend-maven-plugin
>
>
> yarn-build-dev
>
> yarn
>
> prepare-package
>
> ${build-dev.skip}
> build:dev
>
>
>
> yarn-build-prod
>
> yarn
>
> prepare-package
>
> ${build-prod.skip}
> build:prod
>
>
>
>
> {code}
> {{yarn-build-prod}} produces a more complete than {{yarn-build-dev}} but it
> also takes more time to execute:
> - on a dev environment (build-prod.skip=true and build-dev.skip=false) using
> a cache produced with build-prod.skip=false and build-dev.skip=true should
> lead to a cache hit
> - on a CI environment (build-prod.skip=false and build-dev.skip=true) using
> a cache produced with build-prod.skip=true and build-dev.skip=false should
> lead to a cache miss
> The only way I can think of implementing this is to track property {{skip}}
> only for execution id {{yarn-build-prod}}, but not for execution id
> {{yarn-build-dev}}.
> But I can't, because as of now, this extension allows to track plugin
> property with reconcile at plugin goal level, not execution level.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MINVOKER-351) Prevent XML-prohibited characters from entering JUnit report
[
https://issues.apache.org/jira/browse/MINVOKER-351?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17847696#comment-17847696
]
ASF GitHub Bot commented on MINVOKER-351:
-
michael-o commented on PR #242:
URL:
https://github.com/apache/maven-invoker-plugin/pull/242#issuecomment-2119286251
> @elharo `BuildJob` serializer is generated by modello - `xpp3-writer` so
finally `MXSerializer` from plexus-utils is used
Right, I don't see a a way to get in between layers without monkey patching.
> Prevent XML-prohibited characters from entering JUnit report
>
>
> Key: MINVOKER-351
> URL: https://issues.apache.org/jira/browse/MINVOKER-351
> Project: Maven Invoker Plugin
> Issue Type: Bug
>Reporter: Mikkel Kjeldsen
>Assignee: Slawomir Jaranowski
>Priority: Major
> Fix For: 3.7.0
>
> Attachments: minvoker-351.tar.gz
>
>
> Neither the Maven Invoker plugin's implementation of {{}}
> nor the underlying XML infrastructure directly protect against the presence
> of character literals prohibited by the XML specification, meaning such
> literals can appear in the JUnit report and render it unreadable. *I would
> appreciate if the Maven Invoker plugin could learn to strip prohibited
> literals to protect its users from creative plugins.* I argue that this is a
> safe and expected transformation that is not materially lossy.
>
> h2. Background
> MINVOKER-196 added the {{}} option [back in
> maven-invoker-plugin-3.2.1|https://github.com/apache/maven-invoker-plugin/blob/maven-invoker-plugin-3.2.1/src/main/java/org/apache/maven/plugins/invoker/AbstractInvokerMojo.java#L1878-L1946].
> As of [maven-invoker-plugin-3.6.0 the effective implementation of the JUnit
> report remains effectively
> unchanged|https://github.com/apache/maven-invoker-plugin/blob/maven-invoker-plugin-3.6.0/src/main/java/org/apache/maven/plugins/invoker/AbstractInvokerMojo.java#L1695-L1754].
> The JUnit report includes a {{}} element ([example
> documentation|https://github.com/testmoapp/junitxml]) whose value Maven
> Invoker populates with the raw build log contents. I've observed that this
> value is XML-escaped, which I imagine is well understood in the
> implementation, although I can't immediately find documentation to support
> that.
> However, escaping notwithstanding, a number of character literals are
> outright prohibited by the XML specifications. These literals cannot be
> escaped, and their presence renders an XML document not well formed. The
> exact set of prohibited characters varies by XML version; the report produced
> by the Maven Invoker plugin is XML version 1.0. When the Maven Invoker plugin
> reads in the build log it does not strip these character literals and neither
> does the XML writer the Maven Invoker plugin relies on. Consequently, if a
> build log ends up including a prohibited character the resulting JUnit report
> will not be well formed.
> The set of prohibited characters is the complement of [the XML
> specification's definition of {{Char}}|https://www.w3.org/TR/xml/#NT-Char].
> h2. Example
> Among the literals prohibited by XML version 1.0 is {{^H}} (backspace). When
> [pitest runs via Maven|https://pitest.org/quickstart/maven/] it prints a
> spinner to standard out, and the implementation uses backspace to render the
> spinner in place. I have used the Maven Invoker plugin with
> {{}} to verify a pitest configuration, whereby I discovered
> this limitation.
> h2. Remediation
> h3. Blame plugins
> Perhaps pitest should not behave this way but we can't change pitest, and
> even if pitest could be changed that offers no protection against any other
> plugin, so blaming plugins is an ineffective course of action.
> h3. Work-arounds
> The user can manually clean the build log in-place via
> {{}}. This is technically fairly easy to do, and makes
> the transformation very explicit, but it requires considerable local work to
> address an issue many would find obscure and the transformation is
> permanently lossy unless the user also backs up the raw log to another file
> name.
> h3. Strip prohibited literals inside Maven Invoker plugin
> If the Maven Invoker plugin learns to strip offending character literals
> in-between reading the build log and writing to the {{}} value
> then {{}} will Just Work™, which I assert is what a user
> will typically expect. Although the {{}} value will no longer
> exactly match the build log contents, this lossy translation is acceptable:
> the prohibited characters are overwhelmingly unprintable to begin with and
> therefore cannot be meaningfully rendered in a static context, and the raw
> build log remains unchanged in the event that the user needs to investigate
> or assert against the raw
Re: [PR] [MINVOKER-351] Escape special xml character in junit report [maven-invoker-plugin]
michael-o commented on PR #242: URL: https://github.com/apache/maven-invoker-plugin/pull/242#issuecomment-2119286251 > @elharo `BuildJob` serializer is generated by modello - `xpp3-writer` so finally `MXSerializer` from plexus-utils is used Right, I don't see a a way to get in between layers without monkey patching. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MINVOKER-351) Prevent XML-prohibited characters from entering JUnit report
[
https://issues.apache.org/jira/browse/MINVOKER-351?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17847695#comment-17847695
]
ASF GitHub Bot commented on MINVOKER-351:
-
slawekjaranowski commented on PR #242:
URL:
https://github.com/apache/maven-invoker-plugin/pull/242#issuecomment-2119283520
@elharo `BuildJob` serializer is generated by modello - `xpp3-writer` so
finally `MXSerializer` from plexus-utils is used
> Prevent XML-prohibited characters from entering JUnit report
>
>
> Key: MINVOKER-351
> URL: https://issues.apache.org/jira/browse/MINVOKER-351
> Project: Maven Invoker Plugin
> Issue Type: Bug
>Reporter: Mikkel Kjeldsen
>Assignee: Slawomir Jaranowski
>Priority: Major
> Fix For: 3.7.0
>
> Attachments: minvoker-351.tar.gz
>
>
> Neither the Maven Invoker plugin's implementation of {{}}
> nor the underlying XML infrastructure directly protect against the presence
> of character literals prohibited by the XML specification, meaning such
> literals can appear in the JUnit report and render it unreadable. *I would
> appreciate if the Maven Invoker plugin could learn to strip prohibited
> literals to protect its users from creative plugins.* I argue that this is a
> safe and expected transformation that is not materially lossy.
>
> h2. Background
> MINVOKER-196 added the {{}} option [back in
> maven-invoker-plugin-3.2.1|https://github.com/apache/maven-invoker-plugin/blob/maven-invoker-plugin-3.2.1/src/main/java/org/apache/maven/plugins/invoker/AbstractInvokerMojo.java#L1878-L1946].
> As of [maven-invoker-plugin-3.6.0 the effective implementation of the JUnit
> report remains effectively
> unchanged|https://github.com/apache/maven-invoker-plugin/blob/maven-invoker-plugin-3.6.0/src/main/java/org/apache/maven/plugins/invoker/AbstractInvokerMojo.java#L1695-L1754].
> The JUnit report includes a {{}} element ([example
> documentation|https://github.com/testmoapp/junitxml]) whose value Maven
> Invoker populates with the raw build log contents. I've observed that this
> value is XML-escaped, which I imagine is well understood in the
> implementation, although I can't immediately find documentation to support
> that.
> However, escaping notwithstanding, a number of character literals are
> outright prohibited by the XML specifications. These literals cannot be
> escaped, and their presence renders an XML document not well formed. The
> exact set of prohibited characters varies by XML version; the report produced
> by the Maven Invoker plugin is XML version 1.0. When the Maven Invoker plugin
> reads in the build log it does not strip these character literals and neither
> does the XML writer the Maven Invoker plugin relies on. Consequently, if a
> build log ends up including a prohibited character the resulting JUnit report
> will not be well formed.
> The set of prohibited characters is the complement of [the XML
> specification's definition of {{Char}}|https://www.w3.org/TR/xml/#NT-Char].
> h2. Example
> Among the literals prohibited by XML version 1.0 is {{^H}} (backspace). When
> [pitest runs via Maven|https://pitest.org/quickstart/maven/] it prints a
> spinner to standard out, and the implementation uses backspace to render the
> spinner in place. I have used the Maven Invoker plugin with
> {{}} to verify a pitest configuration, whereby I discovered
> this limitation.
> h2. Remediation
> h3. Blame plugins
> Perhaps pitest should not behave this way but we can't change pitest, and
> even if pitest could be changed that offers no protection against any other
> plugin, so blaming plugins is an ineffective course of action.
> h3. Work-arounds
> The user can manually clean the build log in-place via
> {{}}. This is technically fairly easy to do, and makes
> the transformation very explicit, but it requires considerable local work to
> address an issue many would find obscure and the transformation is
> permanently lossy unless the user also backs up the raw log to another file
> name.
> h3. Strip prohibited literals inside Maven Invoker plugin
> If the Maven Invoker plugin learns to strip offending character literals
> in-between reading the build log and writing to the {{}} value
> then {{}} will Just Work™, which I assert is what a user
> will typically expect. Although the {{}} value will no longer
> exactly match the build log contents, this lossy translation is acceptable:
> the prohibited characters are overwhelmingly unprintable to begin with and
> therefore cannot be meaningfully rendered in a static context, and the raw
> build log remains unchanged in the event that the user needs to investigate
> or assert against the raw output.
> This change would be backwards compatible, because any existing user
Re: [PR] [MINVOKER-351] Escape special xml character in junit report [maven-invoker-plugin]
slawekjaranowski commented on PR #242: URL: https://github.com/apache/maven-invoker-plugin/pull/242#issuecomment-2119283520 @elharo `BuildJob` serializer is generated by modello - `xpp3-writer` so finally `MXSerializer` from plexus-utils is used -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MJAVADOC-793) java.lang.NullPointerException: Cannot invoke "String.length()" because "text" is null
[
https://issues.apache.org/jira/browse/MJAVADOC-793?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17847694#comment-17847694
]
Slawomir Jaranowski commented on MJAVADOC-793:
--
[~ggregory] when we will have a fix I can release next version
> java.lang.NullPointerException: Cannot invoke "String.length()" because
> "text" is null
> --
>
> Key: MJAVADOC-793
> URL: https://issues.apache.org/jira/browse/MJAVADOC-793
> Project: Maven Javadoc Plugin
> Issue Type: Bug
>Affects Versions: 3.6.3
>Reporter: Gary D. Gregory
>Priority: Blocker
> Fix For: 3.6.4
>
>
> Plugin throws {{NullPointerException}} when running {{{}javadoc:javadoc{}}}.
> See:
> * Failing PR: https://github.com/apache/commons-compress/pull/528
> * Build log:
> [https://github.com/apache/commons-compress/actions/runs/9113449616/job/25054982405?pr=528]
> Or:
> # git clone [https://gitbox.apache.org/repos/asf/commons-compress.git]
> # git checkout 542cc5a602a9128932e3fb75503383e481141e7e
> # Edit pom.xml and set the parent POM to version 70
> # Run 'mvn javadoc:javadoc' causes:
> {noformat}
> [INFO] --- javadoc:3.6.3:javadoc (default-cli) @ commons-compress ---
> [INFO]
>
> [INFO] BUILD FAILURE
> [INFO]
>
> [INFO] Total time: 8.434 s
> [INFO] Finished at: 2024-05-16T09:36:02-04:00
> [INFO]
>
> [ERROR] Failed to execute goal
> org.apache.maven.plugins:maven-javadoc-plugin:3.6.3:javadoc (default-cli) on
> project commons-compress: Execution default-cli of goal
> org.apache.maven.plugins:maven-javadoc-plugin:3.6.3:javadoc failed: Cannot
> invoke "String.length()" because "text" is null -> [Help 1]
> org.apache.maven.lifecycle.LifecycleExecutionException: Failed to execute
> goal org.apache.maven.plugins:maven-javadoc-plugin:3.6.3:javadoc
> (default-cli) on project commons-compress: Execution default-cli of goal
> org.apache.maven.plugins:maven-javadoc-plugin:3.6.3:javadoc failed: Cannot
> invoke "String.length()" because "text" is null
> at org.apache.maven.lifecycle.internal.MojoExecutor.doExecute2
> (MojoExecutor.java:333)
> at org.apache.maven.lifecycle.internal.MojoExecutor.doExecute
> (MojoExecutor.java:316)
> at org.apache.maven.lifecycle.internal.MojoExecutor.execute
> (MojoExecutor.java:212)
> at org.apache.maven.lifecycle.internal.MojoExecutor.execute
> (MojoExecutor.java:174)
> at org.apache.maven.lifecycle.internal.MojoExecutor.access$000
> (MojoExecutor.java:75)
> at org.apache.maven.lifecycle.internal.MojoExecutor$1.run
> (MojoExecutor.java:162)
> at org.apache.maven.plugin.DefaultMojosExecutionStrategy.execute
> (DefaultMojosExecutionStrategy.java:39)
> at org.apache.maven.lifecycle.internal.MojoExecutor.execute
> (MojoExecutor.java:159)
> at
> org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject
> (LifecycleModuleBuilder.java:105)
> at
> org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject
> (LifecycleModuleBuilder.java:73)
> at
> org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.build
> (SingleThreadedBuilder.java:53)
> at org.apache.maven.lifecycle.internal.LifecycleStarter.execute
> (LifecycleStarter.java:118)
> at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:261)
> at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:173)
> at org.apache.maven.DefaultMaven.execute (DefaultMaven.java:101)
> at org.apache.maven.cli.MavenCli.execute (MavenCli.java:906)
> at org.apache.maven.cli.MavenCli.doMain (MavenCli.java:283)
> at org.apache.maven.cli.MavenCli.main (MavenCli.java:206)
> at jdk.internal.reflect.NativeMethodAccessorImpl.invoke0 (Native Method)
> at jdk.internal.reflect.NativeMethodAccessorImpl.invoke
> (NativeMethodAccessorImpl.java:77)
> at jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke
> (DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke (Method.java:568)
> at org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced
> (Launcher.java:283)
> at org.codehaus.plexus.classworlds.launcher.Launcher.launch
> (Launcher.java:226)
> at org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode
> (Launcher.java:407)
> at org.codehaus.plexus.classworlds.launcher.Launcher.main
> (Launcher.java:348)
> Caused by: org.apache.maven.plugin.PluginExecutionException: Execution
> default-cli of goal
> org.apache.maven.plugins:maven-javadoc-plugin:3.6.3:javadoc failed: Cannot
> invoke "String.length()"
[jira] [Commented] (MJAVADOC-793) java.lang.NullPointerException: Cannot invoke "String.length()" because "text" is null
[
https://issues.apache.org/jira/browse/MJAVADOC-793?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17847680#comment-17847680
]
Gary D. Gregory commented on MJAVADOC-793:
--
Hi,
Any thoughts on pushing out a release sooner rather than later?
> java.lang.NullPointerException: Cannot invoke "String.length()" because
> "text" is null
> --
>
> Key: MJAVADOC-793
> URL: https://issues.apache.org/jira/browse/MJAVADOC-793
> Project: Maven Javadoc Plugin
> Issue Type: Bug
>Affects Versions: 3.6.3
>Reporter: Gary D. Gregory
>Priority: Blocker
> Fix For: 3.6.4
>
>
> Plugin throws {{NullPointerException}} when running {{{}javadoc:javadoc{}}}.
> See:
> * Failing PR: https://github.com/apache/commons-compress/pull/528
> * Build log:
> [https://github.com/apache/commons-compress/actions/runs/9113449616/job/25054982405?pr=528]
> Or:
> # git clone [https://gitbox.apache.org/repos/asf/commons-compress.git]
> # git checkout 542cc5a602a9128932e3fb75503383e481141e7e
> # Edit pom.xml and set the parent POM to version 70
> # Run 'mvn javadoc:javadoc' causes:
> {noformat}
> [INFO] --- javadoc:3.6.3:javadoc (default-cli) @ commons-compress ---
> [INFO]
>
> [INFO] BUILD FAILURE
> [INFO]
>
> [INFO] Total time: 8.434 s
> [INFO] Finished at: 2024-05-16T09:36:02-04:00
> [INFO]
>
> [ERROR] Failed to execute goal
> org.apache.maven.plugins:maven-javadoc-plugin:3.6.3:javadoc (default-cli) on
> project commons-compress: Execution default-cli of goal
> org.apache.maven.plugins:maven-javadoc-plugin:3.6.3:javadoc failed: Cannot
> invoke "String.length()" because "text" is null -> [Help 1]
> org.apache.maven.lifecycle.LifecycleExecutionException: Failed to execute
> goal org.apache.maven.plugins:maven-javadoc-plugin:3.6.3:javadoc
> (default-cli) on project commons-compress: Execution default-cli of goal
> org.apache.maven.plugins:maven-javadoc-plugin:3.6.3:javadoc failed: Cannot
> invoke "String.length()" because "text" is null
> at org.apache.maven.lifecycle.internal.MojoExecutor.doExecute2
> (MojoExecutor.java:333)
> at org.apache.maven.lifecycle.internal.MojoExecutor.doExecute
> (MojoExecutor.java:316)
> at org.apache.maven.lifecycle.internal.MojoExecutor.execute
> (MojoExecutor.java:212)
> at org.apache.maven.lifecycle.internal.MojoExecutor.execute
> (MojoExecutor.java:174)
> at org.apache.maven.lifecycle.internal.MojoExecutor.access$000
> (MojoExecutor.java:75)
> at org.apache.maven.lifecycle.internal.MojoExecutor$1.run
> (MojoExecutor.java:162)
> at org.apache.maven.plugin.DefaultMojosExecutionStrategy.execute
> (DefaultMojosExecutionStrategy.java:39)
> at org.apache.maven.lifecycle.internal.MojoExecutor.execute
> (MojoExecutor.java:159)
> at
> org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject
> (LifecycleModuleBuilder.java:105)
> at
> org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject
> (LifecycleModuleBuilder.java:73)
> at
> org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.build
> (SingleThreadedBuilder.java:53)
> at org.apache.maven.lifecycle.internal.LifecycleStarter.execute
> (LifecycleStarter.java:118)
> at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:261)
> at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:173)
> at org.apache.maven.DefaultMaven.execute (DefaultMaven.java:101)
> at org.apache.maven.cli.MavenCli.execute (MavenCli.java:906)
> at org.apache.maven.cli.MavenCli.doMain (MavenCli.java:283)
> at org.apache.maven.cli.MavenCli.main (MavenCli.java:206)
> at jdk.internal.reflect.NativeMethodAccessorImpl.invoke0 (Native Method)
> at jdk.internal.reflect.NativeMethodAccessorImpl.invoke
> (NativeMethodAccessorImpl.java:77)
> at jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke
> (DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke (Method.java:568)
> at org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced
> (Launcher.java:283)
> at org.codehaus.plexus.classworlds.launcher.Launcher.launch
> (Launcher.java:226)
> at org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode
> (Launcher.java:407)
> at org.codehaus.plexus.classworlds.launcher.Launcher.main
> (Launcher.java:348)
> Caused by: org.apache.maven.plugin.PluginExecutionException: Execution
> default-cli of goal
> org.apache.maven.plugins:maven-javadoc-plugin:3.6.3:javadoc failed: Cannot
> invoke "String.length()"
[jira] [Commented] (MINVOKER-351) Prevent XML-prohibited characters from entering JUnit report
[
https://issues.apache.org/jira/browse/MINVOKER-351?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17847666#comment-17847666
]
ASF GitHub Bot commented on MINVOKER-351:
-
elharo commented on PR #242:
URL:
https://github.com/apache/maven-invoker-plugin/pull/242#issuecomment-2119205215
For working around the plexus bugs, is it possible to add an additional step
in between the build job and the serializer that escapes the message rather
than passing escaped values into the build job?
> Prevent XML-prohibited characters from entering JUnit report
>
>
> Key: MINVOKER-351
> URL: https://issues.apache.org/jira/browse/MINVOKER-351
> Project: Maven Invoker Plugin
> Issue Type: Bug
>Reporter: Mikkel Kjeldsen
>Assignee: Slawomir Jaranowski
>Priority: Major
> Fix For: 3.7.0
>
> Attachments: minvoker-351.tar.gz
>
>
> Neither the Maven Invoker plugin's implementation of {{}}
> nor the underlying XML infrastructure directly protect against the presence
> of character literals prohibited by the XML specification, meaning such
> literals can appear in the JUnit report and render it unreadable. *I would
> appreciate if the Maven Invoker plugin could learn to strip prohibited
> literals to protect its users from creative plugins.* I argue that this is a
> safe and expected transformation that is not materially lossy.
>
> h2. Background
> MINVOKER-196 added the {{}} option [back in
> maven-invoker-plugin-3.2.1|https://github.com/apache/maven-invoker-plugin/blob/maven-invoker-plugin-3.2.1/src/main/java/org/apache/maven/plugins/invoker/AbstractInvokerMojo.java#L1878-L1946].
> As of [maven-invoker-plugin-3.6.0 the effective implementation of the JUnit
> report remains effectively
> unchanged|https://github.com/apache/maven-invoker-plugin/blob/maven-invoker-plugin-3.6.0/src/main/java/org/apache/maven/plugins/invoker/AbstractInvokerMojo.java#L1695-L1754].
> The JUnit report includes a {{}} element ([example
> documentation|https://github.com/testmoapp/junitxml]) whose value Maven
> Invoker populates with the raw build log contents. I've observed that this
> value is XML-escaped, which I imagine is well understood in the
> implementation, although I can't immediately find documentation to support
> that.
> However, escaping notwithstanding, a number of character literals are
> outright prohibited by the XML specifications. These literals cannot be
> escaped, and their presence renders an XML document not well formed. The
> exact set of prohibited characters varies by XML version; the report produced
> by the Maven Invoker plugin is XML version 1.0. When the Maven Invoker plugin
> reads in the build log it does not strip these character literals and neither
> does the XML writer the Maven Invoker plugin relies on. Consequently, if a
> build log ends up including a prohibited character the resulting JUnit report
> will not be well formed.
> The set of prohibited characters is the complement of [the XML
> specification's definition of {{Char}}|https://www.w3.org/TR/xml/#NT-Char].
> h2. Example
> Among the literals prohibited by XML version 1.0 is {{^H}} (backspace). When
> [pitest runs via Maven|https://pitest.org/quickstart/maven/] it prints a
> spinner to standard out, and the implementation uses backspace to render the
> spinner in place. I have used the Maven Invoker plugin with
> {{}} to verify a pitest configuration, whereby I discovered
> this limitation.
> h2. Remediation
> h3. Blame plugins
> Perhaps pitest should not behave this way but we can't change pitest, and
> even if pitest could be changed that offers no protection against any other
> plugin, so blaming plugins is an ineffective course of action.
> h3. Work-arounds
> The user can manually clean the build log in-place via
> {{}}. This is technically fairly easy to do, and makes
> the transformation very explicit, but it requires considerable local work to
> address an issue many would find obscure and the transformation is
> permanently lossy unless the user also backs up the raw log to another file
> name.
> h3. Strip prohibited literals inside Maven Invoker plugin
> If the Maven Invoker plugin learns to strip offending character literals
> in-between reading the build log and writing to the {{}} value
> then {{}} will Just Work™, which I assert is what a user
> will typically expect. Although the {{}} value will no longer
> exactly match the build log contents, this lossy translation is acceptable:
> the prohibited characters are overwhelmingly unprintable to begin with and
> therefore cannot be meaningfully rendered in a static context, and the raw
> build log remains unchanged in the event that the user needs to investigate
> or assert against the raw output.
>
Re: [PR] [MINVOKER-351] Escape special xml character in junit report [maven-invoker-plugin]
elharo commented on PR #242: URL: https://github.com/apache/maven-invoker-plugin/pull/242#issuecomment-2119205215 For working around the plexus bugs, is it possible to add an additional step in between the build job and the serializer that escapes the message rather than passing escaped values into the build job? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
