[jira] [Commented] (MJAVADOC-794) Taglet autodetection fails when taglets JAR includes a module-info.class
[
https://issues.apache.org/jira/browse/MJAVADOC-794?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17848828#comment-17848828
]
Michael Osipov commented on MJAVADOC-794:
-
Patch and IT welcome!
> Taglet autodetection fails when taglets JAR includes a module-info.class
>
>
> Key: MJAVADOC-794
> URL: https://issues.apache.org/jira/browse/MJAVADOC-794
> Project: Maven Javadoc Plugin
> Issue Type: Bug
>Affects Versions: 3.6.3
>Reporter: Curtis Rueden
>Priority: Major
>
> Due to a bug in the maven-javadoc-plugin, the following warning gets emitted
> when a JPMS-modularized artifact containing taglets is included in the
> javadoc build via a `` tag:
> {{ [WARNING] Unable to auto-detect Taglet class names from}}
> {{ '/path/to/jar.jar'. Try to specify them with .}}
> Running with {{mvn -X}} shows the underlying cause:
> {{ NoClassDefFoundError: module-info is not a}}
> {{ class because access_flag ACC_MODULE is set}}
> Removing the {{module-info.java}} from the component avoids the problem.
> The following patch fixes the problem as of {{{}ded56a90{}}}:
> {{diff --git
> a/src/main/java/org/apache/maven/plugins/javadoc/JavadocUtil.java
> b/src/main/java/org/apache/maven/plugins/ja>}}
> {{index 835d6332..6e29eadf 100644}}
> {{--- a/src/main/java/org/apache/maven/plugins/javadoc/JavadocUtil.java}}
> {{+++ b/src/main/java/org/apache/maven/plugins/javadoc/JavadocUtil.java}}
> {{@@ -904,6 +904,9 @@ public class JavadocUtil {}}
> {{ for (JarEntry jarEntry = jarStream.getNextJarEntry();}}
> {{ jarEntry != null;}}
> {{ jarEntry = jarStream.getNextJarEntry()) {}}
> {{+ if ("module-info.class".equals(jarEntry.getName())) {}}
> {{+ continue;}}
> {{+ }}}
> {{ Matcher matcher = pattern.matcher(jarEntry.getName());}}
> {{ if (matcher.matches()) {}}
> {{ String version = matcher.group("v");}}
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Updated] (MJAVADOC-794) Taglet autodetection fails when taglets JAR includes a module-info.class
[
https://issues.apache.org/jira/browse/MJAVADOC-794?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Curtis Rueden updated MJAVADOC-794:
---
Description:
Due to a bug in the maven-javadoc-plugin, the following warning gets emitted
when a JPMS-modularized artifact containing taglets is included in the javadoc
build via a `` tag:
{{ [WARNING] Unable to auto-detect Taglet class names from}}
{{ '/path/to/jar.jar'. Try to specify them with .}}
Running with `mvn -X` shows the underlying cause:
{{ NoClassDefFoundError: module-info is not a}}
{{ class because access_flag ACC_MODULE is set}}
Removing the {{module-info.java}} from the component avoids the problem.
The following patch fixes the problem as of {{{}ded56a90{}}}:
{{diff --git a/src/main/java/org/apache/maven/plugins/javadoc/JavadocUtil.java
b/src/main/java/org/apache/maven/plugins/ja>}}
{{index 835d6332..6e29eadf 100644}}
{{--- a/src/main/java/org/apache/maven/plugins/javadoc/JavadocUtil.java}}
{{+++ b/src/main/java/org/apache/maven/plugins/javadoc/JavadocUtil.java}}
{{@@ -904,6 +904,9 @@ public class JavadocUtil {}}
{{ for (JarEntry jarEntry = jarStream.getNextJarEntry();}}
{{ jarEntry != null;}}
{{ jarEntry = jarStream.getNextJarEntry()) {}}
{{+ if ("module-info.class".equals(jarEntry.getName())) {}}
{{+ continue;}}
{{+ }}}
{{ Matcher matcher = pattern.matcher(jarEntry.getName());}}
{{ if (matcher.matches()) {}}
{{ String version = matcher.group("v");}}
was:
Due to a bug in the maven-javadoc-plugin, the following warning gets emitted
with a JPMS-modularized artifact containing taglets is included in the javadoc
build via a `` tag:
{{ [WARNING] Unable to auto-detect Taglet class names from}}
{{ '/path/to/jar.jar'. Try to specify them with .}}
Running with `mvn -X` shows the underlying cause:
{{ NoClassDefFoundError: module-info is not a}}
{{ class because access_flag ACC_MODULE is set}}
Removing the {{module-info.java}} from the component avoids the problem.
The following patch fixes the problem as of {{{}ded56a90{}}}:
{{diff --git a/src/main/java/org/apache/maven/plugins/javadoc/JavadocUtil.java
b/src/main/java/org/apache/maven/plugins/ja>}}
{{index 835d6332..6e29eadf 100644}}
{{--- a/src/main/java/org/apache/maven/plugins/javadoc/JavadocUtil.java}}
{{+++ b/src/main/java/org/apache/maven/plugins/javadoc/JavadocUtil.java}}
{{@@ -904,6 +904,9 @@ public class JavadocUtil {}}
{{ for (JarEntry jarEntry = jarStream.getNextJarEntry();}}
{{ jarEntry != null;}}
{{ jarEntry = jarStream.getNextJarEntry()) {}}
{{+ if ("module-info.class".equals(jarEntry.getName())) {}}
{{+ continue;}}
{{+ }}}
{{ Matcher matcher = pattern.matcher(jarEntry.getName());}}
{{ if (matcher.matches()) {}}
{{ String version = matcher.group("v");}}
> Taglet autodetection fails when taglets JAR includes a module-info.class
>
>
> Key: MJAVADOC-794
> URL: https://issues.apache.org/jira/browse/MJAVADOC-794
> Project: Maven Javadoc Plugin
> Issue Type: Bug
>Affects Versions: 3.6.3
>Reporter: Curtis Rueden
>Priority: Major
>
> Due to a bug in the maven-javadoc-plugin, the following warning gets emitted
> when a JPMS-modularized artifact containing taglets is included in the
> javadoc build via a `` tag:
> {{ [WARNING] Unable to auto-detect Taglet class names from}}
> {{ '/path/to/jar.jar'. Try to specify them with .}}
> Running with `mvn -X` shows the underlying cause:
> {{ NoClassDefFoundError: module-info is not a}}
> {{ class because access_flag ACC_MODULE is set}}
> Removing the {{module-info.java}} from the component avoids the problem.
> The following patch fixes the problem as of {{{}ded56a90{}}}:
> {{diff --git
> a/src/main/java/org/apache/maven/plugins/javadoc/JavadocUtil.java
> b/src/main/java/org/apache/maven/plugins/ja>}}
> {{index 835d6332..6e29eadf 100644}}
> {{--- a/src/main/java/org/apache/maven/plugins/javadoc/JavadocUtil.java}}
> {{+++ b/src/main/java/org/apache/maven/plugins/javadoc/JavadocUtil.java}}
> {{@@ -904,6 +904,9 @@ public class JavadocUtil {}}
> {{ for (JarEntry jarEntry = jarStream.getNextJarEntry();}}
> {{ jarEntry != null;}}
> {{ jarEntry = jarStream.getNextJarEntry()) {}}
> {{+ if ("module-info.class".equals(jarEntry.getName())) {}}
> {{+ continue;}}
> {{+ }}}
> {{ Matcher matcher = pattern.matcher(jarEntry.getName());}}
> {{ if (matcher.matches()) {}}
> {{
[jira] [Updated] (MJAVADOC-794) Taglet autodetection fails when taglets JAR includes a module-info.class
[
https://issues.apache.org/jira/browse/MJAVADOC-794?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Curtis Rueden updated MJAVADOC-794:
---
Description:
Due to a bug in the maven-javadoc-plugin, the following warning gets emitted
when a JPMS-modularized artifact containing taglets is included in the javadoc
build via a `` tag:
{{ [WARNING] Unable to auto-detect Taglet class names from}}
{{ '/path/to/jar.jar'. Try to specify them with .}}
Running with {{mvn -X}} shows the underlying cause:
{{ NoClassDefFoundError: module-info is not a}}
{{ class because access_flag ACC_MODULE is set}}
Removing the {{module-info.java}} from the component avoids the problem.
The following patch fixes the problem as of {{{}ded56a90{}}}:
{{diff --git a/src/main/java/org/apache/maven/plugins/javadoc/JavadocUtil.java
b/src/main/java/org/apache/maven/plugins/ja>}}
{{index 835d6332..6e29eadf 100644}}
{{--- a/src/main/java/org/apache/maven/plugins/javadoc/JavadocUtil.java}}
{{+++ b/src/main/java/org/apache/maven/plugins/javadoc/JavadocUtil.java}}
{{@@ -904,6 +904,9 @@ public class JavadocUtil {}}
{{ for (JarEntry jarEntry = jarStream.getNextJarEntry();}}
{{ jarEntry != null;}}
{{ jarEntry = jarStream.getNextJarEntry()) {}}
{{+ if ("module-info.class".equals(jarEntry.getName())) {}}
{{+ continue;}}
{{+ }}}
{{ Matcher matcher = pattern.matcher(jarEntry.getName());}}
{{ if (matcher.matches()) {}}
{{ String version = matcher.group("v");}}
was:
Due to a bug in the maven-javadoc-plugin, the following warning gets emitted
when a JPMS-modularized artifact containing taglets is included in the javadoc
build via a `` tag:
{{ [WARNING] Unable to auto-detect Taglet class names from}}
{{ '/path/to/jar.jar'. Try to specify them with .}}
Running with `mvn -X` shows the underlying cause:
{{ NoClassDefFoundError: module-info is not a}}
{{ class because access_flag ACC_MODULE is set}}
Removing the {{module-info.java}} from the component avoids the problem.
The following patch fixes the problem as of {{{}ded56a90{}}}:
{{diff --git a/src/main/java/org/apache/maven/plugins/javadoc/JavadocUtil.java
b/src/main/java/org/apache/maven/plugins/ja>}}
{{index 835d6332..6e29eadf 100644}}
{{--- a/src/main/java/org/apache/maven/plugins/javadoc/JavadocUtil.java}}
{{+++ b/src/main/java/org/apache/maven/plugins/javadoc/JavadocUtil.java}}
{{@@ -904,6 +904,9 @@ public class JavadocUtil {}}
{{ for (JarEntry jarEntry = jarStream.getNextJarEntry();}}
{{ jarEntry != null;}}
{{ jarEntry = jarStream.getNextJarEntry()) {}}
{{+ if ("module-info.class".equals(jarEntry.getName())) {}}
{{+ continue;}}
{{+ }}}
{{ Matcher matcher = pattern.matcher(jarEntry.getName());}}
{{ if (matcher.matches()) {}}
{{ String version = matcher.group("v");}}
> Taglet autodetection fails when taglets JAR includes a module-info.class
>
>
> Key: MJAVADOC-794
> URL: https://issues.apache.org/jira/browse/MJAVADOC-794
> Project: Maven Javadoc Plugin
> Issue Type: Bug
>Affects Versions: 3.6.3
>Reporter: Curtis Rueden
>Priority: Major
>
> Due to a bug in the maven-javadoc-plugin, the following warning gets emitted
> when a JPMS-modularized artifact containing taglets is included in the
> javadoc build via a `` tag:
> {{ [WARNING] Unable to auto-detect Taglet class names from}}
> {{ '/path/to/jar.jar'. Try to specify them with .}}
> Running with {{mvn -X}} shows the underlying cause:
> {{ NoClassDefFoundError: module-info is not a}}
> {{ class because access_flag ACC_MODULE is set}}
> Removing the {{module-info.java}} from the component avoids the problem.
> The following patch fixes the problem as of {{{}ded56a90{}}}:
> {{diff --git
> a/src/main/java/org/apache/maven/plugins/javadoc/JavadocUtil.java
> b/src/main/java/org/apache/maven/plugins/ja>}}
> {{index 835d6332..6e29eadf 100644}}
> {{--- a/src/main/java/org/apache/maven/plugins/javadoc/JavadocUtil.java}}
> {{+++ b/src/main/java/org/apache/maven/plugins/javadoc/JavadocUtil.java}}
> {{@@ -904,6 +904,9 @@ public class JavadocUtil {}}
> {{ for (JarEntry jarEntry = jarStream.getNextJarEntry();}}
> {{ jarEntry != null;}}
> {{ jarEntry = jarStream.getNextJarEntry()) {}}
> {{+ if ("module-info.class".equals(jarEntry.getName())) {}}
> {{+ continue;}}
> {{+ }}}
> {{ Matcher matcher = pattern.matcher(jarEntry.getName());}}
> {{ if (matcher.matches()) {}}
> {{
[jira] [Updated] (MJAVADOC-794) Taglet autodetection fails when taglets JAR includes a module-info.class
[
https://issues.apache.org/jira/browse/MJAVADOC-794?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Curtis Rueden updated MJAVADOC-794:
---
Description:
Due to a bug in the maven-javadoc-plugin, the following warning gets emitted
with a JPMS-modularized artifact containing taglets is included in the javadoc
build via a `` tag:
{{ [WARNING] Unable to auto-detect Taglet class names from}}
{{ '/path/to/jar.jar'. Try to specify them with .}}
Running with `mvn -X` shows the underlying cause:
{{ NoClassDefFoundError: module-info is not a}}
{{ class because access_flag ACC_MODULE is set}}
Removing the {{module-info.java}} from the component avoids the problem.
The following patch fixes the problem as of {{{}ded56a90{}}}:
{{diff --git a/src/main/java/org/apache/maven/plugins/javadoc/JavadocUtil.java
b/src/main/java/org/apache/maven/plugins/ja>}}
{{index 835d6332..6e29eadf 100644}}
{{--- a/src/main/java/org/apache/maven/plugins/javadoc/JavadocUtil.java}}
{{+++ b/src/main/java/org/apache/maven/plugins/javadoc/JavadocUtil.java}}
{{@@ -904,6 +904,9 @@ public class JavadocUtil {}}
{{ for (JarEntry jarEntry = jarStream.getNextJarEntry();}}
{{ jarEntry != null;}}
{{ jarEntry = jarStream.getNextJarEntry()) {}}
{{+ if ("module-info.class".equals(jarEntry.getName())) {}}
{{+ continue;}}
{{+ }}}
{{ Matcher matcher = pattern.matcher(jarEntry.getName());}}
{{ if (matcher.matches()) {}}
{{ String version = matcher.group("v");}}
was:
Due to a bug in the maven-javadoc-plugin, the following warning gets
emitted with the scijava-taglets artifact included in the javadoc build:
[WARNING] Unable to auto-detect Taglet class names from
'/path/to/jar.jar'. Try to specify them with .
Running with `mvn -X` shows the underlying cause:
NoClassDefFoundError: module-info is not a
class because access_flag ACC_MODULE is set
Removing scijava-taglets's module-info.java avoids the problem.
> Taglet autodetection fails when taglets JAR includes a module-info.class
>
>
> Key: MJAVADOC-794
> URL: https://issues.apache.org/jira/browse/MJAVADOC-794
> Project: Maven Javadoc Plugin
> Issue Type: Bug
>Affects Versions: 3.6.3
>Reporter: Curtis Rueden
>Priority: Major
>
> Due to a bug in the maven-javadoc-plugin, the following warning gets emitted
> with a JPMS-modularized artifact containing taglets is included in the
> javadoc build via a `` tag:
> {{ [WARNING] Unable to auto-detect Taglet class names from}}
> {{ '/path/to/jar.jar'. Try to specify them with .}}
> Running with `mvn -X` shows the underlying cause:
> {{ NoClassDefFoundError: module-info is not a}}
> {{ class because access_flag ACC_MODULE is set}}
> Removing the {{module-info.java}} from the component avoids the problem.
> The following patch fixes the problem as of {{{}ded56a90{}}}:
> {{diff --git
> a/src/main/java/org/apache/maven/plugins/javadoc/JavadocUtil.java
> b/src/main/java/org/apache/maven/plugins/ja>}}
> {{index 835d6332..6e29eadf 100644}}
> {{--- a/src/main/java/org/apache/maven/plugins/javadoc/JavadocUtil.java}}
> {{+++ b/src/main/java/org/apache/maven/plugins/javadoc/JavadocUtil.java}}
> {{@@ -904,6 +904,9 @@ public class JavadocUtil {}}
> {{ for (JarEntry jarEntry = jarStream.getNextJarEntry();}}
> {{ jarEntry != null;}}
> {{ jarEntry = jarStream.getNextJarEntry()) {}}
> {{+ if ("module-info.class".equals(jarEntry.getName())) {}}
> {{+ continue;}}
> {{+ }}}
> {{ Matcher matcher = pattern.matcher(jarEntry.getName());}}
> {{ if (matcher.matches()) {}}
> {{ String version = matcher.group("v");}}
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Updated] (MJAVADOC-794) Taglet autodetection fails when taglets JAR includes a module-info.class
[ https://issues.apache.org/jira/browse/MJAVADOC-794?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Curtis Rueden updated MJAVADOC-794: --- Affects Version/s: 3.6.3 > Taglet autodetection fails when taglets JAR includes a module-info.class > > > Key: MJAVADOC-794 > URL: https://issues.apache.org/jira/browse/MJAVADOC-794 > Project: Maven Javadoc Plugin > Issue Type: Bug >Affects Versions: 3.6.3 >Reporter: Curtis Rueden >Priority: Major > > Due to a bug in the maven-javadoc-plugin, the following warning gets > emitted with the scijava-taglets artifact included in the javadoc build: > [WARNING] Unable to auto-detect Taglet class names from > '/path/to/jar.jar'. Try to specify them with . > Running with `mvn -X` shows the underlying cause: > NoClassDefFoundError: module-info is not a > class because access_flag ACC_MODULE is set > Removing scijava-taglets's module-info.java avoids the problem. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (MJAVADOC-794) Taglet autodetection fails when taglets JAR includes a module-info.class
[ https://issues.apache.org/jira/browse/MJAVADOC-794?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Curtis Rueden updated MJAVADOC-794: --- Description: Due to a bug in the maven-javadoc-plugin, the following warning gets emitted with the scijava-taglets artifact included in the javadoc build: [WARNING] Unable to auto-detect Taglet class names from '/path/to/jar.jar'. Try to specify them with . Running with `mvn -X` shows the underlying cause: NoClassDefFoundError: module-info is not a class because access_flag ACC_MODULE is set Removing scijava-taglets's module-info.java avoids the problem. > Taglet autodetection fails when taglets JAR includes a module-info.class > > > Key: MJAVADOC-794 > URL: https://issues.apache.org/jira/browse/MJAVADOC-794 > Project: Maven Javadoc Plugin > Issue Type: Bug >Reporter: Curtis Rueden >Priority: Major > > Due to a bug in the maven-javadoc-plugin, the following warning gets > emitted with the scijava-taglets artifact included in the javadoc build: > [WARNING] Unable to auto-detect Taglet class names from > '/path/to/jar.jar'. Try to specify them with . > Running with `mvn -X` shows the underlying cause: > NoClassDefFoundError: module-info is not a > class because access_flag ACC_MODULE is set > Removing scijava-taglets's module-info.java avoids the problem. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (MJAVADOC-794) Taglet autodetection fails when taglets JAR includes a module-info.class
Curtis Rueden created MJAVADOC-794: -- Summary: Taglet autodetection fails when taglets JAR includes a module-info.class Key: MJAVADOC-794 URL: https://issues.apache.org/jira/browse/MJAVADOC-794 Project: Maven Javadoc Plugin Issue Type: Bug Reporter: Curtis Rueden -- This message was sent by Atlassian Jira (v8.20.10#820010)
[PR] Bump org.slf4j:slf4j-api from 1.7.36 to 2.0.13 [maven-invoker-plugin]
dependabot[bot] opened a new pull request, #245: URL: https://github.com/apache/maven-invoker-plugin/pull/245 Bumps org.slf4j:slf4j-api from 1.7.36 to 2.0.13. [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] Bump org.codehaus.plexus:plexus-xml from 3.0.1 to 4.0.4 [maven-invoker-plugin]
dependabot[bot] opened a new pull request, #244: URL: https://github.com/apache/maven-invoker-plugin/pull/244 Bumps [org.codehaus.plexus:plexus-xml](https://github.com/codehaus-plexus/plexus-xml) from 3.0.1 to 4.0.4. Release notes Sourced from https://github.com/codehaus-plexus/plexus-xml/releases";>org.codehaus.plexus:plexus-xml's releases. 4.0.4 🐛 Bug Fixes Allow nulls for write elements in MXSerializer (https://redirect.github.com/codehaus-plexus/plexus-xml/pull/29";>#29) https://github.com/garydgregory";>@garydgregory Remove special chars from xml output (https://redirect.github.com/codehaus-plexus/plexus-xml/pull/28";>#28) https://github.com/slawekjaranowski";>@slawekjaranowski 📦 Dependency updates Bump org.codehaus.plexus:plexus from 17 to 18 (https://redirect.github.com/codehaus-plexus/plexus-xml/pull/39";>#39) https://github.com/dependabot";>@dependabot Bump org.codehaus.plexus:plexus from 16 to 17 (https://redirect.github.com/codehaus-plexus/plexus-xml/pull/35";>#35) https://github.com/dependabot";>@dependabot Bump org.codehaus.plexus:plexus-utils from 4.0.0 to 4.0.1 (https://redirect.github.com/codehaus-plexus/plexus-xml/pull/37";>#37) https://github.com/dependabot";>@dependabot Bump release-drafter/release-drafter from 5 to 6 (https://redirect.github.com/codehaus-plexus/plexus-xml/pull/34";>#34) https://github.com/dependabot";>@dependabot 4.0.3 What's Changed explain 3 vs 4 by https://github.com/hboutemy";>@hboutemy in https://redirect.github.com/codehaus-plexus/plexus-xml/pull/24";>codehaus-plexus/plexus-xml#24 Update dependencies by https://github.com/cstamas";>@cstamas in https://redirect.github.com/codehaus-plexus/plexus-xml/pull/26";>codehaus-plexus/plexus-xml#26 Upgrade to Maven 4.0.0-alpha-9 by https://github.com/gnodet";>@gnodet in https://redirect.github.com/codehaus-plexus/plexus-xml/pull/27";>codehaus-plexus/plexus-xml#27 New Contributors https://github.com/cstamas";>@cstamas made their first contribution in https://redirect.github.com/codehaus-plexus/plexus-xml/pull/26";>codehaus-plexus/plexus-xml#26 Full Changelog: https://github.com/codehaus-plexus/plexus-xml/compare/plexus-xml-4.0.2...plexus-xml-4.0.3";>https://github.com/codehaus-plexus/plexus-xml/compare/plexus-xml-4.0.2...plexus-xml-4.0.3 4.0.2 What's Changed Cleanup after parent pom upgrade by https://github.com/slachiewicz";>@slachiewicz in https://redirect.github.com/codehaus-plexus/plexus-xml/pull/22";>codehaus-plexus/plexus-xml#22 Upgrade to 4.0.0-alpha-7 and exclude dependency to sisu (fixes https://redirect.github.com/codehaus-plexus/plexus-xml/issues/17";>#17) by https://github.com/gnodet";>@gnodet in https://redirect.github.com/codehaus-plexus/plexus-xml/pull/23";>codehaus-plexus/plexus-xml#23 New Contributors https://github.com/slachiewicz";>@slachiewicz made their first contribution in https://redirect.github.com/codehaus-plexus/plexus-xml/pull/22";>codehaus-plexus/plexus-xml#22 Full Changelog: https://github.com/codehaus-plexus/plexus-xml/compare/plexus-xml-4.0.1...plexus-xml-4.0.2";>https://github.com/codehaus-plexus/plexus-xml/compare/plexus-xml-4.0.1...plexus-xml-4.0.2 4.0.0 Use spotless (https://redirect.github.com/codehaus-plexus/plexus-xml/pull/8";>#8) https://github.com/gnodet";>@gnodet Fix site generation (https://redirect.github.com/codehaus-plexus/plexus-xml/pull/15";>#15) https://github.com/gnodet";>@gnodet Switch build ci workflow to master branch (https://redirect.github.com/codehaus-plexus/plexus-xml/pull/14";>#14) https://github.com/gnodet";>@gnodet Fix SCM urls (https://redirect.github.com/codehaus-plexus/plexus-xml/pull/13";>#13) https://github.com/gnodet";>@gnodet MXParser tokenization fails when PI is before first tag (fixes https://redirect.github.com/codehaus-plexus/plexus-xml/issues/7";>#7) (https://redirect.github.com/codehaus-plexus/plexus-xml/pull/12";>#12) https://github.com/gnodet";>@gnodet Deprecate Xpp3DomUtils (fixes https://redirect.github.com/codehaus-plexus/plexus-xml/issues/6";>#6) (https://redirect.github.com/codehaus-plexus/plexus-xml/pull/9";>#9) https://github.com/gnodet";>@gnodet Use a ArrayDeque (https://redirect.github.com/codehaus-plexus/plexus-xml/pull/5";>#5) https://github.com/gnodet";>@gnodet Upgrade plugins and clean build warnings (https://redirect.github.com/codehaus-plexus/plexus-xml/pull/4";>#4) https://github.com/gnodet";>@gnodet Switch to junit 5 (https://redirect.github.com/codehaus-plexus/plexus-xml/pull/2";>#2) https://github.com/gnodet";>@gnodet Fix parsing an UTF-8 file without BOM and ISO-8859-1 encoding (https://redirect.github.com/codehaus-plexus/plexus-xml/pull/1";>#1) https://github.com/gnodet";>@gnodet Commits https://github.com/codehaus-plexus/plexus-xml/commit/f25521bc31d321c2ffb57cf26ae17f745c2c35a6";>f
[PR] Bump org.apache.maven.resolver:maven-resolver-api from 1.4.1 to 1.9.20 [maven-invoker-plugin]
dependabot[bot] opened a new pull request, #243: URL: https://github.com/apache/maven-invoker-plugin/pull/243 Bumps [org.apache.maven.resolver:maven-resolver-api](https://github.com/apache/maven-resolver) from 1.4.1 to 1.9.20. Release notes Sourced from https://github.com/apache/maven-resolver/releases";>org.apache.maven.resolver:maven-resolver-api's releases. 1.9.20 https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12320628&version=12354578";>Release Notes - Maven Resolver - Version 1.9.20 What's Changed [MRESOLVER-547] Just use setVersion by https://github.com/cstamas";>@cstamas in https://redirect.github.com/apache/maven-resolver/pull/483";>apache/maven-resolver#483 [MRESOLVER-549] Parent POM 42 by https://github.com/cstamas";>@cstamas in https://redirect.github.com/apache/maven-resolver/pull/484";>apache/maven-resolver#484 Full Changelog: https://github.com/apache/maven-resolver/compare/maven-resolver-1.9.19...maven-resolver-1.9.20";>https://github.com/apache/maven-resolver/compare/maven-resolver-1.9.19...maven-resolver-1.9.20 1.9.19 https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12320628&version=12353946";>Release Notes - Maven Resolver - Version 1.9.19 ... (truncated) Commits https://github.com/apache/maven-resolver/commit/f5fbc245e64091a41ba0926a6958b98bf0b29eb3";>f5fbc24 [maven-release-plugin] prepare release maven-resolver-1.9.20 https://github.com/apache/maven-resolver/commit/446009d7073014a7d418a4b9637664a2f6d05c82";>446009d [MRESOLVER-549][MRESOLVER-550][MRESOLVER-551] Parent POM 42 (https://redirect.github.com/apache/maven-resolver/issues/484";>#484) https://github.com/apache/maven-resolver/commit/4f16d5ecd94f85e6e7d793e6b6b82f20c9afbf56";>4f16d5e [MRESOLVER-547] Just use setVersion (https://redirect.github.com/apache/maven-resolver/issues/483";>#483) https://github.com/apache/maven-resolver/commit/c1b24c699621930f4eb77721400f2f6c46930626";>c1b24c6 [maven-release-plugin] prepare for next development iteration https://github.com/apache/maven-resolver/commit/c1b03574961fd2daa7a678bb3fbf9f0779afee56";>c1b0357 [maven-release-plugin] prepare release maven-resolver-1.9.19 https://github.com/apache/maven-resolver/commit/adadd42d1642f39bafedb2ddd619b044fecb12b0";>adadd42 [MRESOLVER-536] Do not belly up if FS does not support setting mtime (https://redirect.github.com/apache/maven-resolver/issues/469";>#469) https://github.com/apache/maven-resolver/commit/31df8a3dc503895172d277de56b1c4a53da0a27c";>31df8a3 [1.9.x] Update dependencies (https://redirect.github.com/apache/maven-resolver/issues/462";>#462) https://github.com/apache/maven-resolver/commit/b225076e5d5b2fe3f166a4018802ac94b7cc94f7";>b225076 [MRESOLVER-522] Improve congested file locks behaviour (https://redirect.github.com/apache/maven-resolver/issues/455";>#455) (https://redirect.github.com/apache/maven-resolver/issues/461";>#461) https://github.com/apache/maven-resolver/commit/fc969c2570041bb72c3f0141ff4957e8754f365c";>fc969c2 [1.9.x][MRESOLVER-483] Fix path concatenation logic (https://redirect.github.com/apache/maven-resolver/issues/420";>#420) https://github.com/apache/maven-resolver/commit/a3e620d6d2ab6ca58d42d264347341b31da00dde";>a3e620d Use one Maven in CI Additional commits viewable in https://github.com/apache/maven-resolver/compare/maven-resolver-1.4.1...maven-resolver-1.9.20";>compare view [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show ignore conditions` will show all of the ignore conditions of the specified dependency - `@dep
[PR] Bump org.junit:junit-bom from 5.10.1 to 5.10.2 [maven]
dependabot[bot] opened a new pull request, #1535: URL: https://github.com/apache/maven/pull/1535 Bumps [org.junit:junit-bom](https://github.com/junit-team/junit5) from 5.10.1 to 5.10.2. Release notes Sourced from https://github.com/junit-team/junit5/releases";>org.junit:junit-bom's releases. JUnit 5.10.2 = Platform 1.10.2 + Jupiter 5.10.2 + Vintage 5.10.2 See http://junit.org/junit5/docs/5.10.2/release-notes/";>Release Notes. Full Changelog: https://github.com/junit-team/junit5/compare/r5.10.1...r5.10.2";>https://github.com/junit-team/junit5/compare/r5.10.1...r5.10.2 Commits https://github.com/junit-team/junit5/commit/4c0dddad1b96d4a20e92a2cd583954643ac56ac0";>4c0ddda Release 5.10.2 https://github.com/junit-team/junit5/commit/463a14773d884f2bf31f073a87bef9d0938872db";>463a147 Finalize release notes for 5.10.2 https://github.com/junit-team/junit5/commit/43c105a246c0130d08145335cb9986236e2a8465";>43c105a Revert "Apply method predicate before searching type hierarchy" https://github.com/junit-team/junit5/commit/63d464d1e10a62743fe4024436ef1e006a89df72";>63d464d Revert "Harmonize application of method and field filters in search algorithms" https://github.com/junit-team/junit5/commit/85ec2fccb32a51fbe6ff966e25726c94a67dd418";>85ec2fc Revert "Apply field predicate before searching type hierarchy" https://github.com/junit-team/junit5/commit/6209006a7693dbf6f680a5ac4541aba86c9da899";>6209006 Update release notes https://github.com/junit-team/junit5/commit/5ee499f0e0029dbd1120ecf889bd214e2082c589";>5ee499f Fix CI build https://github.com/junit-team/junit5/commit/d919ba71ea4c3b1e60f2d21473ba31ff0f6857ab";>d919ba7 Namespace user-specific build parameters https://github.com/junit-team/junit5/commit/e26cd83ed307ef100399ced9985f04612931984b";>e26cd83 Prepare release notes for 5.10.2 https://github.com/junit-team/junit5/commit/ec8d4282c60f480d3de264330b37e75b1b8d05d9";>ec8d428 Include LauncherInterceptor in launcher module declaration Additional commits viewable in https://github.com/junit-team/junit5/compare/r5.10.1...r5.10.2";>compare view [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] Bump commons-cli:commons-cli from 1.5.0 to 1.7.0 [maven]
dependabot[bot] opened a new pull request, #1536: URL: https://github.com/apache/maven/pull/1536 Bumps commons-cli:commons-cli from 1.5.0 to 1.7.0. [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] Bump commons-io:commons-io from 2.11.0 to 2.16.1 [maven]
dependabot[bot] opened a new pull request, #1534: URL: https://github.com/apache/maven/pull/1534 Bumps commons-io:commons-io from 2.11.0 to 2.16.1. [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MDEP-929) Bump org.apache.maven.shared:maven-dependency-analyzer from 1.13.2 to 1.14.1
[ https://issues.apache.org/jira/browse/MDEP-929?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17848768#comment-17848768 ] ASF GitHub Bot commented on MDEP-929: - slawekjaranowski merged PR #394: URL: https://github.com/apache/maven-dependency-plugin/pull/394 > Bump org.apache.maven.shared:maven-dependency-analyzer from 1.13.2 to 1.14.1 > > > Key: MDEP-929 > URL: https://issues.apache.org/jira/browse/MDEP-929 > Project: Maven Dependency Plugin > Issue Type: Dependency upgrade >Reporter: Slawomir Jaranowski >Assignee: Slawomir Jaranowski >Priority: Major > Fix For: 3.7.0 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] [MDEP-929] Bump org.apache.maven.shared:maven-dependency-analyzer from 1.14.0 to 1.14.1 [maven-dependency-plugin]
slawekjaranowski merged PR #394: URL: https://github.com/apache/maven-dependency-plugin/pull/394 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Reopened] (MDEP-929) Bump org.apache.maven.shared:maven-dependency-analyzer from 1.13.2 to 1.14.1
[ https://issues.apache.org/jira/browse/MDEP-929?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Slawomir Jaranowski reopened MDEP-929: -- > Bump org.apache.maven.shared:maven-dependency-analyzer from 1.13.2 to 1.14.1 > > > Key: MDEP-929 > URL: https://issues.apache.org/jira/browse/MDEP-929 > Project: Maven Dependency Plugin > Issue Type: Dependency upgrade >Reporter: Slawomir Jaranowski >Assignee: Slawomir Jaranowski >Priority: Major > Fix For: 3.7.0 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (MDEP-929) Bump org.apache.maven.shared:maven-dependency-analyzer from 1.13.2 to 1.14.1
[ https://issues.apache.org/jira/browse/MDEP-929?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Slawomir Jaranowski updated MDEP-929: - Summary: Bump org.apache.maven.shared:maven-dependency-analyzer from 1.13.2 to 1.14.1 (was: Bump org.apache.maven.shared:maven-dependency-analyzer from 1.13.2 to 1.14.0) > Bump org.apache.maven.shared:maven-dependency-analyzer from 1.13.2 to 1.14.1 > > > Key: MDEP-929 > URL: https://issues.apache.org/jira/browse/MDEP-929 > Project: Maven Dependency Plugin > Issue Type: Dependency upgrade >Reporter: Slawomir Jaranowski >Assignee: Slawomir Jaranowski >Priority: Major > Fix For: 3.7.0 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[PR] Bump org.apache.maven.shared:maven-dependency-analyzer from 1.14.0 to 1.14.1 [maven-dependency-plugin]
dependabot[bot] opened a new pull request, #394: URL: https://github.com/apache/maven-dependency-plugin/pull/394 Bumps [org.apache.maven.shared:maven-dependency-analyzer](https://github.com/apache/maven-dependency-analyzer) from 1.14.0 to 1.14.1. Release notes Sourced from https://github.com/apache/maven-dependency-analyzer/releases";>org.apache.maven.shared:maven-dependency-analyzer's releases. 1.14.1 What's Changed [MSHARED-1398] Fix StringIndexOutOfBoundsException in dynamic bootstrap types by https://github.com/jaredstehler";>@jaredstehler in https://redirect.github.com/apache/maven-dependency-analyzer/pull/121";>apache/maven-dependency-analyzer#121 New Contributors https://github.com/jaredstehler";>@jaredstehler made their first contribution in https://redirect.github.com/apache/maven-dependency-analyzer/pull/121";>apache/maven-dependency-analyzer#121 Full Changelog: https://github.com/apache/maven-dependency-analyzer/compare/maven-dependency-analyzer-1.14.0...maven-dependency-analyzer-1.14.1";>https://github.com/apache/maven-dependency-analyzer/compare/maven-dependency-analyzer-1.14.0...maven-dependency-analyzer-1.14.1 Commits https://github.com/apache/maven-dependency-analyzer/commit/a9344641854e3e47c3dace32a145df6878785b27";>a934464 [maven-release-plugin] prepare release maven-dependency-analyzer-1.14.1 https://github.com/apache/maven-dependency-analyzer/commit/22d52ac19501c21492acff3588f52f507be0e33f";>22d52ac [MSHARED-1398] Fix StringIndexOutOfBoundsException in dynamic bootstrap types... https://github.com/apache/maven-dependency-analyzer/commit/60ff72139c36b88bf1722d2b68bc26643e0ec6c4";>60ff721 [maven-release-plugin] prepare for next development iteration See full diff in https://github.com/apache/maven-dependency-analyzer/compare/maven-dependency-analyzer-1.14.0...maven-dependency-analyzer-1.14.1";>compare view [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MNG-7902) sort plugins in validation report
[
https://issues.apache.org/jira/browse/MNG-7902?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17848764#comment-17848764
]
ASF GitHub Bot commented on MNG-7902:
-
slawekjaranowski commented on code in PR #1510:
URL: https://github.com/apache/maven/pull/1510#discussion_r1610727735
##
maven-core/src/main/java/org/apache/maven/plugin/internal/DefaultPluginValidationManager.java:
##
@@ -203,7 +204,7 @@ public void reportPluginMojoValidationIssue(
mayReportInline(mavenSession.getRepositorySession(), locality, issue);
}
-private void reportSessionCollectedValidationIssues(MavenSession
mavenSession) {
+public void reportSessionCollectedValidationIssues(MavenSession
mavenSession) {
Review Comment:
why change to `public`?
> sort plugins in validation report
> -
>
> Key: MNG-7902
> URL: https://issues.apache.org/jira/browse/MNG-7902
> Project: Maven
> Issue Type: Improvement
> Components: Core
>Reporter: Michael Keppler
>Priority: Minor
> Attachments: image-2023-10-07-13-33-27-762.png
>
>
> Please don't ever output the content of a Set for consumption by humans
> without sorting it first. The order is otherwise "random". Sorting (case
> insensitive) makes the same output easier to read, especially when trying to
> find one specific entry (e.g. "Did we fix plugin foo already?")
> !image-2023-10-07-13-33-27-762.png!
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
Re: [PR] [MNG-7902] Sort plugins in the validation report [maven]
slawekjaranowski commented on code in PR #1510:
URL: https://github.com/apache/maven/pull/1510#discussion_r1610727735
##
maven-core/src/main/java/org/apache/maven/plugin/internal/DefaultPluginValidationManager.java:
##
@@ -203,7 +204,7 @@ public void reportPluginMojoValidationIssue(
mayReportInline(mavenSession.getRepositorySession(), locality, issue);
}
-private void reportSessionCollectedValidationIssues(MavenSession
mavenSession) {
+public void reportSessionCollectedValidationIssues(MavenSession
mavenSession) {
Review Comment:
why change to `public`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Commented] (MNG-7902) sort plugins in validation report
[ https://issues.apache.org/jira/browse/MNG-7902?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17848761#comment-17848761 ] ASF GitHub Bot commented on MNG-7902: - yuehcw commented on code in PR #1510: URL: https://github.com/apache/maven/pull/1510#discussion_r1610724857 ## maven-core/src/main/java/org/apache/maven/plugin/internal/DefaultPluginValidationManager.java: ## @@ -23,17 +23,7 @@ import java.nio.file.Path; import java.nio.file.Paths; -import java.util.Arrays; -import java.util.Collection; -import java.util.Collections; -import java.util.EnumSet; -import java.util.HashMap; -import java.util.LinkedHashMap; -import java.util.LinkedHashSet; -import java.util.List; -import java.util.Locale; -import java.util.Map; -import java.util.Set; +import java.util.*; Review Comment: Hello, I have made the requested changes and pushed the new commit to this pull request. Please review the updates at your earliest convenience. Thank you for your feedback and guidance! > sort plugins in validation report > - > > Key: MNG-7902 > URL: https://issues.apache.org/jira/browse/MNG-7902 > Project: Maven > Issue Type: Improvement > Components: Core >Reporter: Michael Keppler >Priority: Minor > Attachments: image-2023-10-07-13-33-27-762.png > > > Please don't ever output the content of a Set for consumption by humans > without sorting it first. The order is otherwise "random". Sorting (case > insensitive) makes the same output easier to read, especially when trying to > find one specific entry (e.g. "Did we fix plugin foo already?") > !image-2023-10-07-13-33-27-762.png! -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MNG-7902) sort plugins in validation report
[
https://issues.apache.org/jira/browse/MNG-7902?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17848762#comment-17848762
]
ASF GitHub Bot commented on MNG-7902:
-
yuehcw commented on code in PR #1510:
URL: https://github.com/apache/maven/pull/1510#discussion_r1610725091
##
maven-core/src/main/java/org/apache/maven/plugin/internal/DefaultPluginValidationManager.java:
##
@@ -222,7 +212,12 @@ private void
reportSessionCollectedValidationIssues(MavenSession mavenSession) {
logger.warn("");
logger.warn("Plugin {} validation issues were detected in
following plugin(s)", issueLocalitiesToReport);
logger.warn("");
-for (Map.Entry entry :
issuesMap.entrySet()) {
+
+// Sorting the plugins (Fix the open issue)
Review Comment:
Fixed!
> sort plugins in validation report
> -
>
> Key: MNG-7902
> URL: https://issues.apache.org/jira/browse/MNG-7902
> Project: Maven
> Issue Type: Improvement
> Components: Core
>Reporter: Michael Keppler
>Priority: Minor
> Attachments: image-2023-10-07-13-33-27-762.png
>
>
> Please don't ever output the content of a Set for consumption by humans
> without sorting it first. The order is otherwise "random". Sorting (case
> insensitive) makes the same output easier to read, especially when trying to
> find one specific entry (e.g. "Did we fix plugin foo already?")
> !image-2023-10-07-13-33-27-762.png!
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
Re: [PR] [MNG-7902] Sort plugins in the validation report [maven]
yuehcw commented on code in PR #1510:
URL: https://github.com/apache/maven/pull/1510#discussion_r1610725091
##
maven-core/src/main/java/org/apache/maven/plugin/internal/DefaultPluginValidationManager.java:
##
@@ -222,7 +212,12 @@ private void
reportSessionCollectedValidationIssues(MavenSession mavenSession) {
logger.warn("");
logger.warn("Plugin {} validation issues were detected in
following plugin(s)", issueLocalitiesToReport);
logger.warn("");
-for (Map.Entry entry :
issuesMap.entrySet()) {
+
+// Sorting the plugins (Fix the open issue)
Review Comment:
Fixed!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] [MNG-7902] Sort plugins in the validation report [maven]
yuehcw commented on code in PR #1510: URL: https://github.com/apache/maven/pull/1510#discussion_r1610724857 ## maven-core/src/main/java/org/apache/maven/plugin/internal/DefaultPluginValidationManager.java: ## @@ -23,17 +23,7 @@ import java.nio.file.Path; import java.nio.file.Paths; -import java.util.Arrays; -import java.util.Collection; -import java.util.Collections; -import java.util.EnumSet; -import java.util.HashMap; -import java.util.LinkedHashMap; -import java.util.LinkedHashSet; -import java.util.List; -import java.util.Locale; -import java.util.Map; -import java.util.Set; +import java.util.*; Review Comment: Hello, I have made the requested changes and pushed the new commit to this pull request. Please review the updates at your earliest convenience. Thank you for your feedback and guidance! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [MPLUGIN-508] Upgrade to Maven 4.0.0-alpha-13 [maven-plugin-tools]
slawekjaranowski commented on code in PR #242: URL: https://github.com/apache/maven-plugin-tools/pull/242#discussion_r1610706745 ## pom.xml: ## @@ -333,6 +333,21 @@ + + + +true +never +fail + + +false + + maven-2126 + https://repository.apache.org/content/repositories/maven-2126/ Review Comment: should be a PR as draft -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MPLUGIN-508) Upgrade to Maven 4.0.0-alpha-12
[ https://issues.apache.org/jira/browse/MPLUGIN-508?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17848755#comment-17848755 ] ASF GitHub Bot commented on MPLUGIN-508: slawekjaranowski commented on code in PR #242: URL: https://github.com/apache/maven-plugin-tools/pull/242#discussion_r1610706745 ## pom.xml: ## @@ -333,6 +333,21 @@ + + + +true +never +fail + + +false + + maven-2126 + https://repository.apache.org/content/repositories/maven-2126/ Review Comment: should be a PR as draft > Upgrade to Maven 4.0.0-alpha-12 > --- > > Key: MPLUGIN-508 > URL: https://issues.apache.org/jira/browse/MPLUGIN-508 > Project: Maven Plugin Tools > Issue Type: Improvement >Affects Versions: 3.12.0 >Reporter: Guillaume Nodet >Assignee: Guillaume Nodet >Priority: Major > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MDEP-923) Code cleanups
[
https://issues.apache.org/jira/browse/MDEP-923?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17848754#comment-17848754
]
ASF GitHub Bot commented on MDEP-923:
-
slawekjaranowski commented on code in PR #389:
URL:
https://github.com/apache/maven-dependency-plugin/pull/389#discussion_r1610688853
##
src/main/java/org/apache/maven/plugins/dependency/utils/CopyUtil.java:
##
@@ -0,0 +1,70 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.maven.plugins.dependency.utils;
+
+import javax.inject.Inject;
+import javax.inject.Named;
+import javax.inject.Singleton;
+
+import java.io.File;
+import java.io.IOException;
+
+import org.apache.maven.plugin.MojoExecutionException;
+import org.apache.maven.plugin.logging.Log;
+import org.codehaus.plexus.util.FileUtils;
+import org.sonatype.plexus.build.incremental.BuildContext;
+
+/**
+ * Provide a copyFile method in one place.
+ */
+@Named
+@Singleton
+public class CopyUtil {
+
+private final BuildContext buildContext;
+
+@Inject
+public CopyUtil(BuildContext buildContext) {
+this.buildContext = buildContext;
+}
+
+/**
+ * Does the actual copy of the file and logging.
+ *
+ * @param source represents the file to copy.
+ * @param destination file name of destination file.
+ * @throws MojoExecutionException with a message if an error occurs.
+ */
+public void copyFile(Log log, File source, File destination) throws
MojoExecutionException {
+try {
+log.info("Copying " + source + " to " + destination);
+
+if (source.isDirectory()) {
+// usual case is a future jar packaging, but there are special
cases: classifier and other packaging
+throw new MojoExecutionException("Artifact has not been
packaged yet. When used on reactor artifact, "
++ "copy should be executed after packaging: see
MDEP-187.");
+}
+
+FileUtils.copyFile(source, destination);
+buildContext.refresh(destination);
+} catch (IOException e) {
Review Comment:
done - please look
> Code cleanups
> -
>
> Key: MDEP-923
> URL: https://issues.apache.org/jira/browse/MDEP-923
> Project: Maven Dependency Plugin
> Issue Type: Task
>Reporter: Slawomir Jaranowski
>Assignee: Slawomir Jaranowski
>Priority: Major
> Fix For: 3.7.0
>
>
> * remove usage of deprecated API where possible
> * cleanup pom after update to 42
> * exclude transitive dependencies on org.apache.maven
> * add {{@project.version@}} in ITs
> * Remove plexus logger from DependencySilentLog
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
Re: [PR] [MDEP-923] Extract copyFile method from AbstractDependencyMojo [maven-dependency-plugin]
slawekjaranowski commented on code in PR #389:
URL:
https://github.com/apache/maven-dependency-plugin/pull/389#discussion_r1610688853
##
src/main/java/org/apache/maven/plugins/dependency/utils/CopyUtil.java:
##
@@ -0,0 +1,70 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.maven.plugins.dependency.utils;
+
+import javax.inject.Inject;
+import javax.inject.Named;
+import javax.inject.Singleton;
+
+import java.io.File;
+import java.io.IOException;
+
+import org.apache.maven.plugin.MojoExecutionException;
+import org.apache.maven.plugin.logging.Log;
+import org.codehaus.plexus.util.FileUtils;
+import org.sonatype.plexus.build.incremental.BuildContext;
+
+/**
+ * Provide a copyFile method in one place.
+ */
+@Named
+@Singleton
+public class CopyUtil {
+
+private final BuildContext buildContext;
+
+@Inject
+public CopyUtil(BuildContext buildContext) {
+this.buildContext = buildContext;
+}
+
+/**
+ * Does the actual copy of the file and logging.
+ *
+ * @param source represents the file to copy.
+ * @param destination file name of destination file.
+ * @throws MojoExecutionException with a message if an error occurs.
+ */
+public void copyFile(Log log, File source, File destination) throws
MojoExecutionException {
+try {
+log.info("Copying " + source + " to " + destination);
+
+if (source.isDirectory()) {
+// usual case is a future jar packaging, but there are special
cases: classifier and other packaging
+throw new MojoExecutionException("Artifact has not been
packaged yet. When used on reactor artifact, "
++ "copy should be executed after packaging: see
MDEP-187.");
+}
+
+FileUtils.copyFile(source, destination);
+buildContext.refresh(destination);
+} catch (IOException e) {
Review Comment:
done - please look
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Closed] (MINVOKER-348) Build job report is truncated
[
https://issues.apache.org/jira/browse/MINVOKER-348?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Slawomir Jaranowski closed MINVOKER-348.
Resolution: Fixed
> Build job report is truncated
> -
>
> Key: MINVOKER-348
> URL: https://issues.apache.org/jira/browse/MINVOKER-348
> Project: Maven Invoker Plugin
> Issue Type: Bug
>Affects Versions: 3.5.1
>Reporter: Alvaro Sanchez-Mariscal
>Assignee: Slawomir Jaranowski
>Priority: Major
> Fix For: 3.7.0
>
> Attachments: BUILD-test-resources.xml, build.log
>
>
> The build-job.xml generated for a project is truncated:
> {code:xml}
>
> result="failure-post-hook" time="42.662"
> buildlog="/Users/alvaro/Dev/micronaut-projects/micronaut-maven-plugin/target/it/test-resources/build.log">
> Assertion failed:
> assert log.text.contains("BUILD SUCCESS")
>| ||
>| |false
>| '[INFO] Error stacktraces are turned on.\n[INFO] Scanning for
> projects...\n[WARNING] This build will only read from the build cache, since
> the clean lifecycle is not part of the build invocation.\n[INFO] \n[INFO]
> -<
> {code}
> Examining the build output, it gets truncated after a {{<}} appears, which is
> replaced in the XML with {{<}};, but then nothing else. Snippet following
> {noformat}
> [INFO] Error stacktraces are turned on.\n[INFO] Scanning for
> projects...\n[WARNING] This build will only read from the build cache, since
> the clean lifecycle is not part of the build invocation.\n[INFO] \n[INFO]
> -< io.micronaut.build.examples:test-resources
> >-\n[INFO]
> {noformat}
> Then, the verify mojo crashes when reading such file:
> {noformat}
> [ERROR] Failed to execute goal
> org.apache.maven.plugins:maven-invoker-plugin:3.5.1:verify (integration-test)
> on project micronaut-maven-integration-tests: Failed to read report file:
> /Users/alvaro/Dev/micronaut-projects/micronaut-maven-plugin/micronaut-maven-integration-tests/target/invoker-reports/BUILD-test-resources.xml:
> no more data available - expected end tags to
> close start tag from line 3 and start tag from
> line 2, parser stopped on START_TAG seen ...t part of the build
> invocation.\n[INFO] \n[INFO] -<... @8:242 -> [Help 1]
> {noformat}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Closed] (MINVOKER-351) Prevent XML-prohibited characters from entering JUnit report
[
https://issues.apache.org/jira/browse/MINVOKER-351?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Slawomir Jaranowski closed MINVOKER-351.
Resolution: Fixed
> Prevent XML-prohibited characters from entering JUnit report
>
>
> Key: MINVOKER-351
> URL: https://issues.apache.org/jira/browse/MINVOKER-351
> Project: Maven Invoker Plugin
> Issue Type: Bug
>Reporter: Mikkel Kjeldsen
>Assignee: Slawomir Jaranowski
>Priority: Major
> Fix For: 3.7.0
>
> Attachments: minvoker-351.tar.gz
>
>
> Neither the Maven Invoker plugin's implementation of {{}}
> nor the underlying XML infrastructure directly protect against the presence
> of character literals prohibited by the XML specification, meaning such
> literals can appear in the JUnit report and render it unreadable. *I would
> appreciate if the Maven Invoker plugin could learn to strip prohibited
> literals to protect its users from creative plugins.* I argue that this is a
> safe and expected transformation that is not materially lossy.
>
> h2. Background
> MINVOKER-196 added the {{}} option [back in
> maven-invoker-plugin-3.2.1|https://github.com/apache/maven-invoker-plugin/blob/maven-invoker-plugin-3.2.1/src/main/java/org/apache/maven/plugins/invoker/AbstractInvokerMojo.java#L1878-L1946].
> As of [maven-invoker-plugin-3.6.0 the effective implementation of the JUnit
> report remains effectively
> unchanged|https://github.com/apache/maven-invoker-plugin/blob/maven-invoker-plugin-3.6.0/src/main/java/org/apache/maven/plugins/invoker/AbstractInvokerMojo.java#L1695-L1754].
> The JUnit report includes a {{}} element ([example
> documentation|https://github.com/testmoapp/junitxml]) whose value Maven
> Invoker populates with the raw build log contents. I've observed that this
> value is XML-escaped, which I imagine is well understood in the
> implementation, although I can't immediately find documentation to support
> that.
> However, escaping notwithstanding, a number of character literals are
> outright prohibited by the XML specifications. These literals cannot be
> escaped, and their presence renders an XML document not well formed. The
> exact set of prohibited characters varies by XML version; the report produced
> by the Maven Invoker plugin is XML version 1.0. When the Maven Invoker plugin
> reads in the build log it does not strip these character literals and neither
> does the XML writer the Maven Invoker plugin relies on. Consequently, if a
> build log ends up including a prohibited character the resulting JUnit report
> will not be well formed.
> The set of prohibited characters is the complement of [the XML
> specification's definition of {{Char}}|https://www.w3.org/TR/xml/#NT-Char].
> h2. Example
> Among the literals prohibited by XML version 1.0 is {{^H}} (backspace). When
> [pitest runs via Maven|https://pitest.org/quickstart/maven/] it prints a
> spinner to standard out, and the implementation uses backspace to render the
> spinner in place. I have used the Maven Invoker plugin with
> {{}} to verify a pitest configuration, whereby I discovered
> this limitation.
> h2. Remediation
> h3. Blame plugins
> Perhaps pitest should not behave this way but we can't change pitest, and
> even if pitest could be changed that offers no protection against any other
> plugin, so blaming plugins is an ineffective course of action.
> h3. Work-arounds
> The user can manually clean the build log in-place via
> {{}}. This is technically fairly easy to do, and makes
> the transformation very explicit, but it requires considerable local work to
> address an issue many would find obscure and the transformation is
> permanently lossy unless the user also backs up the raw log to another file
> name.
> h3. Strip prohibited literals inside Maven Invoker plugin
> If the Maven Invoker plugin learns to strip offending character literals
> in-between reading the build log and writing to the {{}} value
> then {{}} will Just Work™, which I assert is what a user
> will typically expect. Although the {{}} value will no longer
> exactly match the build log contents, this lossy translation is acceptable:
> the prohibited characters are overwhelmingly unprintable to begin with and
> therefore cannot be meaningfully rendered in a static context, and the raw
> build log remains unchanged in the event that the user needs to investigate
> or assert against the raw output.
> This change would be backwards compatible, because any existing user that
> would be affected by it would already have unparseable JUnit reports.
> * I _believe_ that Java's {{j.u.r.Pattern}} can trivially express the
> complement of allowed characters but there may exist more efficient solutions.
> * Consider also applying this transf
[jira] [Commented] (MINVOKER-351) Prevent XML-prohibited characters from entering JUnit report
[
https://issues.apache.org/jira/browse/MINVOKER-351?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17848750#comment-17848750
]
ASF GitHub Bot commented on MINVOKER-351:
-
slawekjaranowski merged PR #242:
URL: https://github.com/apache/maven-invoker-plugin/pull/242
> Prevent XML-prohibited characters from entering JUnit report
>
>
> Key: MINVOKER-351
> URL: https://issues.apache.org/jira/browse/MINVOKER-351
> Project: Maven Invoker Plugin
> Issue Type: Bug
>Reporter: Mikkel Kjeldsen
>Assignee: Slawomir Jaranowski
>Priority: Major
> Fix For: 3.7.0
>
> Attachments: minvoker-351.tar.gz
>
>
> Neither the Maven Invoker plugin's implementation of {{}}
> nor the underlying XML infrastructure directly protect against the presence
> of character literals prohibited by the XML specification, meaning such
> literals can appear in the JUnit report and render it unreadable. *I would
> appreciate if the Maven Invoker plugin could learn to strip prohibited
> literals to protect its users from creative plugins.* I argue that this is a
> safe and expected transformation that is not materially lossy.
>
> h2. Background
> MINVOKER-196 added the {{}} option [back in
> maven-invoker-plugin-3.2.1|https://github.com/apache/maven-invoker-plugin/blob/maven-invoker-plugin-3.2.1/src/main/java/org/apache/maven/plugins/invoker/AbstractInvokerMojo.java#L1878-L1946].
> As of [maven-invoker-plugin-3.6.0 the effective implementation of the JUnit
> report remains effectively
> unchanged|https://github.com/apache/maven-invoker-plugin/blob/maven-invoker-plugin-3.6.0/src/main/java/org/apache/maven/plugins/invoker/AbstractInvokerMojo.java#L1695-L1754].
> The JUnit report includes a {{}} element ([example
> documentation|https://github.com/testmoapp/junitxml]) whose value Maven
> Invoker populates with the raw build log contents. I've observed that this
> value is XML-escaped, which I imagine is well understood in the
> implementation, although I can't immediately find documentation to support
> that.
> However, escaping notwithstanding, a number of character literals are
> outright prohibited by the XML specifications. These literals cannot be
> escaped, and their presence renders an XML document not well formed. The
> exact set of prohibited characters varies by XML version; the report produced
> by the Maven Invoker plugin is XML version 1.0. When the Maven Invoker plugin
> reads in the build log it does not strip these character literals and neither
> does the XML writer the Maven Invoker plugin relies on. Consequently, if a
> build log ends up including a prohibited character the resulting JUnit report
> will not be well formed.
> The set of prohibited characters is the complement of [the XML
> specification's definition of {{Char}}|https://www.w3.org/TR/xml/#NT-Char].
> h2. Example
> Among the literals prohibited by XML version 1.0 is {{^H}} (backspace). When
> [pitest runs via Maven|https://pitest.org/quickstart/maven/] it prints a
> spinner to standard out, and the implementation uses backspace to render the
> spinner in place. I have used the Maven Invoker plugin with
> {{}} to verify a pitest configuration, whereby I discovered
> this limitation.
> h2. Remediation
> h3. Blame plugins
> Perhaps pitest should not behave this way but we can't change pitest, and
> even if pitest could be changed that offers no protection against any other
> plugin, so blaming plugins is an ineffective course of action.
> h3. Work-arounds
> The user can manually clean the build log in-place via
> {{}}. This is technically fairly easy to do, and makes
> the transformation very explicit, but it requires considerable local work to
> address an issue many would find obscure and the transformation is
> permanently lossy unless the user also backs up the raw log to another file
> name.
> h3. Strip prohibited literals inside Maven Invoker plugin
> If the Maven Invoker plugin learns to strip offending character literals
> in-between reading the build log and writing to the {{}} value
> then {{}} will Just Work™, which I assert is what a user
> will typically expect. Although the {{}} value will no longer
> exactly match the build log contents, this lossy translation is acceptable:
> the prohibited characters are overwhelmingly unprintable to begin with and
> therefore cannot be meaningfully rendered in a static context, and the raw
> build log remains unchanged in the event that the user needs to investigate
> or assert against the raw output.
> This change would be backwards compatible, because any existing user that
> would be affected by it would already have unparseable JUnit reports.
> * I _believe_ that Java's {{j.u.r.Pattern}} can trivially express
Re: [PR] [MINVOKER-351] Escape special xml character in junit report [maven-invoker-plugin]
slawekjaranowski merged PR #242: URL: https://github.com/apache/maven-invoker-plugin/pull/242 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Closed] (MDEP-928) Allow to exclude classes from dependency:analyze
[ https://issues.apache.org/jira/browse/MDEP-928?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Slawomir Jaranowski closed MDEP-928. Resolution: Fixed > Allow to exclude classes from dependency:analyze > > > Key: MDEP-928 > URL: https://issues.apache.org/jira/browse/MDEP-928 > Project: Maven Dependency Plugin > Issue Type: New Feature > Components: analyze, analyze-only, analyze-report >Reporter: Slawomir Jaranowski >Assignee: Slawomir Jaranowski >Priority: Major > Fix For: 3.7.0 > > > Some of classes can be broken - so possibility to exclude can be helpful. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MDEP-928) Allow to exclude classes from dependency:analyze
[ https://issues.apache.org/jira/browse/MDEP-928?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17848749#comment-17848749 ] ASF GitHub Bot commented on MDEP-928: - slawekjaranowski merged PR #393: URL: https://github.com/apache/maven-dependency-plugin/pull/393 > Allow to exclude classes from dependency:analyze > > > Key: MDEP-928 > URL: https://issues.apache.org/jira/browse/MDEP-928 > Project: Maven Dependency Plugin > Issue Type: New Feature > Components: analyze, analyze-only, analyze-report >Reporter: Slawomir Jaranowski >Assignee: Slawomir Jaranowski >Priority: Major > Fix For: 3.7.0 > > > Some of classes can be broken - so possibility to exclude can be helpful. -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] [MDEP-928] Allow excluding classes from dependency:analyze [maven-dependency-plugin]
slawekjaranowski merged PR #393: URL: https://github.com/apache/maven-dependency-plugin/pull/393 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (MSHARED-1402) Upgrade plugins and components (in ITs)
Michael Osipov created MSHARED-1402: --- Summary: Upgrade plugins and components (in ITs) Key: MSHARED-1402 URL: https://issues.apache.org/jira/browse/MSHARED-1402 Project: Maven Shared Components Issue Type: Dependency upgrade Components: maven-reporting-impl Reporter: Michael Osipov Assignee: Michael Osipov Fix For: maven-reporting-impl-4.0.0, maven-reporting-impl-4.0.0-M15 * Upgrade to Maven Doxia 2.0.0-M12 * Upgrade to Maven Doxia Sitetools 2.0.0-M19 * Upgrade to Maven Reporting API 4.0.0-M12 * Upgrade to Maven Site Plugin 4.0.0-M15 * Upgrade to Maven Plugin Tools 3.13.0 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MDEP-799) improve mvn dependency:tree - add optional JSON output of the results
[
https://issues.apache.org/jira/browse/MDEP-799?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17848739#comment-17848739
]
ASF GitHub Bot commented on MDEP-799:
-
LogFlames commented on code in PR #391:
URL:
https://github.com/apache/maven-dependency-plugin/pull/391#discussion_r1610578562
##
src/test/java/org/apache/maven/plugins/dependency/tree/TestTreeMojo.java:
##
@@ -137,6 +147,74 @@ public void testTreeTGFSerializing() throws Exception {
assertTrue(findString(contents,
"testGroupId:release:jar:1.0:compile"));
}
+/**
+ * Test the JSON format serialization on DependencyNodes with circular
dependence
+ */
+public void testTreeJsonCircularDependency() throws Exception {
+String outputFileName = testDir.getAbsolutePath() + "tree1.json";
+File outputFile = new File(outputFileName);
+Files.createDirectories(outputFile.getParentFile().toPath());
+outputFile.createNewFile();
+
+Artifact artifact1 = this.stubFactory.createArtifact("testGroupId",
"project1", "1.0");
+Artifact artifact2 = this.stubFactory.createArtifact("testGroupId",
"project2", "1.0");
+DefaultDependencyNode node1 = new DefaultDependencyNode(artifact1);
+DefaultDependencyNode node2 = new DefaultDependencyNode(artifact2);
+
+node1.setChildren(new ArrayList());
+node2.setChildren(new ArrayList());
+
+node1.getChildren().add(node2);
+node2.getChildren().add(node1);
+
+JsonDependencyNodeVisitor jsonDependencyNodeVisitor =
+new JsonDependencyNodeVisitor(new OutputStreamWriter(new
FileOutputStream(outputFile)));
+
+jsonDependencyNodeVisitor.visit(node1);
+}
+
+/*
+ * Test parsing of Json output and verify all key-value pairs
+ */
+public void testTreeJsonParsing() throws Exception {
+List contents = runTreeMojo("tree2.json", "json");
+
+JsonReader reader = Json.createReader(new
StringReader(String.join("\n", contents)));
+JsonObject root = reader.readObject();
+reader.close();
Review Comment:
Cool feature, thanks! This has been updated to use try-with-resource
> improve mvn dependency:tree - add optional JSON output of the results
> -
>
> Key: MDEP-799
> URL: https://issues.apache.org/jira/browse/MDEP-799
> Project: Maven Dependency Plugin
> Issue Type: New Feature
> Components: tree
>Reporter: Zhenxu Ke
>Priority: Major
>
> I'd like to add an output type JSON, will open a pull request soon
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
Re: [PR] [MDEP-799] tree: add optional output type json [maven-dependency-plugin]
LogFlames commented on code in PR #391:
URL:
https://github.com/apache/maven-dependency-plugin/pull/391#discussion_r1610578562
##
src/test/java/org/apache/maven/plugins/dependency/tree/TestTreeMojo.java:
##
@@ -137,6 +147,74 @@ public void testTreeTGFSerializing() throws Exception {
assertTrue(findString(contents,
"testGroupId:release:jar:1.0:compile"));
}
+/**
+ * Test the JSON format serialization on DependencyNodes with circular
dependence
+ */
+public void testTreeJsonCircularDependency() throws Exception {
+String outputFileName = testDir.getAbsolutePath() + "tree1.json";
+File outputFile = new File(outputFileName);
+Files.createDirectories(outputFile.getParentFile().toPath());
+outputFile.createNewFile();
+
+Artifact artifact1 = this.stubFactory.createArtifact("testGroupId",
"project1", "1.0");
+Artifact artifact2 = this.stubFactory.createArtifact("testGroupId",
"project2", "1.0");
+DefaultDependencyNode node1 = new DefaultDependencyNode(artifact1);
+DefaultDependencyNode node2 = new DefaultDependencyNode(artifact2);
+
+node1.setChildren(new ArrayList());
+node2.setChildren(new ArrayList());
+
+node1.getChildren().add(node2);
+node2.getChildren().add(node1);
+
+JsonDependencyNodeVisitor jsonDependencyNodeVisitor =
+new JsonDependencyNodeVisitor(new OutputStreamWriter(new
FileOutputStream(outputFile)));
+
+jsonDependencyNodeVisitor.visit(node1);
+}
+
+/*
+ * Test parsing of Json output and verify all key-value pairs
+ */
+public void testTreeJsonParsing() throws Exception {
+List contents = runTreeMojo("tree2.json", "json");
+
+JsonReader reader = Json.createReader(new
StringReader(String.join("\n", contents)));
+JsonObject root = reader.readObject();
+reader.close();
Review Comment:
Cool feature, thanks! This has been updated to use try-with-resource
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Commented] (MDEP-799) improve mvn dependency:tree - add optional JSON output of the results
[
https://issues.apache.org/jira/browse/MDEP-799?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17848735#comment-17848735
]
ASF GitHub Bot commented on MDEP-799:
-
LogFlames commented on code in PR #391:
URL:
https://github.com/apache/maven-dependency-plugin/pull/391#discussion_r1610577280
##
src/test/java/org/apache/maven/plugins/dependency/tree/TestTreeMojo.java:
##
@@ -137,6 +147,74 @@ public void testTreeTGFSerializing() throws Exception {
assertTrue(findString(contents,
"testGroupId:release:jar:1.0:compile"));
}
+/**
+ * Test the JSON format serialization on DependencyNodes with circular
dependence
+ */
+public void testTreeJsonCircularDependency() throws Exception {
+String outputFileName = testDir.getAbsolutePath() + "tree1.json";
+File outputFile = new File(outputFileName);
+Files.createDirectories(outputFile.getParentFile().toPath());
+outputFile.createNewFile();
+
+Artifact artifact1 = this.stubFactory.createArtifact("testGroupId",
"project1", "1.0");
+Artifact artifact2 = this.stubFactory.createArtifact("testGroupId",
"project2", "1.0");
+DefaultDependencyNode node1 = new DefaultDependencyNode(artifact1);
+DefaultDependencyNode node2 = new DefaultDependencyNode(artifact2);
+
+node1.setChildren(new ArrayList());
+node2.setChildren(new ArrayList());
+
+node1.getChildren().add(node2);
+node2.getChildren().add(node1);
+
+JsonDependencyNodeVisitor jsonDependencyNodeVisitor =
+new JsonDependencyNodeVisitor(new OutputStreamWriter(new
FileOutputStream(outputFile)));
+
+jsonDependencyNodeVisitor.visit(node1);
+}
+
+/*
+ * Test parsing of Json output and verify all key-value pairs
+ */
+public void testTreeJsonParsing() throws Exception {
Review Comment:
This uses the prebuilt function `runTreeMojo` that is also used by most
other tests in the file, which throws an Exception. I don't think this can be
more specific without changing `runTreeMojo`. Within `runTreeMojo` there are
function that throws the following exceptions:
`lookupMojo`: `Exception`
`setVariableValueToObject`: `IllegalAccessException`
`this.stubFactory.createArtifact`: `IOException`
`mojo.execute()`: `MojoFailureException` and `MojoExecutionException`
> improve mvn dependency:tree - add optional JSON output of the results
> -
>
> Key: MDEP-799
> URL: https://issues.apache.org/jira/browse/MDEP-799
> Project: Maven Dependency Plugin
> Issue Type: New Feature
> Components: tree
>Reporter: Zhenxu Ke
>Priority: Major
>
> I'd like to add an output type JSON, will open a pull request soon
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MDEP-799) improve mvn dependency:tree - add optional JSON output of the results
[
https://issues.apache.org/jira/browse/MDEP-799?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17848736#comment-17848736
]
ASF GitHub Bot commented on MDEP-799:
-
LogFlames commented on code in PR #391:
URL:
https://github.com/apache/maven-dependency-plugin/pull/391#discussion_r1610577280
##
src/test/java/org/apache/maven/plugins/dependency/tree/TestTreeMojo.java:
##
@@ -137,6 +147,74 @@ public void testTreeTGFSerializing() throws Exception {
assertTrue(findString(contents,
"testGroupId:release:jar:1.0:compile"));
}
+/**
+ * Test the JSON format serialization on DependencyNodes with circular
dependence
+ */
+public void testTreeJsonCircularDependency() throws Exception {
+String outputFileName = testDir.getAbsolutePath() + "tree1.json";
+File outputFile = new File(outputFileName);
+Files.createDirectories(outputFile.getParentFile().toPath());
+outputFile.createNewFile();
+
+Artifact artifact1 = this.stubFactory.createArtifact("testGroupId",
"project1", "1.0");
+Artifact artifact2 = this.stubFactory.createArtifact("testGroupId",
"project2", "1.0");
+DefaultDependencyNode node1 = new DefaultDependencyNode(artifact1);
+DefaultDependencyNode node2 = new DefaultDependencyNode(artifact2);
+
+node1.setChildren(new ArrayList());
+node2.setChildren(new ArrayList());
+
+node1.getChildren().add(node2);
+node2.getChildren().add(node1);
+
+JsonDependencyNodeVisitor jsonDependencyNodeVisitor =
+new JsonDependencyNodeVisitor(new OutputStreamWriter(new
FileOutputStream(outputFile)));
+
+jsonDependencyNodeVisitor.visit(node1);
+}
+
+/*
+ * Test parsing of Json output and verify all key-value pairs
+ */
+public void testTreeJsonParsing() throws Exception {
Review Comment:
This uses the prebuilt function `runTreeMojo` that is also used by most
other tests in the file, which throws an Exception. I don't think this can be
more specific without major changes to `runTreeMojo`.
Within `runTreeMojo` there are function that throws the following exceptions:
`lookupMojo`: `Exception`
`setVariableValueToObject`: `IllegalAccessException`
`this.stubFactory.createArtifact`: `IOException`
`mojo.execute()`: `MojoFailureException` and `MojoExecutionException`
> improve mvn dependency:tree - add optional JSON output of the results
> -
>
> Key: MDEP-799
> URL: https://issues.apache.org/jira/browse/MDEP-799
> Project: Maven Dependency Plugin
> Issue Type: New Feature
> Components: tree
>Reporter: Zhenxu Ke
>Priority: Major
>
> I'd like to add an output type JSON, will open a pull request soon
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
Re: [PR] [MDEP-799] tree: add optional output type json [maven-dependency-plugin]
LogFlames commented on code in PR #391:
URL:
https://github.com/apache/maven-dependency-plugin/pull/391#discussion_r1610577280
##
src/test/java/org/apache/maven/plugins/dependency/tree/TestTreeMojo.java:
##
@@ -137,6 +147,74 @@ public void testTreeTGFSerializing() throws Exception {
assertTrue(findString(contents,
"testGroupId:release:jar:1.0:compile"));
}
+/**
+ * Test the JSON format serialization on DependencyNodes with circular
dependence
+ */
+public void testTreeJsonCircularDependency() throws Exception {
+String outputFileName = testDir.getAbsolutePath() + "tree1.json";
+File outputFile = new File(outputFileName);
+Files.createDirectories(outputFile.getParentFile().toPath());
+outputFile.createNewFile();
+
+Artifact artifact1 = this.stubFactory.createArtifact("testGroupId",
"project1", "1.0");
+Artifact artifact2 = this.stubFactory.createArtifact("testGroupId",
"project2", "1.0");
+DefaultDependencyNode node1 = new DefaultDependencyNode(artifact1);
+DefaultDependencyNode node2 = new DefaultDependencyNode(artifact2);
+
+node1.setChildren(new ArrayList());
+node2.setChildren(new ArrayList());
+
+node1.getChildren().add(node2);
+node2.getChildren().add(node1);
+
+JsonDependencyNodeVisitor jsonDependencyNodeVisitor =
+new JsonDependencyNodeVisitor(new OutputStreamWriter(new
FileOutputStream(outputFile)));
+
+jsonDependencyNodeVisitor.visit(node1);
+}
+
+/*
+ * Test parsing of Json output and verify all key-value pairs
+ */
+public void testTreeJsonParsing() throws Exception {
Review Comment:
This uses the prebuilt function `runTreeMojo` that is also used by most
other tests in the file, which throws an Exception. I don't think this can be
more specific without major changes to `runTreeMojo`.
Within `runTreeMojo` there are function that throws the following exceptions:
`lookupMojo`: `Exception`
`setVariableValueToObject`: `IllegalAccessException`
`this.stubFactory.createArtifact`: `IOException`
`mojo.execute()`: `MojoFailureException` and `MojoExecutionException`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] [MDEP-799] tree: add optional output type json [maven-dependency-plugin]
LogFlames commented on code in PR #391:
URL:
https://github.com/apache/maven-dependency-plugin/pull/391#discussion_r1610577280
##
src/test/java/org/apache/maven/plugins/dependency/tree/TestTreeMojo.java:
##
@@ -137,6 +147,74 @@ public void testTreeTGFSerializing() throws Exception {
assertTrue(findString(contents,
"testGroupId:release:jar:1.0:compile"));
}
+/**
+ * Test the JSON format serialization on DependencyNodes with circular
dependence
+ */
+public void testTreeJsonCircularDependency() throws Exception {
+String outputFileName = testDir.getAbsolutePath() + "tree1.json";
+File outputFile = new File(outputFileName);
+Files.createDirectories(outputFile.getParentFile().toPath());
+outputFile.createNewFile();
+
+Artifact artifact1 = this.stubFactory.createArtifact("testGroupId",
"project1", "1.0");
+Artifact artifact2 = this.stubFactory.createArtifact("testGroupId",
"project2", "1.0");
+DefaultDependencyNode node1 = new DefaultDependencyNode(artifact1);
+DefaultDependencyNode node2 = new DefaultDependencyNode(artifact2);
+
+node1.setChildren(new ArrayList());
+node2.setChildren(new ArrayList());
+
+node1.getChildren().add(node2);
+node2.getChildren().add(node1);
+
+JsonDependencyNodeVisitor jsonDependencyNodeVisitor =
+new JsonDependencyNodeVisitor(new OutputStreamWriter(new
FileOutputStream(outputFile)));
+
+jsonDependencyNodeVisitor.visit(node1);
+}
+
+/*
+ * Test parsing of Json output and verify all key-value pairs
+ */
+public void testTreeJsonParsing() throws Exception {
Review Comment:
This uses the prebuilt function `runTreeMojo` that is also used by most
other tests in the file, which throws an Exception. I don't think this can be
more specific without changing `runTreeMojo`. Within `runTreeMojo` there are
function that throws the following exceptions:
`lookupMojo`: `Exception`
`setVariableValueToObject`: `IllegalAccessException`
`this.stubFactory.createArtifact`: `IOException`
`mojo.execute()`: `MojoFailureException` and `MojoExecutionException`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Commented] (MDEP-799) improve mvn dependency:tree - add optional JSON output of the results
[
https://issues.apache.org/jira/browse/MDEP-799?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17848734#comment-17848734
]
ASF GitHub Bot commented on MDEP-799:
-
LogFlames commented on code in PR #391:
URL:
https://github.com/apache/maven-dependency-plugin/pull/391#discussion_r1610575858
##
src/test/java/org/apache/maven/plugins/dependency/tree/TestTreeMojo.java:
##
@@ -137,6 +147,74 @@ public void testTreeTGFSerializing() throws Exception {
assertTrue(findString(contents,
"testGroupId:release:jar:1.0:compile"));
}
+/**
+ * Test the JSON format serialization on DependencyNodes with circular
dependence
+ */
+public void testTreeJsonCircularDependency() throws Exception {
Review Comment:
This has been updated to `IOException`.
> improve mvn dependency:tree - add optional JSON output of the results
> -
>
> Key: MDEP-799
> URL: https://issues.apache.org/jira/browse/MDEP-799
> Project: Maven Dependency Plugin
> Issue Type: New Feature
> Components: tree
>Reporter: Zhenxu Ke
>Priority: Major
>
> I'd like to add an output type JSON, will open a pull request soon
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
Re: [PR] [MDEP-799] tree: add optional output type json [maven-dependency-plugin]
LogFlames commented on code in PR #391:
URL:
https://github.com/apache/maven-dependency-plugin/pull/391#discussion_r1610575858
##
src/test/java/org/apache/maven/plugins/dependency/tree/TestTreeMojo.java:
##
@@ -137,6 +147,74 @@ public void testTreeTGFSerializing() throws Exception {
assertTrue(findString(contents,
"testGroupId:release:jar:1.0:compile"));
}
+/**
+ * Test the JSON format serialization on DependencyNodes with circular
dependence
+ */
+public void testTreeJsonCircularDependency() throws Exception {
Review Comment:
This has been updated to `IOException`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Assigned] (MSHARED-1397) Bump org.apache.maven:maven-archiver from 3.6.1 to 3.6.2
[ https://issues.apache.org/jira/browse/MSHARED-1397?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov reassigned MSHARED-1397: --- Assignee: Sylwester Lachiewicz > Bump org.apache.maven:maven-archiver from 3.6.1 to 3.6.2 > > > Key: MSHARED-1397 > URL: https://issues.apache.org/jira/browse/MSHARED-1397 > Project: Maven Shared Components > Issue Type: Dependency upgrade > Components: maven-reporting-impl >Reporter: Sylwester Lachiewicz >Assignee: Sylwester Lachiewicz >Priority: Minor > Fix For: maven-reporting-impl-4.0.0, > maven-reporting-impl-4.0.0-M15 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Closed] (DOXIASITETOOLS-340) Rearrange title order in Velocity context
[
https://issues.apache.org/jira/browse/DOXIASITETOOLS-340?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Osipov closed DOXIASITETOOLS-340.
-
Resolution: Fixed
Fixed with
[7bf7a0ff95e4e2f092f7f4e15cea3f8cc57bf745|https://gitbox.apache.org/repos/asf?p=maven-doxia-sitetools.git;a=commit;h=7bf7a0ff95e4e2f092f7f4e15cea3f8cc57bf745].
> Rearrange title order in Velocity context
> -
>
> Key: DOXIASITETOOLS-340
> URL: https://issues.apache.org/jira/browse/DOXIASITETOOLS-340
> Project: Maven Doxia Sitetools
> Issue Type: Dependency upgrade
> Components: Site renderer
>Affects Versions: 2.0.0-M18
>Reporter: Michael Osipov
>Assignee: Michael Osipov
>Priority: Major
> Fix For: 2.0.0, 2.0.0-M19
>
>
> Currently, the title is set as follows:
> {projectName}} -- {{documentTitle}}
> This causes problems when you have multiple browsers tabs open, all you see
> is the project name not the document title, making is hard to identify. The
> common, today's approach is to go from specific to general: {{documentTitle}}
> -- {projectName}}. We should do the same.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MDEP-799) improve mvn dependency:tree - add optional JSON output of the results
[
https://issues.apache.org/jira/browse/MDEP-799?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17848728#comment-17848728
]
ASF GitHub Bot commented on MDEP-799:
-
elharo commented on code in PR #391:
URL:
https://github.com/apache/maven-dependency-plugin/pull/391#discussion_r1610551901
##
src/test/java/org/apache/maven/plugins/dependency/tree/TestTreeMojo.java:
##
@@ -137,6 +147,74 @@ public void testTreeTGFSerializing() throws Exception {
assertTrue(findString(contents,
"testGroupId:release:jar:1.0:compile"));
}
+/**
+ * Test the JSON format serialization on DependencyNodes with circular
dependence
+ */
+public void testTreeJsonCircularDependency() throws Exception {
Review Comment:
can you declare a more specific exception?
##
src/test/java/org/apache/maven/plugins/dependency/tree/TestTreeMojo.java:
##
@@ -137,6 +147,74 @@ public void testTreeTGFSerializing() throws Exception {
assertTrue(findString(contents,
"testGroupId:release:jar:1.0:compile"));
}
+/**
+ * Test the JSON format serialization on DependencyNodes with circular
dependence
+ */
+public void testTreeJsonCircularDependency() throws Exception {
+String outputFileName = testDir.getAbsolutePath() + "tree1.json";
+File outputFile = new File(outputFileName);
+Files.createDirectories(outputFile.getParentFile().toPath());
+outputFile.createNewFile();
+
+Artifact artifact1 = this.stubFactory.createArtifact("testGroupId",
"project1", "1.0");
+Artifact artifact2 = this.stubFactory.createArtifact("testGroupId",
"project2", "1.0");
+DefaultDependencyNode node1 = new DefaultDependencyNode(artifact1);
+DefaultDependencyNode node2 = new DefaultDependencyNode(artifact2);
+
+node1.setChildren(new ArrayList());
+node2.setChildren(new ArrayList());
+
+node1.getChildren().add(node2);
+node2.getChildren().add(node1);
+
+JsonDependencyNodeVisitor jsonDependencyNodeVisitor =
+new JsonDependencyNodeVisitor(new OutputStreamWriter(new
FileOutputStream(outputFile)));
+
+jsonDependencyNodeVisitor.visit(node1);
+}
+
+/*
+ * Test parsing of Json output and verify all key-value pairs
+ */
+public void testTreeJsonParsing() throws Exception {
+List contents = runTreeMojo("tree2.json", "json");
+
+JsonReader reader = Json.createReader(new
StringReader(String.join("\n", contents)));
+JsonObject root = reader.readObject();
+reader.close();
Review Comment:
I think you can use try with resources to autoclose this.
##
src/test/java/org/apache/maven/plugins/dependency/tree/TestTreeMojo.java:
##
@@ -137,6 +147,74 @@ public void testTreeTGFSerializing() throws Exception {
assertTrue(findString(contents,
"testGroupId:release:jar:1.0:compile"));
}
+/**
+ * Test the JSON format serialization on DependencyNodes with circular
dependence
+ */
+public void testTreeJsonCircularDependency() throws Exception {
+String outputFileName = testDir.getAbsolutePath() + "tree1.json";
+File outputFile = new File(outputFileName);
+Files.createDirectories(outputFile.getParentFile().toPath());
+outputFile.createNewFile();
+
+Artifact artifact1 = this.stubFactory.createArtifact("testGroupId",
"project1", "1.0");
+Artifact artifact2 = this.stubFactory.createArtifact("testGroupId",
"project2", "1.0");
+DefaultDependencyNode node1 = new DefaultDependencyNode(artifact1);
+DefaultDependencyNode node2 = new DefaultDependencyNode(artifact2);
+
+node1.setChildren(new ArrayList());
+node2.setChildren(new ArrayList());
+
+node1.getChildren().add(node2);
+node2.getChildren().add(node1);
+
+JsonDependencyNodeVisitor jsonDependencyNodeVisitor =
+new JsonDependencyNodeVisitor(new OutputStreamWriter(new
FileOutputStream(outputFile)));
+
+jsonDependencyNodeVisitor.visit(node1);
+}
+
+/*
+ * Test parsing of Json output and verify all key-value pairs
+ */
+public void testTreeJsonParsing() throws Exception {
Review Comment:
can you declare a more specific exception?
> improve mvn dependency:tree - add optional JSON output of the results
> -
>
> Key: MDEP-799
> URL: https://issues.apache.org/jira/browse/MDEP-799
> Project: Maven Dependency Plugin
> Issue Type: New Feature
> Components: tree
>Reporter: Zhenxu Ke
>Priority: Major
>
> I'd like to add an output type JSON, will open a pull request soon
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
Re: [PR] [MDEP-799] tree: add optional output type json [maven-dependency-plugin]
elharo commented on code in PR #391:
URL:
https://github.com/apache/maven-dependency-plugin/pull/391#discussion_r1610551901
##
src/test/java/org/apache/maven/plugins/dependency/tree/TestTreeMojo.java:
##
@@ -137,6 +147,74 @@ public void testTreeTGFSerializing() throws Exception {
assertTrue(findString(contents,
"testGroupId:release:jar:1.0:compile"));
}
+/**
+ * Test the JSON format serialization on DependencyNodes with circular
dependence
+ */
+public void testTreeJsonCircularDependency() throws Exception {
Review Comment:
can you declare a more specific exception?
##
src/test/java/org/apache/maven/plugins/dependency/tree/TestTreeMojo.java:
##
@@ -137,6 +147,74 @@ public void testTreeTGFSerializing() throws Exception {
assertTrue(findString(contents,
"testGroupId:release:jar:1.0:compile"));
}
+/**
+ * Test the JSON format serialization on DependencyNodes with circular
dependence
+ */
+public void testTreeJsonCircularDependency() throws Exception {
+String outputFileName = testDir.getAbsolutePath() + "tree1.json";
+File outputFile = new File(outputFileName);
+Files.createDirectories(outputFile.getParentFile().toPath());
+outputFile.createNewFile();
+
+Artifact artifact1 = this.stubFactory.createArtifact("testGroupId",
"project1", "1.0");
+Artifact artifact2 = this.stubFactory.createArtifact("testGroupId",
"project2", "1.0");
+DefaultDependencyNode node1 = new DefaultDependencyNode(artifact1);
+DefaultDependencyNode node2 = new DefaultDependencyNode(artifact2);
+
+node1.setChildren(new ArrayList());
+node2.setChildren(new ArrayList());
+
+node1.getChildren().add(node2);
+node2.getChildren().add(node1);
+
+JsonDependencyNodeVisitor jsonDependencyNodeVisitor =
+new JsonDependencyNodeVisitor(new OutputStreamWriter(new
FileOutputStream(outputFile)));
+
+jsonDependencyNodeVisitor.visit(node1);
+}
+
+/*
+ * Test parsing of Json output and verify all key-value pairs
+ */
+public void testTreeJsonParsing() throws Exception {
+List contents = runTreeMojo("tree2.json", "json");
+
+JsonReader reader = Json.createReader(new
StringReader(String.join("\n", contents)));
+JsonObject root = reader.readObject();
+reader.close();
Review Comment:
I think you can use try with resources to autoclose this.
##
src/test/java/org/apache/maven/plugins/dependency/tree/TestTreeMojo.java:
##
@@ -137,6 +147,74 @@ public void testTreeTGFSerializing() throws Exception {
assertTrue(findString(contents,
"testGroupId:release:jar:1.0:compile"));
}
+/**
+ * Test the JSON format serialization on DependencyNodes with circular
dependence
+ */
+public void testTreeJsonCircularDependency() throws Exception {
+String outputFileName = testDir.getAbsolutePath() + "tree1.json";
+File outputFile = new File(outputFileName);
+Files.createDirectories(outputFile.getParentFile().toPath());
+outputFile.createNewFile();
+
+Artifact artifact1 = this.stubFactory.createArtifact("testGroupId",
"project1", "1.0");
+Artifact artifact2 = this.stubFactory.createArtifact("testGroupId",
"project2", "1.0");
+DefaultDependencyNode node1 = new DefaultDependencyNode(artifact1);
+DefaultDependencyNode node2 = new DefaultDependencyNode(artifact2);
+
+node1.setChildren(new ArrayList());
+node2.setChildren(new ArrayList());
+
+node1.getChildren().add(node2);
+node2.getChildren().add(node1);
+
+JsonDependencyNodeVisitor jsonDependencyNodeVisitor =
+new JsonDependencyNodeVisitor(new OutputStreamWriter(new
FileOutputStream(outputFile)));
+
+jsonDependencyNodeVisitor.visit(node1);
+}
+
+/*
+ * Test parsing of Json output and verify all key-value pairs
+ */
+public void testTreeJsonParsing() throws Exception {
Review Comment:
can you declare a more specific exception?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Commented] (DOXIASITETOOLS-340) Rearrange title order in Velocity context
[
https://issues.apache.org/jira/browse/DOXIASITETOOLS-340?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17848727#comment-17848727
]
ASF GitHub Bot commented on DOXIASITETOOLS-340:
---
asfgit closed pull request #157: [DOXIASITETOOLS-340] Rearrange title order in
Velocity context
URL: https://github.com/apache/maven-doxia-sitetools/pull/157
> Rearrange title order in Velocity context
> -
>
> Key: DOXIASITETOOLS-340
> URL: https://issues.apache.org/jira/browse/DOXIASITETOOLS-340
> Project: Maven Doxia Sitetools
> Issue Type: Dependency upgrade
> Components: Site renderer
>Affects Versions: 2.0.0-M18
>Reporter: Michael Osipov
>Assignee: Michael Osipov
>Priority: Major
> Fix For: 2.0.0, 2.0.0-M19
>
>
> Currently, the title is set as follows:
> {projectName}} -- {{documentTitle}}
> This causes problems when you have multiple browsers tabs open, all you see
> is the project name not the document title, making is hard to identify. The
> common, today's approach is to go from specific to general: {{documentTitle}}
> -- {projectName}}. We should do the same.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
Re: [PR] [DOXIASITETOOLS-340] Rearrange title order in Velocity context [maven-doxia-sitetools]
asfgit closed pull request #157: [DOXIASITETOOLS-340] Rearrange title order in Velocity context URL: https://github.com/apache/maven-doxia-sitetools/pull/157 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MDEP-923) Code cleanups
[
https://issues.apache.org/jira/browse/MDEP-923?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17848726#comment-17848726
]
ASF GitHub Bot commented on MDEP-923:
-
elharo commented on code in PR #389:
URL:
https://github.com/apache/maven-dependency-plugin/pull/389#discussion_r1610545049
##
src/main/java/org/apache/maven/plugins/dependency/utils/CopyUtil.java:
##
@@ -0,0 +1,70 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.maven.plugins.dependency.utils;
+
+import javax.inject.Inject;
+import javax.inject.Named;
+import javax.inject.Singleton;
+
+import java.io.File;
+import java.io.IOException;
+
+import org.apache.maven.plugin.MojoExecutionException;
+import org.apache.maven.plugin.logging.Log;
+import org.codehaus.plexus.util.FileUtils;
+import org.sonatype.plexus.build.incremental.BuildContext;
+
+/**
+ * Provide a copyFile method in one place.
+ */
+@Named
+@Singleton
+public class CopyUtil {
+
+private final BuildContext buildContext;
+
+@Inject
+public CopyUtil(BuildContext buildContext) {
+this.buildContext = buildContext;
+}
+
+/**
+ * Does the actual copy of the file and logging.
+ *
+ * @param source represents the file to copy.
+ * @param destination file name of destination file.
+ * @throws MojoExecutionException with a message if an error occurs.
+ */
+public void copyFile(Log log, File source, File destination) throws
MojoExecutionException {
+try {
+log.info("Copying " + source + " to " + destination);
+
+if (source.isDirectory()) {
+// usual case is a future jar packaging, but there are special
cases: classifier and other packaging
+throw new MojoExecutionException("Artifact has not been
packaged yet. When used on reactor artifact, "
++ "copy should be executed after packaging: see
MDEP-187.");
+}
+
+FileUtils.copyFile(source, destination);
+buildContext.refresh(destination);
+} catch (IOException e) {
Review Comment:
I'm less sure about that one. That feels close to a MojoExecutionExcepitojn
to me. It's OK for on method to throw different exception types for different
reasons.
> Code cleanups
> -
>
> Key: MDEP-923
> URL: https://issues.apache.org/jira/browse/MDEP-923
> Project: Maven Dependency Plugin
> Issue Type: Task
>Reporter: Slawomir Jaranowski
>Assignee: Slawomir Jaranowski
>Priority: Major
> Fix For: 3.7.0
>
>
> * remove usage of deprecated API where possible
> * cleanup pom after update to 42
> * exclude transitive dependencies on org.apache.maven
> * add {{@project.version@}} in ITs
> * Remove plexus logger from DependencySilentLog
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
Re: [PR] [MDEP-923] Extract copyFile method from AbstractDependencyMojo [maven-dependency-plugin]
elharo commented on code in PR #389:
URL:
https://github.com/apache/maven-dependency-plugin/pull/389#discussion_r1610545049
##
src/main/java/org/apache/maven/plugins/dependency/utils/CopyUtil.java:
##
@@ -0,0 +1,70 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.maven.plugins.dependency.utils;
+
+import javax.inject.Inject;
+import javax.inject.Named;
+import javax.inject.Singleton;
+
+import java.io.File;
+import java.io.IOException;
+
+import org.apache.maven.plugin.MojoExecutionException;
+import org.apache.maven.plugin.logging.Log;
+import org.codehaus.plexus.util.FileUtils;
+import org.sonatype.plexus.build.incremental.BuildContext;
+
+/**
+ * Provide a copyFile method in one place.
+ */
+@Named
+@Singleton
+public class CopyUtil {
+
+private final BuildContext buildContext;
+
+@Inject
+public CopyUtil(BuildContext buildContext) {
+this.buildContext = buildContext;
+}
+
+/**
+ * Does the actual copy of the file and logging.
+ *
+ * @param source represents the file to copy.
+ * @param destination file name of destination file.
+ * @throws MojoExecutionException with a message if an error occurs.
+ */
+public void copyFile(Log log, File source, File destination) throws
MojoExecutionException {
+try {
+log.info("Copying " + source + " to " + destination);
+
+if (source.isDirectory()) {
+// usual case is a future jar packaging, but there are special
cases: classifier and other packaging
+throw new MojoExecutionException("Artifact has not been
packaged yet. When used on reactor artifact, "
++ "copy should be executed after packaging: see
MDEP-187.");
+}
+
+FileUtils.copyFile(source, destination);
+buildContext.refresh(destination);
+} catch (IOException e) {
Review Comment:
I'm less sure about that one. That feels close to a MojoExecutionExcepitojn
to me. It's OK for on method to throw different exception types for different
reasons.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Commented] (MDEP-923) Code cleanups
[
https://issues.apache.org/jira/browse/MDEP-923?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17848723#comment-17848723
]
ASF GitHub Bot commented on MDEP-923:
-
slawekjaranowski commented on code in PR #389:
URL:
https://github.com/apache/maven-dependency-plugin/pull/389#discussion_r1610532357
##
src/main/java/org/apache/maven/plugins/dependency/utils/CopyUtil.java:
##
@@ -0,0 +1,70 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.maven.plugins.dependency.utils;
+
+import javax.inject.Inject;
+import javax.inject.Named;
+import javax.inject.Singleton;
+
+import java.io.File;
+import java.io.IOException;
+
+import org.apache.maven.plugin.MojoExecutionException;
+import org.apache.maven.plugin.logging.Log;
+import org.codehaus.plexus.util.FileUtils;
+import org.sonatype.plexus.build.incremental.BuildContext;
+
+/**
+ * Provide a copyFile method in one place.
+ */
+@Named
+@Singleton
+public class CopyUtil {
+
+private final BuildContext buildContext;
+
+@Inject
+public CopyUtil(BuildContext buildContext) {
+this.buildContext = buildContext;
+}
+
+/**
+ * Does the actual copy of the file and logging.
+ *
+ * @param source represents the file to copy.
+ * @param destination file name of destination file.
+ * @throws MojoExecutionException with a message if an error occurs.
+ */
+public void copyFile(Log log, File source, File destination) throws
MojoExecutionException {
+try {
+log.info("Copying " + source + " to " + destination);
+
+if (source.isDirectory()) {
+// usual case is a future jar packaging, but there are special
cases: classifier and other packaging
+throw new MojoExecutionException("Artifact has not been
packaged yet. When used on reactor artifact, "
++ "copy should be executed after packaging: see
MDEP-187.");
+}
+
+FileUtils.copyFile(source, destination);
+buildContext.refresh(destination);
+} catch (IOException e) {
Review Comment:
See line 60 - we have `MojoExecutionException` - I change it for
`IOException` so ww will have one exception from method - @elharo what do you
think?
##
src/main/java/org/apache/maven/plugins/dependency/utils/CopyUtil.java:
##
@@ -0,0 +1,70 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.maven.plugins.dependency.utils;
+
+import javax.inject.Inject;
+import javax.inject.Named;
+import javax.inject.Singleton;
+
+import java.io.File;
+import java.io.IOException;
+
+import org.apache.maven.plugin.MojoExecutionException;
+import org.apache.maven.plugin.logging.Log;
+import org.codehaus.plexus.util.FileUtils;
+import org.sonatype.plexus.build.incremental.BuildContext;
+
+/**
+ * Provide a copyFile method in one place.
+ */
+@Named
+@Singleton
+public class CopyUtil {
+
+private final BuildContext buildContext;
+
+@Inject
+public CopyUtil(BuildContext buildContext) {
+this.buildContext = buildContext;
+}
+
+/**
+ * Does the actual copy of the file and logging.
+ *
+ * @param source represents the file to copy.
+ * @param destination file name of destination file.
+ * @throws MojoExecutionException with a message if an error occurs.
+
Re: [PR] [MDEP-923] Extract copyFile method from AbstractDependencyMojo [maven-dependency-plugin]
slawekjaranowski commented on code in PR #389:
URL:
https://github.com/apache/maven-dependency-plugin/pull/389#discussion_r1610532357
##
src/main/java/org/apache/maven/plugins/dependency/utils/CopyUtil.java:
##
@@ -0,0 +1,70 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.maven.plugins.dependency.utils;
+
+import javax.inject.Inject;
+import javax.inject.Named;
+import javax.inject.Singleton;
+
+import java.io.File;
+import java.io.IOException;
+
+import org.apache.maven.plugin.MojoExecutionException;
+import org.apache.maven.plugin.logging.Log;
+import org.codehaus.plexus.util.FileUtils;
+import org.sonatype.plexus.build.incremental.BuildContext;
+
+/**
+ * Provide a copyFile method in one place.
+ */
+@Named
+@Singleton
+public class CopyUtil {
+
+private final BuildContext buildContext;
+
+@Inject
+public CopyUtil(BuildContext buildContext) {
+this.buildContext = buildContext;
+}
+
+/**
+ * Does the actual copy of the file and logging.
+ *
+ * @param source represents the file to copy.
+ * @param destination file name of destination file.
+ * @throws MojoExecutionException with a message if an error occurs.
+ */
+public void copyFile(Log log, File source, File destination) throws
MojoExecutionException {
+try {
+log.info("Copying " + source + " to " + destination);
+
+if (source.isDirectory()) {
+// usual case is a future jar packaging, but there are special
cases: classifier and other packaging
+throw new MojoExecutionException("Artifact has not been
packaged yet. When used on reactor artifact, "
++ "copy should be executed after packaging: see
MDEP-187.");
+}
+
+FileUtils.copyFile(source, destination);
+buildContext.refresh(destination);
+} catch (IOException e) {
Review Comment:
See line 60 - we have `MojoExecutionException` - I change it for
`IOException` so ww will have one exception from method - @elharo what do you
think?
##
src/main/java/org/apache/maven/plugins/dependency/utils/CopyUtil.java:
##
@@ -0,0 +1,70 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.maven.plugins.dependency.utils;
+
+import javax.inject.Inject;
+import javax.inject.Named;
+import javax.inject.Singleton;
+
+import java.io.File;
+import java.io.IOException;
+
+import org.apache.maven.plugin.MojoExecutionException;
+import org.apache.maven.plugin.logging.Log;
+import org.codehaus.plexus.util.FileUtils;
+import org.sonatype.plexus.build.incremental.BuildContext;
+
+/**
+ * Provide a copyFile method in one place.
+ */
+@Named
+@Singleton
+public class CopyUtil {
+
+private final BuildContext buildContext;
+
+@Inject
+public CopyUtil(BuildContext buildContext) {
+this.buildContext = buildContext;
+}
+
+/**
+ * Does the actual copy of the file and logging.
+ *
+ * @param source represents the file to copy.
+ * @param destination file name of destination file.
+ * @throws MojoExecutionException with a message if an error occurs.
+ */
+public void copyFile(Log log, File source, File destination) throws
MojoExecutionException {
+try {
+log.info("Copying " + source + " to " + destination);
+
+if (source.isDirectory()) {
+//
[jira] [Closed] (DOXIASITETOOLS-342) Upgrade to Maven Fluido Skin 2.0.0-M9 in default site descriptor
[ https://issues.apache.org/jira/browse/DOXIASITETOOLS-342?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov closed DOXIASITETOOLS-342. - Resolution: Fixed Fixed with [c54e6b1bd6d738a4f75cfbdea89e56c3136a4cd4|https://gitbox.apache.org/repos/asf?p=maven-doxia-sitetools.git;a=commit;h=c54e6b1bd6d738a4f75cfbdea89e56c3136a4cd4]. > Upgrade to Maven Fluido Skin 2.0.0-M9 in default site descriptor > > > Key: DOXIASITETOOLS-342 > URL: https://issues.apache.org/jira/browse/DOXIASITETOOLS-342 > Project: Maven Doxia Sitetools > Issue Type: Dependency upgrade >Reporter: Michael Osipov >Assignee: Michael Osipov >Priority: Major > Fix For: 2.0.0, 2.0.0-M19 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] [MDEP-799] tree: add optional output type json [maven-dependency-plugin]
LogFlames commented on code in PR #391:
URL:
https://github.com/apache/maven-dependency-plugin/pull/391#discussion_r1610513186
##
src/test/java/org/apache/maven/plugins/dependency/tree/TestTreeMojo.java:
##
@@ -137,6 +146,93 @@ public void testTreeTGFSerializing() throws Exception {
assertTrue(findString(contents,
"testGroupId:release:jar:1.0:compile"));
}
+/**
+ * Test the JSON format serialization
+ */
+public void testTreeJsonSerializing() throws Exception {
+List contents = runTreeMojo("tree1.json", "json");
+assertTrue(findString(contents, "\"groupId\": \"testGroupId\""));
+
+assertTrue(findString(contents, "\"artifactId\": \"project\""));
+assertTrue(findString(contents, "\"artifactId\": \"release\""));
+assertTrue(findString(contents, "\"artifactId\": \"snapshot\""));
+
+assertTrue(findString(contents, "\"version\": \"1.0\""));
+assertTrue(findString(contents, "\"version\": \"2.0-SNAPSHOT\""));
+
+assertTrue(findString(contents, "\"type\": \"jar\""));
+
+assertTrue(findString(contents, "\"scope\": \"compile\""));
+}
+
+/**
+ * Test the JSON format serialization on DependencyNodes with circular
dependence
+ */
+public void testTreeJsonCircularDependency() throws Exception {
+String outputFileName = testDir.getAbsolutePath() + "tree2.json";
+File outputFile = new File(outputFileName);
+Files.createDirectories(outputFile.getParentFile().toPath());
+outputFile.createNewFile();
+
+Artifact artifact1 = this.stubFactory.createArtifact("testGroupId",
"project1", "1.0");
+Artifact artifact2 = this.stubFactory.createArtifact("testGroupId",
"project2", "1.0");
+DefaultDependencyNode node1 = new DefaultDependencyNode(artifact1);
+DefaultDependencyNode node2 = new DefaultDependencyNode(artifact2);
+
+node1.setChildren(new ArrayList());
+node2.setChildren(new ArrayList());
+
+node1.getChildren().add(node2);
+node2.getChildren().add(node1);
+
+JsonDependencyNodeVisitor jsonDependencyNodeVisitor =
+new JsonDependencyNodeVisitor(new PrintWriter(outputFile));
Review Comment:
It now uses an OutputStreamWriter instead.
##
src/test/java/org/apache/maven/plugins/dependency/tree/TestTreeMojo.java:
##
@@ -137,6 +146,93 @@ public void testTreeTGFSerializing() throws Exception {
assertTrue(findString(contents,
"testGroupId:release:jar:1.0:compile"));
}
+/**
+ * Test the JSON format serialization
+ */
+public void testTreeJsonSerializing() throws Exception {
+List contents = runTreeMojo("tree1.json", "json");
+assertTrue(findString(contents, "\"groupId\": \"testGroupId\""));
+
+assertTrue(findString(contents, "\"artifactId\": \"project\""));
+assertTrue(findString(contents, "\"artifactId\": \"release\""));
+assertTrue(findString(contents, "\"artifactId\": \"snapshot\""));
+
+assertTrue(findString(contents, "\"version\": \"1.0\""));
+assertTrue(findString(contents, "\"version\": \"2.0-SNAPSHOT\""));
+
+assertTrue(findString(contents, "\"type\": \"jar\""));
+
+assertTrue(findString(contents, "\"scope\": \"compile\""));
+}
+
+/**
+ * Test the JSON format serialization on DependencyNodes with circular
dependence
+ */
+public void testTreeJsonCircularDependency() throws Exception {
+String outputFileName = testDir.getAbsolutePath() + "tree2.json";
+File outputFile = new File(outputFileName);
+Files.createDirectories(outputFile.getParentFile().toPath());
+outputFile.createNewFile();
+
+Artifact artifact1 = this.stubFactory.createArtifact("testGroupId",
"project1", "1.0");
+Artifact artifact2 = this.stubFactory.createArtifact("testGroupId",
"project2", "1.0");
+DefaultDependencyNode node1 = new DefaultDependencyNode(artifact1);
+DefaultDependencyNode node2 = new DefaultDependencyNode(artifact2);
+
+node1.setChildren(new ArrayList());
+node2.setChildren(new ArrayList());
+
+node1.getChildren().add(node2);
+node2.getChildren().add(node1);
+
+JsonDependencyNodeVisitor jsonDependencyNodeVisitor =
+new JsonDependencyNodeVisitor(new PrintWriter(outputFile));
Review Comment:
:+1: It now uses an OutputStreamWriter instead.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Commented] (MDEP-799) improve mvn dependency:tree - add optional JSON output of the results
[
https://issues.apache.org/jira/browse/MDEP-799?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17848715#comment-17848715
]
ASF GitHub Bot commented on MDEP-799:
-
LogFlames commented on code in PR #391:
URL:
https://github.com/apache/maven-dependency-plugin/pull/391#discussion_r1610513186
##
src/test/java/org/apache/maven/plugins/dependency/tree/TestTreeMojo.java:
##
@@ -137,6 +146,93 @@ public void testTreeTGFSerializing() throws Exception {
assertTrue(findString(contents,
"testGroupId:release:jar:1.0:compile"));
}
+/**
+ * Test the JSON format serialization
+ */
+public void testTreeJsonSerializing() throws Exception {
+List contents = runTreeMojo("tree1.json", "json");
+assertTrue(findString(contents, "\"groupId\": \"testGroupId\""));
+
+assertTrue(findString(contents, "\"artifactId\": \"project\""));
+assertTrue(findString(contents, "\"artifactId\": \"release\""));
+assertTrue(findString(contents, "\"artifactId\": \"snapshot\""));
+
+assertTrue(findString(contents, "\"version\": \"1.0\""));
+assertTrue(findString(contents, "\"version\": \"2.0-SNAPSHOT\""));
+
+assertTrue(findString(contents, "\"type\": \"jar\""));
+
+assertTrue(findString(contents, "\"scope\": \"compile\""));
+}
+
+/**
+ * Test the JSON format serialization on DependencyNodes with circular
dependence
+ */
+public void testTreeJsonCircularDependency() throws Exception {
+String outputFileName = testDir.getAbsolutePath() + "tree2.json";
+File outputFile = new File(outputFileName);
+Files.createDirectories(outputFile.getParentFile().toPath());
+outputFile.createNewFile();
+
+Artifact artifact1 = this.stubFactory.createArtifact("testGroupId",
"project1", "1.0");
+Artifact artifact2 = this.stubFactory.createArtifact("testGroupId",
"project2", "1.0");
+DefaultDependencyNode node1 = new DefaultDependencyNode(artifact1);
+DefaultDependencyNode node2 = new DefaultDependencyNode(artifact2);
+
+node1.setChildren(new ArrayList());
+node2.setChildren(new ArrayList());
+
+node1.getChildren().add(node2);
+node2.getChildren().add(node1);
+
+JsonDependencyNodeVisitor jsonDependencyNodeVisitor =
+new JsonDependencyNodeVisitor(new PrintWriter(outputFile));
Review Comment:
It now uses an OutputStreamWriter instead.
##
src/test/java/org/apache/maven/plugins/dependency/tree/TestTreeMojo.java:
##
@@ -137,6 +146,93 @@ public void testTreeTGFSerializing() throws Exception {
assertTrue(findString(contents,
"testGroupId:release:jar:1.0:compile"));
}
+/**
+ * Test the JSON format serialization
+ */
+public void testTreeJsonSerializing() throws Exception {
+List contents = runTreeMojo("tree1.json", "json");
+assertTrue(findString(contents, "\"groupId\": \"testGroupId\""));
+
+assertTrue(findString(contents, "\"artifactId\": \"project\""));
+assertTrue(findString(contents, "\"artifactId\": \"release\""));
+assertTrue(findString(contents, "\"artifactId\": \"snapshot\""));
+
+assertTrue(findString(contents, "\"version\": \"1.0\""));
+assertTrue(findString(contents, "\"version\": \"2.0-SNAPSHOT\""));
+
+assertTrue(findString(contents, "\"type\": \"jar\""));
+
+assertTrue(findString(contents, "\"scope\": \"compile\""));
+}
+
+/**
+ * Test the JSON format serialization on DependencyNodes with circular
dependence
+ */
+public void testTreeJsonCircularDependency() throws Exception {
+String outputFileName = testDir.getAbsolutePath() + "tree2.json";
+File outputFile = new File(outputFileName);
+Files.createDirectories(outputFile.getParentFile().toPath());
+outputFile.createNewFile();
+
+Artifact artifact1 = this.stubFactory.createArtifact("testGroupId",
"project1", "1.0");
+Artifact artifact2 = this.stubFactory.createArtifact("testGroupId",
"project2", "1.0");
+DefaultDependencyNode node1 = new DefaultDependencyNode(artifact1);
+DefaultDependencyNode node2 = new DefaultDependencyNode(artifact2);
+
+node1.setChildren(new ArrayList());
+node2.setChildren(new ArrayList());
+
+node1.getChildren().add(node2);
+node2.getChildren().add(node1);
+
+JsonDependencyNodeVisitor jsonDependencyNodeVisitor =
+new JsonDependencyNodeVisitor(new PrintWriter(outputFile));
Review Comment:
:+1: It now uses an OutputStreamWriter instead.
> improve mvn dependency:tree - add optional JSON output of the results
> -
>
> Key: MDEP-799
> URL: https://issues.apache.org/jira/browse
[jira] [Created] (MPLUGINTESTING-94) Create 3.x branch and switch master to support Maven 4.x
Guillaume Nodet created MPLUGINTESTING-94: - Summary: Create 3.x branch and switch master to support Maven 4.x Key: MPLUGINTESTING-94 URL: https://issues.apache.org/jira/browse/MPLUGINTESTING-94 Project: Maven Plugin Testing Issue Type: Task Reporter: Guillaume Nodet Fix For: 4.0.0-alpha-3 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (MNG-8043) Dependency properties should be provided by Resolver consumer
[ https://issues.apache.org/jira/browse/MNG-8043?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guillaume Nodet updated MNG-8043: - Fix Version/s: 4.0.0-beta-3 > Dependency properties should be provided by Resolver consumer > - > > Key: MNG-8043 > URL: https://issues.apache.org/jira/browse/MNG-8043 > Project: Maven > Issue Type: Task > Components: Artifacts and Repositories >Reporter: Tamas Cservenak >Assignee: Tamas Cservenak >Priority: Major > Fix For: 4.0.0-alpha-13, 4.0.0, 4.0.0-beta-3 > > > Follow up of MRESOLVER-484 > The consumer, in this case Maven is the one who should provide Maven-specific > bits. Also, do not use deprecated stuff from Resolver. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (MNG-8015) Control the type of path where each dependency can be placed
[
https://issues.apache.org/jira/browse/MNG-8015?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Guillaume Nodet updated MNG-8015:
-
Fix Version/s: 4.0.0-beta-3
> Control the type of path where each dependency can be placed
>
>
> Key: MNG-8015
> URL: https://issues.apache.org/jira/browse/MNG-8015
> Project: Maven
> Issue Type: Improvement
> Components: Core
>Affects Versions: 4.0.0-alpha-12
>Reporter: Martin Desruisseaux
>Assignee: Guillaume Nodet
>Priority: Major
> Fix For: 4.0.0-alpha-13, 4.0.0-beta-3
>
>
> Make possible to declare where each dependency can be placed: on the
> module-path, class-path, agent path, doclet path, taglet path, annotation
> processing path, _etc._ The proposed improvement consists in adding a new
> {{PATH_TYPES}} property that can be associated to dependencies. The property
> value is an array of {{PathType}}, a new enumeration-like class with values
> such as {{CLASSES}}, {{MODULES}}, {{DOCLET}}, _etc._ Contrarily to real Java
> enumerations, this enumeration-like class is extensible: plugins can add
> their own enumeration values. This is required at least for the
> {{--patch-module}} option, where a new {{PathType}} enumeration value need to
> be created for each module to patch.
> Users can control indirectly the {{PathType}} of a dependency by specifying
> the dependency type. Note that there is no direct mapping between the
> dependency type and where the dependency will be placed, but only an indirect
> mapping caused by the fact that using a dependency type implies implicit
> values of some properties such as classifier, and (with this proposal) path
> types:
> * {{jar}} implies {{PathType.CLASSES}} and {{PathType.MODULES}}.
> * {{modular-jar}} implies {{PathType.MODULES}} only.
> * {{classpath-jar}} implies {{PathType.CLASSES}} only.
> * _etc._
> When a plugin requests the paths of dependencies, the plugin specifies the
> types of path it is interested in. For example, a Java compiler plugin can
> specify that it is interested in {{PathType.CLASSES}} and
> {{PathType.MODULES}}, but not {{PathType.DOCLET}}. If a dependency declared
> that it can be placed on the class-path or the doclet-path, only the
> class-path is left after intersection with plugin's request. This is
> important for the next step.
> If, after all filtering such as above paragraph are applied, a dependency has
> only one {{PathType}} left, then there is no ambiguity and we are done.
> Combined with above-cited dependency types like {{modular-jar}} or
> {{classpath-jar}}, this rule allows users to control where the dependency
> will be placed. But if there are two or more {{PathType}} left after
> filtering, then a choice needs to be done. For example if there are both
> {{PathType.CLASSES}} and {{PathType.MODULES}} (which may happen when
> {{jar}} is used), then an heuristic rule similar to Maven 3 can
> be applied: check if a {{module-info.class}} file or an {{Automatic-Name}}
> manifest attribute is present, and base the decision on that.
> This proposal aims to fix MNG-7855.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Closed] (MNG-8118) Dependency-management "client" exclusions overwrite BOM exclusions
[ https://issues.apache.org/jira/browse/MNG-8118?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guillaume Nodet closed MNG-8118. Fix Version/s: 4.0.0-beta-3 Resolution: Fixed > Dependency-management "client" exclusions overwrite BOM exclusions > -- > > Key: MNG-8118 > URL: https://issues.apache.org/jira/browse/MNG-8118 > Project: Maven > Issue Type: Bug >Affects Versions: 4.0.0-alpha-13, 4.0.x-candidate > Environment: Any >Reporter: Lenny Primak >Assignee: Guillaume Nodet >Priority: Major > Fix For: 4.0.0-beta-3 > > > When importing BOM and introducing exclusions, they overwrite exclusions > already present in the BOM. They should not > Slack conversation link: > https://the-asf.slack.com/archives/C7Q9JB404/p1714938396499939 > Regressed by https://issues.apache.org/jira/browse/MNG-5600 > Reproducer app: [https://github.com/lprimak/apps/tree/main/emailmanager] > Fixed by: https://github.com/apache/maven/pull/1504 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Assigned] (MNG-8128) Custom packaging not found
[ https://issues.apache.org/jira/browse/MNG-8128?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guillaume Nodet reassigned MNG-8128: Assignee: Guillaume Nodet > Custom packaging not found > -- > > Key: MNG-8128 > URL: https://issues.apache.org/jira/browse/MNG-8128 > Project: Maven > Issue Type: Improvement >Affects Versions: 4.0.0-beta-2 >Reporter: Guillaume Nodet >Assignee: Guillaume Nodet >Priority: Major > Fix For: 4.0.0-beta-3 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MNG-8128) Custom packaging not found
[ https://issues.apache.org/jira/browse/MNG-8128?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17848649#comment-17848649 ] Guillaume Nodet commented on MNG-8128: -- Fixed with [https://github.com/apache/maven/pull/1507] > Custom packaging not found > -- > > Key: MNG-8128 > URL: https://issues.apache.org/jira/browse/MNG-8128 > Project: Maven > Issue Type: Improvement >Affects Versions: 4.0.0-beta-2 >Reporter: Guillaume Nodet >Priority: Major > Fix For: 4.0.0-beta-3 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (MNG-8128) Custom packaging not found
[ https://issues.apache.org/jira/browse/MNG-8128?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guillaume Nodet updated MNG-8128: - Summary: Custom packaging not found (was: Custom packaging are broken) > Custom packaging not found > -- > > Key: MNG-8128 > URL: https://issues.apache.org/jira/browse/MNG-8128 > Project: Maven > Issue Type: Improvement >Affects Versions: 4.0.0-beta-2 >Reporter: Guillaume Nodet >Priority: Major > Fix For: 4.0.0-beta-3 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (MNG-8128) Custom packaging are broken
Guillaume Nodet created MNG-8128: Summary: Custom packaging are broken Key: MNG-8128 URL: https://issues.apache.org/jira/browse/MNG-8128 Project: Maven Issue Type: Improvement Affects Versions: 4.0.0-beta-2 Reporter: Guillaume Nodet Fix For: 4.0.0-beta-3 -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] Backport of "Default value must be handled" [maven-mvnd]
cstamas merged PR #1000: URL: https://github.com/apache/maven-mvnd/pull/1000 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Default value must be manually handled [maven-mvnd]
cstamas merged PR #953: URL: https://github.com/apache/maven-mvnd/pull/953 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (MDEP-931) AbstractSerializingVisitor should not use PrintWriter
Elliotte Rusty Harold created MDEP-931: -- Summary: AbstractSerializingVisitor should not use PrintWriter Key: MDEP-931 URL: https://issues.apache.org/jira/browse/MDEP-931 Project: Maven Dependency Plugin Issue Type: Improvement Reporter: Elliotte Rusty Harold See https://github.com/apache/maven-dependency-plugin/pull/391/files AbstractSerializingVisitor uses a PrintWriter which swallows exceptions. It should use a regular Writer instead. This is exposed in the protected API so fixing this is ugly. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MDEP-799) improve mvn dependency:tree - add optional JSON output of the results
[
https://issues.apache.org/jira/browse/MDEP-799?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17848639#comment-17848639
]
ASF GitHub Bot commented on MDEP-799:
-
elharo commented on code in PR #391:
URL:
https://github.com/apache/maven-dependency-plugin/pull/391#discussion_r1610078602
##
src/test/java/org/apache/maven/plugins/dependency/tree/TestTreeMojo.java:
##
@@ -137,6 +146,93 @@ public void testTreeTGFSerializing() throws Exception {
assertTrue(findString(contents,
"testGroupId:release:jar:1.0:compile"));
}
+/**
+ * Test the JSON format serialization
+ */
+public void testTreeJsonSerializing() throws Exception {
+List contents = runTreeMojo("tree1.json", "json");
+assertTrue(findString(contents, "\"groupId\": \"testGroupId\""));
+
+assertTrue(findString(contents, "\"artifactId\": \"project\""));
+assertTrue(findString(contents, "\"artifactId\": \"release\""));
+assertTrue(findString(contents, "\"artifactId\": \"snapshot\""));
+
+assertTrue(findString(contents, "\"version\": \"1.0\""));
+assertTrue(findString(contents, "\"version\": \"2.0-SNAPSHOT\""));
+
+assertTrue(findString(contents, "\"type\": \"jar\""));
+
+assertTrue(findString(contents, "\"scope\": \"compile\""));
+}
+
+/**
+ * Test the JSON format serialization on DependencyNodes with circular
dependence
+ */
+public void testTreeJsonCircularDependency() throws Exception {
+String outputFileName = testDir.getAbsolutePath() + "tree2.json";
+File outputFile = new File(outputFileName);
+Files.createDirectories(outputFile.getParentFile().toPath());
+outputFile.createNewFile();
+
+Artifact artifact1 = this.stubFactory.createArtifact("testGroupId",
"project1", "1.0");
+Artifact artifact2 = this.stubFactory.createArtifact("testGroupId",
"project2", "1.0");
+DefaultDependencyNode node1 = new DefaultDependencyNode(artifact1);
+DefaultDependencyNode node2 = new DefaultDependencyNode(artifact2);
+
+node1.setChildren(new ArrayList());
+node2.setChildren(new ArrayList());
+
+node1.getChildren().add(node2);
+node2.getChildren().add(node1);
+
+JsonDependencyNodeVisitor jsonDependencyNodeVisitor =
+new JsonDependencyNodeVisitor(new PrintWriter(outputFile));
Review Comment:
Ick. That is bad. Let me file a bug on that. Meanwhile we might as well not
use a PrintWriter here if we don't have to so we don't have extra changes to
makes after the superclass is fixed.
> improve mvn dependency:tree - add optional JSON output of the results
> -
>
> Key: MDEP-799
> URL: https://issues.apache.org/jira/browse/MDEP-799
> Project: Maven Dependency Plugin
> Issue Type: New Feature
> Components: tree
>Reporter: Zhenxu Ke
>Priority: Major
>
> I'd like to add an output type JSON, will open a pull request soon
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
Re: [PR] [MDEP-799] tree: add optional output type json [maven-dependency-plugin]
elharo commented on code in PR #391:
URL:
https://github.com/apache/maven-dependency-plugin/pull/391#discussion_r1610078602
##
src/test/java/org/apache/maven/plugins/dependency/tree/TestTreeMojo.java:
##
@@ -137,6 +146,93 @@ public void testTreeTGFSerializing() throws Exception {
assertTrue(findString(contents,
"testGroupId:release:jar:1.0:compile"));
}
+/**
+ * Test the JSON format serialization
+ */
+public void testTreeJsonSerializing() throws Exception {
+List contents = runTreeMojo("tree1.json", "json");
+assertTrue(findString(contents, "\"groupId\": \"testGroupId\""));
+
+assertTrue(findString(contents, "\"artifactId\": \"project\""));
+assertTrue(findString(contents, "\"artifactId\": \"release\""));
+assertTrue(findString(contents, "\"artifactId\": \"snapshot\""));
+
+assertTrue(findString(contents, "\"version\": \"1.0\""));
+assertTrue(findString(contents, "\"version\": \"2.0-SNAPSHOT\""));
+
+assertTrue(findString(contents, "\"type\": \"jar\""));
+
+assertTrue(findString(contents, "\"scope\": \"compile\""));
+}
+
+/**
+ * Test the JSON format serialization on DependencyNodes with circular
dependence
+ */
+public void testTreeJsonCircularDependency() throws Exception {
+String outputFileName = testDir.getAbsolutePath() + "tree2.json";
+File outputFile = new File(outputFileName);
+Files.createDirectories(outputFile.getParentFile().toPath());
+outputFile.createNewFile();
+
+Artifact artifact1 = this.stubFactory.createArtifact("testGroupId",
"project1", "1.0");
+Artifact artifact2 = this.stubFactory.createArtifact("testGroupId",
"project2", "1.0");
+DefaultDependencyNode node1 = new DefaultDependencyNode(artifact1);
+DefaultDependencyNode node2 = new DefaultDependencyNode(artifact2);
+
+node1.setChildren(new ArrayList());
+node2.setChildren(new ArrayList());
+
+node1.getChildren().add(node2);
+node2.getChildren().add(node1);
+
+JsonDependencyNodeVisitor jsonDependencyNodeVisitor =
+new JsonDependencyNodeVisitor(new PrintWriter(outputFile));
Review Comment:
Ick. That is bad. Let me file a bug on that. Meanwhile we might as well not
use a PrintWriter here if we don't have to so we don't have extra changes to
makes after the superclass is fixed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] Update deps [maven-mvnd]
cstamas merged PR #999: URL: https://github.com/apache/maven-mvnd/pull/999 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump org.codehaus.plexus:plexus-xml from 4.0.1 to 4.0.4 [maven]
gnodet merged PR #1530: URL: https://github.com/apache/maven/pull/1530 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump com.google.guava:guava from 32.1.3-jre to 33.2.0-jre [maven]
gnodet merged PR #1532: URL: https://github.com/apache/maven/pull/1532 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump org.ow2.asm:asm from 9.6 to 9.7 [maven]
gnodet merged PR #1529: URL: https://github.com/apache/maven/pull/1529 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] Bump org.codehaus.plexus:plexus-xml from 3.0.0 to 3.0.1 [maven-plugin-tools]
dependabot[bot] opened a new pull request, #283: URL: https://github.com/apache/maven-plugin-tools/pull/283 Bumps [org.codehaus.plexus:plexus-xml](https://github.com/codehaus-plexus/plexus-xml) from 3.0.0 to 3.0.1. Release notes Sourced from https://github.com/codehaus-plexus/plexus-xml/releases";>org.codehaus.plexus:plexus-xml's releases. 3.0.1 🐛 Bug Fixes Allow nulls for write elements in MXSerializer (https://redirect.github.com/codehaus-plexus/plexus-xml/pull/41";>#41) https://github.com/slawekjaranowski";>@slawekjaranowski Remove special chars from xml output (https://redirect.github.com/codehaus-plexus/plexus-xml/pull/32";>#32) https://github.com/slawekjaranowski";>@slawekjaranowski 📦 Dependency updates Bump org.codehaus.plexus:plexus from 17 to 18 (https://redirect.github.com/codehaus-plexus/plexus-xml/pull/40";>#40) https://github.com/dependabot";>@dependabot Bump release-drafter/release-drafter from 5 to 6 (https://redirect.github.com/codehaus-plexus/plexus-xml/pull/33";>#33) https://github.com/dependabot";>@dependabot Bump parent to 17 and updates (https://redirect.github.com/codehaus-plexus/plexus-xml/pull/30";>#30) https://github.com/slawekjaranowski";>@slawekjaranowski 👻 Maintenance Switch to Junit 5 (https://redirect.github.com/codehaus-plexus/plexus-xml/pull/31";>#31) https://github.com/slawekjaranowski";>@slawekjaranowski Switch to shared gh actions setup from master branch (https://redirect.github.com/codehaus-plexus/plexus-xml/pull/25";>#25) https://github.com/slachiewicz";>@slachiewicz 🔧 Build Deploy snapshots for 3.x branch (https://redirect.github.com/codehaus-plexus/plexus-xml/pull/38";>#38) https://github.com/slawekjaranowski";>@slawekjaranowski Commits https://github.com/codehaus-plexus/plexus-xml/commit/86d35785396e1e8a02ce231c6aa9a7042f2ebd66";>86d3578 [maven-release-plugin] prepare release plexus-xml-3.0.1 https://github.com/codehaus-plexus/plexus-xml/commit/b55ce82f298d5658d45a61611d4dad297ee2d524";>b55ce82 Allow nulls for write elements in MXSerializer https://github.com/codehaus-plexus/plexus-xml/commit/af8cbad164e6ac4839d10d894a39e9d18f0eddb9";>af8cbad Bump org.codehaus.plexus:plexus from 17 to 18 (https://redirect.github.com/codehaus-plexus/plexus-xml/issues/40";>#40) https://github.com/codehaus-plexus/plexus-xml/commit/70b83b15592a5711a5f629591af90f87e1bbfe20";>70b83b1 Bump release-drafter/release-drafter from 5 to 6 (https://redirect.github.com/codehaus-plexus/plexus-xml/issues/33";>#33) https://github.com/codehaus-plexus/plexus-xml/commit/214263a915ec254fab3cd12e01d4d3d940d741b2";>214263a Deploy snapshots for 3.x branch https://github.com/codehaus-plexus/plexus-xml/commit/be6885bef0ecf9e3636e93d8eb7863d48986a053";>be6885b Remove special chars from xml output https://github.com/codehaus-plexus/plexus-xml/commit/4274b2ef0a525421246edd97e16b94e8e31ffbf4";>4274b2e Switch to junit 5 https://github.com/codehaus-plexus/plexus-xml/commit/55de18a2f6cddf52f91b0f90e3a6a6d2227c5145";>55de18a Config release-drafter in 3.x https://github.com/codehaus-plexus/plexus-xml/commit/4793c274541c6c8a3d6552e3ca23edabee2a0b4f";>4793c27 Config release-drafter in 3.x https://github.com/codehaus-plexus/plexus-xml/commit/219f5e0bf05a8990977daeb32d5367556a7fe40d";>219f5e0 Bump parent to 17 and updates Additional commits viewable in https://github.com/codehaus-plexus/plexus-xml/compare/plexus-xml-3.0.0...plexus-xml-3.0.1";>compare view Most Recent Ignore Conditions Applied to This Pull Request | Dependency Name | Ignore Conditions | | --- | --- | | org.codehaus.plexus:plexus-xml | [> 4.0.0] | | org.codehaus.plexus:plexus-xml | [>= 4.a, < 5] | [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot re
Re: [PR] [MNG-8123] Fix Lifecycle in v3 [maven]
gnodet merged PR #1524: URL: https://github.com/apache/maven/pull/1524 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [MNG-8123] IT for build cache extension [maven-integration-testing]
gnodet merged PR #342: URL: https://github.com/apache/maven-integration-testing/pull/342 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Closed] (MNG-8123) Maven 4.0.0-beta-2 fails with maven-build-cache-extension 1.2.0
[
https://issues.apache.org/jira/browse/MNG-8123?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Guillaume Nodet closed MNG-8123.
Assignee: Guillaume Nodet
Resolution: Fixed
> Maven 4.0.0-beta-2 fails with maven-build-cache-extension 1.2.0
> ---
>
> Key: MNG-8123
> URL: https://issues.apache.org/jira/browse/MNG-8123
> Project: Maven
> Issue Type: Bug
>Affects Versions: 4.0.0-beta-2
>Reporter: Filipe Roque
>Assignee: Guillaume Nodet
>Priority: Major
> Fix For: 4.0.0-beta-3
>
>
> {code:java}
> ❯ mvn --version
> Apache Maven 4.0.0-beta-2 (828faba81940a8d2f2e5cfab6f60e35d1ab61ca0)
> Maven home: /opt/maven/apache-maven-4.0.0-beta-2
> Java version: 22.0.1, vendor: Eclipse Adoptium, runtime:
> /usr/lib/jvm/temurin-22-jdk-amd64
> Default locale: en_US, platform encoding: UTF-8
> OS name: "linux", version: "6.5.0-28-generic", arch: "amd64", family: "unix"
> {code}
> project created with
> {code:java}
> mvn archetype:generate {code}
> Adding maven cache extension
> {code:java}
> cat .mvn/extensions.xml
> http://maven.apache.org/EXTENSIONS/1.0.0";>
>
> org.apache.maven.extensions
> maven-build-cache-extension
> 1.2.0
>
>
> {code}
> Fails with:
> {code:java}
> ❯ mvn compile [INFO] Cache configuration is not available at configured path
> /home/froque/workspace/testes/project1/.mvn/maven-build-cache-config.xml,
> cache is enabled with defaults [INFO] Using XX hash algorithm for cache
> [ERROR] Internal error: com.google.inject.ProvisionException: Unable to
> provision, see the following errors: [ERROR] [ERROR] 1)
> [Guice/NullInjectedIntoNonNullable]: null returned by binding at
> LocatorWiring [ERROR] but the 3rd parameter of
> LifecyclePhasesHelper.(LifecyclePhasesHelper.java:61) is not @Nullable
> [ERROR] at LocatorWiring [ERROR] at
> LifecyclePhasesHelper.(LifecyclePhasesHelper.java:61) [ERROR] \_
> for 3rd parameter [ERROR] at
> ClassRealm[coreExtension>org.apache.maven.extensions:maven-build-cache-extension:1.2.0,
> parent: ClassRealm[plexus.core, parent: null]] [ERROR] \_ installed
> by: WireModule -> PlexusBindingModule [ERROR] at
> CacheControllerImpl.(CacheControllerImpl.java:156) [ERROR] \_ for
> 10th parameter [ERROR] at
> ClassRealm[coreExtension>org.apache.maven.extensions:maven-build-cache-extension:1.2.0,
> parent: ClassRealm[plexus.core, parent: null]] [ERROR] \_ installed
> by: WireModule -> PlexusBindingModule [ERROR] while locating
> CacheControllerImpl [ERROR] while locating Object annotated with * [ERROR]
> at LocatorWiring [ERROR] at
> CacheLifecycleParticipant.(CacheLifecycleParticipant.java:39) [ERROR]
> \_ for 2nd parameter [ERROR] at
> ClassRealm[coreExtension>org.apache.maven.extensions:maven-build-cache-extension:1.2.0,
> parent: ClassRealm[plexus.core, parent: null]] [ERROR] \_ installed
> by: WireModule -> PlexusBindingModule [ERROR] while locating
> CacheLifecycleParticipant [ERROR] while locating Object annotated with *
> [ERROR] [ERROR] Learn more: [ERROR]
> https://github.com/google/guice/wiki/NULL_INJECTED_INTO_NON_NULLABLE [ERROR]
> [ERROR] 1 error [ERROR] [ERROR] == [ERROR] Full
> classname legend: [ERROR] == [ERROR] CacheControllerImpl:
> "org.apache.maven.buildcache.CacheControllerImpl" [ERROR]
> CacheLifecycleParticipant:
> "org.apache.maven.buildcache.CacheLifecycleParticipant" [ERROR]
> LifecyclePhasesHelper:
> "org.apache.maven.buildcache.LifecyclePhasesHelper" [ERROR] LocatorWiring:
> "org.eclipse.sisu.wire.LocatorWiring" [ERROR] PlexusBindingModule:
> "org.eclipse.sisu.plexus.PlexusBindingModule" [ERROR] WireModule:
> "org.eclipse.sisu.wire.WireModule" [ERROR]
> [ERROR] End of classname legend: [ERROR] [ERROR] ->
> [Help 1] org.apache.maven.InternalErrorException: Internal error:
> com.google.inject.ProvisionException: Unable to provision, see the following
> errors:1) [Guice/NullInjectedIntoNonNullable]: null returned by binding at
> LocatorWiring but the 3rd parameter of
> LifecyclePhasesHelper.(LifecyclePhasesHelper.java:61) is not @Nullable
> at LocatorWiring at
> LifecyclePhasesHelper.(LifecyclePhasesHelper.java:61) \_ for 3rd
> parameter at
> ClassRealm[coreExtension>org.apache.maven.extensions:maven-build-cache-extension:1.2.0,
> parent: ClassRealm[plexus.core, parent: null]] \_ installed by:
> WireModule -> PlexusBindingModule at
> CacheControllerImpl.(CacheControllerImpl.java:156) \_ for 10th
> parameter at
> ClassRealm[coreExtension>org.apache.maven.extensions:maven-build-cache-extension:1.2.0,
> parent
[jira] [Commented] (MNG-8123) Maven 4.0.0-beta-2 fails with maven-build-cache-extension 1.2.0
[
https://issues.apache.org/jira/browse/MNG-8123?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17848620#comment-17848620
]
ASF GitHub Bot commented on MNG-8123:
-
gnodet merged PR #1524:
URL: https://github.com/apache/maven/pull/1524
> Maven 4.0.0-beta-2 fails with maven-build-cache-extension 1.2.0
> ---
>
> Key: MNG-8123
> URL: https://issues.apache.org/jira/browse/MNG-8123
> Project: Maven
> Issue Type: Bug
>Affects Versions: 4.0.0-beta-2
>Reporter: Filipe Roque
>Priority: Major
> Fix For: 4.0.0-beta-3
>
>
> {code:java}
> ❯ mvn --version
> Apache Maven 4.0.0-beta-2 (828faba81940a8d2f2e5cfab6f60e35d1ab61ca0)
> Maven home: /opt/maven/apache-maven-4.0.0-beta-2
> Java version: 22.0.1, vendor: Eclipse Adoptium, runtime:
> /usr/lib/jvm/temurin-22-jdk-amd64
> Default locale: en_US, platform encoding: UTF-8
> OS name: "linux", version: "6.5.0-28-generic", arch: "amd64", family: "unix"
> {code}
> project created with
> {code:java}
> mvn archetype:generate {code}
> Adding maven cache extension
> {code:java}
> cat .mvn/extensions.xml
> http://maven.apache.org/EXTENSIONS/1.0.0";>
>
> org.apache.maven.extensions
> maven-build-cache-extension
> 1.2.0
>
>
> {code}
> Fails with:
> {code:java}
> ❯ mvn compile [INFO] Cache configuration is not available at configured path
> /home/froque/workspace/testes/project1/.mvn/maven-build-cache-config.xml,
> cache is enabled with defaults [INFO] Using XX hash algorithm for cache
> [ERROR] Internal error: com.google.inject.ProvisionException: Unable to
> provision, see the following errors: [ERROR] [ERROR] 1)
> [Guice/NullInjectedIntoNonNullable]: null returned by binding at
> LocatorWiring [ERROR] but the 3rd parameter of
> LifecyclePhasesHelper.(LifecyclePhasesHelper.java:61) is not @Nullable
> [ERROR] at LocatorWiring [ERROR] at
> LifecyclePhasesHelper.(LifecyclePhasesHelper.java:61) [ERROR] \_
> for 3rd parameter [ERROR] at
> ClassRealm[coreExtension>org.apache.maven.extensions:maven-build-cache-extension:1.2.0,
> parent: ClassRealm[plexus.core, parent: null]] [ERROR] \_ installed
> by: WireModule -> PlexusBindingModule [ERROR] at
> CacheControllerImpl.(CacheControllerImpl.java:156) [ERROR] \_ for
> 10th parameter [ERROR] at
> ClassRealm[coreExtension>org.apache.maven.extensions:maven-build-cache-extension:1.2.0,
> parent: ClassRealm[plexus.core, parent: null]] [ERROR] \_ installed
> by: WireModule -> PlexusBindingModule [ERROR] while locating
> CacheControllerImpl [ERROR] while locating Object annotated with * [ERROR]
> at LocatorWiring [ERROR] at
> CacheLifecycleParticipant.(CacheLifecycleParticipant.java:39) [ERROR]
> \_ for 2nd parameter [ERROR] at
> ClassRealm[coreExtension>org.apache.maven.extensions:maven-build-cache-extension:1.2.0,
> parent: ClassRealm[plexus.core, parent: null]] [ERROR] \_ installed
> by: WireModule -> PlexusBindingModule [ERROR] while locating
> CacheLifecycleParticipant [ERROR] while locating Object annotated with *
> [ERROR] [ERROR] Learn more: [ERROR]
> https://github.com/google/guice/wiki/NULL_INJECTED_INTO_NON_NULLABLE [ERROR]
> [ERROR] 1 error [ERROR] [ERROR] == [ERROR] Full
> classname legend: [ERROR] == [ERROR] CacheControllerImpl:
> "org.apache.maven.buildcache.CacheControllerImpl" [ERROR]
> CacheLifecycleParticipant:
> "org.apache.maven.buildcache.CacheLifecycleParticipant" [ERROR]
> LifecyclePhasesHelper:
> "org.apache.maven.buildcache.LifecyclePhasesHelper" [ERROR] LocatorWiring:
> "org.eclipse.sisu.wire.LocatorWiring" [ERROR] PlexusBindingModule:
> "org.eclipse.sisu.plexus.PlexusBindingModule" [ERROR] WireModule:
> "org.eclipse.sisu.wire.WireModule" [ERROR]
> [ERROR] End of classname legend: [ERROR] [ERROR] ->
> [Help 1] org.apache.maven.InternalErrorException: Internal error:
> com.google.inject.ProvisionException: Unable to provision, see the following
> errors:1) [Guice/NullInjectedIntoNonNullable]: null returned by binding at
> LocatorWiring but the 3rd parameter of
> LifecyclePhasesHelper.(LifecyclePhasesHelper.java:61) is not @Nullable
> at LocatorWiring at
> LifecyclePhasesHelper.(LifecyclePhasesHelper.java:61) \_ for 3rd
> parameter at
> ClassRealm[coreExtension>org.apache.maven.extensions:maven-build-cache-extension:1.2.0,
> parent: ClassRealm[plexus.core, parent: null]] \_ installed by:
> WireModule -> PlexusBindingModule at
> CacheControllerImpl.(CacheControllerImpl.java:156) \_ for 10th
> parameter at
> ClassRealm[coreExtension>org.apache.maven.extensions:maven
Re: [PR] Bump org.jboss.forge.roaster:roaster-jdt from 2.28.0.Final to 2.29.0.Final [maven-mvnd]
cstamas merged PR #963: URL: https://github.com/apache/maven-mvnd/pull/963 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump org.javassist:javassist from 3.29.2-GA to 3.30.2-GA [maven-mvnd]
cstamas merged PR #972: URL: https://github.com/apache/maven-mvnd/pull/972 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump com.google.guava:guava from 32.1.3-jre to 33.2.0-jre [maven-mvnd]
cstamas merged PR #985: URL: https://github.com/apache/maven-mvnd/pull/985 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump info.picocli:picocli-codegen from 4.5.2 to 4.7.6 [maven-mvnd]
cstamas merged PR #988: URL: https://github.com/apache/maven-mvnd/pull/988 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump testcontainers.version from 1.19.7 to 1.19.8 [maven-mvnd]
cstamas merged PR #991: URL: https://github.com/apache/maven-mvnd/pull/991 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump graalvm.version from 22.3.1 to 24.0.1 [maven-mvnd]
cstamas commented on PR #962: URL: https://github.com/apache/maven-mvnd/pull/962#issuecomment-2124775490 @dependabot rebase -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump org.jboss.forge.roaster:roaster-jdt from 2.28.0.Final to 2.29.0.Final [maven-mvnd]
cstamas commented on PR #963: URL: https://github.com/apache/maven-mvnd/pull/963#issuecomment-2124774999 @dependabot rebase -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump org.javassist:javassist from 3.29.2-GA to 3.30.2-GA [maven-mvnd]
cstamas commented on PR #972: URL: https://github.com/apache/maven-mvnd/pull/972#issuecomment-2124774653 @dependabot rebase -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump com.google.guava:guava from 32.1.3-jre to 33.2.0-jre [maven-mvnd]
cstamas commented on PR #985: URL: https://github.com/apache/maven-mvnd/pull/985#issuecomment-2124774155 @dependabot rebase -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump info.picocli:picocli-codegen from 4.5.2 to 4.7.6 [maven-mvnd]
cstamas commented on PR #988: URL: https://github.com/apache/maven-mvnd/pull/988#issuecomment-2124773683 @dependabot rebase -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump testcontainers.version from 1.19.7 to 1.19.8 [maven-mvnd]
cstamas commented on PR #991: URL: https://github.com/apache/maven-mvnd/pull/991#issuecomment-2124773401 @dependabot rebase -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump info.picocli:picocli-codegen from 4.5.2 to 4.7.6 [maven-mvnd]
cstamas commented on PR #988: URL: https://github.com/apache/maven-mvnd/pull/988#issuecomment-2124771830 https://github.com/dependabot rebase -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump info.picocli:picocli-codegen from 4.5.2 to 4.7.6 [maven-mvnd]
dependabot[bot] commented on PR #988: URL: https://github.com/apache/maven-mvnd/pull/988#issuecomment-2124772418 Looks like this PR is already up-to-date with master! If you'd still like to recreate it from scratch, overwriting any edits, you can request `@dependabot recreate`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump info.picocli:picocli-codegen from 4.5.2 to 4.7.6 [maven-mvnd]
dependabot[bot] commented on PR #988: URL: https://github.com/apache/maven-mvnd/pull/988#issuecomment-2124771938 Looks like this PR is already up-to-date with master! If you'd still like to recreate it from scratch, overwriting any edits, you can request `@dependabot recreate`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump testcontainers.version from 1.19.7 to 1.19.8 [maven-mvnd]
dependabot[bot] commented on PR #991: URL: https://github.com/apache/maven-mvnd/pull/991#issuecomment-2124771564 Looks like this PR is already up-to-date with master! If you'd still like to recreate it from scratch, overwriting any edits, you can request `@dependabot recreate`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump testcontainers.version from 1.19.7 to 1.19.8 [maven-mvnd]
cstamas commented on PR #991: URL: https://github.com/apache/maven-mvnd/pull/991#issuecomment-2124771452 @dependabot rebase -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump org.jboss.forge.roaster:roaster-jdt from 2.28.0.Final to 2.29.0.Final [maven-mvnd]
cstamas commented on PR #963: URL: https://github.com/apache/maven-mvnd/pull/963#issuecomment-2124757271 @dependabot rebase -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump org.javassist:javassist from 3.29.2-GA to 3.30.2-GA [maven-mvnd]
cstamas commented on PR #972: URL: https://github.com/apache/maven-mvnd/pull/972#issuecomment-2124756566 @dependabot rebase -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump com.google.guava:guava from 32.1.3-jre to 33.2.0-jre [maven-mvnd]
cstamas commented on PR #985: URL: https://github.com/apache/maven-mvnd/pull/985#issuecomment-2124756126 @dependabot rebase -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump info.picocli:picocli-codegen from 4.5.2 to 4.7.6 [maven-mvnd]
cstamas commented on PR #988: URL: https://github.com/apache/maven-mvnd/pull/988#issuecomment-2124755681 @dependabot rebase -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump testcontainers.version from 1.19.7 to 1.19.8 [maven-mvnd]
cstamas commented on PR #991: URL: https://github.com/apache/maven-mvnd/pull/991#issuecomment-2124755284 @dependabot rebase -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
