[PR] Bump org.apache.commons:commons-compress from 1.26.1 to 1.26.2 [maven-assembly-plugin]
dependabot[bot] opened a new pull request, #206: URL: https://github.com/apache/maven-assembly-plugin/pull/206 Bumps org.apache.commons:commons-compress from 1.26.1 to 1.26.2. [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MDEP-799) improve mvn dependency:tree - add optional JSON output of the results
[ https://issues.apache.org/jira/browse/MDEP-799?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17849153#comment-17849153 ] ASF GitHub Bot commented on MDEP-799: - slawekjaranowski commented on PR #391: URL: https://github.com/apache/maven-dependency-plugin/pull/391#issuecomment-2128524291 Thanks again everybody for contribution ... but we are lack of documentation, so I created issue: https://issues.apache.org/jira/browse/MDEP-933 @LogFlames @elharo or someone else can you look. > improve mvn dependency:tree - add optional JSON output of the results > - > > Key: MDEP-799 > URL: https://issues.apache.org/jira/browse/MDEP-799 > Project: Maven Dependency Plugin > Issue Type: New Feature > Components: tree >Reporter: Zhenxu Ke >Assignee: Elliotte Rusty Harold >Priority: Major > Fix For: 3.7.0 > > > I'd like to add an output type JSON, will open a pull request soon -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] [MDEP-799] tree: add optional output type json [maven-dependency-plugin]
slawekjaranowski commented on PR #391: URL: https://github.com/apache/maven-dependency-plugin/pull/391#issuecomment-2128524291 Thanks again everybody for contribution ... but we are lack of documentation, so I created issue: https://issues.apache.org/jira/browse/MDEP-933 @LogFlames @elharo or someone else can you look. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (MDEP-933) Documents new output format - JSON of dependency:tree
Slawomir Jaranowski created MDEP-933: Summary: Documents new output format - JSON of dependency:tree Key: MDEP-933 URL: https://issues.apache.org/jira/browse/MDEP-933 Project: Maven Dependency Plugin Issue Type: Improvement Components: tree Reporter: Slawomir Jaranowski Fix For: 3.7.0 We add new output format for dependency:tree but we are lack of documentation We should add to Mojo description: [https://maven.apache.org/plugins/maven-dependency-plugin/tree-mojo.html] and to parameter [https://maven.apache.org/plugins/maven-dependency-plugin/tree-mojo.html#outputType] I would to see an example page with format description. In other case it will be complicated to use new feature. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[PR] Bump org.apache.commons:commons-compress from 1.26.1 to 1.26.2 [maven-mvnd]
dependabot[bot] opened a new pull request, #1001: URL: https://github.com/apache/maven-mvnd/pull/1001 Bumps org.apache.commons:commons-compress from 1.26.1 to 1.26.2. [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] Bump org.apache.commons:commons-compress from 1.26.1 to 1.26.2 [maven-shade-plugin]
dependabot[bot] opened a new pull request, #224: URL: https://github.com/apache/maven-shade-plugin/pull/224 Bumps org.apache.commons:commons-compress from 1.26.1 to 1.26.2. [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] Bump org.apache.commons:commons-compress from 1.26.1 to 1.26.2 [maven-resolver]
dependabot[bot] opened a new pull request, #499: URL: https://github.com/apache/maven-resolver/pull/499 Bumps org.apache.commons:commons-compress from 1.26.1 to 1.26.2. [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] Bump commons-cli:commons-cli from 1.7.0 to 1.8.0 [maven-indexer]
dependabot[bot] opened a new pull request, #368: URL: https://github.com/apache/maven-indexer/pull/368 Bumps commons-cli:commons-cli from 1.7.0 to 1.8.0. [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] Bump org.gaul:modernizer-maven-plugin from 2.8.0 to 2.9.0 [maven-indexer]
dependabot[bot] opened a new pull request, #367: URL: https://github.com/apache/maven-indexer/pull/367 Bumps [org.gaul:modernizer-maven-plugin](https://github.com/gaul/modernizer-maven-plugin) from 2.8.0 to 2.9.0. Release notes Sourced from https://github.com/gaul/modernizer-maven-plugin/releases;>org.gaul:modernizer-maven-plugin's releases. Modernizer Maven Plugin 2.9.0 Upgrade to ASM 9.7 Revert unneeded Maven core dependency from 3.9.5 to 3.2.5, https://redirect.github.com/gaul/modernizer-maven-plugin/issues/241;>#241 Thanks https://github.com/cstamas;>@cstamas for sending pull requests to improve Modernizer! Commits https://github.com/gaul/modernizer-maven-plugin/commit/8ddb06e85d9aa4cdb45504f937d6d4f9ec15d57d;>8ddb06e modernizer-maven-plugin 2.9.0 release https://github.com/gaul/modernizer-maven-plugin/commit/6da2deeb31437ac7f188e3086a62c2d48b01a69f;>6da2dee Bump Java requirement to 8 https://github.com/gaul/modernizer-maven-plugin/commit/a1a76876cdf4587b18bd3b09b4130c3ec53c3fd0;>a1a7687 Bump org.apache.maven.plugins:maven-invoker-plugin from 3.6.0 to 3.6.1 https://github.com/gaul/modernizer-maven-plugin/commit/f1b89c8a2cb84f81d801992e99713e7e3f1a6b09;>f1b89c8 Bump commons-codec:commons-codec from 1.16.1 to 1.17.0 https://github.com/gaul/modernizer-maven-plugin/commit/c4e89696d4b3f3b2c8d628b4b9886d95e9405a8c;>c4e8969 Bump org.apache.maven.plugins:maven-source-plugin from 3.3.0 to 3.3.1 https://github.com/gaul/modernizer-maven-plugin/commit/95cf270262f6ad629e851ab6db30a37a2916970e;>95cf270 Bump org.apache.maven.plugin-tools:maven-plugin-annotations https://github.com/gaul/modernizer-maven-plugin/commit/195962de0a4f7015463ca705c99880faff805de9;>195962d Bump org.apache.maven.plugins:maven-gpg-plugin from 3.2.1 to 3.2.2 https://github.com/gaul/modernizer-maven-plugin/commit/8bf26900c1851d6f9be252f34d199580f5790a69;>8bf2690 Bump asm.version from 9.6 to 9.7 https://github.com/gaul/modernizer-maven-plugin/commit/58492bd4c995dea89bad95ee49af7931a5a88139;>58492bd Bump org.apache.commons:commons-lang3 from 3.13.0 to 3.14.0 https://github.com/gaul/modernizer-maven-plugin/commit/a3ca0913d286b14b1e707763bd4cbe7a7bce891b;>a3ca091 [renormalize] Correct line endings on mvnw.cmd Additional commits viewable in https://github.com/gaul/modernizer-maven-plugin/compare/modernizer-maven-plugin-2.8.0...modernizer-maven-plugin-2.9.0;>compare view [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump commons-cli:commons-cli from 1.6.0 to 1.7.0 [maven-doxia-converter]
dependabot[bot] commented on PR #70: URL: https://github.com/apache/maven-doxia-converter/pull/70#issuecomment-2128487085 Superseded by #73. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump commons-cli:commons-cli from 1.6.0 to 1.7.0 [maven-doxia-converter]
dependabot[bot] closed pull request #70: Bump commons-cli:commons-cli from 1.6.0 to 1.7.0 URL: https://github.com/apache/maven-doxia-converter/pull/70 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] Bump commons-cli:commons-cli from 1.6.0 to 1.8.0 [maven-doxia-converter]
dependabot[bot] opened a new pull request, #73: URL: https://github.com/apache/maven-doxia-converter/pull/73 Bumps commons-cli:commons-cli from 1.6.0 to 1.8.0. [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump commons-cli:commons-cli from 1.5.0 to 1.7.0 [maven]
dependabot[bot] commented on PR #1536: URL: https://github.com/apache/maven/pull/1536#issuecomment-2128301334 Superseded by #1537. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump commons-cli:commons-cli from 1.5.0 to 1.7.0 [maven]
dependabot[bot] closed pull request #1536: Bump commons-cli:commons-cli from 1.5.0 to 1.7.0 URL: https://github.com/apache/maven/pull/1536 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] Bump commons-cli:commons-cli from 1.5.0 to 1.8.0 [maven]
dependabot[bot] opened a new pull request, #1537: URL: https://github.com/apache/maven/pull/1537 Bumps commons-cli:commons-cli from 1.5.0 to 1.8.0. [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MDEP-799) improve mvn dependency:tree - add optional JSON output of the results
[ https://issues.apache.org/jira/browse/MDEP-799?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17849124#comment-17849124 ] ASF GitHub Bot commented on MDEP-799: - pombredanne commented on PR #391: URL: https://github.com/apache/maven-dependency-plugin/pull/391#issuecomment-2128158079 Everyone thank you ++ and @LogFlames :bow: :heart: You have rendered obsolete about 22K files on GitHub that try to parse the output of tree! See https://github.com/search?q=mvn+"dependency%3Atree"=code @LogFlames @monperrus I guess you plan to use it in https://github.com/chains-project/maven-lockfile ? FWIW, on my side this is going to be used in a front end to the https://github.com/nexB/scancode.io/ code scanner and matcher: - created for Maven in in https://github.com/nexB/dependency-inspector/issues/6 - otherwise, part of a general purpose solution to https://github.com/nexB/dependency-inspector/issues/2 - and the companion to ecosystem-specific dependency resolvers such as https://github.com/nexB/python-inspector or https://github.com/nexB/nuget-inspector > improve mvn dependency:tree - add optional JSON output of the results > - > > Key: MDEP-799 > URL: https://issues.apache.org/jira/browse/MDEP-799 > Project: Maven Dependency Plugin > Issue Type: New Feature > Components: tree >Reporter: Zhenxu Ke >Assignee: Elliotte Rusty Harold >Priority: Major > Fix For: 3.7.0 > > > I'd like to add an output type JSON, will open a pull request soon -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] [MDEP-799] tree: add optional output type json [maven-dependency-plugin]
pombredanne commented on PR #391: URL: https://github.com/apache/maven-dependency-plugin/pull/391#issuecomment-2128158079 Everyone thank you ++ and @LogFlames :bow: :heart: You have rendered obsolete about 22K files on GitHub that try to parse the output of tree! See https://github.com/search?q=mvn+"dependency%3Atree"=code @LogFlames @monperrus I guess you plan to use it in https://github.com/chains-project/maven-lockfile ? FWIW, on my side this is going to be used in a front end to the https://github.com/nexB/scancode.io/ code scanner and matcher: - created for Maven in in https://github.com/nexB/dependency-inspector/issues/6 - otherwise, part of a general purpose solution to https://github.com/nexB/dependency-inspector/issues/2 - and the companion to ecosystem-specific dependency resolvers such as https://github.com/nexB/python-inspector or https://github.com/nexB/nuget-inspector -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MDEP-932) Don't log successful file copies
[
https://issues.apache.org/jira/browse/MDEP-932?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17849058#comment-17849058
]
Elliotte Rusty Harold commented on MDEP-932:
Might be a moot point after
https://github.com/apache/maven-dependency-plugin/pull/389 lands
> Don't log successful file copies
>
>
> Key: MDEP-932
> URL: https://issues.apache.org/jira/browse/MDEP-932
> Project: Maven Dependency Plugin
> Issue Type: Improvement
>Reporter: Elliotte Rusty Harold
>Priority: Minor
>
> In AbstractDependencyMojo
> Either a file is copied successfully and no one wants to read this message or
> it fails and an exception is thrown. Either way, the log message simply isn't
> needed and gets in the way of debugging real failures.
> /**
> * Does the actual copy of the file and logging.
> *
> * @param artifact represents the file to copy.
> * @param destFile file name of destination file.
> * @throws MojoExecutionException with a message if an error occurs.
> */
> protected void copyFile(File artifact, File destFile) throws
> MojoExecutionException {
> try {
> getLog().info("Copying "
> + (this.outputAbsoluteArtifactFilename ?
> artifact.getAbsolutePath() : artifact.getName()) + " to "
> + destFile);
> if (artifact.isDirectory()) {
> // usual case is a future jar packaging, but there are
> special cases: classifier and other packaging
> throw new MojoExecutionException("Artifact has not been
> packaged yet. When used on reactor artifact, "
> + "copy should be executed after packaging: see
> MDEP-187.");
> }
> FileUtils.copyFile(artifact, destFile);
> buildContext.refresh(destFile);
> } catch (IOException e) {
> throw new MojoExecutionException("Error copying artifact from " +
> artifact + " to " + destFile, e);
> }
> }
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Updated] (MDEP-932) Don't log successful file copies
[
https://issues.apache.org/jira/browse/MDEP-932?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Elliotte Rusty Harold updated MDEP-932:
---
Description:
In AbstractDependencyMojo
Either a file is copied successfully and no one wants to read this message or
it fails and an exception is thrown. Either way, the log message simply isn't
needed and gets in the way of debugging real failures.
/**
* Does the actual copy of the file and logging.
*
* @param artifact represents the file to copy.
* @param destFile file name of destination file.
* @throws MojoExecutionException with a message if an error occurs.
*/
protected void copyFile(File artifact, File destFile) throws
MojoExecutionException {
try {
getLog().info("Copying "
+ (this.outputAbsoluteArtifactFilename ?
artifact.getAbsolutePath() : artifact.getName()) + " to "
+ destFile);
if (artifact.isDirectory()) {
// usual case is a future jar packaging, but there are special
cases: classifier and other packaging
throw new MojoExecutionException("Artifact has not been
packaged yet. When used on reactor artifact, "
+ "copy should be executed after packaging: see
MDEP-187.");
}
FileUtils.copyFile(artifact, destFile);
buildContext.refresh(destFile);
} catch (IOException e) {
throw new MojoExecutionException("Error copying artifact from " +
artifact + " to " + destFile, e);
}
}
was:
In AbstarctDependencyMojo
Either a is file copied successfully and no one wants to read this message or
it fails and an exception is thrown. Either way, the log message simply isn';t
needed and gets in the way of debugging real failures.
/**
* Does the actual copy of the file and logging.
*
* @param artifact represents the file to copy.
* @param destFile file name of destination file.
* @throws MojoExecutionException with a message if an error occurs.
*/
protected void copyFile(File artifact, File destFile) throws
MojoExecutionException {
try {
getLog().info("Copying "
+ (this.outputAbsoluteArtifactFilename ?
artifact.getAbsolutePath() : artifact.getName()) + " to "
+ destFile);
if (artifact.isDirectory()) {
// usual case is a future jar packaging, but there are special
cases: classifier and other packaging
throw new MojoExecutionException("Artifact has not been
packaged yet. When used on reactor artifact, "
+ "copy should be executed after packaging: see
MDEP-187.");
}
FileUtils.copyFile(artifact, destFile);
buildContext.refresh(destFile);
} catch (IOException e) {
throw new MojoExecutionException("Error copying artifact from " +
artifact + " to " + destFile, e);
}
}
> Don't log successful file copies
>
>
> Key: MDEP-932
> URL: https://issues.apache.org/jira/browse/MDEP-932
> Project: Maven Dependency Plugin
> Issue Type: Improvement
>Reporter: Elliotte Rusty Harold
>Priority: Minor
>
> In AbstractDependencyMojo
> Either a file is copied successfully and no one wants to read this message or
> it fails and an exception is thrown. Either way, the log message simply isn't
> needed and gets in the way of debugging real failures.
> /**
> * Does the actual copy of the file and logging.
> *
> * @param artifact represents the file to copy.
> * @param destFile file name of destination file.
> * @throws MojoExecutionException with a message if an error occurs.
> */
> protected void copyFile(File artifact, File destFile) throws
> MojoExecutionException {
> try {
> getLog().info("Copying "
> + (this.outputAbsoluteArtifactFilename ?
> artifact.getAbsolutePath() : artifact.getName()) + " to "
> + destFile);
> if (artifact.isDirectory()) {
> // usual case is a future jar packaging, but there are
> special cases: classifier and other packaging
> throw new MojoExecutionException("Artifact has not been
> packaged yet. When used on reactor artifact, "
> + "copy should be executed after packaging: see
> MDEP-187.");
> }
> FileUtils.copyFile(artifact, destFile);
> buildContext.refresh(destFile);
> } catch (IOException e) {
> throw new MojoExecutionException("Error copying artifact from " +
> artifact + " to " + destFile, e);
> }
> }
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MDEP-932) Don't log successful file copies
[
https://issues.apache.org/jira/browse/MDEP-932?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17849051#comment-17849051
]
Michael Osipov commented on MDEP-932:
-
I agree, it should be at most debug level. Too much granularity.
> Don't log successful file copies
>
>
> Key: MDEP-932
> URL: https://issues.apache.org/jira/browse/MDEP-932
> Project: Maven Dependency Plugin
> Issue Type: Improvement
>Reporter: Elliotte Rusty Harold
>Priority: Minor
>
> In AbstarctDependencyMojo
> Either a is file copied successfully and no one wants to read this message or
> it fails and an exception is thrown. Either way, the log message simply
> isn';t needed and gets in the way of debugging real failures.
> /**
> * Does the actual copy of the file and logging.
> *
> * @param artifact represents the file to copy.
> * @param destFile file name of destination file.
> * @throws MojoExecutionException with a message if an error occurs.
> */
> protected void copyFile(File artifact, File destFile) throws
> MojoExecutionException {
> try {
> getLog().info("Copying "
> + (this.outputAbsoluteArtifactFilename ?
> artifact.getAbsolutePath() : artifact.getName()) + " to "
> + destFile);
> if (artifact.isDirectory()) {
> // usual case is a future jar packaging, but there are
> special cases: classifier and other packaging
> throw new MojoExecutionException("Artifact has not been
> packaged yet. When used on reactor artifact, "
> + "copy should be executed after packaging: see
> MDEP-187.");
> }
> FileUtils.copyFile(artifact, destFile);
> buildContext.refresh(destFile);
> } catch (IOException e) {
> throw new MojoExecutionException("Error copying artifact from " +
> artifact + " to " + destFile, e);
> }
> }
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MPMD-396) Impractical to fail build on violation
[
https://issues.apache.org/jira/browse/MPMD-396?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17849050#comment-17849050
]
Michael Osipov commented on MPMD-396:
-
Regardless of the forking, one needs to check the code for the follwing:
checking mojos and report mojos. In your case it should really be a checker
mojo.
> Impractical to fail build on violation
> --
>
> Key: MPMD-396
> URL: https://issues.apache.org/jira/browse/MPMD-396
> Project: Maven PMD Plugin
> Issue Type: Bug
> Components: PMD
>Affects Versions: 3.22.0
>Reporter: Delany
>Priority: Major
>
> Let me start with what I'm trying to achieve. I have a multi-module build and
> I want it to fail on a violation, quickly.
> I'm not interesting in producing a report.
> The build may include anything from a single module to all modules. In each
> case, I don't want PMD to try parse the entire code base if I only asked
> Maven to build a single module.
> I notice that if I use the "aggregate-pmd-check" goal, I get log lines like
> {{[WARNING] org.apache.maven.plugins.pmd.AggregatorPmdReport - Unable to
> locate Source XRef to link to - DISABLED}}
> Why is AggregatorPmdReport being invoked? Sounds like a legacy issue.
> I also notice that unlike most Maven plugins, the pmd-maven-plugin goal is
> always forking, indicated by chevrons in the output {{<<< pmd:3.22.0:check}}
> With a single custom XPath rule, the time to complete a build becomes
> impractical.
> I was hoping to add pmd to my list of static analysis checkers/formatters
> like checkstyle, impsort, sortpom, errorprone, modernizer etc which are all
> able to parse source code and do various checks without becoming a burden.
> With the current state of the pmd-maven-plugin (v3.22.0) that does not look
> likely.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
Re: [PR] [MDEP-923] Extract copyFile method from AbstractDependencyMojo [maven-dependency-plugin]
slawekjaranowski commented on code in PR #389:
URL:
https://github.com/apache/maven-dependency-plugin/pull/389#discussion_r1612080238
##
src/test/java/org/apache/maven/plugins/dependency/fromDependencies/TestCopyDependenciesMojo.java:
##
@@ -80,7 +80,7 @@ public void assertNoMarkerFile(Artifact artifact) throws
MojoExecutionException
assertFalse(handle.isMarkerSet());
}
-public void testCopyFile() throws MojoExecutionException, IOException {
+public void testCopyFile() throws Exception {
Review Comment:
ok, one exception is new in 3.7.0 but one is old from copied class - so
should I discovered versions for original class or add since now
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Commented] (MDEP-923) Code cleanups
[
https://issues.apache.org/jira/browse/MDEP-923?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17849049#comment-17849049
]
ASF GitHub Bot commented on MDEP-923:
-
slawekjaranowski commented on code in PR #389:
URL:
https://github.com/apache/maven-dependency-plugin/pull/389#discussion_r1612080238
##
src/test/java/org/apache/maven/plugins/dependency/fromDependencies/TestCopyDependenciesMojo.java:
##
@@ -80,7 +80,7 @@ public void assertNoMarkerFile(Artifact artifact) throws
MojoExecutionException
assertFalse(handle.isMarkerSet());
}
-public void testCopyFile() throws MojoExecutionException, IOException {
+public void testCopyFile() throws Exception {
Review Comment:
ok, one exception is new in 3.7.0 but one is old from copied class - so
should I discovered versions for original class or add since now
> Code cleanups
> -
>
> Key: MDEP-923
> URL: https://issues.apache.org/jira/browse/MDEP-923
> Project: Maven Dependency Plugin
> Issue Type: Task
>Reporter: Slawomir Jaranowski
>Assignee: Slawomir Jaranowski
>Priority: Major
> Fix For: 3.7.0
>
>
> * remove usage of deprecated API where possible
> * cleanup pom after update to 42
> * exclude transitive dependencies on org.apache.maven
> * add {{@project.version@}} in ITs
> * Remove plexus logger from DependencySilentLog
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MPMD-391) Log what developers care about and not what they don't
[ https://issues.apache.org/jira/browse/MPMD-391?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17849039#comment-17849039 ] Elliotte Rusty Harold commented on MPMD-391: I don't know. If so it's probably part of maven core rather than this plugin since it comes up in every failure from any plugin. > Log what developers care about and not what they don't > -- > > Key: MPMD-391 > URL: https://issues.apache.org/jira/browse/MPMD-391 > Project: Maven PMD Plugin > Issue Type: Improvement >Reporter: Elliotte Rusty Harold >Priority: Major > > Here's output from a recent PMD plugin run that failed: > [INFO] >>> maven-pmd-plugin:3.21.2:check (default-cli) > :pmd @ commons-io >>> > [INFO] > [INFO] --- maven-pmd-plugin:3.21.2:pmd (pmd) @ commons-io --- > [INFO] PMD version: 6.55.0 > [INFO] Rendering content with > org.apache.maven.skins:maven-default-skin:jar:1.3 skin. > [INFO] > [INFO] <<< maven-pmd-plugin:3.21.2:check (default-cli) < :pmd @ commons-io <<< > [INFO] > [INFO] > [INFO] --- maven-pmd-plugin:3.21.2:check (default-cli) @ commons-io --- > [INFO] PMD version: 6.55.0 > [INFO] > > [INFO] BUILD FAILURE > [INFO] > > [INFO] Total time: 05:22 min > [INFO] Finished at: 2024-01-14T14:11:30Z > [INFO] > > Error: Failed to execute goal > org.apache.maven.plugins:maven-pmd-plugin:3.21.2:check (default-cli) on > project commons-io: You have 1 PMD violation. For more details see: > /home/runner/work/commons-io/commons-io/target/pmd.xml -> [Help 1] > Error: > Error: To see the full stack trace of the errors, re-run Maven with the -e > switch. > Error: Re-run Maven using the -X switch to enable full debug logging. > Error: > Error: For more information about the errors and possible solutions, please > read the following articles: > Error: [Help 1] > http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException > Error: Process completed with exit code 1. > Things I don't care about that are printed: > * PMD version > * Doxia skin > * Blank lines > * Total time > * Timestamp when it finished > * Generic information about Mojo failures > * Exit code from Mojo > The one thing I care about: > * The actual error that caused the failure > Everything in the first list can be hidden in some random log file no one > will ever look at. Everything in the second list should be front and center. > Instead Maven gets this exactly backwards, -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MDEP-799) improve mvn dependency:tree - add optional JSON output of the results
[ https://issues.apache.org/jira/browse/MDEP-799?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17849038#comment-17849038 ] ASF GitHub Bot commented on MDEP-799: - elharo commented on PR #325: URL: https://github.com/apache/maven-dependency-plugin/pull/325#issuecomment-2127618794 feature complete under another PR > improve mvn dependency:tree - add optional JSON output of the results > - > > Key: MDEP-799 > URL: https://issues.apache.org/jira/browse/MDEP-799 > Project: Maven Dependency Plugin > Issue Type: New Feature > Components: tree >Reporter: Zhenxu Ke >Assignee: Elliotte Rusty Harold >Priority: Major > Fix For: 3.7.0 > > > I'd like to add an output type JSON, will open a pull request soon -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MDEP-799) improve mvn dependency:tree - add optional JSON output of the results
[ https://issues.apache.org/jira/browse/MDEP-799?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17849037#comment-17849037 ] ASF GitHub Bot commented on MDEP-799: - elharo closed pull request #325: [MDEP-799] tree: add optional output type json URL: https://github.com/apache/maven-dependency-plugin/pull/325 > improve mvn dependency:tree - add optional JSON output of the results > - > > Key: MDEP-799 > URL: https://issues.apache.org/jira/browse/MDEP-799 > Project: Maven Dependency Plugin > Issue Type: New Feature > Components: tree >Reporter: Zhenxu Ke >Assignee: Elliotte Rusty Harold >Priority: Major > Fix For: 3.7.0 > > > I'd like to add an output type JSON, will open a pull request soon -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] [MDEP-799] tree: add optional output type json [maven-dependency-plugin]
elharo commented on PR #325: URL: https://github.com/apache/maven-dependency-plugin/pull/325#issuecomment-2127618794 feature complete under another PR -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MDEP-799) improve mvn dependency:tree - add optional JSON output of the results
[ https://issues.apache.org/jira/browse/MDEP-799?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17849035#comment-17849035 ] ASF GitHub Bot commented on MDEP-799: - elharo closed pull request #207: [MDEP-799] - improve dependency:tree to add optional JSON output of the results URL: https://github.com/apache/maven-dependency-plugin/pull/207 > improve mvn dependency:tree - add optional JSON output of the results > - > > Key: MDEP-799 > URL: https://issues.apache.org/jira/browse/MDEP-799 > Project: Maven Dependency Plugin > Issue Type: New Feature > Components: tree >Reporter: Zhenxu Ke >Assignee: Elliotte Rusty Harold >Priority: Major > Fix For: 3.7.0 > > > I'd like to add an output type JSON, will open a pull request soon -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] [MDEP-799] tree: add optional output type json [maven-dependency-plugin]
elharo closed pull request #325: [MDEP-799] tree: add optional output type json URL: https://github.com/apache/maven-dependency-plugin/pull/325 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MDEP-799) improve mvn dependency:tree - add optional JSON output of the results
[ https://issues.apache.org/jira/browse/MDEP-799?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17849036#comment-17849036 ] ASF GitHub Bot commented on MDEP-799: - elharo commented on PR #207: URL: https://github.com/apache/maven-dependency-plugin/pull/207#issuecomment-2127618346 feature complete under another PR > improve mvn dependency:tree - add optional JSON output of the results > - > > Key: MDEP-799 > URL: https://issues.apache.org/jira/browse/MDEP-799 > Project: Maven Dependency Plugin > Issue Type: New Feature > Components: tree >Reporter: Zhenxu Ke >Assignee: Elliotte Rusty Harold >Priority: Major > Fix For: 3.7.0 > > > I'd like to add an output type JSON, will open a pull request soon -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] [MDEP-799] - improve dependency:tree to add optional JSON output of the results [maven-dependency-plugin]
elharo commented on PR #207: URL: https://github.com/apache/maven-dependency-plugin/pull/207#issuecomment-2127618346 feature complete under another PR -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [MDEP-799] - improve dependency:tree to add optional JSON output of the results [maven-dependency-plugin]
elharo closed pull request #207: [MDEP-799] - improve dependency:tree to add optional JSON output of the results URL: https://github.com/apache/maven-dependency-plugin/pull/207 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MDEP-923) Code cleanups
[
https://issues.apache.org/jira/browse/MDEP-923?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17849031#comment-17849031
]
ASF GitHub Bot commented on MDEP-923:
-
elharo commented on code in PR #389:
URL:
https://github.com/apache/maven-dependency-plugin/pull/389#discussion_r1612013270
##
src/test/java/org/apache/maven/plugins/dependency/fromDependencies/TestCopyDependenciesMojo.java:
##
@@ -80,7 +80,7 @@ public void assertNoMarkerFile(Artifact artifact) throws
MojoExecutionException
assertFalse(handle.isMarkerSet());
}
-public void testCopyFile() throws MojoExecutionException, IOException {
+public void testCopyFile() throws Exception {
Review Comment:
I like to know when an exception is added or removed from an API, and I'd
make the same comment about the other methods in this class. :-)
> Code cleanups
> -
>
> Key: MDEP-923
> URL: https://issues.apache.org/jira/browse/MDEP-923
> Project: Maven Dependency Plugin
> Issue Type: Task
>Reporter: Slawomir Jaranowski
>Assignee: Slawomir Jaranowski
>Priority: Major
> Fix For: 3.7.0
>
>
> * remove usage of deprecated API where possible
> * cleanup pom after update to 42
> * exclude transitive dependencies on org.apache.maven
> * add {{@project.version@}} in ITs
> * Remove plexus logger from DependencySilentLog
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
Re: [PR] [MDEP-923] Extract copyFile method from AbstractDependencyMojo [maven-dependency-plugin]
elharo commented on code in PR #389:
URL:
https://github.com/apache/maven-dependency-plugin/pull/389#discussion_r1612013270
##
src/test/java/org/apache/maven/plugins/dependency/fromDependencies/TestCopyDependenciesMojo.java:
##
@@ -80,7 +80,7 @@ public void assertNoMarkerFile(Artifact artifact) throws
MojoExecutionException
assertFalse(handle.isMarkerSet());
}
-public void testCopyFile() throws MojoExecutionException, IOException {
+public void testCopyFile() throws Exception {
Review Comment:
I like to know when an exception is added or removed from an API, and I'd
make the same comment about the other methods in this class. :-)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Commented] (MDEP-799) improve mvn dependency:tree - add optional JSON output of the results
[ https://issues.apache.org/jira/browse/MDEP-799?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17849027#comment-17849027 ] ASF GitHub Bot commented on MDEP-799: - monperrus commented on PR #391: URL: https://github.com/apache/maven-dependency-plugin/pull/391#issuecomment-2127542024 > There is on my list ... I hope do next release 3.7.0 it at next week or two excellent, thanks! > improve mvn dependency:tree - add optional JSON output of the results > - > > Key: MDEP-799 > URL: https://issues.apache.org/jira/browse/MDEP-799 > Project: Maven Dependency Plugin > Issue Type: New Feature > Components: tree >Reporter: Zhenxu Ke >Assignee: Elliotte Rusty Harold >Priority: Major > Fix For: 3.7.0 > > > I'd like to add an output type JSON, will open a pull request soon -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] [MDEP-799] tree: add optional output type json [maven-dependency-plugin]
monperrus commented on PR #391: URL: https://github.com/apache/maven-dependency-plugin/pull/391#issuecomment-2127542024 > There is on my list ... I hope do next release 3.7.0 it at next week or two excellent, thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MPLUGIN-525) Remove ant and beanshell support
[ https://issues.apache.org/jira/browse/MPLUGIN-525?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17849026#comment-17849026 ] ASF GitHub Bot commented on MPLUGIN-525: gnodet commented on PR #285: URL: https://github.com/apache/maven-plugin-tools/pull/285#issuecomment-2127541125 > > > Is this Maven 4 only? > > > > > > Yes, I've created a [3.x branch](https://github.com/apache/maven-plugin-tools/tree/3.x) to support Maven 3 plugins and master will support Maven 4 plugins. The goal is to split the plugins to ease maintenance, as the code will ultimately be quite different. See https://issues.apache.org/jira/browse/MPLUGIN-523. We should also drop the Maven 4.x support from the 3.x branch. > > I see. There is no way to have this in one branch with common modules and module per Maven version? Sure, I suppose it's technically feasible, but instead of streamlining and making the code simpler, it will have the exact opposite effect. The javadoc generator is now irrelevant, and the generator one, while I kept a single one for the alpha versions, is becoming more problematic, as the API seems to diverge a bit with the Maven 3 one. We currently generate a plugin.xml but this is all tacky as it assumes there's no difference between the 3.x and 4.x ones. We do have a writer which is generated in Maven 4 which we could use to write the plugin.xml (do we really need it btw ?). I was hoping to clean things and avoids lots of hacks to make the code more robust. > Remove ant and beanshell support > > > Key: MPLUGIN-525 > URL: https://issues.apache.org/jira/browse/MPLUGIN-525 > Project: Maven Plugin Tools > Issue Type: Task >Reporter: Guillaume Nodet >Assignee: Guillaume Nodet >Priority: Major > Fix For: 4.0.0 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] [MPLUGIN-525] Remove ant and beanshell support [maven-plugin-tools]
gnodet commented on PR #285: URL: https://github.com/apache/maven-plugin-tools/pull/285#issuecomment-2127541125 > > > Is this Maven 4 only? > > > > > > Yes, I've created a [3.x branch](https://github.com/apache/maven-plugin-tools/tree/3.x) to support Maven 3 plugins and master will support Maven 4 plugins. The goal is to split the plugins to ease maintenance, as the code will ultimately be quite different. See https://issues.apache.org/jira/browse/MPLUGIN-523. We should also drop the Maven 4.x support from the 3.x branch. > > I see. There is no way to have this in one branch with common modules and module per Maven version? Sure, I suppose it's technically feasible, but instead of streamlining and making the code simpler, it will have the exact opposite effect. The javadoc generator is now irrelevant, and the generator one, while I kept a single one for the alpha versions, is becoming more problematic, as the API seems to diverge a bit with the Maven 3 one. We currently generate a plugin.xml but this is all tacky as it assumes there's no difference between the 3.x and 4.x ones. We do have a writer which is generated in Maven 4 which we could use to write the plugin.xml (do we really need it btw ?). I was hoping to clean things and avoids lots of hacks to make the code more robust. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [MDEP-923] Extract copyFile method from AbstractDependencyMojo [maven-dependency-plugin]
slawekjaranowski commented on code in PR #389:
URL:
https://github.com/apache/maven-dependency-plugin/pull/389#discussion_r1611946471
##
src/main/java/org/apache/maven/plugins/dependency/utils/CopyUtil.java:
##
@@ -0,0 +1,66 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.maven.plugins.dependency.utils;
+
+import javax.inject.Inject;
+import javax.inject.Named;
+import javax.inject.Singleton;
+
+import java.io.File;
+import java.io.IOException;
+
+import org.apache.maven.plugin.MojoExecutionException;
+import org.apache.maven.plugin.logging.Log;
+import org.codehaus.plexus.util.FileUtils;
+import org.sonatype.plexus.build.incremental.BuildContext;
+
+/**
+ * Provide a copyFile method in one place.
+ */
+@Named
+@Singleton
+public class CopyUtil {
+
+private final BuildContext buildContext;
+
+@Inject
+public CopyUtil(BuildContext buildContext) {
+this.buildContext = buildContext;
+}
+
+/**
+ * Does the actual copy of the file and logging.
+ *
+ * @param source represents the file to copy.
+ * @param destination file name of destination file.
+ * @throws IOException with a message if an error occurs.
+ */
+public void copyFile(Log log, File source, File destination) throws
IOException, MojoExecutionException {
+log.info("Copying " + source + " to " + destination);
Review Comment:
Log removed from method argument
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Commented] (MDEP-923) Code cleanups
[
https://issues.apache.org/jira/browse/MDEP-923?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17849021#comment-17849021
]
ASF GitHub Bot commented on MDEP-923:
-
slawekjaranowski commented on code in PR #389:
URL:
https://github.com/apache/maven-dependency-plugin/pull/389#discussion_r1611946471
##
src/main/java/org/apache/maven/plugins/dependency/utils/CopyUtil.java:
##
@@ -0,0 +1,66 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.maven.plugins.dependency.utils;
+
+import javax.inject.Inject;
+import javax.inject.Named;
+import javax.inject.Singleton;
+
+import java.io.File;
+import java.io.IOException;
+
+import org.apache.maven.plugin.MojoExecutionException;
+import org.apache.maven.plugin.logging.Log;
+import org.codehaus.plexus.util.FileUtils;
+import org.sonatype.plexus.build.incremental.BuildContext;
+
+/**
+ * Provide a copyFile method in one place.
+ */
+@Named
+@Singleton
+public class CopyUtil {
+
+private final BuildContext buildContext;
+
+@Inject
+public CopyUtil(BuildContext buildContext) {
+this.buildContext = buildContext;
+}
+
+/**
+ * Does the actual copy of the file and logging.
+ *
+ * @param source represents the file to copy.
+ * @param destination file name of destination file.
+ * @throws IOException with a message if an error occurs.
+ */
+public void copyFile(Log log, File source, File destination) throws
IOException, MojoExecutionException {
+log.info("Copying " + source + " to " + destination);
Review Comment:
Log removed from method argument
> Code cleanups
> -
>
> Key: MDEP-923
> URL: https://issues.apache.org/jira/browse/MDEP-923
> Project: Maven Dependency Plugin
> Issue Type: Task
>Reporter: Slawomir Jaranowski
>Assignee: Slawomir Jaranowski
>Priority: Major
> Fix For: 3.7.0
>
>
> * remove usage of deprecated API where possible
> * cleanup pom after update to 42
> * exclude transitive dependencies on org.apache.maven
> * add {{@project.version@}} in ITs
> * Remove plexus logger from DependencySilentLog
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MDEP-923) Code cleanups
[
https://issues.apache.org/jira/browse/MDEP-923?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17849017#comment-17849017
]
ASF GitHub Bot commented on MDEP-923:
-
slawekjaranowski commented on code in PR #389:
URL:
https://github.com/apache/maven-dependency-plugin/pull/389#discussion_r1611937502
##
src/test/java/org/apache/maven/plugins/dependency/fromDependencies/TestCopyDependenciesMojo.java:
##
@@ -80,7 +80,7 @@ public void assertNoMarkerFile(Artifact artifact) throws
MojoExecutionException
assertFalse(handle.isMarkerSet());
}
-public void testCopyFile() throws MojoExecutionException, IOException {
+public void testCopyFile() throws Exception {
Review Comment:
It is a Unit Test ... all other methods simply throws `Exception`
> Code cleanups
> -
>
> Key: MDEP-923
> URL: https://issues.apache.org/jira/browse/MDEP-923
> Project: Maven Dependency Plugin
> Issue Type: Task
>Reporter: Slawomir Jaranowski
>Assignee: Slawomir Jaranowski
>Priority: Major
> Fix For: 3.7.0
>
>
> * remove usage of deprecated API where possible
> * cleanup pom after update to 42
> * exclude transitive dependencies on org.apache.maven
> * add {{@project.version@}} in ITs
> * Remove plexus logger from DependencySilentLog
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
Re: [PR] [MDEP-923] Extract copyFile method from AbstractDependencyMojo [maven-dependency-plugin]
slawekjaranowski commented on code in PR #389:
URL:
https://github.com/apache/maven-dependency-plugin/pull/389#discussion_r1611937502
##
src/test/java/org/apache/maven/plugins/dependency/fromDependencies/TestCopyDependenciesMojo.java:
##
@@ -80,7 +80,7 @@ public void assertNoMarkerFile(Artifact artifact) throws
MojoExecutionException
assertFalse(handle.isMarkerSet());
}
-public void testCopyFile() throws MojoExecutionException, IOException {
+public void testCopyFile() throws Exception {
Review Comment:
It is a Unit Test ... all other methods simply throws `Exception`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] [MDEP-799] tree: add optional output type json [maven-dependency-plugin]
slawekjaranowski commented on PR #391: URL: https://github.com/apache/maven-dependency-plugin/pull/391#issuecomment-2127441497 > Any ETA for the corresponding release? There is on my list ... I hope do next release 3.7.0 it at next week or two There is issues list https://issues.apache.org/jira/issues/?jql=project%20%3D%20MDEP%20AND%20fixVersion%20%3D%203.7.0 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MDEP-799) improve mvn dependency:tree - add optional JSON output of the results
[ https://issues.apache.org/jira/browse/MDEP-799?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17849012#comment-17849012 ] Slawomir Jaranowski commented on MDEP-799: -- [~elharo] - thanks for take care about it. I assign you to issue. Thera are a two more PR with the same ... please comments and close those > improve mvn dependency:tree - add optional JSON output of the results > - > > Key: MDEP-799 > URL: https://issues.apache.org/jira/browse/MDEP-799 > Project: Maven Dependency Plugin > Issue Type: New Feature > Components: tree >Reporter: Zhenxu Ke >Assignee: Elliotte Rusty Harold >Priority: Major > Fix For: 3.7.0 > > > I'd like to add an output type JSON, will open a pull request soon -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Assigned] (MDEP-799) improve mvn dependency:tree - add optional JSON output of the results
[ https://issues.apache.org/jira/browse/MDEP-799?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Slawomir Jaranowski reassigned MDEP-799: Assignee: Elliotte Rusty Harold > improve mvn dependency:tree - add optional JSON output of the results > - > > Key: MDEP-799 > URL: https://issues.apache.org/jira/browse/MDEP-799 > Project: Maven Dependency Plugin > Issue Type: New Feature > Components: tree >Reporter: Zhenxu Ke >Assignee: Elliotte Rusty Harold >Priority: Major > Fix For: 3.7.0 > > > I'd like to add an output type JSON, will open a pull request soon -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MCOMPILER-369) Adding module-info.java breaks JMH annotation processor
[
https://issues.apache.org/jira/browse/MCOMPILER-369?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17848993#comment-17848993
]
Gili commented on MCOMPILER-369:
Now that nabble is dead, the above discussion can be found at
https://mail.openjdk.org/pipermail/jigsaw-dev/2016-November/010201.html
> Adding module-info.java breaks JMH annotation processor
> ---
>
> Key: MCOMPILER-369
> URL: https://issues.apache.org/jira/browse/MCOMPILER-369
> Project: Maven Compiler Plugin
> Issue Type: Bug
>Affects Versions: 3.8.0
>Reporter: Gili
>Priority: Major
> Attachments: annotation-processor-jigsaw.zip
>
>
> # Open testcase
> # Run {{clean install}}. Notice that the benchmarks run.
> # Open {{pom.xml}} and comment-out the {{
> section.}}
> # Run {{clean install}}. Notice that the annotation processor does not run
> and the benchmarks break.
> # Delete/rename {{module-info.java}}.
> # Run {{clean install}}. Notice that the benchmarks work again.
> The documentation for {{}} states that by default
> annotation processors are detected from the classpath. It seems that adding
> {{module-info.java}} breaks that somehow, which is weird/unexpected because
> JMH exists as a dependency outside the newly-declared module.
> I did two things to prove that the annotation processor is not being invoked
> in step 4:
> # Notice that {{target/test-classes/META-INF}} is not created.
> # Place a breakpoint in {{org.openjdk.jmh.generators.BenchmarkProcessor}}
> and notice that it is never even constructed.
> I tried digging into the maven-compiler-plugin and plexus-compiler
> source-code but couldn't figure out where the problem is. The only workaround
> I found is to specify {{annotationProcessorPaths}} manually but it took me
> half a day to track down this problem.
> Any idea what is going on? Is this a bug in the plugin(s)?
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Created] (MPMD-396) Impractical to fail build on violation
Delany created MPMD-396:
---
Summary: Impractical to fail build on violation
Key: MPMD-396
URL: https://issues.apache.org/jira/browse/MPMD-396
Project: Maven PMD Plugin
Issue Type: Bug
Components: PMD
Affects Versions: 3.22.0
Reporter: Delany
Let me start with what I'm trying to achieve. I have a multi-module build and I
want it to fail on a violation, quickly.
I'm not interesting in producing a report.
The build may include anything from a single module to all modules. In each
case, I don't want PMD to try parse the entire code base if I only asked Maven
to build a single module.
I notice that if I use the "aggregate-pmd-check" goal, I get log lines like
{{[WARNING] org.apache.maven.plugins.pmd.AggregatorPmdReport - Unable to locate
Source XRef to link to - DISABLED}}
Why is AggregatorPmdReport being invoked? Sounds like a legacy issue.
I also notice that unlike most Maven plugins, the pmd-maven-plugin goal is
always forking, indicated by chevrons in the output {{<<< pmd:3.22.0:check}}
With a single custom XPath rule, the time to complete a build becomes
impractical.
I was hoping to add pmd to my list of static analysis checkers/formatters like
checkstyle, impsort, sortpom, errorprone, modernizer etc which are all able to
parse source code and do various checks without becoming a burden.
With the current state of the pmd-maven-plugin (v3.22.0) that does not look
likely.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Updated] (MPLUGINTESTING-72) Release 3.4.0
[ https://issues.apache.org/jira/browse/MPLUGINTESTING-72?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guillaume Nodet updated MPLUGINTESTING-72: -- Summary: Release 3.4.0 (was: release 3.4.0) > Release 3.4.0 > - > > Key: MPLUGINTESTING-72 > URL: https://issues.apache.org/jira/browse/MPLUGINTESTING-72 > Project: Maven Plugin Testing > Issue Type: Wish >Reporter: Samael Bate >Priority: Major > Fix For: 3.4.0 > > > the master branch is passing all builds. There hasn't been a release since > 2014. What's the reasoning for not publishing a new release? There are > numerous dependency updates as well as documentation fixes. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MPLUGINTESTING-72) release 3.4.0
[ https://issues.apache.org/jira/browse/MPLUGINTESTING-72?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17848955#comment-17848955 ] Guillaume Nodet commented on MPLUGINTESTING-72: --- With the split related to Maven 3 / Maven 4 support, it makes sense to get a 3.4.0 release out. > release 3.4.0 > - > > Key: MPLUGINTESTING-72 > URL: https://issues.apache.org/jira/browse/MPLUGINTESTING-72 > Project: Maven Plugin Testing > Issue Type: Wish >Reporter: Samael Bate >Priority: Major > Fix For: 3.4.0 > > > the master branch is passing all builds. There hasn't been a release since > 2014. What's the reasoning for not publishing a new release? There are > numerous dependency updates as well as documentation fixes. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (MPLUGINTESTING-72) release 3.4.0
[ https://issues.apache.org/jira/browse/MPLUGINTESTING-72?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guillaume Nodet updated MPLUGINTESTING-72: -- Fix Version/s: 3.4.0 > release 3.4.0 > - > > Key: MPLUGINTESTING-72 > URL: https://issues.apache.org/jira/browse/MPLUGINTESTING-72 > Project: Maven Plugin Testing > Issue Type: Wish >Reporter: Samael Bate >Priority: Major > Fix For: 3.4.0 > > > the master branch is passing all builds. There hasn't been a release since > 2014. What's the reasoning for not publishing a new release? There are > numerous dependency updates as well as documentation fixes. -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] Do not build with JDK 21 [maven-plugin-testing]
gnodet merged PR #41: URL: https://github.com/apache/maven-plugin-testing/pull/41 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [MDEP-799] tree: add optional output type json [maven-dependency-plugin]
monperrus commented on PR #391: URL: https://github.com/apache/maven-dependency-plugin/pull/391#issuecomment-2127080659 This feature is important. Thanks @LogFlames and @elharo Any ETA for the corresponding release? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] Do not build with JDK 21 [maven-plugin-testing]
gnodet opened a new pull request, #41: URL: https://github.com/apache/maven-plugin-testing/pull/41 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MDEP-923) Code cleanups
[
https://issues.apache.org/jira/browse/MDEP-923?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17848942#comment-17848942
]
ASF GitHub Bot commented on MDEP-923:
-
elharo commented on code in PR #389:
URL:
https://github.com/apache/maven-dependency-plugin/pull/389#discussion_r1611629057
##
src/main/java/org/apache/maven/plugins/dependency/utils/CopyUtil.java:
##
@@ -0,0 +1,66 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.maven.plugins.dependency.utils;
+
+import javax.inject.Inject;
+import javax.inject.Named;
+import javax.inject.Singleton;
+
+import java.io.File;
+import java.io.IOException;
+
+import org.apache.maven.plugin.MojoExecutionException;
+import org.apache.maven.plugin.logging.Log;
+import org.codehaus.plexus.util.FileUtils;
+import org.sonatype.plexus.build.incremental.BuildContext;
+
+/**
+ * Provide a copyFile method in one place.
+ */
+@Named
+@Singleton
+public class CopyUtil {
+
+private final BuildContext buildContext;
+
+@Inject
+public CopyUtil(BuildContext buildContext) {
+this.buildContext = buildContext;
+}
+
+/**
+ * Does the actual copy of the file and logging.
+ *
+ * @param source represents the file to copy.
+ * @param destination file name of destination file.
+ * @throws IOException with a message if an error occurs.
+ */
+public void copyFile(Log log, File source, File destination) throws
IOException, MojoExecutionException {
+log.info("Copying " + source + " to " + destination);
Review Comment:
YAGNI. I spend way too much time wading through maven logs trying to
understand why and how builds failed. Info messages for normal operations just
get in the way and make developers' jobs harder. That someone somewhere might
one day want this message is not a good enough reason to include it.
I can sort of see letting this slip through as a separate issue from the
refactoring, though now that I look at it, I think that refactoring should also
remove the log argument here too. This is a new public API we did not have
before, and including that Log argument now makes it harder to remove later
since it would be a public API change.
If the choice is between adding this method with the Log argument and not
doing the refactoring, I think I'm going to pick not doing the refactoring.
> Code cleanups
> -
>
> Key: MDEP-923
> URL: https://issues.apache.org/jira/browse/MDEP-923
> Project: Maven Dependency Plugin
> Issue Type: Task
>Reporter: Slawomir Jaranowski
>Assignee: Slawomir Jaranowski
>Priority: Major
> Fix For: 3.7.0
>
>
> * remove usage of deprecated API where possible
> * cleanup pom after update to 42
> * exclude transitive dependencies on org.apache.maven
> * add {{@project.version@}} in ITs
> * Remove plexus logger from DependencySilentLog
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
Re: [PR] [MDEP-923] Extract copyFile method from AbstractDependencyMojo [maven-dependency-plugin]
elharo commented on code in PR #389:
URL:
https://github.com/apache/maven-dependency-plugin/pull/389#discussion_r1611629057
##
src/main/java/org/apache/maven/plugins/dependency/utils/CopyUtil.java:
##
@@ -0,0 +1,66 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.maven.plugins.dependency.utils;
+
+import javax.inject.Inject;
+import javax.inject.Named;
+import javax.inject.Singleton;
+
+import java.io.File;
+import java.io.IOException;
+
+import org.apache.maven.plugin.MojoExecutionException;
+import org.apache.maven.plugin.logging.Log;
+import org.codehaus.plexus.util.FileUtils;
+import org.sonatype.plexus.build.incremental.BuildContext;
+
+/**
+ * Provide a copyFile method in one place.
+ */
+@Named
+@Singleton
+public class CopyUtil {
+
+private final BuildContext buildContext;
+
+@Inject
+public CopyUtil(BuildContext buildContext) {
+this.buildContext = buildContext;
+}
+
+/**
+ * Does the actual copy of the file and logging.
+ *
+ * @param source represents the file to copy.
+ * @param destination file name of destination file.
+ * @throws IOException with a message if an error occurs.
+ */
+public void copyFile(Log log, File source, File destination) throws
IOException, MojoExecutionException {
+log.info("Copying " + source + " to " + destination);
Review Comment:
YAGNI. I spend way too much time wading through maven logs trying to
understand why and how builds failed. Info messages for normal operations just
get in the way and make developers' jobs harder. That someone somewhere might
one day want this message is not a good enough reason to include it.
I can sort of see letting this slip through as a separate issue from the
refactoring, though now that I look at it, I think that refactoring should also
remove the log argument here too. This is a new public API we did not have
before, and including that Log argument now makes it harder to remove later
since it would be a public API change.
If the choice is between adding this method with the Log argument and not
doing the refactoring, I think I'm going to pick not doing the refactoring.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Created] (MDEP-932) Don't log successful file copies
Elliotte Rusty Harold created MDEP-932:
--
Summary: Don't log successful file copies
Key: MDEP-932
URL: https://issues.apache.org/jira/browse/MDEP-932
Project: Maven Dependency Plugin
Issue Type: Improvement
Reporter: Elliotte Rusty Harold
In AbstarctDependencyMojo
Either a is file copied successfully and no one wants to read this message or
it fails and an exception is thrown. Either way, the log message simply isn';t
needed and gets in the way of debugging real failures.
/**
* Does the actual copy of the file and logging.
*
* @param artifact represents the file to copy.
* @param destFile file name of destination file.
* @throws MojoExecutionException with a message if an error occurs.
*/
protected void copyFile(File artifact, File destFile) throws
MojoExecutionException {
try {
getLog().info("Copying "
+ (this.outputAbsoluteArtifactFilename ?
artifact.getAbsolutePath() : artifact.getName()) + " to "
+ destFile);
if (artifact.isDirectory()) {
// usual case is a future jar packaging, but there are special
cases: classifier and other packaging
throw new MojoExecutionException("Artifact has not been
packaged yet. When used on reactor artifact, "
+ "copy should be executed after packaging: see
MDEP-187.");
}
FileUtils.copyFile(artifact, destFile);
buildContext.refresh(destFile);
} catch (IOException e) {
throw new MojoExecutionException("Error copying artifact from " +
artifact + " to " + destFile, e);
}
}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[PR] Bump org.apache.maven.skins:maven-fluido-skin from 2.0.0-M6 to 2.0.0-M9 [maven-dist-tool]
dependabot[bot] opened a new pull request, #57: URL: https://github.com/apache/maven-dist-tool/pull/57 Bumps [org.apache.maven.skins:maven-fluido-skin](https://github.com/apache/maven-fluido-skin) from 2.0.0-M6 to 2.0.0-M9. Commits https://github.com/apache/maven-fluido-skin/commit/b889e31de47344d895b82ca66be62de03613344b;>b889e31 [maven-release-plugin] prepare release maven-fluido-skin-2.0.0-M9 https://github.com/apache/maven-fluido-skin/commit/7de78bba87b2d4d5f657efb24fc5f99209cfb98b;>7de78bb [MSKINS-247] Upgrade to Parent 42 https://github.com/apache/maven-fluido-skin/commit/ab1e6a348671a3413bb51da45f1e4cfa97a3c5da;>ab1e6a3 [MSKINS-245] Add code highlighting class to every precode combination https://github.com/apache/maven-fluido-skin/commit/341db6d345f71933e932097accbb5ff79bdd15d2;>341db6d Bump maven-gh-actions-shared to v4 https://github.com/apache/maven-fluido-skin/commit/1f449b606ab455c61dc25f56e68d371e659bfe90;>1f449b6 [MSKINS-246] Upgrade plugins and components (in ITs) https://github.com/apache/maven-fluido-skin/commit/d5eef2752bdb2e3d395438a502ab87ecbebd9e8c;>d5eef27 [MSKINS-243] Update to Parent 41 (https://redirect.github.com/apache/maven-fluido-skin/issues/59;>#59) https://github.com/apache/maven-fluido-skin/commit/7cb683f5505badcb7ecac9569c8445ae435377d8;>7cb683f [MSKINS-239] Drop support for Flattr.com buttons https://github.com/apache/maven-fluido-skin/commit/e33c1b6448674fc3356112728dd2cc6406274961;>e33c1b6 [maven-release-plugin] prepare for next development iteration https://github.com/apache/maven-fluido-skin/commit/59b104d843e65eed6023d192b95f875e1e0e2b0a;>59b104d [maven-release-plugin] prepare release maven-fluido-skin-2.0.0-M8 https://github.com/apache/maven-fluido-skin/commit/51486cb7ba66721c3d895ffdfaafb778752c9207;>51486cb [maven-release-plugin] prepare for next development iteration Additional commits viewable in https://github.com/apache/maven-fluido-skin/compare/maven-fluido-skin-2.0.0-M6...maven-fluido-skin-2.0.0-M9;>compare view [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [MPLUGIN-525] Remove ant and beanshell support [maven-plugin-tools]
michael-o commented on PR #285: URL: https://github.com/apache/maven-plugin-tools/pull/285#issuecomment-2126989217 > > Is this Maven 4 only? > > Yes, I've created a [3.x branch](https://github.com/apache/maven-plugin-tools/tree/3.x) to support Maven 3 plugins and master will support Maven 4 plugins. The goal is to split the plugins to ease maintenance, as the code will ultimately be quite different. See https://issues.apache.org/jira/browse/MPLUGIN-523. We should also drop the Maven 4.x support from the 3.x branch. I see. There is no way to have this in one branch with common modules and module per Maven version? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MPLUGIN-525) Remove ant and beanshell support
[ https://issues.apache.org/jira/browse/MPLUGIN-525?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17848934#comment-17848934 ] ASF GitHub Bot commented on MPLUGIN-525: michael-o commented on PR #285: URL: https://github.com/apache/maven-plugin-tools/pull/285#issuecomment-2126989217 > > Is this Maven 4 only? > > Yes, I've created a [3.x branch](https://github.com/apache/maven-plugin-tools/tree/3.x) to support Maven 3 plugins and master will support Maven 4 plugins. The goal is to split the plugins to ease maintenance, as the code will ultimately be quite different. See https://issues.apache.org/jira/browse/MPLUGIN-523. We should also drop the Maven 4.x support from the 3.x branch. I see. There is no way to have this in one branch with common modules and module per Maven version? > Remove ant and beanshell support > > > Key: MPLUGIN-525 > URL: https://issues.apache.org/jira/browse/MPLUGIN-525 > Project: Maven Plugin Tools > Issue Type: Task >Reporter: Guillaume Nodet >Assignee: Guillaume Nodet >Priority: Major > Fix For: 4.0.0 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MPLUGINTESTING-62) use maven API 3.6.0 and Plexus 2.0.0
[ https://issues.apache.org/jira/browse/MPLUGINTESTING-62?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17848933#comment-17848933 ] ASF GitHub Bot commented on MPLUGINTESTING-62: -- gnodet closed pull request #8: [MPLUGINTESTING-62] target maven 3.6.0 and Plexus 2.0.0 URL: https://github.com/apache/maven-plugin-testing/pull/8 > use maven API 3.6.0 and Plexus 2.0.0 > > > Key: MPLUGINTESTING-62 > URL: https://issues.apache.org/jira/browse/MPLUGINTESTING-62 > Project: Maven Plugin Testing > Issue Type: Dependency upgrade >Reporter: Samael Bate >Priority: Major > Labels: close-pending > > Along with updating to use Java 7 (MPLUGINTESTING-61) the plugin should use a > recent maven API. > As there is no 3.6.0 for maven-aether-provider it will need be set to 3.3.9 -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] [MPLUGINTESTING-62] target maven 3.6.0 and Plexus 2.0.0 [maven-plugin-testing]
gnodet closed pull request #8: [MPLUGINTESTING-62] target maven 3.6.0 and Plexus 2.0.0 URL: https://github.com/apache/maven-plugin-testing/pull/8 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Assigned] (MINDEXER-224) Bump com.google.code.gson:gson from 2.10.1 to 2.11.0
[ https://issues.apache.org/jira/browse/MINDEXER-224?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tamas Cservenak reassigned MINDEXER-224: Assignee: Tamas Cservenak > Bump com.google.code.gson:gson from 2.10.1 to 2.11.0 > > > Key: MINDEXER-224 > URL: https://issues.apache.org/jira/browse/MINDEXER-224 > Project: Maven Indexer > Issue Type: Dependency upgrade >Reporter: Tamas Cservenak >Assignee: Tamas Cservenak >Priority: Major > Fix For: 7.1.4 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Closed] (MINDEXER-224) Bump com.google.code.gson:gson from 2.10.1 to 2.11.0
[ https://issues.apache.org/jira/browse/MINDEXER-224?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tamas Cservenak closed MINDEXER-224. Resolution: Fixed > Bump com.google.code.gson:gson from 2.10.1 to 2.11.0 > > > Key: MINDEXER-224 > URL: https://issues.apache.org/jira/browse/MINDEXER-224 > Project: Maven Indexer > Issue Type: Dependency upgrade >Reporter: Tamas Cservenak >Assignee: Tamas Cservenak >Priority: Major > Fix For: 7.1.4 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (MINDEXER-224) Bump com.google.code.gson:gson from 2.10.1 to 2.11.0
Tamas Cservenak created MINDEXER-224: Summary: Bump com.google.code.gson:gson from 2.10.1 to 2.11.0 Key: MINDEXER-224 URL: https://issues.apache.org/jira/browse/MINDEXER-224 Project: Maven Indexer Issue Type: Dependency upgrade Reporter: Tamas Cservenak Fix For: 7.1.4 -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] Bump com.google.code.gson:gson from 2.10.1 to 2.11.0 [maven-indexer]
cstamas merged PR #366: URL: https://github.com/apache/maven-indexer/pull/366 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (MNG-7902) Sort plugins in validation report
[ https://issues.apache.org/jira/browse/MNG-7902?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guillaume Nodet updated MNG-7902: - Summary: Sort plugins in validation report (was: sort plugins in validation report) > Sort plugins in validation report > - > > Key: MNG-7902 > URL: https://issues.apache.org/jira/browse/MNG-7902 > Project: Maven > Issue Type: Improvement > Components: Core >Reporter: Michael Keppler >Priority: Minor > Fix For: 4.0.0-beta-4 > > Attachments: image-2023-10-07-13-33-27-762.png > > > Please don't ever output the content of a Set for consumption by humans > without sorting it first. The order is otherwise "random". Sorting (case > insensitive) makes the same output easier to read, especially when trying to > find one specific entry (e.g. "Did we fix plugin foo already?") > !image-2023-10-07-13-33-27-762.png! -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Closed] (MNG-7902) sort plugins in validation report
[ https://issues.apache.org/jira/browse/MNG-7902?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guillaume Nodet closed MNG-7902. Fix Version/s: 4.0.0-beta-4 Resolution: Fixed > sort plugins in validation report > - > > Key: MNG-7902 > URL: https://issues.apache.org/jira/browse/MNG-7902 > Project: Maven > Issue Type: Improvement > Components: Core >Reporter: Michael Keppler >Priority: Minor > Fix For: 4.0.0-beta-4 > > Attachments: image-2023-10-07-13-33-27-762.png > > > Please don't ever output the content of a Set for consumption by humans > without sorting it first. The order is otherwise "random". Sorting (case > insensitive) makes the same output easier to read, especially when trying to > find one specific entry (e.g. "Did we fix plugin foo already?") > !image-2023-10-07-13-33-27-762.png! -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MNG-7902) sort plugins in validation report
[ https://issues.apache.org/jira/browse/MNG-7902?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17848931#comment-17848931 ] ASF GitHub Bot commented on MNG-7902: - gnodet merged PR #1510: URL: https://github.com/apache/maven/pull/1510 > sort plugins in validation report > - > > Key: MNG-7902 > URL: https://issues.apache.org/jira/browse/MNG-7902 > Project: Maven > Issue Type: Improvement > Components: Core >Reporter: Michael Keppler >Priority: Minor > Attachments: image-2023-10-07-13-33-27-762.png > > > Please don't ever output the content of a Set for consumption by humans > without sorting it first. The order is otherwise "random". Sorting (case > insensitive) makes the same output easier to read, especially when trying to > find one specific entry (e.g. "Did we fix plugin foo already?") > !image-2023-10-07-13-33-27-762.png! -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] [MNG-7902] Sort plugins in the validation report [maven]
gnodet merged PR #1510: URL: https://github.com/apache/maven/pull/1510 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MDEP-923) Code cleanups
[
https://issues.apache.org/jira/browse/MDEP-923?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17848930#comment-17848930
]
ASF GitHub Bot commented on MDEP-923:
-
slawekjaranowski commented on code in PR #389:
URL:
https://github.com/apache/maven-dependency-plugin/pull/389#discussion_r1611596047
##
src/main/java/org/apache/maven/plugins/dependency/utils/CopyUtil.java:
##
@@ -0,0 +1,66 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.maven.plugins.dependency.utils;
+
+import javax.inject.Inject;
+import javax.inject.Named;
+import javax.inject.Singleton;
+
+import java.io.File;
+import java.io.IOException;
+
+import org.apache.maven.plugin.MojoExecutionException;
+import org.apache.maven.plugin.logging.Log;
+import org.codehaus.plexus.util.FileUtils;
+import org.sonatype.plexus.build.incremental.BuildContext;
+
+/**
+ * Provide a copyFile method in one place.
+ */
+@Named
+@Singleton
+public class CopyUtil {
+
+private final BuildContext buildContext;
+
+@Inject
+public CopyUtil(BuildContext buildContext) {
+this.buildContext = buildContext;
+}
+
+/**
+ * Does the actual copy of the file and logging.
+ *
+ * @param source represents the file to copy.
+ * @param destination file name of destination file.
+ * @throws IOException with a message if an error occurs.
+ */
+public void copyFile(Log log, File source, File destination) throws
IOException, MojoExecutionException {
+log.info("Copying " + source + " to " + destination);
+
+if (source.isDirectory()) {
+// usual case is a future jar packaging, but there are special
cases: classifier and other packaging
+throw new MojoExecutionException("Artifact has not been packaged
yet. When used on reactor artifact, "
++ "copy should be executed after packaging: see
MDEP-187.");
Review Comment:
try paste it in your favorite web search
here similar - it is refactor not improvements
> Code cleanups
> -
>
> Key: MDEP-923
> URL: https://issues.apache.org/jira/browse/MDEP-923
> Project: Maven Dependency Plugin
> Issue Type: Task
>Reporter: Slawomir Jaranowski
>Assignee: Slawomir Jaranowski
>Priority: Major
> Fix For: 3.7.0
>
>
> * remove usage of deprecated API where possible
> * cleanup pom after update to 42
> * exclude transitive dependencies on org.apache.maven
> * add {{@project.version@}} in ITs
> * Remove plexus logger from DependencySilentLog
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
Re: [PR] [MDEP-923] Extract copyFile method from AbstractDependencyMojo [maven-dependency-plugin]
slawekjaranowski commented on code in PR #389:
URL:
https://github.com/apache/maven-dependency-plugin/pull/389#discussion_r1611596047
##
src/main/java/org/apache/maven/plugins/dependency/utils/CopyUtil.java:
##
@@ -0,0 +1,66 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.maven.plugins.dependency.utils;
+
+import javax.inject.Inject;
+import javax.inject.Named;
+import javax.inject.Singleton;
+
+import java.io.File;
+import java.io.IOException;
+
+import org.apache.maven.plugin.MojoExecutionException;
+import org.apache.maven.plugin.logging.Log;
+import org.codehaus.plexus.util.FileUtils;
+import org.sonatype.plexus.build.incremental.BuildContext;
+
+/**
+ * Provide a copyFile method in one place.
+ */
+@Named
+@Singleton
+public class CopyUtil {
+
+private final BuildContext buildContext;
+
+@Inject
+public CopyUtil(BuildContext buildContext) {
+this.buildContext = buildContext;
+}
+
+/**
+ * Does the actual copy of the file and logging.
+ *
+ * @param source represents the file to copy.
+ * @param destination file name of destination file.
+ * @throws IOException with a message if an error occurs.
+ */
+public void copyFile(Log log, File source, File destination) throws
IOException, MojoExecutionException {
+log.info("Copying " + source + " to " + destination);
+
+if (source.isDirectory()) {
+// usual case is a future jar packaging, but there are special
cases: classifier and other packaging
+throw new MojoExecutionException("Artifact has not been packaged
yet. When used on reactor artifact, "
++ "copy should be executed after packaging: see
MDEP-187.");
Review Comment:
try paste it in your favorite web search
here similar - it is refactor not improvements
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Commented] (MDEP-923) Code cleanups
[
https://issues.apache.org/jira/browse/MDEP-923?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17848928#comment-17848928
]
ASF GitHub Bot commented on MDEP-923:
-
slawekjaranowski commented on code in PR #389:
URL:
https://github.com/apache/maven-dependency-plugin/pull/389#discussion_r1611591836
##
src/main/java/org/apache/maven/plugins/dependency/utils/CopyUtil.java:
##
@@ -0,0 +1,66 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.maven.plugins.dependency.utils;
+
+import javax.inject.Inject;
+import javax.inject.Named;
+import javax.inject.Singleton;
+
+import java.io.File;
+import java.io.IOException;
+
+import org.apache.maven.plugin.MojoExecutionException;
+import org.apache.maven.plugin.logging.Log;
+import org.codehaus.plexus.util.FileUtils;
+import org.sonatype.plexus.build.incremental.BuildContext;
+
+/**
+ * Provide a copyFile method in one place.
+ */
+@Named
+@Singleton
+public class CopyUtil {
+
+private final BuildContext buildContext;
+
+@Inject
+public CopyUtil(BuildContext buildContext) {
+this.buildContext = buildContext;
+}
+
+/**
+ * Does the actual copy of the file and logging.
+ *
+ * @param source represents the file to copy.
+ * @param destination file name of destination file.
+ * @throws IOException with a message if an error occurs.
+ */
+public void copyFile(Log log, File source, File destination) throws
IOException, MojoExecutionException {
+log.info("Copying " + source + " to " + destination);
Review Comment:
As I said - I want to keep this as only refactor - without impact on final
features
If we want to remove such logs it should be a new issue for it ... maybe
someone like or use it
> Code cleanups
> -
>
> Key: MDEP-923
> URL: https://issues.apache.org/jira/browse/MDEP-923
> Project: Maven Dependency Plugin
> Issue Type: Task
>Reporter: Slawomir Jaranowski
>Assignee: Slawomir Jaranowski
>Priority: Major
> Fix For: 3.7.0
>
>
> * remove usage of deprecated API where possible
> * cleanup pom after update to 42
> * exclude transitive dependencies on org.apache.maven
> * add {{@project.version@}} in ITs
> * Remove plexus logger from DependencySilentLog
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
Re: [PR] [MDEP-923] Extract copyFile method from AbstractDependencyMojo [maven-dependency-plugin]
slawekjaranowski commented on code in PR #389:
URL:
https://github.com/apache/maven-dependency-plugin/pull/389#discussion_r1611591836
##
src/main/java/org/apache/maven/plugins/dependency/utils/CopyUtil.java:
##
@@ -0,0 +1,66 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.maven.plugins.dependency.utils;
+
+import javax.inject.Inject;
+import javax.inject.Named;
+import javax.inject.Singleton;
+
+import java.io.File;
+import java.io.IOException;
+
+import org.apache.maven.plugin.MojoExecutionException;
+import org.apache.maven.plugin.logging.Log;
+import org.codehaus.plexus.util.FileUtils;
+import org.sonatype.plexus.build.incremental.BuildContext;
+
+/**
+ * Provide a copyFile method in one place.
+ */
+@Named
+@Singleton
+public class CopyUtil {
+
+private final BuildContext buildContext;
+
+@Inject
+public CopyUtil(BuildContext buildContext) {
+this.buildContext = buildContext;
+}
+
+/**
+ * Does the actual copy of the file and logging.
+ *
+ * @param source represents the file to copy.
+ * @param destination file name of destination file.
+ * @throws IOException with a message if an error occurs.
+ */
+public void copyFile(Log log, File source, File destination) throws
IOException, MojoExecutionException {
+log.info("Copying " + source + " to " + destination);
Review Comment:
As I said - I want to keep this as only refactor - without impact on final
features
If we want to remove such logs it should be a new issue for it ... maybe
someone like or use it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Commented] (MPLUGIN-525) Remove ant and beanshell support
[ https://issues.apache.org/jira/browse/MPLUGIN-525?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17848926#comment-17848926 ] ASF GitHub Bot commented on MPLUGIN-525: gnodet commented on PR #285: URL: https://github.com/apache/maven-plugin-tools/pull/285#issuecomment-2126955036 > Is this Maven 4 only? Yes, I've created a [3.x branch](https://github.com/apache/maven-plugin-tools/tree/3.x) to support Maven 3 plugins and master will support Maven 4 plugins. The goal is to split the plugins to ease maintenance, as the code will ultimately be quite different. See https://issues.apache.org/jira/browse/MPLUGIN-523. We should also drop the Maven 4.x support from the 3.x branch. > Remove ant and beanshell support > > > Key: MPLUGIN-525 > URL: https://issues.apache.org/jira/browse/MPLUGIN-525 > Project: Maven Plugin Tools > Issue Type: Task >Reporter: Guillaume Nodet >Assignee: Guillaume Nodet >Priority: Major > Fix For: 4.0.0 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] [MPLUGIN-525] Remove ant and beanshell support [maven-plugin-tools]
gnodet commented on PR #285: URL: https://github.com/apache/maven-plugin-tools/pull/285#issuecomment-2126955036 > Is this Maven 4 only? Yes, I've created a [3.x branch](https://github.com/apache/maven-plugin-tools/tree/3.x) to support Maven 3 plugins and master will support Maven 4 plugins. The goal is to split the plugins to ease maintenance, as the code will ultimately be quite different. See https://issues.apache.org/jira/browse/MPLUGIN-523. We should also drop the Maven 4.x support from the 3.x branch. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Closed] (MDEP-799) improve mvn dependency:tree - add optional JSON output of the results
[ https://issues.apache.org/jira/browse/MDEP-799?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Elliotte Rusty Harold closed MDEP-799. -- > improve mvn dependency:tree - add optional JSON output of the results > - > > Key: MDEP-799 > URL: https://issues.apache.org/jira/browse/MDEP-799 > Project: Maven Dependency Plugin > Issue Type: New Feature > Components: tree >Reporter: Zhenxu Ke >Priority: Major > Fix For: 3.7.0 > > > I'd like to add an output type JSON, will open a pull request soon -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Resolved] (MDEP-799) improve mvn dependency:tree - add optional JSON output of the results
[ https://issues.apache.org/jira/browse/MDEP-799?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Elliotte Rusty Harold resolved MDEP-799. Fix Version/s: 3.7.0 Resolution: Fixed > improve mvn dependency:tree - add optional JSON output of the results > - > > Key: MDEP-799 > URL: https://issues.apache.org/jira/browse/MDEP-799 > Project: Maven Dependency Plugin > Issue Type: New Feature > Components: tree >Reporter: Zhenxu Ke >Priority: Major > Fix For: 3.7.0 > > > I'd like to add an output type JSON, will open a pull request soon -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] [MDEP-799] tree: add optional output type json [maven-dependency-plugin]
elharo merged PR #391: URL: https://github.com/apache/maven-dependency-plugin/pull/391 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MRESOLVER-564) Align with Maven4 beta-3
[ https://issues.apache.org/jira/browse/MRESOLVER-564?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17848914#comment-17848914 ] ASF GitHub Bot commented on MRESOLVER-564: -- cstamas commented on PR #480: URL: https://github.com/apache/maven-resolver/pull/480#issuecomment-2126900491 Before merge the staging repository (assuming beta-3 is release and is in Maven Central) should be dropped. > Align with Maven4 beta-3 > > > Key: MRESOLVER-564 > URL: https://issues.apache.org/jira/browse/MRESOLVER-564 > Project: Maven Resolver > Issue Type: Dependency upgrade >Reporter: Tamas Cservenak >Assignee: Tamas Cservenak >Priority: Major > Fix For: 2.0.0, 2.0.0-beta-1 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] [MRESOLVER-564] Align with Maven 4.0.0-beta-3 [maven-resolver]
cstamas commented on PR #480: URL: https://github.com/apache/maven-resolver/pull/480#issuecomment-2126900491 Before merge the staging repository (assuming beta-3 is release and is in Maven Central) should be dropped. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (MRESOLVER-564) Align with Maven4 beta-3
Tamas Cservenak created MRESOLVER-564: - Summary: Align with Maven4 beta-3 Key: MRESOLVER-564 URL: https://issues.apache.org/jira/browse/MRESOLVER-564 Project: Maven Resolver Issue Type: Dependency upgrade Reporter: Tamas Cservenak Fix For: 2.0.0, 2.0.0-beta-1 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Assigned] (MRESOLVER-564) Align with Maven4 beta-3
[ https://issues.apache.org/jira/browse/MRESOLVER-564?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tamas Cservenak reassigned MRESOLVER-564: - Assignee: Tamas Cservenak > Align with Maven4 beta-3 > > > Key: MRESOLVER-564 > URL: https://issues.apache.org/jira/browse/MRESOLVER-564 > Project: Maven Resolver > Issue Type: Dependency upgrade >Reporter: Tamas Cservenak >Assignee: Tamas Cservenak >Priority: Major > Fix For: 2.0.0, 2.0.0-beta-1 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MDEP-923) Code cleanups
[
https://issues.apache.org/jira/browse/MDEP-923?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17848913#comment-17848913
]
ASF GitHub Bot commented on MDEP-923:
-
elharo commented on code in PR #389:
URL:
https://github.com/apache/maven-dependency-plugin/pull/389#discussion_r1611510587
##
src/main/java/org/apache/maven/plugins/dependency/utils/CopyUtil.java:
##
@@ -0,0 +1,66 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.maven.plugins.dependency.utils;
+
+import javax.inject.Inject;
+import javax.inject.Named;
+import javax.inject.Singleton;
+
+import java.io.File;
+import java.io.IOException;
+
+import org.apache.maven.plugin.MojoExecutionException;
+import org.apache.maven.plugin.logging.Log;
+import org.codehaus.plexus.util.FileUtils;
+import org.sonatype.plexus.build.incremental.BuildContext;
+
+/**
+ * Provide a copyFile method in one place.
+ */
+@Named
+@Singleton
+public class CopyUtil {
+
+private final BuildContext buildContext;
+
+@Inject
+public CopyUtil(BuildContext buildContext) {
+this.buildContext = buildContext;
+}
+
+/**
+ * Does the actual copy of the file and logging.
+ *
+ * @param source represents the file to copy.
+ * @param destination file name of destination file.
+ * @throws IOException with a message if an error occurs.
+ */
+public void copyFile(Log log, File source, File destination) throws
IOException, MojoExecutionException {
+log.info("Copying " + source + " to " + destination);
Review Comment:
Log message is likely noise. Either thew copy succeeds and no one wants to
read this, ior it fails and an exception is thrown. Demote to debug or remove
it.
##
src/test/java/org/apache/maven/plugins/dependency/fromDependencies/TestCopyDependenciesMojo.java:
##
@@ -80,7 +80,7 @@ public void assertNoMarkerFile(Artifact artifact) throws
MojoExecutionException
assertFalse(handle.isMarkerSet());
}
-public void testCopyFile() throws MojoExecutionException, IOException {
+public void testCopyFile() throws Exception {
Review Comment:
did this change to throw a raw exception? Otherwise it's better to declare
the actual exceptions instead of the common superclass.
##
src/main/java/org/apache/maven/plugins/dependency/utils/CopyUtil.java:
##
@@ -0,0 +1,66 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.maven.plugins.dependency.utils;
+
+import javax.inject.Inject;
+import javax.inject.Named;
+import javax.inject.Singleton;
+
+import java.io.File;
+import java.io.IOException;
+
+import org.apache.maven.plugin.MojoExecutionException;
+import org.apache.maven.plugin.logging.Log;
+import org.codehaus.plexus.util.FileUtils;
+import org.sonatype.plexus.build.incremental.BuildContext;
+
+/**
+ * Provide a copyFile method in one place.
+ */
+@Named
+@Singleton
+public class CopyUtil {
+
+private final BuildContext buildContext;
+
+@Inject
+public CopyUtil(BuildContext buildContext) {
+this.buildContext = buildContext;
+}
+
+/**
+ * Does the actual copy of the file and logging.
+ *
+ * @param source represents the file to copy.
+ * @param destination file name of destination file.
+ * @throws IOException with a message if an error occurs.
+ */
+
Re: [PR] [MDEP-923] Extract copyFile method from AbstractDependencyMojo [maven-dependency-plugin]
elharo commented on code in PR #389:
URL:
https://github.com/apache/maven-dependency-plugin/pull/389#discussion_r1611510587
##
src/main/java/org/apache/maven/plugins/dependency/utils/CopyUtil.java:
##
@@ -0,0 +1,66 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.maven.plugins.dependency.utils;
+
+import javax.inject.Inject;
+import javax.inject.Named;
+import javax.inject.Singleton;
+
+import java.io.File;
+import java.io.IOException;
+
+import org.apache.maven.plugin.MojoExecutionException;
+import org.apache.maven.plugin.logging.Log;
+import org.codehaus.plexus.util.FileUtils;
+import org.sonatype.plexus.build.incremental.BuildContext;
+
+/**
+ * Provide a copyFile method in one place.
+ */
+@Named
+@Singleton
+public class CopyUtil {
+
+private final BuildContext buildContext;
+
+@Inject
+public CopyUtil(BuildContext buildContext) {
+this.buildContext = buildContext;
+}
+
+/**
+ * Does the actual copy of the file and logging.
+ *
+ * @param source represents the file to copy.
+ * @param destination file name of destination file.
+ * @throws IOException with a message if an error occurs.
+ */
+public void copyFile(Log log, File source, File destination) throws
IOException, MojoExecutionException {
+log.info("Copying " + source + " to " + destination);
Review Comment:
Log message is likely noise. Either thew copy succeeds and no one wants to
read this, ior it fails and an exception is thrown. Demote to debug or remove
it.
##
src/test/java/org/apache/maven/plugins/dependency/fromDependencies/TestCopyDependenciesMojo.java:
##
@@ -80,7 +80,7 @@ public void assertNoMarkerFile(Artifact artifact) throws
MojoExecutionException
assertFalse(handle.isMarkerSet());
}
-public void testCopyFile() throws MojoExecutionException, IOException {
+public void testCopyFile() throws Exception {
Review Comment:
did this change to throw a raw exception? Otherwise it's better to declare
the actual exceptions instead of the common superclass.
##
src/main/java/org/apache/maven/plugins/dependency/utils/CopyUtil.java:
##
@@ -0,0 +1,66 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.maven.plugins.dependency.utils;
+
+import javax.inject.Inject;
+import javax.inject.Named;
+import javax.inject.Singleton;
+
+import java.io.File;
+import java.io.IOException;
+
+import org.apache.maven.plugin.MojoExecutionException;
+import org.apache.maven.plugin.logging.Log;
+import org.codehaus.plexus.util.FileUtils;
+import org.sonatype.plexus.build.incremental.BuildContext;
+
+/**
+ * Provide a copyFile method in one place.
+ */
+@Named
+@Singleton
+public class CopyUtil {
+
+private final BuildContext buildContext;
+
+@Inject
+public CopyUtil(BuildContext buildContext) {
+this.buildContext = buildContext;
+}
+
+/**
+ * Does the actual copy of the file and logging.
+ *
+ * @param source represents the file to copy.
+ * @param destination file name of destination file.
+ * @throws IOException with a message if an error occurs.
+ */
+public void copyFile(Log log, File source, File destination) throws
IOException, MojoExecutionException {
+log.info("Copying " + source + " to " + destination);
+
+if (source.isDirectory()) {
+// usual case
[jira] [Closed] (MRESOLVER-289) Remove "Aether wiki" link from site
[ https://issues.apache.org/jira/browse/MRESOLVER-289?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tamas Cservenak closed MRESOLVER-289. - Resolution: Fixed > Remove "Aether wiki" link from site > --- > > Key: MRESOLVER-289 > URL: https://issues.apache.org/jira/browse/MRESOLVER-289 > Project: Maven Resolver > Issue Type: Task > Components: Resolver >Reporter: Tamas Cservenak >Assignee: Tamas Cservenak >Priority: Major > Fix For: 2.0.0, 2.0.0-beta-1 > > > It points to Eclipe wiki that is defunct. Possibly migrate something from > there, if needed. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Closed] (MRESOLVER-526) Import Eclipse Aether wiki content to Maven Site
[
https://issues.apache.org/jira/browse/MRESOLVER-526?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Tamas Cservenak closed MRESOLVER-526.
-
Resolution: Fixed
> Import Eclipse Aether wiki content to Maven Site
>
>
> Key: MRESOLVER-526
> URL: https://issues.apache.org/jira/browse/MRESOLVER-526
> Project: Maven Resolver
> Issue Type: Task
> Components: Resolver
>Reporter: Konrad Windszus
>Assignee: Tamas Cservenak
>Priority: Major
> Fix For: 2.0.0, 2.0.0-beta-1
>
> Attachments: EclipseAetherWikiExportAsMD.zip,
> Eclipsepedia-20240410130147.xml
>
>
> As the Eclipse wiki is gonna be shutdown soon the content currently only
> available on https://wiki.eclipse.org/Aether (and other pages with category
> {{Aether}}) should be migrated to the resolver site.
> The steps for exporting and converting to Markdown are outlined at
> https://gitlab.eclipse.org/eclipsefdn/helpdesk/-/wikis/Wiki-Move-FAQ.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MRESOLVER-526) Import Eclipse Aether wiki content to Maven Site
[
https://issues.apache.org/jira/browse/MRESOLVER-526?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17848908#comment-17848908
]
ASF GitHub Bot commented on MRESOLVER-526:
--
cstamas merged PR #496:
URL: https://github.com/apache/maven-resolver/pull/496
> Import Eclipse Aether wiki content to Maven Site
>
>
> Key: MRESOLVER-526
> URL: https://issues.apache.org/jira/browse/MRESOLVER-526
> Project: Maven Resolver
> Issue Type: Task
> Components: Resolver
>Reporter: Konrad Windszus
>Assignee: Tamas Cservenak
>Priority: Major
> Fix For: 2.0.0, 2.0.0-beta-1
>
> Attachments: EclipseAetherWikiExportAsMD.zip,
> Eclipsepedia-20240410130147.xml
>
>
> As the Eclipse wiki is gonna be shutdown soon the content currently only
> available on https://wiki.eclipse.org/Aether (and other pages with category
> {{Aether}}) should be migrated to the resolver site.
> The steps for exporting and converting to Markdown are outlined at
> https://gitlab.eclipse.org/eclipsefdn/helpdesk/-/wikis/Wiki-Move-FAQ.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
Re: [PR] [MRESOLVER-526] Reuse relevant bits from Eclipse Aether wiki contents [maven-resolver]
cstamas merged PR #496: URL: https://github.com/apache/maven-resolver/pull/496 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Closed] (MRESOLVER-563) Bump org.codehaus.plexus:plexus-xml from 4.0.3 to 4.0.4
[ https://issues.apache.org/jira/browse/MRESOLVER-563?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tamas Cservenak closed MRESOLVER-563. - Resolution: Fixed > Bump org.codehaus.plexus:plexus-xml from 4.0.3 to 4.0.4 > --- > > Key: MRESOLVER-563 > URL: https://issues.apache.org/jira/browse/MRESOLVER-563 > Project: Maven Resolver > Issue Type: Dependency upgrade >Reporter: Tamas Cservenak >Assignee: Tamas Cservenak >Priority: Major > Fix For: 2.0.0, 2.0.0-beta-1 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] Bump org.codehaus.plexus:plexus-xml from 4.0.3 to 4.0.4 [maven-resolver]
cstamas merged PR #497: URL: https://github.com/apache/maven-resolver/pull/497 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Assigned] (MRESOLVER-563) Bump org.codehaus.plexus:plexus-xml from 4.0.3 to 4.0.4
[ https://issues.apache.org/jira/browse/MRESOLVER-563?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tamas Cservenak reassigned MRESOLVER-563: - Assignee: Tamas Cservenak > Bump org.codehaus.plexus:plexus-xml from 4.0.3 to 4.0.4 > --- > > Key: MRESOLVER-563 > URL: https://issues.apache.org/jira/browse/MRESOLVER-563 > Project: Maven Resolver > Issue Type: Dependency upgrade >Reporter: Tamas Cservenak >Assignee: Tamas Cservenak >Priority: Major > Fix For: 2.0.0, 2.0.0-beta-1 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (MRESOLVER-563) Bump org.codehaus.plexus:plexus-xml from 4.0.3 to 4.0.4
Tamas Cservenak created MRESOLVER-563: - Summary: Bump org.codehaus.plexus:plexus-xml from 4.0.3 to 4.0.4 Key: MRESOLVER-563 URL: https://issues.apache.org/jira/browse/MRESOLVER-563 Project: Maven Resolver Issue Type: Dependency upgrade Reporter: Tamas Cservenak Fix For: 2.0.0, 2.0.0-beta-1 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Closed] (MRESOLVER-562) Bump org.codehaus.mojo:exec-maven-plugin from 3.2.0 to 3.3.0
[ https://issues.apache.org/jira/browse/MRESOLVER-562?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tamas Cservenak closed MRESOLVER-562. - Assignee: Tamas Cservenak Resolution: Fixed > Bump org.codehaus.mojo:exec-maven-plugin from 3.2.0 to 3.3.0 > > > Key: MRESOLVER-562 > URL: https://issues.apache.org/jira/browse/MRESOLVER-562 > Project: Maven Resolver > Issue Type: Dependency upgrade >Reporter: Tamas Cservenak >Assignee: Tamas Cservenak >Priority: Major > Fix For: 2.0.0, 2.0.0-beta-1 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (MRESOLVER-562) Bump org.codehaus.mojo:exec-maven-plugin from 3.2.0 to 3.3.0
Tamas Cservenak created MRESOLVER-562: - Summary: Bump org.codehaus.mojo:exec-maven-plugin from 3.2.0 to 3.3.0 Key: MRESOLVER-562 URL: https://issues.apache.org/jira/browse/MRESOLVER-562 Project: Maven Resolver Issue Type: Dependency upgrade Reporter: Tamas Cservenak Fix For: 2.0.0, 2.0.0-beta-1 -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] Bump org.codehaus.mojo:exec-maven-plugin from 3.2.0 to 3.3.0 [maven-resolver]
cstamas merged PR #498: URL: https://github.com/apache/maven-resolver/pull/498 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [MNG-7354] Refactor MavenCli to ease extensibility [maven]
cstamas commented on PR #634: URL: https://github.com/apache/maven/pull/634#issuecomment-2126753112 This PR needs to be revived, at least on master (mvn4) as maintenance of mvnd is nightmare. Maven 3.9.x (mvnd m39) can remain as is, as it is not getting new features anymore, and hence, the frequency of changes will tend to zero, but mvn4 is different story. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MNG-7354) Refactor MavenCli to ease extensibility
[
https://issues.apache.org/jira/browse/MNG-7354?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17848903#comment-17848903
]
ASF GitHub Bot commented on MNG-7354:
-
cstamas commented on PR #634:
URL: https://github.com/apache/maven/pull/634#issuecomment-2126753112
This PR needs to be revived, at least on master (mvn4) as maintenance of
mvnd is nightmare. Maven 3.9.x (mvnd m39) can remain as is, as it is not
getting new features anymore, and hence, the frequency of changes will tend to
zero, but mvn4 is different story.
> Refactor MavenCli to ease extensibility
> ---
>
> Key: MNG-7354
> URL: https://issues.apache.org/jira/browse/MNG-7354
> Project: Maven
> Issue Type: Improvement
>Reporter: Guillaume Nodet
>Priority: Major
>
> {{mvnd}} has to fully rewrite {{MavenCli}} in order to extend / slightly
> alter its behavior.
> The goal is to avoid code duplication and ease maintenance for mvnd when
> upgrading maven.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
Re: [PR] [MINVOKER-351] Escape special xml character in junit report [maven-invoker-plugin]
michael-o commented on PR #242: URL: https://github.com/apache/maven-invoker-plugin/pull/242#issuecomment-2126717780 @slawekjaranowski Thanks for the great collaboration. We have achieved a awesome result here. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MINVOKER-351) Prevent XML-prohibited characters from entering JUnit report
[
https://issues.apache.org/jira/browse/MINVOKER-351?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17848901#comment-17848901
]
ASF GitHub Bot commented on MINVOKER-351:
-
michael-o commented on PR #242:
URL:
https://github.com/apache/maven-invoker-plugin/pull/242#issuecomment-2126717780
@slawekjaranowski Thanks for the great collaboration. We have achieved a
awesome result here.
> Prevent XML-prohibited characters from entering JUnit report
>
>
> Key: MINVOKER-351
> URL: https://issues.apache.org/jira/browse/MINVOKER-351
> Project: Maven Invoker Plugin
> Issue Type: Bug
>Reporter: Mikkel Kjeldsen
>Assignee: Slawomir Jaranowski
>Priority: Major
> Fix For: 3.7.0
>
> Attachments: minvoker-351.tar.gz
>
>
> Neither the Maven Invoker plugin's implementation of {{}}
> nor the underlying XML infrastructure directly protect against the presence
> of character literals prohibited by the XML specification, meaning such
> literals can appear in the JUnit report and render it unreadable. *I would
> appreciate if the Maven Invoker plugin could learn to strip prohibited
> literals to protect its users from creative plugins.* I argue that this is a
> safe and expected transformation that is not materially lossy.
>
> h2. Background
> MINVOKER-196 added the {{}} option [back in
> maven-invoker-plugin-3.2.1|https://github.com/apache/maven-invoker-plugin/blob/maven-invoker-plugin-3.2.1/src/main/java/org/apache/maven/plugins/invoker/AbstractInvokerMojo.java#L1878-L1946].
> As of [maven-invoker-plugin-3.6.0 the effective implementation of the JUnit
> report remains effectively
> unchanged|https://github.com/apache/maven-invoker-plugin/blob/maven-invoker-plugin-3.6.0/src/main/java/org/apache/maven/plugins/invoker/AbstractInvokerMojo.java#L1695-L1754].
> The JUnit report includes a {{}} element ([example
> documentation|https://github.com/testmoapp/junitxml]) whose value Maven
> Invoker populates with the raw build log contents. I've observed that this
> value is XML-escaped, which I imagine is well understood in the
> implementation, although I can't immediately find documentation to support
> that.
> However, escaping notwithstanding, a number of character literals are
> outright prohibited by the XML specifications. These literals cannot be
> escaped, and their presence renders an XML document not well formed. The
> exact set of prohibited characters varies by XML version; the report produced
> by the Maven Invoker plugin is XML version 1.0. When the Maven Invoker plugin
> reads in the build log it does not strip these character literals and neither
> does the XML writer the Maven Invoker plugin relies on. Consequently, if a
> build log ends up including a prohibited character the resulting JUnit report
> will not be well formed.
> The set of prohibited characters is the complement of [the XML
> specification's definition of {{Char}}|https://www.w3.org/TR/xml/#NT-Char].
> h2. Example
> Among the literals prohibited by XML version 1.0 is {{^H}} (backspace). When
> [pitest runs via Maven|https://pitest.org/quickstart/maven/] it prints a
> spinner to standard out, and the implementation uses backspace to render the
> spinner in place. I have used the Maven Invoker plugin with
> {{}} to verify a pitest configuration, whereby I discovered
> this limitation.
> h2. Remediation
> h3. Blame plugins
> Perhaps pitest should not behave this way but we can't change pitest, and
> even if pitest could be changed that offers no protection against any other
> plugin, so blaming plugins is an ineffective course of action.
> h3. Work-arounds
> The user can manually clean the build log in-place via
> {{}}. This is technically fairly easy to do, and makes
> the transformation very explicit, but it requires considerable local work to
> address an issue many would find obscure and the transformation is
> permanently lossy unless the user also backs up the raw log to another file
> name.
> h3. Strip prohibited literals inside Maven Invoker plugin
> If the Maven Invoker plugin learns to strip offending character literals
> in-between reading the build log and writing to the {{}} value
> then {{}} will Just Work™, which I assert is what a user
> will typically expect. Although the {{}} value will no longer
> exactly match the build log contents, this lossy translation is acceptable:
> the prohibited characters are overwhelmingly unprintable to begin with and
> therefore cannot be meaningfully rendered in a static context, and the raw
> build log remains unchanged in the event that the user needs to investigate
> or assert against the raw output.
> This change would be backwards compatible, because any existing user that
> would be affected by it would
[jira] [Commented] (MPLUGINTESTING-94) Create 3.x branch and switch master to support Maven 4.x
[ https://issues.apache.org/jira/browse/MPLUGINTESTING-94?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17848900#comment-17848900 ] ASF GitHub Bot commented on MPLUGINTESTING-94: -- gnodet opened a new pull request, #40: URL: https://github.com/apache/maven-plugin-testing/pull/40 (no comment) > Create 3.x branch and switch master to support Maven 4.x > > > Key: MPLUGINTESTING-94 > URL: https://issues.apache.org/jira/browse/MPLUGINTESTING-94 > Project: Maven Plugin Testing > Issue Type: Task >Reporter: Guillaume Nodet >Assignee: Guillaume Nodet >Priority: Major > Fix For: 4.0.0-alpha-3 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
