[jira] [Commented] (MNG-8134) Provide an annotation that can be used to inject dependencies resolution/collection in mojos

2024-06-10 Thread ASF GitHub Bot (Jira)


[ 
https://issues.apache.org/jira/browse/MNG-8134?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17853905#comment-17853905
 ] 

ASF GitHub Bot commented on MNG-8134:
-

gnodet commented on PR #1559:
URL: https://github.com/apache/maven/pull/1559#issuecomment-2159869443

   > I assume - but not sure at all - you speak about adding more concurrency 
or something like that but I'm not sure we can do it more than the resolution 
requested by the mojo itself - which needs to move to a list of custom string I 
guess now.
   
   When injecting into a field, we can use a single `pathScope`, however, we 
have the `dependencyResolutionPathScopes` field of the `@Mojo` annotation which 
can be used for informative purpose (as I explained above), and that one is 
defined in the javadoc as a comma separated list of pathScopes.




> Provide an annotation that can be used to inject dependencies 
> resolution/collection in mojos
> 
>
> Key: MNG-8134
> URL: https://issues.apache.org/jira/browse/MNG-8134
> Project: Maven
>  Issue Type: Task
>Reporter: Guillaume Nodet
>Priority: Major
> Fix For: 4.0.0
>
>
> See 
> https://github.com/apache/maven-plugin-tools/pull/286#discussion_r1620871349



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


Re: [PR] [MNG-8134] Add a @Resolution annotation to mojos to inject project dependencies collection / resolution result [maven]

2024-06-10 Thread via GitHub


gnodet commented on PR #1559:
URL: https://github.com/apache/maven/pull/1559#issuecomment-2159869443

   > I assume - but not sure at all - you speak about adding more concurrency 
or something like that but I'm not sure we can do it more than the resolution 
requested by the mojo itself - which needs to move to a list of custom string I 
guess now.
   
   When injecting into a field, we can use a single `pathScope`, however, we 
have the `dependencyResolutionPathScopes` field of the `@Mojo` annotation which 
can be used for informative purpose (as I explained above), and that one is 
defined in the javadoc as a comma separated list of pathScopes.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[jira] [Commented] (MNG-8134) Provide an annotation that can be used to inject dependencies resolution/collection in mojos

2024-06-10 Thread ASF GitHub Bot (Jira)


[ 
https://issues.apache.org/jira/browse/MNG-8134?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17853899#comment-17853899
 ] 

ASF GitHub Bot commented on MNG-8134:
-

rmannibucau commented on PR #1559:
URL: https://github.com/apache/maven/pull/1559#issuecomment-2159787665

   @gnodet ok, if we mix it with the binding/phase - execution has it - later 
it will work, :+1:, thanks.




> Provide an annotation that can be used to inject dependencies 
> resolution/collection in mojos
> 
>
> Key: MNG-8134
> URL: https://issues.apache.org/jira/browse/MNG-8134
> Project: Maven
>  Issue Type: Task
>Reporter: Guillaume Nodet
>Priority: Major
> Fix For: 4.0.0
>
>
> See 
> https://github.com/apache/maven-plugin-tools/pull/286#discussion_r1620871349



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


Re: [PR] [MNG-8134] Add a @Resolution annotation to mojos to inject project dependencies collection / resolution result [maven]

2024-06-10 Thread via GitHub


rmannibucau commented on PR #1559:
URL: https://github.com/apache/maven/pull/1559#issuecomment-2159787665

   @gnodet ok, if we mix it with the binding/phase - execution has it - later 
it will work, :+1:, thanks.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[jira] [Commented] (MPIR-455) dependencies goal: add support for multi-release JARs

2024-06-10 Thread ASF GitHub Bot (Jira)


[ 
https://issues.apache.org/jira/browse/MPIR-455?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17853865#comment-17853865
 ] 

ASF GitHub Bot commented on MPIR-455:
-

belingueres commented on PR #70:
URL: 
https://github.com/apache/maven-project-info-reports-plugin/pull/70#issuecomment-2159657720

   Regarding the entry count, it seems to be a bug in the shared-jar library. 
The root version entries are not saved anywhere. However an easy workaround 
(until the next shared-jar version release with a fix) would be to take the 
difference between the total count and each version. In this case is 
37-(9+9)=19 in the root. The total of 37 can be in the first row (showing file 
attributes). WDYT?




> dependencies goal: add support for multi-release JARs
> -
>
> Key: MPIR-455
> URL: https://issues.apache.org/jira/browse/MPIR-455
> Project: Maven Project Info Reports Plugin
>  Issue Type: Bug
>  Components: dependencies
>Affects Versions: 3.4.5, 3.5.0
>Reporter: Gabriel Belingueres
>Assignee: Michael Osipov
>Priority: Major
> Fix For: 3.6.0
>
> Attachments: image-2024-01-04-21-12-54-861.png, 
> image-2024-06-02-10-58-46-991.png, image-2024-06-02-11-01-26-148.png, 
> image-2024-06-08-11-11-22-722.png, screenshot-1.png
>
>
> dependencies goal reports dependencies with multi-release support with the 
> highest version supported in the jar file, instead of the base version.
> Example: plexus-utils 4.0.0 is reported as a Java 11 dependency, but their 
> base version is 1.8.
> !image-2024-01-04-21-12-54-861.png!
> Because of this the lower "Total" rows report a wrong java version too.
>  
> This depends on https://issues.apache.org/jira/browse/MSHARED-1256.
>  



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


Re: [PR] [MPIR-455] - add support for multi-release JARs. [maven-project-info-reports-plugin]

2024-06-10 Thread via GitHub


belingueres commented on PR #70:
URL: 
https://github.com/apache/maven-project-info-reports-plugin/pull/70#issuecomment-2159657720

   Regarding the entry count, it seems to be a bug in the shared-jar library. 
The root version entries are not saved anywhere. However an easy workaround 
(until the next shared-jar version release with a fix) would be to take the 
difference between the total count and each version. In this case is 
37-(9+9)=19 in the root. The total of 37 can be in the first row (showing file 
attributes). WDYT?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[jira] [Commented] (MPIR-455) dependencies goal: add support for multi-release JARs

2024-06-10 Thread ASF GitHub Bot (Jira)


[ 
https://issues.apache.org/jira/browse/MPIR-455?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17853844#comment-17853844
 ] 

ASF GitHub Bot commented on MPIR-455:
-

belingueres commented on code in PR #70:
URL: 
https://github.com/apache/maven-project-info-reports-plugin/pull/70#discussion_r1634011475


##
pom.xml:
##
@@ -511,11 +511,47 @@ under the License.
 pom.xml
   
   
${project.build.directory}/local-repo
+  
+
${repository.proxy.url}
+  
+  true

Review Comment:
   It seems to add no needed behavior...I can delete this config.





> dependencies goal: add support for multi-release JARs
> -
>
> Key: MPIR-455
> URL: https://issues.apache.org/jira/browse/MPIR-455
> Project: Maven Project Info Reports Plugin
>  Issue Type: Bug
>  Components: dependencies
>Affects Versions: 3.4.5, 3.5.0
>Reporter: Gabriel Belingueres
>Assignee: Michael Osipov
>Priority: Major
> Fix For: 3.6.0
>
> Attachments: image-2024-01-04-21-12-54-861.png, 
> image-2024-06-02-10-58-46-991.png, image-2024-06-02-11-01-26-148.png, 
> image-2024-06-08-11-11-22-722.png, screenshot-1.png
>
>
> dependencies goal reports dependencies with multi-release support with the 
> highest version supported in the jar file, instead of the base version.
> Example: plexus-utils 4.0.0 is reported as a Java 11 dependency, but their 
> base version is 1.8.
> !image-2024-01-04-21-12-54-861.png!
> Because of this the lower "Total" rows report a wrong java version too.
>  
> This depends on https://issues.apache.org/jira/browse/MSHARED-1256.
>  



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


Re: [PR] [MPIR-455] - add support for multi-release JARs. [maven-project-info-reports-plugin]

2024-06-10 Thread via GitHub


belingueres commented on code in PR #70:
URL: 
https://github.com/apache/maven-project-info-reports-plugin/pull/70#discussion_r1634011475


##
pom.xml:
##
@@ -511,11 +511,47 @@ under the License.
 pom.xml
   
   
${project.build.directory}/local-repo
+  
+
${repository.proxy.url}
+  
+  true

Review Comment:
   It seems to add no needed behavior...I can delete this config.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[jira] [Commented] (MPIR-455) dependencies goal: add support for multi-release JARs

2024-06-10 Thread ASF GitHub Bot (Jira)


[ 
https://issues.apache.org/jira/browse/MPIR-455?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17853836#comment-17853836
 ] 

ASF GitHub Bot commented on MPIR-455:
-

belingueres commented on code in PR #70:
URL: 
https://github.com/apache/maven-project-info-reports-plugin/pull/70#discussion_r1633942122


##
pom.xml:
##
@@ -511,11 +511,47 @@ under the License.
 pom.xml
   
   
${project.build.directory}/local-repo
+  
+
${repository.proxy.url}
+  
+  true
+
   
 site
   
 
   
+  
+org.codehaus.mojo
+mrm-maven-plugin
+1.6.0
+
+  repository.proxy.url
+  
+
+  src/it/mrm/repository
+  
> Key: MPIR-455
> URL: https://issues.apache.org/jira/browse/MPIR-455
> Project: Maven Project Info Reports Plugin
>  Issue Type: Bug
>  Components: dependencies
>Affects Versions: 3.4.5, 3.5.0
>Reporter: Gabriel Belingueres
>Assignee: Michael Osipov
>Priority: Major
> Fix For: 3.6.0
>
> Attachments: image-2024-01-04-21-12-54-861.png, 
> image-2024-06-02-10-58-46-991.png, image-2024-06-02-11-01-26-148.png, 
> image-2024-06-08-11-11-22-722.png, screenshot-1.png
>
>
> dependencies goal reports dependencies with multi-release support with the 
> highest version supported in the jar file, instead of the base version.
> Example: plexus-utils 4.0.0 is reported as a Java 11 dependency, but their 
> base version is 1.8.
> !image-2024-01-04-21-12-54-861.png!
> Because of this the lower "Total" rows report a wrong java version too.
>  
> This depends on https://issues.apache.org/jira/browse/MSHARED-1256.
>  



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


Re: [PR] [MPIR-455] - add support for multi-release JARs. [maven-project-info-reports-plugin]

2024-06-10 Thread via GitHub


belingueres commented on code in PR #70:
URL: 
https://github.com/apache/maven-project-info-reports-plugin/pull/70#discussion_r1633942122


##
pom.xml:
##
@@ -511,11 +511,47 @@ under the License.
 pom.xml
   
   
${project.build.directory}/local-repo
+  
+
${repository.proxy.url}
+  
+  true
+
   
 site
   
 
   
+  
+org.codehaus.mojo
+mrm-maven-plugin
+1.6.0
+
+  repository.proxy.url
+  
+
+  src/it/mrm/repository
+  

[jira] [Commented] (MPIR-455) dependencies goal: add support for multi-release JARs

2024-06-10 Thread ASF GitHub Bot (Jira)


[ 
https://issues.apache.org/jira/browse/MPIR-455?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17853835#comment-17853835
 ] 

ASF GitHub Bot commented on MPIR-455:
-

belingueres commented on code in PR #70:
URL: 
https://github.com/apache/maven-project-info-reports-plugin/pull/70#discussion_r1633941736


##
pom.xml:
##
@@ -511,11 +511,47 @@ under the License.
 pom.xml
   
   
${project.build.directory}/local-repo
+  
+
${repository.proxy.url}
+  
+  true
+
   
 site
   
 
   
+  
+org.codehaus.mojo
+mrm-maven-plugin
+1.6.0

Review Comment:
   I couldn't find the mrm-maven-plugin defined in a parent pom.





> dependencies goal: add support for multi-release JARs
> -
>
> Key: MPIR-455
> URL: https://issues.apache.org/jira/browse/MPIR-455
> Project: Maven Project Info Reports Plugin
>  Issue Type: Bug
>  Components: dependencies
>Affects Versions: 3.4.5, 3.5.0
>Reporter: Gabriel Belingueres
>Assignee: Michael Osipov
>Priority: Major
> Fix For: 3.6.0
>
> Attachments: image-2024-01-04-21-12-54-861.png, 
> image-2024-06-02-10-58-46-991.png, image-2024-06-02-11-01-26-148.png, 
> image-2024-06-08-11-11-22-722.png, screenshot-1.png
>
>
> dependencies goal reports dependencies with multi-release support with the 
> highest version supported in the jar file, instead of the base version.
> Example: plexus-utils 4.0.0 is reported as a Java 11 dependency, but their 
> base version is 1.8.
> !image-2024-01-04-21-12-54-861.png!
> Because of this the lower "Total" rows report a wrong java version too.
>  
> This depends on https://issues.apache.org/jira/browse/MSHARED-1256.
>  



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


Re: [PR] [MPIR-455] - add support for multi-release JARs. [maven-project-info-reports-plugin]

2024-06-10 Thread via GitHub


belingueres commented on code in PR #70:
URL: 
https://github.com/apache/maven-project-info-reports-plugin/pull/70#discussion_r1633941736


##
pom.xml:
##
@@ -511,11 +511,47 @@ under the License.
 pom.xml
   
   
${project.build.directory}/local-repo
+  
+
${repository.proxy.url}
+  
+  true
+
   
 site
   
 
   
+  
+org.codehaus.mojo
+mrm-maven-plugin
+1.6.0

Review Comment:
   I couldn't find the mrm-maven-plugin defined in a parent pom.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[PR] Bump org.jsoup:jsoup from 1.15.3 to 1.17.2 [maven-site]

2024-06-10 Thread via GitHub


dependabot[bot] opened a new pull request, #540:
URL: https://github.com/apache/maven-site/pull/540

   Bumps [org.jsoup:jsoup](https://github.com/jhy/jsoup) from 1.15.3 to 1.17.2.
   
   Release notes
   Sourced from https://github.com/jhy/jsoup/releases";>org.jsoup:jsoup's 
releases.
   
   jsoup Java HTML Parser release 1.17.2
   Improvements
   
   Attribute object accessors: Added 
Element.attribute(String) and 
Attributes.attribute(String) to more simply
   obtain an Attribute object. https://redirect.github.com/jhy/jsoup/issues/2069";>2069
   Attribute source tracking: If source tracking is on, 
and an Attribute's key is changed (
   via Attribute.setKey(String)), the source range is now still 
tracked
   in Attribute.sourceRange(). https://redirect.github.com/jhy/jsoup/issues/2070";>2070
   Wildcard attribute selector: Added support for the 
[*] element with any attribute selector. And also restored
   support for selecting by an empty attribute name prefix ([^]). 
https://redirect.github.com/jhy/jsoup/issues/2079";>2079
   
   Bug Fixes
   
   Mixed-cased source position: When tracking the source 
position of attributes, if the source attribute name was
   mix-cased but the parser was lower-case normalizing attribute names, the 
source position for that attribute was not
   tracked correctly. https://redirect.github.com/jhy/jsoup/issues/2067";>2067
   Source position NPE: When tracking the source position 
of a body fragment parse, a null pointer
   exception was thrown. https://redirect.github.com/jhy/jsoup/issues/2068";>2068
   Multi-point emoji entity: A multi-point encoded emoji 
entity may be incorrectly decoded to the replacement
   character. https://redirect.github.com/jhy/jsoup/issues/2074";>2074
   Selector sub-expressions: (Regression) in a selector 
like parent [attr=va], other, the , OR was binding
   to [attr=va] instead of parent [attr=va], causing 
incorrect selections. The fix includes a EvaluatorDebug class
   that generates a sexpr to represent the query, allowing simpler and more 
thorough query parse
   tests. https://redirect.github.com/jhy/jsoup/issues/2073";>2073
   XML CData output: When generating XML-syntax output 
from parsed HTML, script nodes containing (pseudo) CData
   sections would have an extraneous CData section added, causing script 
execution errors. Now, the data content is
   emitted in a HTML/XML/XHTML polyglot format, if the data is not already 
within a CData
   section. https://redirect.github.com/jhy/jsoup/issues/2078";>2078
   Thread safety: The :has evaluator held a 
non-thread-safe Iterator, and so if an Evaluator object was
   shared across multiple concurrent threads, a NoSuchElement exception may be 
thrown, and the selected results may be
   incorrect. Now, the iterator object is a thread-local. https://redirect.github.com/jhy/jsoup/issues/2088";>2088
   
   jsoup 1.17.1
   
   
   
   
   ... (truncated)
   
   
   Changelog
   Sourced from https://github.com/jhy/jsoup/blob/master/CHANGES.md";>org.jsoup:jsoup's 
changelog.
   
   1.17.2 (2023-Dec-29)
   Improvements
   
   Attribute object accessors: Added 
Element.attribute(String) and 
Attributes.attribute(String) to more simply
   obtain an Attribute object. https://redirect.github.com/jhy/jsoup/issues/2069";>2069
   Attribute source tracking: If source tracking is on, 
and an Attribute's key is changed (
   via Attribute.setKey(String)), the source range is now still 
tracked
   in Attribute.sourceRange(). https://redirect.github.com/jhy/jsoup/issues/2070";>2070
   Wildcard attribute selector: Added support for the 
[*] element with any attribute selector. And also restored
   support for selecting by an empty attribute name prefix ([^]). 
https://redirect.github.com/jhy/jsoup/issues/2079";>2079
   
   Bug Fixes
   
   Mixed-cased source position: When tracking the source 
position of attributes, if the source attribute name was
   mix-cased but the parser was lower-case normalizing attribute names, the 
source position for that attribute was not
   tracked correctly. https://redirect.github.com/jhy/jsoup/issues/2067";>2067
   Source position NPE: When tracking the source position 
of a body fragment parse, a null pointer
   exception was thrown. https://redirect.github.com/jhy/jsoup/issues/2068";>2068
   Multi-point emoji entity: A multi-point encoded emoji 
entity may be incorrectly decoded to the replacement
   character. https://redirect.github.com/jhy/jsoup/issues/2074";>2074
   Selector sub-expressions: (Regression) in a selector 
like parent [attr=va], other, the , OR was binding
   to [attr=va] instead of parent [attr=va], causing 
incorrect selections. The fix includes a EvaluatorDebug class
   that generates a sexpr to represent the query, allowing simpler and more 
thorough query parse
   tests. https://redirect.github.com/jhy/jsoup/issues/2073";>2073
   XML CData output: When generating XML-syntax output 
from parsed HTML, script nodes containing (pseudo) CData
   sections woul

[PR] Bump org.apache.maven.shared:maven-common-artifact-filters from 3.3.2 to 3.4.0 [maven-dependency-plugin]

2024-06-10 Thread via GitHub


dependabot[bot] opened a new pull request, #413:
URL: https://github.com/apache/maven-dependency-plugin/pull/413

   Bumps 
[org.apache.maven.shared:maven-common-artifact-filters](https://github.com/apache/maven-common-artifact-filters)
 from 3.3.2 to 3.4.0.
   
   Commits
   
   https://github.com/apache/maven-common-artifact-filters/commit/d3cd1e4a9646de2a2f30ddd34e1e4471b2a75f8f";>d3cd1e4
 [maven-release-plugin] prepare release maven-common-artifact-filters-3.4.0
   https://github.com/apache/maven-common-artifact-filters/commit/31ecf96e47a6e8aa9f45e47c70767e2f378db919";>31ecf96
 Ignore blame revs
   https://github.com/apache/maven-common-artifact-filters/commit/888d69aee331d183a5f1e6343246fbe2dd712965";>888d69a
 [MSHARED-1301] Upgrade to Parent 42 and Maven 3.6.3
   https://github.com/apache/maven-common-artifact-filters/commit/1742cb10aefa271fbf7dd526b635dca5aa14481a";>1742cb1
 Bump maven-gh-actions-shared to v4
   https://github.com/apache/maven-common-artifact-filters/commit/9d692d49b35014a2d308c78894ee502bccd0361e";>9d692d4
 [MSHARED-1302] upgrade commons-io to 2.13.0 (https://redirect.github.com/apache/maven-common-artifact-filters/issues/34";>#34)
   https://github.com/apache/maven-common-artifact-filters/commit/bbcf21338500a56de7301667900f181cc2bbfc5c";>bbcf213
 [MSHARED-1300] Order of dependencies is not always retained when filtering (https://redirect.github.com/apache/maven-common-artifact-filters/issues/33";>#33)
   https://github.com/apache/maven-common-artifact-filters/commit/c3b2940621e5a9871d181d05f1c51eab2fc335e0";>c3b2940
 Auto-link MSHARED Jira
   https://github.com/apache/maven-common-artifact-filters/commit/9a65b6570154ae48ab8a6c7154e0fa07d3cc2c49";>9a65b65
 add Reproducible Builds badge
   https://github.com/apache/maven-common-artifact-filters/commit/6c7242159031dd72f36bcc15f76f86b4faee70b4";>6c72421
 [maven-release-plugin] prepare for next development iteration
   See full diff in https://github.com/apache/maven-common-artifact-filters/compare/maven-common-artifact-filters-3.3.2...maven-common-artifact-filters-3.4.0";>compare
 view
   
   
   
   
   
   [![Dependabot compatibility 
score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=org.apache.maven.shared:maven-common-artifact-filters&package-manager=maven&previous-version=3.3.2&new-version=3.4.0)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)
   
   Dependabot will resolve any conflicts with this PR as long as you don't 
alter it yourself. You can also trigger a rebase manually by commenting 
`@dependabot rebase`.
   
   [//]: # (dependabot-automerge-start)
   [//]: # (dependabot-automerge-end)
   
   ---
   
   
   Dependabot commands and options
   
   
   You can trigger Dependabot actions by commenting on this PR:
   - `@dependabot rebase` will rebase this PR
   - `@dependabot recreate` will recreate this PR, overwriting any edits that 
have been made to it
   - `@dependabot merge` will merge this PR after your CI passes on it
   - `@dependabot squash and merge` will squash and merge this PR after your CI 
passes on it
   - `@dependabot cancel merge` will cancel a previously requested merge and 
block automerging
   - `@dependabot reopen` will reopen this PR if it is closed
   - `@dependabot close` will close this PR and stop Dependabot recreating it. 
You can achieve the same result by closing it manually
   - `@dependabot show  ignore conditions` will show all of 
the ignore conditions of the specified dependency
   - `@dependabot ignore this major version` will close this PR and stop 
Dependabot creating any more for this major version (unless you reopen the PR 
or upgrade to it yourself)
   - `@dependabot ignore this minor version` will close this PR and stop 
Dependabot creating any more for this minor version (unless you reopen the PR 
or upgrade to it yourself)
   - `@dependabot ignore this dependency` will close this PR and stop 
Dependabot creating any more for this dependency (unless you reopen the PR or 
upgrade to it yourself)
   
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] [MNG-7758] Report dependency problems for all repository [maven]

2024-06-10 Thread via GitHub


slawekjaranowski commented on PR #1563:
URL: https://github.com/apache/maven/pull/1563#issuecomment-2159343593

   and similar for plugins:
   
   ```
   [ERROR] Plugin org.apache.maven.its.plugins:maven-it-plugin-not-exists:1.2.3 
or one of its dependencies could not be resolved:
   [ERROR]  Could not find artifact 
org.apache.maven.its.plugins:maven-it-plugin-not-exists:jar:1.2.3 in central 
(http://localhost:64391/repo)
   [ERROR]  Could not find artifact 
org.apache.maven.its.plugins:maven-it-plugin-not-exists:jar:1.2.3 in 
maven-core-it (http://localhost:64391/repo)
   
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[jira] [Commented] (MNG-7758) o.e.aether.resolution.ArtifactResolutionException incorrectly examined when multiple repositories are involved

2024-06-10 Thread ASF GitHub Bot (Jira)


[ 
https://issues.apache.org/jira/browse/MNG-7758?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17853822#comment-17853822
 ] 

ASF GitHub Bot commented on MNG-7758:
-

slawekjaranowski commented on PR #1563:
URL: https://github.com/apache/maven/pull/1563#issuecomment-2159343593

   and similar for plugins:
   
   ```
   [ERROR] Plugin org.apache.maven.its.plugins:maven-it-plugin-not-exists:1.2.3 
or one of its dependencies could not be resolved:
   [ERROR]  Could not find artifact 
org.apache.maven.its.plugins:maven-it-plugin-not-exists:jar:1.2.3 in central 
(http://localhost:64391/repo)
   [ERROR]  Could not find artifact 
org.apache.maven.its.plugins:maven-it-plugin-not-exists:jar:1.2.3 in 
maven-core-it (http://localhost:64391/repo)
   
   ```




> o.e.aether.resolution.ArtifactResolutionException incorrectly examined when 
> multiple repositories are involved
> --
>
> Key: MNG-7758
> URL: https://issues.apache.org/jira/browse/MNG-7758
> Project: Maven
>  Issue Type: Bug
>  Components: Artifacts and Repositories, Dependencies, Performance
>Affects Versions: 3.8.8, 3.9.1, 4.0.0-alpha-5
>Reporter: Michael Osipov
>Assignee: Slawomir Jaranowski
>Priority: Critical
> Fix For: 4.0.0, 3.9.8, 4.0.0-beta-4
>
> Attachments: 1.png, 2.png, Exception hierarchy.png
>
>
> Consider you have three repos defined in your build (could be POM or 
> settings), evaluated in following order:
> 1. repo A: serves custom artifacts with group id {{com.example}}, due to repo 
> partitioning in Nexus rejects requests to all other group ids with 403
> 1. repo B: serves third party artifacts without any restriction from a Nexus 
> repo
> 1. repo C: serves Central mirror, last one quried, no restrictions
> Note that order is important! Now add a non-existing dependency to your  POM 
> and receive the following behavior:
> {{ArtifactResolutionException}} will contain an {{ArtifactResult}} with three 
> exceptions: 
>  - {{TransferException}} with nested {{AuthorizationException}}, 
>  - {{ArtifactNotFoundException}}, 
>  - {{ArtifactNotFoundException}}. 
> {{ArtifactResolutionException#getCause()}} will be populated with the 
> {{TransferException}} so will 
> {{org.eclipse.aether.resolution.ArtifactResult.isMissing()}} take the first 
> exception only into account. E.g., {{DefaultArtifactDescriptorReader}} will 
> do {{if (e.getCause() instanceof ArtifactNotFoundException)}} which is 
> deceiving.
> Here is a sample for a non-existing artifact:
> {noformat}
> [INFO] --- maven-site-plugin:4.0.0-M7-SNAPSHOT:site (default-site) @ 
> mskins-222 ---
> [INFO] Configuring report plugin 
> org.apache.maven.plugins:maven-project-info-reports-plugin:3.4.2
> [WARNING] index report is declared twice in default reportSet
> [INFO] 15 reports configured for maven-project-info-reports-plugin:3.4.2: 
> index, summary, dependency-info, modules, team, scm, issue-management, 
> mailing-lists, dependency-management, dependencies, dependency-convergence, 
> ci-management, plugin-management, plugins, distribution-management
> [INFO] Rendering site for default locale
> Downloading from lda-public: 
> https://deblndw011x.ad001.siemens.net/nexus/content/groups/lda-public/org/apache/apache/29/apache-29-site.xml
> [INFO] 
> 
> [INFO] BUILD FAILURE
> [INFO] 
> 
> [INFO] Total time:  3.214 s
> [INFO] Finished at: 2023-04-02T12:51:02+02:00
> [INFO] 
> 
> [ERROR] Failed to execute goal 
> org.apache.maven.plugins:maven-site-plugin:4.0.0-M7-SNAPSHOT:site 
> (default-site) on project mskins-222: SiteToolException: The site descriptor 
> cannot be resolved from the repository: Unable to locate site descriptor: 
> Could not transfer artifact org.apache:apache:xml:site:29 from/to lda-public 
> (https://deblndw011x.ad001.siemens.net/nexus/content/groups/lda-public/): 
> authorization failed for 
> https://deblndw011x.ad001.siemens.net/nexus/content/groups/lda-public/org/apache/apache/29/apache-29-site.xml,
>  status: 403 Forbidden -> [Help 1]
> [ERROR]
> [ERROR] To see the full stack trace of the errors, re-run Maven with the -e 
> switch.
> [ERROR] Re-run Maven using the -X switch to enable full debug logging.
> [ERROR]
> [ERROR] For more information about the errors and possible solutions, please 
> read the following articles:
> [ERROR] [Help 1] 
> http://cwiki.apache.org/confluence/display/MAVEN/MojoExecutionException
> {noformat}
> for a dependency:
> {noformat}
> [INFO] org.apache.maven.cli.event.ExecutionEventLogger - 
> ---

[jira] [Commented] (MNG-8134) Provide an annotation that can be used to inject dependencies resolution/collection in mojos

2024-06-10 Thread ASF GitHub Bot (Jira)


[ 
https://issues.apache.org/jira/browse/MNG-8134?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17853808#comment-17853808
 ] 

ASF GitHub Bot commented on MNG-8134:
-

gnodet commented on PR #1559:
URL: https://github.com/apache/maven/pull/1559#issuecomment-2159221597

   > > the benefit of having it statically defined (so that we can compute 
exactly what is needed in advance)
   > 
   > I'm not sure I get it, this should be 1-1 with the programmatic flavor 
IMHO so either it is cached in the impl and it is always computed in advanced 
somehow - or there is no pitfall computing it lazily more exactly - or it will 
be wrong if computed in advanced and a mojo modifies the current scope for next 
mojo 🤔
   > 
   > I assume - but not sure at all - you speak about adding more concurrency 
or something like that but I'm not sure we can do it more than the resolution 
requested by the mojo itself - which needs to move to a list of custom string I 
guess now.
   
   The fact that we statically know that a given mojo execution will require 
the project dependencies will be helpful if we can implement the fully 
concurrent lifecycle. My goal would be to have a builder which goes down to the 
phase or mojo level : all mojos executions should be able to run concurrently 
and ordered according to the actual dependencies specified between projects.
   
   My assumption is that "Project A depends on Project B" has no direct impact 
on the build order.  It only has an effect if a mojo execution actually 
requires the dependencies of project A.   This is currently not really needed, 
because we build a given project completely before building another one.  
   This means we need more fine-grained dependencies: for example, if Project A 
depends on Project B, at compile time, we don't really need the fully built 
Project B, we need compiled and post-processed classes.  We don't need the 
compiled test classes, nor the results of the unit tests.
   This information can be either stored in phase semantics:  all mojos 
executions in the `compile` phase need to be executed after the compile time 
dependencies of the project are themselves in the `compile` phase.  This can 
also be provided on a per-mojo basis: the `@Resolution` annotation of this PR 
does provide some information that a given mojo execution does require its 
dependencies (though it currently does not specify in which phase, that may 
need to be added later).  With both source of informations, we can build a full 
graph of mojo executions and run it in a much more efficient way that with our 
current model.
   




> Provide an annotation that can be used to inject dependencies 
> resolution/collection in mojos
> 
>
> Key: MNG-8134
> URL: https://issues.apache.org/jira/browse/MNG-8134
> Project: Maven
>  Issue Type: Task
>Reporter: Guillaume Nodet
>Priority: Major
> Fix For: 4.0.0
>
>
> See 
> https://github.com/apache/maven-plugin-tools/pull/286#discussion_r1620871349



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


Re: [PR] [MNG-8134] Add a @Resolution annotation to mojos to inject project dependencies collection / resolution result [maven]

2024-06-10 Thread via GitHub


gnodet commented on PR #1559:
URL: https://github.com/apache/maven/pull/1559#issuecomment-2159221597

   > > the benefit of having it statically defined (so that we can compute 
exactly what is needed in advance)
   > 
   > I'm not sure I get it, this should be 1-1 with the programmatic flavor 
IMHO so either it is cached in the impl and it is always computed in advanced 
somehow - or there is no pitfall computing it lazily more exactly - or it will 
be wrong if computed in advanced and a mojo modifies the current scope for next 
mojo 🤔
   > 
   > I assume - but not sure at all - you speak about adding more concurrency 
or something like that but I'm not sure we can do it more than the resolution 
requested by the mojo itself - which needs to move to a list of custom string I 
guess now.
   
   The fact that we statically know that a given mojo execution will require 
the project dependencies will be helpful if we can implement the fully 
concurrent lifecycle. My goal would be to have a builder which goes down to the 
phase or mojo level : all mojos executions should be able to run concurrently 
and ordered according to the actual dependencies specified between projects.
   
   My assumption is that "Project A depends on Project B" has no direct impact 
on the build order.  It only has an effect if a mojo execution actually 
requires the dependencies of project A.   This is currently not really needed, 
because we build a given project completely before building another one.  
   This means we need more fine-grained dependencies: for example, if Project A 
depends on Project B, at compile time, we don't really need the fully built 
Project B, we need compiled and post-processed classes.  We don't need the 
compiled test classes, nor the results of the unit tests.
   This information can be either stored in phase semantics:  all mojos 
executions in the `compile` phase need to be executed after the compile time 
dependencies of the project are themselves in the `compile` phase.  This can 
also be provided on a per-mojo basis: the `@Resolution` annotation of this PR 
does provide some information that a given mojo execution does require its 
dependencies (though it currently does not specify in which phase, that may 
need to be added later).  With both source of informations, we can build a full 
graph of mojo executions and run it in a much more efficient way that with our 
current model.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[jira] [Commented] (MNG-7758) o.e.aether.resolution.ArtifactResolutionException incorrectly examined when multiple repositories are involved

2024-06-10 Thread ASF GitHub Bot (Jira)


[ 
https://issues.apache.org/jira/browse/MNG-7758?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17853803#comment-17853803
 ] 

ASF GitHub Bot commented on MNG-7758:
-

slawekjaranowski commented on PR #1563:
URL: https://github.com/apache/maven/pull/1563#issuecomment-2159183130

   For me it is not a big problem, like connection exception is not common, 
more important is to have a list of not found artifact per repository




> o.e.aether.resolution.ArtifactResolutionException incorrectly examined when 
> multiple repositories are involved
> --
>
> Key: MNG-7758
> URL: https://issues.apache.org/jira/browse/MNG-7758
> Project: Maven
>  Issue Type: Bug
>  Components: Artifacts and Repositories, Dependencies, Performance
>Affects Versions: 3.8.8, 3.9.1, 4.0.0-alpha-5
>Reporter: Michael Osipov
>Assignee: Slawomir Jaranowski
>Priority: Critical
> Fix For: 4.0.0, 3.9.8, 4.0.0-beta-4
>
> Attachments: 1.png, 2.png, Exception hierarchy.png
>
>
> Consider you have three repos defined in your build (could be POM or 
> settings), evaluated in following order:
> 1. repo A: serves custom artifacts with group id {{com.example}}, due to repo 
> partitioning in Nexus rejects requests to all other group ids with 403
> 1. repo B: serves third party artifacts without any restriction from a Nexus 
> repo
> 1. repo C: serves Central mirror, last one quried, no restrictions
> Note that order is important! Now add a non-existing dependency to your  POM 
> and receive the following behavior:
> {{ArtifactResolutionException}} will contain an {{ArtifactResult}} with three 
> exceptions: 
>  - {{TransferException}} with nested {{AuthorizationException}}, 
>  - {{ArtifactNotFoundException}}, 
>  - {{ArtifactNotFoundException}}. 
> {{ArtifactResolutionException#getCause()}} will be populated with the 
> {{TransferException}} so will 
> {{org.eclipse.aether.resolution.ArtifactResult.isMissing()}} take the first 
> exception only into account. E.g., {{DefaultArtifactDescriptorReader}} will 
> do {{if (e.getCause() instanceof ArtifactNotFoundException)}} which is 
> deceiving.
> Here is a sample for a non-existing artifact:
> {noformat}
> [INFO] --- maven-site-plugin:4.0.0-M7-SNAPSHOT:site (default-site) @ 
> mskins-222 ---
> [INFO] Configuring report plugin 
> org.apache.maven.plugins:maven-project-info-reports-plugin:3.4.2
> [WARNING] index report is declared twice in default reportSet
> [INFO] 15 reports configured for maven-project-info-reports-plugin:3.4.2: 
> index, summary, dependency-info, modules, team, scm, issue-management, 
> mailing-lists, dependency-management, dependencies, dependency-convergence, 
> ci-management, plugin-management, plugins, distribution-management
> [INFO] Rendering site for default locale
> Downloading from lda-public: 
> https://deblndw011x.ad001.siemens.net/nexus/content/groups/lda-public/org/apache/apache/29/apache-29-site.xml
> [INFO] 
> 
> [INFO] BUILD FAILURE
> [INFO] 
> 
> [INFO] Total time:  3.214 s
> [INFO] Finished at: 2023-04-02T12:51:02+02:00
> [INFO] 
> 
> [ERROR] Failed to execute goal 
> org.apache.maven.plugins:maven-site-plugin:4.0.0-M7-SNAPSHOT:site 
> (default-site) on project mskins-222: SiteToolException: The site descriptor 
> cannot be resolved from the repository: Unable to locate site descriptor: 
> Could not transfer artifact org.apache:apache:xml:site:29 from/to lda-public 
> (https://deblndw011x.ad001.siemens.net/nexus/content/groups/lda-public/): 
> authorization failed for 
> https://deblndw011x.ad001.siemens.net/nexus/content/groups/lda-public/org/apache/apache/29/apache-29-site.xml,
>  status: 403 Forbidden -> [Help 1]
> [ERROR]
> [ERROR] To see the full stack trace of the errors, re-run Maven with the -e 
> switch.
> [ERROR] Re-run Maven using the -X switch to enable full debug logging.
> [ERROR]
> [ERROR] For more information about the errors and possible solutions, please 
> read the following articles:
> [ERROR] [Help 1] 
> http://cwiki.apache.org/confluence/display/MAVEN/MojoExecutionException
> {noformat}
> for a dependency:
> {noformat}
> [INFO] org.apache.maven.cli.event.ExecutionEventLogger - 
> 
> [ERROR] org.apache.maven.cli.MavenCli - Failed to execute goal 
> org.apache.maven.plugins:maven-site-plugin:4.0.0-M7-SNAPSHOT:site 
> (default-site) on project mskins-222: Failed to get report for 
> org.apache.maven.plugins:maven-project-plugin: Plugin 
> org.apache.maven.plugins

Re: [PR] [MNG-7758] Report dependency problems for all repository [maven]

2024-06-10 Thread via GitHub


slawekjaranowski commented on PR #1563:
URL: https://github.com/apache/maven/pull/1563#issuecomment-2159183130

   For me it is not a big problem, like connection exception is not common, 
more important is to have a list of not found artifact per repository


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[jira] [Commented] (MNG-7758) o.e.aether.resolution.ArtifactResolutionException incorrectly examined when multiple repositories are involved

2024-06-10 Thread ASF GitHub Bot (Jira)


[ 
https://issues.apache.org/jira/browse/MNG-7758?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17853802#comment-17853802
 ] 

ASF GitHub Bot commented on MNG-7758:
-

slawekjaranowski commented on PR #1563:
URL: https://github.com/apache/maven/pull/1563#issuecomment-2159175900

   Please look at https://github.com/apache/maven-integration-testing/pull/348




> o.e.aether.resolution.ArtifactResolutionException incorrectly examined when 
> multiple repositories are involved
> --
>
> Key: MNG-7758
> URL: https://issues.apache.org/jira/browse/MNG-7758
> Project: Maven
>  Issue Type: Bug
>  Components: Artifacts and Repositories, Dependencies, Performance
>Affects Versions: 3.8.8, 3.9.1, 4.0.0-alpha-5
>Reporter: Michael Osipov
>Assignee: Slawomir Jaranowski
>Priority: Critical
> Fix For: 4.0.0, 3.9.8, 4.0.0-beta-4
>
> Attachments: 1.png, 2.png, Exception hierarchy.png
>
>
> Consider you have three repos defined in your build (could be POM or 
> settings), evaluated in following order:
> 1. repo A: serves custom artifacts with group id {{com.example}}, due to repo 
> partitioning in Nexus rejects requests to all other group ids with 403
> 1. repo B: serves third party artifacts without any restriction from a Nexus 
> repo
> 1. repo C: serves Central mirror, last one quried, no restrictions
> Note that order is important! Now add a non-existing dependency to your  POM 
> and receive the following behavior:
> {{ArtifactResolutionException}} will contain an {{ArtifactResult}} with three 
> exceptions: 
>  - {{TransferException}} with nested {{AuthorizationException}}, 
>  - {{ArtifactNotFoundException}}, 
>  - {{ArtifactNotFoundException}}. 
> {{ArtifactResolutionException#getCause()}} will be populated with the 
> {{TransferException}} so will 
> {{org.eclipse.aether.resolution.ArtifactResult.isMissing()}} take the first 
> exception only into account. E.g., {{DefaultArtifactDescriptorReader}} will 
> do {{if (e.getCause() instanceof ArtifactNotFoundException)}} which is 
> deceiving.
> Here is a sample for a non-existing artifact:
> {noformat}
> [INFO] --- maven-site-plugin:4.0.0-M7-SNAPSHOT:site (default-site) @ 
> mskins-222 ---
> [INFO] Configuring report plugin 
> org.apache.maven.plugins:maven-project-info-reports-plugin:3.4.2
> [WARNING] index report is declared twice in default reportSet
> [INFO] 15 reports configured for maven-project-info-reports-plugin:3.4.2: 
> index, summary, dependency-info, modules, team, scm, issue-management, 
> mailing-lists, dependency-management, dependencies, dependency-convergence, 
> ci-management, plugin-management, plugins, distribution-management
> [INFO] Rendering site for default locale
> Downloading from lda-public: 
> https://deblndw011x.ad001.siemens.net/nexus/content/groups/lda-public/org/apache/apache/29/apache-29-site.xml
> [INFO] 
> 
> [INFO] BUILD FAILURE
> [INFO] 
> 
> [INFO] Total time:  3.214 s
> [INFO] Finished at: 2023-04-02T12:51:02+02:00
> [INFO] 
> 
> [ERROR] Failed to execute goal 
> org.apache.maven.plugins:maven-site-plugin:4.0.0-M7-SNAPSHOT:site 
> (default-site) on project mskins-222: SiteToolException: The site descriptor 
> cannot be resolved from the repository: Unable to locate site descriptor: 
> Could not transfer artifact org.apache:apache:xml:site:29 from/to lda-public 
> (https://deblndw011x.ad001.siemens.net/nexus/content/groups/lda-public/): 
> authorization failed for 
> https://deblndw011x.ad001.siemens.net/nexus/content/groups/lda-public/org/apache/apache/29/apache-29-site.xml,
>  status: 403 Forbidden -> [Help 1]
> [ERROR]
> [ERROR] To see the full stack trace of the errors, re-run Maven with the -e 
> switch.
> [ERROR] Re-run Maven using the -X switch to enable full debug logging.
> [ERROR]
> [ERROR] For more information about the errors and possible solutions, please 
> read the following articles:
> [ERROR] [Help 1] 
> http://cwiki.apache.org/confluence/display/MAVEN/MojoExecutionException
> {noformat}
> for a dependency:
> {noformat}
> [INFO] org.apache.maven.cli.event.ExecutionEventLogger - 
> 
> [ERROR] org.apache.maven.cli.MavenCli - Failed to execute goal 
> org.apache.maven.plugins:maven-site-plugin:4.0.0-M7-SNAPSHOT:site 
> (default-site) on project mskins-222: Failed to get report for 
> org.apache.maven.plugins:maven-project-plugin: Plugin 
> org.apache.maven.plugins:maven-project-plugin:3.4.2 or one of its 
> dependencies could not 

[jira] [Commented] (MNG-7758) o.e.aether.resolution.ArtifactResolutionException incorrectly examined when multiple repositories are involved

2024-06-10 Thread ASF GitHub Bot (Jira)


[ 
https://issues.apache.org/jira/browse/MNG-7758?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17853801#comment-17853801
 ] 

ASF GitHub Bot commented on MNG-7758:
-

slawekjaranowski commented on PR #1563:
URL: https://github.com/apache/maven/pull/1563#issuecomment-2159174820

   We have a different behavior for: `DependencyCollectionException` and 
   for `DependencyResolutionException`
   
   `DependencyResolutionException` has an list errors for all repositories but 
`DependencyCollectionException` has only one exception on list
   




> o.e.aether.resolution.ArtifactResolutionException incorrectly examined when 
> multiple repositories are involved
> --
>
> Key: MNG-7758
> URL: https://issues.apache.org/jira/browse/MNG-7758
> Project: Maven
>  Issue Type: Bug
>  Components: Artifacts and Repositories, Dependencies, Performance
>Affects Versions: 3.8.8, 3.9.1, 4.0.0-alpha-5
>Reporter: Michael Osipov
>Assignee: Slawomir Jaranowski
>Priority: Critical
> Fix For: 4.0.0, 3.9.8, 4.0.0-beta-4
>
> Attachments: 1.png, 2.png, Exception hierarchy.png
>
>
> Consider you have three repos defined in your build (could be POM or 
> settings), evaluated in following order:
> 1. repo A: serves custom artifacts with group id {{com.example}}, due to repo 
> partitioning in Nexus rejects requests to all other group ids with 403
> 1. repo B: serves third party artifacts without any restriction from a Nexus 
> repo
> 1. repo C: serves Central mirror, last one quried, no restrictions
> Note that order is important! Now add a non-existing dependency to your  POM 
> and receive the following behavior:
> {{ArtifactResolutionException}} will contain an {{ArtifactResult}} with three 
> exceptions: 
>  - {{TransferException}} with nested {{AuthorizationException}}, 
>  - {{ArtifactNotFoundException}}, 
>  - {{ArtifactNotFoundException}}. 
> {{ArtifactResolutionException#getCause()}} will be populated with the 
> {{TransferException}} so will 
> {{org.eclipse.aether.resolution.ArtifactResult.isMissing()}} take the first 
> exception only into account. E.g., {{DefaultArtifactDescriptorReader}} will 
> do {{if (e.getCause() instanceof ArtifactNotFoundException)}} which is 
> deceiving.
> Here is a sample for a non-existing artifact:
> {noformat}
> [INFO] --- maven-site-plugin:4.0.0-M7-SNAPSHOT:site (default-site) @ 
> mskins-222 ---
> [INFO] Configuring report plugin 
> org.apache.maven.plugins:maven-project-info-reports-plugin:3.4.2
> [WARNING] index report is declared twice in default reportSet
> [INFO] 15 reports configured for maven-project-info-reports-plugin:3.4.2: 
> index, summary, dependency-info, modules, team, scm, issue-management, 
> mailing-lists, dependency-management, dependencies, dependency-convergence, 
> ci-management, plugin-management, plugins, distribution-management
> [INFO] Rendering site for default locale
> Downloading from lda-public: 
> https://deblndw011x.ad001.siemens.net/nexus/content/groups/lda-public/org/apache/apache/29/apache-29-site.xml
> [INFO] 
> 
> [INFO] BUILD FAILURE
> [INFO] 
> 
> [INFO] Total time:  3.214 s
> [INFO] Finished at: 2023-04-02T12:51:02+02:00
> [INFO] 
> 
> [ERROR] Failed to execute goal 
> org.apache.maven.plugins:maven-site-plugin:4.0.0-M7-SNAPSHOT:site 
> (default-site) on project mskins-222: SiteToolException: The site descriptor 
> cannot be resolved from the repository: Unable to locate site descriptor: 
> Could not transfer artifact org.apache:apache:xml:site:29 from/to lda-public 
> (https://deblndw011x.ad001.siemens.net/nexus/content/groups/lda-public/): 
> authorization failed for 
> https://deblndw011x.ad001.siemens.net/nexus/content/groups/lda-public/org/apache/apache/29/apache-29-site.xml,
>  status: 403 Forbidden -> [Help 1]
> [ERROR]
> [ERROR] To see the full stack trace of the errors, re-run Maven with the -e 
> switch.
> [ERROR] Re-run Maven using the -X switch to enable full debug logging.
> [ERROR]
> [ERROR] For more information about the errors and possible solutions, please 
> read the following articles:
> [ERROR] [Help 1] 
> http://cwiki.apache.org/confluence/display/MAVEN/MojoExecutionException
> {noformat}
> for a dependency:
> {noformat}
> [INFO] org.apache.maven.cli.event.ExecutionEventLogger - 
> 
> [ERROR] org.apache.maven.cli.MavenCli - Failed to execute goal 
> org.apache.maven.plugins:maven-site-plugin:4.0.0-M7-SNAPSHOT:site 
> (default-site) on project mski

Re: [PR] [MNG-7758] Report dependency problems for all repository [maven]

2024-06-10 Thread via GitHub


slawekjaranowski commented on PR #1563:
URL: https://github.com/apache/maven/pull/1563#issuecomment-2159175900

   Please look at https://github.com/apache/maven-integration-testing/pull/348


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] [MNG-7758] Report dependency problems for all repository [maven]

2024-06-10 Thread via GitHub


slawekjaranowski commented on PR #1563:
URL: https://github.com/apache/maven/pull/1563#issuecomment-2159174820

   We have a different behavior for: `DependencyCollectionException` and 
   for `DependencyResolutionException`
   
   `DependencyResolutionException` has an list errors for all repositories but 
`DependencyCollectionException` has only one exception on list
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[jira] [Closed] (MNG-8153) Some classes from the Maven 3 API are missing

2024-06-10 Thread Guillaume Nodet (Jira)


 [ 
https://issues.apache.org/jira/browse/MNG-8153?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Guillaume Nodet closed MNG-8153.

Resolution: Fixed

> Some classes from the Maven 3 API are missing
> -
>
> Key: MNG-8153
> URL: https://issues.apache.org/jira/browse/MNG-8153
> Project: Maven
>  Issue Type: Improvement
>Affects Versions: 4.0.0-beta-3
>Reporter: Guillaume Nodet
>Assignee: Guillaume Nodet
>Priority: Major
> Fix For: 4.0.0-beta-4
>
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)


Re: [PR] [MNG-8153] Add back missing classes from the v3 api [maven]

2024-06-10 Thread via GitHub


gnodet merged PR #1577:
URL: https://github.com/apache/maven/pull/1577


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[jira] [Commented] (MNG-8153) Some classes from the Maven 3 API are missing

2024-06-10 Thread ASF GitHub Bot (Jira)


[ 
https://issues.apache.org/jira/browse/MNG-8153?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17853800#comment-17853800
 ] 

ASF GitHub Bot commented on MNG-8153:
-

gnodet merged PR #1577:
URL: https://github.com/apache/maven/pull/1577




> Some classes from the Maven 3 API are missing
> -
>
> Key: MNG-8153
> URL: https://issues.apache.org/jira/browse/MNG-8153
> Project: Maven
>  Issue Type: Improvement
>Affects Versions: 4.0.0-beta-3
>Reporter: Guillaume Nodet
>Assignee: Guillaume Nodet
>Priority: Major
> Fix For: 4.0.0-beta-4
>
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (MRESOLVER-569) DependencyCollectionException.getResult().getExceptions() always return one exec

2024-06-10 Thread Slawomir Jaranowski (Jira)


[ 
https://issues.apache.org/jira/browse/MRESOLVER-569?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17853798#comment-17853798
 ] 

Slawomir Jaranowski commented on MRESOLVER-569:
---

Examples https://github.com/apache/maven-integration-testing/pull/348 and 
https://github.com/apache/maven/pull/1563

> DependencyCollectionException.getResult().getExceptions() always return one 
> exec
> 
>
> Key: MRESOLVER-569
> URL: https://issues.apache.org/jira/browse/MRESOLVER-569
> Project: Maven Resolver
>  Issue Type: Bug
>Reporter: Slawomir Jaranowski
>Priority: Major
>
> The problem is when we have more then one repository in configuration.
> We see only exception from last one.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Created] (MRESOLVER-569) DependencyCollectionException.getResult().getExceptions() always return one exec

2024-06-10 Thread Slawomir Jaranowski (Jira)
Slawomir Jaranowski created MRESOLVER-569:
-

 Summary: DependencyCollectionException.getResult().getExceptions() 
always return one exec
 Key: MRESOLVER-569
 URL: https://issues.apache.org/jira/browse/MRESOLVER-569
 Project: Maven Resolver
  Issue Type: Bug
Reporter: Slawomir Jaranowski


The problem is when we have more then one repository in configuration.

We see only exception from last one.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[PR] [MNG-7758] Report dependency problems for all repository - extends ITs [maven-integration-testing]

2024-06-10 Thread via GitHub


slawekjaranowski opened a new pull request, #348:
URL: https://github.com/apache/maven-integration-testing/pull/348

   (no comment)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[PR] Bump org.codehaus.plexus:plexus-interpolation from 1.25 to 1.27 [maven-surefire]

2024-06-10 Thread via GitHub


dependabot[bot] opened a new pull request, #748:
URL: https://github.com/apache/maven-surefire/pull/748

   Bumps 
[org.codehaus.plexus:plexus-interpolation](https://github.com/codehaus-plexus/plexus-interpolation)
 from 1.25 to 1.27.
   
   Release notes
   Sourced from https://github.com/codehaus-plexus/plexus-interpolation/releases";>org.codehaus.plexus:plexus-interpolation's
 releases.
   
   1.27.0
   
   🚀 New features and improvements
   
   Added support for PPC64LE (https://redirect.github.com/codehaus-plexus/plexus-interpolation/pull/25";>#25)
 https://github.com/ezeeyahoo";>@​ezeeyahoo
   Add dependabot and release drafter configuration (https://redirect.github.com/codehaus-plexus/plexus-interpolation/pull/26";>#26)
 https://github.com/olamy";>@​olamy
   Move to Junit5 (https://redirect.github.com/codehaus-plexus/plexus-interpolation/pull/64";>#64)
 https://github.com/slachiewicz";>@​slachiewicz
   
   📦 Dependency updates
   
   Bump plexus from 7 to 16
   Bump maven-bundle-plugin from 3.0.1 to 5.1.9
   
   🔧 Build
   
   use shared gh action (https://redirect.github.com/codehaus-plexus/plexus-interpolation/pull/57";>#57)
 https://github.com/olamy";>@​olamy
   Reuse plexus-pom action for CI (https://redirect.github.com/codehaus-plexus/plexus-interpolation/pull/70";>#70)
 https://github.com/slachiewicz";>@​slachiewicz
   
   1.26
   What's Changed
   
   Fix https://redirect.github.com/codehaus-plexus/plexus-interpolation/issues/3";>#3
 : Filtering fails when target contains multiple escapes by https://github.com/belingueres";>@​belingueres in https://redirect.github.com/codehaus-plexus/plexus-interpolation/pull/7";>codehaus-plexus/plexus-interpolation#7
   Fix https://redirect.github.com/codehaus-plexus/plexus-interpolation/issues/6";>#6:
 Constructor InterpolatorFilterReader( Reader in, Interpolator… by https://github.com/belingueres";>@​belingueres in https://redirect.github.com/codehaus-plexus/plexus-interpolation/pull/9";>codehaus-plexus/plexus-interpolation#9
   Fix10 - RegexBasedInterpolatorTest fails when building with maven 
3.4.0-SNAPSHOT  by https://github.com/belingueres";>@​belingueres in https://redirect.github.com/codehaus-plexus/plexus-interpolation/pull/11";>codehaus-plexus/plexus-interpolation#11
   Speed optimization to avoid copying the string (through the StringBui… 
by https://github.com/gnodet";>@​gnodet in https://redirect.github.com/codehaus-plexus/plexus-interpolation/pull/23";>codehaus-plexus/plexus-interpolation#23
   
   New Contributors
   
   https://github.com/belingueres";>@​belingueres 
made their first contribution in https://redirect.github.com/codehaus-plexus/plexus-interpolation/pull/7";>codehaus-plexus/plexus-interpolation#7
   https://github.com/gnodet";>@​gnodet made their 
first contribution in https://redirect.github.com/codehaus-plexus/plexus-interpolation/pull/23";>codehaus-plexus/plexus-interpolation#23
   
   Full Changelog: https://github.com/codehaus-plexus/plexus-interpolation/commits/plexus-interpolation-1.26";>https://github.com/codehaus-plexus/plexus-interpolation/commits/plexus-interpolation-1.26
   
   
   
   Commits
   
   https://github.com/codehaus-plexus/plexus-interpolation/commit/f44266e74556c30fddcae4b20ee477e7e64a5204";>f44266e
 [maven-release-plugin] prepare release plexus-interpolation-1.27
   https://github.com/codehaus-plexus/plexus-interpolation/commit/10d6389ad22ac8db8ee7279407d10d64295dc9ec";>10d6389
 Bump org.codehaus.plexus:plexus from 15 to 16
   https://github.com/codehaus-plexus/plexus-interpolation/commit/88f5a941f5b2c6ce5c60ba7b7d2c93a725206807";>88f5a94
 Reuse plexus-pom action for CI
   https://github.com/codehaus-plexus/plexus-interpolation/commit/e980e6679d28afc3d0ccc067fb855ab1270ea97f";>e980e66
 Bump org.codehaus.plexus:plexus from 14 to 15
   https://github.com/codehaus-plexus/plexus-interpolation/commit/acb47031ead222f1bebb983d289907f97cbbe3c6";>acb4703
 Reformat code
   https://github.com/codehaus-plexus/plexus-interpolation/commit/df44d880bda41f5d428835597dd47c0b1f3b2ba5";>df44d88
 Bump org.codehaus.plexus:plexus from 11 to 14
   https://github.com/codehaus-plexus/plexus-interpolation/commit/22b9c9b64132deb3b002f3f68d6b2d9034fc0d0e";>22b9c9b
 Bump maven-bundle-plugin from 5.1.8 to 5.1.9
   https://github.com/codehaus-plexus/plexus-interpolation/commit/dad9f189b5c8782be76afaaa12b9c5a263cdcb95";>dad9f18
 Move to Junit5
   https://github.com/codehaus-plexus/plexus-interpolation/commit/f541b1aa9eda8a977967364e0b34b88d7a60dc73";>f541b1a
 Bump plexus from 10 to 11
   https://github.com/codehaus-plexus/plexus-interpolation/commit/a2b39e67f33060f50e6d68349e5577bc114eafed";>a2b39e6
 Bump maven-bundle-plugin from 5.1.7 to 5.1.8
   Additional commits viewable in https://github.com/codehaus-plexus/plexus-interpolation/compare/plexus-interpolation-1.25...plexus-interpolation-1.27";>compare
 view
   
   
   
   
   
   [![Dependabot compatibility 
score](https://dependabot-badges.githubapp.com/badges/compatibility_score?

[PR] Bump resolverVersion from 1.4.1 to 1.9.20 [maven-surefire]

2024-06-10 Thread via GitHub


dependabot[bot] opened a new pull request, #749:
URL: https://github.com/apache/maven-surefire/pull/749

   Bumps `resolverVersion` from 1.4.1 to 1.9.20.
   Updates `org.apache.maven.resolver:maven-resolver-api` from 1.4.1 to 1.9.20
   
   Release notes
   Sourced from https://github.com/apache/maven-resolver/releases";>org.apache.maven.resolver:maven-resolver-api's
 releases.
   
   1.9.20
   https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12320628&version=12354578";>Release
 Notes - Maven Resolver - Version 1.9.20
   
   
   
   What's Changed
   
   [MRESOLVER-547] Just use setVersion by https://github.com/cstamas";>@​cstamas in https://redirect.github.com/apache/maven-resolver/pull/483";>apache/maven-resolver#483
   [MRESOLVER-549] Parent POM 42 by https://github.com/cstamas";>@​cstamas in https://redirect.github.com/apache/maven-resolver/pull/484";>apache/maven-resolver#484
   
   Full Changelog: https://github.com/apache/maven-resolver/compare/maven-resolver-1.9.19...maven-resolver-1.9.20";>https://github.com/apache/maven-resolver/compare/maven-resolver-1.9.19...maven-resolver-1.9.20
   1.9.19
   https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12320628&version=12353946";>Release
 Notes - Maven Resolver - Version 1.9.19
   
   
   
   
   ... (truncated)
   
   
   Commits
   
   https://github.com/apache/maven-resolver/commit/f5fbc245e64091a41ba0926a6958b98bf0b29eb3";>f5fbc24
 [maven-release-plugin] prepare release maven-resolver-1.9.20
   https://github.com/apache/maven-resolver/commit/446009d7073014a7d418a4b9637664a2f6d05c82";>446009d
 [MRESOLVER-549][MRESOLVER-550][MRESOLVER-551] Parent POM 42 (https://redirect.github.com/apache/maven-resolver/issues/484";>#484)
   https://github.com/apache/maven-resolver/commit/4f16d5ecd94f85e6e7d793e6b6b82f20c9afbf56";>4f16d5e
 [MRESOLVER-547] Just use setVersion (https://redirect.github.com/apache/maven-resolver/issues/483";>#483)
   https://github.com/apache/maven-resolver/commit/c1b24c699621930f4eb77721400f2f6c46930626";>c1b24c6
 [maven-release-plugin] prepare for next development iteration
   https://github.com/apache/maven-resolver/commit/c1b03574961fd2daa7a678bb3fbf9f0779afee56";>c1b0357
 [maven-release-plugin] prepare release maven-resolver-1.9.19
   https://github.com/apache/maven-resolver/commit/adadd42d1642f39bafedb2ddd619b044fecb12b0";>adadd42
 [MRESOLVER-536] Do not belly up if FS does not support setting mtime (https://redirect.github.com/apache/maven-resolver/issues/469";>#469)
   https://github.com/apache/maven-resolver/commit/31df8a3dc503895172d277de56b1c4a53da0a27c";>31df8a3
 [1.9.x] Update dependencies (https://redirect.github.com/apache/maven-resolver/issues/462";>#462)
   https://github.com/apache/maven-resolver/commit/b225076e5d5b2fe3f166a4018802ac94b7cc94f7";>b225076
 [MRESOLVER-522] Improve congested file locks behaviour (https://redirect.github.com/apache/maven-resolver/issues/455";>#455) 
(https://redirect.github.com/apache/maven-resolver/issues/461";>#461)
   https://github.com/apache/maven-resolver/commit/fc969c2570041bb72c3f0141ff4957e8754f365c";>fc969c2
 [1.9.x][MRESOLVER-483] Fix path concatenation logic (https://redirect.github.com/apache/maven-resolver/issues/420";>#420)
   https://github.com/apache/maven-resolver/commit/a3e620d6d2ab6ca58d42d264347341b31da00dde";>a3e620d
 Use one Maven in CI
   Additional commits viewable in https://github.com/apache/maven-resolver/compare/maven-resolver-1.4.1...maven-resolver-1.9.20";>compare
 view
   
   
   
   
   Updates `org.apache.maven.resolver:maven-resolver-util` from 1.4.1 to 1.9.20
   
   Release notes
   Sourced from https://github.com/apache/maven-resolver/releases";>org.apache.maven.resolver:maven-resolver-util's
 releases.
   
   1.9.20
   https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12320628&version=12354578";>Release
 Notes - Maven Resolver - Version 1.9.20
   
   
   
   What's Changed
   
   [MRESOLVER-547] Just use setVersion by https://github.com/cstamas";>@​cstamas in https://redirect.github.com/apache/maven-resolver/pull/483";>apache/maven-resolver#483
   [MRESOLVER-549] Parent POM 42 by https://github.com/cstamas";>@​cstamas in https://redirect.github.com/apache/maven-resolver/pull/484";>apache/maven-resolver#484
   
   Full Changelog: https://github.com/apache/maven-resolver/compare/maven-resolver-1.9.19...maven-resolver-1.9.20";>https://github.com/apache/maven-resolver/compare/maven-resolver-1.9.19...maven-resolver-1.9.20
   1.9.19
   https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12320628&version=12353946";>Release
 Notes - Maven Resolver - Version 1.9.19
   
   
   
   
   ... (truncated)
   
   
   Commits
   
   https://github.com/apache/maven-resolver/commit/f5fbc245e64091a41ba0926a6958b98bf0b29eb3";>f5fbc24
 [maven-release-plugin] prepare release maven-resolver-1.9.20
   https://github.com/apache/maven-resolver/commit/446009d7073014a7d418a4b9637664a2f6d05c82";>446009d
 [MRESOLVER-549][MRESOLV

[PR] Bump org.codehaus.plexus:plexus-component-annotations from 2.1.0 to 2.2.0 [maven-surefire]

2024-06-10 Thread via GitHub


dependabot[bot] opened a new pull request, #747:
URL: https://github.com/apache/maven-surefire/pull/747

   Bumps 
[org.codehaus.plexus:plexus-component-annotations](https://github.com/codehaus-plexus/plexus-containers)
 from 2.1.0 to 2.2.0.
   
   Release notes
   Sourced from https://github.com/codehaus-plexus/plexus-containers/releases";>org.codehaus.plexus:plexus-component-annotations's
 releases.
   
   2.2.0
   
   
   improve documentation to switch to Sisu (https://redirect.github.com/codehaus-plexus/plexus-containers/pull/121";>#121)
 https://github.com/hboutemy";>@​hboutemy
   pom clean after parent upgrade (https://redirect.github.com/codehaus-plexus/plexus-containers/pull/120";>#120)
 https://github.com/hboutemy";>@​hboutemy
   Improve plexus-component metadata - remove dependency to 
plexus-container-default (https://redirect.github.com/codehaus-plexus/plexus-containers/pull/109";>#109)
 https://github.com/slachiewicz";>@​slachiewicz
   Add deprecation information to Plexus components (https://redirect.github.com/codehaus-plexus/plexus-containers/pull/108";>#108)
 https://github.com/slachiewicz";>@​slachiewicz
   Require Java 8 (https://redirect.github.com/codehaus-plexus/plexus-containers/pull/107";>#107)
 https://github.com/slachiewicz";>@​slachiewicz
   Drop plexus-container-default artefact (https://redirect.github.com/codehaus-plexus/plexus-containers/pull/135";>#135)
 https://github.com/slachiewicz";>@​slachiewicz
   Require Maven 3.6.3+ (https://redirect.github.com/codehaus-plexus/plexus-containers/pull/133";>#133)
 https://github.com/slachiewicz";>@​slachiewicz
   Switch to JUnit5 (https://redirect.github.com/codehaus-plexus/plexus-containers/pull/134";>#134)
 https://github.com/slachiewicz";>@​slachiewicz
   Bump org.eclipse.sisu.plexus from 0.3.0.M1 to 0.9.0.M2 (https://redirect.github.com/codehaus-plexus/plexus-containers/pull/113";>#113)
 https://github.com/dependabot";>@​dependabot
   
   📦 Dependency updates
   
   Bump org.codehaus.plexus:plexus-testing from 1.2.0 to 1.3.0 (https://redirect.github.com/codehaus-plexus/plexus-containers/pull/139";>#139)
 https://github.com/dependabot";>@​dependabot
   Bump org.codehaus.plexus:plexus from 15 to 16 (https://redirect.github.com/codehaus-plexus/plexus-containers/pull/138";>#138)
 https://github.com/dependabot";>@​dependabot
   Bump org.apache.xbean:xbean-reflect from 4.23 to 4.24 (https://redirect.github.com/codehaus-plexus/plexus-containers/pull/131";>#131)
 https://github.com/dependabot";>@​dependabot
   Reorg dependencyManagement to subprojects. Prepare to drop 
plexus-container-default (https://redirect.github.com/codehaus-plexus/plexus-containers/pull/132";>#132)
 https://github.com/slachiewicz";>@​slachiewicz
   Bump org.ow2.asm:asm from 9.5 to 9.6 (https://redirect.github.com/codehaus-plexus/plexus-containers/pull/129";>#129)
 https://github.com/dependabot";>@​dependabot
   Bump maven-invoker-plugin from 3.5.1 to 3.6.0 (https://redirect.github.com/codehaus-plexus/plexus-containers/pull/125";>#125)
 https://github.com/dependabot";>@​dependabot
   Bump xbean-reflect from 4.22 to 4.23 (https://redirect.github.com/codehaus-plexus/plexus-containers/pull/116";>#116)
 https://github.com/dependabot";>@​dependabot
   Bump maven-plugin-annotations from 3.8.1 to 3.8.2 (https://redirect.github.com/codehaus-plexus/plexus-containers/pull/104";>#104)
 https://github.com/dependabot";>@​dependabot
   Bump maven-plugin-plugin from 3.8.1 to 3.8.2 (https://redirect.github.com/codehaus-plexus/plexus-containers/pull/105";>#105)
 https://github.com/dependabot";>@​dependabot
   Bump maven-project-info-reports-plugin from 3.4.2 to 3.4.3 (https://redirect.github.com/codehaus-plexus/plexus-containers/pull/102";>#102)
 https://github.com/dependabot";>@​dependabot
   Bump asm from 9.4 to 9.5 (https://redirect.github.com/codehaus-plexus/plexus-containers/pull/99";>#99)
 https://github.com/dependabot";>@​dependabot
   Bump plexus-utils from 3.5.0 to 3.5.1 (https://redirect.github.com/codehaus-plexus/plexus-containers/pull/97";>#97)
 https://github.com/dependabot";>@​dependabot
   Bump checkstyle from 9.2 to 9.3 (https://redirect.github.com/codehaus-plexus/plexus-containers/pull/96";>#96)
 https://github.com/dependabot";>@​dependabot
   Bump maven-plugin-plugin from 3.7.1 to 3.8.1 (https://redirect.github.com/codehaus-plexus/plexus-containers/pull/92";>#92)
 https://github.com/dependabot";>@​dependabot
   Bump maven-plugin-annotations from 3.7.1 to 3.8.1 (https://redirect.github.com/codehaus-plexus/plexus-containers/pull/93";>#93)
 https://github.com/dependabot";>@​dependabot
   Bump asm from 9.3 to 9.4 (https://redirect.github.com/codehaus-plexus/plexus-containers/pull/88";>#88)
 https://github.com/dependabot";>@​dependabot
   Bump maven-project-info-reports-plugin from 3.4.1 to 3.4.2 (https://redirect.github.com/codehaus-plexus/plexus-containers/pull/85";>#85)
 https://github.com/dependabot";>@​dependabot
   Bump maven-plugin-plugin from 3.7.0 to 3.7.1 (h

[jira] [Commented] (MNG-8153) Some classes from the Maven 3 API are missing

2024-06-10 Thread ASF GitHub Bot (Jira)


[ 
https://issues.apache.org/jira/browse/MNG-8153?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17853776#comment-17853776
 ] 

ASF GitHub Bot commented on MNG-8153:
-

gnodet commented on PR #1577:
URL: https://github.com/apache/maven/pull/1577#issuecomment-2159053604

   > When did these classes become "gone"?
   
   I bisected it to 
https://github.com/apache/maven/commit/23bca281fcd084ac21d80f5a2950dcee30a19080




> Some classes from the Maven 3 API are missing
> -
>
> Key: MNG-8153
> URL: https://issues.apache.org/jira/browse/MNG-8153
> Project: Maven
>  Issue Type: Improvement
>Affects Versions: 4.0.0-beta-3
>Reporter: Guillaume Nodet
>Assignee: Guillaume Nodet
>Priority: Major
> Fix For: 4.0.0-beta-4
>
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)


Re: [PR] [MNG-8153] Add back missing classes from the v3 api [maven]

2024-06-10 Thread via GitHub


gnodet commented on PR #1577:
URL: https://github.com/apache/maven/pull/1577#issuecomment-2159053604

   > When did these classes become "gone"?
   
   I bisected it to 
https://github.com/apache/maven/commit/23bca281fcd084ac21d80f5a2950dcee30a19080


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[jira] [Updated] (MRESOLVER-564) Align with Maven4 beta-3

2024-06-10 Thread Tamas Cservenak (Jira)


 [ 
https://issues.apache.org/jira/browse/MRESOLVER-564?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Tamas Cservenak updated MRESOLVER-564:
--
Component/s: Resolver

> Align with Maven4 beta-3
> 
>
> Key: MRESOLVER-564
> URL: https://issues.apache.org/jira/browse/MRESOLVER-564
> Project: Maven Resolver
>  Issue Type: Dependency upgrade
>  Components: Resolver
>Reporter: Tamas Cservenak
>Assignee: Tamas Cservenak
>Priority: Major
> Fix For: 2.0.0, 2.0.0-beta-1
>
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Updated] (MRESOLVER-564) Align with Maven4 beta-3

2024-06-10 Thread Tamas Cservenak (Jira)


 [ 
https://issues.apache.org/jira/browse/MRESOLVER-564?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Tamas Cservenak updated MRESOLVER-564:
--
Component/s: (was: re)

> Align with Maven4 beta-3
> 
>
> Key: MRESOLVER-564
> URL: https://issues.apache.org/jira/browse/MRESOLVER-564
> Project: Maven Resolver
>  Issue Type: Dependency upgrade
>  Components: Resolver
>Reporter: Tamas Cservenak
>Assignee: Tamas Cservenak
>Priority: Major
> Fix For: 2.0.0, 2.0.0-beta-1
>
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Updated] (MRESOLVER-563) Bump org.codehaus.plexus:plexus-xml from 4.0.3 to 4.0.4

2024-06-10 Thread Tamas Cservenak (Jira)


 [ 
https://issues.apache.org/jira/browse/MRESOLVER-563?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Tamas Cservenak updated MRESOLVER-563:
--
Component/s: Resolver

> Bump org.codehaus.plexus:plexus-xml from 4.0.3 to 4.0.4
> ---
>
> Key: MRESOLVER-563
> URL: https://issues.apache.org/jira/browse/MRESOLVER-563
> Project: Maven Resolver
>  Issue Type: Dependency upgrade
>  Components: Resolver
>Reporter: Tamas Cservenak
>Assignee: Tamas Cservenak
>Priority: Major
> Fix For: 2.0.0, 2.0.0-beta-1
>
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Updated] (MRESOLVER-564) Align with Maven4 beta-3

2024-06-10 Thread Tamas Cservenak (Jira)


 [ 
https://issues.apache.org/jira/browse/MRESOLVER-564?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Tamas Cservenak updated MRESOLVER-564:
--
Component/s: re

> Align with Maven4 beta-3
> 
>
> Key: MRESOLVER-564
> URL: https://issues.apache.org/jira/browse/MRESOLVER-564
> Project: Maven Resolver
>  Issue Type: Dependency upgrade
>  Components: re, Resolver
>Reporter: Tamas Cservenak
>Assignee: Tamas Cservenak
>Priority: Major
> Fix For: 2.0.0, 2.0.0-beta-1
>
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Updated] (MRESOLVER-566) Bump sisuVersion from 0.9.0.M2 to 0.9.0.M3

2024-06-10 Thread Tamas Cservenak (Jira)


 [ 
https://issues.apache.org/jira/browse/MRESOLVER-566?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Tamas Cservenak updated MRESOLVER-566:
--
Component/s: Resolver

> Bump sisuVersion from 0.9.0.M2 to 0.9.0.M3
> --
>
> Key: MRESOLVER-566
> URL: https://issues.apache.org/jira/browse/MRESOLVER-566
> Project: Maven Resolver
>  Issue Type: Dependency upgrade
>  Components: Resolver
>Reporter: Tamas Cservenak
>Assignee: Tamas Cservenak
>Priority: Major
> Fix For: 2.0.0, 2.0.0-beta-1
>
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Updated] (MRESOLVER-568) Bump org.apache.commons:commons-compress from 1.26.1 to 1.26.2

2024-06-10 Thread Tamas Cservenak (Jira)


 [ 
https://issues.apache.org/jira/browse/MRESOLVER-568?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Tamas Cservenak updated MRESOLVER-568:
--
Component/s: Resolver

> Bump org.apache.commons:commons-compress from 1.26.1 to 1.26.2
> --
>
> Key: MRESOLVER-568
> URL: https://issues.apache.org/jira/browse/MRESOLVER-568
> Project: Maven Resolver
>  Issue Type: Dependency upgrade
>  Components: Resolver
>Reporter: Tamas Cservenak
>Assignee: Tamas Cservenak
>Priority: Major
> Fix For: 2.0.0, 2.0.0-beta-1
>
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Updated] (MRESOLVER-562) Bump org.codehaus.mojo:exec-maven-plugin from 3.2.0 to 3.3.0

2024-06-10 Thread Tamas Cservenak (Jira)


 [ 
https://issues.apache.org/jira/browse/MRESOLVER-562?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Tamas Cservenak updated MRESOLVER-562:
--
Component/s: Resolver

> Bump org.codehaus.mojo:exec-maven-plugin from 3.2.0 to 3.3.0
> 
>
> Key: MRESOLVER-562
> URL: https://issues.apache.org/jira/browse/MRESOLVER-562
> Project: Maven Resolver
>  Issue Type: Dependency upgrade
>  Components: Resolver
>Reporter: Tamas Cservenak
>Assignee: Tamas Cservenak
>Priority: Major
> Fix For: 2.0.0, 2.0.0-beta-1
>
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Updated] (MRESOLVER-567) Bump org.redisson:redisson from 3.30.0 to 3.31.0

2024-06-10 Thread Tamas Cservenak (Jira)


 [ 
https://issues.apache.org/jira/browse/MRESOLVER-567?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Tamas Cservenak updated MRESOLVER-567:
--
Component/s: Resolver

> Bump org.redisson:redisson from 3.30.0 to 3.31.0
> 
>
> Key: MRESOLVER-567
> URL: https://issues.apache.org/jira/browse/MRESOLVER-567
> Project: Maven Resolver
>  Issue Type: Dependency upgrade
>  Components: Resolver
>Reporter: Tamas Cservenak
>Assignee: Tamas Cservenak
>Priority: Major
> Fix For: 2.0.0, 2.0.0-beta-1
>
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Assigned] (MRESOLVER-566) Bump sisuVersion from 0.9.0.M2 to 0.9.0.M3

2024-06-10 Thread Tamas Cservenak (Jira)


 [ 
https://issues.apache.org/jira/browse/MRESOLVER-566?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Tamas Cservenak reassigned MRESOLVER-566:
-

Assignee: Tamas Cservenak

> Bump sisuVersion from 0.9.0.M2 to 0.9.0.M3
> --
>
> Key: MRESOLVER-566
> URL: https://issues.apache.org/jira/browse/MRESOLVER-566
> Project: Maven Resolver
>  Issue Type: Dependency upgrade
>Reporter: Tamas Cservenak
>Assignee: Tamas Cservenak
>Priority: Major
> Fix For: 2.0.0, 2.0.0-beta-1
>
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Assigned] (MRESOLVER-568) Bump org.apache.commons:commons-compress from 1.26.1 to 1.26.2

2024-06-10 Thread Tamas Cservenak (Jira)


 [ 
https://issues.apache.org/jira/browse/MRESOLVER-568?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Tamas Cservenak reassigned MRESOLVER-568:
-

Assignee: Tamas Cservenak

> Bump org.apache.commons:commons-compress from 1.26.1 to 1.26.2
> --
>
> Key: MRESOLVER-568
> URL: https://issues.apache.org/jira/browse/MRESOLVER-568
> Project: Maven Resolver
>  Issue Type: Dependency upgrade
>Reporter: Tamas Cservenak
>Assignee: Tamas Cservenak
>Priority: Major
> Fix For: 2.0.0, 2.0.0-beta-1
>
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Closed] (MRESOLVER-567) Bump org.redisson:redisson from 3.30.0 to 3.31.0

2024-06-10 Thread Tamas Cservenak (Jira)


 [ 
https://issues.apache.org/jira/browse/MRESOLVER-567?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Tamas Cservenak closed MRESOLVER-567.
-
Resolution: Fixed

> Bump org.redisson:redisson from 3.30.0 to 3.31.0
> 
>
> Key: MRESOLVER-567
> URL: https://issues.apache.org/jira/browse/MRESOLVER-567
> Project: Maven Resolver
>  Issue Type: Dependency upgrade
>Reporter: Tamas Cservenak
>Assignee: Tamas Cservenak
>Priority: Major
> Fix For: 2.0.0, 2.0.0-beta-1
>
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Closed] (MRESOLVER-568) Bump org.apache.commons:commons-compress from 1.26.1 to 1.26.2

2024-06-10 Thread Tamas Cservenak (Jira)


 [ 
https://issues.apache.org/jira/browse/MRESOLVER-568?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Tamas Cservenak closed MRESOLVER-568.
-
Resolution: Fixed

> Bump org.apache.commons:commons-compress from 1.26.1 to 1.26.2
> --
>
> Key: MRESOLVER-568
> URL: https://issues.apache.org/jira/browse/MRESOLVER-568
> Project: Maven Resolver
>  Issue Type: Dependency upgrade
>Reporter: Tamas Cservenak
>Assignee: Tamas Cservenak
>Priority: Major
> Fix For: 2.0.0, 2.0.0-beta-1
>
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Assigned] (MRESOLVER-567) Bump org.redisson:redisson from 3.30.0 to 3.31.0

2024-06-10 Thread Tamas Cservenak (Jira)


 [ 
https://issues.apache.org/jira/browse/MRESOLVER-567?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Tamas Cservenak reassigned MRESOLVER-567:
-

Assignee: Tamas Cservenak

> Bump org.redisson:redisson from 3.30.0 to 3.31.0
> 
>
> Key: MRESOLVER-567
> URL: https://issues.apache.org/jira/browse/MRESOLVER-567
> Project: Maven Resolver
>  Issue Type: Dependency upgrade
>Reporter: Tamas Cservenak
>Assignee: Tamas Cservenak
>Priority: Major
> Fix For: 2.0.0, 2.0.0-beta-1
>
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)


Re: [PR] Bump org.apache.commons:commons-compress from 1.26.1 to 1.26.2 [maven-resolver]

2024-06-10 Thread via GitHub


cstamas merged PR #499:
URL: https://github.com/apache/maven-resolver/pull/499


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[jira] [Created] (MRESOLVER-568) Bump org.apache.commons:commons-compress from 1.26.1 to 1.26.2

2024-06-10 Thread Tamas Cservenak (Jira)
Tamas Cservenak created MRESOLVER-568:
-

 Summary: Bump org.apache.commons:commons-compress from 1.26.1 to 
1.26.2
 Key: MRESOLVER-568
 URL: https://issues.apache.org/jira/browse/MRESOLVER-568
 Project: Maven Resolver
  Issue Type: Dependency upgrade
Reporter: Tamas Cservenak
 Fix For: 2.0.0, 2.0.0-beta-1






--
This message was sent by Atlassian Jira
(v8.20.10#820010)


Re: [PR] Bump org.redisson:redisson from 3.30.0 to 3.31.0 [maven-resolver]

2024-06-10 Thread via GitHub


cstamas merged PR #501:
URL: https://github.com/apache/maven-resolver/pull/501


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[jira] [Created] (MRESOLVER-567) Bump org.redisson:redisson from 3.30.0 to 3.31.0

2024-06-10 Thread Tamas Cservenak (Jira)
Tamas Cservenak created MRESOLVER-567:
-

 Summary: Bump org.redisson:redisson from 3.30.0 to 3.31.0
 Key: MRESOLVER-567
 URL: https://issues.apache.org/jira/browse/MRESOLVER-567
 Project: Maven Resolver
  Issue Type: Dependency upgrade
Reporter: Tamas Cservenak
 Fix For: 2.0.0, 2.0.0-beta-1






--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Closed] (MRESOLVER-566) Bump sisuVersion from 0.9.0.M2 to 0.9.0.M3

2024-06-10 Thread Tamas Cservenak (Jira)


 [ 
https://issues.apache.org/jira/browse/MRESOLVER-566?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Tamas Cservenak closed MRESOLVER-566.
-
Resolution: Fixed

> Bump sisuVersion from 0.9.0.M2 to 0.9.0.M3
> --
>
> Key: MRESOLVER-566
> URL: https://issues.apache.org/jira/browse/MRESOLVER-566
> Project: Maven Resolver
>  Issue Type: Dependency upgrade
>Reporter: Tamas Cservenak
>Priority: Major
> Fix For: 2.0.0, 2.0.0-beta-1
>
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Created] (MRESOLVER-566) Bump sisuVersion from 0.9.0.M2 to 0.9.0.M3

2024-06-10 Thread Tamas Cservenak (Jira)
Tamas Cservenak created MRESOLVER-566:
-

 Summary: Bump sisuVersion from 0.9.0.M2 to 0.9.0.M3
 Key: MRESOLVER-566
 URL: https://issues.apache.org/jira/browse/MRESOLVER-566
 Project: Maven Resolver
  Issue Type: Dependency upgrade
Reporter: Tamas Cservenak
 Fix For: 2.0.0, 2.0.0-beta-1






--
This message was sent by Atlassian Jira
(v8.20.10#820010)


Re: [PR] Bump sisuVersion from 0.9.0.M2 to 0.9.0.M3 [maven-resolver]

2024-06-10 Thread via GitHub


cstamas merged PR #502:
URL: https://github.com/apache/maven-resolver/pull/502


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[jira] [Commented] (MNG-8134) Provide an annotation that can be used to inject dependencies resolution/collection in mojos

2024-06-10 Thread ASF GitHub Bot (Jira)


[ 
https://issues.apache.org/jira/browse/MNG-8134?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17853766#comment-17853766
 ] 

ASF GitHub Bot commented on MNG-8134:
-

rmannibucau commented on PR #1559:
URL: https://github.com/apache/maven/pull/1559#issuecomment-2158999624

   >  the benefit of having it statically defined (so that we can compute 
exactly what is needed in advance)
   
   I'm not sure I get it, this should be 1-1 with the programmatic flavor IMHO 
so either it is cached in the impl and it is always computed in advanced 
somehow - or there is no pitfall computing it lazily more exactly -  or it will 
be wrong if computed in advanced and a mojo modifies the current scope for next 
mojo :thinking: 
   
   I assume - but not sure at all - you speak about adding more concurrency or 
something like that but I'm not sure we can do it more than the resolution 
requested by the mojo itself - which needs to move to a list of custom string I 
guess now.




> Provide an annotation that can be used to inject dependencies 
> resolution/collection in mojos
> 
>
> Key: MNG-8134
> URL: https://issues.apache.org/jira/browse/MNG-8134
> Project: Maven
>  Issue Type: Task
>Reporter: Guillaume Nodet
>Priority: Major
> Fix For: 4.0.0
>
>
> See 
> https://github.com/apache/maven-plugin-tools/pull/286#discussion_r1620871349



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


Re: [PR] [MNG-8134] Add a @Resolution annotation to mojos to inject project dependencies collection / resolution result [maven]

2024-06-10 Thread via GitHub


rmannibucau commented on PR #1559:
URL: https://github.com/apache/maven/pull/1559#issuecomment-2158999624

   >  the benefit of having it statically defined (so that we can compute 
exactly what is needed in advance)
   
   I'm not sure I get it, this should be 1-1 with the programmatic flavor IMHO 
so either it is cached in the impl and it is always computed in advanced 
somehow - or there is no pitfall computing it lazily more exactly -  or it will 
be wrong if computed in advanced and a mojo modifies the current scope for next 
mojo :thinking: 
   
   I assume - but not sure at all - you speak about adding more concurrency or 
something like that but I'm not sure we can do it more than the resolution 
requested by the mojo itself - which needs to move to a list of custom string I 
guess now.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] [MNG-7758] Report dependency problems for all repository [maven]

2024-06-10 Thread via GitHub


michael-o commented on PR #1563:
URL: https://github.com/apache/maven/pull/1563#issuecomment-2158993026

   > See 
https://github.com/apache/maven-resolver/blob/master/maven-resolver-spi/src/main/java/org/eclipse/aether/spi/connector/transport/Transporter.java#L37-L51
   > 
   > Resolver "knows" 404 and "everything else" (like 403)
   
   403 is not an authentication problem, but solely authorization: 
https://www.rfc-editor.org/rfc/rfc9110#status.403
   
   Unfornately, I cannot configure Nexus to send 404 in this case which would 
be better for Nexus.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[jira] [Commented] (MNG-7758) o.e.aether.resolution.ArtifactResolutionException incorrectly examined when multiple repositories are involved

2024-06-10 Thread ASF GitHub Bot (Jira)


[ 
https://issues.apache.org/jira/browse/MNG-7758?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17853765#comment-17853765
 ] 

ASF GitHub Bot commented on MNG-7758:
-

michael-o commented on PR #1563:
URL: https://github.com/apache/maven/pull/1563#issuecomment-2158993026

   > See 
https://github.com/apache/maven-resolver/blob/master/maven-resolver-spi/src/main/java/org/eclipse/aether/spi/connector/transport/Transporter.java#L37-L51
   > 
   > Resolver "knows" 404 and "everything else" (like 403)
   
   403 is not an authentication problem, but solely authorization: 
https://www.rfc-editor.org/rfc/rfc9110#status.403
   
   Unfornately, I cannot configure Nexus to send 404 in this case which would 
be better for Nexus.




> o.e.aether.resolution.ArtifactResolutionException incorrectly examined when 
> multiple repositories are involved
> --
>
> Key: MNG-7758
> URL: https://issues.apache.org/jira/browse/MNG-7758
> Project: Maven
>  Issue Type: Bug
>  Components: Artifacts and Repositories, Dependencies, Performance
>Affects Versions: 3.8.8, 3.9.1, 4.0.0-alpha-5
>Reporter: Michael Osipov
>Assignee: Slawomir Jaranowski
>Priority: Critical
> Fix For: 4.0.0, 3.9.8, 4.0.0-beta-4
>
> Attachments: 1.png, 2.png, Exception hierarchy.png
>
>
> Consider you have three repos defined in your build (could be POM or 
> settings), evaluated in following order:
> 1. repo A: serves custom artifacts with group id {{com.example}}, due to repo 
> partitioning in Nexus rejects requests to all other group ids with 403
> 1. repo B: serves third party artifacts without any restriction from a Nexus 
> repo
> 1. repo C: serves Central mirror, last one quried, no restrictions
> Note that order is important! Now add a non-existing dependency to your  POM 
> and receive the following behavior:
> {{ArtifactResolutionException}} will contain an {{ArtifactResult}} with three 
> exceptions: 
>  - {{TransferException}} with nested {{AuthorizationException}}, 
>  - {{ArtifactNotFoundException}}, 
>  - {{ArtifactNotFoundException}}. 
> {{ArtifactResolutionException#getCause()}} will be populated with the 
> {{TransferException}} so will 
> {{org.eclipse.aether.resolution.ArtifactResult.isMissing()}} take the first 
> exception only into account. E.g., {{DefaultArtifactDescriptorReader}} will 
> do {{if (e.getCause() instanceof ArtifactNotFoundException)}} which is 
> deceiving.
> Here is a sample for a non-existing artifact:
> {noformat}
> [INFO] --- maven-site-plugin:4.0.0-M7-SNAPSHOT:site (default-site) @ 
> mskins-222 ---
> [INFO] Configuring report plugin 
> org.apache.maven.plugins:maven-project-info-reports-plugin:3.4.2
> [WARNING] index report is declared twice in default reportSet
> [INFO] 15 reports configured for maven-project-info-reports-plugin:3.4.2: 
> index, summary, dependency-info, modules, team, scm, issue-management, 
> mailing-lists, dependency-management, dependencies, dependency-convergence, 
> ci-management, plugin-management, plugins, distribution-management
> [INFO] Rendering site for default locale
> Downloading from lda-public: 
> https://deblndw011x.ad001.siemens.net/nexus/content/groups/lda-public/org/apache/apache/29/apache-29-site.xml
> [INFO] 
> 
> [INFO] BUILD FAILURE
> [INFO] 
> 
> [INFO] Total time:  3.214 s
> [INFO] Finished at: 2023-04-02T12:51:02+02:00
> [INFO] 
> 
> [ERROR] Failed to execute goal 
> org.apache.maven.plugins:maven-site-plugin:4.0.0-M7-SNAPSHOT:site 
> (default-site) on project mskins-222: SiteToolException: The site descriptor 
> cannot be resolved from the repository: Unable to locate site descriptor: 
> Could not transfer artifact org.apache:apache:xml:site:29 from/to lda-public 
> (https://deblndw011x.ad001.siemens.net/nexus/content/groups/lda-public/): 
> authorization failed for 
> https://deblndw011x.ad001.siemens.net/nexus/content/groups/lda-public/org/apache/apache/29/apache-29-site.xml,
>  status: 403 Forbidden -> [Help 1]
> [ERROR]
> [ERROR] To see the full stack trace of the errors, re-run Maven with the -e 
> switch.
> [ERROR] Re-run Maven using the -X switch to enable full debug logging.
> [ERROR]
> [ERROR] For more information about the errors and possible solutions, please 
> read the following articles:
> [ERROR] [Help 1] 
> http://cwiki.apache.org/confluence/display/MAVEN/MojoExecutionException
> {noformat}
> for a dependency:
> {noformat}
> [INFO] org.apache.maven.cli.event.ExecutionEventLogger - 
> 

Re: [PR] [MNG-7758] Report dependency problems for all repository [maven]

2024-06-10 Thread via GitHub


cstamas commented on PR #1563:
URL: https://github.com/apache/maven/pull/1563#issuecomment-2158984627

   See 
https://github.com/apache/maven-resolver/blob/master/maven-resolver-spi/src/main/java/org/eclipse/aether/spi/connector/transport/Transporter.java#L37-L51
   
   Resolver "knows" 404 and "everything else" (like 403)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[jira] [Commented] (MNG-7758) o.e.aether.resolution.ArtifactResolutionException incorrectly examined when multiple repositories are involved

2024-06-10 Thread ASF GitHub Bot (Jira)


[ 
https://issues.apache.org/jira/browse/MNG-7758?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17853763#comment-17853763
 ] 

ASF GitHub Bot commented on MNG-7758:
-

cstamas commented on PR #1563:
URL: https://github.com/apache/maven/pull/1563#issuecomment-2158984627

   See 
https://github.com/apache/maven-resolver/blob/master/maven-resolver-spi/src/main/java/org/eclipse/aether/spi/connector/transport/Transporter.java#L37-L51
   
   Resolver "knows" 404 and "everything else" (like 403)




> o.e.aether.resolution.ArtifactResolutionException incorrectly examined when 
> multiple repositories are involved
> --
>
> Key: MNG-7758
> URL: https://issues.apache.org/jira/browse/MNG-7758
> Project: Maven
>  Issue Type: Bug
>  Components: Artifacts and Repositories, Dependencies, Performance
>Affects Versions: 3.8.8, 3.9.1, 4.0.0-alpha-5
>Reporter: Michael Osipov
>Assignee: Slawomir Jaranowski
>Priority: Critical
> Fix For: 4.0.0, 3.9.8, 4.0.0-beta-4
>
> Attachments: 1.png, 2.png, Exception hierarchy.png
>
>
> Consider you have three repos defined in your build (could be POM or 
> settings), evaluated in following order:
> 1. repo A: serves custom artifacts with group id {{com.example}}, due to repo 
> partitioning in Nexus rejects requests to all other group ids with 403
> 1. repo B: serves third party artifacts without any restriction from a Nexus 
> repo
> 1. repo C: serves Central mirror, last one quried, no restrictions
> Note that order is important! Now add a non-existing dependency to your  POM 
> and receive the following behavior:
> {{ArtifactResolutionException}} will contain an {{ArtifactResult}} with three 
> exceptions: 
>  - {{TransferException}} with nested {{AuthorizationException}}, 
>  - {{ArtifactNotFoundException}}, 
>  - {{ArtifactNotFoundException}}. 
> {{ArtifactResolutionException#getCause()}} will be populated with the 
> {{TransferException}} so will 
> {{org.eclipse.aether.resolution.ArtifactResult.isMissing()}} take the first 
> exception only into account. E.g., {{DefaultArtifactDescriptorReader}} will 
> do {{if (e.getCause() instanceof ArtifactNotFoundException)}} which is 
> deceiving.
> Here is a sample for a non-existing artifact:
> {noformat}
> [INFO] --- maven-site-plugin:4.0.0-M7-SNAPSHOT:site (default-site) @ 
> mskins-222 ---
> [INFO] Configuring report plugin 
> org.apache.maven.plugins:maven-project-info-reports-plugin:3.4.2
> [WARNING] index report is declared twice in default reportSet
> [INFO] 15 reports configured for maven-project-info-reports-plugin:3.4.2: 
> index, summary, dependency-info, modules, team, scm, issue-management, 
> mailing-lists, dependency-management, dependencies, dependency-convergence, 
> ci-management, plugin-management, plugins, distribution-management
> [INFO] Rendering site for default locale
> Downloading from lda-public: 
> https://deblndw011x.ad001.siemens.net/nexus/content/groups/lda-public/org/apache/apache/29/apache-29-site.xml
> [INFO] 
> 
> [INFO] BUILD FAILURE
> [INFO] 
> 
> [INFO] Total time:  3.214 s
> [INFO] Finished at: 2023-04-02T12:51:02+02:00
> [INFO] 
> 
> [ERROR] Failed to execute goal 
> org.apache.maven.plugins:maven-site-plugin:4.0.0-M7-SNAPSHOT:site 
> (default-site) on project mskins-222: SiteToolException: The site descriptor 
> cannot be resolved from the repository: Unable to locate site descriptor: 
> Could not transfer artifact org.apache:apache:xml:site:29 from/to lda-public 
> (https://deblndw011x.ad001.siemens.net/nexus/content/groups/lda-public/): 
> authorization failed for 
> https://deblndw011x.ad001.siemens.net/nexus/content/groups/lda-public/org/apache/apache/29/apache-29-site.xml,
>  status: 403 Forbidden -> [Help 1]
> [ERROR]
> [ERROR] To see the full stack trace of the errors, re-run Maven with the -e 
> switch.
> [ERROR] Re-run Maven using the -X switch to enable full debug logging.
> [ERROR]
> [ERROR] For more information about the errors and possible solutions, please 
> read the following articles:
> [ERROR] [Help 1] 
> http://cwiki.apache.org/confluence/display/MAVEN/MojoExecutionException
> {noformat}
> for a dependency:
> {noformat}
> [INFO] org.apache.maven.cli.event.ExecutionEventLogger - 
> 
> [ERROR] org.apache.maven.cli.MavenCli - Failed to execute goal 
> org.apache.maven.plugins:maven-site-plugin:4.0.0-M7-SNAPSHOT:site 
> (default-site) on project mskins-222: Failed to get report for 
> org.apache.mav

[jira] [Commented] (MNG-7758) o.e.aether.resolution.ArtifactResolutionException incorrectly examined when multiple repositories are involved

2024-06-10 Thread ASF GitHub Bot (Jira)


[ 
https://issues.apache.org/jira/browse/MNG-7758?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17853762#comment-17853762
 ] 

ASF GitHub Bot commented on MNG-7758:
-

cstamas commented on PR #1563:
URL: https://github.com/apache/maven/pull/1563#issuecomment-2158983378

   Resolver handles differently 403, as it assumes "user error" in those cases 
(and user would fix/update access credentials, or remove repo).




> o.e.aether.resolution.ArtifactResolutionException incorrectly examined when 
> multiple repositories are involved
> --
>
> Key: MNG-7758
> URL: https://issues.apache.org/jira/browse/MNG-7758
> Project: Maven
>  Issue Type: Bug
>  Components: Artifacts and Repositories, Dependencies, Performance
>Affects Versions: 3.8.8, 3.9.1, 4.0.0-alpha-5
>Reporter: Michael Osipov
>Assignee: Slawomir Jaranowski
>Priority: Critical
> Fix For: 4.0.0, 3.9.8, 4.0.0-beta-4
>
> Attachments: 1.png, 2.png, Exception hierarchy.png
>
>
> Consider you have three repos defined in your build (could be POM or 
> settings), evaluated in following order:
> 1. repo A: serves custom artifacts with group id {{com.example}}, due to repo 
> partitioning in Nexus rejects requests to all other group ids with 403
> 1. repo B: serves third party artifacts without any restriction from a Nexus 
> repo
> 1. repo C: serves Central mirror, last one quried, no restrictions
> Note that order is important! Now add a non-existing dependency to your  POM 
> and receive the following behavior:
> {{ArtifactResolutionException}} will contain an {{ArtifactResult}} with three 
> exceptions: 
>  - {{TransferException}} with nested {{AuthorizationException}}, 
>  - {{ArtifactNotFoundException}}, 
>  - {{ArtifactNotFoundException}}. 
> {{ArtifactResolutionException#getCause()}} will be populated with the 
> {{TransferException}} so will 
> {{org.eclipse.aether.resolution.ArtifactResult.isMissing()}} take the first 
> exception only into account. E.g., {{DefaultArtifactDescriptorReader}} will 
> do {{if (e.getCause() instanceof ArtifactNotFoundException)}} which is 
> deceiving.
> Here is a sample for a non-existing artifact:
> {noformat}
> [INFO] --- maven-site-plugin:4.0.0-M7-SNAPSHOT:site (default-site) @ 
> mskins-222 ---
> [INFO] Configuring report plugin 
> org.apache.maven.plugins:maven-project-info-reports-plugin:3.4.2
> [WARNING] index report is declared twice in default reportSet
> [INFO] 15 reports configured for maven-project-info-reports-plugin:3.4.2: 
> index, summary, dependency-info, modules, team, scm, issue-management, 
> mailing-lists, dependency-management, dependencies, dependency-convergence, 
> ci-management, plugin-management, plugins, distribution-management
> [INFO] Rendering site for default locale
> Downloading from lda-public: 
> https://deblndw011x.ad001.siemens.net/nexus/content/groups/lda-public/org/apache/apache/29/apache-29-site.xml
> [INFO] 
> 
> [INFO] BUILD FAILURE
> [INFO] 
> 
> [INFO] Total time:  3.214 s
> [INFO] Finished at: 2023-04-02T12:51:02+02:00
> [INFO] 
> 
> [ERROR] Failed to execute goal 
> org.apache.maven.plugins:maven-site-plugin:4.0.0-M7-SNAPSHOT:site 
> (default-site) on project mskins-222: SiteToolException: The site descriptor 
> cannot be resolved from the repository: Unable to locate site descriptor: 
> Could not transfer artifact org.apache:apache:xml:site:29 from/to lda-public 
> (https://deblndw011x.ad001.siemens.net/nexus/content/groups/lda-public/): 
> authorization failed for 
> https://deblndw011x.ad001.siemens.net/nexus/content/groups/lda-public/org/apache/apache/29/apache-29-site.xml,
>  status: 403 Forbidden -> [Help 1]
> [ERROR]
> [ERROR] To see the full stack trace of the errors, re-run Maven with the -e 
> switch.
> [ERROR] Re-run Maven using the -X switch to enable full debug logging.
> [ERROR]
> [ERROR] For more information about the errors and possible solutions, please 
> read the following articles:
> [ERROR] [Help 1] 
> http://cwiki.apache.org/confluence/display/MAVEN/MojoExecutionException
> {noformat}
> for a dependency:
> {noformat}
> [INFO] org.apache.maven.cli.event.ExecutionEventLogger - 
> 
> [ERROR] org.apache.maven.cli.MavenCli - Failed to execute goal 
> org.apache.maven.plugins:maven-site-plugin:4.0.0-M7-SNAPSHOT:site 
> (default-site) on project mskins-222: Failed to get report for 
> org.apache.maven.plugins:maven-project-plugin: Plugin 
> org.apache.maven.plugins:maven-proje

Re: [PR] [MNG-7758] Report dependency problems for all repository [maven]

2024-06-10 Thread via GitHub


cstamas commented on PR #1563:
URL: https://github.com/apache/maven/pull/1563#issuecomment-2158983378

   Resolver handles differently 403, as it assumes "user error" in those cases 
(and user would fix/update access credentials, or remove repo).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] [MNG-8153] Add back missing classes from the v3 api [maven]

2024-06-10 Thread via GitHub


cstamas commented on PR #1577:
URL: https://github.com/apache/maven/pull/1577#issuecomment-2158977524

   When did these classes become "gone"?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[jira] [Commented] (MNG-8153) Some classes from the Maven 3 API are missing

2024-06-10 Thread ASF GitHub Bot (Jira)


[ 
https://issues.apache.org/jira/browse/MNG-8153?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17853760#comment-17853760
 ] 

ASF GitHub Bot commented on MNG-8153:
-

cstamas commented on PR #1577:
URL: https://github.com/apache/maven/pull/1577#issuecomment-2158977524

   When did these classes become "gone"?




> Some classes from the Maven 3 API are missing
> -
>
> Key: MNG-8153
> URL: https://issues.apache.org/jira/browse/MNG-8153
> Project: Maven
>  Issue Type: Improvement
>Affects Versions: 4.0.0-beta-3
>Reporter: Guillaume Nodet
>Assignee: Guillaume Nodet
>Priority: Major
> Fix For: 4.0.0-beta-4
>
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (MBUILDCACHE-87) Checksum should consider plugin dependencies

2024-06-10 Thread ASF GitHub Bot (Jira)


[ 
https://issues.apache.org/jira/browse/MBUILDCACHE-87?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17853738#comment-17853738
 ] 

ASF GitHub Bot commented on MBUILDCACHE-87:
---

reda-alaoui commented on code in PR #146:
URL: 
https://github.com/apache/maven-build-cache-extension/pull/146#discussion_r1633569241


##
src/main/java/org/apache/maven/buildcache/checksum/MavenProjectInput.java:
##
@@ -620,14 +631,26 @@ private static boolean isReadable(Path entry) throws 
IOException {
 }
 
 private SortedMap getMutableDependencies() throws 
IOException {
+return getMutableDependenciesHashes("", project.getDependencies());
+}
+
+private SortedMap getMutablePluginDependencies() throws 
IOException {
+SortedMap fullMap = new TreeMap<>();
+for (Plugin plugin : project.getBuildPlugins()) {
+if (config.isPluginDependenciesExcluded(plugin)) {
+continue;
+}
+fullMap.putAll(getMutableDependenciesHashes(
+
KeyUtils.getVersionlessArtifactKey(repoSystem.createPluginArtifact(plugin)) + 
"|",

Review Comment:
   To keep `compareWithBaseline` feature operational with plugin dependencies, 
I added an occurrency index to the map key instead of turning the map into a 
collection.





> Checksum should consider plugin dependencies
> 
>
> Key: MBUILDCACHE-87
> URL: https://issues.apache.org/jira/browse/MBUILDCACHE-87
> Project: Maven Build Cache Extension
>  Issue Type: Improvement
>Reporter: Réda Housni Alaoui
>Priority: Major
>  Labels: pull-request-available
>
> I have a multi module project where module A is used as a dependency of 
> maven-dependency-plugin:unpack declared in module B.
> {{buildinfo.xml}} of module B does not consider module A as a dependency.
> Maybe something similar to 
> https://github.com/apache/maven-build-cache-extension/blob/6eb05e61fdfa7be1ad44cf6afc13958b0c6ea4a6/src/main/java/org/apache/maven/buildcache/checksum/MavenProjectInput.java#L602
>  should be added for plugin dependencies?



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (MBUILDCACHE-87) Checksum should consider plugin dependencies

2024-06-10 Thread ASF GitHub Bot (Jira)


[ 
https://issues.apache.org/jira/browse/MBUILDCACHE-87?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17853740#comment-17853740
 ] 

ASF GitHub Bot commented on MBUILDCACHE-87:
---

reda-alaoui commented on code in PR #146:
URL: 
https://github.com/apache/maven-build-cache-extension/pull/146#discussion_r1633569241


##
src/main/java/org/apache/maven/buildcache/checksum/MavenProjectInput.java:
##
@@ -620,14 +631,26 @@ private static boolean isReadable(Path entry) throws 
IOException {
 }
 
 private SortedMap getMutableDependencies() throws 
IOException {
+return getMutableDependenciesHashes("", project.getDependencies());
+}
+
+private SortedMap getMutablePluginDependencies() throws 
IOException {
+SortedMap fullMap = new TreeMap<>();
+for (Plugin plugin : project.getBuildPlugins()) {
+if (config.isPluginDependenciesExcluded(plugin)) {
+continue;
+}
+fullMap.putAll(getMutableDependenciesHashes(
+
KeyUtils.getVersionlessArtifactKey(repoSystem.createPluginArtifact(plugin)) + 
"|",

Review Comment:
   To keep `compareWithBaseline` feature operational with plugin dependencies, 
I added an occurrence index to the map key instead of turning the map into a 
collection.





> Checksum should consider plugin dependencies
> 
>
> Key: MBUILDCACHE-87
> URL: https://issues.apache.org/jira/browse/MBUILDCACHE-87
> Project: Maven Build Cache Extension
>  Issue Type: Improvement
>Reporter: Réda Housni Alaoui
>Priority: Major
>  Labels: pull-request-available
>
> I have a multi module project where module A is used as a dependency of 
> maven-dependency-plugin:unpack declared in module B.
> {{buildinfo.xml}} of module B does not consider module A as a dependency.
> Maybe something similar to 
> https://github.com/apache/maven-build-cache-extension/blob/6eb05e61fdfa7be1ad44cf6afc13958b0c6ea4a6/src/main/java/org/apache/maven/buildcache/checksum/MavenProjectInput.java#L602
>  should be added for plugin dependencies?



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


Re: [PR] [MBUILDCACHE-87] - Checksum should consider plugin dependencies [maven-build-cache-extension]

2024-06-10 Thread via GitHub


reda-alaoui commented on code in PR #146:
URL: 
https://github.com/apache/maven-build-cache-extension/pull/146#discussion_r1633569241


##
src/main/java/org/apache/maven/buildcache/checksum/MavenProjectInput.java:
##
@@ -620,14 +631,26 @@ private static boolean isReadable(Path entry) throws 
IOException {
 }
 
 private SortedMap getMutableDependencies() throws 
IOException {
+return getMutableDependenciesHashes("", project.getDependencies());
+}
+
+private SortedMap getMutablePluginDependencies() throws 
IOException {
+SortedMap fullMap = new TreeMap<>();
+for (Plugin plugin : project.getBuildPlugins()) {
+if (config.isPluginDependenciesExcluded(plugin)) {
+continue;
+}
+fullMap.putAll(getMutableDependenciesHashes(
+
KeyUtils.getVersionlessArtifactKey(repoSystem.createPluginArtifact(plugin)) + 
"|",

Review Comment:
   To keep `compareWithBaseline` feature operational with plugin dependencies, 
I added an occurrence index to the map key instead of turning the map into a 
collection.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] [MBUILDCACHE-87] - Checksum should consider plugin dependencies [maven-build-cache-extension]

2024-06-10 Thread via GitHub


reda-alaoui commented on code in PR #146:
URL: 
https://github.com/apache/maven-build-cache-extension/pull/146#discussion_r1633569241


##
src/main/java/org/apache/maven/buildcache/checksum/MavenProjectInput.java:
##
@@ -620,14 +631,26 @@ private static boolean isReadable(Path entry) throws 
IOException {
 }
 
 private SortedMap getMutableDependencies() throws 
IOException {
+return getMutableDependenciesHashes("", project.getDependencies());
+}
+
+private SortedMap getMutablePluginDependencies() throws 
IOException {
+SortedMap fullMap = new TreeMap<>();
+for (Plugin plugin : project.getBuildPlugins()) {
+if (config.isPluginDependenciesExcluded(plugin)) {
+continue;
+}
+fullMap.putAll(getMutableDependenciesHashes(
+
KeyUtils.getVersionlessArtifactKey(repoSystem.createPluginArtifact(plugin)) + 
"|",

Review Comment:
   To keep `compareWithBaseline` feature operational with plugin dependencies, 
I added an occurrency index to the map key instead of turning the map into a 
collection.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[jira] [Commented] (MNG-8153) Some classes from the Maven 3 API are missing

2024-06-10 Thread ASF GitHub Bot (Jira)


[ 
https://issues.apache.org/jira/browse/MNG-8153?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17853731#comment-17853731
 ] 

ASF GitHub Bot commented on MNG-8153:
-

gnodet opened a new pull request, #1577:
URL: https://github.com/apache/maven/pull/1577

   (no comment)




> Some classes from the Maven 3 API are missing
> -
>
> Key: MNG-8153
> URL: https://issues.apache.org/jira/browse/MNG-8153
> Project: Maven
>  Issue Type: Improvement
>Affects Versions: 4.0.0-beta-3
>Reporter: Guillaume Nodet
>Assignee: Guillaume Nodet
>Priority: Major
> Fix For: 4.0.0-beta-4
>
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[PR] [MNG-8153] Add back missing classes from the v3 api [maven]

2024-06-10 Thread via GitHub


gnodet opened a new pull request, #1577:
URL: https://github.com/apache/maven/pull/1577

   (no comment)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[jira] [Created] (MNG-8153) Some classes from the Maven 3 API are missing

2024-06-10 Thread Guillaume Nodet (Jira)
Guillaume Nodet created MNG-8153:


 Summary: Some classes from the Maven 3 API are missing
 Key: MNG-8153
 URL: https://issues.apache.org/jira/browse/MNG-8153
 Project: Maven
  Issue Type: Improvement
Affects Versions: 4.0.0-beta-3
Reporter: Guillaume Nodet
Assignee: Guillaume Nodet
 Fix For: 4.0.0-beta-4






--
This message was sent by Atlassian Jira
(v8.20.10#820010)


Re: [I] mvnd version support Maven 3.9.6+ [maven-mvnd]

2024-06-10 Thread via GitHub


gsmet commented on issue #1009:
URL: https://github.com/apache/maven-mvnd/issues/1009#issuecomment-2158806141

   Thanks, that's awesome. No need to keep this issue open then.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [I] mvnd version support Maven 3.9.6+ [maven-mvnd]

2024-06-10 Thread via GitHub


gsmet closed issue #1009: mvnd version support Maven 3.9.6+
URL: https://github.com/apache/maven-mvnd/issues/1009


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] Bump org.apache.maven.shared:maven-common-artifact-filters from 3.3.2 to 3.4.0 [maven-pmd-plugin]

2024-06-10 Thread via GitHub


michael-o merged PR #153:
URL: https://github.com/apache/maven-pmd-plugin/pull/153


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] Bump org.apache.maven.shared:maven-common-artifact-filters from 3.3.2 to 3.4.0 [maven-pmd-plugin]

2024-06-10 Thread via GitHub


dependabot[bot] commented on PR #153:
URL: https://github.com/apache/maven-pmd-plugin/pull/153#issuecomment-2158628515

   Looks like this PR is already up-to-date with master! If you'd still like to 
recreate it from scratch, overwriting any edits, you can request `@dependabot 
recreate`.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] Bump org.apache.maven.shared:maven-common-artifact-filters from 3.3.2 to 3.4.0 [maven-pmd-plugin]

2024-06-10 Thread via GitHub


michael-o commented on PR #153:
URL: https://github.com/apache/maven-pmd-plugin/pull/153#issuecomment-2158628358

   @dependabot  rebase


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[jira] [Commented] (MPMD-399) Incorrect warning: The project X does not seem to be compiled. PMD results might be inaccurate.

2024-06-10 Thread Michael Osipov (Jira)


[ 
https://issues.apache.org/jira/browse/MPMD-399?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17853706#comment-17853706
 ] 

Michael Osipov commented on MPMD-399:
-

Have a look at the PR.

> Incorrect warning: The project X does not seem to be compiled. PMD results 
> might be inaccurate.
> ---
>
> Key: MPMD-399
> URL: https://issues.apache.org/jira/browse/MPMD-399
> Project: Maven PMD Plugin
>  Issue Type: Bug
>  Components: PMD
>Affects Versions: 3.22.0
>Reporter: AB-xdev
>Priority: Major
>
> PMD plugin is reporting the following warnings on in a multi-maven project:
> "The project X does not seem to be compiled. PMD results might be inaccurate."
> This is caused by the fact that not all modules have a
>  * {{src/main/java}} or
>  * {{src/test/java}} folder
> and therefore no {{target/classes}} or {{target/test-classes}} folders are 
> generated.
> The affected code that causes the problem can be found here:
> [https://github.com/apache/maven-pmd-plugin/blob/1961d771ea585e9344c25dfde194ee64a1b9040b/src/main/java/org/apache/maven/plugins/pmd/PmdReport.java#L516-L532]
> h3. Reproduction example
>  * Create a maven multi-module project
>  * Leave {{src/main/java}} of one module empty
>  * Execute {{pmd:aggregate-pmd}} or {{test pmd:aggregate-pmd-no-fork 
> -DskipTests}}
> → (x) Warning is reported
> h3. Possible fixes
> * Make it possible to ignore this warning
> * Do not warn when at least {{target/classes}} or {{target/test-classes}} is 
> present
>  



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (MPMD-399) Incorrect warning: The project X does not seem to be compiled. PMD results might be inaccurate.

2024-06-10 Thread ASF GitHub Bot (Jira)


[ 
https://issues.apache.org/jira/browse/MPMD-399?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17853704#comment-17853704
 ] 

ASF GitHub Bot commented on MPMD-399:
-

michael-o opened a new pull request, #154:
URL: https://github.com/apache/maven-pmd-plugin/pull/154

   …led. PMD results might be inaccurate.
   
   Following this checklist to help us incorporate your
   contribution quickly and easily:
   
- [ ] Make sure there is a [JIRA 
issue](https://issues.apache.org/jira/browse/MPMD) filed
  for the change (usually before you start working on it).  Trivial 
changes like typos do not
  require a JIRA issue.  Your pull request should address just this 
issue, without
  pulling in other changes.
- [ ] Each commit in the pull request should have a meaningful subject line 
and body.
- [ ] Format the pull request title like `[MPMD-XXX] - Subject of the JIRA 
Ticket`,
  where you replace `MPMD-XXX` with the appropriate JIRA issue. Best 
practice
  is to use the JIRA issue title in the pull request title and in the 
first line of the
  commit message.
- [ ] Write a pull request description that is detailed enough to 
understand what the pull request does, how, and why.
- [ ] Run `mvn clean verify` to make sure basic checks pass. A more 
thorough check will
  be performed on your pull request automatically.
- [ ] You have run the integration tests successfully (`mvn -Prun-its clean 
verify`).
   
   If your pull request is about ~20 lines of code you don't need to sign an
   [Individual Contributor License 
Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure
   please ask on the developers list.
   
   To make clear that you license your contribution under
   the [Apache License Version 2.0, January 
2004](http://www.apache.org/licenses/LICENSE-2.0)
   you have to acknowledge this by using the following check-box.
   
- [ ] I hereby declare this contribution to be licenced under the [Apache 
License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
   
- [ ] In any other case, please file an [Apache Individual Contributor 
License Agreement](https://www.apache.org/licenses/icla.pdf).
   




> Incorrect warning: The project X does not seem to be compiled. PMD results 
> might be inaccurate.
> ---
>
> Key: MPMD-399
> URL: https://issues.apache.org/jira/browse/MPMD-399
> Project: Maven PMD Plugin
>  Issue Type: Bug
>  Components: PMD
>Affects Versions: 3.22.0
>Reporter: AB-xdev
>Priority: Major
>
> PMD plugin is reporting the following warnings on in a multi-maven project:
> "The project X does not seem to be compiled. PMD results might be inaccurate."
> This is caused by the fact that not all modules have a
>  * {{src/main/java}} or
>  * {{src/test/java}} folder
> and therefore no {{target/classes}} or {{target/test-classes}} folders are 
> generated.
> The affected code that causes the problem can be found here:
> [https://github.com/apache/maven-pmd-plugin/blob/1961d771ea585e9344c25dfde194ee64a1b9040b/src/main/java/org/apache/maven/plugins/pmd/PmdReport.java#L516-L532]
> h3. Reproduction example
>  * Create a maven multi-module project
>  * Leave {{src/main/java}} of one module empty
>  * Execute {{pmd:aggregate-pmd}} or {{test pmd:aggregate-pmd-no-fork 
> -DskipTests}}
> → (x) Warning is reported
> h3. Possible fixes
> * Make it possible to ignore this warning
> * Do not warn when at least {{target/classes}} or {{target/test-classes}} is 
> present
>  



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


Re: [PR] Bump resolverVersion from 1.4.1 to 1.9.20 [maven-pmd-plugin]

2024-06-10 Thread via GitHub


dependabot[bot] commented on PR #152:
URL: https://github.com/apache/maven-pmd-plugin/pull/152#issuecomment-2158623637

   OK, I won't notify you about any of these dependencies again, unless you 
re-open this PR.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] Bump resolverVersion from 1.4.1 to 1.9.20 [maven-pmd-plugin]

2024-06-10 Thread via GitHub


dependabot[bot] closed pull request #152: Bump resolverVersion from 1.4.1 to 
1.9.20
URL: https://github.com/apache/maven-pmd-plugin/pull/152


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] Bump resolverVersion from 1.4.1 to 1.9.20 [maven-pmd-plugin]

2024-06-10 Thread via GitHub


michael-o commented on PR #152:
URL: https://github.com/apache/maven-pmd-plugin/pull/152#issuecomment-2158623490

   @dependabot ignore this dependency


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[PR] [MPMD-399] Incorrect warning: The project X does not seem to be compi… [maven-pmd-plugin]

2024-06-10 Thread via GitHub


michael-o opened a new pull request, #154:
URL: https://github.com/apache/maven-pmd-plugin/pull/154

   …led. PMD results might be inaccurate.
   
   Following this checklist to help us incorporate your
   contribution quickly and easily:
   
- [ ] Make sure there is a [JIRA 
issue](https://issues.apache.org/jira/browse/MPMD) filed
  for the change (usually before you start working on it).  Trivial 
changes like typos do not
  require a JIRA issue.  Your pull request should address just this 
issue, without
  pulling in other changes.
- [ ] Each commit in the pull request should have a meaningful subject line 
and body.
- [ ] Format the pull request title like `[MPMD-XXX] - Subject of the JIRA 
Ticket`,
  where you replace `MPMD-XXX` with the appropriate JIRA issue. Best 
practice
  is to use the JIRA issue title in the pull request title and in the 
first line of the
  commit message.
- [ ] Write a pull request description that is detailed enough to 
understand what the pull request does, how, and why.
- [ ] Run `mvn clean verify` to make sure basic checks pass. A more 
thorough check will
  be performed on your pull request automatically.
- [ ] You have run the integration tests successfully (`mvn -Prun-its clean 
verify`).
   
   If your pull request is about ~20 lines of code you don't need to sign an
   [Individual Contributor License 
Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure
   please ask on the developers list.
   
   To make clear that you license your contribution under
   the [Apache License Version 2.0, January 
2004](http://www.apache.org/licenses/LICENSE-2.0)
   you have to acknowledge this by using the following check-box.
   
- [ ] I hereby declare this contribution to be licenced under the [Apache 
License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
   
- [ ] In any other case, please file an [Apache Individual Contributor 
License Agreement](https://www.apache.org/licenses/icla.pdf).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[jira] [Created] (MNG-8152) Implement @SessionScoped and @MojoExecutionScoped from the DI API

2024-06-10 Thread Guillaume Nodet (Jira)
Guillaume Nodet created MNG-8152:


 Summary: Implement @SessionScoped and @MojoExecutionScoped from 
the DI API
 Key: MNG-8152
 URL: https://issues.apache.org/jira/browse/MNG-8152
 Project: Maven
  Issue Type: Improvement
Reporter: Guillaume Nodet
Assignee: Guillaume Nodet
 Fix For: 4.0.0-beta-4






--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Created] (MNG-8151) Merge DependencyCollector into DependencyResolver

2024-06-10 Thread Guillaume Nodet (Jira)
Guillaume Nodet created MNG-8151:


 Summary: Merge DependencyCollector into DependencyResolver
 Key: MNG-8151
 URL: https://issues.apache.org/jira/browse/MNG-8151
 Project: Maven
  Issue Type: Improvement
  Components: API
Reporter: Guillaume Nodet
Assignee: Guillaume Nodet
 Fix For: 4.0.0-beta-4






--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (MPMD-399) Incorrect warning: The project X does not seem to be compiled. PMD results might be inaccurate.

2024-06-10 Thread Michael Osipov (Jira)


[ 
https://issues.apache.org/jira/browse/MPMD-399?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17853702#comment-17853702
 ] 

Michael Osipov commented on MPMD-399:
-

Forget my previous questions because 
{{localProject.getTestClasspathElements()}} is cumulative. Ony the 
documentation needs to be updated. [~AB-xdev], we can get back to the actual 
problem.

> Incorrect warning: The project X does not seem to be compiled. PMD results 
> might be inaccurate.
> ---
>
> Key: MPMD-399
> URL: https://issues.apache.org/jira/browse/MPMD-399
> Project: Maven PMD Plugin
>  Issue Type: Bug
>  Components: PMD
>Affects Versions: 3.22.0
>Reporter: AB-xdev
>Priority: Major
>
> PMD plugin is reporting the following warnings on in a multi-maven project:
> "The project X does not seem to be compiled. PMD results might be inaccurate."
> This is caused by the fact that not all modules have a
>  * {{src/main/java}} or
>  * {{src/test/java}} folder
> and therefore no {{target/classes}} or {{target/test-classes}} folders are 
> generated.
> The affected code that causes the problem can be found here:
> [https://github.com/apache/maven-pmd-plugin/blob/1961d771ea585e9344c25dfde194ee64a1b9040b/src/main/java/org/apache/maven/plugins/pmd/PmdReport.java#L516-L532]
> h3. Reproduction example
>  * Create a maven multi-module project
>  * Leave {{src/main/java}} of one module empty
>  * Execute {{pmd:aggregate-pmd}} or {{test pmd:aggregate-pmd-no-fork 
> -DskipTests}}
> → (x) Warning is reported
> h3. Possible fixes
> * Make it possible to ignore this warning
> * Do not warn when at least {{target/classes}} or {{target/test-classes}} is 
> present
>  



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (MPMD-399) Incorrect warning: The project X does not seem to be compiled. PMD results might be inaccurate.

2024-06-10 Thread Michael Osipov (Jira)


[ 
https://issues.apache.org/jira/browse/MPMD-399?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17853699#comment-17853699
 ] 

Michael Osipov commented on MPMD-399:
-

I am also confused why the single project case does not include the deps...

> Incorrect warning: The project X does not seem to be compiled. PMD results 
> might be inaccurate.
> ---
>
> Key: MPMD-399
> URL: https://issues.apache.org/jira/browse/MPMD-399
> Project: Maven PMD Plugin
>  Issue Type: Bug
>  Components: PMD
>Affects Versions: 3.22.0
>Reporter: AB-xdev
>Priority: Major
>
> PMD plugin is reporting the following warnings on in a multi-maven project:
> "The project X does not seem to be compiled. PMD results might be inaccurate."
> This is caused by the fact that not all modules have a
>  * {{src/main/java}} or
>  * {{src/test/java}} folder
> and therefore no {{target/classes}} or {{target/test-classes}} folders are 
> generated.
> The affected code that causes the problem can be found here:
> [https://github.com/apache/maven-pmd-plugin/blob/1961d771ea585e9344c25dfde194ee64a1b9040b/src/main/java/org/apache/maven/plugins/pmd/PmdReport.java#L516-L532]
> h3. Reproduction example
>  * Create a maven multi-module project
>  * Leave {{src/main/java}} of one module empty
>  * Execute {{pmd:aggregate-pmd}} or {{test pmd:aggregate-pmd-no-fork 
> -DskipTests}}
> → (x) Warning is reported
> h3. Possible fixes
> * Make it possible to ignore this warning
> * Do not warn when at least {{target/classes}} or {{target/test-classes}} is 
> present
>  



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (MPMD-399) Incorrect warning: The project X does not seem to be compiled. PMD results might be inaccurate.

2024-06-10 Thread Michael Osipov (Jira)


[ 
https://issues.apache.org/jira/browse/MPMD-399?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17853698#comment-17853698
 ] 

Michael Osipov commented on MPMD-399:
-

I have a slight problem with {{includeTests}}: It documentation says "Run PMD 
on the tests.". Looking at 
https://github.com/apache/maven-pmd-plugin/blob/1961d771ea585e9344c25dfde194ee64a1b9040b/src/main/java/org/apache/maven/plugins/pmd/AbstractPmdReport.java#L351-L384.
 The operation is additive/inclusive. The description is wrong. But here, it is 
exclusive: 
https://github.com/apache/maven-pmd-plugin/blob/1961d771ea585e9344c25dfde194ee64a1b9040b/src/main/java/org/apache/maven/plugins/pmd/PmdReport.java#L516-L518

[~adangel], shouldn't {{auxClasspath}} include main classpath as well when 
tests should be included? Since dependencies are inclusive as well: 
https://github.com/apache/maven-pmd-plugin/blob/1961d771ea585e9344c25dfde194ee64a1b9040b/src/main/java/org/apache/maven/plugins/pmd/PmdReport.java#L493-L497

It does not compute fo me.

[~AB-xdev], sorry to deviate, but that needs to clarified first.

> Incorrect warning: The project X does not seem to be compiled. PMD results 
> might be inaccurate.
> ---
>
> Key: MPMD-399
> URL: https://issues.apache.org/jira/browse/MPMD-399
> Project: Maven PMD Plugin
>  Issue Type: Bug
>  Components: PMD
>Affects Versions: 3.22.0
>Reporter: AB-xdev
>Priority: Major
>
> PMD plugin is reporting the following warnings on in a multi-maven project:
> "The project X does not seem to be compiled. PMD results might be inaccurate."
> This is caused by the fact that not all modules have a
>  * {{src/main/java}} or
>  * {{src/test/java}} folder
> and therefore no {{target/classes}} or {{target/test-classes}} folders are 
> generated.
> The affected code that causes the problem can be found here:
> [https://github.com/apache/maven-pmd-plugin/blob/1961d771ea585e9344c25dfde194ee64a1b9040b/src/main/java/org/apache/maven/plugins/pmd/PmdReport.java#L516-L532]
> h3. Reproduction example
>  * Create a maven multi-module project
>  * Leave {{src/main/java}} of one module empty
>  * Execute {{pmd:aggregate-pmd}} or {{test pmd:aggregate-pmd-no-fork 
> -DskipTests}}
> → (x) Warning is reported
> h3. Possible fixes
> * Make it possible to ignore this warning
> * Do not warn when at least {{target/classes}} or {{target/test-classes}} is 
> present
>  



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


Re: [PR] Checkstyle 10.x [maven-checkstyle-plugin]

2024-06-10 Thread via GitHub


romani commented on code in PR #141:
URL: 
https://github.com/apache/maven-checkstyle-plugin/pull/141#discussion_r1633357951


##
src/main/java/org/apache/maven/plugins/checkstyle/AbstractCheckstyleReport.java:
##
@@ -26,22 +26,24 @@
 import java.io.OutputStream;
 import java.nio.file.Path;
 import java.util.ArrayList;
+import java.util.Collections;
 import java.util.List;
 import java.util.Locale;
 import java.util.Map;
 
+import 
com.puppycrawl.tools.checkstyle.AbstractAutomaticBean.OutputStreamOptions;

Review Comment:
   With a strive to cover as much people as possible, we will force all of them 
to understand that plugin is not compatible with [10.9.3, 10.17.0], it is a lot 
of versions. People need some specific versions to match behavior in Eclipse 
and in Sonar.
   
   If we want full happiness of users we need to put in plugin code that is 
aware of problems in Ctors and use ctor only if it exists.
   We will remove deprecated class when we do major version bump or something 
big.
   But again maybe it is better to break compatibility sooner. Breaking changes 
are inevitable, it is just just question on to do it sooner or later, but user 
pain will be the same.
   
   As you already do huge non compatible changes, it might be good to make it 
clear that this version is up to checkstyle 10.9.2 
   . And next version of plugin will be 10.9.3 and up.
   
   So we will remove deprecated class and users will not notice it. So next big 
update for plugin will be migration to jdk17, whenever maven team decides to go 
this. But users will use plugin at jdk21 with all latest updates to validate 
fancy modern syntax of java .



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[jira] [Commented] (MPMD-399) Incorrect warning: The project X does not seem to be compiled. PMD results might be inaccurate.

2024-06-10 Thread Michael Osipov (Jira)


[ 
https://issues.apache.org/jira/browse/MPMD-399?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17853692#comment-17853692
 ] 

Michael Osipov commented on MPMD-399:
-

Hold on, that confuses me. In the default case if src/main is there there 
should be not warning, only if src/tests are there and {{includeTests}} is 
{{false}} and the other way around: {{true}} and only {{src/main}}. The first 
case I do not understand, but the latter makes sense. You should see the 
warning. Can you confirm?

> Incorrect warning: The project X does not seem to be compiled. PMD results 
> might be inaccurate.
> ---
>
> Key: MPMD-399
> URL: https://issues.apache.org/jira/browse/MPMD-399
> Project: Maven PMD Plugin
>  Issue Type: Bug
>  Components: PMD
>Affects Versions: 3.22.0
>Reporter: AB-xdev
>Priority: Major
>
> PMD plugin is reporting the following warnings on in a multi-maven project:
> "The project X does not seem to be compiled. PMD results might be inaccurate."
> This is caused by the fact that not all modules have a
>  * {{src/main/java}} or
>  * {{src/test/java}} folder
> and therefore no {{target/classes}} or {{target/test-classes}} folders are 
> generated.
> The affected code that causes the problem can be found here:
> [https://github.com/apache/maven-pmd-plugin/blob/1961d771ea585e9344c25dfde194ee64a1b9040b/src/main/java/org/apache/maven/plugins/pmd/PmdReport.java#L516-L532]
> h3. Reproduction example
>  * Create a maven multi-module project
>  * Leave {{src/main/java}} of one module empty
>  * Execute {{pmd:aggregate-pmd}} or {{test pmd:aggregate-pmd-no-fork 
> -DskipTests}}
> → (x) Warning is reported
> h3. Possible fixes
> * Make it possible to ignore this warning
> * Do not warn when at least {{target/classes}} or {{target/test-classes}} is 
> present
>  



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (MNG-8134) Provide an annotation that can be used to inject dependencies resolution/collection in mojos

2024-06-10 Thread ASF GitHub Bot (Jira)


[ 
https://issues.apache.org/jira/browse/MNG-8134?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17853677#comment-17853677
 ] 

ASF GitHub Bot commented on MNG-8134:
-

gnodet commented on PR #1559:
URL: https://github.com/apache/maven/pull/1559#issuecomment-2158446053

   > I'd shamefully copy a new `DependencySet` wrapper idea to avoid to have to 
inject a map or a list which are rarely what is needed so a think wrapper 
enabling to lookup what is needed (with filter + default collectors support).
   > 
   > That said I don't know if we need an injection or just this wrapper being 
accessible from the project - I have a few cases where the scope is configured 
in the mojo so the injection can need an expression to work (+-0 to make it 
working or just rely on v4 project).
   
   If you want the wrapper, you can inject the `DependencyResolverResult` class 
from the API which provides everything.  The other ones are just to simplify 
for simple use cases. 
   
   For the expression, I thought about it, but I'm not sure that's easily 
feasible, nor worth it.  The API is quite easily usable, it would just save two 
lines:
   ```
   PathScope ps = 
session.getService(PathScopeRegistry.class).require(pathScope);
   DependencyResolverResult res = 
session.getService(DependencyResolver.class).resolve(session, project, ps);
   ```
   and the benefit of having it statically defined (so that we can compute 
exactly what is needed in advance) would be lost.
   Another possibility would be for the mojo to define multiple resolutions:
   ```
   @Resolution(pathScope = "main-compile")
   Map> compilePaths;
   
   @Resolution(pathScope = "main-test")
   Map> testPaths;
   ```
   




> Provide an annotation that can be used to inject dependencies 
> resolution/collection in mojos
> 
>
> Key: MNG-8134
> URL: https://issues.apache.org/jira/browse/MNG-8134
> Project: Maven
>  Issue Type: Task
>Reporter: Guillaume Nodet
>Priority: Major
> Fix For: 4.0.0
>
>
> See 
> https://github.com/apache/maven-plugin-tools/pull/286#discussion_r1620871349



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


Re: [PR] [MNG-8134] Add a @Resolution annotation to mojos to inject project dependencies collection / resolution result [maven]

2024-06-10 Thread via GitHub


gnodet commented on PR #1559:
URL: https://github.com/apache/maven/pull/1559#issuecomment-2158446053

   > I'd shamefully copy a new `DependencySet` wrapper idea to avoid to have to 
inject a map or a list which are rarely what is needed so a think wrapper 
enabling to lookup what is needed (with filter + default collectors support).
   > 
   > That said I don't know if we need an injection or just this wrapper being 
accessible from the project - I have a few cases where the scope is configured 
in the mojo so the injection can need an expression to work (+-0 to make it 
working or just rely on v4 project).
   
   If you want the wrapper, you can inject the `DependencyResolverResult` class 
from the API which provides everything.  The other ones are just to simplify 
for simple use cases. 
   
   For the expression, I thought about it, but I'm not sure that's easily 
feasible, nor worth it.  The API is quite easily usable, it would just save two 
lines:
   ```
   PathScope ps = 
session.getService(PathScopeRegistry.class).require(pathScope);
   DependencyResolverResult res = 
session.getService(DependencyResolver.class).resolve(session, project, ps);
   ```
   and the benefit of having it statically defined (so that we can compute 
exactly what is needed in advance) would be lost.
   Another possibility would be for the mojo to define multiple resolutions:
   ```
   @Resolution(pathScope = "main-compile")
   Map> compilePaths;
   
   @Resolution(pathScope = "main-test")
   Map> testPaths;
   ```
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[jira] [Commented] (MPMD-399) Incorrect warning: The project X does not seem to be compiled. PMD results might be inaccurate.

2024-06-10 Thread Michael Osipov (Jira)


[ 
https://issues.apache.org/jira/browse/MPMD-399?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17853670#comment-17853670
 ] 

Michael Osipov commented on MPMD-399:
-

The method is deprecated, but the information is still required and needs to be 
obtained elsewhere. That is different discussion. I would take care of the 
message.

Why do you have a JAR project w/o source code in the first place?

> Incorrect warning: The project X does not seem to be compiled. PMD results 
> might be inaccurate.
> ---
>
> Key: MPMD-399
> URL: https://issues.apache.org/jira/browse/MPMD-399
> Project: Maven PMD Plugin
>  Issue Type: Bug
>  Components: PMD
>Affects Versions: 3.22.0
>Reporter: AB-xdev
>Priority: Major
>
> PMD plugin is reporting the following warnings on in a multi-maven project:
> "The project X does not seem to be compiled. PMD results might be inaccurate."
> This is caused by the fact that not all modules have a
>  * {{src/main/java}} or
>  * {{src/test/java}} folder
> and therefore no {{target/classes}} or {{target/test-classes}} folders are 
> generated.
> The affected code that causes the problem can be found here:
> [https://github.com/apache/maven-pmd-plugin/blob/1961d771ea585e9344c25dfde194ee64a1b9040b/src/main/java/org/apache/maven/plugins/pmd/PmdReport.java#L516-L532]
> h3. Reproduction example
>  * Create a maven multi-module project
>  * Leave {{src/main/java}} of one module empty
>  * Execute {{pmd:aggregate-pmd}} or {{test pmd:aggregate-pmd-no-fork 
> -DskipTests}}
> → (x) Warning is reported
> h3. Possible fixes
> * Make it possible to ignore this warning
> * Do not warn when at least {{target/classes}} or {{target/test-classes}} is 
> present
>  



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (MPMD-399) Incorrect warning: The project X does not seem to be compiled. PMD results might be inaccurate.

2024-06-10 Thread AB-xdev (Jira)


[ 
https://issues.apache.org/jira/browse/MPMD-399?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17853667#comment-17853667
 ] 

AB-xdev commented on MPMD-399:
--

Well I'm not that familiar with the code, but anyway my opinion:

Block 1: Either delete it or add some kind of flag that let's the end-user 
control this check
Block 2: According to 
https://github.com/apache/maven-pmd-plugin/blob/master/src/main/java/org/apache/maven/plugins/pmd/AbstractPmdReport.java#L548
 this seems to be deprecated anyway? Maybe a good time to remove it :)

> Incorrect warning: The project X does not seem to be compiled. PMD results 
> might be inaccurate.
> ---
>
> Key: MPMD-399
> URL: https://issues.apache.org/jira/browse/MPMD-399
> Project: Maven PMD Plugin
>  Issue Type: Bug
>  Components: PMD
>Affects Versions: 3.22.0
>Reporter: AB-xdev
>Priority: Major
>
> PMD plugin is reporting the following warnings on in a multi-maven project:
> "The project X does not seem to be compiled. PMD results might be inaccurate."
> This is caused by the fact that not all modules have a
>  * {{src/main/java}} or
>  * {{src/test/java}} folder
> and therefore no {{target/classes}} or {{target/test-classes}} folders are 
> generated.
> The affected code that causes the problem can be found here:
> [https://github.com/apache/maven-pmd-plugin/blob/1961d771ea585e9344c25dfde194ee64a1b9040b/src/main/java/org/apache/maven/plugins/pmd/PmdReport.java#L516-L532]
> h3. Reproduction example
>  * Create a maven multi-module project
>  * Leave {{src/main/java}} of one module empty
>  * Execute {{pmd:aggregate-pmd}} or {{test pmd:aggregate-pmd-no-fork 
> -DskipTests}}
> → (x) Warning is reported
> h3. Possible fixes
> * Make it possible to ignore this warning
> * Do not warn when at least {{target/classes}} or {{target/test-classes}} is 
> present
>  



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (MPMD-399) Incorrect warning: The project X does not seem to be compiled. PMD results might be inaccurate.

2024-06-10 Thread Michael Osipov (Jira)


[ 
https://issues.apache.org/jira/browse/MPMD-399?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17853660#comment-17853660
 ] 

Michael Osipov commented on MPMD-399:
-

I am inclined to delete this entire block 
https://github.com/apache/maven-pmd-plugin/blob/1961d771ea585e9344c25dfde194ee64a1b9040b/src/main/java/org/apache/maven/plugins/pmd/PmdReport.java#L522-L532
 because in a single module there is not such message, but would make sense to 
be consistent: 
https://github.com/apache/maven-pmd-plugin/blob/1961d771ea585e9344c25dfde194ee64a1b9040b/src/main/java/org/apache/maven/plugins/pmd/PmdReport.java#L539-L541

Either both or none, WDYT?

> Incorrect warning: The project X does not seem to be compiled. PMD results 
> might be inaccurate.
> ---
>
> Key: MPMD-399
> URL: https://issues.apache.org/jira/browse/MPMD-399
> Project: Maven PMD Plugin
>  Issue Type: Bug
>  Components: PMD
>Affects Versions: 3.22.0
>Reporter: AB-xdev
>Priority: Major
>
> PMD plugin is reporting the following warnings on in a multi-maven project:
> "The project X does not seem to be compiled. PMD results might be inaccurate."
> This is caused by the fact that not all modules have a
>  * {{src/main/java}} or
>  * {{src/test/java}} folder
> and therefore no {{target/classes}} or {{target/test-classes}} folders are 
> generated.
> The affected code that causes the problem can be found here:
> [https://github.com/apache/maven-pmd-plugin/blob/1961d771ea585e9344c25dfde194ee64a1b9040b/src/main/java/org/apache/maven/plugins/pmd/PmdReport.java#L516-L532]
> h3. Reproduction example
>  * Create a maven multi-module project
>  * Leave {{src/main/java}} of one module empty
>  * Execute {{pmd:aggregate-pmd}} or {{test pmd:aggregate-pmd-no-fork 
> -DskipTests}}
> → (x) Warning is reported
> h3. Possible fixes
> * Make it possible to ignore this warning
> * Do not warn when at least {{target/classes}} or {{target/test-classes}} is 
> present
>  



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (MPMD-399) Incorrect warning: The project X does not seem to be compiled. PMD results might be inaccurate.

2024-06-10 Thread AB-xdev (Jira)


[ 
https://issues.apache.org/jira/browse/MPMD-399?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17853657#comment-17853657
 ] 

AB-xdev commented on MPMD-399:
--

Well it then fails with some false positives (as the types are not resolved), 
but yes the warning is then gone.

I still prefer some incorrect warnings instead of FP, so I don't think this is 
a long term solution ;)

> Incorrect warning: The project X does not seem to be compiled. PMD results 
> might be inaccurate.
> ---
>
> Key: MPMD-399
> URL: https://issues.apache.org/jira/browse/MPMD-399
> Project: Maven PMD Plugin
>  Issue Type: Bug
>  Components: PMD
>Affects Versions: 3.22.0
>Reporter: AB-xdev
>Priority: Major
>
> PMD plugin is reporting the following warnings on in a multi-maven project:
> "The project X does not seem to be compiled. PMD results might be inaccurate."
> This is caused by the fact that not all modules have a
>  * {{src/main/java}} or
>  * {{src/test/java}} folder
> and therefore no {{target/classes}} or {{target/test-classes}} folders are 
> generated.
> The affected code that causes the problem can be found here:
> [https://github.com/apache/maven-pmd-plugin/blob/1961d771ea585e9344c25dfde194ee64a1b9040b/src/main/java/org/apache/maven/plugins/pmd/PmdReport.java#L516-L532]
> h3. Reproduction example
>  * Create a maven multi-module project
>  * Leave {{src/main/java}} of one module empty
>  * Execute {{pmd:aggregate-pmd}} or {{test pmd:aggregate-pmd-no-fork 
> -DskipTests}}
> → (x) Warning is reported
> h3. Possible fixes
> * Make it possible to ignore this warning
> * Do not warn when at least {{target/classes}} or {{target/test-classes}} is 
> present
>  



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (MNG-8150) Make SimplexTransferListener handle absent source/target files

2024-06-10 Thread ASF GitHub Bot (Jira)


[ 
https://issues.apache.org/jira/browse/MNG-8150?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17853656#comment-17853656
 ] 

ASF GitHub Bot commented on MNG-8150:
-

pshevche commented on PR #1575:
URL: https://github.com/apache/maven/pull/1575#issuecomment-2158289393

   > No, IMO records on master (Maven 4, that is Java 17) is ok, I just warned 
you when you try to backport this to maven-3.9.x branch...
   
   Makes sense, thank you. Here is the PR for backport: 
https://github.com/apache/maven/pull/1576




> Make SimplexTransferListener handle absent source/target files
> --
>
> Key: MNG-8150
> URL: https://issues.apache.org/jira/browse/MNG-8150
> Project: Maven
>  Issue Type: Improvement
>  Components: Core
>Affects Versions: 3.9.7
>Reporter: Pavlo Shevchenko
>Assignee: Tamas Cservenak
>Priority: Minor
> Fix For: 4.0.0, 3.9.8, 4.0.0-beta-4
>
>
> See the discussion: 
> [https://github.com/apache/maven/pull/1471/files#r1632930409]
> The `TransferResource#file` may be `null`. The current implementation of the 
> `SimplexTransferListener` cannot handle this case and will break with an NPE.
>  
> The fix should be merged to `master` and backported to `maven-3.9.x` branches.
>  
>  



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


Re: [PR] [MNG-8150] Handle absent source/target files in transfer listener [maven]

2024-06-10 Thread via GitHub


pshevche commented on PR #1575:
URL: https://github.com/apache/maven/pull/1575#issuecomment-2158289393

   > No, IMO records on master (Maven 4, that is Java 17) is ok, I just warned 
you when you try to backport this to maven-3.9.x branch...
   
   Makes sense, thank you. Here is the PR for backport: 
https://github.com/apache/maven/pull/1576


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[PR] Backport TransferListenerImprovements for Maven 3.9.x [maven]

2024-06-10 Thread via GitHub


pshevche opened a new pull request, #1576:
URL: https://github.com/apache/maven/pull/1576

   ## Summary
   Backporting https://github.com/apache/maven/pull/1575 to Maven 3.9.x.
   
- [x] I hereby declare this contribution to be licenced under the [Apache 
License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[jira] [Commented] (MNG-8150) Make SimplexTransferListener handle absent source/target files

2024-06-10 Thread ASF GitHub Bot (Jira)


[ 
https://issues.apache.org/jira/browse/MNG-8150?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17853654#comment-17853654
 ] 

ASF GitHub Bot commented on MNG-8150:
-

cstamas commented on PR #1575:
URL: https://github.com/apache/maven/pull/1575#issuecomment-2158279929

   No, IMO records on master (Maven 4, that is Java 17) is ok, I just warned 
you when you try to backport this to maven-3.9.x branch...




> Make SimplexTransferListener handle absent source/target files
> --
>
> Key: MNG-8150
> URL: https://issues.apache.org/jira/browse/MNG-8150
> Project: Maven
>  Issue Type: Improvement
>  Components: Core
>Affects Versions: 3.9.7
>Reporter: Pavlo Shevchenko
>Assignee: Tamas Cservenak
>Priority: Minor
> Fix For: 4.0.0, 3.9.8, 4.0.0-beta-4
>
>
> See the discussion: 
> [https://github.com/apache/maven/pull/1471/files#r1632930409]
> The `TransferResource#file` may be `null`. The current implementation of the 
> `SimplexTransferListener` cannot handle this case and will break with an NPE.
>  
> The fix should be merged to `master` and backported to `maven-3.9.x` branches.
>  
>  



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


  1   2   >