Re: [PR] Make mvnd-1.x buildable with Java 21 [maven-mvnd]

2024-06-13 Thread via GitHub


cstamas merged PR #1018:
URL: https://github.com/apache/maven-mvnd/pull/1018


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[PR] Make mvnd-1.x buildable with Java 21 [maven-mvnd]

2024-06-13 Thread via GitHub


cstamas opened a new pull request, #1018:
URL: https://github.com/apache/maven-mvnd/pull/1018

   So far it was buildable ONLY with Java 17, but only due single IT: it used 
old Quarkus version that refused to work on Java 21. Ported updates from mvnd 
master and now mvnd-1.x branch can also be build without any problem with Java 
21.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[jira] [Commented] (MRELEASE-1106) Target perform failed for non standard pom location

2024-06-13 Thread Stanislav Spiridonov (Jira)


[ 
https://issues.apache.org/jira/browse/MRELEASE-1106?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17854936#comment-17854936
 ] 

Stanislav Spiridonov commented on MRELEASE-1106:


No, bisect form what to what? M5 works, M6 no. Ot you suggested bissect from M6 
to M5 on commit level?

Anyway I am using 3.9.6 now and it works perfect. I think we can close this bug 
as outdated.

> Target perform failed for non standard pom location 
> 
>
> Key: MRELEASE-1106
> URL: https://issues.apache.org/jira/browse/MRELEASE-1106
> Project: Maven Release Plugin
>  Issue Type: Bug
>Affects Versions: 3.0.0-M6
> Environment: GitHub action
>Reporter: Stanislav Spiridonov
>Priority: Blocker
>
> My project uses the nonstandard location of pom.xml:
> inside pom folder
> e.g.
> {noformat}
> pom/pom.xml
> module/pom.xml{noformat}
> instead of
> {code:java}
> pom.xml
> module/pom.xml{code}
> Version 3.0.0-M6 fails to build it
> {noformat}
> [INFO] Executing: /bin/sh -c cd '/home/runner/work/gwt-time-apt/gwt-time-apt' 
> && 'git' 'commit' '--verbose' '-F' '/tmp/maven-scm-1301126221.commit'
> 2985[INFO] Working directory: /home/runner/work/gwt-time-apt/gwt-time-apt
> 2986[INFO] 17/17 prepare:end-release
> 2987[INFO] Release preparation complete.
> 2988[INFO] 
> 2989[INFO] --- maven-release-plugin:3.0.0-M6:perform (default-cli) @ 
> org.jresearch.gwt.time.apt.pom ---
> 2990[INFO] starting perform goal, composed of 3 phases: 
> verify-completed-prepare-phases, checkout-project-from-scm, run-perform-goals
> 2991[INFO] 1/3 perform:verify-completed-prepare-phases
> 2992[INFO] 2/3 perform:checkout-project-from-scm
> 2993[INFO] Performing a LOCAL checkout from 
> scm:git:file:///home/runner/work/gwt-time-apt/gwt-time-apt
> 2994[INFO] Checking out the project to perform the release ...
> 2995[INFO] Executing: /bin/sh -c cd 
> '/home/runner/work/gwt-time-apt/gwt-time-apt/pom/target' && 'git' 'clone' 
> '--depth' '1' '--branch' 'v2.0.9' 
> 'file:///home/runner/work/gwt-time-apt/gwt-time-apt' 'checkout'
> 2996[INFO] Working directory: 
> /home/runner/work/gwt-time-apt/gwt-time-apt/pom/target
> 2997[INFO] Executing: /bin/sh -c cd '/tmp' && 'git' 'ls-remote' 
> 'file:///home/runner/work/gwt-time-apt/gwt-time-apt'
> 2998[INFO] Working directory: /tmp
> 2999[INFO] Executing: /bin/sh -c cd 
> '/home/runner/work/gwt-time-apt/gwt-time-apt/pom/target/checkout' && 'git' 
> 'fetch' 'file:///home/runner/work/gwt-time-apt/gwt-time-apt'
> 3000[INFO] Working directory: 
> /home/runner/work/gwt-time-apt/gwt-time-apt/pom/target/checkout
> 3001[INFO] Executing: /bin/sh -c cd 
> '/home/runner/work/gwt-time-apt/gwt-time-apt/pom/target/checkout' && 'git' 
> 'checkout' 'v2.0.9'
> 3002[INFO] Working directory: 
> /home/runner/work/gwt-time-apt/gwt-time-apt/pom/target/checkout
> 3003[INFO] Executing: /bin/sh -c cd 
> '/home/runner/work/gwt-time-apt/gwt-time-apt/pom/target/checkout' && 'git' 
> 'ls-files'
> 3004[INFO] Working directory: 
> /home/runner/work/gwt-time-apt/gwt-time-apt/pom/target/checkout
> 3005[INFO] 3/3 perform:run-perform-goals
> 3006[INFO] Executing goals 'deploy'...
> 3007Error:  POM file pom/pom.xml specified with the -f/--file command line 
> argument does not exist
> 3008[INFO] [INFO] Scanning for projects...
> 3009Error:  [ERROR] Some problems were encountered while processing the POMs:
> 3010[INFO] [FATAL] Non-readable POM 
> /home/runner/work/gwt-time-apt/gwt-time-apt/pom/target/checkout/pom/pom/pom.xml:
>  
> /home/runner/work/gwt-time-apt/gwt-time-apt/pom/target/checkout/pom/pom/pom.xml
>  (No such file or directory) @ 
> 3011[INFO]  @ 
> 3012Error: [ERROR] The build could not read 1 project -> [Help 1]
> 3013Error: [ERROR]   
> 3014Error: [ERROR]   The project  
> (/home/runner/work/gwt-time-apt/gwt-time-apt/pom/target/checkout/pom/pom/pom.xml)
>  has 1 error
> 3015Error: [ERROR] Non-readable POM 
> /home/runner/work/gwt-time-apt/gwt-time-apt/pom/target/checkout/pom/pom/pom.xml:
>  
> /home/runner/work/gwt-time-apt/gwt-time-apt/pom/target/checkout/pom/pom/pom.xml
>  (No such file or directory)
> 3016Error: [ERROR] 
> 3017Error: [ERROR] To see the full stack trace of the errors, re-run Maven 
> with the -e switch.
> 3018Error: [ERROR] Re-run Maven using the -X switch to enable full debug 
> logging.
> 3019Error: [ERROR] 
> 3020Error: [ERROR] For more information about the errors and possible 
> solutions, please read the following articles:
> 3021Error: [ERROR] [Help 1] 
> http://cwiki.apache.org/confluence/display/MAVEN/ProjectBuildingException
> 3022[INFO] 
> 
> 3023[INFO] Reactor Summary for JRESEARCH-COMMONS: GWT time APT POM 
> 2.0.9-SNAPSHOT:
> 3024[INFO] 
> 3025[INFO] JRESEARCH-COMMONS: GWT time APT POM  FAILUR

[PR] Bump resolverVersion from 1.4.1 to 1.9.20 [maven-release]

2024-06-13 Thread via GitHub


dependabot[bot] opened a new pull request, #222:
URL: https://github.com/apache/maven-release/pull/222

   Bumps `resolverVersion` from 1.4.1 to 1.9.20.
   Updates `org.apache.maven.resolver:maven-resolver-api` from 1.4.1 to 1.9.20
   
   Release notes
   Sourced from https://github.com/apache/maven-resolver/releases";>org.apache.maven.resolver:maven-resolver-api's
 releases.
   
   1.9.20
   https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12320628&version=12354578";>Release
 Notes - Maven Resolver - Version 1.9.20
   
   
   
   What's Changed
   
   [MRESOLVER-547] Just use setVersion by https://github.com/cstamas";>@​cstamas in https://redirect.github.com/apache/maven-resolver/pull/483";>apache/maven-resolver#483
   [MRESOLVER-549] Parent POM 42 by https://github.com/cstamas";>@​cstamas in https://redirect.github.com/apache/maven-resolver/pull/484";>apache/maven-resolver#484
   
   Full Changelog: https://github.com/apache/maven-resolver/compare/maven-resolver-1.9.19...maven-resolver-1.9.20";>https://github.com/apache/maven-resolver/compare/maven-resolver-1.9.19...maven-resolver-1.9.20
   1.9.19
   https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12320628&version=12353946";>Release
 Notes - Maven Resolver - Version 1.9.19
   
   
   
   
   ... (truncated)
   
   
   Commits
   
   https://github.com/apache/maven-resolver/commit/f5fbc245e64091a41ba0926a6958b98bf0b29eb3";>f5fbc24
 [maven-release-plugin] prepare release maven-resolver-1.9.20
   https://github.com/apache/maven-resolver/commit/446009d7073014a7d418a4b9637664a2f6d05c82";>446009d
 [MRESOLVER-549][MRESOLVER-550][MRESOLVER-551] Parent POM 42 (https://redirect.github.com/apache/maven-resolver/issues/484";>#484)
   https://github.com/apache/maven-resolver/commit/4f16d5ecd94f85e6e7d793e6b6b82f20c9afbf56";>4f16d5e
 [MRESOLVER-547] Just use setVersion (https://redirect.github.com/apache/maven-resolver/issues/483";>#483)
   https://github.com/apache/maven-resolver/commit/c1b24c699621930f4eb77721400f2f6c46930626";>c1b24c6
 [maven-release-plugin] prepare for next development iteration
   https://github.com/apache/maven-resolver/commit/c1b03574961fd2daa7a678bb3fbf9f0779afee56";>c1b0357
 [maven-release-plugin] prepare release maven-resolver-1.9.19
   https://github.com/apache/maven-resolver/commit/adadd42d1642f39bafedb2ddd619b044fecb12b0";>adadd42
 [MRESOLVER-536] Do not belly up if FS does not support setting mtime (https://redirect.github.com/apache/maven-resolver/issues/469";>#469)
   https://github.com/apache/maven-resolver/commit/31df8a3dc503895172d277de56b1c4a53da0a27c";>31df8a3
 [1.9.x] Update dependencies (https://redirect.github.com/apache/maven-resolver/issues/462";>#462)
   https://github.com/apache/maven-resolver/commit/b225076e5d5b2fe3f166a4018802ac94b7cc94f7";>b225076
 [MRESOLVER-522] Improve congested file locks behaviour (https://redirect.github.com/apache/maven-resolver/issues/455";>#455) 
(https://redirect.github.com/apache/maven-resolver/issues/461";>#461)
   https://github.com/apache/maven-resolver/commit/fc969c2570041bb72c3f0141ff4957e8754f365c";>fc969c2
 [1.9.x][MRESOLVER-483] Fix path concatenation logic (https://redirect.github.com/apache/maven-resolver/issues/420";>#420)
   https://github.com/apache/maven-resolver/commit/a3e620d6d2ab6ca58d42d264347341b31da00dde";>a3e620d
 Use one Maven in CI
   Additional commits viewable in https://github.com/apache/maven-resolver/compare/maven-resolver-1.4.1...maven-resolver-1.9.20";>compare
 view
   
   
   
   
   Updates `org.apache.maven.resolver:maven-resolver-util` from 1.4.1 to 1.9.20
   
   Release notes
   Sourced from https://github.com/apache/maven-resolver/releases";>org.apache.maven.resolver:maven-resolver-util's
 releases.
   
   1.9.20
   https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12320628&version=12354578";>Release
 Notes - Maven Resolver - Version 1.9.20
   
   
   
   What's Changed
   
   [MRESOLVER-547] Just use setVersion by https://github.com/cstamas";>@​cstamas in https://redirect.github.com/apache/maven-resolver/pull/483";>apache/maven-resolver#483
   [MRESOLVER-549] Parent POM 42 by https://github.com/cstamas";>@​cstamas in https://redirect.github.com/apache/maven-resolver/pull/484";>apache/maven-resolver#484
   
   Full Changelog: https://github.com/apache/maven-resolver/compare/maven-resolver-1.9.19...maven-resolver-1.9.20";>https://github.com/apache/maven-resolver/compare/maven-resolver-1.9.19...maven-resolver-1.9.20
   1.9.19
   https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12320628&version=12353946";>Release
 Notes - Maven Resolver - Version 1.9.19
   
   
   
   
   ... (truncated)
   
   
   Commits
   
   https://github.com/apache/maven-resolver/commit/f5fbc245e64091a41ba0926a6958b98bf0b29eb3";>f5fbc24
 [maven-release-plugin] prepare release maven-resolver-1.9.20
   https://github.com/apache/maven-resolver/commit/446009d7073014a7d418a4b9637664a2f6d05c82";>446009d
 [MRESOLVER-549][MRESOLVE

[PR] [MSHARED-1411] - Allow to access the root content entries... [maven-shared-jar]

2024-06-13 Thread via GitHub


belingueres opened a new pull request, #40:
URL: https://github.com/apache/maven-shared-jar/pull/40

   ...if it is a multi-release JAR file


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[jira] [Created] (MNG-8156) mvn shell script should print the environment variables when “The JAVA_HOME environment variable is not defined correctly”

2024-06-13 Thread Didier Loiseau (Jira)
Didier Loiseau created MNG-8156:
---

 Summary: mvn shell script should print the environment variables 
when “The JAVA_HOME environment variable is not defined correctly”
 Key: MNG-8156
 URL: https://issues.apache.org/jira/browse/MNG-8156
 Project: Maven
  Issue Type: Improvement
  Components: Command Line
Affects Versions: 3.9.7
 Environment: Unix
Reporter: Didier Loiseau


When {{$JAVA_HOME}} is not properly set, it just prints:
{code}
The JAVA_HOME environment variable is not defined correctly,
this environment variable is needed to run this program.
{code}
and stops.

This is not very helpful as there is absolutely no indication of what is wrong 
exactly and how to fix it. For instance, in [this Stack Overflow 
question|https://stackoverflow.com/q/78614953/525036], the user had a correct 
{{$JAVA_HOME}}, but it was unknowingly overridden in their {{.mavenrc}}

The command should at least print the values of {{$JAVA_HOME}} and 
{{$JAVACMD}}, and ideally some additional help. Something like:
{quote}
JAVA_HOME: $JAVA_HOME
JAVACMD: $JAVACMD
If this is not what you expect, you should check the environment variables, the 
mavenrc file(s), and ensure that you have execution rights on the java 
executable.
You can try setting environment variable MAVEN_SKIP_RC=true to bypass mavenrc 
temporarily.
{quote}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


Re: [I] Too many open files on Mac OS with JDK 11 and mvnd 0.8.2 [maven-mvnd]

2024-06-13 Thread via GitHub


telemenar commented on issue #710:
URL: https://github.com/apache/maven-mvnd/issues/710#issuecomment-2166906072

   I've spent far too much time in the last day looking into this. I think I 
know what is happening though. 
   
   Graalvm doesn't support the `MaxFDLimit` flag at least according to this 
across both jdk/native variants in all versions:
   https://chriswhocodes.com/graalvm_native_image_jdk17_options.html
   
   Looking at the source code for graalvm: https://github.com/oracle/graal/
   
   There isn't any real option for interacting with RLIMIT_NOFILE except in a 
weird corner case during PosixNativeLibrary initialization. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] Remove hardcoded references to woodstox stax implementation [maven]

2024-06-13 Thread via GitHub


gnodet merged PR #1585:
URL: https://github.com/apache/maven/pull/1585


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] Bump jakarta.inject:jakarta.inject-api from 1.0 to 1.0.5 [maven-mvnd]

2024-06-13 Thread via GitHub


slachiewicz commented on PR #992:
URL: https://github.com/apache/maven-mvnd/pull/992#issuecomment-2166880302

   @dependabot recreate 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[jira] [Commented] (MDEPLOY-319) Cleanup of test code

2024-06-13 Thread ASF GitHub Bot (Jira)


[ 
https://issues.apache.org/jira/browse/MDEPLOY-319?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17854878#comment-17854878
 ] 

ASF GitHub Bot commented on MDEPLOY-319:


slawekjaranowski opened a new pull request, #58:
URL: https://github.com/apache/maven-deploy-plugin/pull/58

   Following this checklist to help us incorporate your 
   contribution quickly and easily:
   
- [ ] Make sure there is a [JIRA 
issue](https://issues.apache.org/jira/browse/MDEPLOY) filed 
  for the change (usually before you start working on it).  Trivial 
changes like typos do not 
  require a JIRA issue.  Your pull request should address just this 
issue, without 
  pulling in other changes.
- [ ] Each commit in the pull request should have a meaningful subject line 
and body.
- [ ] Format the pull request title like `[MDEPLOY-XXX] - Fixes bug in 
ApproximateQuantiles`,
  where you replace `MDEPLOY-XXX` with the appropriate JIRA issue. Best 
practice
  is to use the JIRA issue title in the pull request title and in the 
first line of the 
  commit message.
- [ ] Write a pull request description that is detailed enough to 
understand what the pull request does, how, and why.
- [ ] Run `mvn clean verify` to make sure basic checks pass. A more 
thorough check will 
  be performed on your pull request automatically.
- [ ] You have run the integration tests successfully (`mvn -Prun-its clean 
verify`).
   
   If your pull request is about ~20 lines of code you don't need to sign an
   [Individual Contributor License 
Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure
   please ask on the developers list.
   
   To make clear that you license your contribution under 
   the [Apache License Version 2.0, January 
2004](http://www.apache.org/licenses/LICENSE-2.0)
   you have to acknowledge this by using the following check-box.
   
- [ ] I hereby declare this contribution to be licenced under the [Apache 
License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
   
- [ ] In any other case, please file an [Apache Individual Contributor 
License Agreement](https://www.apache.org/licenses/icla.pdf).
   
   




> Cleanup of test code
> 
>
> Key: MDEPLOY-319
> URL: https://issues.apache.org/jira/browse/MDEPLOY-319
> Project: Maven Deploy Plugin
>  Issue Type: Task
>Reporter: Slawomir Jaranowski
>Assignee: Slawomir Jaranowski
>Priority: Major
> Fix For: next-release
>
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[PR] [MDEPLOY-319] Cleanup of test code [maven-deploy-plugin]

2024-06-13 Thread via GitHub


slawekjaranowski opened a new pull request, #58:
URL: https://github.com/apache/maven-deploy-plugin/pull/58

   Following this checklist to help us incorporate your 
   contribution quickly and easily:
   
- [ ] Make sure there is a [JIRA 
issue](https://issues.apache.org/jira/browse/MDEPLOY) filed 
  for the change (usually before you start working on it).  Trivial 
changes like typos do not 
  require a JIRA issue.  Your pull request should address just this 
issue, without 
  pulling in other changes.
- [ ] Each commit in the pull request should have a meaningful subject line 
and body.
- [ ] Format the pull request title like `[MDEPLOY-XXX] - Fixes bug in 
ApproximateQuantiles`,
  where you replace `MDEPLOY-XXX` with the appropriate JIRA issue. Best 
practice
  is to use the JIRA issue title in the pull request title and in the 
first line of the 
  commit message.
- [ ] Write a pull request description that is detailed enough to 
understand what the pull request does, how, and why.
- [ ] Run `mvn clean verify` to make sure basic checks pass. A more 
thorough check will 
  be performed on your pull request automatically.
- [ ] You have run the integration tests successfully (`mvn -Prun-its clean 
verify`).
   
   If your pull request is about ~20 lines of code you don't need to sign an
   [Individual Contributor License 
Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure
   please ask on the developers list.
   
   To make clear that you license your contribution under 
   the [Apache License Version 2.0, January 
2004](http://www.apache.org/licenses/LICENSE-2.0)
   you have to acknowledge this by using the following check-box.
   
- [ ] I hereby declare this contribution to be licenced under the [Apache 
License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
   
- [ ] In any other case, please file an [Apache Individual Contributor 
License Agreement](https://www.apache.org/licenses/icla.pdf).
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[jira] [Created] (MDEPLOY-319) Cleanup of test code

2024-06-13 Thread Slawomir Jaranowski (Jira)
Slawomir Jaranowski created MDEPLOY-319:
---

 Summary: Cleanup of test code
 Key: MDEPLOY-319
 URL: https://issues.apache.org/jira/browse/MDEPLOY-319
 Project: Maven Deploy Plugin
  Issue Type: Task
Reporter: Slawomir Jaranowski
Assignee: Slawomir Jaranowski
 Fix For: next-release






--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (MDEP-943) appendOutput for tree goal broken for multi-module project

2024-06-13 Thread Slawomir Jaranowski (Jira)


[ 
https://issues.apache.org/jira/browse/MDEP-943?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17854875#comment-17854875
 ] 

Slawomir Jaranowski commented on MDEP-943:
--

Thanks for reports ... looks like method {{DependencyUtil#write}} is broken
{code:java}
public static synchronized void write(String string, File file, boolean append, 
String encoding)
throws IOException {
Files.createDirectories(file.getParentFile().toPath());

try (Writer writer = Files.newBufferedWriter(file.toPath(), 
Charset.forName(encoding))) {
writer.write(string);
}
} {code}
{{append}} parameter is not used ...

> appendOutput for tree goal broken for multi-module project
> --
>
> Key: MDEP-943
> URL: https://issues.apache.org/jira/browse/MDEP-943
> Project: Maven Dependency Plugin
>  Issue Type: Bug
>Affects Versions: 3.7.0
>Reporter: Jim Sellers
>Priority: Major
>
> [appendOutput|https://maven.apache.org/plugins/maven-dependency-plugin/tree-mojo.html#appendOutput]
>  no longer seems to work for a multi-module project. It only has the 
> dependency tree for the last module.
> {code}
> # use example spring project
> git clone https://github.com/spring-guides/gs-multi-module.git
> cd gs-multi-module/complete
> # do a dependency tree
> mvn org.apache.maven.plugins:maven-dependency-plugin:3.6.1:tree 
> -DoutputFile=/tmp/tree-3.6.1.txt -DappendOutput=true
> mvn org.apache.maven.plugins:maven-dependency-plugin:3.7.0:tree 
> -DoutputFile=/tmp/tree-3.7.0.txt -DappendOutput=true
> diff /tmp/tree-3.6.1.txt /tmp/tree-3.7.0.txt
> wc -l /tmp/tree-3.*txt
>  123 /tmp/tree-3.6.1.txt
>1 /tmp/tree-3.7.0.txt
> {code}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


Re: [PR] Bump graalvm.version from 22.3.1 to 24.0.1 [maven-mvnd]

2024-06-13 Thread via GitHub


slachiewicz commented on PR #962:
URL: https://github.com/apache/maven-mvnd/pull/962#issuecomment-2166802988

   @dependabot recreate 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] Bump org.xmlunit:xmlunit-core from 2.9.1 to 2.10.0 [maven-release]

2024-06-13 Thread via GitHub


asfgit merged PR #214:
URL: https://github.com/apache/maven-release/pull/214


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] [MRELEASE-1147] @junitVersion@ never replaced in UTs (make explicit) [maven-release]

2024-06-13 Thread via GitHub


asfgit closed pull request #220: [MRELEASE-1147] @junitVersion@ never replaced 
in UTs (make explicit)
URL: https://github.com/apache/maven-release/pull/220


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[jira] [Commented] (MRELEASE-1064) [REGRESSION] release:branch uses @releaseLabel instead of @branchName in default SCM commit

2024-06-13 Thread ASF GitHub Bot (Jira)


[ 
https://issues.apache.org/jira/browse/MRELEASE-1064?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17854865#comment-17854865
 ] 

ASF GitHub Bot commented on MRELEASE-1064:
--

asfgit closed pull request #221: [MRELEASE-1064] [REGRESSION] release:branch 
uses @releaseLabel instea…
URL: https://github.com/apache/maven-release/pull/221




> [REGRESSION] release:branch uses @releaseLabel instead of @branchName in 
> default SCM commit
> ---
>
> Key: MRELEASE-1064
> URL: https://issues.apache.org/jira/browse/MRELEASE-1064
> Project: Maven Release Plugin
>  Issue Type: Bug
>  Components: branch
>Affects Versions: 3.0.0-M4
>Reporter: Jordan Amar
>Assignee: Michael Osipov
>Priority: Major
> Fix For: 3.1.0
>
>
> Calling plugin with this command: 
> {code:java}
> mvn release:branch -B -DbranchName=lol -DupdateBranchVersions=true 
> -DdryRun{code}
>  (dry run or not) will create a commit with the folling comment:
> _[maven-release-plugin] prepare branch @\{releaseLabel}_
> +branchName+ should be used instead +releaseLabel+ in scmBranchCommitComment



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


Re: [PR] Bump org.codehaus.plexus:plexus-interpolation from 1.26 to 1.27 [maven-release]

2024-06-13 Thread via GitHub


michael-o commented on PR #206:
URL: https://github.com/apache/maven-release/pull/206#issuecomment-2166740241

   @dependabot rebase


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[jira] [Closed] (MRELEASE-1064) [REGRESSION] release:branch uses @releaseLabel instead of @branchName in default SCM commit

2024-06-13 Thread Michael Osipov (Jira)


 [ 
https://issues.apache.org/jira/browse/MRELEASE-1064?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Michael Osipov closed MRELEASE-1064.

Resolution: Fixed

Fixed with 
[f3bbb7769da79cce175cf1e9b47a617e56195753|https://gitbox.apache.org/repos/asf?p=maven-release.git;a=commit;h=f3bbb7769da79cce175cf1e9b47a617e56195753].

> [REGRESSION] release:branch uses @releaseLabel instead of @branchName in 
> default SCM commit
> ---
>
> Key: MRELEASE-1064
> URL: https://issues.apache.org/jira/browse/MRELEASE-1064
> Project: Maven Release Plugin
>  Issue Type: Bug
>  Components: branch
>Affects Versions: 3.0.0-M4
>Reporter: Jordan Amar
>Assignee: Michael Osipov
>Priority: Major
> Fix For: 3.1.0
>
>
> Calling plugin with this command: 
> {code:java}
> mvn release:branch -B -DbranchName=lol -DupdateBranchVersions=true 
> -DdryRun{code}
>  (dry run or not) will create a commit with the folling comment:
> _[maven-release-plugin] prepare branch @\{releaseLabel}_
> +branchName+ should be used instead +releaseLabel+ in scmBranchCommitComment



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


Re: [PR] Bump org.codehaus.plexus:plexus-interactivity-api from 1.2 to 1.3 [maven-release]

2024-06-13 Thread via GitHub


michael-o commented on PR #210:
URL: https://github.com/apache/maven-release/pull/210#issuecomment-2166739975

   @dependabot rebase


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] Bump scmVersion from 2.0.1 to 2.1.0 [maven-release]

2024-06-13 Thread via GitHub


michael-o commented on PR #213:
URL: https://github.com/apache/maven-release/pull/213#issuecomment-2166739749

   @dependabot rebase


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] Bump org.xmlunit:xmlunit-core from 2.9.1 to 2.10.0 [maven-release]

2024-06-13 Thread via GitHub


michael-o commented on PR #214:
URL: https://github.com/apache/maven-release/pull/214#issuecomment-2166739560

   @dependabot rebase


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] Bump org.apache.maven.shared:maven-invoker from 3.2.0 to 3.3.0 [maven-release]

2024-06-13 Thread via GitHub


michael-o commented on PR #215:
URL: https://github.com/apache/maven-release/pull/215#issuecomment-2166739406

   @dependabot rebase


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] [MRELEASE-1064] [REGRESSION] release:branch uses @releaseLabel instea… [maven-release]

2024-06-13 Thread via GitHub


asfgit closed pull request #221: [MRELEASE-1064] [REGRESSION] release:branch 
uses @releaseLabel instea…
URL: https://github.com/apache/maven-release/pull/221


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[PR] [MRELEASE-1064] [REGRESSION] release:branch uses @releaseLabel instea… [maven-release]

2024-06-13 Thread via GitHub


michael-o opened a new pull request, #221:
URL: https://github.com/apache/maven-release/pull/221

   …d of @branchName in default SCM commit
   
   This closes #221
   
   Following this checklist to help us incorporate your 
   contribution quickly and easily:
   
- [ ] Make sure there is a [JIRA 
issue](https://issues.apache.org/jira/browse/MRELEASE) filed 
  for the change (usually before you start working on it).  Trivial 
changes like typos do not 
  require a JIRA issue.  Your pull request should address just this 
issue, without 
  pulling in other changes.
- [ ] Each commit in the pull request should have a meaningful subject line 
and body.
- [ ] Format the pull request title like `[MRELEASE-XXX] - Fixes bug in 
ApproximateQuantiles`,
  where you replace `MRELEASE-XXX` with the appropriate JIRA issue. 
Best practice
  is to use the JIRA issue title in the pull request title and in the 
first line of the 
  commit message.
- [ ] Write a pull request description that is detailed enough to 
understand what the pull request does, how, and why.
- [ ] Run `mvn clean verify -Prun-its` to make sure basic checks pass. A 
more thorough check will 
  be performed on your pull request automatically.
   
   If your pull request is about ~20 lines of code you don't need to sign an
   [Individual Contributor License 
Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure
   please ask on the developers list.
   
   To make clear that you license your contribution under 
   the [Apache License Version 2.0, January 
2004](http://www.apache.org/licenses/LICENSE-2.0)
   you have to acknowledge this by using the following check-box.
   
- [ ] I hereby declare this contribution to be licenced under the [Apache 
License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
   
- [ ] In any other case, please file an [Apache Individual Contributor 
License Agreement](https://www.apache.org/licenses/icla.pdf).
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[jira] [Commented] (MRELEASE-1064) [REGRESSION] release:branch uses @releaseLabel instead of @branchName in default SCM commit

2024-06-13 Thread ASF GitHub Bot (Jira)


[ 
https://issues.apache.org/jira/browse/MRELEASE-1064?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17854862#comment-17854862
 ] 

ASF GitHub Bot commented on MRELEASE-1064:
--

michael-o opened a new pull request, #221:
URL: https://github.com/apache/maven-release/pull/221

   …d of @branchName in default SCM commit
   
   This closes #221
   
   Following this checklist to help us incorporate your 
   contribution quickly and easily:
   
- [ ] Make sure there is a [JIRA 
issue](https://issues.apache.org/jira/browse/MRELEASE) filed 
  for the change (usually before you start working on it).  Trivial 
changes like typos do not 
  require a JIRA issue.  Your pull request should address just this 
issue, without 
  pulling in other changes.
- [ ] Each commit in the pull request should have a meaningful subject line 
and body.
- [ ] Format the pull request title like `[MRELEASE-XXX] - Fixes bug in 
ApproximateQuantiles`,
  where you replace `MRELEASE-XXX` with the appropriate JIRA issue. 
Best practice
  is to use the JIRA issue title in the pull request title and in the 
first line of the 
  commit message.
- [ ] Write a pull request description that is detailed enough to 
understand what the pull request does, how, and why.
- [ ] Run `mvn clean verify -Prun-its` to make sure basic checks pass. A 
more thorough check will 
  be performed on your pull request automatically.
   
   If your pull request is about ~20 lines of code you don't need to sign an
   [Individual Contributor License 
Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure
   please ask on the developers list.
   
   To make clear that you license your contribution under 
   the [Apache License Version 2.0, January 
2004](http://www.apache.org/licenses/LICENSE-2.0)
   you have to acknowledge this by using the following check-box.
   
- [ ] I hereby declare this contribution to be licenced under the [Apache 
License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
   
- [ ] In any other case, please file an [Apache Individual Contributor 
License Agreement](https://www.apache.org/licenses/icla.pdf).
   
   




> [REGRESSION] release:branch uses @releaseLabel instead of @branchName in 
> default SCM commit
> ---
>
> Key: MRELEASE-1064
> URL: https://issues.apache.org/jira/browse/MRELEASE-1064
> Project: Maven Release Plugin
>  Issue Type: Bug
>  Components: branch
>Affects Versions: 3.0.0-M4
>Reporter: Jordan Amar
>Assignee: Michael Osipov
>Priority: Major
> Fix For: 3.1.0
>
>
> Calling plugin with this command: 
> {code:java}
> mvn release:branch -B -DbranchName=lol -DupdateBranchVersions=true 
> -DdryRun{code}
>  (dry run or not) will create a commit with the folling comment:
> _[maven-release-plugin] prepare branch @\{releaseLabel}_
> +branchName+ should be used instead +releaseLabel+ in scmBranchCommitComment



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


Re: [PR] Fix deprecation warning about JAnsi Terminal [maven-mvnd]

2024-06-13 Thread via GitHub


wendigo commented on PR #1017:
URL: https://github.com/apache/maven-mvnd/pull/1017#issuecomment-2166583757

   Thanks for fixing this :)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[jira] [Created] (MDEP-943) appendOutput for tree goal broken for multi-module project

2024-06-13 Thread Jim Sellers (Jira)
Jim Sellers created MDEP-943:


 Summary: appendOutput for tree goal broken for multi-module project
 Key: MDEP-943
 URL: https://issues.apache.org/jira/browse/MDEP-943
 Project: Maven Dependency Plugin
  Issue Type: Bug
Affects Versions: 3.7.0
Reporter: Jim Sellers


[appendOutput|https://maven.apache.org/plugins/maven-dependency-plugin/tree-mojo.html#appendOutput]
 no longer seems to work for a multi-module project. It only has the dependency 
tree for the last module.

{code}
# use example spring project
git clone https://github.com/spring-guides/gs-multi-module.git
cd gs-multi-module/complete

# do a dependency tree
mvn org.apache.maven.plugins:maven-dependency-plugin:3.6.1:tree 
-DoutputFile=/tmp/tree-3.6.1.txt -DappendOutput=true
mvn org.apache.maven.plugins:maven-dependency-plugin:3.7.0:tree 
-DoutputFile=/tmp/tree-3.7.0.txt -DappendOutput=true
diff /tmp/tree-3.6.1.txt /tmp/tree-3.7.0.txt

wc -l /tmp/tree-3.*txt
 123 /tmp/tree-3.6.1.txt
   1 /tmp/tree-3.7.0.txt
{code}





--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Closed] (MRELEASE-989) prepare-with-pom - Cannot add release POM to SCM - API regression

2024-06-13 Thread Michael Osipov (Jira)


 [ 
https://issues.apache.org/jira/browse/MRELEASE-989?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Michael Osipov closed MRELEASE-989.
---
Resolution: Won't Fix

The {{svnjava}} provider is gone.

> prepare-with-pom - Cannot add release POM to SCM - API regression
> -
>
> Key: MRELEASE-989
> URL: https://issues.apache.org/jira/browse/MRELEASE-989
> Project: Maven Release Plugin
>  Issue Type: Bug
>  Components: prepare-with-pom, scm, Subversion
>Affects Versions: 2.5.3
> Environment: Apache Maven 3.5.0 
> (ff8f5e7444045639af65f6095c62210b5713f426; 2017-04-03T21:39:06+02:00)
> Maven home: D:\maven\apache-maven-3.5.0\bin\..
> Java version: 1.8.0_60, vendor: Oracle Corporation
> Java home: C:\Program Files\Java\jdk1.8.0_60\jre
> Default locale: de_DE, platform encoding: Cp1252
> OS name: "windows 7", version: "6.1", arch: "amd64", family: "windows"
>  Included: org.apache.maven.plugins:maven-release-plugin:jar:2.5.3
>  Included: 
> com.google.code.maven-scm-provider-svnjava:maven-scm-provider-svnjava:jar:2.1.1
>  Included: org.apache.maven.scm:maven-scm-provider-svn-commons:jar:1.8
>  Included: net.java.dev.jna:jna:jar:3.5.2
>  Included: commons-lang:commons-lang:jar:2.6
>  Included: commons-io:commons-io:jar:2.1
>  Included: org.tmatesoft.svnkit:svnkit:jar:1.8.7
>  Included: com.jcraft:jsch.agentproxy.svnkit-trilead-ssh2:jar:0.0.7
>  Included: com.jcraft:jsch.agentproxy.core:jar:0.0.7
>Reporter: Georg Tsakumagos
>Priority: Critical
> Attachments: maven-console.log
>
>
> Preparing a prepare-with-pom fails due to the changed SCM API.
> The ScmFileSet constructor needs a base path and a list of relative file 
> paths. The release plugin provides a full qualified path. The SCM concat the 
> full qualified path to the basepath and is not able to locate the file. The 
> path should be relative as described in JavaDoc. 
> May the problem arise to some svn scm implementation which interprets the 
> JavaDoc to precise. But hey thats the reason someone writes javadoc. The 
> constructor org.apache.maven.scm.ScmFileSet.ScmFileSet(File, List) 
> should check the restriction and fail fast. 



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (MRELEASE-1106) Target perform failed for non standard pom location

2024-06-13 Thread Michael Osipov (Jira)


[ 
https://issues.apache.org/jira/browse/MRELEASE-1106?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17854859#comment-17854859
 ] 

Michael Osipov commented on MRELEASE-1106:
--

[~foal], did you try to perform a bisect?

> Target perform failed for non standard pom location 
> 
>
> Key: MRELEASE-1106
> URL: https://issues.apache.org/jira/browse/MRELEASE-1106
> Project: Maven Release Plugin
>  Issue Type: Bug
>Affects Versions: 3.0.0-M6
> Environment: GitHub action
>Reporter: Stanislav Spiridonov
>Priority: Blocker
>
> My project uses the nonstandard location of pom.xml:
> inside pom folder
> e.g.
> {noformat}
> pom/pom.xml
> module/pom.xml{noformat}
> instead of
> {code:java}
> pom.xml
> module/pom.xml{code}
> Version 3.0.0-M6 fails to build it
> {noformat}
> [INFO] Executing: /bin/sh -c cd '/home/runner/work/gwt-time-apt/gwt-time-apt' 
> && 'git' 'commit' '--verbose' '-F' '/tmp/maven-scm-1301126221.commit'
> 2985[INFO] Working directory: /home/runner/work/gwt-time-apt/gwt-time-apt
> 2986[INFO] 17/17 prepare:end-release
> 2987[INFO] Release preparation complete.
> 2988[INFO] 
> 2989[INFO] --- maven-release-plugin:3.0.0-M6:perform (default-cli) @ 
> org.jresearch.gwt.time.apt.pom ---
> 2990[INFO] starting perform goal, composed of 3 phases: 
> verify-completed-prepare-phases, checkout-project-from-scm, run-perform-goals
> 2991[INFO] 1/3 perform:verify-completed-prepare-phases
> 2992[INFO] 2/3 perform:checkout-project-from-scm
> 2993[INFO] Performing a LOCAL checkout from 
> scm:git:file:///home/runner/work/gwt-time-apt/gwt-time-apt
> 2994[INFO] Checking out the project to perform the release ...
> 2995[INFO] Executing: /bin/sh -c cd 
> '/home/runner/work/gwt-time-apt/gwt-time-apt/pom/target' && 'git' 'clone' 
> '--depth' '1' '--branch' 'v2.0.9' 
> 'file:///home/runner/work/gwt-time-apt/gwt-time-apt' 'checkout'
> 2996[INFO] Working directory: 
> /home/runner/work/gwt-time-apt/gwt-time-apt/pom/target
> 2997[INFO] Executing: /bin/sh -c cd '/tmp' && 'git' 'ls-remote' 
> 'file:///home/runner/work/gwt-time-apt/gwt-time-apt'
> 2998[INFO] Working directory: /tmp
> 2999[INFO] Executing: /bin/sh -c cd 
> '/home/runner/work/gwt-time-apt/gwt-time-apt/pom/target/checkout' && 'git' 
> 'fetch' 'file:///home/runner/work/gwt-time-apt/gwt-time-apt'
> 3000[INFO] Working directory: 
> /home/runner/work/gwt-time-apt/gwt-time-apt/pom/target/checkout
> 3001[INFO] Executing: /bin/sh -c cd 
> '/home/runner/work/gwt-time-apt/gwt-time-apt/pom/target/checkout' && 'git' 
> 'checkout' 'v2.0.9'
> 3002[INFO] Working directory: 
> /home/runner/work/gwt-time-apt/gwt-time-apt/pom/target/checkout
> 3003[INFO] Executing: /bin/sh -c cd 
> '/home/runner/work/gwt-time-apt/gwt-time-apt/pom/target/checkout' && 'git' 
> 'ls-files'
> 3004[INFO] Working directory: 
> /home/runner/work/gwt-time-apt/gwt-time-apt/pom/target/checkout
> 3005[INFO] 3/3 perform:run-perform-goals
> 3006[INFO] Executing goals 'deploy'...
> 3007Error:  POM file pom/pom.xml specified with the -f/--file command line 
> argument does not exist
> 3008[INFO] [INFO] Scanning for projects...
> 3009Error:  [ERROR] Some problems were encountered while processing the POMs:
> 3010[INFO] [FATAL] Non-readable POM 
> /home/runner/work/gwt-time-apt/gwt-time-apt/pom/target/checkout/pom/pom/pom.xml:
>  
> /home/runner/work/gwt-time-apt/gwt-time-apt/pom/target/checkout/pom/pom/pom.xml
>  (No such file or directory) @ 
> 3011[INFO]  @ 
> 3012Error: [ERROR] The build could not read 1 project -> [Help 1]
> 3013Error: [ERROR]   
> 3014Error: [ERROR]   The project  
> (/home/runner/work/gwt-time-apt/gwt-time-apt/pom/target/checkout/pom/pom/pom.xml)
>  has 1 error
> 3015Error: [ERROR] Non-readable POM 
> /home/runner/work/gwt-time-apt/gwt-time-apt/pom/target/checkout/pom/pom/pom.xml:
>  
> /home/runner/work/gwt-time-apt/gwt-time-apt/pom/target/checkout/pom/pom/pom.xml
>  (No such file or directory)
> 3016Error: [ERROR] 
> 3017Error: [ERROR] To see the full stack trace of the errors, re-run Maven 
> with the -e switch.
> 3018Error: [ERROR] Re-run Maven using the -X switch to enable full debug 
> logging.
> 3019Error: [ERROR] 
> 3020Error: [ERROR] For more information about the errors and possible 
> solutions, please read the following articles:
> 3021Error: [ERROR] [Help 1] 
> http://cwiki.apache.org/confluence/display/MAVEN/ProjectBuildingException
> 3022[INFO] 
> 
> 3023[INFO] Reactor Summary for JRESEARCH-COMMONS: GWT time APT POM 
> 2.0.9-SNAPSHOT:
> 3024[INFO] 
> 3025[INFO] JRESEARCH-COMMONS: GWT time APT POM  FAILURE 
> [01:00 min]
> 3026[INFO] JRESEARCH-COMMONS: GWT time support APT annotations  SKIPPED
> 3027[INFO] JRESEARCH-COMMONS: GWT time support APT processor .. SKIPPED
> 30

[jira] [Closed] (MRELEASE-1145) Upgrade to Maven 3.6.3

2024-06-13 Thread Michael Osipov (Jira)


 [ 
https://issues.apache.org/jira/browse/MRELEASE-1145?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Michael Osipov closed MRELEASE-1145.

Resolution: Fixed

Fixed with 
[fa6c3db04d76adcae2b1388999cf1f413b19de1c|https://gitbox.apache.org/repos/asf?p=maven-release.git;a=commit;h=fa6c3db04d76adcae2b1388999cf1f413b19de1c].

> Upgrade to Maven 3.6.3
> --
>
> Key: MRELEASE-1145
> URL: https://issues.apache.org/jira/browse/MRELEASE-1145
> Project: Maven Release Plugin
>  Issue Type: Dependency upgrade
>Reporter: Michael Osipov
>Assignee: Michael Osipov
>Priority: Major
> Fix For: 3.1.0
>
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (MRELEASE-1145) Upgrade to Maven 3.6.3

2024-06-13 Thread ASF GitHub Bot (Jira)


[ 
https://issues.apache.org/jira/browse/MRELEASE-1145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17854855#comment-17854855
 ] 

ASF GitHub Bot commented on MRELEASE-1145:
--

asfgit closed pull request #217: [MRELEASE-1145] Upgrade to Maven 3.6.3
URL: https://github.com/apache/maven-release/pull/217




> Upgrade to Maven 3.6.3
> --
>
> Key: MRELEASE-1145
> URL: https://issues.apache.org/jira/browse/MRELEASE-1145
> Project: Maven Release Plugin
>  Issue Type: Dependency upgrade
>Reporter: Michael Osipov
>Assignee: Michael Osipov
>Priority: Major
> Fix For: 3.1.0
>
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (MRELEASE-1145) Upgrade to Maven 3.6.3

2024-06-13 Thread ASF GitHub Bot (Jira)


[ 
https://issues.apache.org/jira/browse/MRELEASE-1145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17854856#comment-17854856
 ] 

ASF GitHub Bot commented on MRELEASE-1145:
--

asfgit merged PR #217:
URL: https://github.com/apache/maven-release/pull/217




> Upgrade to Maven 3.6.3
> --
>
> Key: MRELEASE-1145
> URL: https://issues.apache.org/jira/browse/MRELEASE-1145
> Project: Maven Release Plugin
>  Issue Type: Dependency upgrade
>Reporter: Michael Osipov
>Assignee: Michael Osipov
>Priority: Major
> Fix For: 3.1.0
>
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)


Re: [PR] [MRELEASE-1145] Upgrade to Maven 3.6.3 [maven-release]

2024-06-13 Thread via GitHub


asfgit merged PR #217:
URL: https://github.com/apache/maven-release/pull/217


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] [MRELEASE-1145] Upgrade to Maven 3.6.3 [maven-release]

2024-06-13 Thread via GitHub


asfgit closed pull request #217: [MRELEASE-1145] Upgrade to Maven 3.6.3
URL: https://github.com/apache/maven-release/pull/217


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] Fix deprecation warning about JAnsi Terminal [maven-mvnd]

2024-06-13 Thread via GitHub


cstamas merged PR #1017:
URL: https://github.com/apache/maven-mvnd/pull/1017


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] [MDEPLOY-311] Pass on 'packaging' when creating artifact to upload [maven-deploy-plugin]

2024-06-13 Thread via GitHub


EnigmaTriton commented on code in PR #42:
URL: 
https://github.com/apache/maven-deploy-plugin/pull/42#discussion_r1638662304


##
src/main/java/org/apache/maven/plugins/deploy/DeployFileMojo.java:
##
@@ -274,9 +274,7 @@ public void execute() throws MojoExecutionException, 
MojoFailureException {
 classifier = artifactType.getClassifier();
 }
 }
-Artifact mainArtifact = new DefaultArtifact(
-groupId, artifactId, classifier, isFilePom ? "pom" : 
getExtension(file), version)
-.setFile(file);
+Artifact mainArtifact = new DefaultArtifact(groupId, artifactId, 
classifier, packaging, version).setFile(file);

Review Comment:
   According to the 
[documentation|https://maven.apache.org/plugins/maven-deploy-plugin/deploy-file-mojo.html],
 `packaging` designate the “Type of the artifact to be deployed. Retrieved from 
the  element of the POM file if a POM file specified. Defaults to 
the file extension if it is not specified via command line or POM.”
   
   The way I read it, it means that the `packaging` tag takes precedence 
(whether from command line or from the POM), followed by the extension of the 
file to upload as a fallback.
   
   I just hit this issue (MDEPLOY-311) because we generate a zip file using the 
truezip plugin (that relies on the extension) and then we need to deploy using 
a different extension.
   The `.epub` ebooks (used for documentation) are really `.zip` files with a 
specific content but this is true for quite a lot of other formats as well so 
there really is a use-case for using `` with a different extension 
than the one on the deployed file.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[jira] [Updated] (MRELEASE-1064) [REGRESSION] release:branch uses @releaseLabel instead of @branchName in default SCM commit

2024-06-13 Thread Michael Osipov (Jira)


 [ 
https://issues.apache.org/jira/browse/MRELEASE-1064?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Michael Osipov updated MRELEASE-1064:
-
Fix Version/s: 3.1.0

> [REGRESSION] release:branch uses @releaseLabel instead of @branchName in 
> default SCM commit
> ---
>
> Key: MRELEASE-1064
> URL: https://issues.apache.org/jira/browse/MRELEASE-1064
> Project: Maven Release Plugin
>  Issue Type: Bug
>  Components: branch
>Affects Versions: 3.0.0-M4
>Reporter: Jordan Amar
>Assignee: Michael Osipov
>Priority: Major
> Fix For: 3.1.0
>
>
> Calling plugin with this command: 
> {code:java}
> mvn release:branch -B -DbranchName=lol -DupdateBranchVersions=true 
> -DdryRun{code}
>  (dry run or not) will create a commit with the folling comment:
> _[maven-release-plugin] prepare branch @\{releaseLabel}_
> +branchName+ should be used instead +releaseLabel+ in scmBranchCommitComment



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (MRELEASE-1138) [REGRESSION] @{releaseLabel} variable is not resolved in the commit message of the branch goal

2024-06-13 Thread Michael Osipov (Jira)


[ 
https://issues.apache.org/jira/browse/MRELEASE-1138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17854850#comment-17854850
 ] 

Michael Osipov commented on MRELEASE-1138:
--

[~mosermw], confirmed. Please follow the other issue. Working on a fix.

> [REGRESSION] @{releaseLabel} variable is not resolved in the commit message 
> of the branch goal
> --
>
> Key: MRELEASE-1138
> URL: https://issues.apache.org/jira/browse/MRELEASE-1138
> Project: Maven Release Plugin
>  Issue Type: Bug
>  Components: branch
>Affects Versions: 3.0.1
>Reporter: Thomas Mortagne
>Priority: Major
>
> We get the following commit message since the upgrade to the release plugin 
> 3.0.1 (from 2.5.3): "[maven-release-plugin] prepare branch @{releaseLabel}" 
> (see 
> https://github.com/xwiki/xwiki-commons/commit/4e7eba27102a6c3c4954cf8dd7925232b8858157
>  for an example).
> We used the following command line in this case:
> {code}
> mvn release:branch -DbranchName=stable-16.0.x -DautoVersionSubmodules 
> -DdevelopmentVersion=16.1.0-SNAPSHOT -DpushChanges=false 
> -Pci,integration-tests,office-tests,legacy,standalone,flavor-integration-tests,distribution,docker
> {code}
> Before the upgrade, we used to get messages like "[maven-release-plugin] 
> prepare branch stable-14.6.x" with the same command line (except for the 
> versions related parameters values, of course).
> The release prepare goal message which contains the same variable according 
> to the documentation does not seem to have the same problem as we get 
> "[maven-release-plugin] prepare release xwiki-commons-16.0.0-rc-1" (see 
> https://github.com/xwiki/xwiki-commons/commit/716ed16279968ea1a251cfbcb200893f9f43735c
>  for example) with command line
> {code}
>   mvn --batch-mode release:prepare -DpushChanges=false -DlocalCheckout=true 
> -DreleaseVersion=16.0.0-rc-1 -DdevelopmentVersion=16.0.0-SNAPSHOT 
> -Dtag=xwiki-commons-16.0.0-rc-1 -DautoVersionSubmodules=true 
> -Plegacy,integration-tests,office-tests,standalone,flavor-integration-tests,distribution,docker
> {code}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Assigned] (MRELEASE-1064) [REGRESSION] release:branch uses @releaseLabel instead of @branchName in default SCM commit

2024-06-13 Thread Michael Osipov (Jira)


 [ 
https://issues.apache.org/jira/browse/MRELEASE-1064?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Michael Osipov reassigned MRELEASE-1064:


Assignee: Michael Osipov

> [REGRESSION] release:branch uses @releaseLabel instead of @branchName in 
> default SCM commit
> ---
>
> Key: MRELEASE-1064
> URL: https://issues.apache.org/jira/browse/MRELEASE-1064
> Project: Maven Release Plugin
>  Issue Type: Bug
>  Components: branch
>Affects Versions: 3.0.0-M4
>Reporter: Jordan Amar
>Assignee: Michael Osipov
>Priority: Major
>
> Calling plugin with this command: 
> {code:java}
> mvn release:branch -B -DbranchName=lol -DupdateBranchVersions=true 
> -DdryRun{code}
>  (dry run or not) will create a commit with the folling comment:
> _[maven-release-plugin] prepare branch @\{releaseLabel}_
> +branchName+ should be used instead +releaseLabel+ in scmBranchCommitComment



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Closed] (MRELEASE-1138) [REGRESSION] @{releaseLabel} variable is not resolved in the commit message of the branch goal

2024-06-13 Thread Michael Osipov (Jira)


 [ 
https://issues.apache.org/jira/browse/MRELEASE-1138?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Michael Osipov closed MRELEASE-1138.

Resolution: Duplicate

> [REGRESSION] @{releaseLabel} variable is not resolved in the commit message 
> of the branch goal
> --
>
> Key: MRELEASE-1138
> URL: https://issues.apache.org/jira/browse/MRELEASE-1138
> Project: Maven Release Plugin
>  Issue Type: Bug
>  Components: branch
>Affects Versions: 3.0.1
>Reporter: Thomas Mortagne
>Priority: Major
>
> We get the following commit message since the upgrade to the release plugin 
> 3.0.1 (from 2.5.3): "[maven-release-plugin] prepare branch @{releaseLabel}" 
> (see 
> https://github.com/xwiki/xwiki-commons/commit/4e7eba27102a6c3c4954cf8dd7925232b8858157
>  for an example).
> We used the following command line in this case:
> {code}
> mvn release:branch -DbranchName=stable-16.0.x -DautoVersionSubmodules 
> -DdevelopmentVersion=16.1.0-SNAPSHOT -DpushChanges=false 
> -Pci,integration-tests,office-tests,legacy,standalone,flavor-integration-tests,distribution,docker
> {code}
> Before the upgrade, we used to get messages like "[maven-release-plugin] 
> prepare branch stable-14.6.x" with the same command line (except for the 
> versions related parameters values, of course).
> The release prepare goal message which contains the same variable according 
> to the documentation does not seem to have the same problem as we get 
> "[maven-release-plugin] prepare release xwiki-commons-16.0.0-rc-1" (see 
> https://github.com/xwiki/xwiki-commons/commit/716ed16279968ea1a251cfbcb200893f9f43735c
>  for example) with command line
> {code}
>   mvn --batch-mode release:prepare -DpushChanges=false -DlocalCheckout=true 
> -DreleaseVersion=16.0.0-rc-1 -DdevelopmentVersion=16.0.0-SNAPSHOT 
> -Dtag=xwiki-commons-16.0.0-rc-1 -DautoVersionSubmodules=true 
> -Plegacy,integration-tests,office-tests,standalone,flavor-integration-tests,distribution,docker
> {code}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (MRELEASE-1064) release:branch uses @releaseLabel instead of @branchName in default scm commit

2024-06-13 Thread Michael Osipov (Jira)


[ 
https://issues.apache.org/jira/browse/MRELEASE-1064?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17854849#comment-17854849
 ] 

Michael Osipov commented on MRELEASE-1064:
--

The next week turned out to be three years...

> release:branch uses @releaseLabel instead of @branchName in default scm commit
> --
>
> Key: MRELEASE-1064
> URL: https://issues.apache.org/jira/browse/MRELEASE-1064
> Project: Maven Release Plugin
>  Issue Type: Bug
>  Components: branch
>Affects Versions: 3.0.0-M4
>Reporter: Jordan Amar
>Priority: Major
>
> Calling plugin with this command: 
> {code:java}
> mvn release:branch -B -DbranchName=lol -DupdateBranchVersions=true 
> -DdryRun{code}
>  (dry run or not) will create a commit with the folling comment:
> _[maven-release-plugin] prepare branch @\{releaseLabel}_
> +branchName+ should be used instead +releaseLabel+ in scmBranchCommitComment



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Updated] (MRELEASE-1064) [REGRESSION] release:branch uses @releaseLabel instead of @branchName in default SCM commit

2024-06-13 Thread Michael Osipov (Jira)


 [ 
https://issues.apache.org/jira/browse/MRELEASE-1064?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Michael Osipov updated MRELEASE-1064:
-
Summary: [REGRESSION] release:branch uses @releaseLabel instead of 
@branchName in default SCM commit  (was: release:branch uses @releaseLabel 
instead of @branchName in default scm commit)

> [REGRESSION] release:branch uses @releaseLabel instead of @branchName in 
> default SCM commit
> ---
>
> Key: MRELEASE-1064
> URL: https://issues.apache.org/jira/browse/MRELEASE-1064
> Project: Maven Release Plugin
>  Issue Type: Bug
>  Components: branch
>Affects Versions: 3.0.0-M4
>Reporter: Jordan Amar
>Priority: Major
>
> Calling plugin with this command: 
> {code:java}
> mvn release:branch -B -DbranchName=lol -DupdateBranchVersions=true 
> -DdryRun{code}
>  (dry run or not) will create a commit with the folling comment:
> _[maven-release-plugin] prepare branch @\{releaseLabel}_
> +branchName+ should be used instead +releaseLabel+ in scmBranchCommitComment



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Updated] (MRELEASE-1138) [REGRESSION] @{releaseLabel} variable is not resolved in the commit message of the branch goal

2024-06-13 Thread Michael Osipov (Jira)


 [ 
https://issues.apache.org/jira/browse/MRELEASE-1138?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Michael Osipov updated MRELEASE-1138:
-
Summary: [REGRESSION] @{releaseLabel} variable is not resolved in the 
commit message of the branch goal  (was: Regression: @{releaseLabel} variable 
is not resolved in the commit message of the branch goal)

> [REGRESSION] @{releaseLabel} variable is not resolved in the commit message 
> of the branch goal
> --
>
> Key: MRELEASE-1138
> URL: https://issues.apache.org/jira/browse/MRELEASE-1138
> Project: Maven Release Plugin
>  Issue Type: Bug
>  Components: branch
>Affects Versions: 3.0.1
>Reporter: Thomas Mortagne
>Priority: Major
>
> We get the following commit message since the upgrade to the release plugin 
> 3.0.1 (from 2.5.3): "[maven-release-plugin] prepare branch @{releaseLabel}" 
> (see 
> https://github.com/xwiki/xwiki-commons/commit/4e7eba27102a6c3c4954cf8dd7925232b8858157
>  for an example).
> We used the following command line in this case:
> {code}
> mvn release:branch -DbranchName=stable-16.0.x -DautoVersionSubmodules 
> -DdevelopmentVersion=16.1.0-SNAPSHOT -DpushChanges=false 
> -Pci,integration-tests,office-tests,legacy,standalone,flavor-integration-tests,distribution,docker
> {code}
> Before the upgrade, we used to get messages like "[maven-release-plugin] 
> prepare branch stable-14.6.x" with the same command line (except for the 
> versions related parameters values, of course).
> The release prepare goal message which contains the same variable according 
> to the documentation does not seem to have the same problem as we get 
> "[maven-release-plugin] prepare release xwiki-commons-16.0.0-rc-1" (see 
> https://github.com/xwiki/xwiki-commons/commit/716ed16279968ea1a251cfbcb200893f9f43735c
>  for example) with command line
> {code}
>   mvn --batch-mode release:prepare -DpushChanges=false -DlocalCheckout=true 
> -DreleaseVersion=16.0.0-rc-1 -DdevelopmentVersion=16.0.0-SNAPSHOT 
> -Dtag=xwiki-commons-16.0.0-rc-1 -DautoVersionSubmodules=true 
> -Plegacy,integration-tests,office-tests,standalone,flavor-integration-tests,distribution,docker
> {code}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Closed] (MRELEASE-1147) @junitVersion@ never replaced in UTs (make explicit)

2024-06-13 Thread Michael Osipov (Jira)


 [ 
https://issues.apache.org/jira/browse/MRELEASE-1147?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Michael Osipov closed MRELEASE-1147.

Resolution: Fixed

Fixed with 
[167db81e121bfe1fad59a7fa7a403ce97c4dd18d|https://gitbox.apache.org/repos/asf?p=maven-release.git;a=commit;h=167db81e121bfe1fad59a7fa7a403ce97c4dd18d].

> @junitVersion@ never replaced in UTs (make explicit)
> 
>
> Key: MRELEASE-1147
> URL: https://issues.apache.org/jira/browse/MRELEASE-1147
> Project: Maven Release Plugin
>  Issue Type: Bug
>Affects Versions: 3.0.1
>Reporter: Michael Osipov
>Assignee: Michael Osipov
>Priority: Major
> Fix For: 3.1.0
>
>
> Maven Release Manager contains UTs which are supposed to resolve a 
> {{@junitVersion@}}, but this something like this only happens in ITs. Before 
> this starts to fail with newer Resolver versions we should make those 
> placeholders explicit.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (MRELEASE-1147) @junitVersion@ never replaced in UTs (make explicit)

2024-06-13 Thread ASF GitHub Bot (Jira)


[ 
https://issues.apache.org/jira/browse/MRELEASE-1147?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17854847#comment-17854847
 ] 

ASF GitHub Bot commented on MRELEASE-1147:
--

asfgit closed pull request #220: [MRELEASE-1147] @junitVersion@ never replaced 
in UTs (make explicit)
URL: https://github.com/apache/maven-release/pull/220




> @junitVersion@ never replaced in UTs (make explicit)
> 
>
> Key: MRELEASE-1147
> URL: https://issues.apache.org/jira/browse/MRELEASE-1147
> Project: Maven Release Plugin
>  Issue Type: Bug
>Affects Versions: 3.0.1
>Reporter: Michael Osipov
>Assignee: Michael Osipov
>Priority: Major
> Fix For: 3.1.0
>
>
> Maven Release Manager contains UTs which are supposed to resolve a 
> {{@junitVersion@}}, but this something like this only happens in ITs. Before 
> this starts to fail with newer Resolver versions we should make those 
> placeholders explicit.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (MRELEASE-1147) @junitVersion@ never replaced in UTs (make explicit)

2024-06-13 Thread ASF GitHub Bot (Jira)


[ 
https://issues.apache.org/jira/browse/MRELEASE-1147?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17854848#comment-17854848
 ] 

ASF GitHub Bot commented on MRELEASE-1147:
--

asfgit merged PR #220:
URL: https://github.com/apache/maven-release/pull/220




> @junitVersion@ never replaced in UTs (make explicit)
> 
>
> Key: MRELEASE-1147
> URL: https://issues.apache.org/jira/browse/MRELEASE-1147
> Project: Maven Release Plugin
>  Issue Type: Bug
>Affects Versions: 3.0.1
>Reporter: Michael Osipov
>Assignee: Michael Osipov
>Priority: Major
> Fix For: 3.1.0
>
>
> Maven Release Manager contains UTs which are supposed to resolve a 
> {{@junitVersion@}}, but this something like this only happens in ITs. Before 
> this starts to fail with newer Resolver versions we should make those 
> placeholders explicit.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


Re: [PR] [MRELEASE-1147] @junitVersion@ never replaced in UTs (make explicit) [maven-release]

2024-06-13 Thread via GitHub


asfgit merged PR #220:
URL: https://github.com/apache/maven-release/pull/220


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[jira] [Commented] (MRELEASE-1148) Release Manager pulls in transitive dependencies

2024-06-13 Thread ASF GitHub Bot (Jira)


[ 
https://issues.apache.org/jira/browse/MRELEASE-1148?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17854840#comment-17854840
 ] 

ASF GitHub Bot commented on MRELEASE-1148:
--

asfgit closed pull request #219: [MRELEASE-1148] Release Manage pulls in 
transitive dependencies
URL: https://github.com/apache/maven-release/pull/219




> Release Manager pulls in transitive dependencies
> 
>
> Key: MRELEASE-1148
> URL: https://issues.apache.org/jira/browse/MRELEASE-1148
> Project: Maven Release Plugin
>  Issue Type: Bug
>Affects Versions: 3.0.1
>Reporter: Michael Osipov
>Assignee: Michael Osipov
>Priority: Major
> Fix For: 3.1.0
>
>
> When a release POM is generated all (including transitive) artifacts are 
> flattened. This can cause test dependencies from dependencies to be inlined 
> which is not desired. Rely on on direct dependencies.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


Re: [PR] [MJAVADOC-796] Do not follow links for Java 12+ [maven-javadoc-plugin]

2024-06-13 Thread via GitHub


asfgit merged PR #287:
URL: https://github.com/apache/maven-javadoc-plugin/pull/287


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[jira] [Commented] (MRELEASE-1147) @junitVersion@ never replaced in UTs (make explicit)

2024-06-13 Thread ASF GitHub Bot (Jira)


[ 
https://issues.apache.org/jira/browse/MRELEASE-1147?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17854842#comment-17854842
 ] 

ASF GitHub Bot commented on MRELEASE-1147:
--

michael-o opened a new pull request, #220:
URL: https://github.com/apache/maven-release/pull/220

   This closes #220
   
   Following this checklist to help us incorporate your 
   contribution quickly and easily:
   
- [ ] Make sure there is a [JIRA 
issue](https://issues.apache.org/jira/browse/MRELEASE) filed 
  for the change (usually before you start working on it).  Trivial 
changes like typos do not 
  require a JIRA issue.  Your pull request should address just this 
issue, without 
  pulling in other changes.
- [ ] Each commit in the pull request should have a meaningful subject line 
and body.
- [ ] Format the pull request title like `[MRELEASE-XXX] - Fixes bug in 
ApproximateQuantiles`,
  where you replace `MRELEASE-XXX` with the appropriate JIRA issue. 
Best practice
  is to use the JIRA issue title in the pull request title and in the 
first line of the 
  commit message.
- [ ] Write a pull request description that is detailed enough to 
understand what the pull request does, how, and why.
- [ ] Run `mvn clean verify -Prun-its` to make sure basic checks pass. A 
more thorough check will 
  be performed on your pull request automatically.
   
   If your pull request is about ~20 lines of code you don't need to sign an
   [Individual Contributor License 
Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure
   please ask on the developers list.
   
   To make clear that you license your contribution under 
   the [Apache License Version 2.0, January 
2004](http://www.apache.org/licenses/LICENSE-2.0)
   you have to acknowledge this by using the following check-box.
   
- [ ] I hereby declare this contribution to be licenced under the [Apache 
License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
   
- [ ] In any other case, please file an [Apache Individual Contributor 
License Agreement](https://www.apache.org/licenses/icla.pdf).
   
   




> @junitVersion@ never replaced in UTs (make explicit)
> 
>
> Key: MRELEASE-1147
> URL: https://issues.apache.org/jira/browse/MRELEASE-1147
> Project: Maven Release Plugin
>  Issue Type: Bug
>Affects Versions: 3.0.1
>Reporter: Michael Osipov
>Assignee: Michael Osipov
>Priority: Major
> Fix For: 3.1.0
>
>
> Maven Release Manager contains UTs which are supposed to resolve a 
> {{@junitVersion@}}, but this something like this only happens in ITs. Before 
> this starts to fail with newer Resolver versions we should make those 
> placeholders explicit.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Closed] (MRELEASE-1148) Release Manager pulls in transitive dependencies

2024-06-13 Thread Michael Osipov (Jira)


 [ 
https://issues.apache.org/jira/browse/MRELEASE-1148?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Michael Osipov closed MRELEASE-1148.

Resolution: Fixed

Fixed with 
[7249d1f69251e8c7ae4cf379f88be802a14d2eed|https://gitbox.apache.org/repos/asf?p=maven-release.git;a=commit;h=7249d1f69251e8c7ae4cf379f88be802a14d2eed].

> Release Manager pulls in transitive dependencies
> 
>
> Key: MRELEASE-1148
> URL: https://issues.apache.org/jira/browse/MRELEASE-1148
> Project: Maven Release Plugin
>  Issue Type: Bug
>Affects Versions: 3.0.1
>Reporter: Michael Osipov
>Assignee: Michael Osipov
>Priority: Major
> Fix For: 3.1.0
>
>
> When a release POM is generated all (including transitive) artifacts are 
> flattened. This can cause test dependencies from dependencies to be inlined 
> which is not desired. Rely on on direct dependencies.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[PR] [MRELEASE-1147] @junitVersion@ never replaced in UTs (make explicit) [maven-release]

2024-06-13 Thread via GitHub


michael-o opened a new pull request, #220:
URL: https://github.com/apache/maven-release/pull/220

   This closes #220
   
   Following this checklist to help us incorporate your 
   contribution quickly and easily:
   
- [ ] Make sure there is a [JIRA 
issue](https://issues.apache.org/jira/browse/MRELEASE) filed 
  for the change (usually before you start working on it).  Trivial 
changes like typos do not 
  require a JIRA issue.  Your pull request should address just this 
issue, without 
  pulling in other changes.
- [ ] Each commit in the pull request should have a meaningful subject line 
and body.
- [ ] Format the pull request title like `[MRELEASE-XXX] - Fixes bug in 
ApproximateQuantiles`,
  where you replace `MRELEASE-XXX` with the appropriate JIRA issue. 
Best practice
  is to use the JIRA issue title in the pull request title and in the 
first line of the 
  commit message.
- [ ] Write a pull request description that is detailed enough to 
understand what the pull request does, how, and why.
- [ ] Run `mvn clean verify -Prun-its` to make sure basic checks pass. A 
more thorough check will 
  be performed on your pull request automatically.
   
   If your pull request is about ~20 lines of code you don't need to sign an
   [Individual Contributor License 
Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure
   please ask on the developers list.
   
   To make clear that you license your contribution under 
   the [Apache License Version 2.0, January 
2004](http://www.apache.org/licenses/LICENSE-2.0)
   you have to acknowledge this by using the following check-box.
   
- [ ] I hereby declare this contribution to be licenced under the [Apache 
License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
   
- [ ] In any other case, please file an [Apache Individual Contributor 
License Agreement](https://www.apache.org/licenses/icla.pdf).
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] [MRELEASE-1148] Release Manage pulls in transitive dependencies [maven-release]

2024-06-13 Thread via GitHub


asfgit closed pull request #219: [MRELEASE-1148] Release Manage pulls in 
transitive dependencies
URL: https://github.com/apache/maven-release/pull/219


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[jira] [Commented] (MRELEASE-1148) Release Manager pulls in transitive dependencies

2024-06-13 Thread ASF GitHub Bot (Jira)


[ 
https://issues.apache.org/jira/browse/MRELEASE-1148?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17854834#comment-17854834
 ] 

ASF GitHub Bot commented on MRELEASE-1148:
--

michael-o opened a new pull request, #219:
URL: https://github.com/apache/maven-release/pull/219

   This closes #219
   
   Following this checklist to help us incorporate your 
   contribution quickly and easily:
   
- [ ] Make sure there is a [JIRA 
issue](https://issues.apache.org/jira/browse/MRELEASE) filed 
  for the change (usually before you start working on it).  Trivial 
changes like typos do not 
  require a JIRA issue.  Your pull request should address just this 
issue, without 
  pulling in other changes.
- [ ] Each commit in the pull request should have a meaningful subject line 
and body.
- [ ] Format the pull request title like `[MRELEASE-XXX] - Fixes bug in 
ApproximateQuantiles`,
  where you replace `MRELEASE-XXX` with the appropriate JIRA issue. 
Best practice
  is to use the JIRA issue title in the pull request title and in the 
first line of the 
  commit message.
- [ ] Write a pull request description that is detailed enough to 
understand what the pull request does, how, and why.
- [ ] Run `mvn clean verify -Prun-its` to make sure basic checks pass. A 
more thorough check will 
  be performed on your pull request automatically.
   
   If your pull request is about ~20 lines of code you don't need to sign an
   [Individual Contributor License 
Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure
   please ask on the developers list.
   
   To make clear that you license your contribution under 
   the [Apache License Version 2.0, January 
2004](http://www.apache.org/licenses/LICENSE-2.0)
   you have to acknowledge this by using the following check-box.
   
- [ ] I hereby declare this contribution to be licenced under the [Apache 
License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
   
- [ ] In any other case, please file an [Apache Individual Contributor 
License Agreement](https://www.apache.org/licenses/icla.pdf).
   
   




> Release Manager pulls in transitive dependencies
> 
>
> Key: MRELEASE-1148
> URL: https://issues.apache.org/jira/browse/MRELEASE-1148
> Project: Maven Release Plugin
>  Issue Type: Bug
>Affects Versions: 3.0.1
>Reporter: Michael Osipov
>Assignee: Michael Osipov
>Priority: Major
> Fix For: 3.1.0
>
>
> When a release POM is generated all (including transitive) artifacts are 
> flattened. This can cause test dependencies from dependencies to be inlined 
> which is not desired. Rely on on direct dependencies.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[PR] [MRELEASE-1148] Release Manage pulls in transitive dependencies [maven-release]

2024-06-13 Thread via GitHub


michael-o opened a new pull request, #219:
URL: https://github.com/apache/maven-release/pull/219

   This closes #219
   
   Following this checklist to help us incorporate your 
   contribution quickly and easily:
   
- [ ] Make sure there is a [JIRA 
issue](https://issues.apache.org/jira/browse/MRELEASE) filed 
  for the change (usually before you start working on it).  Trivial 
changes like typos do not 
  require a JIRA issue.  Your pull request should address just this 
issue, without 
  pulling in other changes.
- [ ] Each commit in the pull request should have a meaningful subject line 
and body.
- [ ] Format the pull request title like `[MRELEASE-XXX] - Fixes bug in 
ApproximateQuantiles`,
  where you replace `MRELEASE-XXX` with the appropriate JIRA issue. 
Best practice
  is to use the JIRA issue title in the pull request title and in the 
first line of the 
  commit message.
- [ ] Write a pull request description that is detailed enough to 
understand what the pull request does, how, and why.
- [ ] Run `mvn clean verify -Prun-its` to make sure basic checks pass. A 
more thorough check will 
  be performed on your pull request automatically.
   
   If your pull request is about ~20 lines of code you don't need to sign an
   [Individual Contributor License 
Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure
   please ask on the developers list.
   
   To make clear that you license your contribution under 
   the [Apache License Version 2.0, January 
2004](http://www.apache.org/licenses/LICENSE-2.0)
   you have to acknowledge this by using the following check-box.
   
- [ ] I hereby declare this contribution to be licenced under the [Apache 
License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
   
- [ ] In any other case, please file an [Apache Individual Contributor 
License Agreement](https://www.apache.org/licenses/icla.pdf).
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[jira] [Updated] (MRELEASE-1148) Release Manager pulls in transitive dependencies

2024-06-13 Thread Michael Osipov (Jira)


 [ 
https://issues.apache.org/jira/browse/MRELEASE-1148?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Michael Osipov updated MRELEASE-1148:
-
Summary: Release Manager pulls in transitive dependencies  (was: Release 
Manage pulls in transitive dependencies)

> Release Manager pulls in transitive dependencies
> 
>
> Key: MRELEASE-1148
> URL: https://issues.apache.org/jira/browse/MRELEASE-1148
> Project: Maven Release Plugin
>  Issue Type: Bug
>Affects Versions: 3.0.1
>Reporter: Michael Osipov
>Assignee: Michael Osipov
>Priority: Major
> Fix For: 3.1.0
>
>
> When a release POM is generated all (including transitive) artifacts are 
> flattened. This can cause test dependencies from dependencies to be inlined 
> which is not desired. Rely on on direct dependencies.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Created] (MRELEASE-1148) Release Manage pulls in transitive dependencies

2024-06-13 Thread Michael Osipov (Jira)
Michael Osipov created MRELEASE-1148:


 Summary: Release Manage pulls in transitive dependencies
 Key: MRELEASE-1148
 URL: https://issues.apache.org/jira/browse/MRELEASE-1148
 Project: Maven Release Plugin
  Issue Type: Bug
Affects Versions: 3.0.1
Reporter: Michael Osipov
Assignee: Michael Osipov
 Fix For: 3.1.0


When a release POM is generated all (including transitive) artifacts are 
flattened. This can cause test dependencies from dependencies to be inlined 
which is not desired. Rely on on direct dependencies.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Updated] (MNG-8155) Reword "This project has been banned from the build due to previous failures."

2024-06-13 Thread Michael Osipov (Jira)


 [ 
https://issues.apache.org/jira/browse/MNG-8155?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Michael Osipov updated MNG-8155:

Docs Text:   (was: Saw this error message. This confused me and I did not 
initially know what it meant. In fact, I guessed wrong. 

[INFO] Skipping presto-prism-plugin
[INFO] This project has been banned from the build due to previous failures.


I suggest rephrasing along the lines of "Module name was not build because the 
module module-name it depends on failed to build.")

> Reword "This project has been banned from the build due to previous failures."
> --
>
> Key: MNG-8155
> URL: https://issues.apache.org/jira/browse/MNG-8155
> Project: Maven
>  Issue Type: Improvement
>Reporter: Elliotte Rusty Harold
>Priority: Minor
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Created] (MRELEASE-1147) @junitVersion@ never replaces in UTs

2024-06-13 Thread Michael Osipov (Jira)
Michael Osipov created MRELEASE-1147:


 Summary: @junitVersion@ never replaces in UTs
 Key: MRELEASE-1147
 URL: https://issues.apache.org/jira/browse/MRELEASE-1147
 Project: Maven Release Plugin
  Issue Type: Bug
Affects Versions: 3.0.1
Reporter: Michael Osipov
Assignee: Michael Osipov
 Fix For: 3.1.0


Maven Release Manager contains UTs which are supposed to resolve a 
{{@junitVersion@}}, but this something like this only happens in ITs. Before 
this starts to fail with newer Resolver versions we should make those 
placeholders explicit.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Updated] (MRELEASE-1147) @junitVersion@ never replaced in UTs (make explicit)

2024-06-13 Thread Michael Osipov (Jira)


 [ 
https://issues.apache.org/jira/browse/MRELEASE-1147?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Michael Osipov updated MRELEASE-1147:
-
Summary: @junitVersion@ never replaced in UTs (make explicit)  (was: 
@junitVersion@ never replaced in UTs)

> @junitVersion@ never replaced in UTs (make explicit)
> 
>
> Key: MRELEASE-1147
> URL: https://issues.apache.org/jira/browse/MRELEASE-1147
> Project: Maven Release Plugin
>  Issue Type: Bug
>Affects Versions: 3.0.1
>Reporter: Michael Osipov
>Assignee: Michael Osipov
>Priority: Major
> Fix For: 3.1.0
>
>
> Maven Release Manager contains UTs which are supposed to resolve a 
> {{@junitVersion@}}, but this something like this only happens in ITs. Before 
> this starts to fail with newer Resolver versions we should make those 
> placeholders explicit.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Updated] (MRELEASE-1147) @junitVersion@ never replaced in UTs

2024-06-13 Thread Michael Osipov (Jira)


 [ 
https://issues.apache.org/jira/browse/MRELEASE-1147?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Michael Osipov updated MRELEASE-1147:
-
Summary: @junitVersion@ never replaced in UTs  (was: @junitVersion@ never 
replaces in UTs)

> @junitVersion@ never replaced in UTs
> 
>
> Key: MRELEASE-1147
> URL: https://issues.apache.org/jira/browse/MRELEASE-1147
> Project: Maven Release Plugin
>  Issue Type: Bug
>Affects Versions: 3.0.1
>Reporter: Michael Osipov
>Assignee: Michael Osipov
>Priority: Major
> Fix For: 3.1.0
>
>
> Maven Release Manager contains UTs which are supposed to resolve a 
> {{@junitVersion@}}, but this something like this only happens in ITs. Before 
> this starts to fail with newer Resolver versions we should make those 
> placeholders explicit.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (MDEPLOY-311) Regression in 3.0.0: deploy-file: -Dpackaging is not considered during artifact upload

2024-06-13 Thread ASF GitHub Bot (Jira)


[ 
https://issues.apache.org/jira/browse/MDEPLOY-311?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17854830#comment-17854830
 ] 

ASF GitHub Bot commented on MDEPLOY-311:


EnigmaTriton commented on code in PR #42:
URL: 
https://github.com/apache/maven-deploy-plugin/pull/42#discussion_r1638662304


##
src/main/java/org/apache/maven/plugins/deploy/DeployFileMojo.java:
##
@@ -274,9 +274,7 @@ public void execute() throws MojoExecutionException, 
MojoFailureException {
 classifier = artifactType.getClassifier();
 }
 }
-Artifact mainArtifact = new DefaultArtifact(
-groupId, artifactId, classifier, isFilePom ? "pom" : 
getExtension(file), version)
-.setFile(file);
+Artifact mainArtifact = new DefaultArtifact(groupId, artifactId, 
classifier, packaging, version).setFile(file);

Review Comment:
   According to the 
[documentation](https://maven.apache.org/plugins/maven-deploy-plugin/deploy-file-mojo.html),
 `packaging` designate the “Type of the artifact to be deployed. Retrieved from 
the  element of the POM file if a POM file specified. Defaults to 
the file extension if it is not specified via command line or POM.”
   
   The way I read it, it means that the `packaging` tag takes precedence 
(whether from command line or from the POM), followed by the extension of the 
file to upload as a fallback.
   
   I just hit this issue (MDEPLOY-311) because we generate a zip file using the 
truezip plugin (that relies on the extension) and then we need to deploy using 
a different extension.
   The `.epub` ebooks (used for documentation) are really `.zip` files with a 
specific content but this is true for quite a lot of other formats as well so 
there really is a use-case for using `` with a different extension 
than the one on the deployed file.





> Regression in 3.0.0: deploy-file: -Dpackaging is not considered during 
> artifact upload
> --
>
> Key: MDEPLOY-311
> URL: https://issues.apache.org/jira/browse/MDEPLOY-311
> Project: Maven Deploy Plugin
>  Issue Type: Bug
>  Components: deploy:deploy-file
>Affects Versions: 3.0.0, 3.1.0, 3.1.1
>Reporter: Sebastian Ratz
>Priority: Major
>
> Regression in [https://github.com/apache/maven-deploy-plugin/pull/26]
>  
> Property passed via {{-Dpackaging}} is not considered anymore during upload. 
> Instead, packaging is always derived from the file name.
>  
> To reproduce:
>  
> {{$ mvn -Dfile=foo.zip -DgroupId=com.bar -Dclassifier=baz 
> -DrepositoryId=deploy.snapshots -DartifactId=foo 
> -D{*}packaging=alterantivepackaging{*} -Dversion=1.0.0-SNAPSHOT 
> deploy:{*}3.0.0-M2{*}:deploy-file -Durl=file:./repo}}
> {{...}}
> {{Uploading to deploy.snapshots: 
> file:./repo/com/bar/foo/1.0.0-SNAPSHOT/foo-1.0.0-20230703.093021-2-baz{*}.alterantivepackaging{*}}}
> {{...}}
>  
> {{$ mvn -Dfile=foo.zip -DgroupId=com.bar -Dclassifier=baz 
> -DrepositoryId=deploy.snapshots -DartifactId=foo 
> -Dpackaging=alterantivepackaging -Dversion=1.0.0-SNAPSHOT 
> deploy:{*}3.0.0{*}:deploy-file -Durl=file:./repo}}
> {{...}}
> {{Uploading to deploy.snapshots: 
> file:./repo/com/bar/foo/1.0.0-SNAPSHOT/foo-1.0.0-20230703.093125-3-baz.zip}}
> {{...}}
>  
> The problematic line is
> [https://github.com/apache/maven-deploy-plugin/blob/707ab61615606053eb816e7c96d1fc276a80a47f/src/main/java/org/apache/maven/plugins/deploy/DeployFileMojo.java#L278C58-L278C96]
> Here,
> {{packaging}}
> should be used instead of
> {{isFilePom ? "pom" : getExtension(file)}}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (MDEPLOY-311) Regression in 3.0.0: deploy-file: -Dpackaging is not considered during artifact upload

2024-06-13 Thread ASF GitHub Bot (Jira)


[ 
https://issues.apache.org/jira/browse/MDEPLOY-311?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17854829#comment-17854829
 ] 

ASF GitHub Bot commented on MDEPLOY-311:


EnigmaTriton commented on code in PR #42:
URL: 
https://github.com/apache/maven-deploy-plugin/pull/42#discussion_r1638662304


##
src/main/java/org/apache/maven/plugins/deploy/DeployFileMojo.java:
##
@@ -274,9 +274,7 @@ public void execute() throws MojoExecutionException, 
MojoFailureException {
 classifier = artifactType.getClassifier();
 }
 }
-Artifact mainArtifact = new DefaultArtifact(
-groupId, artifactId, classifier, isFilePom ? "pom" : 
getExtension(file), version)
-.setFile(file);
+Artifact mainArtifact = new DefaultArtifact(groupId, artifactId, 
classifier, packaging, version).setFile(file);

Review Comment:
   According to the 
[documentation|https://maven.apache.org/plugins/maven-deploy-plugin/deploy-file-mojo.html],
 `packaging` designate the “Type of the artifact to be deployed. Retrieved from 
the  element of the POM file if a POM file specified. Defaults to 
the file extension if it is not specified via command line or POM.”
   
   The way I read it, it means that the `packaging` tag takes precedence 
(whether from command line or from the POM), followed by the extension of the 
file to upload as a fallback.
   
   I just hit this issue (MDEPLOY-311) because we generate a zip file using the 
truezip plugin (that relies on the extension) and then we need to deploy using 
a different extension.
   The `.epub` ebooks (used for documentation) are really `.zip` files with a 
specific content but this is true for quite a lot of other formats as well so 
there really is a use-case for using `` with a different extension 
than the one on the deployed file.





> Regression in 3.0.0: deploy-file: -Dpackaging is not considered during 
> artifact upload
> --
>
> Key: MDEPLOY-311
> URL: https://issues.apache.org/jira/browse/MDEPLOY-311
> Project: Maven Deploy Plugin
>  Issue Type: Bug
>  Components: deploy:deploy-file
>Affects Versions: 3.0.0, 3.1.0, 3.1.1
>Reporter: Sebastian Ratz
>Priority: Major
>
> Regression in [https://github.com/apache/maven-deploy-plugin/pull/26]
>  
> Property passed via {{-Dpackaging}} is not considered anymore during upload. 
> Instead, packaging is always derived from the file name.
>  
> To reproduce:
>  
> {{$ mvn -Dfile=foo.zip -DgroupId=com.bar -Dclassifier=baz 
> -DrepositoryId=deploy.snapshots -DartifactId=foo 
> -D{*}packaging=alterantivepackaging{*} -Dversion=1.0.0-SNAPSHOT 
> deploy:{*}3.0.0-M2{*}:deploy-file -Durl=file:./repo}}
> {{...}}
> {{Uploading to deploy.snapshots: 
> file:./repo/com/bar/foo/1.0.0-SNAPSHOT/foo-1.0.0-20230703.093021-2-baz{*}.alterantivepackaging{*}}}
> {{...}}
>  
> {{$ mvn -Dfile=foo.zip -DgroupId=com.bar -Dclassifier=baz 
> -DrepositoryId=deploy.snapshots -DartifactId=foo 
> -Dpackaging=alterantivepackaging -Dversion=1.0.0-SNAPSHOT 
> deploy:{*}3.0.0{*}:deploy-file -Durl=file:./repo}}
> {{...}}
> {{Uploading to deploy.snapshots: 
> file:./repo/com/bar/foo/1.0.0-SNAPSHOT/foo-1.0.0-20230703.093125-3-baz.zip}}
> {{...}}
>  
> The problematic line is
> [https://github.com/apache/maven-deploy-plugin/blob/707ab61615606053eb816e7c96d1fc276a80a47f/src/main/java/org/apache/maven/plugins/deploy/DeployFileMojo.java#L278C58-L278C96]
> Here,
> {{packaging}}
> should be used instead of
> {{isFilePom ? "pom" : getExtension(file)}}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


Re: [PR] [MDEPLOY-311] Pass on 'packaging' when creating artifact to upload [maven-deploy-plugin]

2024-06-13 Thread via GitHub


EnigmaTriton commented on code in PR #42:
URL: 
https://github.com/apache/maven-deploy-plugin/pull/42#discussion_r1638662304


##
src/main/java/org/apache/maven/plugins/deploy/DeployFileMojo.java:
##
@@ -274,9 +274,7 @@ public void execute() throws MojoExecutionException, 
MojoFailureException {
 classifier = artifactType.getClassifier();
 }
 }
-Artifact mainArtifact = new DefaultArtifact(
-groupId, artifactId, classifier, isFilePom ? "pom" : 
getExtension(file), version)
-.setFile(file);
+Artifact mainArtifact = new DefaultArtifact(groupId, artifactId, 
classifier, packaging, version).setFile(file);

Review Comment:
   According to the 
[documentation](https://maven.apache.org/plugins/maven-deploy-plugin/deploy-file-mojo.html),
 `packaging` designate the “Type of the artifact to be deployed. Retrieved from 
the  element of the POM file if a POM file specified. Defaults to 
the file extension if it is not specified via command line or POM.”
   
   The way I read it, it means that the `packaging` tag takes precedence 
(whether from command line or from the POM), followed by the extension of the 
file to upload as a fallback.
   
   I just hit this issue (MDEPLOY-311) because we generate a zip file using the 
truezip plugin (that relies on the extension) and then we need to deploy using 
a different extension.
   The `.epub` ebooks (used for documentation) are really `.zip` files with a 
specific content but this is true for quite a lot of other formats as well so 
there really is a use-case for using `` with a different extension 
than the one on the deployed file.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[jira] [Commented] (MPIR-461) Upgrade plugins and components (in ITs)

2024-06-13 Thread ASF GitHub Bot (Jira)


[ 
https://issues.apache.org/jira/browse/MPIR-461?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17854803#comment-17854803
 ] 

ASF GitHub Bot commented on MPIR-461:
-

michael-o opened a new pull request, #71:
URL: https://github.com/apache/maven-project-info-reports-plugin/pull/71

   This closes #71
   
   Following this checklist to help us incorporate your 
   contribution quickly and easily:
   
- [ ] Make sure there is a [JIRA 
issue](https://issues.apache.org/jira/browse/MPIR) filed 
  for the change (usually before you start working on it).  Trivial 
changes like typos do not 
  require a JIRA issue.  Your pull request should address just this 
issue, without 
  pulling in other changes.
- [ ] Each commit in the pull request should have a meaningful subject line 
and body.
- [ ] Format the pull request title like `[MPIR-XXX] - Fixes bug in 
ApproximateQuantiles`,
  where you replace `MPIR-XXX` with the appropriate JIRA issue. Best 
practice
  is to use the JIRA issue title in the pull request title and in the 
first line of the 
  commit message.
- [ ] Write a pull request description that is detailed enough to 
understand what the pull request does, how, and why.
- [ ] Run `mvn clean verify` to make sure basic checks pass. A more 
thorough check will 
  be performed on your pull request automatically.
- [ ] You have run the integration tests successfully (`mvn -Prun-its clean 
verify`).
   
   If your pull request is about ~20 lines of code you don't need to sign an
   [Individual Contributor License 
Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure
   please ask on the developers list.
   
   To make clear that you license your contribution under 
   the [Apache License Version 2.0, January 
2004](http://www.apache.org/licenses/LICENSE-2.0)
   you have to acknowledge this by using the following check-box.
   
- [ ] I hereby declare this contribution to be licenced under the [Apache 
License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
   
- [ ] In any other case, please file an [Apache Individual Contributor 
License Agreement](https://www.apache.org/licenses/icla.pdf).
   
   




> Upgrade plugins and components (in ITs)
> ---
>
> Key: MPIR-461
> URL: https://issues.apache.org/jira/browse/MPIR-461
> Project: Maven Project Info Reports Plugin
>  Issue Type: Dependency upgrade
>Reporter: Michael Osipov
>Assignee: Michael Osipov
>Priority: Major
> Fix For: 3.6.0
>
>
> * Upgrade to Maven SCM 2.1.0
> * Upgrade to Maven Common Artifact Filters 2.4.0
> * Upgrade to Plexus Interpolation 1.27
> * Upgrade to Commons Validator 1.9.0



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Closed] (MJAVADOC-796) Do not follow links for Java 12+

2024-06-13 Thread Michael Osipov (Jira)


 [ 
https://issues.apache.org/jira/browse/MJAVADOC-796?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Michael Osipov closed MJAVADOC-796.
---
Resolution: Fixed

Fixed with 
[aa0a6662452c219d2b1d04be224a2a17e19c6a3d|https://gitbox.apache.org/repos/asf?p=maven-javadoc-plugin.git;a=commit;h=aa0a6662452c219d2b1d04be224a2a17e19c6a3d].

> Do not follow links for Java 12+
> 
>
> Key: MJAVADOC-796
> URL: https://issues.apache.org/jira/browse/MJAVADOC-796
> Project: Maven Javadoc Plugin
>  Issue Type: Improvement
>  Components: javadoc
>Affects Versions: 3.7.0
>Reporter: Michael Osipov
>Assignee: Michael Osipov
>Priority: Major
> Fix For: 3.7.1
>
>
> For years, we have been following redirects manually because {{javadoc}} was 
> not able to. with Java 12 (JDK-8190312) is was implemented and our logic can 
> be skipped when {{javadoc}} 12+ is used.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (MJAVADOC-796) Do not follow links for Java 12+

2024-06-13 Thread ASF GitHub Bot (Jira)


[ 
https://issues.apache.org/jira/browse/MJAVADOC-796?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17854815#comment-17854815
 ] 

ASF GitHub Bot commented on MJAVADOC-796:
-

asfgit closed pull request #287: [MJAVADOC-796] Do not follow links for Java 12+
URL: https://github.com/apache/maven-javadoc-plugin/pull/287




> Do not follow links for Java 12+
> 
>
> Key: MJAVADOC-796
> URL: https://issues.apache.org/jira/browse/MJAVADOC-796
> Project: Maven Javadoc Plugin
>  Issue Type: Improvement
>  Components: javadoc
>Affects Versions: 3.7.0
>Reporter: Michael Osipov
>Assignee: Michael Osipov
>Priority: Major
> Fix For: 3.7.1
>
>
> For years, we have been following redirects manually because {{javadoc}} was 
> not able to. with Java 12 (JDK-8190312) is was implemented and our logic can 
> be skipped when {{javadoc}} 12+ is used.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (MJAVADOC-796) Do not follow links for Java 12+

2024-06-13 Thread Michael Osipov (Jira)


[ 
https://issues.apache.org/jira/browse/MJAVADOC-796?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17854818#comment-17854818
 ] 

Michael Osipov commented on MJAVADOC-796:
-

[~pwebb], can you also provide a reference to the described behavior?

> Do not follow links for Java 12+
> 
>
> Key: MJAVADOC-796
> URL: https://issues.apache.org/jira/browse/MJAVADOC-796
> Project: Maven Javadoc Plugin
>  Issue Type: Improvement
>  Components: javadoc
>Affects Versions: 3.7.0
>Reporter: Michael Osipov
>Assignee: Michael Osipov
>Priority: Major
> Fix For: 3.7.1
>
>
> For years, we have been following redirects manually because {{javadoc}} was 
> not able to. with Java 12 (JDK-8190312) is was implemented and our logic can 
> be skipped when {{javadoc}} 12+ is used.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (MJAVADOC-796) Do not follow links for Java 12+

2024-06-13 Thread ASF GitHub Bot (Jira)


[ 
https://issues.apache.org/jira/browse/MJAVADOC-796?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17854816#comment-17854816
 ] 

ASF GitHub Bot commented on MJAVADOC-796:
-

asfgit merged PR #287:
URL: https://github.com/apache/maven-javadoc-plugin/pull/287




> Do not follow links for Java 12+
> 
>
> Key: MJAVADOC-796
> URL: https://issues.apache.org/jira/browse/MJAVADOC-796
> Project: Maven Javadoc Plugin
>  Issue Type: Improvement
>  Components: javadoc
>Affects Versions: 3.7.0
>Reporter: Michael Osipov
>Assignee: Michael Osipov
>Priority: Major
> Fix For: 3.7.1
>
>
> For years, we have been following redirects manually because {{javadoc}} was 
> not able to. with Java 12 (JDK-8190312) is was implemented and our logic can 
> be skipped when {{javadoc}} 12+ is used.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


Re: [PR] [MJAVADOC-796] Do not follow links for Java 12+ [maven-javadoc-plugin]

2024-06-13 Thread via GitHub


asfgit closed pull request #287: [MJAVADOC-796] Do not follow links for Java 12+
URL: https://github.com/apache/maven-javadoc-plugin/pull/287


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[jira] [Updated] (MNG-8155) Reword "This project has been banned from the build due to previous failures."

2024-06-13 Thread Michael Osipov (Jira)


 [ 
https://issues.apache.org/jira/browse/MNG-8155?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Michael Osipov updated MNG-8155:

Description: 
Saw this error message. This confused me and I did not initially know what it 
meant. In fact, I guessed wrong. 

[INFO] Skipping presto-prism-plugin
[INFO] This project has been banned from the build due to previous failures.


I suggest rephrasing along the lines of "Module name was not build because the 
module module-name it depends on failed to build."

> Reword "This project has been banned from the build due to previous failures."
> --
>
> Key: MNG-8155
> URL: https://issues.apache.org/jira/browse/MNG-8155
> Project: Maven
>  Issue Type: Improvement
>Reporter: Elliotte Rusty Harold
>Priority: Minor
>
> Saw this error message. This confused me and I did not initially know what it 
> meant. In fact, I guessed wrong. 
> [INFO] Skipping presto-prism-plugin
> [INFO] This project has been banned from the build due to previous failures.
> I suggest rephrasing along the lines of "Module name was not build because 
> the module module-name it depends on failed to build."



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (MPIR-455) dependencies goal: add support for multi-release JARs

2024-06-13 Thread ASF GitHub Bot (Jira)


[ 
https://issues.apache.org/jira/browse/MPIR-455?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17854794#comment-17854794
 ] 

ASF GitHub Bot commented on MPIR-455:
-

michael-o closed pull request #70: [MPIR-455] - add support for multi-release 
JARs.
URL: https://github.com/apache/maven-project-info-reports-plugin/pull/70




> dependencies goal: add support for multi-release JARs
> -
>
> Key: MPIR-455
> URL: https://issues.apache.org/jira/browse/MPIR-455
> Project: Maven Project Info Reports Plugin
>  Issue Type: Bug
>  Components: dependencies
>Affects Versions: 3.4.5, 3.5.0
>Reporter: Gabriel Belingueres
>Assignee: Michael Osipov
>Priority: Major
> Fix For: 3.6.0
>
> Attachments: image-2024-01-04-21-12-54-861.png, 
> image-2024-06-02-10-58-46-991.png, image-2024-06-02-11-01-26-148.png, 
> image-2024-06-08-11-11-22-722.png, screenshot-1.png
>
>
> dependencies goal reports dependencies with multi-release support with the 
> highest version supported in the jar file, instead of the base version.
> Example: plexus-utils 4.0.0 is reported as a Java 11 dependency, but their 
> base version is 1.8.
> !image-2024-01-04-21-12-54-861.png!
> Because of this the lower "Total" rows report a wrong java version too.
>  
> This depends on https://issues.apache.org/jira/browse/MSHARED-1256.
>  



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Updated] (MPIR-455) dependencies goal: add support for multi-release JARs

2024-06-13 Thread Michael Osipov (Jira)


 [ 
https://issues.apache.org/jira/browse/MPIR-455?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Michael Osipov updated MPIR-455:

Issue Type: New Feature  (was: Bug)

> dependencies goal: add support for multi-release JARs
> -
>
> Key: MPIR-455
> URL: https://issues.apache.org/jira/browse/MPIR-455
> Project: Maven Project Info Reports Plugin
>  Issue Type: New Feature
>  Components: dependencies
>Affects Versions: 3.4.5, 3.5.0
>Reporter: Gabriel Belingueres
>Assignee: Michael Osipov
>Priority: Major
> Fix For: 3.6.0
>
> Attachments: image-2024-01-04-21-12-54-861.png, 
> image-2024-06-02-10-58-46-991.png, image-2024-06-02-11-01-26-148.png, 
> image-2024-06-08-11-11-22-722.png, screenshot-1.png
>
>
> dependencies goal reports dependencies with multi-release support with the 
> highest version supported in the jar file, instead of the base version.
> Example: plexus-utils 4.0.0 is reported as a Java 11 dependency, but their 
> base version is 1.8.
> !image-2024-01-04-21-12-54-861.png!
> Because of this the lower "Total" rows report a wrong java version too.
>  
> This depends on https://issues.apache.org/jira/browse/MSHARED-1256.
>  



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (MJAVADOC-796) Do not follow links for Java 12+

2024-06-13 Thread Michael Osipov (Jira)


[ 
https://issues.apache.org/jira/browse/MJAVADOC-796?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17854812#comment-17854812
 ] 

Michael Osipov commented on MJAVADOC-796:
-

It is a shame that the redirect code in Javadoc has never been backported to 8 
and 11.

> Do not follow links for Java 12+
> 
>
> Key: MJAVADOC-796
> URL: https://issues.apache.org/jira/browse/MJAVADOC-796
> Project: Maven Javadoc Plugin
>  Issue Type: Improvement
>  Components: javadoc
>Affects Versions: 3.7.0
>Reporter: Michael Osipov
>Assignee: Michael Osipov
>Priority: Major
> Fix For: 3.7.1
>
>
> For years, we have been following redirects manually because {{javadoc}} was 
> not able to. with Java 12 (JDK-8190312) is was implemented and our logic can 
> be skipped when {{javadoc}} 12+ is used.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Closed] (MPIR-461) Upgrade plugins and components (in ITs)

2024-06-13 Thread Michael Osipov (Jira)


 [ 
https://issues.apache.org/jira/browse/MPIR-461?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Michael Osipov closed MPIR-461.
---
Resolution: Fixed

Fixed with 
[34ca65bc0fae866814b59c9bfe1795bbec80|https://gitbox.apache.org/repos/asf?p=maven-project-info-reports-plugin.git;a=commit;h=34ca65bc0fae866814b59c9bfe1795bbec80].

> Upgrade plugins and components (in ITs)
> ---
>
> Key: MPIR-461
> URL: https://issues.apache.org/jira/browse/MPIR-461
> Project: Maven Project Info Reports Plugin
>  Issue Type: Dependency upgrade
>Reporter: Michael Osipov
>Assignee: Michael Osipov
>Priority: Major
> Fix For: 3.6.0
>
>
> * Upgrade to Maven SCM 2.1.0
> * Upgrade to Maven Common Artifact Filters 2.4.0
> * Upgrade to Plexus Interpolation 1.27
> * Upgrade to Commons Validator 1.9.0



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (MPIR-461) Upgrade plugins and components (in ITs)

2024-06-13 Thread ASF GitHub Bot (Jira)


[ 
https://issues.apache.org/jira/browse/MPIR-461?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17854806#comment-17854806
 ] 

ASF GitHub Bot commented on MPIR-461:
-

asfgit merged PR #71:
URL: https://github.com/apache/maven-project-info-reports-plugin/pull/71




> Upgrade plugins and components (in ITs)
> ---
>
> Key: MPIR-461
> URL: https://issues.apache.org/jira/browse/MPIR-461
> Project: Maven Project Info Reports Plugin
>  Issue Type: Dependency upgrade
>Reporter: Michael Osipov
>Assignee: Michael Osipov
>Priority: Major
> Fix For: 3.6.0
>
>
> * Upgrade to Maven SCM 2.1.0
> * Upgrade to Maven Common Artifact Filters 2.4.0
> * Upgrade to Plexus Interpolation 1.27
> * Upgrade to Commons Validator 1.9.0



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (MPIR-461) Upgrade plugins and components (in ITs)

2024-06-13 Thread ASF GitHub Bot (Jira)


[ 
https://issues.apache.org/jira/browse/MPIR-461?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17854807#comment-17854807
 ] 

ASF GitHub Bot commented on MPIR-461:
-

asfgit merged PR #71:
URL: https://github.com/apache/maven-project-info-reports-plugin/pull/71




> Upgrade plugins and components (in ITs)
> ---
>
> Key: MPIR-461
> URL: https://issues.apache.org/jira/browse/MPIR-461
> Project: Maven Project Info Reports Plugin
>  Issue Type: Dependency upgrade
>Reporter: Michael Osipov
>Assignee: Michael Osipov
>Priority: Major
> Fix For: 3.6.0
>
>
> * Upgrade to Maven SCM 2.1.0
> * Upgrade to Maven Common Artifact Filters 2.4.0
> * Upgrade to Plexus Interpolation 1.27
> * Upgrade to Commons Validator 1.9.0



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


Re: [PR] [MPIR-461] Upgrade plugins and components (in ITs) [maven-project-info-reports-plugin]

2024-06-13 Thread via GitHub


asfgit merged PR #71:
URL: https://github.com/apache/maven-project-info-reports-plugin/pull/71


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] [MPIR-461] Upgrade plugins and components (in ITs) [maven-project-info-reports-plugin]

2024-06-13 Thread via GitHub


asfgit merged PR #71:
URL: https://github.com/apache/maven-project-info-reports-plugin/pull/71


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[jira] [Created] (MPIR-461) Upgrade plugins and components (in ITs)

2024-06-13 Thread Michael Osipov (Jira)
Michael Osipov created MPIR-461:
---

 Summary: Upgrade plugins and components (in ITs)
 Key: MPIR-461
 URL: https://issues.apache.org/jira/browse/MPIR-461
 Project: Maven Project Info Reports Plugin
  Issue Type: Dependency upgrade
Reporter: Michael Osipov
Assignee: Michael Osipov
 Fix For: 3.6.0


* Upgrade to Maven SCM 2.1.0
* Upgrade to Maven Common Artifact Filters 2.4.0
* Upgrade to Plexus Interpolation 1.27
* Upgrade to Commons Validator 1.9.0



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[PR] [MPIR-461] Upgrade plugins and components (in ITs) [maven-project-info-reports-plugin]

2024-06-13 Thread via GitHub


michael-o opened a new pull request, #71:
URL: https://github.com/apache/maven-project-info-reports-plugin/pull/71

   This closes #71
   
   Following this checklist to help us incorporate your 
   contribution quickly and easily:
   
- [ ] Make sure there is a [JIRA 
issue](https://issues.apache.org/jira/browse/MPIR) filed 
  for the change (usually before you start working on it).  Trivial 
changes like typos do not 
  require a JIRA issue.  Your pull request should address just this 
issue, without 
  pulling in other changes.
- [ ] Each commit in the pull request should have a meaningful subject line 
and body.
- [ ] Format the pull request title like `[MPIR-XXX] - Fixes bug in 
ApproximateQuantiles`,
  where you replace `MPIR-XXX` with the appropriate JIRA issue. Best 
practice
  is to use the JIRA issue title in the pull request title and in the 
first line of the 
  commit message.
- [ ] Write a pull request description that is detailed enough to 
understand what the pull request does, how, and why.
- [ ] Run `mvn clean verify` to make sure basic checks pass. A more 
thorough check will 
  be performed on your pull request automatically.
- [ ] You have run the integration tests successfully (`mvn -Prun-its clean 
verify`).
   
   If your pull request is about ~20 lines of code you don't need to sign an
   [Individual Contributor License 
Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure
   please ask on the developers list.
   
   To make clear that you license your contribution under 
   the [Apache License Version 2.0, January 
2004](http://www.apache.org/licenses/LICENSE-2.0)
   you have to acknowledge this by using the following check-box.
   
- [ ] I hereby declare this contribution to be licenced under the [Apache 
License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
   
- [ ] In any other case, please file an [Apache Individual Contributor 
License Agreement](https://www.apache.org/licenses/icla.pdf).
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[jira] [Closed] (MPIR-455) dependencies goal: add support for multi-release JARs

2024-06-13 Thread Michael Osipov (Jira)


 [ 
https://issues.apache.org/jira/browse/MPIR-455?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Michael Osipov closed MPIR-455.
---
Resolution: Fixed

Fixed with 
[a44cc8ab44dda25c08d658666e0b2dadf826f93d|https://gitbox.apache.org/repos/asf?p=maven-project-info-reports-plugin.git&a=commit&h=a44cc8ab44dda25c08d658666e0b2dadf826f93d].

> dependencies goal: add support for multi-release JARs
> -
>
> Key: MPIR-455
> URL: https://issues.apache.org/jira/browse/MPIR-455
> Project: Maven Project Info Reports Plugin
>  Issue Type: New Feature
>  Components: dependencies
>Affects Versions: 3.4.5, 3.5.0
>Reporter: Gabriel Belingueres
>Assignee: Michael Osipov
>Priority: Major
> Fix For: 3.6.0
>
> Attachments: image-2024-01-04-21-12-54-861.png, 
> image-2024-06-02-10-58-46-991.png, image-2024-06-02-11-01-26-148.png, 
> image-2024-06-08-11-11-22-722.png, screenshot-1.png
>
>
> dependencies goal reports dependencies with multi-release support with the 
> highest version supported in the jar file, instead of the base version.
> Example: plexus-utils 4.0.0 is reported as a Java 11 dependency, but their 
> base version is 1.8.
> !image-2024-01-04-21-12-54-861.png!
> Because of this the lower "Total" rows report a wrong java version too.
>  
> This depends on https://issues.apache.org/jira/browse/MSHARED-1256.
>  



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


Re: [PR] [MPIR-455] - add support for multi-release JARs. [maven-project-info-reports-plugin]

2024-06-13 Thread via GitHub


michael-o closed pull request #70: [MPIR-455] - add support for multi-release 
JARs.
URL: https://github.com/apache/maven-project-info-reports-plugin/pull/70


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[jira] [Created] (MNG-8155) Reword "This project has been banned from the build due to previous failures."

2024-06-13 Thread Elliotte Rusty Harold (Jira)
Elliotte Rusty Harold created MNG-8155:
--

 Summary: Reword "This project has been banned from the build due 
to previous failures."
 Key: MNG-8155
 URL: https://issues.apache.org/jira/browse/MNG-8155
 Project: Maven
  Issue Type: Improvement
Reporter: Elliotte Rusty Harold






--
This message was sent by Atlassian Jira
(v8.20.10#820010)


Re: [PR] Release binaries: linux amd64, macos amd64, macos aarch64, windows amd64 [maven-mvnd]

2024-06-13 Thread via GitHub


cstamas merged PR #1016:
URL: https://github.com/apache/maven-mvnd/pull/1016


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[jira] [Commented] (MNG-8131) Property replacement in dependency pom no longer works

2024-06-13 Thread Tamas Cservenak (Jira)


[ 
https://issues.apache.org/jira/browse/MNG-8131?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17854777#comment-17854777
 ] 

Tamas Cservenak commented on MNG-8131:
--

No, currently it is -X only that shows fully the issues. We may later improve 
and add some selective switch to enable "detail" input even no DEBUG enabled.

> Property replacement in dependency pom no longer works
> --
>
> Key: MNG-8131
> URL: https://issues.apache.org/jira/browse/MNG-8131
> Project: Maven
>  Issue Type: Bug
>  Components: Core
>Affects Versions: 3.9.7
> Environment: macOS 14.5 (23F79)
>Reporter: Taylor Smock
>Assignee: Tamas Cservenak
>Priority: Major
> Fix For: 3.9.8
>
>
> h1. The problem:{{{}{}}}
> Classifiers in dependency poms are no longer replaced (either due to 
> performing profile activation of a parent pom of the dependency, or not 
> performing replacement of a property).{{{}{}}}
> Steps to reproduce (from [https://openjfx.io/openjfx-docs/#maven] )
>  # {{m{{{}vn archetype:generate
> -DarchetypeGroupId=org.openjfx 
> -DarchetypeArtifactId=javafx-archetype-simple -DarchetypeVersion=0.0.3 
> -DgroupId=org.openjfx -DartifactId=sample -Dversion=1.0.0 
> -Djavafx-version=22.0.1{}
>  # {{{}mvn compile{{{}{}}}[INFO] Scanning for projects...{}}}{{{}[INFO] 
> {}}}{{{}[INFO] -< org.openjfx:sample 
> >-{}}}{{{}[INFO] Building sample 1.0.0{}}}{{{}[INFO]  
>  from pom.xml{}}}{{{}[INFO] [ jar 
> ]-{}}}{{{}Downloading from central: 
> https://repo.maven.apache.org/maven2/org/openjfx/javafx-controls/22.0.1/javafx-controls-22.0.1.pom{}}}{{{}Downloaded
>  from central: 
> https://repo.maven.apache.org/maven2/org/openjfx/javafx-controls/22.0.1/javafx-controls-22.0.1.pom
>  (908 B at 1.9 kB/s){}}}{{{}Downloading from central: 
> https://repo.maven.apache.org/maven2/org/openjfx/javafx/22.0.1/javafx-22.0.1.pom{}}}{{{}Downloaded
>  from central: 
> https://repo.maven.apache.org/maven2/org/openjfx/javafx/22.0.1/javafx-22.0.1.pom
>  (8.4 kB at 165 kB/s){}}}{{{}Downloading from central: 
> https://repo.maven.apache.org/maven2/org/openjfx/javafx-graphics/22.0.1/javafx-graphics-22.0.1.pom{}}}{{{}Downloaded
>  from central: 
> https://repo.maven.apache.org/maven2/org/openjfx/javafx-graphics/22.0.1/javafx-graphics-22.0.1.pom
>  (904 B at 21 kB/s){}}}{{{}Downloading from central: 
> https://repo.maven.apache.org/maven2/org/openjfx/javafx-base/22.0.1/javafx-base-22.0.1.pom{}}}{{{}Downloaded
>  from central: 
> https://repo.maven.apache.org/maven2/org/openjfx/javafx-base/22.0.1/javafx-base-22.0.1.pom
>  (749 B at 17 kB/s){}}}{{{}Downloading from central: 
> https://repo.maven.apache.org/maven2/org/openjfx/javafx-controls/22.0.1/javafx-controls-22.0.1.jar{}}}{{{}Downloaded
>  from central: 
> https://repo.maven.apache.org/maven2/org/openjfx/javafx-controls/22.0.1/javafx-controls-22.0.1.jar
>  (306 B at 6.8 kB/s){}}}{{{}Downloading from central: 
> https://repo.maven.apache.org/maven2/org/openjfx/javafx-controls/22.0.1/javafx-controls-22.0.1-$%7Bjavafx.platform%7D.jar{}}}{{{}Downloading
>  from central: 
> https://repo.maven.apache.org/maven2/org/openjfx/javafx-graphics/22.0.1/javafx-graphics-22.0.1.jar{}}}{{{}Downloading
>  from central: 
> https://repo.maven.apache.org/maven2/org/openjfx/javafx-graphics/22.0.1/javafx-graphics-22.0.1-$%7Bjavafx.platform%7D.jar{}}}{{{}Downloading
>  from central: 
> https://repo.maven.apache.org/maven2/org/openjfx/javafx-base/22.0.1/javafx-base-22.0.1.jar{}}}{{{}Downloading
>  from central: 
> https://repo.maven.apache.org/maven2/org/openjfx/javafx-base/22.0.1/javafx-base-22.0.1-$%7Bjavafx.platform%7D.jar{}}}{{{}Downloaded
>  from central: 
> https://repo.maven.apache.org/maven2/org/openjfx/javafx-base/22.0.1/javafx-base-22.0.1.jar
>  (302 B at 2.4 kB/s){}}}{{{}Downloaded from central: 
> https://repo.maven.apache.org/maven2/org/openjfx/javafx-graphics/22.0.1/javafx-graphics-22.0.1.jar
>  (306 B at 2.4 kB/s){}}}{{{}[INFO] 
> {}}}{{{}[INFO]
>  BUILD FAILURE{}}}{{{}[INFO] 
> {}}}{{{}[INFO]
>  Total time:  1.378 s{}}}{{{}[INFO] Finished at: 
> 2024-05-28T10:23:05-06:00{}}}{{{}[INFO] 
> {}}}{{{}[ERROR]
>  Failed to execute goal on project sample: Could not resolve dependencies for 
> project org.openjfx:sample:jar:1.0.0: The following artifacts could not be 
> resolved: org.openjfx:javafx-controls:jar:${javafx.platform}:22.0.1 (absent), 
> org.openjfx:javafx-graphics:jar:${javafx.platform}:22.0.1 (absent), 
> org.openjfx:javafx-bas

[jira] [Comment Edited] (MNG-8131) Property replacement in dependency pom no longer works

2024-06-13 Thread John Neffenger (Jira)


[ 
https://issues.apache.org/jira/browse/MNG-8131?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17854776#comment-17854776
 ] 

John Neffenger edited comment on MNG-8131 at 6/13/24 3:03 PM:
--

In the release of Maven 3.9.8, I'm getting just the first generic warning 
message now by default:

{noformat}
[WARNING] 6 problems were encountered while building the effective model for 
org.openjfx:javafx-controls:jar:22.0.1
{noformat}

I have to enable debug output with '{{mvn -X}}' to get the detailed list of 
problems, as shown below, but then they're buried in a couple thousand lines of 
output:

{noformat}
[WARNING] 6 problems were encountered while building the effective model for 
org.openjfx:javafx-controls:jar:22.0.1
[WARNING] 'profiles.profile.id' Duplicate activation for profile linux-x86_64 @ 
org.openjfx:javafx:22.0.1
[WARNING] 'profiles.profile.id' Duplicate activation for profile linux-aarch64 
@ org.openjfx:javafx:22.0.1
[WARNING] 'profiles.profile.id' Duplicate activation for profile macosx-x86_64 
@ org.openjfx:javafx:22.0.1
[WARNING] 'profiles.profile.id' Duplicate activation for profile macosx-aarch64 
@ org.openjfx:javafx:22.0.1
[WARNING] 'profiles.profile.id' Duplicate activation for profile windows-x86_64 
@ org.openjfx:javafx:22.0.1
[WARNING] 'profiles.profile.id' Duplicate activation for profile windows-x86 @ 
org.openjfx:javafx:22.0.1
{noformat}

Is there an easier way to list the "6 problems" encountered?



was (Author: jgneff):
In the release of Maven 3.9.8, I'm getting just the first generic warning 
message now by default:

{noformat}
WARNING] 6 problems were encountered while building the effective model for 
org.openjfx:javafx-controls:jar:22.0.1
{noformat}

I have to enable debug output with '{{mvn -X}}' to get the detailed list of 
problems, as shown below, but then they're buried in a couple thousand lines of 
output:

{noformat}
[WARNING] 6 problems were encountered while building the effective model for 
org.openjfx:javafx-controls:jar:22.0.1
[WARNING] 'profiles.profile.id' Duplicate activation for profile linux-x86_64 @ 
org.openjfx:javafx:22.0.1
[WARNING] 'profiles.profile.id' Duplicate activation for profile linux-aarch64 
@ org.openjfx:javafx:22.0.1
[WARNING] 'profiles.profile.id' Duplicate activation for profile macosx-x86_64 
@ org.openjfx:javafx:22.0.1
[WARNING] 'profiles.profile.id' Duplicate activation for profile macosx-aarch64 
@ org.openjfx:javafx:22.0.1
[WARNING] 'profiles.profile.id' Duplicate activation for profile windows-x86_64 
@ org.openjfx:javafx:22.0.1
[WARNING] 'profiles.profile.id' Duplicate activation for profile windows-x86 @ 
org.openjfx:javafx:22.0.1
{noformat}

Is there an easier way to list the "6 problems" encountered?


> Property replacement in dependency pom no longer works
> --
>
> Key: MNG-8131
> URL: https://issues.apache.org/jira/browse/MNG-8131
> Project: Maven
>  Issue Type: Bug
>  Components: Core
>Affects Versions: 3.9.7
> Environment: macOS 14.5 (23F79)
>Reporter: Taylor Smock
>Assignee: Tamas Cservenak
>Priority: Major
> Fix For: 3.9.8
>
>
> h1. The problem:{{{}{}}}
> Classifiers in dependency poms are no longer replaced (either due to 
> performing profile activation of a parent pom of the dependency, or not 
> performing replacement of a property).{{{}{}}}
> Steps to reproduce (from [https://openjfx.io/openjfx-docs/#maven] )
>  # {{m{{{}vn archetype:generate
> -DarchetypeGroupId=org.openjfx 
> -DarchetypeArtifactId=javafx-archetype-simple -DarchetypeVersion=0.0.3 
> -DgroupId=org.openjfx -DartifactId=sample -Dversion=1.0.0 
> -Djavafx-version=22.0.1{}
>  # {{{}mvn compile{{{}{}}}[INFO] Scanning for projects...{}}}{{{}[INFO] 
> {}}}{{{}[INFO] -< org.openjfx:sample 
> >-{}}}{{{}[INFO] Building sample 1.0.0{}}}{{{}[INFO]  
>  from pom.xml{}}}{{{}[INFO] [ jar 
> ]-{}}}{{{}Downloading from central: 
> https://repo.maven.apache.org/maven2/org/openjfx/javafx-controls/22.0.1/javafx-controls-22.0.1.pom{}}}{{{}Downloaded
>  from central: 
> https://repo.maven.apache.org/maven2/org/openjfx/javafx-controls/22.0.1/javafx-controls-22.0.1.pom
>  (908 B at 1.9 kB/s){}}}{{{}Downloading from central: 
> https://repo.maven.apache.org/maven2/org/openjfx/javafx/22.0.1/javafx-22.0.1.pom{}}}{{{}Downloaded
>  from central: 
> https://repo.maven.apache.org/maven2/org/openjfx/javafx/22.0.1/javafx-22.0.1.pom
>  (8.4 kB at 165 kB/s){}}}{{{}Downloading from central: 
> https://repo.maven.apache.org/maven2/org/openjfx/javafx-graphics/22.0.1/javafx-graphics-22.0.1.pom{}}}{{{}Downloaded
>  from central: 
> https://repo.maven.apache.org/maven2/org/openjfx/javafx-graphic

[jira] [Commented] (MNG-8131) Property replacement in dependency pom no longer works

2024-06-13 Thread John Neffenger (Jira)


[ 
https://issues.apache.org/jira/browse/MNG-8131?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17854776#comment-17854776
 ] 

John Neffenger commented on MNG-8131:
-

In the release of Maven 3.9.8, I'm getting just the first generic warning 
message now by default:

{noformat}
WARNING] 6 problems were encountered while building the effective model for 
org.openjfx:javafx-controls:jar:22.0.1
{noformat}

I have to enable debug output with '{{mvn -X}}' to get the detailed list of 
problems, as shown below, but then they're buried in a couple thousand lines of 
output:

{noformat}
[WARNING] 6 problems were encountered while building the effective model for 
org.openjfx:javafx-controls:jar:22.0.1
[WARNING] 'profiles.profile.id' Duplicate activation for profile linux-x86_64 @ 
org.openjfx:javafx:22.0.1
[WARNING] 'profiles.profile.id' Duplicate activation for profile linux-aarch64 
@ org.openjfx:javafx:22.0.1
[WARNING] 'profiles.profile.id' Duplicate activation for profile macosx-x86_64 
@ org.openjfx:javafx:22.0.1
[WARNING] 'profiles.profile.id' Duplicate activation for profile macosx-aarch64 
@ org.openjfx:javafx:22.0.1
[WARNING] 'profiles.profile.id' Duplicate activation for profile windows-x86_64 
@ org.openjfx:javafx:22.0.1
[WARNING] 'profiles.profile.id' Duplicate activation for profile windows-x86 @ 
org.openjfx:javafx:22.0.1
{noformat}

Is there an easier way to list the "6 problems" encountered?


> Property replacement in dependency pom no longer works
> --
>
> Key: MNG-8131
> URL: https://issues.apache.org/jira/browse/MNG-8131
> Project: Maven
>  Issue Type: Bug
>  Components: Core
>Affects Versions: 3.9.7
> Environment: macOS 14.5 (23F79)
>Reporter: Taylor Smock
>Assignee: Tamas Cservenak
>Priority: Major
> Fix For: 3.9.8
>
>
> h1. The problem:{{{}{}}}
> Classifiers in dependency poms are no longer replaced (either due to 
> performing profile activation of a parent pom of the dependency, or not 
> performing replacement of a property).{{{}{}}}
> Steps to reproduce (from [https://openjfx.io/openjfx-docs/#maven] )
>  # {{m{{{}vn archetype:generate
> -DarchetypeGroupId=org.openjfx 
> -DarchetypeArtifactId=javafx-archetype-simple -DarchetypeVersion=0.0.3 
> -DgroupId=org.openjfx -DartifactId=sample -Dversion=1.0.0 
> -Djavafx-version=22.0.1{}
>  # {{{}mvn compile{{{}{}}}[INFO] Scanning for projects...{}}}{{{}[INFO] 
> {}}}{{{}[INFO] -< org.openjfx:sample 
> >-{}}}{{{}[INFO] Building sample 1.0.0{}}}{{{}[INFO]  
>  from pom.xml{}}}{{{}[INFO] [ jar 
> ]-{}}}{{{}Downloading from central: 
> https://repo.maven.apache.org/maven2/org/openjfx/javafx-controls/22.0.1/javafx-controls-22.0.1.pom{}}}{{{}Downloaded
>  from central: 
> https://repo.maven.apache.org/maven2/org/openjfx/javafx-controls/22.0.1/javafx-controls-22.0.1.pom
>  (908 B at 1.9 kB/s){}}}{{{}Downloading from central: 
> https://repo.maven.apache.org/maven2/org/openjfx/javafx/22.0.1/javafx-22.0.1.pom{}}}{{{}Downloaded
>  from central: 
> https://repo.maven.apache.org/maven2/org/openjfx/javafx/22.0.1/javafx-22.0.1.pom
>  (8.4 kB at 165 kB/s){}}}{{{}Downloading from central: 
> https://repo.maven.apache.org/maven2/org/openjfx/javafx-graphics/22.0.1/javafx-graphics-22.0.1.pom{}}}{{{}Downloaded
>  from central: 
> https://repo.maven.apache.org/maven2/org/openjfx/javafx-graphics/22.0.1/javafx-graphics-22.0.1.pom
>  (904 B at 21 kB/s){}}}{{{}Downloading from central: 
> https://repo.maven.apache.org/maven2/org/openjfx/javafx-base/22.0.1/javafx-base-22.0.1.pom{}}}{{{}Downloaded
>  from central: 
> https://repo.maven.apache.org/maven2/org/openjfx/javafx-base/22.0.1/javafx-base-22.0.1.pom
>  (749 B at 17 kB/s){}}}{{{}Downloading from central: 
> https://repo.maven.apache.org/maven2/org/openjfx/javafx-controls/22.0.1/javafx-controls-22.0.1.jar{}}}{{{}Downloaded
>  from central: 
> https://repo.maven.apache.org/maven2/org/openjfx/javafx-controls/22.0.1/javafx-controls-22.0.1.jar
>  (306 B at 6.8 kB/s){}}}{{{}Downloading from central: 
> https://repo.maven.apache.org/maven2/org/openjfx/javafx-controls/22.0.1/javafx-controls-22.0.1-$%7Bjavafx.platform%7D.jar{}}}{{{}Downloading
>  from central: 
> https://repo.maven.apache.org/maven2/org/openjfx/javafx-graphics/22.0.1/javafx-graphics-22.0.1.jar{}}}{{{}Downloading
>  from central: 
> https://repo.maven.apache.org/maven2/org/openjfx/javafx-graphics/22.0.1/javafx-graphics-22.0.1-$%7Bjavafx.platform%7D.jar{}}}{{{}Downloading
>  from central: 
> https://repo.maven.apache.org/maven2/org/openjfx/javafx-base/22.0.1/javafx-base-22.0.1.jar{}}}{{{}Downloading
>  from central: 
> https://repo.maven.apache.org/maven2/org/openjfx/javafx-base/22.0.1/java

Re: [PR] Mvnd 1.x gh runner test [maven-mvnd]

2024-06-13 Thread via GitHub


cstamas closed pull request #1015: Mvnd 1.x gh runner test
URL: https://github.com/apache/maven-mvnd/pull/1015


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[jira] [Commented] (MRESOLVER-499) IPC Named Locks

2024-06-13 Thread ASF GitHub Bot (Jira)


[ 
https://issues.apache.org/jira/browse/MRESOLVER-499?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17854733#comment-17854733
 ] 

ASF GitHub Bot commented on MRESOLVER-499:
--

cstamas commented on PR #435:
URL: https://github.com/apache/maven-resolver/pull/435#issuecomment-2165476995

   PR updated to latest Resolver master. If anyone wants to pick up, go for it. 
Otherwise I may pick it up later.




> IPC Named Locks
> ---
>
> Key: MRESOLVER-499
> URL: https://issues.apache.org/jira/browse/MRESOLVER-499
> Project: Maven Resolver
>  Issue Type: New Feature
>  Components: Resolver
>Reporter: Tamas Cservenak
>Assignee: Tamas Cservenak
>Priority: Major
> Fix For: 2.0.0
>
>
> Create IPC named locks implementation. Depends on MRESOLVER-421.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


Re: [PR] [MRESOLVER-499] IPC Named locks [maven-resolver]

2024-06-13 Thread via GitHub


cstamas commented on PR #435:
URL: https://github.com/apache/maven-resolver/pull/435#issuecomment-2165476995

   PR updated to latest Resolver master. If anyone wants to pick up, go for it. 
Otherwise I may pick it up later.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[jira] [Updated] (MRESOLVER-404) New strategy may be needed for Hazelcast named locks

2024-06-13 Thread Tamas Cservenak (Jira)


 [ 
https://issues.apache.org/jira/browse/MRESOLVER-404?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Tamas Cservenak updated MRESOLVER-404:
--
Fix Version/s: (was: 2.0.0)

> New strategy may be needed for Hazelcast named locks
> 
>
> Key: MRESOLVER-404
> URL: https://issues.apache.org/jira/browse/MRESOLVER-404
> Project: Maven Resolver
>  Issue Type: Improvement
>  Components: Resolver
>Reporter: Tamas Cservenak
>Priority: Major
>  Labels: up-for-grabs
>
> Originally (for today, see below) Hazelcast NamedLock implementation worked 
> like this:
> * on lock acquire, an ISemaphore DO with lock name is created (or just get, 
> if exists), is refCounted
> * on lock release, if refCount shows 0 = uses, ISemaphore was destroyed 
> (releasing HZ cluster resources)
> * if after some time, a new lock acquire happened for same name, ISemaphore 
> DO would get re-created.
> Today, HZ NamedLocks implementation works in following way:
> * there is only one Semaphore provider implementation, the 
> {{DirectHazelcastSemaphoreProvider}} that maps lock name 1:1 onto ISemaphore 
> Distributed Object (DO) name and does not destroys the DO
> Reason for this is historical: originally, named locks precursor code was 
> done for Hazelcast 2/3, that used "unreliable" distributed operations, and 
> recreating previously destroyed DO was possible (at the cost of 
> "unreliability").
> Since Hazelcast 4.x it updated to RAFT consensus algorithm and made things 
> reliable, it was at the cost that DOs once created, then destroyed, could not 
> be recreated anymore. This change was applied to 
> {{DirectHazelcastSemaphoreProvider}} as well, by simply not dropping unused 
> ISemaphores (release semaphore is no-op method).
> But, this has an important consequence: a long running Hazelcast cluster will 
> have more and more ISemaphore DOs (basically as many as many Artifacts all 
> the builds met, that use this cluster to coordinate). Artifacts count 
> existing out there is not infinite, but is large enough -- especially if 
> cluster shared across many different/unrelated builds -- to grow over sane 
> limit.
> So, current recommendation is to have "large enough" dedicated Hazelcast 
> cluster and  use {{semaphore-hazelcast-client}} (that is a "thin client" that 
> connects to cluster), instead of {{semaphore-hazelcast}} (that is "thick 
> client", so puts burden onto JVM process running it as node, hence Maven as 
> well). But even then, regular reboot of cluster may be needed.
> A proper but somewhat complicated solution would be to introduce some sort of 
> indirection: create as many ISemaphore as needed at the moment, and map those 
> onto locks names in use at the moment (and reuse unused semaphores). Problem 
> is, that mapping would need to be distributed as well (so all clients pick 
> them up, or perform new mapping), and this may cause performance penalty. But 
> this could be proved by exhaustive perf testing only.
> The benefit would be obvious: today cluster holds as many ISemaphores as many 
> Artifacts were met by all the builds, that use given cluster since cluster 
> boot. With indirection, the number of DOs would lowered to "maximum 
> concurrently used", so if you have a large build farm, that is able to juggle 
> with 1000 artifacts at given one moment, your cluster would have 1000 
> ISemaphores.
> Still, with proper "segmenting" of the clusters, for example to have them 
> split for "related" job groups, hence, the Artifacts coming thru them would 
> remain somewhat within limited boundaries, or some automation for "cluster 
> regular reboot", or simply just create "huge enough" clusters, may make users 
> benefit of never hitting these issues (cluster OOM). 
> And current code is most probably the fastest solution, hence, I just created 
> this issue to have it documented, but i plan no meritorious work on this 
> topic.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (MRESOLVER-564) Align with Maven4 beta-3

2024-06-13 Thread ASF GitHub Bot (Jira)


[ 
https://issues.apache.org/jira/browse/MRESOLVER-564?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17854725#comment-17854725
 ] 

ASF GitHub Bot commented on MRESOLVER-564:
--

cstamas merged PR #480:
URL: https://github.com/apache/maven-resolver/pull/480




> Align with Maven4 beta-3
> 
>
> Key: MRESOLVER-564
> URL: https://issues.apache.org/jira/browse/MRESOLVER-564
> Project: Maven Resolver
>  Issue Type: Dependency upgrade
>  Components: Resolver
>Reporter: Tamas Cservenak
>Assignee: Tamas Cservenak
>Priority: Major
> Fix For: 2.0.0, 2.0.0-beta-1
>
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Closed] (MRESOLVER-564) Align with Maven4 beta-3

2024-06-13 Thread Tamas Cservenak (Jira)


 [ 
https://issues.apache.org/jira/browse/MRESOLVER-564?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Tamas Cservenak closed MRESOLVER-564.
-
Resolution: Fixed

> Align with Maven4 beta-3
> 
>
> Key: MRESOLVER-564
> URL: https://issues.apache.org/jira/browse/MRESOLVER-564
> Project: Maven Resolver
>  Issue Type: Dependency upgrade
>  Components: Resolver
>Reporter: Tamas Cservenak
>Assignee: Tamas Cservenak
>Priority: Major
> Fix For: 2.0.0, 2.0.0-beta-1
>
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)


Re: [PR] [MRESOLVER-564] Align with Maven 4.0.0-beta-3 [maven-resolver]

2024-06-13 Thread via GitHub


cstamas merged PR #480:
URL: https://github.com/apache/maven-resolver/pull/480


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[jira] [Commented] (MRESOLVER-565) Rename null selectors to more natural name

2024-06-13 Thread ASF GitHub Bot (Jira)


[ 
https://issues.apache.org/jira/browse/MRESOLVER-565?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17854716#comment-17854716
 ] 

ASF GitHub Bot commented on MRESOLVER-565:
--

cstamas merged PR #503:
URL: https://github.com/apache/maven-resolver/pull/503




> Rename null selectors to more natural name
> --
>
> Key: MRESOLVER-565
> URL: https://issues.apache.org/jira/browse/MRESOLVER-565
> Project: Maven Resolver
>  Issue Type: Task
>  Components: Resolver
>Reporter: Tamas Cservenak
>Assignee: Tamas Cservenak
>Priority: Major
> Fix For: 2.0.0, 2.0.0-beta-1
>
>
> The classes {{NullProxySelector}} and {{NullAuthenticationSelector}} are 
> badly named, in way that unlike other implementations of {{ProxySelector}} 
> and {{AuthenticationSelector}} implementations, they do not "find out" any 
> proxies or auth, they literally return "what remote repository instance 
> passed in has". Is more like "identity" or "passthrough" implementation, not 
> "null".



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Closed] (MRESOLVER-565) Rename null selectors to more natural name

2024-06-13 Thread Tamas Cservenak (Jira)


 [ 
https://issues.apache.org/jira/browse/MRESOLVER-565?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Tamas Cservenak closed MRESOLVER-565.
-
Resolution: Fixed

> Rename null selectors to more natural name
> --
>
> Key: MRESOLVER-565
> URL: https://issues.apache.org/jira/browse/MRESOLVER-565
> Project: Maven Resolver
>  Issue Type: Task
>  Components: Resolver
>Reporter: Tamas Cservenak
>Assignee: Tamas Cservenak
>Priority: Major
> Fix For: 2.0.0, 2.0.0-beta-1
>
>
> The classes {{NullProxySelector}} and {{NullAuthenticationSelector}} are 
> badly named, in way that unlike other implementations of {{ProxySelector}} 
> and {{AuthenticationSelector}} implementations, they do not "find out" any 
> proxies or auth, they literally return "what remote repository instance 
> passed in has". Is more like "identity" or "passthrough" implementation, not 
> "null".



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


Re: [PR] Null implementations shall return null [maven-resolver]

2024-06-13 Thread via GitHub


cstamas commented on PR #113:
URL: https://github.com/apache/maven-resolver/pull/113#issuecomment-2165382262

   Superseded by https://github.com/apache/maven-resolver/pull/503


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] Null implementations shall return null [maven-resolver]

2024-06-13 Thread via GitHub


cstamas closed pull request #113: Null implementations shall return null
URL: https://github.com/apache/maven-resolver/pull/113


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



  1   2   >