[jira] [Commented] (SUREFIRE-1872) unwanted change in random generator?

2024-06-27 Thread Michael Osipov (Jira)


[ 
https://issues.apache.org/jira/browse/SUREFIRE-1872?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17860638#comment-17860638
 ] 

Michael Osipov commented on SUREFIRE-1872:
--

Does this still occur? There is nothing related to PRNG in Surefire code.

> unwanted change in random generator?
> 
>
> Key: SUREFIRE-1872
> URL: https://issues.apache.org/jira/browse/SUREFIRE-1872
> Project: Maven Surefire
>  Issue Type: Bug
>Reporter: Bernd Wahlen
>Priority: Minor
>
> We are using maven-surefire-plugin:3.0.0-M4 with argLine.
> When updating to M5 solr testcases fail with the following message:
> {code:java}
> [ERROR]   
> SearchCitiesImplTest>SolrTestCaseJ4.assertNonBlockingRandomGeneratorAvailable:2918->Assert.assertEquals:117
>  Algorithm specified using test.solr.allowed.securerandom system property 
> does not match actual algorithm expected: but 
> was:
> [ERROR]   
> MatchSolrIndexQueryTest>SolrTestCaseJ4.assertNonBlockingRandomGeneratorAvailable:2918->Assert.assertEquals:117
>  Algorithm specified using test.solr.allowed.securerandom system property 
> does not match actual algorithm expected: but 
> was:
> [ERROR]   
> SearchUsersQueryTest>SolrTestCaseJ4.assertNonBlockingRandomGeneratorAvailable:2918->Assert.assertEquals:117
>  Algorithm specified using test.solr.allowed.securerandom system property 
> does not match actual algorithm expected: but 
> was:
> {code}
> example plugin config from pom:
> setup is jenkins:2.274-centos docker image + maven-3.6.3 + adoptopenjdk-15
> {code:java}
> 
> org.apache.maven.plugins
> maven-surefire-plugin
> 
> false
> true
> 
> **/Test*.java
> **/Abstract*.java
> 
> 
> 
> java.awt.headless
> true
> 
> 
> java.net.preferIPv4Stack
> true
> 
> 
> -Dfile.encoding=UTF-8 
> -Dtest.solr.allowed.securerandom=NativePRNGNonBlocking
> 
> 3.0.0-M4 
> 
> {code}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Updated] (SUREFIRE-1872) unwanted change in random generator?

2024-06-27 Thread Michael Osipov (Jira)


 [ 
https://issues.apache.org/jira/browse/SUREFIRE-1872?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Michael Osipov updated SUREFIRE-1872:
-
Fix Version/s: waiting-for-feedback

> unwanted change in random generator?
> 
>
> Key: SUREFIRE-1872
> URL: https://issues.apache.org/jira/browse/SUREFIRE-1872
> Project: Maven Surefire
>  Issue Type: Bug
>Reporter: Bernd Wahlen
>Priority: Minor
> Fix For: waiting-for-feedback
>
>
> We are using maven-surefire-plugin:3.0.0-M4 with argLine.
> When updating to M5 solr testcases fail with the following message:
> {code:java}
> [ERROR]   
> SearchCitiesImplTest>SolrTestCaseJ4.assertNonBlockingRandomGeneratorAvailable:2918->Assert.assertEquals:117
>  Algorithm specified using test.solr.allowed.securerandom system property 
> does not match actual algorithm expected: but 
> was:
> [ERROR]   
> MatchSolrIndexQueryTest>SolrTestCaseJ4.assertNonBlockingRandomGeneratorAvailable:2918->Assert.assertEquals:117
>  Algorithm specified using test.solr.allowed.securerandom system property 
> does not match actual algorithm expected: but 
> was:
> [ERROR]   
> SearchUsersQueryTest>SolrTestCaseJ4.assertNonBlockingRandomGeneratorAvailable:2918->Assert.assertEquals:117
>  Algorithm specified using test.solr.allowed.securerandom system property 
> does not match actual algorithm expected: but 
> was:
> {code}
> example plugin config from pom:
> setup is jenkins:2.274-centos docker image + maven-3.6.3 + adoptopenjdk-15
> {code:java}
> 
> org.apache.maven.plugins
> maven-surefire-plugin
> 
> false
> true
> 
> **/Test*.java
> **/Abstract*.java
> 
> 
> 
> java.awt.headless
> true
> 
> 
> java.net.preferIPv4Stack
> true
> 
> 
> -Dfile.encoding=UTF-8 
> -Dtest.solr.allowed.securerandom=NativePRNGNonBlocking
> 
> 3.0.0-M4 
> 
> {code}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Closed] (SUREFIRE-1517) Getting ClassNotFoundException when filtering tests from a dependency jar

2024-06-27 Thread Michael Osipov (Jira)


 [ 
https://issues.apache.org/jira/browse/SUREFIRE-1517?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Michael Osipov closed SUREFIRE-1517.

Resolution: Incomplete

No feedback provided.

> Getting ClassNotFoundException when filtering tests from a dependency jar
> -
>
> Key: SUREFIRE-1517
> URL: https://issues.apache.org/jira/browse/SUREFIRE-1517
> Project: Maven Surefire
>  Issue Type: Bug
>  Components: Maven Surefire Plugin
>Affects Versions: 2.21.0
> Environment: Windows
>Reporter: simon cierniak
>Priority: Minor
>  Labels: waiting-for-feedback
> Attachments: 2018-04-19T12-07-18_153-jvmRun1.dump
>
>
> The issue happens only when I am using tests from a test jar (using option 
> dependenciesToScan) and when tests are not into a final package meaning 
> having sub-package.  FYI, I am executing Spock tests.
> To create my test jar, I followed doc 
> [https://maven.apache.org/plugins/maven-jar-plugin/examples/create-test-jar.html]
>  
> *+Structure+*
> {noformat}
> com.bug.package1.ASpec
> com.bug.package1.BSpec
> com.bug.package2.CSpec
> com.bug.package2.DSpec
> com.bug.package2.subpackage.C1Spec
> com.bug.package2.subpackage.C2Spec
> {noformat}
>  
> +*Commands:*+
> mvn test -Dtest=***/*Spec*            works : execute ASpec, BSpec, CSpec, 
> DSpec, C1Spec and C2Spec
> mvn test -Dtest=ASpec             works : execute ASpec
> mvn test -Dtest=***/package1/**  works : execute ASpec and BSpec
> mvn test -Dtest=C1Spec   works : execute C1Spec
> mvn test -Dtest=***/package2/subpackage/**  works : execute C1Spec and C2Spec
> mvn test -Dtest=CSpec   works : execute CSpec
> {color:#ff}mvn test -Dtest=***/package2/**  fails with error: 
> RuntimeException: Unable to create test class 'com.bug.package2.subpackage.' 
> ... caused by: java.lang.ClassNotFoundException: 
> com.bug.package2.subpackage.{color}
> {color:#ff}The tests executed should be CSpec and DSpec{color}
> same error when filtering by com/bug/***/**
>  
> +*Pom.xml*+
> {noformat}
> 
> http://maven.apache.org/POM/4.0.0; 
> xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance;
>  xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 
> http://maven.apache.org/maven-v4_0_0.xsd;>
>     4.0.0
>     com.bug
>     demo-execution
>     1.0-SNAPSHOT
>     jar
>     Test Bug
>     
>         UTF-8
>         2.4.5
>         1.0-groovy-2.4
>         false
>         **/*Spec.java
>         
>         
>         
>  
>         4.11
>         1.1.1
>         2.21.0
>     
>     
>         
>         
>             
>                 org.apache.maven.plugins
>                 maven-surefire-plugin
>                 ${surefire.version}
>                 
>                     
>                         org.apache.maven.surefire
>                         surefire-junit47
>                         ${surefire.version}
>                     
>                 
>                 
>                     ${skipTests}
>                     true
>                     false
>                     true
>                     true
>                     
>                         com.bug:demo-tests
>                     
>                     
>                         
>                         ${SpockTests}
>                     
>                     
>                     
>                     
>                     ${junit.groups}
>                     ${junit.excludedGroups}
>                 
>             
>         
>     
>     
>         
>             com.bug
>             demo-tests
>             1.0
>         
>     
> 
> {noformat}
>  
>  I tested also with version 2.20.1 and 2.19.1 and got same errors.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Closed] (SUREFIRE-1838) Ability to run an inner class or a method within

2024-06-27 Thread Michael Osipov (Jira)


 [ 
https://issues.apache.org/jira/browse/SUREFIRE-1838?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Michael Osipov closed SUREFIRE-1838.

Resolution: Not A Problem

> Ability to run an inner class or a method within
> 
>
> Key: SUREFIRE-1838
> URL: https://issues.apache.org/jira/browse/SUREFIRE-1838
> Project: Maven Surefire
>  Issue Type: Bug
>  Components: Junit 4.x support
>Affects Versions: 3.0.0-M5
>Reporter: Ernst Reissner
>Priority: Major
>
> invocations like
> ```
> mvn surefire:test -Dtest=XFPNumberTest$AxField$AddGroup 
> ```
> do not restrict to inner classes as expected.
> The same with methods within.
>  
> In fact, this prevents single methods from being invoked individually,
> if test classes are nested like in 
>  
> ```
> mvn surefire:test -Dtest=XFPNumberTest$AxField$AddGroup.testXXX
> ```



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Closed] (SUREFIRE-2242) Plain test report does not include names of the skipped tests

2024-06-27 Thread Michael Osipov (Jira)


 [ 
https://issues.apache.org/jira/browse/SUREFIRE-2242?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Michael Osipov closed SUREFIRE-2242.

Resolution: Fixed

Fixed with 
[6ff0f83ea1c9427a88d42b3a8c1b7bdb9e5e3fcb|https://gitbox.apache.org/repos/asf?p=maven-surefire.git;a=commit;h=6ff0f83ea1c9427a88d42b3a8c1b7bdb9e5e3fcb].

> Plain test report does not include names of the skipped tests
> -
>
> Key: SUREFIRE-2242
> URL: https://issues.apache.org/jira/browse/SUREFIRE-2242
> Project: Maven Surefire
>  Issue Type: Bug
>Affects Versions: 3.2.5
>Reporter: Alexandru Popescu
>Assignee: Michael Osipov
>Priority: Major
> Fix For: 3.3.1
>
>
> When using the plain reportFormat, skipped tests using JUnit 
> Assumptions/Conditions API are not including the method name in the report, 
> just the class name.
>  
> Example output (note the last 2 lines, indicating two skipped test)
> {noformat}
> Tests run: 3, Failures: 0, Errors: 0, Skipped: 2, Time elapsed: 0.031 s -- in 
> org.example.AssumptionsDemo
> org.example.AssumptionsDemo.testWithAssumption -- Time elapsed: 0.015 s
> org.example.AssumptionsDemo skipped
> org.example.AssumptionsDemo skipped
> {noformat}
>  
>  



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (MINSTALL-201) Regression in 3.1.2 when installing pom artifact

2024-06-27 Thread Michael Osipov (Jira)


[ 
https://issues.apache.org/jira/browse/MINSTALL-201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17860628#comment-17860628
 ] 

Michael Osipov commented on MINSTALL-201:
-

[~cstamas]

> Regression in 3.1.2 when installing pom artifact
> 
>
> Key: MINSTALL-201
> URL: https://issues.apache.org/jira/browse/MINSTALL-201
> Project: Maven Install Plugin
>  Issue Type: Bug
>Affects Versions: 3.1.2
> Environment: macOS 14.5, Maven 3.9.8; probably any
>Reporter: Christian Kohlschütter
>Priority: Blocker
>
> With 3.1.2, I'm seeing wrong artifact metadata (POM files) being installed 
> for POM-packaged artifacts in a multi-module project.
> Prior to 3.1.2, we were excluding some operations in InstallMojo.java when a 
> project's packaging was "pom". The check got removed, leading to ".pom" 
> artifact files being installed as some sort of zip file (yet having the 
> ".pom" file suffix).
> This breaks all sorts of things for me, effectively rendering version 3.1.2 
> unusable.
> Patch forthcoming.
> To reproduce:
> {code:java}
> git clone g...@github.com:kohlschutter/kohlschutter-parent.git
> git checkout kohlschutter-parent-1.7.2
> cd kohlschutter-parent
> mvn clean install -Dignorant -DskipTests
> file 
> $HOME/.m2/repository/com/kohlschutter/kohlschutter-parent-multirelease/1.7.2/kohlschutter-parent-multirelease-1.7.2.pom
> # the above command should return something like "XML 1.0 document text, 
> ASCII text"
> # 
> # now change maven-install-plugin dependency version in kohlschutter-parent's 
> pom.xml from 3.1.1 to 3.1.2
> mvn clean install -Dignorant -DskipTests
> file 
> $HOME/.m2/repository/com/kohlschutter/kohlschutter-parent-multirelease/1.7.2/kohlschutter-parent-multirelease-1.7.2.pom
> # 
> # the above command now returns something like "Zip archive data, at least 
> v1.0 to extract, compression method=store"
> # 
> # contents of the zip file:
> # META-INF/
> # META-INF/MANIFEST.MF
> # META-INF/maven/
> # META-INF/maven/com.kohlschutter/
> # META-INF/maven/com.kohlschutter/kohlschutter-parent-multirelease/
> # META-INF/maven/com.kohlschutter/kohlschutter-parent-multirelease/pom.xml
> # 
> META-INF/maven/com.kohlschutter/kohlschutter-parent-multirelease/pom.properties}}
>  {code}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (MINSTALL-200) "mvn jar:jar install:install" installs a jar instead of a pom

2024-06-27 Thread Jira


[ 
https://issues.apache.org/jira/browse/MINSTALL-200?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17860623#comment-17860623
 ] 

Christian Kohlschütter commented on MINSTALL-200:
-

I've encountered the same problem. I just saw your bug report after filing 
MINSTALL-200 with some root cause analysis and a potential fix.

 

> "mvn jar:jar install:install" installs a jar instead of a pom
> -
>
> Key: MINSTALL-200
> URL: https://issues.apache.org/jira/browse/MINSTALL-200
> Project: Maven Install Plugin
>  Issue Type: Bug
>  Components: install:install
>Affects Versions: 3.1.2
>Reporter: Urs Keller
>Priority: Minor
>
> {code:java}
> 
> http://maven.apache.org/POM/4.0.0; 
> xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance;
>          xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 
> https://maven.apache.org/xsd/maven-4.0.0.xsd;>
>     4.0.0
>     com.example
>     test-project-parent
>     main-SNAPSHOT
>     pom
>     
>         
>             
>                 
>                     org.apache.maven.plugins
>                     maven-install-plugin
>                     3.1.2
>                 
>             
>         
>     
> 
>  {code}
> {code:java}
> $ rm -rf ~/.m2/repository/com/example/test-project-parent
> $ mvn jar:jar install:install
> $ file  ~/.m2/repository/com/example/test-project-parent/main-SNAPSHOT/* 
> .../test-project-parent-main-SNAPSHOT.pom: Zip archive data, at least v1.0 to 
> extract, compression method=store
>  
> {code}
> The behaviour is different in 3.1.1 where this command will install the pom. 
> The output looks like this:
> {code:java}
> .../test-project-parent-main-SNAPSHOT.pom: XML 1.0 document text, ASCII text 
> {code}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Comment Edited] (MINSTALL-200) "mvn jar:jar install:install" installs a jar instead of a pom

2024-06-27 Thread Jira


[ 
https://issues.apache.org/jira/browse/MINSTALL-200?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17860623#comment-17860623
 ] 

Christian Kohlschütter edited comment on MINSTALL-200 at 6/27/24 7:16 PM:
--

I've encountered the same problem. I just saw your bug report after filing 
MINSTALL-201 with some root cause analysis and a potential fix.

 


was (Author: c...@newsclub.de):
I've encountered the same problem. I just saw your bug report after filing 
MINSTALL-200 with some root cause analysis and a potential fix.

 

> "mvn jar:jar install:install" installs a jar instead of a pom
> -
>
> Key: MINSTALL-200
> URL: https://issues.apache.org/jira/browse/MINSTALL-200
> Project: Maven Install Plugin
>  Issue Type: Bug
>  Components: install:install
>Affects Versions: 3.1.2
>Reporter: Urs Keller
>Priority: Minor
>
> {code:java}
> 
> http://maven.apache.org/POM/4.0.0; 
> xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance;
>          xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 
> https://maven.apache.org/xsd/maven-4.0.0.xsd;>
>     4.0.0
>     com.example
>     test-project-parent
>     main-SNAPSHOT
>     pom
>     
>         
>             
>                 
>                     org.apache.maven.plugins
>                     maven-install-plugin
>                     3.1.2
>                 
>             
>         
>     
> 
>  {code}
> {code:java}
> $ rm -rf ~/.m2/repository/com/example/test-project-parent
> $ mvn jar:jar install:install
> $ file  ~/.m2/repository/com/example/test-project-parent/main-SNAPSHOT/* 
> .../test-project-parent-main-SNAPSHOT.pom: Zip archive data, at least v1.0 to 
> extract, compression method=store
>  
> {code}
> The behaviour is different in 3.1.1 where this command will install the pom. 
> The output looks like this:
> {code:java}
> .../test-project-parent-main-SNAPSHOT.pom: XML 1.0 document text, ASCII text 
> {code}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (MINSTALL-201) Regression in 3.1.2 when installing pom artifact

2024-06-27 Thread Jira


[ 
https://issues.apache.org/jira/browse/MINSTALL-201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17860621#comment-17860621
 ] 

Christian Kohlschütter commented on MINSTALL-201:
-

[https://github.com/apache/maven-install-plugin/pull/72]

> Regression in 3.1.2 when installing pom artifact
> 
>
> Key: MINSTALL-201
> URL: https://issues.apache.org/jira/browse/MINSTALL-201
> Project: Maven Install Plugin
>  Issue Type: Bug
>Affects Versions: 3.1.2
> Environment: macOS 14.5, Maven 3.9.8; probably any
>Reporter: Christian Kohlschütter
>Priority: Blocker
>
> With 3.1.2, I'm seeing wrong artifact metadata (POM files) being installed 
> for POM-packaged artifacts in a multi-module project.
> Prior to 3.1.2, we were excluding some operations in InstallMojo.java when a 
> project's packaging was "pom". The check got removed, leading to ".pom" 
> artifact files being installed as some sort of zip file (yet having the 
> ".pom" file suffix).
> This breaks all sorts of things for me, effectively rendering version 3.1.2 
> unusable.
> Patch forthcoming.
> To reproduce:
> {code:java}
> git clone g...@github.com:kohlschutter/kohlschutter-parent.git
> git checkout kohlschutter-parent-1.7.2
> cd kohlschutter-parent
> mvn clean install -Dignorant -DskipTests
> file 
> $HOME/.m2/repository/com/kohlschutter/kohlschutter-parent-multirelease/1.7.2/kohlschutter-parent-multirelease-1.7.2.pom
> # the above command should return something like "XML 1.0 document text, 
> ASCII text"
> # 
> # now change maven-install-plugin dependency version in kohlschutter-parent's 
> pom.xml from 3.1.1 to 3.1.2
> mvn clean install -Dignorant -DskipTests
> file 
> $HOME/.m2/repository/com/kohlschutter/kohlschutter-parent-multirelease/1.7.2/kohlschutter-parent-multirelease-1.7.2.pom
> # 
> # the above command now returns something like "Zip archive data, at least 
> v1.0 to extract, compression method=store"
> # 
> # contents of the zip file:
> # META-INF/
> # META-INF/MANIFEST.MF
> # META-INF/maven/
> # META-INF/maven/com.kohlschutter/
> # META-INF/maven/com.kohlschutter/kohlschutter-parent-multirelease/
> # META-INF/maven/com.kohlschutter/kohlschutter-parent-multirelease/pom.xml
> # 
> META-INF/maven/com.kohlschutter/kohlschutter-parent-multirelease/pom.properties}}
>  {code}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (SUREFIRE-2203) In pom.xml, the configurationParameters configuration junit.platform.launcher.interceptors.enabled does not work

2024-06-27 Thread Michael Osipov (Jira)


[ 
https://issues.apache.org/jira/browse/SUREFIRE-2203?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17860619#comment-17860619
 ] 

Michael Osipov commented on SUREFIRE-2203:
--

There is this admonition block: 
https://junit.org/junit5/docs/snapshot/user-guide/#launcher-api-listeners-custom-deactivation,
 but it does not refer to your interceptor.

> In pom.xml, the configurationParameters configuration 
> junit.platform.launcher.interceptors.enabled does not work
> 
>
> Key: SUREFIRE-2203
> URL: https://issues.apache.org/jira/browse/SUREFIRE-2203
> Project: Maven Surefire
>  Issue Type: Bug
>  Components: JUnit 5.x support
>Reporter: Hengyunabc Chen
>Priority: Trivial
> Fix For: waiting-for-feedback
>
>
> In pom.xml, the configuration 
> {{junit.platform.launcher.interceptors.enabled}} does not work.
> The following configuration does not take effect:
> {code:java}
> 
> maven-surefire-plugin
> 3.1.2
> 
> 
> 
> junit.platform.launcher.interceptors.enabled=true
> 
> 
>  {code}
>  
> The following configuration can work:
> {code:java}
> 
> maven-surefire-plugin
> 3.1.2
> 
> 
> 
> true
> 
>  {code}
>  
> Or configuring it in the {{junit-platform.properties}} file will also work.
> Reference documentation:
>  * 
> [https://junit.org/junit5/docs/snapshot/user-guide/#launcher-api-launcher-interceptors-custom]
>  * 
> [https://junit.org/junit5/docs/snapshot/user-guide/#running-tests-build-maven-config-params]
>  * 
> [https://maven.apache.org/surefire/maven-surefire-plugin/examples/junit-platform.html#configuration-parameters]



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Created] (MINSTALL-201) Regression in 3.1.2 when installing pom artifact

2024-06-27 Thread Jira
Christian Kohlschütter created MINSTALL-201:
---

 Summary: Regression in 3.1.2 when installing pom artifact
 Key: MINSTALL-201
 URL: https://issues.apache.org/jira/browse/MINSTALL-201
 Project: Maven Install Plugin
  Issue Type: Bug
Affects Versions: 3.1.2
 Environment: macOS 14.5, Maven 3.9.8; probably any
Reporter: Christian Kohlschütter


With 3.1.2, I'm seeing wrong artifact metadata (POM files) being installed for 
POM-packaged artifacts in a multi-module project.

Prior to 3.1.2, we were excluding some operations in InstallMojo.java when a 
project's packaging was "pom". The check got removed, leading to ".pom" 
artifact files being installed as some sort of zip file (yet having the ".pom" 
file suffix).

This breaks all sorts of things for me, effectively rendering version 3.1.2 
unusable.

Patch forthcoming.

To reproduce:
{code:java}
git clone g...@github.com:kohlschutter/kohlschutter-parent.git
git checkout kohlschutter-parent-1.7.2
cd kohlschutter-parent
mvn clean install -Dignorant -DskipTests
file 
$HOME/.m2/repository/com/kohlschutter/kohlschutter-parent-multirelease/1.7.2/kohlschutter-parent-multirelease-1.7.2.pom
# the above command should return something like "XML 1.0 document text, ASCII 
text"
# 
# now change maven-install-plugin dependency version in kohlschutter-parent's 
pom.xml from 3.1.1 to 3.1.2
mvn clean install -Dignorant -DskipTests
file 
$HOME/.m2/repository/com/kohlschutter/kohlschutter-parent-multirelease/1.7.2/kohlschutter-parent-multirelease-1.7.2.pom
# 
# the above command now returns something like "Zip archive data, at least v1.0 
to extract, compression method=store"
# 
# contents of the zip file:
# META-INF/
# META-INF/MANIFEST.MF
# META-INF/maven/
# META-INF/maven/com.kohlschutter/
# META-INF/maven/com.kohlschutter/kohlschutter-parent-multirelease/
# META-INF/maven/com.kohlschutter/kohlschutter-parent-multirelease/pom.xml
# 
META-INF/maven/com.kohlschutter/kohlschutter-parent-multirelease/pom.properties}}
 {code}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (SUREFIRE-2203) In pom.xml, the configurationParameters configuration junit.platform.launcher.interceptors.enabled does not work

2024-06-27 Thread Michael Osipov (Jira)


[ 
https://issues.apache.org/jira/browse/SUREFIRE-2203?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17860618#comment-17860618
 ] 

Michael Osipov commented on SUREFIRE-2203:
--

OK, I believe there is no bug, but likely bad documentation in JUnit. 
[~sormu...@gmx.de],  [~marcphilipp], maybe you both can confirm the behavior:

{{LauncherFactory#openSession(LauncherConfig)}} does
{code:java}
LauncherConfigurationParameters configurationParameters = 
LauncherConfigurationParameters.builder().build();
return new 
DefaultLauncherSession(collectLauncherInterceptors(configurationParameters),
() -> createLauncherSessionListener(config), () -> 
createDefaultLauncher(config, configurationParameters));
{code}
but does not use the parameters on {{LauncherConfig}}. 
{{LauncherConfigurationParameters.builder().build();}} is
{code:java}
LauncherConfigurationParameters build() {
List parameterProviders = new 
ArrayList<>();
if (!explicitParameters.isEmpty()) {

parameterProviders.add(ParameterProvider.explicit(explicitParameters));
}

if (parentConfigurationParameters != null) {

parameterProviders.add(ParameterProvider.inherited(parentConfigurationParameters));
}

if (implicitProvidersEnabled) {

parameterProviders.add(ParameterProvider.systemProperties());

parameterProviders.add(ParameterProvider.propertiesFile(configFileName));
}
return new 
LauncherConfigurationParameters(parameterProviders);
}
}
{code}
I cannot path anything to the explcit one and the cod resorts to system 
properties and the properties file.

Wether it is good, bad, reasonable -- I cannot tell, but only JUnit folks can 
change that for us.

> In pom.xml, the configurationParameters configuration 
> junit.platform.launcher.interceptors.enabled does not work
> 
>
> Key: SUREFIRE-2203
> URL: https://issues.apache.org/jira/browse/SUREFIRE-2203
> Project: Maven Surefire
>  Issue Type: Bug
>  Components: JUnit 5.x support
>Reporter: Hengyunabc Chen
>Priority: Trivial
> Fix For: waiting-for-feedback
>
>
> In pom.xml, the configuration 
> {{junit.platform.launcher.interceptors.enabled}} does not work.
> The following configuration does not take effect:
> {code:java}
> 
> maven-surefire-plugin
> 3.1.2
> 
> 
> 
> junit.platform.launcher.interceptors.enabled=true
> 
> 
>  {code}
>  
> The following configuration can work:
> {code:java}
> 
> maven-surefire-plugin
> 3.1.2
> 
> 
> 
> true
> 
>  {code}
>  
> Or configuring it in the {{junit-platform.properties}} file will also work.
> Reference documentation:
>  * 
> [https://junit.org/junit5/docs/snapshot/user-guide/#launcher-api-launcher-interceptors-custom]
>  * 
> [https://junit.org/junit5/docs/snapshot/user-guide/#running-tests-build-maven-config-params]
>  * 
> [https://maven.apache.org/surefire/maven-surefire-plugin/examples/junit-platform.html#configuration-parameters]



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (MCHECKSTYLE-431) Avoid creating unnecessary target files for pom projects

2024-06-27 Thread Michael Osipov (Jira)


[ 
https://issues.apache.org/jira/browse/MCHECKSTYLE-431?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17860614#comment-17860614
 ] 

Michael Osipov commented on MCHECKSTYLE-431:


How can we know for sure that we can skip the project?

Here is the code:
{noformat}
if (!isAggregator() || !"pom".equalsIgnoreCase(project.getPackaging())) 
{
ArtifactHandler artifactHandler = 
project.getArtifact().getArtifactHandler();
if (!"java".equals(artifactHandler.getLanguage())) {
getLog().info("Not executing Javadoc as the project is not a 
Java classpath-capable package");
return;
}
}
{noformat}

Does this apply to other JVM languages? I mean I could likely test Groovy code 
with Surefire, no?

The NullOutputStream is pointless because you cannot know whether there will be 
something and if you know you can skip execution altogether.

> Avoid creating unnecessary target files for pom projects
> 
>
> Key: MCHECKSTYLE-431
> URL: https://issues.apache.org/jira/browse/MCHECKSTYLE-431
> Project: Maven Checkstyle Plugin
>  Issue Type: Improvement
>  Components: checkstyle:check
>Affects Versions: 3.2.1
>Reporter: Alexis Jehan
>Priority: Minor
>
> Because pom projects do not have Java code, It is not necessary to create 
> "target/checkstyle-cachefile", "target/checkstyle-checker.xml", 
> "target/checkstyle-result.xml" and "target/checkstyle-suppressions.xml" files 
> for these projects.
> Maven configuration:
> {code:xml}
> 
>   org.apache.maven.plugins
>   maven-checkstyle-plugin
>   3.2.1
>   
>   
>   com.puppycrawl.tools
>   checkstyle
>   10.9.3
>   
>   
>   
>   checkstyle.xml
>   
> checkstyle-suppressions.xml
>   true
>   info
>   
>   
>   
>   checkstyle-check
>   validate
>   
>   check
>   
>   
>   
> 
> {code}
> Maven output:
> {noformat}
> [INFO] --- checkstyle:3.2.1:check (checkstyle-check) @ parent-project ---
> [INFO] You have 0 Checkstyle violations.
> {noformat}
> Content of the generated "target/checkstyle-result.xml":
> {code:xml}
> 
> 
> 
> {code}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Comment Edited] (MNG-8162) Maven should warn about modules relative to parent directory

2024-06-27 Thread Lenny Primak (Jira)


[ 
https://issues.apache.org/jira/browse/MNG-8162?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17860595#comment-17860595
 ] 

Lenny Primak edited comment on MNG-8162 at 6/27/24 4:28 PM:


Agreed with the following caveats:
 * Must be able to turn off the warning in settings.xml or on the command line 
(-Dmaven.warnings.nonroot=off)
 * There is a legit case for this, using git submodules to create a build 
system for an existing project. Since there is no submodules in parent 
directories (i.e. ../module/one/pom.xml) this warning should not exist for a 
single-module project

 

See [https://github.com/flowlogix/jbake-maven] for an example of a valid use 
case


was (Author: lprimak):
Agreed with the following caveats:
 * Must be able to turn off the warning in settings.xml or on the command line 
(-Dmaven.warnings.nonroot=off)
 * There is a legit case for this, using git submodules to create a build 
system for an existing project. Since there is no submodules in parent 
directories (i.e. ../module/one/pom.xml) this warning should not exist for a 
single-module project

> Maven should warn about modules relative to parent directory
> 
>
> Key: MNG-8162
> URL: https://issues.apache.org/jira/browse/MNG-8162
> Project: Maven
>  Issue Type: Task
>  Components: Core
>Reporter: Benjamin Marwell
>Priority: Major
>
> Maven should warn if a pom project references modules which are not direct 
> descendants, e.g.
> {code:html}
> ../other
> {code}
> h2. Rationale
> Given this situation:
> * the repository root does not contain the root pom.xml 
> * A subdirectory contains the "root" pom.xml (e.g. ./Build/pom.xml)
> * Maven must be called either via {{mvn -f Build}} or {{cd Build && mvn}}
> Then it is hard to determine the root:
> * Is it in the VCS clone/checkout root?
> * Is it in the first common ancestor? Maybe it is in 
> {{project/dev/impl/Build}} ?
> * Is root=true a valid tag in either of these cases?
> * what if you call maven from even yet  a higher directory?
> * What if both .mvn directores and the root tags are present?
> * What if there are multitple .mvn directories (lets say in repo root, and in 
> ./project/dev/impl and in ./project/dev/impl/Build)?
> In any of those cases and combinations of those, Maven should print a warning
> h2. Suggested warning
> {code}
> [WARN] This maven project has modules relative to the parent directory 
> (../{..}. This is an invalid configuration and will be 
> unsupported in future releases. To fix, move all descendants of a pom project 
> to its directory, making it a direct descendant.
> {code}
> h2. Checks
> Should be included in the new self-check
> h2. Suggested deprecation
> Maven 5 should not work under such circumstances
> h2. Backports
> Might be a candidate for backporting to 3.9.
> h2. Documentation
> The docs should clarify which "root" takes precedence (and why).



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (MNG-8162) Maven should warn about modules relative to parent directory

2024-06-27 Thread Lenny Primak (Jira)


[ 
https://issues.apache.org/jira/browse/MNG-8162?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17860595#comment-17860595
 ] 

Lenny Primak commented on MNG-8162:
---

Agreed with the following caveats:
 * Must be able to turn off the warning in settings.xml or on the command line 
(-Dmaven.warnings.nonroot=off)
 * There is a legit case for this, using git submodules to create a build 
system for an existing project. Since there is no submodules in parent 
directories (i.e. ../module/one/pom.xml) this warning should not exist for a 
single-module project

> Maven should warn about modules relative to parent directory
> 
>
> Key: MNG-8162
> URL: https://issues.apache.org/jira/browse/MNG-8162
> Project: Maven
>  Issue Type: Task
>  Components: Core
>Reporter: Benjamin Marwell
>Priority: Major
>
> Maven should warn if a pom project references modules which are not direct 
> descendants, e.g.
> {code:html}
> ../other
> {code}
> h2. Rationale
> Given this situation:
> * the repository root does not contain the root pom.xml 
> * A subdirectory contains the "root" pom.xml (e.g. ./Build/pom.xml)
> * Maven must be called either via {{mvn -f Build}} or {{cd Build && mvn}}
> Then it is hard to determine the root:
> * Is it in the VCS clone/checkout root?
> * Is it in the first common ancestor? Maybe it is in 
> {{project/dev/impl/Build}} ?
> * Is root=true a valid tag in either of these cases?
> * what if you call maven from even yet  a higher directory?
> * What if both .mvn directores and the root tags are present?
> * What if there are multitple .mvn directories (lets say in repo root, and in 
> ./project/dev/impl and in ./project/dev/impl/Build)?
> In any of those cases and combinations of those, Maven should print a warning
> h2. Suggested warning
> {code}
> [WARN] This maven project has modules relative to the parent directory 
> (../{..}. This is an invalid configuration and will be 
> unsupported in future releases. To fix, move all descendants of a pom project 
> to its directory, making it a direct descendant.
> {code}
> h2. Checks
> Should be included in the new self-check
> h2. Suggested deprecation
> Maven 5 should not work under such circumstances
> h2. Backports
> Might be a candidate for backporting to 3.9.
> h2. Documentation
> The docs should clarify which "root" takes precedence (and why).



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (SUREFIRE-2203) In pom.xml, the configurationParameters configuration junit.platform.launcher.interceptors.enabled does not work

2024-06-27 Thread Michael Osipov (Jira)


[ 
https://issues.apache.org/jira/browse/SUREFIRE-2203?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17860581#comment-17860581
 ] 

Michael Osipov commented on SUREFIRE-2203:
--

Will take a look. This is quite confusing because all props are passed the 
same. Maybe JUnit needs them earlier...

> In pom.xml, the configurationParameters configuration 
> junit.platform.launcher.interceptors.enabled does not work
> 
>
> Key: SUREFIRE-2203
> URL: https://issues.apache.org/jira/browse/SUREFIRE-2203
> Project: Maven Surefire
>  Issue Type: Bug
>  Components: JUnit 5.x support
>Reporter: Hengyunabc Chen
>Priority: Trivial
> Fix For: waiting-for-feedback
>
>
> In pom.xml, the configuration 
> {{junit.platform.launcher.interceptors.enabled}} does not work.
> The following configuration does not take effect:
> {code:java}
> 
> maven-surefire-plugin
> 3.1.2
> 
> 
> 
> junit.platform.launcher.interceptors.enabled=true
> 
> 
>  {code}
>  
> The following configuration can work:
> {code:java}
> 
> maven-surefire-plugin
> 3.1.2
> 
> 
> 
> true
> 
>  {code}
>  
> Or configuring it in the {{junit-platform.properties}} file will also work.
> Reference documentation:
>  * 
> [https://junit.org/junit5/docs/snapshot/user-guide/#launcher-api-launcher-interceptors-custom]
>  * 
> [https://junit.org/junit5/docs/snapshot/user-guide/#running-tests-build-maven-config-params]
>  * 
> [https://maven.apache.org/surefire/maven-surefire-plugin/examples/junit-platform.html#configuration-parameters]



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (MCHECKSTYLE-431) Avoid creating unnecessary target files for pom projects

2024-06-27 Thread Alexis Jehan (Jira)


[ 
https://issues.apache.org/jira/browse/MCHECKSTYLE-431?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17860462#comment-17860462
 ] 

Alexis Jehan commented on MCHECKSTYLE-431:
--

That would be possible with such a "NullOutputStream", but yeah this is not a 
clean solution. Better one would be not to run checkstyle if we detect that 
this is useless (Like respectively the javadoc plugin with _"Not executing 
Javadoc as the project is not a Java classpath-capable package"_ or the 
surefire plugin with _"No tests to run."_).

> Avoid creating unnecessary target files for pom projects
> 
>
> Key: MCHECKSTYLE-431
> URL: https://issues.apache.org/jira/browse/MCHECKSTYLE-431
> Project: Maven Checkstyle Plugin
>  Issue Type: Improvement
>  Components: checkstyle:check
>Affects Versions: 3.2.1
>Reporter: Alexis Jehan
>Priority: Minor
>
> Because pom projects do not have Java code, It is not necessary to create 
> "target/checkstyle-cachefile", "target/checkstyle-checker.xml", 
> "target/checkstyle-result.xml" and "target/checkstyle-suppressions.xml" files 
> for these projects.
> Maven configuration:
> {code:xml}
> 
>   org.apache.maven.plugins
>   maven-checkstyle-plugin
>   3.2.1
>   
>   
>   com.puppycrawl.tools
>   checkstyle
>   10.9.3
>   
>   
>   
>   checkstyle.xml
>   
> checkstyle-suppressions.xml
>   true
>   info
>   
>   
>   
>   checkstyle-check
>   validate
>   
>   check
>   
>   
>   
> 
> {code}
> Maven output:
> {noformat}
> [INFO] --- checkstyle:3.2.1:check (checkstyle-check) @ parent-project ---
> [INFO] You have 0 Checkstyle violations.
> {noformat}
> Content of the generated "target/checkstyle-result.xml":
> {code:xml}
> 
> 
> 
> {code}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (MCHECKSTYLE-431) Avoid creating unnecessary target files for pom projects

2024-06-27 Thread Michael Osipov (Jira)


[ 
https://issues.apache.org/jira/browse/MCHECKSTYLE-431?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17860425#comment-17860425
 ] 

Michael Osipov commented on MCHECKSTYLE-431:


Yes, not easily possible: Look here: 
https://github.com/apache/maven-checkstyle-plugin/blob/c6dbdfea723968428ba3ed23bc88e5aad3b396f2/src/main/java/org/apache/maven/plugins/checkstyle/AbstractCheckstyleReport.java#L611-L637

Checkstyle requires us to pass an output stream which means the file needs to 
creates in anycase. Maybe [~roman.ivanov] could give us an advice here...

> Avoid creating unnecessary target files for pom projects
> 
>
> Key: MCHECKSTYLE-431
> URL: https://issues.apache.org/jira/browse/MCHECKSTYLE-431
> Project: Maven Checkstyle Plugin
>  Issue Type: Improvement
>  Components: checkstyle:check
>Affects Versions: 3.2.1
>Reporter: Alexis Jehan
>Priority: Minor
>
> Because pom projects do not have Java code, It is not necessary to create 
> "target/checkstyle-cachefile", "target/checkstyle-checker.xml", 
> "target/checkstyle-result.xml" and "target/checkstyle-suppressions.xml" files 
> for these projects.
> Maven configuration:
> {code:xml}
> 
>   org.apache.maven.plugins
>   maven-checkstyle-plugin
>   3.2.1
>   
>   
>   com.puppycrawl.tools
>   checkstyle
>   10.9.3
>   
>   
>   
>   checkstyle.xml
>   
> checkstyle-suppressions.xml
>   true
>   info
>   
>   
>   
>   checkstyle-check
>   validate
>   
>   check
>   
>   
>   
> 
> {code}
> Maven output:
> {noformat}
> [INFO] --- checkstyle:3.2.1:check (checkstyle-check) @ parent-project ---
> [INFO] You have 0 Checkstyle violations.
> {noformat}
> Content of the generated "target/checkstyle-result.xml":
> {code:xml}
> 
> 
> 
> {code}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Closed] (SUREFIRE-2124) Avoid creating unnecessary target files for pom projects

2024-06-27 Thread Michael Osipov (Jira)


 [ 
https://issues.apache.org/jira/browse/SUREFIRE-2124?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Michael Osipov closed SUREFIRE-2124.

Resolution: Fixed

Fixed with 
[5f64810fdca1c942eabf0f81394581e8238b2783|https://gitbox.apache.org/repos/asf?p=maven-surefire.git=commit=5f64810fdca1c942eabf0f81394581e8238b2783].

> Avoid creating unnecessary target files for pom projects
> 
>
> Key: SUREFIRE-2124
> URL: https://issues.apache.org/jira/browse/SUREFIRE-2124
> Project: Maven Surefire
>  Issue Type: Improvement
>  Components: Maven Failsafe Plugin
>Affects Versions: 2.22.2
>Reporter: Alexis Jehan
>Assignee: Michael Osipov
>Priority: Minor
> Fix For: 3.3.1
>
>
> Because pom projects do not have tests, It is not necessary to create the 
> "target/failsafe-reports/failsafe-summary.xml" file for these projects.
> The behavior should be the same as the surefire plugin which works as 
> expected.
> Maven configuration:
> {code:xml}
> 
>   org.apache.maven.plugins
>   maven-failsafe-plugin
>   2.22.2
>   
>   
>   ${argLine} --enable-preview
>   
>   
>   
>   failsafe-integration-test
>   
>   integration-test
>   
>   
>   
>   failsafe-verify
>   
>   verify
>   
>   
>   
> 
> {code}
> Maven output:
> {noformat}
> [INFO] --- maven-failsafe-plugin:2.22.2:integration-test 
> (failsafe-integration-test) @ parent-project ---
> [INFO] No tests to run.
> {noformat}
> Content of generated {{target/failsafe-reports/failsafe-summary.xml}} :
> {code:xml}
> 
> http://www.w3.org/2001/XMLSchema-instance; 
> xsi:noNamespaceSchemaLocation="https://maven.apache.org/surefire/maven-surefire-plugin/xsd/failsafe-summary.xsd;
>  result="254" timeout="false">
> 0
> 0
> 0
> 0
>  xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"/>
> 
> {code}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (MCHECKSTYLE-431) Avoid creating unnecessary target files for pom projects

2024-06-27 Thread Michael Osipov (Jira)


[ 
https://issues.apache.org/jira/browse/MCHECKSTYLE-431?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17860411#comment-17860411
 ] 

Michael Osipov commented on MCHECKSTYLE-431:


I will check this again, but I am afraid that those files are created by 
checkstyle directly. This means they would be logically opaque...

> Avoid creating unnecessary target files for pom projects
> 
>
> Key: MCHECKSTYLE-431
> URL: https://issues.apache.org/jira/browse/MCHECKSTYLE-431
> Project: Maven Checkstyle Plugin
>  Issue Type: Improvement
>  Components: checkstyle:check
>Affects Versions: 3.2.1
>Reporter: Alexis Jehan
>Priority: Minor
>
> Because pom projects do not have Java code, It is not necessary to create 
> "target/checkstyle-cachefile", "target/checkstyle-checker.xml", 
> "target/checkstyle-result.xml" and "target/checkstyle-suppressions.xml" files 
> for these projects.
> Maven configuration:
> {code:xml}
> 
>   org.apache.maven.plugins
>   maven-checkstyle-plugin
>   3.2.1
>   
>   
>   com.puppycrawl.tools
>   checkstyle
>   10.9.3
>   
>   
>   
>   checkstyle.xml
>   
> checkstyle-suppressions.xml
>   true
>   info
>   
>   
>   
>   checkstyle-check
>   validate
>   
>   check
>   
>   
>   
> 
> {code}
> Maven output:
> {noformat}
> [INFO] --- checkstyle:3.2.1:check (checkstyle-check) @ parent-project ---
> [INFO] You have 0 Checkstyle violations.
> {noformat}
> Content of the generated "target/checkstyle-result.xml":
> {code:xml}
> 
> 
> 
> {code}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (SUREFIRE-2124) Avoid creating unnecessary target files for pom projects

2024-06-27 Thread Michael Osipov (Jira)


[ 
https://issues.apache.org/jira/browse/SUREFIRE-2124?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17860404#comment-17860404
 ] 

Michael Osipov commented on SUREFIRE-2124:
--

Let me push yet another small improvement then we are good to merge.

> Avoid creating unnecessary target files for pom projects
> 
>
> Key: SUREFIRE-2124
> URL: https://issues.apache.org/jira/browse/SUREFIRE-2124
> Project: Maven Surefire
>  Issue Type: Improvement
>  Components: Maven Failsafe Plugin
>Affects Versions: 2.22.2
>Reporter: Alexis Jehan
>Assignee: Michael Osipov
>Priority: Minor
> Fix For: 3.3.1
>
>
> Because pom projects do not have tests, It is not necessary to create the 
> "target/failsafe-reports/failsafe-summary.xml" file for these projects.
> The behavior should be the same as the surefire plugin which works as 
> expected.
> Maven configuration:
> {code:xml}
> 
>   org.apache.maven.plugins
>   maven-failsafe-plugin
>   2.22.2
>   
>   
>   ${argLine} --enable-preview
>   
>   
>   
>   failsafe-integration-test
>   
>   integration-test
>   
>   
>   
>   failsafe-verify
>   
>   verify
>   
>   
>   
> 
> {code}
> Maven output:
> {noformat}
> [INFO] --- maven-failsafe-plugin:2.22.2:integration-test 
> (failsafe-integration-test) @ parent-project ---
> [INFO] No tests to run.
> {noformat}
> Content of generated {{target/failsafe-reports/failsafe-summary.xml}} :
> {code:xml}
> 
> http://www.w3.org/2001/XMLSchema-instance; 
> xsi:noNamespaceSchemaLocation="https://maven.apache.org/surefire/maven-surefire-plugin/xsd/failsafe-summary.xsd;
>  result="254" timeout="false">
> 0
> 0
> 0
> 0
>  xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"/>
> 
> {code}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (SUREFIRE-2124) Avoid creating unnecessary target files for pom projects

2024-06-27 Thread Alexis Jehan (Jira)


[ 
https://issues.apache.org/jira/browse/SUREFIRE-2124?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17860401#comment-17860401
 ] 

Alexis Jehan commented on SUREFIRE-2124:


This time it works, thank you!

In my project now, remaining files in the parent module's target directory are 
only those from the checkstyle plugin as described here: 
https://issues.apache.org/jira/browse/MCHECKSTYLE-431

> Avoid creating unnecessary target files for pom projects
> 
>
> Key: SUREFIRE-2124
> URL: https://issues.apache.org/jira/browse/SUREFIRE-2124
> Project: Maven Surefire
>  Issue Type: Improvement
>  Components: Maven Failsafe Plugin
>Affects Versions: 2.22.2
>Reporter: Alexis Jehan
>Assignee: Michael Osipov
>Priority: Minor
> Fix For: 3.3.1
>
>
> Because pom projects do not have tests, It is not necessary to create the 
> "target/failsafe-reports/failsafe-summary.xml" file for these projects.
> The behavior should be the same as the surefire plugin which works as 
> expected.
> Maven configuration:
> {code:xml}
> 
>   org.apache.maven.plugins
>   maven-failsafe-plugin
>   2.22.2
>   
>   
>   ${argLine} --enable-preview
>   
>   
>   
>   failsafe-integration-test
>   
>   integration-test
>   
>   
>   
>   failsafe-verify
>   
>   verify
>   
>   
>   
> 
> {code}
> Maven output:
> {noformat}
> [INFO] --- maven-failsafe-plugin:2.22.2:integration-test 
> (failsafe-integration-test) @ parent-project ---
> [INFO] No tests to run.
> {noformat}
> Content of generated {{target/failsafe-reports/failsafe-summary.xml}} :
> {code:xml}
> 
> http://www.w3.org/2001/XMLSchema-instance; 
> xsi:noNamespaceSchemaLocation="https://maven.apache.org/surefire/maven-surefire-plugin/xsd/failsafe-summary.xsd;
>  result="254" timeout="false">
> 0
> 0
> 0
> 0
>  xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"/>
> 
> {code}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Comment Edited] (SUREFIRE-2124) Avoid creating unnecessary target files for pom projects

2024-06-27 Thread Alexis Jehan (Jira)


[ 
https://issues.apache.org/jira/browse/SUREFIRE-2124?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17860265#comment-17860265
 ] 

Alexis Jehan edited comment on SUREFIRE-2124 at 6/27/24 9:25 AM:
-

Yes that is still the case with the latest version.


was (Author: alexisj):
Yes that is still the case with the lastest version.

> Avoid creating unnecessary target files for pom projects
> 
>
> Key: SUREFIRE-2124
> URL: https://issues.apache.org/jira/browse/SUREFIRE-2124
> Project: Maven Surefire
>  Issue Type: Improvement
>  Components: Maven Failsafe Plugin
>Affects Versions: 2.22.2
>Reporter: Alexis Jehan
>Assignee: Michael Osipov
>Priority: Minor
> Fix For: 3.3.1
>
>
> Because pom projects do not have tests, It is not necessary to create the 
> "target/failsafe-reports/failsafe-summary.xml" file for these projects.
> The behavior should be the same as the surefire plugin which works as 
> expected.
> Maven configuration:
> {code:xml}
> 
>   org.apache.maven.plugins
>   maven-failsafe-plugin
>   2.22.2
>   
>   
>   ${argLine} --enable-preview
>   
>   
>   
>   failsafe-integration-test
>   
>   integration-test
>   
>   
>   
>   failsafe-verify
>   
>   verify
>   
>   
>   
> 
> {code}
> Maven output:
> {noformat}
> [INFO] --- maven-failsafe-plugin:2.22.2:integration-test 
> (failsafe-integration-test) @ parent-project ---
> [INFO] No tests to run.
> {noformat}
> Content of generated {{target/failsafe-reports/failsafe-summary.xml}} :
> {code:xml}
> 
> http://www.w3.org/2001/XMLSchema-instance; 
> xsi:noNamespaceSchemaLocation="https://maven.apache.org/surefire/maven-surefire-plugin/xsd/failsafe-summary.xsd;
>  result="254" timeout="false">
> 0
> 0
> 0
> 0
>  xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"/>
> 
> {code}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (MNG-8137) Goal jar unconditionally replace main artifact (if it was not set)

2024-06-27 Thread Tamas Cservenak (Jira)


[ 
https://issues.apache.org/jira/browse/MNG-8137?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17860397#comment-17860397
 ] 

Tamas Cservenak commented on MNG-8137:
--

If that is the case, is fine. But still we have situation when packaging=war 
(or whatever else) have in reactor get direct mojo invocation like jar:jar... 
So this is not only about packing=pom, but IMO a much broader issue.

In my opinion, following conditions are true:
 * plugin "knows" what it produces (ie. jar plugin produces JAR)
 * core have to have some means to check what main artifact is "expected to be"
 * nor plugin nor core should be "aware of all existing packaging out there", 
as it is impossible
 * hence, it is maybe the packaging, that can/should "nod" like "yes, I accept 
this file as main artifact"?

> Goal jar unconditionally replace main artifact (if it was not set)
> --
>
> Key: MNG-8137
> URL: https://issues.apache.org/jira/browse/MNG-8137
> Project: Maven
>  Issue Type: Bug
>Reporter: Tamas Cservenak
>Priority: Major
>
> This seems wrong, as it completely circumvents any check... for example on 
> project with packaging=pom it will attach a JAR, bringing project into wrong 
> state.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (SUREFIRE-2203) In pom.xml, the configurationParameters configuration junit.platform.launcher.interceptors.enabled does not work

2024-06-27 Thread Hengyunabc Chen (Jira)


[ 
https://issues.apache.org/jira/browse/SUREFIRE-2203?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17860384#comment-17860384
 ] 

Hengyunabc Chen commented on SUREFIRE-2203:
---

[~michael-o]  https://github.com/hengyunabc/junit5-surefire-bug-demo

> In pom.xml, the configurationParameters configuration 
> junit.platform.launcher.interceptors.enabled does not work
> 
>
> Key: SUREFIRE-2203
> URL: https://issues.apache.org/jira/browse/SUREFIRE-2203
> Project: Maven Surefire
>  Issue Type: Bug
>  Components: JUnit 5.x support
>Reporter: Hengyunabc Chen
>Priority: Trivial
> Fix For: waiting-for-feedback
>
>
> In pom.xml, the configuration 
> {{junit.platform.launcher.interceptors.enabled}} does not work.
> The following configuration does not take effect:
> {code:java}
> 
> maven-surefire-plugin
> 3.1.2
> 
> 
> 
> junit.platform.launcher.interceptors.enabled=true
> 
> 
>  {code}
>  
> The following configuration can work:
> {code:java}
> 
> maven-surefire-plugin
> 3.1.2
> 
> 
> 
> true
> 
>  {code}
>  
> Or configuring it in the {{junit-platform.properties}} file will also work.
> Reference documentation:
>  * 
> [https://junit.org/junit5/docs/snapshot/user-guide/#launcher-api-launcher-interceptors-custom]
>  * 
> [https://junit.org/junit5/docs/snapshot/user-guide/#running-tests-build-maven-config-params]
>  * 
> [https://maven.apache.org/surefire/maven-surefire-plugin/examples/junit-platform.html#configuration-parameters]



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Updated] (MRESOLVER-27) turn artifacts into Java 9 modules

2024-06-27 Thread Robert Scholte (Jira)


 [ 
https://issues.apache.org/jira/browse/MRESOLVER-27?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robert Scholte updated MRESOLVER-27:

Description: 
Java 9 with Jigsaw modules is coming

Maven Artifact Resolver:
# has a chance to be turned into Java 9 modules
# could be useful as Java 9 modules

Automatic Modules Names in MRESOLVER-26 is a quickstart, but turning artifacts 
into real Java 9 modules would be more powerful, even if it requires more work

NOTE: partly done for api, spi and utils in 
https://github.com/apache/maven-resolver/commit/8266e6c320a7cf4deed3deb253ff4fd506d1d8f2


  was:
Java 9 with Jigsaw modules is coming

Maven Artifact Resolver:
# has a chance to be turned into Java 9 modules
# could be useful as Java 9 modules

Automatic Modules Names in MRESOLVER-26 is a quickstart, but turning artifacts 
into real Java 9 modules would be more powerful, even if it requires more work



> turn artifacts into Java 9 modules
> --
>
> Key: MRESOLVER-27
> URL: https://issues.apache.org/jira/browse/MRESOLVER-27
> Project: Maven Resolver
>  Issue Type: New Feature
>  Components: Resolver
>Affects Versions: Maven Artifact Resolver 1.1.0
>Reporter: Herve Boutemy
>Priority: Minor
>
> Java 9 with Jigsaw modules is coming
> Maven Artifact Resolver:
> # has a chance to be turned into Java 9 modules
> # could be useful as Java 9 modules
> Automatic Modules Names in MRESOLVER-26 is a quickstart, but turning 
> artifacts into real Java 9 modules would be more powerful, even if it 
> requires more work
> NOTE: partly done for api, spi and utils in 
> https://github.com/apache/maven-resolver/commit/8266e6c320a7cf4deed3deb253ff4fd506d1d8f2



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (MJAVADOC-798) Consider user settings when using invoker

2024-06-27 Thread Carsten Pfeiffer (Jira)


[ 
https://issues.apache.org/jira/browse/MJAVADOC-798?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17860373#comment-17860373
 ] 

Carsten Pfeiffer commented on MJAVADOC-798:
---

PR https://github.com/apache/maven-javadoc-plugin/pull/290

> Consider user settings when using invoker
> -
>
> Key: MJAVADOC-798
> URL: https://issues.apache.org/jira/browse/MJAVADOC-798
> Project: Maven Javadoc Plugin
>  Issue Type: Improvement
>Reporter: Carsten Pfeiffer
>Priority: Minor
>
> I get this in some of our builds:
> {code}
> [INFO] The goal 'org.apache.maven.plugins:maven-javadoc-plugin:3.7.0:javadoc' 
> has not been previously called for the module: 
> 'de.example:myproject:jar:1.0.0-SNAPSHOT'. Trying to invoke it...
> [ERROR] MavenInvocationException: Error when invoking Maven, consult the 
> invoker log file: 
> /tmp/myproject/myproject-submodule/target/invoker/maven-javadoc-plugin1730810899.txt
> [WARNING] Creating fake javadoc directory to prevent repeated invocations: 
> /tmp/myproject/myproject/target/site/apidocs
> [ERROR] Error fetching link: /tmp/myproject/myproject/target/site/apidocs. 
> Ignored it.
> {code}
> And looking at the invoker log, I see that some parent pom cannot be found, 
> because my custom {{settings.xml}} that I specified with {{mvn -s 
> mysettings.xml}} was not considered:
> {code}
> Invoking Maven for the goals: 
> [org.apache.maven.plugins:maven-javadoc-plugin:3.7.0:javadoc] with no 
> properties
> M2_HOME=/home/gis/.m2/wrapper/dists/apache-maven-3.6-bin/5al0cn3ksttl2pq1n2rbut6jh8/apache-maven-3.6.3
> MAVEN_OPTS=null
> JAVA_HOME=/usr/lib/jvm/java-17-openjdk-amd64
> JAVA_OPTS=null
> [INFO] Scanning for projects...
> [ERROR] [ERROR] Some problems were encountered while processing the POMs:
> [FATAL] Non-resolvable parent POM for 
> de.example:myproject-parent:1.0.0-SNAPSHOT: Failure to find 
> de.example.other:someparent:pom:1.9.0-I26 in 
> https://mynexus/content/groups/releases was cached in the local repository, 
> resolution will not be reattempted until the update interval of releases has 
> elapsed or updates are forced and 'parent.relativePath' points at wrong local 
> POM @ de.example:myproject-parent:1.0.0-SNAPSHOT, /tmp/myproject/pom.xml, 
> line 8, column 10
>  @ 
> [ERROR] The build could not read 1 project -> [Help 1]
> {code}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Created] (MJAVADOC-798) Consider user settings when using invoker

2024-06-27 Thread Carsten Pfeiffer (Jira)
Carsten Pfeiffer created MJAVADOC-798:
-

 Summary: Consider user settings when using invoker
 Key: MJAVADOC-798
 URL: https://issues.apache.org/jira/browse/MJAVADOC-798
 Project: Maven Javadoc Plugin
  Issue Type: Improvement
Reporter: Carsten Pfeiffer


I get this in some of our builds:
{code}
[INFO] The goal 'org.apache.maven.plugins:maven-javadoc-plugin:3.7.0:javadoc' 
has not been previously called for the module: 
'de.example:myproject:jar:1.0.0-SNAPSHOT'. Trying to invoke it...
[ERROR] MavenInvocationException: Error when invoking Maven, consult the 
invoker log file: 
/tmp/myproject/myproject-submodule/target/invoker/maven-javadoc-plugin1730810899.txt
[WARNING] Creating fake javadoc directory to prevent repeated invocations: 
/tmp/myproject/myproject/target/site/apidocs
[ERROR] Error fetching link: /tmp/myproject/myproject/target/site/apidocs. 
Ignored it.
{code}

And looking at the invoker log, I see that some parent pom cannot be found, 
because my custom {{settings.xml}} that I specified with {{mvn -s 
mysettings.xml}} was not considered:

{code}
Invoking Maven for the goals: 
[org.apache.maven.plugins:maven-javadoc-plugin:3.7.0:javadoc] with no properties

M2_HOME=/home/gis/.m2/wrapper/dists/apache-maven-3.6-bin/5al0cn3ksttl2pq1n2rbut6jh8/apache-maven-3.6.3
MAVEN_OPTS=null
JAVA_HOME=/usr/lib/jvm/java-17-openjdk-amd64
JAVA_OPTS=null

[INFO] Scanning for projects...
[ERROR] [ERROR] Some problems were encountered while processing the POMs:
[FATAL] Non-resolvable parent POM for 
de.example:myproject-parent:1.0.0-SNAPSHOT: Failure to find 
de.example.other:someparent:pom:1.9.0-I26 in 
https://mynexus/content/groups/releases was cached in the local repository, 
resolution will not be reattempted until the update interval of releases has 
elapsed or updates are forced and 'parent.relativePath' points at wrong local 
POM @ de.example:myproject-parent:1.0.0-SNAPSHOT, /tmp/myproject/pom.xml, line 
8, column 10
 @ 
[ERROR] The build could not read 1 project -> [Help 1]
{code}




--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Updated] (MDEPLOY-320) Unclear exception prompt

2024-06-27 Thread Huang Xiao (Jira)


 [ 
https://issues.apache.org/jira/browse/MDEPLOY-320?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Huang Xiao updated MDEPLOY-320:
---
Description: 
Examples of unclear source code:

!image-2024-06-26-20-21-58-461.png|width=869,height=527!

!image-2024-06-26-20-23-51-491.png|width=872,height=514!

Short message output from the console:

!image-2024-06-26-20-52-10-086.png|width=839,height=645!

*Suggest:* Use clearer longMessage instead of shortMessage.

 

 
h3. *Optimization:*

The following is the optimized effect.

 

1. example 1

!image-2024-06-27-15-13-14-762.png|width=1606,height=150!

expected error message

*!image-2024-06-27-15-03-23-770.png|width=1690,height=256!*

 

2. example 2

*!image-2024-06-27-15-12-23-385.png|width=1271,height=120!*

expected error message

*!image-2024-06-27-15-11-37-833.png|width=1390,height=212!*

  was:
Examples of unclear source code:

!image-2024-06-26-20-21-58-461.png|width=869,height=527!

!image-2024-06-26-20-23-51-491.png|width=872,height=514!

Short message output from the console:

!image-2024-06-26-20-52-10-086.png|width=839,height=645!

*Suggest:* Use clearer longMessage instead of shortMessage.

 

 
h3. *Optimization:*

The following is the optimized effect.

 

1. example 1

!image-2024-06-27-15-13-14-762.png|width=1606,height=150!

expected error message

*!image-2024-06-27-15-03-23-770.png|width=1690,height=256!*

 

2. example 2 ** 

*!image-2024-06-27-15-12-23-385.png|width=1271,height=120!*

expected error message

*!image-2024-06-27-15-11-37-833.png|width=1390,height=212!*


> Unclear exception prompt
> 
>
> Key: MDEPLOY-320
> URL: https://issues.apache.org/jira/browse/MDEPLOY-320
> Project: Maven Deploy Plugin
>  Issue Type: Improvement
>  Components: deploy:deploy
>Reporter: Huang Xiao
>Priority: Major
> Attachments: image-2024-06-26-20-21-58-461.png, 
> image-2024-06-26-20-23-51-491.png, image-2024-06-26-20-52-10-086.png, 
> image-2024-06-27-14-48-46-433.png, image-2024-06-27-15-03-23-770.png, 
> image-2024-06-27-15-05-19-091.png, image-2024-06-27-15-11-37-833.png, 
> image-2024-06-27-15-12-23-385.png, image-2024-06-27-15-13-14-762.png
>
>
> Examples of unclear source code:
> !image-2024-06-26-20-21-58-461.png|width=869,height=527!
> !image-2024-06-26-20-23-51-491.png|width=872,height=514!
> Short message output from the console:
> !image-2024-06-26-20-52-10-086.png|width=839,height=645!
> *Suggest:* Use clearer longMessage instead of shortMessage.
>  
>  
> h3. *Optimization:*
> The following is the optimized effect.
>  
> 1. example 1
> !image-2024-06-27-15-13-14-762.png|width=1606,height=150!
> expected error message
> *!image-2024-06-27-15-03-23-770.png|width=1690,height=256!*
>  
> 2. example 2
> *!image-2024-06-27-15-12-23-385.png|width=1271,height=120!*
> expected error message
> *!image-2024-06-27-15-11-37-833.png|width=1390,height=212!*



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Updated] (MDEPLOY-320) Unclear exception prompt

2024-06-27 Thread Huang Xiao (Jira)


 [ 
https://issues.apache.org/jira/browse/MDEPLOY-320?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Huang Xiao updated MDEPLOY-320:
---
Description: 
Examples of unclear source code:

!image-2024-06-26-20-21-58-461.png|width=869,height=527!

!image-2024-06-26-20-23-51-491.png|width=872,height=514!

Short message output from the console:

!image-2024-06-26-20-52-10-086.png|width=839,height=645!

*Suggest:* Use clearer longMessage instead of shortMessage.

 

 
h3. *Optimization:*

The following is the optimized effect.

 

1. example 1

!image-2024-06-27-15-13-14-762.png|width=1606,height=150!

expected error message

*!image-2024-06-27-15-03-23-770.png|width=1690,height=256!*

 

2. example 2 ** 

*!image-2024-06-27-15-12-23-385.png|width=1271,height=120!*

expected error message

*!image-2024-06-27-15-11-37-833.png|width=1390,height=212!*

  was:
!image-2024-06-26-20-21-58-461.png|width=869,height=527!

!image-2024-06-26-20-23-51-491.png|width=872,height=514!

Short message output from the console:

!image-2024-06-26-20-52-10-086.png|width=839,height=645!

 

*Suggest:*

Use clearer longMessage instead of shortMessage.

 


> Unclear exception prompt
> 
>
> Key: MDEPLOY-320
> URL: https://issues.apache.org/jira/browse/MDEPLOY-320
> Project: Maven Deploy Plugin
>  Issue Type: Improvement
>  Components: deploy:deploy
>Reporter: Huang Xiao
>Priority: Major
> Attachments: image-2024-06-26-20-21-58-461.png, 
> image-2024-06-26-20-23-51-491.png, image-2024-06-26-20-52-10-086.png, 
> image-2024-06-27-14-48-46-433.png, image-2024-06-27-15-03-23-770.png, 
> image-2024-06-27-15-05-19-091.png, image-2024-06-27-15-11-37-833.png, 
> image-2024-06-27-15-12-23-385.png, image-2024-06-27-15-13-14-762.png
>
>
> Examples of unclear source code:
> !image-2024-06-26-20-21-58-461.png|width=869,height=527!
> !image-2024-06-26-20-23-51-491.png|width=872,height=514!
> Short message output from the console:
> !image-2024-06-26-20-52-10-086.png|width=839,height=645!
> *Suggest:* Use clearer longMessage instead of shortMessage.
>  
>  
> h3. *Optimization:*
> The following is the optimized effect.
>  
> 1. example 1
> !image-2024-06-27-15-13-14-762.png|width=1606,height=150!
> expected error message
> *!image-2024-06-27-15-03-23-770.png|width=1690,height=256!*
>  
> 2. example 2 ** 
> *!image-2024-06-27-15-12-23-385.png|width=1271,height=120!*
> expected error message
> *!image-2024-06-27-15-11-37-833.png|width=1390,height=212!*



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Updated] (MDEPLOY-320) Unclear exception prompt

2024-06-27 Thread Huang Xiao (Jira)


 [ 
https://issues.apache.org/jira/browse/MDEPLOY-320?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Huang Xiao updated MDEPLOY-320:
---
Attachment: image-2024-06-27-15-13-14-762.png

> Unclear exception prompt
> 
>
> Key: MDEPLOY-320
> URL: https://issues.apache.org/jira/browse/MDEPLOY-320
> Project: Maven Deploy Plugin
>  Issue Type: Improvement
>  Components: deploy:deploy
>Reporter: Huang Xiao
>Priority: Major
> Attachments: image-2024-06-26-20-21-58-461.png, 
> image-2024-06-26-20-23-51-491.png, image-2024-06-26-20-52-10-086.png, 
> image-2024-06-27-14-48-46-433.png, image-2024-06-27-15-03-23-770.png, 
> image-2024-06-27-15-05-19-091.png, image-2024-06-27-15-11-37-833.png, 
> image-2024-06-27-15-12-23-385.png, image-2024-06-27-15-13-14-762.png
>
>
> !image-2024-06-26-20-21-58-461.png|width=869,height=527!
> !image-2024-06-26-20-23-51-491.png|width=872,height=514!
> Short message output from the console:
> !image-2024-06-26-20-52-10-086.png|width=839,height=645!
>  
> *Suggest:*
> Use clearer longMessage instead of shortMessage.
>  



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Updated] (MDEPLOY-320) Unclear exception prompt

2024-06-27 Thread Huang Xiao (Jira)


 [ 
https://issues.apache.org/jira/browse/MDEPLOY-320?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Huang Xiao updated MDEPLOY-320:
---
Attachment: image-2024-06-27-15-12-23-385.png

> Unclear exception prompt
> 
>
> Key: MDEPLOY-320
> URL: https://issues.apache.org/jira/browse/MDEPLOY-320
> Project: Maven Deploy Plugin
>  Issue Type: Improvement
>  Components: deploy:deploy
>Reporter: Huang Xiao
>Priority: Major
> Attachments: image-2024-06-26-20-21-58-461.png, 
> image-2024-06-26-20-23-51-491.png, image-2024-06-26-20-52-10-086.png, 
> image-2024-06-27-14-48-46-433.png, image-2024-06-27-15-03-23-770.png, 
> image-2024-06-27-15-05-19-091.png, image-2024-06-27-15-11-37-833.png, 
> image-2024-06-27-15-12-23-385.png
>
>
> !image-2024-06-26-20-21-58-461.png|width=869,height=527!
> !image-2024-06-26-20-23-51-491.png|width=872,height=514!
> Short message output from the console:
> !image-2024-06-26-20-52-10-086.png|width=839,height=645!
>  
> *Suggest:*
> Use clearer longMessage instead of shortMessage.
>  



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Updated] (MDEPLOY-320) Unclear exception prompt

2024-06-27 Thread Huang Xiao (Jira)


 [ 
https://issues.apache.org/jira/browse/MDEPLOY-320?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Huang Xiao updated MDEPLOY-320:
---
Attachment: image-2024-06-27-15-11-37-833.png

> Unclear exception prompt
> 
>
> Key: MDEPLOY-320
> URL: https://issues.apache.org/jira/browse/MDEPLOY-320
> Project: Maven Deploy Plugin
>  Issue Type: Improvement
>  Components: deploy:deploy
>Reporter: Huang Xiao
>Priority: Major
> Attachments: image-2024-06-26-20-21-58-461.png, 
> image-2024-06-26-20-23-51-491.png, image-2024-06-26-20-52-10-086.png, 
> image-2024-06-27-14-48-46-433.png, image-2024-06-27-15-03-23-770.png, 
> image-2024-06-27-15-05-19-091.png, image-2024-06-27-15-11-37-833.png
>
>
> !image-2024-06-26-20-21-58-461.png|width=869,height=527!
> !image-2024-06-26-20-23-51-491.png|width=872,height=514!
> Short message output from the console:
> !image-2024-06-26-20-52-10-086.png|width=839,height=645!
>  
> *Suggest:*
> Use clearer longMessage instead of shortMessage.
>  



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (MNG-8137) Goal jar unconditionally replace main artifact (if it was not set)

2024-06-27 Thread Guillaume Nodet (Jira)


[ 
https://issues.apache.org/jira/browse/MNG-8137?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17860363#comment-17860363
 ] 

Guillaume Nodet commented on MNG-8137:
--

Actually, I don't think the current code allows breaking things anymore.  And 
it looks correct to me.

Note that if {{{}packaging=pom{}}}, {{getMainArtifact()}} returns 
{{{}Optional.empty(){}}}, so {{get()}} will throw an exception.

So you can't really set a jar as the main artifact for a pom package project.  
You can always attach with a classifier, but that has never been forbidden, 
right ?

 

> Goal jar unconditionally replace main artifact (if it was not set)
> --
>
> Key: MNG-8137
> URL: https://issues.apache.org/jira/browse/MNG-8137
> Project: Maven
>  Issue Type: Bug
>Reporter: Tamas Cservenak
>Priority: Major
>
> This seems wrong, as it completely circumvents any check... for example on 
> project with packaging=pom it will attach a JAR, bringing project into wrong 
> state.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Updated] (MDEPLOY-320) Unclear exception prompt

2024-06-27 Thread Huang Xiao (Jira)


 [ 
https://issues.apache.org/jira/browse/MDEPLOY-320?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Huang Xiao updated MDEPLOY-320:
---
Attachment: image-2024-06-27-15-05-19-091.png

> Unclear exception prompt
> 
>
> Key: MDEPLOY-320
> URL: https://issues.apache.org/jira/browse/MDEPLOY-320
> Project: Maven Deploy Plugin
>  Issue Type: Improvement
>  Components: deploy:deploy
>Reporter: Huang Xiao
>Priority: Major
> Attachments: image-2024-06-26-20-21-58-461.png, 
> image-2024-06-26-20-23-51-491.png, image-2024-06-26-20-52-10-086.png, 
> image-2024-06-27-14-48-46-433.png, image-2024-06-27-15-03-23-770.png, 
> image-2024-06-27-15-05-19-091.png
>
>
> !image-2024-06-26-20-21-58-461.png|width=869,height=527!
> !image-2024-06-26-20-23-51-491.png|width=872,height=514!
> Short message output from the console:
> !image-2024-06-26-20-52-10-086.png|width=839,height=645!
>  
> *Suggest:*
> Use clearer longMessage instead of shortMessage.
>  



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Updated] (MDEPLOY-320) Unclear exception prompt

2024-06-27 Thread Huang Xiao (Jira)


 [ 
https://issues.apache.org/jira/browse/MDEPLOY-320?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Huang Xiao updated MDEPLOY-320:
---
Attachment: image-2024-06-27-15-03-23-770.png

> Unclear exception prompt
> 
>
> Key: MDEPLOY-320
> URL: https://issues.apache.org/jira/browse/MDEPLOY-320
> Project: Maven Deploy Plugin
>  Issue Type: Improvement
>  Components: deploy:deploy
>Reporter: Huang Xiao
>Priority: Major
> Attachments: image-2024-06-26-20-21-58-461.png, 
> image-2024-06-26-20-23-51-491.png, image-2024-06-26-20-52-10-086.png, 
> image-2024-06-27-14-48-46-433.png, image-2024-06-27-15-03-23-770.png
>
>
> !image-2024-06-26-20-21-58-461.png|width=869,height=527!
> !image-2024-06-26-20-23-51-491.png|width=872,height=514!
> Short message output from the console:
> !image-2024-06-26-20-52-10-086.png|width=839,height=645!
>  
> *Suggest:*
> Use clearer longMessage instead of shortMessage.
>  



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Updated] (MDEPLOY-320) Unclear exception prompt

2024-06-27 Thread Huang Xiao (Jira)


 [ 
https://issues.apache.org/jira/browse/MDEPLOY-320?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Huang Xiao updated MDEPLOY-320:
---
Description: 
!image-2024-06-26-20-21-58-461.png|width=869,height=527!

!image-2024-06-26-20-23-51-491.png|width=872,height=514!

Short message output from the console:

!image-2024-06-26-20-52-10-086.png|width=839,height=645!

 

*Suggest:*

Use clearer longMessage instead of shortMessage.

 

  was:
!image-2024-06-26-20-21-58-461.png|width=869,height=527!

!image-2024-06-26-20-23-51-491.png|width=872,height=514!

Short message output from the console:

!image-2024-06-26-20-52-10-086.png|width=839,height=645!

 

{*}Suggest{*}:

Use clearer longMessage instead of shortMessage.


> Unclear exception prompt
> 
>
> Key: MDEPLOY-320
> URL: https://issues.apache.org/jira/browse/MDEPLOY-320
> Project: Maven Deploy Plugin
>  Issue Type: Improvement
>  Components: deploy:deploy
>Reporter: Huang Xiao
>Priority: Major
> Attachments: image-2024-06-26-20-21-58-461.png, 
> image-2024-06-26-20-23-51-491.png, image-2024-06-26-20-52-10-086.png, 
> image-2024-06-27-14-48-46-433.png
>
>
> !image-2024-06-26-20-21-58-461.png|width=869,height=527!
> !image-2024-06-26-20-23-51-491.png|width=872,height=514!
> Short message output from the console:
> !image-2024-06-26-20-52-10-086.png|width=839,height=645!
>  
> *Suggest:*
> Use clearer longMessage instead of shortMessage.
>  



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Updated] (MDEPLOY-320) Unclear exception prompt

2024-06-27 Thread Huang Xiao (Jira)


 [ 
https://issues.apache.org/jira/browse/MDEPLOY-320?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Huang Xiao updated MDEPLOY-320:
---
Attachment: image-2024-06-27-14-48-46-433.png

> Unclear exception prompt
> 
>
> Key: MDEPLOY-320
> URL: https://issues.apache.org/jira/browse/MDEPLOY-320
> Project: Maven Deploy Plugin
>  Issue Type: Improvement
>  Components: deploy:deploy
>Reporter: Huang Xiao
>Priority: Major
> Attachments: image-2024-06-26-20-21-58-461.png, 
> image-2024-06-26-20-23-51-491.png, image-2024-06-26-20-52-10-086.png, 
> image-2024-06-27-14-48-46-433.png
>
>
> !image-2024-06-26-20-21-58-461.png|width=869,height=527!
> !image-2024-06-26-20-23-51-491.png|width=872,height=514!
> Short message output from the console:
> !image-2024-06-26-20-52-10-086.png|width=839,height=645!
>  
> {*}Suggest{*}:
> Use clearer longMessage instead of shortMessage.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (SUREFIRE-2124) Avoid creating unnecessary target files for pom projects

2024-06-27 Thread Michael Osipov (Jira)


[ 
https://issues.apache.org/jira/browse/SUREFIRE-2124?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17860347#comment-17860347
 ] 

Michael Osipov commented on SUREFIRE-2124:
--

Good catch! Updated. Try again, please.

> Avoid creating unnecessary target files for pom projects
> 
>
> Key: SUREFIRE-2124
> URL: https://issues.apache.org/jira/browse/SUREFIRE-2124
> Project: Maven Surefire
>  Issue Type: Improvement
>  Components: Maven Failsafe Plugin
>Affects Versions: 2.22.2
>Reporter: Alexis Jehan
>Assignee: Michael Osipov
>Priority: Minor
> Fix For: 3.3.1
>
>
> Because pom projects do not have tests, It is not necessary to create the 
> "target/failsafe-reports/failsafe-summary.xml" file for these projects.
> The behavior should be the same as the surefire plugin which works as 
> expected.
> Maven configuration:
> {code:xml}
> 
>   org.apache.maven.plugins
>   maven-failsafe-plugin
>   2.22.2
>   
>   
>   ${argLine} --enable-preview
>   
>   
>   
>   failsafe-integration-test
>   
>   integration-test
>   
>   
>   
>   failsafe-verify
>   
>   verify
>   
>   
>   
> 
> {code}
> Maven output:
> {noformat}
> [INFO] --- maven-failsafe-plugin:2.22.2:integration-test 
> (failsafe-integration-test) @ parent-project ---
> [INFO] No tests to run.
> {noformat}
> Content of generated {{target/failsafe-reports/failsafe-summary.xml}} :
> {code:xml}
> 
> http://www.w3.org/2001/XMLSchema-instance; 
> xsi:noNamespaceSchemaLocation="https://maven.apache.org/surefire/maven-surefire-plugin/xsd/failsafe-summary.xsd;
>  result="254" timeout="false">
> 0
> 0
> 0
> 0
>  xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"/>
> 
> {code}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)