[jira] [Commented] (MPMD-404) Upgrade to PMD 7.5.0
[ https://issues.apache.org/jira/browse/MPMD-404?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17885550#comment-17885550 ] ASF GitHub Bot commented on MPMD-404: - michael-o closed pull request #168: [MPMD-404] Bump PMD to 7.5.0 URL: https://github.com/apache/maven-pmd-plugin/pull/168 > Upgrade to PMD 7.5.0 > > > Key: MPMD-404 > URL: https://issues.apache.org/jira/browse/MPMD-404 > Project: Maven PMD Plugin > Issue Type: Dependency upgrade >Reporter: Piotr Zygielo >Assignee: Michael Osipov >Priority: Major > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MPMD-404) Upgrade to PMD 7.5.0
[ https://issues.apache.org/jira/browse/MPMD-404?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17885551#comment-17885551 ] ASF GitHub Bot commented on MPMD-404: - michael-o commented on PR #170: URL: https://github.com/apache/maven-pmd-plugin/pull/170#issuecomment-2380571794 Like I said, before I release the plugin again there will be a hundred new releases in between. > Upgrade to PMD 7.5.0 > > > Key: MPMD-404 > URL: https://issues.apache.org/jira/browse/MPMD-404 > Project: Maven PMD Plugin > Issue Type: Dependency upgrade >Reporter: Piotr Zygielo >Assignee: Michael Osipov >Priority: Major > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MPMD-404) Upgrade to PMD 7.5.0
[ https://issues.apache.org/jira/browse/MPMD-404?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17885549#comment-17885549 ] ASF GitHub Bot commented on MPMD-404: - slachiewicz commented on PR #168: URL: https://github.com/apache/maven-pmd-plugin/pull/168#issuecomment-2380567738 Superseded by #170 > Upgrade to PMD 7.5.0 > > > Key: MPMD-404 > URL: https://issues.apache.org/jira/browse/MPMD-404 > Project: Maven PMD Plugin > Issue Type: Dependency upgrade >Reporter: Piotr Zygielo >Assignee: Michael Osipov >Priority: Major > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MPMD-404) Upgrade to PMD 7.5.0
[ https://issues.apache.org/jira/browse/MPMD-404?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17885433#comment-17885433 ] ASF GitHub Bot commented on MPMD-404: - pzygielo opened a new pull request, #170: URL: https://github.com/apache/maven-pmd-plugin/pull/170 - Closes #168 > Upgrade to PMD 7.5.0 > > > Key: MPMD-404 > URL: https://issues.apache.org/jira/browse/MPMD-404 > Project: Maven PMD Plugin > Issue Type: Dependency upgrade >Reporter: Piotr Zygielo >Assignee: Michael Osipov >Priority: Major > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MPIR-469) Broken link to git documentation page
[ https://issues.apache.org/jira/browse/MPIR-469?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17885108#comment-17885108 ] ASF GitHub Bot commented on MPIR-469: - bhamail opened a new pull request, #77: URL: https://github.com/apache/maven-project-info-reports-plugin/pull/77 The git documentation site has changed and the old general documentation page link is no longer valid. This PR updates the links to use the new general documentation link. [MPIR-469](https://issues.apache.org/jira/browse/MPIR-469) Following this checklist to help us incorporate your contribution quickly and easily: - [x] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/MPIR) filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes. https://issues.apache.org/jira/browse/MPIR-469 - [x] Each commit in the pull request should have a meaningful subject line and body. - [x] Format the pull request title like `[MPIR-XXX] - Fixes bug in ApproximateQuantiles`, where you replace `MPIR-XXX` with the appropriate JIRA issue. Best practice is to use the JIRA issue title in the pull request title and in the first line of the commit message. - [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [x] Run `mvn clean verify` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically. - [x] You have run the integration tests successfully (`mvn -Prun-its clean verify`). If your pull request is about ~20 lines of code you don't need to sign an [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure please ask on the developers list. To make clear that you license your contribution under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) you have to acknowledge this by using the following check-box. - [x] I hereby declare this contribution to be licenced under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) - [x] In any other case, please file an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). > Broken link to git documentation page > - > > Key: MPIR-469 > URL: https://issues.apache.org/jira/browse/MPIR-469 > Project: Maven Project Info Reports Plugin > Issue Type: Bug > Components: scm >Reporter: Dan Rollo >Priority: Major > > The git doc site layout has changed, and the old general link in all > generated maven report sites is no longer valid. I've pushed a PR to change > the old link: > [https://git-scm.com/documentation] > to point to the new general git doc link: > [https://git-scm.com/doc]. > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MARTIFACT-70) jetty-jspc-maven-plugin is build reproducible since 11.0.0
[ https://issues.apache.org/jira/browse/MARTIFACT-70?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17884802#comment-17884802 ] ASF GitHub Bot commented on MARTIFACT-70: - olamy commented on PR #57: URL: https://github.com/apache/maven-artifact-plugin/pull/57#issuecomment-2375363621 > @olamy IIUC, this has been integrated into Jetty 11.0.21 and 12.0.8 [jetty/jetty.project@6a10c65](https://github.com/jetty/jetty.project/commit/6a10c65c359704f94b540447b7bf455b29322c94) , isn't it? The exact commit is https://github.com/jetty/jetty.project/commit/00d324979fb775d6c4e6950155d735a4a7d3403f With upgrade to 10.0.0-M10 which is the first version containing the Apache Tomcat fix. which means Jetty 11.0.0 > jetty-jspc-maven-plugin is build reproducible since 11.0.0 > -- > > Key: MARTIFACT-70 > URL: https://issues.apache.org/jira/browse/MARTIFACT-70 > Project: Maven Artifact Plugin > Issue Type: Task >Reporter: Olivier Lamy >Assignee: Olivier Lamy >Priority: Major > Labels: pull-request-available > Fix For: 3.5.2 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MARTIFACT-70) jetty-jspc-maven-plugin is build reproducible since 11.0.0
[ https://issues.apache.org/jira/browse/MARTIFACT-70?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17884651#comment-17884651 ] ASF GitHub Bot commented on MARTIFACT-70: - hboutemy commented on PR #57: URL: https://github.com/apache/maven-artifact-plugin/pull/57#issuecomment-2374482486 @olamy IIUC, this has been integrated into Jetty 11.0.21 and 12.0.8 https://github.com/jetty/jetty.project/commit/6a10c65c359704f94b540447b7bf455b29322c94 , isn't it? > jetty-jspc-maven-plugin is build reproducible since 11.0.0 > -- > > Key: MARTIFACT-70 > URL: https://issues.apache.org/jira/browse/MARTIFACT-70 > Project: Maven Artifact Plugin > Issue Type: Task >Reporter: Olivier Lamy >Assignee: Olivier Lamy >Priority: Major > Labels: pull-request-available > Fix For: 3.5.2 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MARTIFACT-70) jetty-jspc-maven-plugin is build reproducible since 11.0.0
[ https://issues.apache.org/jira/browse/MARTIFACT-70?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17884543#comment-17884543 ] ASF GitHub Bot commented on MARTIFACT-70: - olamy commented on PR #57: URL: https://github.com/apache/maven-artifact-plugin/pull/57#issuecomment-2373488179 Apache Tomcat change https://github.com/apache/tomcat/commit/374690d5793248f26d5894a33bb5ed562e22da91#diff-57d2f0a72170743f6c3687a48997b2aa37d8d209efe200f00a0b9dc51fc7e572 > jetty-jspc-maven-plugin is build reproducible since 11.0.0 > -- > > Key: MARTIFACT-70 > URL: https://issues.apache.org/jira/browse/MARTIFACT-70 > Project: Maven Artifact Plugin > Issue Type: Task >Reporter: Olivier Lamy >Assignee: Olivier Lamy >Priority: Major > Labels: pull-request-available > Fix For: 3.5.2 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MARTIFACT-70) jetty-jspc-maven-plugin is build reproducible since 11.0.0
[ https://issues.apache.org/jira/browse/MARTIFACT-70?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17884541#comment-17884541 ] ASF GitHub Bot commented on MARTIFACT-70: - olamy opened a new pull request, #57: URL: https://github.com/apache/maven-artifact-plugin/pull/57 Signed-off-by: Olivier Lamy > jetty-jspc-maven-plugin is build reproducible since 11.0.0 > -- > > Key: MARTIFACT-70 > URL: https://issues.apache.org/jira/browse/MARTIFACT-70 > Project: Maven Artifact Plugin > Issue Type: Task >Reporter: Olivier Lamy >Assignee: Olivier Lamy >Priority: Major > Fix For: 3.5.2 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (MARTIFACT-70) jetty-jspc-maven-plugin is build reproducible since 11.0.0
[ https://issues.apache.org/jira/browse/MARTIFACT-70?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated MARTIFACT-70: Labels: pull-request-available (was: ) > jetty-jspc-maven-plugin is build reproducible since 11.0.0 > -- > > Key: MARTIFACT-70 > URL: https://issues.apache.org/jira/browse/MARTIFACT-70 > Project: Maven Artifact Plugin > Issue Type: Task >Reporter: Olivier Lamy >Assignee: Olivier Lamy >Priority: Major > Labels: pull-request-available > Fix For: 3.5.2 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MRESOLVER-397) Deprecate Guice modules
[ https://issues.apache.org/jira/browse/MRESOLVER-397?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17884406#comment-17884406 ] ASF GitHub Bot commented on MRESOLVER-397: -- cstamas commented on PR #328: URL: https://github.com/apache/maven-resolver/pull/328#issuecomment-2372003980 @basil something along these lines? https://github.com/jenkinsci/acceptance-test-harness/pull/1733 > Deprecate Guice modules > --- > > Key: MRESOLVER-397 > URL: https://issues.apache.org/jira/browse/MRESOLVER-397 > Project: Maven Resolver > Issue Type: Task > Components: Resolver >Reporter: Tamas Cservenak >Assignee: Tamas Cservenak >Priority: Minor > Fix For: 1.9.16 > > > So far resolver supported instantiation via: > * sisu components (JSR330) -- as used in Maven > * Guice module > * ServiceLocator > We should drop all non-major ones (guice, sl), as we provided replacement in > for of resolver provider module, so we provide: > * sisu components (JSR330) > * maven-resolver-provider MRESOLVER-387 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MRESOLVER-397) Deprecate Guice modules
[ https://issues.apache.org/jira/browse/MRESOLVER-397?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17884381#comment-17884381 ] ASF GitHub Bot commented on MRESOLVER-397: -- basil commented on PR #328: URL: https://github.com/apache/maven-resolver/pull/328#issuecomment-2371874963 @cstamas This is a test framework, so the added Sisu dependency would be fine for us. Thanks for confirming that Sisu is the preferred migration path for heavy Guice users. As far as building instructions, https://github.com/jenkinsci/acceptance-test-harness/blob/master/docs/DOCKER.md is the best place to start. For testing Guice integration, you could probably even avoid Docker and simply use e.g. `run.sh firefox latest -Dtest=plugins.AntPluginTest#autoInstallAnt`. > Deprecate Guice modules > --- > > Key: MRESOLVER-397 > URL: https://issues.apache.org/jira/browse/MRESOLVER-397 > Project: Maven Resolver > Issue Type: Task > Components: Resolver >Reporter: Tamas Cservenak >Assignee: Tamas Cservenak >Priority: Minor > Fix For: 1.9.16 > > > So far resolver supported instantiation via: > * sisu components (JSR330) -- as used in Maven > * Guice module > * ServiceLocator > We should drop all non-major ones (guice, sl), as we provided replacement in > for of resolver provider module, so we provide: > * sisu components (JSR330) > * maven-resolver-provider MRESOLVER-387 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MRESOLVER-397) Deprecate Guice modules
[ https://issues.apache.org/jira/browse/MRESOLVER-397?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17884373#comment-17884373 ] ASF GitHub Bot commented on MRESOLVER-397: -- cstamas commented on PR #328: URL: https://github.com/apache/maven-resolver/pull/328#issuecomment-2371857312 Given you use Guice already, [Sisu](https://repo.maven.apache.org/maven2/org/eclipse/sisu/org.eclipse.sisu.inject/0.9.0.M3/) is "just" +300KB (if using no_asm and you provide ASM), or +500KB extra dependency. If you can live with that, I'd say "go with Sisu". @basil can you point me at some building instructions where I can test some ideas for migration? > Deprecate Guice modules > --- > > Key: MRESOLVER-397 > URL: https://issues.apache.org/jira/browse/MRESOLVER-397 > Project: Maven Resolver > Issue Type: Task > Components: Resolver >Reporter: Tamas Cservenak >Assignee: Tamas Cservenak >Priority: Minor > Fix For: 1.9.16 > > > So far resolver supported instantiation via: > * sisu components (JSR330) -- as used in Maven > * Guice module > * ServiceLocator > We should drop all non-major ones (guice, sl), as we provided replacement in > for of resolver provider module, so we provide: > * sisu components (JSR330) > * maven-resolver-provider MRESOLVER-387 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MRESOLVER-397) Deprecate Guice modules
[ https://issues.apache.org/jira/browse/MRESOLVER-397?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17884368#comment-17884368 ] ASF GitHub Bot commented on MRESOLVER-397: -- basil commented on PR #328: URL: https://github.com/apache/maven-resolver/pull/328#issuecomment-2371842156 Hi @cstamas, we are currently relying on this deprecated functionality in the Jenkins Acceptance Test Harness (ATH), a Guice-based project that also uses Maven Resolver to fetch Jenkins plugins for tesitng purposes. The relevant functionality is here: https://github.com/jenkinsci/acceptance-test-harness/blob/9b7b87da2b1d5873876d156756f8849b26fcbc16/src/main/java/org/jenkinsci/test/acceptance/utils/aether/AetherModule.java Thank you very much for including this note: > This class is about to be dropped in 2.0.0 release. Use [Sisu](https://projects.eclipse.org/projects/technology.sisu) or use [Maven Resolver Supplier](https://maven.apache.org/resolver/third-party-integrations.html) to get `Resolver` instances. However, I am not sure whether Sisu or Maven Resolver Supplier would be better for our use case. Since we are already using Guice, would Sisu be the preferred migration path? And if so, are there any examples you could point to? > Deprecate Guice modules > --- > > Key: MRESOLVER-397 > URL: https://issues.apache.org/jira/browse/MRESOLVER-397 > Project: Maven Resolver > Issue Type: Task > Components: Resolver >Reporter: Tamas Cservenak >Assignee: Tamas Cservenak >Priority: Minor > Fix For: 1.9.16 > > > So far resolver supported instantiation via: > * sisu components (JSR330) -- as used in Maven > * Guice module > * ServiceLocator > We should drop all non-major ones (guice, sl), as we provided replacement in > for of resolver provider module, so we provide: > * sisu components (JSR330) > * maven-resolver-provider MRESOLVER-387 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MGPG-136) "gpg: signing failed: Bad passphrase" on GitHub Windows runners
[ https://issues.apache.org/jira/browse/MGPG-136?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17884262#comment-17884262 ] ASF GitHub Bot commented on MGPG-136: - cstamas merged PR #120: URL: https://github.com/apache/maven-gpg-plugin/pull/120 > "gpg: signing failed: Bad passphrase" on GitHub Windows runners > --- > > Key: MGPG-136 > URL: https://issues.apache.org/jira/browse/MGPG-136 > Project: Maven GPG Plugin > Issue Type: Bug >Affects Versions: 3.2.0, 3.2.1, 3.2.2, 3.2.3, 3.2.4, 3.2.5, 3.2.6 > Environment: Apache Maven 3.9.6 > (bc0240f3c744dd6b6ec2920b3cd08dcc295161ae) > Maven home: > C:\Users\runneradmin\.m2\wrapper\dists\apache-maven-3.9.6-bin\3311e1d4\apache-maven-3.9.6 > Java version: 1.8.0_422, vendor: Azul Systems, Inc., runtime: > C:\hostedtoolcache\windows\Java_Zulu_jdk\8.0.422-5\x64\jre > Default locale: en_US, platform encoding: Cp1252 > OS name: "windows server 2022", version: "10.0", arch: "aarch64", family: > "windows" >Reporter: Gili >Priority: Critical > Fix For: 3.2.7 > > > Version 3.2.0 - 3.2.6 fail with "gpg: signing failed: Bad passphrase" on > GitHub Windows Runners. > Using Linux or downgrading to version 3.1.0 seems to work fine. > It's not clear what changed in these newer versions but > [https://github.com/apache/maven-gpg-plugin/blob/3a31714e9cbdde86a6b12f1ef05d5c60252fef4a/src/main/java/org/apache/maven/plugins/gpg/AbstractGpgMojo.java#L368] > looks like a highly supicious way of reading environment variables. It's > possible that this approach does not work properly under Powershell. > If I echo "$env:MAVEN_GPG_PASSPHRASE" on the GitHub Windows runner, I get > back the correct value, so it sounds like there is a bug in the way that this > plugin is choosing to read the environment variable. > What makes this a bit tricky, however, is that the environment variable is > called $MAVEN_GPG_PASSPHRASE on Linux, %MAVEN_GPG_PASSPHRASE% on cmd.exe and > $env:MAVEN_GPG_PASSPHRASE on Powershell. GitHub is using the Powershell > variant. > Can you guys please look into this? -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MJAVADOC-812) [REGRESSION] maven-javadoc-plugin 3.10.0 creates empty JARs
[
https://issues.apache.org/jira/browse/MJAVADOC-812?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17884242#comment-17884242
]
ASF GitHub Bot commented on MJAVADOC-812:
-
michael-o merged PR #320:
URL: https://github.com/apache/maven-javadoc-plugin/pull/320
> [REGRESSION] maven-javadoc-plugin 3.10.0 creates empty JARs
> ---
>
> Key: MJAVADOC-812
> URL: https://issues.apache.org/jira/browse/MJAVADOC-812
> Project: Maven Javadoc Plugin
> Issue Type: Bug
>Affects Versions: 3.10.0
>Reporter: Armin Krezovic
>Assignee: Michael Osipov
>Priority: Major
> Fix For: 3.10.1
>
> Attachments: maven-javadoc-invocation.log
>
>
> After updating to maven-javadoc-plugin 3.10.0, I am getting empty javadoc
> jars created.
> {code:java}
> [INFO] --- jar:3.4.2:jar (default-jar) @ configuration ---
> [INFO] Building jar:
> C:\path\to\configuration\target\configuration-10.1.0-SNAPSHOT-2409192051.4892c3d.jar
> [INFO]
> [INFO] --- javadoc:3.10.0:jar (attach-javadocs) @ configuration ---
> [WARNING] JAR will be empty - no content was marked for inclusion!
> [INFO] Building jar:
> C:\path\to\configuration\target\configuration-10.1.0-SNAPSHOT-2409192051.4892c3d-javadoc.jar
> [INFO]
> [INFO] --- source:3.3.1:jar-no-fork (attach-sources) @ configuration ---
> [INFO] No sources in project. Archive not created.{code}
>
> Prior version, 3.8.0, had no such problem
> {code:java}
> [INFO] --- jar:3.4.2:jar (default-jar) @ configuration ---
> [INFO] Building jar:
> C:\path\to\configuration\target\configuration-10.1.0-SNAPSHOT-2409192102.595f143.jar
> [INFO]
> [INFO] --- javadoc:3.8.0:jar (attach-javadocs) @ configuration ---
> [INFO]
> [INFO] >>> source:3.3.1:jar (attach-sources) > generate-sources @
> configuration >>>{code}
>
> Plugin configuration
> {code:java}
>
> org.apache.maven.plugins
> maven-javadoc-plugin
> 3.10.0
>
>all,-missing
>
>
>
> attach-javadocs
>
> jar
>
>
>
> {code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MJAVADOC-812) [REGRESSION] maven-javadoc-plugin 3.10.0 creates empty JARs
[
https://issues.apache.org/jira/browse/MJAVADOC-812?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17884241#comment-17884241
]
ASF GitHub Bot commented on MJAVADOC-812:
-
michael-o closed pull request #320: [MJAVADOC-812] [REGRESSION]
maven-javadoc-plugin 3.10.0 creates empty…
URL: https://github.com/apache/maven-javadoc-plugin/pull/320
> [REGRESSION] maven-javadoc-plugin 3.10.0 creates empty JARs
> ---
>
> Key: MJAVADOC-812
> URL: https://issues.apache.org/jira/browse/MJAVADOC-812
> Project: Maven Javadoc Plugin
> Issue Type: Bug
>Affects Versions: 3.10.0
>Reporter: Armin Krezovic
>Assignee: Michael Osipov
>Priority: Major
> Fix For: 3.10.1
>
> Attachments: maven-javadoc-invocation.log
>
>
> After updating to maven-javadoc-plugin 3.10.0, I am getting empty javadoc
> jars created.
> {code:java}
> [INFO] --- jar:3.4.2:jar (default-jar) @ configuration ---
> [INFO] Building jar:
> C:\path\to\configuration\target\configuration-10.1.0-SNAPSHOT-2409192051.4892c3d.jar
> [INFO]
> [INFO] --- javadoc:3.10.0:jar (attach-javadocs) @ configuration ---
> [WARNING] JAR will be empty - no content was marked for inclusion!
> [INFO] Building jar:
> C:\path\to\configuration\target\configuration-10.1.0-SNAPSHOT-2409192051.4892c3d-javadoc.jar
> [INFO]
> [INFO] --- source:3.3.1:jar-no-fork (attach-sources) @ configuration ---
> [INFO] No sources in project. Archive not created.{code}
>
> Prior version, 3.8.0, had no such problem
> {code:java}
> [INFO] --- jar:3.4.2:jar (default-jar) @ configuration ---
> [INFO] Building jar:
> C:\path\to\configuration\target\configuration-10.1.0-SNAPSHOT-2409192102.595f143.jar
> [INFO]
> [INFO] --- javadoc:3.8.0:jar (attach-javadocs) @ configuration ---
> [INFO]
> [INFO] >>> source:3.3.1:jar (attach-sources) > generate-sources @
> configuration >>>{code}
>
> Plugin configuration
> {code:java}
>
> org.apache.maven.plugins
> maven-javadoc-plugin
> 3.10.0
>
>all,-missing
>
>
>
> attach-javadocs
>
> jar
>
>
>
> {code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MJAVADOC-811) javadoc.bat fails to execute on Windows when project is not on drive C and AutoRun is configured
[
https://issues.apache.org/jira/browse/MJAVADOC-811?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17884239#comment-17884239
]
ASF GitHub Bot commented on MJAVADOC-811:
-
michael-o closed pull request #321: [MJAVADOC-811] javadoc.bat fails to execute
on Windows when project i…
URL: https://github.com/apache/maven-javadoc-plugin/pull/321
> javadoc.bat fails to execute on Windows when project is not on drive C and
> AutoRun is configured
>
>
> Key: MJAVADOC-811
> URL: https://issues.apache.org/jira/browse/MJAVADOC-811
> Project: Maven Javadoc Plugin
> Issue Type: Bug
> Components: javadoc
>Affects Versions: 3.8.0
> Environment: Windows 10, Java 11, Maven 3.9.9
>Reporter: Sebastian T
>Assignee: Michael Osipov
>Priority: Major
> Fix For: 3.10.1
>
>
> Trying to execute the javadoc plugin in a Maven build on Windows results in
> {noformat}
> [ERROR] Failed to execute goal
> org.apache.maven.plugins:maven-javadoc-plugin:3.8.0:jar (attach-javadocs) on
> project myproject: MavenReportException: Error while generating Javadoc:
> [ERROR] Exit code: 1 - javadoc: error - cannot read options (The system
> cannot find the file specified)
> [ERROR]
> [ERROR] Command line was: cmd.exe /X /C
> "F:\java\temurin_jdk11\bin\javadoc.exe @options @packages"[ERROR]
> [ERROR] Refer to the generated Javadoc files in
> 'F:\projects\myproject\target\apidocs' dir.
> {noformat}
> when the project is not on the system drive and
> {{HKEY_CURRENT_USER\Software\Microsoft\Command Processor\AutoRun}} is
> configured to some directory on drive C. Then cmd.exe will not execute in the
> current directory but in the directory specified via AutoRun. This is the
> case in a corporate environment I am working in.
> The solution is trivial by adding the /D flag to cmd.exe
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MGPG-136) "gpg: signing failed: Bad passphrase" on GitHub Windows runners
[
https://issues.apache.org/jira/browse/MGPG-136?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17884200#comment-17884200
]
ASF GitHub Bot commented on MGPG-136:
-
michael-o commented on code in PR #120:
URL: https://github.com/apache/maven-gpg-plugin/pull/120#discussion_r1773041660
##
src/main/java/org/apache/maven/plugins/gpg/AbstractGpgMojo.java:
##
@@ -270,6 +270,20 @@ public abstract class AbstractGpgMojo extends AbstractMojo
{
@Parameter(property = "gpg.bestPractices", defaultValue = "false")
private boolean bestPractices;
+/**
+ * Whether to append the passphrase with LF character or not, as on some
systems and some GPG executable combinations
+ * lack of this character may cause GPG to not detect passphrase on STDIN.
Since 3.2.0 it was always appended, unless
+ * passphrase itself ended with line separator. This parameter affects
ONLY the GPG signer, not the BC signer.
+ *
+ * By default, this parameter is {@code true} to retain same behaviour as
before.
+ *
+ * @since 3.2.7
+ * @see https://issues.apache.org/jira/browse/MGPG-99";>MGPG-99
+ * @see https://issues.apache.org/jira/browse/MGPG-136";>MGPG-136
+ */
+@Parameter(property = "gpg.passphraseLf", defaultValue = "true")
+private boolean passphraseLf;
Review Comment:
I think this parameter should just be `terminatePassphrase`
##
src/main/java/org/apache/maven/plugins/gpg/AbstractGpgMojo.java:
##
@@ -270,6 +270,20 @@ public abstract class AbstractGpgMojo extends AbstractMojo
{
@Parameter(property = "gpg.bestPractices", defaultValue = "false")
private boolean bestPractices;
+/**
+ * Whether to append the passphrase with LF character or not, as on some
systems and some GPG executable combinations
Review Comment:
Whether to to terminate the passphrase with the LF character or not,
> "gpg: signing failed: Bad passphrase" on GitHub Windows runners
> ---
>
> Key: MGPG-136
> URL: https://issues.apache.org/jira/browse/MGPG-136
> Project: Maven GPG Plugin
> Issue Type: Bug
>Affects Versions: 3.2.0, 3.2.1, 3.2.2, 3.2.3, 3.2.4, 3.2.5
> Environment: Apache Maven 3.9.6
> (bc0240f3c744dd6b6ec2920b3cd08dcc295161ae)
> Maven home:
> C:\Users\runneradmin\.m2\wrapper\dists\apache-maven-3.9.6-bin\3311e1d4\apache-maven-3.9.6
> Java version: 1.8.0_422, vendor: Azul Systems, Inc., runtime:
> C:\hostedtoolcache\windows\Java_Zulu_jdk\8.0.422-5\x64\jre
> Default locale: en_US, platform encoding: Cp1252
> OS name: "windows server 2022", version: "10.0", arch: "aarch64", family:
> "windows"
>Reporter: Gili
>Priority: Critical
> Fix For: 3.2.7
>
>
> Version 3.2.0 - 3.2.5 fail with "gpg: signing failed: Bad passphrase" on
> GitHub Windows Runners.
> Using Linux or downgrading to version 3.1.0 seems to work fine.
> It's not clear what changed in these newer versions but
> [https://github.com/apache/maven-gpg-plugin/blob/3a31714e9cbdde86a6b12f1ef05d5c60252fef4a/src/main/java/org/apache/maven/plugins/gpg/AbstractGpgMojo.java#L368]
> looks like a highly supicious way of reading environment variables. It's
> possible that this approach does not work properly under Powershell.
> If I echo "$env:MAVEN_GPG_PASSPHRASE" on the GitHub Windows runner, I get
> back the correct value, so it sounds like there is a bug in the way that this
> plugin is choosing to read the environment variable.
> What makes this a bit tricky, however, is that the environment variable is
> called $MAVEN_GPG_PASSPHRASE on Linux, %MAVEN_GPG_PASSPHRASE% on cmd.exe and
> $env:MAVEN_GPG_PASSPHRASE on Powershell. GitHub is using the Powershell
> variant.
> Can you guys please look into this?
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MJAVADOC-812) [REGRESSION] maven-javadoc-plugin 3.10.0 creates empty JARs
[
https://issues.apache.org/jira/browse/MJAVADOC-812?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17884160#comment-17884160
]
ASF GitHub Bot commented on MJAVADOC-812:
-
michael-o commented on PR #320:
URL:
https://github.com/apache/maven-javadoc-plugin/pull/320#issuecomment-2370475121
@pzygielo IT added.
> [REGRESSION] maven-javadoc-plugin 3.10.0 creates empty JARs
> ---
>
> Key: MJAVADOC-812
> URL: https://issues.apache.org/jira/browse/MJAVADOC-812
> Project: Maven Javadoc Plugin
> Issue Type: Bug
>Affects Versions: 3.10.0
>Reporter: Armin Krezovic
>Assignee: Michael Osipov
>Priority: Major
> Attachments: maven-javadoc-invocation.log
>
>
> After updating to maven-javadoc-plugin 3.10.0, I am getting empty javadoc
> jars created.
> {code:java}
> [INFO] --- jar:3.4.2:jar (default-jar) @ configuration ---
> [INFO] Building jar:
> C:\path\to\configuration\target\configuration-10.1.0-SNAPSHOT-2409192051.4892c3d.jar
> [INFO]
> [INFO] --- javadoc:3.10.0:jar (attach-javadocs) @ configuration ---
> [WARNING] JAR will be empty - no content was marked for inclusion!
> [INFO] Building jar:
> C:\path\to\configuration\target\configuration-10.1.0-SNAPSHOT-2409192051.4892c3d-javadoc.jar
> [INFO]
> [INFO] --- source:3.3.1:jar-no-fork (attach-sources) @ configuration ---
> [INFO] No sources in project. Archive not created.{code}
>
> Prior version, 3.8.0, had no such problem
> {code:java}
> [INFO] --- jar:3.4.2:jar (default-jar) @ configuration ---
> [INFO] Building jar:
> C:\path\to\configuration\target\configuration-10.1.0-SNAPSHOT-2409192102.595f143.jar
> [INFO]
> [INFO] --- javadoc:3.8.0:jar (attach-javadocs) @ configuration ---
> [INFO]
> [INFO] >>> source:3.3.1:jar (attach-sources) > generate-sources @
> configuration >>>{code}
>
> Plugin configuration
> {code:java}
>
> org.apache.maven.plugins
> maven-javadoc-plugin
> 3.10.0
>
>all,-missing
>
>
>
> attach-javadocs
>
> jar
>
>
>
> {code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (DOXIA-740) Rendering Markdown silently truncates files that skip a heading level
[
https://issues.apache.org/jira/browse/DOXIA-740?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17884155#comment-17884155
]
ASF GitHub Bot commented on DOXIA-740:
--
kwin merged PR #228:
URL: https://github.com/apache/maven-doxia/pull/228
> Rendering Markdown silently truncates files that skip a heading level
> -
>
> Key: DOXIA-740
> URL: https://issues.apache.org/jira/browse/DOXIA-740
> Project: Maven Doxia
> Issue Type: Bug
> Components: Module - Markdown
>Affects Versions: 2.0.0-M9
>Reporter: John Dimeo
>Assignee: Konrad Windszus
>Priority: Major
> Fix For: 2.0.0
>
>
> I am using a fork of the latest Doxia site tools because I am testing my
> performance fix, so it's possible this is related to my fork, but I don't
> _think_ so...
> If your Markdown skips a heading level i.e.
> {noformat}
> # Heading 1
> Text
> ### Heading 3
> Text 2{noformat}
> Then the rendered HTML only contains Heading 1 and Text. This is a major
> regression compared to past versions, so I must be missing something. Thank
> you.
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MJAVADOC-811) javadoc.bat fails to execute on Windows when project is not on drive C and AutoRun is configured
[
https://issues.apache.org/jira/browse/MJAVADOC-811?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17884133#comment-17884133
]
ASF GitHub Bot commented on MJAVADOC-811:
-
michael-o opened a new pull request, #321:
URL: https://github.com/apache/maven-javadoc-plugin/pull/321
…s not on drive C and AutoRun is configured
This closes #321
Following this checklist to help us incorporate your
contribution quickly and easily:
- [ ] Make sure there is a [JIRA
issue](https://issues.apache.org/jira/browse/MJAVADOC) filed
for the change (usually before you start working on it). Trivial
changes like typos do not
require a JIRA issue. Your pull request should address just this
issue, without
pulling in other changes.
- [ ] Each commit in the pull request should have a meaningful subject line
and body.
- [ ] Format the pull request title like `[MJAVADOC-XXX] - Fixes bug in
ApproximateQuantiles`,
where you replace `MJAVADOC-XXX` with the appropriate JIRA issue.
Best practice
is to use the JIRA issue title in the pull request title and in the
first line of the
commit message.
- [ ] Write a pull request description that is detailed enough to
understand what the pull request does, how, and why.
- [ ] Run `mvn clean verify -Prun-its` to make sure basic checks pass. A
more thorough check will
be performed on your pull request automatically.
If your pull request is about ~20 lines of code you don't need to sign an
[Individual Contributor License
Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure
please ask on the developers list.
To make clear that you license your contribution under
the [Apache License Version 2.0, January
2004](http://www.apache.org/licenses/LICENSE-2.0)
you have to acknowledge this by using the following check-box.
- [ ] I hereby declare this contribution to be licensed under the [Apache
License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
- [ ] In any other case, please file an [Apache Individual Contributor
License Agreement](https://www.apache.org/licenses/icla.pdf).
> javadoc.bat fails to execute on Windows when project is not on drive C and
> AutoRun is configured
>
>
> Key: MJAVADOC-811
> URL: https://issues.apache.org/jira/browse/MJAVADOC-811
> Project: Maven Javadoc Plugin
> Issue Type: Bug
> Components: javadoc
>Affects Versions: 3.8.0
> Environment: Windows 10, Java 11, Maven 3.9.9
>Reporter: Sebastian T
>Assignee: Michael Osipov
>Priority: Major
> Fix For: 3.10.1
>
>
> Trying to execute the javadoc plugin in a Maven build on Windows results in
> {noformat}
> [ERROR] Failed to execute goal
> org.apache.maven.plugins:maven-javadoc-plugin:3.8.0:jar (attach-javadocs) on
> project myproject: MavenReportException: Error while generating Javadoc:
> [ERROR] Exit code: 1 - javadoc: error - cannot read options (The system
> cannot find the file specified)
> [ERROR]
> [ERROR] Command line was: cmd.exe /X /C
> "F:\java\temurin_jdk11\bin\javadoc.exe @options @packages"[ERROR]
> [ERROR] Refer to the generated Javadoc files in
> 'F:\projects\myproject\target\apidocs' dir.
> {noformat}
> when the project is not on the system drive and
> {{HKEY_CURRENT_USER\Software\Microsoft\Command Processor\AutoRun}} is
> configured to some directory on drive C. Then cmd.exe will not execute in the
> current directory but in the directory specified via AutoRun. This is the
> case in a corporate environment I am working in.
> The solution is trivial by adding the /D flag to cmd.exe
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MRELEASE-1154) [REGRESSION] MRELEASE-1109 breaks release of Maven Surefire
[
https://issues.apache.org/jira/browse/MRELEASE-1154?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17884089#comment-17884089
]
ASF GitHub Bot commented on MRELEASE-1154:
--
gnodet commented on code in PR #230:
URL: https://github.com/apache/maven-release/pull/230#discussion_r1772487584
##
maven-release-manager/src/main/java/org/apache/maven/shared/release/phase/AbstractRewritePomsPhase.java:
##
@@ -517,128 +517,177 @@ private void rewriteArtifactVersions(
if (elements == null) {
return;
}
-String projectId =
ArtifactUtils.versionlessKey(projectModel.getGroupId(),
projectModel.getArtifactId());
for (MavenCoordinate coordinate : elements) {
-String rawVersion = coordinate.getVersion();
-if (rawVersion == null) {
-// managed dependency or unversioned plugin
-continue;
-}
+rewriteArtifactVersion(coordinate, projectModel, properties,
result, releaseDescriptor, simulate);
+}
+}
-String rawGroupId = coordinate.getGroupId();
-if (rawGroupId == null) {
-if ("plugin".equals(coordinate.getName())) {
-rawGroupId = "org.apache.maven.plugins";
-} else {
-// incomplete dependency
-continue;
-}
-}
-String groupId = ReleaseUtil.interpolate(rawGroupId, projectModel);
+private void rewriteArtifactVersion(
+MavenCoordinate artifact,
+Model projectModel,
+Properties properties,
+ReleaseResult result,
+ReleaseDescriptor releaseDescriptor,
+boolean simulate)
+throws ReleaseExecutionException, ReleaseFailureException {
+String projectId =
ArtifactUtils.versionlessKey(projectModel.getGroupId(),
projectModel.getArtifactId());
+String rawVersion = artifact.getVersion();
+if (rawVersion == null) {
+// managed dependency or unversioned plugin
+return;
+}
-String rawArtifactId = coordinate.getArtifactId();
-if (rawArtifactId == null) {
-// incomplete element
-continue;
-}
-String artifactId = ReleaseUtil.interpolate(rawArtifactId,
projectModel);
-
-String key = ArtifactUtils.versionlessKey(groupId, artifactId);
-String resolvedSnapshotVersion = getResolvedSnapshotVersion(key,
releaseDescriptor);
-String mappedVersion = getNextVersion(releaseDescriptor, key);
-String originalVersion = getOriginalVersion(releaseDescriptor,
key, simulate);
-if (originalVersion == null) {
-originalVersion = getOriginalResolvedSnapshotVersion(key,
releaseDescriptor);
+String rawGroupId = artifact.getGroupId();
+if (rawGroupId == null) {
+if ("plugin".equals(artifact.getName())) {
+rawGroupId = "org.apache.maven.plugins";
+} else {
+// incomplete dependency
+return;
}
+}
+String groupId = ReleaseUtil.interpolate(rawGroupId, projectModel);
-// MRELEASE-220
-if (mappedVersion != null
-&& mappedVersion.endsWith(Artifact.SNAPSHOT_VERSION)
-&& !rawVersion.endsWith(Artifact.SNAPSHOT_VERSION)
-&& !releaseDescriptor.isUpdateDependencies()) {
-continue;
-}
+String rawArtifactId = artifact.getArtifactId();
+if (rawArtifactId == null) {
+// incomplete element
+return;
+}
+String artifactId = ReleaseUtil.interpolate(rawArtifactId,
projectModel);
+
+String key = ArtifactUtils.versionlessKey(groupId, artifactId);
+String resolvedSnapshotVersion = getResolvedSnapshotVersion(key,
releaseDescriptor);
+String mappedVersion = getNextVersion(releaseDescriptor, key);
+String originalVersion = getOriginalVersion(releaseDescriptor, key,
simulate);
+if (originalVersion == null) {
+originalVersion = getOriginalResolvedSnapshotVersion(key,
releaseDescriptor);
+}
-if (mappedVersion != null) {
-if (rawVersion.equals(originalVersion)) {
-logInfo(result, " Updating " + artifactId + " to " +
mappedVersion);
-coordinate.setVersion(mappedVersion);
-} else {
-String property =
extractPropertyFromExpression(rawVersion);
-if (property != null) {
-if (property.startsWith("project.")
-|| property.startsWith("pom.")
-|| "version".equ
[jira] [Commented] (MPLUGINTESTING-95) Upgrade parent POM to version 43
[ https://issues.apache.org/jira/browse/MPLUGINTESTING-95?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17884055#comment-17884055 ] ASF GitHub Bot commented on MPLUGINTESTING-95: -- slachiewicz opened a new pull request, #45: URL: https://github.com/apache/maven-plugin-testing/pull/45 Cleanup deprecated code. Update to Maven 3.9.9 > Upgrade parent POM to version 43 > > > Key: MPLUGINTESTING-95 > URL: https://issues.apache.org/jira/browse/MPLUGINTESTING-95 > Project: Maven Plugin Testing > Issue Type: Dependency upgrade >Reporter: Sylwester Lachiewicz >Priority: Minor > Fix For: 3.4.0 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MPLUGINTESTING-95) Upgrade parent POM to version 43
[ https://issues.apache.org/jira/browse/MPLUGINTESTING-95?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17884056#comment-17884056 ] ASF GitHub Bot commented on MPLUGINTESTING-95: -- slachiewicz merged PR #45: URL: https://github.com/apache/maven-plugin-testing/pull/45 > Upgrade parent POM to version 43 > > > Key: MPLUGINTESTING-95 > URL: https://issues.apache.org/jira/browse/MPLUGINTESTING-95 > Project: Maven Plugin Testing > Issue Type: Dependency upgrade >Reporter: Sylwester Lachiewicz >Priority: Minor > Fix For: 3.4.0 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (DOXIASITETOOLS-348) Extend site descriptor to enforce a parent
[
https://issues.apache.org/jira/browse/DOXIASITETOOLS-348?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17884043#comment-17884043
]
ASF GitHub Bot commented on DOXIASITETOOLS-348:
---
michael-o commented on code in PR #173:
URL:
https://github.com/apache/maven-doxia-sitetools/pull/173#discussion_r1772034411
##
doxia-site-model/pom.xml:
##
@@ -84,7 +84,7 @@ under the License.
src/main/mdo/site.mdo
Extend site descriptor to enforce a parent
> --
>
> Key: DOXIASITETOOLS-348
> URL: https://issues.apache.org/jira/browse/DOXIASITETOOLS-348
> Project: Maven Doxia Sitetools
> Issue Type: Improvement
> Components: Site model
>Affects Versions: 2.0.0-M19
>Reporter: Konrad Windszus
>Assignee: Konrad Windszus
>Priority: Major
>
> Currently the [site
> descriptor|https://maven.apache.org/doxia/doxia-sitetools/doxia-site-model/site.html]
> does not allow to enforce a parent {{site.xml}}.
> The attribute {{combine.self}} does not lead to a failure in case no parent
> {{site.xml}} can be found.
> This may easily lead to broken sites without breaking the site build as
> a) the site transparently inherits the {{site.xml}} attached to the parent
> POM.
> b) attaching the {{site.xml}} to a project is a manual step
> (https://maven.apache.org/plugins/maven-site-plugin/attach-descriptor-mojo.html)
> As at the time when the descriptor of the derived {{site.xml}} is created it
> is known whether the descriptor works standalone or requires a parent
> {{site.xml}}, therefore this should be made explicit in the site descriptor.
> I propose to add an additional attribute {{requireParent}} on the top level
> element which is {{false}} by default (current behaviour). If set to {{true}}
> it should lead to a build failure in case the parent {{site.xml}} cannot be
> resolved (for whatever reason).
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (DOXIASITETOOLS-348) Extend site descriptor to enforce a parent
[
https://issues.apache.org/jira/browse/DOXIASITETOOLS-348?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17884044#comment-17884044
]
ASF GitHub Bot commented on DOXIASITETOOLS-348:
---
michael-o commented on code in PR #173:
URL:
https://github.com/apache/maven-doxia-sitetools/pull/173#discussion_r1772034411
##
doxia-site-model/pom.xml:
##
@@ -84,7 +84,7 @@ under the License.
src/main/mdo/site.mdo
Extend site descriptor to enforce a parent
> --
>
> Key: DOXIASITETOOLS-348
> URL: https://issues.apache.org/jira/browse/DOXIASITETOOLS-348
> Project: Maven Doxia Sitetools
> Issue Type: Improvement
> Components: Site model
>Affects Versions: 2.0.0-M19
>Reporter: Konrad Windszus
>Assignee: Konrad Windszus
>Priority: Major
>
> Currently the [site
> descriptor|https://maven.apache.org/doxia/doxia-sitetools/doxia-site-model/site.html]
> does not allow to enforce a parent {{site.xml}}.
> The attribute {{combine.self}} does not lead to a failure in case no parent
> {{site.xml}} can be found.
> This may easily lead to broken sites without breaking the site build as
> a) the site transparently inherits the {{site.xml}} attached to the parent
> POM.
> b) attaching the {{site.xml}} to a project is a manual step
> (https://maven.apache.org/plugins/maven-site-plugin/attach-descriptor-mojo.html)
> As at the time when the descriptor of the derived {{site.xml}} is created it
> is known whether the descriptor works standalone or requires a parent
> {{site.xml}}, therefore this should be made explicit in the site descriptor.
> I propose to add an additional attribute {{requireParent}} on the top level
> element which is {{false}} by default (current behaviour). If set to {{true}}
> it should lead to a build failure in case the parent {{site.xml}} cannot be
> resolved (for whatever reason).
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (DOXIASITETOOLS-348) Extend site descriptor to enforce a parent
[
https://issues.apache.org/jira/browse/DOXIASITETOOLS-348?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17884042#comment-17884042
]
ASF GitHub Bot commented on DOXIASITETOOLS-348:
---
michael-o commented on code in PR #173:
URL:
https://github.com/apache/maven-doxia-sitetools/pull/173#discussion_r1771964660
##
doxia-site-model/src/main/mdo/site.mdo:
##
@@ -66,6 +66,15 @@ under the License.
String
merge
+
+
+ enforceParentDescriptor
Review Comment:
Instead of `enforce` I'd use the term `requre`. E.g., `requireParentSite`.
The term `descriptor` is too confusing and too abstract for most.
##
doxia-integration-tools/src/test/java/org/apache/maven/doxia/tools/SiteToolTest.java:
##
@@ -70,46 +66,16 @@
@PlexusTest
public class SiteToolTest {
-@Inject
-private PlexusContainer container;
-
-@Inject
-private ArtifactRepositoryFactory artifactRepositoryFactory;
-
-@Inject
-@Named("default")
-private ArtifactRepositoryLayout defaultArtifactRepositoryLayout;
-
@Inject
private DefaultSiteTool tool;
-/**
- * @return the repo.
- *
- * @throws Exception
- */
-protected ArtifactRepository getLocalRepo() throws Exception {
-String updatePolicyFlag =
ArtifactRepositoryPolicy.UPDATE_POLICY_ALWAYS;
-String checksumPolicyFlag =
ArtifactRepositoryPolicy.CHECKSUM_POLICY_WARN;
-ArtifactRepositoryPolicy snapshotsPolicy =
-new ArtifactRepositoryPolicy(true, updatePolicyFlag,
checksumPolicyFlag);
-ArtifactRepositoryPolicy releasesPolicy =
-new ArtifactRepositoryPolicy(true, updatePolicyFlag,
checksumPolicyFlag);
-return artifactRepositoryFactory.createArtifactRepository(
-"local",
-getTestFile("target/local-repo").toURI().toURL().toString(),
-defaultArtifactRepositoryLayout,
-snapshotsPolicy,
-releasesPolicy);
-}
-
Review Comment:
Accepted.
> Extend site descriptor to enforce a parent
> --
>
> Key: DOXIASITETOOLS-348
> URL: https://issues.apache.org/jira/browse/DOXIASITETOOLS-348
> Project: Maven Doxia Sitetools
> Issue Type: Improvement
> Components: Site model
>Affects Versions: 2.0.0-M19
>Reporter: Konrad Windszus
>Assignee: Konrad Windszus
>Priority: Major
>
> Currently the [site
> descriptor|https://maven.apache.org/doxia/doxia-sitetools/doxia-site-model/site.html]
> does not allow to enforce a parent {{site.xml}}.
> The attribute {{combine.self}} does not lead to a failure in case no parent
> {{site.xml}} can be found.
> This may easily lead to broken sites without breaking the site build as
> a) the site transparently inherits the {{site.xml}} attached to the parent
> POM.
> b) attaching the {{site.xml}} to a project is a manual step
> (https://maven.apache.org/plugins/maven-site-plugin/attach-descriptor-mojo.html)
> As at the time when the descriptor of the derived {{site.xml}} is created it
> is known whether the descriptor works standalone or requires a parent
> {{site.xml}}, therefore this should be made explicit in the site descriptor.
> I propose to add an additional attribute {{requireParent}} on the top level
> element which is {{false}} by default (current behaviour). If set to {{true}}
> it should lead to a build failure in case the parent {{site.xml}} cannot be
> resolved (for whatever reason).
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (DOXIASITETOOLS-348) Extend site descriptor to enforce a parent
[
https://issues.apache.org/jira/browse/DOXIASITETOOLS-348?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17884041#comment-17884041
]
ASF GitHub Bot commented on DOXIASITETOOLS-348:
---
michael-o commented on code in PR #173:
URL:
https://github.com/apache/maven-doxia-sitetools/pull/173#discussion_r1771964660
##
doxia-site-model/src/main/mdo/site.mdo:
##
@@ -66,6 +66,15 @@ under the License.
String
merge
+
+
+ enforceParentDescriptor
Review Comment:
Instead of `enforce` I'd use the term 'requre'. E.g., `requireParentSite`.
The term `descriptor` is too confusing and too abstract for most.
> Extend site descriptor to enforce a parent
> --
>
> Key: DOXIASITETOOLS-348
> URL: https://issues.apache.org/jira/browse/DOXIASITETOOLS-348
> Project: Maven Doxia Sitetools
> Issue Type: Improvement
> Components: Site model
>Affects Versions: 2.0.0-M19
>Reporter: Konrad Windszus
>Assignee: Konrad Windszus
>Priority: Major
>
> Currently the [site
> descriptor|https://maven.apache.org/doxia/doxia-sitetools/doxia-site-model/site.html]
> does not allow to enforce a parent {{site.xml}}.
> The attribute {{combine.self}} does not lead to a failure in case no parent
> {{site.xml}} can be found.
> This may easily lead to broken sites without breaking the site build as
> a) the site transparently inherits the {{site.xml}} attached to the parent
> POM.
> b) attaching the {{site.xml}} to a project is a manual step
> (https://maven.apache.org/plugins/maven-site-plugin/attach-descriptor-mojo.html)
> As at the time when the descriptor of the derived {{site.xml}} is created it
> is known whether the descriptor works standalone or requires a parent
> {{site.xml}}, therefore this should be made explicit in the site descriptor.
> I propose to add an additional attribute {{requireParent}} on the top level
> element which is {{false}} by default (current behaviour). If set to {{true}}
> it should lead to a build failure in case the parent {{site.xml}} cannot be
> resolved (for whatever reason).
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (DOXIASITETOOLS-348) Extend site descriptor to enforce a parent
[
https://issues.apache.org/jira/browse/DOXIASITETOOLS-348?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17884040#comment-17884040
]
ASF GitHub Bot commented on DOXIASITETOOLS-348:
---
kwin commented on code in PR #173:
URL:
https://github.com/apache/maven-doxia-sitetools/pull/173#discussion_r1772031993
##
doxia-site-model/pom.xml:
##
@@ -84,7 +84,7 @@ under the License.
src/main/mdo/site.mdo
Extend site descriptor to enforce a parent
> --
>
> Key: DOXIASITETOOLS-348
> URL: https://issues.apache.org/jira/browse/DOXIASITETOOLS-348
> Project: Maven Doxia Sitetools
> Issue Type: Improvement
> Components: Site model
>Affects Versions: 2.0.0-M19
>Reporter: Konrad Windszus
>Assignee: Konrad Windszus
>Priority: Major
>
> Currently the [site
> descriptor|https://maven.apache.org/doxia/doxia-sitetools/doxia-site-model/site.html]
> does not allow to enforce a parent {{site.xml}}.
> The attribute {{combine.self}} does not lead to a failure in case no parent
> {{site.xml}} can be found.
> This may easily lead to broken sites without breaking the site build as
> a) the site transparently inherits the {{site.xml}} attached to the parent
> POM.
> b) attaching the {{site.xml}} to a project is a manual step
> (https://maven.apache.org/plugins/maven-site-plugin/attach-descriptor-mojo.html)
> As at the time when the descriptor of the derived {{site.xml}} is created it
> is known whether the descriptor works standalone or requires a parent
> {{site.xml}}, therefore this should be made explicit in the site descriptor.
> I propose to add an additional attribute {{requireParent}} on the top level
> element which is {{false}} by default (current behaviour). If set to {{true}}
> it should lead to a build failure in case the parent {{site.xml}} cannot be
> resolved (for whatever reason).
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (DOXIASITETOOLS-348) Extend site descriptor to enforce a parent
[
https://issues.apache.org/jira/browse/DOXIASITETOOLS-348?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17884038#comment-17884038
]
ASF GitHub Bot commented on DOXIASITETOOLS-348:
---
kwin commented on code in PR #173:
URL:
https://github.com/apache/maven-doxia-sitetools/pull/173#discussion_r1772030115
##
doxia-integration-tools/src/test/java/org/apache/maven/doxia/tools/SiteToolTest.java:
##
@@ -70,46 +66,16 @@
@PlexusTest
public class SiteToolTest {
-@Inject
-private PlexusContainer container;
-
-@Inject
-private ArtifactRepositoryFactory artifactRepositoryFactory;
-
-@Inject
-@Named("default")
-private ArtifactRepositoryLayout defaultArtifactRepositoryLayout;
-
@Inject
private DefaultSiteTool tool;
-/**
- * @return the repo.
- *
- * @throws Exception
- */
-protected ArtifactRepository getLocalRepo() throws Exception {
-String updatePolicyFlag =
ArtifactRepositoryPolicy.UPDATE_POLICY_ALWAYS;
-String checksumPolicyFlag =
ArtifactRepositoryPolicy.CHECKSUM_POLICY_WARN;
-ArtifactRepositoryPolicy snapshotsPolicy =
-new ArtifactRepositoryPolicy(true, updatePolicyFlag,
checksumPolicyFlag);
-ArtifactRepositoryPolicy releasesPolicy =
-new ArtifactRepositoryPolicy(true, updatePolicyFlag,
checksumPolicyFlag);
-return artifactRepositoryFactory.createArtifactRepository(
-"local",
-getTestFile("target/local-repo").toURI().toURL().toString(),
-defaultArtifactRepositoryLayout,
-snapshotsPolicy,
-releasesPolicy);
-}
-
Review Comment:
Because it was unused in the test.
> Extend site descriptor to enforce a parent
> --
>
> Key: DOXIASITETOOLS-348
> URL: https://issues.apache.org/jira/browse/DOXIASITETOOLS-348
> Project: Maven Doxia Sitetools
> Issue Type: Improvement
> Components: Site model
>Affects Versions: 2.0.0-M19
>Reporter: Konrad Windszus
>Assignee: Konrad Windszus
>Priority: Major
>
> Currently the [site
> descriptor|https://maven.apache.org/doxia/doxia-sitetools/doxia-site-model/site.html]
> does not allow to enforce a parent {{site.xml}}.
> The attribute {{combine.self}} does not lead to a failure in case no parent
> {{site.xml}} can be found.
> This may easily lead to broken sites without breaking the site build as
> a) the site transparently inherits the {{site.xml}} attached to the parent
> POM.
> b) attaching the {{site.xml}} to a project is a manual step
> (https://maven.apache.org/plugins/maven-site-plugin/attach-descriptor-mojo.html)
> As at the time when the descriptor of the derived {{site.xml}} is created it
> is known whether the descriptor works standalone or requires a parent
> {{site.xml}}, therefore this should be made explicit in the site descriptor.
> I propose to add an additional attribute {{requireParent}} on the top level
> element which is {{false}} by default (current behaviour). If set to {{true}}
> it should lead to a build failure in case the parent {{site.xml}} cannot be
> resolved (for whatever reason).
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (DOXIA-740) Rendering Markdown silently truncates files that skip a heading level
[
https://issues.apache.org/jira/browse/DOXIA-740?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17884037#comment-17884037
]
ASF GitHub Bot commented on DOXIA-740:
--
kwin commented on code in PR #228:
URL: https://github.com/apache/maven-doxia/pull/228#discussion_r1772028770
##
doxia-core/src/main/java/org/apache/maven/doxia/index/IndexingSink.java:
##
@@ -150,14 +158,20 @@ public void text(String text, SinkEventAttributes
attributes) {
case SECTION_3:
case SECTION_4:
case SECTION_5:
+case SECTION_6:
//
---
// Sanitize the id. The most important step is to remove
any blanks
//
---
// append text to current entry
IndexEntry entry = stack.lastElement();
-String title = entry.getTitle() + text;
+String title;
Review Comment:
Done in
https://github.com/apache/maven-doxia/pull/228/commits/bd1e61ea7705af4a6a6f19ad28355a5c6807c343.
> Rendering Markdown silently truncates files that skip a heading level
> -
>
> Key: DOXIA-740
> URL: https://issues.apache.org/jira/browse/DOXIA-740
> Project: Maven Doxia
> Issue Type: Bug
> Components: Module - Markdown
>Affects Versions: 2.0.0-M9
>Reporter: John Dimeo
>Assignee: Konrad Windszus
>Priority: Major
> Fix For: 2.0.0
>
>
> I am using a fork of the latest Doxia site tools because I am testing my
> performance fix, so it's possible this is related to my fork, but I don't
> _think_ so...
> If your Markdown skips a heading level i.e.
> {noformat}
> # Heading 1
> Text
> ### Heading 3
> Text 2{noformat}
> Then the rendered HTML only contains Heading 1 and Text. This is a major
> regression compared to past versions, so I must be missing something. Thank
> you.
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MRESOURCES-299) Inaccuracy on docu page for Apache Maven Resources Plugin / Filtering
[
https://issues.apache.org/jira/browse/MRESOURCES-299?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17884029#comment-17884029
]
ASF GitHub Bot commented on MRESOURCES-299:
---
pzygielo opened a new pull request, #81:
URL: https://github.com/apache/maven-resources-plugin/pull/81
- like #80 but for master
> Inaccuracy on docu page for Apache Maven Resources Plugin / Filtering
> -
>
> Key: MRESOURCES-299
> URL: https://issues.apache.org/jira/browse/MRESOURCES-299
> Project: Maven Resources Plugin
> Issue Type: Improvement
> Components: filtering
>Affects Versions: 3.3.1
>Reporter: Gerold Broser
>Priority: Minor
>
> {-}NB: _3.1.2_ is the max. _Affects Version/s_ that can be selected above,
> but the current docu page is for _3.3.1_ (though the following most probably
> applies since...ever){-}[does not apply here at the now right plugin; see
> comments]
> On the docu page
> [https://maven.apache.org/plugins/maven-resources-plugin/examples/filter.html]
> there's:
> {quote}However, if we add a {{}} tag to our POM and set it to
> {{true}} like this:
> {quote}
> While just {{}} really is a {_}tag{_}, we have to add a
> {{filtering}} {_}element{_}, consisting of a _start tag_ *and* an _end tag_
> (and some content in between, but that's not the point here anyway).
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (DOXIA-740) Rendering Markdown silently truncates files that skip a heading level
[
https://issues.apache.org/jira/browse/DOXIA-740?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17884025#comment-17884025
]
ASF GitHub Bot commented on DOXIA-740:
--
michael-o commented on code in PR #228:
URL: https://github.com/apache/maven-doxia/pull/228#discussion_r1772001187
##
doxia-core/src/main/java/org/apache/maven/doxia/index/IndexingSink.java:
##
@@ -150,14 +158,20 @@ public void text(String text, SinkEventAttributes
attributes) {
case SECTION_3:
case SECTION_4:
case SECTION_5:
+case SECTION_6:
//
---
// Sanitize the id. The most important step is to remove
any blanks
//
---
// append text to current entry
IndexEntry entry = stack.lastElement();
-String title = entry.getTitle() + text;
+String title;
Review Comment:
I mean for the if else clause:
```
String title = entry.getTitle();
if (title != null) {
title += text;
} else {
title = text;
}
```
> Rendering Markdown silently truncates files that skip a heading level
> -
>
> Key: DOXIA-740
> URL: https://issues.apache.org/jira/browse/DOXIA-740
> Project: Maven Doxia
> Issue Type: Bug
> Components: Module - Markdown
>Affects Versions: 2.0.0-M9
>Reporter: John Dimeo
>Assignee: Konrad Windszus
>Priority: Major
> Fix For: 2.0.0
>
>
> I am using a fork of the latest Doxia site tools because I am testing my
> performance fix, so it's possible this is related to my fork, but I don't
> _think_ so...
> If your Markdown skips a heading level i.e.
> {noformat}
> # Heading 1
> Text
> ### Heading 3
> Text 2{noformat}
> Then the rendered HTML only contains Heading 1 and Text. This is a major
> regression compared to past versions, so I must be missing something. Thank
> you.
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (DOXIA-740) Rendering Markdown silently truncates files that skip a heading level
[
https://issues.apache.org/jira/browse/DOXIA-740?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17884024#comment-17884024
]
ASF GitHub Bot commented on DOXIA-740:
--
kwin commented on code in PR #228:
URL: https://github.com/apache/maven-doxia/pull/228#discussion_r1771991131
##
doxia-core/src/main/java/org/apache/maven/doxia/index/IndexingSink.java:
##
@@ -150,14 +158,20 @@ public void text(String text, SinkEventAttributes
attributes) {
case SECTION_3:
case SECTION_4:
case SECTION_5:
+case SECTION_6:
//
---
// Sanitize the id. The most important step is to remove
any blanks
//
---
// append text to current entry
IndexEntry entry = stack.lastElement();
-String title = entry.getTitle() + text;
+String title;
Review Comment:
Because entry.getTitle() might return null
> Rendering Markdown silently truncates files that skip a heading level
> -
>
> Key: DOXIA-740
> URL: https://issues.apache.org/jira/browse/DOXIA-740
> Project: Maven Doxia
> Issue Type: Bug
> Components: Module - Markdown
>Affects Versions: 2.0.0-M9
>Reporter: John Dimeo
>Assignee: Konrad Windszus
>Priority: Major
> Fix For: 2.0.0
>
>
> I am using a fork of the latest Doxia site tools because I am testing my
> performance fix, so it's possible this is related to my fork, but I don't
> _think_ so...
> If your Markdown skips a heading level i.e.
> {noformat}
> # Heading 1
> Text
> ### Heading 3
> Text 2{noformat}
> Then the rendered HTML only contains Heading 1 and Text. This is a major
> regression compared to past versions, so I must be missing something. Thank
> you.
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (DOXIA-740) Rendering Markdown silently truncates files that skip a heading level
[
https://issues.apache.org/jira/browse/DOXIA-740?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17884015#comment-17884015
]
ASF GitHub Bot commented on DOXIA-740:
--
michael-o commented on code in PR #228:
URL: https://github.com/apache/maven-doxia/pull/228#discussion_r1771968627
##
doxia-core/src/main/java/org/apache/maven/doxia/index/IndexingSink.java:
##
@@ -150,14 +158,20 @@ public void text(String text, SinkEventAttributes
attributes) {
case SECTION_3:
case SECTION_4:
case SECTION_5:
+case SECTION_6:
//
---
// Sanitize the id. The most important step is to remove
any blanks
//
---
// append text to current entry
IndexEntry entry = stack.lastElement();
-String title = entry.getTitle() + text;
+String title;
Review Comment:
Why not `title = entry.getTitle()` and then `title += text`/`title = text`?
> Rendering Markdown silently truncates files that skip a heading level
> -
>
> Key: DOXIA-740
> URL: https://issues.apache.org/jira/browse/DOXIA-740
> Project: Maven Doxia
> Issue Type: Bug
> Components: Module - Markdown
>Affects Versions: 2.0.0-M9
>Reporter: John Dimeo
>Assignee: Konrad Windszus
>Priority: Major
> Fix For: 2.0.0
>
>
> I am using a fork of the latest Doxia site tools because I am testing my
> performance fix, so it's possible this is related to my fork, but I don't
> _think_ so...
> If your Markdown skips a heading level i.e.
> {noformat}
> # Heading 1
> Text
> ### Heading 3
> Text 2{noformat}
> Then the rendered HTML only contains Heading 1 and Text. This is a major
> regression compared to past versions, so I must be missing something. Thank
> you.
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (DOXIASITETOOLS-348) Extend site descriptor to enforce a parent
[
https://issues.apache.org/jira/browse/DOXIASITETOOLS-348?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17884013#comment-17884013
]
ASF GitHub Bot commented on DOXIASITETOOLS-348:
---
michael-o commented on code in PR #173:
URL:
https://github.com/apache/maven-doxia-sitetools/pull/173#discussion_r1771965492
##
doxia-integration-tools/src/test/java/org/apache/maven/doxia/tools/SiteToolTest.java:
##
@@ -70,46 +66,16 @@
@PlexusTest
public class SiteToolTest {
-@Inject
-private PlexusContainer container;
-
-@Inject
-private ArtifactRepositoryFactory artifactRepositoryFactory;
-
-@Inject
-@Named("default")
-private ArtifactRepositoryLayout defaultArtifactRepositoryLayout;
-
@Inject
private DefaultSiteTool tool;
-/**
- * @return the repo.
- *
- * @throws Exception
- */
-protected ArtifactRepository getLocalRepo() throws Exception {
-String updatePolicyFlag =
ArtifactRepositoryPolicy.UPDATE_POLICY_ALWAYS;
-String checksumPolicyFlag =
ArtifactRepositoryPolicy.CHECKSUM_POLICY_WARN;
-ArtifactRepositoryPolicy snapshotsPolicy =
-new ArtifactRepositoryPolicy(true, updatePolicyFlag,
checksumPolicyFlag);
-ArtifactRepositoryPolicy releasesPolicy =
-new ArtifactRepositoryPolicy(true, updatePolicyFlag,
checksumPolicyFlag);
-return artifactRepositoryFactory.createArtifactRepository(
-"local",
-getTestFile("target/local-repo").toURI().toURL().toString(),
-defaultArtifactRepositoryLayout,
-snapshotsPolicy,
-releasesPolicy);
-}
-
Review Comment:
Why is this block gone?
##
doxia-site-model/src/main/mdo/site.mdo:
##
@@ -66,6 +66,15 @@ under the License.
String
merge
+
+
+ enforceParentDescriptor
Review Comment:
Instead of `enforce` I'd use the term 'requre`. E.g., `requireParentSite`.
The term `descriptor` is too confusing and too abstract for most.
> Extend site descriptor to enforce a parent
> --
>
> Key: DOXIASITETOOLS-348
> URL: https://issues.apache.org/jira/browse/DOXIASITETOOLS-348
> Project: Maven Doxia Sitetools
> Issue Type: Improvement
> Components: Site model
>Affects Versions: 2.0.0-M19
>Reporter: Konrad Windszus
>Assignee: Konrad Windszus
>Priority: Major
>
> Currently the [site
> descriptor|https://maven.apache.org/doxia/doxia-sitetools/doxia-site-model/site.html]
> does not allow to enforce a parent {{site.xml}}.
> The attribute {{combine.self}} does not lead to a failure in case no parent
> {{site.xml}} can be found.
> This may easily lead to broken sites without breaking the site build as
> a) the site transparently inherits the {{site.xml}} attached to the parent
> POM.
> b) attaching the {{site.xml}} to a project is a manual step
> (https://maven.apache.org/plugins/maven-site-plugin/attach-descriptor-mojo.html)
> As at the time when the descriptor of the derived {{site.xml}} is created it
> is known whether the descriptor works standalone or requires a parent
> {{site.xml}}, therefore this should be made explicit in the site descriptor.
> I propose to add an additional attribute {{requireParent}} on the top level
> element which is {{false}} by default (current behaviour). If set to {{true}}
> it should lead to a build failure in case the parent {{site.xml}} cannot be
> resolved (for whatever reason).
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MGPG-136) "gpg: signing failed: Bad passphrase" on GitHub Windows runners
[ https://issues.apache.org/jira/browse/MGPG-136?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17883881#comment-17883881 ] ASF GitHub Bot commented on MGPG-136: - cstamas opened a new pull request, #120: URL: https://github.com/apache/maven-gpg-plugin/pull/120 This is shot in a dark, but should make possible to at least eliminate (if not even figure out) the issue on Windows with passphrase. --- https://issues.apache.org/jira/browse/MGPG-136 > "gpg: signing failed: Bad passphrase" on GitHub Windows runners > --- > > Key: MGPG-136 > URL: https://issues.apache.org/jira/browse/MGPG-136 > Project: Maven GPG Plugin > Issue Type: Bug >Affects Versions: 3.2.0, 3.2.1, 3.2.2, 3.2.3, 3.2.4, 3.2.5 > Environment: Apache Maven 3.9.6 > (bc0240f3c744dd6b6ec2920b3cd08dcc295161ae) > Maven home: > C:\Users\runneradmin\.m2\wrapper\dists\apache-maven-3.9.6-bin\3311e1d4\apache-maven-3.9.6 > Java version: 1.8.0_422, vendor: Azul Systems, Inc., runtime: > C:\hostedtoolcache\windows\Java_Zulu_jdk\8.0.422-5\x64\jre > Default locale: en_US, platform encoding: Cp1252 > OS name: "windows server 2022", version: "10.0", arch: "aarch64", family: > "windows" >Reporter: Gili >Priority: Critical > > Version 3.2.0 - 3.2.5 fail with "gpg: signing failed: Bad passphrase" on > GitHub Windows Runners. > Using Linux or downgrading to version 3.1.0 seems to work fine. > It's not clear what changed in these newer versions but > [https://github.com/apache/maven-gpg-plugin/blob/3a31714e9cbdde86a6b12f1ef05d5c60252fef4a/src/main/java/org/apache/maven/plugins/gpg/AbstractGpgMojo.java#L368] > looks like a highly supicious way of reading environment variables. It's > possible that this approach does not work properly under Powershell. > If I echo "$env:MAVEN_GPG_PASSPHRASE" on the GitHub Windows runner, I get > back the correct value, so it sounds like there is a bug in the way that this > plugin is choosing to read the environment variable. > What makes this a bit tricky, however, is that the environment variable is > called $MAVEN_GPG_PASSPHRASE on Linux, %MAVEN_GPG_PASSPHRASE% on cmd.exe and > $env:MAVEN_GPG_PASSPHRASE on Powershell. GitHub is using the Powershell > variant. > Can you guys please look into this? -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (SUREFIRE-2267) Packages for commons-codec should be relocated in surefire-shared-utils
[ https://issues.apache.org/jira/browse/SUREFIRE-2267?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17883705#comment-17883705 ] ASF GitHub Bot commented on SUREFIRE-2267: -- slawekjaranowski merged PR #782: URL: https://github.com/apache/maven-surefire/pull/782 > Packages for commons-codec should be relocated in surefire-shared-utils > --- > > Key: SUREFIRE-2267 > URL: https://issues.apache.org/jira/browse/SUREFIRE-2267 > Project: Maven Surefire > Issue Type: Bug > Components: surefire-shared-utils >Reporter: Slawomir Jaranowski >Assignee: Slawomir Jaranowski >Priority: Major > Fix For: 3.5.1 > > > We have transitive dependency to commons-codec so we should also relocation > package for it. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MRESOURCES-299) Inaccuracy on docu page for Apache Maven Resources Plugin / Filtering
[
https://issues.apache.org/jira/browse/MRESOURCES-299?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17883632#comment-17883632
]
ASF GitHub Bot commented on MRESOURCES-299:
---
pzygielo opened a new pull request, #80:
URL: https://github.com/apache/maven-resources-plugin/pull/80
It targets 3.x, as the [published
site](https://maven.apache.org/plugins/maven-resources-plugin) is for 3.3.1
(and not 4.0.0-beta-1 from master).
> Inaccuracy on docu page for Apache Maven Resources Plugin / Filtering
> -
>
> Key: MRESOURCES-299
> URL: https://issues.apache.org/jira/browse/MRESOURCES-299
> Project: Maven Resources Plugin
> Issue Type: Improvement
> Components: filtering
>Affects Versions: 3.3.1
>Reporter: Gerold Broser
>Priority: Minor
>
> {-}NB: _3.1.2_ is the max. _Affects Version/s_ that can be selected above,
> but the current docu page is for _3.3.1_ (though the following most probably
> applies since...ever){-}[does not apply here at the now right plugin; see
> comments]
> On the docu page
> [https://maven.apache.org/plugins/maven-resources-plugin/examples/filter.html]
> there's:
> {quote}However, if we add a {{}} tag to our POM and set it to
> {{true}} like this:
> {quote}
> While just {{}} really is a {_}tag{_}, we have to add a
> {{filtering}} {_}element{_}, consisting of a _start tag_ *and* an _end tag_
> (and some content in between, but that's not the point here anyway).
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MPLUGIN-537) Set the core Maven dependency to 4.0.0-beta4
[ https://issues.apache.org/jira/browse/MPLUGIN-537?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17883630#comment-17883630 ] ASF GitHub Bot commented on MPLUGIN-537: slachiewicz merged PR #327: URL: https://github.com/apache/maven-plugin-tools/pull/327 > Set the core Maven dependency to 4.0.0-beta4 > > > Key: MPLUGIN-537 > URL: https://issues.apache.org/jira/browse/MPLUGIN-537 > Project: Maven Plugin Tools > Issue Type: Dependency upgrade >Reporter: Sylwester Lachiewicz >Priority: Minor > Fix For: 4.0.0, 4.0.0-beta-2 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (SUREFIRE-1737) Disabling the JUnit5Xml30StatelessReporter has no effect
[
https://issues.apache.org/jira/browse/SUREFIRE-1737?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17883618#comment-17883618
]
ASF GitHub Bot commented on SUREFIRE-1737:
--
slawekjaranowski merged PR #780:
URL: https://github.com/apache/maven-surefire/pull/780
> Disabling the JUnit5Xml30StatelessReporter has no effect
> -
>
> Key: SUREFIRE-1737
> URL: https://issues.apache.org/jira/browse/SUREFIRE-1737
> Project: Maven Surefire
> Issue Type: Bug
>Affects Versions: 3.0.0-M4
>Reporter: Dietrich Schulten
>Assignee: Slawomir Jaranowski
>Priority: Major
> Fix For: 3.5.1
>
>
> I have the following configuration for JUnit 5 display names:
> {code:java}
>
> org.apache.maven.plugins
> maven-surefire-plugin
> 3.0.0-M4
>
> implementation="org.apache.maven.plugin.surefire.extensions.junit5.JUnit5Xml30StatelessReporter">
> true
> true
> true
> true
> true
>
>
> {code}
> Based on the disable flag, the {{JUnit5Xml30StatelessReporter}} should be
> {{disabled}}, but it evaluates display names according to the
> {{usePhrasedXXX}} flags.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MJAVADOC-812) [REGRESSION] maven-javadoc-plugin 3.10.0 creates empty JARs
[
https://issues.apache.org/jira/browse/MJAVADOC-812?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17883610#comment-17883610
]
ASF GitHub Bot commented on MJAVADOC-812:
-
krezovic commented on PR #320:
URL:
https://github.com/apache/maven-javadoc-plugin/pull/320#issuecomment-2366817587
I am the same person who reported the bug, but I write from personal account
here since I don't have the credentials from the work account on my personal
machine.
When I checkout this branch and build the plugin, then build the reproducer
I provided, it seems OK
> [REGRESSION] maven-javadoc-plugin 3.10.0 creates empty JARs
> ---
>
> Key: MJAVADOC-812
> URL: https://issues.apache.org/jira/browse/MJAVADOC-812
> Project: Maven Javadoc Plugin
> Issue Type: Bug
>Affects Versions: 3.10.0
>Reporter: Armin Krezovic
>Assignee: Michael Osipov
>Priority: Major
> Attachments: maven-javadoc-invocation.log
>
>
> After updating to maven-javadoc-plugin 3.10.0, I am getting empty javadoc
> jars created.
> {code:java}
> [INFO] --- jar:3.4.2:jar (default-jar) @ configuration ---
> [INFO] Building jar:
> C:\path\to\configuration\target\configuration-10.1.0-SNAPSHOT-2409192051.4892c3d.jar
> [INFO]
> [INFO] --- javadoc:3.10.0:jar (attach-javadocs) @ configuration ---
> [WARNING] JAR will be empty - no content was marked for inclusion!
> [INFO] Building jar:
> C:\path\to\configuration\target\configuration-10.1.0-SNAPSHOT-2409192051.4892c3d-javadoc.jar
> [INFO]
> [INFO] --- source:3.3.1:jar-no-fork (attach-sources) @ configuration ---
> [INFO] No sources in project. Archive not created.{code}
>
> Prior version, 3.8.0, had no such problem
> {code:java}
> [INFO] --- jar:3.4.2:jar (default-jar) @ configuration ---
> [INFO] Building jar:
> C:\path\to\configuration\target\configuration-10.1.0-SNAPSHOT-2409192102.595f143.jar
> [INFO]
> [INFO] --- javadoc:3.8.0:jar (attach-javadocs) @ configuration ---
> [INFO]
> [INFO] >>> source:3.3.1:jar (attach-sources) > generate-sources @
> configuration >>>{code}
>
> Plugin configuration
> {code:java}
>
> org.apache.maven.plugins
> maven-javadoc-plugin
> 3.10.0
>
>all,-missing
>
>
>
> attach-javadocs
>
> jar
>
>
>
> {code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MJDEPS-31) Upgrade maven-plugin parent to 43
[ https://issues.apache.org/jira/browse/MJDEPS-31?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17883607#comment-17883607 ] ASF GitHub Bot commented on MJDEPS-31: -- slachiewicz merged PR #16: URL: https://github.com/apache/maven-jdeps-plugin/pull/16 > Upgrade maven-plugin parent to 43 > - > > Key: MJDEPS-31 > URL: https://issues.apache.org/jira/browse/MJDEPS-31 > Project: Maven JDeps Plugin > Issue Type: Dependency upgrade >Affects Versions: 3.1.2 >Reporter: Karl Heinz Marbaise >Assignee: Sylwester Lachiewicz >Priority: Minor > Fix For: 3.2.0 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MRELEASE-1154) [REGRESSION] MRELEASE-1109 breaks release of Maven Surefire
[
https://issues.apache.org/jira/browse/MRELEASE-1154?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17883606#comment-17883606
]
ASF GitHub Bot commented on MRELEASE-1154:
--
michael-o commented on PR #230:
URL: https://github.com/apache/maven-release/pull/230#issuecomment-2366805379
> Any more feedback? I would like to merge this in order to fix the
underlying regression.
Will pick up tomorrow
> [REGRESSION] MRELEASE-1109 breaks release of Maven Surefire
> ---
>
> Key: MRELEASE-1154
> URL: https://issues.apache.org/jira/browse/MRELEASE-1154
> Project: Maven Release Plugin
> Issue Type: Bug
> Components: prepare
>Affects Versions: 3.1.0, 3.1.1
>Reporter: Michael Osipov
>Assignee: Michael Osipov
>Priority: Major
> Fix For: next-release
>
>
> Upgraded Maven Surefire to Parent 43 and failed to prepare release with {{mvn
> release:prepare -e}}:
> {noformat}
> [INFO] Ignoring artifact version update for expression ${project.version}
> [INFO]
>
> [INFO] Reactor Summary for Apache Maven Surefire 3.5.1-SNAPSHOT:
> [INFO]
> [INFO] Apache Maven Surefire .. FAILURE [ 58.812
> s]
> [INFO] Surefire Shared Utils .. SKIPPED
> [INFO] Surefire Logger API SKIPPED
> [INFO] Surefire API ... SKIPPED
> [INFO] Surefire Extensions API SKIPPED
> [INFO] Surefire Extensions SPI SKIPPED
> [INFO] Surefire Booter SKIPPED
> [INFO] Maven Surefire Test-Grouping Support ... SKIPPED
> [INFO] Surefire Providers . SKIPPED
> [INFO] Shared JUnit3 Provider Code SKIPPED
> [INFO] Shared Java 5 Provider Base SKIPPED
> [INFO] Shared JUnit4 Provider Code SKIPPED
> [INFO] Shared JUnit48 Provider Code ... SKIPPED
> [INFO] Surefire JUnit Runner .. SKIPPED
> [INFO] Surefire JUnit4 Runner . SKIPPED
> [INFO] Maven Surefire Common .. SKIPPED
> [INFO] Surefire JUnitCore Runner .. SKIPPED
> [INFO] Surefire JUnit Platform Runner . SKIPPED
> [INFO] Surefire TestNG Utils .. SKIPPED
> [INFO] Surefire TestNG Runner . SKIPPED
> [INFO] ShadeFire JUnit3 Provider .. SKIPPED
> [INFO] Surefire Report Parser . SKIPPED
> [INFO] Maven Surefire Plugin .. SKIPPED
> [INFO] Maven Failsafe Plugin .. SKIPPED
> [INFO] Maven Surefire Report Plugin ... SKIPPED
> [INFO] Maven Surefire Integration Tests ... SKIPPED
> [INFO]
>
> [INFO] BUILD FAILURE
> [INFO]
>
> [INFO] Total time: 01:02 min
> [INFO] Finished at: 2024-08-23T11:32:04+02:00
> [INFO]
>
> [ERROR] Failed to execute goal
> org.apache.maven.plugins:maven-release-plugin:3.1.0:prepare (default-cli) on
> project surefire: Could not find properties resolving version expression :
> ${surefire-shared-utils.version} -> [Help 1]
> org.apache.maven.lifecycle.LifecycleExecutionException: Failed to execute
> goal org.apache.maven.plugins:maven-release-plugin:3.1.0:prepare
> (default-cli) on project surefire: Could not find properties resolving
> version expression : ${surefire-shared-utils.version}
> at org.apache.maven.lifecycle.internal.MojoExecutor.doExecute2
> (MojoExecutor.java:333)
> at org.apache.maven.lifecycle.internal.MojoExecutor.doExecute
> (MojoExecutor.java:316)
> at org.apache.maven.lifecycle.internal.MojoExecutor.execute
> (MojoExecutor.java:212)
> at org.apache.maven.lifecycle.internal.MojoExecutor.execute
> (MojoExecutor.java:174)
> at org.apache.maven.lifecycle.internal.MojoExecutor.access$000
> (MojoExecutor.java:75)
> at org.apache.maven.lifecycle.internal.MojoExecutor$1.run
> (MojoExecutor.java:162)
> at org.apache.maven.plugin.DefaultMojosExecutionStrategy.execute
> (DefaultMojosExecutionStrategy.java:39)
> at org.apache.maven.lifecycle.internal.MojoExecutor.execute
> (MojoExecutor.java:159)
> at
> org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject
> (LifecycleModuleBuilder.java:105)
> at
> org.a
[jira] [Commented] (MRELEASE-1154) [REGRESSION] MRELEASE-1109 breaks release of Maven Surefire
[
https://issues.apache.org/jira/browse/MRELEASE-1154?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17883604#comment-17883604
]
ASF GitHub Bot commented on MRELEASE-1154:
--
kwin commented on PR #230:
URL: https://github.com/apache/maven-release/pull/230#issuecomment-2366794719
Any more feedback? I would like to merge this in order to fix the underlying
regression.
> [REGRESSION] MRELEASE-1109 breaks release of Maven Surefire
> ---
>
> Key: MRELEASE-1154
> URL: https://issues.apache.org/jira/browse/MRELEASE-1154
> Project: Maven Release Plugin
> Issue Type: Bug
> Components: prepare
>Affects Versions: 3.1.0, 3.1.1
>Reporter: Michael Osipov
>Assignee: Michael Osipov
>Priority: Major
> Fix For: next-release
>
>
> Upgraded Maven Surefire to Parent 43 and failed to prepare release with {{mvn
> release:prepare -e}}:
> {noformat}
> [INFO] Ignoring artifact version update for expression ${project.version}
> [INFO]
>
> [INFO] Reactor Summary for Apache Maven Surefire 3.5.1-SNAPSHOT:
> [INFO]
> [INFO] Apache Maven Surefire .. FAILURE [ 58.812
> s]
> [INFO] Surefire Shared Utils .. SKIPPED
> [INFO] Surefire Logger API SKIPPED
> [INFO] Surefire API ... SKIPPED
> [INFO] Surefire Extensions API SKIPPED
> [INFO] Surefire Extensions SPI SKIPPED
> [INFO] Surefire Booter SKIPPED
> [INFO] Maven Surefire Test-Grouping Support ... SKIPPED
> [INFO] Surefire Providers . SKIPPED
> [INFO] Shared JUnit3 Provider Code SKIPPED
> [INFO] Shared Java 5 Provider Base SKIPPED
> [INFO] Shared JUnit4 Provider Code SKIPPED
> [INFO] Shared JUnit48 Provider Code ... SKIPPED
> [INFO] Surefire JUnit Runner .. SKIPPED
> [INFO] Surefire JUnit4 Runner . SKIPPED
> [INFO] Maven Surefire Common .. SKIPPED
> [INFO] Surefire JUnitCore Runner .. SKIPPED
> [INFO] Surefire JUnit Platform Runner . SKIPPED
> [INFO] Surefire TestNG Utils .. SKIPPED
> [INFO] Surefire TestNG Runner . SKIPPED
> [INFO] ShadeFire JUnit3 Provider .. SKIPPED
> [INFO] Surefire Report Parser . SKIPPED
> [INFO] Maven Surefire Plugin .. SKIPPED
> [INFO] Maven Failsafe Plugin .. SKIPPED
> [INFO] Maven Surefire Report Plugin ... SKIPPED
> [INFO] Maven Surefire Integration Tests ... SKIPPED
> [INFO]
>
> [INFO] BUILD FAILURE
> [INFO]
>
> [INFO] Total time: 01:02 min
> [INFO] Finished at: 2024-08-23T11:32:04+02:00
> [INFO]
>
> [ERROR] Failed to execute goal
> org.apache.maven.plugins:maven-release-plugin:3.1.0:prepare (default-cli) on
> project surefire: Could not find properties resolving version expression :
> ${surefire-shared-utils.version} -> [Help 1]
> org.apache.maven.lifecycle.LifecycleExecutionException: Failed to execute
> goal org.apache.maven.plugins:maven-release-plugin:3.1.0:prepare
> (default-cli) on project surefire: Could not find properties resolving
> version expression : ${surefire-shared-utils.version}
> at org.apache.maven.lifecycle.internal.MojoExecutor.doExecute2
> (MojoExecutor.java:333)
> at org.apache.maven.lifecycle.internal.MojoExecutor.doExecute
> (MojoExecutor.java:316)
> at org.apache.maven.lifecycle.internal.MojoExecutor.execute
> (MojoExecutor.java:212)
> at org.apache.maven.lifecycle.internal.MojoExecutor.execute
> (MojoExecutor.java:174)
> at org.apache.maven.lifecycle.internal.MojoExecutor.access$000
> (MojoExecutor.java:75)
> at org.apache.maven.lifecycle.internal.MojoExecutor$1.run
> (MojoExecutor.java:162)
> at org.apache.maven.plugin.DefaultMojosExecutionStrategy.execute
> (DefaultMojosExecutionStrategy.java:39)
> at org.apache.maven.lifecycle.internal.MojoExecutor.execute
> (MojoExecutor.java:159)
> at
> org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject
> (LifecycleModuleBuilder.java:105)
> at
> org.apache.maven.lifecycle.internal.Lifecy
[jira] [Commented] (MJDEPS-31) Upgrade maven-plugin parent to 43
[ https://issues.apache.org/jira/browse/MJDEPS-31?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17883602#comment-17883602 ] ASF GitHub Bot commented on MJDEPS-31: -- slachiewicz opened a new pull request, #16: URL: https://github.com/apache/maven-jdeps-plugin/pull/16 (no comment) > Upgrade maven-plugin parent to 43 > - > > Key: MJDEPS-31 > URL: https://issues.apache.org/jira/browse/MJDEPS-31 > Project: Maven JDeps Plugin > Issue Type: Dependency upgrade >Affects Versions: 3.1.2 >Reporter: Karl Heinz Marbaise >Assignee: Sylwester Lachiewicz >Priority: Minor > Fix For: 3.2.0 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MPMD-405) No release notes for 3.25.0 on https://maven.apache.org/plugins/maven-pmd-plugin/releasenotes.html
[ https://issues.apache.org/jira/browse/MPMD-405?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17883590#comment-17883590 ] ASF GitHub Bot commented on MPMD-405: - garydgregory commented on PR #166: URL: https://github.com/apache/maven-pmd-plugin/pull/166#issuecomment-2366733680 Shouldn't the notes say that a specifc maven site plug-in (or later) is required? > No release notes for 3.25.0 on > https://maven.apache.org/plugins/maven-pmd-plugin/releasenotes.html > -- > > Key: MPMD-405 > URL: https://issues.apache.org/jira/browse/MPMD-405 > Project: Maven PMD Plugin > Issue Type: Bug >Reporter: Gary D. Gregory >Priority: Major > > HI All, > There are no release notes for 3.25.0 on > https://maven.apache.org/plugins/maven-pmd-plugin/releasenotes.html -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MJAVADOC-812) [REGRESSION] maven-javadoc-plugin 3.10.0 creates empty JARs
[
https://issues.apache.org/jira/browse/MJAVADOC-812?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17883532#comment-17883532
]
ASF GitHub Bot commented on MJAVADOC-812:
-
michael-o commented on PR #320:
URL:
https://github.com/apache/maven-javadoc-plugin/pull/320#issuecomment-2365262254
> > I am very surprised that no unit or integration test has failed here
>
> Still no test I see...
True, waiting for the confirmation first. If you want to contribute a test
that would me more than great.
> [REGRESSION] maven-javadoc-plugin 3.10.0 creates empty JARs
> ---
>
> Key: MJAVADOC-812
> URL: https://issues.apache.org/jira/browse/MJAVADOC-812
> Project: Maven Javadoc Plugin
> Issue Type: Bug
>Affects Versions: 3.10.0
>Reporter: Armin Krezovic
>Assignee: Michael Osipov
>Priority: Major
> Attachments: maven-javadoc-invocation.log
>
>
> After updating to maven-javadoc-plugin 3.10.0, I am getting empty javadoc
> jars created.
> {code:java}
> [INFO] --- jar:3.4.2:jar (default-jar) @ configuration ---
> [INFO] Building jar:
> C:\path\to\configuration\target\configuration-10.1.0-SNAPSHOT-2409192051.4892c3d.jar
> [INFO]
> [INFO] --- javadoc:3.10.0:jar (attach-javadocs) @ configuration ---
> [WARNING] JAR will be empty - no content was marked for inclusion!
> [INFO] Building jar:
> C:\path\to\configuration\target\configuration-10.1.0-SNAPSHOT-2409192051.4892c3d-javadoc.jar
> [INFO]
> [INFO] --- source:3.3.1:jar-no-fork (attach-sources) @ configuration ---
> [INFO] No sources in project. Archive not created.{code}
>
> Prior version, 3.8.0, had no such problem
> {code:java}
> [INFO] --- jar:3.4.2:jar (default-jar) @ configuration ---
> [INFO] Building jar:
> C:\path\to\configuration\target\configuration-10.1.0-SNAPSHOT-2409192102.595f143.jar
> [INFO]
> [INFO] --- javadoc:3.8.0:jar (attach-javadocs) @ configuration ---
> [INFO]
> [INFO] >>> source:3.3.1:jar (attach-sources) > generate-sources @
> configuration >>>{code}
>
> Plugin configuration
> {code:java}
>
> org.apache.maven.plugins
> maven-javadoc-plugin
> 3.10.0
>
>all,-missing
>
>
>
> attach-javadocs
>
> jar
>
>
>
> {code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MJAVADOC-812) [REGRESSION] maven-javadoc-plugin 3.10.0 creates empty JARs
[
https://issues.apache.org/jira/browse/MJAVADOC-812?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17883525#comment-17883525
]
ASF GitHub Bot commented on MJAVADOC-812:
-
pzygielo commented on PR #320:
URL:
https://github.com/apache/maven-javadoc-plugin/pull/320#issuecomment-2365247324
> I am very surprised that no unit or integration test has failed here
Still no test I see...
> [REGRESSION] maven-javadoc-plugin 3.10.0 creates empty JARs
> ---
>
> Key: MJAVADOC-812
> URL: https://issues.apache.org/jira/browse/MJAVADOC-812
> Project: Maven Javadoc Plugin
> Issue Type: Bug
>Affects Versions: 3.10.0
>Reporter: Armin Krezovic
>Assignee: Michael Osipov
>Priority: Major
> Attachments: maven-javadoc-invocation.log
>
>
> After updating to maven-javadoc-plugin 3.10.0, I am getting empty javadoc
> jars created.
> {code:java}
> [INFO] --- jar:3.4.2:jar (default-jar) @ configuration ---
> [INFO] Building jar:
> C:\path\to\configuration\target\configuration-10.1.0-SNAPSHOT-2409192051.4892c3d.jar
> [INFO]
> [INFO] --- javadoc:3.10.0:jar (attach-javadocs) @ configuration ---
> [WARNING] JAR will be empty - no content was marked for inclusion!
> [INFO] Building jar:
> C:\path\to\configuration\target\configuration-10.1.0-SNAPSHOT-2409192051.4892c3d-javadoc.jar
> [INFO]
> [INFO] --- source:3.3.1:jar-no-fork (attach-sources) @ configuration ---
> [INFO] No sources in project. Archive not created.{code}
>
> Prior version, 3.8.0, had no such problem
> {code:java}
> [INFO] --- jar:3.4.2:jar (default-jar) @ configuration ---
> [INFO] Building jar:
> C:\path\to\configuration\target\configuration-10.1.0-SNAPSHOT-2409192102.595f143.jar
> [INFO]
> [INFO] --- javadoc:3.8.0:jar (attach-javadocs) @ configuration ---
> [INFO]
> [INFO] >>> source:3.3.1:jar (attach-sources) > generate-sources @
> configuration >>>{code}
>
> Plugin configuration
> {code:java}
>
> org.apache.maven.plugins
> maven-javadoc-plugin
> 3.10.0
>
>all,-missing
>
>
>
> attach-javadocs
>
> jar
>
>
>
> {code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MJAVADOC-812) [REGRESSION] maven-javadoc-plugin 3.10.0 creates empty JARs
[
https://issues.apache.org/jira/browse/MJAVADOC-812?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17883523#comment-17883523
]
ASF GitHub Bot commented on MJAVADOC-812:
-
michael-o opened a new pull request, #320:
URL: https://github.com/apache/maven-javadoc-plugin/pull/320
… JARs
This closes #320
Following this checklist to help us incorporate your
contribution quickly and easily:
- [ ] Make sure there is a [JIRA
issue](https://issues.apache.org/jira/browse/MJAVADOC) filed
for the change (usually before you start working on it). Trivial
changes like typos do not
require a JIRA issue. Your pull request should address just this
issue, without
pulling in other changes.
- [ ] Each commit in the pull request should have a meaningful subject line
and body.
- [ ] Format the pull request title like `[MJAVADOC-XXX] - Fixes bug in
ApproximateQuantiles`,
where you replace `MJAVADOC-XXX` with the appropriate JIRA issue.
Best practice
is to use the JIRA issue title in the pull request title and in the
first line of the
commit message.
- [ ] Write a pull request description that is detailed enough to
understand what the pull request does, how, and why.
- [ ] Run `mvn clean verify -Prun-its` to make sure basic checks pass. A
more thorough check will
be performed on your pull request automatically.
If your pull request is about ~20 lines of code you don't need to sign an
[Individual Contributor License
Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure
please ask on the developers list.
To make clear that you license your contribution under
the [Apache License Version 2.0, January
2004](http://www.apache.org/licenses/LICENSE-2.0)
you have to acknowledge this by using the following check-box.
- [ ] I hereby declare this contribution to be licensed under the [Apache
License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
- [ ] In any other case, please file an [Apache Individual Contributor
License Agreement](https://www.apache.org/licenses/icla.pdf).
> [REGRESSION] maven-javadoc-plugin 3.10.0 creates empty JARs
> ---
>
> Key: MJAVADOC-812
> URL: https://issues.apache.org/jira/browse/MJAVADOC-812
> Project: Maven Javadoc Plugin
> Issue Type: Bug
>Affects Versions: 3.10.0
>Reporter: Armin Krezovic
>Assignee: Michael Osipov
>Priority: Major
> Attachments: maven-javadoc-invocation.log
>
>
> After updating to maven-javadoc-plugin 3.10.0, I am getting empty javadoc
> jars created.
> {code:java}
> [INFO] --- jar:3.4.2:jar (default-jar) @ configuration ---
> [INFO] Building jar:
> C:\path\to\configuration\target\configuration-10.1.0-SNAPSHOT-2409192051.4892c3d.jar
> [INFO]
> [INFO] --- javadoc:3.10.0:jar (attach-javadocs) @ configuration ---
> [WARNING] JAR will be empty - no content was marked for inclusion!
> [INFO] Building jar:
> C:\path\to\configuration\target\configuration-10.1.0-SNAPSHOT-2409192051.4892c3d-javadoc.jar
> [INFO]
> [INFO] --- source:3.3.1:jar-no-fork (attach-sources) @ configuration ---
> [INFO] No sources in project. Archive not created.{code}
>
> Prior version, 3.8.0, had no such problem
> {code:java}
> [INFO] --- jar:3.4.2:jar (default-jar) @ configuration ---
> [INFO] Building jar:
> C:\path\to\configuration\target\configuration-10.1.0-SNAPSHOT-2409192102.595f143.jar
> [INFO]
> [INFO] --- javadoc:3.8.0:jar (attach-javadocs) @ configuration ---
> [INFO]
> [INFO] >>> source:3.3.1:jar (attach-sources) > generate-sources @
> configuration >>>{code}
>
> Plugin configuration
> {code:java}
>
> org.apache.maven.plugins
> maven-javadoc-plugin
> 3.10.0
>
>all,-missing
>
>
>
> attach-javadocs
>
> jar
>
>
>
> {code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (SUREFIRE-1737) Disabling the JUnit5Xml30StatelessReporter has no effect
[
https://issues.apache.org/jira/browse/SUREFIRE-1737?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17883456#comment-17883456
]
ASF GitHub Bot commented on SUREFIRE-1737:
--
slawekjaranowski commented on PR #780:
URL: https://github.com/apache/maven-surefire/pull/780#issuecomment-2365041406
One failed build on jenkins on branch ... can not be re-run as we have PR
> Disabling the JUnit5Xml30StatelessReporter has no effect
> -
>
> Key: SUREFIRE-1737
> URL: https://issues.apache.org/jira/browse/SUREFIRE-1737
> Project: Maven Surefire
> Issue Type: Bug
>Affects Versions: 3.0.0-M4
>Reporter: Dietrich Schulten
>Assignee: Slawomir Jaranowski
>Priority: Major
> Fix For: 3.5.1
>
>
> I have the following configuration for JUnit 5 display names:
> {code:java}
>
> org.apache.maven.plugins
> maven-surefire-plugin
> 3.0.0-M4
>
> implementation="org.apache.maven.plugin.surefire.extensions.junit5.JUnit5Xml30StatelessReporter">
> true
> true
> true
> true
> true
>
>
> {code}
> Based on the disable flag, the {{JUnit5Xml30StatelessReporter}} should be
> {{disabled}}, but it evaluates display names according to the
> {{usePhrasedXXX}} flags.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (SUREFIRE-2267) Packages for commons-codec should be relocated in surefire-shared-utils
[ https://issues.apache.org/jira/browse/SUREFIRE-2267?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17883407#comment-17883407 ] ASF GitHub Bot commented on SUREFIRE-2267: -- slawekjaranowski opened a new pull request, #782: URL: https://github.com/apache/maven-surefire/pull/782 …efire-shared-utils Following this checklist to help us incorporate your contribution quickly and easily: - [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/SUREFIRE) filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes. - [ ] Each commit in the pull request should have a meaningful subject line and body. - [ ] Format the pull request title like `[SUREFIRE-XXX] - Fixes bug in ApproximateQuantiles`, where you replace `SUREFIRE-XXX` with the appropriate JIRA issue. Best practice is to use the JIRA issue title in the pull request title and in the first line of the commit message. - [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [ ] Run `mvn clean install` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically. - [ ] You have run the integration tests successfully (`mvn -Prun-its clean install`). If your pull request is about ~20 lines of code you don't need to sign an [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure please ask on the developers list. To make clear that you license your contribution under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) you have to acknowledge this by using the following check-box. - [ ] I hereby declare this contribution to be licenced under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) - [ ] In any other case, please file an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). > Packages for commons-codec should be relocated in surefire-shared-utils > --- > > Key: SUREFIRE-2267 > URL: https://issues.apache.org/jira/browse/SUREFIRE-2267 > Project: Maven Surefire > Issue Type: Bug >Reporter: Slawomir Jaranowski >Assignee: Slawomir Jaranowski >Priority: Major > Fix For: 3.5.1 > > > We have transitive dependency to commons-codec so we should also relocation > package for it. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (SUREFIRE-2226) Upgrade to Maven Verifier 2.0.0-M1
[ https://issues.apache.org/jira/browse/SUREFIRE-2226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17883406#comment-17883406 ] ASF GitHub Bot commented on SUREFIRE-2226: -- slawekjaranowski merged PR #706: URL: https://github.com/apache/maven-surefire/pull/706 > Upgrade to Maven Verifier 2.0.0-M1 > -- > > Key: SUREFIRE-2226 > URL: https://issues.apache.org/jira/browse/SUREFIRE-2226 > Project: Maven Surefire > Issue Type: Dependency upgrade >Affects Versions: 3.2.3 >Reporter: Michael Osipov >Assignee: Slawomir Jaranowski >Priority: Major > Fix For: 3.5.1 > > > This isn't just a dependency upgrade. Tasks to be done: > * Align import package name > * Replace usage of deprecated methods > * Make use consistently of CLI arguments which contains options, goals, > phases and user properties -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (SUREFIRE-2252) Failsafe xml for a test class has results from another class
[
https://issues.apache.org/jira/browse/SUREFIRE-2252?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17883405#comment-17883405
]
ASF GitHub Bot commented on SUREFIRE-2252:
--
slawekjaranowski commented on code in PR #772:
URL: https://github.com/apache/maven-surefire/pull/772#discussion_r1769219828
##
surefire-providers/surefire-junit-platform/src/main/java/org/apache/maven/surefire/junitplatform/JUnitPlatformProvider.java:
##
@@ -172,25 +171,13 @@ private void invokeAllTests(TestsToRun testsToRun,
RunListenerAdapter adapter) {
}
private void execute(TestsToRun testsToRun, RunListenerAdapter adapter) {
-if (testsToRun.allowEagerReading()) {
-List selectors = new ArrayList<>();
-testsToRun.iterator().forEachRemaining(c ->
selectors.add(selectClass(c.getName(;
-
+testsToRun.iterator().forEachRemaining(c -> {
LauncherDiscoveryRequestBuilder builder = request()
.filters(filters)
.configurationParameters(configurationParameters)
-.selectors(selectors);
-
+.selectors(selectClass(c.getName()));
launcher.execute(builder.build(), adapter);
-} else {
Review Comment:
I linked some of similar issues ... the problem is probbably in
StatelessXmlReporter
> Failsafe xml for a test class has results from another class
>
>
> Key: SUREFIRE-2252
> URL: https://issues.apache.org/jira/browse/SUREFIRE-2252
> Project: Maven Surefire
> Issue Type: Bug
> Components: Maven Failsafe Plugin
>Affects Versions: 3.2.5, 3.3.1
> Environment: Maven/JUnit5/Mac
>Reporter: Arvind Joshi
>Priority: Blocker
> Attachments: ClassAIT.java, ClassBIT.java,
> TEST-org.example.ClassAIT.xml, TEST-org.example.ClassBIT.xml, pom.xml
>
>
> *Issue*
> When I execute tests concurrently (at class level), I see the failsafe xmls
> being generated, but the test methods themselves seem to be mixed up with
> other classes.
> *Expectation*
> Each failsafe xml is unique to a class, which was the case with the JUnit4
> provider.
> *Versions*
> maven failsafe plugin 3.2.5 or 3.3.1
> JUnit 5.10.2
> *Sample code and Test results*
> Please see attached files
> *Running the tests attached*
>
> {noformat}
> mvn clean verify -Pparallel-tests{noformat}
>
>
> {noformat}
> [INFO] ---
> [INFO] T E S T S
> [INFO] ---
> [INFO] Running org.example.ClassBIT
> [INFO] Running org.example.ClassAIT
> [INFO] Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.026
> s – in org.example.ClassAIT
> [INFO] Tests run: 0, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.026
> s – in org.example.ClassBIT
> [INFO]
> [INFO] Results:
> [INFO]
> [INFO] Tests run: 2, Failures: 0, Errors: 0, Skipped: 0{noformat}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (SUREFIRE-2252) Failsafe xml for a test class has results from another class
[
https://issues.apache.org/jira/browse/SUREFIRE-2252?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17883402#comment-17883402
]
ASF GitHub Bot commented on SUREFIRE-2252:
--
ArvindJoshi-okta commented on code in PR #772:
URL: https://github.com/apache/maven-surefire/pull/772#discussion_r1769204975
##
surefire-providers/surefire-junit-platform/src/main/java/org/apache/maven/surefire/junitplatform/JUnitPlatformProvider.java:
##
@@ -172,25 +171,13 @@ private void invokeAllTests(TestsToRun testsToRun,
RunListenerAdapter adapter) {
}
private void execute(TestsToRun testsToRun, RunListenerAdapter adapter) {
-if (testsToRun.allowEagerReading()) {
-List selectors = new ArrayList<>();
-testsToRun.iterator().forEachRemaining(c ->
selectors.add(selectClass(c.getName(;
-
+testsToRun.iterator().forEachRemaining(c -> {
LauncherDiscoveryRequestBuilder builder = request()
.filters(filters)
.configurationParameters(configurationParameters)
-.selectors(selectors);
-
+.selectors(selectClass(c.getName()));
launcher.execute(builder.build(), adapter);
-} else {
Review Comment:
The issue seems to be in the test listener which isn't parallel safe and is
expecting results to trickle in sequentially, unsure of what needs to be fixed.
> Failsafe xml for a test class has results from another class
>
>
> Key: SUREFIRE-2252
> URL: https://issues.apache.org/jira/browse/SUREFIRE-2252
> Project: Maven Surefire
> Issue Type: Bug
> Components: Maven Failsafe Plugin
>Affects Versions: 3.2.5, 3.3.1
> Environment: Maven/JUnit5/Mac
>Reporter: Arvind Joshi
>Priority: Blocker
> Attachments: ClassAIT.java, ClassBIT.java,
> TEST-org.example.ClassAIT.xml, TEST-org.example.ClassBIT.xml, pom.xml
>
>
> *Issue*
> When I execute tests concurrently (at class level), I see the failsafe xmls
> being generated, but the test methods themselves seem to be mixed up with
> other classes.
> *Expectation*
> Each failsafe xml is unique to a class, which was the case with the JUnit4
> provider.
> *Versions*
> maven failsafe plugin 3.2.5 or 3.3.1
> JUnit 5.10.2
> *Sample code and Test results*
> Please see attached files
> *Running the tests attached*
>
> {noformat}
> mvn clean verify -Pparallel-tests{noformat}
>
>
> {noformat}
> [INFO] ---
> [INFO] T E S T S
> [INFO] ---
> [INFO] Running org.example.ClassBIT
> [INFO] Running org.example.ClassAIT
> [INFO] Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.026
> s – in org.example.ClassAIT
> [INFO] Tests run: 0, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.026
> s – in org.example.ClassBIT
> [INFO]
> [INFO] Results:
> [INFO]
> [INFO] Tests run: 2, Failures: 0, Errors: 0, Skipped: 0{noformat}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (SUREFIRE-2266) Execute ITs in parallel
[ https://issues.apache.org/jira/browse/SUREFIRE-2266?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17883219#comment-17883219 ] ASF GitHub Bot commented on SUREFIRE-2266: -- slawekjaranowski merged PR #781: URL: https://github.com/apache/maven-surefire/pull/781 > Execute ITs in parallel > --- > > Key: SUREFIRE-2266 > URL: https://issues.apache.org/jira/browse/SUREFIRE-2266 > Project: Maven Surefire > Issue Type: Improvement >Reporter: Slawomir Jaranowski >Assignee: Slawomir Jaranowski >Priority: Major > Fix For: 3.5.1 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (DOXIASITETOOLS-348) Extend site descriptor to enforce a parent
[
https://issues.apache.org/jira/browse/DOXIASITETOOLS-348?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17883195#comment-17883195
]
ASF GitHub Bot commented on DOXIASITETOOLS-348:
---
michael-o commented on PR #173:
URL:
https://github.com/apache/maven-doxia-sitetools/pull/173#issuecomment-2363210034
> > we have a conceptual flaw in our design
>
> Yes, but I am trying to fix this without breaking backwards compatibility.
>
> Having an additional parent on the site.xml level would fix this, but in
most cases is highly redundant (and also isn't properly upgraded during
release), so maintaining this on `site.xml` level would lead to a lot of
additional challenges.
>
> Similar an additional dependency on the POM level feels highly redundant,
because this should always reflect the Maven coordinates of the parent. Also
knowledge about classifier (potentially extended with locale) requires
additional knowledge from consumers they shouldn't necessarily know about.
>
> So just having a boolean toggle is IMHO the option with least redundancy
and simplest to understand from a consumer PoV.
Let me crunch on this...I am we are already breaking stuff. This would be
ideal for now because we won't have another chance soon to break it.
> Extend site descriptor to enforce a parent
> --
>
> Key: DOXIASITETOOLS-348
> URL: https://issues.apache.org/jira/browse/DOXIASITETOOLS-348
> Project: Maven Doxia Sitetools
> Issue Type: Improvement
> Components: Site model
>Affects Versions: 2.0.0-M19
>Reporter: Konrad Windszus
>Assignee: Konrad Windszus
>Priority: Major
>
> Currently the [site
> descriptor|https://maven.apache.org/doxia/doxia-sitetools/doxia-site-model/site.html]
> does not allow to enforce a parent {{site.xml}}.
> The attribute {{combine.self}} does not lead to a failure in case no parent
> {{site.xml}} can be found.
> This may easily lead to broken sites without breaking the site build as
> a) the site transparently inherits the {{site.xml}} attached to the parent
> POM.
> b) attaching the {{site.xml}} to a project is a manual step
> (https://maven.apache.org/plugins/maven-site-plugin/attach-descriptor-mojo.html)
> As at the time when the descriptor of the derived {{site.xml}} is created it
> is known whether the descriptor works standalone or requires a parent
> {{site.xml}}, therefore this should be made explicit in the site descriptor.
> I propose to add an additional attribute {{requireParent}} on the top level
> element which is {{false}} by default (current behaviour). If set to {{true}}
> it should lead to a build failure in case the parent {{site.xml}} cannot be
> resolved (for whatever reason).
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (DOXIASITETOOLS-348) Extend site descriptor to enforce a parent
[
https://issues.apache.org/jira/browse/DOXIASITETOOLS-348?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17883194#comment-17883194
]
ASF GitHub Bot commented on DOXIASITETOOLS-348:
---
kwin commented on PR #173:
URL:
https://github.com/apache/maven-doxia-sitetools/pull/173#issuecomment-2363204708
> we have a conceptual flaw in our design
Yes, but I am trying to fix this without breaking backwards compatibility.
Having an additional parent on the site.xml level would fix this, but in
most cases is highly redundant (and also isn't properly upgraded during
release), so maintaining this on `site.xml` level would lead to a lot of
additional challenges.
Similar an additional dependency on the POM level feels highly redundant,
because this should always reflect the Maven coordinates of the parent. Also
knowledge about classifier (potentially extended with locale) requires
additional knowledge from consumers they shouldn't necessarily know about.
So just having a boolean toggle is IMHO the option with least redundancy and
simplest to understand from a consumer PoV.
> Extend site descriptor to enforce a parent
> --
>
> Key: DOXIASITETOOLS-348
> URL: https://issues.apache.org/jira/browse/DOXIASITETOOLS-348
> Project: Maven Doxia Sitetools
> Issue Type: Improvement
> Components: Site model
>Affects Versions: 2.0.0-M19
>Reporter: Konrad Windszus
>Assignee: Konrad Windszus
>Priority: Major
>
> Currently the [site
> descriptor|https://maven.apache.org/doxia/doxia-sitetools/doxia-site-model/site.html]
> does not allow to enforce a parent {{site.xml}}.
> The attribute {{combine.self}} does not lead to a failure in case no parent
> {{site.xml}} can be found.
> This may easily lead to broken sites without breaking the site build as
> a) the site transparently inherits the {{site.xml}} attached to the parent
> POM.
> b) attaching the {{site.xml}} to a project is a manual step
> (https://maven.apache.org/plugins/maven-site-plugin/attach-descriptor-mojo.html)
> As at the time when the descriptor of the derived {{site.xml}} is created it
> is known whether the descriptor works standalone or requires a parent
> {{site.xml}}, therefore this should be made explicit in the site descriptor.
> I propose to add an additional attribute {{requireParent}} on the top level
> element which is {{false}} by default (current behaviour). If set to {{true}}
> it should lead to a build failure in case the parent {{site.xml}} cannot be
> resolved (for whatever reason).
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (DOXIASITETOOLS-348) Extend site descriptor to enforce a parent
[
https://issues.apache.org/jira/browse/DOXIASITETOOLS-348?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17883193#comment-17883193
]
ASF GitHub Bot commented on DOXIASITETOOLS-348:
---
michael-o commented on PR #173:
URL:
https://github.com/apache/maven-doxia-sitetools/pull/173#issuecomment-2363189879
Looking at your usecase I have the feeling that we have a conceptual flaw in
our design. Implicit parents do not seem right after all and you are trying to
remedy this with a parameter at the wrong place IMHO. I think that we either
need something like:
```xml
com.mycompany.app
my-app
1
```
(type and classifier are implied)
or we can make the `site.xml` a provided dependency of our build in the POM
directly. If the site descriptor follows the rules of the POM then introducing
a parent seems natural to me, no?
See this one:
https://repo1.maven.org/maven2/org/apache/maven/maven-parent/43/maven-parent-43-site.xml
Either:
```xml
org.apache.maven
maven-parent
43
```
OR
```xml
org.apache.maven
maven-parent
43
xml
site
```
WDYT?
> Extend site descriptor to enforce a parent
> --
>
> Key: DOXIASITETOOLS-348
> URL: https://issues.apache.org/jira/browse/DOXIASITETOOLS-348
> Project: Maven Doxia Sitetools
> Issue Type: Improvement
> Components: Site model
>Affects Versions: 2.0.0-M19
>Reporter: Konrad Windszus
>Assignee: Konrad Windszus
>Priority: Major
>
> Currently the [site
> descriptor|https://maven.apache.org/doxia/doxia-sitetools/doxia-site-model/site.html]
> does not allow to enforce a parent {{site.xml}}.
> The attribute {{combine.self}} does not lead to a failure in case no parent
> {{site.xml}} can be found.
> This may easily lead to broken sites without breaking the site build as
> a) the site transparently inherits the {{site.xml}} attached to the parent
> POM.
> b) attaching the {{site.xml}} to a project is a manual step
> (https://maven.apache.org/plugins/maven-site-plugin/attach-descriptor-mojo.html)
> As at the time when the descriptor of the derived {{site.xml}} is created it
> is known whether the descriptor works standalone or requires a parent
> {{site.xml}}, therefore this should be made explicit in the site descriptor.
> I propose to add an additional attribute {{requireParent}} on the top level
> element which is {{false}} by default (current behaviour). If set to {{true}}
> it should lead to a build failure in case the parent {{site.xml}} cannot be
> resolved (for whatever reason).
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (SUREFIRE-2226) Upgrade to Maven Verifier 2.0.0-M1
[
https://issues.apache.org/jira/browse/SUREFIRE-2226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17883188#comment-17883188
]
ASF GitHub Bot commented on SUREFIRE-2226:
--
michael-o commented on code in PR #706:
URL: https://github.com/apache/maven-surefire/pull/706#discussion_r1768174827
##
surefire-its/src/test/java/org/apache/maven/surefire/its/fixture/MavenLauncher.java:
##
@@ -259,21 +260,14 @@ public OutputValidator execute(String goal) {
public OutputValidator executeCurrentGoals() {
try {
-List goalsAndProps = new ArrayList<>(goals);
-
-for (Entry e : props.entrySet()) {
-String key = e.getKey();
-String val = e.getValue();
-goalsAndProps.add(val == null ? "-D" + key : "-D" + key + "="
+ val);
-}
-
-getVerifier().setCliOptions(cliOptions);
-getVerifier().executeGoals(goalsAndProps, envVars);
+getVerifier().addCliArguments(cliOptions.toArray(new String[] {}));
Review Comment:
`new String[0]` is sufficient
> Upgrade to Maven Verifier 2.0.0-M1
> --
>
> Key: SUREFIRE-2226
> URL: https://issues.apache.org/jira/browse/SUREFIRE-2226
> Project: Maven Surefire
> Issue Type: Dependency upgrade
>Affects Versions: 3.2.3
>Reporter: Michael Osipov
>Assignee: Slawomir Jaranowski
>Priority: Major
> Fix For: 3.5.1
>
>
> This isn't just a dependency upgrade. Tasks to be done:
> * Align import package name
> * Replace usage of deprecated methods
> * Make use consistently of CLI arguments which contains options, goals,
> phases and user properties
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (SUREFIRE-2265) Bump commons-io:commons-io from 2.16.1 to 2.17.0
[ https://issues.apache.org/jira/browse/SUREFIRE-2265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17883178#comment-17883178 ] ASF GitHub Bot commented on SUREFIRE-2265: -- slawekjaranowski merged PR #779: URL: https://github.com/apache/maven-surefire/pull/779 > Bump commons-io:commons-io from 2.16.1 to 2.17.0 > > > Key: SUREFIRE-2265 > URL: https://issues.apache.org/jira/browse/SUREFIRE-2265 > Project: Maven Surefire > Issue Type: Dependency upgrade >Reporter: Slawomir Jaranowski >Assignee: Slawomir Jaranowski >Priority: Major > Fix For: 3.5.1 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (DOXIASITETOOLS-349) Remove plexus-component-metadata plugin
[ https://issues.apache.org/jira/browse/DOXIASITETOOLS-349?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17883166#comment-17883166 ] ASF GitHub Bot commented on DOXIASITETOOLS-349: --- kwin merged PR #172: URL: https://github.com/apache/maven-doxia-sitetools/pull/172 > Remove plexus-component-metadata plugin > --- > > Key: DOXIASITETOOLS-349 > URL: https://issues.apache.org/jira/browse/DOXIASITETOOLS-349 > Project: Maven Doxia Sitetools > Issue Type: Improvement >Reporter: Konrad Windszus >Assignee: Konrad Windszus >Priority: Major > > With DOXIASITETOOLS-247 Plexus annotations have been replaced by JSR-330 > ones. However the plexus-component-metadata-plugin is still executed > (although the annotations are no longer used). -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (ARCHETYPE-678) Code cleanups
[
https://issues.apache.org/jira/browse/ARCHETYPE-678?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17883161#comment-17883161
]
ASF GitHub Bot commented on ARCHETYPE-678:
--
slawekjaranowski merged PR #221:
URL: https://github.com/apache/maven-archetype/pull/221
> Code cleanups
> -
>
> Key: ARCHETYPE-678
> URL: https://issues.apache.org/jira/browse/ARCHETYPE-678
> Project: Maven Archetype
> Issue Type: Task
>Reporter: Slawomir Jaranowski
>Assignee: Slawomir Jaranowski
>Priority: Major
> Fix For: 3.3.0
>
>
> - fix modello xmlns
> - avoid using deprecated api
> - remove unused items
> - use Files nio for IO streams
> - drop usage of {{MojoFailureException}}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (SUREFIRE-1737) Disabling the JUnit5Xml30StatelessReporter has no effect
[
https://issues.apache.org/jira/browse/SUREFIRE-1737?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17883114#comment-17883114
]
ASF GitHub Bot commented on SUREFIRE-1737:
--
slawekjaranowski opened a new pull request, #780:
URL: https://github.com/apache/maven-surefire/pull/780
Following this checklist to help us incorporate your
contribution quickly and easily:
- [ ] Make sure there is a [JIRA
issue](https://issues.apache.org/jira/browse/SUREFIRE) filed
for the change (usually before you start working on it). Trivial
changes like typos do not
require a JIRA issue. Your pull request should address just this
issue, without
pulling in other changes.
- [ ] Each commit in the pull request should have a meaningful subject line
and body.
- [ ] Format the pull request title like `[SUREFIRE-XXX] - Fixes bug in
ApproximateQuantiles`,
where you replace `SUREFIRE-XXX` with the appropriate JIRA issue.
Best practice
is to use the JIRA issue title in the pull request title and in the
first line of the
commit message.
- [ ] Write a pull request description that is detailed enough to
understand what the pull request does, how, and why.
- [ ] Run `mvn clean install` to make sure basic checks pass. A more
thorough check will
be performed on your pull request automatically.
- [ ] You have run the integration tests successfully (`mvn -Prun-its clean
install`).
If your pull request is about ~20 lines of code you don't need to sign an
[Individual Contributor License
Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure
please ask on the developers list.
To make clear that you license your contribution under
the [Apache License Version 2.0, January
2004](http://www.apache.org/licenses/LICENSE-2.0)
you have to acknowledge this by using the following check-box.
- [ ] I hereby declare this contribution to be licenced under the [Apache
License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
- [ ] In any other case, please file an [Apache Individual Contributor
License Agreement](https://www.apache.org/licenses/icla.pdf).
> Disabling the JUnit5Xml30StatelessReporter has no effect
> -
>
> Key: SUREFIRE-1737
> URL: https://issues.apache.org/jira/browse/SUREFIRE-1737
> Project: Maven Surefire
> Issue Type: Bug
>Affects Versions: 3.0.0-M4
>Reporter: Dietrich Schulten
>Assignee: Slawomir Jaranowski
>Priority: Major
> Fix For: 3.5.1
>
>
> I have the following configuration for JUnit 5 display names:
> {code:java}
>
> org.apache.maven.plugins
> maven-surefire-plugin
> 3.0.0-M4
>
> implementation="org.apache.maven.plugin.surefire.extensions.junit5.JUnit5Xml30StatelessReporter">
> true
> true
> true
> true
> true
>
>
> {code}
> Based on the disable flag, the {{JUnit5Xml30StatelessReporter}} should be
> {{disabled}}, but it evaluates display names according to the
> {{usePhrasedXXX}} flags.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (DOXIASITETOOLS-348) Extend site descriptor to enforce a parent
[
https://issues.apache.org/jira/browse/DOXIASITETOOLS-348?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17883086#comment-17883086
]
ASF GitHub Bot commented on DOXIASITETOOLS-348:
---
michael-o commented on PR #173:
URL:
https://github.com/apache/maven-doxia-sitetools/pull/173#issuecomment-2361857399
I have a few thoughts on this, will try to share tomorrow or over the
weekend.
> Extend site descriptor to enforce a parent
> --
>
> Key: DOXIASITETOOLS-348
> URL: https://issues.apache.org/jira/browse/DOXIASITETOOLS-348
> Project: Maven Doxia Sitetools
> Issue Type: Improvement
> Components: Site model
>Affects Versions: 2.0.0-M19
>Reporter: Konrad Windszus
>Assignee: Konrad Windszus
>Priority: Major
>
> Currently the [site
> descriptor|https://maven.apache.org/doxia/doxia-sitetools/doxia-site-model/site.html]
> does not allow to enforce a parent {{site.xml}}.
> The attribute {{combine.self}} does not lead to a failure in case no parent
> {{site.xml}} can be found.
> This may easily lead to broken sites without breaking the site build as
> a) the site transparently inherits the {{site.xml}} attached to the parent
> POM.
> b) attaching the {{site.xml}} to a project is a manual step
> (https://maven.apache.org/plugins/maven-site-plugin/attach-descriptor-mojo.html)
> As at the time when the descriptor of the derived {{site.xml}} is created it
> is known whether the descriptor works standalone or requires a parent
> {{site.xml}}, therefore this should be made explicit in the site descriptor.
> I propose to add an additional attribute {{requireParent}} on the top level
> element which is {{false}} by default (current behaviour). If set to {{true}}
> it should lead to a build failure in case the parent {{site.xml}} cannot be
> resolved (for whatever reason).
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (ARCHETYPE-664) Bump commons-io:commons-io from 2.15.1 to 2.17.0
[ https://issues.apache.org/jira/browse/ARCHETYPE-664?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17883084#comment-17883084 ] ASF GitHub Bot commented on ARCHETYPE-664: -- slawekjaranowski merged PR #220: URL: https://github.com/apache/maven-archetype/pull/220 > Bump commons-io:commons-io from 2.15.1 to 2.17.0 > > > Key: ARCHETYPE-664 > URL: https://issues.apache.org/jira/browse/ARCHETYPE-664 > Project: Maven Archetype > Issue Type: Dependency upgrade >Reporter: Slawomir Jaranowski >Assignee: Slawomir Jaranowski >Priority: Major > Fix For: 3.3.0 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (ARCHETYPE-678) Code cleanups
[
https://issues.apache.org/jira/browse/ARCHETYPE-678?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17883082#comment-17883082
]
ASF GitHub Bot commented on ARCHETYPE-678:
--
slawekjaranowski opened a new pull request, #221:
URL: https://github.com/apache/maven-archetype/pull/221
https://issues.apache.org/jira/browse/ARCHETYPE-678
> Code cleanups
> -
>
> Key: ARCHETYPE-678
> URL: https://issues.apache.org/jira/browse/ARCHETYPE-678
> Project: Maven Archetype
> Issue Type: Task
>Reporter: Slawomir Jaranowski
>Assignee: Slawomir Jaranowski
>Priority: Major
> Fix For: 3.3.0
>
>
> - fix modello xmlns
> - avoid using deprecated api
> - remove unused items
> - use Files nio for IO streams
> - drop usage of {{MojoFailureException}}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (DOXIASITETOOLS-348) Extend site descriptor to enforce a parent
[ https://issues.apache.org/jira/browse/DOXIASITETOOLS-348?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17883074#comment-17883074 ] ASF GitHub Bot commented on DOXIASITETOOLS-348: --- kwin commented on code in PR #173: URL: https://github.com/apache/maven-doxia-sitetools/pull/173#discussion_r1767328000 ## doxia-site-model/src/main/mdo/site.mdo: ## @@ -66,6 +66,15 @@ under the License. String merge + +
[jira] [Commented] (DOXIASITETOOLS-348) Extend site descriptor to enforce a parent
[ https://issues.apache.org/jira/browse/DOXIASITETOOLS-348?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17883073#comment-17883073 ] ASF GitHub Bot commented on DOXIASITETOOLS-348: --- kwin commented on code in PR #173: URL: https://github.com/apache/maven-doxia-sitetools/pull/173#discussion_r1767328000 ## doxia-site-model/src/main/mdo/site.mdo: ## @@ -66,6 +66,15 @@ under the License. String merge + +
[jira] [Commented] (DOXIASITETOOLS-348) Extend site descriptor to enforce a parent
[
https://issues.apache.org/jira/browse/DOXIASITETOOLS-348?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17883070#comment-17883070
]
ASF GitHub Bot commented on DOXIASITETOOLS-348:
---
kwin commented on code in PR #173:
URL:
https://github.com/apache/maven-doxia-sitetools/pull/173#discussion_r1767301384
##
doxia-site-model/src/main/mdo/site.mdo:
##
@@ -66,6 +66,15 @@ under the License.
String
merge
+
+
+ enforceParentDescriptor
Review Comment:
not sure this is really a good name, any other suggestion?
> Extend site descriptor to enforce a parent
> --
>
> Key: DOXIASITETOOLS-348
> URL: https://issues.apache.org/jira/browse/DOXIASITETOOLS-348
> Project: Maven Doxia Sitetools
> Issue Type: Improvement
> Components: Site model
>Affects Versions: 2.0.0-M19
>Reporter: Konrad Windszus
>Assignee: Konrad Windszus
>Priority: Major
>
> Currently the [site
> descriptor|https://maven.apache.org/doxia/doxia-sitetools/doxia-site-model/site.html]
> does not allow to enforce a parent {{site.xml}}.
> The attribute {{combine.self}} does not lead to a failure in case no parent
> {{site.xml}} can be found.
> This may easily lead to broken sites without breaking the site build as
> a) the site transparently inherits the {{site.xml}} attached to the parent
> POM.
> b) attaching the {{site.xml}} to a project is a manual step
> (https://maven.apache.org/plugins/maven-site-plugin/attach-descriptor-mojo.html)
> As at the time when the descriptor of the derived {{site.xml}} is created it
> is known whether the descriptor works standalone or requires a parent
> {{site.xml}}, therefore this should be made explicit in the site descriptor.
> I propose to add an additional attribute {{requireParent}} on the top level
> element which is {{false}} by default (current behaviour). If set to {{true}}
> it should lead to a build failure in case the parent {{site.xml}} cannot be
> resolved (for whatever reason).
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (DOXIASITETOOLS-348) Extend site descriptor to enforce a parent
[
https://issues.apache.org/jira/browse/DOXIASITETOOLS-348?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17883067#comment-17883067
]
ASF GitHub Bot commented on DOXIASITETOOLS-348:
---
kwin opened a new pull request, #173:
URL: https://github.com/apache/maven-doxia-sitetools/pull/173
(no comment)
> Extend site descriptor to enforce a parent
> --
>
> Key: DOXIASITETOOLS-348
> URL: https://issues.apache.org/jira/browse/DOXIASITETOOLS-348
> Project: Maven Doxia Sitetools
> Issue Type: Improvement
> Components: Site model
>Affects Versions: 2.0.0-M19
>Reporter: Konrad Windszus
>Assignee: Konrad Windszus
>Priority: Major
>
> Currently the [site
> descriptor|https://maven.apache.org/doxia/doxia-sitetools/doxia-site-model/site.html]
> does not allow to enforce a parent {{site.xml}}.
> The attribute {{combine.self}} does not lead to a failure in case no parent
> {{site.xml}} can be found.
> This may easily lead to broken sites without breaking the site build as
> a) the site transparently inherits the {{site.xml}} attached to the parent
> POM.
> b) attaching the {{site.xml}} to a project is a manual step
> (https://maven.apache.org/plugins/maven-site-plugin/attach-descriptor-mojo.html)
> As at the time when the descriptor of the derived {{site.xml}} is created it
> is known whether the descriptor works standalone or requires a parent
> {{site.xml}}, therefore this should be made explicit in the site descriptor.
> I propose to add an additional attribute {{requireParent}} on the top level
> element which is {{false}} by default (current behaviour). If set to {{true}}
> it should lead to a build failure in case the parent {{site.xml}} cannot be
> resolved (for whatever reason).
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (DOXIASITETOOLS-348) Extend site descriptor to enforce a parent
[
https://issues.apache.org/jira/browse/DOXIASITETOOLS-348?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17883069#comment-17883069
]
ASF GitHub Bot commented on DOXIASITETOOLS-348:
---
kwin commented on code in PR #173:
URL:
https://github.com/apache/maven-doxia-sitetools/pull/173#discussion_r1767301056
##
doxia-site-model/pom.xml:
##
@@ -84,7 +84,7 @@ under the License.
src/main/mdo/site.mdo
Extend site descriptor to enforce a parent
> --
>
> Key: DOXIASITETOOLS-348
> URL: https://issues.apache.org/jira/browse/DOXIASITETOOLS-348
> Project: Maven Doxia Sitetools
> Issue Type: Improvement
> Components: Site model
>Affects Versions: 2.0.0-M19
>Reporter: Konrad Windszus
>Assignee: Konrad Windszus
>Priority: Major
>
> Currently the [site
> descriptor|https://maven.apache.org/doxia/doxia-sitetools/doxia-site-model/site.html]
> does not allow to enforce a parent {{site.xml}}.
> The attribute {{combine.self}} does not lead to a failure in case no parent
> {{site.xml}} can be found.
> This may easily lead to broken sites without breaking the site build as
> a) the site transparently inherits the {{site.xml}} attached to the parent
> POM.
> b) attaching the {{site.xml}} to a project is a manual step
> (https://maven.apache.org/plugins/maven-site-plugin/attach-descriptor-mojo.html)
> As at the time when the descriptor of the derived {{site.xml}} is created it
> is known whether the descriptor works standalone or requires a parent
> {{site.xml}}, therefore this should be made explicit in the site descriptor.
> I propose to add an additional attribute {{requireParent}} on the top level
> element which is {{false}} by default (current behaviour). If set to {{true}}
> it should lead to a build failure in case the parent {{site.xml}} cannot be
> resolved (for whatever reason).
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MWRAPPER-150) Fails to validate checksums on MacOS Sequoia
[
https://issues.apache.org/jira/browse/MWRAPPER-150?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17883041#comment-17883041
]
ASF GitHub Bot commented on MWRAPPER-150:
-
jon-signal opened a new pull request, #155:
URL: https://github.com/apache/maven-wrapper/pull/155
The version of `sha256sum` that ships with macOS Sequoia appears to have a
bug where it does not read from stdin by default, even though its `man` page
says, in part (emphasis added):
> In all cases, each file listed on the command line is processed
separately. **If no files are listed on the command line**, or a file name is
given as -, input is taken from stdin instead.
…but invoking `sha256` as it appears in the `mvnw` script does not work as
expected:
```sh
❯ echo '3d8f20ce6103913be8b52aef6d994e0c54705fb527324ceb9b835b338739c7a8
/Users/jon/REDACTED/.mvn/wrapper/maven-wrapper.jar' | sha256sum -c
usage: sha256sum [-bctwz] [files ...]
```
…which in turns to a non-successful exit code, which in turn leads to a
(rather alarming!) warning about a mismatched checksums and possible compromise.
Adding a `-` explicitly calls for `sha256sum` to read from stdin.
To make clear that you license your contribution under
the [Apache License Version 2.0, January
2004](http://www.apache.org/licenses/LICENSE-2.0)
you have to acknowledge this by using the following check-box.
- [x] I hereby declare this contribution to be licenced under the [Apache
License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
- [ ] In any other case, please file an [Apache Individual Contributor
License Agreement](https://www.apache.org/licenses/icla.pdf).
> Fails to validate checksums on MacOS Sequoia
>
>
> Key: MWRAPPER-150
> URL: https://issues.apache.org/jira/browse/MWRAPPER-150
> Project: Maven Wrapper
> Issue Type: Bug
> Components: Maven Wrapper Scripts
>Affects Versions: 3.3.2
> Environment: MacOS 15.0
>Reporter: Gonzalo Bermúdez
>Priority: Normal
>
> The command issued to check the sha256sum fails with sha256sum packaged with
> MacOS Sequoia.
> This can be reproduced with an empty project using mvnw, and adding the
> distribution's shasum on the affected OS.
>
> {code:java}
> $ mkdir test && cd test
> $ mvn wrapper:wrapper
> $ echo
> distributionSha256Sum=83aaf914c785c9faed661f223000a92d1de9553f5c82d3b4362e66d9c031625f
> >> .mvn/wrapper/maven-wrapper.properties
> $ ./mvnw compile
> {code}
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (SUREFIRE-2226) Upgrade to Maven Verifier 2.0.0-M1
[ https://issues.apache.org/jira/browse/SUREFIRE-2226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17882999#comment-17882999 ] ASF GitHub Bot commented on SUREFIRE-2226: -- slawekjaranowski commented on PR #706: URL: https://github.com/apache/maven-surefire/pull/706#issuecomment-2360819329 @michael-o looks like done 😄 > Upgrade to Maven Verifier 2.0.0-M1 > -- > > Key: SUREFIRE-2226 > URL: https://issues.apache.org/jira/browse/SUREFIRE-2226 > Project: Maven Surefire > Issue Type: Dependency upgrade >Affects Versions: 3.2.3 >Reporter: Michael Osipov >Priority: Major > > This isn't just a dependency upgrade. Tasks to be done: > * Align import package name > * Replace usage of deprecated methods > * Make use consistently of CLI arguments which contains options, goals, > phases and user properties -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (DOXIASITETOOLS-349) Remove plexus-component-metadata plugin
[ https://issues.apache.org/jira/browse/DOXIASITETOOLS-349?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17882977#comment-17882977 ] ASF GitHub Bot commented on DOXIASITETOOLS-349: --- kwin opened a new pull request, #172: URL: https://github.com/apache/maven-doxia-sitetools/pull/172 The according annotations have been removed already with DOXIASITETOOLS-247. > Remove plexus-component-metadata plugin > --- > > Key: DOXIASITETOOLS-349 > URL: https://issues.apache.org/jira/browse/DOXIASITETOOLS-349 > Project: Maven Doxia Sitetools > Issue Type: Improvement >Reporter: Konrad Windszus >Assignee: Konrad Windszus >Priority: Major > > With DOXIASITETOOLS-247 Plexus annotations have been replaced by JSR-330 > ones. However the plexus-component-metadata-plugin is still executed > (although the annotations are no longer used). -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (DOXIA-740) Rendering Markdown silently truncates files that skip a heading level
[
https://issues.apache.org/jira/browse/DOXIA-740?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17882919#comment-17882919
]
ASF GitHub Bot commented on DOXIA-740:
--
kwin commented on code in PR #228:
URL: https://github.com/apache/maven-doxia/pull/228#discussion_r1766275985
##
doxia-core/src/main/java/org/apache/maven/doxia/macro/toc/TocMacro.java:
##
@@ -112,9 +113,13 @@ public void execute(Sink sink, MacroRequest request)
throws MacroExecutionExcept
tocSink.close();
}
-IndexEntry index = tocSink.getRootEntry();
+writeTocForIndexEntry(sink,
getAttributesFromMap(request.getParameters()), tocSink.getRootEntry());
+}
+
+void writeTocForIndexEntry(Sink sink, SinkEventAttributes listAttributes,
IndexEntry rootEntry) {
Review Comment:
Done now.
> Rendering Markdown silently truncates files that skip a heading level
> -
>
> Key: DOXIA-740
> URL: https://issues.apache.org/jira/browse/DOXIA-740
> Project: Maven Doxia
> Issue Type: Bug
> Components: Module - Markdown
>Reporter: John Dimeo
>Assignee: Konrad Windszus
>Priority: Major
>
> I am using a fork of the latest Doxia site tools because I am testing my
> performance fix, so it's possible this is related to my fork, but I don't
> _think_ so...
> If your Markdown skips a heading level i.e.
> {noformat}
> # Heading 1
> Text
> ### Heading 3
> Text 2{noformat}
> Then the rendered HTML only contains Heading 1 and Text. This is a major
> regression compared to past versions, so I must be missing something. Thank
> you.
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MWRAPPER-147) mvnw fails on Windows if user name contains whitespace
[
https://issues.apache.org/jira/browse/MWRAPPER-147?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17882784#comment-17882784
]
ASF GitHub Bot commented on MWRAPPER-147:
-
slawekjaranowski commented on PR #152:
URL: https://github.com/apache/maven-wrapper/pull/152#issuecomment-2359181184
I don't use windows so can not confirm ... but looks ok
> mvnw fails on Windows if user name contains whitespace
> --
>
> Key: MWRAPPER-147
> URL: https://issues.apache.org/jira/browse/MWRAPPER-147
> Project: Maven Wrapper
> Issue Type: Bug
> Components: Maven Wrapper Scripts
>Affects Versions: 3.3.2
>Reporter: Sebastian T
>Priority: Major
>
> Calling mvnw I get:
>
> {noformat}
> > mvnw
> 'C:\Users\John' is not recognized as an internal or external command,
> operable program or batch file.
> Cannot start maven from wrapper
> {noformat}
> The command fails at line:
> {noformat}
> @IF NOT "%__MVNW_CMD__%"=="" (%__MVNW_CMD__% %*)
> {noformat}
> For debugging I changed the mvnw.cmd file and printed out the value of
> %__MVNW_CMD__% which is:
> {noformat}
> C:\Users\John
> Doe/.m2/wrapper/dists/apache-maven-3.9.9/977a63e90f436cd6ade95b4c0e10c20c/bin/mvn.cmd
> {noformat}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MWRAPPER-147) mvnw fails on Windows if user name contains whitespace
[
https://issues.apache.org/jira/browse/MWRAPPER-147?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17882779#comment-17882779
]
ASF GitHub Bot commented on MWRAPPER-147:
-
sebthom commented on PR #152:
URL: https://github.com/apache/maven-wrapper/pull/152#issuecomment-2359116018
@slawekjaranowski can you please have a look?
> mvnw fails on Windows if user name contains whitespace
> --
>
> Key: MWRAPPER-147
> URL: https://issues.apache.org/jira/browse/MWRAPPER-147
> Project: Maven Wrapper
> Issue Type: Bug
> Components: Maven Wrapper Scripts
>Affects Versions: 3.3.2
>Reporter: Sebastian T
>Priority: Major
>
> Calling mvnw I get:
>
> {noformat}
> > mvnw
> 'C:\Users\John' is not recognized as an internal or external command,
> operable program or batch file.
> Cannot start maven from wrapper
> {noformat}
> The command fails at line:
> {noformat}
> @IF NOT "%__MVNW_CMD__%"=="" (%__MVNW_CMD__% %*)
> {noformat}
> For debugging I changed the mvnw.cmd file and printed out the value of
> %__MVNW_CMD__% which is:
> {noformat}
> C:\Users\John
> Doe/.m2/wrapper/dists/apache-maven-3.9.9/977a63e90f436cd6ade95b4c0e10c20c/bin/mvn.cmd
> {noformat}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (ARCHETYPE-655) Get rid of Wagon API to download catalogs
[
https://issues.apache.org/jira/browse/ARCHETYPE-655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17882761#comment-17882761
]
ASF GitHub Bot commented on ARCHETYPE-655:
--
slawekjaranowski merged PR #215:
URL: https://github.com/apache/maven-archetype/pull/215
> Get rid of Wagon API to download catalogs
> -
>
> Key: ARCHETYPE-655
> URL: https://issues.apache.org/jira/browse/ARCHETYPE-655
> Project: Maven Archetype
> Issue Type: Improvement
>Reporter: Konrad Windszus
>Assignee: Slawomir Jaranowski
>Priority: Major
> Fix For: 3.3.0
>
>
> Currently the {{RemoteCatalogArchetypeDataSource}} relies on Wagon API to
> download the catalog from a Maven repository
> ([https://github.com/apache/maven-archetype/blob/3a2b725198c3823fd5d7e9f88b665b2e4515a202/archetype-common/src/main/java/org/apache/maven/archetype/source/RemoteCatalogArchetypeDataSource.java#L127-L149]).
>
> Instead the Maven Resolver API should be used directly. At the same time some
> more flexibility with regards to repository ids would be beneficial (in order
> to support multiple custom catalogs or to reuse existing repository/server
> sections in the {{{}settings.xml{}}}). In the best case even merging catalog
> XMLs from multiple repos (with deduplication) should be supported.
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (SUREFIRE-2264) Limit usage of commons-io from surefire-shared-utils
[ https://issues.apache.org/jira/browse/SUREFIRE-2264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17882697#comment-17882697 ] ASF GitHub Bot commented on SUREFIRE-2264: -- slawekjaranowski merged PR #777: URL: https://github.com/apache/maven-surefire/pull/777 > Limit usage of commons-io from surefire-shared-utils > > > Key: SUREFIRE-2264 > URL: https://issues.apache.org/jira/browse/SUREFIRE-2264 > Project: Maven Surefire > Issue Type: Improvement >Reporter: Slawomir Jaranowski >Assignee: Slawomir Jaranowski >Priority: Major > Fix For: 3.5.1 > > > Only a few methods is used in production code, can be replaced by standard > jdk. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (ARCHETYPE-655) Get rid of Wagon API to download catalogs
[
https://issues.apache.org/jira/browse/ARCHETYPE-655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17882682#comment-17882682
]
ASF GitHub Bot commented on ARCHETYPE-655:
--
cstamas commented on PR #215:
URL: https://github.com/apache/maven-archetype/pull/215#issuecomment-2358193196
Don't get me wrong, I am _not -1 on this PR_, but anyone looking at the code
will raise eyebrows when look into how is remote catalog fetched :smile:
> Get rid of Wagon API to download catalogs
> -
>
> Key: ARCHETYPE-655
> URL: https://issues.apache.org/jira/browse/ARCHETYPE-655
> Project: Maven Archetype
> Issue Type: Improvement
>Reporter: Konrad Windszus
>Assignee: Slawomir Jaranowski
>Priority: Major
> Fix For: 3.3.0
>
>
> Currently the {{RemoteCatalogArchetypeDataSource}} relies on Wagon API to
> download the catalog from a Maven repository
> ([https://github.com/apache/maven-archetype/blob/3a2b725198c3823fd5d7e9f88b665b2e4515a202/archetype-common/src/main/java/org/apache/maven/archetype/source/RemoteCatalogArchetypeDataSource.java#L127-L149]).
>
> Instead the Maven Resolver API should be used directly. At the same time some
> more flexibility with regards to repository ids would be beneficial (in order
> to support multiple custom catalogs or to reuse existing repository/server
> sections in the {{{}settings.xml{}}}). In the best case even merging catalog
> XMLs from multiple repos (with deduplication) should be supported.
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (ARCHETYPE-655) Get rid of Wagon API to download catalogs
[
https://issues.apache.org/jira/browse/ARCHETYPE-655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17882678#comment-17882678
]
ASF GitHub Bot commented on ARCHETYPE-655:
--
cstamas commented on code in PR #215:
URL: https://github.com/apache/maven-archetype/pull/215#discussion_r1764863712
##
archetype-common/src/main/java/org/apache/maven/archetype/source/RemoteCatalogArchetypeDataSource.java:
##
@@ -77,303 +57,56 @@ public class RemoteCatalogArchetypeDataSource extends
CatalogArchetypeDataSource
public static final String CENTRAL_REPOSITORY_ID = "central";
@Override
-public ArchetypeCatalog getArchetypeCatalog(ProjectBuildingRequest
buildingRequest)
-throws ArchetypeDataSourceException {
-// With M3 artifactRepositories are already injected with their
mirror, including the new id
-// First look for mirrorId of both 'central' and 'archetype'
-final String archetypeRepoId;
-Mirror archetypeMirror = getMirror(ARCHETYPE_REPOSITORY_ID);
-if (archetypeMirror != null) {
-archetypeRepoId = archetypeMirror.getId();
-} else {
-archetypeRepoId = ARCHETYPE_REPOSITORY_ID;
-}
-
-final String centralRepoId;
-Mirror centralMirror = getMirror(CENTRAL_REPOSITORY_ID);
-if (centralMirror != null) {
-centralRepoId = centralMirror.getId();
-} else {
-centralRepoId = CENTRAL_REPOSITORY_ID;
-}
-
-ArtifactRepository centralRepository = null;
-ArtifactRepository archetypeRepository = null;
-for (ArtifactRepository remoteRepository :
buildingRequest.getRemoteRepositories()) {
-if (archetypeRepoId.equals(remoteRepository.getId())) {
-archetypeRepository = remoteRepository;
-break;
-} else if (centralRepoId.equals(remoteRepository.getId())) {
-centralRepository = remoteRepository;
-}
-}
-
-if (archetypeRepository == null) {
-archetypeRepository = centralRepository;
-}
-
-try {
-return downloadCatalog(archetypeRepository);
-} catch (IOException e) {
-throw new ArchetypeDataSourceException(e);
-} catch (WagonException e) {
-throw new ArchetypeDataSourceException(e);
-}
-}
-
-@Override
-public File updateCatalog(ProjectBuildingRequest buildingRequest,
Archetype archetype)
+public ArchetypeCatalog getArchetypeCatalog(
+RepositorySystemSession repositorySession, List
remoteRepositories)
throws ArchetypeDataSourceException {
-throw new ArchetypeDataSourceException("Not supported yet.");
-}
-
-private ArchetypeCatalog downloadCatalog(ArtifactRepository repository)
-throws WagonException, IOException, ArchetypeDataSourceException {
-getLogger().debug("Searching for remote catalog: " +
repository.getUrl() + "/" + ARCHETYPE_CATALOG_FILENAME);
-
-// We use wagon to take advantage of a Proxy that has already been
setup in a Maven environment.
-Repository wagonRepository = new Repository(repository.getId(),
repository.getUrl());
-
-AuthenticationInfo authInfo =
getAuthenticationInfo(wagonRepository.getId());
-ProxyInfo proxyInfo = getProxy(wagonRepository.getProtocol());
-
-Wagon wagon = getWagon(wagonRepository);
-
-File catalog = File.createTempFile("archetype-catalog", ".xml");
-try {
-wagon.connect(wagonRepository, authInfo, proxyInfo);
-wagon.get(ARCHETYPE_CATALOG_FILENAME, catalog);
-
-return readCatalog(ReaderFactory.newXmlReader(catalog));
-} finally {
-disconnectWagon(wagon);
-catalog.delete();
-}
-}
-
-private void disconnectWagon(Wagon wagon) {
-try {
-wagon.disconnect();
-} catch (Exception e) {
-getLogger().warn("Problem disconnecting from wagon - ignoring: " +
e.getMessage());
-}
-}
-
-//
-
-private Wagon getWagon(Repository repository) throws
UnsupportedProtocolException {
-return getWagon(repository.getProtocol());
-}
-
-private Wagon getWagon(String protocol) throws
UnsupportedProtocolException {
-if (protocol == null) {
-throw new UnsupportedProtocolException("Unspecified protocol");
-}
-
-String hint = protocol.toLowerCase(java.util.Locale.ENGLISH);
-
-Wagon wagon = wagons.get(hint);
-if (wagon == null) {
-throw new UnsupportedProtocolException(
-"Cannot find wagon which supports the requested protocol:
" + protocol);
-}
-
-return wagon;
-}
-
-private AuthenticationInfo getAuthenticationInfo(String id) {
-MavenSession session =
[jira] [Commented] (ARCHETYPE-655) Get rid of Wagon API to download catalogs
[
https://issues.apache.org/jira/browse/ARCHETYPE-655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17882664#comment-17882664
]
ASF GitHub Bot commented on ARCHETYPE-655:
--
slawekjaranowski commented on PR #215:
URL: https://github.com/apache/maven-archetype/pull/215#issuecomment-2358157875
@cstamas can you look?
> Get rid of Wagon API to download catalogs
> -
>
> Key: ARCHETYPE-655
> URL: https://issues.apache.org/jira/browse/ARCHETYPE-655
> Project: Maven Archetype
> Issue Type: Improvement
>Reporter: Konrad Windszus
>Assignee: Slawomir Jaranowski
>Priority: Major
> Fix For: 3.3.0
>
>
> Currently the {{RemoteCatalogArchetypeDataSource}} relies on Wagon API to
> download the catalog from a Maven repository
> ([https://github.com/apache/maven-archetype/blob/3a2b725198c3823fd5d7e9f88b665b2e4515a202/archetype-common/src/main/java/org/apache/maven/archetype/source/RemoteCatalogArchetypeDataSource.java#L127-L149]).
>
> Instead the Maven Resolver API should be used directly. At the same time some
> more flexibility with regards to repository ids would be beneficial (in order
> to support multiple custom catalogs or to reuse existing repository/server
> sections in the {{{}settings.xml{}}}). In the best case even merging catalog
> XMLs from multiple repos (with deduplication) should be supported.
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (SUREFIRE-2263) Use the latest version of surefire for self build
[ https://issues.apache.org/jira/browse/SUREFIRE-2263?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17882594#comment-17882594 ] ASF GitHub Bot commented on SUREFIRE-2263: -- slawekjaranowski merged PR #776: URL: https://github.com/apache/maven-surefire/pull/776 > Use the latest version of surefire for self build > - > > Key: SUREFIRE-2263 > URL: https://issues.apache.org/jira/browse/SUREFIRE-2263 > Project: Maven Surefire > Issue Type: Dependency upgrade >Reporter: Slawomir Jaranowski >Assignee: Slawomir Jaranowski >Priority: Major > Fix For: 3.5.1 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (SUREFIRE-2264) Drop commons-io from surefire-shared-utils
[ https://issues.apache.org/jira/browse/SUREFIRE-2264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17882516#comment-17882516 ] ASF GitHub Bot commented on SUREFIRE-2264: -- slawekjaranowski opened a new pull request, #777: URL: https://github.com/apache/maven-surefire/pull/777 https://issues.apache.org/jira/browse/SUREFIRE-2264 > Drop commons-io from surefire-shared-utils > -- > > Key: SUREFIRE-2264 > URL: https://issues.apache.org/jira/browse/SUREFIRE-2264 > Project: Maven Surefire > Issue Type: Improvement >Reporter: Slawomir Jaranowski >Assignee: Slawomir Jaranowski >Priority: Major > Fix For: 3.5.1 > > > Only a few methods is used in production code, can be replaced by standard > jdk. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (SUREFIRE-2252) Failsafe xml for a test class has results from another class
[
https://issues.apache.org/jira/browse/SUREFIRE-2252?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17882501#comment-17882501
]
ASF GitHub Bot commented on SUREFIRE-2252:
--
slawekjaranowski commented on code in PR #772:
URL: https://github.com/apache/maven-surefire/pull/772#discussion_r1763824318
##
surefire-providers/surefire-junit-platform/src/main/java/org/apache/maven/surefire/junitplatform/JUnitPlatformProvider.java:
##
@@ -172,25 +171,13 @@ private void invokeAllTests(TestsToRun testsToRun,
RunListenerAdapter adapter) {
}
private void execute(TestsToRun testsToRun, RunListenerAdapter adapter) {
-if (testsToRun.allowEagerReading()) {
-List selectors = new ArrayList<>();
-testsToRun.iterator().forEachRemaining(c ->
selectors.add(selectClass(c.getName(;
-
+testsToRun.iterator().forEachRemaining(c -> {
LauncherDiscoveryRequestBuilder builder = request()
.filters(filters)
.configurationParameters(configurationParameters)
-.selectors(selectors);
-
+.selectors(selectClass(c.getName()));
launcher.execute(builder.build(), adapter);
-} else {
Review Comment:
With this change I see in logs:
```
[INFO] Running pkg.domain.BxTest
[INFO] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.014
s
> Failsafe xml for a test class has results from another class
>
>
> Key: SUREFIRE-2252
> URL: https://issues.apache.org/jira/browse/SUREFIRE-2252
> Project: Maven Surefire
> Issue Type: Bug
> Components: Maven Failsafe Plugin
>Affects Versions: 3.2.5, 3.3.1
> Environment: Maven/JUnit5/Mac
>Reporter: Arvind Joshi
>Priority: Blocker
> Attachments: ClassAIT.java, ClassBIT.java,
> TEST-org.example.ClassAIT.xml, TEST-org.example.ClassBIT.xml, pom.xml
>
>
> *Issue*
> When I execute tests concurrently (at class level), I see the failsafe xmls
> being generated, but the test methods themselves seem to be mixed up with
> other classes.
> *Expectation*
> Each failsafe xml is unique to a class, which was the case with the JUnit4
> provider.
> *Versions*
> maven failsafe plugin 3.2.5 or 3.3.1
> JUnit 5.10.2
> *Sample code and Test results*
> Please see attached files
> *Running the tests attached*
>
> {noformat}
> mvn clean verify -Pparallel-tests{noformat}
>
>
> {noformat}
> [INFO] ---
> [INFO] T E S T S
> [INFO] ---
> [INFO] Running org.example.ClassBIT
> [INFO] Running org.example.ClassAIT
> [INFO] Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.026
> s – in org.example.ClassAIT
> [INFO] Tests run: 0, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.026
> s – in org.example.ClassBIT
> [INFO]
> [INFO] Results:
> [INFO]
> [INFO] Tests run: 2, Failures: 0, Errors: 0, Skipped: 0{noformat}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (DOXIA-740) Rendering Markdown silently truncates files that skip a heading level
[
https://issues.apache.org/jira/browse/DOXIA-740?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17882498#comment-17882498
]
ASF GitHub Bot commented on DOXIA-740:
--
kwin commented on code in PR #228:
URL: https://github.com/apache/maven-doxia/pull/228#discussion_r1763757207
##
doxia-core/src/main/java/org/apache/maven/doxia/macro/toc/TocMacro.java:
##
@@ -112,9 +113,13 @@ public void execute(Sink sink, MacroRequest request)
throws MacroExecutionExcept
tocSink.close();
}
-IndexEntry index = tocSink.getRootEntry();
+writeTocForIndexEntry(sink,
getAttributesFromMap(request.getParameters()), tocSink.getRootEntry());
+}
+
+void writeTocForIndexEntry(Sink sink, SinkEventAttributes listAttributes,
IndexEntry rootEntry) {
Review Comment:
This still needs some work to
a) only consider entries for type section
b) skip empty entries (not having an id)
> Rendering Markdown silently truncates files that skip a heading level
> -
>
> Key: DOXIA-740
> URL: https://issues.apache.org/jira/browse/DOXIA-740
> Project: Maven Doxia
> Issue Type: Bug
> Components: Module - Markdown
>Reporter: John Dimeo
>Assignee: Konrad Windszus
>Priority: Major
>
> I am using a fork of the latest Doxia site tools because I am testing my
> performance fix, so it's possible this is related to my fork, but I don't
> _think_ so...
> If your Markdown skips a heading level i.e.
> {noformat}
> # Heading 1
> Text
> ### Heading 3
> Text 2{noformat}
> Then the rendered HTML only contains Heading 1 and Text. This is a major
> regression compared to past versions, so I must be missing something. Thank
> you.
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (DOXIA-740) Rendering Markdown silently truncates files that skip a heading level
[
https://issues.apache.org/jira/browse/DOXIA-740?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17882499#comment-17882499
]
ASF GitHub Bot commented on DOXIA-740:
--
kwin commented on PR #228:
URL: https://github.com/apache/maven-doxia/pull/228#issuecomment-2356689358
@michael-o Feel free to already have a look, although this need to consider
some more edge cases (see comments inline).
> Rendering Markdown silently truncates files that skip a heading level
> -
>
> Key: DOXIA-740
> URL: https://issues.apache.org/jira/browse/DOXIA-740
> Project: Maven Doxia
> Issue Type: Bug
> Components: Module - Markdown
>Reporter: John Dimeo
>Assignee: Konrad Windszus
>Priority: Major
>
> I am using a fork of the latest Doxia site tools because I am testing my
> performance fix, so it's possible this is related to my fork, but I don't
> _think_ so...
> If your Markdown skips a heading level i.e.
> {noformat}
> # Heading 1
> Text
> ### Heading 3
> Text 2{noformat}
> Then the rendered HTML only contains Heading 1 and Text. This is a major
> regression compared to past versions, so I must be missing something. Thank
> you.
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (SUREFIRE-2263) Use the latest version of surefire for self build
[ https://issues.apache.org/jira/browse/SUREFIRE-2263?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17882490#comment-17882490 ] ASF GitHub Bot commented on SUREFIRE-2263: -- slawekjaranowski opened a new pull request, #776: URL: https://github.com/apache/maven-surefire/pull/776 https://issues.apache.org/jira/browse/SUREFIRE-2263 > Use the latest version of surefire for self build > - > > Key: SUREFIRE-2263 > URL: https://issues.apache.org/jira/browse/SUREFIRE-2263 > Project: Maven Surefire > Issue Type: Dependency upgrade >Reporter: Slawomir Jaranowski >Assignee: Slawomir Jaranowski >Priority: Major > Fix For: 3.5.1 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (SUREFIRE-2262) Bump org.apache.commons:commons-lang3 from 3.16.0 to 3.17.0
[ https://issues.apache.org/jira/browse/SUREFIRE-2262?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17882435#comment-17882435 ] ASF GitHub Bot commented on SUREFIRE-2262: -- slawekjaranowski merged PR #775: URL: https://github.com/apache/maven-surefire/pull/775 > Bump org.apache.commons:commons-lang3 from 3.16.0 to 3.17.0 > --- > > Key: SUREFIRE-2262 > URL: https://issues.apache.org/jira/browse/SUREFIRE-2262 > Project: Maven Surefire > Issue Type: Dependency upgrade >Reporter: Slawomir Jaranowski >Assignee: Slawomir Jaranowski >Priority: Major > Fix For: 3.5.1 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (DOXIA-740) Rendering Markdown silently truncates files that skip a heading level
[
https://issues.apache.org/jira/browse/DOXIA-740?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17882430#comment-17882430
]
ASF GitHub Bot commented on DOXIA-740:
--
kwin opened a new pull request, #228:
URL: https://github.com/apache/maven-doxia/pull/228
output
> Rendering Markdown silently truncates files that skip a heading level
> -
>
> Key: DOXIA-740
> URL: https://issues.apache.org/jira/browse/DOXIA-740
> Project: Maven Doxia
> Issue Type: Bug
> Components: Module - Markdown
>Reporter: John Dimeo
>Assignee: Konrad Windszus
>Priority: Major
>
> I am using a fork of the latest Doxia site tools because I am testing my
> performance fix, so it's possible this is related to my fork, but I don't
> _think_ so...
> If your Markdown skips a heading level i.e.
> {noformat}
> # Heading 1
> Text
> ### Heading 3
> Text 2{noformat}
> Then the rendered HTML only contains Heading 1 and Text. This is a major
> regression compared to past versions, so I must be missing something. Thank
> you.
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (ARCHETYPE-649) "[WARNING] CP Don't override file" when generating archetype with 3.2.1
[
https://issues.apache.org/jira/browse/ARCHETYPE-649?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17882184#comment-17882184
]
ASF GitHub Bot commented on ARCHETYPE-649:
--
WolfgangHG commented on PR #160:
URL: https://github.com/apache/maven-archetype/pull/160#issuecomment-2353869607
I hope you guys have a better solution for this, I know that this pull
request is no good ;-).
The original issue might also be a problem in my own archetype, but I have
no idea what could be improved.
> "[WARNING] CP Don't override file" when generating archetype with 3.2.1
> ---
>
> Key: ARCHETYPE-649
> URL: https://issues.apache.org/jira/browse/ARCHETYPE-649
> Project: Maven Archetype
> Issue Type: Bug
> Components: Creator
>Affects Versions: 3.2.1
>Reporter: Wolfgang Knauf
>Priority: Major
> Attachments: archetype-metadata.xml,
> wildfly-jakartaee-ear-archetype-30.0.0.Final-SNAPSHOT_312.jar,
> wildfly-jakartaee-ear-archetype-30.0.0.Final-SNAPSHOT_321.jar,
> wildfly-jakartaee-ear-archetype_ARCHETYPE-649.zip
>
>
> I do some maintenance work on the "wildfly-jakartaee-ear-archetype". After
> updating "maven-archetype-plugin" to 3.2.1, there are two warnings printed
> when creating a project from the archetype.
> {quote}{{[WARNING] Don't override file
> ...\multi\project\multi\web\src\test\java\foo\bar\multi}}
> {{[WARNING] CP Don't override file
> ...\multi\project\multi\web\src\main\webapp}}{quote}
>
> I think the problem depends on the archetype-plugin version that creates the
> archetype JAR. Attached are the jar files from my local repository. One is
> created with archetype-plugin 3.1.2, the other with 3.2.1.
> [^wildfly-jakartaee-ear-archetype-30.0.0.Final-SNAPSHOT_321.jar]
> [^wildfly-jakartaee-ear-archetype-30.0.0.Final-SNAPSHOT_312.jar]
> Note the size difference of the two jar files.
> When creating a project from the archetype, the message appears with both
> 3.1.2 and 3.2.1, if the archetype jar was created with 3.2.1. It does not
> appear when the archetype jar was created with the 3.1.2 plugin.
>
> Debug logging during generating of the project from the archetype seems to
> point me to the reason: with 3.2.1, the jar file contains a lot of entries
> for the directories. With 3.1.2, there are only entries for "real" files.
> This seems to cause duplicates with the fileSets in "archetype-metadata.xml"
>
> Here is the log when the archetype jar was created with 3.1.2:
>
> {{[DEBUG] getFilesetArchetypeResources(
> "C:\Users\USERNAME\.m2\repository\org\wildfly\archetype\wildfly-jakartaee-ear-archetype\30.0.0.Final-SNAPSHOT\wildfly-jakartaee-ear-archetype-30.0.0.Final-SNAPSHOT.jar"
> )}}
> {{[DEBUG] - found resource (archetype-resources/)ear/pom.xml}}
> {{[DEBUG] - found resource (archetype-resources/)ejb/pom.xml}}
> {{[DEBUG] - found resource
> (archetype-resources/)ejb/src/main/resources/META-INF/persistence.xml}}
> {{[DEBUG] - found resource
> (archetype-resources/)ejb/src/test/resources/arquillian.xml}}
> {{[DEBUG] - found resource (archetype-resources/)pom.xml}}
> {{[DEBUG] - found resource (archetype-resources/)README.txt}}
> {{[DEBUG] - found resource (archetype-resources/)web/pom.xml}}
> {{[DEBUG] - found resource
> (archetype-resources/)web/src/main/webapp/WEB-INF/beans.xml}}
> {{[DEBUG] - found resource
> (archetype-resources/)web/src/main/webapp/WEB-INF/faces-config.xml}}
> {{[DEBUG] - found resource
> (archetype-resources/)web/src/test/java/test/SampleIT.java}}
> {{[DEBUG] - found resource
> (archetype-resources/)web/src/test/resources/arquillian.xml}}
> {{[DEBUG] - ignored resource META-INF/maven/archetype-metadata.xml}}
> {{[DEBUG] Processing complete archetype
> wildfly-jakartaee-webapp-ear-archetype}}
>
> And this is the output for an archetype created with 3.2.1:
>
> {{[DEBUG] getFilesetArchetypeResources(
> "C:\Users\USERNAME\.m2\repository\org\wildfly\archetype\wildfly-jakartaee-ear-archetype\30.0.0.Final-SNAPSHOT\wildfly-jakartaee-ear-archetype-30.0.0.Final-SNAPSHOT.jar"
> )}}
> {{[DEBUG] - ignored resource META-INF/MANIFEST.MF}}
> {{[DEBUG] - ignored resource META-INF/}}
> {{[DEBUG] - found resource (archetype-resources/)}}
> {{[DEBUG] - found resource (archetype-resources/)ear/}}
> {{[DEBUG] - found resource (archetype-resources/)ejb/}}
> {{[DEBUG] - found resource (archetype-resources/)ejb/src/}}
> {{[DEBUG] - found resource (archetype-resources/)ejb/src/main/}}
> {{[DEBUG] - found resource (archetype-resources/)ejb/src/main/resources/}}
> {{[DEBUG] - found resource
> (archetype-resources/)ejb/src/main/resources/META-INF/}}
> {{[DEBUG] - found resource (archetype-resources/)ejb/src/test/}}
> {{[DEBUG] - found resource (archetype-resources/)ej
[jira] [Commented] (ARCHETYPE-677) Upgrade versions of archetypes in internal catalog
[ https://issues.apache.org/jira/browse/ARCHETYPE-677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17881811#comment-17881811 ] ASF GitHub Bot commented on ARCHETYPE-677: -- slawekjaranowski merged PR #217: URL: https://github.com/apache/maven-archetype/pull/217 > Upgrade versions of archetypes in internal catalog > -- > > Key: ARCHETYPE-677 > URL: https://issues.apache.org/jira/browse/ARCHETYPE-677 > Project: Maven Archetype > Issue Type: Dependency upgrade >Reporter: Slawomir Jaranowski >Assignee: Slawomir Jaranowski >Priority: Major > Fix For: 3.3.0 > > > https://github.com/apache/maven-archetype/commits/master/archetype-common/src/main/resources/archetype-catalog.xml -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (ARCHETYPE-649) "[WARNING] CP Don't override file" when generating archetype with 3.2.1
[
https://issues.apache.org/jira/browse/ARCHETYPE-649?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17881782#comment-17881782
]
ASF GitHub Bot commented on ARCHETYPE-649:
--
slawekjaranowski commented on PR #160:
URL: https://github.com/apache/maven-archetype/pull/160#issuecomment-2350987352
I think this PR will break feature like
https://issues.apache.org/jira/browse/ARCHETYPE-289
> "[WARNING] CP Don't override file" when generating archetype with 3.2.1
> ---
>
> Key: ARCHETYPE-649
> URL: https://issues.apache.org/jira/browse/ARCHETYPE-649
> Project: Maven Archetype
> Issue Type: Bug
> Components: Creator
>Affects Versions: 3.2.1
>Reporter: Wolfgang Knauf
>Priority: Major
> Attachments: archetype-metadata.xml,
> wildfly-jakartaee-ear-archetype-30.0.0.Final-SNAPSHOT_312.jar,
> wildfly-jakartaee-ear-archetype-30.0.0.Final-SNAPSHOT_321.jar,
> wildfly-jakartaee-ear-archetype_ARCHETYPE-649.zip
>
>
> I do some maintenance work on the "wildfly-jakartaee-ear-archetype". After
> updating "maven-archetype-plugin" to 3.2.1, there are two warnings printed
> when creating a project from the archetype.
> {quote}{{[WARNING] Don't override file
> ...\multi\project\multi\web\src\test\java\foo\bar\multi}}
> {{[WARNING] CP Don't override file
> ...\multi\project\multi\web\src\main\webapp}}{quote}
>
> I think the problem depends on the archetype-plugin version that creates the
> archetype JAR. Attached are the jar files from my local repository. One is
> created with archetype-plugin 3.1.2, the other with 3.2.1.
> [^wildfly-jakartaee-ear-archetype-30.0.0.Final-SNAPSHOT_321.jar]
> [^wildfly-jakartaee-ear-archetype-30.0.0.Final-SNAPSHOT_312.jar]
> Note the size difference of the two jar files.
> When creating a project from the archetype, the message appears with both
> 3.1.2 and 3.2.1, if the archetype jar was created with 3.2.1. It does not
> appear when the archetype jar was created with the 3.1.2 plugin.
>
> Debug logging during generating of the project from the archetype seems to
> point me to the reason: with 3.2.1, the jar file contains a lot of entries
> for the directories. With 3.1.2, there are only entries for "real" files.
> This seems to cause duplicates with the fileSets in "archetype-metadata.xml"
>
> Here is the log when the archetype jar was created with 3.1.2:
>
> {{[DEBUG] getFilesetArchetypeResources(
> "C:\Users\USERNAME\.m2\repository\org\wildfly\archetype\wildfly-jakartaee-ear-archetype\30.0.0.Final-SNAPSHOT\wildfly-jakartaee-ear-archetype-30.0.0.Final-SNAPSHOT.jar"
> )}}
> {{[DEBUG] - found resource (archetype-resources/)ear/pom.xml}}
> {{[DEBUG] - found resource (archetype-resources/)ejb/pom.xml}}
> {{[DEBUG] - found resource
> (archetype-resources/)ejb/src/main/resources/META-INF/persistence.xml}}
> {{[DEBUG] - found resource
> (archetype-resources/)ejb/src/test/resources/arquillian.xml}}
> {{[DEBUG] - found resource (archetype-resources/)pom.xml}}
> {{[DEBUG] - found resource (archetype-resources/)README.txt}}
> {{[DEBUG] - found resource (archetype-resources/)web/pom.xml}}
> {{[DEBUG] - found resource
> (archetype-resources/)web/src/main/webapp/WEB-INF/beans.xml}}
> {{[DEBUG] - found resource
> (archetype-resources/)web/src/main/webapp/WEB-INF/faces-config.xml}}
> {{[DEBUG] - found resource
> (archetype-resources/)web/src/test/java/test/SampleIT.java}}
> {{[DEBUG] - found resource
> (archetype-resources/)web/src/test/resources/arquillian.xml}}
> {{[DEBUG] - ignored resource META-INF/maven/archetype-metadata.xml}}
> {{[DEBUG] Processing complete archetype
> wildfly-jakartaee-webapp-ear-archetype}}
>
> And this is the output for an archetype created with 3.2.1:
>
> {{[DEBUG] getFilesetArchetypeResources(
> "C:\Users\USERNAME\.m2\repository\org\wildfly\archetype\wildfly-jakartaee-ear-archetype\30.0.0.Final-SNAPSHOT\wildfly-jakartaee-ear-archetype-30.0.0.Final-SNAPSHOT.jar"
> )}}
> {{[DEBUG] - ignored resource META-INF/MANIFEST.MF}}
> {{[DEBUG] - ignored resource META-INF/}}
> {{[DEBUG] - found resource (archetype-resources/)}}
> {{[DEBUG] - found resource (archetype-resources/)ear/}}
> {{[DEBUG] - found resource (archetype-resources/)ejb/}}
> {{[DEBUG] - found resource (archetype-resources/)ejb/src/}}
> {{[DEBUG] - found resource (archetype-resources/)ejb/src/main/}}
> {{[DEBUG] - found resource (archetype-resources/)ejb/src/main/resources/}}
> {{[DEBUG] - found resource
> (archetype-resources/)ejb/src/main/resources/META-INF/}}
> {{[DEBUG] - found resource (archetype-resources/)ejb/src/test/}}
> {{[DEBUG] - found resource (archetype-resources/)ejb/src/test/resources/}}
> {{[DEBUG] - found resource (archetype-resources/)web/}}
> {{[DEBUG] - found resourc
[jira] [Commented] (ARCHETYPE-661) Refresh download page
[ https://issues.apache.org/jira/browse/ARCHETYPE-661?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17881781#comment-17881781 ] ASF GitHub Bot commented on ARCHETYPE-661: -- slawekjaranowski merged PR #216: URL: https://github.com/apache/maven-archetype/pull/216 > Refresh download page > - > > Key: ARCHETYPE-661 > URL: https://issues.apache.org/jira/browse/ARCHETYPE-661 > Project: Maven Archetype > Issue Type: Task >Reporter: Slawomir Jaranowski >Assignee: Slawomir Jaranowski >Priority: Major > Labels: up-for-grabs > Fix For: 3.3.0 > > > Old download page contains information about mirrors, which is not actual > today. > Some of links are also broken. > Download page should be updated like in: > https://issues.apache.org/jira/browse/MCLEAN-114 > https://issues.apache.org/jira/browse/MSHARED-1389 > We can copy src/site/xdoc/download.xml.vm from exaple changes according to > project type, plugin or shared. > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (ARCHETYPE-632) Add logging conflict line in integration-test
[
https://issues.apache.org/jira/browse/ARCHETYPE-632?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17881772#comment-17881772
]
ASF GitHub Bot commented on ARCHETYPE-632:
--
slawekjaranowski merged PR #114:
URL: https://github.com/apache/maven-archetype/pull/114
> Add logging conflict line in integration-test
> -
>
> Key: ARCHETYPE-632
> URL: https://issues.apache.org/jira/browse/ARCHETYPE-632
> Project: Maven Archetype
> Issue Type: Improvement
> Components: Plugin
>Affects Versions: 3.2.1
>Reporter: Toshiya Kobayashi
>Assignee: Slawomir Jaranowski
>Priority: Major
> Fix For: 3.3.0
>
>
> In maven-archetype-plugin integration-test phase, if a generated file is not
> equal to a reference file, WARNING is raised
> {noformat}
> [WARNING] Contents of file src/test/java/it/pkg/RuleTest.java are not equal
> {noformat}
> But sometimes it's hard to locate where the conflict line is.
> This JIRA is to log more information like:
> {noformat}
> [WARNING] Conflict found. Reference line :
> [WARNING] private static final Logger LOG =
> LoggerFactory.getLogger(RuleTest.class);
> [WARNING] Actual line :
> [WARNING] static final Logger LOG =
> LoggerFactory.getLogger(RuleTest.class);
> [WARNING] Contents of file src/test/java/it/pkg/RuleTest.java are not equal
> {noformat}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (ARCHETYPE-677) Upgrade versions of archetypes in internal catalog
[ https://issues.apache.org/jira/browse/ARCHETYPE-677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17881770#comment-17881770 ] ASF GitHub Bot commented on ARCHETYPE-677: -- slawekjaranowski opened a new pull request, #217: URL: https://github.com/apache/maven-archetype/pull/217 (no comment) > Upgrade versions of archetypes in internal catalog > -- > > Key: ARCHETYPE-677 > URL: https://issues.apache.org/jira/browse/ARCHETYPE-677 > Project: Maven Archetype > Issue Type: Dependency upgrade >Reporter: Slawomir Jaranowski >Assignee: Slawomir Jaranowski >Priority: Major > Fix For: 3.3.0 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (ARCHETYPE-661) Refresh download page
[ https://issues.apache.org/jira/browse/ARCHETYPE-661?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17881767#comment-17881767 ] ASF GitHub Bot commented on ARCHETYPE-661: -- slawekjaranowski opened a new pull request, #216: URL: https://github.com/apache/maven-archetype/pull/216 (no comment) > Refresh download page > - > > Key: ARCHETYPE-661 > URL: https://issues.apache.org/jira/browse/ARCHETYPE-661 > Project: Maven Archetype > Issue Type: Task >Reporter: Slawomir Jaranowski >Priority: Major > Labels: up-for-grabs > Fix For: 3.3.0 > > > Old download page contains information about mirrors, which is not actual > today. > Some of links are also broken. > Download page should be updated like in: > https://issues.apache.org/jira/browse/MCLEAN-114 > https://issues.apache.org/jira/browse/MSHARED-1389 > We can copy src/site/xdoc/download.xml.vm from exaple changes according to > project type, plugin or shared. > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (ARCHETYPE-655) Get rid of Wagon API to download catalogs
[
https://issues.apache.org/jira/browse/ARCHETYPE-655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17881652#comment-17881652
]
ASF GitHub Bot commented on ARCHETYPE-655:
--
slawekjaranowski opened a new pull request, #215:
URL: https://github.com/apache/maven-archetype/pull/215
https://issues.apache.org/jira/browse/ARCHETYPE-655
> Get rid of Wagon API to download catalogs
> -
>
> Key: ARCHETYPE-655
> URL: https://issues.apache.org/jira/browse/ARCHETYPE-655
> Project: Maven Archetype
> Issue Type: Improvement
>Reporter: Konrad Windszus
>Assignee: Slawomir Jaranowski
>Priority: Major
> Fix For: 3.3.0
>
>
> Currently the {{RemoteCatalogArchetypeDataSource}} relies on Wagon API to
> download the catalog from a Maven repository
> ([https://github.com/apache/maven-archetype/blob/3a2b725198c3823fd5d7e9f88b665b2e4515a202/archetype-common/src/main/java/org/apache/maven/archetype/source/RemoteCatalogArchetypeDataSource.java#L127-L149]).
>
> Instead the Maven Resolver API should be used directly. At the same time some
> more flexibility with regards to repository ids would be beneficial (in order
> to support multiple custom catalogs or to reuse existing repository/server
> sections in the {{{}settings.xml{}}}). In the best case even merging catalog
> XMLs from multiple repos (with deduplication) should be supported.
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
