[jira] (MCHANGES-304) Include an HTML announcement template
Alex Halovanic created MCHANGES-304: --- Summary: Include an HTML announcement template Key: MCHANGES-304 URL: https://jira.codehaus.org/browse/MCHANGES-304 Project: Maven 2.x Changes Plugin Issue Type: Improvement Components: announcement Reporter: Alex Halovanic Priority: Trivial Attachments: announcement_html.vm I'm pretty sure this has been brought up before, but is there interest in including an HTML version of the announcement email velocity template as an alternative to the default plaintext one? I've attached the one I've been using for a year or two here. It's my best attempt to emulate the appearance of the project report page with velocity. For others like me, it would eliminate having to unpack another dependency to make the email look more like the report page. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://jira.codehaus.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] (MEAR-146) Expose parameter to not write library-directory element in application.xml
[ https://jira.codehaus.org/browse/MEAR-146?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=307269#comment-307269 ] Alex Halovanic commented on MEAR-146: - Works like a charm, thanks! Expose parameter to not write library-directory element in application.xml -- Key: MEAR-146 URL: https://jira.codehaus.org/browse/MEAR-146 Project: Maven 2.x Ear Plugin Issue Type: Improvement Affects Versions: 2.7 Environment: Oracle WebLogic Reporter: Alex Halovanic Assignee: Stéphane Nicoll Priority: Minor Fix For: 2.8 Attachments: ear-general-librarydirectory.patch, ear-remove-librarydirectory-IT.patch, ear-remove-librarydirectory-IT.patch, ear-remove-librarydirectory.patch, ear-remove-librarydirectory.patch The current handling of defaultLibBundleDir leads to some issues on Oracle Weblogic 10+. The Ear plugin currently sets library-directory to the value of defaultLibBundleDir in the application.xml for EARs v5+. Some of Oracle's classloading features break (specifically Generic File Loading) when this element is set. defaultLibBundleDir has to be set to APP-INF/lib since this is the magic library folder for WebLogic. The patch adds a parameter to prevent setting library-directory for cases like this. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://jira.codehaus.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] (MEAR-146) Expose parameter to not write library-directory element in application.xml
[ https://jira.codehaus.org/browse/MEAR-146?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alex Halovanic updated MEAR-146: Attachment: ear-general-librarydirectory.patch Patch to try to cover all library-directory scenarios from this and MEAR-151. Expose parameter to not write library-directory element in application.xml -- Key: MEAR-146 URL: https://jira.codehaus.org/browse/MEAR-146 Project: Maven 2.x Ear Plugin Issue Type: Improvement Affects Versions: 2.7 Environment: Oracle WebLogic Reporter: Alex Halovanic Priority: Minor Fix For: 2.8 Attachments: ear-general-librarydirectory.patch, ear-remove-librarydirectory-IT.patch, ear-remove-librarydirectory-IT.patch, ear-remove-librarydirectory.patch, ear-remove-librarydirectory.patch The current handling of defaultLibBundleDir leads to some issues on Oracle Weblogic 10+. The Ear plugin currently sets library-directory to the value of defaultLibBundleDir in the application.xml for EARs v5+. Some of Oracle's classloading features break (specifically Generic File Loading) when this element is set. defaultLibBundleDir has to be set to APP-INF/lib since this is the magic library folder for WebLogic. The patch adds a parameter to prevent setting library-directory for cases like this. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://jira.codehaus.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] (MEAR-146) Expose parameter to not write library-directory element in application.xml
[ https://jira.codehaus.org/browse/MEAR-146?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=307120#comment-307120 ] Alex Halovanic commented on MEAR-146: - I don't want to make this any more confusing, but I've now uploaded a patch with a general string parameter to cover any possible required scenarios for library-directory, rather than having to do this in 2 or more boolean parameters. This defaults to the existing behavior of writing the same value as defaultLibBundleDir, should that be set. It can also be overriden to cover the empty string of MEAR-151, the not set of MEAR-146, and the as-yet hypothetical scenario where it has to be some other value. The use of special magic values is necessary because Mojo parameters unfortunately combine the empty, null and default scenarios for strings. Hopefully it's relatively clear in the generated site doc. Expose parameter to not write library-directory element in application.xml -- Key: MEAR-146 URL: https://jira.codehaus.org/browse/MEAR-146 Project: Maven 2.x Ear Plugin Issue Type: Improvement Affects Versions: 2.7 Environment: Oracle WebLogic Reporter: Alex Halovanic Priority: Minor Fix For: 2.8 Attachments: ear-general-librarydirectory.patch, ear-remove-librarydirectory-IT.patch, ear-remove-librarydirectory-IT.patch, ear-remove-librarydirectory.patch, ear-remove-librarydirectory.patch The current handling of defaultLibBundleDir leads to some issues on Oracle Weblogic 10+. The Ear plugin currently sets library-directory to the value of defaultLibBundleDir in the application.xml for EARs v5+. Some of Oracle's classloading features break (specifically Generic File Loading) when this element is set. defaultLibBundleDir has to be set to APP-INF/lib since this is the magic library folder for WebLogic. The patch adds a parameter to prevent setting library-directory for cases like this. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://jira.codehaus.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] (MEAR-146) Expose parameter to not write library-directory element in application.xml
[ https://jira.codehaus.org/browse/MEAR-146?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=306325#comment-306325 ] Alex Halovanic commented on MEAR-146: - I checked that empty library directory works for my use case with WebLogic too. But only in a way that worries me that these two scenarios don't entirely match up. Remember that /APP-INF/lib is the older WebLogic-specific magic library classpath and /lib is supposed to be the standardized location since EAR v5. These are the three scenarios defined according to the Sun XSD: # Element not present - search in /lib ## WebLogic searches /lib and in /APP-INF/lib and some other special external directories (exploded EARs, generic file overrides, etc.) # Element empty - disable searching ## WebLogic still searches in /APP-INF/lib and the external directories, but fails to search /lib. # Element defined - search in given directory ## WebLogic exclusively searches in this directory and ignores all others. So I think in Sean and my cases an empty element works, but *only* so long as we stick to the WebLogic specific APP-INF/lib defaultLibBundleDir. Expose parameter to not write library-directory element in application.xml -- Key: MEAR-146 URL: https://jira.codehaus.org/browse/MEAR-146 Project: Maven 2.x Ear Plugin Issue Type: Improvement Affects Versions: 2.7 Environment: Oracle WebLogic Reporter: Alex Halovanic Priority: Minor Fix For: 2.8 Attachments: ear-remove-librarydirectory-IT.patch, ear-remove-librarydirectory-IT.patch, ear-remove-librarydirectory.patch, ear-remove-librarydirectory.patch The current handling of defaultLibBundleDir leads to some issues on Oracle Weblogic 10+. The Ear plugin currently sets library-directory to the value of defaultLibBundleDir in the application.xml for EARs v5+. Some of Oracle's classloading features break (specifically Generic File Loading) when this element is set. defaultLibBundleDir has to be set to APP-INF/lib since this is the magic library folder for WebLogic. The patch adds a parameter to prevent setting library-directory for cases like this. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://jira.codehaus.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] (MEAR-146) Expose parameter to not write library-directory element in application.xml
[ https://jira.codehaus.org/browse/MEAR-146?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alex Halovanic updated MEAR-146: Attachment: ear-remove-librarydirectory-IT.patch ear-remove-librarydirectory.patch Updated to be inside webLogic section Expose parameter to not write library-directory element in application.xml -- Key: MEAR-146 URL: https://jira.codehaus.org/browse/MEAR-146 Project: Maven 2.x Ear Plugin Issue Type: Improvement Affects Versions: 2.7 Environment: Oracle WebLogic Reporter: Alex Halovanic Priority: Minor Attachments: ear-remove-librarydirectory-IT.patch, ear-remove-librarydirectory-IT.patch, ear-remove-librarydirectory.patch, ear-remove-librarydirectory.patch The current handling of defaultLibBundleDir leads to some issues on Oracle Weblogic 10+. The Ear plugin currently sets library-directory to the value of defaultLibBundleDir in the application.xml for EARs v5+. Some of Oracle's classloading features break (specifically Generic File Loading) when this element is set. defaultLibBundleDir has to be set to APP-INF/lib since this is the magic library folder for WebLogic. The patch adds a parameter to prevent setting library-directory for cases like this. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://jira.codehaus.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] (MEAR-146) Expose parameter to not write library-directory element in application.xml
[ https://jira.codehaus.org/browse/MEAR-146?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=305403#comment-305403 ] Alex Halovanic commented on MEAR-146: - I'll rework patch to be in a WebLogic section then. Expose parameter to not write library-directory element in application.xml -- Key: MEAR-146 URL: https://jira.codehaus.org/browse/MEAR-146 Project: Maven 2.x Ear Plugin Issue Type: Improvement Affects Versions: 2.7 Environment: Oracle WebLogic Reporter: Alex Halovanic Priority: Minor Attachments: ear-remove-librarydirectory-IT.patch, ear-remove-librarydirectory.patch The current handling of defaultLibBundleDir leads to some issues on Oracle Weblogic 10+. The Ear plugin currently sets library-directory to the value of defaultLibBundleDir in the application.xml for EARs v5+. Some of Oracle's classloading features break (specifically Generic File Loading) when this element is set. defaultLibBundleDir has to be set to APP-INF/lib since this is the magic library folder for WebLogic. The patch adds a parameter to prevent setting library-directory for cases like this. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://jira.codehaus.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] (MEAR-146) Expose parameter to not write library-directory element in application.xml
[ https://jira.codehaus.org/browse/MEAR-146?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=301799#comment-301799 ] Alex Halovanic commented on MEAR-146: - Stéphane, in light of Oracle confirming this being intentional behavior for the foreseeable future, do you still think it makes sense to modify this to have a specific WebLogic section for this option? I feel like introducing a PlexusConfiguration just to nest a parameter is going to make invoking this option unnecessarily complex. For example, the ear:ear goal documentation is not going to list this flag if it's nested under a Configuration class. Also, unlike the JBoss options, this does not modify a separate file, but has consequences for application.xml. Expose parameter to not write library-directory element in application.xml -- Key: MEAR-146 URL: https://jira.codehaus.org/browse/MEAR-146 Project: Maven 2.x Ear Plugin Issue Type: Improvement Affects Versions: 2.8 Environment: Oracle WebLogic Reporter: Alex Halovanic Priority: Minor Attachments: ear-remove-librarydirectory-IT.patch, ear-remove-librarydirectory.patch The current handling of defaultLibBundleDir leads to some issues on Oracle Weblogic 10+. The Ear plugin currently sets library-directory to the value of defaultLibBundleDir in the application.xml for EARs v5+. Some of Oracle's classloading features break (specifically Generic File Loading) when this element is set. defaultLibBundleDir has to be set to APP-INF/lib since this is the magic library folder for WebLogic. The patch adds a parameter to prevent setting library-directory for cases like this. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://jira.codehaus.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] (MEAR-146) Expose parameter to not write library-directory element in application.xml
[
https://jira.codehaus.org/browse/MEAR-146?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=300502#comment-300502
]
Alex Halovanic commented on MEAR-146:
-
I have the response back from Oracle:
{quote}
You can either use AppFileOverrides directory (and let the container do the
classloading discovery), or you can use library-directory and you decide
where you want the files to come from. You should not use both.
By default, library-directory will be loaded from APP-INF/lib of the EAR
anyways, rendering the explicit library-directory inside the application.xml
is redundant.
When no library-directory, you're delegating the classloading to the
container (ie. WLS), and the documented behavior below will suffix :
http://docs.oracle.com/cd/E12839_01/web./e13702/config.htm#i1066493
However, if you explicitly define library-directory in application.xml, this
would take precedence, and since you specify the following -
...
library-directoryAPP-INF/lib/library-directory
...
.
in which you have the following file in APP-INF/lib in
classloader-ear-libdir.ear -
.
classloader-jse-1.0-SNAPSHOT.ear
.
In such case, you're essentially overriding the AppFileOverrides directory.
So you can either use library-directory or AppFileOverrides, but not both. If
both are specified, library-directory will take precedence.
{quote}
So in their opinion, this is not a bug, but intended behavior and always
defining library-directory to the default EAR lib folder has side-effects.
However, unless there's another product that has special classloading overrides
like this, it's almost certainly still WebLogic-specific.
Expose parameter to not write library-directory element in application.xml
--
Key: MEAR-146
URL: https://jira.codehaus.org/browse/MEAR-146
Project: Maven 2.x Ear Plugin
Issue Type: Improvement
Affects Versions: 2.8
Environment: Oracle WebLogic
Reporter: Alex Halovanic
Priority: Minor
Attachments: ear-remove-librarydirectory-IT.patch,
ear-remove-librarydirectory.patch
The current handling of defaultLibBundleDir leads to some issues on Oracle
Weblogic 10+. The Ear plugin currently sets library-directory to the value
of defaultLibBundleDir in the application.xml for EARs v5+. Some of Oracle's
classloading features break (specifically Generic File Loading) when this
element is set. defaultLibBundleDir has to be set to APP-INF/lib since this
is the magic library folder for WebLogic.
The patch adds a parameter to prevent setting library-directory for cases
like this.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://jira.codehaus.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] (MEAR-146) Expose parameter to not write library-directory element in application.xml
[ https://jira.codehaus.org/browse/MEAR-146?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=289757#comment-289757 ] Alex Halovanic commented on MEAR-146: - I was agreeing with you about it being a workaround for a bug; I'm fine with rewriting the patch to make it be listed as for WebLogic only. I think I should just wait for Oracle to get back to me about this before I do, in case they have a more appropriate fix. Expose parameter to not write library-directory element in application.xml -- Key: MEAR-146 URL: https://jira.codehaus.org/browse/MEAR-146 Project: Maven 2.x Ear Plugin Issue Type: Improvement Affects Versions: 2.8 Environment: Oracle WebLogic Reporter: Alex Halovanic Priority: Minor Attachments: ear-remove-librarydirectory-IT.patch, ear-remove-librarydirectory.patch The current handling of defaultLibBundleDir leads to some issues on Oracle Weblogic 10+. The Ear plugin currently sets library-directory to the value of defaultLibBundleDir in the application.xml for EARs v5+. Some of Oracle's classloading features break (specifically Generic File Loading) when this element is set. defaultLibBundleDir has to be set to APP-INF/lib since this is the magic library folder for WebLogic. The patch adds a parameter to prevent setting library-directory for cases like this. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://jira.codehaus.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] (MEAR-146) Expose parameter to not write library-directory element in application.xml
[ https://jira.codehaus.org/browse/MEAR-146?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=289635#comment-289635 ] Alex Halovanic commented on MEAR-146: - You've got it exactly. Definitely a bug in WebLogic. I am working on putting together a bug report with Oracle, but from past experience, if they don't first tell me this is intended behavior, they won't release a fix to others since it's not a security flaw. Expose parameter to not write library-directory element in application.xml -- Key: MEAR-146 URL: https://jira.codehaus.org/browse/MEAR-146 Project: Maven 2.x Ear Plugin Issue Type: Improvement Affects Versions: 2.8 Environment: Oracle WebLogic Reporter: Alex Halovanic Priority: Minor Attachments: ear-remove-librarydirectory-IT.patch, ear-remove-librarydirectory.patch The current handling of defaultLibBundleDir leads to some issues on Oracle Weblogic 10+. The Ear plugin currently sets library-directory to the value of defaultLibBundleDir in the application.xml for EARs v5+. Some of Oracle's classloading features break (specifically Generic File Loading) when this element is set. defaultLibBundleDir has to be set to APP-INF/lib since this is the magic library folder for WebLogic. The patch adds a parameter to prevent setting library-directory for cases like this. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://jira.codehaus.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] (MEAR-146) Expose parameter to not write library-directory element in application.xml
[ https://jira.codehaus.org/browse/MEAR-146?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=289710#comment-289710 ] Alex Halovanic commented on MEAR-146: - Well, fair enough, I'm not too happy about an option just for working around a bug. But you did bring up the point that library-directory would only get written if defaultLibDirectory is set. Can I ask, is there a reason why JARs are written to the root by default? From http://java.sun.com/xml/ns/javaee/application_5.xsd: If this element [library-directory] isn't specified, the directory named lib is searched. Should jars be written to lib/ by default instead of the root? It seems to be the expected location according to the spec and would seem to eliminate the need for defining defaultLibDirectory in most cases. Expose parameter to not write library-directory element in application.xml -- Key: MEAR-146 URL: https://jira.codehaus.org/browse/MEAR-146 Project: Maven 2.x Ear Plugin Issue Type: Improvement Affects Versions: 2.8 Environment: Oracle WebLogic Reporter: Alex Halovanic Priority: Minor Attachments: ear-remove-librarydirectory-IT.patch, ear-remove-librarydirectory.patch The current handling of defaultLibBundleDir leads to some issues on Oracle Weblogic 10+. The Ear plugin currently sets library-directory to the value of defaultLibBundleDir in the application.xml for EARs v5+. Some of Oracle's classloading features break (specifically Generic File Loading) when this element is set. defaultLibBundleDir has to be set to APP-INF/lib since this is the magic library folder for WebLogic. The patch adds a parameter to prevent setting library-directory for cases like this. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://jira.codehaus.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] (MEAR-146) Expose parameter to not write library-directory element in application.xml
Alex Halovanic created MEAR-146: --- Summary: Expose parameter to not write library-directory element in application.xml Key: MEAR-146 URL: https://jira.codehaus.org/browse/MEAR-146 Project: Maven 2.x Ear Plugin Issue Type: Improvement Affects Versions: 2.8 Environment: Oracle WebLogic Reporter: Alex Halovanic Priority: Minor Attachments: ear-remove-librarydirectory-IT.patch, ear-remove-librarydirectory.patch The current handling of defaultLibBundleDir leads to some issues on Oracle Weblogic 10+. The Ear plugin currently sets library-directory to the value of defaultLibBundleDir in the application.xml for EARs v5+. Some of Oracle's classloading features break (specifically Generic File Loading) when this element is set. defaultLibBundleDir has to be set to APP-INF/lib since this is the magic library folder for WebLogic. The patch adds a parameter to prevent setting library-directory for cases like this. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://jira.codehaus.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
