[jira] [Commented] (MNG-8167) enable "split repo" in settings.xml
[ https://issues.apache.org/jira/browse/MNG-8167?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17860883#comment-17860883 ] Benjamin Marwell commented on MNG-8167: --- So, create a profile? Why does localRepository does not need a profile? I think having to wrap this in a profile is a drawback. It should not be (de-)activatable. https://maven.apache.org/settings.html Oh I just found it in the other docs, pom.html: https://maven.apache.org/pom.html#Properties Thanks! > enable "split repo" in settings.xml > --- > > Key: MNG-8167 > URL: https://issues.apache.org/jira/browse/MNG-8167 > Project: Maven > Issue Type: Improvement >Reporter: Benjamin Marwell >Priority: Major > > With the availability of "-Daether.enhancedLocalRepository.split" and others, > this should be settable in settings.xml. > Rationale: the repo should not have two layouts (or more) locally. > Settings.xml should at least be able to define a default. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Comment Edited] (MNG-8167) enable "split repo" in settings.xml
[ https://issues.apache.org/jira/browse/MNG-8167?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17860883#comment-17860883 ] Benjamin Marwell edited comment on MNG-8167 at 6/28/24 7:43 PM: So, create a profile? Why does localRepository does not need a profile? I think having to wrap this in a profile is a drawback. It should not be (de-)activatable. https://maven.apache.org/settings.html It is only mentioned in pom.xml which I do not want to edit. https://maven.apache.org/pom.html#Properties Thanks! was (Author: mampf86): So, create a profile? Why does localRepository does not need a profile? I think having to wrap this in a profile is a drawback. It should not be (de-)activatable. https://maven.apache.org/settings.html Oh I just found it in the other docs, pom.html: https://maven.apache.org/pom.html#Properties Thanks! > enable "split repo" in settings.xml > --- > > Key: MNG-8167 > URL: https://issues.apache.org/jira/browse/MNG-8167 > Project: Maven > Issue Type: Improvement >Reporter: Benjamin Marwell >Priority: Major > > With the availability of "-Daether.enhancedLocalRepository.split" and others, > this should be settable in settings.xml. > Rationale: the repo should not have two layouts (or more) locally. > Settings.xml should at least be able to define a default. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Reopened] (MNG-8167) enable "split repo" in settings.xml
[ https://issues.apache.org/jira/browse/MNG-8167?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Benjamin Marwell reopened MNG-8167: --- > enable "split repo" in settings.xml > --- > > Key: MNG-8167 > URL: https://issues.apache.org/jira/browse/MNG-8167 > Project: Maven > Issue Type: Improvement >Reporter: Benjamin Marwell >Priority: Major > > With the availability of "-Daether.enhancedLocalRepository.split" and others, > this should be settable in settings.xml. > Rationale: the repo should not have two layouts (or more) locally. > Settings.xml should at least be able to define a default. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Resolved] (MNG-8167) enable "split repo" in settings.xml
[ https://issues.apache.org/jira/browse/MNG-8167?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Benjamin Marwell resolved MNG-8167. --- Resolution: Information Provided > enable "split repo" in settings.xml > --- > > Key: MNG-8167 > URL: https://issues.apache.org/jira/browse/MNG-8167 > Project: Maven > Issue Type: Improvement >Reporter: Benjamin Marwell >Priority: Major > > With the availability of "-Daether.enhancedLocalRepository.split" and others, > this should be settable in settings.xml. > Rationale: the repo should not have two layouts (or more) locally. > Settings.xml should at least be able to define a default. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (MNG-8167) enable "split repo" in settings.xml
Benjamin Marwell created MNG-8167: - Summary: enable "split repo" in settings.xml Key: MNG-8167 URL: https://issues.apache.org/jira/browse/MNG-8167 Project: Maven Issue Type: Improvement Reporter: Benjamin Marwell With the availability of "-Daether.enhancedLocalRepository.split" and others, this should be settable in settings.xml. Rationale: the repo should not have two layouts (or more) locally. Settings.xml should at least be able to define a default. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MNG-8162) Maven should warn about modules relative to parent directory
[
https://issues.apache.org/jira/browse/MNG-8162?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17856921#comment-17856921
]
Benjamin Marwell commented on MNG-8162:
---
If the root pom is in:
$root/$appname/dev/Impl/Build/pom.xml
:face_vomiting:
... do I put .mvn in...
$root
or
$root/$appname/dev/Impl (first common ancestor of all modules)
or
$root/$appname/dev/Impl/Build
..?
> Maven should warn about modules relative to parent directory
>
>
> Key: MNG-8162
> URL: https://issues.apache.org/jira/browse/MNG-8162
> Project: Maven
> Issue Type: Task
> Components: Core
>Reporter: Benjamin Marwell
>Priority: Major
>
> Maven should warn if a pom project references modules which are not direct
> descendants, e.g.
> {code:html}
> ../other
> {code}
> h2. Rationale
> Given this situation:
> * the repository root does not contain the root pom.xml
> * A subdirectory contains the "root" pom.xml (e.g. ./Build/pom.xml)
> * Maven must be called either via {{mvn -f Build}} or {{cd Build && mvn}}
> Then it is hard to determine the root:
> * Is it in the VCS clone/checkout root?
> * Is it in the first common ancestor? Maybe it is in
> {{project/dev/impl/Build}} ?
> * Is root=true a valid tag in either of these cases?
> * what if you call maven from even yet a higher directory?
> * What if both .mvn directores and the root tags are present?
> * What if there are multitple .mvn directories (lets say in repo root, and in
> ./project/dev/impl and in ./project/dev/impl/Build)?
> In any of those cases and combinations of those, Maven should print a warning
> h2. Suggested warning
> {code}
> [WARN] This maven project has modules relative to the parent directory
> (../{..}. This is an invalid configuration and will be
> unsupported in future releases. To fix, move all descendants of a pom project
> to its directory, making it a direct descendant.
> {code}
> h2. Checks
> Should be included in the new self-check
> h2. Suggested deprecation
> Maven 5 should not work under such circumstances
> h2. Backports
> Might be a candidate for backporting to 3.9.
> h2. Documentation
> The docs should clarify which "root" takes precedence (and why).
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MNG-8162) Maven should warn about modules relative to parent directory
[
https://issues.apache.org/jira/browse/MNG-8162?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17856751#comment-17856751
]
Benjamin Marwell commented on MNG-8162:
---
The main idea is to avoid trouble with the root tag vs where to place the .mvn
directory vs from where to call it vs multiple .mvn directories...
> Maven should warn about modules relative to parent directory
>
>
> Key: MNG-8162
> URL: https://issues.apache.org/jira/browse/MNG-8162
> Project: Maven
> Issue Type: Task
> Components: Core
>Reporter: Benjamin Marwell
>Priority: Major
>
> Maven should warn if a pom project references modules which are not direct
> descendants, e.g.
> {code:html}
> ../other
> {code}
> h2. Rationale
> Given this situation:
> * the repository root does not contain the root pom.xml
> * A subdirectory contains the "root" pom.xml (e.g. ./Build/pom.xml)
> * Maven must be called either via {{mvn -f Build}} or {{cd Build && mvn}}
> Then it is hard to determine the root:
> * Is it in the VCS clone/checkout root?
> * Is it in the first common ancestor? Maybe it is in
> {{project/dev/impl/Build}} ?
> * Is root=true a valid tag in either of these cases?
> * what if you call maven from even yet a higher directory?
> * What if both .mvn directores and the root tags are present?
> * What if there are multitple .mvn directories (lets say in repo root, and in
> ./project/dev/impl and in ./project/dev/impl/Build)?
> In any of those cases and combinations of those, Maven should print a warning
> h2. Suggested warning
> {code}
> [WARN] This maven project has modules relative to the parent directory
> (../{..}. This is an invalid configuration and will be
> unsupported in future releases. To fix, move all descendants of a pom project
> to its directory, making it a direct descendant.
> {code}
> h2. Checks
> Should be included in the new self-check
> h2. Suggested deprecation
> Maven 5 should not work under such circumstances
> h2. Backports
> Might be a candidate for backporting to 3.9.
> h2. Documentation
> The docs should clarify which "root" takes precedence (and why).
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Created] (MNG-8162) Maven should warn about modules relative to parent directory
Benjamin Marwell created MNG-8162:
-
Summary: Maven should warn about modules relative to parent
directory
Key: MNG-8162
URL: https://issues.apache.org/jira/browse/MNG-8162
Project: Maven
Issue Type: Task
Components: Core
Reporter: Benjamin Marwell
Maven should warn if a pom project references modules which are not direct
descendants, e.g.
{code:html}
../other
{code}
h2. Rationale
Given this situation:
* the repository root does not contain the root pom.xml
* A subfolder contains the "root" pom.xml (e.g. ./Build/pom.xml)
* Maven must be called either via {{mvn -f Build}} or {{cd Build && mvn}}
Then it is hard to determine the root:
* Is it in the VCS clone/checkout root?
* Is it in the first common ancestor? Maybe it is in {{project/dev/impl/Build}}
?
* Is root=true a valid tag in either of these cases?
* what if you call maven from even yet a higher directory?
* What if both .mvn folders and the root tags are present?
* What if there are multitple .mvn folders (lets say in repo root, and in
./project/dev/impl and in ./project/dev/impl/Build)?
In any of those cases and combinations of those, Maven should print a warning
h2. Suggested warning
{code}
[WARN] This maven project has modules relative to the parent folder
(../{..}. This is an invalid configuration and will be
unsupported in future releases. To fix, move all descendants of a pom project
to its folder, making it a direct descendant.
{code}
h2. Checks
Should be included in the new self-check
h2. Suggested deprecation
Maven 5 should not work under such circumstances
h2. Backports
Might be a candidate for backporting to 3.9.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Updated] (MNG-8162) Maven should warn about modules relative to parent directory
[
https://issues.apache.org/jira/browse/MNG-8162?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Benjamin Marwell updated MNG-8162:
--
Description:
Maven should warn if a pom project references modules which are not direct
descendants, e.g.
{code:html}
../other
{code}
h2. Rationale
Given this situation:
* the repository root does not contain the root pom.xml
* A subfolder contains the "root" pom.xml (e.g. ./Build/pom.xml)
* Maven must be called either via {{mvn -f Build}} or {{cd Build && mvn}}
Then it is hard to determine the root:
* Is it in the VCS clone/checkout root?
* Is it in the first common ancestor? Maybe it is in {{project/dev/impl/Build}}
?
* Is root=true a valid tag in either of these cases?
* what if you call maven from even yet a higher directory?
* What if both .mvn folders and the root tags are present?
* What if there are multitple .mvn folders (lets say in repo root, and in
./project/dev/impl and in ./project/dev/impl/Build)?
In any of those cases and combinations of those, Maven should print a warning
h2. Suggested warning
{code}
[WARN] This maven project has modules relative to the parent folder
(../{..}. This is an invalid configuration and will be
unsupported in future releases. To fix, move all descendants of a pom project
to its folder, making it a direct descendant.
{code}
h2. Checks
Should be included in the new self-check
h2. Suggested deprecation
Maven 5 should not work under such circumstances
h2. Backports
Might be a candidate for backporting to 3.9.
h2. Documentation
The docs should clarify which "root" takes precedence (and why).
was:
Maven should warn if a pom project references modules which are not direct
descendants, e.g.
{code:html}
../other
{code}
h2. Rationale
Given this situation:
* the repository root does not contain the root pom.xml
* A subfolder contains the "root" pom.xml (e.g. ./Build/pom.xml)
* Maven must be called either via {{mvn -f Build}} or {{cd Build && mvn}}
Then it is hard to determine the root:
* Is it in the VCS clone/checkout root?
* Is it in the first common ancestor? Maybe it is in {{project/dev/impl/Build}}
?
* Is root=true a valid tag in either of these cases?
* what if you call maven from even yet a higher directory?
* What if both .mvn folders and the root tags are present?
* What if there are multitple .mvn folders (lets say in repo root, and in
./project/dev/impl and in ./project/dev/impl/Build)?
In any of those cases and combinations of those, Maven should print a warning
h2. Suggested warning
{code}
[WARN] This maven project has modules relative to the parent folder
(../{..}. This is an invalid configuration and will be
unsupported in future releases. To fix, move all descendants of a pom project
to its folder, making it a direct descendant.
{code}
h2. Checks
Should be included in the new self-check
h2. Suggested deprecation
Maven 5 should not work under such circumstances
h2. Backports
Might be a candidate for backporting to 3.9.
> Maven should warn about modules relative to parent directory
>
>
> Key: MNG-8162
> URL: https://issues.apache.org/jira/browse/MNG-8162
> Project: Maven
> Issue Type: Task
> Components: Core
>Reporter: Benjamin Marwell
>Priority: Major
>
> Maven should warn if a pom project references modules which are not direct
> descendants, e.g.
> {code:html}
> ../other
> {code}
> h2. Rationale
> Given this situation:
> * the repository root does not contain the root pom.xml
> * A subfolder contains the "root" pom.xml (e.g. ./Build/pom.xml)
> * Maven must be called either via {{mvn -f Build}} or {{cd Build && mvn}}
> Then it is hard to determine the root:
> * Is it in the VCS clone/checkout root?
> * Is it in the first common ancestor? Maybe it is in
> {{project/dev/impl/Build}} ?
> * Is root=true a valid tag in either of these cases?
> * what if you call maven from even yet a higher directory?
> * What if both .mvn folders and the root tags are present?
> * What if there are multitple .mvn folders (lets say in repo root, and in
> ./project/dev/impl and in ./project/dev/impl/Build)?
> In any of those cases and combinations of those, Maven should print a warning
> h2. Suggested warning
> {code}
> [WARN] This maven project has modules relative to the parent folder
> (../{..}. This is an invalid configuration and will be
> unsupported in future releases. To fix, move all descendants of a pom project
> to its folder, making it a direct descendant.
> {code}
> h2. Checks
> Should be included in the new self-check
> h2. Suggested deprecation
> Maven 5 should not work under such circumstances
> h2. Backports
> Might be a candidate for backporting to 3.9.
> h2. Documentation
> The docs should clarify which "root" takes precedence (and why).
--
This
[jira] [Resolved] (MNG-8122) `versions:display-dependency-updates -pl .` on Maven 4 alpha-13 will output dependency trees from all projects
[
https://issues.apache.org/jira/browse/MNG-8122?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Benjamin Marwell resolved MNG-8122.
---
Resolution: Not A Bug
> `versions:display-dependency-updates -pl .` on Maven 4 alpha-13 will output
> dependency trees from all projects
> --
>
> Key: MNG-8122
> URL: https://issues.apache.org/jira/browse/MNG-8122
> Project: Maven
> Issue Type: Bug
> Components: Command Line, Core
>Affects Versions: 4.0.0-alpha-12, 4.0.0-alpha-13
>Reporter: Benjamin Marwell
>Priority: Major
>
> When running this command:
> {code:bash}
> ./mvnw versions:display-dependency-updates -ntp -Prun-its
> -DallowMajorUpdates=true
> -Dmaven.version.ignore='.*-SNAPSHOT,.*-M[0-9],.*[aA]lpha(-)?[0-9],.*-RC[0-9],.*beta(-)?[0-9]*'
> -pl .
> ─╯
> {code}
> with Maven Wrapper and Maven 4.0.0-alpha-12, it will actually output the
> dependency trees on all projects.
> When switching back to v3.9.6, this does not happen.
> h2. Expected outcome
> Only display updates from root project
> h2. Actual outcome
> ignores? parameter {{-pl .}}
> h2. Versions
> dependency-plugin v3.6.1
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MNG-8122) `versions:display-dependency-updates -pl .` on Maven 4 alpha-13 will output dependency trees from all projects
[
https://issues.apache.org/jira/browse/MNG-8122?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17847066#comment-17847066
]
Benjamin Marwell commented on MNG-8122:
---
Oh you are right! Karl Heinz actually mentioned `-N` to me the other day. Sorry
for the fuzz...
> `versions:display-dependency-updates -pl .` on Maven 4 alpha-13 will output
> dependency trees from all projects
> --
>
> Key: MNG-8122
> URL: https://issues.apache.org/jira/browse/MNG-8122
> Project: Maven
> Issue Type: Bug
> Components: Command Line, Core
>Affects Versions: 4.0.0-alpha-12, 4.0.0-alpha-13
>Reporter: Benjamin Marwell
>Priority: Major
>
> When running this command:
> {code:bash}
> ./mvnw versions:display-dependency-updates -ntp -Prun-its
> -DallowMajorUpdates=true
> -Dmaven.version.ignore='.*-SNAPSHOT,.*-M[0-9],.*[aA]lpha(-)?[0-9],.*-RC[0-9],.*beta(-)?[0-9]*'
> -pl .
> ─╯
> {code}
> with Maven Wrapper and Maven 4.0.0-alpha-12, it will actually output the
> dependency trees on all projects.
> When switching back to v3.9.6, this does not happen.
> h2. Expected outcome
> Only display updates from root project
> h2. Actual outcome
> ignores? parameter {{-pl .}}
> h2. Versions
> dependency-plugin v3.6.1
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Created] (MNG-8122) `versions:display-dependency-updates -pl .` on Maven 4 alpha-13 will output dependency trees from all projects
Benjamin Marwell created MNG-8122:
-
Summary: `versions:display-dependency-updates -pl .` on Maven 4
alpha-13 will output dependency trees from all projects
Key: MNG-8122
URL: https://issues.apache.org/jira/browse/MNG-8122
Project: Maven
Issue Type: Bug
Components: Command Line, Core
Affects Versions: 4.0.0-alpha-13, 4.0.0-alpha-12
Reporter: Benjamin Marwell
When running this command:
{code:bash}
./mvnw versions:display-dependency-updates -ntp -Prun-its
-DallowMajorUpdates=true
-Dmaven.version.ignore='.*-SNAPSHOT,.*-M[0-9],.*[aA]lpha(-)?[0-9],.*-RC[0-9],.*beta(-)?[0-9]*'
-pl .
─╯
{code}
with Maven Wrapper and Maven 4.0.0-alpha-12, it will actually output the
dependency trees on all projects.
When switching back to v3.9.6, this does not happen.
h2. Expected outcome
Only display updates from root project
h2. Actual outcome
ignores? parameter {{-pl .}}
h2. Versions
dependency-plugin v3.6.1
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Updated] (MCOMPILER-581) Create 2nd default execution "default-generate-sources" for APT
[ https://issues.apache.org/jira/browse/MCOMPILER-581?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Benjamin Marwell updated MCOMPILER-581: --- Summary: Create 2nd default execution "default-generate-sources" for APT (was: Create 2nd default goal "default-generate-sources" for APT) > Create 2nd default execution "default-generate-sources" for APT > --- > > Key: MCOMPILER-581 > URL: https://issues.apache.org/jira/browse/MCOMPILER-581 > Project: Maven Compiler Plugin > Issue Type: Task >Reporter: Benjamin Marwell >Priority: Major > Fix For: 4.0.0 > > > Starting with version 4.0.0 of this plugin for use with Maven 4+, the > following changes should be incorporated to align the compilation process > with the process designed by the OpenJDK javac team: > * Modify default-compile to use proc:none by default > * Create a new goal default-generate-sources and use proc:only > This will align the compilation process with the default javac use. > h2. Rationale > Before JDK 21+, no "proc:full" was available and implicitly used when no > proc:* was set. > However, starting with JDK 21, proc:full was introduced and not specifying > proc:* will now trigger a warning. > h2. Alternatives > Keep one phase but specify proc:full whenever APTs are in the CP or used as a > compiler-plugin dependency/path or when APT classes are explicitly given. > h2. Drawbacks of this approach > TODO: document drawbacks of this approach and of the alternatives. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (MCOMPILER-581) Create 2nd default goal "default-generate-sources" for APT
Benjamin Marwell created MCOMPILER-581: -- Summary: Create 2nd default goal "default-generate-sources" for APT Key: MCOMPILER-581 URL: https://issues.apache.org/jira/browse/MCOMPILER-581 Project: Maven Compiler Plugin Issue Type: Task Reporter: Benjamin Marwell Fix For: 4.0.0 Starting with version 4.0.0 of this plugin for use with Maven 4+, the following changes should be incorporated to align the compilation process with the process designed by the OpenJDK javac team: * Modify default-compile to use proc:none by default * Create a new goal default-generate-sources and use proc:only This will align the compilation process with the default javac use. h2. Rationale Before JDK 21+, no "proc:full" was available and implicitly used when no proc:* was set. However, starting with JDK 21, proc:full was introduced and not specifying proc:* will now trigger a warning. h2. Alternatives Keep one phase but specify proc:full whenever APTs are in the CP or used as a compiler-plugin dependency/path or when APT classes are explicitly given. h2. Drawbacks of this approach TODO: document drawbacks of this approach and of the alternatives. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Resolved] (MWRAPPER-86) Trim trailing slash in Repo URL
[
https://issues.apache.org/jira/browse/MWRAPPER-86?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Benjamin Marwell resolved MWRAPPER-86.
--
Fix Version/s: 3.3.0
Resolution: Fixed
> Trim trailing slash in Repo URL
> ---
>
> Key: MWRAPPER-86
> URL: https://issues.apache.org/jira/browse/MWRAPPER-86
> Project: Maven Wrapper
> Issue Type: Bug
> Components: Maven Wrapper Plugin
>Affects Versions: 3.1.1
>Reporter: Björn Michael
>Assignee: Benjamin Marwell
>Priority: Major
> Fix For: 3.3.0
>
>
> If repository URL ends with a trailing slash then the URLs in
> {{maven-wrapper.properties}} contain double slashes.
> E.g. {{MVNW_REPOURL=[https://myrepo.local/]}} ends up with
> {code:java}
> distributionUrl=https://myrepo.local//org/apache/maven/apache-maven/3.8.7/apache-maven-3.8.7-bin.zip
> wrapperUrl=https://myrepo.local//org/apache/maven/wrapper/maven-wrapper/3.1.1/maven-wrapper-3.1.1.jar{code}
> This also occurs when mirror * URL ends with trailing slash.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Reopened] (MNG-8061) Upgrade Maven runtime requirement to Java 17
[ https://issues.apache.org/jira/browse/MNG-8061?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Benjamin Marwell reopened MNG-8061: --- Needs docs > Upgrade Maven runtime requirement to Java 17 > > > Key: MNG-8061 > URL: https://issues.apache.org/jira/browse/MNG-8061 > Project: Maven > Issue Type: Task > Components: API, Core, POM >Reporter: Benjamin Marwell >Assignee: Benjamin Marwell >Priority: Major > Labels: NeedsReleaseNote, pull-request-available > Fix For: 4.0.0-alpha-13 > > > Update Maven and its plugins to Java 17 by replacing maven.compiler.* with > maven.compiler.release and setting the language level to 17. > This issue and its PR need a vote -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MNG-8061) Upgrade Maven runtime requirement to Java 17
[ https://issues.apache.org/jira/browse/MNG-8061?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17822992#comment-17822992 ] Benjamin Marwell commented on MNG-8061: --- The vote has succeeded and the PR was merged > Upgrade Maven runtime requirement to Java 17 > > > Key: MNG-8061 > URL: https://issues.apache.org/jira/browse/MNG-8061 > Project: Maven > Issue Type: Task > Components: API, Core, POM >Reporter: Benjamin Marwell >Assignee: Benjamin Marwell >Priority: Major > Labels: NeedsReleaseNote, pull-request-available > Fix For: 4.0.0-alpha-13 > > > Update Maven and its plugins to Java 17 by replacing maven.compiler.* with > maven.compiler.release and setting the language level to 17. > This issue and its PR need a vote -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Closed] (MNG-8061) Upgrade Maven runtime requirement to Java 17
[ https://issues.apache.org/jira/browse/MNG-8061?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Benjamin Marwell closed MNG-8061. - > Upgrade Maven runtime requirement to Java 17 > > > Key: MNG-8061 > URL: https://issues.apache.org/jira/browse/MNG-8061 > Project: Maven > Issue Type: Task > Components: API, Core, POM >Reporter: Benjamin Marwell >Assignee: Benjamin Marwell >Priority: Major > Labels: NeedsReleaseNote, pull-request-available > Fix For: 4.0.0-alpha-13 > > > Update Maven and its plugins to Java 17 by replacing maven.compiler.* with > maven.compiler.release and setting the language level to 17. > This issue and its PR need a vote -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Resolved] (MNG-8061) Upgrade Maven runtime requirement to Java 17
[ https://issues.apache.org/jira/browse/MNG-8061?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Benjamin Marwell resolved MNG-8061. --- Fix Version/s: 4.0.0-alpha-13 Assignee: Benjamin Marwell Resolution: Fixed > Upgrade Maven runtime requirement to Java 17 > > > Key: MNG-8061 > URL: https://issues.apache.org/jira/browse/MNG-8061 > Project: Maven > Issue Type: Task > Components: API, Core, POM >Reporter: Benjamin Marwell >Assignee: Benjamin Marwell >Priority: Major > Labels: NeedsReleaseNote, pull-request-available > Fix For: 4.0.0-alpha-13 > > > Update Maven and its plugins to Java 17 by replacing maven.compiler.* with > maven.compiler.release and setting the language level to 17. > This issue and its PR need a vote -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Resolved] (MJMOD-32) Remove commons-lang
[ https://issues.apache.org/jira/browse/MJMOD-32?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Benjamin Marwell resolved MJMOD-32. --- Resolution: Fixed > Remove commons-lang > --- > > Key: MJMOD-32 > URL: https://issues.apache.org/jira/browse/MJMOD-32 > Project: Maven JMod Plugin > Issue Type: Improvement >Reporter: Benjamin Marwell >Assignee: Benjamin Marwell >Priority: Major > Fix For: 3.0.0 > > > We have maven-shared-utils with the same OS functionality. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Assigned] (MSCRIPTING-7) Session is not bound in scripting bindings
[ https://issues.apache.org/jira/browse/MSCRIPTING-7?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Benjamin Marwell reassigned MSCRIPTING-7: - Assignee: Benjamin Marwell > Session is not bound in scripting bindings > -- > > Key: MSCRIPTING-7 > URL: https://issues.apache.org/jira/browse/MSCRIPTING-7 > Project: Maven Scripting > Issue Type: Task >Affects Versions: 3.0.0 >Reporter: Romain Manni-Bucau >Assignee: Benjamin Marwell >Priority: Major > Labels: pull-request-available > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (MJMOD-32) Remove commons-lang
Benjamin Marwell created MJMOD-32: - Summary: Remove commons-lang Key: MJMOD-32 URL: https://issues.apache.org/jira/browse/MJMOD-32 Project: Maven JMod Plugin Issue Type: Improvement Reporter: Benjamin Marwell Assignee: Benjamin Marwell Fix For: 3.0.0 We have maven-shared-utils with the same OS functionality. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Resolved] (MJMOD-31) Fix dependency scopes
[ https://issues.apache.org/jira/browse/MJMOD-31?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Benjamin Marwell resolved MJMOD-31. --- Resolution: Fixed > Fix dependency scopes > - > > Key: MJMOD-31 > URL: https://issues.apache.org/jira/browse/MJMOD-31 > Project: Maven JMod Plugin > Issue Type: Task >Reporter: Benjamin Marwell >Assignee: Benjamin Marwell >Priority: Major > Fix For: 3.0.0 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MSCRIPTING-10) Page Not Found on majority of Maven Scripting Plugin pages
[ https://issues.apache.org/jira/browse/MSCRIPTING-10?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17822983#comment-17822983 ] Benjamin Marwell commented on MSCRIPTING-10: The usage page will work now, it was written in markdown but the site-plugin was too old. Was automatically fixed by the parent-update. I also checked the other links with the same result. I will mark it as resolved for 3.1.0. > Page Not Found on majority of Maven Scripting Plugin pages > -- > > Key: MSCRIPTING-10 > URL: https://issues.apache.org/jira/browse/MSCRIPTING-10 > Project: Maven Scripting > Issue Type: Bug > Environment: Web >Reporter: Milan Kubec >Assignee: Benjamin Marwell >Priority: Major > > On page https://maven.apache.org/plugins/maven-scripting-plugin/index.html > there is "Page Not Found" response for following links: > [https://maven.apache.org/plugins/maven-scripting-plugin/usage.html] > [https://maven.apache.org/plugins/maven-scripting-plugin/faq.html] > [https://maven.apache.org/plugins/maven-scripting-plugin/mail-lists.html] > [https://maven.apache.org/plugins/maven-scripting-plugin/mail-lists.html] > [https://maven.apache.org/plugins/maven-scripting-plugin/issue-tracking.html] > [https://maven.apache.org/plugins/maven-scripting-plugin/source-repository.html] -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Resolved] (MSCRIPTING-10) Page Not Found on majority of Maven Scripting Plugin pages
[ https://issues.apache.org/jira/browse/MSCRIPTING-10?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Benjamin Marwell resolved MSCRIPTING-10. Fix Version/s: 3.1.0 Resolution: Fixed > Page Not Found on majority of Maven Scripting Plugin pages > -- > > Key: MSCRIPTING-10 > URL: https://issues.apache.org/jira/browse/MSCRIPTING-10 > Project: Maven Scripting > Issue Type: Bug > Environment: Web >Reporter: Milan Kubec >Assignee: Benjamin Marwell >Priority: Major > Fix For: 3.1.0 > > > On page https://maven.apache.org/plugins/maven-scripting-plugin/index.html > there is "Page Not Found" response for following links: > [https://maven.apache.org/plugins/maven-scripting-plugin/usage.html] > [https://maven.apache.org/plugins/maven-scripting-plugin/faq.html] > [https://maven.apache.org/plugins/maven-scripting-plugin/mail-lists.html] > [https://maven.apache.org/plugins/maven-scripting-plugin/mail-lists.html] > [https://maven.apache.org/plugins/maven-scripting-plugin/issue-tracking.html] > [https://maven.apache.org/plugins/maven-scripting-plugin/source-repository.html] -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Assigned] (MSCRIPTING-10) Page Not Found on majority of Maven Scripting Plugin pages
[ https://issues.apache.org/jira/browse/MSCRIPTING-10?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Benjamin Marwell reassigned MSCRIPTING-10: -- Assignee: Benjamin Marwell > Page Not Found on majority of Maven Scripting Plugin pages > -- > > Key: MSCRIPTING-10 > URL: https://issues.apache.org/jira/browse/MSCRIPTING-10 > Project: Maven Scripting > Issue Type: Bug > Environment: Web >Reporter: Milan Kubec >Assignee: Benjamin Marwell >Priority: Major > > On page https://maven.apache.org/plugins/maven-scripting-plugin/index.html > there is "Page Not Found" response for following links: > [https://maven.apache.org/plugins/maven-scripting-plugin/usage.html] > [https://maven.apache.org/plugins/maven-scripting-plugin/faq.html] > [https://maven.apache.org/plugins/maven-scripting-plugin/mail-lists.html] > [https://maven.apache.org/plugins/maven-scripting-plugin/mail-lists.html] > [https://maven.apache.org/plugins/maven-scripting-plugin/issue-tracking.html] > [https://maven.apache.org/plugins/maven-scripting-plugin/source-repository.html] -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Resolved] (MSCRIPTING-9) Support java scripting
[ https://issues.apache.org/jira/browse/MSCRIPTING-9?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Benjamin Marwell resolved MSCRIPTING-9. --- Resolution: Fixed > Support java scripting > -- > > Key: MSCRIPTING-9 > URL: https://issues.apache.org/jira/browse/MSCRIPTING-9 > Project: Maven Scripting > Issue Type: Task >Reporter: Romain Manni-Bucau >Assignee: Benjamin Marwell >Priority: Major > Labels: pull-request-available > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (MJMOD-31) Fix dependency scopes
[ https://issues.apache.org/jira/browse/MJMOD-31?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Benjamin Marwell updated MJMOD-31: -- Summary: Fix dependency scopes (was: Fix dependency scopes; remove uneeded deps) > Fix dependency scopes > - > > Key: MJMOD-31 > URL: https://issues.apache.org/jira/browse/MJMOD-31 > Project: Maven JMod Plugin > Issue Type: Task >Reporter: Benjamin Marwell >Assignee: Benjamin Marwell >Priority: Major > Fix For: 3.0.0 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (MJMOD-31) Fix dependency scopes; remove uneeded deps
Benjamin Marwell created MJMOD-31: - Summary: Fix dependency scopes; remove uneeded deps Key: MJMOD-31 URL: https://issues.apache.org/jira/browse/MJMOD-31 Project: Maven JMod Plugin Issue Type: Task Reporter: Benjamin Marwell Assignee: Benjamin Marwell Fix For: 3.0.0 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Resolved] (MJMOD-28) Update Maven plugins-parent to v41
[ https://issues.apache.org/jira/browse/MJMOD-28?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Benjamin Marwell resolved MJMOD-28. --- Resolution: Fixed > Update Maven plugins-parent to v41 > -- > > Key: MJMOD-28 > URL: https://issues.apache.org/jira/browse/MJMOD-28 > Project: Maven JMod Plugin > Issue Type: Dependency upgrade >Reporter: Benjamin Marwell >Assignee: Benjamin Marwell >Priority: Major > Fix For: 3.0.0 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Resolved] (MJMOD-30) Require Maven 3.6.3; update project-report requirements
[ https://issues.apache.org/jira/browse/MJMOD-30?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Benjamin Marwell resolved MJMOD-30. --- Resolution: Fixed > Require Maven 3.6.3; update project-report requirements > --- > > Key: MJMOD-30 > URL: https://issues.apache.org/jira/browse/MJMOD-30 > Project: Maven JMod Plugin > Issue Type: Dependency upgrade >Reporter: Benjamin Marwell >Assignee: Benjamin Marwell >Priority: Major > Fix For: 3.0.0 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Resolved] (MJMOD-29) Update to Java 8 and add/update requirements
[ https://issues.apache.org/jira/browse/MJMOD-29?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Benjamin Marwell resolved MJMOD-29. --- Resolution: Fixed > Update to Java 8 and add/update requirements > > > Key: MJMOD-29 > URL: https://issues.apache.org/jira/browse/MJMOD-29 > Project: Maven JMod Plugin > Issue Type: Task >Reporter: Benjamin Marwell >Assignee: Benjamin Marwell >Priority: Major > Fix For: 3.0.0 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (MJMOD-30) Require Maven 3.6.3; update project-report requirements
Benjamin Marwell created MJMOD-30: - Summary: Require Maven 3.6.3; update project-report requirements Key: MJMOD-30 URL: https://issues.apache.org/jira/browse/MJMOD-30 Project: Maven JMod Plugin Issue Type: Dependency upgrade Reporter: Benjamin Marwell Assignee: Benjamin Marwell Fix For: 3.0.0 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (MJMOD-29) Update to Java 8 and add/update requirements
[ https://issues.apache.org/jira/browse/MJMOD-29?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Benjamin Marwell updated MJMOD-29: -- Summary: Update to Java 8 and add/update requirements (was: Update to Java 8 and add requirements) > Update to Java 8 and add/update requirements > > > Key: MJMOD-29 > URL: https://issues.apache.org/jira/browse/MJMOD-29 > Project: Maven JMod Plugin > Issue Type: Task >Reporter: Benjamin Marwell >Assignee: Benjamin Marwell >Priority: Major > Fix For: 3.0.0 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (MJMOD-29) Update to Java 8 and add requirements
Benjamin Marwell created MJMOD-29: - Summary: Update to Java 8 and add requirements Key: MJMOD-29 URL: https://issues.apache.org/jira/browse/MJMOD-29 Project: Maven JMod Plugin Issue Type: Task Reporter: Benjamin Marwell Assignee: Benjamin Marwell Fix For: 3.0.0 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (MJMOD-28) Update Maven plugins-parent to v41
Benjamin Marwell created MJMOD-28: - Summary: Update Maven plugins-parent to v41 Key: MJMOD-28 URL: https://issues.apache.org/jira/browse/MJMOD-28 Project: Maven JMod Plugin Issue Type: Dependency upgrade Reporter: Benjamin Marwell Assignee: Benjamin Marwell Fix For: 3.0.0 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (MJMOD-24) Upgrade plexus-java 1.0.3
[ https://issues.apache.org/jira/browse/MJMOD-24?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Benjamin Marwell updated MJMOD-24: -- Fix Version/s: 3.0.0-alpha-2 > Upgrade plexus-java 1.0.3 > - > > Key: MJMOD-24 > URL: https://issues.apache.org/jira/browse/MJMOD-24 > Project: Maven JMod Plugin > Issue Type: Dependency upgrade >Affects Versions: 3.0.0 >Reporter: Karl Heinz Marbaise >Assignee: Karl Heinz Marbaise >Priority: Minor > Fix For: 3.0.0-alpha-2, 3.0.0 > > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (MJMOD-22) Upgrade maven-shared-utils to 3.2.1
[ https://issues.apache.org/jira/browse/MJMOD-22?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Benjamin Marwell updated MJMOD-22: -- Fix Version/s: 3.0.0-alpha-2 > Upgrade maven-shared-utils to 3.2.1 > --- > > Key: MJMOD-22 > URL: https://issues.apache.org/jira/browse/MJMOD-22 > Project: Maven JMod Plugin > Issue Type: Dependency upgrade >Affects Versions: 3.0.0-alpha-1 >Reporter: Karl Heinz Marbaise >Assignee: Karl Heinz Marbaise >Priority: Minor > Fix For: 3.0.0-alpha-2, 3.0.0 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (MJMOD-15) Upgrade maven-plugins parent to version 32.
[ https://issues.apache.org/jira/browse/MJMOD-15?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Benjamin Marwell updated MJMOD-15: -- Fix Version/s: 3.0.0-alpha-2 > Upgrade maven-plugins parent to version 32. > --- > > Key: MJMOD-15 > URL: https://issues.apache.org/jira/browse/MJMOD-15 > Project: Maven JMod Plugin > Issue Type: Dependency upgrade >Affects Versions: 3.0.0 >Reporter: Karl Heinz Marbaise >Priority: Minor > Fix For: 3.0.0-alpha-2, 3.0.0 > > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (MJMOD-21) Upgrade plexus-java to 1.0.1
[ https://issues.apache.org/jira/browse/MJMOD-21?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Benjamin Marwell updated MJMOD-21: -- Fix Version/s: 3.0.0-alpha-2 > Upgrade plexus-java to 1.0.1 > > > Key: MJMOD-21 > URL: https://issues.apache.org/jira/browse/MJMOD-21 > Project: Maven JMod Plugin > Issue Type: Dependency upgrade >Affects Versions: 3.0.0-alpha-1 >Reporter: Karl Heinz Marbaise >Assignee: Karl Heinz Marbaise >Priority: Minor > Fix For: 3.0.0-alpha-2, 3.0.0 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (MJMOD-18) Upgrade parent to version 33
[ https://issues.apache.org/jira/browse/MJMOD-18?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Benjamin Marwell updated MJMOD-18: -- Fix Version/s: 3.0.0-alpha-2 > Upgrade parent to version 33 > > > Key: MJMOD-18 > URL: https://issues.apache.org/jira/browse/MJMOD-18 > Project: Maven JMod Plugin > Issue Type: Dependency upgrade >Affects Versions: 3.0.0 >Reporter: Karl Heinz Marbaise >Priority: Minor > Fix For: 3.0.0-alpha-2, 3.0.0 > > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Resolved] (MSCRIPTING-13) Remove unused dependencies
[ https://issues.apache.org/jira/browse/MSCRIPTING-13?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Benjamin Marwell resolved MSCRIPTING-13. Fix Version/s: 3.1.0 Resolution: Fixed > Remove unused dependencies > -- > > Key: MSCRIPTING-13 > URL: https://issues.apache.org/jira/browse/MSCRIPTING-13 > Project: Maven Scripting > Issue Type: Dependency upgrade >Reporter: Elliotte Rusty Harold >Assignee: Benjamin Marwell >Priority: Major > Labels: pull-request-available, up-for-grabs > Fix For: 3.1.0 > > > [WARNING] Unused declared dependencies found: > [WARNING]org.apache.maven.shared:maven-shared-utils:jar:3.3.3:compile > [WARNING]junit:junit:jar:4.12:test > [WARNING] > org.apache.maven.plugin-testing:maven-plugin-testing-harness:jar:2.1:test > [WARNING]org.apache.maven:maven-compat:jar:3.0:test -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Resolved] (MSCRIPTING-16) Update Maven plugins-parent to v41
[ https://issues.apache.org/jira/browse/MSCRIPTING-16?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Benjamin Marwell resolved MSCRIPTING-16. Resolution: Fixed > Update Maven plugins-parent to v41 > -- > > Key: MSCRIPTING-16 > URL: https://issues.apache.org/jira/browse/MSCRIPTING-16 > Project: Maven Scripting > Issue Type: Dependency upgrade >Reporter: Benjamin Marwell >Assignee: Benjamin Marwell >Priority: Major > Labels: pull-request-available > Fix For: 3.1.0 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Assigned] (MSCRIPTING-13) Remove unused dependencies
[ https://issues.apache.org/jira/browse/MSCRIPTING-13?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Benjamin Marwell reassigned MSCRIPTING-13: -- Assignee: Benjamin Marwell > Remove unused dependencies > -- > > Key: MSCRIPTING-13 > URL: https://issues.apache.org/jira/browse/MSCRIPTING-13 > Project: Maven Scripting > Issue Type: Dependency upgrade >Reporter: Elliotte Rusty Harold >Assignee: Benjamin Marwell >Priority: Major > Labels: up-for-grabs > > [WARNING] Unused declared dependencies found: > [WARNING]org.apache.maven.shared:maven-shared-utils:jar:3.3.3:compile > [WARNING]junit:junit:jar:4.12:test > [WARNING] > org.apache.maven.plugin-testing:maven-plugin-testing-harness:jar:2.1:test > [WARNING]org.apache.maven:maven-compat:jar:3.0:test -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (MSCRIPTING-16) Update Maven plugins-parent to v41
Benjamin Marwell created MSCRIPTING-16: -- Summary: Update Maven plugins-parent to v41 Key: MSCRIPTING-16 URL: https://issues.apache.org/jira/browse/MSCRIPTING-16 Project: Maven Scripting Issue Type: Dependency upgrade Reporter: Benjamin Marwell Assignee: Benjamin Marwell Fix For: 3.1.0 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Assigned] (MSCRIPTING-9) Support java scripting
[ https://issues.apache.org/jira/browse/MSCRIPTING-9?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Benjamin Marwell reassigned MSCRIPTING-9: - Assignee: Benjamin Marwell > Support java scripting > -- > > Key: MSCRIPTING-9 > URL: https://issues.apache.org/jira/browse/MSCRIPTING-9 > Project: Maven Scripting > Issue Type: Task >Reporter: Romain Manni-Bucau >Assignee: Benjamin Marwell >Priority: Major > Labels: pull-request-available > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Assigned] (MSCRIPTING-14) Add requirement history
[ https://issues.apache.org/jira/browse/MSCRIPTING-14?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Benjamin Marwell reassigned MSCRIPTING-14: -- Assignee: Benjamin Marwell > Add requirement history > --- > > Key: MSCRIPTING-14 > URL: https://issues.apache.org/jira/browse/MSCRIPTING-14 > Project: Maven Scripting > Issue Type: Task >Reporter: Benjamin Marwell >Assignee: Benjamin Marwell >Priority: Major > Labels: pull-request-available > Fix For: 3.1.0 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Resolved] (MSCRIPTING-14) Add requirement history
[ https://issues.apache.org/jira/browse/MSCRIPTING-14?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Benjamin Marwell resolved MSCRIPTING-14. Resolution: Fixed > Add requirement history > --- > > Key: MSCRIPTING-14 > URL: https://issues.apache.org/jira/browse/MSCRIPTING-14 > Project: Maven Scripting > Issue Type: Task >Reporter: Benjamin Marwell >Priority: Major > Labels: pull-request-available > Fix For: 3.1.0 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Resolved] (MSCRIPTING-15) Require Maven 3.6.3
[ https://issues.apache.org/jira/browse/MSCRIPTING-15?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Benjamin Marwell resolved MSCRIPTING-15. Resolution: Fixed > Require Maven 3.6.3 > --- > > Key: MSCRIPTING-15 > URL: https://issues.apache.org/jira/browse/MSCRIPTING-15 > Project: Maven Scripting > Issue Type: Dependency upgrade >Reporter: Benjamin Marwell >Assignee: Benjamin Marwell >Priority: Major > Labels: pull-request-available > Fix For: 3.1.0 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (MSCRIPTING-14) Add requirement history
[ https://issues.apache.org/jira/browse/MSCRIPTING-14?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Benjamin Marwell updated MSCRIPTING-14: --- Fix Version/s: 3.1.0 > Add requirement history > --- > > Key: MSCRIPTING-14 > URL: https://issues.apache.org/jira/browse/MSCRIPTING-14 > Project: Maven Scripting > Issue Type: Task >Reporter: Benjamin Marwell >Priority: Major > Labels: pull-request-available > Fix For: 3.1.0 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (MSCRIPTING-15) Require Maven 3.6.3
[ https://issues.apache.org/jira/browse/MSCRIPTING-15?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Benjamin Marwell updated MSCRIPTING-15: --- Fix Version/s: 3.1.0 > Require Maven 3.6.3 > --- > > Key: MSCRIPTING-15 > URL: https://issues.apache.org/jira/browse/MSCRIPTING-15 > Project: Maven Scripting > Issue Type: Dependency upgrade >Reporter: Benjamin Marwell >Assignee: Benjamin Marwell >Priority: Major > Labels: pull-request-available > Fix For: 3.1.0 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Moved] (MSCRIPTING-15) Require Maven 3.6.3
[ https://issues.apache.org/jira/browse/MSCRIPTING-15?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Benjamin Marwell moved MNG-8064 to MSCRIPTING-15: - Key: MSCRIPTING-15 (was: MNG-8064) Project: Maven Scripting (was: Maven) > Require Maven 3.6.3 > --- > > Key: MSCRIPTING-15 > URL: https://issues.apache.org/jira/browse/MSCRIPTING-15 > Project: Maven Scripting > Issue Type: Dependency upgrade >Reporter: Benjamin Marwell >Assignee: Benjamin Marwell >Priority: Major > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (MNG-8064) Require Maven 3.6.3
Benjamin Marwell created MNG-8064: - Summary: Require Maven 3.6.3 Key: MNG-8064 URL: https://issues.apache.org/jira/browse/MNG-8064 Project: Maven Issue Type: Dependency upgrade Reporter: Benjamin Marwell Assignee: Benjamin Marwell -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (MJLINK-81) Document requirements history
[ https://issues.apache.org/jira/browse/MJLINK-81?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Benjamin Marwell updated MJLINK-81: --- Issue Type: Task (was: Improvement) > Document requirements history > - > > Key: MJLINK-81 > URL: https://issues.apache.org/jira/browse/MJLINK-81 > Project: Maven JLink Plugin > Issue Type: Task >Reporter: Benjamin Marwell >Assignee: Benjamin Marwell >Priority: Major > Fix For: 3.3.0 > > > Add requirement history to info-plugin, like this one: > https://github.com/apache/maven-shade-plugin/blob/a8030f829180f50d4497e42e212a891ec595a059/pom.xml#L308-L355 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (MSCRIPTING-14) Add requirement history
Benjamin Marwell created MSCRIPTING-14: -- Summary: Add requirement history Key: MSCRIPTING-14 URL: https://issues.apache.org/jira/browse/MSCRIPTING-14 Project: Maven Scripting Issue Type: Task Reporter: Benjamin Marwell -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (MJLINK-81) Document requirements history
[ https://issues.apache.org/jira/browse/MJLINK-81?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Benjamin Marwell updated MJLINK-81: --- Description: Add requirement history to info-plugin, like this one: https://github.com/apache/maven-shade-plugin/blob/a8030f829180f50d4497e42e212a891ec595a059/pom.xml#L308-L355 was:Add requirement history to info-plugin > Document requirements history > - > > Key: MJLINK-81 > URL: https://issues.apache.org/jira/browse/MJLINK-81 > Project: Maven JLink Plugin > Issue Type: Improvement >Reporter: Benjamin Marwell >Assignee: Benjamin Marwell >Priority: Major > Fix For: 3.3.0 > > > Add requirement history to info-plugin, like this one: > https://github.com/apache/maven-shade-plugin/blob/a8030f829180f50d4497e42e212a891ec595a059/pom.xml#L308-L355 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (MJLINK-81) Document requirements history
Benjamin Marwell created MJLINK-81: -- Summary: Document requirements history Key: MJLINK-81 URL: https://issues.apache.org/jira/browse/MJLINK-81 Project: Maven JLink Plugin Issue Type: Improvement Reporter: Benjamin Marwell Assignee: Benjamin Marwell Fix For: 3.3.0 Add requirement history to info-plugin -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (MJLINK-81) Document requirements history
[ https://issues.apache.org/jira/browse/MJLINK-81?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Benjamin Marwell updated MJLINK-81: --- Language: XML > Document requirements history > - > > Key: MJLINK-81 > URL: https://issues.apache.org/jira/browse/MJLINK-81 > Project: Maven JLink Plugin > Issue Type: Improvement >Reporter: Benjamin Marwell >Assignee: Benjamin Marwell >Priority: Major > Fix For: 3.3.0 > > > Add requirement history to info-plugin -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (MNG-8061) Upgrade Maven runtime requirement to Java 17
Benjamin Marwell created MNG-8061: - Summary: Upgrade Maven runtime requirement to Java 17 Key: MNG-8061 URL: https://issues.apache.org/jira/browse/MNG-8061 Project: Maven Issue Type: Task Components: API, Core, POM Reporter: Benjamin Marwell Update Maven and its plugins to Java 17 by replacing maven.compiler.* with maven.compiler.release and setting the language level to 17. This issue and its PR need a vote -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MENFORCER-499) New Rule: Prohibit specific files to be checked in
[
https://issues.apache.org/jira/browse/MENFORCER-499?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17818694#comment-17818694
]
Benjamin Marwell commented on MENFORCER-499:
Not much. Just a little harder to circumvent, and it is checked in CI (which is
the biggest plus). gitignore: you can just use {{git add -f $path}}. The check,
if it is defined in a parent pom, is way harder to circumvent (though still
easily possible if you know what you are doing). But developers would get way
more immediate feedback. And it is much clearer in a Pull Request / Change
Request to see whether a parent-defined execution was tampered with...
> New Rule: Prohibit specific files to be checked in
> --
>
> Key: MENFORCER-499
> URL: https://issues.apache.org/jira/browse/MENFORCER-499
> Project: Maven Enforcer Plugin
> Issue Type: New Feature
> Components: Standard Rules
>Reporter: Benjamin Marwell
>Priority: Major
>
> This is a suggestion for yet another new standard rule.
> "require Files not checked in"
> While there are already rules "require files don't exist" and "require file
> size", this one would check wether files are actually checked in or added
> into the current VCS.
> E.g. for each file in the pattern:
> * check if they are added (git, bzr) or checked in (cvs, svn, bzr, git)
> * If so, fail the build.
> configurable options:
> * files (like the other two checks, ant pattern)
> * failOnAdd (git, bzr): true by default, can be set to false. Then the check
> will only fail if files are currently in a commit.
> * useDefaultExclusions: Read exclusion rules from VCS (git: .gitignore, svn:
> svn:ignore, etc.). However, files could have been forcibly added in git. So
> maybe this doesn't make much sense
> * skip
> * ..?
> The idea is to prevent developers from accidentally check in big files (like
> jar files, zip files) or other binary artifacts. While this could be spotted
> in a PR, the repo might already be spoiled and enlarged by this size, which
> is usually not feasible.
> Alternatives:
> * use "files don't exist" and exclude target (may not work for everyone)
> * use a shell script
> * don't implement this rule and leave the task to others.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Created] (MENFORCER-499) New Rule: Prohibit specific files to be checked in
Benjamin Marwell created MENFORCER-499: -- Summary: New Rule: Prohibit specific files to be checked in Key: MENFORCER-499 URL: https://issues.apache.org/jira/browse/MENFORCER-499 Project: Maven Enforcer Plugin Issue Type: New Feature Components: Standard Rules Reporter: Benjamin Marwell This is a suggestion for yet another new standard rule. "require Files not checked in" While there are already rules "require files don't exist" and "require file size", this one would check wether files are actually checked in or added into the current VCS. E.g. for each file in the pattern: * check if they are added (git, bzr) or checked in (cvs, svn, bzr, git) * If so, fail the build. configurable options: * files (like the other two checks, ant pattern) * failOnAdd (git, bzr): true by default, can be set to false. Then the check will only fail if files are currently in a commit. * useDefaultExclusions: Read exclusion rules from VCS (git: .gitignore, svn: svn:ignore, etc.). However, files could have been forcibly added in git. So maybe this doesn't make much sense * skip * ..? The idea is to prevent developers from accidentally check in big files (like jar files, zip files) or other binary artifacts. While this could be spotted in a PR, the repo might already be spoiled and enlarged by this size, which is usually not feasible. Alternatives: * use "files don't exist" and exclude target (may not work for everyone) * use a shell script * don't implement this rule and leave the task to others. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MWRAPPER-91) Concurrent execution of mvnw to download wrapper fails
[
https://issues.apache.org/jira/browse/MWRAPPER-91?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17816123#comment-17816123
]
Benjamin Marwell commented on MWRAPPER-91:
--
[~ahus1] do you, by chance, know which scripts are affected? We have multiple
wrappers, the "most modern" option at the moment being only-mvnw,
See the "without binary" section here:
https://maven.apache.org/wrapper/index.html
> Concurrent execution of mvnw to download wrapper fails
> --
>
> Key: MWRAPPER-91
> URL: https://issues.apache.org/jira/browse/MWRAPPER-91
> Project: Maven Wrapper
> Issue Type: Bug
> Components: Maven Wrapper Scripts
>Affects Versions: 3.1.0
>Reporter: Alexander Schwartz
>Assignee: Benjamin Marwell
>Priority: Major
>
> The script will download the executable maven wrapper JAR file directly to
> the final file name.
> When multiple calls do this concurrently, it happens that the first call
> executes the JAR file that is currently overwritten by the second parallel
> call.
> This leads to error like:
> * {{NoClassDefFoundError: org/codehaus/plexus/PlexusContainer}}
> * {{ClassNotFoundException: org.apache.maven.wrapper.MavenWrapperMain}}
> A different solution might be to first download the JAR file to a temporary
> file, and then use an atomic file operator like a rename one the download is
> complete.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Assigned] (MWRAPPER-108) mvnw script fails silently when download fails
[ https://issues.apache.org/jira/browse/MWRAPPER-108?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Benjamin Marwell reassigned MWRAPPER-108: - Assignee: Benjamin Marwell > mvnw script fails silently when download fails > -- > > Key: MWRAPPER-108 > URL: https://issues.apache.org/jira/browse/MWRAPPER-108 > Project: Maven Wrapper > Issue Type: Bug > Components: Maven Wrapper Scripts >Affects Versions: 3.2.0 >Reporter: selckin >Assignee: Benjamin Marwell >Priority: Major > > The wrapper only-mvnw script fail silently when the download fails, giving a > cryptic error when trying to run mvn > https://github.com/apache/maven-wrapper/pull/98 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Assigned] (MWRAPPER-86) Trim trailing slash in Repo URL
[
https://issues.apache.org/jira/browse/MWRAPPER-86?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Benjamin Marwell reassigned MWRAPPER-86:
Assignee: Benjamin Marwell
> Trim trailing slash in Repo URL
> ---
>
> Key: MWRAPPER-86
> URL: https://issues.apache.org/jira/browse/MWRAPPER-86
> Project: Maven Wrapper
> Issue Type: Bug
> Components: Maven Wrapper Plugin
>Affects Versions: 3.1.1
>Reporter: Björn Michael
>Assignee: Benjamin Marwell
>Priority: Major
>
> If repository URL ends with a trailing slash then the URLs in
> {{maven-wrapper.properties}} contain double slashes.
> E.g. {{MVNW_REPOURL=[https://myrepo.local/]}} ends up with
> {code:java}
> distributionUrl=https://myrepo.local//org/apache/maven/apache-maven/3.8.7/apache-maven-3.8.7-bin.zip
> wrapperUrl=https://myrepo.local//org/apache/maven/wrapper/maven-wrapper/3.1.1/maven-wrapper-3.1.1.jar{code}
> This also occurs when mirror * URL ends with trailing slash.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Assigned] (MWRAPPER-91) Concurrent execution of mvnw to download wrapper fails
[
https://issues.apache.org/jira/browse/MWRAPPER-91?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Benjamin Marwell reassigned MWRAPPER-91:
Assignee: Benjamin Marwell
> Concurrent execution of mvnw to download wrapper fails
> --
>
> Key: MWRAPPER-91
> URL: https://issues.apache.org/jira/browse/MWRAPPER-91
> Project: Maven Wrapper
> Issue Type: Bug
> Components: Maven Wrapper Scripts
>Affects Versions: 3.1.0
>Reporter: Alexander Schwartz
>Assignee: Benjamin Marwell
>Priority: Major
>
> The script will download the executable maven wrapper JAR file directly to
> the final file name.
> When multiple calls do this concurrently, it happens that the first call
> executes the JAR file that is currently overwritten by the second parallel
> call.
> This leads to error like:
> * {{NoClassDefFoundError: org/codehaus/plexus/PlexusContainer}}
> * {{ClassNotFoundException: org.apache.maven.wrapper.MavenWrapperMain}}
> A different solution might be to first download the JAR file to a temporary
> file, and then use an atomic file operator like a rename one the download is
> complete.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Resolved] (MWRAPPER-113) Error and warning output goes to standard output and intermingles with Maven output
[
https://issues.apache.org/jira/browse/MWRAPPER-113?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Benjamin Marwell resolved MWRAPPER-113.
---
Resolution: Fixed
> Error and warning output goes to standard output and intermingles with Maven
> output
> ---
>
> Key: MWRAPPER-113
> URL: https://issues.apache.org/jira/browse/MWRAPPER-113
> Project: Maven Wrapper
> Issue Type: Bug
> Components: Maven Wrapper Scripts
>Affects Versions: 3.2.0, 3.3.0
>Reporter: Ingo Karkat
>Assignee: Benjamin Marwell
>Priority: Trivial
> Labels: pull-request-available
> Fix For: 3.3.0
>
>
> Errors and warnings from the wrapper should go to standard error, so that
> those are also shown to the user when the regular Maven output is suppressed,
> redirected into a file, or captured by a script.
> For the latter use case, separation is especially critical because otherwise
> error output is mistakenly interpreted as desired Maven output (for example,
> when obtaining the list of Maven project names in the reactor with {{mvnw
> --quiet -Dexec.executable=echo
> '-Dexec.args=${project.groupId}:${project.artifactId}'
> org.codehaus.mojo:exec-maven-plugin:exec}}).
> The current wrapper scripts do this only inconsistently, and so warnings like
> {{Warning: JAVA_HOME environment variable is not set.}} are printed to stdout
> instead of stderr.
> Pull request: https://github.com/apache/maven-wrapper/pull/106
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Assigned] (MWRAPPER-113) Error and warning output goes to standard output and intermingles with Maven output
[
https://issues.apache.org/jira/browse/MWRAPPER-113?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Benjamin Marwell reassigned MWRAPPER-113:
-
Assignee: Benjamin Marwell
> Error and warning output goes to standard output and intermingles with Maven
> output
> ---
>
> Key: MWRAPPER-113
> URL: https://issues.apache.org/jira/browse/MWRAPPER-113
> Project: Maven Wrapper
> Issue Type: Bug
> Components: Maven Wrapper Scripts
>Affects Versions: 3.2.0, 3.3.0
>Reporter: Ingo Karkat
>Assignee: Benjamin Marwell
>Priority: Trivial
> Labels: pull-request-available
> Fix For: 3.3.0
>
>
> Errors and warnings from the wrapper should go to standard error, so that
> those are also shown to the user when the regular Maven output is suppressed,
> redirected into a file, or captured by a script.
> For the latter use case, separation is especially critical because otherwise
> error output is mistakenly interpreted as desired Maven output (for example,
> when obtaining the list of Maven project names in the reactor with {{mvnw
> --quiet -Dexec.executable=echo
> '-Dexec.args=${project.groupId}:${project.artifactId}'
> org.codehaus.mojo:exec-maven-plugin:exec}}).
> The current wrapper scripts do this only inconsistently, and so warnings like
> {{Warning: JAVA_HOME environment variable is not set.}} are printed to stdout
> instead of stderr.
> Pull request: https://github.com/apache/maven-wrapper/pull/106
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Updated] (MWRAPPER-113) Error and warning output goes to standard output and intermingles with Maven output
[
https://issues.apache.org/jira/browse/MWRAPPER-113?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Benjamin Marwell updated MWRAPPER-113:
--
Fix Version/s: 3.3.0
> Error and warning output goes to standard output and intermingles with Maven
> output
> ---
>
> Key: MWRAPPER-113
> URL: https://issues.apache.org/jira/browse/MWRAPPER-113
> Project: Maven Wrapper
> Issue Type: Bug
> Components: Maven Wrapper Scripts
>Affects Versions: 3.2.0, 3.3.0
>Reporter: Ingo Karkat
>Priority: Trivial
> Labels: pull-request-available
> Fix For: 3.3.0
>
>
> Errors and warnings from the wrapper should go to standard error, so that
> those are also shown to the user when the regular Maven output is suppressed,
> redirected into a file, or captured by a script.
> For the latter use case, separation is especially critical because otherwise
> error output is mistakenly interpreted as desired Maven output (for example,
> when obtaining the list of Maven project names in the reactor with {{mvnw
> --quiet -Dexec.executable=echo
> '-Dexec.args=${project.groupId}:${project.artifactId}'
> org.codehaus.mojo:exec-maven-plugin:exec}}).
> The current wrapper scripts do this only inconsistently, and so warnings like
> {{Warning: JAVA_HOME environment variable is not set.}} are printed to stdout
> instead of stderr.
> Pull request: https://github.com/apache/maven-wrapper/pull/106
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Updated] (MWRAPPER-123) only-mvnw fails on ksh printf implementations
[
https://issues.apache.org/jira/browse/MWRAPPER-123?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Benjamin Marwell updated MWRAPPER-123:
--
Description:
the script {{only-mvnw}} contains this snippet in a line to calculate a hash:
{code:bash}
printf %d "'$str"
{code}
The idea is to convert {{$str}} to a number, where {{'}} has a special meaning
for {{%d}} conversion. However, there is a major problem with it:
It does not work on any ksh (and maybe other shells, too), because the
behaviour of this conversion is undefined:
https://pubs.opengroup.org/onlinepubs/9699919799/functions/printf.html
Instead, just do a conversion char-by-char.
was:
the script {{only-mvnw}} contains this snippet in a line to calculate a hash:
{code:bash}
printf %d "'$str"
{code}
The idea is to convert {{$str}} to a number, where {{'}} has a special meaning
for {{%d}} conversion. However, there are two problems with it:
1. It does not work on ksh on AIX (because this conversion is not posix
compliant), so the script will not run on AIX.
2. It will only use the first letter, which is alway {{h}} (from the string
always being a valid URI).
For now, replace it with the ASCII constant 104 (ASCII value of h). The
intended behaviour can be restored in another PR if feasible.
> only-mvnw fails on ksh printf implementations
> -
>
> Key: MWRAPPER-123
> URL: https://issues.apache.org/jira/browse/MWRAPPER-123
> Project: Maven Wrapper
> Issue Type: Bug
>Affects Versions: 3.1.1
>Reporter: Benjamin Marwell
>Assignee: Benjamin Marwell
>Priority: Urgent
> Fix For: 3.3.0
>
>
> the script {{only-mvnw}} contains this snippet in a line to calculate a hash:
> {code:bash}
> printf %d "'$str"
> {code}
> The idea is to convert {{$str}} to a number, where {{'}} has a special
> meaning for {{%d}} conversion. However, there is a major problem with it:
> It does not work on any ksh (and maybe other shells, too), because the
> behaviour of this conversion is undefined:
> https://pubs.opengroup.org/onlinepubs/9699919799/functions/printf.html
> Instead, just do a conversion char-by-char.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Updated] (MWRAPPER-123) only-mvnw fails on ksh printf implementations
[
https://issues.apache.org/jira/browse/MWRAPPER-123?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Benjamin Marwell updated MWRAPPER-123:
--
Summary: only-mvnw fails on ksh printf implementations (was: only-mvnw
fails on AIX' ksh implementation)
> only-mvnw fails on ksh printf implementations
> -
>
> Key: MWRAPPER-123
> URL: https://issues.apache.org/jira/browse/MWRAPPER-123
> Project: Maven Wrapper
> Issue Type: Bug
>Affects Versions: 3.1.1
>Reporter: Benjamin Marwell
>Assignee: Benjamin Marwell
>Priority: Urgent
> Fix For: 3.3.0
>
>
> the script {{only-mvnw}} contains this snippet in a line to calculate a hash:
> {code:bash}
> printf %d "'$str"
> {code}
> The idea is to convert {{$str}} to a number, where {{'}} has a special
> meaning for {{%d}} conversion. However, there are two problems with it:
> 1. It does not work on ksh on AIX (because this conversion is not posix
> compliant), so the script will not run on AIX.
> 2. It will only use the first letter, which is alway {{h}} (from the string
> always being a valid URI).
> For now, replace it with the ASCII constant 104 (ASCII value of h). The
> intended behaviour can be restored in another PR if feasible.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Resolved] (MWRAPPER-112) Detection of JAVA_HOME fails due to bad quoting
[
https://issues.apache.org/jira/browse/MWRAPPER-112?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Benjamin Marwell resolved MWRAPPER-112.
---
Resolution: Fixed
> Detection of JAVA_HOME fails due to bad quoting
> ---
>
> Key: MWRAPPER-112
> URL: https://issues.apache.org/jira/browse/MWRAPPER-112
> Project: Maven Wrapper
> Issue Type: Bug
>Affects Versions: 3.2.0, 3.3.0
> Environment: Ubuntu 20.04, Java 17
>Reporter: Ingo Karkat
>Assignee: Benjamin Marwell
>Priority: Trivial
> Labels: pull-request-available
> Fix For: 3.3.0
>
>
> I have a standard Ubuntu 20.04 Java installation ({{{}openjdk-17-jdk{}}} APT
> package, {{/usr/bin/javac}} linked to
> {{/usr/lib/jvm/java-17-openjdk-amd64/bin/javac}} via the update-alternatives
> system, no {{JAVA_HOME}} set). Maven Wrapper 3.2.0 should detect that, but on
> each invocation prints this warning:
> {{Warning: JAVA_HOME environment variable is not set.}}
> This is caused by excessive quoting (i.e. the {{{}\"{}}}):
> {{javaExecutable="$(readlink -f "\"$javaExecutable\"")"}}
> Apparently, that code has been in the codebase since the beginning, taken
> over from the {{gradlew}} wrapper (which had the shell wrappers completely
> rewritten; there are no remnants of this code found there any longer).
> Pull request: https://github.com/apache/maven-wrapper/pull/102
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Resolved] (MWRAPPER-121) Specifying an invalid version will make the mvnw script output nothing instead of an error
[
https://issues.apache.org/jira/browse/MWRAPPER-121?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Benjamin Marwell resolved MWRAPPER-121.
---
Resolution: Duplicate
> Specifying an invalid version will make the mvnw script output nothing
> instead of an error
> --
>
> Key: MWRAPPER-121
> URL: https://issues.apache.org/jira/browse/MWRAPPER-121
> Project: Maven Wrapper
> Issue Type: Bug
> Components: Maven Wrapper Scripts
>Affects Versions: 3.2.0
>Reporter: Benjamin Marwell
>Priority: Major
>
> Given the following setup:
> {code}
> mvn wrapper:wrapper -Dmaven=4.0.0-alpha-8 -Dtype=only-script
> {code}
> The output of the created {{./mvnw}} script is empty, because the 404 wget
> error will not be handled.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Updated] (MWRAPPER-112) Detection of JAVA_HOME fails due to bad quoting
[
https://issues.apache.org/jira/browse/MWRAPPER-112?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Benjamin Marwell updated MWRAPPER-112:
--
Fix Version/s: next-release
> Detection of JAVA_HOME fails due to bad quoting
> ---
>
> Key: MWRAPPER-112
> URL: https://issues.apache.org/jira/browse/MWRAPPER-112
> Project: Maven Wrapper
> Issue Type: Bug
>Affects Versions: 3.2.0, next-release
> Environment: Ubuntu 20.04, Java 17
>Reporter: Ingo Karkat
>Assignee: Benjamin Marwell
>Priority: Trivial
> Labels: pull-request-available
> Fix For: next-release
>
>
> I have a standard Ubuntu 20.04 Java installation ({{{}openjdk-17-jdk{}}} APT
> package, {{/usr/bin/javac}} linked to
> {{/usr/lib/jvm/java-17-openjdk-amd64/bin/javac}} via the update-alternatives
> system, no {{JAVA_HOME}} set). Maven Wrapper 3.2.0 should detect that, but on
> each invocation prints this warning:
> {{Warning: JAVA_HOME environment variable is not set.}}
> This is caused by excessive quoting (i.e. the {{{}\"{}}}):
> {{javaExecutable="$(readlink -f "\"$javaExecutable\"")"}}
> Apparently, that code has been in the codebase since the beginning, taken
> over from the {{gradlew}} wrapper (which had the shell wrappers completely
> rewritten; there are no remnants of this code found there any longer).
> Pull request: https://github.com/apache/maven-wrapper/pull/102
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Assigned] (MWRAPPER-112) Detection of JAVA_HOME fails due to bad quoting
[
https://issues.apache.org/jira/browse/MWRAPPER-112?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Benjamin Marwell reassigned MWRAPPER-112:
-
Assignee: Benjamin Marwell
> Detection of JAVA_HOME fails due to bad quoting
> ---
>
> Key: MWRAPPER-112
> URL: https://issues.apache.org/jira/browse/MWRAPPER-112
> Project: Maven Wrapper
> Issue Type: Bug
>Affects Versions: 3.2.0, next-release
> Environment: Ubuntu 20.04, Java 17
>Reporter: Ingo Karkat
>Assignee: Benjamin Marwell
>Priority: Trivial
> Labels: pull-request-available
>
> I have a standard Ubuntu 20.04 Java installation ({{{}openjdk-17-jdk{}}} APT
> package, {{/usr/bin/javac}} linked to
> {{/usr/lib/jvm/java-17-openjdk-amd64/bin/javac}} via the update-alternatives
> system, no {{JAVA_HOME}} set). Maven Wrapper 3.2.0 should detect that, but on
> each invocation prints this warning:
> {{Warning: JAVA_HOME environment variable is not set.}}
> This is caused by excessive quoting (i.e. the {{{}\"{}}}):
> {{javaExecutable="$(readlink -f "\"$javaExecutable\"")"}}
> Apparently, that code has been in the codebase since the beginning, taken
> over from the {{gradlew}} wrapper (which had the shell wrappers completely
> rewritten; there are no remnants of this code found there any longer).
> Pull request: https://github.com/apache/maven-wrapper/pull/102
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Resolved] (MWRAPPER-123) only-mvnw fails on AIX' ksh implementation
[
https://issues.apache.org/jira/browse/MWRAPPER-123?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Benjamin Marwell resolved MWRAPPER-123.
---
Resolution: Fixed
> only-mvnw fails on AIX' ksh implementation
> --
>
> Key: MWRAPPER-123
> URL: https://issues.apache.org/jira/browse/MWRAPPER-123
> Project: Maven Wrapper
> Issue Type: Bug
>Affects Versions: 3.1.1
>Reporter: Benjamin Marwell
>Assignee: Benjamin Marwell
>Priority: Urgent
> Fix For: next-release
>
>
> the script {{only-mvnw}} contains this snippet in a line to calculate a hash:
> {code:bash}
> printf %d "'$str"
> {code}
> The idea is to convert {{$str}} to a number, where {{'}} has a special
> meaning for {{%d}} conversion. However, there are two problems with it:
> 1. It does not work on ksh on AIX (because this conversion is not posix
> compliant), so the script will not run on AIX.
> 2. It will only use the first letter, which is alway {{h}} (from the string
> always being a valid URI).
> For now, replace it with the ASCII constant 104 (ASCII value of h). The
> intended behaviour can be restored in another PR if feasible.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Updated] (MWRAPPER-123) only-mvnw fails on AIX' ksh implementation
[
https://issues.apache.org/jira/browse/MWRAPPER-123?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Benjamin Marwell updated MWRAPPER-123:
--
Fix Version/s: next-release
> only-mvnw fails on AIX' ksh implementation
> --
>
> Key: MWRAPPER-123
> URL: https://issues.apache.org/jira/browse/MWRAPPER-123
> Project: Maven Wrapper
> Issue Type: Bug
>Affects Versions: 3.1.1
>Reporter: Benjamin Marwell
>Assignee: Benjamin Marwell
>Priority: Urgent
> Fix For: next-release
>
>
> the script {{only-mvnw}} contains this snippet in a line to calculate a hash:
> {code:bash}
> printf %d "'$str"
> {code}
> The idea is to convert {{$str}} to a number, where {{'}} has a special
> meaning for {{%d}} conversion. However, there are two problems with it:
> 1. It does not work on ksh on AIX (because this conversion is not posix
> compliant), so the script will not run on AIX.
> 2. It will only use the first letter, which is alway {{h}} (from the string
> always being a valid URI).
> For now, replace it with the ASCII constant 104 (ASCII value of h). The
> intended behaviour can be restored in another PR if feasible.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Assigned] (MWRAPPER-123) only-mvnw fails on AIX' ksh implementation
[
https://issues.apache.org/jira/browse/MWRAPPER-123?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Benjamin Marwell reassigned MWRAPPER-123:
-
Assignee: Benjamin Marwell
> only-mvnw fails on AIX' ksh implementation
> --
>
> Key: MWRAPPER-123
> URL: https://issues.apache.org/jira/browse/MWRAPPER-123
> Project: Maven Wrapper
> Issue Type: Bug
>Affects Versions: 3.1.1
>Reporter: Benjamin Marwell
>Assignee: Benjamin Marwell
>Priority: Urgent
>
> the script {{only-mvnw}} contains this snippet in a line to calculate a hash:
> {code:bash}
> printf %d "'$str"
> {code}
> The idea is to convert {{$str}} to a number, where {{'}} has a special
> meaning for {{%d}} conversion. However, there are two problems with it:
> 1. It does not work on ksh on AIX (because this conversion is not posix
> compliant), so the script will not run on AIX.
> 2. It will only use the first letter, which is alway {{h}} (from the string
> always being a valid URI).
> For now, replace it with the ASCII constant 104 (ASCII value of h). The
> intended behaviour can be restored in another PR if feasible.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Assigned] (MWRAPPER-120) Maven wrapper plugin should not create wrapperUrl property for script-only mode
[ https://issues.apache.org/jira/browse/MWRAPPER-120?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Benjamin Marwell reassigned MWRAPPER-120: - Assignee: Brian Demers > Maven wrapper plugin should not create wrapperUrl property for script-only > mode > --- > > Key: MWRAPPER-120 > URL: https://issues.apache.org/jira/browse/MWRAPPER-120 > Project: Maven Wrapper > Issue Type: Bug >Reporter: Brian Demers >Assignee: Brian Demers >Priority: Major > Fix For: next-release > > > The `script-only` mode of the wrapper:wrapper should not add the `wrapperUrl` > to `maven-wrapper.properties` as this property is not used. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Resolved] (MWRAPPER-104) Add prettier config for shell scripts
[ https://issues.apache.org/jira/browse/MWRAPPER-104?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Benjamin Marwell resolved MWRAPPER-104. --- Resolution: Fixed > Add prettier config for shell scripts > - > > Key: MWRAPPER-104 > URL: https://issues.apache.org/jira/browse/MWRAPPER-104 > Project: Maven Wrapper > Issue Type: Improvement > Components: Maven Wrapper Scripts >Reporter: Benjamin Marwell >Assignee: Slawomir Jaranowski >Priority: Normal > Fix For: next-release > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (MWRAPPER-120) Maven wrapper plugin should not create wrapperUrl property for script-only mode
[ https://issues.apache.org/jira/browse/MWRAPPER-120?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Benjamin Marwell updated MWRAPPER-120: -- Fix Version/s: next-release > Maven wrapper plugin should not create wrapperUrl property for script-only > mode > --- > > Key: MWRAPPER-120 > URL: https://issues.apache.org/jira/browse/MWRAPPER-120 > Project: Maven Wrapper > Issue Type: Bug >Reporter: Brian Demers >Priority: Major > Fix For: next-release > > > The `script-only` mode of the wrapper:wrapper should not add the `wrapperUrl` > to `maven-wrapper.properties` as this property is not used. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (MWRAPPER-104) Add prettier config for shell scripts
[ https://issues.apache.org/jira/browse/MWRAPPER-104?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Benjamin Marwell updated MWRAPPER-104: -- Fix Version/s: next-release > Add prettier config for shell scripts > - > > Key: MWRAPPER-104 > URL: https://issues.apache.org/jira/browse/MWRAPPER-104 > Project: Maven Wrapper > Issue Type: Improvement > Components: Maven Wrapper Scripts >Reporter: Benjamin Marwell >Assignee: Slawomir Jaranowski >Priority: Normal > Fix For: next-release > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Closed] (MJLINK-71) Require Maven 3.6.3 as new baseline
[ https://issues.apache.org/jira/browse/MJLINK-71?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Benjamin Marwell closed MJLINK-71. -- > Require Maven 3.6.3 as new baseline > --- > > Key: MJLINK-71 > URL: https://issues.apache.org/jira/browse/MJLINK-71 > Project: Maven JLink Plugin > Issue Type: Dependency upgrade >Reporter: Benjamin Marwell >Assignee: Benjamin Marwell >Priority: Major > Fix For: 3.2.0 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Closed] (MJLINK-76) Upgrade maven-plugin parent to 41
[ https://issues.apache.org/jira/browse/MJLINK-76?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Benjamin Marwell closed MJLINK-76. -- > Upgrade maven-plugin parent to 41 > - > > Key: MJLINK-76 > URL: https://issues.apache.org/jira/browse/MJLINK-76 > Project: Maven JLink Plugin > Issue Type: Improvement >Affects Versions: 3.1.0 >Reporter: Karl Heinz Marbaise >Assignee: Karl Heinz Marbaise >Priority: Minor > Fix For: 3.2.0 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Closed] (MJLINK-77) Update description and parameters of --compress to reflect JDK21 changes
[
https://issues.apache.org/jira/browse/MJLINK-77?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Benjamin Marwell closed MJLINK-77.
--
> Update description and parameters of --compress to reflect JDK21 changes
>
>
> Key: MJLINK-77
> URL: https://issues.apache.org/jira/browse/MJLINK-77
> Project: Maven JLink Plugin
> Issue Type: Task
>Reporter: Benjamin Marwell
>Assignee: Benjamin Marwell
>Priority: Major
> Fix For: 3.2.0
>
>
> Starting from Java 21, the allowed parameters for {{compress}} have changed,
> and the old ones are suspect to removal:
> {code:java}
> $ jlink --help
> […]
> --compress Compression to use in compressing
> resources:
> Accepted values are:
> zip-[0-9], where zip-0 provides no
> compression,
> and zip-9 provides the best
> compression.
> Default is zip-6.
> Deprecated values to be removed in a
> future release:
> 0: No compression. Equivalent to
> zip-0.
> 1: Constant String Sharing
> 2: Equivalent to zip-6.
> {code}
> Thus, the current jlink-plugin is incompatible with Java 21:
> {code:java}
> /**
> * Here you can define the compression of the resources being used. The
> command line equivalent is:
> * -c, --compress=level. The valid values for the level
> are: 0, 1, 2.
> */
> @Parameter
> private Integer compress;
> {code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Closed] (MJLINK-70) Update m-site-p to 3.12.1
[ https://issues.apache.org/jira/browse/MJLINK-70?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Benjamin Marwell closed MJLINK-70. -- > Update m-site-p to 3.12.1 > - > > Key: MJLINK-70 > URL: https://issues.apache.org/jira/browse/MJLINK-70 > Project: Maven JLink Plugin > Issue Type: Dependency upgrade >Reporter: Benjamin Marwell >Assignee: Benjamin Marwell >Priority: Major > Fix For: 3.2.0 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Closed] (MJLINK-69) Update to Java 11
[
https://issues.apache.org/jira/browse/MJLINK-69?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Benjamin Marwell closed MJLINK-69.
--
> Update to Java 11
> -
>
> Key: MJLINK-69
> URL: https://issues.apache.org/jira/browse/MJLINK-69
> Project: Maven JLink Plugin
> Issue Type: Improvement
>Reporter: Benjamin Marwell
>Assignee: Benjamin Marwell
>Priority: Major
> Labels: java1.8, java11
> Fix For: 3.2.0
>
>
> Due to the recent changes in the Jenkinsfiles which are now streamlined, this
> plugin is not tested anymore with toolchains. That means, we currently do not
> test with Java 8 running Maven and Java 11 Toolchains.
> However, as this is an improbable and unlikely scenario, we can do the
> following:
> * Require Java 11 for the plugin
> * Move classes from the {{java9}} source folder to the {{java}} source folder
> We *could* move to Java 9 only, but I do not see any benefit from using a
> long-dead non-LTS version as a baseline.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Closed] (MJLINK-64) Add-options double quoting
[
https://issues.apache.org/jira/browse/MJLINK-64?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Benjamin Marwell closed MJLINK-64.
--
> Add-options double quoting
> --
>
> Key: MJLINK-64
> URL: https://issues.apache.org/jira/browse/MJLINK-64
> Project: Maven JLink Plugin
> Issue Type: Bug
>Affects Versions: 3.1.0
>Reporter: Tigran Sargsyan
>Assignee: Benjamin Marwell
>Priority: Major
> Fix For: 3.2.0
>
>
> In case of add multiple options via **, they are combined to one
> in runtime. For example :
>
> {code:java}
>
> -Darg1=value1
> -Darg2=value2
>
> {code}
>
>
> In runtime for the following code:
>
> {code:java}
> System.out.println(System.getProperty("arg1"));
> System.out.println(System.getProperty("arg2"));
>
> {code}
> Output is:
>
> {code:java}
> value1 -Darg2=value2
> null
> {code}
>
>
> After I examined the source code, I noticed that in fact, in the final
> command, it turns out something like '*"-Darg1 = value1 -Darg2 = value2"'*
> instead of *"-Darg1 = value1 -Darg2 = value2"*.
> I.e +double quoting.+
> _*My seggesion:*_
> Remove reduntant quoting in file *JlinkMojo(line:657).*
>
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Closed] (MJLINK-72) Remove common-lang3
[ https://issues.apache.org/jira/browse/MJLINK-72?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Benjamin Marwell closed MJLINK-72. -- > Remove common-lang3 > --- > > Key: MJLINK-72 > URL: https://issues.apache.org/jira/browse/MJLINK-72 > Project: Maven JLink Plugin > Issue Type: Dependency upgrade >Reporter: Benjamin Marwell >Assignee: Benjamin Marwell >Priority: Major > Fix For: 3.2.0 > > > common-lang3 is only used for very few operations and can be removed. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Closed] (MJLINK-62) Replace ByteArrayOutputStream with StringWriter
[ https://issues.apache.org/jira/browse/MJLINK-62?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Benjamin Marwell closed MJLINK-62. -- > Replace ByteArrayOutputStream with StringWriter > --- > > Key: MJLINK-62 > URL: https://issues.apache.org/jira/browse/MJLINK-62 > Project: Maven JLink Plugin > Issue Type: Bug >Affects Versions: 3.1.0 >Reporter: Benjamin Marwell >Assignee: Benjamin Marwell >Priority: Major > Labels: encoding > Fix For: 3.2.0 > > > Currently a BAOS exists to capture JLinks output. > Replacing it with StringWriter would preserve the platform’s encoding. > Reference: > https://github.com/apache/maven-jlink-plugin/blob/f8bdf5050c266854524aaa51eb36109c00ca692a/src/main/java9/org/apache/maven/plugins/jlink/JLinkExecutor.java#L72-L75 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Closed] (MJLINK-66) Update parent pom to 39
[ https://issues.apache.org/jira/browse/MJLINK-66?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Benjamin Marwell closed MJLINK-66. -- > Update parent pom to 39 > --- > > Key: MJLINK-66 > URL: https://issues.apache.org/jira/browse/MJLINK-66 > Project: Maven JLink Plugin > Issue Type: Dependency upgrade >Reporter: Elliotte Rusty Harold >Assignee: Benjamin Marwell >Priority: Major > Fix For: 3.2.0 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Closed] (MJLINK-63) Upgrade plexus-java
[ https://issues.apache.org/jira/browse/MJLINK-63?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Benjamin Marwell closed MJLINK-63. -- > Upgrade plexus-java > --- > > Key: MJLINK-63 > URL: https://issues.apache.org/jira/browse/MJLINK-63 > Project: Maven JLink Plugin > Issue Type: Dependency upgrade >Reporter: Benjamin Marwell >Assignee: Benjamin Marwell >Priority: Minor > Fix For: 3.2.0 > > > Fixes: > * [Duplicate module handled > incorrectly|https://github.com/codehaus-plexus/plexus-languages/issues/54] > * [read of JPMS multi-release jars fails if a newer version than supported > is > present|https://github.com/codehaus-plexus/plexus-languages/commit/020a7f208956eddb8938ef7f2c56250db55f059e] -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (MWRAPPER-123) only-mvnw fails on AIX' ksh implementation
Benjamin Marwell created MWRAPPER-123:
-
Summary: only-mvnw fails on AIX' ksh implementation
Key: MWRAPPER-123
URL: https://issues.apache.org/jira/browse/MWRAPPER-123
Project: Maven Wrapper
Issue Type: Bug
Affects Versions: 3.1.1
Reporter: Benjamin Marwell
the script {{only-mvnw}} contains this snippet in a line to calculate a hash:
{code:bash}
printf %d "'$str"
{code}
The idea is to convert {{$str}} to a number, where {{'}} has a special meaning
for {{%d}} conversion. However, there are two problems with it:
1. It does not work on ksh on AIX (because this conversion is not posix
compliant), so the script will not run on AIX.
2. It will only use the first letter, which is alway {{h}} (from the string
always being a valid URI).
For now, replace it with the ASCII constant 104 (ASCII value of h). The
intended behaviour can be restored in another PR if feasible.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MJLINK-75) Reproducibility of ZIP artifacts
[
https://issues.apache.org/jira/browse/MJLINK-75?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17809779#comment-17809779
]
Benjamin Marwell commented on MJLINK-75:
Hi, thanks for the clarification. In my mind, the jlink executable created the
zip file, which was obviously wrong. Thanks [~hboutemy] for chiming in!
> Reproducibility of ZIP artifacts
>
>
> Key: MJLINK-75
> URL: https://issues.apache.org/jira/browse/MJLINK-75
> Project: Maven JLink Plugin
> Issue Type: New Feature
>Affects Versions: 3.1.0
>Reporter: Piotr Karwasz
>Assignee: Herve Boutemy
>Priority: Minor
> Fix For: 3.2.0
>
>
> The artifacts produced by this plugin do not use the
> {{'project.build.outputTimestamp'}} property for the ZIP file entries and
> therefore are not reproducible.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Assigned] (MJLINK-75) Reproducibility of ZIP artifacts
[
https://issues.apache.org/jira/browse/MJLINK-75?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Benjamin Marwell reassigned MJLINK-75:
--
Assignee: Herve Boutemy
> Reproducibility of ZIP artifacts
>
>
> Key: MJLINK-75
> URL: https://issues.apache.org/jira/browse/MJLINK-75
> Project: Maven JLink Plugin
> Issue Type: New Feature
>Affects Versions: 3.1.0
>Reporter: Piotr Karwasz
>Assignee: Herve Boutemy
>Priority: Minor
> Fix For: 3.2.0
>
>
> The artifacts produced by this plugin do not use the
> {{'project.build.outputTimestamp'}} property for the ZIP file entries and
> therefore are not reproducible.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MJLINK-75) Reproducibility of ZIP artifacts
[
https://issues.apache.org/jira/browse/MJLINK-75?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17809653#comment-17809653
]
Benjamin Marwell commented on MJLINK-75:
Sadly, I do not see an option for this in the executable:
https://docs.oracle.com/en/java/javase/11/tools/jlink.html
The java lib takes the same arguments iirc, so, I'd say no. We would need to
open a feature request with oracle / the OpenJDK community.
> Reproducibility of ZIP artifacts
>
>
> Key: MJLINK-75
> URL: https://issues.apache.org/jira/browse/MJLINK-75
> Project: Maven JLink Plugin
> Issue Type: New Feature
>Affects Versions: 3.1.0
>Reporter: Piotr Karwasz
>Priority: Minor
> Fix For: 3.2.0
>
>
> The artifacts produced by this plugin do not use the
> {{'project.build.outputTimestamp'}} property for the ZIP file entries and
> therefore are not reproducible.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Created] (MWRAPPER-121) Specifying an invalid version will make the mvnw script output nothing instead of an error
Benjamin Marwell created MWRAPPER-121:
-
Summary: Specifying an invalid version will make the mvnw script
output nothing instead of an error
Key: MWRAPPER-121
URL: https://issues.apache.org/jira/browse/MWRAPPER-121
Project: Maven Wrapper
Issue Type: Bug
Components: Maven Wrapper Scripts
Affects Versions: 3.2.0
Reporter: Benjamin Marwell
Given the following setup:
{code}
mvn wrapper:wrapper -Dmaven=4.0.0-alpha-8 -Dtype=only-script
{code}
The output of the created {{./mvnw}} script is empty, because the 404 wget
error will not be handled.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Resolved] (MJLINK-77) Update description and parameters of --compress to reflect JDK21 changes
[
https://issues.apache.org/jira/browse/MJLINK-77?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Benjamin Marwell resolved MJLINK-77.
Resolution: Fixed
> Update description and parameters of --compress to reflect JDK21 changes
>
>
> Key: MJLINK-77
> URL: https://issues.apache.org/jira/browse/MJLINK-77
> Project: Maven JLink Plugin
> Issue Type: Task
>Reporter: Benjamin Marwell
>Assignee: Benjamin Marwell
>Priority: Major
> Fix For: 3.2.0
>
>
> Starting from Java 21, the allowed parameters for {{compress}} have changed,
> and the old ones are suspect to removal:
> {code:java}
> $ jlink --help
> […]
> --compress Compression to use in compressing
> resources:
> Accepted values are:
> zip-[0-9], where zip-0 provides no
> compression,
> and zip-9 provides the best
> compression.
> Default is zip-6.
> Deprecated values to be removed in a
> future release:
> 0: No compression. Equivalent to
> zip-0.
> 1: Constant String Sharing
> 2: Equivalent to zip-6.
> {code}
> Thus, the current jlink-plugin is incompatible with Java 21:
> {code:java}
> /**
> * Here you can define the compression of the resources being used. The
> command line equivalent is:
> * -c, --compress=level. The valid values for the level
> are: 0, 1, 2.
> */
> @Parameter
> private Integer compress;
> {code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Resolved] (MJLINK-76) Upgrade maven-plugin parent to 41
[ https://issues.apache.org/jira/browse/MJLINK-76?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Benjamin Marwell resolved MJLINK-76. Resolution: Fixed > Upgrade maven-plugin parent to 41 > - > > Key: MJLINK-76 > URL: https://issues.apache.org/jira/browse/MJLINK-76 > Project: Maven JLink Plugin > Issue Type: Improvement >Affects Versions: 3.1.0 >Reporter: Karl Heinz Marbaise >Assignee: Karl Heinz Marbaise >Priority: Minor > Fix For: 3.2.0 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (MJLINK-77) Update description and parameters of --compress to reflect JDK21 changes
[
https://issues.apache.org/jira/browse/MJLINK-77?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Benjamin Marwell updated MJLINK-77:
---
Fix Version/s: 3.2.0
> Update description and parameters of --compress to reflect JDK21 changes
>
>
> Key: MJLINK-77
> URL: https://issues.apache.org/jira/browse/MJLINK-77
> Project: Maven JLink Plugin
> Issue Type: Task
>Reporter: Benjamin Marwell
>Assignee: Benjamin Marwell
>Priority: Major
> Fix For: 3.2.0
>
>
> Starting from Java 21, the allowed parameters for {{compress}} have changed,
> and the old ones are suspect to removal:
> {code:java}
> $ jlink --help
> […]
> --compress Compression to use in compressing
> resources:
> Accepted values are:
> zip-[0-9], where zip-0 provides no
> compression,
> and zip-9 provides the best
> compression.
> Default is zip-6.
> Deprecated values to be removed in a
> future release:
> 0: No compression. Equivalent to
> zip-0.
> 1: Constant String Sharing
> 2: Equivalent to zip-6.
> {code}
> Thus, the current jlink-plugin is incompatible with Java 21:
> {code:java}
> /**
> * Here you can define the compression of the resources being used. The
> command line equivalent is:
> * -c, --compress=level. The valid values for the level
> are: 0, 1, 2.
> */
> @Parameter
> private Integer compress;
> {code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Updated] (MJLINK-73) Add fork mode
[ https://issues.apache.org/jira/browse/MJLINK-73?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Benjamin Marwell updated MJLINK-73: --- Priority: Minor (was: Major) > Add fork mode > - > > Key: MJLINK-73 > URL: https://issues.apache.org/jira/browse/MJLINK-73 > Project: Maven JLink Plugin > Issue Type: New Feature >Reporter: Benjamin Marwell >Priority: Minor > > Instead of just using Toolchains, we could add a fork=true parameter which > will do the same but with the jlink executable from JAVA_HOME. > Hint: Due to toolchains, this is actually the default. -- This message was sent by Atlassian Jira (v8.20.10#820010)
