[jira] [Commented] (MRELEASE-1042) releaseProfiles get overriden by activeProfiles
[ https://issues.apache.org/jira/browse/MRELEASE-1042?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17110640#comment-17110640 ] Benoit GUERIN commented on MRELEASE-1042: - New PR sent to fix > releaseProfiles get overriden by activeProfiles > --- > > Key: MRELEASE-1042 > URL: https://issues.apache.org/jira/browse/MRELEASE-1042 > Project: Maven Release Plugin > Issue Type: Bug > Components: perform >Affects Versions: 3.0.0-M2 >Reporter: Arnaud Heritier >Assignee: Robert Scholte >Priority: Major > Fix For: 3.0.0-M3 > > Time Spent: 20m > Remaining Estimate: 0h > > I tried to release a project with 3.0.0-M2 and potentially it is another > problem related to MRELEASE-1038 [~rfscholte] [~olamy] > > In our corporate POM we have a pluginManagement entry: > {code:java} > > maven-release-plugin > 2.5.3 > > forked-path > false > cloudbees-internal-release > > > {code} > My project extends it and has no settings related to the release plugin > In my user settings I have > {code:java} > > cloudbees-internal-deploy > cloudbees-snapshots > apache-staging > > {code} > Then I release my project using 3.0.0-M2 with > {code:java} > mvn org.apache.maven.plugins:maven-release-plugin:3.0.0-M2:prepare > org.apache.maven.plugins:maven-release-plugin:3.0.0-M2:perform > {code} > The perform step is taking my user profiles but not the ones from > "releaseProfiles" > {noformat} > [INFO] Executing: /bin/sh -c cd /Users/arnaud/some/path/target/checkout && > /Users/arnaud/.asdf/installs/maven/3.6.3/bin/mvn -s > /var/folders/bw/j0tmy8p52szfms6c7qb0tx2rgn/T/release-settings4094445863857985100.xml > -f pom.xml deploy -P > cloudbees-internal-deploy,cloudbees-snapshots,apache-staging -f > pom.xml{noformat} > Not sure if it could be because I call the release plugin with the full GAV > but it is strange ... > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (MRELEASE-1042) releaseProfiles get overriden by activeProfiles
[ https://issues.apache.org/jira/browse/MRELEASE-1042?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17110622#comment-17110622 ] Benoit GUERIN commented on MRELEASE-1042: - [~rfscholte] I am sorry but I disagree ... Lookin at the stack, it IS in the code modified by my PR, so this issue is not fixed :( > releaseProfiles get overriden by activeProfiles > --- > > Key: MRELEASE-1042 > URL: https://issues.apache.org/jira/browse/MRELEASE-1042 > Project: Maven Release Plugin > Issue Type: Bug > Components: perform >Affects Versions: 3.0.0-M2 >Reporter: Arnaud Heritier >Assignee: Robert Scholte >Priority: Major > Fix For: 3.0.0-M3 > > Time Spent: 20m > Remaining Estimate: 0h > > I tried to release a project with 3.0.0-M2 and potentially it is another > problem related to MRELEASE-1038 [~rfscholte] [~olamy] > > In our corporate POM we have a pluginManagement entry: > {code:java} > > maven-release-plugin > 2.5.3 > > forked-path > false > cloudbees-internal-release > > > {code} > My project extends it and has no settings related to the release plugin > In my user settings I have > {code:java} > > cloudbees-internal-deploy > cloudbees-snapshots > apache-staging > > {code} > Then I release my project using 3.0.0-M2 with > {code:java} > mvn org.apache.maven.plugins:maven-release-plugin:3.0.0-M2:prepare > org.apache.maven.plugins:maven-release-plugin:3.0.0-M2:perform > {code} > The perform step is taking my user profiles but not the ones from > "releaseProfiles" > {noformat} > [INFO] Executing: /bin/sh -c cd /Users/arnaud/some/path/target/checkout && > /Users/arnaud/.asdf/installs/maven/3.6.3/bin/mvn -s > /var/folders/bw/j0tmy8p52szfms6c7qb0tx2rgn/T/release-settings4094445863857985100.xml > -f pom.xml deploy -P > cloudbees-internal-deploy,cloudbees-snapshots,apache-staging -f > pom.xml{noformat} > Not sure if it could be because I call the release plugin with the full GAV > but it is strange ... > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (MRELEASE-1042) releaseProfiles get overriden by activeProfiles
[ https://issues.apache.org/jira/browse/MRELEASE-1042?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17082701#comment-17082701 ] Benoit GUERIN commented on MRELEASE-1042: - PR updated > releaseProfiles get overriden by activeProfiles > --- > > Key: MRELEASE-1042 > URL: https://issues.apache.org/jira/browse/MRELEASE-1042 > Project: Maven Release Plugin > Issue Type: Bug > Components: perform >Affects Versions: 3.0.0-M2 >Reporter: Arnaud Heritier >Assignee: Robert Scholte >Priority: Major > Time Spent: 10m > Remaining Estimate: 0h > > I tried to release a project with 3.0.0-M2 and potentially it is another > problem related to MRELEASE-1038 [~rfscholte] [~olamy] > > In our corporate POM we have a pluginManagement entry: > {code:java} > > maven-release-plugin > 2.5.3 > > forked-path > false > cloudbees-internal-release > > > {code} > My project extends it and has no settings related to the release plugin > In my user settings I have > {code:java} > > cloudbees-internal-deploy > cloudbees-snapshots > apache-staging > > {code} > Then I release my project using 3.0.0-M2 with > {code:java} > mvn org.apache.maven.plugins:maven-release-plugin:3.0.0-M2:prepare > org.apache.maven.plugins:maven-release-plugin:3.0.0-M2:perform > {code} > The perform step is taking my user profiles but not the ones from > "releaseProfiles" > {noformat} > [INFO] Executing: /bin/sh -c cd /Users/arnaud/some/path/target/checkout && > /Users/arnaud/.asdf/installs/maven/3.6.3/bin/mvn -s > /var/folders/bw/j0tmy8p52szfms6c7qb0tx2rgn/T/release-settings4094445863857985100.xml > -f pom.xml deploy -P > cloudbees-internal-deploy,cloudbees-snapshots,apache-staging -f > pom.xml{noformat} > Not sure if it could be because I call the release plugin with the full GAV > but it is strange ... > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (MRELEASE-1042) releaseProfiles get overriden by activeProfiles
[ https://issues.apache.org/jira/browse/MRELEASE-1042?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17082609#comment-17082609 ] Benoit GUERIN commented on MRELEASE-1042: - Right, I will change my PR > releaseProfiles get overriden by activeProfiles > --- > > Key: MRELEASE-1042 > URL: https://issues.apache.org/jira/browse/MRELEASE-1042 > Project: Maven Release Plugin > Issue Type: Bug > Components: perform >Affects Versions: 3.0.0-M2 >Reporter: Arnaud Heritier >Assignee: Robert Scholte >Priority: Major > Time Spent: 10m > Remaining Estimate: 0h > > I tried to release a project with 3.0.0-M2 and potentially it is another > problem related to MRELEASE-1038 [~rfscholte] [~olamy] > > In our corporate POM we have a pluginManagement entry: > {code:java} > > maven-release-plugin > 2.5.3 > > forked-path > false > cloudbees-internal-release > > > {code} > My project extends it and has no settings related to the release plugin > In my user settings I have > {code:java} > > cloudbees-internal-deploy > cloudbees-snapshots > apache-staging > > {code} > Then I release my project using 3.0.0-M2 with > {code:java} > mvn org.apache.maven.plugins:maven-release-plugin:3.0.0-M2:prepare > org.apache.maven.plugins:maven-release-plugin:3.0.0-M2:perform > {code} > The perform step is taking my user profiles but not the ones from > "releaseProfiles" > {noformat} > [INFO] Executing: /bin/sh -c cd /Users/arnaud/some/path/target/checkout && > /Users/arnaud/.asdf/installs/maven/3.6.3/bin/mvn -s > /var/folders/bw/j0tmy8p52szfms6c7qb0tx2rgn/T/release-settings4094445863857985100.xml > -f pom.xml deploy -P > cloudbees-internal-deploy,cloudbees-snapshots,apache-staging -f > pom.xml{noformat} > Not sure if it could be because I call the release plugin with the full GAV > but it is strange ... > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (MRELEASE-1042) releaseProfiles get overriden by activeProfiles
[ https://issues.apache.org/jira/browse/MRELEASE-1042?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17082460#comment-17082460 ] Benoit GUERIN commented on MRELEASE-1042: - {quote}Thus when the release.properties is generated we are supposed to add the "releaseProfiles" but "getAdditionalProfiles()" returns null in the prepare Mojo (it's only implemented in perform) thus we completely lost the info {quote} Yep, but the release descriptor is reconstructed from scratch on perform : [https://github.com/apache/maven-release/blob/master/maven-release-plugin/src/main/java/org/apache/maven/plugins/release/PerformReleaseMojo.java#L170] and the perform goals has the correct overload to append additional profiles : [https://github.com/apache/maven-release/blob/master/maven-release-plugin/src/main/java/org/apache/maven/plugins/release/PerformReleaseMojo.java#L140] BUT this descriptor is then passed to the ReleaseManager, through the request argument : [https://github.com/apache/maven-release/blob/master/maven-release-plugin/src/main/java/org/apache/maven/plugins/release/PerformReleaseMojo.java#L195] which merge it with the properties from the temporary release.properties file : [https://github.com/apache/maven-release/blob/master/maven-release-manager/src/main/java/org/apache/maven/shared/release/DefaultReleaseManager.java#L303] [https://github.com/apache/maven-release/blob/master/maven-release-manager/src/main/java/org/apache/maven/shared/release/config/PropertiesReleaseDescriptorStore.java#L78] in this method you will see that : # we load properties from the release.properties file (2nd arg) # we reuse the descriptorBuilder passed from the perform MOJO # we override existing values in the builder which values from the properties. This IS WHERE we lost additional profiles. I think we should change (again) how ReleaseUtils.copyPropertiesToReleaseDescriptor handle activateProfiles : [https://github.com/apache/maven-release/blob/master/maven-release-manager/src/main/java/org/apache/maven/shared/release/config/ReleaseUtils.java#L132] and do a merge between existing values if any and those from properties > releaseProfiles get overriden by activeProfiles > --- > > Key: MRELEASE-1042 > URL: https://issues.apache.org/jira/browse/MRELEASE-1042 > Project: Maven Release Plugin > Issue Type: Bug > Components: perform >Affects Versions: 3.0.0-M2 >Reporter: Arnaud Heritier >Assignee: Robert Scholte >Priority: Major > > I tried to release a project with 3.0.0-M2 and potentially it is another > problem related to MRELEASE-1038 [~rfscholte] [~olamy] > > In our corporate POM we have a pluginManagement entry: > {code:java} > > maven-release-plugin > 2.5.3 > > forked-path > false > cloudbees-internal-release > > > {code} > My project extends it and has no settings related to the release plugin > In my user settings I have > {code:java} > > cloudbees-internal-deploy > cloudbees-snapshots > apache-staging > > {code} > Then I release my project using 3.0.0-M2 with > {code:java} > mvn org.apache.maven.plugins:maven-release-plugin:3.0.0-M2:prepare > org.apache.maven.plugins:maven-release-plugin:3.0.0-M2:perform > {code} > The perform step is taking my user profiles but not the ones from > "releaseProfiles" > {noformat} > [INFO] Executing: /bin/sh -c cd /Users/arnaud/some/path/target/checkout && > /Users/arnaud/.asdf/installs/maven/3.6.3/bin/mvn -s > /var/folders/bw/j0tmy8p52szfms6c7qb0tx2rgn/T/release-settings4094445863857985100.xml > -f pom.xml deploy -P > cloudbees-internal-deploy,cloudbees-snapshots,apache-staging -f > pom.xml{noformat} > Not sure if it could be because I call the release plugin with the full GAV > but it is strange ... > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (MRELEASE-1038) releaseProfiles get overriden by exec.pomFileName
[ https://issues.apache.org/jira/browse/MRELEASE-1038?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17082333#comment-17082333 ] Benoit GUERIN commented on MRELEASE-1038: - Ok, thanks for your answer > releaseProfiles get overriden by exec.pomFileName > - > > Key: MRELEASE-1038 > URL: https://issues.apache.org/jira/browse/MRELEASE-1038 > Project: Maven Release Plugin > Issue Type: Bug > Components: perform >Affects Versions: 3.0.0-M1 >Reporter: Benoit MESSAGER >Assignee: Olivier Lamy >Priority: Minor > Fix For: 3.0.0-M2 > > Time Spent: 20m > Remaining Estimate: 0h > > Profiles specified in . are overrided by the > pom file name. > This come from : org.apache.maven.shared.release.config.ReleaseUtils line 130 > : > {code:java} > if ( properties.containsKey( "exec.activateProfiles" ) ) > { > builder.setActivateProfiles( Arrays.asList( properties.getProperty( > "exec.pomFileName" ).split( "," ) ) ); > } > {code} > this look like a failed copy/paste > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (MRELEASE-1038) releaseProfiles get overriden by exec.pomFileName
[ https://issues.apache.org/jira/browse/MRELEASE-1038?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17082122#comment-17082122 ] Benoit GUERIN commented on MRELEASE-1038: - I am sorry to ask but where is this M2 release ? I can see the commits and the tag on github, but nothing on central. Even the documentation site is still in M1 [~rfscholte] ? > releaseProfiles get overriden by exec.pomFileName > - > > Key: MRELEASE-1038 > URL: https://issues.apache.org/jira/browse/MRELEASE-1038 > Project: Maven Release Plugin > Issue Type: Bug > Components: perform >Affects Versions: 3.0.0-M1 >Reporter: Benoit MESSAGER >Assignee: Olivier Lamy >Priority: Minor > Fix For: 3.0.0-M2 > > Time Spent: 20m > Remaining Estimate: 0h > > Profiles specified in . are overrided by the > pom file name. > This come from : org.apache.maven.shared.release.config.ReleaseUtils line 130 > : > {code:java} > if ( properties.containsKey( "exec.activateProfiles" ) ) > { > builder.setActivateProfiles( Arrays.asList( properties.getProperty( > "exec.pomFileName" ).split( "," ) ) ); > } > {code} > this look like a failed copy/paste > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (MRELEASE-1038) releaseProfiles get overriden by exec.pomFileName
[ https://issues.apache.org/jira/browse/MRELEASE-1038?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17078771#comment-17078771 ] Benoit GUERIN commented on MRELEASE-1038: - (y) > releaseProfiles get overriden by exec.pomFileName > - > > Key: MRELEASE-1038 > URL: https://issues.apache.org/jira/browse/MRELEASE-1038 > Project: Maven Release Plugin > Issue Type: Bug > Components: perform >Affects Versions: 3.0.0-M1 >Reporter: Benoit MESSAGER >Assignee: Olivier Lamy >Priority: Minor > Fix For: 3.0.0-M2 > > Time Spent: 20m > Remaining Estimate: 0h > > Profiles specified in . are overrided by the > pom file name. > This come from : org.apache.maven.shared.release.config.ReleaseUtils line 130 > : > {code:java} > if ( properties.containsKey( "exec.activateProfiles" ) ) > { > builder.setActivateProfiles( Arrays.asList( properties.getProperty( > "exec.pomFileName" ).split( "," ) ) ); > } > {code} > this look like a failed copy/paste > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (MRELEASE-1038) releaseProfiles get overriden by exec.pomFileName
[ https://issues.apache.org/jira/browse/MRELEASE-1038?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17034305#comment-17034305 ] Benoit GUERIN commented on MRELEASE-1038: - PR opened on GitHub [https://github.com/apache/maven-release/pull/38] > releaseProfiles get overriden by exec.pomFileName > - > > Key: MRELEASE-1038 > URL: https://issues.apache.org/jira/browse/MRELEASE-1038 > Project: Maven Release Plugin > Issue Type: Bug > Components: perform >Affects Versions: 3.0.0-M1 >Reporter: Benoit MESSAGER >Priority: Minor > Time Spent: 10m > Remaining Estimate: 0h > > Profiles specified in . are overrided by the > pom file name. > This come from : org.apache.maven.shared.release.config.ReleaseUtils line 130 > : > {code:java} > if ( properties.containsKey( "exec.activateProfiles" ) ) > { > builder.setActivateProfiles( Arrays.asList( properties.getProperty( > "exec.pomFileName" ).split( "," ) ) ); > } > {code} > this look like a failed copy/paste > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (MNG-6643) Version comparison CLI does not work anymore
Benoit GUERIN created MNG-6643: -- Summary: Version comparison CLI does not work anymore Key: MNG-6643 URL: https://issues.apache.org/jira/browse/MNG-6643 Project: Maven Issue Type: Bug Components: Command Line Affects Versions: 3.6.1 Reporter: Benoit GUERIN Since 3.6.1, comparison CLI does not work : {code:java} $ java -jar apache-maven-3.6.1/lib/maven-artifact-3.6.1.jar 5.32 5.27 Display parameters as parsed by Maven (in canonical form) and comparison result: Exception in thread "main" java.lang.NoClassDefFoundError: org/apache/commons/lang3/StringUtils at org.apache.maven.artifact.versioning.ComparableVersion.stripLeadingZeroes(ComparableVersion.java:612) at org.apache.maven.artifact.versioning.ComparableVersion.parseItem(ComparableVersion.java:594) at org.apache.maven.artifact.versioning.ComparableVersion.parseVersion(ComparableVersion.java:529) at org.apache.maven.artifact.versioning.ComparableVersion.(ComparableVersion.java:496) at org.apache.maven.artifact.versioning.ComparableVersion.main(ComparableVersion.java:679) Caused by: java.lang.ClassNotFoundException: org.apache.commons.lang3.StringUtils at java.net.URLClassLoader.findClass(URLClassLoader.java:382) at java.lang.ClassLoader.loadClass(ClassLoader.java:424) at sun.misc.Launcher$AppClassLoader.loadClass(Launcher.java:349) at java.lang.ClassLoader.loadClass(ClassLoader.java:357) ... 5 more {code} -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] (MJAR-179) Adding empty files to jar failed with a ZipException : bad CRC checksum
[ https://jira.codehaus.org/browse/MJAR-179?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=349779#comment-349779 ] Benoit Guerin commented on MJAR-179: I attached a zipped sample project to reproduce I run command : mvn clean install Using : bgu@:~/mjar-179$ mvn -v Apache Maven 3.2.2 (45f7c06d68e745d05611f7fd14efb6594181933e; 2014-06-17T15:51:42+02:00) Maven home: /home/bgu/apache-maven Java version: 1.7.0_60, vendor: Oracle Corporation Java home: /home/bgu/Java7/jre Default locale: fr_FR, platform encoding: UTF-8 OS name: "linux", version: "3.2.0-4-amd64", arch: "amd64", family: "unix" > Adding empty files to jar failed with a ZipException : bad CRC checksum > --- > > Key: MJAR-179 > URL: https://jira.codehaus.org/browse/MJAR-179 > Project: Maven JAR Plugin > Issue Type: Bug >Affects Versions: 2.5 >Reporter: Benoit Guerin >Priority: Blocker > Fix For: more-investigation > > Attachments: mjar-179.zip > > > Here is the trace : > [INFO] --- maven-jar-plugin:2.5:jar (default-jar) @ project --- > [INFO] Building jar: workspace/project/project-1.0.0-SNAPSHOT.jar > org.apache.maven.lifecycle.LifecycleExecutionException: Failed to execute > goal org.apache.maven.plugins:maven-jar-plugin:2.5:jar (default-jar) on > project project: Error assembling JAR > at > org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:216) > at > org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:153) > at > org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:145) > at > org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:116) > at > org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:80) > at > org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.build(SingleThreadedBuilder.java:51) > at > org.apache.maven.lifecycle.internal.LifecycleStarter.execute(LifecycleStarter.java:120) > at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:347) > at org.apache.maven.DefaultMaven.execute(DefaultMaven.java:154) > at org.apache.maven.cli.MavenCli.execute(MavenCli.java:584) > at org.apache.maven.cli.MavenCli.doMain(MavenCli.java:213) > at org.apache.maven.cli.MavenCli.main(MavenCli.java:157) > at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) > at > sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57) > at > sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) > at java.lang.reflect.Method.invoke(Method.java:606) > at > org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced(Launcher.java:289) > at > org.codehaus.plexus.classworlds.launcher.Launcher.launch(Launcher.java:229) > at > org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode(Launcher.java:415) > at > org.codehaus.plexus.classworlds.launcher.Launcher.main(Launcher.java:356) > Caused by: org.apache.maven.plugin.MojoExecutionException: Error assembling > JAR > at > org.apache.maven.plugin.jar.AbstractJarMojo.createArchive(AbstractJarMojo.java:233) > at > org.apache.maven.plugin.jar.AbstractJarMojo.execute(AbstractJarMojo.java:251) > at > org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo(DefaultBuildPluginManager.java:132) > at > org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:208) > ... 19 more > Caused by: org.codehaus.plexus.archiver.ArchiverException: IOException when > zipping Test.class: bad CRC checksum for entry empty_file: 2144df1c instead > of 0 > at > org.codehaus.plexus.archiver.zip.AbstractZipArchiver.zipFile(AbstractZipArchiver.java:602) > at > org.codehaus.plexus.archiver.zip.AbstractZipArchiver.addResources(AbstractZipArchiver.java:401) > at > org.codehaus.plexus.archiver.zip.AbstractZipArchiver.createArchiveMain(AbstractZipArchiver.java:326) > at > org.codehaus.plexus.archiver.zip.AbstractZipArchiver.execute(AbstractZipArchiver.java:223) > at > org.codehaus.plexus.archiver.AbstractArchiver.createArchive(AbstractArchiver.java:910) > at > org.apache.maven.archiver.MavenArchiver.createArchive(MavenArchiver.java:582) > at > org.apache.maven.plugin.jar.AbstractJarMojo.createArchive(AbstractJarMojo.java:226) > ... 22 more > Caused by: java.util.zip.ZipException: bad CRC checksum for entry empty_file: > 2144df1c instead of 0 > at > org.codehaus.plexus.archiver.zip.ZipOutputStream.closeEntry(ZipOutputStream.java:372) > at > org.codehaus.plexus.archiver.zip.ZipOutputS
[jira] (MJAR-179) Adding empty files to jar failed with a ZipException : bad CRC checksum
[ https://jira.codehaus.org/browse/MJAR-179?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Benoit Guerin updated MJAR-179: --- Attachment: mjar-179.zip Sample project to reproduce > Adding empty files to jar failed with a ZipException : bad CRC checksum > --- > > Key: MJAR-179 > URL: https://jira.codehaus.org/browse/MJAR-179 > Project: Maven JAR Plugin > Issue Type: Bug >Affects Versions: 2.5 >Reporter: Benoit Guerin >Priority: Blocker > Fix For: more-investigation > > Attachments: mjar-179.zip > > > Here is the trace : > [INFO] --- maven-jar-plugin:2.5:jar (default-jar) @ project --- > [INFO] Building jar: workspace/project/project-1.0.0-SNAPSHOT.jar > org.apache.maven.lifecycle.LifecycleExecutionException: Failed to execute > goal org.apache.maven.plugins:maven-jar-plugin:2.5:jar (default-jar) on > project project: Error assembling JAR > at > org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:216) > at > org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:153) > at > org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:145) > at > org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:116) > at > org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:80) > at > org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.build(SingleThreadedBuilder.java:51) > at > org.apache.maven.lifecycle.internal.LifecycleStarter.execute(LifecycleStarter.java:120) > at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:347) > at org.apache.maven.DefaultMaven.execute(DefaultMaven.java:154) > at org.apache.maven.cli.MavenCli.execute(MavenCli.java:584) > at org.apache.maven.cli.MavenCli.doMain(MavenCli.java:213) > at org.apache.maven.cli.MavenCli.main(MavenCli.java:157) > at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) > at > sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57) > at > sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) > at java.lang.reflect.Method.invoke(Method.java:606) > at > org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced(Launcher.java:289) > at > org.codehaus.plexus.classworlds.launcher.Launcher.launch(Launcher.java:229) > at > org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode(Launcher.java:415) > at > org.codehaus.plexus.classworlds.launcher.Launcher.main(Launcher.java:356) > Caused by: org.apache.maven.plugin.MojoExecutionException: Error assembling > JAR > at > org.apache.maven.plugin.jar.AbstractJarMojo.createArchive(AbstractJarMojo.java:233) > at > org.apache.maven.plugin.jar.AbstractJarMojo.execute(AbstractJarMojo.java:251) > at > org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo(DefaultBuildPluginManager.java:132) > at > org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:208) > ... 19 more > Caused by: org.codehaus.plexus.archiver.ArchiverException: IOException when > zipping Test.class: bad CRC checksum for entry empty_file: 2144df1c instead > of 0 > at > org.codehaus.plexus.archiver.zip.AbstractZipArchiver.zipFile(AbstractZipArchiver.java:602) > at > org.codehaus.plexus.archiver.zip.AbstractZipArchiver.addResources(AbstractZipArchiver.java:401) > at > org.codehaus.plexus.archiver.zip.AbstractZipArchiver.createArchiveMain(AbstractZipArchiver.java:326) > at > org.codehaus.plexus.archiver.zip.AbstractZipArchiver.execute(AbstractZipArchiver.java:223) > at > org.codehaus.plexus.archiver.AbstractArchiver.createArchive(AbstractArchiver.java:910) > at > org.apache.maven.archiver.MavenArchiver.createArchive(MavenArchiver.java:582) > at > org.apache.maven.plugin.jar.AbstractJarMojo.createArchive(AbstractJarMojo.java:226) > ... 22 more > Caused by: java.util.zip.ZipException: bad CRC checksum for entry empty_file: > 2144df1c instead of 0 > at > org.codehaus.plexus.archiver.zip.ZipOutputStream.closeEntry(ZipOutputStream.java:372) > at > org.codehaus.plexus.archiver.zip.ZipOutputStream.putNextEntry(ZipOutputStream.java:422) > at > org.codehaus.plexus.archiver.zip.AbstractZipArchiver.zipFile(AbstractZipArchiver.java:563) > at > org.codehaus.plexus.archiver.jar.JarArchiver.zipFile(JarArchiver.java:480) > at > org.codehaus.plexus.archiver.zip.AbstractZipArchiver.zipFile(AbstractZipArchiver.java:598) > ... 28 more -- This message was sent by Atlassian JIRA (v6.1.6#6162)
[jira] (MJAR-179) Adding empty files to jar failed with a ZipException : bad CRC checksum
Benoit Guerin created MJAR-179: -- Summary: Adding empty files to jar failed with a ZipException : bad CRC checksum Key: MJAR-179 URL: https://jira.codehaus.org/browse/MJAR-179 Project: Maven JAR Plugin Issue Type: Bug Affects Versions: 2.5 Reporter: Benoit Guerin Priority: Blocker Here is the trace : [INFO] --- maven-jar-plugin:2.5:jar (default-jar) @ project --- [INFO] Building jar: workspace/project/project-1.0.0-SNAPSHOT.jar org.apache.maven.lifecycle.LifecycleExecutionException: Failed to execute goal org.apache.maven.plugins:maven-jar-plugin:2.5:jar (default-jar) on project project: Error assembling JAR at org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:216) at org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:153) at org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:145) at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:116) at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:80) at org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.build(SingleThreadedBuilder.java:51) at org.apache.maven.lifecycle.internal.LifecycleStarter.execute(LifecycleStarter.java:120) at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:347) at org.apache.maven.DefaultMaven.execute(DefaultMaven.java:154) at org.apache.maven.cli.MavenCli.execute(MavenCli.java:584) at org.apache.maven.cli.MavenCli.doMain(MavenCli.java:213) at org.apache.maven.cli.MavenCli.main(MavenCli.java:157) at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) at java.lang.reflect.Method.invoke(Method.java:606) at org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced(Launcher.java:289) at org.codehaus.plexus.classworlds.launcher.Launcher.launch(Launcher.java:229) at org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode(Launcher.java:415) at org.codehaus.plexus.classworlds.launcher.Launcher.main(Launcher.java:356) Caused by: org.apache.maven.plugin.MojoExecutionException: Error assembling JAR at org.apache.maven.plugin.jar.AbstractJarMojo.createArchive(AbstractJarMojo.java:233) at org.apache.maven.plugin.jar.AbstractJarMojo.execute(AbstractJarMojo.java:251) at org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo(DefaultBuildPluginManager.java:132) at org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:208) ... 19 more Caused by: org.codehaus.plexus.archiver.ArchiverException: IOException when zipping Test.class: bad CRC checksum for entry empty_file: 2144df1c instead of 0 at org.codehaus.plexus.archiver.zip.AbstractZipArchiver.zipFile(AbstractZipArchiver.java:602) at org.codehaus.plexus.archiver.zip.AbstractZipArchiver.addResources(AbstractZipArchiver.java:401) at org.codehaus.plexus.archiver.zip.AbstractZipArchiver.createArchiveMain(AbstractZipArchiver.java:326) at org.codehaus.plexus.archiver.zip.AbstractZipArchiver.execute(AbstractZipArchiver.java:223) at org.codehaus.plexus.archiver.AbstractArchiver.createArchive(AbstractArchiver.java:910) at org.apache.maven.archiver.MavenArchiver.createArchive(MavenArchiver.java:582) at org.apache.maven.plugin.jar.AbstractJarMojo.createArchive(AbstractJarMojo.java:226) ... 22 more Caused by: java.util.zip.ZipException: bad CRC checksum for entry empty_file: 2144df1c instead of 0 at org.codehaus.plexus.archiver.zip.ZipOutputStream.closeEntry(ZipOutputStream.java:372) at org.codehaus.plexus.archiver.zip.ZipOutputStream.putNextEntry(ZipOutputStream.java:422) at org.codehaus.plexus.archiver.zip.AbstractZipArchiver.zipFile(AbstractZipArchiver.java:563) at org.codehaus.plexus.archiver.jar.JarArchiver.zipFile(JarArchiver.java:480) at org.codehaus.plexus.archiver.zip.AbstractZipArchiver.zipFile(AbstractZipArchiver.java:598) ... 28 more -- This message was sent by Atlassian JIRA (v6.1.6#6162)
[jira] (MCHANGES-303) Add an option to enable tls
[ https://jira.codehaus.org/browse/MCHANGES-303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=343169#comment-343169 ] Benoit Guerin commented on MCHANGES-303: Great ! thanks ! > Add an option to enable tls > --- > > Key: MCHANGES-303 > URL: https://jira.codehaus.org/browse/MCHANGES-303 > Project: Maven Changes Plugin > Issue Type: Improvement > Components: announcement >Affects Versions: 2.8 >Reporter: Benoit Guerin >Assignee: Dennis Lundberg > Fix For: 2.10 > > Attachments: enableTls.patch > > > Add an option to set ProjectJavamailMailSender.tlsEnabled to true, to allow > to use as an example GMail to send announcement emails -- This message was sent by Atlassian JIRA (v6.1.6#6162)
[jira] (MCHANGES-303) Add an option to enable tls
Benoit Guerin created MCHANGES-303: -- Summary: Add an option to enable tls Key: MCHANGES-303 URL: https://jira.codehaus.org/browse/MCHANGES-303 Project: Maven 2.x Changes Plugin Issue Type: Improvement Components: announcement Affects Versions: 2.8 Reporter: Benoit Guerin Attachments: enableTls.patch Add an option to set ProjectJavamailMailSender.tlsEnabled to true, to allow to use as an example GMail to send announcement emails -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://jira.codehaus.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] (MCHANGES-303) Add an option to enable tls
[ https://jira.codehaus.org/browse/MCHANGES-303?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Benoit Guerin updated MCHANGES-303: --- Attachment: enableTls.patch > Add an option to enable tls > --- > > Key: MCHANGES-303 > URL: https://jira.codehaus.org/browse/MCHANGES-303 > Project: Maven 2.x Changes Plugin > Issue Type: Improvement > Components: announcement >Affects Versions: 2.8 >Reporter: Benoit Guerin > Attachments: enableTls.patch > > > Add an option to set ProjectJavamailMailSender.tlsEnabled to true, to allow > to use as an example GMail to send announcement emails -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://jira.codehaus.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] (SCM-508) Wrong scm url validation for mercurial provider
[ https://jira.codehaus.org/browse/SCM-508?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=300550#comment-300550 ] Benoit Guerin commented on SCM-508: --- any update on this ? It is (for me) a blocker bug : we are using DVCS, so we except not to clone from Internet when releasing. And from now, with this bug, the only way to release from Windows PC is to let localCheckout to false in the maven-release-plugin configuration ... > Wrong scm url validation for mercurial provider > --- > > Key: SCM-508 > URL: https://jira.codehaus.org/browse/SCM-508 > Project: Maven SCM > Issue Type: Bug > Components: maven-scm-provider-mercurial (hg) >Reporter: Alexander Nemish > Fix For: 1.x > > Attachments: SCM-508-maven-scm-provider-hg.patch > > > According to documentation (http://maven.apache.org/scm/mercurial.html) scm > url can be of this form: > scm:hg:file://C:/dev/project/v3 > but it doesn't work due to a bug in > https://svn.apache.org/repos/asf/maven/scm/tags/maven-scm-1.2/maven-scm-providers/maven-scm-provider-hg/src/main/java/org/apache/maven/scm/provider/hg/HgScmProvider.java > private HgUrlParserResult parseScmUrl( String scmSpecificUrl ) > line 104: if ( !url.startsWith( "file:///" ) && !url.startsWith( > "file://localhost/" ) ) > The fix might be the following (like in svn provider) > line 104: if ( !url.startsWith( "file://" ) && !url.startsWith( > "file://localhost/" ) ) -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://jira.codehaus.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira