[jira] [Created] (SUREFIRE-1599) %regex pattern handling does not match documentation

2018-11-12 Thread Bryan Turner (JIRA)
Bryan Turner created SUREFIRE-1599:
--

 Summary: %regex pattern handling does not match documentation
 Key: SUREFIRE-1599
 URL: https://issues.apache.org/jira/browse/SUREFIRE-1599
 Project: Maven Surefire
  Issue Type: Bug
  Components: documentation
Affects Versions: 2.22.1, 2.22.0
 Environment: Windows
Reporter: Bryan Turner


[This pull request|https://github.com/apache/maven-surefire/pull/138] updated 
the inclusion/exclusion documentation to state:

{quote}
Regex matches are done over paths using slashes ("/") and not package names 
using dots ("."), so the "." in pkg.\*Slow.\*.class is a regex metacharacter, 
which happens to match any character, notably the (forward) slashes ("/") that 
make up the path. Slashes here are forward, even on Windows
{quote}

That's not true, at least in Surefire 2.22+. I've prepared a [simple 
reproduction|https://github.com/bturner/surefire-slashes]. Built on Linux or 
macOS, Surefire will correctly skip {{ExampleIntegrationTest}}, but on Windows 
it will run (and fail the build).

Surefire is configured as follows:
{code}

org.apache.maven.plugins
maven-surefire-plugin
2.22.1


%regex[it/.*]



{code}

Per the documentation, that forward slash should work on Windows as well as 
Linux and macOS.

(Note: This also effects Failsafe, as one might expect.)



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (MINVOKER-243) invoker:install doesn't copy transitive dependencies anymore (as of 3.1.0)

2018-11-10 Thread Bryan Turner (JIRA)


[ 
https://issues.apache.org/jira/browse/MINVOKER-243?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16682680#comment-16682680
 ] 

Bryan Turner commented on MINVOKER-243:
---

(Note: I'm not sure why _both_ 3.0.1 and 3.1.0 appear to copy the POMs twice; 
seems like that might be a different issue. Not filtering duplicates, perhaps?)

> invoker:install doesn't copy transitive dependencies anymore (as of 3.1.0)
> --
>
> Key: MINVOKER-243
> URL: https://issues.apache.org/jira/browse/MINVOKER-243
> Project: Maven Invoker Plugin
>  Issue Type: Bug
>Affects Versions: 3.1.0
>Reporter: Christopher Tubbs
>Priority: Blocker
>
> Something seems to have broken between 3.0.1 and 3.1.0, as the install goal 
> no longer copies transitive dependencies to the localRepositoryPath as it did 
> in version 3.0.1.
> This is very problematic, because if the artifacts are not in the 
> localRepositoryPath, the invoked project will try to download them from a 
> remote repository, which isn't possible for SNAPSHOT versions (such as those 
> in a sibling module in a multi-module project). This can make it difficult to 
> even build a multi-module project, unless the invoked task is skipped and the 
> sibling module can be published to a remote snapshot repository temporarily, 
> and then the build re-executed normally. (Saw this happen in Apache Accumulo 
> after upgrading to apache-21.pom)



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (MINVOKER-243) invoker:install doesn't copy transitive dependencies anymore (as of 3.1.0)

2018-11-10 Thread Bryan Turner (JIRA)


[ 
https://issues.apache.org/jira/browse/MINVOKER-243?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16682679#comment-16682679
 ] 

Bryan Turner commented on MINVOKER-243:
---

This just caused some CI failures for me. We've got branch builds for our Maven 
plugins, and artifacts from different branches can be incompatible in various 
ways depending on the in-flight changes. Since the artifacts from different 
branches aren't compatible, transitive _in-reactor_ dependencies not being 
copied can result in mismatches between any current-build artifacts that _do_ 
get copied and other _in-reactor_ artifacts from previous builds that aren't 
overwritten. Under 3.0.1, that's not an issue as all _in-reactor_ artifacts are 
copied, whether they're explicit dependencies or transitive.

{{install}} output from 3.0.1:
{noformat}
[INFO] --- maven-invoker-plugin:3.0.1:install (integration-test) @ 
bitbucket-maven-plugin ---
[INFO] Installing /Users/bturner/Development/atlassian/amps/pom.xml to 
/Users/bturner/Development/atlassian/amps/invoker-repo/com/atlassian/amps/atlassian-amps-parent/8.0.0-SNAPSHOT/atlassian-amps-parent-8.0.0-SNAPSHOT.pom
[INFO] Installing 
/Users/bturner/Development/atlassian/amps/plugin-module-codegen-api/pom.xml to 
/Users/bturner/Development/atlassian/amps/invoker-repo/com/atlassian/amps/plugin-module-codegen-api/8.0.0-SNAPSHOT/plugin-module-codegen-api-8.0.0-SNAPSHOT.pom
[INFO] Installing 
/Users/bturner/Development/atlassian/amps/plugin-module-codegen-api/target/plugin-module-codegen-api-8.0.0-SNAPSHOT.jar
 to 
/Users/bturner/Development/atlassian/amps/invoker-repo/com/atlassian/amps/plugin-module-codegen-api/8.0.0-SNAPSHOT/plugin-module-codegen-api-8.0.0-SNAPSHOT.jar
[INFO] Installing 
/Users/bturner/Development/atlassian/amps/plugin-module-codegen-api/pom.xml to 
/Users/bturner/Development/atlassian/amps/invoker-repo/com/atlassian/amps/plugin-module-codegen-api/8.0.0-SNAPSHOT/plugin-module-codegen-api-8.0.0-SNAPSHOT.pom
[INFO] Installing 
/Users/bturner/Development/atlassian/amps/test-codegen-jar-classes/pom.xml to 
/Users/bturner/Development/atlassian/amps/invoker-repo/com/atlassian/amps/test-codegen-jar-classes/8.0.0-SNAPSHOT/test-codegen-jar-classes-8.0.0-SNAPSHOT.pom
[INFO] Installing 
/Users/bturner/Development/atlassian/amps/test-codegen-jar-classes/target/test-codegen-jar-classes-8.0.0-SNAPSHOT.jar
 to 
/Users/bturner/Development/atlassian/amps/invoker-repo/com/atlassian/amps/test-codegen-jar-classes/8.0.0-SNAPSHOT/test-codegen-jar-classes-8.0.0-SNAPSHOT.jar
[INFO] Installing 
/Users/bturner/Development/atlassian/amps/test-codegen-jar-classes/pom.xml to 
/Users/bturner/Development/atlassian/amps/invoker-repo/com/atlassian/amps/test-codegen-jar-classes/8.0.0-SNAPSHOT/test-codegen-jar-classes-8.0.0-SNAPSHOT.pom
[INFO] Installing 
/Users/bturner/Development/atlassian/amps/plugin-module-codegen-engine/pom.xml 
to 
/Users/bturner/Development/atlassian/amps/invoker-repo/com/atlassian/amps/plugin-module-codegen-engine/8.0.0-SNAPSHOT/plugin-module-codegen-engine-8.0.0-SNAPSHOT.pom
[INFO] Installing 
/Users/bturner/Development/atlassian/amps/plugin-module-codegen-engine/target/plugin-module-codegen-engine-8.0.0-SNAPSHOT.jar
 to 
/Users/bturner/Development/atlassian/amps/invoker-repo/com/atlassian/amps/plugin-module-codegen-engine/8.0.0-SNAPSHOT/plugin-module-codegen-engine-8.0.0-SNAPSHOT.jar
[INFO] Installing 
/Users/bturner/Development/atlassian/amps/plugin-module-codegen-engine/pom.xml 
to 
/Users/bturner/Development/atlassian/amps/invoker-repo/com/atlassian/amps/plugin-module-codegen-engine/8.0.0-SNAPSHOT/plugin-module-codegen-engine-8.0.0-SNAPSHOT.pom
[INFO] Installing 
/Users/bturner/Development/atlassian/amps/plugin-module-codegen-maven-client/pom.xml
 to 
/Users/bturner/Development/atlassian/amps/invoker-repo/com/atlassian/amps/plugin-module-codegen-maven-client/8.0.0-SNAPSHOT/plugin-module-codegen-maven-client-8.0.0-SNAPSHOT.pom
[INFO] Installing 
/Users/bturner/Development/atlassian/amps/plugin-module-codegen-maven-client/target/plugin-module-codegen-maven-client-8.0.0-SNAPSHOT.jar
 to 
/Users/bturner/Development/atlassian/amps/invoker-repo/com/atlassian/amps/plugin-module-codegen-maven-client/8.0.0-SNAPSHOT/plugin-module-codegen-maven-client-8.0.0-SNAPSHOT.jar
[INFO] Installing 
/Users/bturner/Development/atlassian/amps/plugin-module-codegen-maven-client/pom.xml
 to 
/Users/bturner/Development/atlassian/amps/invoker-repo/com/atlassian/amps/plugin-module-codegen-maven-client/8.0.0-SNAPSHOT/plugin-module-codegen-maven-client-8.0.0-SNAPSHOT.pom
[INFO] Installing /Users/bturner/Development/atlassian/amps/standalone/pom.xml 
to 
/Users/bturner/Development/atlassian/amps/invoker-repo/com/atlassian/amps/standalone/8.0.0-SNAPSHOT/standalone-8.0.0-SNAPSHOT.pom
[INFO] Installing 
/Users/bturner/Development/atlassian/amps/amps-product-archetypes/pom.xml to