[jira] [Commented] (MJAR-287) Site says 3.5.2 is Current, but Maven Central Only Contains 3.2.2
[ https://issues.apache.org/jira/browse/MJAR-287?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17530380#comment-17530380 ] David Georg Reichelt commented on MJAR-287: --- Sorry, my mistake. > Site says 3.5.2 is Current, but Maven Central Only Contains 3.2.2 > - > > Key: MJAR-287 > URL: https://issues.apache.org/jira/browse/MJAR-287 > Project: Maven JAR Plugin > Issue Type: Bug > Components: site >Reporter: David Georg Reichelt >Priority: Minor > > If I go on the maven jar plugin site, e.g. on > [https://maven.apache.org/shared/maven-archiver/summary.html,] everything > says version 3.5.2 is current (also in the right top corner at every page). > But as far as I see it, the newest version at least in maven central is 3.2.2 > ([https://mvnrepository.com/artifact/org.apache.maven.plugins/maven-jar-plugin).] > As an end user, it would be nice if the latest deployed version and the > version in the documentation would match (like for the compiler plugin: > [https://maven.apache.org/plugins/maven-compiler-plugin/summary.html] where > 3.10.1 is the latest version, both on the site and in maven central). -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Created] (MJAR-287) Site says 3.5.2 is Current, but Maven Central Only Contains 3.2.2
David Georg Reichelt created MJAR-287: - Summary: Site says 3.5.2 is Current, but Maven Central Only Contains 3.2.2 Key: MJAR-287 URL: https://issues.apache.org/jira/browse/MJAR-287 Project: Maven JAR Plugin Issue Type: Bug Components: site Affects Versions: 3.3.0 Reporter: David Georg Reichelt If I go on the maven jar plugin site, e.g. on [https://maven.apache.org/shared/maven-archiver/summary.html,] everything says version 3.5.2 is current (also in the right top corner at every page). But as far as I see it, the newest version at least in maven central is 3.2.2 ([https://mvnrepository.com/artifact/org.apache.maven.plugins/maven-jar-plugin).] As an end user, it would be nice if the latest deployed version and the version in the documentation would match (like for the compiler plugin: [https://maven.apache.org/plugins/maven-compiler-plugin/summary.html] where 3.10.1 is the latest version, both on the site and in maven central). -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Commented] (SUREFIRE-2010) Parameterized Selection Does not Work
[ https://issues.apache.org/jira/browse/SUREFIRE-2010?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17497432#comment-17497432 ] David Georg Reichelt commented on SUREFIRE-2010: [~tibordigana] Thanks for the quick reply. I was a little surprised that I can post my pullrequest on GH now, since the test currently doesn't really work (it only calls test, without a selector, and it does not check whether certain tests are selected). Nevertheless, I created the pullrequest: [https://github.com/apache/maven-surefire/pull/476] Hope this helps. If you need further input from me, tell me. > Parameterized Selection Does not Work > - > > Key: SUREFIRE-2010 > URL: https://issues.apache.org/jira/browse/SUREFIRE-2010 > Project: Maven Surefire > Issue Type: Bug > Components: Junit 4.x support, JUnit 5.x support >Affects Versions: 3.0.0-M5 > Environment: Maven 3.6.3 and Ubuntu 20.04, but I suppose it happens > everywhere >Reporter: David Georg Reichelt >Priority: Major > > In the current version (and also M6-SNAPSHOT), maven surefire is not capable > of selecting parameterized tests based on the index. In > [https://maven.apache.org/surefire/maven-surefire-plugin/examples/single-test.html,] > it is described that this should work by providing the index, e.g. using > {code:java} > -Dtest=MyTest#method[$INDEX]{code} > or > {code:java} > -Dtest=MyTest#method[*]{code} > for all. > > This happens both for JUnit 4 and JUnit 5. > I created a mwe demonstrating this problem: > [https://github.com/DaGeRe/parameterized-selection-demo] > As far as I see it, the TestMethodFilter in > [https://github.com/apache/maven-surefire/blob/master/surefire-providers/surefire-junit-platform/src/main/java/org/apache/maven/surefire/junitplatform/TestMethodFilter.java#L45] > does the filtering, but has only a descriptor in the form: > > {code:java} > [engine:junit-jupiter]/[class:de.dagere.peass.ExampleTest]/[test-template:test(int)]{code} > > So there is not the concrete value, but only the information that an int > should be provided. Therefore, I currently see not any option to fix this > easily or get this running using a regex pattern. > Do I oversee something, or is it planned to fix this? If not, it would be > better to update the documentation site accordingly. -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Commented] (SUREFIRE-2010) Parameterized Selection Does not Work
[ https://issues.apache.org/jira/browse/SUREFIRE-2010?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17497354#comment-17497354 ] David Georg Reichelt commented on SUREFIRE-2010: Unfortunately, I did not succeed to write a working integration test. I looked at [https://maven.apache.org/surefire/maven-surefire-plugin/developing.html,] which stated that I should to {code:java} cd surefire-integration-tests/src/test/resources/failsafe-buildfail mvn -Dsurefire.version=2.12 verify {code} This did not work (and the link provided there is also not working), since the folder now seems to be named {code:java} surefire-its {code} Could you fix this, or should I just change [https://github.com/apache/maven-surefire/blob/master/maven-surefire-plugin/src/site/apt/developing.apt.vm] and create a PR? Doing {code:java} surefire-its/src/test/resources/surefire-1146-rerunFailingTests-with-Parameterized mvn -Dsurefire.version=3.0.0-M6-SNAPSHOT verify {code} works fine for me and yields the output I would expect. Now I would like to write the integration test itself. After some fiddeling, I got the old test running by {code:java} mvn verify -Dsurefire.version=3.0.0-M6-SNAPSHOT -Dtest=Surefire1146RerunFailedAndParameterizedIT {code} Unfortunately, for my new test [https://github.com/DaGeRe/maven-surefire/blob/surefire-2010/surefire-its/src/test/java/org/apache/maven/surefire/its/jiras/Surefire2010ParameterizedSelectionDoesNotWorkIT.java] (that currently does not select anything and should just execute the tests), the output of {code:java} mvn verify -Dsurefire.version=3.0.0-M6-SNAPSHOT -Dtest=Surefire2010ParameterizedSelectionDoesNotWorkIT {code} is {code:java} [ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.1:testCompile (default-testCompile) on project jiras-surefire-2010: Compilation failure [ERROR] /tmp/Surefire2010ParameterizedSelectionDoesNotWorkIT_testJUnit4/src/test/java/junitplatform/ParametersTest.java:[37,22] static interface method invocations are not supported in -source 7 [ERROR] (use -source 8 or higher to enable static interface method invocations) [ERROR] -> [Help 1] org.apache.maven.lifecycle.LifecycleExecutionException: Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.1:testCompile (default-testCompile) on project jiras-sure fire-2010: Compilation failure /tmp/Surefire2010ParameterizedSelectionDoesNotWorkIT_testJUnit4/src/test/java/junitplatform/ParametersTest.java:[37,22] static interface method invocations are not supported in -source 7 {code} I tried to fix this by adding {code:java} 1.8 1.8 {code} to the {code:java} surefire-its/src/test/resources/surefire-2010-parameterized-selection-does-not-work/pom.xml {code} but then I got the following output: {code:java} [ERROR] junitplatform.ParametersTest.testOneFailingPassingTest(ConnectionPoolFactory)[2] Time elapsed: 0.005 s <<< FAILURE! org.opentest4j.AssertionFailedError: expected: <1> but was: <2> at junitplatform.ParametersTest.testOneFailingPassingTest(ParametersTest.java:57) [INFO] Running junitplatform.FlakyFirstTimeTest Failing test Error test Passing test [ERROR] Tests run: 3, Failures: 1, Errors: 1, Skipped: 0, Time elapsed: 0.004 s <<< FAILURE! - in junitplatform.FlakyFirstTimeTest [ERROR] junitpla
[jira] [Comment Edited] (SUREFIRE-2010) Parameterized Selection Does not Work
[ https://issues.apache.org/jira/browse/SUREFIRE-2010?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17492009#comment-17492009 ] David Georg Reichelt edited comment on SUREFIRE-2010 at 2/14/22, 2:01 PM: -- Thanks for the feedback. I can reproduce this, so it also seems to me like the problem is including the JUnit 5 engine, regardless of whether it is a JUnit 4 or JUnit 5 test. I'll try to write an IT, but unfortunately, I'm busy until Wednesday, so I'll catch up on this on Thursday. was (Author: dagere1989): Thanks for the feedback. I'll try to write an IT, but unfortunately, I'm busy until Wednesday, so I'll catch up on this on Thursday. > Parameterized Selection Does not Work > - > > Key: SUREFIRE-2010 > URL: https://issues.apache.org/jira/browse/SUREFIRE-2010 > Project: Maven Surefire > Issue Type: Bug > Components: Junit 4.x support, JUnit 5.x support >Affects Versions: 3.0.0-M5 > Environment: Maven 3.6.3 and Ubuntu 20.04, but I suppose it happens > everywhere >Reporter: David Georg Reichelt >Priority: Major > > In the current version (and also M6-SNAPSHOT), maven surefire is not capable > of selecting parameterized tests based on the index. In > [https://maven.apache.org/surefire/maven-surefire-plugin/examples/single-test.html,] > it is described that this should work by providing the index, e.g. using > {code:java} > -Dtest=MyTest#method[$INDEX]{code} > or > {code:java} > -Dtest=MyTest#method[*]{code} > for all. > > This happens both for JUnit 4 and JUnit 5. > I created a mwe demonstrating this problem: > [https://github.com/DaGeRe/parameterized-selection-demo] > As far as I see it, the TestMethodFilter in > [https://github.com/apache/maven-surefire/blob/master/surefire-providers/surefire-junit-platform/src/main/java/org/apache/maven/surefire/junitplatform/TestMethodFilter.java#L45] > does the filtering, but has only a descriptor in the form: > > {code:java} > [engine:junit-jupiter]/[class:de.dagere.peass.ExampleTest]/[test-template:test(int)]{code} > > So there is not the concrete value, but only the information that an int > should be provided. Therefore, I currently see not any option to fix this > easily or get this running using a regex pattern. > Do I oversee something, or is it planned to fix this? If not, it would be > better to update the documentation site accordingly. -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Commented] (SUREFIRE-2010) Parameterized Selection Does not Work
[ https://issues.apache.org/jira/browse/SUREFIRE-2010?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17492009#comment-17492009 ] David Georg Reichelt commented on SUREFIRE-2010: Thanks for the feedback. I'll try to write an IT, but unfortunately, I'm busy until Wednesday, so I'll catch up on this on Thursday. > Parameterized Selection Does not Work > - > > Key: SUREFIRE-2010 > URL: https://issues.apache.org/jira/browse/SUREFIRE-2010 > Project: Maven Surefire > Issue Type: Bug > Components: Junit 4.x support, JUnit 5.x support >Affects Versions: 3.0.0-M5 > Environment: Maven 3.6.3 and Ubuntu 20.04, but I suppose it happens > everywhere >Reporter: David Georg Reichelt >Priority: Major > > In the current version (and also M6-SNAPSHOT), maven surefire is not capable > of selecting parameterized tests based on the index. In > [https://maven.apache.org/surefire/maven-surefire-plugin/examples/single-test.html,] > it is described that this should work by providing the index, e.g. using > {code:java} > -Dtest=MyTest#method[$INDEX]{code} > or > {code:java} > -Dtest=MyTest#method[*]{code} > for all. > > This happens both for JUnit 4 and JUnit 5. > I created a mwe demonstrating this problem: > [https://github.com/DaGeRe/parameterized-selection-demo] > As far as I see it, the TestMethodFilter in > [https://github.com/apache/maven-surefire/blob/master/surefire-providers/surefire-junit-platform/src/main/java/org/apache/maven/surefire/junitplatform/TestMethodFilter.java#L45] > does the filtering, but has only a descriptor in the form: > > {code:java} > [engine:junit-jupiter]/[class:de.dagere.peass.ExampleTest]/[test-template:test(int)]{code} > > So there is not the concrete value, but only the information that an int > should be provided. Therefore, I currently see not any option to fix this > easily or get this running using a regex pattern. > Do I oversee something, or is it planned to fix this? If not, it would be > better to update the documentation site accordingly. -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Comment Edited] (SUREFIRE-2010) Parameterized Selection Does not Work
[ https://issues.apache.org/jira/browse/SUREFIRE-2010?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17491446#comment-17491446 ] David Georg Reichelt edited comment on SUREFIRE-2010 at 2/12/22, 8:36 PM: -- Thanks for the hint, so JUnit 5 is not supported currently. However, as far as I see, this also does not work for JUnit 4. So in the example project, running {code:java} mvn clean test -Dtest=*ExampleTestJUnit4#test[1]{code} also results in an error. Using JUnit 4, the descriptor has the form {code:java} [engine:junit-vintage]/[runner:de.dagere.peass.ExampleTestJUnit4]/[test:%5B1%5D]/[test:test%5B1%5D(de.dagere.peass.ExampleTestJUnit4)]{code} was (Author: dagere1989): Thanks for the hint, so JUnit 5 is not supported currently. However, as far as I see, this also does not work for JUnit 4. So in the example project, running {{}} {code:java} mvn clean test -Dtest=*ExampleTestJUnit4#test[1]{code} {{}} also results in an error. Using JUnit 4, the descriptor has the form {code:java} [engine:junit-vintage]/[runner:de.dagere.peass.ExampleTestJUnit4]/[test:%5B1%5D]/[test:test%5B1%5D(de.dagere.peass.ExampleTestJUnit4)]{code} {{{}{}}}{{{}{}}} > Parameterized Selection Does not Work > - > > Key: SUREFIRE-2010 > URL: https://issues.apache.org/jira/browse/SUREFIRE-2010 > Project: Maven Surefire > Issue Type: Bug > Components: Junit 4.x support, JUnit 5.x support >Affects Versions: 3.0.0-M5 > Environment: Maven 3.6.3 and Ubuntu 20.04, but I suppose it happens > everywhere >Reporter: David Georg Reichelt >Priority: Minor > > In the current version (and also M6-SNAPSHOT), maven surefire is not capable > of selecting parameterized tests based on the index. In > [https://maven.apache.org/surefire/maven-surefire-plugin/examples/single-test.html,] > it is described that this should work by providing the index, e.g. using > {code:java} > -Dtest=MyTest#method[$INDEX]{code} > or > {code:java} > -Dtest=MyTest#method[*]{code} > for all. > > This happens both for JUnit 4 and JUnit 5. > I created a mwe demonstrating this problem: > [https://github.com/DaGeRe/parameterized-selection-demo] > As far as I see it, the TestMethodFilter in > [https://github.com/apache/maven-surefire/blob/master/surefire-providers/surefire-junit-platform/src/main/java/org/apache/maven/surefire/junitplatform/TestMethodFilter.java#L45] > does the filtering, but has only a descriptor in the form: > > {code:java} > [engine:junit-jupiter]/[class:de.dagere.peass.ExampleTest]/[test-template:test(int)]{code} > > So there is not the concrete value, but only the information that an int > should be provided. Therefore, I currently see not any option to fix this > easily or get this running using a regex pattern. > Do I oversee something, or is it planned to fix this? If not, it would be > better to update the documentation site accordingly. -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Commented] (SUREFIRE-2010) Parameterized Selection Does not Work
[ https://issues.apache.org/jira/browse/SUREFIRE-2010?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17491446#comment-17491446 ] David Georg Reichelt commented on SUREFIRE-2010: Thanks for the hint, so JUnit 5 is not supported currently. However, as far as I see, this also does not work for JUnit 4. So in the example project, running {{}} {code:java} mvn clean test -Dtest=*ExampleTestJUnit4#test[1]{code} {{}} also results in an error. Using JUnit 4, the descriptor has the form {code:java} [engine:junit-vintage]/[runner:de.dagere.peass.ExampleTestJUnit4]/[test:%5B1%5D]/[test:test%5B1%5D(de.dagere.peass.ExampleTestJUnit4)]{code} {{{}{}}}{{{}{}}} > Parameterized Selection Does not Work > - > > Key: SUREFIRE-2010 > URL: https://issues.apache.org/jira/browse/SUREFIRE-2010 > Project: Maven Surefire > Issue Type: Bug > Components: Junit 4.x support, JUnit 5.x support >Affects Versions: 3.0.0-M5 > Environment: Maven 3.6.3 and Ubuntu 20.04, but I suppose it happens > everywhere >Reporter: David Georg Reichelt >Priority: Minor > > In the current version (and also M6-SNAPSHOT), maven surefire is not capable > of selecting parameterized tests based on the index. In > [https://maven.apache.org/surefire/maven-surefire-plugin/examples/single-test.html,] > it is described that this should work by providing the index, e.g. using > {code:java} > -Dtest=MyTest#method[$INDEX]{code} > or > {code:java} > -Dtest=MyTest#method[*]{code} > for all. > > This happens both for JUnit 4 and JUnit 5. > I created a mwe demonstrating this problem: > [https://github.com/DaGeRe/parameterized-selection-demo] > As far as I see it, the TestMethodFilter in > [https://github.com/apache/maven-surefire/blob/master/surefire-providers/surefire-junit-platform/src/main/java/org/apache/maven/surefire/junitplatform/TestMethodFilter.java#L45] > does the filtering, but has only a descriptor in the form: > > {code:java} > [engine:junit-jupiter]/[class:de.dagere.peass.ExampleTest]/[test-template:test(int)]{code} > > So there is not the concrete value, but only the information that an int > should be provided. Therefore, I currently see not any option to fix this > easily or get this running using a regex pattern. > Do I oversee something, or is it planned to fix this? If not, it would be > better to update the documentation site accordingly. -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Created] (SUREFIRE-2010) Parameterized Selection Does not Work
David Georg Reichelt created SUREFIRE-2010: -- Summary: Parameterized Selection Does not Work Key: SUREFIRE-2010 URL: https://issues.apache.org/jira/browse/SUREFIRE-2010 Project: Maven Surefire Issue Type: Bug Components: Junit 4.x support, JUnit 5.x support Affects Versions: 3.0.0-M5 Environment: Maven 3.6.3 and Ubuntu 20.04, but I suppose it happens everywhere Reporter: David Georg Reichelt In the current version (and also M6-SNAPSHOT), maven surefire is not capable of selecting parameterized tests based on the index. In [https://maven.apache.org/surefire/maven-surefire-plugin/examples/single-test.html,] it is described that this should work by providing the index, e.g. using {code:java} -Dtest=MyTest#method[$INDEX]{code} or {code:java} -Dtest=MyTest#method[*]{code} for all. This happens both for JUnit 4 and JUnit 5. I created a mwe demonstrating this problem: [https://github.com/DaGeRe/parameterized-selection-demo] As far as I see it, the TestMethodFilter in [https://github.com/apache/maven-surefire/blob/master/surefire-providers/surefire-junit-platform/src/main/java/org/apache/maven/surefire/junitplatform/TestMethodFilter.java#L45] does the filtering, but has only a descriptor in the form: {code:java} [engine:junit-jupiter]/[class:de.dagere.peass.ExampleTest]/[test-template:test(int)]{code} So there is not the concrete value, but only the information that an int should be provided. Therefore, I currently see not any option to fix this easily or get this running using a regex pattern. Do I oversee something, or is it planned to fix this? If not, it would be better to update the documentation site accordingly. -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Commented] (SUREFIRE-1454) Speedup Standard Output if Tests
[ https://issues.apache.org/jira/browse/SUREFIRE-1454?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16391278#comment-16391278 ] David Georg Reichelt commented on SUREFIRE-1454: Surefire3 means commit c10e717d44edd45772bdf696e2cdc2e942ee7643, X axis is count of lines printed to stdout and y axis is average duration of execution (x lines are printed 100 times to stdout, this is repeated in 3 VM starts, and over all this executions the average is calculated). > Speedup Standard Output if Tests > > > Key: SUREFIRE-1454 > URL: https://issues.apache.org/jira/browse/SUREFIRE-1454 > Project: Maven Surefire > Issue Type: Improvement > Components: Maven Failsafe Plugin, Maven Surefire Plugin, process > forking >Reporter: Tibor Digana >Assignee: Tibor Digana >Priority: Major > Fix For: 2.21.0 > > > Currently, surefire creates a new byte array with size of the input *3 for > saving the unescaped input. This made surefire way slower than running a test > directly in eclipse or with gradle, if it used standardout or error heavily. > By using a list for saving the elements and converting them to an array > afterwards, this problem is solved, and stdout-heavy surefire tests get > faster. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SUREFIRE-1454) Speedup Standard Output if Tests
[ https://issues.apache.org/jira/browse/SUREFIRE-1454?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16391019#comment-16391019 ] David Georg Reichelt commented on SUREFIRE-1454: I did not believe that this patch also solves the issue and therefore created a benchmark: [https://github.com/DaGeRe/surefire-benchmark] . It indicates that surefire 3 ( [https://github.com/DaGeRe/surefire-benchmark/blob/master/results/surefire3.png] ) is performing similiar as my original patch ( [https://github.com/DaGeRe/surefire-benchmark/blob/master/results/surefire_dagerepatch.png] ), while the old surefire version is very slow ( [https://github.com/DaGeRe/surefire-benchmark/blob/master/results/surefire219.png] ). Therefore, it seems like everythings is fine. > Speedup Standard Output if Tests > > > Key: SUREFIRE-1454 > URL: https://issues.apache.org/jira/browse/SUREFIRE-1454 > Project: Maven Surefire > Issue Type: Improvement > Components: Maven Failsafe Plugin, Maven Surefire Plugin, process > forking >Reporter: Tibor Digana >Assignee: Tibor Digana >Priority: Major > Fix For: 2.21.0 > > > Currently, surefire creates a new byte array with size of the input *3 for > saving the unescaped input. This made surefire way slower than running a test > directly in eclipse or with gradle, if it used standardout or error heavily. > By using a list for saving the elements and converting them to an array > afterwards, this problem is solved, and stdout-heavy surefire tests get > faster. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] (MNGSITE-177) Annotation not existing
David Georg Reichelt created MNGSITE-177: Summary: Annotation not existing Key: MNGSITE-177 URL: https://jira.codehaus.org/browse/MNGSITE-177 Project: Maven Project Web Site Issue Type: Bug Environment: Ubuntu 12.10 Reporter: David Georg Reichelt Priority: Minor On http://maven.apache.org/guides/plugin/guide-java-plugin-development.html the Code for a plugin seems to be wrong: at least at my environment, I can't use the annotation @Mojo( name = "sayhi"). Instead (copied from another site) I can specify the name of a new mojo via the annotation /** * Goal which touches a timestamp file. * * @goal touch * * @phase process-sources */ As I copied the dependency, my version of the Mojo-API should be up-to-date, and I can't find a @Mojo annotation in http://maven.apache.org/developers/mojo-api-specification.html anyway, so the problem seems to be the documentation at the site. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira