[jira] [Created] (SUREFIRE-2143) Disabled @ParametrizedTest is not counted as skipped one in M8 (worked in M7)
Jiri Ondrusek created SUREFIRE-2143:
---
Summary: Disabled @ParametrizedTest is not counted as skipped one
in M8 (worked in M7)
Key: SUREFIRE-2143
URL: https://issues.apache.org/jira/browse/SUREFIRE-2143
Project: Maven Surefire
Issue Type: Bug
Components: JUnit 5.x support
Affects Versions: 3.0.0-M8
Reporter: Jiri Ondrusek
I'm upgrading surefire plugin from 2.22.2 to 3.0.0-M8, but there are
differences in numbers of skipped tests.
Follows https://issues.apache.org/jira/browse/SUREFIRE-1812 -> which is working
correctly with M8 (not with M7)
But there is another issue, when disabled @ParametrizedTest is not counted
towards skipped tests. This issue happens in M8, works in M7
I prepared simple reproducer -
[https://github.com/JiriOndrusek/surefire-reproducer-2]
Result with 3.0.0-M8 is *wrong*
{code:java}
[INFO] Running reproducer.ReproducerTest
[WARNING] Tests run: 1, Failures: 0, Errors: 0, Skipped: 1, Time elapsed: 0.03
s - in reproducer.ReproducerTest
[INFO]
[INFO] Results:
[INFO]
[WARNING] Tests run: 1, Failures: 0, Errors: 0, Skipped: 1
{code}
Result with 3.0.0-M7 is correct:
{code:java}
[INFO] Running reproducer.ReproducerTest
[WARNING] Tests run: 2, Failures: 0, Errors: 0, Skipped: 2, Time elapsed: 0.031
s - in reproducer.ReproducerTest
[INFO]
[INFO] Results:
[INFO]
[WARNING] Tests run: 2, Failures: 0, Errors: 0, Skipped: 2
{code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (SUREFIRE-1812) Skipped tests (by annotation @EnabledIfEnvironmentVariable on the test class) are not reported
[
https://issues.apache.org/jira/browse/SUREFIRE-1812?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17678246#comment-17678246
]
Jiri Ondrusek commented on SUREFIRE-1812:
-
[~tibordigana]
I verified the current state of the problem with my reproducer. All versions
3.0.0-M5 - 3.0.0-M7 show the error.
Version 3.0.0-M8 shows the correct result, therefore I think that the issue may
by closed as fixed (TBH I didn't search for the commit fixing that behavior.
The results just confirm, that some upgrades between M7 and M8 fixed this issue)
> Skipped tests (by annotation @EnabledIfEnvironmentVariable on the test class)
> are not reported
> --
>
> Key: SUREFIRE-1812
> URL: https://issues.apache.org/jira/browse/SUREFIRE-1812
> Project: Maven Surefire
> Issue Type: Bug
> Components: JUnit 5.x support, Maven Surefire Plugin
>Affects Versions: 3.0.0-M4, 3.0.0-M5
>Reporter: Jiri Ondrusek
>Priority: Major
> Labels: junit5
> Fix For: Backlog
>
>
> I'm upgrading surefire plugin from 2.22.2 and there is a different behavior
> started from 3.0.0-M4.
> When the test class is ignored by using @EnabledIfEnvironmentVariable(...),
> final report shows bad information: (3.0.0.-M4, M5, master)
> {quote}[INFO] Results:
> [INFO]
> [INFO] Tests run: 0, Failures: 0, Errors: 0, Skipped: 0
> {quote}
> The same test executed with 3.0.0-M3 shows:
> {quote}[INFO] Results:
> [INFO]
> [WARNING] Tests run: 1, Failures: 0, Errors: 0, Skipped: 1
> {quote}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (SUREFIRE-1812) Skipped tests (by annotation @EnabledIfEnvironmentVariable on the test class) are not reported
[
https://issues.apache.org/jira/browse/SUREFIRE-1812?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17278097#comment-17278097
]
Jiri Ondrusek commented on SUREFIRE-1812:
-
[~tibordigana]
I've created a simple reproducer:
[https://github.com/JiriOndrusek/SUREFIRE-1812-reproducer]
Run test via 'mvn test' and get
{quote}[INFO] ---
[INFO] T E S T S
[INFO] ---
[INFO]
[INFO] Results:
[INFO]
[INFO] Tests run: 0, Failures: 0, Errors: 0, Skipped: 0
{quote}
Switch maven-surefire-plugin to 3.0.0-M5 in
[https://github.com/JiriOndrusek/SUREFIRE-1812-reproducer/blob/master/pom.xml#L36]
Run again. Result is:
{quote}INFO] ---
[INFO] T E S T S
[INFO] ---
[INFO] Running reproducer.eproducerTest
[WARNING] Tests run: 1, Failures: 0, Errors: 0, Skipped: 1, Time elapsed:
0.004 s - in reproducer.eproducerTest
[INFO]
[INFO] Results:
[INFO]
[WARNING] Tests run: 1, Failures: 0, Errors: 0, Skipped: 1
[INFO]
[INFO]
[INFO] BUILD SUCCESS
{quote}
(you can not have environmental variable with name *TEST_ENV* - see
[https://github.com/JiriOndrusek/SUREFIRE-1812-reproducer/blob/master/src/test/java/reproducer/ReproducerTest.java#L8])
> Skipped tests (by annotation @EnabledIfEnvironmentVariable on the test class)
> are not reported
> --
>
> Key: SUREFIRE-1812
> URL: https://issues.apache.org/jira/browse/SUREFIRE-1812
> Project: Maven Surefire
> Issue Type: Bug
> Components: Maven Surefire Plugin
>Affects Versions: 3.0.0-M4, 3.0.0-M5
>Reporter: Jiri Ondrusek
>Priority: Major
>
> I'm upgrading surefire plugin from 2.22.2 and there is a different behavior
> started from 3.0.0-M4.
> When the test class is ignored by using @EnabledIfEnvironmentVariable(...),
> final report shows bad information: (3.0.0.-M4, M5, master)
> {quote}[INFO] Results:
> [INFO]
> [INFO] Tests run: 0, Failures: 0, Errors: 0, Skipped: 0
> {quote}
> The same test executed with 3.0.0-M3 shows:
> {quote}[INFO] Results:
> [INFO]
> [WARNING] Tests run: 1, Failures: 0, Errors: 0, Skipped: 1
> {quote}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (SUREFIRE-1812) Skipped tests (by annotation @EnabledIfEnvironmentVariable on the test class) are not reported
[
https://issues.apache.org/jira/browse/SUREFIRE-1812?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17276968#comment-17276968
]
Jiri Ondrusek commented on SUREFIRE-1812:
-
[~tibordigana] I'll try to create a reproducer without the requirement to build
whole camel-quarkus
> Skipped tests (by annotation @EnabledIfEnvironmentVariable on the test class)
> are not reported
> --
>
> Key: SUREFIRE-1812
> URL: https://issues.apache.org/jira/browse/SUREFIRE-1812
> Project: Maven Surefire
> Issue Type: Bug
> Components: Maven Surefire Plugin
>Affects Versions: 3.0.0-M4, 3.0.0-M5
>Reporter: Jiri Ondrusek
>Priority: Major
>
> I'm upgrading surefire plugin from 2.22.2 and there is a different behavior
> started from 3.0.0-M4.
> When the test class is ignored by using @EnabledIfEnvironmentVariable(...),
> final report shows bad information: (3.0.0.-M4, M5, master)
> {quote}[INFO] Results:
> [INFO]
> [INFO] Tests run: 0, Failures: 0, Errors: 0, Skipped: 0
> {quote}
> The same test executed with 3.0.0-M3 shows:
> {quote}[INFO] Results:
> [INFO]
> [WARNING] Tests run: 1, Failures: 0, Errors: 0, Skipped: 1
> {quote}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (SUREFIRE-1812) Skipped tests (by annotation @EnabledIfEnvironmentVariable on the test class) are not reported
[
https://issues.apache.org/jira/browse/SUREFIRE-1812?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17276293#comment-17276293
]
Jiri Ondrusek commented on SUREFIRE-1812:
-
Hi [~tibordigana], I've retested my scenario and problem is still there. How to
reproduce:
* get camel-quarkus from my branch:
[https://github.com/JiriOndrusek/camel-quarkus/tree/upgrading-maven-surefire-plugin]
* build (mvn clen install -DskipTests)
* run jvm test of braintree (`mvn test -fintegration-tests/braintree`), which
uses maven-surefire-plugin 3.0.0-M5
* result is:
{quote}[INFO] ---
[INFO] T E S T S
[INFO] ---
[INFO]
[INFO] Results:
[INFO]
[INFO] Tests run: 0, Failures: 0, Errors: 0, Skipped: 0
{quote}
* revert last commit (which returns maven-surefire-plugin to 2.22.2)
* run the same test
* result is
{quote}[INFO] ---
[INFO] T E S T S
[INFO] ---
[INFO] Running org.apache.camel.quarkus.component.braintree.it.BraintreeTest
[WARNING] Tests run: 1, Failures: 0, Errors: 0, Skipped: 1, Time elapsed: 0.004
s - in org.apache.camel.quarkus.component.braintree.it.BraintreeTest
[INFO]
[INFO] Results:
[INFO]
[WARNING] Tests run: 1, Failures: 0, Errors: 0, Skipped: 1{quote}
Annotation is here:
https://github.com/JiriOndrusek/camel-quarkus/blob/upgrading-maven-surefire-plugin/integration-tests/braintree/src/test/java/org/apache/camel/quarkus/component/braintree/it/BraintreeTest.java#L29-L31
> Skipped tests (by annotation @EnabledIfEnvironmentVariable on the test class)
> are not reported
> --
>
> Key: SUREFIRE-1812
> URL: https://issues.apache.org/jira/browse/SUREFIRE-1812
> Project: Maven Surefire
> Issue Type: Bug
> Components: Maven Surefire Plugin
>Affects Versions: 3.0.0-M4, 3.0.0-M5
>Reporter: Jiri Ondrusek
>Priority: Major
>
> I'm upgrading surefire plugin from 2.22.2 and there is a different behavior
> started from 3.0.0-M4.
> When the test class is ignored by using @EnabledIfEnvironmentVariable(...),
> final report shows bad information: (3.0.0.-M4, M5, master)
> {quote}[INFO] Results:
> [INFO]
> [INFO] Tests run: 0, Failures: 0, Errors: 0, Skipped: 0
> {quote}
> The same test executed with 3.0.0-M3 shows:
> {quote}[INFO] Results:
> [INFO]
> [WARNING] Tests run: 1, Failures: 0, Errors: 0, Skipped: 1
> {quote}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (SUREFIRE-1812) Skipped tests (by annotation @EnabledIfEnvironmentVariable on the test class) are not reported
[
https://issues.apache.org/jira/browse/SUREFIRE-1812?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=1727#comment-1727
]
Jiri Ondrusek commented on SUREFIRE-1812:
-
[~tibordigana] I rebased my test branch -
[https://github.com/apache/camel-quarkus/pull/1383] - and once there will be
some results, I'll compare it to some other results (using older surefire
plugin). From my notes, there should be a difference in the following test:
`org.apache.camel.quarkus.component.braintree.it.BraintreeTest`
> Skipped tests (by annotation @EnabledIfEnvironmentVariable on the test class)
> are not reported
> --
>
> Key: SUREFIRE-1812
> URL: https://issues.apache.org/jira/browse/SUREFIRE-1812
> Project: Maven Surefire
> Issue Type: Bug
> Components: Maven Surefire Plugin
>Affects Versions: 3.0.0-M4, 3.0.0-M5
>Reporter: Jiri Ondrusek
>Priority: Major
>
> I'm upgrading surefire plugin from 2.22.2 and there is a different behavior
> started from 3.0.0-M4.
> When the test class is ignored by using @EnabledIfEnvironmentVariable(...),
> final report shows bad information: (3.0.0.-M4, M5, master)
> {quote}[INFO] Results:
> [INFO]
> [INFO] Tests run: 0, Failures: 0, Errors: 0, Skipped: 0
> {quote}
> The same test executed with 3.0.0-M3 shows:
> {quote}[INFO] Results:
> [INFO]
> [WARNING] Tests run: 1, Failures: 0, Errors: 0, Skipped: 1
> {quote}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (SUREFIRE-1809) Differences between Oracle JDK and AdoptOpenJDK caused by JPMS
[ https://issues.apache.org/jira/browse/SUREFIRE-1809?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17152539#comment-17152539 ] Jiri Ondrusek commented on SUREFIRE-1809: - Hi [~tibordigana] , I agree with closing this ticket by the fix in the branch surefire-1809. Do I understand correctly, that the fix will be merged into master (to be part of M6)? > Differences between Oracle JDK and AdoptOpenJDK caused by JPMS > -- > > Key: SUREFIRE-1809 > URL: https://issues.apache.org/jira/browse/SUREFIRE-1809 > Project: Maven Surefire > Issue Type: Bug > Components: Maven Failsafe Plugin, Maven Surefire Plugin >Affects Versions: 3.0.0-M5 >Reporter: Jiri Ondrusek >Assignee: Tibor Digana >Priority: Major > Fix For: 3.0.0-M6 > > > I was upgrading maven-surefire-plugin to 3.0.0-M5 in > [camel-quarkus|[https://github.com/apache/camel-quarkus]] project. > Unfortunately there was a test which was failing on CI (using AdoptOpenJDK > build 11.0.7+10) and there was no failure on my local machine (using Oracle > "11.0.7" 2020-04-14 LTS). > Problem was caused by JPMS. On Orace JDK this was turned off by default. On > AdoptOpenJDK it was turned on by default. Solution was to turn this feature > off by configuration (https://github.com/apache/camel-quarkus/pull/1383). > It would be nice if default behavior was the same for different Java vendors. > Difference seems to be coming from this line - > https://github.com/apache/maven-surefire/blob/master/maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/AbstractSurefireMojo.java#L1423 > On AdoptOpenJDK both 3 clausules are true. On Oracle JDK the last one is > false. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (SUREFIRE-1809) Differences between Oracle JDK and AdoptOpenJDK caused by JPMS
[ https://issues.apache.org/jira/browse/SUREFIRE-1809?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17149514#comment-17149514 ] Jiri Ondrusek commented on SUREFIRE-1809: - I'll try to add some logs tomorrow. But shortly: M-5: oracle jdk in native mode - was successful week ago (but it is failing now - don't now why, I'm using the same revision - with the same error as adopt jdk)) M-5: adoptJdk in native mode fails with `java.lang.ClassNotFoundException: org.apache.camel.quarkus.main.CamelMainRoutesCollector` M-6-SNAPSHOT: oracle jdk in native mode works M-6-SNAPSHOT: adoptjdk in native mode works for both cases with M-5 there is a workaround to use `false` > Differences between Oracle JDK and AdoptOpenJDK caused by JPMS > -- > > Key: SUREFIRE-1809 > URL: https://issues.apache.org/jira/browse/SUREFIRE-1809 > Project: Maven Surefire > Issue Type: Bug > Components: Maven Failsafe Plugin, Maven Surefire Plugin >Affects Versions: 3.0.0-M5 >Reporter: Jiri Ondrusek >Assignee: Tibor Digana >Priority: Major > Fix For: 3.0.0-M6 > > > I was upgrading maven-surefire-plugin to 3.0.0-M5 in > [camel-quarkus|[https://github.com/apache/camel-quarkus]] project. > Unfortunately there was a test which was failing on CI (using AdoptOpenJDK > build 11.0.7+10) and there was no failure on my local machine (using Oracle > "11.0.7" 2020-04-14 LTS). > Problem was caused by JPMS. On Orace JDK this was turned off by default. On > AdoptOpenJDK it was turned on by default. Solution was to turn this feature > off by configuration (https://github.com/apache/camel-quarkus/pull/1383). > It would be nice if default behavior was the same for different Java vendors. > Difference seems to be coming from this line - > https://github.com/apache/maven-surefire/blob/master/maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/AbstractSurefireMojo.java#L1423 > On AdoptOpenJDK both 3 clausules are true. On Oracle JDK the last one is > false. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (SUREFIRE-1809) Differences between Oracle JDK and AdoptOpenJDK caused by JPMS
[ https://issues.apache.org/jira/browse/SUREFIRE-1809?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17149429#comment-17149429 ] Jiri Ondrusek commented on SUREFIRE-1809: - [~tibordigana] I tested branch 'surefire-1809' with the test I'm referencing in the summary: * unfortunately, I'm not able to simulate successful run on oracle JDK with plugin 3.0.0-M5 (which I was using before - not sure why it is different now) * nevertheless I'm able to test scenario with adopt JDK, without using false. Fix works. With plugin 3.0.0-M5 test fails, with 3.0.0-M6-SNAPSHOT is successful. From my POV branch fixes this issue. To be able to finally upgrade surefire plugin, there is an issue https://issues.apache.org/jira/browse/SUREFIRE-1812, which causes that some ignored tests are not reported. > Differences between Oracle JDK and AdoptOpenJDK caused by JPMS > -- > > Key: SUREFIRE-1809 > URL: https://issues.apache.org/jira/browse/SUREFIRE-1809 > Project: Maven Surefire > Issue Type: Bug > Components: Maven Failsafe Plugin, Maven Surefire Plugin >Affects Versions: 3.0.0-M5 >Reporter: Jiri Ondrusek >Assignee: Tibor Digana >Priority: Major > Fix For: 3.0.0-M6 > > > I was upgrading maven-surefire-plugin to 3.0.0-M5 in > [camel-quarkus|[https://github.com/apache/camel-quarkus]] project. > Unfortunately there was a test which was failing on CI (using AdoptOpenJDK > build 11.0.7+10) and there was no failure on my local machine (using Oracle > "11.0.7" 2020-04-14 LTS). > Problem was caused by JPMS. On Orace JDK this was turned off by default. On > AdoptOpenJDK it was turned on by default. Solution was to turn this feature > off by configuration (https://github.com/apache/camel-quarkus/pull/1383). > It would be nice if default behavior was the same for different Java vendors. > Difference seems to be coming from this line - > https://github.com/apache/maven-surefire/blob/master/maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/AbstractSurefireMojo.java#L1423 > On AdoptOpenJDK both 3 clausules are true. On Oracle JDK the last one is > false. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (SUREFIRE-1809) Differences between Oracle JDK and AdoptOpenJDK caused by JPMS
[ https://issues.apache.org/jira/browse/SUREFIRE-1809?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17149168#comment-17149168 ] Jiri Ondrusek commented on SUREFIRE-1809: - [~tibordigana] I'll verify camel-quarkus with plugin from branch (with -nsu in command) > Differences between Oracle JDK and AdoptOpenJDK caused by JPMS > -- > > Key: SUREFIRE-1809 > URL: https://issues.apache.org/jira/browse/SUREFIRE-1809 > Project: Maven Surefire > Issue Type: Bug > Components: Maven Failsafe Plugin, Maven Surefire Plugin >Affects Versions: 3.0.0-M5 >Reporter: Jiri Ondrusek >Assignee: Tibor Digana >Priority: Major > Fix For: 3.0.0-M6 > > > I was upgrading maven-surefire-plugin to 3.0.0-M5 in > [camel-quarkus|[https://github.com/apache/camel-quarkus]] project. > Unfortunately there was a test which was failing on CI (using AdoptOpenJDK > build 11.0.7+10) and there was no failure on my local machine (using Oracle > "11.0.7" 2020-04-14 LTS). > Problem was caused by JPMS. On Orace JDK this was turned off by default. On > AdoptOpenJDK it was turned on by default. Solution was to turn this feature > off by configuration (https://github.com/apache/camel-quarkus/pull/1383). > It would be nice if default behavior was the same for different Java vendors. > Difference seems to be coming from this line - > https://github.com/apache/maven-surefire/blob/master/maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/AbstractSurefireMojo.java#L1423 > On AdoptOpenJDK both 3 clausules are true. On Oracle JDK the last one is > false. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (SUREFIRE-1812) Skipped tests (by annotation @EnabledIfEnvironmentVariable on the test class) are not reported
Jiri Ondrusek created SUREFIRE-1812:
---
Summary: Skipped tests (by annotation
@EnabledIfEnvironmentVariable on the test class) are not reported
Key: SUREFIRE-1812
URL: https://issues.apache.org/jira/browse/SUREFIRE-1812
Project: Maven Surefire
Issue Type: Bug
Components: Maven Surefire Plugin
Affects Versions: 3.0.0-M5, 3.0.0-M4
Reporter: Jiri Ondrusek
I'm upgrading surefire plugin from 2.22.2 and there is a different behavior
started from 3.0.0-M4.
When the test class is ignored by using @EnabledIfEnvironmentVariable(...),
final report shows bad information: (3.0.0.-M4, M5, master)
{quote}[INFO] Results:
[INFO]
[INFO] Tests run: 0, Failures: 0, Errors: 0, Skipped: 0
{quote}
The same test executed with 3.0.0-M3 shows:
{quote}[INFO] Results:
[INFO]
[WARNING] Tests run: 1, Failures: 0, Errors: 0, Skipped: 1
{quote}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (SUREFIRE-1809) Differences between Oracle JDK and AdoptOpenJDK caused by JPMS
[ https://issues.apache.org/jira/browse/SUREFIRE-1809?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17146040#comment-17146040 ] Jiri Ondrusek commented on SUREFIRE-1809: - [~tibordigana] yes. That's the way I used and it is working. > Differences between Oracle JDK and AdoptOpenJDK caused by JPMS > -- > > Key: SUREFIRE-1809 > URL: https://issues.apache.org/jira/browse/SUREFIRE-1809 > Project: Maven Surefire > Issue Type: Bug > Components: Maven Failsafe Plugin, Maven Surefire Plugin >Affects Versions: 3.0.0-M5 >Reporter: Jiri Ondrusek >Assignee: Tibor Digana >Priority: Major > Fix For: 3.0.0-M6 > > > I was upgrading maven-surefire-plugin to 3.0.0-M5 in > [camel-quarkus|[https://github.com/apache/camel-quarkus]] project. > Unfortunately there was a test which was failing on CI (using AdoptOpenJDK > build 11.0.7+10) and there was no failure on my local machine (using Oracle > "11.0.7" 2020-04-14 LTS). > Problem was caused by JPMS. On Orace JDK this was turned off by default. On > AdoptOpenJDK it was turned on by default. Solution was to turn this feature > off by configuration (https://github.com/apache/camel-quarkus/pull/1383). > It would be nice if default behavior was the same for different Java vendors. > Difference seems to be coming from this line - > https://github.com/apache/maven-surefire/blob/master/maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/AbstractSurefireMojo.java#L1423 > On AdoptOpenJDK both 3 clausules are true. On Oracle JDK the last one is > false. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (SUREFIRE-1809) Differences between Oracle JDK and AdoptOpenJDK caused by JPMS
[ https://issues.apache.org/jira/browse/SUREFIRE-1809?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17144970#comment-17144970 ] Jiri Ondrusek commented on SUREFIRE-1809: - And another thing. Version of surefire-plugin has to be changed to `3.0.0-M5` (here https://github.com/apache/camel-quarkus/pull/1383/files#diff-600376dffeb79835ede4a0b285078036R120) > Differences between Oracle JDK and AdoptOpenJDK caused by JPMS > -- > > Key: SUREFIRE-1809 > URL: https://issues.apache.org/jira/browse/SUREFIRE-1809 > Project: Maven Surefire > Issue Type: Bug > Components: Maven Failsafe Plugin, Maven Surefire Plugin >Affects Versions: 3.0.0-M5 >Reporter: Jiri Ondrusek >Priority: Major > > I was upgrading maven-surefire-plugin to 3.0.0-M5 in > [camel-quarkus|[https://github.com/apache/camel-quarkus]] project. > Unfortunately there was a test which was failing on CI (using AdoptOpenJDK > build 11.0.7+10) and there was no failure on my local machine (using Oracle > "11.0.7" 2020-04-14 LTS). > Problem was caused by JPMS. On Orace JDK this was turned off by default. On > AdoptOpenJDK it was turned on by default. Solution was to turn this feature > off by configuration (https://github.com/apache/camel-quarkus/pull/1383). > It would be nice if default behavior was the same for different Java vendors. > Difference seems to be coming from this line - > https://github.com/apache/maven-surefire/blob/master/maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/AbstractSurefireMojo.java#L1423 > On AdoptOpenJDK both 3 clausules are true. On Oracle JDK the last one is > false. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (SUREFIRE-1809) Differences between Oracle JDK and AdoptOpenJDK caused by JPMS
[ https://issues.apache.org/jira/browse/SUREFIRE-1809?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17144965#comment-17144965 ] Jiri Ondrusek commented on SUREFIRE-1809: - Hi [~tibordigana], yes, I was debugging plugin. But I don't know much about its architecture, so I've found only difference against Oracle jdk and AdoptOpenJDK executions. Test I was running was org.apache.camel.quarkus.main.CoreMainIT.testMainInstance in native mode. I was running test by command: `mvn clean verify -Pnative -f integration-tests/main` If executed with AdoptOpenJDK there was 1 error. If executed with oracle JDK, there was no error. (Just be sure, that this PR is not merged in your revision - it sets JPMS to false - https://github.com/apache/camel-quarkus/pull/1383) > Differences between Oracle JDK and AdoptOpenJDK caused by JPMS > -- > > Key: SUREFIRE-1809 > URL: https://issues.apache.org/jira/browse/SUREFIRE-1809 > Project: Maven Surefire > Issue Type: Bug > Components: Maven Failsafe Plugin, Maven Surefire Plugin >Affects Versions: 3.0.0-M5 >Reporter: Jiri Ondrusek >Priority: Major > > I was upgrading maven-surefire-plugin to 3.0.0-M5 in > [camel-quarkus|[https://github.com/apache/camel-quarkus]] project. > Unfortunately there was a test which was failing on CI (using AdoptOpenJDK > build 11.0.7+10) and there was no failure on my local machine (using Oracle > "11.0.7" 2020-04-14 LTS). > Problem was caused by JPMS. On Orace JDK this was turned off by default. On > AdoptOpenJDK it was turned on by default. Solution was to turn this feature > off by configuration (https://github.com/apache/camel-quarkus/pull/1383). > It would be nice if default behavior was the same for different Java vendors. > Difference seems to be coming from this line - > https://github.com/apache/maven-surefire/blob/master/maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/AbstractSurefireMojo.java#L1423 > On AdoptOpenJDK both 3 clausules are true. On Oracle JDK the last one is > false. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (SUREFIRE-1809) Differences between Oracle JDK and AdoptOpenJDK caused by JPMS
Jiri Ondrusek created SUREFIRE-1809: --- Summary: Differences between Oracle JDK and AdoptOpenJDK caused by JPMS Key: SUREFIRE-1809 URL: https://issues.apache.org/jira/browse/SUREFIRE-1809 Project: Maven Surefire Issue Type: Bug Components: Maven Failsafe Plugin, Maven Surefire Plugin Affects Versions: 3.0.0-M5 Reporter: Jiri Ondrusek I was upgrading maven-surefire-plugin to 3.0.0-M5 in [camel-quarkus|[https://github.com/apache/camel-quarkus]] project. Unfortunately there was a test which was failing on CI (using AdoptOpenJDK build 11.0.7+10) and there was no failure on my local machine (using Oracle "11.0.7" 2020-04-14 LTS). Problem was caused by JPMS. On Orace JDK this was turned off by default. On AdoptOpenJDK it was turned on by default. Solution was to turn this feature off by configuration (https://github.com/apache/camel-quarkus/pull/1383). It would be nice if default behavior was the same for different Java vendors. Difference seems to be coming from this line - https://github.com/apache/maven-surefire/blob/master/maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/AbstractSurefireMojo.java#L1423 On AdoptOpenJDK both 3 clausules are true. On Oracle JDK the last one is false. -- This message was sent by Atlassian Jira (v8.3.4#803005)
