[jira] (MNG-3092) Version ranges with non-snapshot bounds can contain snapshot versions
[ https://jira.codehaus.org/browse/MNG-3092?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=323400#comment-323400 ] Kunalkumar Somani edited comment on MNG-3092 at 4/8/13 3:53 PM: @Andrei Pozolotin, I have already attached the patch in this thread. was (Author: kunalsomani): @Andrei Pozolotin, I already attached the patch in this thread. > Version ranges with non-snapshot bounds can contain snapshot versions > - > > Key: MNG-3092 > URL: https://jira.codehaus.org/browse/MNG-3092 > Project: Maven 2 & 3 > Issue Type: Bug > Components: Dependencies >Reporter: Mark Hobson >Assignee: Jason van Zyl > Fix For: 3.1.1 > > Attachments: MNG-3092.patch, MNG-3092.patch > > > Contrary to the 2.0 design docs: > "Resolution of dependency ranges should not resolve to a snapshot > (development version) unless it is included as an explicit boundary." > -- from > http://docs.codehaus.org/display/MAVEN/Dependency+Mediation+and+Conflict+Resolution#DependencyMediationandConflictResolution-Incorporating%7B%7BSNAPSHOT%7D%7Dversionsintothespecification > The following is equates to true: > VersionRange.createFromVersionSpec( "[1.0,1.1]" ).containsVersion( new > DefaultArtifactVersion( "1.1-SNAPSHOT" ) ) > The attached patch only allows snapshot versions to be contained in a range > if they are equal to one of the boundaries. Note that this is a strict > equality, so [1.0,1.2-SNAPSHOT] will not contain 1.1-SNAPSHOT. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] (MNG-3092) Version ranges with non-snapshot bounds can contain snapshot versions
[ https://jira.codehaus.org/browse/MNG-3092?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=323400#comment-323400 ] Kunalkumar Somani commented on MNG-3092: @Andrei Pozolotin, I already attached the patch in this thread. > Version ranges with non-snapshot bounds can contain snapshot versions > - > > Key: MNG-3092 > URL: https://jira.codehaus.org/browse/MNG-3092 > Project: Maven 2 & 3 > Issue Type: Bug > Components: Dependencies >Reporter: Mark Hobson >Assignee: Jason van Zyl > Fix For: 3.1.1 > > Attachments: MNG-3092.patch, MNG-3092.patch > > > Contrary to the 2.0 design docs: > "Resolution of dependency ranges should not resolve to a snapshot > (development version) unless it is included as an explicit boundary." > -- from > http://docs.codehaus.org/display/MAVEN/Dependency+Mediation+and+Conflict+Resolution#DependencyMediationandConflictResolution-Incorporating%7B%7BSNAPSHOT%7D%7Dversionsintothespecification > The following is equates to true: > VersionRange.createFromVersionSpec( "[1.0,1.1]" ).containsVersion( new > DefaultArtifactVersion( "1.1-SNAPSHOT" ) ) > The attached patch only allows snapshot versions to be contained in a range > if they are equal to one of the boundaries. Note that this is a strict > equality, so [1.0,1.2-SNAPSHOT] will not contain 1.1-SNAPSHOT. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] (MNG-3092) Version ranges with non-snapshot bounds can contain snapshot versions
[ https://jira.codehaus.org/browse/MNG-3092?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=322488#comment-322488 ] Kunalkumar Somani edited comment on MNG-3092 at 3/28/13 11:55 PM: -- @Sergei, everyone has different view to look at the problem. We have gone back and forth on this behavior a couple time. I totally agree with Tuomas where he has mentioned in last paragraph, it will be very tedious for SNAPSHOT range removal before releasing and resetting after releasing but anyways we are removing the SNAPSHOT while releasing any artifact. With your thoughts User can pass property in maven command -DuseSnapshotInRange=false and it will exclude all SNAPSHOT from range. The problem what I can see here is if we have range defined in parent POM then you need to ask reference POM to use this new parameter else it will pick latest SNAPSHOT if available in repository. was (Author: kunalsomani): @Sergei, everyone has different view to look at the problem. We have gone back and forth on this behavior a couple time. I totally agree with Tuomas where he has mentioned in last paragraph, it will be very tedious for SNAPSHOT range removal before releasing and resetting after releasing. Agree with your idea and can release patch where User can pass property in maven command -DuseSnapshotInRange=false and it will exclude all SNAPSHOT from range, the default behavior is true, in that case we will have backward compatibility as well. It will not impact the existing behavior. The problem what I can see here is if we have range defined in parent POM then you need to ask reference POM to use this new parameter else it will pick latest SNAPSHOT if available in repository. > Version ranges with non-snapshot bounds can contain snapshot versions > - > > Key: MNG-3092 > URL: https://jira.codehaus.org/browse/MNG-3092 > Project: Maven 2 & 3 > Issue Type: Bug > Components: Dependencies >Reporter: Mark Hobson >Assignee: Jason van Zyl > Fix For: 3.1.1 > > Attachments: MNG-3092.patch, MNG-3092.patch > > > Contrary to the 2.0 design docs: > "Resolution of dependency ranges should not resolve to a snapshot > (development version) unless it is included as an explicit boundary." > -- from > http://docs.codehaus.org/display/MAVEN/Dependency+Mediation+and+Conflict+Resolution#DependencyMediationandConflictResolution-Incorporating%7B%7BSNAPSHOT%7D%7Dversionsintothespecification > The following is equates to true: > VersionRange.createFromVersionSpec( "[1.0,1.1]" ).containsVersion( new > DefaultArtifactVersion( "1.1-SNAPSHOT" ) ) > The attached patch only allows snapshot versions to be contained in a range > if they are equal to one of the boundaries. Note that this is a strict > equality, so [1.0,1.2-SNAPSHOT] will not contain 1.1-SNAPSHOT. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] (MNG-3092) Version ranges with non-snapshot bounds can contain snapshot versions
[ https://jira.codehaus.org/browse/MNG-3092?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=322717#comment-322717 ] Kunalkumar Somani edited comment on MNG-3092 at 3/27/13 1:42 AM: - As per Mark Hobson we should disallow snapshots in ranges when they aren't in explicit boundary. http://www.mail-archive.com/dev@maven.apache.org/msg68512.html was (Author: kunalsomani): As per Mark Hobson we should disallow snapshots in ranges when they aren't in explicit boundary. http://www.mail-archive.com/dev@maven.apache.org/msg68512.html > Version ranges with non-snapshot bounds can contain snapshot versions > - > > Key: MNG-3092 > URL: https://jira.codehaus.org/browse/MNG-3092 > Project: Maven 2 & 3 > Issue Type: Bug > Components: Dependencies >Reporter: Mark Hobson >Assignee: Jason van Zyl > Fix For: 3.1.1 > > Attachments: MNG-3092.patch, MNG-3092.patch > > > Contrary to the 2.0 design docs: > "Resolution of dependency ranges should not resolve to a snapshot > (development version) unless it is included as an explicit boundary." > -- from > http://docs.codehaus.org/display/MAVEN/Dependency+Mediation+and+Conflict+Resolution#DependencyMediationandConflictResolution-Incorporating%7B%7BSNAPSHOT%7D%7Dversionsintothespecification > The following is equates to true: > VersionRange.createFromVersionSpec( "[1.0,1.1]" ).containsVersion( new > DefaultArtifactVersion( "1.1-SNAPSHOT" ) ) > The attached patch only allows snapshot versions to be contained in a range > if they are equal to one of the boundaries. Note that this is a strict > equality, so [1.0,1.2-SNAPSHOT] will not contain 1.1-SNAPSHOT. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] (MNG-3092) Version ranges with non-snapshot bounds can contain snapshot versions
[ https://jira.codehaus.org/browse/MNG-3092?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=322717#comment-322717 ] Kunalkumar Somani edited comment on MNG-3092 at 3/27/13 1:40 AM: - As per Mark Hobson we should disallow snapshots in ranges when they aren't in explicit boundary. http://www.mail-archive.com/dev@maven.apache.org/msg68512.html (Restricted to jira-users group) was (Author: kunalsomani): As per Mark Hobson we should disallow snapshots in ranges when they aren't in explicit boundary. The attached patch ignores SNAPSHOT if it's not defined in boundary. http://www.mail-archive.com/dev@maven.apache.org/msg68512.html (Restricted to jira-users group) > Version ranges with non-snapshot bounds can contain snapshot versions > - > > Key: MNG-3092 > URL: https://jira.codehaus.org/browse/MNG-3092 > Project: Maven 2 & 3 > Issue Type: Bug > Components: Dependencies >Reporter: Mark Hobson >Assignee: Jason van Zyl > Fix For: 3.1.1 > > Attachments: MNG-3092.patch, MNG-3092.patch > > > Contrary to the 2.0 design docs: > "Resolution of dependency ranges should not resolve to a snapshot > (development version) unless it is included as an explicit boundary." > -- from > http://docs.codehaus.org/display/MAVEN/Dependency+Mediation+and+Conflict+Resolution#DependencyMediationandConflictResolution-Incorporating%7B%7BSNAPSHOT%7D%7Dversionsintothespecification > The following is equates to true: > VersionRange.createFromVersionSpec( "[1.0,1.1]" ).containsVersion( new > DefaultArtifactVersion( "1.1-SNAPSHOT" ) ) > The attached patch only allows snapshot versions to be contained in a range > if they are equal to one of the boundaries. Note that this is a strict > equality, so [1.0,1.2-SNAPSHOT] will not contain 1.1-SNAPSHOT. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] (MNG-3092) Version ranges with non-snapshot bounds can contain snapshot versions
[ https://jira.codehaus.org/browse/MNG-3092?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=322717#comment-322717 ] Kunalkumar Somani edited comment on MNG-3092 at 3/27/13 1:41 AM: - As per Mark Hobson we should disallow snapshots in ranges when they aren't in explicit boundary. http://www.mail-archive.com/dev@maven.apache.org/msg68512.html was (Author: kunalsomani): As per Mark Hobson we should disallow snapshots in ranges when they aren't in explicit boundary. http://www.mail-archive.com/dev@maven.apache.org/msg68512.html (Restricted to jira-users group) > Version ranges with non-snapshot bounds can contain snapshot versions > - > > Key: MNG-3092 > URL: https://jira.codehaus.org/browse/MNG-3092 > Project: Maven 2 & 3 > Issue Type: Bug > Components: Dependencies >Reporter: Mark Hobson >Assignee: Jason van Zyl > Fix For: 3.1.1 > > Attachments: MNG-3092.patch, MNG-3092.patch > > > Contrary to the 2.0 design docs: > "Resolution of dependency ranges should not resolve to a snapshot > (development version) unless it is included as an explicit boundary." > -- from > http://docs.codehaus.org/display/MAVEN/Dependency+Mediation+and+Conflict+Resolution#DependencyMediationandConflictResolution-Incorporating%7B%7BSNAPSHOT%7D%7Dversionsintothespecification > The following is equates to true: > VersionRange.createFromVersionSpec( "[1.0,1.1]" ).containsVersion( new > DefaultArtifactVersion( "1.1-SNAPSHOT" ) ) > The attached patch only allows snapshot versions to be contained in a range > if they are equal to one of the boundaries. Note that this is a strict > equality, so [1.0,1.2-SNAPSHOT] will not contain 1.1-SNAPSHOT. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] (MNG-3092) Version ranges with non-snapshot bounds can contain snapshot versions
[ https://jira.codehaus.org/browse/MNG-3092?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=322717#comment-322717 ] Kunalkumar Somani edited comment on MNG-3092 at 3/27/13 1:39 AM: - As per Mark Hobson we should disallow snapshots in ranges when they aren't in explicit boundary. The attached patch ignores SNAPSHOT if it's not defined in boundary. http://www.mail-archive.com/dev@maven.apache.org/msg68512.html (Restricted to jira-users group) was (Author: kunalsomani): As per Mark Hobson we should disallow snapshots in ranges when they aren't in explicit boundary. The attached patch ignores SNAPSHOT if it's not defined in boundary. http://www.mail-archive.com/dev@maven.apache.org/msg68512.html > Version ranges with non-snapshot bounds can contain snapshot versions > - > > Key: MNG-3092 > URL: https://jira.codehaus.org/browse/MNG-3092 > Project: Maven 2 & 3 > Issue Type: Bug > Components: Dependencies >Reporter: Mark Hobson >Assignee: Jason van Zyl > Fix For: 3.1.1 > > Attachments: MNG-3092.patch, MNG-3092.patch > > > Contrary to the 2.0 design docs: > "Resolution of dependency ranges should not resolve to a snapshot > (development version) unless it is included as an explicit boundary." > -- from > http://docs.codehaus.org/display/MAVEN/Dependency+Mediation+and+Conflict+Resolution#DependencyMediationandConflictResolution-Incorporating%7B%7BSNAPSHOT%7D%7Dversionsintothespecification > The following is equates to true: > VersionRange.createFromVersionSpec( "[1.0,1.1]" ).containsVersion( new > DefaultArtifactVersion( "1.1-SNAPSHOT" ) ) > The attached patch only allows snapshot versions to be contained in a range > if they are equal to one of the boundaries. Note that this is a strict > equality, so [1.0,1.2-SNAPSHOT] will not contain 1.1-SNAPSHOT. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] (MNG-3092) Version ranges with non-snapshot bounds can contain snapshot versions
[ https://jira.codehaus.org/browse/MNG-3092?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=322717#comment-322717 ] Kunalkumar Somani edited comment on MNG-3092 at 3/27/13 1:35 AM: - As per Mark Hobson we should disallow snapshots in ranges when they aren't in explicit boundary. The attached patch ignores SNAPSHOT if it's not defined in boundary. http://www.mail-archive.com/dev@maven.apache.org/msg68512.html was (Author: kunalsomani): As per Mark Hobson we should disallow snapshots in ranges when they aren't an explicit boundary. This patch ignore SNAPSHOT if it's not defined in boundary. > Version ranges with non-snapshot bounds can contain snapshot versions > - > > Key: MNG-3092 > URL: https://jira.codehaus.org/browse/MNG-3092 > Project: Maven 2 & 3 > Issue Type: Bug > Components: Dependencies >Reporter: Mark Hobson >Assignee: Jason van Zyl > Fix For: 3.1.1 > > Attachments: MNG-3092.patch, MNG-3092.patch > > > Contrary to the 2.0 design docs: > "Resolution of dependency ranges should not resolve to a snapshot > (development version) unless it is included as an explicit boundary." > -- from > http://docs.codehaus.org/display/MAVEN/Dependency+Mediation+and+Conflict+Resolution#DependencyMediationandConflictResolution-Incorporating%7B%7BSNAPSHOT%7D%7Dversionsintothespecification > The following is equates to true: > VersionRange.createFromVersionSpec( "[1.0,1.1]" ).containsVersion( new > DefaultArtifactVersion( "1.1-SNAPSHOT" ) ) > The attached patch only allows snapshot versions to be contained in a range > if they are equal to one of the boundaries. Note that this is a strict > equality, so [1.0,1.2-SNAPSHOT] will not contain 1.1-SNAPSHOT. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] (MNG-3092) Version ranges with non-snapshot bounds can contain snapshot versions
[ https://jira.codehaus.org/browse/MNG-3092?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kunalkumar Somani updated MNG-3092: --- Attachment: MNG-3092.patch As per Mark Hobson we should disallow snapshots in ranges when they aren't an explicit boundary. This patch ignore SNAPSHOT if it's not defined in boundary. > Version ranges with non-snapshot bounds can contain snapshot versions > - > > Key: MNG-3092 > URL: https://jira.codehaus.org/browse/MNG-3092 > Project: Maven 2 & 3 > Issue Type: Bug > Components: Dependencies >Reporter: Mark Hobson >Assignee: Jason van Zyl > Fix For: 3.1.1 > > Attachments: MNG-3092.patch, MNG-3092.patch > > > Contrary to the 2.0 design docs: > "Resolution of dependency ranges should not resolve to a snapshot > (development version) unless it is included as an explicit boundary." > -- from > http://docs.codehaus.org/display/MAVEN/Dependency+Mediation+and+Conflict+Resolution#DependencyMediationandConflictResolution-Incorporating%7B%7BSNAPSHOT%7D%7Dversionsintothespecification > The following is equates to true: > VersionRange.createFromVersionSpec( "[1.0,1.1]" ).containsVersion( new > DefaultArtifactVersion( "1.1-SNAPSHOT" ) ) > The attached patch only allows snapshot versions to be contained in a range > if they are equal to one of the boundaries. Note that this is a strict > equality, so [1.0,1.2-SNAPSHOT] will not contain 1.1-SNAPSHOT. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] (MNG-3092) Version ranges with non-snapshot bounds can contain snapshot versions
[ https://jira.codehaus.org/browse/MNG-3092?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=322488#comment-322488 ] Kunalkumar Somani edited comment on MNG-3092 at 3/23/13 1:58 PM: - @Sergei, everyone has different view to look at the problem. We have gone back and forth on this behavior a couple time. I totally agree with Tuomas where he has mentioned in last paragraph, it will be very tedious for SNAPSHOT range removal before releasing and resetting after releasing. Agree with your idea and can release patch where User can pass property in maven command -DuseSnapshotInRange=false and it will exclude all SNAPSHOT from range, the default behavior is true, in that case we will have backward compatibility as well. It will not impact the existing behavior. The problem what I can see here is if we have range defined in parent POM then you need to ask reference POM to use this new parameter else it will pick latest SNAPSHOT if available in repository. was (Author: kunalsomani): @Sergei, everyone has different view to look at the problem. We have gone back and forth on this behavior a couple time. I totally agree with Tuomas where he has mentioned in last paragraph, it will be very tedious for SNAPSHOT range removal before releasing and resetting after releasing. Agree with your idea and can release patch where User can pass property in maven command -DuseSnapshotInRange=false and it will exclude all SNAPSHOT from range, the default behavior is true, in that case we will have backward compatibility as well. It will not impact the existing behavior.The problem what I can see here is if we have range defined in parent POM then you need to ask reference POM to use this new parameter else it will pick latest SNAPSHOT if available in repository. > Version ranges with non-snapshot bounds can contain snapshot versions > - > > Key: MNG-3092 > URL: https://jira.codehaus.org/browse/MNG-3092 > Project: Maven 2 & 3 > Issue Type: Bug > Components: Dependencies >Reporter: Mark Hobson >Assignee: Jason van Zyl > Fix For: 3.1.1 > > Attachments: MNG-3092.patch > > > Contrary to the 2.0 design docs: > "Resolution of dependency ranges should not resolve to a snapshot > (development version) unless it is included as an explicit boundary." > -- from > http://docs.codehaus.org/display/MAVEN/Dependency+Mediation+and+Conflict+Resolution#DependencyMediationandConflictResolution-Incorporating%7B%7BSNAPSHOT%7D%7Dversionsintothespecification > The following is equates to true: > VersionRange.createFromVersionSpec( "[1.0,1.1]" ).containsVersion( new > DefaultArtifactVersion( "1.1-SNAPSHOT" ) ) > The attached patch only allows snapshot versions to be contained in a range > if they are equal to one of the boundaries. Note that this is a strict > equality, so [1.0,1.2-SNAPSHOT] will not contain 1.1-SNAPSHOT. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] (MNG-3092) Version ranges with non-snapshot bounds can contain snapshot versions
[ https://jira.codehaus.org/browse/MNG-3092?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=322488#comment-322488 ] Kunalkumar Somani edited comment on MNG-3092 at 3/23/13 1:38 PM: - @Sergei, everyone has different view to look at the problem. We have gone back and forth on this behavior a couple time. I totally agree with Tuomas where he has mentioned in last paragraph, it will be very tedious for SNAPSHOT range removal before releasing and resetting after releasing. Agree with your idea and can release patch where User can pass property in maven command -DuseSnapshotInRange=false and it will exclude all SNAPSHOT from range, the default behavior is true, in that case we will have backward compatibility as well. It will not impact the existing behavior.The problem what I can see here is if we have range defined in parent POM then you need to ask reference POM to use this new parameter else it will pick latest SNAPSHOT if available in repository. was (Author: kunalsomani): @Sergei, everyone has different view to look at the problem. We have gone back and forth on this behavior a couple time. I totally agree with Tuomas where he has mentioned in last paragraph, it will be very tedious for SNAPSHOT range removal before releasing and resetting after releasing. Agree with your idea and can release patch where User can pass property in maven command -DuseSnapshotInRange=false and it will exclude all SNAPSHOT from range, the default behavior is true, in that case we will have backward compatibility as well. It will not impact the existing behavior.The problem what I can see here is if we have range defined in parent POM then you need to ask reference POM to use this new parameter else it will pick latest SNAPSHOT if available in repository. If you all are agree on it please vote for it and will fix this bug. > Version ranges with non-snapshot bounds can contain snapshot versions > - > > Key: MNG-3092 > URL: https://jira.codehaus.org/browse/MNG-3092 > Project: Maven 2 & 3 > Issue Type: Bug > Components: Dependencies >Reporter: Mark Hobson >Assignee: Jason van Zyl > Fix For: 3.1.1 > > Attachments: MNG-3092.patch > > > Contrary to the 2.0 design docs: > "Resolution of dependency ranges should not resolve to a snapshot > (development version) unless it is included as an explicit boundary." > -- from > http://docs.codehaus.org/display/MAVEN/Dependency+Mediation+and+Conflict+Resolution#DependencyMediationandConflictResolution-Incorporating%7B%7BSNAPSHOT%7D%7Dversionsintothespecification > The following is equates to true: > VersionRange.createFromVersionSpec( "[1.0,1.1]" ).containsVersion( new > DefaultArtifactVersion( "1.1-SNAPSHOT" ) ) > The attached patch only allows snapshot versions to be contained in a range > if they are equal to one of the boundaries. Note that this is a strict > equality, so [1.0,1.2-SNAPSHOT] will not contain 1.1-SNAPSHOT. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] (MNG-3092) Version ranges with non-snapshot bounds can contain snapshot versions
[ https://jira.codehaus.org/browse/MNG-3092?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=322488#comment-322488 ] Kunalkumar Somani commented on MNG-3092: @Sergei, everyone has different view to look at the problem. We have gone back and forth on this behavior a couple time. I totally agree with Tuomas where he has mentioned in last paragraph, it will be very tedious for SNAPSHOT range removal before releasing and resetting after releasing. Agree with your idea and can release patch where User can pass property in maven command -DuseSnapshotInRange=false and it will exclude all SNAPSHOT from range, the default behavior is true, in that case we will have backward compatibility as well. It will not impact the existing behavior.The problem what I can see here is if we have range defined in parent POM then you need to ask reference POM to use this new parameter else it will pick latest SNAPSHOT if available in repository. If you all are agree on it please vote for it and will fix this bug. > Version ranges with non-snapshot bounds can contain snapshot versions > - > > Key: MNG-3092 > URL: https://jira.codehaus.org/browse/MNG-3092 > Project: Maven 2 & 3 > Issue Type: Bug > Components: Dependencies >Reporter: Mark Hobson >Assignee: Jason van Zyl > Fix For: 3.1.1 > > Attachments: MNG-3092.patch > > > Contrary to the 2.0 design docs: > "Resolution of dependency ranges should not resolve to a snapshot > (development version) unless it is included as an explicit boundary." > -- from > http://docs.codehaus.org/display/MAVEN/Dependency+Mediation+and+Conflict+Resolution#DependencyMediationandConflictResolution-Incorporating%7B%7BSNAPSHOT%7D%7Dversionsintothespecification > The following is equates to true: > VersionRange.createFromVersionSpec( "[1.0,1.1]" ).containsVersion( new > DefaultArtifactVersion( "1.1-SNAPSHOT" ) ) > The attached patch only allows snapshot versions to be contained in a range > if they are equal to one of the boundaries. Note that this is a strict > equality, so [1.0,1.2-SNAPSHOT] will not contain 1.1-SNAPSHOT. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] (MNG-3092) Version ranges with non-snapshot bounds can contain snapshot versions
[ https://jira.codehaus.org/browse/MNG-3092?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=322366#comment-322366 ] Kunalkumar Somani edited comment on MNG-3092 at 3/22/13 12:39 AM: -- We need to resolve this problem, as this is going on since many years. I have made code change in Maven with this assumption that if User keep SNAPSHOT at any place(lower or upper) in range it means user is expecting SNAPSHOT for dependency, if User does not put SNAPSHOT it means User is expecting only release. Example: Available jar version : 13.0.0-SNAPSHOT, 13.0.0, 13.0.1-SNAPSHOT, 13.0.1, 13.0.2-SNAPSHOT, 13.1.0-SNAPSHOT (Don't have 13.0.2) [13.0.0-SNAPSHOT,13.1.0-SNAPSHOT) Selected : 13.0.2-SNAPSHOT [13.0.0,13.1.0) Selected : 13.0.1 [13.0.0-SNAPSHOT,13.1.0) Selected : 13.1.0-SNAPSHOT [13.0.0,13.1.0-SNAPSHOT) Selected : 13.0.2-SNAPSHOT [13.0.0,13.0.1) Selected : 13.0.0 [13.0.0,13.0.1] Selected : 13.0.1 [13.0.0-SNAPSHOT,13.0.2-SNAPSHOT) Selected : 13.0.1 was (Author: kunalsomani): We need to resolve this problem, as this is going on since many years. I have made code change in Maven with this assumption that if user keep SNAPSHOT at any place(lower or upper) in range it means user is expecting SNAPSHOT for dependency, if User don?t put SNAPSHOT it means User is expecting only release. Example: Available jar version : 13.0.0-SNAPSHOT, 13.0.0, 13.0.1-SNAPSHOT, 13.0.1, 13.0.2-SNAPSHOT, 13.1.0-SNAPSHOT (Don't have 13.0.2) [13.0.0-SNAPSHOT,13.1.0-SNAPSHOT) Selected : 13.0.2-SNAPSHOT [13.0.0,13.1.0) Selected : 13.0.1 [13.0.0-SNAPSHOT,13.1.0) Selected : 13.1.0-SNAPSHOT [13.0.0,13.1.0-SNAPSHOT) Selected : 13.0.2-SNAPSHOT [13.0.0,13.0.1) Selected : 13.0.0 [13.0.0,13.0.1] Selected : 13.0.1 [13.0.0-SNAPSHOT,13.0.2-SNAPSHOT) Selected : 13.0.1 > Version ranges with non-snapshot bounds can contain snapshot versions > - > > Key: MNG-3092 > URL: https://jira.codehaus.org/browse/MNG-3092 > Project: Maven 2 & 3 > Issue Type: Bug > Components: Dependencies >Reporter: Mark Hobson >Assignee: Jason van Zyl > Fix For: 3.1.1 > > Attachments: MNG-3092.patch > > > Contrary to the 2.0 design docs: > "Resolution of dependency ranges should not resolve to a snapshot > (development version) unless it is included as an explicit boundary." > -- from > http://docs.codehaus.org/display/MAVEN/Dependency+Mediation+and+Conflict+Resolution#DependencyMediationandConflictResolution-Incorporating%7B%7BSNAPSHOT%7D%7Dversionsintothespecification > The following is equates to true: > VersionRange.createFromVersionSpec( "[1.0,1.1]" ).containsVersion( new > DefaultArtifactVersion( "1.1-SNAPSHOT" ) ) > The attached patch only allows snapshot versions to be contained in a range > if they are equal to one of the boundaries. Note that this is a strict > equality, so [1.0,1.2-SNAPSHOT] will not contain 1.1-SNAPSHOT. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] (MNG-3092) Version ranges with non-snapshot bounds can contain snapshot versions
[ https://jira.codehaus.org/browse/MNG-3092?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=322366#comment-322366 ] Kunalkumar Somani edited comment on MNG-3092 at 3/21/13 7:37 PM: - We need to resolve this problem, as this is going on since many years. I have made code change in Maven with this assumption that if user keep SNAPSHOT at any place(lower or upper) in range it means user is expecting SNAPSHOT for dependency, if User don?t put SNAPSHOT it means User is expecting only release. Example: Available jar version : 13.0.0-SNAPSHOT, 13.0.0, 13.0.1-SNAPSHOT, 13.0.1, 13.0.2-SNAPSHOT, 13.1.0-SNAPSHOT (Don't have 13.0.2) [13.0.0-SNAPSHOT,13.1.0-SNAPSHOT) Selected : 13.0.2-SNAPSHOT [13.0.0,13.1.0) Selected : 13.0.1 [13.0.0-SNAPSHOT,13.1.0) Selected : 13.1.0-SNAPSHOT [13.0.0,13.1.0-SNAPSHOT) Selected : 13.0.2-SNAPSHOT [13.0.0,13.0.1) Selected : 13.0.0 [13.0.0,13.0.1] Selected : 13.0.1 [13.0.0-SNAPSHOT,13.0.2-SNAPSHOT) Selected : 13.0.1 was (Author: kunalsomani): We need to resolve this problem, as this is going on since many years. With the assumption that if user keep SNAPSHOT at any place(lower or upper) in range it means user is expecting SNAPSHOT for dependency, if User don?t put SNAPSHOT it means User is expecting only release. I have made code change in Maven with this assumption. Example: Available jar version : 13.0.0-SNAPSHOT, 13.0.0, 13.0.1-SNAPSHOT, 13.0.1, 13.0.2-SNAPSHOT, 13.1.0-SNAPSHOT (Don't have 13.0.2) [13.0.0-SNAPSHOT,13.1.0-SNAPSHOT) Selected : 13.0.2-SNAPSHOT [13.0.0,13.1.0) Selected : 13.0.1 [13.0.0-SNAPSHOT,13.1.0) Selected : 13.1.0-SNAPSHOT [13.0.0,13.1.0-SNAPSHOT) Selected : 13.0.2-SNAPSHOT [13.0.0,13.0.1) Selected : 13.0.0 [13.0.0,13.0.1] Selected : 13.0.1 [13.0.0-SNAPSHOT,13.0.2-SNAPSHOT) Selected : 13.0.1 > Version ranges with non-snapshot bounds can contain snapshot versions > - > > Key: MNG-3092 > URL: https://jira.codehaus.org/browse/MNG-3092 > Project: Maven 2 & 3 > Issue Type: Bug > Components: Dependencies >Reporter: Mark Hobson >Assignee: Jason van Zyl > Fix For: 3.1.1 > > Attachments: MNG-3092.patch > > > Contrary to the 2.0 design docs: > "Resolution of dependency ranges should not resolve to a snapshot > (development version) unless it is included as an explicit boundary." > -- from > http://docs.codehaus.org/display/MAVEN/Dependency+Mediation+and+Conflict+Resolution#DependencyMediationandConflictResolution-Incorporating%7B%7BSNAPSHOT%7D%7Dversionsintothespecification > The following is equates to true: > VersionRange.createFromVersionSpec( "[1.0,1.1]" ).containsVersion( new > DefaultArtifactVersion( "1.1-SNAPSHOT" ) ) > The attached patch only allows snapshot versions to be contained in a range > if they are equal to one of the boundaries. Note that this is a strict > equality, so [1.0,1.2-SNAPSHOT] will not contain 1.1-SNAPSHOT. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] (MNG-3092) Version ranges with non-snapshot bounds can contain snapshot versions
[ https://jira.codehaus.org/browse/MNG-3092?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=322366#comment-322366 ] Kunalkumar Somani edited comment on MNG-3092 at 3/21/13 6:46 PM: - We need to resolve this problem, as this is going on since many years. With the assumption that if user keep SNAPSHOT at any place(lower or upper) in range it means user is expecting SNAPSHOT for dependency, if User don?t put SNAPSHOT it means User is expecting only release. I have made code change in Maven with this assumption. Example: Available jar version : 13.0.0-SNAPSHOT, 13.0.0, 13.0.1-SNAPSHOT, 13.0.1, 13.0.2-SNAPSHOT, 13.1.0-SNAPSHOT (Don't have 13.0.2) [13.0.0-SNAPSHOT,13.1.0-SNAPSHOT) Selected : 13.0.2-SNAPSHOT [13.0.0,13.1.0) Selected : 13.0.1 [13.0.0-SNAPSHOT,13.1.0) Selected : 13.1.0-SNAPSHOT [13.0.0,13.1.0-SNAPSHOT) Selected : 13.0.2-SNAPSHOT [13.0.0,13.0.1) Selected : 13.0.0 [13.0.0,13.0.1] Selected : 13.0.1 [13.0.0-SNAPSHOT,13.0.2-SNAPSHOT) Selected : 13.0.1 was (Author: kunalsomani): We need to resolve this problem, as this is going on since many years. With the assumption that if user keep SNAPSHOT at any place(lower or upper) in range it means user is expecting SNAPSHOT for dependency, if User don?t put SNAPSHOT it means User is expecting only release. I have made code change in Maven with this assumption. I would like to contribute here to fix this bug, if you have any concern please do let me know. Example: Available jar version : 13.0.0-SNAPSHOT, 13.0.0, 13.0.1-SNAPSHOT, 13.0.1, 13.0.2-SNAPSHOT, 13.1.0-SNAPSHOT (Don't have 13.0.2) [13.0.0-SNAPSHOT,13.1.0-SNAPSHOT) Selected : 13.0.2-SNAPSHOT [13.0.0,13.1.0) Selected : 13.0.1 [13.0.0-SNAPSHOT,13.1.0) Selected : 13.1.0-SNAPSHOT [13.0.0,13.1.0-SNAPSHOT) Selected : 13.0.2-SNAPSHOT [13.0.0,13.0.1) Selected : 13.0.0 [13.0.0,13.0.1] Selected : 13.0.1 [13.0.0-SNAPSHOT,13.0.2-SNAPSHOT) Selected : 13.0.1 > Version ranges with non-snapshot bounds can contain snapshot versions > - > > Key: MNG-3092 > URL: https://jira.codehaus.org/browse/MNG-3092 > Project: Maven 2 & 3 > Issue Type: Bug > Components: Dependencies >Reporter: Mark Hobson >Assignee: Jason van Zyl > Fix For: 3.1.1 > > Attachments: MNG-3092.patch > > > Contrary to the 2.0 design docs: > "Resolution of dependency ranges should not resolve to a snapshot > (development version) unless it is included as an explicit boundary." > -- from > http://docs.codehaus.org/display/MAVEN/Dependency+Mediation+and+Conflict+Resolution#DependencyMediationandConflictResolution-Incorporating%7B%7BSNAPSHOT%7D%7Dversionsintothespecification > The following is equates to true: > VersionRange.createFromVersionSpec( "[1.0,1.1]" ).containsVersion( new > DefaultArtifactVersion( "1.1-SNAPSHOT" ) ) > The attached patch only allows snapshot versions to be contained in a range > if they are equal to one of the boundaries. Note that this is a strict > equality, so [1.0,1.2-SNAPSHOT] will not contain 1.1-SNAPSHOT. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] (MNG-3092) Version ranges with non-snapshot bounds can contain snapshot versions
[ https://jira.codehaus.org/browse/MNG-3092?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=322366#comment-322366 ] Kunalkumar Somani commented on MNG-3092: We need to resolve this problem, as this is going on since many years. With the assumption that if user keep SNAPSHOT at any place(lower or upper) in range it means user is expecting SNAPSHOT for dependency, if User don?t put SNAPSHOT it means User is expecting only release. I have made code change in Maven with this assumption. I would like to contribute here to fix this bug, if you have any concern please do let me know. Example: Available jar version : 13.0.0-SNAPSHOT, 13.0.0, 13.0.1-SNAPSHOT, 13.0.1, 13.0.2-SNAPSHOT, 13.1.0-SNAPSHOT (Don't have 13.0.2) [13.0.0-SNAPSHOT,13.1.0-SNAPSHOT) Selected : 13.0.2-SNAPSHOT [13.0.0,13.1.0) Selected : 13.0.1 [13.0.0-SNAPSHOT,13.1.0) Selected : 13.1.0-SNAPSHOT [13.0.0,13.1.0-SNAPSHOT) Selected : 13.0.2-SNAPSHOT [13.0.0,13.0.1) Selected : 13.0.0 [13.0.0,13.0.1] Selected : 13.0.1 [13.0.0-SNAPSHOT,13.0.2-SNAPSHOT) Selected : 13.0.1 > Version ranges with non-snapshot bounds can contain snapshot versions > - > > Key: MNG-3092 > URL: https://jira.codehaus.org/browse/MNG-3092 > Project: Maven 2 & 3 > Issue Type: Bug > Components: Dependencies >Reporter: Mark Hobson >Assignee: Jason van Zyl > Fix For: 3.1.1 > > Attachments: MNG-3092.patch > > > Contrary to the 2.0 design docs: > "Resolution of dependency ranges should not resolve to a snapshot > (development version) unless it is included as an explicit boundary." > -- from > http://docs.codehaus.org/display/MAVEN/Dependency+Mediation+and+Conflict+Resolution#DependencyMediationandConflictResolution-Incorporating%7B%7BSNAPSHOT%7D%7Dversionsintothespecification > The following is equates to true: > VersionRange.createFromVersionSpec( "[1.0,1.1]" ).containsVersion( new > DefaultArtifactVersion( "1.1-SNAPSHOT" ) ) > The attached patch only allows snapshot versions to be contained in a range > if they are equal to one of the boundaries. Note that this is a strict > equality, so [1.0,1.2-SNAPSHOT] will not contain 1.1-SNAPSHOT. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
