[jira] (MSITE-669) site:stage creates incorrect structure when module paths contains sets of ../
[
https://jira.codehaus.org/browse/MSITE-669?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=327706#comment-327706
]
Lennart Jorelid commented on MSITE-669:
---
With the release of m-s-p 3.1, this issue can be regarded as partially closed.
m-s-p 3.1 provides the means to handle this problem, but not the information
about *how* this should be done (i.e. what steps should be done to acquire a
working multisite staged site).
This is particularly nasty since the steps to a fully functional staged
multisite (using both site:stage and site:stage-deploy) are far from trivial or
self-evident, IMHO. There were many partial pitfalls encountered on the way to
a smoothly functioning site.
I will supply a documentation patch, which is fairly detailed and -
unfortunately - rather big.
site:stage creates incorrect structure when module paths contains sets of
../
---
Key: MSITE-669
URL: https://jira.codehaus.org/browse/MSITE-669
Project: Maven 2.x and 3.x Site Plugin
Issue Type: Bug
Components: multi module, relative links, site:stage(-deploy)
Affects Versions: 3.1, 3.2
Reporter: Lennart Jorelid
Assignee: Lukas Theussl
Attachments: msite_669.patch, msite_669_v2.patch, msite_669_v3.patch,
msite_669_v4.patch, nazgul_tools_project_dependencies.png,
nazgul_tools_reactor_structure.png, sample.zip
Given the module definitions given below, the site:stage goal produces sets
of maps relative to the staging directory - i.e. outside of the target
directory.
{code:xml}
modules
module../../validation/validation-api/module
module../../validation/validation-aspect/module
module../parent/module
/modules
{code}
The staged site should be fully included within the staging directory. It
would appear that relativization of links for site:stage should take special
links into consideration.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] (MNG-5488) Add support for comment metadata for POM Elements
Lennart Jorelid created MNG-5488:
Summary: Add support for comment metadata for POM Elements
Key: MNG-5488
URL: https://jira.codehaus.org/browse/MNG-5488
Project: Maven 2 3
Issue Type: Improvement
Affects Versions: 3.0.5
Reporter: Lennart Jorelid
h1. Lack of model metadata is a problem!
The Maven model APIs today do not handle XML comments (at all, and in a uniform
manner).
Comments and explanations to human beings are (or should be) an integral
and important part of any larger POMs - just like the ability to comment
source code is important to usability and improved understanding.
Comments/metadata can ensure that people understand *why* a particular
plugin/configuration/property was provided, what role it has in the
reactor and how it should be changed/managed in child projects.
The fact that POM element metadata such as XML comments is not a first-class
citizen of the Maven model must be considered a deficiency, since larger POMs
[typically root poms] can be daunting or confusing to read and understand.
So if POMs are processed (reordered, laundered, synthesized, whatever) using
Maven's APIs, comments are either removed or impossible to add.
h2. Alteration suggestions
I suggest some alterations to the Maven model:
# Add state holding an optional comment to all elements in the Maven model
# If non-null, the comments should be inserted in a uniform and pretty-printed
way, i.e:
## Standard intendation
## Standard handling of XML comment delimiters
## Pom tools should not [by default]Â reformat/mess up comments carefully
crafted by developers - be clear about this in documentation to tool devs
h2. Examples
We are developers, and should really not need examples on why commenting
source code or configuration is important. However, the two smallish samples
below should be sufficient to convey the gist of my idea here.
{code:xml}
!--
Provides Plantuml integration into site deployments.
Why: Convert Plantuml (*.puml) documents to png images, for use in site
documentation.
Used: Site lifecycle, mvn site.
--
plugin
groupIdcom.github.jeluard/groupId
artifactIdplantuml-maven-plugin/artifactId
version7954/version
{code}
... or, perhaps a better example ...
{code:xml}
properties
...
!--
Override this property only in the root reactor POM of each sub-reactor
project, to ensure that the site staging, site deployment, issue
management and CI integration works properly.
--
reactor.namenazgul_core/reactor.name
{code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] (MNG-5488) Add support for comment metadata for POM Elements
[
https://jira.codehaus.org/browse/MNG-5488?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=327349#comment-327349
]
Lennart Jorelid commented on MNG-5488:
--
I would suggest that we simply add an optional comment field to all maven
model entities.
(Wouldn't it be great if this could be done in a shared superclass as well? ;) )
That comment would then need some extra smarts in the xml reader and writer
standard implementation.
Add support for comment metadata for POM Elements
-
Key: MNG-5488
URL: https://jira.codehaus.org/browse/MNG-5488
Project: Maven 2 3
Issue Type: Improvement
Affects Versions: 3.0.5
Reporter: Lennart Jorelid
h1. Lack of model metadata is a problem!
The Maven model APIs today do not handle XML comments (at all, and in a
uniform manner).
Comments and explanations to human beings are (or should be) an integral
and important part of any larger POMs - just like the ability to comment
source code is important to usability and improved understanding.
Comments/metadata can ensure that people understand *why* a particular
plugin/configuration/property was provided, what role it has in the
reactor and how it should be changed/managed in child projects.
The fact that POM element metadata such as XML comments is not a first-class
citizen of the Maven model must be considered a deficiency, since larger POMs
[typically root poms] can be daunting or confusing to read and understand.
So if POMs are processed (reordered, laundered, synthesized, whatever) using
Maven's APIs, comments are either removed or impossible to add.
h2. Alteration suggestions
I suggest some alterations to the Maven model:
# Add state holding an optional comment to all elements in the Maven model
# If non-null, the comments should be inserted in a uniform and
pretty-printed way, i.e:
## Standard intendation
## Standard handling of XML comment delimiters
## Pom tools should not [by default]Â reformat/mess up comments carefully
crafted by developers - be clear about this in documentation to tool devs
h2. Examples
We are developers, and should really not need examples on why commenting
source code or configuration is important. However, the two smallish samples
below should be sufficient to convey the gist of my idea here.
{code:xml}
!--
Provides Plantuml integration into site deployments.
Why: Convert Plantuml (*.puml) documents to png images, for use in site
documentation.
Used: Site lifecycle, mvn site.
--
plugin
groupIdcom.github.jeluard/groupId
artifactIdplantuml-maven-plugin/artifactId
version7954/version
{code}
... or, perhaps a better example ...
{code:xml}
properties
...
!--
Override this property only in the root reactor POM of each sub-reactor
project, to ensure that the site staging, site deployment, issue
management and CI integration works properly.
--
reactor.namenazgul_core/reactor.name
{code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] (MSITE-669) site:stage creates incorrect structure when module paths contains sets of ../
[
https://jira.codehaus.org/browse/MSITE-669?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=325571#comment-325571
]
Lennart Jorelid commented on MSITE-669:
---
OK; I have tested the newly released m-s-p with the new features regarding the
topSiteURL property.
Some thoughts on the matter:
# Staging and stage-deploying a site now mainly works as expected for
nonstandard reactors. Some navigational problems might be addressed in future
releases. (Breadcrumbs, sitemap)
# The documentation in the m-s-p in regards to how the topSiteURL property
should be used - and how it should relate to the
distributionManagement/site/url could be clearer by an example (and also within
the documentation of the topSiteURL property itself). I will submit a patch
with this.
... but this is a great release; m-s-p is now useable for our reactors.
site:stage creates incorrect structure when module paths contains sets of
../
---
Key: MSITE-669
URL: https://jira.codehaus.org/browse/MSITE-669
Project: Maven 2.x and 3.x Site Plugin
Issue Type: Bug
Components: multi module, relative links, site:stage(-deploy)
Affects Versions: 3.1, 3.2
Reporter: Lennart Jorelid
Assignee: Lukas Theussl
Attachments: msite_669.patch, msite_669_v2.patch, msite_669_v3.patch,
msite_669_v4.patch, nazgul_tools_project_dependencies.png,
nazgul_tools_reactor_structure.png, sample.zip
Given the module definitions given below, the site:stage goal produces sets
of maps relative to the staging directory - i.e. outside of the target
directory.
{code:xml}
modules
module../../validation/validation-api/module
module../../validation/validation-aspect/module
module../parent/module
/modules
{code}
The staged site should be fully included within the staging directory. It
would appear that relativization of links for site:stage should take special
links into consideration.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] (MSITE-669) site:stage creates incorrect structure when module paths contains sets of ../
[
https://jira.codehaus.org/browse/MSITE-669?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=324690#comment-324690
]
Lennart Jorelid commented on MSITE-669:
---
Fair to use Skype instead of IRC, Hervé?
Feel free to ping me on Skype.
site:stage creates incorrect structure when module paths contains sets of
../
---
Key: MSITE-669
URL: https://jira.codehaus.org/browse/MSITE-669
Project: Maven 2.x and 3.x Site Plugin
Issue Type: Bug
Components: multi module, relative links, site:stage(-deploy)
Affects Versions: 3.1, 3.2
Reporter: Lennart Jorelid
Assignee: Lukas Theussl
Fix For: 3.3
Attachments: msite_669.patch, msite_669_v2.patch, msite_669_v3.patch,
msite_669_v4.patch, nazgul_tools_project_dependencies.png,
nazgul_tools_reactor_structure.png, sample.zip
Given the module definitions given below, the site:stage goal produces sets
of maps relative to the staging directory - i.e. outside of the target
directory.
{code:xml}
modules
module../../validation/validation-api/module
module../../validation/validation-aspect/module
module../parent/module
/modules
{code}
The staged site should be fully included within the staging directory. It
would appear that relativization of links for site:stage should take special
links into consideration.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] (MSITE-669) site:stage creates incorrect structure when module paths contains sets of ../
[
https://jira.codehaus.org/browse/MSITE-669?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=324384#comment-324384
]
Lennart Jorelid commented on MSITE-669:
---
Hello again, Herve and Lukas.
Just a friendly reminder that this bug/patch/misconception is a real pain for
at least 3 projects within which I am working.
Neither of these projects can use released versions of the m-s-p to generate
staged documentation.
Basically, this bug boils down to Maven's assumption that POMs always plays two
roles (reactor and parent), whereas there are
many good reasons to let some POMs be only reactor POMs (defining the reactor
build order) and other POMs only parent
POMs (defining mainly plugins, configuration and versions). This is
particularly apparent when your build reactor contains
stereotype projects (such as projects defining entities), having a set of
common needs/properties/build definitions but being
scattered in several places over the build reactor. This concept clashes with
the way that the m-s-p defines its staging and
site generation.
Have you had any chance to do a review of the patch I supplied in february?
Is anyone else involved in reviewing this [concept and patch], in case you
don't have the cycles yourself?
As far as I have been able to tell, no feedback other than the comments on the
MSITE-669 issue have been given. Am I missing something here?
site:stage creates incorrect structure when module paths contains sets of
../
---
Key: MSITE-669
URL: https://jira.codehaus.org/browse/MSITE-669
Project: Maven 2.x and 3.x Site Plugin
Issue Type: Bug
Components: multi module, relative links, site:stage(-deploy)
Affects Versions: 3.1, 3.2
Reporter: Lennart Jorelid
Assignee: Lukas Theussl
Attachments: msite_669.patch, msite_669_v2.patch, msite_669_v3.patch,
msite_669_v4.patch, nazgul_tools_project_dependencies.png,
nazgul_tools_project_dependencies.png, nazgul_tools_reactor_structure.png,
sample.zip
Given the module definitions given below, the site:stage goal produces sets
of maps relative to the staging directory - i.e. outside of the target
directory.
{code:xml}
modules
module../../validation/validation-api/module
module../../validation/validation-aspect/module
module../parent/module
/modules
{code}
The staged site should be fully included within the staging directory. It
would appear that relativization of links for site:stage should take special
links into consideration.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] (MSITE-669) site:stage creates incorrect structure when module paths contains sets of ../
[
https://jira.codehaus.org/browse/MSITE-669?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=324384#comment-324384
]
Lennart Jorelid edited comment on MSITE-669 at 4/29/13 4:37 AM:
Hello again, Herve and Lukas.
Just a friendly reminder that this bug/misconception is a real pain for at
least 3 projects within which I am working.
Neither of these projects can use released versions of the m-s-p to generate
staged documentation.
Basically, this issue boils down to Maven's assumption that POMs always plays
two roles (reactor and parent), whereas there are
many good reasons to let some POMs be only reactor POMs (defining the reactor
build order) and other POMs only parent
POMs (defining mainly plugins, configuration and versions). This is
particularly apparent when your build reactor contains
stereotype projects (such as projects defining entities), having a set of
common needs/properties/build definitions but being
scattered in several places over the build reactor. This concept clashes with
the way that the m-s-p defines its staging and
site generation.
Have you had any chance to do a review of the patch I supplied in february?
Is anyone else involved in reviewing this [concept and patch], in case you
don't have the cycles yourself?
As far as I have been able to tell, no feedback other than the comments on the
MSITE-669 issue have been given. Am I missing something here?
was (Author: l...@jguru.se):
Hello again, Herve and Lukas.
Just a friendly reminder that this bug/patch/misconception is a real pain for
at least 3 projects within which I am working.
Neither of these projects can use released versions of the m-s-p to generate
staged documentation.
Basically, this bug boils down to Maven's assumption that POMs always plays two
roles (reactor and parent), whereas there are
many good reasons to let some POMs be only reactor POMs (defining the reactor
build order) and other POMs only parent
POMs (defining mainly plugins, configuration and versions). This is
particularly apparent when your build reactor contains
stereotype projects (such as projects defining entities), having a set of
common needs/properties/build definitions but being
scattered in several places over the build reactor. This concept clashes with
the way that the m-s-p defines its staging and
site generation.
Have you had any chance to do a review of the patch I supplied in february?
Is anyone else involved in reviewing this [concept and patch], in case you
don't have the cycles yourself?
As far as I have been able to tell, no feedback other than the comments on the
MSITE-669 issue have been given. Am I missing something here?
site:stage creates incorrect structure when module paths contains sets of
../
---
Key: MSITE-669
URL: https://jira.codehaus.org/browse/MSITE-669
Project: Maven 2.x and 3.x Site Plugin
Issue Type: Bug
Components: multi module, relative links, site:stage(-deploy)
Affects Versions: 3.1, 3.2
Reporter: Lennart Jorelid
Assignee: Lukas Theussl
Attachments: msite_669.patch, msite_669_v2.patch, msite_669_v3.patch,
msite_669_v4.patch, nazgul_tools_project_dependencies.png,
nazgul_tools_project_dependencies.png, nazgul_tools_reactor_structure.png,
sample.zip
Given the module definitions given below, the site:stage goal produces sets
of maps relative to the staging directory - i.e. outside of the target
directory.
{code:xml}
modules
module../../validation/validation-api/module
module../../validation/validation-aspect/module
module../parent/module
/modules
{code}
The staged site should be fully included within the staging directory. It
would appear that relativization of links for site:stage should take special
links into consideration.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] (MSITE-669) site:stage creates incorrect structure when module paths contains sets of ../
[
https://jira.codehaus.org/browse/MSITE-669?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=322545#comment-322545
]
Lennart Jorelid commented on MSITE-669:
---
Folks ... AFAICT this bug prevents anyone from staging a site unless the parent
pom is identical to the reactor parent pom.
Presuming that we have a maintainer on the maven-site-plugin, scheduling this
for release [or commenting on the patch] would be greatly appreciated.
Any takers?
site:stage creates incorrect structure when module paths contains sets of
../
---
Key: MSITE-669
URL: https://jira.codehaus.org/browse/MSITE-669
Project: Maven 2.x and 3.x Site Plugin
Issue Type: Bug
Components: multi module, relative links, site:stage(-deploy)
Affects Versions: 3.1, 3.2
Reporter: Lennart Jorelid
Assignee: Lukas Theussl
Attachments: msite_669.patch, msite_669_v2.patch, msite_669_v3.patch,
msite_669_v4.patch, nazgul_tools_project_dependencies.png,
nazgul_tools_project_dependencies.png, nazgul_tools_reactor_structure.png,
sample.zip
Given the module definitions given below, the site:stage goal produces sets
of maps relative to the staging directory - i.e. outside of the target
directory.
{code:xml}
modules
module../../validation/validation-api/module
module../../validation/validation-aspect/module
module../parent/module
/modules
{code}
The staged site should be fully included within the staging directory. It
would appear that relativization of links for site:stage should take special
links into consideration.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] (MSITE-669) site:stage creates incorrect structure when module paths contains sets of ../
[
https://jira.codehaus.org/browse/MSITE-669?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=321855#comment-321855
]
Lennart Jorelid commented on MSITE-669:
---
Any thoughts on this matter, folks?
I would value your input/feedback.
site:stage creates incorrect structure when module paths contains sets of
../
---
Key: MSITE-669
URL: https://jira.codehaus.org/browse/MSITE-669
Project: Maven 2.x and 3.x Site Plugin
Issue Type: Bug
Components: multi module, relative links, site:stage(-deploy)
Affects Versions: 3.1, 3.2
Reporter: Lennart Jorelid
Assignee: Lukas Theussl
Attachments: msite_669.patch, msite_669_v2.patch, msite_669_v3.patch,
msite_669_v4.patch, nazgul_tools_project_dependencies.png,
nazgul_tools_project_dependencies.png, nazgul_tools_reactor_structure.png,
sample.zip
Given the module definitions given below, the site:stage goal produces sets
of maps relative to the staging directory - i.e. outside of the target
directory.
{code:xml}
modules
module../../validation/validation-api/module
module../../validation/validation-aspect/module
module../parent/module
/modules
{code}
The staged site should be fully included within the staging directory. It
would appear that relativization of links for site:stage should take special
links into consideration.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://jira.codehaus.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] (MSITE-669) site:stage creates incorrect structure when module paths contains sets of ../
[
https://jira.codehaus.org/browse/MSITE-669?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Lennart Jorelid updated MSITE-669:
--
Attachment: msite_669_v4.patch
Added version 4 of the patch; added similar structure to stage-deploy goal.
Should we remove the site:stage goal from the site plugin, and simply use the
site:stage-deploy instead?
site:stage creates incorrect structure when module paths contains sets of
../
---
Key: MSITE-669
URL: https://jira.codehaus.org/browse/MSITE-669
Project: Maven 2.x and 3.x Site Plugin
Issue Type: Bug
Components: multi module, relative links, site:stage(-deploy)
Affects Versions: 3.1, 3.2
Reporter: Lennart Jorelid
Assignee: Lukas Theussl
Attachments: msite_669.patch, msite_669_v2.patch, msite_669_v3.patch,
msite_669_v4.patch, nazgul_tools_project_dependencies.png,
nazgul_tools_project_dependencies.png, nazgul_tools_reactor_structure.png,
sample.zip
Given the module definitions given below, the site:stage goal produces sets
of maps relative to the staging directory - i.e. outside of the target
directory.
{code:xml}
modules
module../../validation/validation-api/module
module../../validation/validation-aspect/module
module../parent/module
/modules
{code}
The staged site should be fully included within the staging directory. It
would appear that relativization of links for site:stage should take special
links into consideration.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://jira.codehaus.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] (MSITE-669) site:stage creates incorrect structure when module paths contains sets of ../
[
https://jira.codehaus.org/browse/MSITE-669?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=320037#comment-320037
]
Lennart Jorelid commented on MSITE-669:
---
Taking a look at the site:stage-deploy goal, I am a little confused over its
structure.
One could assume that it would be relying on the fact that site:stage had been
run, but instead it basically is a copy of the site:stage plus some extra
steps/parameters to deploy the staged site.
I wonder if it would not be more natural that the site:stage-deploy goal would
# Need the site:stage goal to be run, and complain otherwise
# Simply deploy the output from the site:stage goal to a remote location
instead of doing all site:stage work all over again
site:stage creates incorrect structure when module paths contains sets of
../
---
Key: MSITE-669
URL: https://jira.codehaus.org/browse/MSITE-669
Project: Maven 2.x and 3.x Site Plugin
Issue Type: Bug
Components: multi module, relative links, site:stage(-deploy)
Affects Versions: 3.1, 3.2
Reporter: Lennart Jorelid
Assignee: Lukas Theussl
Attachments: msite_669.patch, msite_669_v2.patch, msite_669_v3.patch,
nazgul_tools_project_dependencies.png, nazgul_tools_project_dependencies.png,
nazgul_tools_reactor_structure.png, sample.zip
Given the module definitions given below, the site:stage goal produces sets
of maps relative to the staging directory - i.e. outside of the target
directory.
{code:xml}
modules
module../../validation/validation-api/module
module../../validation/validation-aspect/module
module../parent/module
/modules
{code}
The staged site should be fully included within the staging directory. It
would appear that relativization of links for site:stage should take special
links into consideration.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://jira.codehaus.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] (MSITE-669) site:stage creates incorrect structure when module paths contains sets of ../
[
https://jira.codehaus.org/browse/MSITE-669?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=319867#comment-319867
]
Lennart Jorelid commented on MSITE-669:
---
Back from vacation; got a few cycles this week to assign to this issue.
Will check sanity on the patch during the evening.
Meanwhile - could you validate that the documentation changes (on multisite
site generation) provided in this patch are sane/OK/makes sense?
site:stage creates incorrect structure when module paths contains sets of
../
---
Key: MSITE-669
URL: https://jira.codehaus.org/browse/MSITE-669
Project: Maven 2.x and 3.x Site Plugin
Issue Type: Bug
Components: multi module, relative links, site:stage(-deploy)
Affects Versions: 3.1, 3.2
Reporter: Lennart Jorelid
Assignee: Lukas Theussl
Attachments: msite_669.patch, msite_669_v2.patch, msite_669_v3.patch,
nazgul_tools_project_dependencies.png, nazgul_tools_project_dependencies.png,
nazgul_tools_reactor_structure.png, sample.zip
Given the module definitions given below, the site:stage goal produces sets
of maps relative to the staging directory - i.e. outside of the target
directory.
{code:xml}
modules
module../../validation/validation-api/module
module../../validation/validation-aspect/module
module../parent/module
/modules
{code}
The staged site should be fully included within the staging directory. It
would appear that relativization of links for site:stage should take special
links into consideration.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://jira.codehaus.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] (MSITE-669) site:stage creates incorrect structure when module paths contains sets of ../
[
https://jira.codehaus.org/browse/MSITE-669?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=319956#comment-319956
]
Lennart Jorelid commented on MSITE-669:
---
I agree, Herve; it seems that the patch could/should be applied to the
stage-deploy goal as well - with the added twitch that one must also define
which URL should be used to find the site ID, to enable the stage-deploy goal
correctly interact with predefined userID and password given in a server
element within the effective settings.xml.
In stage-deploy, we have at least two URLs to play with:
# The [currently existing] stageSiteURL can be used to override the deployment
upload URL.
# The [to be added] rootSiteURL can be used to define how we should relativize
the intra-module links within the staged site.
I believe that the most logical choice in finding settings.xml-defined
UID/Password for upload of data would be to use the data defined within
settings.xml for the stageSiteURL, rather than the rootSiteURL. You agree
here? This implies that the standard behaviour is used unless overridden.
site:stage creates incorrect structure when module paths contains sets of
../
---
Key: MSITE-669
URL: https://jira.codehaus.org/browse/MSITE-669
Project: Maven 2.x and 3.x Site Plugin
Issue Type: Bug
Components: multi module, relative links, site:stage(-deploy)
Affects Versions: 3.1, 3.2
Reporter: Lennart Jorelid
Assignee: Lukas Theussl
Attachments: msite_669.patch, msite_669_v2.patch, msite_669_v3.patch,
nazgul_tools_project_dependencies.png, nazgul_tools_project_dependencies.png,
nazgul_tools_reactor_structure.png, sample.zip
Given the module definitions given below, the site:stage goal produces sets
of maps relative to the staging directory - i.e. outside of the target
directory.
{code:xml}
modules
module../../validation/validation-api/module
module../../validation/validation-aspect/module
module../parent/module
/modules
{code}
The staged site should be fully included within the staging directory. It
would appear that relativization of links for site:stage should take special
links into consideration.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://jira.codehaus.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] (MSITE-669) site:stage creates incorrect structure when module paths contains sets of ../
[
https://jira.codehaus.org/browse/MSITE-669?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Lennart Jorelid updated MSITE-669:
--
Attachment: msite_669_v3.patch
Version 3 of the patch permits users to supply a configurable URL to use for
siteRootURL.
Could we please slate this patch for inclusion in the next release of the site
plugin?
site:stage creates incorrect structure when module paths contains sets of
../
---
Key: MSITE-669
URL: https://jira.codehaus.org/browse/MSITE-669
Project: Maven 2.x and 3.x Site Plugin
Issue Type: Bug
Components: multi module, relative links, site:stage(-deploy)
Affects Versions: 3.1, 3.2
Reporter: Lennart Jorelid
Assignee: Lukas Theussl
Attachments: msite_669.patch, msite_669_v2.patch, msite_669_v3.patch,
nazgul_tools_project_dependencies.png, nazgul_tools_project_dependencies.png,
nazgul_tools_reactor_structure.png, sample.zip
Given the module definitions given below, the site:stage goal produces sets
of maps relative to the staging directory - i.e. outside of the target
directory.
{code:xml}
modules
module../../validation/validation-api/module
module../../validation/validation-aspect/module
module../parent/module
/modules
{code}
The staged site should be fully included within the staging directory. It
would appear that relativization of links for site:stage should take special
links into consideration.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://jira.codehaus.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] (MSITE-669) site:stage creates incorrect structure when module paths contains sets of ../
[
https://jira.codehaus.org/browse/MSITE-669?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Lennart Jorelid updated MSITE-669:
--
Attachment: msite_669_v2.patch
Patch fix - forgot to use the
--show-copies-as-adds in the former patch.
Please use the v2 patch instead; this patch version is verified to work.
Also - please supply some feedback, folks.
site:stage creates incorrect structure when module paths contains sets of
../
---
Key: MSITE-669
URL: https://jira.codehaus.org/browse/MSITE-669
Project: Maven 2.x and 3.x Site Plugin
Issue Type: Bug
Components: multi module, relative links, site:stage(-deploy)
Affects Versions: 3.1, 3.2
Reporter: Lennart Jorelid
Assignee: Lukas Theussl
Attachments: msite_669.patch, msite_669_v2.patch,
nazgul_tools_project_dependencies.png, nazgul_tools_project_dependencies.png,
nazgul_tools_reactor_structure.png, sample.zip
Given the module definitions given below, the site:stage goal produces sets
of maps relative to the staging directory - i.e. outside of the target
directory.
{code:xml}
modules
module../../validation/validation-api/module
module../../validation/validation-aspect/module
module../parent/module
/modules
{code}
The staged site should be fully included within the staging directory. It
would appear that relativization of links for site:stage should take special
links into consideration.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://jira.codehaus.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
