[jira] Commented: (MASSEMBLY-212) Assembly Descriptor Schemas (XSD) have wrong targetNamespace
[ http://jira.codehaus.org/browse/MASSEMBLY-212?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_114766 ] Manfred Geiler commented on MASSEMBLY-212: -- Hmm, no idea how modello generates the "targetNamespace". Is it derived from the rootElement class definition? Any modello expert here? I would guess that the following "patch" could do the job: Assembly - 1.0.0+ + 1.1.0+ But perhaps that could have the sideeffect that 1.0.0 assemblies could not longer be read? > Assembly Descriptor Schemas (XSD) have wrong targetNamespace > > > Key: MASSEMBLY-212 > URL: http://jira.codehaus.org/browse/MASSEMBLY-212 > Project: Maven 2.x Assembly Plugin > Issue Type: Bug >Affects Versions: 2.1, 2.2-beta-1, 2.2-beta-2, 2.2 >Reporter: Manfred Geiler >Priority: Minor > Fix For: 2.2 > > > There are two versions of Assembly XSDs on the website: > http://maven.apache.org/plugins/maven-assembly-plugin/ > Both define a targetNamespace "http://maven.apache.org/POM/4.0.0"; which is > wrong because those XSDs define the Schema for the Assembly Descriptor and > not the POM. > Proposed fix for assembly-1.0.0.xsd: > Change targetNamespace and xmlns to something like > "http://maven.apache.org/Assembly/1.0.0"; > Proposed fix for assembly-1.1.0-SNAPSHOT.xsd: > Change targetNamespace and xmlns to something like > "http://maven.apache.org/Assembly/1.1.0"; > Regards, > Manfred -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (MASSEMBLY-212) Assembly Descriptor Schemas (XSD) have wrong targetNamespace
[ http://jira.codehaus.org/browse/MASSEMBLY-212?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_112215 ] Manfred Geiler commented on MASSEMBLY-212: -- *PING* Just searched, but have no idea, where those XSDs are located in the SVN repo. If someone points me to them I can provide a patch. Regards, Manfred > Assembly Descriptor Schemas (XSD) have wrong targetNamespace > > > Key: MASSEMBLY-212 > URL: http://jira.codehaus.org/browse/MASSEMBLY-212 > Project: Maven 2.x Assembly Plugin > Issue Type: Bug >Affects Versions: 2.1, 2.2-beta-1, 2.2-beta-2, 2.2 >Reporter: Manfred Geiler >Priority: Minor > Fix For: 2.2 > > > There are two versions of Assembly XSDs on the website: > http://maven.apache.org/plugins/maven-assembly-plugin/ > Both define a targetNamespace "http://maven.apache.org/POM/4.0.0"; which is > wrong because those XSDs define the Schema for the Assembly Descriptor and > not the POM. > Proposed fix for assembly-1.0.0.xsd: > Change targetNamespace and xmlns to something like > "http://maven.apache.org/Assembly/1.0.0"; > Proposed fix for assembly-1.1.0-SNAPSHOT.xsd: > Change targetNamespace and xmlns to something like > "http://maven.apache.org/Assembly/1.1.0"; > Regards, > Manfred -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Created: (MASSEMBLY-212) Assembly Descriptor Schemas (XSD) have wrong targetNamespace
Assembly Descriptor Schemas (XSD) have wrong targetNamespace Key: MASSEMBLY-212 URL: http://jira.codehaus.org/browse/MASSEMBLY-212 Project: Maven 2.x Assembly Plugin Issue Type: Bug Affects Versions: 2.2-beta-1, 2.1, 2.2-beta-2, 2.2 Reporter: Manfred Geiler Priority: Minor There are two versions of Assembly XSDs on the website: http://maven.apache.org/plugins/maven-assembly-plugin/ Both define a targetNamespace "http://maven.apache.org/POM/4.0.0"; which is wrong because those XSDs define the Schema for the Assembly Descriptor and not the POM. Proposed fix for assembly-1.0.0.xsd: Change targetNamespace and xmlns to something like "http://maven.apache.org/Assembly/1.0.0"; Proposed fix for assembly-1.1.0-SNAPSHOT.xsd: Change targetNamespace and xmlns to something like "http://maven.apache.org/Assembly/1.1.0"; Regards, Manfred -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (MNG-2234) activeProfile in ~/.m2/settings.xml is ignored when profiles section is missing or empty
[ http://jira.codehaus.org/browse/MNG-2234?page=comments#action_63894 ] Manfred Geiler commented on MNG-2234: - The actual profiles are defined in the pom.xml files (= best practice for environment settings - see http://maven.apache.org/guides/introduction/introduction-to-profiles.html). To activate one of these profiles without always having to add a -P foobar option on the command line, it makes perfect sense to have this profile activation in the user's settings.xml. And it really works. But only when there is a dummy profile in the settings.xml file. > activeProfile in ~/.m2/settings.xml is ignored when profiles section is > missing or empty > > > Key: MNG-2234 > URL: http://jira.codehaus.org/browse/MNG-2234 > Project: Maven 2 > Type: Bug > Versions: 2.0.4 > Reporter: Manfred Geiler > > > When i have this settings.xml file in my user home dir, the activeProfile > setting is simply ignored by Maven: > > > env-test > > > Adding an empty profiles section does not help: > > > > > env-test > > > Well, adding a dummy profile makes it work: > > > > dummy > > > > env-test > > > Funny, isn't it? > Regards, > Manfred -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Created: (MNG-2234) activeProfile in ~/.m2/settings.xml is ignored when profiles section is missing or empty
activeProfile in ~/.m2/settings.xml is ignored when profiles section is missing or empty Key: MNG-2234 URL: http://jira.codehaus.org/browse/MNG-2234 Project: Maven 2 Type: Bug Versions: 2.0.4 Reporter: Manfred Geiler When i have this settings.xml file in my user home dir, the activeProfile setting is simply ignored by Maven: env-test Adding an empty profiles section does not help: env-test Well, adding a dummy profile makes it work: dummy env-test Funny, isn't it? Regards, Manfred -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (MIDEA-49) WebModuleProperties reactor modules: adding with method 5 not compatible with /WEB-INF/classes
[ http://jira.codehaus.org/browse/MIDEA-49?page=all ]
Manfred Geiler updated MIDEA-49:
Attachment: MIDEA-49-1.patch
> WebModuleProperties reactor modules: adding with method 5 not compatible with
> /WEB-INF/classes
> --
>
> Key: MIDEA-49
> URL: http://jira.codehaus.org/browse/MIDEA-49
> Project: Maven 2.x Idea Plugin
> Type: Bug
> Versions: 2.0
> Reporter: Manfred Geiler
> Attachments: MIDEA-49-1.patch, MIDEA-49-2.patch
>
>
> Currently reactor project modules are added with method "5":
> if ( linkModules && isReactorProject( artifact.getGroupId(),
> artifact.getArtifactId() ) )
> {
> containerElement.addAttribute( "type", "module" );
> containerElement.addAttribute( "name",
> artifact.getArtifactId() );
> Element methodAttribute = createElement( containerElement,
> "attribute" );
> methodAttribute.addAttribute( "name", "method" );
> methodAttribute.addAttribute( "value", "5" );
> <
> Element uriAttribute = createElement( containerElement,
> "attribute" );
> uriAttribute.addAttribute( "name", "URI" );
> uriAttribute.addAttribute( "value", "/WEB-INF/classes" );
> }
> Well, method "5" seems to be "JAR module output and copy file to" in IDEA.
> This method is not compatible with the given URI attribute, which should
> rather be something like "/WEB-INF/lib/foobar.jar".
> So, one way to fix this is to use method "1" ("Copy module output to")
> instead, then the used URI is correct. -->See patch 1.
> Another (more maven-style way) is to fix the URI to be "/WEB-INF/lib/" +
> artifact.getArtifactId() + "-" + artifact.getVersion() + ".jar". -->See patch
> 2.
> Regards,
> Manfred
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Updated: (MIDEA-49) WebModuleProperties reactor modules: adding with method 5 not compatible with /WEB-INF/classes
[ http://jira.codehaus.org/browse/MIDEA-49?page=all ]
Manfred Geiler updated MIDEA-49:
Attachment: MIDEA-49-2.patch
> WebModuleProperties reactor modules: adding with method 5 not compatible with
> /WEB-INF/classes
> --
>
> Key: MIDEA-49
> URL: http://jira.codehaus.org/browse/MIDEA-49
> Project: Maven 2.x Idea Plugin
> Type: Bug
> Versions: 2.0
> Reporter: Manfred Geiler
> Attachments: MIDEA-49-1.patch, MIDEA-49-2.patch
>
>
> Currently reactor project modules are added with method "5":
> if ( linkModules && isReactorProject( artifact.getGroupId(),
> artifact.getArtifactId() ) )
> {
> containerElement.addAttribute( "type", "module" );
> containerElement.addAttribute( "name",
> artifact.getArtifactId() );
> Element methodAttribute = createElement( containerElement,
> "attribute" );
> methodAttribute.addAttribute( "name", "method" );
> methodAttribute.addAttribute( "value", "5" );
> <
> Element uriAttribute = createElement( containerElement,
> "attribute" );
> uriAttribute.addAttribute( "name", "URI" );
> uriAttribute.addAttribute( "value", "/WEB-INF/classes" );
> }
> Well, method "5" seems to be "JAR module output and copy file to" in IDEA.
> This method is not compatible with the given URI attribute, which should
> rather be something like "/WEB-INF/lib/foobar.jar".
> So, one way to fix this is to use method "1" ("Copy module output to")
> instead, then the used URI is correct. -->See patch 1.
> Another (more maven-style way) is to fix the URI to be "/WEB-INF/lib/" +
> artifact.getArtifactId() + "-" + artifact.getVersion() + ".jar". -->See patch
> 2.
> Regards,
> Manfred
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Created: (MIDEA-49) WebModuleProperties reactor modules: adding with method 5 not compatible with /WEB-INF/classes
WebModuleProperties reactor modules: adding with method 5 not compatible with
/WEB-INF/classes
--
Key: MIDEA-49
URL: http://jira.codehaus.org/browse/MIDEA-49
Project: Maven 2.x Idea Plugin
Type: Bug
Versions: 2.0
Reporter: Manfred Geiler
Currently reactor project modules are added with method "5":
if ( linkModules && isReactorProject( artifact.getGroupId(),
artifact.getArtifactId() ) )
{
containerElement.addAttribute( "type", "module" );
containerElement.addAttribute( "name", artifact.getArtifactId()
);
Element methodAttribute = createElement( containerElement,
"attribute" );
methodAttribute.addAttribute( "name", "method" );
methodAttribute.addAttribute( "value", "5" );
<
Element uriAttribute = createElement( containerElement,
"attribute" );
uriAttribute.addAttribute( "name", "URI" );
uriAttribute.addAttribute( "value", "/WEB-INF/classes" );
}
Well, method "5" seems to be "JAR module output and copy file to" in IDEA. This
method is not compatible with the given URI attribute, which should rather be
something like "/WEB-INF/lib/foobar.jar".
So, one way to fix this is to use method "1" ("Copy module output to") instead,
then the used URI is correct. -->See patch 1.
Another (more maven-style way) is to fix the URI to be "/WEB-INF/lib/" +
artifact.getArtifactId() + "-" + artifact.getVersion() + ".jar". -->See patch 2.
Regards,
Manfred
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Commented: (MIDEA-35) Module Libraries and WebModule libraries to package should not have a name attribute
[ http://jira.codehaus.org/browse/MIDEA-35?page=comments#action_63299 ] Manfred Geiler commented on MIDEA-35: - No, sorry for bringing you false hope ;-) By "undocumented" I meant that it is not possible from with IDEA GUI to achieve that result. It's only possible to have named module lib definitions when you fiddle with iml files directly. > Module Libraries and WebModule libraries to package should not have a name > attribute > > > Key: MIDEA-35 > URL: http://jira.codehaus.org/browse/MIDEA-35 > Project: Maven 2.x Idea Plugin > Type: Bug > Versions: 2.0 > Reporter: Manfred Geiler > Assignee: Edwin Punzalan > Priority: Blocker > Fix For: 2.0 > Attachments: MIDEA-35.patch, idea-2.patch > > > Idea 5.x does not seem to support name attributes in module library > definitions. At least it leads to buggy behavior when WebModule settings are > involved. > There is no way to add a module library with a name from within IDEA. So what > the plugin is using here is an undocumented feature that leads to strange > results. > The solution is to add the module libraries without the name attribute and to > add the WebModule containerElements without a name too. Instead the jar URL > is added to the containerElement. > see applied patch > Cheers, > Manfred -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Created: (MIDEA-35) Module Libraries and WebModule libraries to package should not have a name attribute
Module Libraries and WebModule libraries to package should not have a name attribute Key: MIDEA-35 URL: http://jira.codehaus.org/browse/MIDEA-35 Project: Maven 2.x Idea Plugin Type: Bug Versions: 2.0 Reporter: Manfred Geiler Priority: Blocker Attachments: idea-2.patch Idea 5.x does not seem to support name attributes in module library definitions. At least it leads to buggy behavior when WebModule settings are involved. There is no way to add a module library with a name from within IDEA. So what the plugin is using here is an undocumented feature that leads to strange results. The solution is to add the module libraries without the name attribute and to add the WebModule containerElements without a name too. Instead the jar URL is added to the containerElement. see applied patch Cheers, Manfred -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Created: (MIDEA-34) Add resources to source folders instead of module libraries
Add resources to source folders instead of module libraries --- Key: MIDEA-34 URL: http://jira.codehaus.org/browse/MIDEA-34 Project: Maven 2.x Idea Plugin Type: Bug Versions: 2.0 Reporter: Manfred Geiler Priority: Critical Attachments: idea-1.patch Having the resources as module libraries does not make much sense. Instead the resources dir(s) should be added as normal idea source folders, so that editing of properties files, xml files, etc. is possible. see applied patch Regards, Manfred -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
