[jira] Created: (MNGECLIPSE-198) resolveClasspathEntries performance bug

2006-09-25 Thread Marek Bieganski (JIRA)
resolveClasspathEntries performance bug
---

 Key: MNGECLIPSE-198
 URL: http://jira.codehaus.org/browse/MNGECLIPSE-198
 Project: Maven 2.x Extension for Eclipse
  Issue Type: Bug
  Components: Dependency Resolver
Affects Versions: 0.0.10
 Environment: Eclipse 3.2 for Windows
Reporter: Marek Bieganski
 Attachments: call_graph.zip

Most of time used by resolveClasspathEntries method is wasted for resolving 
javadoc urls.
I attached call graps from jprofiler.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: 
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira




[jira] Updated: (MNGECLIPSE-59) Allow artifact resolution from workspace projects

2006-08-28 Thread Marek Bieganski (JIRA)
 [ http://jira.codehaus.org/browse/MNGECLIPSE-59?page=all ]

Marek Bieganski updated MNGECLIPSE-59:
--

Attachment: CloseAndOpen.zip

> Allow artifact resolution from workspace projects
> -
>
> Key: MNGECLIPSE-59
> URL: http://jira.codehaus.org/browse/MNGECLIPSE-59
> Project: Maven 2.x Extension for Eclipse
>  Issue Type: New Feature
>  Components: Dependency Resolver
>Affects Versions: 0.0.4
>Reporter: Leonardo Quijano Vincenzi
> Attachments: ArtifactResolver-try3.patch, CloseAndOpen.zip, 
> MNGECLIPSE-59, mngeclipse-59-drew-hack.txt, 
> project-artifacts-2006062701.patch, project-artifacts-2006062900.patch, 
> project-artifacts.patch
>
>
> Provide artifact resolution from workspace projects, which override the same 
> artifact from the local or remote repositories. This would allow to work with 
> dependant Eclipse projects without specifying the Eclipse dependency manually.
> The workspace artifact resolution would have to be specified manually, since 
> several Maven-Enabled projects in the same workspace could have the same 
> artifact and version Id. Or at least automatic resolution with an optional 
> override would be nice.
> More comments here:
> http://jira.codehaus.org/browse/MNGECLIPSE-58

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: 
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira




[jira] Commented: (MNGECLIPSE-59) Allow artifact resolution from workspace projects

2006-08-28 Thread Marek Bieganski (JIRA)
[ http://jira.codehaus.org/browse/MNGECLIPSE-59?page=comments#action_73452 
] 

Marek Bieganski commented on MNGECLIPSE-59:
---

Step 0:
Turn on auto build 

Step 1: 
Import attached simple projects

Step 2: 
Deploy library project (jar and pom) into maven2 repository 

Setp 3: 
Clean workspace to ensure situation on picture 1

Step 4:
Close library project (picture 2). 
Repository jar should be used, but eclipse is still looking for project
"Project application is missing required Java project: 'library'"
Cleaning workspace has no effect.

Step 5: 
Close eclipse, and reopen it
Situation is still like on picture 2

Step 6: 
Clean workspace
This time it has effect, and jar from repository is used (picture 3).

Step 7:
Open library project 
Project is available, but jar is still used. (picture 4)
First clean has no effect.
Second clean has effect and we are back in step 3

Similar problems occurs on deleting and e.g importing library project.
When auto build is on, no workspace cleaning nor closing eclipse should be 
needed.


> Allow artifact resolution from workspace projects
> -
>
> Key: MNGECLIPSE-59
> URL: http://jira.codehaus.org/browse/MNGECLIPSE-59
> Project: Maven 2.x Extension for Eclipse
>  Issue Type: New Feature
>  Components: Dependency Resolver
>Affects Versions: 0.0.4
>Reporter: Leonardo Quijano Vincenzi
> Attachments: ArtifactResolver-try3.patch, MNGECLIPSE-59, 
> mngeclipse-59-drew-hack.txt, project-artifacts-2006062701.patch, 
> project-artifacts-2006062900.patch, project-artifacts.patch
>
>
> Provide artifact resolution from workspace projects, which override the same 
> artifact from the local or remote repositories. This would allow to work with 
> dependant Eclipse projects without specifying the Eclipse dependency manually.
> The workspace artifact resolution would have to be specified manually, since 
> several Maven-Enabled projects in the same workspace could have the same 
> artifact and version Id. Or at least automatic resolution with an optional 
> override would be nice.
> More comments here:
> http://jira.codehaus.org/browse/MNGECLIPSE-58

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: 
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira




[jira] Created: (MNGECLIPSE-190) Unable to enable Maven2 plugin for existing not maven2 project

2006-08-25 Thread Marek Bieganski (JIRA)
Unable to enable Maven2 plugin for existing not maven2 project
--

 Key: MNGECLIPSE-190
 URL: http://jira.codehaus.org/browse/MNGECLIPSE-190
 Project: Maven 2.x Extension for Eclipse
  Issue Type: Bug
  Components: Wizards
Affects Versions: 0.0.10
 Environment: WinXP, Eclipse 3.2
Reporter: Marek Bieganski
 Assigned To: Eugene Kuleshov
 Attachments: UnableToEnable.PNG

Steps:

1. Create new Java project, enter name e.g. "lib"
2. Right click on it, select Maven2->Enable
3. Cannot do anything on this window 

In 0.0.9 it was it worked fine.



-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: 
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira




[jira] Commented: (MNGECLIPSE-59) Allow artifact resolution from workspace projects

2006-08-24 Thread Marek Bieganski (JIRA)
[ http://jira.codehaus.org/browse/MNGECLIPSE-59?page=comments#action_73187 
] 

Marek Bieganski commented on MNGECLIPSE-59:
---

There are still problems on open/close or checkout/delete projects declared as 
dependencies in other project's pom.



> Allow artifact resolution from workspace projects
> -
>
> Key: MNGECLIPSE-59
> URL: http://jira.codehaus.org/browse/MNGECLIPSE-59
> Project: Maven 2.x Extension for Eclipse
>  Issue Type: New Feature
>  Components: Dependency Resolver
>Affects Versions: 0.0.4
>Reporter: Leonardo Quijano Vincenzi
> Attachments: ArtifactResolver-try3.patch, MNGECLIPSE-59, 
> mngeclipse-59-drew-hack.txt, project-artifacts-2006062701.patch, 
> project-artifacts-2006062900.patch, project-artifacts.patch
>
>
> Provide artifact resolution from workspace projects, which override the same 
> artifact from the local or remote repositories. This would allow to work with 
> dependant Eclipse projects without specifying the Eclipse dependency manually.
> The workspace artifact resolution would have to be specified manually, since 
> several Maven-Enabled projects in the same workspace could have the same 
> artifact and version Id. Or at least automatic resolution with an optional 
> override would be nice.
> More comments here:
> http://jira.codehaus.org/browse/MNGECLIPSE-58

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: 
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira




[jira] Created: (MNGECLIPSE-186) repositories section in settings.xml ignored (trunk - 0.0.10 candidate)

2006-08-23 Thread Marek Bieganski (JIRA)
repositories section in settings.xml ignored (trunk - 0.0.10 candidate)
---

 Key: MNGECLIPSE-186
 URL: http://jira.codehaus.org/browse/MNGECLIPSE-186
 Project: Maven 2.x Extension for Eclipse
  Issue Type: Bug
  Components: Repository Management
Affects Versions: 0.0.10
 Environment: Eclipse 3.1/3.2 for Windows
Reporter: Marek Bieganski
 Assigned To: Eugene Kuleshov


Repositories section in settings.xml ignored. It worked ok in 0.0.9
When I switched to unreleased version from trunk, i had to configure remote 
repositories in every pom.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: 
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira




[jira] Commented: (MNGECLIPSE-59) Allow artifact resolution from workspace projects

2006-06-26 Thread Marek Bieganski (JIRA)
[ http://jira.codehaus.org/browse/MNGECLIPSE-59?page=comments#action_68229 
] 

Marek Bieganski commented on MNGECLIPSE-59:
---

Caching artifact key in Maven2Nature instead of parsing model/project every 
time seems to be good idea too

> Allow artifact resolution from workspace projects
> -
>
>  Key: MNGECLIPSE-59
>  URL: http://jira.codehaus.org/browse/MNGECLIPSE-59
>  Project: Maven 2.x Extension for Eclipse
> Type: New Feature

>   Components: Dependency Resolver
> Versions: 0.0.4
> Reporter: Leonardo Quijano Vincenzi
> Assignee: Eugene Kuleshov
>  Attachments: ArtifactResolver-try3.patch, MNGECLIPSE-59, 
> mngeclipse-59-drew-hack.txt, project-artifacts.patch
>
>
> Provide artifact resolution from workspace projects, which override the same 
> artifact from the local or remote repositories. This would allow to work with 
> dependant Eclipse projects without specifying the Eclipse dependency manually.
> The workspace artifact resolution would have to be specified manually, since 
> several Maven-Enabled projects in the same workspace could have the same 
> artifact and version Id. Or at least automatic resolution with an optional 
> override would be nice.
> More comments here:
> http://jira.codehaus.org/browse/MNGECLIPSE-58

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira



[jira] Commented: (MNGECLIPSE-59) Allow artifact resolution from workspace projects

2006-06-26 Thread Marek Bieganski (JIRA)
[ http://jira.codehaus.org/browse/MNGECLIPSE-59?page=comments#action_68227 
] 

Marek Bieganski commented on MNGECLIPSE-59:
---

in patched Maven2Plugin class:
Why method: getModel(IFile file)  
uses:
  getMavenEmbedder().readProjectWithDependencies( file.getLocation().toFile() 
).getModel();
instead of quicker:
  getMavenEmbedder().readModel(file.getLocation().toFile());
?


> Allow artifact resolution from workspace projects
> -
>
>  Key: MNGECLIPSE-59
>  URL: http://jira.codehaus.org/browse/MNGECLIPSE-59
>  Project: Maven 2.x Extension for Eclipse
> Type: New Feature

>   Components: Dependency Resolver
> Versions: 0.0.4
> Reporter: Leonardo Quijano Vincenzi
> Assignee: Eugene Kuleshov
>  Attachments: ArtifactResolver-try3.patch, MNGECLIPSE-59, 
> mngeclipse-59-drew-hack.txt, project-artifacts.patch
>
>
> Provide artifact resolution from workspace projects, which override the same 
> artifact from the local or remote repositories. This would allow to work with 
> dependant Eclipse projects without specifying the Eclipse dependency manually.
> The workspace artifact resolution would have to be specified manually, since 
> several Maven-Enabled projects in the same workspace could have the same 
> artifact and version Id. Or at least automatic resolution with an optional 
> override would be nice.
> More comments here:
> http://jira.codehaus.org/browse/MNGECLIPSE-58

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira



[jira] Commented: (MNGECLIPSE-140) Inaccessible POM validation messages

2006-06-19 Thread Marek Bieganski (JIRA)
[ http://jira.codehaus.org/browse/MNGECLIPSE-140?page=comments#action_67624 
] 

Marek Bieganski commented on MNGECLIPSE-140:


I believe, whenever pom is invalid
http://svn.apache.org/repos/asf/maven/components/trunk/maven-project/src/main/java/org/apache/maven/project/validation/

> Inaccessible POM validation messages 
> -
>
>  Key: MNGECLIPSE-140
>  URL: http://jira.codehaus.org/browse/MNGECLIPSE-140
>  Project: Maven 2.x Extension for Eclipse
> Type: Bug

>   Components: Dependency Resolver
> Versions: 0.0.9
> Reporter: Marek Bieganski
> Assignee: Eugene Kuleshov

>
>
> Question is why handleProjectBuildingException method completely ignores 
> information from validationResult?
> Shouldn't it contain:
> ...
> } else if( ex instanceof InvalidProjectModelException) {
> InvalidProjectModelException pex = ( InvalidProjectModelException ) ex;
> String msg = Messages.getString("plugin.markerBuildError") + pex.getMessage() 
> + ": " + pex.getValidationResult().toString();
> Maven2Plugin.getDefault().addMarker(this.file, msg, 1, 
> IMarker.SEVERITY_ERROR); //$NON-NLS-1$
> Maven2Plugin.getDefault().getConsole().logError( msg);
> } else {
> ...

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira



[jira] Commented: (MNGECLIPSE-140) Inaccessible POM validation messages

2006-06-14 Thread Marek Bieganski (JIRA)
[ http://jira.codehaus.org/browse/MNGECLIPSE-140?page=comments#action_67396 
] 

Marek Bieganski commented on MNGECLIPSE-140:


Exception is thrown when ModelValidator creates not empty result. 
Just remove: ".toString()", or check for null before concatenetion 

> Inaccessible POM validation messages 
> -
>
>  Key: MNGECLIPSE-140
>  URL: http://jira.codehaus.org/browse/MNGECLIPSE-140
>  Project: Maven 2.x Extension for Eclipse
> Type: Bug

>   Components: Dependency Resolver
> Versions: 0.0.9
> Reporter: Marek Bieganski
> Assignee: Eugene Kuleshov

>
>
> Question is why handleProjectBuildingException method completely ignores 
> information from validationResult?
> Shouldn't it contain:
> ...
> } else if( ex instanceof InvalidProjectModelException) {
> InvalidProjectModelException pex = ( InvalidProjectModelException ) ex;
> String msg = Messages.getString("plugin.markerBuildError") + pex.getMessage() 
> + ": " + pex.getValidationResult().toString();
> Maven2Plugin.getDefault().addMarker(this.file, msg, 1, 
> IMarker.SEVERITY_ERROR); //$NON-NLS-1$
> Maven2Plugin.getDefault().getConsole().logError( msg);
> } else {
> ...

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira



[jira] Commented: (MNGECLIPSE-129) dependency type from parent pom

2006-06-14 Thread Marek Bieganski (JIRA)
[ http://jira.codehaus.org/browse/MNGECLIPSE-129?page=comments#action_67388 
] 

Marek Bieganski commented on MNGECLIPSE-129:


MNGECLIPSE-140 is created

> dependency type from parent pom
> ---
>
>  Key: MNGECLIPSE-129
>  URL: http://jira.codehaus.org/browse/MNGECLIPSE-129
>  Project: Maven 2.x Extension for Eclipse
> Type: Bug

>   Components: Dependency Resolver
> Versions: 0.0.9
>  Environment: Eclipse: 3.1.1
> Reporter: Marek Bieganski
> Assignee: Eugene Kuleshov
> Priority: Minor

>
>
> My pom contains dependencies like:
> 
>   xxx-parent
>   com.xxx
>   HEAD-SNAPSHOT
> 
> ...
> 
>   com.xxx
>   yyy
> 
> xxx-parent pom contains full yyy dependency info:
> 
>   com.xxx
>   yyy
>   HEAD-SNAPSHOT
>   ejb
>  
> Problem occurs when ejb is declared in parent pom, and no  
> is declared in child pom.
> Only error message i got is:
> 06-05-30 15:32:49 CEST: Project build error Failed to validate POM
> Workaround is to redeclare ejb in child pom, but AFAIK if no 
> type is declared, it should be inherited from parent

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira



[jira] Closed: (MNGECLIPSE-129) dependency type from parent pom

2006-06-14 Thread Marek Bieganski (JIRA)
 [ http://jira.codehaus.org/browse/MNGECLIPSE-129?page=all ]
 
Marek Bieganski closed MNGECLIPSE-129:
--

Resolution: Cannot Reproduce

> dependency type from parent pom
> ---
>
>  Key: MNGECLIPSE-129
>  URL: http://jira.codehaus.org/browse/MNGECLIPSE-129
>  Project: Maven 2.x Extension for Eclipse
> Type: Bug

>   Components: Dependency Resolver
> Versions: 0.0.9
>  Environment: Eclipse: 3.1.1
> Reporter: Marek Bieganski
> Assignee: Eugene Kuleshov
> Priority: Minor

>
>
> My pom contains dependencies like:
> 
>   xxx-parent
>   com.xxx
>   HEAD-SNAPSHOT
> 
> ...
> 
>   com.xxx
>   yyy
> 
> xxx-parent pom contains full yyy dependency info:
> 
>   com.xxx
>   yyy
>   HEAD-SNAPSHOT
>   ejb
>  
> Problem occurs when ejb is declared in parent pom, and no  
> is declared in child pom.
> Only error message i got is:
> 06-05-30 15:32:49 CEST: Project build error Failed to validate POM
> Workaround is to redeclare ejb in child pom, but AFAIK if no 
> type is declared, it should be inherited from parent

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira



[jira] Created: (MNGECLIPSE-140) Inaccessible POM validation messages

2006-06-14 Thread Marek Bieganski (JIRA)
Inaccessible POM validation messages 
-

 Key: MNGECLIPSE-140
 URL: http://jira.codehaus.org/browse/MNGECLIPSE-140
 Project: Maven 2.x Extension for Eclipse
Type: Bug

  Components: Dependency Resolver  
Versions: 0.0.9
Reporter: Marek Bieganski
 Assigned to: Eugene Kuleshov 


Question is why handleProjectBuildingException method completely ignores 
information from validationResult?

Shouldn't it contain:

...
} else if( ex instanceof InvalidProjectModelException) {
InvalidProjectModelException pex = ( InvalidProjectModelException ) ex;
String msg = Messages.getString("plugin.markerBuildError") + pex.getMessage() + 
": " + pex.getValidationResult().toString();
Maven2Plugin.getDefault().addMarker(this.file, msg, 1, IMarker.SEVERITY_ERROR); 
//$NON-NLS-1$
Maven2Plugin.getDefault().getConsole().logError( msg);
} else {
...



-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira



[jira] Commented: (MNGECLIPSE-129) dependency type from parent pom

2006-06-14 Thread Marek Bieganski (JIRA)
[ http://jira.codehaus.org/browse/MNGECLIPSE-129?page=comments#action_67387 
] 

Marek Bieganski commented on MNGECLIPSE-129:


You are right. This issue should be closed. If you need another to for message 
validation logs, I will create one

> dependency type from parent pom
> ---
>
>  Key: MNGECLIPSE-129
>  URL: http://jira.codehaus.org/browse/MNGECLIPSE-129
>  Project: Maven 2.x Extension for Eclipse
> Type: Bug

>   Components: Dependency Resolver
> Versions: 0.0.9
>  Environment: Eclipse: 3.1.1
> Reporter: Marek Bieganski
> Assignee: Eugene Kuleshov
> Priority: Minor

>
>
> My pom contains dependencies like:
> 
>   xxx-parent
>   com.xxx
>   HEAD-SNAPSHOT
> 
> ...
> 
>   com.xxx
>   yyy
> 
> xxx-parent pom contains full yyy dependency info:
> 
>   com.xxx
>   yyy
>   HEAD-SNAPSHOT
>   ejb
>  
> Problem occurs when ejb is declared in parent pom, and no  
> is declared in child pom.
> Only error message i got is:
> 06-05-30 15:32:49 CEST: Project build error Failed to validate POM
> Workaround is to redeclare ejb in child pom, but AFAIK if no 
> type is declared, it should be inherited from parent

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira



[jira] Commented: (MNGECLIPSE-129) dependency type from parent pom

2006-06-14 Thread Marek Bieganski (JIRA)
[ http://jira.codehaus.org/browse/MNGECLIPSE-129?page=comments#action_67386 
] 

Marek Bieganski commented on MNGECLIPSE-129:


Of course it should be:

...
  } else if( ex instanceof InvalidProjectModelException) {
InvalidProjectModelException pex = ( InvalidProjectModelException ) ex;
String msg = Messages.getString("plugin.markerBuildError") + 
pex.getMessage() + ": " + pex.getValidationResult().toString();
Maven2Plugin.getDefault().addMarker(this.file, msg, 1, 
IMarker.SEVERITY_ERROR); //$NON-NLS-1$
Maven2Plugin.getDefault().getConsole().logError( msg);
  } else {
...

Sorry for small mistake. This time it works fine

> dependency type from parent pom
> ---
>
>  Key: MNGECLIPSE-129
>  URL: http://jira.codehaus.org/browse/MNGECLIPSE-129
>  Project: Maven 2.x Extension for Eclipse
> Type: Bug

>   Components: Dependency Resolver
> Versions: 0.0.9
>  Environment: Eclipse: 3.1.1
> Reporter: Marek Bieganski
> Assignee: Eugene Kuleshov
> Priority: Minor

>
>
> My pom contains dependencies like:
> 
>   xxx-parent
>   com.xxx
>   HEAD-SNAPSHOT
> 
> ...
> 
>   com.xxx
>   yyy
> 
> xxx-parent pom contains full yyy dependency info:
> 
>   com.xxx
>   yyy
>   HEAD-SNAPSHOT
>   ejb
>  
> Problem occurs when ejb is declared in parent pom, and no  
> is declared in child pom.
> Only error message i got is:
> 06-05-30 15:32:49 CEST: Project build error Failed to validate POM
> Workaround is to redeclare ejb in child pom, but AFAIK if no 
> type is declared, it should be inherited from parent

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira



[jira] Commented: (MNGECLIPSE-129) dependency type from parent pom

2006-06-14 Thread Marek Bieganski (JIRA)
[ http://jira.codehaus.org/browse/MNGECLIPSE-129?page=comments#action_67382 
] 

Marek Bieganski commented on MNGECLIPSE-129:


I found out, that maven2 does not obtain type from parent. It uses "jar" as 
default value.
When dependency type in child project (default "jar" in my case) is different 
from depency type in parent pom (in my case "ejb"), dependency is not matched 
so child dependency version is null and child pom is invalid.

Maven 2.x Extension for Eclipse is not a source of problem. 
It seems, that dependency types different than "jar" have to be redeclared in 
child projects.

Question is why handleProjectBuildingException method completely ignores 
information from validationResult?

Shouldn't it contain:

  } else if( cause instanceof InvalidProjectModelException) {
InvalidProjectModelException pex = ( InvalidProjectModelException ) 
cause;
String msg = Messages.getString("plugin.markerBuildError") + 
pex.getMessage() + ": " + pex.getValidationResult().toString();
Maven2Plugin.getDefault().addMarker(this.file, msg, 1, 
IMarker.SEVERITY_ERROR); //$NON-NLS-1$
Maven2Plugin.getDefault().getConsole().logError( msg);
  } else {





> dependency type from parent pom
> ---
>
>  Key: MNGECLIPSE-129
>  URL: http://jira.codehaus.org/browse/MNGECLIPSE-129
>  Project: Maven 2.x Extension for Eclipse
> Type: Bug

>   Components: Dependency Resolver
> Versions: 0.0.9
>  Environment: Eclipse: 3.1.1
> Reporter: Marek Bieganski
> Assignee: Eugene Kuleshov
> Priority: Minor

>
>
> My pom contains dependencies like:
> 
>   xxx-parent
>   com.xxx
>   HEAD-SNAPSHOT
> 
> ...
> 
>   com.xxx
>   yyy
> 
> xxx-parent pom contains full yyy dependency info:
> 
>   com.xxx
>   yyy
>   HEAD-SNAPSHOT
>   ejb
>  
> Problem occurs when ejb is declared in parent pom, and no  
> is declared in child pom.
> Only error message i got is:
> 06-05-30 15:32:49 CEST: Project build error Failed to validate POM
> Workaround is to redeclare ejb in child pom, but AFAIK if no 
> type is declared, it should be inherited from parent

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira



[jira] Commented: (MNGECLIPSE-59) Allow artifact resolution from workspace projects

2006-06-14 Thread Marek Bieganski (JIRA)
[ http://jira.codehaus.org/browse/MNGECLIPSE-59?page=comments#action_67370 
] 

Marek Bieganski commented on MNGECLIPSE-59:
---

getWorkspaceNature(Artifact) method iterates over all projects every time it is 
called.
Isn't it a good idea to cache natures in map indexed with artifact key and 
reset this map only if needed?

  static Map getWorkspaceNatures() throws CoreException {
IProject[] projects = 
ResourcesPlugin.getWorkspace().getRoot().getProjects();
Map natures=new Hashtable();
for (int i = 0; i < projects.length; ++i) {
  IProject project = projects[i];
  if (project.isOpen()) {
Maven2Nature nature = (Maven2Nature)project.getNature(NATURE_ID);
if (nature != null) {
  natures.put(nature.getArtifactKey(),nature);
}
  }
}
return natures;
  }

> Allow artifact resolution from workspace projects
> -
>
>  Key: MNGECLIPSE-59
>  URL: http://jira.codehaus.org/browse/MNGECLIPSE-59
>  Project: Maven 2.x Extension for Eclipse
> Type: New Feature

>   Components: Dependency Resolver
> Versions: 0.0.4
> Reporter: Leonardo Quijano Vincenzi
> Assignee: Eugene Kuleshov
>  Attachments: ArtifactResolver-try3.patch, MNGECLIPSE-59, 
> mngeclipse-59-drew-hack.txt, project-artifacts.patch
>
>
> Provide artifact resolution from workspace projects, which override the same 
> artifact from the local or remote repositories. This would allow to work with 
> dependant Eclipse projects without specifying the Eclipse dependency manually.
> The workspace artifact resolution would have to be specified manually, since 
> several Maven-Enabled projects in the same workspace could have the same 
> artifact and version Id. Or at least automatic resolution with an optional 
> override would be nice.
> More comments here:
> http://jira.codehaus.org/browse/MNGECLIPSE-58

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira



[jira] Commented: (MNGECLIPSE-59) Allow artifact resolution from workspace projects

2006-06-07 Thread Marek Bieganski (JIRA)
[ http://jira.codehaus.org/browse/MNGECLIPSE-59?page=comments#action_66895 
] 

Marek Bieganski commented on MNGECLIPSE-59:
---

In my opinion main goal of this functionality is to have only one version of 
.classpath and pom for each project. It should be versioned with projects in 
CVS or SVN. If somebody wants to work on single projects only, he checks out 
only this project. Correct dependencies are downloaded from m2 repository. If 
sombody decide to work on other projects connected with dependencies, the only 
thing he has to do is to check out correct versions of these projects. No 
changes in pom nor in .classpath are needed. There will be no reqiured projects 
declarations in "java build path". 
I thing it will be a huge improvement for people working on complicated project 
sets, to allow them to work only on projects that they are interested in 
without forcing them to change anything in build path or to check out 
everything.

> Allow artifact resolution from workspace projects
> -
>
>  Key: MNGECLIPSE-59
>  URL: http://jira.codehaus.org/browse/MNGECLIPSE-59
>  Project: Maven 2.x Extension for Eclipse
> Type: New Feature

>   Components: Dependency Resolver
> Versions: 0.0.4
> Reporter: Leonardo Quijano Vincenzi
> Assignee: Eugene Kuleshov
>  Attachments: ArtifactResolver-try3.patch, MNGECLIPSE-59, 
> mngeclipse-59-drew-hack.txt
>
>
> Provide artifact resolution from workspace projects, which override the same 
> artifact from the local or remote repositories. This would allow to work with 
> dependant Eclipse projects without specifying the Eclipse dependency manually.
> The workspace artifact resolution would have to be specified manually, since 
> several Maven-Enabled projects in the same workspace could have the same 
> artifact and version Id. Or at least automatic resolution with an optional 
> override would be nice.
> More comments here:
> http://jira.codehaus.org/browse/MNGECLIPSE-58

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira