[jira] (MSCMPUB-13) automaticRemotePathCreation does not create parent directories
Michael Koch created MSCMPUB-13:
---
Summary: automaticRemotePathCreation does not create parent
directories
Key: MSCMPUB-13
URL: https://jira.codehaus.org/browse/MSCMPUB-13
Project: maven-scm-publish-plugin
Issue Type: Bug
Affects Versions: 1.0
Reporter: Michael Koch
Priority: Minor
{{mvn scm-publish:publish-scm
-Dscmpublish.pubScmUrl=scm:svn:.../$\{project.artifactId\}/$\{project.version\}}}
fails if the directory {{$\{project.artifactId\}}} does not exist. This
happens regardless of the {{automaticRemotePathCreation}} setting. Publishing
the site of a new project therefore fails unless the SVN path is created
manually.
The root cause is that maven-scm-provider-svnexe does not add the "--parents"
parameter to the {{svn mkdir}} command. I don't know if this should be
considered a bug of the provider, or if the provider API should be enhanced to
make this configurable.
--
This message was sent by Atlassian JIRA
(v6.1.6#6162)
[jira] (MSITE-640) Maven searches only central repository for imported dependencies
[
https://jira.codehaus.org/browse/MSITE-640?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=326279#comment-326279
]
Michael Koch commented on MSITE-640:
I should add that I could not reproduce the error in the current Maven
3.1-SNAPSHOT. The newer Aether version (_Eclipse 0.9.0-M2_ as opposed to
_Sonatype 1.13.1_ in the 3.0.5 release) resolves the artifact from the local
repository even though the remote repository from which it originated is not
defined in the {{ProjectBuildingRequest}}.
> Maven searches only central repository for imported dependencies
>
>
> Key: MSITE-640
> URL: https://jira.codehaus.org/browse/MSITE-640
> Project: Maven 2.x and 3.x Site Plugin
> Issue Type: Bug
> Components: Maven 3
>Affects Versions: 3.0
> Environment: Windows 7
>Reporter: Markus Tippmann
> Attachments: stacktrace.txt
>
>
> We are using dependencyManagement with "import" scope like described here:
> http://maven.apache.org/guides/introduction/introduction-to-dependency-mechanism.html#Importing_Dependencies
> Problem occurs only at site generation, not at build time, where it works
> perfectly.
> The site plugin tries to find the imported artifacts, but searches only the
> central repository and ignores the repositories in settings.xml
> configuration. Mirror settings work, if "central" is mirrored, but
> dependencies need to be resolved from two repositories, so one mirror does
> not help here.
> I try to attach the relevant parts of the stacktrace.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] (MSITE-640) Maven searches only central repository for imported dependencies
[
https://jira.codehaus.org/browse/MSITE-640?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=326248#comment-326248
]
Michael Koch commented on MSITE-640:
I also spent some time debugging the code, here are my findings:
bq. the root cause seemed to be that the site plugin wasn't giving Maven the
full list of repositories to search.
I don't think the site plugin ({{DefaultSiteTool.populateModulesMenu}} from
_doxia-integration-tools_) can pass the list of repositories because the
{{MavenProjectBuilder}} interface has no method which accepts a POM file and a
list of repositories. I guess adding one would be counter-productive since the
interface is deprecated.
My idea would be to fix the repository list resolution of the
{{DefaultMavenProjectBuilder}} in _maven-compat_. As far as I can see by
debugging, the problem is that the list of profiles (including the profile from
the settings.xml which declares the required repository) is not copied from the
{{legacySupport MavenSession}} to the {{ProjectBuildingRequest request}}.
Therefore, even though the request contains the list of active profile IDs, the
profile corresponding to the ID cannot be found.
The issue can be fixed by copying the profiles in
{{DefaultMavenProjectBuilder.injectSession}}.
{noformat}
diff --git
a/maven-compat/src/main/java/org/apache/maven/project/DefaultMavenProjectBuilder.java
b/maven-compat/src/main
index fff2de1..fdb18ec 100644
---
a/maven-compat/src/main/java/org/apache/maven/project/DefaultMavenProjectBuilder.java
+++
b/maven-compat/src/main/java/org/apache/maven/project/DefaultMavenProjectBuilder.java
@@ -124,6 +124,7 @@ public class DefaultMavenProjectBuilder
if ( req != null )
{
request.setRemoteRepositories( req.getRemoteRepositories() );
+request.setProfiles(req.getProfiles());
}
}
else
{noformat}
This fixes the issue with site creation for me. However, I am not sure if this
change does not break other things. Could someone experienced with this part of
the Maven core have a look at it?
> Maven searches only central repository for imported dependencies
>
>
> Key: MSITE-640
> URL: https://jira.codehaus.org/browse/MSITE-640
> Project: Maven 2.x and 3.x Site Plugin
> Issue Type: Bug
> Components: Maven 3
>Affects Versions: 3.0
> Environment: Windows 7
>Reporter: Markus Tippmann
> Attachments: stacktrace.txt
>
>
> We are using dependencyManagement with "import" scope like described here:
> http://maven.apache.org/guides/introduction/introduction-to-dependency-mechanism.html#Importing_Dependencies
> Problem occurs only at site generation, not at build time, where it works
> perfectly.
> The site plugin tries to find the imported artifacts, but searches only the
> central repository and ignores the repositories in settings.xml
> configuration. Mirror settings work, if "central" is mirrored, but
> dependencies need to be resolved from two repositories, so one mirror does
> not help here.
> I try to attach the relevant parts of the stacktrace.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] (SCM-709) REGRESSION: git status doesn't work if repository root is not the working directory
[
https://jira.codehaus.org/browse/SCM-709?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=325425#comment-325425
]
Michael Koch commented on SCM-709:
--
Thanks for taking the time to look at this. I think that even with your fix
there is still a problem where the {{Git*Command}} classes calculate the
{{relativeRepositoryPath}} if the repository root path (i. e. the output of
{{git rev-parse --show-toplevel}}) contains spaces.
> REGRESSION: git status doesn't work if repository root is not the working
> directory
> ---
>
> Key: SCM-709
> URL: https://jira.codehaus.org/browse/SCM-709
> Project: Maven SCM
> Issue Type: Bug
> Components: maven-scm-provider-git
>Affects Versions: 1.8, 1.8.1
>Reporter: Robert Scholte
>Assignee: Robert Scholte
>Priority: Blocker
> Attachments:
> 0001-use-new-File-.toURI-to-fix-handling-of-paths-with-sp.patch
>
>
> SCM-686 introduced the {{--porcelain}} option to make the {{status}} result
> language independend.
> Without the {{--porcelain}} option files were listed relative to the working
> directory, but with {{--porcelain}} files are listed relative to the
> repository root. In most cases these are the same, but not always.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] (SCM-709) REGRESSION: git status doesn't work if repository root is not the working directory
[
https://jira.codehaus.org/browse/SCM-709?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=325248#comment-325248
]
Michael Koch commented on SCM-709:
--
I just found out that {{URI.create}} generally does not work as intended
because it does not create a {{file:}} URL. Therefore
{{URI.create( stdout.getOutput().trim() ).relativize(
fileSet.getBasedir().toURI() )}}
does not create a relative URL and the {{git status}} command fails. You can
test this if in {{GitStatusCommandTest.testResolvePath()}} you change
{{URI path = repositoryRoot.toURI().relativize( workingDirectory.toURI() );}}
to
{{URI path =
URI.create(repositoryRoot.getAbsolutePath()).relativize(workingDirectory.toURI());}}.
> REGRESSION: git status doesn't work if repository root is not the working
> directory
> ---
>
> Key: SCM-709
> URL: https://jira.codehaus.org/browse/SCM-709
> Project: Maven SCM
> Issue Type: Bug
> Components: maven-scm-provider-git
>Affects Versions: 1.8, 1.8.1
>Reporter: Robert Scholte
>Assignee: Robert Scholte
>Priority: Blocker
> Attachments:
> 0001-use-new-File-.toURI-to-fix-handling-of-paths-with-sp.patch
>
>
> SCM-686 introduced the {{--porcelain}} option to make the {{status}} result
> language independend.
> Without the {{--porcelain}} option files were listed relative to the working
> directory, but with {{--porcelain}} files are listed relative to the
> repository root. In most cases these are the same, but not always.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] (SCM-709) REGRESSION: git status doesn't work if repository root is not the working directory
[
https://jira.codehaus.org/browse/SCM-709?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Koch updated SCM-709:
-
Attachment: 0001-use-new-File-.toURI-to-fix-handling-of-paths-with-sp.patch
The current 1.9-SNAPSHOT fails in {{GitStatusCommand.executeStatusCommand}}
line 68 if there are spaces in the directory path.
{noformat}
[ERROR] Failed to execute goal
org.apache.maven.plugins:maven-release-plugin:2.4.1:prepare (default-cli) on
project codequality: An error occurred during the status check process:
Exception while executing SCM command. Illegal character in path at index 29:
/home/michael/Projekte/JGloss Test -> [Help 1]
org.apache.maven.lifecycle.LifecycleExecutionException: Failed to execute goal
org.apache.maven.plugins:maven-release-plugin:2.4.1:prepare (default-cli) on
project codequality: An error occurred during the status check process:
Exception while executing SCM command.
at
org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:217)
[snip]
Caused by: java.lang.IllegalArgumentException: Illegal character in path at
index 29: /home/michael/Projekte/JGloss Test
at java.net.URI.create(URI.java:859)
at
org.apache.maven.scm.provider.git.gitexe.command.status.GitStatusCommand.executeStatusCommand(GitStatusCommand.java:68)
at
org.apache.maven.scm.command.status.AbstractStatusCommand.executeCommand(AbstractStatusCommand.java:44)
at
org.apache.maven.scm.command.AbstractCommand.execute(AbstractCommand.java:59)
... 31 more
Caused by: java.net.URISyntaxException: Illegal character in path at index 29:
/home/michael/Projekte/JGloss Test
at java.net.URI$Parser.fail(URI.java:2829)
{noformat}
This is because {{URI.create}} does not handle spaces. Using {{new
File(path).toURI()}} instead fixes this bug. The {{GitAddCommand}} and
{{GitCheckInCommand}} should also be affected, though I haven't tested it. I've
attached a patch which fixes all occurrences.
> REGRESSION: git status doesn't work if repository root is not the working
> directory
> ---
>
> Key: SCM-709
> URL: https://jira.codehaus.org/browse/SCM-709
> Project: Maven SCM
> Issue Type: Bug
> Components: maven-scm-provider-git
>Affects Versions: 1.8, 1.8.1
>Reporter: Robert Scholte
>Assignee: Robert Scholte
>Priority: Blocker
> Attachments:
> 0001-use-new-File-.toURI-to-fix-handling-of-paths-with-sp.patch
>
>
> SCM-686 introduced the {{--porcelain}} option to make the {{status}} result
> language independend.
> Without the {{--porcelain}} option files were listed relative to the working
> directory, but with {{--porcelain}} files are listed relative to the
> repository root. In most cases these are the same, but not always.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] (MSKINS-77) Add Github ribbon for maven-skins to fluido site
[ https://jira.codehaus.org/browse/MSKINS-77?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=320240#comment-320240 ] Michael Koch commented on MSKINS-77: I've created a pull request which implements this: https://github.com/apache/maven-skins/pull/2 By the way, is this the right way to do this or would you prefer patches against SVN? (It's the first time I've ever used Github pull requests.) > Add Github ribbon for maven-skins to fluido site > > > Key: MSKINS-77 > URL: https://jira.codehaus.org/browse/MSKINS-77 > Project: Maven Skins > Issue Type: Improvement > Components: Fluido Skin >Reporter: Michael Koch >Priority: Minor > > The maven-skins scm report shows the svn repository location. However, there > is also a mirror on Github at http://github.com/apache/maven-skins/. Since > maven-fluido-skin supports adding a Github ribbon, one pointing to > maven-skins could be added to the maven-fluido-skin site itself. > (I didn't find out about the Github mirror until after messing with git svn > for preparing my last patches.) -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://jira.codehaus.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] (MSKINS-77) Add Github ribbon for maven-skins to fluido site
Michael Koch created MSKINS-77: -- Summary: Add Github ribbon for maven-skins to fluido site Key: MSKINS-77 URL: https://jira.codehaus.org/browse/MSKINS-77 Project: Maven Skins Issue Type: Improvement Components: Fluido Skin Reporter: Michael Koch Priority: Minor The maven-skins scm report shows the svn repository location. However, there is also a mirror on Github at http://github.com/apache/maven-skins/. Since maven-fluido-skin supports adding a Github ribbon, one pointing to maven-skins could be added to the maven-fluido-skin site itself. (I didn't find out about the Github mirror until after messing with git svn for preparing my last patches.) -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://jira.codehaus.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] (MSKINS-76) Add Flattr button integration to Fluido skin
[ https://jira.codehaus.org/browse/MSKINS-76?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Koch updated MSKINS-76: --- Attachment: mskins-76.patch Added patch which adds Flattr button integration. Patch against http://svn.apache.org/repos/asf/maven/skins/trunk/maven-fluido-skin rev 1448780 The patch also adds my e-mail address to the contributors section. > Add Flattr button integration to Fluido skin > > > Key: MSKINS-76 > URL: https://jira.codehaus.org/browse/MSKINS-76 > Project: Maven Skins > Issue Type: New Feature > Components: Fluido Skin >Reporter: Michael Koch >Priority: Minor > Attachments: mskins-76.patch > > > [Flattr|https://flattr.com/about] is a social micro-payment service. The > Flattr button works similar to the Google+ button. I'd like to have support > for adding a Flattr button in the Fluido skin. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://jira.codehaus.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] (MSKINS-76) Add Flattr button integration to Fluido skin
[ https://jira.codehaus.org/browse/MSKINS-76?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=320010#comment-320010 ] Michael Koch commented on MSKINS-76: I am currently working on a patch for this and should have it ready in a few days. I'll attach it then. > Add Flattr button integration to Fluido skin > > > Key: MSKINS-76 > URL: https://jira.codehaus.org/browse/MSKINS-76 > Project: Maven Skins > Issue Type: New Feature > Components: Fluido Skin >Reporter: Michael Koch >Priority: Minor > > [Flattr|https://flattr.com/about] is a social micro-payment service. The > Flattr button works similar to the Google+ button. I'd like to have support > for adding a Flattr button in the Fluido skin. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://jira.codehaus.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] (MSKINS-76) Add Flattr button integration to Fluido skin
Michael Koch created MSKINS-76: -- Summary: Add Flattr button integration to Fluido skin Key: MSKINS-76 URL: https://jira.codehaus.org/browse/MSKINS-76 Project: Maven Skins Issue Type: New Feature Components: Fluido Skin Reporter: Michael Koch Priority: Minor [Flattr|https://flattr.com/about] is a social micro-payment service. The Flattr button works similar to the Google+ button. I'd like to have support for adding a Flattr button in the Fluido skin. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://jira.codehaus.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] (MSKINS-75) Add Piwik web analytics tracking code integration to Fluido skin
[ https://jira.codehaus.org/browse/MSKINS-75?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=320008#comment-320008 ] Michael Koch commented on MSKINS-75: Thanks for accepting my patch. Please note that I wrote _"Since version <<1.4>>..."_ in _index.apt.vm_. You might want to change this if you release this in 1.3.1. > Add Piwik web analytics tracking code integration to Fluido skin > > > Key: MSKINS-75 > URL: https://jira.codehaus.org/browse/MSKINS-75 > Project: Maven Skins > Issue Type: New Feature > Components: Fluido Skin >Reporter: Michael Koch >Assignee: Olivier Lamy >Priority: Minor > Fix For: fluido-1.3.1 > > Attachments: mskins-75.patch > > > I'd like to have support for adding the [Piwik web > analytics|http://piwik.org/] [tracking > code|http://piwik.org/docs/javascript-tracking/#toc-where-can-i-find-the-piwik-tracking-code] > for the Fluido skin. This is similar to the Google analytics code or > MSKINS-33. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://jira.codehaus.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] (MSKINS-75) Add Piwik web analytics tracking code integration to Fluido skin
[ https://jira.codehaus.org/browse/MSKINS-75?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Koch updated MSKINS-75: --- Attachment: mskins-75.patch Added patch which adds Piwi tracking code integration to Fluido skin. * add support in site.vm * add documentation in index.apt.vm * add integration test I've tested the patch with http://svn.apache.org/repos/asf/maven/skins/trunk/maven-fluido-skin rev 1447032. > Add Piwik web analytics tracking code integration to Fluido skin > > > Key: MSKINS-75 > URL: https://jira.codehaus.org/browse/MSKINS-75 > Project: Maven Skins > Issue Type: New Feature > Components: Fluido Skin >Reporter: Michael Koch >Priority: Minor > Attachments: mskins-75.patch > > > I'd like to have support for adding the [Piwik web > analytics|http://piwik.org/] [tracking > code|http://piwik.org/docs/javascript-tracking/#toc-where-can-i-find-the-piwik-tracking-code] > for the Fluido skin. This is similar to the Google analytics code or > MSKINS-33. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://jira.codehaus.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] (MSKINS-75) Add Piwik web analytics tracking code integration to Fluido skin
[ https://jira.codehaus.org/browse/MSKINS-75?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=319840#comment-319840 ] Michael Koch commented on MSKINS-75: I am currently working on a patch for this and will attach it when it's ready. > Add Piwik web analytics tracking code integration to Fluido skin > > > Key: MSKINS-75 > URL: https://jira.codehaus.org/browse/MSKINS-75 > Project: Maven Skins > Issue Type: New Feature > Components: Fluido Skin >Reporter: Michael Koch >Priority: Minor > > I'd like to have support for adding the [Piwik web > analytics|http://piwik.org/] [tracking > code|http://piwik.org/docs/javascript-tracking/#toc-where-can-i-find-the-piwik-tracking-code] > for the Fluido skin. This is similar to the Google analytics code or > MSKINS-33. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://jira.codehaus.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] (MSKINS-75) Add Piwik web analytics tracking code integration to Fluido skin
Michael Koch created MSKINS-75: -- Summary: Add Piwik web analytics tracking code integration to Fluido skin Key: MSKINS-75 URL: https://jira.codehaus.org/browse/MSKINS-75 Project: Maven Skins Issue Type: New Feature Components: Fluido Skin Reporter: Michael Koch Priority: Minor I'd like to have support for adding the [Piwik web analytics|http://piwik.org/] [tracking code|http://piwik.org/docs/javascript-tracking/#toc-where-can-i-find-the-piwik-tracking-code] for the Fluido skin. This is similar to the Google analytics code or MSKINS-33. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://jira.codehaus.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] (WAGON-354) Site deployment always fails with StringIndexOutOfBoundsException in SftpWagon
[
https://jira.codehaus.org/browse/WAGON-354?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Koch updated WAGON-354:
---
Attachment: 0001-WAGON-354-Site-deployment-always-fails-with-StringIn.patch
I agree with Juergens analysis and conclusion that {{SftpWagon.putDirectory}}
should not fail if the {{destinationDirectory}} ends with a {{"/"}}. I've
attached a patch which changes {{ScpHelper.getResourceFilename}} to return a
{{"."}} instead of {{""}} if the resource path ends with a {{"/"}}. This fixes
the site deployment for me.
> Site deployment always fails with StringIndexOutOfBoundsException in SftpWagon
> --
>
> Key: WAGON-354
> URL: https://jira.codehaus.org/browse/WAGON-354
> Project: Maven Wagon
> Issue Type: Bug
> Components: wagon-ssh
>Affects Versions: 1.0, 2.0
> Environment: Maven 3.0.3, Site-Plugin 3.0, Wagon 2.0
>Reporter: Juergen Kellerer
>Priority: Critical
> Fix For: backlog
>
> Attachments:
> 0001-WAGON-354-Site-deployment-always-fails-with-StringIn.patch
>
>
> I always get StringIndexOutOfBoundsException on the attempt to deploy a site
> with SFTP using Maven 3 + Site Plugin 3.
> Calling *"mvn site-deploy"* causes:
> {noformat}
> ...
> Caused by: org.apache.maven.plugin.MojoExecutionException: Error uploading
> site
> at
> org.apache.maven.plugins.site.AbstractDeployMojo.push(AbstractDeployMojo.java:464)
> at
> org.apache.maven.plugins.site.AbstractDeployMojo.deploy(AbstractDeployMojo.java:296)
> at
> org.apache.maven.plugins.site.AbstractDeployMojo.deployTo(AbstractDeployMojo.java:257)
> at
> org.apache.maven.plugins.site.AbstractDeployMojo.execute(AbstractDeployMojo.java:165)
> at
> org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo(DefaultBuildPluginManager.java:101)
> at
> org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:209)
> ... 19 more
> Caused by: org.apache.maven.wagon.TransferFailedException: Error occurred
> while deploying 'c:\Projects\OS\doxia-include\target\site' to remo
> te repository:
> sftp://web.sourceforge.net/home/groups/d/do/doxia-include/htdocs/:
> at
> org.apache.maven.wagon.providers.ssh.jsch.SftpWagon.putDirectory(SftpWagon.java:286)
> at
> org.apache.maven.plugins.site.AbstractDeployMojo.push(AbstractDeployMojo.java:447)
> ... 24 more
> Caused by: 4:
> at com.jcraft.jsch.ChannelSftp.mkdir(ChannelSftp.java:1713)
> at
> org.apache.maven.wagon.providers.ssh.jsch.SftpWagon.mkdir(SftpWagon.java:204)
> at
> org.apache.maven.wagon.providers.ssh.jsch.SftpWagon.ftpRecursivePut(SftpWagon.java:300)
> at
> org.apache.maven.wagon.providers.ssh.jsch.SftpWagon.putDirectory(SftpWagon.java:277)
> ... 25 more
> Caused by: java.lang.StringIndexOutOfBoundsException: String index out of
> range: 0
> at java.lang.String.charAt(String.java:686)
> at
> com.jcraft.jsch.ChannelSftp.remoteAbsolutePath(ChannelSftp.java:2367)
> at com.jcraft.jsch.ChannelSftp.mkdir(ChannelSftp.java:1691)
> ... 28 more
> {noformat}
> *The configuration is*:
> {code:xml}
>
> doxia-include
>
>
>
> ${application.id}.shell.sourceforge.net
> ${application.id}.shell.sourceforge.net
>
> sftp://web.sourceforge.net/home/groups/d/do/${application.id}/htdocs
>
> {code}
> (Btw. I tried variuous urls, "../htdocs", "../htdocs/" and "../htdocs/." but
> the site plugin always normalizes them to "../htdocs/", which is actually the
> right thing to do.)
> *My assumption why it happens:*
> I looked at the sources of wagon (particularly to the methods mentioned in
> the stack trace), and I think the issue seems to be that:
> - Site Plugin 3 always normalizes the remote directory to end with a trailing
> slash.
> - WagonSftp.putDirectory:277 calls ScpHelper.getResourceFilename(
> destinationDirectory ) on this directory which returns an empty string.
> - WagonSfto.ftpRecursivePut:300 calls mkdir with an empty string which causes
> the exception.
> Actually it looks as if older site plugins added a trailing "/." to the path
> instead of just "/" as otherwise it would have been broken before (I did not
> verify this). Nevertheless I think the bug is in the Wagon implementation as
> it should not fail if the destination is given like this.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://jira.codehaus.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (MSITE-417) CLONE -The modules menu is not inherited if the parent project has no modules of its own
[ http://jira.codehaus.org/browse/MSITE-417?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=212120#action_212120 ] Michael Koch commented on MSITE-417: If you remove parent/pom.xml from the main project pom of the attached testcase, running 'mvn site' will generate a site without module references. > CLONE -The modules menu is not inherited if the parent project has no modules > of its own > > > Key: MSITE-417 > URL: http://jira.codehaus.org/browse/MSITE-417 > Project: Maven 2.x Site Plugin > Issue Type: Bug > Components: inheritance >Affects Versions: 2.0 > Environment: ubuntu linux / debian linux >Reporter: Lukas Theussl >Assignee: Lukas Theussl > Attachments: MSITE-417.zip > > > if I have a site.xml in a parent project that contains the line ref="modules" inherit="top" /> it is not inherited by child projects. > works, as does parent. > This happens when the parent project has no modules of its own. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (SCM-334) Faulty svn commandline is generated for passwords containing special chars
[ http://jira.codehaus.org/browse/SCM-334?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=138163#action_138163 ] Michael Koch commented on SCM-334: -- The class org.codehaus.plexus.util.cli.Commandline, which is used by SvnCommandLineUtils, has a method quoteArgument which could be used for this. > Faulty svn commandline is generated for passwords containing special chars > -- > > Key: SCM-334 > URL: http://jira.codehaus.org/browse/SCM-334 > Project: Maven SCM > Issue Type: Bug > Components: maven-scm-provider-svn >Affects Versions: 1.0 > Environment: All >Reporter: Jan Lisse >Priority: Critical > Attachments: patch.txt > > > If i use a svn password containing a semicolon with the > maven-scm-provider-svnexe, the commandline generated by SvnCommandlineUtils > is faulty, because > the password is not quoted. Passwords containing other special chars might > cause problems too. > Solution: Enclosing the password for the commandline in single quotes solves > this problem. > I have attached a patch for SvnCommandlineUtils that fixes this issue. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (SCM-334) Faulty svn commandline is generated for passwords containing special chars
[ http://jira.codehaus.org/browse/SCM-334?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=138160#action_138160 ] Michael Koch commented on SCM-334: -- Single quoting the whole password is easier that checking for special chars and quoting them individually. Nevertheless, as you probably assumed, any single quotes in the password will still need to be quoted. I guess that this problem also applies to the user name. Perhaps all arguments should be quoted to be on the safe side. > Faulty svn commandline is generated for passwords containing special chars > -- > > Key: SCM-334 > URL: http://jira.codehaus.org/browse/SCM-334 > Project: Maven SCM > Issue Type: Bug > Components: maven-scm-provider-svn >Affects Versions: 1.0 > Environment: All >Reporter: Jan Lisse >Priority: Critical > Attachments: patch.txt > > > If i use a svn password containing a semicolon with the > maven-scm-provider-svnexe, the commandline generated by SvnCommandlineUtils > is faulty, because > the password is not quoted. Passwords containing other special chars might > cause problems too. > Solution: Enclosing the password for the commandline in single quotes solves > this problem. > I have attached a patch for SvnCommandlineUtils that fixes this issue. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
