[jira] Commented: (MRELEASE-303) Resolved SNAPSHOT versions are overwritten
[
http://jira.codehaus.org/browse/MRELEASE-303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=172430#action_172430
]
Noel Keating commented on MRELEASE-303:
---
I have added a patch to MRELEASE-317 that corrects the problem outlined by
Joerg Schaible above.
> Resolved SNAPSHOT versions are overwritten
> --
>
> Key: MRELEASE-303
> URL: http://jira.codehaus.org/browse/MRELEASE-303
> Project: Maven 2.x Release Plugin
> Issue Type: Bug
> Components: prepare
>Affects Versions: 2.0-beta-8
>Reporter: Jean-Philippe Steck
>
> When running release:prepare on a parent-child projet, I'm asked to resolved
> the SNAPSHOT version but some of my answers are ignored.
> Cause is :
> In this method : CheckDependencySnapshotsPhase.resolveSnapshots
> Lig 367 : releaseDescriptor.setResolvedSnapshotDependencies(
> resolvedSnapshots );
> This line overwrite the map of resolved snapshot of the releaseDescriptor :
> The newly resolved informations should be added to the existing map.
> It should be smthg like :
> for (resolvedSnapshots ) {
> if (! eleaseDescriptor.getResolvedSnapshotDependencies().contains(key))
>
> releaseDescriptor.getResolvedSnapshotDependencies().put(resolvedSnapshots.key,
> resolvedSnapshots .value)
> }
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (MRELEASE-317) release:prepare should fail if any pom depends on SNAPSHOT parent
[ http://jira.codehaus.org/browse/MRELEASE-317?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Noel Keating updated MRELEASE-317: -- Attachment: MRELEASE-317.patch.txt This patch adds code to check the resolvedSnapshotDependencies in AbstractRewritePomsPhase.rewriteParent(...), (plus a test case) > release:prepare should fail if any pom depends on SNAPSHOT parent > - > > Key: MRELEASE-317 > URL: http://jira.codehaus.org/browse/MRELEASE-317 > Project: Maven 2.x Release Plugin > Issue Type: Bug > Components: prepare > Environment: maven-2.0.8 > java-1.6 >Reporter: Petr Kozelka >Priority: Critical > Attachments: MRELEASE-317.patch.txt > > > Currently the release plugin happily releases a pom that declares a SNAPSHOT > version of parent. > Such a release is exposed to a danger of irreproducibility: > 1.) on another machine > 2.) at another time (parent may significantly change in the meantime) > While it can be sometimes convenient, it is, as I am quite sure, a bad > behavior. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (MRELEASE-317) release:prepare should fail if any pom depends on SNAPSHOT parent
[ http://jira.codehaus.org/browse/MRELEASE-317?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=172207#action_172207 ] Noel Keating commented on MRELEASE-317: --- It seems that the CheckDependencySnapshotsPhase includes the parent artifact as part of it check, but the RewritePomPhases (AbstractRewritePomsPhase.rewriteParent) does not consider the resolvedSnapshotDependencies when transforming the pom file. So even though you are asked to set the parent to released, a SNAPSHOT parent is committed. > release:prepare should fail if any pom depends on SNAPSHOT parent > - > > Key: MRELEASE-317 > URL: http://jira.codehaus.org/browse/MRELEASE-317 > Project: Maven 2.x Release Plugin > Issue Type: Bug > Components: prepare > Environment: maven-2.0.8 > java-1.6 >Reporter: Petr Kozelka >Priority: Critical > > Currently the release plugin happily releases a pom that declares a SNAPSHOT > version of parent. > Such a release is exposed to a danger of irreproducibility: > 1.) on another machine > 2.) at another time (parent may significantly change in the meantime) > While it can be sometimes convenient, it is, as I am quite sure, a bad > behavior. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
