[jira] [Created] (MPATCH-22) Patching fails if target path contains "fail", "skip" or "reject"
Oleg Rekutin created MPATCH-22:
--
Summary: Patching fails if target path contains "fail", "skip" or
"reject"
Key: MPATCH-22
URL: https://issues.apache.org/jira/browse/MPATCH-22
Project: Maven Patch Plugin
Issue Type: Bug
Affects Versions: 1.2
Reporter: Oleg Rekutin
Default failure match phrases 'fail', 'skip' and 'reject' are way too broad. If
they appear anywhere in the path of the target file being patched, then the
plugin execution will fail with:
{code}
Failed to apply patches (detected watch-phrase: 'fail' in output). If this is
in error, configure the patchFailureWatchPhrases parameter.
{code}
One can get into this situation in a typical CI environment by creating a
branch with 'fail' in the name.
To reproduce, clone maven-patch-plugin repo to a directory with fail in the
name and run the ITs: mvn verify -P run-its
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] (SUREFIRE-877) Surefire doesn't support mixed TestNG 6.5.x config parameter
Oleg Rekutin created SUREFIRE-877: - Summary: Surefire doesn't support mixed TestNG 6.5.x config parameter Key: SUREFIRE-877 URL: https://jira.codehaus.org/browse/SUREFIRE-877 Project: Maven Surefire Issue Type: Bug Components: TestNG support Affects Versions: 2.12 Reporter: Oleg Rekutin Priority: Minor Specifying: property namemixed/name valuetrue/value /property causes org.apache.maven.surefire.util.SurefireReflectionException: java.lang.reflect.InvocationTargetException; nested exception is java.lang.reflect.InvocationTargetException: null java.lang.reflect.InvocationTargetException at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25) at java.lang.reflect.Method.invoke(Method.java:597) at org.apache.maven.surefire.util.ReflectionUtils.invokeMethodWithArray(ReflectionUtils.java:189) at org.apache.maven.surefire.booter.ProviderFactory$ProviderProxy.invoke(ProviderFactory.java:165) at org.apache.maven.surefire.booter.ProviderFactory.invokeProvider(ProviderFactory.java:85) at org.apache.maven.surefire.booter.ForkedBooter.runSuitesInProcess(ForkedBooter.java:103) at org.apache.maven.surefire.booter.ForkedBooter.main(ForkedBooter.java:74) Caused by: java.lang.ClassCastException: java.lang.String cannot be cast to java.lang.Boolean at org.testng.TestNG.configure(TestNG.java:1522) at org.apache.maven.surefire.testng.conf.TestNGMapConfigurator.configure(TestNGMapConfigurator.java:95) at org.apache.maven.surefire.testng.TestNGExecutor.run(TestNGExecutor.java:73) at org.apache.maven.surefire.testng.TestNGDirectoryTestSuite.executeMulti(TestNGDirectoryTestSuite.java:161) at org.apache.maven.surefire.testng.TestNGDirectoryTestSuite.execute(TestNGDirectoryTestSuite.java:101) at org.apache.maven.surefire.testng.TestNGProvider.invoke(TestNGProvider.java:115) ... 9 more -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://jira.codehaus.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Created: (MENFORCER-113) enforce goal should require dependency collection, not resolution
enforce goal should require dependency collection, not resolution - Key: MENFORCER-113 URL: http://jira.codehaus.org/browse/MENFORCER-113 Project: Maven 2.x Enforcer Plugin Issue Type: Bug Components: Plugin Affects Versions: 1.0 Reporter: Oleg Rekutin Enforce goal presently has @requiresDependencyResolution(test), which forces all dependencies to be downloaded for a project at the start of the lifecycle (e.g. if the plugin is bounded to initialize). If a project has really large dependencies that are resolved on an as-needed basis (e.g. by the assembly plugin), inserting the enforcer plugin (e.g. to enforce certain properties being set) causes everything to be downloaded. The goal should use the new Maven 3.0 requiresDependencyCollection annotation, which should be sufficient for all existing rules (banned dependencies and such). Any investigation of the contents of the dependencies themselves should be an on-demand resolve by the enforcer. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (MENFORCER-113) enforce goal should require dependency collection, not resolution
[ http://jira.codehaus.org/browse/MENFORCER-113?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Oleg Rekutin updated MENFORCER-113: --- Attachment: menforcer113.patch 1-line patch against EnforcerMojo.java. Tested locally, but no integration test written. enforce goal should require dependency collection, not resolution - Key: MENFORCER-113 URL: http://jira.codehaus.org/browse/MENFORCER-113 Project: Maven 2.x Enforcer Plugin Issue Type: Bug Components: Plugin Affects Versions: 1.0 Reporter: Oleg Rekutin Attachments: menforcer113.patch Enforce goal presently has @requiresDependencyResolution(test), which forces all dependencies to be downloaded for a project at the start of the lifecycle (e.g. if the plugin is bounded to initialize). If a project has really large dependencies that are resolved on an as-needed basis (e.g. by the assembly plugin), inserting the enforcer plugin (e.g. to enforce certain properties being set) causes everything to be downloaded. The goal should use the new Maven 3.0 requiresDependencyCollection annotation, which should be sufficient for all existing rules (banned dependencies and such). Any investigation of the contents of the dependencies themselves should be an on-demand resolve by the enforcer. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
