[jira] [Comment Edited] (ARCHETYPE-552) Erroneous Inheritance Cycle Generated By Archetype Plugin

2019-10-02 Thread Scott MacDonald (Jira)


[ 
https://issues.apache.org/jira/browse/ARCHETYPE-552?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16943200#comment-16943200
 ] 

Scott MacDonald edited comment on ARCHETYPE-552 at 10/2/19 10:11 PM:
-

Just ran into this exact  issue on maven 3.6.2 with the  bundled archetype 
plugin, and it also occurs  on latest 3.2.1 archetype  plugin.  Came here to 
log a bug and and submit a minimal reproducible case, but low and behold, 
somebody already did...me!! hah! over a year ago!!  Well that saves me little 
time (not as much as if I remembered I did that 2 hours ago...ha) .

 

Anyway, sure hope somebody can fix this cuz  using a sibling parent with an 
aggregator pom that inherits from it is a pretty nice pattern. Many people 
separate aggregation and inheritance this way.  I've use this pattern on 
hundreds of projects and it work well.   I just can't generate working 
templated projects for them with the archetype plugin.  

A none ideal workaround is to break the inheritance from the aggregator to the 
parent, and then  specify  version in the aggregator, which isn't ideal  cuz 
DRYand I also have call versions:set twice to change them (once on 
aggregator, once on parent).   Not a huge deal, but it would be wonderful if it 
archetype didn;t  erroneously add the inheritance  cycle in the first place.

 

 


was (Author: scanguskhan):
Just ran into this exact  issue on maven 3.6.2 with the  bundled archetype 
plugin, and it also occurs  on latest 3.2.1 archetype  plugin.  Came here to 
log a bug and and submit a minimal reproducible case, but low and behold, 
somebody already did...me!! hah! over a year ago!!  Well that saves me little 
time (not as much as if I remembered I did that 2 hours ago...ha) .

 

Anyway, sure hope somebody can fix this cuz  using a sibling parent with an 
aggregator pom that inherits from it is pretty nice pattern. (man people 
separate aggregation and inheritance this way)   I've use this pattern on 
hundreds of projects. .   I just can't generate working templated projects for 
therm with the archetype plugin.  

A none ideal workaround is to break the inheritance from the aggregator to the 
parent, and then  specify  version in the aggregator, which isn't ideal  cuz 
DRYand I also have call versions:set twice to change them (once on 
aggregator, once on parent).   Not a huge deal, but it would be wonderful if it 
archetype didn;t  erroneously add the inheritance  cycle in the first place.

 

 

> Erroneous Inheritance Cycle Generated By Archetype Plugin
> -
>
> Key: ARCHETYPE-552
> URL: https://issues.apache.org/jira/browse/ARCHETYPE-552
> Project: Maven Archetype
>  Issue Type: Bug
>  Components: Plugin
>Affects Versions: 3.0.1
>Reporter: Scott MacDonald
>Priority: Major
> Attachments: maven-archetype-parent-cycle-bug.zip
>
>
> When developing a multi module archetype with a root level aggregator pom 
> which inherits from a sibling parent within the project,  the archetype 
> generated project will incorrectly add the aggregator pom as a parent in the 
> sibling parent pom file, causing an inheritance cycle in the generated 
> project.
> Attached is a zip file containing a minimal archetype project that 
> demonstrates the behavior.
> After running mvn install,   you can inspect 
> target/test-classes/projects/it-basic/project/example-project/example-project-parent/pom.xml
>   and see that the generated project incorrectly adds the top-level aggregate 
> pom  as a parent in the parent pom causing an inheritance cycle, even though 
> such a parent designation is  not specified in the archetype resources.
>  
> The exact element that is incorrectly added to 
> target/test-classes/projects/it-basic/project/example-project/example-project-parent/pom.xml
>  is below..
>     
>      example-project-aggregator
>      com.foo
>      0.0.0
>    
>  
> After the failure, removing the  incorrect parent pom element from the  
> target/test-classes/projects/it-basic/project/example-project/example-project-parent/pom.xml
>  results in a working  maven project. 
>  
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Comment Edited] (ARCHETYPE-552) Erroneous Inheritance Cycle Generated By Archetype Plugin

2019-10-02 Thread Scott MacDonald (Jira)


[ 
https://issues.apache.org/jira/browse/ARCHETYPE-552?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16943200#comment-16943200
 ] 

Scott MacDonald edited comment on ARCHETYPE-552 at 10/2/19 10:10 PM:
-

Just ran into this exact  issue on maven 3.6.2 with the  bundled archetype 
plugin, and it also occurs  on latest 3.2.1 archetype  plugin.  Came here to 
log a bug and and submit a minimal reproducible case, but low and behold, 
somebody already did...me!! hah! over a year ago!!  Well that saves me little 
time (not as much as if I remembered I did that 2 hours ago...ha) .

 

Anyway, sure hope somebody can fix this cuz  using a sibling parent with an 
aggregator pom that inherits from it is pretty nice pattern. (man people 
separate aggregation and inheritance this way)   I've use this pattern on 
hundreds of projects. .   I just can't generate working templated projects for 
therm with the archetype plugin.  

A none ideal workaround is to break the inheritance from the aggregator to the 
parent, and then  specify  version in the aggregator, which isn't ideal  cuz 
DRYand I also have call versions:set twice to change them (once on 
aggregator, once on parent).   Not a huge deal, but it would be wonderful if it 
archetype didn;t  erroneously add the inheritance  cycle in the first place.

 

 


was (Author: scanguskhan):
Just ran into this exact  issue on maven 3.6.2 with the  bundled archetype 
plugin, and it also occurs  on latest 3.2.1 archetype  plugin.  Came here to 
log a bug and and submit a minimal reproducible case, but low and behold, 
somebody already did...me!! hah! over a year ago!!  Well that saves me little 
time (not as much as if I remembered I did that 2 hours ago...ha) .

 

Anyway, sure hope somebody can fix this cuz  using a sibling parent with an 
aggregator pom that inherits from it is pretty nice pattern. (man people 
separate aggregation and inheritance this way)   I've use this pattern on 
hundreds of projects. .   I just can't generate working templated projects for 
therm with the archetype plugin.  

A none ideal workaround is to break the inheritance from the aggregator to the 
parent, and then  specify  version in the aggregator, which isn't ideal  cuz 
DRYand I also have call versions:set twice to change them (once on 
aggregator, once on parent).   Not a huge deal, but it would be wonderful if it 
archetype didn;t  erroneously add the inheritance  cycle in the first.

 

 

> Erroneous Inheritance Cycle Generated By Archetype Plugin
> -
>
> Key: ARCHETYPE-552
> URL: https://issues.apache.org/jira/browse/ARCHETYPE-552
> Project: Maven Archetype
>  Issue Type: Bug
>  Components: Plugin
>Affects Versions: 3.0.1
>Reporter: Scott MacDonald
>Priority: Major
> Attachments: maven-archetype-parent-cycle-bug.zip
>
>
> When developing a multi module archetype with a root level aggregator pom 
> which inherits from a sibling parent within the project,  the archetype 
> generated project will incorrectly add the aggregator pom as a parent in the 
> sibling parent pom file, causing an inheritance cycle in the generated 
> project.
> Attached is a zip file containing a minimal archetype project that 
> demonstrates the behavior.
> After running mvn install,   you can inspect 
> target/test-classes/projects/it-basic/project/example-project/example-project-parent/pom.xml
>   and see that the generated project incorrectly adds the top-level aggregate 
> pom  as a parent in the parent pom causing an inheritance cycle, even though 
> such a parent designation is  not specified in the archetype resources.
>  
> The exact element that is incorrectly added to 
> target/test-classes/projects/it-basic/project/example-project/example-project-parent/pom.xml
>  is below..
>     
>      example-project-aggregator
>      com.foo
>      0.0.0
>    
>  
> After the failure, removing the  incorrect parent pom element from the  
> target/test-classes/projects/it-basic/project/example-project/example-project-parent/pom.xml
>  results in a working  maven project. 
>  
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (ARCHETYPE-552) Erroneous Inheritance Cycle Generated By Archetype Plugin

2019-10-02 Thread Scott MacDonald (Jira)


[ 
https://issues.apache.org/jira/browse/ARCHETYPE-552?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16943200#comment-16943200
 ] 

Scott MacDonald commented on ARCHETYPE-552:
---

Just ran into this exact  issue on maven 3.6.2 with the  bundled archetype 
plugin, and it also occurs  on latest 3.2.1 archetype  plugin.  Came here to 
log a bug and and submit a minimal reproducible case, but low and behold, 
somebody already did...me!! hah! over a year ago!!  Well that saves me little 
time (not as much as if I remembered I did that 2 hours ago...ha) .

 

Anyway, sure hope somebody can fix this cuz  using a sibling parent with an 
aggregator pom that inherits from it is pretty nice pattern. (man people 
separate aggregation and inheritance this way)   I've use this pattern on 
hundreds of projects. .   I just can't generate working templated projects for 
therm with the archetype plugin.  

A none ideal workaround is to break the inheritance from the aggregator to the 
parent, and then  specify  version in the aggregator, which isn't ideal  cuz 
DRYand I also have call versions:set twice to change them (once on 
aggregator, once on parent).   Not a huge deal, but it would be wonderful if it 
archetype didn;t  erroneously add the inheritance  cycle in the first.

 

 

> Erroneous Inheritance Cycle Generated By Archetype Plugin
> -
>
> Key: ARCHETYPE-552
> URL: https://issues.apache.org/jira/browse/ARCHETYPE-552
> Project: Maven Archetype
>  Issue Type: Bug
>  Components: Plugin
>Affects Versions: 3.0.1
>Reporter: Scott MacDonald
>Priority: Major
> Attachments: maven-archetype-parent-cycle-bug.zip
>
>
> When developing a multi module archetype with a root level aggregator pom 
> which inherits from a sibling parent within the project,  the archetype 
> generated project will incorrectly add the aggregator pom as a parent in the 
> sibling parent pom file, causing an inheritance cycle in the generated 
> project.
> Attached is a zip file containing a minimal archetype project that 
> demonstrates the behavior.
> After running mvn install,   you can inspect 
> target/test-classes/projects/it-basic/project/example-project/example-project-parent/pom.xml
>   and see that the generated project incorrectly adds the top-level aggregate 
> pom  as a parent in the parent pom causing an inheritance cycle, even though 
> such a parent designation is  not specified in the archetype resources.
>  
> The exact element that is incorrectly added to 
> target/test-classes/projects/it-basic/project/example-project/example-project-parent/pom.xml
>  is below..
>     
>      example-project-aggregator
>      com.foo
>      0.0.0
>    
>  
> After the failure, removing the  incorrect parent pom element from the  
> target/test-classes/projects/it-basic/project/example-project/example-project-parent/pom.xml
>  results in a working  maven project. 
>  
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (ARCHETYPE-552) Erroneous Inheritance Cycle Generated By Archetype Plugin

2019-10-02 Thread Scott MacDonald (Jira)


 [ 
https://issues.apache.org/jira/browse/ARCHETYPE-552?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Scott MacDonald updated ARCHETYPE-552:
--
Summary: Erroneous Inheritance Cycle Generated By Archetype Plugin  (was: 
Valid Archetype projects  can generate broken projects with inheritance cycle  )

> Erroneous Inheritance Cycle Generated By Archetype Plugin
> -
>
> Key: ARCHETYPE-552
> URL: https://issues.apache.org/jira/browse/ARCHETYPE-552
> Project: Maven Archetype
>  Issue Type: Bug
>  Components: Plugin
>Affects Versions: 3.0.1
>Reporter: Scott MacDonald
>Priority: Major
> Attachments: maven-archetype-parent-cycle-bug.zip
>
>
> When developing a multi module archetype with a root level aggregator pom 
> which inherits from a sibling parent within the project,  the archetype 
> generated project will incorrectly add the aggregator pom as a parent in the 
> sibling parent pom file, causing an inheritance cycle in the generated 
> project.
> Attached is a zip file containing a minimal archetype project that 
> demonstrates the behavior.
> After running mvn install,   you can inspect 
> target/test-classes/projects/it-basic/project/example-project/example-project-parent/pom.xml
>   and see that the generated project incorrectly adds the top-level aggregate 
> pom  as a parent in the parent pom causing an inheritance cycle, even though 
> such a parent designation is  not specified in the archetype resources.
>  
> The exact element that is incorrectly added to 
> target/test-classes/projects/it-basic/project/example-project/example-project-parent/pom.xml
>  is below..
>     
>      example-project-aggregator
>      com.foo
>      0.0.0
>    
>  
> After the failure, removing the  incorrect parent pom element from the  
> target/test-classes/projects/it-basic/project/example-project/example-project-parent/pom.xml
>  results in a working  maven project. 
>  
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (ARCHETYPE-552) Valid Archetype projects can generate broken projects with inheritance cycle

2018-07-25 Thread Scott MacDonald (JIRA)


 [ 
https://issues.apache.org/jira/browse/ARCHETYPE-552?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Scott MacDonald updated ARCHETYPE-552:
--
Description: 
When developing a multi module archetype with a root level aggregator pom which 
inherits from a sibling parent within the project,  the archetype generated 
project will incorrectly add the aggregator pom as a parent in the sibling 
parent pom file, causing an inheritance cycle in the generated project.

Attached is a zip file containing a minimal archetype project that demonstrates 
the behavior.

After running mvn install,   you can inspect 
target/test-classes/projects/it-basic/project/example-project/example-project-parent/pom.xml
  and see that the generated project incorrectly adds the top-level aggregate 
pom  as a parent in the parent pom causing an inheritance cycle, even though 
such a parent designation is  not specified in the archetype resources.

 

The exact element that is incorrectly added to 
target/test-classes/projects/it-basic/project/example-project/example-project-parent/pom.xml
 is below..

    
     example-project-aggregator
     com.foo
     0.0.0
   

 

After the failure, removing the  incorrect parent pom element from the  
target/test-classes/projects/it-basic/project/example-project/example-project-parent/pom.xml
 results in a working  maven project. 

 

 

  was:
When developing a multi module archetype with a root level aggregator pom which 
inherits from a sibling parent within the project,  the archetype generated 
project will incorrectly add the aggregator pom as a parent in the sibling 
parent pom file, causing an inheritance cycle in the generated project.

Attached is a zip file containing a minimal archetype project that demonstrates 
the behavior.

After running mvn install,   you can inspect 
target/test-classes/projects/it-basic/project/example-project/example-project-parent/pom.xml
  and see that the generated project incorrectly adds the top-level aggregate 
pom  as a parent in the parent pom causing an inheritance cycle, even though 
such a parent designation is  specified in the archetype resources.

 

The exact element that is incorrectly added to 
target/test-classes/projects/it-basic/project/example-project/example-project-parent/pom.xml
 is below..

    
     example-project-aggregator
     com.foo
     0.0.0
   

 

After the failure, removing the  incorrect parent pom element from the  
target/test-classes/projects/it-basic/project/example-project/example-project-parent/pom.xml
 results in a working  maven project. 

 

 


> Valid Archetype projects  can generate broken projects with inheritance cycle 
>  
> ---
>
> Key: ARCHETYPE-552
> URL: https://issues.apache.org/jira/browse/ARCHETYPE-552
> Project: Maven Archetype
>  Issue Type: Bug
>  Components: Plugin
>Affects Versions: 3.0.1
>Reporter: Scott MacDonald
>Priority: Major
> Attachments: maven-archetype-parent-cycle-bug.zip
>
>
> When developing a multi module archetype with a root level aggregator pom 
> which inherits from a sibling parent within the project,  the archetype 
> generated project will incorrectly add the aggregator pom as a parent in the 
> sibling parent pom file, causing an inheritance cycle in the generated 
> project.
> Attached is a zip file containing a minimal archetype project that 
> demonstrates the behavior.
> After running mvn install,   you can inspect 
> target/test-classes/projects/it-basic/project/example-project/example-project-parent/pom.xml
>   and see that the generated project incorrectly adds the top-level aggregate 
> pom  as a parent in the parent pom causing an inheritance cycle, even though 
> such a parent designation is  not specified in the archetype resources.
>  
> The exact element that is incorrectly added to 
> target/test-classes/projects/it-basic/project/example-project/example-project-parent/pom.xml
>  is below..
>     
>      example-project-aggregator
>      com.foo
>      0.0.0
>    
>  
> After the failure, removing the  incorrect parent pom element from the  
> target/test-classes/projects/it-basic/project/example-project/example-project-parent/pom.xml
>  results in a working  maven project. 
>  
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (ARCHETYPE-552) Valid Archetype projects can generate broken projects with inheritance cycle

2018-07-25 Thread Scott MacDonald (JIRA)


 [ 
https://issues.apache.org/jira/browse/ARCHETYPE-552?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Scott MacDonald updated ARCHETYPE-552:
--
Description: 
When developing a multi module archetype with a root level aggregator pom which 
inherits from a sibling parent within the project,  the archetype generated 
project will incorrectly add the aggregator pom as a parent in the sibling 
parent pom file, causing an inheritance cycle in the generated project.

Attached is a zip file containing a minimal archetype project that demonstrates 
the behavior.

After running mvn install,   you can inspect 
target/test-classes/projects/it-basic/project/example-project/example-project-parent/pom.xml
  and see that the generated project incorrectly adds the top-level aggregate 
pom  as a parent in the parent pom causing an inheritance cycle, even though 
such a parent designation is  specified in the archetype resources.

 

The exact element that is incorrectly added to 
target/test-classes/projects/it-basic/project/example-project/example-project-parent/pom.xml
 is below..

    
     example-project-aggregator
     com.foo
     0.0.0
   

 

After the failure, removing the  incorrect parent pom element from the  
target/test-classes/projects/it-basic/project/example-project/example-project-parent/pom.xml
 results in a working  maven project. 

 

 

  was:
When developing a multi module archetype with a root level aggregator pom which 
inherits from a sibling parent within the project,  the archetype generated 
project will incorrectly add the aggregator pom as a parent to the sibling 
parent pom file, causing an inheritance cycle in the generated project.

Attached is a zip file containing a minimal archetype project that demonstrates 
the behavior.

After running mvn install,   you can inspect 
target/test-classes/projects/it-basic/project/example-project/example-project-parent/pom.xml
  and see that the generated project incorrectly adds the top-level aggregate 
pom  as a parent in the parent pom causing an inheritance cycle, even though 
such a parent designation is  specified in the archetype resources.

 

The exact element that is incorrectly added to 
target/test-classes/projects/it-basic/project/example-project/example-project-parent/pom.xml
 is below..

    
     example-project-aggregator
     com.foo
     0.0.0
   

 

After the failure, removing the  incorrect parent pom element from the  
target/test-classes/projects/it-basic/project/example-project/example-project-parent/pom.xml
 results in a working  maven project. 

 

 


> Valid Archetype projects  can generate broken projects with inheritance cycle 
>  
> ---
>
> Key: ARCHETYPE-552
> URL: https://issues.apache.org/jira/browse/ARCHETYPE-552
> Project: Maven Archetype
>  Issue Type: Bug
>  Components: Plugin
>Affects Versions: 3.0.1
>Reporter: Scott MacDonald
>Priority: Major
> Attachments: maven-archetype-parent-cycle-bug.zip
>
>
> When developing a multi module archetype with a root level aggregator pom 
> which inherits from a sibling parent within the project,  the archetype 
> generated project will incorrectly add the aggregator pom as a parent in the 
> sibling parent pom file, causing an inheritance cycle in the generated 
> project.
> Attached is a zip file containing a minimal archetype project that 
> demonstrates the behavior.
> After running mvn install,   you can inspect 
> target/test-classes/projects/it-basic/project/example-project/example-project-parent/pom.xml
>   and see that the generated project incorrectly adds the top-level aggregate 
> pom  as a parent in the parent pom causing an inheritance cycle, even though 
> such a parent designation is  specified in the archetype resources.
>  
> The exact element that is incorrectly added to 
> target/test-classes/projects/it-basic/project/example-project/example-project-parent/pom.xml
>  is below..
>     
>      example-project-aggregator
>      com.foo
>      0.0.0
>    
>  
> After the failure, removing the  incorrect parent pom element from the  
> target/test-classes/projects/it-basic/project/example-project/example-project-parent/pom.xml
>  results in a working  maven project. 
>  
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (ARCHETYPE-552) Valid Archetype projects can generate broken projects with inheritance cycle

2018-07-25 Thread Scott MacDonald (JIRA)


 [ 
https://issues.apache.org/jira/browse/ARCHETYPE-552?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Scott MacDonald updated ARCHETYPE-552:
--
Description: 
When developing a multi module archetype with a root level aggregator pom which 
inherits from a sibling parent within the project,  the archetype generated 
project will incorrectly add the aggregator pom as a parent to the sibling 
parent pom file, causing an inheritance cycle in the generated project.

Attached is a zip file containing a minimal archetype project that demonstrates 
the behavior.

After running mvn install,   you can inspect 
target/test-classes/projects/it-basic/project/example-project/example-project-parent/pom.xml
  and see that the generated project incorrectly adds the top-level aggregate 
pom  as a parent in the parent pom causing an inheritance cycle, even though 
such a parent designation is  specified in the archetype resources.

 

The exact element that is incorrectly added to 
target/test-classes/projects/it-basic/project/example-project/example-project-parent/pom.xml
 is below..

    
     example-project-aggregator
     com.foo
     0.0.0
   

 

After the failure, removing the  incorrect parent pom element from the  
target/test-classes/projects/it-basic/project/example-project/example-project-parent/pom.xml
 results in a working  maven project. 

 

 

  was:
When developing a multi module archetype with a root level aggregator pom which 
inherits from a sibling parent within the project,  the archetype generated 
project will incorrectly add the aggregator pom as a parent to the sibling 
parent pom file, causing an inheritance cycle in the generated project.

Attached is a zip file containing a minimal archetype project that demonstrates 
the behavior.

After running mvn install,   you can inspect 
target/test-classes/projects/it-basic/project/example-project/example-project-parent/pom.xml
  and see that the generated project incorrectly adds the top-level aggregate 
pom  as a parent in the to the parent pom causing an inheritance cycle, ven 
tough such a parent designation is not specified in the archetype resources)

 

The exact element that is incorrectly added to 
target/test-classes/projects/it-basic/project/example-project/example-project-parent/pom.xml
 is below..

    
    example-project-aggregator
    com.foo
    0.0.0
  

 

After the failure, removing the  incorrect parent pom element from the  
target/test-classes/projects/it-basic/project/example-project/example-project-parent/pom.xml
 results in a working  maven project. 

 

 


> Valid Archetype projects  can generate broken projects with inheritance cycle 
>  
> ---
>
> Key: ARCHETYPE-552
> URL: https://issues.apache.org/jira/browse/ARCHETYPE-552
> Project: Maven Archetype
>  Issue Type: Bug
>  Components: Plugin
>Affects Versions: 3.0.1
>Reporter: Scott MacDonald
>Priority: Major
> Attachments: maven-archetype-parent-cycle-bug.zip
>
>
> When developing a multi module archetype with a root level aggregator pom 
> which inherits from a sibling parent within the project,  the archetype 
> generated project will incorrectly add the aggregator pom as a parent to the 
> sibling parent pom file, causing an inheritance cycle in the generated 
> project.
> Attached is a zip file containing a minimal archetype project that 
> demonstrates the behavior.
> After running mvn install,   you can inspect 
> target/test-classes/projects/it-basic/project/example-project/example-project-parent/pom.xml
>   and see that the generated project incorrectly adds the top-level aggregate 
> pom  as a parent in the parent pom causing an inheritance cycle, even though 
> such a parent designation is  specified in the archetype resources.
>  
> The exact element that is incorrectly added to 
> target/test-classes/projects/it-basic/project/example-project/example-project-parent/pom.xml
>  is below..
>     
>      example-project-aggregator
>      com.foo
>      0.0.0
>    
>  
> After the failure, removing the  incorrect parent pom element from the  
> target/test-classes/projects/it-basic/project/example-project/example-project-parent/pom.xml
>  results in a working  maven project. 
>  
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (ARCHETYPE-552) Valid Archetype projects can generate broken projects with inheritance cycle

2018-07-25 Thread Scott MacDonald (JIRA)


 [ 
https://issues.apache.org/jira/browse/ARCHETYPE-552?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Scott MacDonald updated ARCHETYPE-552:
--
Component/s: Plugin

> Valid Archetype projects  can generate broken projects with inheritance cycle 
>  
> ---
>
> Key: ARCHETYPE-552
> URL: https://issues.apache.org/jira/browse/ARCHETYPE-552
> Project: Maven Archetype
>  Issue Type: Bug
>  Components: Plugin
>Affects Versions: 3.0.1
>Reporter: Scott MacDonald
>Priority: Major
> Attachments: maven-archetype-parent-cycle-bug.zip
>
>
> When developing a multi module archetype with a root level aggregator pom 
> which inherits from a sibling parent within the project,  the archetype 
> generated project will incorrectly add the aggregator pom as a parent to the 
> sibling parent pom file, causing an inheritance cycle in the generated 
> project.
> Attached is a zip file containing a minimal archetype project that 
> demonstrates the behavior.
> After running mvn install,   you can inspect 
> target/test-classes/projects/it-basic/project/example-project/example-project-parent/pom.xml
>   and see that the generated project incorrectly adds the top-level aggregate 
> pom  as a parent in the parent pom causing an inheritance cycle, even though 
> such a parent designation is  specified in the archetype resources.
>  
> The exact element that is incorrectly added to 
> target/test-classes/projects/it-basic/project/example-project/example-project-parent/pom.xml
>  is below..
>     
>      example-project-aggregator
>      com.foo
>      0.0.0
>    
>  
> After the failure, removing the  incorrect parent pom element from the  
> target/test-classes/projects/it-basic/project/example-project/example-project-parent/pom.xml
>  results in a working  maven project. 
>  
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (ARCHETYPE-552) Valid Archetype projects can generate broken projects with inheritance cycle

2018-07-25 Thread Scott MacDonald (JIRA)


 [ 
https://issues.apache.org/jira/browse/ARCHETYPE-552?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Scott MacDonald updated ARCHETYPE-552:
--
Summary: Valid Archetype projects  can generate broken projects with 
inheritance cycle(was: Valid Archetype projects  can generate broken 
projects with inheritanc cycle  )

> Valid Archetype projects  can generate broken projects with inheritance cycle 
>  
> ---
>
> Key: ARCHETYPE-552
> URL: https://issues.apache.org/jira/browse/ARCHETYPE-552
> Project: Maven Archetype
>  Issue Type: Bug
>Affects Versions: 3.0.1
>Reporter: Scott MacDonald
>Priority: Major
> Attachments: maven-archetype-parent-cycle-bug.zip
>
>
> When developing a multi module archetype with a root level aggregator pom 
> which inherits from a sibling parent within the project,  the archetype 
> generated project will incorrectly add the aggregator pom as a parent to the 
> sibling parent pom file, causing an inheritance cycle in the generated 
> project.
> Attached is a zip file containing a minimal archetype project that 
> demonstrates the behavior.
> After running mvn install,   you can inspect 
> target/test-classes/projects/it-basic/project/example-project/example-project-parent/pom.xml
>   and see that the generated project incorrectly adds the top-level aggregate 
> pom  as a parent in the to the parent pom causing an inheritance cycle, ven 
> tough such a parent designation is not specified in the archetype resources)
>  
> The exact element that is incorrectly added to 
> target/test-classes/projects/it-basic/project/example-project/example-project-parent/pom.xml
>  is below..
>     
>     example-project-aggregator
>     com.foo
>     0.0.0
>   
>  
> After the failure, removing the  incorrect parent pom element from the  
> target/test-classes/projects/it-basic/project/example-project/example-project-parent/pom.xml
>  results in a working  maven project. 
>  
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Created] (ARCHETYPE-552) Valid Archetype projects can generate broken projects with inheritanc cycle

2018-07-25 Thread Scott MacDonald (JIRA)
Scott MacDonald created ARCHETYPE-552:
-

 Summary: Valid Archetype projects  can generate broken projects 
with inheritanc cycle  
 Key: ARCHETYPE-552
 URL: https://issues.apache.org/jira/browse/ARCHETYPE-552
 Project: Maven Archetype
  Issue Type: Bug
Affects Versions: 3.0.1
Reporter: Scott MacDonald
 Attachments: maven-archetype-parent-cycle-bug.zip

When developing a multi module archetype with a root level aggregator pom which 
inherits from a sibling parent within the project,  the archetype generated 
project will incorrectly add the aggregator pom as a parent to the sibling 
parent pom file, causing an inheritance cycle in the generated project.

Attached is a zip file containing a minimal archetype project that demonstrates 
the behavior.

After running mvn install,   you can inspect 
target/test-classes/projects/it-basic/project/example-project/example-project-parent/pom.xml
  and see that the generated project incorrectly adds the top-level aggregate 
pom  as a parent in the to the parent pom causing an inheritance cycle, ven 
tough such a parent designation is not specified in the archetype resources)

 

The exact element that is incorrectly added to 
target/test-classes/projects/it-basic/project/example-project/example-project-parent/pom.xml
 is below..

    
    example-project-aggregator
    com.foo
    0.0.0
  

 

After the failure, removing the  incorrect parent pom element from the  
target/test-classes/projects/it-basic/project/example-project/example-project-parent/pom.xml
 results in a working  maven project. 

 

 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] Created: (SCM-640) Add support for automatic lables when using Perforce

2011-10-24 Thread Scott MacDonald (JIRA)
Add support for automatic lables when using Perforce


 Key: SCM-640
 URL: https://jira.codehaus.org/browse/SCM-640
 Project: Maven SCM
  Issue Type: Improvement
  Components: maven-scm-provider-perforce
Affects Versions: 1.5
Reporter: Scott MacDonald


Perforce has known performance using static labels which is the type of label 
used by maven-scm-provider-perforce.   See  http://kb.perforce.com/article/1169
for info on status versus automatic labels.

This improvement is to add support for automatic labels. 

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira




[jira] Commented: (MNG-519) Timestamps on messages

2011-08-12 Thread Scott MacDonald (JIRA)

[ 
https://jira.codehaus.org/browse/MNG-519?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=275668#comment-275668
 ] 

Scott MacDonald commented on MNG-519:
-

I'm not sure what is more amazing...That maven does not support timestamped 
logs, or that I have been a maven user for so many  years and only just 
noticed.  

 Timestamps on messages
 --

 Key: MNG-519
 URL: https://jira.codehaus.org/browse/MNG-519
 Project: Maven 2  3
  Issue Type: New Feature
  Components: Logging, Plugins and Lifecycle
Reporter: Jeff Jensen
Priority: Minor
 Fix For: 3.x / Backlog


 With current and/or moving forward with M2, I would like an option for 
 timestamped messages.
 We have a somewhat long nightly process.  I regularly wish for timestamps on 
 the log messages from the Maven build.  The two primary reasons for this are 
 duration calculation - how long did something take, and an occasional 
 correlation with an outside event.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira




[jira] Commented: (MPMD-86) Using JDK 1.5 causes ParseException: Can't use generics unless running in JDK 1.5 mode!

2011-08-04 Thread Scott MacDonald (JIRA)

[ 
https://jira.codehaus.org/browse/MPMD-86?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=275012#comment-275012
 ] 

Scott MacDonald commented on MPMD-86:
-

After confnigruing my pom correcly, the Workaround of setting global 
propertiestargetJdk1.6targetJdkproperties does actually work for me..  
This is still a bug though.   Would be nice if PMD honored compiler jdk version.

 Using JDK 1.5 causes ParseException: Can't use generics unless running in JDK 
 1.5 mode!
 ---

 Key: MPMD-86
 URL: https://jira.codehaus.org/browse/MPMD-86
 Project: Maven 2.x PMD Plugin
  Issue Type: Bug
  Components: PMD
Affects Versions: 2.4
 Environment: JAVA 1.5, Maven 2.0.9
Reporter: Debabrat Panda
Assignee: Benjamin Bentmann

 While running PMD with Maven i am getting parsing error Error while parsing 
 ../../../java file
 The errors are
 1. Can't use generics unless running in JDK 1.5 mode!
 2. Can't use static imports when running in JDK 1.4 mode!
 Can't use annotations when running in JDK 1.4 mode!
 Any help will be appreciated.
 Thanks in advance.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira




[jira] Commented: (MPMD-86) Using JDK 1.5 causes ParseException: Can't use generics unless running in JDK 1.5 mode!

2011-08-03 Thread Scott MacDonald (JIRA)

[ 
https://jira.codehaus.org/browse/MPMD-86?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=274907#comment-274907
 ] 

Scott MacDonald commented on MPMD-86:
-

The workaround of setting propertiestargetJdk1.6targetJdkproperties  is 
not working for me.   This bug still exists in latest maven 3.0.03  PMD 2.4,  
has a workaround that does not work in all cases,  and should be reopened.

 Using JDK 1.5 causes ParseException: Can't use generics unless running in JDK 
 1.5 mode!
 ---

 Key: MPMD-86
 URL: https://jira.codehaus.org/browse/MPMD-86
 Project: Maven 2.x PMD Plugin
  Issue Type: Bug
  Components: PMD
Affects Versions: 2.4
 Environment: JAVA 1.5, Maven 2.0.9
Reporter: Debabrat Panda
Assignee: Benjamin Bentmann

 While running PMD with Maven i am getting parsing error Error while parsing 
 ../../../java file
 The errors are
 1. Can't use generics unless running in JDK 1.5 mode!
 2. Can't use static imports when running in JDK 1.4 mode!
 Can't use annotations when running in JDK 1.4 mode!
 Any help will be appreciated.
 Thanks in advance.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira




[jira] Created: (MNG-5146) parent.relativePath Warning is very misleading

2011-08-03 Thread Scott MacDonald (JIRA)
parent.relativePath Warning is very misleading
--

 Key: MNG-5146
 URL: https://jira.codehaus.org/browse/MNG-5146
 Project: Maven 2  3
  Issue Type: Bug
  Components: Errors
 Environment: Maven 3.0.3
Reporter: Scott MacDonald
Priority: Minor


When a parent pom.xml is located in a sibling directory as the children, and 
relativePath is not set in the parent element of the children, maven spits 
out a completely bogus, very misleading, warning message.

For example, suppose com.fubar  and com.parent are in sibling directories 
(along with a bunch of other modules), and com.fubar specifies com.parent as 
its parent, but does snot specify a parent.relativePath in it parent element. 

When you run a build, you get the following...

[INFO] Scanning for projects...
[WARNING]
[WARNING] Some problems were encountered while building the effective model for 
com.fubar:jar:1234.5
[WARNING] 'parent.relativePath' points at com.someRandomModule instead of 
com.parent, please verify your project structure @ line
10, column 11
[WARNING]
[WARNING] It is highly recommended to fix these problems because they threaten 
the stability of your build.
[WARNING]
[WARNING] For this reason, future Maven versions might no longer support 
building such malformed projects.
[WARNING]

The warning incorrectly states that the child pom has specified 
com.someRandomModule (a  completely unrelated module) as its parent when that 
is completely not the case. The unlreated module, in this case, happens to be 
an existing module in a differrnt  sibling directory, but otherwise has no 
relation whatsoever to the parent or child.

It would be much better to  warn about the actual problem

The actual problem is that maven first tries to resolve parent poms locally 
based on the value of relativePath in the parent element of the child.  IF it 
does not find it there, it will then resolve the parent from the repos.  The 
current default value of relativepath is ../pom.xml  (which in my case doesn;t 
work because my parent is in a sibling directory) 

The warning should  be changed to something useful, such as

[WARNING]  Could not resolve parent pom locally using parent.relativePath value 
of ../pom.xml.  Parent pom will be resolved from  local or remote repository. 
To disable local parent pom resolution, specify relativePathrelativePath in 
you parent element.











--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira




[jira] Commented: (MPMD-86) Using JDK 1.5 causes ParseException: Can't use generics unless running in JDK 1.5 mode!

2011-08-02 Thread Scott MacDonald (JIRA)

[ 
https://jira.codehaus.org/browse/MPMD-86?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=274821#comment-274821
 ] 

Scott MacDonald commented on MPMD-86:
-

How is this closed as Not a bug while simultaneously providing a work around 
for the bug?

This is still an issue in maven 3.03 PMD 2.4.



 Using JDK 1.5 causes ParseException: Can't use generics unless running in JDK 
 1.5 mode!
 ---

 Key: MPMD-86
 URL: https://jira.codehaus.org/browse/MPMD-86
 Project: Maven 2.x PMD Plugin
  Issue Type: Bug
  Components: PMD
Affects Versions: 2.4
 Environment: JAVA 1.5, Maven 2.0.9
Reporter: Debabrat Panda
Assignee: Benjamin Bentmann

 While running PMD with Maven i am getting parsing error Error while parsing 
 ../../../java file
 The errors are
 1. Can't use generics unless running in JDK 1.5 mode!
 2. Can't use static imports when running in JDK 1.4 mode!
 Can't use annotations when running in JDK 1.4 mode!
 Any help will be appreciated.
 Thanks in advance.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira