[jira] [Comment Edited] (MSKINS-97) Upgrade to Bootstrap 5.x
[ https://issues.apache.org/jira/browse/MSKINS-97?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17697116#comment-17697116 ] Stephen Crocker edited comment on MSKINS-97 at 3/6/23 9:20 PM: --- Its on Twitter Bootstrap v2, which is 10 years old. It underwent a huge API rewrite to v3 and most the v2 documentation has disappeared. As part of v3 the grid system was completely rewritten along with how many of the components work. While this has changed between v3 to v5, the changes are typically smaller. So I thought the logical step was to migrate to v3 before moving to v5. The problem I hit is bootstrap doesn't really have a concept as a Side Navigation Bar, there are website which hack the NavBar to operate on the side but the principles shift radically between versions. So its easier to got straight to bootstrap 5. My suggestion: * Follow the readme to construct all the test sites and take a screenshot so you can compare them with your future release. * You only want the Bootstrap, [Code-Prettify|https://www.npmjs.com/package/code-prettify] & [jQuery|https://www.npmjs.com/package/jquery] JS files within the project. Bootstrap no longer uses jQuery and code-prettify can use the latest release. * You might want to add [bootstrap icons|https://www.npmjs.com/package/bootstrap-icons] * You can then upgrade the bootstrap js and CSS files to the latest release of Bootstrap. * At this point everything breaks, I would start by reimplementing the [grid system|https://getbootstrap.com/docs/5.0/layout/grid/] on the project to the latest Bootstrap standard. * Then I would look specifically at the [horizontal navbar|https://getbootstrap.com/docs/5.2/components/navbar/] reworking it to follow the Bootstrap guidelines. * At this point I would look at getting the NavBar to operate as a Sidebar. [This is my implementation|https://github.com/stevecrox/maven-site-bootstrap-skin/blob/main/bootstrap-site-skin/src/main/resources/META-INF/maven/sidebar-macros.vm] for Bootstrap 5. * Once you have a working Nav bar, you can start looking at the 'deviations'. The biggest issue is this skin, isn't a 'Bootstrap layout' skin, but rather an attempt to implement the [Maven Default Site|https://maven.apache.org/skins/maven-default-skin/sample/] using Bootstrap. This results in deviations, for example the concept of a 'banner' was dropped for the the Navbar but you'll find 'Banner Left', 'Banner Right', sit in the 'Banner' the Breadcrumbs, Project Version and last published also sit in the 'Banner'. Within Bootstrap this means working out how to integrate them within the NavBar. This is how I implemented the [Banner|https://github.com/stevecrox/maven-site-bootstrap-skin/blob/main/bootstrap-site-skin/src/main/resources/META-INF/maven/site.vm#L79] and the [Project Bar|https://github.com/stevecrox/maven-site-bootstrap-skin/blob/main/bootstrap-site-skin/src/main/resources/META-INF/maven/projectbar-macros.vm] Bootstrap isn't designed for multiple Navbar's so this is weirdly difficult to put in place. You then have other deviations, for example the current implementation has a bunch of Gif Files it attaches to various elements. There aren't always direct equivalents in bootstrap/bootstrap-icons and the Gif's are really low resolution so look terrible for poor vision/4k Screen users. On top of that trying to get those elements to work responsively when Bootstrap doesn't really expect them is a complete nightmare. Also the sidebar (how I grew to hate it) has a bunch of rules on colouring, indent and icons which aren't obvious and I gave up trying to make them work on anything but a desktop screen. I found some of the team here blunt, unhelpful and frequently insulting (see my last comment). In the end I went off make [Maven Site Bootstrap skin|https://stevecrox.github.io/maven-site-bootstrap-skin/index.html], my goal was similar to this project but I wanted to prioritise sticking with standard Bootstrap layouts over recreating Maven's default site. The [Maven Reflow skin|https://devacfr.github.io/reflow-maven-skin/] is a great project, the maintainer seems a really nice person. Unfortunately they have deviated significantly from this and core bootstrap to try and build a really flexible and good product. Porting my work from here would have been a rewrite but I would like to contribute to it at some point. was (Author: JIRAUSER290518): Its on Twitter Bootstrap v1, which is 10 years old. It underwent a huge API rewrite to v2 and most the V2 documentation has disappeared. I thought the logical step was migrating to v3 which is closer to v5 (largely differences in css class names) but.. The problem I hit is bootstrap doesn't really have a concept as a Navigation Bar on the side. The way to achieve it in Bootstrap 3 is completely different to Bootstrap 5. So its easier to go
[jira] [Commented] (MSKINS-97) Upgrade to Bootstrap 5.x
[ https://issues.apache.org/jira/browse/MSKINS-97?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17697116#comment-17697116 ] Stephen Crocker commented on MSKINS-97: --- Its on Twitter Bootstrap v1, which is 10 years old. It underwent a huge API rewrite to v2 and most the V2 documentation has disappeared. I thought the logical step was migrating to v3 which is closer to v5 (largely differences in css class names) but.. The problem I hit is bootstrap doesn't really have a concept as a Navigation Bar on the side. The way to achieve it in Bootstrap 3 is completely different to Bootstrap 5. So its easier to got straight to bootstrap 5. The current library has copy pasted javascript files, the only one you need to track down is the one which makes source code render blocks. My suggestion: * Follow the readme to construct all the test sites and take a screenshot so you can compare. * Then remove jQuery, etc.. from the project and purge the CSS (bootstrap no longer needs jQuery and the CSS is not the right way to do it in bootstrap 5. * Then upgrade the bootstrap js and CSS files to the latest. * Then start by migrating everything to the bootstrap grid system, it doesn't matter the parts arent rendering correctly, they they are in the right place. * Then redo the horizontal navbar to align with bootstrap docs (and don't forget the banner left/banner right parts of the spec). * Then work to build a sidebar (that is a huge effort). * Then complete the project version/date parts * Then look at breadcrumbs * Then all the deviations. This skin attempts to exactly recreate the exist Maven 2 Site design, that was made in 2010 and large chunks of it are considered bad/dated today. Those deviations are largely where I got fed up. I spent 4 days trying to get bootstrap-icon equivalents render like the existing gifs and work under a responsive design knowing this team wouldbe unhappy if it was missing. I went off to make [Maven Site Bootstrap skin|https://stevecrox.github.io/maven-site-bootstrap-skin/index.html], where the goal was to create this but stick with standard bootstrap components and try to limit custom config. I know the guy behind The [Maven Reflow skin|https://devacfr.github.io/reflow-maven-skin/] felt similar to me, but what I had done wasn't a good fit for his solution and I'd burnt myself out trying to get some if this working. I still want to contribute to it though, that dude was super nice and helpful > Upgrade to Bootstrap 5.x > > > Key: MSKINS-97 > URL: https://issues.apache.org/jira/browse/MSKINS-97 > Project: Maven Skins > Issue Type: Task > Components: Fluido Skin >Reporter: Michael Osipov >Priority: Major > Attachments: bootstrap5-sidebar.png, bootstrap5-topbar.png > > > Next major of Fluido should be upgraded to Bootstrap 5.x which is *not* > backwards compatible to 2.x. See http://getbootstrap.com/migration/ -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MSITE-909) Add Bootstrap Site Skin to documentation
[ https://issues.apache.org/jira/browse/MSITE-909?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17573307#comment-17573307 ] Stephen Crocker commented on MSITE-909: --- Raised PR: https://github.com/apache/maven-site/pull/314 > Add Bootstrap Site Skin to documentation > > > Key: MSITE-909 > URL: https://issues.apache.org/jira/browse/MSITE-909 > Project: Maven Site Plugin > Issue Type: New Feature >Reporter: Stephen Crocker >Priority: Minor > > I have developed a new Maven Site skin based on Bootstrap 5 components and > elements which can be toggled on/off allowing a variety of layouts. > The areas of the community I have shared this with have suggested placing it > into the available skin documentation so other projects can find it. > This feature is adding that information to the relevant documentation page. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (MSITE-909) Add Bootstrap Site Skin to documentation
Stephen Crocker created MSITE-909: - Summary: Add Bootstrap Site Skin to documentation Key: MSITE-909 URL: https://issues.apache.org/jira/browse/MSITE-909 Project: Maven Site Plugin Issue Type: New Feature Reporter: Stephen Crocker I have developed a new Maven Site skin based on Bootstrap 5 components and elements which can be toggled on/off allowing a variety of layouts. The areas of the community I have shared this with have suggested placing it into the available skin documentation so other projects can find it. This feature is adding that information to the relevant documentation page. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MSKINS-97) Upgrade to Bootstrap 5.x
[ https://issues.apache.org/jira/browse/MSKINS-97?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17558767#comment-17558767 ] Stephen Crocker commented on MSKINS-97: --- I've closed my commit, after being frequently insulted by [~michael-o] I'm then presented with a requirement I view as bad practice by [~sjaranowski] who can't justify their position with reason. I am not going to waste additional effort trying to help a project that doesn't want it. > Upgrade to Bootstrap 5.x > > > Key: MSKINS-97 > URL: https://issues.apache.org/jira/browse/MSKINS-97 > Project: Maven Skins > Issue Type: Task > Components: Fluido Skin >Reporter: Michael Osipov >Priority: Major > Fix For: fluido-2.0.0 > > Attachments: bootstrap5-sidebar.png, bootstrap5-topbar.png > > > Next major of Fluido should be upgraded to Bootstrap 5.x which is *not* > backwards compatible to 2.x. See http://getbootstrap.com/migration/ -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Commented] (MSKINS-191) Update how project retreives bootstrap libraries
[ https://issues.apache.org/jira/browse/MSKINS-191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17558766#comment-17558766 ] Stephen Crocker commented on MSKINS-191: I've closed my commit, after being frequently insulted by [~michael-o] I'm then presented with a requirement I view as bad practice by [~sjaranowski] who can't justify their position with reason. I am not going to waste additional effort trying to help a project that doesn't want it. > Update how project retreives bootstrap libraries > > > Key: MSKINS-191 > URL: https://issues.apache.org/jira/browse/MSKINS-191 > Project: Maven Skins > Issue Type: New Feature >Reporter: Stephen Crocker >Priority: Major > Attachments: bootstrap3-sidebar.png, bootstrap3-topbar.png > > > Currently the Bootstrap library is included within the project itself, > Bootstrap builds and deploys into the NPM repository. We can use the > com.github.eirslett:frontend-maven-plugin plugin to pull down the boostrap > plugins and setting the project up for packaging. This should simplify > updates to the boostrap library. -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Commented] (MSKINS-188) Build by use old Maven logo
[ https://issues.apache.org/jira/browse/MSKINS-188?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17558765#comment-17558765 ] Stephen Crocker commented on MSKINS-188: I've closed my commit, after being frequently insulted by [~michael-o] I'm then presented with a requirement I view as bad practice by [~sjaranowski] who can't justify their position with reason. I am not going to waste additional effort trying to help a project that doesn't want it. > Build by use old Maven logo > --- > > Key: MSKINS-188 > URL: https://issues.apache.org/jira/browse/MSKINS-188 > Project: Maven Skins > Issue Type: Improvement > Components: Fluido Skin >Reporter: Slawomir Jaranowski >Priority: Major > Fix For: fluido-1.11.1 > > Attachments: image-2022-05-15-10-26-28-674.png, > image-2022-05-15-10-29-02-990.png, image-2022-06-25-10-44-43-268.png, maven > feather example.png, powered by example.png, powered by example2.png, powered > by.png > > > h2. Actual logo: > [https://www.apache.org/logos/#maven] > h2. Default Skin > !image-2022-05-15-10-26-28-674.png! > > h2. Fluido Skin > !image-2022-05-15-10-29-02-990.png! > -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Commented] (MSKINS-191) Update how project retreives bootstrap libraries
[ https://issues.apache.org/jira/browse/MSKINS-191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17558685#comment-17558685 ] Stephen Crocker commented on MSKINS-191: [~michaelo] Believe it or not there are the same CSS classes used in MSKINS-97 > Update how project retreives bootstrap libraries > > > Key: MSKINS-191 > URL: https://issues.apache.org/jira/browse/MSKINS-191 > Project: Maven Skins > Issue Type: New Feature >Reporter: Stephen Crocker >Priority: Major > Attachments: bootstrap3-sidebar.png, bootstrap3-topbar.png > > > Currently the Bootstrap library is included within the project itself, > Bootstrap builds and deploys into the NPM repository. We can use the > com.github.eirslett:frontend-maven-plugin plugin to pull down the boostrap > plugins and setting the project up for packaging. This should simplify > updates to the boostrap library. -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Updated] (MSKINS-191) Update how project retreives bootstrap libraries
[ https://issues.apache.org/jira/browse/MSKINS-191?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stephen Crocker updated MSKINS-191: --- Attachment: bootstrap3-sidebar.png bootstrap3-topbar.png > Update how project retreives bootstrap libraries > > > Key: MSKINS-191 > URL: https://issues.apache.org/jira/browse/MSKINS-191 > Project: Maven Skins > Issue Type: New Feature >Reporter: Stephen Crocker >Priority: Major > Attachments: bootstrap3-sidebar.png, bootstrap3-topbar.png > > > Currently the Bootstrap library is included within the project itself, > Bootstrap builds and deploys into the NPM repository. We can use the > com.github.eirslett:frontend-maven-plugin plugin to pull down the boostrap > plugins and setting the project up for packaging. This should simplify > updates to the boostrap library. -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Commented] (MSKINS-191) Update how project retreives bootstrap libraries
[ https://issues.apache.org/jira/browse/MSKINS-191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17558684#comment-17558684 ] Stephen Crocker commented on MSKINS-191: !bootstrap3-sidebar.png! !bootstrap3-topbar.png! > Update how project retreives bootstrap libraries > > > Key: MSKINS-191 > URL: https://issues.apache.org/jira/browse/MSKINS-191 > Project: Maven Skins > Issue Type: New Feature >Reporter: Stephen Crocker >Priority: Major > Attachments: bootstrap3-sidebar.png, bootstrap3-topbar.png > > > Currently the Bootstrap library is included within the project itself, > Bootstrap builds and deploys into the NPM repository. We can use the > com.github.eirslett:frontend-maven-plugin plugin to pull down the boostrap > plugins and setting the project up for packaging. This should simplify > updates to the boostrap library. -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Comment Edited] (MSKINS-97) Upgrade to Bootstrap 5.x
[ https://issues.apache.org/jira/browse/MSKINS-97?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17558683#comment-17558683 ] Stephen Crocker edited comment on MSKINS-97 at 6/24/22 9:28 PM: The sidebar is lacking icons (problem for tomorrow). Its lost the indentation and floating nature because of bootstrap spacing in v5. Some of the navbar stuff seems to have moved to the flex system, after spending an evening fighting it I gave up and embraced it and changed the sidebar to be a d-flex. This is what causes the sidebar background to go to the edges. The text and use of upper capitals comes from the base Bootstrap theme, for the dynamic branch I altered the mainmenu/topmenu to make use of nav-header, nav-link, nav-item, etc.. It the basic theme nav-header will all caps titles Also the fact the top bar/banner isn't going to the edge is bugging me, either the sidebar needs to indent or the topbar should fully extend. was (Author: JIRAUSER290518): The sidebar is lacking icons (problem for tomorrow). Its lost the indentation and floating nature because of bootstrap spacing in v5. Some of the navbar stuff seems to have moved to the flex system, after spending an evening fighting it I gave up and embraced it and changed the sidebar to be a d-flex. This is what causes the sidebar background to go to the edges. The text and use of upper capitals comes from the base Bootstrap theme, for the dynamic branch I altered the mainmenu/topmenu to make use of nav-header, nav-link, nav-item, etc.. It the basic theme nav-header will all caps titles > Upgrade to Bootstrap 5.x > > > Key: MSKINS-97 > URL: https://issues.apache.org/jira/browse/MSKINS-97 > Project: Maven Skins > Issue Type: Task > Components: Fluido Skin >Reporter: Michael Osipov >Priority: Major > Fix For: fluido-2.0.0 > > Attachments: bootstrap5-sidebar.png, bootstrap5-topbar.png > > > Next major of Fluido should be upgraded to Bootstrap 5.x which is *not* > backwards compatible to 2.x. See http://getbootstrap.com/migration/ -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Commented] (MSKINS-97) Upgrade to Bootstrap 5.x
[ https://issues.apache.org/jira/browse/MSKINS-97?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17558683#comment-17558683 ] Stephen Crocker commented on MSKINS-97: --- The sidebar is lacking icons (problem for tomorrow). Its lost the indentation and floating nature because of bootstrap spacing in v5. Some of the navbar stuff seems to have moved to the flex system, after spending an evening fighting it I gave up and embraced it and changed the sidebar to be a d-flex. This is what causes the sidebar background to go to the edges. The text and use of upper capitals comes from the base Bootstrap theme, for the dynamic branch I altered the mainmenu/topmenu to make use of nav-header, nav-link, nav-item, etc.. It the basic theme nav-header will all caps titles > Upgrade to Bootstrap 5.x > > > Key: MSKINS-97 > URL: https://issues.apache.org/jira/browse/MSKINS-97 > Project: Maven Skins > Issue Type: Task > Components: Fluido Skin >Reporter: Michael Osipov >Priority: Major > Fix For: fluido-2.0.0 > > Attachments: bootstrap5-sidebar.png, bootstrap5-topbar.png > > > Next major of Fluido should be upgraded to Bootstrap 5.x which is *not* > backwards compatible to 2.x. See http://getbootstrap.com/migration/ -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Updated] (MSKINS-97) Upgrade to Bootstrap 5.x
[ https://issues.apache.org/jira/browse/MSKINS-97?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stephen Crocker updated MSKINS-97: -- Attachment: bootstrap5-topbar.png > Upgrade to Bootstrap 5.x > > > Key: MSKINS-97 > URL: https://issues.apache.org/jira/browse/MSKINS-97 > Project: Maven Skins > Issue Type: Task > Components: Fluido Skin >Reporter: Michael Osipov >Priority: Major > Fix For: fluido-2.0.0 > > Attachments: bootstrap5-sidebar.png, bootstrap5-topbar.png > > > Next major of Fluido should be upgraded to Bootstrap 5.x which is *not* > backwards compatible to 2.x. See http://getbootstrap.com/migration/ -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Commented] (MSKINS-97) Upgrade to Bootstrap 5.x
[ https://issues.apache.org/jira/browse/MSKINS-97?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17558682#comment-17558682 ] Stephen Crocker commented on MSKINS-97: --- !bootstrap5-topbar.png! > Upgrade to Bootstrap 5.x > > > Key: MSKINS-97 > URL: https://issues.apache.org/jira/browse/MSKINS-97 > Project: Maven Skins > Issue Type: Task > Components: Fluido Skin >Reporter: Michael Osipov >Priority: Major > Fix For: fluido-2.0.0 > > Attachments: bootstrap5-sidebar.png, bootstrap5-topbar.png > > > Next major of Fluido should be upgraded to Bootstrap 5.x which is *not* > backwards compatible to 2.x. See http://getbootstrap.com/migration/ -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Updated] (MSKINS-97) Upgrade to Bootstrap 5.x
[ https://issues.apache.org/jira/browse/MSKINS-97?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stephen Crocker updated MSKINS-97: -- Attachment: bootstrap5-sidebar.png > Upgrade to Bootstrap 5.x > > > Key: MSKINS-97 > URL: https://issues.apache.org/jira/browse/MSKINS-97 > Project: Maven Skins > Issue Type: Task > Components: Fluido Skin >Reporter: Michael Osipov >Priority: Major > Fix For: fluido-2.0.0 > > Attachments: bootstrap5-sidebar.png > > > Next major of Fluido should be upgraded to Bootstrap 5.x which is *not* > backwards compatible to 2.x. See http://getbootstrap.com/migration/ -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Commented] (MSKINS-97) Upgrade to Bootstrap 5.x
[ https://issues.apache.org/jira/browse/MSKINS-97?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17558680#comment-17558680 ] Stephen Crocker commented on MSKINS-97: --- !bootstrap5-sidebar.png! > Upgrade to Bootstrap 5.x > > > Key: MSKINS-97 > URL: https://issues.apache.org/jira/browse/MSKINS-97 > Project: Maven Skins > Issue Type: Task > Components: Fluido Skin >Reporter: Michael Osipov >Priority: Major > Fix For: fluido-2.0.0 > > Attachments: bootstrap5-sidebar.png > > > Next major of Fluido should be upgraded to Bootstrap 5.x which is *not* > backwards compatible to 2.x. See http://getbootstrap.com/migration/ -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Commented] (MSKINS-109) Support HiDPI displays
[ https://issues.apache.org/jira/browse/MSKINS-109?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17558467#comment-17558467 ] Stephen Crocker commented on MSKINS-109: Bootstrap 2.x had an undeveloped glyphicon set which uses very different names, the naming scheme is largely consistent from 3->5 and they add new glyphs for each. I'll have a look at 3 to see if we can swap stuff in. > Support HiDPI displays > -- > > Key: MSKINS-109 > URL: https://issues.apache.org/jira/browse/MSKINS-109 > Project: Maven Skins > Issue Type: Improvement > Components: Fluido Skin >Affects Versions: fluido-1.3.1 > Environment: HiDPI/Retina display >Reporter: Hendrik Schreiber >Priority: Major > > Graphics provided in the skin (github ribbon, "Built by Maven", link icons, > ...) are only provided in standard resolution. By now, this looks amateurish > on screens with HiDPI (i.e. Retina displays). > Please provide hi res images that are scaled with width/height parameters so > that they look good on hi res displays. > Thanks. -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Commented] (MSKINS-97) Upgrade to Bootstrap 5.x
[ https://issues.apache.org/jira/browse/MSKINS-97?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17558465#comment-17558465 ] Stephen Crocker commented on MSKINS-97: --- I have something working! Branch needs some serious clean-up > Upgrade to Bootstrap 5.x > > > Key: MSKINS-97 > URL: https://issues.apache.org/jira/browse/MSKINS-97 > Project: Maven Skins > Issue Type: Task > Components: Fluido Skin >Reporter: Michael Osipov >Priority: Major > Fix For: fluido-2.0.0 > > > Next major of Fluido should be upgraded to Bootstrap 5.x which is *not* > backwards compatible to 2.x. See http://getbootstrap.com/migration/ -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Commented] (MSKINS-188) Build by use old Maven logo
[ https://issues.apache.org/jira/browse/MSKINS-188?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17558464#comment-17558464 ] Stephen Crocker commented on MSKINS-188: https://github.com/apache/maven-fluido-skin/pull/39 > Build by use old Maven logo > --- > > Key: MSKINS-188 > URL: https://issues.apache.org/jira/browse/MSKINS-188 > Project: Maven Skins > Issue Type: Improvement >Reporter: Slawomir Jaranowski >Priority: Major > Attachments: image-2022-05-15-10-26-28-674.png, > image-2022-05-15-10-29-02-990.png, maven feather example.png, powered by > example.png, powered by example2.png, powered by.png > > > h2. Actual logo: > [https://www.apache.org/logos/#maven] > h2. Default Skin > !image-2022-05-15-10-26-28-674.png! > > h2. Fluido Skin > !image-2022-05-15-10-29-02-990.png! > -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Commented] (MSKINS-175) Upgrade to JQuery 3.6.0 in Fluido skin
[ https://issues.apache.org/jira/browse/MSKINS-175?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17558463#comment-17558463 ] Stephen Crocker commented on MSKINS-175: https://github.com/apache/maven-fluido-skin/pull/38 <- After looking at each integration test I can't see a single thing breaking > Upgrade to JQuery 3.6.0 in Fluido skin > -- > > Key: MSKINS-175 > URL: https://issues.apache.org/jira/browse/MSKINS-175 > Project: Maven Skins > Issue Type: Bug > Components: Fluido Skin >Reporter: László Langó >Priority: Critical > Labels: Securtity > > Please upgrade to JQuery 3.6.0 due to CVEs > ([CVE-2020-11022|https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2020-11022] > and > [CVE-2020-11023|https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2020-11023]) > affecting JQuery <3.5.0. -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Commented] (MSKINS-195) Follow Twitter button broken
[ https://issues.apache.org/jira/browse/MSKINS-195?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17558462#comment-17558462 ] Stephen Crocker commented on MSKINS-195: https://github.com/apache/maven-fluido-skin/pull/40 - submitted a PR > Follow Twitter button broken > > > Key: MSKINS-195 > URL: https://issues.apache.org/jira/browse/MSKINS-195 > Project: Maven Skins > Issue Type: Bug >Reporter: Stephen Crocker >Priority: Minor > > If you include a follow twitter button, the address it uses to construct > itself has dropped the protocol prefix. > Should be a simple change to add it back in. -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Created] (MSKINS-195) Follow Twitter button broken
Stephen Crocker created MSKINS-195: -- Summary: Follow Twitter button broken Key: MSKINS-195 URL: https://issues.apache.org/jira/browse/MSKINS-195 Project: Maven Skins Issue Type: Bug Reporter: Stephen Crocker If you include a follow twitter button, the address it uses to construct itself has dropped the protocol prefix. Should be a simple change to add it back in. -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Commented] (MSKINS-188) Build by use old Maven logo
[ https://issues.apache.org/jira/browse/MSKINS-188?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17556551#comment-17556551 ] Stephen Crocker commented on MSKINS-188: I'll mess around with some centring options and submit a PR. The Span size you give it within the grid system directly affects the size of the icon. > Build by use old Maven logo > --- > > Key: MSKINS-188 > URL: https://issues.apache.org/jira/browse/MSKINS-188 > Project: Maven Skins > Issue Type: Improvement >Reporter: Slawomir Jaranowski >Priority: Major > Attachments: image-2022-05-15-10-26-28-674.png, > image-2022-05-15-10-29-02-990.png, maven feather example.png, powered by > example.png, powered by example2.png, powered by.png > > > h2. Actual logo: > [https://www.apache.org/logos/#maven] > h2. Default Skin > !image-2022-05-15-10-26-28-674.png! > > h2. Fluido Skin > !image-2022-05-15-10-29-02-990.png! > -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Commented] (MSKINS-97) Upgrade to Bootstrap 5.x
[ https://issues.apache.org/jira/browse/MSKINS-97?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17556550#comment-17556550 ] Stephen Crocker commented on MSKINS-97: --- Bootstrap 3 introduced navbar-right to work with pull-right, this was replaced in float-end in Bootstrap v4. Frustratingly Bootstrap 5 ditched the concept and went in heavily with the flex system (introduced in Bootstrap v4). It means to replicate the alignment, a few class changes gets you almost there but its more layout work to get a replica. I also need to look at the Maven theme file, the CSS file clearly isn't injecting a theme like it did > Upgrade to Bootstrap 5.x > > > Key: MSKINS-97 > URL: https://issues.apache.org/jira/browse/MSKINS-97 > Project: Maven Skins > Issue Type: Task > Components: Fluido Skin >Reporter: Michael Osipov >Priority: Major > Fix For: fluido-2.0.0 > > > Next major of Fluido should be upgraded to Bootstrap 5.x which is *not* > backwards compatible to 2.x. See http://getbootstrap.com/migration/ -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Commented] (MSKINS-188) Build by use old Maven logo
[ https://issues.apache.org/jira/browse/MSKINS-188?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17555992#comment-17555992 ] Stephen Crocker commented on MSKINS-188: !powered by example2.png! The circle images are going to be interesting to get the alignment correct, I think I actually like yours the best > Build by use old Maven logo > --- > > Key: MSKINS-188 > URL: https://issues.apache.org/jira/browse/MSKINS-188 > Project: Maven Skins > Issue Type: Improvement >Reporter: Slawomir Jaranowski >Priority: Major > Attachments: image-2022-05-15-10-26-28-674.png, > image-2022-05-15-10-29-02-990.png, maven feather example.png, powered by > example.png, powered by example2.png, powered by.png > > > h2. Actual logo: > [https://www.apache.org/logos/#maven] > h2. Default Skin > !image-2022-05-15-10-26-28-674.png! > > h2. Fluido Skin > !image-2022-05-15-10-29-02-990.png! > -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Updated] (MSKINS-188) Build by use old Maven logo
[ https://issues.apache.org/jira/browse/MSKINS-188?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stephen Crocker updated MSKINS-188: --- Attachment: powered by example2.png > Build by use old Maven logo > --- > > Key: MSKINS-188 > URL: https://issues.apache.org/jira/browse/MSKINS-188 > Project: Maven Skins > Issue Type: Improvement >Reporter: Slawomir Jaranowski >Priority: Major > Attachments: image-2022-05-15-10-26-28-674.png, > image-2022-05-15-10-29-02-990.png, maven feather example.png, powered by > example.png, powered by example2.png, powered by.png > > > h2. Actual logo: > [https://www.apache.org/logos/#maven] > h2. Default Skin > !image-2022-05-15-10-26-28-674.png! > > h2. Fluido Skin > !image-2022-05-15-10-29-02-990.png! > -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Commented] (MSKINS-97) Upgrade to Bootstrap 5.x
[ https://issues.apache.org/jira/browse/MSKINS-97?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17554792#comment-17554792 ] Stephen Crocker commented on MSKINS-97: --- My last comment is out of date, MSKINS-191 lays a lot of the ground work for this. > Upgrade to Bootstrap 5.x > > > Key: MSKINS-97 > URL: https://issues.apache.org/jira/browse/MSKINS-97 > Project: Maven Skins > Issue Type: Task > Components: Fluido Skin >Reporter: Michael Osipov >Priority: Major > Fix For: fluido-2.0.0 > > > Next major of Fluido should be upgraded to Bootstrap 5.x which is *not* > backwards compatible to 2.x. See http://getbootstrap.com/migration/ -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Commented] (MSKINS-188) Build by use old Maven logo
[ https://issues.apache.org/jira/browse/MSKINS-188?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17554791#comment-17554791 ] Stephen Crocker commented on MSKINS-188: Example of first option embedded !powered by example.png! > Build by use old Maven logo > --- > > Key: MSKINS-188 > URL: https://issues.apache.org/jira/browse/MSKINS-188 > Project: Maven Skins > Issue Type: Improvement >Reporter: Slawomir Jaranowski >Priority: Major > Attachments: image-2022-05-15-10-26-28-674.png, > image-2022-05-15-10-29-02-990.png, maven feather example.png, powered by > example.png, powered by.png > > > h2. Actual logo: > [https://www.apache.org/logos/#maven] > h2. Default Skin > !image-2022-05-15-10-26-28-674.png! > > h2. Fluido Skin > !image-2022-05-15-10-29-02-990.png! > -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Updated] (MSKINS-188) Build by use old Maven logo
[ https://issues.apache.org/jira/browse/MSKINS-188?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stephen Crocker updated MSKINS-188: --- Attachment: powered by example.png > Build by use old Maven logo > --- > > Key: MSKINS-188 > URL: https://issues.apache.org/jira/browse/MSKINS-188 > Project: Maven Skins > Issue Type: Improvement >Reporter: Slawomir Jaranowski >Priority: Major > Attachments: image-2022-05-15-10-26-28-674.png, > image-2022-05-15-10-29-02-990.png, maven feather example.png, powered by > example.png, powered by.png > > > h2. Actual logo: > [https://www.apache.org/logos/#maven] > h2. Default Skin > !image-2022-05-15-10-26-28-674.png! > > h2. Fluido Skin > !image-2022-05-15-10-29-02-990.png! > -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Commented] (MSKINS-188) Build by use old Maven logo
[
https://issues.apache.org/jira/browse/MSKINS-188?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17554790#comment-17554790
]
Stephen Crocker commented on MSKINS-188:
Using an SVG allows us to escape the issue of HiDPI screens, but this hits a
second problem. An image has a maximum height/width and the previous solution
used this, an SVG doesn't so we want to dynamic size it based on the grid
system. The grid system in Bootstrap 2.x is based around spans like so:
{code:xml}
http://maven.apache.org/"; title="Built by Maven"
class="poweredBy">
{code}
SVG defines a viewport and the lines, text and shapes are based off of a
central coordinate point, so adding text objects to the SVG is fairly easy
(just open it in Karbon or Inkscape). Trying to overlay text at the HTML level
you loose the context of the central coordinate so we'll end up having to track
various screen widths and modify the margin/padding of the text, just so much
more effort.
The challenge is the text, the SVG letters are clearly drawn shapes (and not
text elements) so we need to locate the font (it is not maven pro). The second
issue is the logo itself, its changed and where ever I place "Built by" it ends
up making it look unbalanced.
I am thinking there are two ways forward.
The first is to embrace the Apache Powered by Idea here:
https://www.apache.org/foundation/press/kit/#poweredby which produces a logo
like this:
!powered by.png!
The second is to move away from powered by and go more for "organisation logo"
and let people enable it and supply an image which produces something like this:
!maven feather example.png!
> Build by use old Maven logo
> ---
>
> Key: MSKINS-188
> URL: https://issues.apache.org/jira/browse/MSKINS-188
> Project: Maven Skins
> Issue Type: Improvement
>Reporter: Slawomir Jaranowski
>Priority: Major
> Attachments: image-2022-05-15-10-26-28-674.png,
> image-2022-05-15-10-29-02-990.png, maven feather example.png, powered by.png
>
>
> h2. Actual logo:
> [https://www.apache.org/logos/#maven]
> h2. Default Skin
> !image-2022-05-15-10-26-28-674.png!
>
> h2. Fluido Skin
> !image-2022-05-15-10-29-02-990.png!
>
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
[jira] [Updated] (MSKINS-188) Build by use old Maven logo
[ https://issues.apache.org/jira/browse/MSKINS-188?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stephen Crocker updated MSKINS-188: --- Attachment: maven feather example.png > Build by use old Maven logo > --- > > Key: MSKINS-188 > URL: https://issues.apache.org/jira/browse/MSKINS-188 > Project: Maven Skins > Issue Type: Improvement >Reporter: Slawomir Jaranowski >Priority: Major > Attachments: image-2022-05-15-10-26-28-674.png, > image-2022-05-15-10-29-02-990.png, maven feather example.png, powered by.png > > > h2. Actual logo: > [https://www.apache.org/logos/#maven] > h2. Default Skin > !image-2022-05-15-10-26-28-674.png! > > h2. Fluido Skin > !image-2022-05-15-10-29-02-990.png! > -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Updated] (MSKINS-188) Build by use old Maven logo
[ https://issues.apache.org/jira/browse/MSKINS-188?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stephen Crocker updated MSKINS-188: --- Attachment: powered by.png > Build by use old Maven logo > --- > > Key: MSKINS-188 > URL: https://issues.apache.org/jira/browse/MSKINS-188 > Project: Maven Skins > Issue Type: Improvement >Reporter: Slawomir Jaranowski >Priority: Major > Attachments: image-2022-05-15-10-26-28-674.png, > image-2022-05-15-10-29-02-990.png, powered by.png > > > h2. Actual logo: > [https://www.apache.org/logos/#maven] > h2. Default Skin > !image-2022-05-15-10-26-28-674.png! > > h2. Fluido Skin > !image-2022-05-15-10-29-02-990.png! > -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Commented] (MSKINS-117) Improve lisibility and user-friendliness in the left menu
[ https://issues.apache.org/jira/browse/MSKINS-117?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17554307#comment-17554307 ] Stephen Crocker commented on MSKINS-117: This should be fairly straight forward to achieve by modifying the sidebar margins on sub items, I will create a branch. > Improve lisibility and user-friendliness in the left menu > - > > Key: MSKINS-117 > URL: https://issues.apache.org/jira/browse/MSKINS-117 > Project: Maven Skins > Issue Type: Wish > Components: Fluido Skin >Affects Versions: fluido-1.4 >Reporter: Cyril JACQUENOT >Priority: Major > Attachments: actual_skin_bad_lisibility.jpg, > skin_maven_old_better_lisibility.jpg > > > In our company, we now use *Maven Fluido Skin* for our projects > online-documentation. > I like the design but the lisibility is not optimal: it is hard for me to > find the location of my current page in the menu. > Great improvements should be : > * to increase indentations > * to use fonts weight to show different levels of indentation > * to give the possibility to manage more than 2 levels in the menu > _here is the bad lisibility skin :_ > !actual_skin_bad_lisibility.jpg! > _here is an old skin, but with *better lisibility* :_ > !skin_maven_old_better_lisibility.jpg! -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Commented] (MSKINS-109) Support HiDPI displays
[ https://issues.apache.org/jira/browse/MSKINS-109?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17554303#comment-17554303 ] Stephen Crocker commented on MSKINS-109: I don't have a 4k screen do the icons embeded into Bootstrap scale nicely you can see them here: https://icons.getbootstrap.com/ Fontawesome is normally the fallback when you can't find the appropriate icons, how does these look on a 4k monitor? https://fontawesome.com/search?s=thin > Support HiDPI displays > -- > > Key: MSKINS-109 > URL: https://issues.apache.org/jira/browse/MSKINS-109 > Project: Maven Skins > Issue Type: Improvement > Components: Fluido Skin >Affects Versions: fluido-1.3.1 > Environment: HiDPI/Retina display >Reporter: Hendrik Schreiber >Priority: Major > > Graphics provided in the skin (github ribbon, "Built by Maven", link icons, > ...) are only provided in standard resolution. By now, this looks amateurish > on screens with HiDPI (i.e. Retina displays). > Please provide hi res images that are scaled with width/height parameters so > that they look good on hi res displays. > Thanks. -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Commented] (MSKINS-188) Build by use old Maven logo
[ https://issues.apache.org/jira/browse/MSKINS-188?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17554292#comment-17554292 ] Stephen Crocker commented on MSKINS-188: The SVG of the logo is here: https://svn.apache.org/repos/asf/comdev/project-logos/originals/maven.svg. We have 3 logos https://github.com/apache/maven-fluido-skin/blob/master/src/main/resources/images/logos/build-by-maven-black.png https://github.com/apache/maven-fluido-skin/blob/master/src/main/resources/images/logos/build-by-maven-white.png https://github.com/apache/maven-fluido-skin/blob/master/src/main/resources/images/logos/maven-feather.png Moving to the SVG should allow better scaling on to High resolution screens. > Build by use old Maven logo > --- > > Key: MSKINS-188 > URL: https://issues.apache.org/jira/browse/MSKINS-188 > Project: Maven Skins > Issue Type: Improvement >Reporter: Slawomir Jaranowski >Priority: Major > Attachments: image-2022-05-15-10-26-28-674.png, > image-2022-05-15-10-29-02-990.png > > > h2. Actual logo: > [https://www.apache.org/logos/#maven] > h2. Default Skin > !image-2022-05-15-10-26-28-674.png! > > h2. Fluido Skin > !image-2022-05-15-10-29-02-990.png! > -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Commented] (MSKINS-175) Upgrade to JQuery 3.6.0 in Fluido skin
[ https://issues.apache.org/jira/browse/MSKINS-175?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17554289#comment-17554289 ] Stephen Crocker commented on MSKINS-175: I've created a branch to look at the feasibility, switching between 1.11.2 and 3.6.0 (latest release) doesnt break Bootstrap, Anchor.js or code-prettify. I've looked at various IT builds and everything is rendering and working correctly. > Upgrade to JQuery 3.6.0 in Fluido skin > -- > > Key: MSKINS-175 > URL: https://issues.apache.org/jira/browse/MSKINS-175 > Project: Maven Skins > Issue Type: Bug > Components: Fluido Skin >Reporter: László Langó >Priority: Critical > Labels: Securtity > > Please upgrade to JQuery 3.6.0 due to CVEs > ([CVE-2020-11022|https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2020-11022] > and > [CVE-2020-11023|https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2020-11023]) > affecting JQuery <3.5.0. -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Created] (MJAVADOC-717) Support Maven-Site approach
Stephen Crocker created MJAVADOC-717: Summary: Support Maven-Site approach Key: MJAVADOC-717 URL: https://issues.apache.org/jira/browse/MJAVADOC-717 Project: Maven Javadoc Plugin Issue Type: New Feature Reporter: Stephen Crocker The maven-javadoc-plugin currently creates its own independent website using Jquery, etc.. This means javadoc always looks separate from a site produced file. I would like to rewrite the plug-in so it uses the same Apache Velocity based template approach as the maven-site-plugin (and can be pointed at a maven-site-directory), the javadoc design should then sit within the same format as that generated output. I've noticed there is the 'java' and 'maven' style, I purpose the new approach is only taken for 'maven' projects with the existing code used for the 'java' type. -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Comment Edited] (MSKINS-97) Upgrade to Bootstrap 5.x
[ https://issues.apache.org/jira/browse/MSKINS-97?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17550249#comment-17550249 ] Stephen Crocker edited comment on MSKINS-97 at 6/5/22 8:50 PM: --- I would like to change the macro file layout to support the upgrade, things like the Navbar and footer sections have undergone quite a lot of modification. So I want to break them out into the following sections: * Header * Footer * Sidebar * Analytics * Social Media This then lets me raise a PR to change each file and helps group the templating we want to create. was (Author: JIRAUSER290518): I would like to change the macro file layout to support the upgrade, things like the Navbar and footer sections have undergone quite a lot of modification. So I want to break them out into the following sections: * Apache headers * Navbars * Sidebar * Analytics * Social Media This then lets me raise a PR to change each file and helps group the templating we want to create. > Upgrade to Bootstrap 5.x > > > Key: MSKINS-97 > URL: https://issues.apache.org/jira/browse/MSKINS-97 > Project: Maven Skins > Issue Type: Task > Components: Fluido Skin >Reporter: Michael Osipov >Priority: Major > Fix For: fluido-2.0.0 > > > Next major of Fluido should be upgraded to Bootstrap 5.x which is *not* > backwards compatible to 2.x. See http://getbootstrap.com/migration/ -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Comment Edited] (MSKINS-97) Upgrade to Bootstrap 5.x
[ https://issues.apache.org/jira/browse/MSKINS-97?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17550249#comment-17550249 ] Stephen Crocker edited comment on MSKINS-97 at 6/5/22 8:45 PM: --- I would like to change the macro file layout to support the upgrade, things like the Navbar and footer sections have undergone quite a lot of modification. So I want to break them out into the following sections: * Apache headers * Navbars * Sidebar * Analytics * Social Media This then lets me raise a PR to change each file and helps group the templating we want to create. was (Author: JIRAUSER290518): I would like to change the macro file layout to support the upgrade, things like the Navbar and footer sections have undergone quite a lot of modification. So I want to break them out into the following sections: * Apache headers * Navbars * Sidebar * Social Media This then lets me raise a PR to change each file and helps group the templating we want to create. > Upgrade to Bootstrap 5.x > > > Key: MSKINS-97 > URL: https://issues.apache.org/jira/browse/MSKINS-97 > Project: Maven Skins > Issue Type: Task > Components: Fluido Skin >Reporter: Michael Osipov >Priority: Major > Fix For: fluido-2.0.0 > > > Next major of Fluido should be upgraded to Bootstrap 5.x which is *not* > backwards compatible to 2.x. See http://getbootstrap.com/migration/ -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Commented] (MSKINS-97) Upgrade to Bootstrap 5.x
[ https://issues.apache.org/jira/browse/MSKINS-97?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17550249#comment-17550249 ] Stephen Crocker commented on MSKINS-97: --- I would like to change the macro file layout to support the upgrade, things like the Navbar and footer sections have undergone quite a lot of modification. So I want to break them out into the following sections: * Apache headers * Navbars * Sidebar * Social Media This then lets me raise a PR to change each file and helps group the templating we want to create. > Upgrade to Bootstrap 5.x > > > Key: MSKINS-97 > URL: https://issues.apache.org/jira/browse/MSKINS-97 > Project: Maven Skins > Issue Type: Task > Components: Fluido Skin >Reporter: Michael Osipov >Priority: Major > Fix For: fluido-2.0.0 > > > Next major of Fluido should be upgraded to Bootstrap 5.x which is *not* > backwards compatible to 2.x. See http://getbootstrap.com/migration/ -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Commented] (MSKINS-191) Update how project retreives bootstrap libraries
[ https://issues.apache.org/jira/browse/MSKINS-191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17550248#comment-17550248 ] Stephen Crocker commented on MSKINS-191: I have submitted PR: [https://github.com/apache/maven-fluido-skin/pull/32] My goal by this change is to help enable future bootstrap upgrades, by simplifying version upgrades to the property values. This means we can focus on changes to the HTML generated by the system when new releases are performed. > Update how project retreives bootstrap libraries > > > Key: MSKINS-191 > URL: https://issues.apache.org/jira/browse/MSKINS-191 > Project: Maven Skins > Issue Type: New Feature >Reporter: Stephen Crocker >Priority: Major > > Currently the Bootstrap library is included within the project itself, > Bootstrap builds and deploys into the NPM repository. We can use the > com.github.eirslett:frontend-maven-plugin plugin to pull down the boostrap > plugins and setting the project up for packaging. This should simplify > updates to the boostrap library. -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Created] (MSKINS-191) Update how project retreives bootstrap libraries
Stephen Crocker created MSKINS-191: -- Summary: Update how project retreives bootstrap libraries Key: MSKINS-191 URL: https://issues.apache.org/jira/browse/MSKINS-191 Project: Maven Skins Issue Type: New Feature Reporter: Stephen Crocker Currently the Bootstrap library is included within the project itself, Bootstrap builds and deploys into the NPM repository. We can use the com.github.eirslett:frontend-maven-plugin plugin to pull down the boostrap plugins and setting the project up for packaging. This should simplify updates to the boostrap library. -- This message was sent by Atlassian Jira (v8.20.7#820007)
