[jira] [Commented] (MPMD-383) PMD should fail when there is a processing error
[
https://issues.apache.org/jira/browse/MPMD-383?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17865067#comment-17865067
]
Thomas Nikolay commented on MPMD-383:
-
I agree with the arguments of [~adangel]
> PMD should fail when there is a processing error
>
>
> Key: MPMD-383
> URL: https://issues.apache.org/jira/browse/MPMD-383
> Project: Maven PMD Plugin
> Issue Type: Improvement
> Components: PMD
>Affects Versions: 3.21.0
>Reporter: Thomas Nikolay
>Priority: Critical
> Attachments: image-2023-07-28-13-34-28-717.png
>
>
> We had the case that PMD can't process some processing error but the build
> does not fail.
>
> {noformat}
> [2023-07-28T10:59:44.102Z] [INFO] --- maven-pmd-plugin:3.20.0:pmd (pmd) @
> mod-config-client-cst ---
> [2023-07-28T10:59:44.692Z] [INFO] PMD version: 6.53.0
> [2023-07-28T10:59:45.672Z] [WARNING] Removed misconfigured rule:
> GK-SAP-ApacheLoggerDeniedRule cause: missing value
> [2023-07-28T10:59:45.672Z] [WARNING] There are 3 PMD processing errors:
> [2023-07-28T10:59:45.672Z] [WARNING]
> /var/lib/hudson-slave/workspace/hmr.MAIN.00-FEATURE-BRANCHES/pos/config/mod-config-client-cst/src/test/java/com/gk_software/cst/client/AppInfoProviderImpl_CST_Test.java:
> PMDException: Error while processing
> /var/lib/hudson-slave/workspace/hmr.MAIN.00-FEATURE-BRANCHES/pos/config/mod-config-client-cst/src/test/java/com/gk_software/cst/client/AppInfoProviderImpl_CST_Test.java
> [2023-07-28T10:59:45.948Z]
> /var/lib/hudson-slave/workspace/hmr.MAIN.00-FEATURE-BRANCHES/pos/config/mod-config-client-cst/src/test/java/com/gk_software/pos/api/model/config/component/client/print/additional_printout/Trigger_CFH_CST_Test.java:
> PMDException: Error while processing
> /var/lib/hudson-slave/workspace/hmr.MAIN.00-FEATURE-BRANCHES/pos/config/mod-config-client-cst/src/test/java/com/gk_software/pos/api/model/config/component/client/print/additional_printout/Trigger_CFH_CST_Test.java
> [2023-07-28T10:59:45.948Z]
> /var/lib/hudson-slave/workspace/hmr.MAIN.00-FEATURE-BRANCHES/pos/config/mod-config-client-cst/src/main/java/com/gk_software/pos/api/model/config/component/client/print/additional_printout/Trigger_CFH_CST.java:
> PMDException: Error while processing
> /var/lib/hudson-slave/workspace/hmr.MAIN.00-FEATURE-BRANCHES/pos/config/mod-config-client-cst/src/main/java/com/gk_software/pos/api/model/config/component/client/print/additional_printout/Trigger_CFH_CST.java
> [2023-07-28T10:59:45.948Z] [INFO] Rendering content with
> org.apache.maven.skins:maven-default-skin:jar:1.3 skin.
> [2023-07-28T10:59:46.210Z] [INFO]
> [2023-07-28T10:59:46.210Z] [INFO] <<< maven-pmd-plugin:3.20.0:check
> (pmd-check) < :pmd @ mod-config-client-cst <<<
> {noformat}
>
> My expectation would be that the build failed when there a processing errors.
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Comment Edited] (MPMD-383) PMD should fail when there is a processing error
[
https://issues.apache.org/jira/browse/MPMD-383?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17841932#comment-17841932
]
Thomas Nikolay edited comment on MPMD-383 at 4/29/24 10:12 AM:
---
Andreas Dangel The parameter was not explicitly set - so it should use the
default value = true. That is, it works as designed. But from my point of view
this is a bad design decision.
Use case:
* Setting up a new project
* Setup PMD with errors
* New developer without experience develops some code - no errors appear
* Developer doesn't know he made some bugs
* after a while, someone with experience discovers that PMD does not work and
activates it. Then the code needs to be refactored.
My proposal would to set the default value to false
was (Author: tnikolay):
Andreas Dangel The parameter was not explicitly set - so it should use the
default value = true. That is, it works as designed. But from my point of view
this is a bad design decision.
Use case:
* Setting up a new project
* Setup PMD with errors
* New developer without experience develops some code - no errors appear
* Developer doesn't know he made some bugs
* after a while, someone with experience discovers that PMD does not work and
activates it. Then the code needs to be refactored.
> PMD should fail when there is a processing error
>
>
> Key: MPMD-383
> URL: https://issues.apache.org/jira/browse/MPMD-383
> Project: Maven PMD Plugin
> Issue Type: Improvement
> Components: PMD
>Affects Versions: 3.21.0
>Reporter: Thomas Nikolay
>Priority: Critical
> Fix For: waiting-for-feedback
>
> Attachments: image-2023-07-28-13-34-28-717.png
>
>
> We had the case that PMD can't process some processing error but the build
> does not fail.
>
> {noformat}
> [2023-07-28T10:59:44.102Z] [INFO] --- maven-pmd-plugin:3.20.0:pmd (pmd) @
> mod-config-client-cst ---
> [2023-07-28T10:59:44.692Z] [INFO] PMD version: 6.53.0
> [2023-07-28T10:59:45.672Z] [WARNING] Removed misconfigured rule:
> GK-SAP-ApacheLoggerDeniedRule cause: missing value
> [2023-07-28T10:59:45.672Z] [WARNING] There are 3 PMD processing errors:
> [2023-07-28T10:59:45.672Z] [WARNING]
> /var/lib/hudson-slave/workspace/hmr.MAIN.00-FEATURE-BRANCHES/pos/config/mod-config-client-cst/src/test/java/com/gk_software/cst/client/AppInfoProviderImpl_CST_Test.java:
> PMDException: Error while processing
> /var/lib/hudson-slave/workspace/hmr.MAIN.00-FEATURE-BRANCHES/pos/config/mod-config-client-cst/src/test/java/com/gk_software/cst/client/AppInfoProviderImpl_CST_Test.java
> [2023-07-28T10:59:45.948Z]
> /var/lib/hudson-slave/workspace/hmr.MAIN.00-FEATURE-BRANCHES/pos/config/mod-config-client-cst/src/test/java/com/gk_software/pos/api/model/config/component/client/print/additional_printout/Trigger_CFH_CST_Test.java:
> PMDException: Error while processing
> /var/lib/hudson-slave/workspace/hmr.MAIN.00-FEATURE-BRANCHES/pos/config/mod-config-client-cst/src/test/java/com/gk_software/pos/api/model/config/component/client/print/additional_printout/Trigger_CFH_CST_Test.java
> [2023-07-28T10:59:45.948Z]
> /var/lib/hudson-slave/workspace/hmr.MAIN.00-FEATURE-BRANCHES/pos/config/mod-config-client-cst/src/main/java/com/gk_software/pos/api/model/config/component/client/print/additional_printout/Trigger_CFH_CST.java:
> PMDException: Error while processing
> /var/lib/hudson-slave/workspace/hmr.MAIN.00-FEATURE-BRANCHES/pos/config/mod-config-client-cst/src/main/java/com/gk_software/pos/api/model/config/component/client/print/additional_printout/Trigger_CFH_CST.java
> [2023-07-28T10:59:45.948Z] [INFO] Rendering content with
> org.apache.maven.skins:maven-default-skin:jar:1.3 skin.
> [2023-07-28T10:59:46.210Z] [INFO]
> [2023-07-28T10:59:46.210Z] [INFO] <<< maven-pmd-plugin:3.20.0:check
> (pmd-check) < :pmd @ mod-config-client-cst <<<
> {noformat}
>
> My expectation would be that the build failed when there a processing errors.
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MPMD-383) PMD should fail when there is a processing error
[
https://issues.apache.org/jira/browse/MPMD-383?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17841932#comment-17841932
]
Thomas Nikolay commented on MPMD-383:
-
Andreas Dangel The parameter was not explicitly set - so it should use the
default value = true. That is, it works as designed. But from my point of view
this is a bad design decision.
Use case:
* Setting up a new project
* Setup PMD with errors
* New developer without experience develops some code - no errors appear
* Developer doesn't know he made some bugs
* after a while, someone with experience discovers that PMD does not work and
activates it. Then the code needs to be refactored.
> PMD should fail when there is a processing error
>
>
> Key: MPMD-383
> URL: https://issues.apache.org/jira/browse/MPMD-383
> Project: Maven PMD Plugin
> Issue Type: Improvement
> Components: PMD
>Affects Versions: 3.21.0
>Reporter: Thomas Nikolay
>Priority: Critical
> Fix For: waiting-for-feedback
>
> Attachments: image-2023-07-28-13-34-28-717.png
>
>
> We had the case that PMD can't process some processing error but the build
> does not fail.
>
> {noformat}
> [2023-07-28T10:59:44.102Z] [INFO] --- maven-pmd-plugin:3.20.0:pmd (pmd) @
> mod-config-client-cst ---
> [2023-07-28T10:59:44.692Z] [INFO] PMD version: 6.53.0
> [2023-07-28T10:59:45.672Z] [WARNING] Removed misconfigured rule:
> GK-SAP-ApacheLoggerDeniedRule cause: missing value
> [2023-07-28T10:59:45.672Z] [WARNING] There are 3 PMD processing errors:
> [2023-07-28T10:59:45.672Z] [WARNING]
> /var/lib/hudson-slave/workspace/hmr.MAIN.00-FEATURE-BRANCHES/pos/config/mod-config-client-cst/src/test/java/com/gk_software/cst/client/AppInfoProviderImpl_CST_Test.java:
> PMDException: Error while processing
> /var/lib/hudson-slave/workspace/hmr.MAIN.00-FEATURE-BRANCHES/pos/config/mod-config-client-cst/src/test/java/com/gk_software/cst/client/AppInfoProviderImpl_CST_Test.java
> [2023-07-28T10:59:45.948Z]
> /var/lib/hudson-slave/workspace/hmr.MAIN.00-FEATURE-BRANCHES/pos/config/mod-config-client-cst/src/test/java/com/gk_software/pos/api/model/config/component/client/print/additional_printout/Trigger_CFH_CST_Test.java:
> PMDException: Error while processing
> /var/lib/hudson-slave/workspace/hmr.MAIN.00-FEATURE-BRANCHES/pos/config/mod-config-client-cst/src/test/java/com/gk_software/pos/api/model/config/component/client/print/additional_printout/Trigger_CFH_CST_Test.java
> [2023-07-28T10:59:45.948Z]
> /var/lib/hudson-slave/workspace/hmr.MAIN.00-FEATURE-BRANCHES/pos/config/mod-config-client-cst/src/main/java/com/gk_software/pos/api/model/config/component/client/print/additional_printout/Trigger_CFH_CST.java:
> PMDException: Error while processing
> /var/lib/hudson-slave/workspace/hmr.MAIN.00-FEATURE-BRANCHES/pos/config/mod-config-client-cst/src/main/java/com/gk_software/pos/api/model/config/component/client/print/additional_printout/Trigger_CFH_CST.java
> [2023-07-28T10:59:45.948Z] [INFO] Rendering content with
> org.apache.maven.skins:maven-default-skin:jar:1.3 skin.
> [2023-07-28T10:59:46.210Z] [INFO]
> [2023-07-28T10:59:46.210Z] [INFO] <<< maven-pmd-plugin:3.20.0:check
> (pmd-check) < :pmd @ mod-config-client-cst <<<
> {noformat}
>
> My expectation would be that the build failed when there a processing errors.
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Created] (MPMD-383) PMD should fail when there is a processing error
Thomas Nikolay created MPMD-383:
---
Summary: PMD should fail when there is a processing error
Key: MPMD-383
URL: https://issues.apache.org/jira/browse/MPMD-383
Project: Maven PMD Plugin
Issue Type: Improvement
Components: PMD
Affects Versions: 3.21.0
Reporter: Thomas Nikolay
Attachments: image-2023-07-28-13-34-28-717.png
We had the case that PMD can't process some processing error but the build does
not fail.
{noformat}
[2023-07-28T10:59:44.102Z] [INFO] --- maven-pmd-plugin:3.20.0:pmd (pmd) @
mod-config-client-cst ---
[2023-07-28T10:59:44.692Z] [INFO] PMD version: 6.53.0
[2023-07-28T10:59:45.672Z] [WARNING] Removed misconfigured rule:
GK-SAP-ApacheLoggerDeniedRule cause: missing value
[2023-07-28T10:59:45.672Z] [WARNING] There are 3 PMD processing errors:
[2023-07-28T10:59:45.672Z] [WARNING]
/var/lib/hudson-slave/workspace/hmr.MAIN.00-FEATURE-BRANCHES/pos/config/mod-config-client-cst/src/test/java/com/gk_software/cst/client/AppInfoProviderImpl_CST_Test.java:
PMDException: Error while processing
/var/lib/hudson-slave/workspace/hmr.MAIN.00-FEATURE-BRANCHES/pos/config/mod-config-client-cst/src/test/java/com/gk_software/cst/client/AppInfoProviderImpl_CST_Test.java
[2023-07-28T10:59:45.948Z]
/var/lib/hudson-slave/workspace/hmr.MAIN.00-FEATURE-BRANCHES/pos/config/mod-config-client-cst/src/test/java/com/gk_software/pos/api/model/config/component/client/print/additional_printout/Trigger_CFH_CST_Test.java:
PMDException: Error while processing
/var/lib/hudson-slave/workspace/hmr.MAIN.00-FEATURE-BRANCHES/pos/config/mod-config-client-cst/src/test/java/com/gk_software/pos/api/model/config/component/client/print/additional_printout/Trigger_CFH_CST_Test.java
[2023-07-28T10:59:45.948Z]
/var/lib/hudson-slave/workspace/hmr.MAIN.00-FEATURE-BRANCHES/pos/config/mod-config-client-cst/src/main/java/com/gk_software/pos/api/model/config/component/client/print/additional_printout/Trigger_CFH_CST.java:
PMDException: Error while processing
/var/lib/hudson-slave/workspace/hmr.MAIN.00-FEATURE-BRANCHES/pos/config/mod-config-client-cst/src/main/java/com/gk_software/pos/api/model/config/component/client/print/additional_printout/Trigger_CFH_CST.java
[2023-07-28T10:59:45.948Z] [INFO] Rendering content with
org.apache.maven.skins:maven-default-skin:jar:1.3 skin.
[2023-07-28T10:59:46.210Z] [INFO]
[2023-07-28T10:59:46.210Z] [INFO] <<< maven-pmd-plugin:3.20.0:check (pmd-check)
< :pmd @ mod-config-client-cst <<<
{noformat}
My expectation would be that the build failed when there a processing errors.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Created] (MENFORCER-326) Log output
Thomas Nikolay created MENFORCER-326:
Summary: Log output
Key: MENFORCER-326
URL: https://issues.apache.org/jira/browse/MENFORCER-326
Project: Maven Enforcer Plugin
Issue Type: Improvement
Components: Plugin
Affects Versions: 3.0.0-M2
Reporter: Thomas Nikolay
Please improve the output - because it is not clear which rule execution raise
an error
{noformat}
INFO] --- maven-enforcer-plugin:3.0.0-M2:enforce (enforce-plugin-versions) @
bhs-ws-interface ---
[INFO] Adding ignore: module-info
[INFO] Adding ignore: META-INF/versions/*/module-info
[INFO] Adding ignore: org.jaxen.*
[INFO] Adding ignore: org.xml.sax.*
[INFO] Adding ignore: com.l2fprod.common.*
[INFO] Adding ignore: net.sf.json.*
[INFO] Adding ignore: com.eviware.soapui.analytics.providers.*
[INFO] Adding ignore: net.sf.ezmorph.*
[INFO] Adding ignore: org.apache.xmlbeans.*
[INFO] Adding ignore: schemaorg_apache_xmlbeans.system.*
[INFO] Adding ignore: org.apache.commons.httpclient.*
[INFO] Adding ignore: org.w3c.dom.*
[INFO] Adding ignore: org.aopalliance.*
[INFO] Adding ignorable dependency: null:jaxb-core:null
[INFO] Adding ignore: com.sun.istack.*
[INFO] Adding ignorable dependency: null:xml-apis:null
[INFO] Adding ignore: org.w3c.dom.*
[INFO] Adding ignore: javax.xml.*
[INFO] Adding ignorable dependency: null:cxf-bundle-jaxrs:null
[INFO] Adding ignore: org.apache.cxf.*
[INFO] Adding ignorable dependency: null:asm:null
[INFO] Adding ignore: org.objectweb.*
[INFO] Adding ignorable dependency: null:shtrihjavapos:null
[INFO] Adding ignore: *
[INFO] Adding ignorable dependency: null:commons-collections:null
[INFO] Adding ignore: org.apache.commons.collections.*
[INFO] Adding ignorable dependency: null:commons-beanutils:null
[INFO] Adding ignore: org.apache.commons.beanutils.*
[INFO] Adding ignorable dependency: null:lib-common-utils:null
[INFO] Adding ignore: org.springframework.beans.CachedIntrospectionResults
[INFO] Adding ignorable dependency: null:bcprov-jdk15on:null
[INFO] Adding ignore: org.bouncycastle.*
[INFO] Adding ignorable dependency: null:bcprov-ext-jdk15on:null
[INFO] Adding ignore: org.bouncycastle.*
[INFO] Adding ignorable dependency: null:geronimo-jaxws_2.2_spec:null
[INFO] Adding ignore: org.apache.geronimo.osgi.locator.*
[INFO] Adding ignorable dependency: null:org.eclipse.jdt.core:null
[INFO] Adding ignore: org.eclipse.jdt.*
[INFO] Adding ignorable dependency: null:mod-reporting-if:null
[INFO] Adding ignorable dependency: null:namespace:null
[INFO] Adding ignore: javax.xml.*
[INFO] Adding ignorable dependency: null:mod-md-master-data-api:null
[INFO] Adding ignorable dependency: null:stax-api:null
[INFO] Adding ignore: javax.xml.stream.*
[INFO] Adding ignorable dependency: null:barcode4j-light:null
[INFO] Adding ignore: *
[INFO] Adding ignorable dependency: null:mod-data-provider-server:null
[INFO] Adding ignore: com.sap.*
[INFO] Adding ignorable dependency: null:commons-logging-api:null
[INFO] Adding ignore: org.apache.commons.logging.*
[INFO] Adding ignorable dependency: org.apache.derby:derby:null
[INFO] Adding ignore: org.apache.derby.*
[INFO] Adding ignorable dependency: org.apache.xmlgraphics:batik-ext:null
[INFO] Adding ignore: org.w3c.*
[INFO] Adding ignorable dependency: jfree:jcommon:null
[INFO] Adding ignore: com.keypoint.PngEncoder
[INFO] Adding ignorable dependency: aopalliance:aopalliance:null
[INFO] Adding ignore: org.aopalliance*
[INFO] Adding ignorable dependency:
org.apache.geronimo.specs:geronimo-javamail_1.4_spec:null
[INFO] Adding ignore: javax.mail.*
[INFO] Adding ignorable dependency: org.mortbay.jetty:servlet-api:null
[INFO] Adding ignore: javax.servlet.*
[INFO] Adding ignorable dependency: com.google.code.findbugs:jsr305:null
[INFO] Adding ignore: javax.annotation.*
[WARNING] Could not find org.powermock:powermock-reflect:jar:1.7.3:test at null
[WARNING] Could not find
org.powermock:powermock-module-junit4-common:jar:1.7.3:test at null
[WARNING] Could not find
org.apache.cxf:cxf-rt-frontend-jaxrs:jar:2.7.18:compile at null
[WARNING] Could not find
org.codehaus.jackson:jackson-mapper-asl:jar:1.9.11:compile at null
[WARNING] Could not find
org.apache.cxf:cxf-rt-frontend-jaxws:jar:2.7.18:compile at null
[WARNING] Could not find
org.powermock:powermock-module-junit4-legacy:jar:1.7.3:test at null
[WARNING] Could not find org.codehaus.jackson:jackson-xc:jar:1.9.11:compile at
null
[WARNING] Could not find org.powermock:powermock-api-mockito:jar:1.7.3:test at
null
[WARNING] Could not find org.mockito:mockito-core:jar:1.10.19:test at null
[WARNING] Could not find org.apache.derby:derby:jar:10.10.2.0:test at null
[WARNING] Could not find
com.smartbear.soapui:soapui-maven-plugin:jar:5.2.1:test at null
[WARNING] Could not find org.powermock:powermock-api-support:jar:1.7.3:test at
null
[WARNING] Could not find
org.powermock:powermock-classloading-base:jar:1.7.3:test
[jira] [Commented] (MNG-6311) Maven intolerably slow when import scope used heavily in large project
[ https://issues.apache.org/jira/browse/MNG-6311?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16603021#comment-16603021 ] Thomas Nikolay commented on MNG-6311: - [~khmarbaise] when is the release planned? > Maven intolerably slow when import scope used heavily in large project > -- > > Key: MNG-6311 > URL: https://issues.apache.org/jira/browse/MNG-6311 > Project: Maven > Issue Type: Bug > Components: core, Performance >Affects Versions: 3.5.0, 3.5.2 >Reporter: David Churcher >Priority: Major > Labels: performance > Fix For: 3.6.0 > > Attachments: Call-tree-–-All-threads-together.html, > anon-hierarchy-maven-output.zip, modelcachefix.diff > > > I have a build performance problem that is identical to MNG-5312, and has > appeared since MNG-6030 in Maven v3.5.0 reversed the patch for MNG-5312, > removing the ModelCache from some of the overloads for > DefaultProjectBuilder.build. > As in MNG-5312 the problem is in a large proprietary project. It uses up to 8 > levels of parent POMs, many of which use the import scope and have large > dependency-management sections, and has hundreds of dependencies that also > use the same parent POM hierarchy. Adding some logging shows that Maven does > over 800,000 uncached reads of parent POM files, which takes about half an > hour. With model caching this goes down to a few seconds. > I've attached a patch that fixes this by using a class-level ModelCache in > DefaultProjectBuilder. This does not suffer from the memory usage problems > reported in MNG-6030. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (MNG-6311) Maven intolerably slow when import scope used heavily in large project
[ https://issues.apache.org/jira/browse/MNG-6311?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16602724#comment-16602724 ] Thomas Nikolay commented on MNG-6311: - you're welcome - that also for me great news because it is very critical topic for our company. > Maven intolerably slow when import scope used heavily in large project > -- > > Key: MNG-6311 > URL: https://issues.apache.org/jira/browse/MNG-6311 > Project: Maven > Issue Type: Bug > Components: core, Performance >Affects Versions: 3.5.0, 3.5.2 >Reporter: David Churcher >Priority: Major > Labels: performance > Attachments: Call-tree-–-All-threads-together.html, > anon-hierarchy-maven-output.zip, modelcachefix.diff > > > I have a build performance problem that is identical to MNG-5312, and has > appeared since MNG-6030 in Maven v3.5.0 reversed the patch for MNG-5312, > removing the ModelCache from some of the overloads for > DefaultProjectBuilder.build. > As in MNG-5312 the problem is in a large proprietary project. It uses up to 8 > levels of parent POMs, many of which use the import scope and have large > dependency-management sections, and has hundreds of dependencies that also > use the same parent POM hierarchy. Adding some logging shows that Maven does > over 800,000 uncached reads of parent POM files, which takes about half an > hour. With model caching this goes down to a few seconds. > I've attached a patch that fixes this by using a class-level ModelCache in > DefaultProjectBuilder. This does not suffer from the memory usage problems > reported in MNG-6030. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (MNG-6311) Maven intolerably slow when import scope used heavily in large project
[ https://issues.apache.org/jira/browse/MNG-6311?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16602718#comment-16602718 ] Thomas Nikolay commented on MNG-6311: - I tested yesterday both. The current master have already the problem with the slow build and the branch with the fix doesn't have the problem. > Maven intolerably slow when import scope used heavily in large project > -- > > Key: MNG-6311 > URL: https://issues.apache.org/jira/browse/MNG-6311 > Project: Maven > Issue Type: Bug > Components: core, Performance >Affects Versions: 3.5.0, 3.5.2 >Reporter: David Churcher >Priority: Major > Labels: performance > Attachments: Call-tree-–-All-threads-together.html, > anon-hierarchy-maven-output.zip, modelcachefix.diff > > > I have a build performance problem that is identical to MNG-5312, and has > appeared since MNG-6030 in Maven v3.5.0 reversed the patch for MNG-5312, > removing the ModelCache from some of the overloads for > DefaultProjectBuilder.build. > As in MNG-5312 the problem is in a large proprietary project. It uses up to 8 > levels of parent POMs, many of which use the import scope and have large > dependency-management sections, and has hundreds of dependencies that also > use the same parent POM hierarchy. Adding some logging shows that Maven does > over 800,000 uncached reads of parent POM files, which takes about half an > hour. With model caching this goes down to a few seconds. > I've attached a patch that fixes this by using a class-level ModelCache in > DefaultProjectBuilder. This does not suffer from the memory usage problems > reported in MNG-6030. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Comment Edited] (MNG-6311) Maven intolerably slow when import scope used heavily in large project
[ https://issues.apache.org/jira/browse/MNG-6311?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16602261#comment-16602261 ] Thomas Nikolay edited comment on MNG-6311 at 9/3/18 2:57 PM: - [~khmarbaise] , [~slachiewicz] you can this not test on the master because it is on a fix branch fix/MNG-6311. But I checked it out from there and build of maven. After that I run a smoke test on the affected project and it was faster as before 3.3.9 :) was (Author: tnikolay): [~khmarbaise] you can this not test on the master because it is on a fix branch fix/MNG-6311. But I checked it out from there and build of maven. After that I run a smoke test on the affected project and it was faster as before 3.3.9 :) > Maven intolerably slow when import scope used heavily in large project > -- > > Key: MNG-6311 > URL: https://issues.apache.org/jira/browse/MNG-6311 > Project: Maven > Issue Type: Bug > Components: core, Performance >Affects Versions: 3.5.0, 3.5.2 >Reporter: David Churcher >Priority: Major > Labels: performance > Attachments: Call-tree-–-All-threads-together.html, > anon-hierarchy-maven-output.zip, modelcachefix.diff > > > I have a build performance problem that is identical to MNG-5312, and has > appeared since MNG-6030 in Maven v3.5.0 reversed the patch for MNG-5312, > removing the ModelCache from some of the overloads for > DefaultProjectBuilder.build. > As in MNG-5312 the problem is in a large proprietary project. It uses up to 8 > levels of parent POMs, many of which use the import scope and have large > dependency-management sections, and has hundreds of dependencies that also > use the same parent POM hierarchy. Adding some logging shows that Maven does > over 800,000 uncached reads of parent POM files, which takes about half an > hour. With model caching this goes down to a few seconds. > I've attached a patch that fixes this by using a class-level ModelCache in > DefaultProjectBuilder. This does not suffer from the memory usage problems > reported in MNG-6030. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (MNG-6311) Maven intolerably slow when import scope used heavily in large project
[ https://issues.apache.org/jira/browse/MNG-6311?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16602261#comment-16602261 ] Thomas Nikolay commented on MNG-6311: - [~khmarbaise] you can this not test on the master because it is on a fix branch fix/MNG-6311. But I checked it out from there and build of maven. After that I run a smoke test on the affected project and it was faster as before 3.3.9 :) > Maven intolerably slow when import scope used heavily in large project > -- > > Key: MNG-6311 > URL: https://issues.apache.org/jira/browse/MNG-6311 > Project: Maven > Issue Type: Bug > Components: core, Performance >Affects Versions: 3.5.0, 3.5.2 >Reporter: David Churcher >Priority: Major > Labels: performance > Attachments: Call-tree-–-All-threads-together.html, > anon-hierarchy-maven-output.zip, modelcachefix.diff > > > I have a build performance problem that is identical to MNG-5312, and has > appeared since MNG-6030 in Maven v3.5.0 reversed the patch for MNG-5312, > removing the ModelCache from some of the overloads for > DefaultProjectBuilder.build. > As in MNG-5312 the problem is in a large proprietary project. It uses up to 8 > levels of parent POMs, many of which use the import scope and have large > dependency-management sections, and has hundreds of dependencies that also > use the same parent POM hierarchy. Adding some logging shows that Maven does > over 800,000 uncached reads of parent POM files, which takes about half an > hour. With model caching this goes down to a few seconds. > I've attached a patch that fixes this by using a class-level ModelCache in > DefaultProjectBuilder. This does not suffer from the memory usage problems > reported in MNG-6030. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Comment Edited] (MNG-6311) Maven intolerably slow when import scope used heavily in large project
[ https://issues.apache.org/jira/browse/MNG-6311?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16487007#comment-16487007 ] Thomas Nikolay edited comment on MNG-6311 at 5/23/18 10:07 AM: --- Our Company runs in the same problem with very large POM structures and imports. This is currently a blocker to migrate from 3.3.9 to 3.5.X. The same POM with JDK 1.8.0_112 * with MVN 3.3.9 duration = 6 seconds * with MVN 3.5.2 duration = 107 seconds I analysed with Yourkit [^Call-tree-–-All-threads-together.html] was (Author: tnikolay): Our Company runs in the same problem with very large POM structures and imports. This is currently a blocker to migrate from 3.3.9 to 3.5.X. I analysed with Yourkit [^Call-tree-–-All-threads-together.html] > Maven intolerably slow when import scope used heavily in large project > -- > > Key: MNG-6311 > URL: https://issues.apache.org/jira/browse/MNG-6311 > Project: Maven > Issue Type: Bug > Components: core, Performance >Affects Versions: 3.5.0, 3.5.2 >Reporter: David Churcher >Priority: Major > Labels: performance > Attachments: Call-tree-–-All-threads-together.html, > anon-hierarchy-maven-output.zip, modelcachefix.diff > > > I have a build performance problem that is identical to MNG-5312, and has > appeared since MNG-6030 in Maven v3.5.0 reversed the patch for MNG-5312, > removing the ModelCache from some of the overloads for > DefaultProjectBuilder.build. > As in MNG-5312 the problem is in a large proprietary project. It uses up to 8 > levels of parent POMs, many of which use the import scope and have large > dependency-management sections, and has hundreds of dependencies that also > use the same parent POM hierarchy. Adding some logging shows that Maven does > over 800,000 uncached reads of parent POM files, which takes about half an > hour. With model caching this goes down to a few seconds. > I've attached a patch that fixes this by using a class-level ModelCache in > DefaultProjectBuilder. This does not suffer from the memory usage problems > reported in MNG-6030. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (MNG-6311) Maven intolerably slow when import scope used heavily in large project
[ https://issues.apache.org/jira/browse/MNG-6311?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16487007#comment-16487007 ] Thomas Nikolay commented on MNG-6311: - Our Company runs in the same problem with very large POM structures and imports. This is currently a blocker to migrate from 3.3.9 to 3.5.X. I analysed with Yourkit [^Call-tree-–-All-threads-together.html] > Maven intolerably slow when import scope used heavily in large project > -- > > Key: MNG-6311 > URL: https://issues.apache.org/jira/browse/MNG-6311 > Project: Maven > Issue Type: Bug > Components: core, Performance >Affects Versions: 3.5.0, 3.5.2 >Reporter: David Churcher >Priority: Major > Labels: performance > Attachments: Call-tree-–-All-threads-together.html, > anon-hierarchy-maven-output.zip, modelcachefix.diff > > > I have a build performance problem that is identical to MNG-5312, and has > appeared since MNG-6030 in Maven v3.5.0 reversed the patch for MNG-5312, > removing the ModelCache from some of the overloads for > DefaultProjectBuilder.build. > As in MNG-5312 the problem is in a large proprietary project. It uses up to 8 > levels of parent POMs, many of which use the import scope and have large > dependency-management sections, and has hundreds of dependencies that also > use the same parent POM hierarchy. Adding some logging shows that Maven does > over 800,000 uncached reads of parent POM files, which takes about half an > hour. With model caching this goes down to a few seconds. > I've attached a patch that fixes this by using a class-level ModelCache in > DefaultProjectBuilder. This does not suffer from the memory usage problems > reported in MNG-6030. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (MNG-6311) Maven intolerably slow when import scope used heavily in large project
[ https://issues.apache.org/jira/browse/MNG-6311?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Thomas Nikolay updated MNG-6311: Attachment: Call-tree-–-All-threads-together.html > Maven intolerably slow when import scope used heavily in large project > -- > > Key: MNG-6311 > URL: https://issues.apache.org/jira/browse/MNG-6311 > Project: Maven > Issue Type: Bug > Components: core, Performance >Affects Versions: 3.5.0, 3.5.2 >Reporter: David Churcher >Priority: Major > Labels: performance > Attachments: Call-tree-–-All-threads-together.html, > anon-hierarchy-maven-output.zip, modelcachefix.diff > > > I have a build performance problem that is identical to MNG-5312, and has > appeared since MNG-6030 in Maven v3.5.0 reversed the patch for MNG-5312, > removing the ModelCache from some of the overloads for > DefaultProjectBuilder.build. > As in MNG-5312 the problem is in a large proprietary project. It uses up to 8 > levels of parent POMs, many of which use the import scope and have large > dependency-management sections, and has hundreds of dependencies that also > use the same parent POM hierarchy. Adding some logging shows that Maven does > over 800,000 uncached reads of parent POM files, which takes about half an > hour. With model caching this goes down to a few seconds. > I've attached a patch that fixes this by using a class-level ModelCache in > DefaultProjectBuilder. This does not suffer from the memory usage problems > reported in MNG-6030. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
