[jira] [Created] (MNG-7780) DefaultArtifact.equals throws NullPointerException if o.version is null
Tobias Gruetzmacher created MNG-7780: Summary: DefaultArtifact.equals throws NullPointerException if o.version is null Key: MNG-7780 URL: https://issues.apache.org/jira/browse/MNG-7780 Project: Maven Issue Type: Bug Affects Versions: 4.0.0-alpha-5, 3.9.1 Reporter: Tobias Gruetzmacher DefaultArtifact.validateIdentity() only throws if BOTH version and versionRange are null, so it's possible to create an instance of DefaultArtifact where version == null. If such an instance ever ends up in DefaultArtifact.equals(o), the check {{a.getVersion().equals(version)}} will throw a NullPointerException. (This was observed while debugging an issue in versions-maven-plugin) -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MENFORCER-334) Regression: pluginVersions in Parent-POM pluginManagement not working
[ https://issues.apache.org/jira/browse/MENFORCER-334?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16988570#comment-16988570 ] Tobias Gruetzmacher commented on MENFORCER-334: --- Is this the same as MENFORCER-306? > Regression: pluginVersions in Parent-POM pluginManagement not working > - > > Key: MENFORCER-334 > URL: https://issues.apache.org/jira/browse/MENFORCER-334 > Project: Maven Enforcer Plugin > Issue Type: Bug > Components: Plugin >Affects Versions: 3.0.0-M2 > Environment: Maven 3.6.1, Ubuntu 18.04 LTS, Oracle JDK 1.8.0_181 >Reporter: Wolf Geldmacher >Priority: Major > Attachments: enforcer-regression.zip > > > The enforcer plugin no longer accepts versions defined in a parent POMs > pluginManagement section. > In the example project attached you will find two pom.xml files. The one in > the parent directory is to be installed/deployed into the repository and then > to be used as parent POM in the project stub of the project directory. > If the parent defines version 1.4.1 for the maven-enforcer-plugin, everything > works as expected (i.e. when running "mvn validate" in the "project" > directory validation succeeds), when the parent defines version 3.0.0-M2, > validation fails with: > [INFO] --- maven-enforcer-plugin:3.0.0-M2:enforce (default) @ project --- > [WARNING] Rule 0: org.apache.maven.plugins.enforcer.RequirePluginVersions > failed with message: > Some plugins are missing valid versions:(LATEST RELEASE SNAPSHOT are not > allowed ) > org.apache.maven.plugins:maven-compiler-plugin. The version currently in use > is 3.8.1 > org.apache.maven.plugins:maven-surefire-plugin. The version currently in use > is 3.0.0-M3 > org.apache.maven.plugins:maven-jar-plugin. The version currently in use is > 3.1.2 > org.apache.maven.plugins:maven-clean-plugin. The version currently in use is > 3.1.0 > org.apache.maven.plugins:maven-install-plugin. The version currently in use > is 3.0.0-M1 > org.apache.maven.plugins:maven-site-plugin. The version currently in use is > 3.7.1 > org.apache.maven.plugins:maven-resources-plugin. The version currently in use > is 3.1.0 > org.apache.maven.plugins:maven-deploy-plugin. The version currently in use is > 3.0.0-M1 > org.apache.maven.plugins:maven-enforcer-plugin. The version currently in use > is 3.0.0-M2 > Best Practice is to always define plugin versions! > even though these versions have been defined in the pluginManagement section > of the parent. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (MNG-6642) Tycho-based modules do not build with 3.6.1 (works with 3.6.0)
[ https://issues.apache.org/jira/browse/MNG-6642?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16819044#comment-16819044 ] Tobias Gruetzmacher commented on MNG-6642: -- Bisecting yields: {code:java} bb3ec5da71d26d105972392f0a20bc61bc5d8c53 is the first bad commit commit bb3ec5da71d26d105972392f0a20bc61bc5d8c53 Author: Sylwester Lachiewicz Date: Sat Oct 13 04:16:44 2018 +0200 [MNG-5995] Remove dependency to maven-compat (#185) No implementation for deprecated Maven 2.x RepositorySystem interface {code} (if I didn't do anything wrong) > Tycho-based modules do not build with 3.6.1 (works with 3.6.0) > -- > > Key: MNG-6642 > URL: https://issues.apache.org/jira/browse/MNG-6642 > Project: Maven > Issue Type: Bug >Affects Versions: 3.6.1 >Reporter: Francesco Chicchiriccò >Priority: Major > > Build does not work with Maven 3.6.1 (works fine with Maven 3.6.0). > How to reproduce: > # git clone https://github.com/apache/syncope.git > # git checkout 2_1_X > # $M2_HOME/bin/mvn clean > When {{M2_HOME}} points to 3.6.0, build goes fine. > When {{M2_HOME}} points to 3.6.1, the following output is reported: > {code} > [INFO] Scanning for projects... > [INFO] Computing target platform for MavenProject: > org.apache.syncope.ide.eclipse:org.apache.syncope.ide.eclipse.plugin:2.1.4-SNAPSHOT > @ > /home/ilgrosso/work/syncope/syncope/ide/eclipse/bundles/org.apache.syncope.ide.eclipse.plugin/pom.xml > [INFO] Resolving dependencies of MavenProject: > org.apache.syncope.ide.eclipse:org.apache.syncope.ide.eclipse.plugin:2.1.4-SNAPSHOT > @ > /home/ilgrosso/work/syncope/syncope/ide/eclipse/bundles/org.apache.syncope.ide.eclipse.plugin/pom.xml > [INFO] {osgi.os=linux, osgi.ws=gtk, org.eclipse.update.install.features=true, > osgi.arch=x86} > [ERROR] Cannot resolve project dependencies: > [ERROR] Software being installed: org.apache.syncope.ide.eclipse.plugin > 2.1.4.qualifier > [ERROR] Missing requirement: org.apache.syncope.ide.eclipse.plugin > 2.1.4.qualifier requires 'osgi.bundle; org.eclipse.ui 0.0.0' but it could not > be found > [ERROR] > [ERROR] See > http://wiki.eclipse.org/Tycho/Dependency_Resolution_Troubleshooting for help. > [ERROR] Cannot resolve dependencies of MavenProject: > org.apache.syncope.ide.eclipse:org.apache.syncope.ide.eclipse.plugin:2.1.4-SNAPSHOT > @ > /home/ilgrosso/work/syncope/syncope/ide/eclipse/bundles/org.apache.syncope.ide.eclipse.plugin/pom.xml: > See log for details -> [Help 1] > [ERROR] > [ERROR] To see the full stack trace of the errors, re-run Maven with the -e > switch. > [ERROR] Re-run Maven using the -X switch to enable full debug logging. > [ERROR] > [ERROR] For more information about the errors and possible solutions, please > read the following articles: > [ERROR] [Help 1] > http://cwiki.apache.org/confluence/display/MAVEN/MavenExecutionException > {code} -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (SCM-914) InfoItem.lastChangedDate is leaky abstraction
Tobias Gruetzmacher created SCM-914: --- Summary: InfoItem.lastChangedDate is leaky abstraction Key: SCM-914 URL: https://issues.apache.org/jira/browse/SCM-914 Project: Maven SCM Issue Type: Bug Components: maven-scm-api Reporter: Tobias Gruetzmacher I was looking into implementing [https://github.com/mojohaus/buildnumber-maven-plugin/pull/16] in a sane way, but had to conclude that InfoItem.lastChangedDate is unfortunately just a string and not a Data, so will leak the console output of different providers to the user. Does anybody see a sane way to fix this API and create a sane abstraction for different SCMs? If yes, I would try to go ahead with the following tasks: # Fix InfoItem, so that lastChangedDate is a Date # Fix the current providers filling this field (svnexe and svnjava AFAICS - aside: why is svnjava not part of the maven-scm repository?) # Implement this feature for at least gitexe (and maybe jgit) so I can use it for my usecase Ideas, comments? -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (MENFORCER-306) [REGRESSION] RequirePluginVersions fails
[ https://issues.apache.org/jira/browse/MENFORCER-306?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16517871#comment-16517871 ] Tobias Gruetzmacher commented on MENFORCER-306: --- [~mbenson] Correct, that is the normal use case: You want to define all plugin versions in your pom (or any parent), so that plugin versions aren't dependent on the super pom, which might define different plugin versions when using different maven versions. btw: The super pom is here: [https://gitbox.apache.org/repos/asf?p=maven.git;a=blob;f=maven-core/src/main/resources/META-INF/plexus/default-bindings.xml;hb=HEAD] I attached a repoducer zip: Fails: {code:java} mvn verify{code} Still works: {code:java} mvn verify -Denforcer.version=3.0.0-M1{code} It seems org.apache.maven.plugins.enforcer.RequirePluginVersions.getAllPluginEntries(MavenProject) doesn't collect all plugins anymore... > [REGRESSION] RequirePluginVersions fails > > > Key: MENFORCER-306 > URL: https://issues.apache.org/jira/browse/MENFORCER-306 > Project: Maven Enforcer Plugin > Issue Type: Bug >Affects Versions: 3.0.0-M2 >Reporter: Karl Heinz Marbaise >Assignee: Karl Heinz Marbaise >Priority: Critical > Fix For: 3.0.0 > > Attachments: MENFORCER-306.zip, pom.xml > > > I have found that running the {{RequirePluginVersions}} rule on a project > with version {{3.0.0-M1}} works fine whereas it fails with version > {{3.0.0-M2}}. > {code} > [DEBUG] Executing rule: > org.apache.maven.plugins.enforcer.RequirePluginVersions > [DEBUG] RequirePluginVersions.getAllPlugins: > [DEBUG] lifecycleMapping = clean > [DEBUG] plugins = org.apache.maven.plugins:maven-clean-plugin:2.5:clean > [DEBUG] plugin = org.apache.maven.plugins:maven-clean-plugin:2.5:clean > [DEBUG] GAV = [org.apache.maven.plugins, maven-clean-plugin, 2.5, clean] > [DEBUG] RequirePluginVersions.getAllPlugins: > [DEBUG] lifecycleMapping = install > [DEBUG] plugins = org.apache.maven.plugins:maven-install-plugin:2.4:install > [DEBUG] plugin = org.apache.maven.plugins:maven-install-plugin:2.4:install > [DEBUG] GAV = [org.apache.maven.plugins, maven-install-plugin, 2.4, > install] > [DEBUG] lifecycleMapping = deploy > [DEBUG] plugins = org.apache.maven.plugins:maven-deploy-plugin:2.7:deploy > [DEBUG] plugin = org.apache.maven.plugins:maven-deploy-plugin:2.7:deploy > [DEBUG] GAV = [org.apache.maven.plugins, maven-deploy-plugin, 2.7, deploy] > [DEBUG] RequirePluginVersions.getAllPlugins: > [DEBUG] lifecycleMapping = site > [DEBUG] plugins = org.apache.maven.plugins:maven-site-plugin:3.3:site > [DEBUG] plugin = org.apache.maven.plugins:maven-site-plugin:3.3:site > [DEBUG] GAV = [org.apache.maven.plugins, maven-site-plugin, 3.3, site] > [DEBUG] lifecycleMapping = site-deploy > [DEBUG] plugins = org.apache.maven.plugins:maven-site-plugin:3.3:deploy > [DEBUG] plugin = org.apache.maven.plugins:maven-site-plugin:3.3:deploy > [DEBUG] GAV = [org.apache.maven.plugins, maven-site-plugin, 3.3, deploy] > [DEBUG] All Plugins in use: [Plugin [org.tinyjee.dim:doxia-include-macro], > Plugin [org.apache.maven.plugins:maven-clean-plugin], Plugin > [org.apache.maven.plugins:maven-install-plugin], Plugin > [org.apache.maven.plugins:maven-site-plugin], Plugin > [org.apache.maven.plugins:maven-deploy-plugin], Plugin > [org.jacoco:jacoco-maven-plugin], Plugin > [org.apache.maven.plugins:maven-enforcer-plugin]] > [DEBUG] plugin org.tinyjee.dim:doxia-include-macro not found > [DEBUG] plugin org.apache.maven.plugins:maven-clean-plugin not found > [DEBUG] plugin org.apache.maven.plugins:maven-install-plugin not found > [DEBUG] plugin org.apache.maven.plugins:maven-site-plugin not found > [DEBUG] plugin org.apache.maven.plugins:maven-deploy-plugin not found > [DEBUG] plugin org.jacoco:jacoco-maven-plugin not found > [DEBUG] Adding failure due to exception > org.apache.maven.enforcer.rule.api.EnforcerRuleException: Some plugins are > missing valid versions:(LATEST RELEASE SNAPSHOT are not allowed ) > org.tinyjee.dim:doxia-include-macro. The version currently in use is 1.1 > org.apache.maven.plugins:maven-clean-plugin. The version currently in use is > 3.0.0 > org.apache.maven.plugins:maven-install-plugin.The version currently > in use is 2.5.2 > org.apache.maven.plugins:maven-site-plugin. The version currently in use is > 3.6 > org.apache.maven.plugins:maven-deploy-plugin. The version currently > in use is 2.8.2 > org.jacoco:jacoco-maven-plugin. The version currently in use is 0.8.0 > Always define plugin versions! Never use LATEST or RELEASE. > at org.apache.maven.plugins.enforcer.RequirePluginVersions.execute > (RequirePluginVersions.java:320) > at org.apache.maven.plugins.enforcer.Enfor
[jira] [Updated] (MENFORCER-306) [REGRESSION] RequirePluginVersions fails
[ https://issues.apache.org/jira/browse/MENFORCER-306?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tobias Gruetzmacher updated MENFORCER-306: -- Attachment: MENFORCER-306.zip > [REGRESSION] RequirePluginVersions fails > > > Key: MENFORCER-306 > URL: https://issues.apache.org/jira/browse/MENFORCER-306 > Project: Maven Enforcer Plugin > Issue Type: Bug >Affects Versions: 3.0.0-M2 >Reporter: Karl Heinz Marbaise >Assignee: Karl Heinz Marbaise >Priority: Critical > Fix For: 3.0.0 > > Attachments: MENFORCER-306.zip, pom.xml > > > I have found that running the {{RequirePluginVersions}} rule on a project > with version {{3.0.0-M1}} works fine whereas it fails with version > {{3.0.0-M2}}. > {code} > [DEBUG] Executing rule: > org.apache.maven.plugins.enforcer.RequirePluginVersions > [DEBUG] RequirePluginVersions.getAllPlugins: > [DEBUG] lifecycleMapping = clean > [DEBUG] plugins = org.apache.maven.plugins:maven-clean-plugin:2.5:clean > [DEBUG] plugin = org.apache.maven.plugins:maven-clean-plugin:2.5:clean > [DEBUG] GAV = [org.apache.maven.plugins, maven-clean-plugin, 2.5, clean] > [DEBUG] RequirePluginVersions.getAllPlugins: > [DEBUG] lifecycleMapping = install > [DEBUG] plugins = org.apache.maven.plugins:maven-install-plugin:2.4:install > [DEBUG] plugin = org.apache.maven.plugins:maven-install-plugin:2.4:install > [DEBUG] GAV = [org.apache.maven.plugins, maven-install-plugin, 2.4, > install] > [DEBUG] lifecycleMapping = deploy > [DEBUG] plugins = org.apache.maven.plugins:maven-deploy-plugin:2.7:deploy > [DEBUG] plugin = org.apache.maven.plugins:maven-deploy-plugin:2.7:deploy > [DEBUG] GAV = [org.apache.maven.plugins, maven-deploy-plugin, 2.7, deploy] > [DEBUG] RequirePluginVersions.getAllPlugins: > [DEBUG] lifecycleMapping = site > [DEBUG] plugins = org.apache.maven.plugins:maven-site-plugin:3.3:site > [DEBUG] plugin = org.apache.maven.plugins:maven-site-plugin:3.3:site > [DEBUG] GAV = [org.apache.maven.plugins, maven-site-plugin, 3.3, site] > [DEBUG] lifecycleMapping = site-deploy > [DEBUG] plugins = org.apache.maven.plugins:maven-site-plugin:3.3:deploy > [DEBUG] plugin = org.apache.maven.plugins:maven-site-plugin:3.3:deploy > [DEBUG] GAV = [org.apache.maven.plugins, maven-site-plugin, 3.3, deploy] > [DEBUG] All Plugins in use: [Plugin [org.tinyjee.dim:doxia-include-macro], > Plugin [org.apache.maven.plugins:maven-clean-plugin], Plugin > [org.apache.maven.plugins:maven-install-plugin], Plugin > [org.apache.maven.plugins:maven-site-plugin], Plugin > [org.apache.maven.plugins:maven-deploy-plugin], Plugin > [org.jacoco:jacoco-maven-plugin], Plugin > [org.apache.maven.plugins:maven-enforcer-plugin]] > [DEBUG] plugin org.tinyjee.dim:doxia-include-macro not found > [DEBUG] plugin org.apache.maven.plugins:maven-clean-plugin not found > [DEBUG] plugin org.apache.maven.plugins:maven-install-plugin not found > [DEBUG] plugin org.apache.maven.plugins:maven-site-plugin not found > [DEBUG] plugin org.apache.maven.plugins:maven-deploy-plugin not found > [DEBUG] plugin org.jacoco:jacoco-maven-plugin not found > [DEBUG] Adding failure due to exception > org.apache.maven.enforcer.rule.api.EnforcerRuleException: Some plugins are > missing valid versions:(LATEST RELEASE SNAPSHOT are not allowed ) > org.tinyjee.dim:doxia-include-macro. The version currently in use is 1.1 > org.apache.maven.plugins:maven-clean-plugin. The version currently in use is > 3.0.0 > org.apache.maven.plugins:maven-install-plugin.The version currently > in use is 2.5.2 > org.apache.maven.plugins:maven-site-plugin. The version currently in use is > 3.6 > org.apache.maven.plugins:maven-deploy-plugin. The version currently > in use is 2.8.2 > org.jacoco:jacoco-maven-plugin. The version currently in use is 0.8.0 > Always define plugin versions! Never use LATEST or RELEASE. > at org.apache.maven.plugins.enforcer.RequirePluginVersions.execute > (RequirePluginVersions.java:320) > at org.apache.maven.plugins.enforcer.EnforceMojo.execute > (EnforceMojo.java:194) > at org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo > (DefaultBuildPluginManager.java:137) > {code} -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (MENFORCER-306) [REGRESSION] RequirePluginVersions fails
[ https://issues.apache.org/jira/browse/MENFORCER-306?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16517218#comment-16517218 ] Tobias Gruetzmacher commented on MENFORCER-306: --- Well, that pom.xml doesn't contain any versions for those plugins, so this fails even with enforcer 1.4.1. Did you reduce your minimal test case too much, because I'm currently tracking down a similar issue... Expanding the example pom.xml with versions for all those dependencies and THEN using it as a parent, breaks with M2 but works with M1... > [REGRESSION] RequirePluginVersions fails > > > Key: MENFORCER-306 > URL: https://issues.apache.org/jira/browse/MENFORCER-306 > Project: Maven Enforcer Plugin > Issue Type: Bug >Affects Versions: 3.0.0-M2 >Reporter: Karl Heinz Marbaise >Assignee: Karl Heinz Marbaise >Priority: Critical > Fix For: 3.0.0 > > Attachments: pom.xml > > > I have found that running the {{RequirePluginVersions}} rule on a project > with version {{3.0.0-M1}} works fine whereas it fails with version > {{3.0.0-M2}}. > {code} > [DEBUG] Executing rule: > org.apache.maven.plugins.enforcer.RequirePluginVersions > [DEBUG] RequirePluginVersions.getAllPlugins: > [DEBUG] lifecycleMapping = clean > [DEBUG] plugins = org.apache.maven.plugins:maven-clean-plugin:2.5:clean > [DEBUG] plugin = org.apache.maven.plugins:maven-clean-plugin:2.5:clean > [DEBUG] GAV = [org.apache.maven.plugins, maven-clean-plugin, 2.5, clean] > [DEBUG] RequirePluginVersions.getAllPlugins: > [DEBUG] lifecycleMapping = install > [DEBUG] plugins = org.apache.maven.plugins:maven-install-plugin:2.4:install > [DEBUG] plugin = org.apache.maven.plugins:maven-install-plugin:2.4:install > [DEBUG] GAV = [org.apache.maven.plugins, maven-install-plugin, 2.4, > install] > [DEBUG] lifecycleMapping = deploy > [DEBUG] plugins = org.apache.maven.plugins:maven-deploy-plugin:2.7:deploy > [DEBUG] plugin = org.apache.maven.plugins:maven-deploy-plugin:2.7:deploy > [DEBUG] GAV = [org.apache.maven.plugins, maven-deploy-plugin, 2.7, deploy] > [DEBUG] RequirePluginVersions.getAllPlugins: > [DEBUG] lifecycleMapping = site > [DEBUG] plugins = org.apache.maven.plugins:maven-site-plugin:3.3:site > [DEBUG] plugin = org.apache.maven.plugins:maven-site-plugin:3.3:site > [DEBUG] GAV = [org.apache.maven.plugins, maven-site-plugin, 3.3, site] > [DEBUG] lifecycleMapping = site-deploy > [DEBUG] plugins = org.apache.maven.plugins:maven-site-plugin:3.3:deploy > [DEBUG] plugin = org.apache.maven.plugins:maven-site-plugin:3.3:deploy > [DEBUG] GAV = [org.apache.maven.plugins, maven-site-plugin, 3.3, deploy] > [DEBUG] All Plugins in use: [Plugin [org.tinyjee.dim:doxia-include-macro], > Plugin [org.apache.maven.plugins:maven-clean-plugin], Plugin > [org.apache.maven.plugins:maven-install-plugin], Plugin > [org.apache.maven.plugins:maven-site-plugin], Plugin > [org.apache.maven.plugins:maven-deploy-plugin], Plugin > [org.jacoco:jacoco-maven-plugin], Plugin > [org.apache.maven.plugins:maven-enforcer-plugin]] > [DEBUG] plugin org.tinyjee.dim:doxia-include-macro not found > [DEBUG] plugin org.apache.maven.plugins:maven-clean-plugin not found > [DEBUG] plugin org.apache.maven.plugins:maven-install-plugin not found > [DEBUG] plugin org.apache.maven.plugins:maven-site-plugin not found > [DEBUG] plugin org.apache.maven.plugins:maven-deploy-plugin not found > [DEBUG] plugin org.jacoco:jacoco-maven-plugin not found > [DEBUG] Adding failure due to exception > org.apache.maven.enforcer.rule.api.EnforcerRuleException: Some plugins are > missing valid versions:(LATEST RELEASE SNAPSHOT are not allowed ) > org.tinyjee.dim:doxia-include-macro. The version currently in use is 1.1 > org.apache.maven.plugins:maven-clean-plugin. The version currently in use is > 3.0.0 > org.apache.maven.plugins:maven-install-plugin.The version currently > in use is 2.5.2 > org.apache.maven.plugins:maven-site-plugin. The version currently in use is > 3.6 > org.apache.maven.plugins:maven-deploy-plugin. The version currently > in use is 2.8.2 > org.jacoco:jacoco-maven-plugin. The version currently in use is 0.8.0 > Always define plugin versions! Never use LATEST or RELEASE. > at org.apache.maven.plugins.enforcer.RequirePluginVersions.execute > (RequirePluginVersions.java:320) > at org.apache.maven.plugins.enforcer.EnforceMojo.execute > (EnforceMojo.java:194) > at org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo > (DefaultBuildPluginManager.java:137) > {code} -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (SCM-834) Git Commit encoding is platform-dependend instead of UTF-8
Tobias Gruetzmacher created SCM-834: --- Summary: Git Commit encoding is platform-dependend instead of UTF-8 Key: SCM-834 URL: https://issues.apache.org/jira/browse/SCM-834 Project: Maven SCM Issue Type: Bug Components: maven-scm-provider-gitexe Affects Versions: 1.9.4 Reporter: Tobias Gruetzmacher When doing a release with the maven-release-plugin, if you have a non-ASCII-character in your commit message (setting scmCommentPrefix to "lösung" for example), the resulting commit message has a different encoding on different operating systems. If it isn't UTF-8 (on Windows, for example), git complains with {code} Warning: commit message did not conform to UTF-8. You may want to amend it after fixing the message, or set the config variable i18n.commitencoding to the encoding your project uses. {code} AFAICS, the fix is pretty simple: Just add "UTF-8" to the call of fileWrite in [GitCheckInCommand.java|https://github.com/apache/maven-scm/blob/master/maven-scm-providers/maven-scm-providers-git/maven-scm-provider-gitexe/src/main/java/org/apache/maven/scm/provider/git/gitexe/command/checkin/GitCheckInCommand.java#L74] -- This message was sent by Atlassian JIRA (v6.3.4#6332)