[GitHub] [maven] cstamas commented on pull request #883: [MNG-6609] Profile activation based on packaging

2023-02-06 Thread via GitHub


cstamas commented on PR #883:
URL: https://github.com/apache/maven/pull/883#issuecomment-1419071474

   @delanym you mean the original issue? (as this PR was "just" a fire 
extinguish/fix for original one). Seems we missed it, @kwin ? Created 
https://issues.apache.org/jira/browse/MSITE-923


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [maven] cstamas commented on pull request #883: [MNG-6609] Profile activation based on packaging

2022-12-01 Thread GitBox


cstamas commented on PR #883:
URL: https://github.com/apache/maven/pull/883#issuecomment-1333554347

   IT fixed 
https://github.com/apache/maven-integration-testing/pull/214#pullrequestreview-1200730814
   
   So am to merge this PR.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [maven] cstamas commented on pull request #883: [MNG-6609] Profile activation based on packaging

2022-11-30 Thread GitBox


cstamas commented on PR #883:
URL: https://github.com/apache/maven/pull/883#issuecomment-1331930222

   @kwin so does the new IT work? you mentioned something it does not fail with 
your commit?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [maven] cstamas commented on pull request #883: [MNG-6609] Profile activation based on packaging

2022-11-28 Thread GitBox


cstamas commented on PR #883:
URL: https://github.com/apache/maven/pull/883#issuecomment-1329563048

   Jut wanted to quickly "publish" my findings about the cause, but around same 
time moved to something else :smile: feel free to reuse (no need to keep my 
user ID, after all this is your change set with my one line removal). Or, I can 
pick it up later.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org