[GitHub] [maven] gnodet commented on pull request #402: DefaultProjectBuilder enhancements
gnodet commented on pull request #402: URL: https://github.com/apache/maven/pull/402#issuecomment-778257427 > I just had another look at this. It looks to me that this commit has become too big. We should split it into 2 pieces: > > * rewriting JUnit tests using maven-test-support. > * Remove double cache, which would fix [MNG-7063](https://issues.apache.org/jira/browse/MNG-7063). Done. Fwiw, https://github.com/apache/maven/pull/432 is about the junit 5. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven] gnodet commented on pull request #402: DefaultProjectBuilder enhancements
gnodet commented on pull request #402: URL: https://github.com/apache/maven/pull/402#issuecomment-763061798 @rfscholte I've rebased and fix the integration tests. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven] gnodet commented on pull request #402: DefaultProjectBuilder enhancements
gnodet commented on pull request #402: URL: https://github.com/apache/maven/pull/402#issuecomment-761072579 I'll get back on this PR next week. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven] gnodet commented on pull request #402: DefaultProjectBuilder enhancements
gnodet commented on pull request #402: URL: https://github.com/apache/maven/pull/402#issuecomment-756604579 I'll investigate the integration test failures asap. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven] gnodet commented on pull request #402: DefaultProjectBuilder enhancements
gnodet commented on pull request #402: URL: https://github.com/apache/maven/pull/402#issuecomment-756594921 @rfscholte the commit I pointed you at and on which you (commented)[https://github.com/apache/maven/commit/aa285f20bc2c4aef9898e42e297dd43430ac2c11#r45727670] yesterday was outdated. I've rebased on top of the recent changes in master. The related commit is now https://github.com/apache/maven/pull/402/commits/22582b662401afbb1ee648b5d63be49a8076dbb0. The answer to the question should be in the commit comment: ``` The checks were previously done after the cache hit, but they are now a duplication of the checks performed in readParentLocally. Doing caching is useless as the first time, the version range will be resolved and stored in the Parent and caching happens during the call to readRawModel anyway. ``` This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven] gnodet commented on pull request #402: DefaultProjectBuilder enhancements
gnodet commented on pull request #402: URL: https://github.com/apache/maven/pull/402#issuecomment-756049064 @rfscholte could you have a quick look and see if that's something that could be merged at some point ? I don't want to waste time if there's no interest at all. The 2 big and non trivial commits are 331e402 and aa285f2. I'm willing to rebase if there's a chance it could be included. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven] gnodet commented on pull request #402: DefaultProjectBuilder enhancements
gnodet commented on pull request #402: URL: https://github.com/apache/maven/pull/402#issuecomment-735127371 On top of that, I'm going to check if caching of *effective* models can be done. This requires tracking which properties / profiles are used, but it looks doable. It may not be very interesting for stock maven, but it would certainly be for `mvnd`. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
