[GitHub] [maven] hboutemy commented on pull request #1231: MNG-7875 colorize transfer messages

2023-09-11 Thread via GitHub


hboutemy commented on PR #1231:
URL: https://github.com/apache/maven/pull/1231#issuecomment-1714227158

   here it is:
   
![MNG-7875_colorized_output_second](https://github.com/apache/maven/assets/237462/9d74cd8e-66d5-4b48-839c-01f3d30a60bf)
   
   probably less surprising to end-users


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [maven] hboutemy commented on pull request #1231: MNG-7875 colorize transfer messages

2023-09-11 Thread via GitHub


hboutemy commented on PR #1231:
URL: https://github.com/apache/maven/pull/1231#issuecomment-1714078071

   dropped the layout-specific colorization as asked


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [maven] hboutemy commented on pull request #1231: MNG-7875 colorize transfer messages

2023-09-11 Thread via GitHub


hboutemy commented on PR #1231:
URL: https://github.com/apache/maven/pull/1231#issuecomment-1713435810

   if the goal is https://issues.apache.org/jira/browse/MNG-7875 (please take 
time to read it), it reaches its goal
   
   if there is another goal (and I understand there is), please open a Jira 
issue describing the goal: I don't get fully this other goal


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [maven] hboutemy commented on pull request #1231: MNG-7875 colorize transfer messages

2023-09-11 Thread via GitHub


hboutemy commented on PR #1231:
URL: https://github.com/apache/maven/pull/1231#issuecomment-1713261184

   disagree on everything: the PR does what the Jira title and description say 
= color to ease understanding
   which solve my improvement expectation
   
   your expectations are different, probably complementary, then to be done 
separately if you need it: going to slf4j will have other independent impact
   I'm not saying that your expectations are wrong: just saying that they are 
independent and should not be conflated (or even imposed on something 
independent)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [maven] hboutemy commented on pull request #1231: MNG-7875 colorize transfer messages

2023-09-10 Thread via GitHub


hboutemy commented on PR #1231:
URL: https://github.com/apache/maven/pull/1231#issuecomment-1712915939

   using slf4j vs console is completely orthogonal: it does not change anything 
to this issue. Don't hesitate to open a Jira and a PR in parallel
   
   on `Downloading org.apache.maven:foo:1.2.3 from apache-snapshots`:
   - we don't have gavce in the API: we can't do that
   - effective url base is useful (depends on user settings)
   - gavce can't display `maven-metadata.xml`
   
   >  it is already readable without anything else IMHO
   ask a normal user about the difference between "Downloading" and 
"Downloaded", ask about the url structure
   for you and every Maven developer, there is no problem (just hard to read 
output: you need to concentrate to see the different parts)
   
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org