[GitHub] [maven] kun-lu20 commented on pull request #1207: [MNG-7848] Add s390x pipeline to Jenkins CI
kun-lu20 commented on PR #1207: URL: https://github.com/apache/maven/pull/1207#issuecomment-1660336106 Hi @olamy @slachiewicz , Thanks for merging this PR. Yes, I think I know how to adjust it and I was working on that change (replacing `jenkinsNotify()` with another function which sends the notifications to our team). Since this PR has been merged, I will raise a new PR for it ASAP. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven] kun-lu20 commented on pull request #1207: [MNG-7848] Add s390x pipeline to Jenkins CI
kun-lu20 commented on PR #1207: URL: https://github.com/apache/maven/pull/1207#issuecomment-1655617325 Hi @olamy , Our team (Linux on IBM Z Open Source Team) will maintain/monitor the Jenkins job. Sure, I'll update the `Notifications` stage to send emails to us. I'll get back to you once the change is done. Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven] kun-lu20 commented on pull request #1207: [MNG-7848] Add s390x pipeline to Jenkins CI
kun-lu20 commented on PR #1207: URL: https://github.com/apache/maven/pull/1207#issuecomment-1653722464 Hi @slachiewicz , Could you please help to merge this PR and set up a nightly build s390x pipeline on Jenkins CI? Thank you so much! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven] kun-lu20 commented on pull request #1207: [MNG-7848] Add s390x pipeline to Jenkins CI
kun-lu20 commented on PR #1207: URL: https://github.com/apache/maven/pull/1207#issuecomment-1651732478 Hi @slachiewicz , Thanks for your feedback! I checked [amd64 Jenkinsfile](https://github.com/apache/maven/blob/master/Jenkinsfile) and it only uses Maven 3.8.x to build and test, the same as what we did in this PR for s390x Jenkinsfile: ```groovy def buildMvn = '3.8.x' ... def runITsMvn = '3.8.x' ``` Do you mean I should change the following line to maven-3.9.x only? ```groovy if (env.BRANCH_NAME in ['master', 'maven-3.8.x', 'maven-3.9.x']){ ``` Thank you very much! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven] kun-lu20 commented on pull request #1207: [MNG-7848] Add s390x pipeline to Jenkins CI
kun-lu20 commented on PR #1207: URL: https://github.com/apache/maven/pull/1207#issuecomment-1649778794 Hi @bmarwell , Thanks for your feedback! Yes, modifying the existing pipeline should be ok, but I think separating them also has some benefits: 1. We might not need to run the s390x pipeline as frequently as the amd64 pipeline, probably the nightly build is ok for s390x, like the s390x pipeline in other Apache projects, such as https://github.com/apache/zookeeper/blob/master/Jenkinsfile-s390x and https://github.com/apache/camel/blob/main/Jenkinsfile.s390x . 2. For now we need to use a hard-coded mapped entry jdktool `ibm-semeru-8u362-b09` for JDK 8 on s390x, separating two pipelines will make the scripts clearer. Please let me know what you think. Thanks again! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven] kun-lu20 commented on pull request #1207: [MNG-7848] Add s390x pipeline to Jenkins CI
kun-lu20 commented on PR #1207: URL: https://github.com/apache/maven/pull/1207#issuecomment-1645651621 Hi @slawekjaranowski @cstamas @olamy , Could you please review this PR when you have a chance? Thank you very much! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org