[GitHub] [maven] michael-o commented on pull request #394: [MNG-7020] Remove Maven 2 WagonExcluder backward compat code

2022-01-08 Thread GitBox


michael-o commented on pull request #394:
URL: https://github.com/apache/maven/pull/394#issuecomment-1008158052


   @mthmulders I have rebased the branch, I guess the ITs should pass. Let's 
wait.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [maven] michael-o commented on pull request #394: [MNG-7020] Remove Maven 2 WagonExcluder backward compat code

2022-01-08 Thread GitBox


michael-o commented on pull request #394:
URL: https://github.com/apache/maven/pull/394#issuecomment-1008154902


   > 
   
   Let me check...


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [maven] michael-o commented on pull request #394: [MNG-7020] Remove Maven 2 WagonExcluder backward compat code

2022-01-06 Thread GitBox


michael-o commented on pull request #394:
URL: https://github.com/apache/maven/pull/394#issuecomment-1006638182


   @rfscholte Can you reassess please?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [maven] michael-o commented on pull request #394: [MNG-7020] Remove Maven 2 WagonExcluder backward compat code

2021-10-04 Thread GitBox


michael-o commented on pull request #394:
URL: https://github.com/apache/maven/pull/394#issuecomment-933261043


   > 
   > 
   > @cstamas @michael-o I thought we also worked on that "require 
maven-plugin-api version", but can't find the ticket. For me that must be 
implemented first before accepting this PR.
   
   That is true and that is why I have not yet merged it.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [maven] michael-o commented on pull request #394: [MNG-7020] Remove Maven 2 WagonExcluder backward compat code

2021-02-05 Thread GitBox


michael-o commented on pull request #394:
URL: https://github.com/apache/maven/pull/394#issuecomment-773440336







This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [maven] michael-o commented on pull request #394: [MNG-7020] Remove Maven 2 WagonExcluder backward compat code

2021-02-04 Thread GitBox


michael-o commented on pull request #394:
URL: https://github.com/apache/maven/pull/394#issuecomment-773560933


   Sure...



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [maven] michael-o commented on pull request #394: [MNG-7020] Remove Maven 2 WagonExcluder backward compat code

2021-02-04 Thread GitBox


michael-o commented on pull request #394:
URL: https://github.com/apache/maven/pull/394#issuecomment-773440336


   @rfscholte Since you approved this, can I go on and merge?



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org