[GitHub] [maven] michael-o commented on pull request #399: [MNG-7034] StackOverflowError thrown if a cycle exists in BOM imports

2020-12-13 Thread GitBox 


michael-o commented on pull request #399:
URL: https://github.com/apache/maven/pull/399#issuecomment-744010593


   This changes causes:
   ```
   [ERROR] Failures:
   [ERROR]   
MavenITmng3819PluginDepPlexusUtilsTest>AbstractMavenIntegrationTestCase.runTest:255->testitMNG3819:62
   [ERROR]   
MavenITmng3843PomInheritanceTest>AbstractMavenIntegrationTestCase.runTest:255->testitMNG3843:105
 expected:<[1]> but was:<[2]>
   [ERROR]   
MavenITmng4262MakeLikeReactorDottedPathTest>AbstractMavenIntegrationTestCase.runTest:255->testitMakeRoot:67
 Unwanted file was found: 
/var/osipovmi/Projekte/mit/core-it-suite/target/test-classes/mng-4262/parent/../sub-a/target/touch.txt
   [ERROR]   
MavenITmng5783PluginDependencyFiltering>AbstractMavenIntegrationTestCase.runTest:255->testSLF4j:36
 expected:<3> but was:<2>
   ```
   
   I haven't looked into yet, but that doesn't look good. Could also be fallout 
from crappy ITs.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [maven] michael-o commented on pull request #399: [MNG-7034] StackOverflowError thrown if a cycle exists in BOM imports

2020-12-11 Thread GitBox 


michael-o commented on pull request #399:
URL: https://github.com/apache/maven/pull/399#issuecomment-743280138


   You have proposed two different solutions in the JIRA issue. Which have you 
chosen? I am also a bit confused about the change. You pass a new parameter: 
`importIds`, but in that method it is not used. Can you please clarify?



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [maven] michael-o commented on pull request #399: [MNG-7034] StackOverflowError thrown if a cycle exists in BOM imports

2020-12-11 Thread GitBox 


michael-o commented on pull request #399:
URL: https://github.com/apache/maven/pull/399#issuecomment-743222592


   Damn, it's Friday already...will go though this night!



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [maven] michael-o commented on pull request #399: [MNG-7034] StackOverflowError thrown if a cycle exists in BOM imports

2020-12-08 Thread GitBox 


michael-o commented on pull request #399:
URL: https://github.com/apache/maven/pull/399#issuecomment-740864726


   @gnodet I would like to review. Can you  ping me on Friday by noon?



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org