[GitHub] [maven] michael-o commented on pull request #427: [MNG-6727] Changed expression check to project.version and project.parent.version

2022-01-06 Thread GitBox 


michael-o commented on pull request #427:
URL: https://github.com/apache/maven/pull/427#issuecomment-1006815704


   @jmax01 `${pom.parent.version}` also needs to be added. Also rebase and 
reconcile the conflict. Targetting for 3.8.5.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [maven] michael-o commented on pull request #427: [MNG-6727] Changed expression check to project.version and project.parent.version

2021-12-30 Thread GitBox 


michael-o commented on pull request #427:
URL: https://github.com/apache/maven/pull/427#issuecomment-1003094540


   Just tried `${pom.version}` with `help:evaluate`, this must be also tested.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [maven] michael-o commented on pull request #427: [MNG-6727] Changed expression check to project.version and project.parent.version

2021-12-28 Thread GitBox 


michael-o commented on pull request #427:
URL: https://github.com/apache/maven/pull/427#issuecomment-1001991812


   As far as I understand this PR it slightly relaxes the expression to a 
disallowed minimum. What about pom.version?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [maven] michael-o commented on pull request #427: [MNG-6727] Changed expression check to project.version and project.parent.version

2021-12-28 Thread GitBox 


michael-o commented on pull request #427:
URL: https://github.com/apache/maven/pull/427#issuecomment-1001990913


   Please rebase


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [maven] michael-o commented on pull request #427: [MNG-6727] Changed expression check to project.version and project.parent.version

2021-01-11 Thread GitBox 


michael-o commented on pull request #427:
URL: https://github.com/apache/maven/pull/427#issuecomment-758087966


   Since I don't know the implications of this I requested @rfscholte and 
@khmarbaise to review this.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [maven] michael-o commented on pull request #427: [MNG-6727] Changed expression check to project.version and project.parent.version

2021-01-07 Thread GitBox 


michael-o commented on pull request #427:
URL: https://github.com/apache/maven/pull/427#issuecomment-756197574


   > 
   > 
   > All (*-latestest, 11) ITS fail in the same spot unrelated to the patch.
   > 
   > It appears it can't find `java.util.Objects` which was added in `1.7`, 
this is very odd.
   > 
   > ```
   > 2021-01-06T20:54:59.0695722Z [ERROR] Failed to execute goal 
org.apache.maven.plugins:maven-compiler-plugin:3.8.1:compile (default-compile) 
on project build-plugin: Compilation failure
   > 2021-01-06T20:54:59.0710252Z [ERROR] 
/home/runner/work/maven/maven/maven-integration-testing/core-it-suite/target/test-classes/mng-6972-allow-access-to-graph-package/build-plugin/src/main/java/com/example/BuildExtensionUsingGraphPackage.java:[4,17]
 cannot find symbol
   > 2021-01-06T20:54:59.0714174Z [ERROR]   symbol:   class Objects
   > 2021-01-06T20:54:59.0716976Z [ERROR]   location: package java.util
   > 2021-01-06T20:54:59.0719183Z [ERROR] -> [Help 1]
   > 2021-01-06T20:54:59.0730372Z 
org.apache.maven.lifecycle.LifecycleExecutionException: Failed to execute goal 
org.apache.maven.plugins:maven-compiler-plugin:3.8.1:compile (default-compile) 
on project build-plugin: Compilation failure
   > 2021-01-06T20:54:59.0743693Z 
/home/runner/work/maven/maven/maven-integration-testing/core-it-suite/target/test-classes/mng-6972-allow-access-to-graph-package/build-plugin/src/main/java/com/example/BuildExtensionUsingGraphPackage.java:[4,17]
 cannot find symbol
   > 2021-01-06T20:54:59.0746982Z   symbol:   class Objects
   > 2021-01-06T20:54:59.0749402Z   location: package java.util
   > ```
   
   This has also been observed with other PRs as well. I'd see it as unrelated 
for now.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org