mthmulders opened a new pull request #378:
URL: https://github.com/apache/maven/pull/378


   The refactoring of MavenCli.populateRequest introduced a subtle bug. It 
would select ~/.m2/repository as the local repository instead of something that 
is configured in ~/.m2/settings.xml.
   
   See [MNG-6991](https://issues.apache.org/jira/browse/MNG-6991) and [this 
Slack 
discussion](https://the-asf.slack.com/archives/C7Q9JB404/p1601016907001000) for 
additional details.
   
    - [X] Make sure there is a [JIRA 
issue](https://issues.apache.org/jira/browse/MNG) filed for the change (usually 
before you start working on it).
    - [X] Each commit in the pull request should have a meaningful subject line 
and body.
    - [X] Format the pull request title like `[MNG-XXX] - Fixes bug in 
ApproximateQuantiles`, where you replace `MNG-XXX` with the appropriate JIRA 
issue. Best practice is to use the JIRA issue title in the pull request title 
and in the first line of the commit message.
    - [X] Write a pull request description that is detailed enough to 
understand what the pull request does, how, and why.
    - [X] Run `mvn clean verify` to make sure basic checks pass. A more 
thorough check will 
          be performed on your pull request automatically.
    - [X] You have run the [Core IT][core-its] successfully.
   
    - [X] In any other case, please file an [Apache Individual Contributor 
License Agreement](https://www.apache.org/licenses/icla.pdf).
   
   [core-its]: https://maven.apache.org/core-its/core-it-suite/
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to