[GitHub] [maven] nielsbasjes commented on pull request #840: [MNG-7038] Introducing project.topdir
nielsbasjes commented on PR #840: URL: https://github.com/apache/maven/pull/840#issuecomment-1288093272 A practical example is in this project https://github.com/nielsbasjes/yauaa I wanted to have a single set of project specific checkstyle config. I ended up with packaging these files in a jar and making that a dependency of the checkstyle plugin. The only reason is not having a stable topdir which I could refer to. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven] nielsbasjes commented on pull request #840: [MNG-7038] Introducing project.topdir
nielsbasjes commented on PR #840: URL: https://github.com/apache/maven/pull/840#issuecomment-1288068788 @gnodet My first class of usecases is a consistent location for project level settings ( https://issues.apache.org/jira/browse/MNG-5659 ) which will solve a lot of practical problems for many of the projects where I work. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven] nielsbasjes commented on pull request #840: [MNG-7038] Introducing project.topdir
nielsbasjes commented on PR #840:
URL: https://github.com/apache/maven/pull/840#issuecomment-1288068151
Cases to think about I just thought of:
Context: Multi module project, all `parent modules` have pointers towards
their `child modules`.
- A child module points to the correct parent (within the project).
- A child module points to a different parent within the project.
- A child module points to a parent outside the project.
- A child module has no parent.
One of the child mentioned edge cases has settings IN the child module (i.e.
`${project.topdir}/mvn/settings.xml` is not really the top of the entire
project).
In this example the build of such a module will yield different results if
built from the real top v.s. build from within the module itself.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [maven] nielsbasjes commented on pull request #840: [MNG-7038] Introducing project.topdir
nielsbasjes commented on PR #840: URL: https://github.com/apache/maven/pull/840#issuecomment-1287770947 I think I ran into a chicken-egg type of problem. - I would like to have the project.topdir available as a variable that can be used in the pom.xml to pin point things. This implies it must be available before that point. - Yet the only viable way to determine it is after the pom.xml has been parsed and at least the parents are available. I would like to have some suggestions on how to handle this is. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven] nielsbasjes commented on pull request #840: [MNG-7038] Introducing project.topdir
nielsbasjes commented on PR #840: URL: https://github.com/apache/maven/pull/840#issuecomment-1286625160 This also means the (internal) `maven.multiModuleProjectDirectory` suffers from the same problem: It may traverse outside of the project root. This will also cause problems if people checkout a different project in a subdirectory of their current project. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven] nielsbasjes commented on pull request #840: [MNG-7038] Introducing project.topdir
nielsbasjes commented on PR #840:
URL: https://github.com/apache/maven/pull/840#issuecomment-1286619888
@kwin You are right.
That is probably a lot better, also because this code in init will travel
outside of the project and even the homedirectory of the user to find the
`.mvn` directory.
however...
The problem I see is that for some things, like reading the
`${project.topdir}/.mvn/settings.xml` (See
[MNG-5659](https://issues.apache.org/jira/browse/MNG-5659)) you'll need to have
that available before the pom.xml files are read.
This needs more investigation on how to implement!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [maven] nielsbasjes commented on pull request #840: [MNG-7038] Introducing project.topdir
nielsbasjes commented on PR #840: URL: https://github.com/apache/maven/pull/840#issuecomment-1286589500 Sidenote: I found in the [init](https://github.com/apache/maven/blob/18eff3baeb899ddd27b34635c8f0d7e47f5c027b/apache-maven/src/assembly/shared/init#L33) script there is something called `basedir` that seems to be very similar to this `project.topdir` (it is different if you have a .mvn somewhere half way your project tree) yet it is very different from `project.basedir`. Confusing! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
