[GitHub] [maven] oehme edited a comment on issue #242: Speed up project discovery
oehme edited a comment on issue #242: Speed up project discovery URL: https://github.com/apache/maven/pull/242#issuecomment-486396545 @hboutemy Only one integration test still fails locally for me (an `master` too), the `mng6386BaseUriProperty(itMNG6386UnicodeChars)` case. I'll see if I can find out why, it's not a big deal for me though. Thanks for approving the changes. I was wondering one thing: Is using Guava allowed in the core module? It's already a transitive dependency of Maven and it could simplify some of the code I wrote for this PR. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [maven] oehme edited a comment on issue #242: Speed up project discovery
oehme edited a comment on issue #242: Speed up project discovery URL: https://github.com/apache/maven/pull/242#issuecomment-481618896 Project discovery on the project took ~5min before, now down to ~2.5min. Still a long way to go, but a good improvement :) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [maven] oehme edited a comment on issue #242: Speed up project discovery
oehme edited a comment on issue #242: Speed up project discovery URL: https://github.com/apache/maven/pull/242#issuecomment-482035989 I've created the issues and addressed your comments above, please have another look. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [maven] oehme edited a comment on issue #242: Speed up project discovery
oehme edited a comment on issue #242: Speed up project discovery URL: https://github.com/apache/maven/pull/242#issuecomment-481630398 ~The last commit seems to be problematic, some core-its around ArtifactHandler are failing. I'm not yet sure I understand why - Can the artifact handler for a given type change over time? I thought the idea is to only add additional handlers for new types?~ Nevermind, I got it - We can't remember the `DefaultArtifactHandler` created for unknown types, as that might later be replaced with a better handler by an extension. All integration tests are passing now. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [maven] oehme edited a comment on issue #242: Speed up project discovery
oehme edited a comment on issue #242: Speed up project discovery URL: https://github.com/apache/maven/pull/242#issuecomment-481630398 ~The last commit seems to be problematic, some core-its around ArtifactHandler are failing. I'm not yet sure I understand why - Can the artifact handler for a given type change over time? I thought the idea is to only add additional handlers for new types?~~ Nevermind, I got it - We can't remember the `DefaultArtifactHandler` created for unknown types, as that might later be replaced with a better handler by an extension. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [maven] oehme edited a comment on issue #242: Speed up project discovery
oehme edited a comment on issue #242: Speed up project discovery URL: https://github.com/apache/maven/pull/242#issuecomment-481630398 ~The last commit seems to be problematic, some core-its around ArtifactHandler are failing. I'm not yet sure I understand why - Can the artifact handler for a given type change over time? I thought the idea is to only add additional handlers for new types?~ Nevermind, I got it - We can't remember the `DefaultArtifactHandler` created for unknown types, as that might later be replaced with a better handler by an extension. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
