[GitHub] [maven] pzygielo commented on a change in pull request #646: [MNG-7377] - ignore .vscode directories
pzygielo commented on a change in pull request #646: URL: https://github.com/apache/maven/pull/646#discussion_r776253734 ## File path: .gitignore ## @@ -15,3 +15,4 @@ out/ .java-version .checkstyle .factorypath +.vscode/ Review comment: This should go to global git config, not here. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven] pzygielo commented on a change in pull request #646: [MNG-7377] - ignore .vscode directories
pzygielo commented on a change in pull request #646: URL: https://github.com/apache/maven/pull/646#discussion_r776254142 ## File path: pom.xml ## @@ -579,6 +579,7 @@ under the License. src/main/appended-resources/licenses/MIT-slf4j-api-1.7.30.txt src/main/appended-resources/licenses/EPL-1.0.txt src/main/appended-resources/licenses/unrecognized-javax.annotation-api-1.3.2.txt + .vscode/** Review comment: This should be added to https://creadur.apache.org/rat/apache-rat-plugin/rat-mojo.html, like `useEclipseDefaultExcludes` and others. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven] pzygielo commented on a change in pull request #646: [MNG-7377] - ignore .vscode directories
pzygielo commented on a change in pull request #646: URL: https://github.com/apache/maven/pull/646#discussion_r776253734 ## File path: .gitignore ## @@ -15,3 +15,4 @@ out/ .java-version .checkstyle .factorypath +.vscode/ Review comment: This should go to global git config, not here. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
